{"action":"created","issue":{"url":"https://api.github.com/repos/kentcdodds/react-testing-library/issues/130","repository_url":"https://api.github.com/repos/kentcdodds/react-testing-library","labels_url":"https://api.github.com/repos/kentcdodds/react-testing-library/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/kentcdodds/react-testing-library/issues/130/comments","events_url":"https://api.github.com/repos/kentcdodds/react-testing-library/issues/130/events","html_url":"https://github.com/kentcdodds/react-testing-library/pull/130","id":337656754,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Nzg0OTY0","number":130,"title":"update typings with dom-testing-library queries and export them","user":{"login":"jpavon","id":1493505,"node_id":"MDQ6VXNlcjE0OTM1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1493505?v=4","gravatar_id":"","url":"https://api.github.com/users/jpavon","html_url":"https://github.com/jpavon","followers_url":"https://api.github.com/users/jpavon/followers","following_url":"https://api.github.com/users/jpavon/following{/other_user}","gists_url":"https://api.github.com/users/jpavon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpavon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpavon/subscriptions","organizations_url":"https://api.github.com/users/jpavon/orgs","repos_url":"https://api.github.com/users/jpavon/repos","events_url":"https://api.github.com/users/jpavon/events{/privacy}","received_events_url":"https://api.github.com/users/jpavon/received_events","type":"User","site_admin":false},"labels":[{"id":887582724,"node_id":"MDU6TGFiZWw4ODc1ODI3MjQ=","url":"https://api.github.com/repos/kentcdodds/react-testing-library/labels/TypeScript","name":"TypeScript","color":"007ACC","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-02T20:45:07Z","updated_at":"2018-07-02T22:41:46Z","closed_at":"2018-07-02T21:31:09Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kentcdodds/react-testing-library/pulls/130","html_url":"https://github.com/kentcdodds/react-testing-library/pull/130","diff_url":"https://github.com/kentcdodds/react-testing-library/pull/130.diff","patch_url":"https://github.com/kentcdodds/react-testing-library/pull/130.patch"},"body":"<!--\r\nThanks for your interest in the project. Bugs filed and PRs submitted are appreciated!\r\n\r\nPlease make sure that you are familiar with and follow the Code of Conduct for\r\nthis project (found in the CODE_OF_CONDUCT.md file).\r\n\r\nAlso, please make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nIf you're new to contributing to open source projects, you might find this free\r\nvideo course helpful: http://kcd.im/pull-request\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n\r\n**What**: Update queries typings to match dom-testing-library\r\n\r\n<!-- Why are these changes necessary? -->\r\n\r\n**Why**: Not up to date typings with dom-testing-library\r\n\r\n<!-- How were these changes implemented? -->\r\n\r\n**How**: Modify typings/index.d.ts.\r\n\r\n<!-- Have you done all of these things?  -->\r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n- [ ] Documentation\r\n- [x] Tests\r\n- [x] Ready to be merged\r\n      <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n- [x] Added myself to contributors table\r\n      <!-- this is optional, see the contributing guidelines for instructions -->\r\n\r\n<!-- feel free to add additional comments -->\r\n"},"comment":{"url":"https://api.github.com/repos/kentcdodds/react-testing-library/issues/comments/401959238","html_url":"https://github.com/kentcdodds/react-testing-library/pull/130#issuecomment-401959238","issue_url":"https://api.github.com/repos/kentcdodds/react-testing-library/issues/130","id":401959238,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTk1OTIzOA==","user":{"login":"jpavon","id":1493505,"node_id":"MDQ6VXNlcjE0OTM1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1493505?v=4","gravatar_id":"","url":"https://api.github.com/users/jpavon","html_url":"https://github.com/jpavon","followers_url":"https://api.github.com/users/jpavon/followers","following_url":"https://api.github.com/users/jpavon/following{/other_user}","gists_url":"https://api.github.com/users/jpavon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpavon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpavon/subscriptions","organizations_url":"https://api.github.com/users/jpavon/orgs","repos_url":"https://api.github.com/users/jpavon/repos","events_url":"https://api.github.com/users/jpavon/events{/privacy}","received_events_url":"https://api.github.com/users/jpavon/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T22:41:46Z","updated_at":"2018-07-02T22:41:46Z","author_association":"CONTRIBUTOR","body":"@pbomb @kentcdodds I'm thinking having `export * from 'dom-testing-library'` inside the `index.d.ts` makes more sense and would remove a lot of duplication, let me know what you think I can create a pr in the next days."}}
{"actor":{"display_login":"jpavon"}}