{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/quickstart-ios/pulls/comments/198918550","pull_request_review_id":132938583,"id":198918550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODkxODU1MA==","diff_hunk":"@@ -91,7 +93,23 @@ - (void)viewDidLoad {\n                             error:nil];\n     }] resume];\n \n-  [trace incrementMetric:@\"request_sent\" byInt:1];\n+    [trace incrementMetric:@\"request_sent\" byInt:1];\n+    \n+    if (@available(iOS 10, *)) {\n+      AVURLAsset *asset = [AVURLAsset assetWithURL:\n+        [NSURL URLWithString:@\"https://upload.wikimedia.org/wikipedia/commons/thumb/3/36/Two_red_dice_01.svg/220px-Two_red_dice_01.svg.png\"]];\n+    \n+      AVAssetDownloadURLSession *downloadSession =\n+        [AVAssetDownloadURLSession sessionWithConfiguration:\n+      [NSURLSessionConfiguration backgroundSessionConfigurationWithIdentifier:@\"avasset\"]\n+                                  assetDownloadDelegate:nil delegateQueue:[NSOperationQueue mainQueue]];\n+    \n+      AVAssetDownloadTask *task = [downloadSession assetDownloadTaskWithURLAsset:asset assetTitle:\n+                                 @\"something\" assetArtworkData:nil options:nil];\n+    \n+      [task resume];\n+      [trace incrementMetric:@\"av_request_sent\" byInt:1];","path":"performance/PerformanceExample/ViewController.m","position":29,"original_position":29,"commit_id":"160efc4a412f3dca3a5663d5443370d89ef1204d","original_commit_id":"160efc4a412f3dca3a5663d5443370d89ef1204d","user":{"login":"morganchen12","id":4529021,"node_id":"MDQ6VXNlcjQ1MjkwMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4529021?v=4","gravatar_id":"","url":"https://api.github.com/users/morganchen12","html_url":"https://github.com/morganchen12","followers_url":"https://api.github.com/users/morganchen12/followers","following_url":"https://api.github.com/users/morganchen12/following{/other_user}","gists_url":"https://api.github.com/users/morganchen12/gists{/gist_id}","starred_url":"https://api.github.com/users/morganchen12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morganchen12/subscriptions","organizations_url":"https://api.github.com/users/morganchen12/orgs","repos_url":"https://api.github.com/users/morganchen12/repos","events_url":"https://api.github.com/users/morganchen12/events{/privacy}","received_events_url":"https://api.github.com/users/morganchen12/received_events","type":"User","site_admin":false},"body":"The lines above this seem to all be indented by two extra spaces.","created_at":"2018-06-28T17:14:11Z","updated_at":"2018-06-28T17:14:25Z","html_url":"https://github.com/firebase/quickstart-ios/pull/483#discussion_r198918550","pull_request_url":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/firebase/quickstart-ios/pulls/comments/198918550"},"html":{"href":"https://github.com/firebase/quickstart-ios/pull/483#discussion_r198918550"},"pull_request":{"href":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483"}}},"pull_request":{"url":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483","id":197918540,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTE4NTQw","html_url":"https://github.com/firebase/quickstart-ios/pull/483","diff_url":"https://github.com/firebase/quickstart-ios/pull/483.diff","patch_url":"https://github.com/firebase/quickstart-ios/pull/483.patch","issue_url":"https://api.github.com/repos/firebase/quickstart-ios/issues/483","number":483,"state":"open","locked":false,"title":"added AVFoundation task","user":{"login":"Chava","id":579624,"node_id":"MDQ6VXNlcjU3OTYyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/579624?v=4","gravatar_id":"","url":"https://api.github.com/users/Chava","html_url":"https://github.com/Chava","followers_url":"https://api.github.com/users/Chava/followers","following_url":"https://api.github.com/users/Chava/following{/other_user}","gists_url":"https://api.github.com/users/Chava/gists{/gist_id}","starred_url":"https://api.github.com/users/Chava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chava/subscriptions","organizations_url":"https://api.github.com/users/Chava/orgs","repos_url":"https://api.github.com/users/Chava/repos","events_url":"https://api.github.com/users/Chava/events{/privacy}","received_events_url":"https://api.github.com/users/Chava/received_events","type":"User","site_admin":false},"body":"added an extra task derived from AVAssetDownloadURLSession","created_at":"2018-06-28T05:08:41Z","updated_at":"2018-06-28T17:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c814010f40702829a5d03af2683bc9cbd8baf244","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483/commits","review_comments_url":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483/comments","review_comment_url":"https://api.github.com/repos/firebase/quickstart-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/quickstart-ios/issues/483/comments","statuses_url":"https://api.github.com/repos/firebase/quickstart-ios/statuses/160efc4a412f3dca3a5663d5443370d89ef1204d","head":{"label":"Chava:master","ref":"master","sha":"160efc4a412f3dca3a5663d5443370d89ef1204d","user":{"login":"Chava","id":579624,"node_id":"MDQ6VXNlcjU3OTYyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/579624?v=4","gravatar_id":"","url":"https://api.github.com/users/Chava","html_url":"https://github.com/Chava","followers_url":"https://api.github.com/users/Chava/followers","following_url":"https://api.github.com/users/Chava/following{/other_user}","gists_url":"https://api.github.com/users/Chava/gists{/gist_id}","starred_url":"https://api.github.com/users/Chava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chava/subscriptions","organizations_url":"https://api.github.com/users/Chava/orgs","repos_url":"https://api.github.com/users/Chava/repos","events_url":"https://api.github.com/users/Chava/events{/privacy}","received_events_url":"https://api.github.com/users/Chava/received_events","type":"User","site_admin":false},"repo":{"id":137151219,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNTEyMTk=","name":"quickstart-ios","full_name":"Chava/quickstart-ios","owner":{"login":"Chava","id":579624,"node_id":"MDQ6VXNlcjU3OTYyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/579624?v=4","gravatar_id":"","url":"https://api.github.com/users/Chava","html_url":"https://github.com/Chava","followers_url":"https://api.github.com/users/Chava/followers","following_url":"https://api.github.com/users/Chava/following{/other_user}","gists_url":"https://api.github.com/users/Chava/gists{/gist_id}","starred_url":"https://api.github.com/users/Chava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chava/subscriptions","organizations_url":"https://api.github.com/users/Chava/orgs","repos_url":"https://api.github.com/users/Chava/repos","events_url":"https://api.github.com/users/Chava/events{/privacy}","received_events_url":"https://api.github.com/users/Chava/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chava/quickstart-ios","description":"Firebase Quickstart Samples for iOS","fork":true,"url":"https://api.github.com/repos/Chava/quickstart-ios","forks_url":"https://api.github.com/repos/Chava/quickstart-ios/forks","keys_url":"https://api.github.com/repos/Chava/quickstart-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chava/quickstart-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chava/quickstart-ios/teams","hooks_url":"https://api.github.com/repos/Chava/quickstart-ios/hooks","issue_events_url":"https://api.github.com/repos/Chava/quickstart-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Chava/quickstart-ios/events","assignees_url":"https://api.github.com/repos/Chava/quickstart-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Chava/quickstart-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Chava/quickstart-ios/tags","blobs_url":"https://api.github.com/repos/Chava/quickstart-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chava/quickstart-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chava/quickstart-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chava/quickstart-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chava/quickstart-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Chava/quickstart-ios/languages","stargazers_url":"https://api.github.com/repos/Chava/quickstart-ios/stargazers","contributors_url":"https://api.github.com/repos/Chava/quickstart-ios/contributors","subscribers_url":"https://api.github.com/repos/Chava/quickstart-ios/subscribers","subscription_url":"https://api.github.com/repos/Chava/quickstart-ios/subscription","commits_url":"https://api.github.com/repos/Chava/quickstart-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chava/quickstart-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chava/quickstart-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chava/quickstart-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chava/quickstart-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Chava/quickstart-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chava/quickstart-ios/merges","archive_url":"https://api.github.com/repos/Chava/quickstart-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chava/quickstart-ios/downloads","issues_url":"https://api.github.com/repos/Chava/quickstart-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Chava/quickstart-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Chava/quickstart-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Chava/quickstart-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chava/quickstart-ios/labels{/name}","releases_url":"https://api.github.com/repos/Chava/quickstart-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Chava/quickstart-ios/deployments","created_at":"2018-06-13T02:21:01Z","updated_at":"2018-06-28T04:41:54Z","pushed_at":"2018-06-28T04:41:52Z","git_url":"git://github.com/Chava/quickstart-ios.git","ssh_url":"git@github.com:Chava/quickstart-ios.git","clone_url":"https://github.com/Chava/quickstart-ios.git","svn_url":"https://github.com/Chava/quickstart-ios","homepage":"https://firebase.google.com","size":25680,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"51fd4097bec28ecd54599ec7f4fbed42b14f7c5e","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":57147359,"node_id":"MDEwOlJlcG9zaXRvcnk1NzE0NzM1OQ==","name":"quickstart-ios","full_name":"firebase/quickstart-ios","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/quickstart-ios","description":"Firebase Quickstart Samples for iOS","fork":false,"url":"https://api.github.com/repos/firebase/quickstart-ios","forks_url":"https://api.github.com/repos/firebase/quickstart-ios/forks","keys_url":"https://api.github.com/repos/firebase/quickstart-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/quickstart-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/quickstart-ios/teams","hooks_url":"https://api.github.com/repos/firebase/quickstart-ios/hooks","issue_events_url":"https://api.github.com/repos/firebase/quickstart-ios/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/quickstart-ios/events","assignees_url":"https://api.github.com/repos/firebase/quickstart-ios/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/quickstart-ios/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/quickstart-ios/tags","blobs_url":"https://api.github.com/repos/firebase/quickstart-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/quickstart-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/quickstart-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/quickstart-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/quickstart-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/quickstart-ios/languages","stargazers_url":"https://api.github.com/repos/firebase/quickstart-ios/stargazers","contributors_url":"https://api.github.com/repos/firebase/quickstart-ios/contributors","subscribers_url":"https://api.github.com/repos/firebase/quickstart-ios/subscribers","subscription_url":"https://api.github.com/repos/firebase/quickstart-ios/subscription","commits_url":"https://api.github.com/repos/firebase/quickstart-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/quickstart-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/quickstart-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/quickstart-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/quickstart-ios/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/quickstart-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/quickstart-ios/merges","archive_url":"https://api.github.com/repos/firebase/quickstart-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/quickstart-ios/downloads","issues_url":"https://api.github.com/repos/firebase/quickstart-ios/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/quickstart-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/quickstart-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/quickstart-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/quickstart-ios/labels{/name}","releases_url":"https://api.github.com/repos/firebase/quickstart-ios/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/quickstart-ios/deployments","created_at":"2016-04-26T17:13:37Z","updated_at":"2018-06-28T15:31:19Z","pushed_at":"2018-06-28T15:31:16Z","git_url":"git://github.com/firebase/quickstart-ios.git","ssh_url":"git@github.com:firebase/quickstart-ios.git","clone_url":"https://github.com/firebase/quickstart-ios.git","svn_url":"https://github.com/firebase/quickstart-ios","homepage":"https://firebase.google.com","size":25689,"stargazers_count":1153,"watchers_count":1153,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":739,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":739,"open_issues":5,"watchers":1153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483"},"html":{"href":"https://github.com/firebase/quickstart-ios/pull/483"},"issue":{"href":"https://api.github.com/repos/firebase/quickstart-ios/issues/483"},"comments":{"href":"https://api.github.com/repos/firebase/quickstart-ios/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/quickstart-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/quickstart-ios/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/quickstart-ios/statuses/160efc4a412f3dca3a5663d5443370d89ef1204d"}},"author_association":"NONE"}}
{"actor":{"display_login":"morganchen12"}}