{"push_id":2534300724,"size":16,"distinct_size":0,"ref":"refs/heads/master","head":"0d43bdec2b8598ff542a1afdee876d417b4e7668","before":"62b58e625ea5b32b2301a0c015edb1dfa07d61ea","commits":[{"sha":"e353f45b4f894d4b0e3a5889c4c569475c0acc26","author":{"name":"Ed Bartosh","email":"cf5683a160f96df0ae6420fb2eaa7c999477ee65@intel.com"},"message":"check for commands in kubelet command line\n\nKubelet doesn't support subcommands and silently ignores them.\nThis causes a lot of confusion among users, for example:\n  Running 'kubelet logs' can produce this output:\n    I0206 16:20:40.010949    5712 feature_gate.go:220] feature gates: &{{} map[]}\n    I0206 16:20:40.011054    5712 controller.go:114] kubelet config controller: starting controller\n    ...\n    error: failed to run Kubelet: failed to create kubelet:\n           misconfiguration: kubelet cgroup driver: \"cgroupfs\" is different from\n           docker cgroup driver: \"systemd\"\n\nThe output in this case looks like a valid log output. The error is not\ncaused by incorrectly configured cgroup driver though. It's caused by\nthe fact that kubelet ignores 'logs' subcommand, so 'kubelet logs' is\nessentially the same as 'kubelet': it runs kubelet with the default set\nof parameters, including default cgroup driver.\n\nAdded check to prevent kubelet from running if user specifies\nsubcommands in the command line.\n\nFixes: #639","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/e353f45b4f894d4b0e3a5889c4c569475c0acc26"},{"sha":"81bf821d691768bd028536450caba8f7bfc00d5c","author":{"name":"Fabio Bertinatto","email":"905206f9a551c436cd9dfe6312f8fe1386efbb4c@redhat.com"},"message":"Capitalize acronyms in AWS metrics-related code","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/81bf821d691768bd028536450caba8f7bfc00d5c"},{"sha":"5e24289f89bf5c973d7713254083a6194a447394","author":{"name":"Jordan Liggitt","email":"aa6ef2bbe17379c3e8e7883829f55c5a7ad052b1@redhat.com"},"message":"Add set image test for sparse API group resource","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/5e24289f89bf5c973d7713254083a6194a447394"},{"sha":"9a480667493f6275c22cc9cd0f69fb0c75ef3579","author":{"name":"David Eads","email":"89303f5b3c40c1b24f758e05b147c2160fb869de@redhat.com"},"message":"update restmapping to indicate fully qualified resource","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/9a480667493f6275c22cc9cd0f69fb0c75ef3579"},{"sha":"a30f4591609301bd6160abeb22731f70e7dae2e0","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63335 from deads2k/api-15-mappingtype\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nupdate restmapping to indicate fully qualified resource\n\nThe resource of a restmapping is logically fully qualified and we have that value when we construct it.  Update the return value so that callers don't have to synthentically create one.\r\n\r\n@kubernetes/sig-api-machinery-pr-reviews \r\n\r\n```release-note\r\nNONE\r\n```","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/a30f4591609301bd6160abeb22731f70e7dae2e0"},{"sha":"8f571a0e9d64050d7b300c01fa2ab68727564b84","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63308 from liggitt/cronjob-set-test\n\nAutomatic merge from submit-queue (batch tested with PRs 63335, 63308). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nAdd set image test for sparse API group resource\n\nEnsures set image works correctly on resources that do not exist in the preferred version of their API group\r\n\r\nTests scenario noticed in review of https://github.com/kubernetes/kubernetes/pull/63206#discussion_r185008596\r\n\r\n```release-note\r\nNONE\r\n```","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/8f571a0e9d64050d7b300c01fa2ab68727564b84"},{"sha":"5eefd7d012a560c67750a6a57320d7c5ee107f63","author":{"name":"Cao Shufeng","email":"085a1a83f4537cd8dd617d49c0bf6fc9e9199f94@cn.fujitsu.com"},"message":"not expose object detail when creating TokenRequest","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/5eefd7d012a560c67750a6a57320d7c5ee107f63"},{"sha":"aec3d55c324c6e1360c097aaa599fff0bf22df8b","author":{"name":"WanLinghao","email":"7c0edcb066d78e845f27e883eaa8e4af59f164ed@cn.fujitsu.com"},"message":"\tadd UT test to PolicyRuleBuilder in file\n\t./pkg/apis/rbac/helpers_test.go","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/aec3d55c324c6e1360c097aaa599fff0bf22df8b"},{"sha":"7d57060d9ebe82aa6e57f5195a03c6a16164daf9","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #61833 from bart0sh/PR0008-kubelet-unknown-command\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\ncheck for commands in kubelet command line\n\n**What this PR does / why we need it**:\r\n\r\nKubelet doesn't support subcommands and silently ignores them.\r\nThis causes a lot of confusion among users, for example:\r\n\r\n  Running 'kubelet logs' can produce this output:\r\n```\r\n    I0206 16:20:40.010949    5712 feature_gate.go:220] feature gates: &{{} map[]}\r\n    I0206 16:20:40.011054    5712 controller.go:114] kubelet config controller: starting controller\r\n    ...\r\n    error: failed to run Kubelet: failed to create kubelet:\r\n           misconfiguration: kubelet cgroup driver: \"cgroupfs\" is different from\r\n           docker cgroup driver: \"systemd\"\r\n```\r\n\r\nThe output in this case looks like a valid log output. The error is not\r\ncaused by incorrectly configured cgroup driver though. It's caused by\r\nthe fact that kubelet ignores 'logs' subcommand, so 'kubelet logs' is\r\nessentially the same as 'kubelet': it runs kubelet with the default set\r\nof parameters, including default cgroup driver.\r\n\r\n**The fix**:\r\nAdded check to prevent kubelet from running if user specifies\r\nsubcommands in the command line.\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes: kubeadm issue 639\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/7d57060d9ebe82aa6e57f5195a03c6a16164daf9"},{"sha":"ed9b25c90241b2b8a1fa10b96381c57f99ca952a","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #62062 from CaoShuFeng/TokenRequest-information\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nnot expose object detail when creating TokenRequest\n\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n/assign @liggitt @mikedanese \r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/ed9b25c90241b2b8a1fa10b96381c57f99ca952a"},{"sha":"5abe207eefb60a07e77d1e7e8d4afa897a1cd97a","author":{"name":"Fabio Bertinatto","email":"905206f9a551c436cd9dfe6312f8fe1386efbb4c@redhat.com"},"message":"Add metric for throttled requests in AWS","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/5abe207eefb60a07e77d1e7e8d4afa897a1cd97a"},{"sha":"96a0df641343829709a9f45cd715add9f3a83e47","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #59254 from WanLinghao/rbac_helpers_test_improve\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\n\tAdd UT test for PolicyRuleBuilder\n\nPolicyRuleBuilder is used to construct PolicyRule.\r\nAdd UT test to check if its construct is correct.\t\r\n\r\n\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNONE\r\n```","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/96a0df641343829709a9f45cd715add9f3a83e47"},{"sha":"dbde7ef2104e7bed3c9ebf7414671321f3c40eda","author":{"name":"Anago GCB","email":"365ec17a675f3273bc16c74761ad83f2cf07c59a@k8s.io"},"message":"Update CHANGELOG-1.11.md for v1.11.0-alpha.2.","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/dbde7ef2104e7bed3c9ebf7414671321f3c40eda"},{"sha":"1002f80569d80eadff485dce74cf5d4bf05aac35","author":{"name":"Clayton Coleman","email":"4f499256fd2260f9682a9d9e63c3f1d668ee5cdf@redhat.com"},"message":"Decorator for Create should be called on out, not obj\n\nobj is not what we return","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/1002f80569d80eadff485dce74cf5d4bf05aac35"},{"sha":"9e72003b9d3c80a510e5913af432fad740519c32","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63349 from smarterclayton/decorator\n\nAutomatic merge from submit-queue (batch tested with PRs 63349, 63294). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nDecorator for Create should be called on out, not obj","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/9e72003b9d3c80a510e5913af432fad740519c32"},{"sha":"0d43bdec2b8598ff542a1afdee876d417b4e7668","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63294 from bertinatto/throttle_aws\n\nAutomatic merge from submit-queue (batch tested with PRs 63349, 63294). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nAdd metric for throttled requests in AWS\n\n**What this PR does / why we need it**:\r\n\r\nThis PR adds a metric for request throttling in AWS.\r\n\r\n**Special notes for your reviewer**:\r\n\r\n* Added metric.\r\n* Moved metrics-related code to `aws_metrics.go`.\r\n* Capitalized acronyms, e.g., `recordAwsMetric` to `recordAWSMetric`.\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNONE\r\n```","distinct":false,"url":"https://api.github.com/repos/jingax10/kubernetes/commits/0d43bdec2b8598ff542a1afdee876d417b4e7668"}]}
{"actor":{"display_login":"jingax10"}}