{"action":"created","comment":{"url":"https://api.github.com/repos/oursky/react-native-oursky/pulls/comments/239319798","pull_request_review_id":182073522,"id":239319798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTMxOTc5OA==","diff_hunk":"@@ -143,15 +144,22 @@ class CountryPicker extends React.PureComponent<Props, State> {\n       containerStyle,\n       backButtonText,\n       headerTitle,\n+      error,\n+      errorStyle,\n       ...rest\n     } = this.props;\n     const { selectedValue, showCountryList } = this.state;\n \n+    const errorColor = StyleSheet.flatten(errorStyle).color;","path":"packages/react-native-oursky/src/CountryPicker.js","position":77,"original_position":77,"commit_id":"5fbefa6daea50725cd1aabc338a6158e9b006d43","original_commit_id":"5fbefa6daea50725cd1aabc338a6158e9b006d43","user":{"login":"louischan-oursky","id":15082564,"node_id":"MDQ6VXNlcjE1MDgyNTY0","avatar_url":"https://avatars2.githubusercontent.com/u/15082564?v=4","gravatar_id":"","url":"https://api.github.com/users/louischan-oursky","html_url":"https://github.com/louischan-oursky","followers_url":"https://api.github.com/users/louischan-oursky/followers","following_url":"https://api.github.com/users/louischan-oursky/following{/other_user}","gists_url":"https://api.github.com/users/louischan-oursky/gists{/gist_id}","starred_url":"https://api.github.com/users/louischan-oursky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louischan-oursky/subscriptions","organizations_url":"https://api.github.com/users/louischan-oursky/orgs","repos_url":"https://api.github.com/users/louischan-oursky/repos","events_url":"https://api.github.com/users/louischan-oursky/events{/privacy}","received_events_url":"https://api.github.com/users/louischan-oursky/received_events","type":"User","site_admin":false},"body":"The shape of `style` is\r\n\r\nhttps://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L1837\r\n\r\n```typescript\r\nexport type StyleProp<T> = T | RegisteredStyle<T> | RecursiveArray<T | RegisteredStyle<T> | Falsy> | Falsy;\r\n```\r\n\r\nIt is either T because we can pass `{ color: \"red\"}` simply.\r\nIt can be RegisteredStyle because the bundler can assign static style to integer at bundle time.\r\nit can be array because React Native allows us to use array to compose and merge style.\r\nIt can be falsy because it allows to write condition style easier\r\n\r\n```typescript\r\n[style, error ? { color: \"red\" } : undefined /* undefined is falsy */]\r\n```","created_at":"2018-12-06T03:41:43Z","updated_at":"2018-12-06T03:41:43Z","html_url":"https://github.com/oursky/react-native-oursky/pull/14#discussion_r239319798","pull_request_url":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oursky/react-native-oursky/pulls/comments/239319798"},"html":{"href":"https://github.com/oursky/react-native-oursky/pull/14#discussion_r239319798"},"pull_request":{"href":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14"}},"in_reply_to_id":239318052},"pull_request":{"url":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14","id":236092418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDkyNDE4","html_url":"https://github.com/oursky/react-native-oursky/pull/14","diff_url":"https://github.com/oursky/react-native-oursky/pull/14.diff","patch_url":"https://github.com/oursky/react-native-oursky/pull/14.patch","issue_url":"https://api.github.com/repos/oursky/react-native-oursky/issues/14","number":14,"state":"open","locked":false,"title":"Change underline color when have error #11","user":{"login":"shana0440","id":6259797,"node_id":"MDQ6VXNlcjYyNTk3OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6259797?v=4","gravatar_id":"","url":"https://api.github.com/users/shana0440","html_url":"https://github.com/shana0440","followers_url":"https://api.github.com/users/shana0440/followers","following_url":"https://api.github.com/users/shana0440/following{/other_user}","gists_url":"https://api.github.com/users/shana0440/gists{/gist_id}","starred_url":"https://api.github.com/users/shana0440/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana0440/subscriptions","organizations_url":"https://api.github.com/users/shana0440/orgs","repos_url":"https://api.github.com/users/shana0440/repos","events_url":"https://api.github.com/users/shana0440/events{/privacy}","received_events_url":"https://api.github.com/users/shana0440/received_events","type":"User","site_admin":false},"body":"Connect #11 ","created_at":"2018-12-05T08:56:55Z","updated_at":"2018-12-06T03:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d57ad6bd593139b061630a6a5931411d47ebaa4a","assignee":{"login":"cychiuae","id":10144357,"node_id":"MDQ6VXNlcjEwMTQ0MzU3","avatar_url":"https://avatars1.githubusercontent.com/u/10144357?v=4","gravatar_id":"","url":"https://api.github.com/users/cychiuae","html_url":"https://github.com/cychiuae","followers_url":"https://api.github.com/users/cychiuae/followers","following_url":"https://api.github.com/users/cychiuae/following{/other_user}","gists_url":"https://api.github.com/users/cychiuae/gists{/gist_id}","starred_url":"https://api.github.com/users/cychiuae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cychiuae/subscriptions","organizations_url":"https://api.github.com/users/cychiuae/orgs","repos_url":"https://api.github.com/users/cychiuae/repos","events_url":"https://api.github.com/users/cychiuae/events{/privacy}","received_events_url":"https://api.github.com/users/cychiuae/received_events","type":"User","site_admin":false},"assignees":[{"login":"cychiuae","id":10144357,"node_id":"MDQ6VXNlcjEwMTQ0MzU3","avatar_url":"https://avatars1.githubusercontent.com/u/10144357?v=4","gravatar_id":"","url":"https://api.github.com/users/cychiuae","html_url":"https://github.com/cychiuae","followers_url":"https://api.github.com/users/cychiuae/followers","following_url":"https://api.github.com/users/cychiuae/following{/other_user}","gists_url":"https://api.github.com/users/cychiuae/gists{/gist_id}","starred_url":"https://api.github.com/users/cychiuae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cychiuae/subscriptions","organizations_url":"https://api.github.com/users/cychiuae/orgs","repos_url":"https://api.github.com/users/cychiuae/repos","events_url":"https://api.github.com/users/cychiuae/events{/privacy}","received_events_url":"https://api.github.com/users/cychiuae/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cychiuae","id":10144357,"node_id":"MDQ6VXNlcjEwMTQ0MzU3","avatar_url":"https://avatars1.githubusercontent.com/u/10144357?v=4","gravatar_id":"","url":"https://api.github.com/users/cychiuae","html_url":"https://github.com/cychiuae","followers_url":"https://api.github.com/users/cychiuae/followers","following_url":"https://api.github.com/users/cychiuae/following{/other_user}","gists_url":"https://api.github.com/users/cychiuae/gists{/gist_id}","starred_url":"https://api.github.com/users/cychiuae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cychiuae/subscriptions","organizations_url":"https://api.github.com/users/cychiuae/orgs","repos_url":"https://api.github.com/users/cychiuae/repos","events_url":"https://api.github.com/users/cychiuae/events{/privacy}","received_events_url":"https://api.github.com/users/cychiuae/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14/commits","review_comments_url":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14/comments","review_comment_url":"https://api.github.com/repos/oursky/react-native-oursky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oursky/react-native-oursky/issues/14/comments","statuses_url":"https://api.github.com/repos/oursky/react-native-oursky/statuses/5fbefa6daea50725cd1aabc338a6158e9b006d43","head":{"label":"shana0440:11-change-underline-color-when-have-error","ref":"11-change-underline-color-when-have-error","sha":"5fbefa6daea50725cd1aabc338a6158e9b006d43","user":{"login":"shana0440","id":6259797,"node_id":"MDQ6VXNlcjYyNTk3OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6259797?v=4","gravatar_id":"","url":"https://api.github.com/users/shana0440","html_url":"https://github.com/shana0440","followers_url":"https://api.github.com/users/shana0440/followers","following_url":"https://api.github.com/users/shana0440/following{/other_user}","gists_url":"https://api.github.com/users/shana0440/gists{/gist_id}","starred_url":"https://api.github.com/users/shana0440/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana0440/subscriptions","organizations_url":"https://api.github.com/users/shana0440/orgs","repos_url":"https://api.github.com/users/shana0440/repos","events_url":"https://api.github.com/users/shana0440/events{/privacy}","received_events_url":"https://api.github.com/users/shana0440/received_events","type":"User","site_admin":false},"repo":{"id":159443685,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0NDM2ODU=","name":"react-native-oursky","full_name":"shana0440/react-native-oursky","private":false,"owner":{"login":"shana0440","id":6259797,"node_id":"MDQ6VXNlcjYyNTk3OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6259797?v=4","gravatar_id":"","url":"https://api.github.com/users/shana0440","html_url":"https://github.com/shana0440","followers_url":"https://api.github.com/users/shana0440/followers","following_url":"https://api.github.com/users/shana0440/following{/other_user}","gists_url":"https://api.github.com/users/shana0440/gists{/gist_id}","starred_url":"https://api.github.com/users/shana0440/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana0440/subscriptions","organizations_url":"https://api.github.com/users/shana0440/orgs","repos_url":"https://api.github.com/users/shana0440/repos","events_url":"https://api.github.com/users/shana0440/events{/privacy}","received_events_url":"https://api.github.com/users/shana0440/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shana0440/react-native-oursky","description":null,"fork":true,"url":"https://api.github.com/repos/shana0440/react-native-oursky","forks_url":"https://api.github.com/repos/shana0440/react-native-oursky/forks","keys_url":"https://api.github.com/repos/shana0440/react-native-oursky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shana0440/react-native-oursky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shana0440/react-native-oursky/teams","hooks_url":"https://api.github.com/repos/shana0440/react-native-oursky/hooks","issue_events_url":"https://api.github.com/repos/shana0440/react-native-oursky/issues/events{/number}","events_url":"https://api.github.com/repos/shana0440/react-native-oursky/events","assignees_url":"https://api.github.com/repos/shana0440/react-native-oursky/assignees{/user}","branches_url":"https://api.github.com/repos/shana0440/react-native-oursky/branches{/branch}","tags_url":"https://api.github.com/repos/shana0440/react-native-oursky/tags","blobs_url":"https://api.github.com/repos/shana0440/react-native-oursky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shana0440/react-native-oursky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shana0440/react-native-oursky/git/refs{/sha}","trees_url":"https://api.github.com/repos/shana0440/react-native-oursky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shana0440/react-native-oursky/statuses/{sha}","languages_url":"https://api.github.com/repos/shana0440/react-native-oursky/languages","stargazers_url":"https://api.github.com/repos/shana0440/react-native-oursky/stargazers","contributors_url":"https://api.github.com/repos/shana0440/react-native-oursky/contributors","subscribers_url":"https://api.github.com/repos/shana0440/react-native-oursky/subscribers","subscription_url":"https://api.github.com/repos/shana0440/react-native-oursky/subscription","commits_url":"https://api.github.com/repos/shana0440/react-native-oursky/commits{/sha}","git_commits_url":"https://api.github.com/repos/shana0440/react-native-oursky/git/commits{/sha}","comments_url":"https://api.github.com/repos/shana0440/react-native-oursky/comments{/number}","issue_comment_url":"https://api.github.com/repos/shana0440/react-native-oursky/issues/comments{/number}","contents_url":"https://api.github.com/repos/shana0440/react-native-oursky/contents/{+path}","compare_url":"https://api.github.com/repos/shana0440/react-native-oursky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shana0440/react-native-oursky/merges","archive_url":"https://api.github.com/repos/shana0440/react-native-oursky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shana0440/react-native-oursky/downloads","issues_url":"https://api.github.com/repos/shana0440/react-native-oursky/issues{/number}","pulls_url":"https://api.github.com/repos/shana0440/react-native-oursky/pulls{/number}","milestones_url":"https://api.github.com/repos/shana0440/react-native-oursky/milestones{/number}","notifications_url":"https://api.github.com/repos/shana0440/react-native-oursky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shana0440/react-native-oursky/labels{/name}","releases_url":"https://api.github.com/repos/shana0440/react-native-oursky/releases{/id}","deployments_url":"https://api.github.com/repos/shana0440/react-native-oursky/deployments","created_at":"2018-11-28T04:29:16Z","updated_at":"2018-11-28T04:29:19Z","pushed_at":"2018-12-06T03:40:47Z","git_url":"git://github.com/shana0440/react-native-oursky.git","ssh_url":"git@github.com:shana0440/react-native-oursky.git","clone_url":"https://github.com/shana0440/react-native-oursky.git","svn_url":"https://github.com/shana0440/react-native-oursky","homepage":null,"size":459,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oursky:master","ref":"master","sha":"b5233964378198b123c48f1960038b3a9ebbd073","user":{"login":"oursky","id":372439,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjQzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/372439?v=4","gravatar_id":"","url":"https://api.github.com/users/oursky","html_url":"https://github.com/oursky","followers_url":"https://api.github.com/users/oursky/followers","following_url":"https://api.github.com/users/oursky/following{/other_user}","gists_url":"https://api.github.com/users/oursky/gists{/gist_id}","starred_url":"https://api.github.com/users/oursky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oursky/subscriptions","organizations_url":"https://api.github.com/users/oursky/orgs","repos_url":"https://api.github.com/users/oursky/repos","events_url":"https://api.github.com/users/oursky/events{/privacy}","received_events_url":"https://api.github.com/users/oursky/received_events","type":"Organization","site_admin":false},"repo":{"id":145705393,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3MDUzOTM=","name":"react-native-oursky","full_name":"oursky/react-native-oursky","private":false,"owner":{"login":"oursky","id":372439,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjQzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/372439?v=4","gravatar_id":"","url":"https://api.github.com/users/oursky","html_url":"https://github.com/oursky","followers_url":"https://api.github.com/users/oursky/followers","following_url":"https://api.github.com/users/oursky/following{/other_user}","gists_url":"https://api.github.com/users/oursky/gists{/gist_id}","starred_url":"https://api.github.com/users/oursky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oursky/subscriptions","organizations_url":"https://api.github.com/users/oursky/orgs","repos_url":"https://api.github.com/users/oursky/repos","events_url":"https://api.github.com/users/oursky/events{/privacy}","received_events_url":"https://api.github.com/users/oursky/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oursky/react-native-oursky","description":null,"fork":false,"url":"https://api.github.com/repos/oursky/react-native-oursky","forks_url":"https://api.github.com/repos/oursky/react-native-oursky/forks","keys_url":"https://api.github.com/repos/oursky/react-native-oursky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oursky/react-native-oursky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oursky/react-native-oursky/teams","hooks_url":"https://api.github.com/repos/oursky/react-native-oursky/hooks","issue_events_url":"https://api.github.com/repos/oursky/react-native-oursky/issues/events{/number}","events_url":"https://api.github.com/repos/oursky/react-native-oursky/events","assignees_url":"https://api.github.com/repos/oursky/react-native-oursky/assignees{/user}","branches_url":"https://api.github.com/repos/oursky/react-native-oursky/branches{/branch}","tags_url":"https://api.github.com/repos/oursky/react-native-oursky/tags","blobs_url":"https://api.github.com/repos/oursky/react-native-oursky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oursky/react-native-oursky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oursky/react-native-oursky/git/refs{/sha}","trees_url":"https://api.github.com/repos/oursky/react-native-oursky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oursky/react-native-oursky/statuses/{sha}","languages_url":"https://api.github.com/repos/oursky/react-native-oursky/languages","stargazers_url":"https://api.github.com/repos/oursky/react-native-oursky/stargazers","contributors_url":"https://api.github.com/repos/oursky/react-native-oursky/contributors","subscribers_url":"https://api.github.com/repos/oursky/react-native-oursky/subscribers","subscription_url":"https://api.github.com/repos/oursky/react-native-oursky/subscription","commits_url":"https://api.github.com/repos/oursky/react-native-oursky/commits{/sha}","git_commits_url":"https://api.github.com/repos/oursky/react-native-oursky/git/commits{/sha}","comments_url":"https://api.github.com/repos/oursky/react-native-oursky/comments{/number}","issue_comment_url":"https://api.github.com/repos/oursky/react-native-oursky/issues/comments{/number}","contents_url":"https://api.github.com/repos/oursky/react-native-oursky/contents/{+path}","compare_url":"https://api.github.com/repos/oursky/react-native-oursky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oursky/react-native-oursky/merges","archive_url":"https://api.github.com/repos/oursky/react-native-oursky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oursky/react-native-oursky/downloads","issues_url":"https://api.github.com/repos/oursky/react-native-oursky/issues{/number}","pulls_url":"https://api.github.com/repos/oursky/react-native-oursky/pulls{/number}","milestones_url":"https://api.github.com/repos/oursky/react-native-oursky/milestones{/number}","notifications_url":"https://api.github.com/repos/oursky/react-native-oursky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oursky/react-native-oursky/labels{/name}","releases_url":"https://api.github.com/repos/oursky/react-native-oursky/releases{/id}","deployments_url":"https://api.github.com/repos/oursky/react-native-oursky/deployments","created_at":"2018-08-22T12:22:03Z","updated_at":"2018-12-05T07:26:41Z","pushed_at":"2018-12-06T03:40:48Z","git_url":"git://github.com/oursky/react-native-oursky.git","ssh_url":"git@github.com:oursky/react-native-oursky.git","clone_url":"https://github.com/oursky/react-native-oursky.git","svn_url":"https://github.com/oursky/react-native-oursky","homepage":null,"size":439,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14"},"html":{"href":"https://github.com/oursky/react-native-oursky/pull/14"},"issue":{"href":"https://api.github.com/repos/oursky/react-native-oursky/issues/14"},"comments":{"href":"https://api.github.com/repos/oursky/react-native-oursky/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/oursky/react-native-oursky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oursky/react-native-oursky/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/oursky/react-native-oursky/statuses/5fbefa6daea50725cd1aabc338a6158e9b006d43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"louischan-oursky"}}