{"action":"opened","number":4626,"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/4626","id":220084603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDg0NjAz","html_url":"https://github.com/dotnet/core-setup/pull/4626","diff_url":"https://github.com/dotnet/core-setup/pull/4626.diff","patch_url":"https://github.com/dotnet/core-setup/pull/4626.patch","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/4626","number":4626,"state":"open","locked":false,"title":"Add option to build the corehost incrementally","user":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"body":"Currently the build script hardcodes clean rebuild of the native components in corehost. This makes it pretty slow for inner dev loop.\r\nThe same script also always clears all the intermediates which makes cmake perform all of the detections again which is also very slow.\r\nThis change adds a new build option -IncrementalNativeBuild=true which disables these two behaviors (don't delete intermediates, don't force a rebuild).\r\n\r\nAlso add a build option to build just the corehost subtree since that's a common task for devs working on the hosting components.\r\n\r\nWith this change empty incremental build (no changes made) of the corehost components is now less than 10 seconds. Change to a single cpp file takes less than 20 seconds to rebuild (as oppose to couple of minutes before).","created_at":"2018-10-03T15:38:33Z","updated_at":"2018-10-03T15:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4626/commits","review_comments_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4626/comments","review_comment_url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/4626/comments","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/af139963731ef1fbc43c754aaf6378c0287a697a","head":{"label":"vitek-karas:IncrementalNativeBuild","ref":"IncrementalNativeBuild","sha":"af139963731ef1fbc43c754aaf6378c0287a697a","user":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"repo":{"id":138876524,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4NzY1MjQ=","name":"core-setup","full_name":"vitek-karas/core-setup","private":false,"owner":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vitek-karas/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":true,"url":"https://api.github.com/repos/vitek-karas/core-setup","forks_url":"https://api.github.com/repos/vitek-karas/core-setup/forks","keys_url":"https://api.github.com/repos/vitek-karas/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitek-karas/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitek-karas/core-setup/teams","hooks_url":"https://api.github.com/repos/vitek-karas/core-setup/hooks","issue_events_url":"https://api.github.com/repos/vitek-karas/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/vitek-karas/core-setup/events","assignees_url":"https://api.github.com/repos/vitek-karas/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/vitek-karas/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/vitek-karas/core-setup/tags","blobs_url":"https://api.github.com/repos/vitek-karas/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitek-karas/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitek-karas/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitek-karas/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitek-karas/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/vitek-karas/core-setup/languages","stargazers_url":"https://api.github.com/repos/vitek-karas/core-setup/stargazers","contributors_url":"https://api.github.com/repos/vitek-karas/core-setup/contributors","subscribers_url":"https://api.github.com/repos/vitek-karas/core-setup/subscribers","subscription_url":"https://api.github.com/repos/vitek-karas/core-setup/subscription","commits_url":"https://api.github.com/repos/vitek-karas/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitek-karas/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitek-karas/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitek-karas/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitek-karas/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/vitek-karas/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitek-karas/core-setup/merges","archive_url":"https://api.github.com/repos/vitek-karas/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitek-karas/core-setup/downloads","issues_url":"https://api.github.com/repos/vitek-karas/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/vitek-karas/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/vitek-karas/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/vitek-karas/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitek-karas/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/vitek-karas/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/vitek-karas/core-setup/deployments","created_at":"2018-06-27T12:09:50Z","updated_at":"2018-10-03T14:03:34Z","pushed_at":"2018-10-03T15:36:37Z","git_url":"git://github.com/vitek-karas/core-setup.git","ssh_url":"git@github.com:vitek-karas/core-setup.git","clone_url":"https://github.com/vitek-karas/core-setup.git","svn_url":"https://github.com/vitek-karas/core-setup","homepage":"","size":6533,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f032e2ae42c51a04629d3d8b51874073992be269","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":59249196,"node_id":"MDEwOlJlcG9zaXRvcnk1OTI0OTE5Ng==","name":"core-setup","full_name":"dotnet/core-setup","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":false,"url":"https://api.github.com/repos/dotnet/core-setup","forks_url":"https://api.github.com/repos/dotnet/core-setup/forks","keys_url":"https://api.github.com/repos/dotnet/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/core-setup/teams","hooks_url":"https://api.github.com/repos/dotnet/core-setup/hooks","issue_events_url":"https://api.github.com/repos/dotnet/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/core-setup/events","assignees_url":"https://api.github.com/repos/dotnet/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/core-setup/tags","blobs_url":"https://api.github.com/repos/dotnet/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/core-setup/languages","stargazers_url":"https://api.github.com/repos/dotnet/core-setup/stargazers","contributors_url":"https://api.github.com/repos/dotnet/core-setup/contributors","subscribers_url":"https://api.github.com/repos/dotnet/core-setup/subscribers","subscription_url":"https://api.github.com/repos/dotnet/core-setup/subscription","commits_url":"https://api.github.com/repos/dotnet/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/core-setup/merges","archive_url":"https://api.github.com/repos/dotnet/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/core-setup/downloads","issues_url":"https://api.github.com/repos/dotnet/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/core-setup/deployments","created_at":"2016-05-19T23:07:13Z","updated_at":"2018-10-03T12:20:34Z","pushed_at":"2018-10-03T12:58:29Z","git_url":"git://github.com/dotnet/core-setup.git","ssh_url":"git@github.com:dotnet/core-setup.git","clone_url":"https://github.com/dotnet/core-setup.git","svn_url":"https://github.com/dotnet/core-setup","homepage":"","size":6720,"stargazers_count":241,"watchers_count":241,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":158,"open_issues":190,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4626"},"html":{"href":"https://github.com/dotnet/core-setup/pull/4626"},"issue":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/4626"},"comments":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/4626/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4626/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4626/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/core-setup/statuses/af139963731ef1fbc43c754aaf6378c0287a697a"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":28,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"vitek-karas"}}