{"action":"created","comment":{"url":"https://api.github.com/repos/google/xi-mac/pulls/comments/170675399","pull_request_review_id":99397397,"id":170675399,"diff_hunk":"@@ -259,6 +259,14 @@ class EditViewController: NSViewController, EditViewDataSource, FindDelegate, Sc\n         editView.inputContext?.discardMarkedText()\n         document.sendRpcAsync(\"select_all\", params: [])\n     }\n+    \n+    override func uppercaseWord(_ sender: Any?) {\n+        document.sendRpcAsync(\"uppercase\", params: [])","path":"XiEditor/EditViewController.swift","position":6,"original_position":6,"commit_id":"6cf895989be196e8a2b7d92bb93ced3278c50574","original_commit_id":"87afb7e724535e7472181ec73447e926d3076e8e","user":{"login":"cmyr","id":3330916,"avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"body":"This is... ambiguous. The `Events` enum was a drive-by addition, and hasn't really been used consistently. I think the longer-term goal would be to have a `XiCore` protocol that is implemented by `CoreConnection` (or a thin wrapper) which exposes the API. In any case I don't mind this as is, I don't love the `Events` API particularly, and this is clear.","created_at":"2018-02-26T17:41:55Z","updated_at":"2018-02-26T17:41:55Z","html_url":"https://github.com/google/xi-mac/pull/144#discussion_r170675399","pull_request_url":"https://api.github.com/repos/google/xi-mac/pulls/144","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/xi-mac/pulls/comments/170675399"},"html":{"href":"https://github.com/google/xi-mac/pull/144#discussion_r170675399"},"pull_request":{"href":"https://api.github.com/repos/google/xi-mac/pulls/144"}},"in_reply_to_id":168925400},"pull_request":{"url":"https://api.github.com/repos/google/xi-mac/pulls/144","id":169548529,"html_url":"https://github.com/google/xi-mac/pull/144","diff_url":"https://github.com/google/xi-mac/pull/144.diff","patch_url":"https://github.com/google/xi-mac/pull/144.patch","issue_url":"https://api.github.com/repos/google/xi-mac/issues/144","number":144,"state":"open","locked":false,"title":"Add make uppercase/lowercase","user":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"body":"This adds functionality to make text uppercase and lowercase.\r\nThis relies on https://github.com/google/xi-editor/pull/523","created_at":"2018-02-16T05:02:26Z","updated_at":"2018-02-26T17:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b92539d65887c68fec0773c2c6f2f934499c554a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/xi-mac/pulls/144/commits","review_comments_url":"https://api.github.com/repos/google/xi-mac/pulls/144/comments","review_comment_url":"https://api.github.com/repos/google/xi-mac/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/xi-mac/issues/144/comments","statuses_url":"https://api.github.com/repos/google/xi-mac/statuses/6cf895989be196e8a2b7d92bb93ced3278c50574","head":{"label":"scholtzan:master","ref":"master","sha":"6cf895989be196e8a2b7d92bb93ced3278c50574","user":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"repo":{"id":121592446,"name":"xi-mac","full_name":"scholtzan/xi-mac","owner":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scholtzan/xi-mac","description":null,"fork":true,"url":"https://api.github.com/repos/scholtzan/xi-mac","forks_url":"https://api.github.com/repos/scholtzan/xi-mac/forks","keys_url":"https://api.github.com/repos/scholtzan/xi-mac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scholtzan/xi-mac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scholtzan/xi-mac/teams","hooks_url":"https://api.github.com/repos/scholtzan/xi-mac/hooks","issue_events_url":"https://api.github.com/repos/scholtzan/xi-mac/issues/events{/number}","events_url":"https://api.github.com/repos/scholtzan/xi-mac/events","assignees_url":"https://api.github.com/repos/scholtzan/xi-mac/assignees{/user}","branches_url":"https://api.github.com/repos/scholtzan/xi-mac/branches{/branch}","tags_url":"https://api.github.com/repos/scholtzan/xi-mac/tags","blobs_url":"https://api.github.com/repos/scholtzan/xi-mac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scholtzan/xi-mac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scholtzan/xi-mac/git/refs{/sha}","trees_url":"https://api.github.com/repos/scholtzan/xi-mac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scholtzan/xi-mac/statuses/{sha}","languages_url":"https://api.github.com/repos/scholtzan/xi-mac/languages","stargazers_url":"https://api.github.com/repos/scholtzan/xi-mac/stargazers","contributors_url":"https://api.github.com/repos/scholtzan/xi-mac/contributors","subscribers_url":"https://api.github.com/repos/scholtzan/xi-mac/subscribers","subscription_url":"https://api.github.com/repos/scholtzan/xi-mac/subscription","commits_url":"https://api.github.com/repos/scholtzan/xi-mac/commits{/sha}","git_commits_url":"https://api.github.com/repos/scholtzan/xi-mac/git/commits{/sha}","comments_url":"https://api.github.com/repos/scholtzan/xi-mac/comments{/number}","issue_comment_url":"https://api.github.com/repos/scholtzan/xi-mac/issues/comments{/number}","contents_url":"https://api.github.com/repos/scholtzan/xi-mac/contents/{+path}","compare_url":"https://api.github.com/repos/scholtzan/xi-mac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scholtzan/xi-mac/merges","archive_url":"https://api.github.com/repos/scholtzan/xi-mac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scholtzan/xi-mac/downloads","issues_url":"https://api.github.com/repos/scholtzan/xi-mac/issues{/number}","pulls_url":"https://api.github.com/repos/scholtzan/xi-mac/pulls{/number}","milestones_url":"https://api.github.com/repos/scholtzan/xi-mac/milestones{/number}","notifications_url":"https://api.github.com/repos/scholtzan/xi-mac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scholtzan/xi-mac/labels{/name}","releases_url":"https://api.github.com/repos/scholtzan/xi-mac/releases{/id}","deployments_url":"https://api.github.com/repos/scholtzan/xi-mac/deployments","created_at":"2018-02-15T04:52:52Z","updated_at":"2018-02-15T04:52:54Z","pushed_at":"2018-02-24T18:46:49Z","git_url":"git://github.com/scholtzan/xi-mac.git","ssh_url":"git@github.com:scholtzan/xi-mac.git","clone_url":"https://github.com/scholtzan/xi-mac.git","svn_url":"https://github.com/scholtzan/xi-mac","homepage":null,"size":1675,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"4d33fad469b8ead520f50bc20e76797f26eca447","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":78881023,"name":"xi-mac","full_name":"google/xi-mac","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/xi-mac","description":null,"fork":false,"url":"https://api.github.com/repos/google/xi-mac","forks_url":"https://api.github.com/repos/google/xi-mac/forks","keys_url":"https://api.github.com/repos/google/xi-mac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/xi-mac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/xi-mac/teams","hooks_url":"https://api.github.com/repos/google/xi-mac/hooks","issue_events_url":"https://api.github.com/repos/google/xi-mac/issues/events{/number}","events_url":"https://api.github.com/repos/google/xi-mac/events","assignees_url":"https://api.github.com/repos/google/xi-mac/assignees{/user}","branches_url":"https://api.github.com/repos/google/xi-mac/branches{/branch}","tags_url":"https://api.github.com/repos/google/xi-mac/tags","blobs_url":"https://api.github.com/repos/google/xi-mac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/xi-mac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/xi-mac/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/xi-mac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/xi-mac/statuses/{sha}","languages_url":"https://api.github.com/repos/google/xi-mac/languages","stargazers_url":"https://api.github.com/repos/google/xi-mac/stargazers","contributors_url":"https://api.github.com/repos/google/xi-mac/contributors","subscribers_url":"https://api.github.com/repos/google/xi-mac/subscribers","subscription_url":"https://api.github.com/repos/google/xi-mac/subscription","commits_url":"https://api.github.com/repos/google/xi-mac/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/xi-mac/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/xi-mac/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/xi-mac/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/xi-mac/contents/{+path}","compare_url":"https://api.github.com/repos/google/xi-mac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/xi-mac/merges","archive_url":"https://api.github.com/repos/google/xi-mac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/xi-mac/downloads","issues_url":"https://api.github.com/repos/google/xi-mac/issues{/number}","pulls_url":"https://api.github.com/repos/google/xi-mac/pulls{/number}","milestones_url":"https://api.github.com/repos/google/xi-mac/milestones{/number}","notifications_url":"https://api.github.com/repos/google/xi-mac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/xi-mac/labels{/name}","releases_url":"https://api.github.com/repos/google/xi-mac/releases{/id}","deployments_url":"https://api.github.com/repos/google/xi-mac/deployments","created_at":"2017-01-13T19:46:46Z","updated_at":"2018-02-26T17:21:25Z","pushed_at":"2018-02-24T22:00:24Z","git_url":"git://github.com/google/xi-mac.git","ssh_url":"git@github.com:google/xi-mac.git","clone_url":"https://github.com/google/xi-mac.git","svn_url":"https://github.com/google/xi-mac","homepage":null,"size":1677,"stargazers_count":1428,"watchers_count":1428,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":57,"open_issues":30,"watchers":1428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/xi-mac/pulls/144"},"html":{"href":"https://github.com/google/xi-mac/pull/144"},"issue":{"href":"https://api.github.com/repos/google/xi-mac/issues/144"},"comments":{"href":"https://api.github.com/repos/google/xi-mac/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/google/xi-mac/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/google/xi-mac/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/xi-mac/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/google/xi-mac/statuses/6cf895989be196e8a2b7d92bb93ced3278c50574"}},"author_association":"NONE"}}
{"actor":{"display_login":"cmyr"}}