{"action":"created","issue":{"url":"https://api.github.com/repos/steveklabnik/simple-server/issues/93","repository_url":"https://api.github.com/repos/steveklabnik/simple-server","labels_url":"https://api.github.com/repos/steveklabnik/simple-server/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/steveklabnik/simple-server/issues/93/comments","events_url":"https://api.github.com/repos/steveklabnik/simple-server/issues/93/events","html_url":"https://github.com/steveklabnik/simple-server/pull/93","id":285325355,"number":93,"title":"Forward the request method to the handler","user":{"login":"denis-golubev","id":875765,"avatar_url":"https://avatars1.githubusercontent.com/u/875765?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-golubev","html_url":"https://github.com/denis-golubev","followers_url":"https://api.github.com/users/denis-golubev/followers","following_url":"https://api.github.com/users/denis-golubev/following{/other_user}","gists_url":"https://api.github.com/users/denis-golubev/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-golubev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-golubev/subscriptions","organizations_url":"https://api.github.com/users/denis-golubev/orgs","repos_url":"https://api.github.com/users/denis-golubev/repos","events_url":"https://api.github.com/users/denis-golubev/events{/privacy}","received_events_url":"https://api.github.com/users/denis-golubev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-01T19:48:46Z","updated_at":"2018-03-19T14:01:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/steveklabnik/simple-server/pulls/93","html_url":"https://github.com/steveklabnik/simple-server/pull/93","diff_url":"https://github.com/steveklabnik/simple-server/pull/93.diff","patch_url":"https://github.com/steveklabnik/simple-server/pull/93.patch"},"body":"This is a proposed fix for issue #83. This PR contains the following changes:\r\n- Use request method from `httparse`\r\n- Add a test for a simple PUT-request\r\n- Add an `Error` variant for a missing request method (I am not sure about this and do not understand in which case the `method`-attribute of `httparse::Request` may be None, i.e. if this can actually happen -- should it have a `#[doc(hidden)]` attribute?)\r\n\r\nI had to make the following changes to compile and pass the tests, though:\r\n- Fix example in documentation for `Server::with_timeout` (stable / nightly needed the handler boxed)\r\n- Fix type inference issue in the tests by specifying the type (in `impl<'content> Read for ChunkStream<'content>`)\r\n\r\nI'll be happy about feedback. "},"comment":{"url":"https://api.github.com/repos/steveklabnik/simple-server/issues/comments/374221755","html_url":"https://github.com/steveklabnik/simple-server/pull/93#issuecomment-374221755","issue_url":"https://api.github.com/repos/steveklabnik/simple-server/issues/93","id":374221755,"user":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars2.githubusercontent.com/u/27786?v=4","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T14:01:23Z","updated_at":"2018-03-19T14:01:23Z","author_association":"OWNER","body":"I'm going to nuke the cargo cache, maybe it has `rustfmt` cached or something since we were preveiously `cargo intsall`ing it?"}}
{"actor":{"display_login":"steveklabnik"}}