{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/beats/issues/8488","repository_url":"https://api.github.com/repos/elastic/beats","labels_url":"https://api.github.com/repos/elastic/beats/issues/8488/labels{/name}","comments_url":"https://api.github.com/repos/elastic/beats/issues/8488/comments","events_url":"https://api.github.com/repos/elastic/beats/issues/8488/events","html_url":"https://github.com/elastic/beats/pull/8488","id":364964848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDI2NTY3","number":8488,"title":"Update autoconfigure to stop on Docker delete events","user":{"login":"brianjones","id":2412706,"node_id":"MDQ6VXNlcjI0MTI3MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2412706?v=4","gravatar_id":"","url":"https://api.github.com/users/brianjones","html_url":"https://github.com/brianjones","followers_url":"https://api.github.com/users/brianjones/followers","following_url":"https://api.github.com/users/brianjones/following{/other_user}","gists_url":"https://api.github.com/users/brianjones/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjones/subscriptions","organizations_url":"https://api.github.com/users/brianjones/orgs","repos_url":"https://api.github.com/users/brianjones/repos","events_url":"https://api.github.com/users/brianjones/events{/privacy}","received_events_url":"https://api.github.com/users/brianjones/received_events","type":"User","site_admin":false},"labels":[{"id":294278853,"node_id":"MDU6TGFiZWwyOTQyNzg4NTM=","url":"https://api.github.com/repos/elastic/beats/labels/libbeat","name":"libbeat","color":"008000","default":false},{"id":228068770,"node_id":"MDU6TGFiZWwyMjgwNjg3NzA=","url":"https://api.github.com/repos/elastic/beats/labels/review","name":"review","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-28T16:47:51Z","updated_at":"2018-10-03T13:53:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/8488","html_url":"https://github.com/elastic/beats/pull/8488","diff_url":"https://github.com/elastic/beats/pull/8488.diff","patch_url":"https://github.com/elastic/beats/pull/8488.patch"},"body":"Fixes #6694\r\n\r\nThe Docker Autodiscover Provider was listening for \"stop\" events from Docker, which occur when a container stops. This immediatly stopped harvesting of the log file, often losing the end of the it. In the case of a failure, the end of the log file is the most important.\r\n\r\nFortunately, the common Docker component already generates \"delete\" events 60s after a container is stopped.\r\n\r\nThis PR changes the provider to use the delete event instead, allowing the rest of the log file to be harvested in that 60s."},"comment":{"url":"https://api.github.com/repos/elastic/beats/issues/comments/426645740","html_url":"https://github.com/elastic/beats/pull/8488#issuecomment-426645740","issue_url":"https://api.github.com/repos/elastic/beats/issues/8488","id":426645740,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjY0NTc0MA==","user":{"login":"exekias","id":299804,"node_id":"MDQ6VXNlcjI5OTgwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/299804?v=4","gravatar_id":"","url":"https://api.github.com/users/exekias","html_url":"https://github.com/exekias","followers_url":"https://api.github.com/users/exekias/followers","following_url":"https://api.github.com/users/exekias/following{/other_user}","gists_url":"https://api.github.com/users/exekias/gists{/gist_id}","starred_url":"https://api.github.com/users/exekias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exekias/subscriptions","organizations_url":"https://api.github.com/users/exekias/orgs","repos_url":"https://api.github.com/users/exekias/repos","events_url":"https://api.github.com/users/exekias/events{/privacy}","received_events_url":"https://api.github.com/users/exekias/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T13:53:08Z","updated_at":"2018-10-03T13:53:08Z","author_association":"MEMBER","body":"Understood, btw you got the code right. I would be ok with exposing the 60s timeout as a configuration variable. Does that sound good to you?\r\n\r\nI think we should closed this PR and open a new issue or PR for that"}}
{"actor":{"display_login":"exekias"}}