{"action":"closed","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/19745","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/19745/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/19745/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/19745/events","html_url":"https://github.com/openshift/origin/issues/19745","id":323825557,"number":19745,"title":"Support mapping configMaps and secrets in BuildConfigs","user":{"login":"sparty02","id":1483538,"avatar_url":"https://avatars2.githubusercontent.com/u/1483538?v=4","gravatar_id":"","url":"https://api.github.com/users/sparty02","html_url":"https://github.com/sparty02","followers_url":"https://api.github.com/users/sparty02/followers","following_url":"https://api.github.com/users/sparty02/following{/other_user}","gists_url":"https://api.github.com/users/sparty02/gists{/gist_id}","starred_url":"https://api.github.com/users/sparty02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparty02/subscriptions","organizations_url":"https://api.github.com/users/sparty02/orgs","repos_url":"https://api.github.com/users/sparty02/repos","events_url":"https://api.github.com/users/sparty02/events{/privacy}","received_events_url":"https://api.github.com/users/sparty02/received_events","type":"User","site_admin":false},"labels":[{"id":210155294,"url":"https://api.github.com/repos/openshift/origin/labels/component/build","name":"component/build","color":"0052cc","default":false},{"id":770487842,"url":"https://api.github.com/repos/openshift/origin/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":657292112,"url":"https://api.github.com/repos/openshift/origin/labels/sig/developer-experience","name":"sig/developer-experience","color":"f9d0c4","default":false}],"state":"closed","locked":false,"assignee":{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-16T23:47:54Z","updated_at":"2018-05-17T12:40:08Z","closed_at":"2018-05-17T12:40:07Z","author_association":"NONE","body":"OpenShift BuildConfigs should support buildArgs being sourced from secrets (or config maps for that matter).\r\n\r\nHere is an example of what using this feature would look like:\r\n\r\n```yaml\r\napiVersion: build.openshift.io/v1\r\nkind: BuildConfig\r\nmetadata:\r\n  name: foo-build\r\nspec:\r\n  runPolicy: Serial\r\n  source:\r\n    type: Binary\r\n  strategy:\r\n    type: Docker\r\n    dockerStrategy:\r\n      dockerfilePath: Dockerfile\r\n      buildArgs:\r\n        - name: http_proxy\r\n          valueFrom:\r\n            configMapKeyRef:\r\n              name: proxy-config\r\n              key: proxy-url\r\n        - name: no_proxy\r\n          value: foo.dev.local\r\n        - name: USERNAME\r\n          valueFrom:\r\n            secretKeyRef:\r\n              name: auth-basic\r\n              key: username\r\n```\r\n\r\nNote that the example above is showing a mixture of a buildArg literal, a buildArg mapped from a configMap and a buildArg mapped from a secret.  Also note that this particular example is for mapping buildArgs in a dockerStrategy, but the ability to map configMaps and secrets should be available in all BuildConfig strategies for other similar items like environment variable (env) blocks.\r\n\r\n##### Version\r\nOpenShift Master:\r\nv3.7.44\r\nKubernetes Master:\r\nv1.7.6+a08f5eeb62\r\n"}}
{"actor":{"display_login":"bparees"}}