{"action":"created","comment":{"url":"https://api.github.com/repos/mxcube/ui-api/pulls/comments/191433699","pull_request_review_id":124003682,"id":191433699,"diff_hunk":"@@ -1,38 +1,33 @@\n General API\n ===========\n \n-  Functions and classes used generally across the interface.\n+  Functions and classes used across the interface.\n \n Procedures\n ----------\n \n .. code:: python\n \n     \"\"\"\n-    This code describes \"generic\" beamline procedures.","path":"data_structures.rst","position":13,"original_position":13,"commit_id":"dcdbff1c5c25b6c09477922193089316c86c9f7e","original_commit_id":"5a3fc33745f88cff1517cedc10395b03fdbba069","user":{"login":"rhfogh","id":9820176,"avatar_url":"https://avatars0.githubusercontent.com/u/9820176?v=4","gravatar_id":"","url":"https://api.github.com/users/rhfogh","html_url":"https://github.com/rhfogh","followers_url":"https://api.github.com/users/rhfogh/followers","following_url":"https://api.github.com/users/rhfogh/following{/other_user}","gists_url":"https://api.github.com/users/rhfogh/gists{/gist_id}","starred_url":"https://api.github.com/users/rhfogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhfogh/subscriptions","organizations_url":"https://api.github.com/users/rhfogh/orgs","repos_url":"https://api.github.com/users/rhfogh/repos","events_url":"https://api.github.com/users/rhfogh/events{/privacy}","received_events_url":"https://api.github.com/users/rhfogh/received_events","type":"User","site_admin":false},"body":"Moving the (modified) text sound like a good idea. But I am again a little confused by what goes where. Procedures are not inherently limited and could be used for (beamline-specific) functionality in any area: diffractometer, lims, workflow, ... The beamline file I thouight was limited to things that do not belong elsewhere (i.e. not diffractometer, not lims, not workflow, ...). So is this use of procedure data limited to a specific component, or is beamine.rst not a component but a sort of top-level, covers-everything file?","created_at":"2018-05-29T13:57:28Z","updated_at":"2018-05-29T13:57:28Z","html_url":"https://github.com/mxcube/ui-api/pull/21#discussion_r191433699","pull_request_url":"https://api.github.com/repos/mxcube/ui-api/pulls/21","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mxcube/ui-api/pulls/comments/191433699"},"html":{"href":"https://github.com/mxcube/ui-api/pull/21#discussion_r191433699"},"pull_request":{"href":"https://api.github.com/repos/mxcube/ui-api/pulls/21"}},"in_reply_to_id":191373872},"pull_request":{"url":"https://api.github.com/repos/mxcube/ui-api/pulls/21","id":191082850,"html_url":"https://github.com/mxcube/ui-api/pull/21","diff_url":"https://github.com/mxcube/ui-api/pull/21.diff","patch_url":"https://github.com/mxcube/ui-api/pull/21.patch","issue_url":"https://api.github.com/repos/mxcube/ui-api/issues/21","number":21,"state":"open","locked":false,"title":"Removed \"in code\" questions, and fixed some typos","user":{"login":"marcus-oscarsson","id":4331447,"avatar_url":"https://avatars0.githubusercontent.com/u/4331447?v=4","gravatar_id":"","url":"https://api.github.com/users/marcus-oscarsson","html_url":"https://github.com/marcus-oscarsson","followers_url":"https://api.github.com/users/marcus-oscarsson/followers","following_url":"https://api.github.com/users/marcus-oscarsson/following{/other_user}","gists_url":"https://api.github.com/users/marcus-oscarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/marcus-oscarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcus-oscarsson/subscriptions","organizations_url":"https://api.github.com/users/marcus-oscarsson/orgs","repos_url":"https://api.github.com/users/marcus-oscarsson/repos","events_url":"https://api.github.com/users/marcus-oscarsson/events{/privacy}","received_events_url":"https://api.github.com/users/marcus-oscarsson/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nRemoved \"in code\" questions, and fixed some typos. Please comment on the questions that you feel have not been answered.\r\n\r\nRegards,\r\nMarcus","created_at":"2018-05-29T09:24:30Z","updated_at":"2018-05-29T13:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6ead02f66852b02d6d05d57c4ce8fca0df6f6ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mxcube/ui-api/pulls/21/commits","review_comments_url":"https://api.github.com/repos/mxcube/ui-api/pulls/21/comments","review_comment_url":"https://api.github.com/repos/mxcube/ui-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxcube/ui-api/issues/21/comments","statuses_url":"https://api.github.com/repos/mxcube/ui-api/statuses/dcdbff1c5c25b6c09477922193089316c86c9f7e","head":{"label":"marcus-oscarsson:master","ref":"master","sha":"dcdbff1c5c25b6c09477922193089316c86c9f7e","user":{"login":"marcus-oscarsson","id":4331447,"avatar_url":"https://avatars0.githubusercontent.com/u/4331447?v=4","gravatar_id":"","url":"https://api.github.com/users/marcus-oscarsson","html_url":"https://github.com/marcus-oscarsson","followers_url":"https://api.github.com/users/marcus-oscarsson/followers","following_url":"https://api.github.com/users/marcus-oscarsson/following{/other_user}","gists_url":"https://api.github.com/users/marcus-oscarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/marcus-oscarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcus-oscarsson/subscriptions","organizations_url":"https://api.github.com/users/marcus-oscarsson/orgs","repos_url":"https://api.github.com/users/marcus-oscarsson/repos","events_url":"https://api.github.com/users/marcus-oscarsson/events{/privacy}","received_events_url":"https://api.github.com/users/marcus-oscarsson/received_events","type":"User","site_admin":false},"repo":{"id":129271418,"name":"ui-api","full_name":"marcus-oscarsson/ui-api","owner":{"login":"marcus-oscarsson","id":4331447,"avatar_url":"https://avatars0.githubusercontent.com/u/4331447?v=4","gravatar_id":"","url":"https://api.github.com/users/marcus-oscarsson","html_url":"https://github.com/marcus-oscarsson","followers_url":"https://api.github.com/users/marcus-oscarsson/followers","following_url":"https://api.github.com/users/marcus-oscarsson/following{/other_user}","gists_url":"https://api.github.com/users/marcus-oscarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/marcus-oscarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcus-oscarsson/subscriptions","organizations_url":"https://api.github.com/users/marcus-oscarsson/orgs","repos_url":"https://api.github.com/users/marcus-oscarsson/repos","events_url":"https://api.github.com/users/marcus-oscarsson/events{/privacy}","received_events_url":"https://api.github.com/users/marcus-oscarsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcus-oscarsson/ui-api","description":"Repository for specifying the API used between the MXCuBE user interface and its backend","fork":true,"url":"https://api.github.com/repos/marcus-oscarsson/ui-api","forks_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/forks","keys_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/teams","hooks_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/hooks","issue_events_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/issues/events{/number}","events_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/events","assignees_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/assignees{/user}","branches_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/branches{/branch}","tags_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/tags","blobs_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/statuses/{sha}","languages_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/languages","stargazers_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/stargazers","contributors_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/contributors","subscribers_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/subscribers","subscription_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/subscription","commits_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/contents/{+path}","compare_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/merges","archive_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/downloads","issues_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/issues{/number}","pulls_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/pulls{/number}","milestones_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/milestones{/number}","notifications_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/labels{/name}","releases_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/releases{/id}","deployments_url":"https://api.github.com/repos/marcus-oscarsson/ui-api/deployments","created_at":"2018-04-12T15:19:51Z","updated_at":"2018-05-29T12:52:35Z","pushed_at":"2018-05-29T12:52:33Z","git_url":"git://github.com/marcus-oscarsson/ui-api.git","ssh_url":"git@github.com:marcus-oscarsson/ui-api.git","clone_url":"https://github.com/marcus-oscarsson/ui-api.git","svn_url":"https://github.com/marcus-oscarsson/ui-api","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mxcube:master","ref":"master","sha":"6688e8d76360837e01a6e27926811c02edd2a114","user":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars2.githubusercontent.com/u/4322027?v=4","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"repo":{"id":129268611,"name":"ui-api","full_name":"mxcube/ui-api","owner":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars2.githubusercontent.com/u/4322027?v=4","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mxcube/ui-api","description":"Repository for specifying the API used between the MXCuBE user interface and its backend","fork":false,"url":"https://api.github.com/repos/mxcube/ui-api","forks_url":"https://api.github.com/repos/mxcube/ui-api/forks","keys_url":"https://api.github.com/repos/mxcube/ui-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxcube/ui-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxcube/ui-api/teams","hooks_url":"https://api.github.com/repos/mxcube/ui-api/hooks","issue_events_url":"https://api.github.com/repos/mxcube/ui-api/issues/events{/number}","events_url":"https://api.github.com/repos/mxcube/ui-api/events","assignees_url":"https://api.github.com/repos/mxcube/ui-api/assignees{/user}","branches_url":"https://api.github.com/repos/mxcube/ui-api/branches{/branch}","tags_url":"https://api.github.com/repos/mxcube/ui-api/tags","blobs_url":"https://api.github.com/repos/mxcube/ui-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxcube/ui-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxcube/ui-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxcube/ui-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxcube/ui-api/statuses/{sha}","languages_url":"https://api.github.com/repos/mxcube/ui-api/languages","stargazers_url":"https://api.github.com/repos/mxcube/ui-api/stargazers","contributors_url":"https://api.github.com/repos/mxcube/ui-api/contributors","subscribers_url":"https://api.github.com/repos/mxcube/ui-api/subscribers","subscription_url":"https://api.github.com/repos/mxcube/ui-api/subscription","commits_url":"https://api.github.com/repos/mxcube/ui-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxcube/ui-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxcube/ui-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxcube/ui-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxcube/ui-api/contents/{+path}","compare_url":"https://api.github.com/repos/mxcube/ui-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxcube/ui-api/merges","archive_url":"https://api.github.com/repos/mxcube/ui-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxcube/ui-api/downloads","issues_url":"https://api.github.com/repos/mxcube/ui-api/issues{/number}","pulls_url":"https://api.github.com/repos/mxcube/ui-api/pulls{/number}","milestones_url":"https://api.github.com/repos/mxcube/ui-api/milestones{/number}","notifications_url":"https://api.github.com/repos/mxcube/ui-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxcube/ui-api/labels{/name}","releases_url":"https://api.github.com/repos/mxcube/ui-api/releases{/id}","deployments_url":"https://api.github.com/repos/mxcube/ui-api/deployments","created_at":"2018-04-12T15:00:09Z","updated_at":"2018-05-29T13:37:44Z","pushed_at":"2018-05-29T13:37:42Z","git_url":"git://github.com/mxcube/ui-api.git","ssh_url":"git@github.com:mxcube/ui-api.git","clone_url":"https://github.com/mxcube/ui-api.git","svn_url":"https://github.com/mxcube/ui-api","homepage":null,"size":65,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxcube/ui-api/pulls/21"},"html":{"href":"https://github.com/mxcube/ui-api/pull/21"},"issue":{"href":"https://api.github.com/repos/mxcube/ui-api/issues/21"},"comments":{"href":"https://api.github.com/repos/mxcube/ui-api/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/mxcube/ui-api/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/mxcube/ui-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxcube/ui-api/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/mxcube/ui-api/statuses/dcdbff1c5c25b6c09477922193089316c86c9f7e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rhfogh"}}