{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/23140","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23140/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23140/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23140/events","html_url":"https://github.com/joomla/joomla-cms/pull/23140","id":383447410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTA5NzYy","number":23140,"title":"[4.0] RTL: Correcting Joomla Update version display in System CPanel badge and Joomla Update component","user":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-22T09:28:20Z","updated_at":"2018-11-24T15:54:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/23140","html_url":"https://github.com/joomla/joomla-cms/pull/23140","diff_url":"https://github.com/joomla/joomla-cms/pull/23140.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/23140.patch"},"body":"Completing https://github.com/joomla/joomla-cms/pull/23047 ++\r\n\r\n### Summary of Changes\r\nCorrecting RTL display of Joomla Update version in CPanel System as well as in the Joomla update component.\r\nCorrecting Extension version in Joomla Update component. That one required also to modify joomlaupdate default js file to change the order of version and 'Yes' when present\r\n\r\nBasically we want to get for example:\r\n`4.0.0-alpha6-dev` instead of `alpha-dev-4.0.0` and align correctly the `<span>` concerned.\r\n\r\n### Testing Instructions\r\nOn last 4.0.0-dev branch\r\nModify libraries/src/Version.php\r\nto `const EXTRA_VERSION = 'alpha4-dev';`\r\nin order to get a database fix issue\r\nFix database.\r\nThen in JoomlaUpdate Options choose Custom URL and add this link:\r\nhttps://update.joomla.org/core/nightlies/next_major_list.xml\r\n\r\nInstall Persian language and set admin language to Persian.\r\n\r\nRequires using `npm ci` to test.\r\n### Before patch\r\n\r\n![screen shot 2018-11-22 at 10 19 14](https://user-images.githubusercontent.com/869724/48893227-258b3d80-ee40-11e8-9e37-31d299701b8b.png)\r\n\r\n![4 0jupdate_before_1](https://user-images.githubusercontent.com/869724/48892581-afd2a200-ee3e-11e8-8513-e41f121f80f6.png)\r\n\r\n![40jupdate_before_3](https://user-images.githubusercontent.com/869724/48892579-af3a0b80-ee3e-11e8-8799-cbe96c1090e9.png)\r\n\r\n![4 0jupdate_before_2](https://user-images.githubusercontent.com/869724/48892580-afd2a200-ee3e-11e8-8ab3-05e5ec749702.png)\r\n\r\n![screen shot 2018-11-22 at 10 20 58](https://user-images.githubusercontent.com/869724/48893361-76029b00-ee40-11e8-9b11-91b8180de845.png)\r\n\r\n\r\n### After patch\r\n![screen shot 2018-11-22 at 07 30 05](https://user-images.githubusercontent.com/869724/48892705-f45e3d80-ee3e-11e8-88f2-5e5e635a7b2c.png)\r\n![after-1](https://user-images.githubusercontent.com/869724/48892728-0049ff80-ee3f-11e8-9bb4-4ae363fb1621.png)\r\n![after-3](https://user-images.githubusercontent.com/869724/48892779-18ba1a00-ee3f-11e8-90dd-9b82a9e2f2a7.png)\r\n![after2-a](https://user-images.githubusercontent.com/869724/48892792-22dc1880-ee3f-11e8-8196-671af4bcacfd.png)\r\n\r\nIf no update available \r\n\r\n![after2-b](https://user-images.githubusercontent.com/869724/48892796-266f9f80-ee3f-11e8-9d79-c25139ddf438.png)\r\n\r\n![screen shot 2018-11-22 at 09 18 12](https://user-images.githubusercontent.com/869724/48892809-2b345380-ee3f-11e8-90e6-f560fe8bff5d.png)\r\n\r\n\r\n### Documentation Changes Required\r\n\r\nNone\r\n\r\n@Quy @richard67 @C-Lodder @wilsonge "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/441376990","html_url":"https://github.com/joomla/joomla-cms/pull/23140#issuecomment-441376990","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23140","id":441376990,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTM3Njk5MA==","user":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"created_at":"2018-11-24T15:54:42Z","updated_at":"2018-11-24T15:54:42Z","author_association":"MEMBER","body":"on it"}}
{"actor":{"display_login":"infograf768"}}