{"action":"created","issue":{"url":"https://api.github.com/repos/gantry/gantry5/issues/2363","repository_url":"https://api.github.com/repos/gantry/gantry5","labels_url":"https://api.github.com/repos/gantry/gantry5/issues/2363/labels{/name}","comments_url":"https://api.github.com/repos/gantry/gantry5/issues/2363/comments","events_url":"https://api.github.com/repos/gantry/gantry5/issues/2363/events","html_url":"https://github.com/gantry/gantry5/issues/2363","id":360245825,"node_id":"MDU6SXNzdWUzNjAyNDU4MjU=","number":2363,"title":"inappropriate folder permissions","user":{"login":"mandville","id":893049,"node_id":"MDQ6VXNlcjg5MzA0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/893049?v=4","gravatar_id":"","url":"https://api.github.com/users/mandville","html_url":"https://github.com/mandville","followers_url":"https://api.github.com/users/mandville/followers","following_url":"https://api.github.com/users/mandville/following{/other_user}","gists_url":"https://api.github.com/users/mandville/gists{/gist_id}","starred_url":"https://api.github.com/users/mandville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandville/subscriptions","organizations_url":"https://api.github.com/users/mandville/orgs","repos_url":"https://api.github.com/users/mandville/repos","events_url":"https://api.github.com/users/mandville/events{/privacy}","received_events_url":"https://api.github.com/users/mandville/received_events","type":"User","site_admin":false},"labels":[{"id":192807865,"node_id":"MDU6TGFiZWwxOTI4MDc4NjU=","url":"https://api.github.com/repos/gantry/gantry5/labels/invalid","name":"invalid","color":"e6e6e6","default":true},{"id":192807867,"node_id":"MDU6TGFiZWwxOTI4MDc4Njc=","url":"https://api.github.com/repos/gantry/gantry5/labels/wontfix","name":"wontfix","color":"f9f9f9","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/gantry/gantry5/milestones/73","html_url":"https://github.com/gantry/gantry5/milestone/73","labels_url":"https://api.github.com/repos/gantry/gantry5/milestones/73/labels","id":3642552,"node_id":"MDk6TWlsZXN0b25lMzY0MjU1Mg==","number":73,"title":"5.4.27","description":"","creator":{"login":"mahagr","id":854915,"node_id":"MDQ6VXNlcjg1NDkxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/854915?v=4","gravatar_id":"","url":"https://api.github.com/users/mahagr","html_url":"https://github.com/mahagr","followers_url":"https://api.github.com/users/mahagr/followers","following_url":"https://api.github.com/users/mahagr/following{/other_user}","gists_url":"https://api.github.com/users/mahagr/gists{/gist_id}","starred_url":"https://api.github.com/users/mahagr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahagr/subscriptions","organizations_url":"https://api.github.com/users/mahagr/orgs","repos_url":"https://api.github.com/users/mahagr/repos","events_url":"https://api.github.com/users/mahagr/events{/privacy}","received_events_url":"https://api.github.com/users/mahagr/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2018-09-11T06:44:33Z","updated_at":"2018-09-14T11:28:09Z","due_on":"2018-11-12T08:00:00Z","closed_at":null},"comments":45,"created_at":"2018-09-14T10:20:53Z","updated_at":"2018-09-18T11:57:37Z","closed_at":"2018-09-14T11:28:08Z","author_association":"NONE","body":"disappointing coding and possible security risk\r\n\r\n```php\r\nif (is_dir($folder)) {\r\n    return;\r\n}\r\n\r\n$success = @mkdir($folder, 0777, true);\r\n\r\nif (!$success) {\r\n    // Double check if the folder exists\r\n```"},"comment":{"url":"https://api.github.com/repos/gantry/gantry5/issues/comments/422364015","html_url":"https://github.com/gantry/gantry5/issues/2363#issuecomment-422364015","issue_url":"https://api.github.com/repos/gantry/gantry5/issues/2363","id":422364015,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjM2NDAxNQ==","user":{"login":"fcoulter","id":767486,"node_id":"MDQ6VXNlcjc2NzQ4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/767486?v=4","gravatar_id":"","url":"https://api.github.com/users/fcoulter","html_url":"https://github.com/fcoulter","followers_url":"https://api.github.com/users/fcoulter/followers","following_url":"https://api.github.com/users/fcoulter/following{/other_user}","gists_url":"https://api.github.com/users/fcoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/fcoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcoulter/subscriptions","organizations_url":"https://api.github.com/users/fcoulter/orgs","repos_url":"https://api.github.com/users/fcoulter/repos","events_url":"https://api.github.com/users/fcoulter/events{/privacy}","received_events_url":"https://api.github.com/users/fcoulter/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T11:57:37Z","updated_at":"2018-09-18T11:57:37Z","author_association":"NONE","body":"I fully accept that you can reproduce the issue on a plain Joomla installation. I have not disputed this.\r\n\r\nI still believe that there is a place for a check at the extension level as well, for several reasons:-\r\n\r\n1. It is the extension that will actually be doing the potentially unsafe operation, therefore I think that some responsibility lies with the extension developer\r\n2. At the moment Joomla etc do not show these warnings\r\n3.  If the umask issue is produced through faulty code it might not affect the entire site, eg some plugin code may or may not be executed depending on circumstances, eg an extension-specific plugin\r\n4. It never does any harm to repeat warnings.\r\n\r\nI have never suggested hiding problems, and I find it slightly irritating that you keep attributing that to me. I am simply suggesting that if there is a problem we don't make things worse than they need to be. I think that is a good rule for life in general as well.\r\n\r\nI also favour constructive proposals.\r\n"}}
{"actor":{"display_login":"fcoulter"}}