{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/user_ldap/issues/248","repository_url":"https://api.github.com/repos/owncloud/user_ldap","labels_url":"https://api.github.com/repos/owncloud/user_ldap/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/user_ldap/issues/248/comments","events_url":"https://api.github.com/repos/owncloud/user_ldap/issues/248/events","html_url":"https://github.com/owncloud/user_ldap/pull/248","id":329881736,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDI0MzEx","number":248,"title":"Remove legacy table and resolve dn encoding issues","user":{"login":"tomneedham","id":660805,"node_id":"MDQ6VXNlcjY2MDgwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/660805?v=4","gravatar_id":"","url":"https://api.github.com/users/tomneedham","html_url":"https://github.com/tomneedham","followers_url":"https://api.github.com/users/tomneedham/followers","following_url":"https://api.github.com/users/tomneedham/following{/other_user}","gists_url":"https://api.github.com/users/tomneedham/gists{/gist_id}","starred_url":"https://api.github.com/users/tomneedham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomneedham/subscriptions","organizations_url":"https://api.github.com/users/tomneedham/orgs","repos_url":"https://api.github.com/users/tomneedham/repos","events_url":"https://api.github.com/users/tomneedham/events{/privacy}","received_events_url":"https://api.github.com/users/tomneedham/received_events","type":"User","site_admin":false},"labels":[{"id":454924446,"node_id":"MDU6TGFiZWw0NTQ5MjQ0NDY=","url":"https://api.github.com/repos/owncloud/user_ldap/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":454925276,"node_id":"MDU6TGFiZWw0NTQ5MjUyNzY=","url":"https://api.github.com/repos/owncloud/user_ldap/labels/blue-ticket","name":"blue-ticket","color":"0033CC","default":false},{"id":616629015,"node_id":"MDU6TGFiZWw2MTY2MjkwMTU=","url":"https://api.github.com/repos/owncloud/user_ldap/labels/p3-medium","name":"p3-medium","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"tomneedham","id":660805,"node_id":"MDQ6VXNlcjY2MDgwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/660805?v=4","gravatar_id":"","url":"https://api.github.com/users/tomneedham","html_url":"https://github.com/tomneedham","followers_url":"https://api.github.com/users/tomneedham/followers","following_url":"https://api.github.com/users/tomneedham/following{/other_user}","gists_url":"https://api.github.com/users/tomneedham/gists{/gist_id}","starred_url":"https://api.github.com/users/tomneedham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomneedham/subscriptions","organizations_url":"https://api.github.com/users/tomneedham/orgs","repos_url":"https://api.github.com/users/tomneedham/repos","events_url":"https://api.github.com/users/tomneedham/events{/privacy}","received_events_url":"https://api.github.com/users/tomneedham/received_events","type":"User","site_admin":false},"assignees":[{"login":"tomneedham","id":660805,"node_id":"MDQ6VXNlcjY2MDgwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/660805?v=4","gravatar_id":"","url":"https://api.github.com/users/tomneedham","html_url":"https://github.com/tomneedham","followers_url":"https://api.github.com/users/tomneedham/followers","following_url":"https://api.github.com/users/tomneedham/following{/other_user}","gists_url":"https://api.github.com/users/tomneedham/gists{/gist_id}","starred_url":"https://api.github.com/users/tomneedham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomneedham/subscriptions","organizations_url":"https://api.github.com/users/tomneedham/orgs","repos_url":"https://api.github.com/users/tomneedham/repos","events_url":"https://api.github.com/users/tomneedham/events{/privacy}","received_events_url":"https://api.github.com/users/tomneedham/received_events","type":"User","site_admin":false},{"login":"butonic","id":956847,"node_id":"MDQ6VXNlcjk1Njg0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/956847?v=4","gravatar_id":"","url":"https://api.github.com/users/butonic","html_url":"https://github.com/butonic","followers_url":"https://api.github.com/users/butonic/followers","following_url":"https://api.github.com/users/butonic/following{/other_user}","gists_url":"https://api.github.com/users/butonic/gists{/gist_id}","starred_url":"https://api.github.com/users/butonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/butonic/subscriptions","organizations_url":"https://api.github.com/users/butonic/orgs","repos_url":"https://api.github.com/users/butonic/repos","events_url":"https://api.github.com/users/butonic/events{/privacy}","received_events_url":"https://api.github.com/users/butonic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-06-06T14:02:24Z","updated_at":"2018-07-02T14:47:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/owncloud/user_ldap/pulls/248","html_url":"https://github.com/owncloud/user_ldap/pull/248","diff_url":"https://github.com/owncloud/user_ldap/pull/248.diff","patch_url":"https://github.com/owncloud/user_ldap/pull/248.patch"},"body":"We identified an issue with group memberships when using special characters in the DN AND using `member` attribute for memberships. The DN is then used as an attribute value in a LDAP search filter and is not properly escaped, resulting in an empty response from LDAP. \r\n\r\n`dn2ocname` and `resolveUID` are both called to find a user based on DN, but only one sanitizes the DN. This often results in the DN being changed in the table, depending on the code path / query requested. \r\n\r\nThis results in the memberships for a user sometimes being cached as empty. "},"comment":{"url":"https://api.github.com/repos/owncloud/user_ldap/issues/comments/401830612","html_url":"https://github.com/owncloud/user_ldap/pull/248#issuecomment-401830612","issue_url":"https://api.github.com/repos/owncloud/user_ldap/issues/248","id":401830612,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTgzMDYxMg==","user":{"login":"butonic","id":956847,"node_id":"MDQ6VXNlcjk1Njg0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/956847?v=4","gravatar_id":"","url":"https://api.github.com/users/butonic","html_url":"https://github.com/butonic","followers_url":"https://api.github.com/users/butonic/followers","following_url":"https://api.github.com/users/butonic/following{/other_user}","gists_url":"https://api.github.com/users/butonic/gists{/gist_id}","starred_url":"https://api.github.com/users/butonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/butonic/subscriptions","organizations_url":"https://api.github.com/users/butonic/orgs","repos_url":"https://api.github.com/users/butonic/repos","events_url":"https://api.github.com/users/butonic/events{/privacy}","received_events_url":"https://api.github.com/users/butonic/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T14:47:58Z","updated_at":"2018-07-02T14:47:58Z","author_association":"MEMBER","body":"@tom @jvillafanez rebased, added legacy dn fallback that can be disabled via appconfig. please review"}}
{"actor":{"display_login":"butonic"}}