{"action":"created","issue":{"url":"https://api.github.com/repos/VSCodium/vscodium/issues/27","repository_url":"https://api.github.com/repos/VSCodium/vscodium","labels_url":"https://api.github.com/repos/VSCodium/vscodium/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/VSCodium/vscodium/issues/27/comments","events_url":"https://api.github.com/repos/VSCodium/vscodium/issues/27/events","html_url":"https://github.com/VSCodium/vscodium/pull/27","id":365961063,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzUyNzM3","number":27,"title":"Undo telemetry before build","user":{"login":"stripedpajamas","id":2707340,"node_id":"MDQ6VXNlcjI3MDczNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2707340?v=4","gravatar_id":"","url":"https://api.github.com/users/stripedpajamas","html_url":"https://github.com/stripedpajamas","followers_url":"https://api.github.com/users/stripedpajamas/followers","following_url":"https://api.github.com/users/stripedpajamas/following{/other_user}","gists_url":"https://api.github.com/users/stripedpajamas/gists{/gist_id}","starred_url":"https://api.github.com/users/stripedpajamas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripedpajamas/subscriptions","organizations_url":"https://api.github.com/users/stripedpajamas/orgs","repos_url":"https://api.github.com/users/stripedpajamas/repos","events_url":"https://api.github.com/users/stripedpajamas/events{/privacy}","received_events_url":"https://api.github.com/users/stripedpajamas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-02T15:44:07Z","updated_at":"2018-10-04T14:42:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/VSCodium/vscodium/pulls/27","html_url":"https://github.com/VSCodium/vscodium/pull/27","diff_url":"https://github.com/VSCodium/vscodium/pull/27.diff","patch_url":"https://github.com/VSCodium/vscodium/pull/27.patch"},"body":"Fix #26 \r\n\r\nReplaces telemetry endpoints with 0.0.0.0. I tested that this does not mess up the build, and [Little Snitch](https://www.obdev.at/products/littlesnitch/index.html) shows no outgoing traffic from the binary after opening (unless I go to the Marketplace, but that is expected behavior)."},"comment":{"url":"https://api.github.com/repos/VSCodium/vscodium/issues/comments/427045414","html_url":"https://github.com/VSCodium/vscodium/pull/27#issuecomment-427045414","issue_url":"https://api.github.com/repos/VSCodium/vscodium/issues/27","id":427045414,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzA0NTQxNA==","user":{"login":"stripedpajamas","id":2707340,"node_id":"MDQ6VXNlcjI3MDczNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2707340?v=4","gravatar_id":"","url":"https://api.github.com/users/stripedpajamas","html_url":"https://github.com/stripedpajamas","followers_url":"https://api.github.com/users/stripedpajamas/followers","following_url":"https://api.github.com/users/stripedpajamas/following{/other_user}","gists_url":"https://api.github.com/users/stripedpajamas/gists{/gist_id}","starred_url":"https://api.github.com/users/stripedpajamas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripedpajamas/subscriptions","organizations_url":"https://api.github.com/users/stripedpajamas/orgs","repos_url":"https://api.github.com/users/stripedpajamas/repos","events_url":"https://api.github.com/users/stripedpajamas/events{/privacy}","received_events_url":"https://api.github.com/users/stripedpajamas/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T14:42:00Z","updated_at":"2018-10-04T14:42:00Z","author_association":"CONTRIBUTOR","body":"After @paulcarroty commented in #26 about using a regex I started wondering why we would go the patch route. Using the regex means that if MS adds another dependency that hits either of these URLs, we will still end up stripping it out. Using the patch file means we would have to a) notice the addition, and b) update the patch file. Thoughts @em92 @JL2210 ? I am inclined to revert back to `grep | sed`"}}
{"actor":{"display_login":"stripedpajamas"}}