{"action":"created","issue":{"url":"https://api.github.com/repos/gitgitgadget/git/issues/88","repository_url":"https://api.github.com/repos/gitgitgadget/git","labels_url":"https://api.github.com/repos/gitgitgadget/git/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/gitgitgadget/git/issues/88/comments","events_url":"https://api.github.com/repos/gitgitgadget/git/issues/88/events","html_url":"https://github.com/gitgitgadget/git/pull/88","id":384737445,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODY1ODc4","number":88,"title":"Fix `git rebase --stat -i <unrelated-history>`","user":{"login":"dscho","id":127790,"node_id":"MDQ6VXNlcjEyNzc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/127790?v=4","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-27T10:58:15Z","updated_at":"2018-11-29T12:59:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gitgitgadget/git/pulls/88","html_url":"https://github.com/gitgitgadget/git/pull/88","diff_url":"https://github.com/gitgitgadget/git/pull/88.diff","patch_url":"https://github.com/gitgitgadget/git/pull/88.patch"},"body":"We're really entering obscure territory here, I would say.\r\n\r\nTo trigger the bug, two things have to come together: the user must have asked for a diffstat afterwards, and the commits need to have been rebased onto a completely unrelated commit history (i.e. there must exist no merge base between the pre-rebase `HEAD` and the post-rebase `HEAD`).\r\n\r\nPlease note that this bug existed already in the scripted rebase, but it was never detected because the scripted version would not even perform any error checking.\r\n\r\nIt will make Junio very happy that I squashed the regression test in to the patch that fixes it. The reason, however, was not to make Junio happy (I hope to make him happy by fixing bugs), but simply that an earlier iteration of test would only fail with the built-in rebase, but not with the scripted version. The current version *would* fail with the scripted version, but I'll save the time to split the patch again now.\r\n\r\nChanges since v1:\r\n- The commit message now talks more about what we should do in case that there is no merge base, rather than stressing the differences between the way scripted vs built-in rebase handled it (both buggy, and fixed by this patch).\r\n- In case that there is no merge base, it no longer reports \"Changes from (empty) to ...\" but \"Changes to ...\", which should be a lot less controversial."},"comment":{"url":"https://api.github.com/repos/gitgitgadget/git/issues/comments/442824649","html_url":"https://github.com/gitgitgadget/git/pull/88#issuecomment-442824649","issue_url":"https://api.github.com/repos/gitgitgadget/git/issues/88","id":442824649,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjgyNDY0OQ==","user":{"login":"dscho","id":127790,"node_id":"MDQ6VXNlcjEyNzc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/127790?v=4","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T12:59:03Z","updated_at":"2018-11-29T12:59:03Z","author_association":"NONE","body":"/submit"}}
{"actor":{"display_login":"dscho"}}