{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/232845559","pull_request_review_id":174134889,"id":232845559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjg0NTU1OQ==","diff_hunk":"@@ -237,6 +237,16 @@ bool TeamMgr::checkPortIffUp(const string &port)\n     return ifr.ifr_flags & IFF_UP;\n }\n \n+bool TeamMgr::checkKernelPortMaster(const string &port)\n+{\n+    SWSS_LOG_ENTER();\n+\n+    string cmd = \"ls /sys/class/net/\" + port + \"/master\";","path":"cfgmgr/teammgr.cpp","position":8,"original_position":8,"commit_id":"234a49644d82aff6b54db2fe4c5ac162088c5429","original_commit_id":"234a49644d82aff6b54db2fe4c5ac162088c5429","user":{"login":"qiluo-msft","id":11406616,"node_id":"MDQ6VXNlcjExNDA2NjE2","avatar_url":"https://avatars1.githubusercontent.com/u/11406616?v=4","gravatar_id":"","url":"https://api.github.com/users/qiluo-msft","html_url":"https://github.com/qiluo-msft","followers_url":"https://api.github.com/users/qiluo-msft/followers","following_url":"https://api.github.com/users/qiluo-msft/following{/other_user}","gists_url":"https://api.github.com/users/qiluo-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/qiluo-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiluo-msft/subscriptions","organizations_url":"https://api.github.com/users/qiluo-msft/orgs","repos_url":"https://api.github.com/users/qiluo-msft/repos","events_url":"https://api.github.com/users/qiluo-msft/events{/privacy}","received_events_url":"https://api.github.com/users/qiluo-msft/received_events","type":"User","site_admin":false},"body":"Do you intend to check the file existing?","created_at":"2018-11-12T23:18:47Z","updated_at":"2018-11-12T23:18:47Z","html_url":"https://github.com/Azure/sonic-swss/pull/681#discussion_r232845559","pull_request_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/681","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/232845559"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/681#discussion_r232845559"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/681"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/681","id":230298076,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjk4MDc2","html_url":"https://github.com/Azure/sonic-swss/pull/681","diff_url":"https://github.com/Azure/sonic-swss/pull/681.diff","patch_url":"https://github.com/Azure/sonic-swss/pull/681.patch","issue_url":"https://api.github.com/repos/Azure/sonic-swss/issues/681","number":681,"state":"open","locked":false,"title":"[teammgrd]: Add kernel master check for port before enslaving","user":{"login":"stcheng","id":2702699,"node_id":"MDQ6VXNlcjI3MDI2OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2702699?v=4","gravatar_id":"","url":"https://api.github.com/users/stcheng","html_url":"https://github.com/stcheng","followers_url":"https://api.github.com/users/stcheng/followers","following_url":"https://api.github.com/users/stcheng/following{/other_user}","gists_url":"https://api.github.com/users/stcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/stcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stcheng/subscriptions","organizations_url":"https://api.github.com/users/stcheng/orgs","repos_url":"https://api.github.com/users/stcheng/repos","events_url":"https://api.github.com/users/stcheng/events{/privacy}","received_events_url":"https://api.github.com/users/stcheng/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-12T23:15:29Z","updated_at":"2018-11-12T23:18:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bb61528d8467469967f75c50ec05c5294b5e131","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/681/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/681/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/issues/681/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/234a49644d82aff6b54db2fe4c5ac162088c5429","head":{"label":"stcheng:team","ref":"team","sha":"234a49644d82aff6b54db2fe4c5ac162088c5429","user":{"login":"stcheng","id":2702699,"node_id":"MDQ6VXNlcjI3MDI2OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2702699?v=4","gravatar_id":"","url":"https://api.github.com/users/stcheng","html_url":"https://github.com/stcheng","followers_url":"https://api.github.com/users/stcheng/followers","following_url":"https://api.github.com/users/stcheng/following{/other_user}","gists_url":"https://api.github.com/users/stcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/stcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stcheng/subscriptions","organizations_url":"https://api.github.com/users/stcheng/orgs","repos_url":"https://api.github.com/users/stcheng/repos","events_url":"https://api.github.com/users/stcheng/events{/privacy}","received_events_url":"https://api.github.com/users/stcheng/received_events","type":"User","site_admin":false},"repo":{"id":53697552,"node_id":"MDEwOlJlcG9zaXRvcnk1MzY5NzU1Mg==","name":"sonic-swss","full_name":"stcheng/sonic-swss","private":false,"owner":{"login":"stcheng","id":2702699,"node_id":"MDQ6VXNlcjI3MDI2OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2702699?v=4","gravatar_id":"","url":"https://api.github.com/users/stcheng","html_url":"https://github.com/stcheng","followers_url":"https://api.github.com/users/stcheng/followers","following_url":"https://api.github.com/users/stcheng/following{/other_user}","gists_url":"https://api.github.com/users/stcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/stcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stcheng/subscriptions","organizations_url":"https://api.github.com/users/stcheng/orgs","repos_url":"https://api.github.com/users/stcheng/repos","events_url":"https://api.github.com/users/stcheng/events{/privacy}","received_events_url":"https://api.github.com/users/stcheng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stcheng/sonic-swss","description":"SONiC - Switch State Service - SwSS","fork":true,"url":"https://api.github.com/repos/stcheng/sonic-swss","forks_url":"https://api.github.com/repos/stcheng/sonic-swss/forks","keys_url":"https://api.github.com/repos/stcheng/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stcheng/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stcheng/sonic-swss/teams","hooks_url":"https://api.github.com/repos/stcheng/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/stcheng/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/stcheng/sonic-swss/events","assignees_url":"https://api.github.com/repos/stcheng/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/stcheng/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/stcheng/sonic-swss/tags","blobs_url":"https://api.github.com/repos/stcheng/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stcheng/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stcheng/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/stcheng/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stcheng/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/stcheng/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/stcheng/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/stcheng/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/stcheng/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/stcheng/sonic-swss/subscription","commits_url":"https://api.github.com/repos/stcheng/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/stcheng/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/stcheng/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/stcheng/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/stcheng/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/stcheng/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stcheng/sonic-swss/merges","archive_url":"https://api.github.com/repos/stcheng/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stcheng/sonic-swss/downloads","issues_url":"https://api.github.com/repos/stcheng/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/stcheng/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/stcheng/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/stcheng/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stcheng/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/stcheng/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/stcheng/sonic-swss/deployments","created_at":"2016-03-11T21:23:42Z","updated_at":"2017-03-25T11:56:09Z","pushed_at":"2018-11-12T23:15:17Z","git_url":"git://github.com/stcheng/sonic-swss.git","ssh_url":"git@github.com:stcheng/sonic-swss.git","clone_url":"https://github.com/stcheng/sonic-swss.git","svn_url":"https://github.com/stcheng/sonic-swss","homepage":"","size":2118,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"dc2ff7722fcfc4a95039e379bd8d6135bf7292fe","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53515475,"node_id":"MDEwOlJlcG9zaXRvcnk1MzUxNTQ3NQ==","name":"sonic-swss","full_name":"Azure/sonic-swss","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/sonic-swss","description":"SONiC Switch State Service (SwSS)","fork":false,"url":"https://api.github.com/repos/Azure/sonic-swss","forks_url":"https://api.github.com/repos/Azure/sonic-swss/forks","keys_url":"https://api.github.com/repos/Azure/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-swss/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-swss/events","assignees_url":"https://api.github.com/repos/Azure/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-swss/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-swss/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-swss/merges","archive_url":"https://api.github.com/repos/Azure/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-swss/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-swss/deployments","created_at":"2016-03-09T17:01:09Z","updated_at":"2018-11-12T22:08:27Z","pushed_at":"2018-11-12T23:15:30Z","git_url":"git://github.com/Azure/sonic-swss.git","ssh_url":"git@github.com:Azure/sonic-swss.git","clone_url":"https://github.com/Azure/sonic-swss.git","svn_url":"https://github.com/Azure/sonic-swss","homepage":"https://azure.github.io/SONiC","size":2147,"stargazers_count":36,"watchers_count":36,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":75,"open_issues":67,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/681"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/681"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/681"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-swss/statuses/234a49644d82aff6b54db2fe4c5ac162088c5429"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"qiluo-msft"}}