{"action":"created","comment":{"url":"https://api.github.com/repos/4Catalyzer/found/pulls/comments/236026367","pull_request_review_id":178033350,"id":236026367,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAyNjM2Nw==","diff_hunk":"@@ -686,59 +646,43 @@ ReactDOM.render(\n \n The options object for `createFarceRouter` should have a `historyProtocol` property that has a history protocol object. For example, to use the HTML History API as with `createBrowserRouter`, you would provide `new BrowserProtocol()`.\n \n-The `createFarceRouter` options object does not have a default for the `render` property. It ignores the `renderPending`, `renderReady`, and `renderError` properties.\n-\n The created `<FarceRouter>` manages setting up and providing a Redux store with the appropriate configuration internally. It also requires a `resolver` prop with the route element resolver object. For routes configured as above, this should be the `resolver` object in this library.\n \n #### `createConnectedRouter`\n \n `createConnectedRouter` creates a router that works with an existing Redux store and provider.\n \n ```js\n-import {\n-  Actions as FarceActions,\n-  BrowserProtocol,\n-  createHistoryEnhancer,\n-  queryMiddleware,\n-} from 'farce';\n+import { BrowserProtocol, queryMiddleware } from 'farce';\n import {\n   createConnectedRouter,\n-  createMatchEnhancer,\n-  createRender,\n+  createFoundEnhancer,\n   foundReducer,\n-  Matcher,\n   resolver,\n } from 'found';\n import { Provider } from 'react-redux';\n-import { combineReducers, compose, createStore } from 'redux';\n+import { combineReducers, createStore } from 'redux';\n \n /* ... */\n \n const store = createStore(\n   combineReducers({\n     found: foundReducer,\n   }),\n-  compose(\n-    createHistoryEnhancer({\n-      protocol: new BrowserProtocol(),\n-      middlewares: [queryMiddleware],\n-    }),\n-    createMatchEnhancer(\n-      new Matcher(routeConfig, { matchStemRoutes: false }),\n-    ),\n-  ),\n+  createFoundEnhancer({\n+    routeConfig,\n+    matchOptions: { matchStemRoutes: false },\n+    historyProtocol: new BrowserProtocol(),\n+    historyMiddlewares: [queryMiddleware],\n+  }),\n );\n \n-store.dispatch(FarceActions.init());\n+store.startRouting();","path":"README.md","position":523,"original_position":523,"commit_id":"99db347d01314ff04d8d457046f19414fcc86cfd","original_commit_id":"99db347d01314ff04d8d457046f19414fcc86cfd","user":{"login":"taion","id":3112159,"node_id":"MDQ6VXNlcjMxMTIxNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3112159?v=4","gravatar_id":"","url":"https://api.github.com/users/taion","html_url":"https://github.com/taion","followers_url":"https://api.github.com/users/taion/followers","following_url":"https://api.github.com/users/taion/following{/other_user}","gists_url":"https://api.github.com/users/taion/gists{/gist_id}","starred_url":"https://api.github.com/users/taion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taion/subscriptions","organizations_url":"https://api.github.com/users/taion/orgs","repos_url":"https://api.github.com/users/taion/repos","events_url":"https://api.github.com/users/taion/events{/privacy}","received_events_url":"https://api.github.com/users/taion/received_events","type":"User","site_admin":false},"body":"i mean, i dunno... i think dispatching an action is pretty idiomatic. in this case that's all that's happening, no? i don't think redux add-ons in general follow this sort of pattern of binding action dispatches as methods onto the store","created_at":"2018-11-23T23:34:43Z","updated_at":"2018-11-23T23:37:22Z","html_url":"https://github.com/4Catalyzer/found/pull/213#discussion_r236026367","pull_request_url":"https://api.github.com/repos/4Catalyzer/found/pulls/213","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/4Catalyzer/found/pulls/comments/236026367"},"html":{"href":"https://github.com/4Catalyzer/found/pull/213#discussion_r236026367"},"pull_request":{"href":"https://api.github.com/repos/4Catalyzer/found/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/4Catalyzer/found/pulls/213","id":232694382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjk0Mzgy","html_url":"https://github.com/4Catalyzer/found/pull/213","diff_url":"https://github.com/4Catalyzer/found/pull/213.diff","patch_url":"https://github.com/4Catalyzer/found/pull/213.patch","issue_url":"https://api.github.com/repos/4Catalyzer/found/issues/213","number":213,"state":"open","locked":false,"title":"fixup ts types and tweak createRouter","user":{"login":"jquense","id":339286,"node_id":"MDQ6VXNlcjMzOTI4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/339286?v=4","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-21T14:59:50Z","updated_at":"2018-11-23T23:37:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e8eaf757a91bcb168951a1e95a2dfe281ff4f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/4Catalyzer/found/pulls/213/commits","review_comments_url":"https://api.github.com/repos/4Catalyzer/found/pulls/213/comments","review_comment_url":"https://api.github.com/repos/4Catalyzer/found/pulls/comments{/number}","comments_url":"https://api.github.com/repos/4Catalyzer/found/issues/213/comments","statuses_url":"https://api.github.com/repos/4Catalyzer/found/statuses/99db347d01314ff04d8d457046f19414fcc86cfd","head":{"label":"4Catalyzer:qol","ref":"qol","sha":"99db347d01314ff04d8d457046f19414fcc86cfd","user":{"login":"4Catalyzer","id":13967986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY3OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/13967986?v=4","gravatar_id":"","url":"https://api.github.com/users/4Catalyzer","html_url":"https://github.com/4Catalyzer","followers_url":"https://api.github.com/users/4Catalyzer/followers","following_url":"https://api.github.com/users/4Catalyzer/following{/other_user}","gists_url":"https://api.github.com/users/4Catalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/4Catalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4Catalyzer/subscriptions","organizations_url":"https://api.github.com/users/4Catalyzer/orgs","repos_url":"https://api.github.com/users/4Catalyzer/repos","events_url":"https://api.github.com/users/4Catalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/4Catalyzer/received_events","type":"Organization","site_admin":false},"repo":{"id":66730332,"node_id":"MDEwOlJlcG9zaXRvcnk2NjczMDMzMg==","name":"found","full_name":"4Catalyzer/found","private":false,"owner":{"login":"4Catalyzer","id":13967986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY3OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/13967986?v=4","gravatar_id":"","url":"https://api.github.com/users/4Catalyzer","html_url":"https://github.com/4Catalyzer","followers_url":"https://api.github.com/users/4Catalyzer/followers","following_url":"https://api.github.com/users/4Catalyzer/following{/other_user}","gists_url":"https://api.github.com/users/4Catalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/4Catalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4Catalyzer/subscriptions","organizations_url":"https://api.github.com/users/4Catalyzer/orgs","repos_url":"https://api.github.com/users/4Catalyzer/repos","events_url":"https://api.github.com/users/4Catalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/4Catalyzer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/4Catalyzer/found","description":"Extensible route-based routing for React applications","fork":false,"url":"https://api.github.com/repos/4Catalyzer/found","forks_url":"https://api.github.com/repos/4Catalyzer/found/forks","keys_url":"https://api.github.com/repos/4Catalyzer/found/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4Catalyzer/found/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4Catalyzer/found/teams","hooks_url":"https://api.github.com/repos/4Catalyzer/found/hooks","issue_events_url":"https://api.github.com/repos/4Catalyzer/found/issues/events{/number}","events_url":"https://api.github.com/repos/4Catalyzer/found/events","assignees_url":"https://api.github.com/repos/4Catalyzer/found/assignees{/user}","branches_url":"https://api.github.com/repos/4Catalyzer/found/branches{/branch}","tags_url":"https://api.github.com/repos/4Catalyzer/found/tags","blobs_url":"https://api.github.com/repos/4Catalyzer/found/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4Catalyzer/found/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4Catalyzer/found/git/refs{/sha}","trees_url":"https://api.github.com/repos/4Catalyzer/found/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4Catalyzer/found/statuses/{sha}","languages_url":"https://api.github.com/repos/4Catalyzer/found/languages","stargazers_url":"https://api.github.com/repos/4Catalyzer/found/stargazers","contributors_url":"https://api.github.com/repos/4Catalyzer/found/contributors","subscribers_url":"https://api.github.com/repos/4Catalyzer/found/subscribers","subscription_url":"https://api.github.com/repos/4Catalyzer/found/subscription","commits_url":"https://api.github.com/repos/4Catalyzer/found/commits{/sha}","git_commits_url":"https://api.github.com/repos/4Catalyzer/found/git/commits{/sha}","comments_url":"https://api.github.com/repos/4Catalyzer/found/comments{/number}","issue_comment_url":"https://api.github.com/repos/4Catalyzer/found/issues/comments{/number}","contents_url":"https://api.github.com/repos/4Catalyzer/found/contents/{+path}","compare_url":"https://api.github.com/repos/4Catalyzer/found/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4Catalyzer/found/merges","archive_url":"https://api.github.com/repos/4Catalyzer/found/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4Catalyzer/found/downloads","issues_url":"https://api.github.com/repos/4Catalyzer/found/issues{/number}","pulls_url":"https://api.github.com/repos/4Catalyzer/found/pulls{/number}","milestones_url":"https://api.github.com/repos/4Catalyzer/found/milestones{/number}","notifications_url":"https://api.github.com/repos/4Catalyzer/found/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4Catalyzer/found/labels{/name}","releases_url":"https://api.github.com/repos/4Catalyzer/found/releases{/id}","deployments_url":"https://api.github.com/repos/4Catalyzer/found/deployments","created_at":"2016-08-27T18:48:57Z","updated_at":"2018-11-22T02:14:51Z","pushed_at":"2018-11-21T16:12:12Z","git_url":"git://github.com/4Catalyzer/found.git","ssh_url":"git@github.com:4Catalyzer/found.git","clone_url":"https://github.com/4Catalyzer/found.git","svn_url":"https://github.com/4Catalyzer/found","homepage":"","size":803,"stargazers_count":535,"watchers_count":535,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":17,"watchers":535,"default_branch":"master"}},"base":{"label":"4Catalyzer:master","ref":"master","sha":"ca594e7d1800ac7d45ab6e82fd1a7b994945c964","user":{"login":"4Catalyzer","id":13967986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY3OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/13967986?v=4","gravatar_id":"","url":"https://api.github.com/users/4Catalyzer","html_url":"https://github.com/4Catalyzer","followers_url":"https://api.github.com/users/4Catalyzer/followers","following_url":"https://api.github.com/users/4Catalyzer/following{/other_user}","gists_url":"https://api.github.com/users/4Catalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/4Catalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4Catalyzer/subscriptions","organizations_url":"https://api.github.com/users/4Catalyzer/orgs","repos_url":"https://api.github.com/users/4Catalyzer/repos","events_url":"https://api.github.com/users/4Catalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/4Catalyzer/received_events","type":"Organization","site_admin":false},"repo":{"id":66730332,"node_id":"MDEwOlJlcG9zaXRvcnk2NjczMDMzMg==","name":"found","full_name":"4Catalyzer/found","private":false,"owner":{"login":"4Catalyzer","id":13967986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY3OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/13967986?v=4","gravatar_id":"","url":"https://api.github.com/users/4Catalyzer","html_url":"https://github.com/4Catalyzer","followers_url":"https://api.github.com/users/4Catalyzer/followers","following_url":"https://api.github.com/users/4Catalyzer/following{/other_user}","gists_url":"https://api.github.com/users/4Catalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/4Catalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4Catalyzer/subscriptions","organizations_url":"https://api.github.com/users/4Catalyzer/orgs","repos_url":"https://api.github.com/users/4Catalyzer/repos","events_url":"https://api.github.com/users/4Catalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/4Catalyzer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/4Catalyzer/found","description":"Extensible route-based routing for React applications","fork":false,"url":"https://api.github.com/repos/4Catalyzer/found","forks_url":"https://api.github.com/repos/4Catalyzer/found/forks","keys_url":"https://api.github.com/repos/4Catalyzer/found/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4Catalyzer/found/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4Catalyzer/found/teams","hooks_url":"https://api.github.com/repos/4Catalyzer/found/hooks","issue_events_url":"https://api.github.com/repos/4Catalyzer/found/issues/events{/number}","events_url":"https://api.github.com/repos/4Catalyzer/found/events","assignees_url":"https://api.github.com/repos/4Catalyzer/found/assignees{/user}","branches_url":"https://api.github.com/repos/4Catalyzer/found/branches{/branch}","tags_url":"https://api.github.com/repos/4Catalyzer/found/tags","blobs_url":"https://api.github.com/repos/4Catalyzer/found/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4Catalyzer/found/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4Catalyzer/found/git/refs{/sha}","trees_url":"https://api.github.com/repos/4Catalyzer/found/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4Catalyzer/found/statuses/{sha}","languages_url":"https://api.github.com/repos/4Catalyzer/found/languages","stargazers_url":"https://api.github.com/repos/4Catalyzer/found/stargazers","contributors_url":"https://api.github.com/repos/4Catalyzer/found/contributors","subscribers_url":"https://api.github.com/repos/4Catalyzer/found/subscribers","subscription_url":"https://api.github.com/repos/4Catalyzer/found/subscription","commits_url":"https://api.github.com/repos/4Catalyzer/found/commits{/sha}","git_commits_url":"https://api.github.com/repos/4Catalyzer/found/git/commits{/sha}","comments_url":"https://api.github.com/repos/4Catalyzer/found/comments{/number}","issue_comment_url":"https://api.github.com/repos/4Catalyzer/found/issues/comments{/number}","contents_url":"https://api.github.com/repos/4Catalyzer/found/contents/{+path}","compare_url":"https://api.github.com/repos/4Catalyzer/found/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4Catalyzer/found/merges","archive_url":"https://api.github.com/repos/4Catalyzer/found/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4Catalyzer/found/downloads","issues_url":"https://api.github.com/repos/4Catalyzer/found/issues{/number}","pulls_url":"https://api.github.com/repos/4Catalyzer/found/pulls{/number}","milestones_url":"https://api.github.com/repos/4Catalyzer/found/milestones{/number}","notifications_url":"https://api.github.com/repos/4Catalyzer/found/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4Catalyzer/found/labels{/name}","releases_url":"https://api.github.com/repos/4Catalyzer/found/releases{/id}","deployments_url":"https://api.github.com/repos/4Catalyzer/found/deployments","created_at":"2016-08-27T18:48:57Z","updated_at":"2018-11-22T02:14:51Z","pushed_at":"2018-11-21T16:12:12Z","git_url":"git://github.com/4Catalyzer/found.git","ssh_url":"git@github.com:4Catalyzer/found.git","clone_url":"https://github.com/4Catalyzer/found.git","svn_url":"https://github.com/4Catalyzer/found","homepage":"","size":803,"stargazers_count":535,"watchers_count":535,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":17,"watchers":535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/4Catalyzer/found/pulls/213"},"html":{"href":"https://github.com/4Catalyzer/found/pull/213"},"issue":{"href":"https://api.github.com/repos/4Catalyzer/found/issues/213"},"comments":{"href":"https://api.github.com/repos/4Catalyzer/found/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/4Catalyzer/found/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/4Catalyzer/found/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/4Catalyzer/found/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/4Catalyzer/found/statuses/99db347d01314ff04d8d457046f19414fcc86cfd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"taion"}}