{"action":"created","comment":{"url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments/212540829","pull_request_review_id":149191369,"id":212540829,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjU0MDgyOQ==","diff_hunk":"@@ -99,68 +116,30 @@ export const resetPasswordAccount = (wallet, mnemonic, password) => async (dispa\n \n }\n \n-export const createAccount = ({ name, password, privateKey, mnemonic, numberOfAccounts = 0, types = {} }) => async (dispatch) => {\n-  let hex = ''\n-\n-  if (privateKey){\n-    hex = `0x${privateKey}`\n-  }\n-\n-  if (mnemonic){\n-    const hdKeyWallet = hdkey.fromMasterSeed(bip39.mnemonicToSeed(mnemonic)).derivePath(WALLET_HD_PATH).getWallet()\n-    hex = hdKeyWallet.getPrivateKeyString()\n-  }\n-\n-  const accounts = new Accounts()\n-\n-  const wallet = await accounts.wallet.create(numberOfAccounts)\n-  const account = accounts.privateKeyToAccount(hex)\n-  wallet.add(account)\n+export const createAccount = ({ name, wallet, type }) => async (dispatch) => {\n \n   const entry = new AccountEntryModel({\n     key: uuid(),\n     name,\n-    types,\n-    encrypted: wallet && wallet.encrypt(password),\n+    type,\n+    encrypted: [wallet],\n     profile: null,\n   })\n \n+  console.log(entry)\n   const newAccounts = await dispatch(setProfilesForAccounts([entry]))\n-\n+  console.log(newAccounts)\n   return newAccounts[0] || entry\n \n }\n \n-export const createHWAccount = ({ name, password, privateKey, mnemonic, numberOfAccounts = 0, types = {} }) => async (dispatch) => {\n-  let hex = ''\n-\n-  if (privateKey){\n-    hex = `0x${privateKey}`\n-  }\n-\n-  if (mnemonic){\n-    const hdKeyWallet = hdkey.fromMasterSeed(bip39.mnemonicToSeed(mnemonic)).derivePath(WALLET_HD_PATH).getWallet()\n-    hex = hdKeyWallet.getPrivateKeyString()\n-  }\n-\n-  const accounts = new Accounts()\n-  accounts.wallet.clear()\n-\n-  const wallet = await accounts.wallet.create(numberOfAccounts)\n-  const account = accounts.privateKeyToAccount(hex)\n-  wallet.add(account)\n-\n-  const entry = new AccountEntryModel({\n-    key: uuid(),\n-    name,\n-    types,\n-    encrypted: wallet && wallet.encrypt(password),\n-    profile: null,\n-  })\n-\n-  const newAccounts = await dispatch(setProfilesForAccounts([entry]))\n-\n-  return newAccounts[0] || entry\n+export const createMemoryAccount = ({name, password, mnemonic, privateKey}) => async (dispatch) => {\n+  const wallet = await EthereumMemoryDevice.create({ privateKey, mnemonic, password })\n+  console.log('create account')\n+  console.log(wallet)\n+  const account = await dispatch(createAccount({name, wallet, type: 'memory'}))\n+  console.log(account)","path":"packages/core/redux/persistAccount/actions.js","position":145,"original_position":145,"commit_id":"ca6f7d5de4b133755aa6e3bd040855cd61e14b8c","original_commit_id":"ca6f7d5de4b133755aa6e3bd040855cd61e14b8c","user":{"login":"wAISw","id":5791100,"node_id":"MDQ6VXNlcjU3OTExMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5791100?v=4","gravatar_id":"","url":"https://api.github.com/users/wAISw","html_url":"https://github.com/wAISw","followers_url":"https://api.github.com/users/wAISw/followers","following_url":"https://api.github.com/users/wAISw/following{/other_user}","gists_url":"https://api.github.com/users/wAISw/gists{/gist_id}","starred_url":"https://api.github.com/users/wAISw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wAISw/subscriptions","organizations_url":"https://api.github.com/users/wAISw/orgs","repos_url":"https://api.github.com/users/wAISw/repos","events_url":"https://api.github.com/users/wAISw/events{/privacy}","received_events_url":"https://api.github.com/users/wAISw/received_events","type":"User","site_admin":false},"body":"Please, remove console.log","created_at":"2018-08-24T07:19:08Z","updated_at":"2018-08-24T07:40:32Z","html_url":"https://github.com/ChronoBank/ChronoMint/pull/769#discussion_r212540829","pull_request_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments/212540829"},"html":{"href":"https://github.com/ChronoBank/ChronoMint/pull/769#discussion_r212540829"},"pull_request":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769"}}},"pull_request":{"url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769","id":210402579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDAyNTc5","html_url":"https://github.com/ChronoBank/ChronoMint/pull/769","diff_url":"https://github.com/ChronoBank/ChronoMint/pull/769.diff","patch_url":"https://github.com/ChronoBank/ChronoMint/pull/769.patch","issue_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/769","number":769,"state":"open","locked":false,"title":"Signers","user":{"login":"Mikefluff","id":127661,"node_id":"MDQ6VXNlcjEyNzY2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127661?v=4","gravatar_id":"","url":"https://api.github.com/users/Mikefluff","html_url":"https://github.com/Mikefluff","followers_url":"https://api.github.com/users/Mikefluff/followers","following_url":"https://api.github.com/users/Mikefluff/following{/other_user}","gists_url":"https://api.github.com/users/Mikefluff/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikefluff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikefluff/subscriptions","organizations_url":"https://api.github.com/users/Mikefluff/orgs","repos_url":"https://api.github.com/users/Mikefluff/repos","events_url":"https://api.github.com/users/Mikefluff/events{/privacy}","received_events_url":"https://api.github.com/users/Mikefluff/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-23T10:32:14Z","updated_at":"2018-08-24T07:40:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f82b6d7f9441a944fefcd3064690587c19924647","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769/commits","review_comments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769/comments","review_comment_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/769/comments","statuses_url":"https://api.github.com/repos/ChronoBank/ChronoMint/statuses/ca6f7d5de4b133755aa6e3bd040855cd61e14b8c","head":{"label":"Mikefluff:Signers","ref":"Signers","sha":"ca6f7d5de4b133755aa6e3bd040855cd61e14b8c","user":{"login":"Mikefluff","id":127661,"node_id":"MDQ6VXNlcjEyNzY2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127661?v=4","gravatar_id":"","url":"https://api.github.com/users/Mikefluff","html_url":"https://github.com/Mikefluff","followers_url":"https://api.github.com/users/Mikefluff/followers","following_url":"https://api.github.com/users/Mikefluff/following{/other_user}","gists_url":"https://api.github.com/users/Mikefluff/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikefluff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikefluff/subscriptions","organizations_url":"https://api.github.com/users/Mikefluff/orgs","repos_url":"https://api.github.com/users/Mikefluff/repos","events_url":"https://api.github.com/users/Mikefluff/events{/privacy}","received_events_url":"https://api.github.com/users/Mikefluff/received_events","type":"User","site_admin":false},"repo":{"id":87374743,"node_id":"MDEwOlJlcG9zaXRvcnk4NzM3NDc0Mw==","name":"ChronoMint","full_name":"Mikefluff/ChronoMint","owner":{"login":"Mikefluff","id":127661,"node_id":"MDQ6VXNlcjEyNzY2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127661?v=4","gravatar_id":"","url":"https://api.github.com/users/Mikefluff","html_url":"https://github.com/Mikefluff","followers_url":"https://api.github.com/users/Mikefluff/followers","following_url":"https://api.github.com/users/Mikefluff/following{/other_user}","gists_url":"https://api.github.com/users/Mikefluff/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikefluff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikefluff/subscriptions","organizations_url":"https://api.github.com/users/Mikefluff/orgs","repos_url":"https://api.github.com/users/Mikefluff/repos","events_url":"https://api.github.com/users/Mikefluff/events{/privacy}","received_events_url":"https://api.github.com/users/Mikefluff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mikefluff/ChronoMint","description":"Control panel for ChronoBank and Labour-Offering Companies.","fork":true,"url":"https://api.github.com/repos/Mikefluff/ChronoMint","forks_url":"https://api.github.com/repos/Mikefluff/ChronoMint/forks","keys_url":"https://api.github.com/repos/Mikefluff/ChronoMint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mikefluff/ChronoMint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mikefluff/ChronoMint/teams","hooks_url":"https://api.github.com/repos/Mikefluff/ChronoMint/hooks","issue_events_url":"https://api.github.com/repos/Mikefluff/ChronoMint/issues/events{/number}","events_url":"https://api.github.com/repos/Mikefluff/ChronoMint/events","assignees_url":"https://api.github.com/repos/Mikefluff/ChronoMint/assignees{/user}","branches_url":"https://api.github.com/repos/Mikefluff/ChronoMint/branches{/branch}","tags_url":"https://api.github.com/repos/Mikefluff/ChronoMint/tags","blobs_url":"https://api.github.com/repos/Mikefluff/ChronoMint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mikefluff/ChronoMint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mikefluff/ChronoMint/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mikefluff/ChronoMint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mikefluff/ChronoMint/statuses/{sha}","languages_url":"https://api.github.com/repos/Mikefluff/ChronoMint/languages","stargazers_url":"https://api.github.com/repos/Mikefluff/ChronoMint/stargazers","contributors_url":"https://api.github.com/repos/Mikefluff/ChronoMint/contributors","subscribers_url":"https://api.github.com/repos/Mikefluff/ChronoMint/subscribers","subscription_url":"https://api.github.com/repos/Mikefluff/ChronoMint/subscription","commits_url":"https://api.github.com/repos/Mikefluff/ChronoMint/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mikefluff/ChronoMint/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mikefluff/ChronoMint/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mikefluff/ChronoMint/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mikefluff/ChronoMint/contents/{+path}","compare_url":"https://api.github.com/repos/Mikefluff/ChronoMint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mikefluff/ChronoMint/merges","archive_url":"https://api.github.com/repos/Mikefluff/ChronoMint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mikefluff/ChronoMint/downloads","issues_url":"https://api.github.com/repos/Mikefluff/ChronoMint/issues{/number}","pulls_url":"https://api.github.com/repos/Mikefluff/ChronoMint/pulls{/number}","milestones_url":"https://api.github.com/repos/Mikefluff/ChronoMint/milestones{/number}","notifications_url":"https://api.github.com/repos/Mikefluff/ChronoMint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mikefluff/ChronoMint/labels{/name}","releases_url":"https://api.github.com/repos/Mikefluff/ChronoMint/releases{/id}","deployments_url":"https://api.github.com/repos/Mikefluff/ChronoMint/deployments","created_at":"2017-04-06T01:57:40Z","updated_at":"2017-04-06T01:57:42Z","pushed_at":"2018-08-23T10:30:35Z","git_url":"git://github.com/Mikefluff/ChronoMint.git","ssh_url":"git@github.com:Mikefluff/ChronoMint.git","clone_url":"https://github.com/Mikefluff/ChronoMint.git","svn_url":"https://github.com/Mikefluff/ChronoMint","homepage":"","size":36242,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ChronoBank:develop","ref":"develop","sha":"fb1478eca4c8ee73973cecbc05f256feba5a53f2","user":{"login":"ChronoBank","id":23405498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDA1NDk4","avatar_url":"https://avatars2.githubusercontent.com/u/23405498?v=4","gravatar_id":"","url":"https://api.github.com/users/ChronoBank","html_url":"https://github.com/ChronoBank","followers_url":"https://api.github.com/users/ChronoBank/followers","following_url":"https://api.github.com/users/ChronoBank/following{/other_user}","gists_url":"https://api.github.com/users/ChronoBank/gists{/gist_id}","starred_url":"https://api.github.com/users/ChronoBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChronoBank/subscriptions","organizations_url":"https://api.github.com/users/ChronoBank/orgs","repos_url":"https://api.github.com/users/ChronoBank/repos","events_url":"https://api.github.com/users/ChronoBank/events{/privacy}","received_events_url":"https://api.github.com/users/ChronoBank/received_events","type":"Organization","site_admin":false},"repo":{"id":73798361,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzc5ODM2MQ==","name":"ChronoMint","full_name":"ChronoBank/ChronoMint","owner":{"login":"ChronoBank","id":23405498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDA1NDk4","avatar_url":"https://avatars2.githubusercontent.com/u/23405498?v=4","gravatar_id":"","url":"https://api.github.com/users/ChronoBank","html_url":"https://github.com/ChronoBank","followers_url":"https://api.github.com/users/ChronoBank/followers","following_url":"https://api.github.com/users/ChronoBank/following{/other_user}","gists_url":"https://api.github.com/users/ChronoBank/gists{/gist_id}","starred_url":"https://api.github.com/users/ChronoBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChronoBank/subscriptions","organizations_url":"https://api.github.com/users/ChronoBank/orgs","repos_url":"https://api.github.com/users/ChronoBank/repos","events_url":"https://api.github.com/users/ChronoBank/events{/privacy}","received_events_url":"https://api.github.com/users/ChronoBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChronoBank/ChronoMint","description":"ChronoBank client","fork":false,"url":"https://api.github.com/repos/ChronoBank/ChronoMint","forks_url":"https://api.github.com/repos/ChronoBank/ChronoMint/forks","keys_url":"https://api.github.com/repos/ChronoBank/ChronoMint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChronoBank/ChronoMint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChronoBank/ChronoMint/teams","hooks_url":"https://api.github.com/repos/ChronoBank/ChronoMint/hooks","issue_events_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/events{/number}","events_url":"https://api.github.com/repos/ChronoBank/ChronoMint/events","assignees_url":"https://api.github.com/repos/ChronoBank/ChronoMint/assignees{/user}","branches_url":"https://api.github.com/repos/ChronoBank/ChronoMint/branches{/branch}","tags_url":"https://api.github.com/repos/ChronoBank/ChronoMint/tags","blobs_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChronoBank/ChronoMint/statuses/{sha}","languages_url":"https://api.github.com/repos/ChronoBank/ChronoMint/languages","stargazers_url":"https://api.github.com/repos/ChronoBank/ChronoMint/stargazers","contributors_url":"https://api.github.com/repos/ChronoBank/ChronoMint/contributors","subscribers_url":"https://api.github.com/repos/ChronoBank/ChronoMint/subscribers","subscription_url":"https://api.github.com/repos/ChronoBank/ChronoMint/subscription","commits_url":"https://api.github.com/repos/ChronoBank/ChronoMint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChronoBank/ChronoMint/contents/{+path}","compare_url":"https://api.github.com/repos/ChronoBank/ChronoMint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChronoBank/ChronoMint/merges","archive_url":"https://api.github.com/repos/ChronoBank/ChronoMint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChronoBank/ChronoMint/downloads","issues_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues{/number}","pulls_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls{/number}","milestones_url":"https://api.github.com/repos/ChronoBank/ChronoMint/milestones{/number}","notifications_url":"https://api.github.com/repos/ChronoBank/ChronoMint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChronoBank/ChronoMint/labels{/name}","releases_url":"https://api.github.com/repos/ChronoBank/ChronoMint/releases{/id}","deployments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/deployments","created_at":"2016-11-15T09:34:13Z","updated_at":"2018-08-21T14:19:30Z","pushed_at":"2018-08-24T07:36:12Z","git_url":"git://github.com/ChronoBank/ChronoMint.git","ssh_url":"git@github.com:ChronoBank/ChronoMint.git","clone_url":"https://github.com/ChronoBank/ChronoMint.git","svn_url":"https://github.com/ChronoBank/ChronoMint","homepage":"https://mint.chronobank.io","size":21033,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":34,"open_issues":7,"watchers":30,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769"},"html":{"href":"https://github.com/ChronoBank/ChronoMint/pull/769"},"issue":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/769"},"comments":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/769/comments"},"review_comments":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769/comments"},"review_comment":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/769/commits"},"statuses":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/statuses/ca6f7d5de4b133755aa6e3bd040855cd61e14b8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wAISw"}}