{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/3526","repository_url":"https://api.github.com/repos/php/php-src","labels_url":"https://api.github.com/repos/php/php-src/issues/3526/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/3526/comments","events_url":"https://api.github.com/repos/php/php-src/issues/3526/events","html_url":"https://github.com/php/php-src/pull/3526","id":360633575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODE5NzQ2","number":3526,"title":"Convert ext/xml to use object instead of resource","user":{"login":"nikic","id":216080,"node_id":"MDQ6VXNlcjIxNjA4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/216080?v=4","gravatar_id":"","url":"https://api.github.com/users/nikic","html_url":"https://github.com/nikic","followers_url":"https://api.github.com/users/nikic/followers","following_url":"https://api.github.com/users/nikic/following{/other_user}","gists_url":"https://api.github.com/users/nikic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikic/subscriptions","organizations_url":"https://api.github.com/users/nikic/orgs","repos_url":"https://api.github.com/users/nikic/repos","events_url":"https://api.github.com/users/nikic/events{/privacy}","received_events_url":"https://api.github.com/users/nikic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-09-16T12:13:07Z","updated_at":"2018-10-12T02:10:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/3526","html_url":"https://github.com/php/php-src/pull/3526","diff_url":"https://github.com/php/php-src/pull/3526.diff","patch_url":"https://github.com/php/php-src/pull/3526.patch"},"body":"The primary motivation here is to fix https://bugs.php.net/bug.php?id=72793 and https://bugs.php.net/bug.php?id=76874, which cannot be done with a resource, as resources are not part of cycle GC.\r\n\r\nThe object is called `XmlParser`. An open question is what `xml_parser_free()` is supposed to do. Right now I've left it as essentially a no-op.\r\n\r\nTargeting PHP 7.4 based on precedent. ext/gmp was converted in 5.6, ext/hash in 7.2, so we seem to be fine with doing these resource->object conversions in minor versions.\r\n\r\n * [x] Implement proper get_gc\r\n * [ ] Forbid explicit construction of the object\r\n * [ ] Decide what to do with xml_parser_free()"},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/429180501","html_url":"https://github.com/php/php-src/pull/3526#issuecomment-429180501","issue_url":"https://api.github.com/repos/php/php-src/issues/3526","id":429180501,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTE4MDUwMQ==","user":{"login":"php-pulls","id":1406938,"node_id":"MDQ6VXNlcjE0MDY5Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1406938?v=4","gravatar_id":"","url":"https://api.github.com/users/php-pulls","html_url":"https://github.com/php-pulls","followers_url":"https://api.github.com/users/php-pulls/followers","following_url":"https://api.github.com/users/php-pulls/following{/other_user}","gists_url":"https://api.github.com/users/php-pulls/gists{/gist_id}","starred_url":"https://api.github.com/users/php-pulls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-pulls/subscriptions","organizations_url":"https://api.github.com/users/php-pulls/orgs","repos_url":"https://api.github.com/users/php-pulls/repos","events_url":"https://api.github.com/users/php-pulls/events{/privacy}","received_events_url":"https://api.github.com/users/php-pulls/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T02:10:54Z","updated_at":"2018-10-12T02:10:54Z","author_association":"NONE","body":"**Comment on behalf of petk at php.net:**\n\nLabelling"}}
{"actor":{"display_login":"php-pulls"}}