{"action":"created","comment":{"url":"https://api.github.com/repos/sveltejs/svelte/pulls/comments/191057189","pull_request_review_id":123565289,"id":191057189,"diff_hunk":"@@ -100,6 +100,10 @@ export default function dom(\n \t\tbuilder.addBlock(compiler.javascript);\n \t}\n \n+\tif (compiler.options.dev) {\n+\t\tbuilder.addLine(`const __file = ${JSON.stringify(compiler.file)};`);","path":"src/compile/dom/index.ts","position":5,"original_position":5,"commit_id":"63a712ccd9e43078697a4f5ffb814f76ab288eef","original_commit_id":"63a712ccd9e43078697a4f5ffb814f76ab288eef","user":{"login":"Conduitry","id":16696352,"avatar_url":"https://avatars1.githubusercontent.com/u/16696352?v=4","gravatar_id":"","url":"https://api.github.com/users/Conduitry","html_url":"https://github.com/Conduitry","followers_url":"https://api.github.com/users/Conduitry/followers","following_url":"https://api.github.com/users/Conduitry/following{/other_user}","gists_url":"https://api.github.com/users/Conduitry/gists{/gist_id}","starred_url":"https://api.github.com/users/Conduitry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conduitry/subscriptions","organizations_url":"https://api.github.com/users/Conduitry/orgs","repos_url":"https://api.github.com/users/Conduitry/repos","events_url":"https://api.github.com/users/Conduitry/events{/privacy}","received_events_url":"https://api.github.com/users/Conduitry/received_events","type":"User","site_admin":false},"body":"It's of course very unlikely that anyone would use a variable called `__file`, but it seems unwise to knowingly introduce potential conflicts, and I don't really see what this provides over simply including `${JSON.stringify(this.compiler.file)}` over when you generate code calling `addLoc` from Element.ts","created_at":"2018-05-26T19:54:14Z","updated_at":"2018-05-26T19:54:14Z","html_url":"https://github.com/sveltejs/svelte/pull/1501#discussion_r191057189","pull_request_url":"https://api.github.com/repos/sveltejs/svelte/pulls/1501","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sveltejs/svelte/pulls/comments/191057189"},"html":{"href":"https://github.com/sveltejs/svelte/pull/1501#discussion_r191057189"},"pull_request":{"href":"https://api.github.com/repos/sveltejs/svelte/pulls/1501"}}},"pull_request":{"url":"https://api.github.com/repos/sveltejs/svelte/pulls/1501","id":190752670,"html_url":"https://github.com/sveltejs/svelte/pull/1501","diff_url":"https://github.com/sveltejs/svelte/pull/1501.diff","patch_url":"https://github.com/sveltejs/svelte/pull/1501.patch","issue_url":"https://api.github.com/repos/sveltejs/svelte/issues/1501","number":1501,"state":"open","locked":false,"title":"add location info to nodes","user":{"login":"Rich-Harris","id":1162160,"avatar_url":"https://avatars3.githubusercontent.com/u/1162160?v=4","gravatar_id":"","url":"https://api.github.com/users/Rich-Harris","html_url":"https://github.com/Rich-Harris","followers_url":"https://api.github.com/users/Rich-Harris/followers","following_url":"https://api.github.com/users/Rich-Harris/following{/other_user}","gists_url":"https://api.github.com/users/Rich-Harris/gists{/gist_id}","starred_url":"https://api.github.com/users/Rich-Harris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rich-Harris/subscriptions","organizations_url":"https://api.github.com/users/Rich-Harris/orgs","repos_url":"https://api.github.com/users/Rich-Harris/repos","events_url":"https://api.github.com/users/Rich-Harris/events{/privacy}","received_events_url":"https://api.github.com/users/Rich-Harris/received_events","type":"User","site_admin":false},"body":"Fixes #1499.\r\n\r\n[Here's a short clip](http://sapper-studio-preview.surge.sh/studio-preview.mp4) of this feature being used in Sapper Studio. The `App` pane has an edit icon, which takes you to the current page, and a crosshairs icon which lets you select a specific element.","created_at":"2018-05-26T17:56:27Z","updated_at":"2018-05-26T19:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b99ee1d3b6a0d0a75b69f8b352c3aa522125c718","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sveltejs/svelte/pulls/1501/commits","review_comments_url":"https://api.github.com/repos/sveltejs/svelte/pulls/1501/comments","review_comment_url":"https://api.github.com/repos/sveltejs/svelte/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sveltejs/svelte/issues/1501/comments","statuses_url":"https://api.github.com/repos/sveltejs/svelte/statuses/63a712ccd9e43078697a4f5ffb814f76ab288eef","head":{"label":"sveltejs:gh-1499","ref":"gh-1499","sha":"63a712ccd9e43078697a4f5ffb814f76ab288eef","user":{"login":"sveltejs","id":23617963,"avatar_url":"https://avatars1.githubusercontent.com/u/23617963?v=4","gravatar_id":"","url":"https://api.github.com/users/sveltejs","html_url":"https://github.com/sveltejs","followers_url":"https://api.github.com/users/sveltejs/followers","following_url":"https://api.github.com/users/sveltejs/following{/other_user}","gists_url":"https://api.github.com/users/sveltejs/gists{/gist_id}","starred_url":"https://api.github.com/users/sveltejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveltejs/subscriptions","organizations_url":"https://api.github.com/users/sveltejs/orgs","repos_url":"https://api.github.com/users/sveltejs/repos","events_url":"https://api.github.com/users/sveltejs/events{/privacy}","received_events_url":"https://api.github.com/users/sveltejs/received_events","type":"Organization","site_admin":false},"repo":{"id":74293321,"name":"svelte","full_name":"sveltejs/svelte","owner":{"login":"sveltejs","id":23617963,"avatar_url":"https://avatars1.githubusercontent.com/u/23617963?v=4","gravatar_id":"","url":"https://api.github.com/users/sveltejs","html_url":"https://github.com/sveltejs","followers_url":"https://api.github.com/users/sveltejs/followers","following_url":"https://api.github.com/users/sveltejs/following{/other_user}","gists_url":"https://api.github.com/users/sveltejs/gists{/gist_id}","starred_url":"https://api.github.com/users/sveltejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveltejs/subscriptions","organizations_url":"https://api.github.com/users/sveltejs/orgs","repos_url":"https://api.github.com/users/sveltejs/repos","events_url":"https://api.github.com/users/sveltejs/events{/privacy}","received_events_url":"https://api.github.com/users/sveltejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sveltejs/svelte","description":"The magical disappearing UI framework","fork":false,"url":"https://api.github.com/repos/sveltejs/svelte","forks_url":"https://api.github.com/repos/sveltejs/svelte/forks","keys_url":"https://api.github.com/repos/sveltejs/svelte/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sveltejs/svelte/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sveltejs/svelte/teams","hooks_url":"https://api.github.com/repos/sveltejs/svelte/hooks","issue_events_url":"https://api.github.com/repos/sveltejs/svelte/issues/events{/number}","events_url":"https://api.github.com/repos/sveltejs/svelte/events","assignees_url":"https://api.github.com/repos/sveltejs/svelte/assignees{/user}","branches_url":"https://api.github.com/repos/sveltejs/svelte/branches{/branch}","tags_url":"https://api.github.com/repos/sveltejs/svelte/tags","blobs_url":"https://api.github.com/repos/sveltejs/svelte/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sveltejs/svelte/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sveltejs/svelte/git/refs{/sha}","trees_url":"https://api.github.com/repos/sveltejs/svelte/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sveltejs/svelte/statuses/{sha}","languages_url":"https://api.github.com/repos/sveltejs/svelte/languages","stargazers_url":"https://api.github.com/repos/sveltejs/svelte/stargazers","contributors_url":"https://api.github.com/repos/sveltejs/svelte/contributors","subscribers_url":"https://api.github.com/repos/sveltejs/svelte/subscribers","subscription_url":"https://api.github.com/repos/sveltejs/svelte/subscription","commits_url":"https://api.github.com/repos/sveltejs/svelte/commits{/sha}","git_commits_url":"https://api.github.com/repos/sveltejs/svelte/git/commits{/sha}","comments_url":"https://api.github.com/repos/sveltejs/svelte/comments{/number}","issue_comment_url":"https://api.github.com/repos/sveltejs/svelte/issues/comments{/number}","contents_url":"https://api.github.com/repos/sveltejs/svelte/contents/{+path}","compare_url":"https://api.github.com/repos/sveltejs/svelte/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sveltejs/svelte/merges","archive_url":"https://api.github.com/repos/sveltejs/svelte/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sveltejs/svelte/downloads","issues_url":"https://api.github.com/repos/sveltejs/svelte/issues{/number}","pulls_url":"https://api.github.com/repos/sveltejs/svelte/pulls{/number}","milestones_url":"https://api.github.com/repos/sveltejs/svelte/milestones{/number}","notifications_url":"https://api.github.com/repos/sveltejs/svelte/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sveltejs/svelte/labels{/name}","releases_url":"https://api.github.com/repos/sveltejs/svelte/releases{/id}","deployments_url":"https://api.github.com/repos/sveltejs/svelte/deployments","created_at":"2016-11-20T18:13:05Z","updated_at":"2018-05-26T18:59:02Z","pushed_at":"2018-05-26T17:56:27Z","git_url":"git://github.com/sveltejs/svelte.git","ssh_url":"git@github.com:sveltejs/svelte.git","clone_url":"https://github.com/sveltejs/svelte.git","svn_url":"https://github.com/sveltejs/svelte","homepage":"https://svelte.technology","size":5836,"stargazers_count":7022,"watchers_count":7022,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":258,"open_issues":159,"watchers":7022,"default_branch":"master"}},"base":{"label":"sveltejs:master","ref":"master","sha":"54799736b8b03da41b7110a321dca8a3d880ed32","user":{"login":"sveltejs","id":23617963,"avatar_url":"https://avatars1.githubusercontent.com/u/23617963?v=4","gravatar_id":"","url":"https://api.github.com/users/sveltejs","html_url":"https://github.com/sveltejs","followers_url":"https://api.github.com/users/sveltejs/followers","following_url":"https://api.github.com/users/sveltejs/following{/other_user}","gists_url":"https://api.github.com/users/sveltejs/gists{/gist_id}","starred_url":"https://api.github.com/users/sveltejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveltejs/subscriptions","organizations_url":"https://api.github.com/users/sveltejs/orgs","repos_url":"https://api.github.com/users/sveltejs/repos","events_url":"https://api.github.com/users/sveltejs/events{/privacy}","received_events_url":"https://api.github.com/users/sveltejs/received_events","type":"Organization","site_admin":false},"repo":{"id":74293321,"name":"svelte","full_name":"sveltejs/svelte","owner":{"login":"sveltejs","id":23617963,"avatar_url":"https://avatars1.githubusercontent.com/u/23617963?v=4","gravatar_id":"","url":"https://api.github.com/users/sveltejs","html_url":"https://github.com/sveltejs","followers_url":"https://api.github.com/users/sveltejs/followers","following_url":"https://api.github.com/users/sveltejs/following{/other_user}","gists_url":"https://api.github.com/users/sveltejs/gists{/gist_id}","starred_url":"https://api.github.com/users/sveltejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveltejs/subscriptions","organizations_url":"https://api.github.com/users/sveltejs/orgs","repos_url":"https://api.github.com/users/sveltejs/repos","events_url":"https://api.github.com/users/sveltejs/events{/privacy}","received_events_url":"https://api.github.com/users/sveltejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sveltejs/svelte","description":"The magical disappearing UI framework","fork":false,"url":"https://api.github.com/repos/sveltejs/svelte","forks_url":"https://api.github.com/repos/sveltejs/svelte/forks","keys_url":"https://api.github.com/repos/sveltejs/svelte/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sveltejs/svelte/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sveltejs/svelte/teams","hooks_url":"https://api.github.com/repos/sveltejs/svelte/hooks","issue_events_url":"https://api.github.com/repos/sveltejs/svelte/issues/events{/number}","events_url":"https://api.github.com/repos/sveltejs/svelte/events","assignees_url":"https://api.github.com/repos/sveltejs/svelte/assignees{/user}","branches_url":"https://api.github.com/repos/sveltejs/svelte/branches{/branch}","tags_url":"https://api.github.com/repos/sveltejs/svelte/tags","blobs_url":"https://api.github.com/repos/sveltejs/svelte/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sveltejs/svelte/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sveltejs/svelte/git/refs{/sha}","trees_url":"https://api.github.com/repos/sveltejs/svelte/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sveltejs/svelte/statuses/{sha}","languages_url":"https://api.github.com/repos/sveltejs/svelte/languages","stargazers_url":"https://api.github.com/repos/sveltejs/svelte/stargazers","contributors_url":"https://api.github.com/repos/sveltejs/svelte/contributors","subscribers_url":"https://api.github.com/repos/sveltejs/svelte/subscribers","subscription_url":"https://api.github.com/repos/sveltejs/svelte/subscription","commits_url":"https://api.github.com/repos/sveltejs/svelte/commits{/sha}","git_commits_url":"https://api.github.com/repos/sveltejs/svelte/git/commits{/sha}","comments_url":"https://api.github.com/repos/sveltejs/svelte/comments{/number}","issue_comment_url":"https://api.github.com/repos/sveltejs/svelte/issues/comments{/number}","contents_url":"https://api.github.com/repos/sveltejs/svelte/contents/{+path}","compare_url":"https://api.github.com/repos/sveltejs/svelte/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sveltejs/svelte/merges","archive_url":"https://api.github.com/repos/sveltejs/svelte/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sveltejs/svelte/downloads","issues_url":"https://api.github.com/repos/sveltejs/svelte/issues{/number}","pulls_url":"https://api.github.com/repos/sveltejs/svelte/pulls{/number}","milestones_url":"https://api.github.com/repos/sveltejs/svelte/milestones{/number}","notifications_url":"https://api.github.com/repos/sveltejs/svelte/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sveltejs/svelte/labels{/name}","releases_url":"https://api.github.com/repos/sveltejs/svelte/releases{/id}","deployments_url":"https://api.github.com/repos/sveltejs/svelte/deployments","created_at":"2016-11-20T18:13:05Z","updated_at":"2018-05-26T18:59:02Z","pushed_at":"2018-05-26T17:56:27Z","git_url":"git://github.com/sveltejs/svelte.git","ssh_url":"git@github.com:sveltejs/svelte.git","clone_url":"https://github.com/sveltejs/svelte.git","svn_url":"https://github.com/sveltejs/svelte","homepage":"https://svelte.technology","size":5836,"stargazers_count":7022,"watchers_count":7022,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":258,"open_issues":159,"watchers":7022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sveltejs/svelte/pulls/1501"},"html":{"href":"https://github.com/sveltejs/svelte/pull/1501"},"issue":{"href":"https://api.github.com/repos/sveltejs/svelte/issues/1501"},"comments":{"href":"https://api.github.com/repos/sveltejs/svelte/issues/1501/comments"},"review_comments":{"href":"https://api.github.com/repos/sveltejs/svelte/pulls/1501/comments"},"review_comment":{"href":"https://api.github.com/repos/sveltejs/svelte/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sveltejs/svelte/pulls/1501/commits"},"statuses":{"href":"https://api.github.com/repos/sveltejs/svelte/statuses/63a712ccd9e43078697a4f5ffb814f76ab288eef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Conduitry"}}