{"action":"created","issue":{"url":"https://api.github.com/repos/wireapp/wire-ios/issues/2721","repository_url":"https://api.github.com/repos/wireapp/wire-ios","labels_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2721/labels{/name}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2721/comments","events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2721/events","html_url":"https://github.com/wireapp/wire-ios/pull/2721","id":364003024,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Mjk2ODU5","number":2721,"title":"Refactor + allow emoji search","user":{"login":"mikeger","id":715129,"node_id":"MDQ6VXNlcjcxNTEyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/715129?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeger","html_url":"https://github.com/mikeger","followers_url":"https://api.github.com/users/mikeger/followers","following_url":"https://api.github.com/users/mikeger/following{/other_user}","gists_url":"https://api.github.com/users/mikeger/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeger/subscriptions","organizations_url":"https://api.github.com/users/mikeger/orgs","repos_url":"https://api.github.com/users/mikeger/repos","events_url":"https://api.github.com/users/mikeger/events{/privacy}","received_events_url":"https://api.github.com/users/mikeger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/wireapp/wire-ios/milestones/48","html_url":"https://github.com/wireapp/wire-ios/milestone/48","labels_url":"https://api.github.com/repos/wireapp/wire-ios/milestones/48/labels","id":3632351,"node_id":"MDk6TWlsZXN0b25lMzYzMjM1MQ==","number":48,"title":"3.21","description":"","creator":{"login":"mikeger","id":715129,"node_id":"MDQ6VXNlcjcxNTEyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/715129?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeger","html_url":"https://github.com/mikeger","followers_url":"https://api.github.com/users/mikeger/followers","following_url":"https://api.github.com/users/mikeger/following{/other_user}","gists_url":"https://api.github.com/users/mikeger/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeger/subscriptions","organizations_url":"https://api.github.com/users/mikeger/orgs","repos_url":"https://api.github.com/users/mikeger/repos","events_url":"https://api.github.com/users/mikeger/events{/privacy}","received_events_url":"https://api.github.com/users/mikeger/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2018-09-07T10:47:11Z","updated_at":"2018-09-26T12:26:53Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-09-26T12:26:53Z","updated_at":"2018-09-26T13:49:48Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/2721","html_url":"https://github.com/wireapp/wire-ios/pull/2721","diff_url":"https://github.com/wireapp/wire-ios/pull/2721.diff","patch_url":"https://github.com/wireapp/wire-ios/pull/2721.patch"},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nSearch by emoji was not working for @ mentions.\r\n\r\n### Causes\r\n\r\nWe called `String.normalized()` method, it is cutting all characters except of latin and numbers: https://github.com/wireapp/wire-ios-utilities/blob/develop/Source/NSString+Normalization.m#L48\r\n\r\n### Solutions\r\n\r\nUse `String.normalizedForSearch()` instead.\r\n\r\n## Notes\r\n\r\nI separated concerns for search and display of the results. This allows easier test setup and more general approach."},"comment":{"url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments/424722414","html_url":"https://github.com/wireapp/wire-ios/pull/2721#issuecomment-424722414","issue_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2721","id":424722414,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDcyMjQxNA==","user":{"login":"mikeger","id":715129,"node_id":"MDQ6VXNlcjcxNTEyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/715129?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeger","html_url":"https://github.com/mikeger","followers_url":"https://api.github.com/users/mikeger/followers","following_url":"https://api.github.com/users/mikeger/following{/other_user}","gists_url":"https://api.github.com/users/mikeger/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeger/subscriptions","organizations_url":"https://api.github.com/users/mikeger/orgs","repos_url":"https://api.github.com/users/mikeger/repos","events_url":"https://api.github.com/users/mikeger/events{/privacy}","received_events_url":"https://api.github.com/users/mikeger/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T13:49:47Z","updated_at":"2018-09-26T13:49:47Z","author_association":"MEMBER","body":"Also fixed the colors for the dark mode."}}
{"actor":{"display_login":"mikeger"}}