{"action":"created","comment":{"url":"https://api.github.com/repos/canjs/can-define/pulls/comments/201861758","pull_request_review_id":136448088,"id":201861758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg2MTc1OA==","diff_hunk":"@@ -473,18 +473,15 @@ QUnit.test(\"copying with assign() excludes special keys\", function() {\n \n \tvar a = {\n \t\t_data: {},\n-\t\tconstructor: function() {},\n-\t\t__bindEvents: {},\n \t\t\"foo\": \"bar\",\n-\t\t\"existing\": \"newVal\"\n+\t\t\"existing\": \"neVal\"\n \t};\n \n \tvar b = new DefineMap({\n \t\t\"existing\": \"oldVal\"\n \t});\n-\tassign(b, a);\n+\tcanReflect.assignMap(b, a);\n \n-\tQUnit.notEqual(a.constructor, b.constructor, \"Constructor prop not copied\");","path":"map/map-test.js","position":17,"original_position":17,"commit_id":"4ecc4e17fc779670a3d74142971695c8a7184027","original_commit_id":"4ecc4e17fc779670a3d74142971695c8a7184027","user":{"login":"Aosanders","id":8368544,"node_id":"MDQ6VXNlcjgzNjg1NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8368544?v=4","gravatar_id":"","url":"https://api.github.com/users/Aosanders","html_url":"https://github.com/Aosanders","followers_url":"https://api.github.com/users/Aosanders/followers","following_url":"https://api.github.com/users/Aosanders/following{/other_user}","gists_url":"https://api.github.com/users/Aosanders/gists{/gist_id}","starred_url":"https://api.github.com/users/Aosanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aosanders/subscriptions","organizations_url":"https://api.github.com/users/Aosanders/orgs","repos_url":"https://api.github.com/users/Aosanders/repos","events_url":"https://api.github.com/users/Aosanders/events{/privacy}","received_events_url":"https://api.github.com/users/Aosanders/received_events","type":"User","site_admin":false},"body":"@matthewp and I removed it when we changed it to test assignments between two DefineMaps, as it wasn't deemed a realistic test.\r\nHowever, since I changed it back to an assignment between a regular object and a DefineMap object it might be necessary to check against anyone attempting to assign a constructor to the DefineMap object.","created_at":"2018-07-11T22:40:48Z","updated_at":"2018-07-11T22:40:48Z","html_url":"https://github.com/canjs/can-define/pull/356#discussion_r201861758","pull_request_url":"https://api.github.com/repos/canjs/can-define/pulls/356","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/canjs/can-define/pulls/comments/201861758"},"html":{"href":"https://github.com/canjs/can-define/pull/356#discussion_r201861758"},"pull_request":{"href":"https://api.github.com/repos/canjs/can-define/pulls/356"}},"in_reply_to_id":201857796},"pull_request":{"url":"https://api.github.com/repos/canjs/can-define/pulls/356","id":200805855,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODA1ODU1","html_url":"https://github.com/canjs/can-define/pull/356","diff_url":"https://github.com/canjs/can-define/pull/356.diff","patch_url":"https://github.com/canjs/can-define/pull/356.patch","issue_url":"https://api.github.com/repos/canjs/can-define/issues/356","number":356,"state":"open","locked":false,"title":"Fixes #353. Can-define special-keys assignment does not throw an error","user":{"login":"Aosanders","id":8368544,"node_id":"MDQ6VXNlcjgzNjg1NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8368544?v=4","gravatar_id":"","url":"https://api.github.com/users/Aosanders","html_url":"https://github.com/Aosanders","followers_url":"https://api.github.com/users/Aosanders/followers","following_url":"https://api.github.com/users/Aosanders/following{/other_user}","gists_url":"https://api.github.com/users/Aosanders/gists{/gist_id}","starred_url":"https://api.github.com/users/Aosanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aosanders/subscriptions","organizations_url":"https://api.github.com/users/Aosanders/orgs","repos_url":"https://api.github.com/users/Aosanders/repos","events_url":"https://api.github.com/users/Aosanders/events{/privacy}","received_events_url":"https://api.github.com/users/Aosanders/received_events","type":"User","site_admin":false},"body":"can-define/map/map-test.js was throwing an error when testing assignment of special keys to a DefineMap object. Added check to see if property being assigned is writable; if not, the property is skipped.\r\n\r\nShould we add a warning if someone attempts to add a special key to a DefineMap object?\r\n\r\n<!--\r\nThanks for your contribution!\r\n\r\nPlease make sure your pull request (PR) includes documentation and/or test updates.\r\n\r\nIn this PR description, please include a link to the issue(s) your PR addresses. If you include the issue number(s) in your commit(s), GitHub can automatically close the original issue(s): https://help.github.com/articles/closing-issues-via-commit-messages/\r\n\r\nIf applicable, please include a screenshot or gif to demonstrate your change. This makes it easier for reviewers to verify that it works for them. You can use LICEcap to make a gif: http://www.cockos.com/licecap/\r\n-->\r\n","created_at":"2018-07-11T19:43:15Z","updated_at":"2018-07-11T22:40:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99b2f4ea3d4b97547d08f374336594c14549f304","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justinbmeyer","id":78602,"node_id":"MDQ6VXNlcjc4NjAy","avatar_url":"https://avatars0.githubusercontent.com/u/78602?v=4","gravatar_id":"","url":"https://api.github.com/users/justinbmeyer","html_url":"https://github.com/justinbmeyer","followers_url":"https://api.github.com/users/justinbmeyer/followers","following_url":"https://api.github.com/users/justinbmeyer/following{/other_user}","gists_url":"https://api.github.com/users/justinbmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/justinbmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinbmeyer/subscriptions","organizations_url":"https://api.github.com/users/justinbmeyer/orgs","repos_url":"https://api.github.com/users/justinbmeyer/repos","events_url":"https://api.github.com/users/justinbmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/justinbmeyer/received_events","type":"User","site_admin":false},{"login":"matthewp","id":361671,"node_id":"MDQ6VXNlcjM2MTY3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/361671?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/canjs/can-define/pulls/356/commits","review_comments_url":"https://api.github.com/repos/canjs/can-define/pulls/356/comments","review_comment_url":"https://api.github.com/repos/canjs/can-define/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canjs/can-define/issues/356/comments","statuses_url":"https://api.github.com/repos/canjs/can-define/statuses/4ecc4e17fc779670a3d74142971695c8a7184027","head":{"label":"canjs:fixes-specialKeys-assignment","ref":"fixes-specialKeys-assignment","sha":"4ecc4e17fc779670a3d74142971695c8a7184027","user":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":48712549,"node_id":"MDEwOlJlcG9zaXRvcnk0ODcxMjU0OQ==","name":"can-define","full_name":"canjs/can-define","owner":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-define","description":"Observable properties","fork":false,"url":"https://api.github.com/repos/canjs/can-define","forks_url":"https://api.github.com/repos/canjs/can-define/forks","keys_url":"https://api.github.com/repos/canjs/can-define/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-define/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-define/teams","hooks_url":"https://api.github.com/repos/canjs/can-define/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-define/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-define/events","assignees_url":"https://api.github.com/repos/canjs/can-define/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-define/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-define/tags","blobs_url":"https://api.github.com/repos/canjs/can-define/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-define/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-define/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-define/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-define/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-define/languages","stargazers_url":"https://api.github.com/repos/canjs/can-define/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-define/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-define/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-define/subscription","commits_url":"https://api.github.com/repos/canjs/can-define/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-define/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-define/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-define/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-define/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-define/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-define/merges","archive_url":"https://api.github.com/repos/canjs/can-define/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-define/downloads","issues_url":"https://api.github.com/repos/canjs/can-define/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-define/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-define/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-define/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-define/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-define/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-define/deployments","created_at":"2015-12-28T21:13:05Z","updated_at":"2018-07-06T20:35:12Z","pushed_at":"2018-07-11T19:43:16Z","git_url":"git://github.com/canjs/can-define.git","ssh_url":"git@github.com:canjs/can-define.git","clone_url":"https://github.com/canjs/can-define.git","svn_url":"https://github.com/canjs/can-define","homepage":"https://canjs.com/doc/can-define.html","size":1492,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":29,"watchers":14,"default_branch":"master"}},"base":{"label":"canjs:master","ref":"master","sha":"f2b3d1b0c180803d76c56848b9be06c8800bdaa3","user":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":48712549,"node_id":"MDEwOlJlcG9zaXRvcnk0ODcxMjU0OQ==","name":"can-define","full_name":"canjs/can-define","owner":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-define","description":"Observable properties","fork":false,"url":"https://api.github.com/repos/canjs/can-define","forks_url":"https://api.github.com/repos/canjs/can-define/forks","keys_url":"https://api.github.com/repos/canjs/can-define/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-define/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-define/teams","hooks_url":"https://api.github.com/repos/canjs/can-define/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-define/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-define/events","assignees_url":"https://api.github.com/repos/canjs/can-define/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-define/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-define/tags","blobs_url":"https://api.github.com/repos/canjs/can-define/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-define/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-define/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-define/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-define/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-define/languages","stargazers_url":"https://api.github.com/repos/canjs/can-define/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-define/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-define/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-define/subscription","commits_url":"https://api.github.com/repos/canjs/can-define/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-define/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-define/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-define/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-define/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-define/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-define/merges","archive_url":"https://api.github.com/repos/canjs/can-define/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-define/downloads","issues_url":"https://api.github.com/repos/canjs/can-define/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-define/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-define/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-define/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-define/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-define/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-define/deployments","created_at":"2015-12-28T21:13:05Z","updated_at":"2018-07-06T20:35:12Z","pushed_at":"2018-07-11T19:43:16Z","git_url":"git://github.com/canjs/can-define.git","ssh_url":"git@github.com:canjs/can-define.git","clone_url":"https://github.com/canjs/can-define.git","svn_url":"https://github.com/canjs/can-define","homepage":"https://canjs.com/doc/can-define.html","size":1492,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":29,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canjs/can-define/pulls/356"},"html":{"href":"https://github.com/canjs/can-define/pull/356"},"issue":{"href":"https://api.github.com/repos/canjs/can-define/issues/356"},"comments":{"href":"https://api.github.com/repos/canjs/can-define/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/canjs/can-define/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/canjs/can-define/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canjs/can-define/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/canjs/can-define/statuses/4ecc4e17fc779670a3d74142971695c8a7184027"}},"author_association":"NONE"}}
{"actor":{"display_login":"Aosanders"}}