{"action":"created","issue":{"url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/issues/175","repository_url":"https://api.github.com/repos/sendgrid/sendgrid-ruby","labels_url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/issues/175/comments","events_url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/issues/175/events","html_url":"https://github.com/sendgrid/sendgrid-ruby/issues/175","id":258969031,"number":175,"title":"dependencies","user":{"login":"jjb","id":6097,"avatar_url":"https://avatars2.githubusercontent.com/u/6097?v=4","gravatar_id":"","url":"https://api.github.com/users/jjb","html_url":"https://github.com/jjb","followers_url":"https://api.github.com/users/jjb/followers","following_url":"https://api.github.com/users/jjb/following{/other_user}","gists_url":"https://api.github.com/users/jjb/gists{/gist_id}","starred_url":"https://api.github.com/users/jjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjb/subscriptions","organizations_url":"https://api.github.com/users/jjb/orgs","repos_url":"https://api.github.com/users/jjb/repos","events_url":"https://api.github.com/users/jjb/events{/privacy}","received_events_url":"https://api.github.com/users/jjb/received_events","type":"User","site_admin":false},"labels":[{"id":105894946,"url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/labels/status:%20help%20wanted","name":"status: help wanted","color":"159818","default":false},{"id":105894948,"url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/labels/type:%20question","name":"type: question","color":"cc317c","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-09-19T21:24:13Z","updated_at":"2018-02-13T01:35:50Z","closed_at":"2017-09-20T05:52:00Z","author_association":"NONE","body":"Hi,\r\n\r\nFirst of all, thanks for providing and maintaining what looks to be a full-featured client library! I'm just getting started and there are a couple things that stick out to me in the dependencies.\r\n\r\n1. the dependency on Sinatra and rack-protection. I'm guessing both of these are only needed for inbound processing. They each add dependencies of their own, so including the sendgrid-ruby gem in my projects adds a lot of unneeded gems. I saw in [this comment](https://github.com/sendgrid/sendgrid-ruby/issues/159#issuecomment-317751032) that you will split the outgoing and incoming processing libraries in the future. Even before you do that, you can simply make the sinatra dependency optional. Put in the readme that if the user wants to do incoming processing, they have to add sinatra to the Gemfile. This isn't ideal because one can't control versions and such with as much precision and it might complicate the test suite setup a but, but overall it should be quite feasible.\r\n\r\n2. ruby_http_client - it looks like this is a standalone http client library developed by sendgrid? Why did you chose to make an http client library? There are several fantastic choices in ruby. Using an existing library would possibly reduce the weight of the dependencies, make it easier for users to work with your code and add new features, save you development time, let you benefit from the experience and history of those projects... this list goes on :)\r\n\r\nJohn"},"comment":{"url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/issues/comments/365122339","html_url":"https://github.com/sendgrid/sendgrid-ruby/issues/175#issuecomment-365122339","issue_url":"https://api.github.com/repos/sendgrid/sendgrid-ruby/issues/175","id":365122339,"user":{"login":"thinkingserious","id":146695,"avatar_url":"https://avatars0.githubusercontent.com/u/146695?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkingserious","html_url":"https://github.com/thinkingserious","followers_url":"https://api.github.com/users/thinkingserious/followers","following_url":"https://api.github.com/users/thinkingserious/following{/other_user}","gists_url":"https://api.github.com/users/thinkingserious/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkingserious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkingserious/subscriptions","organizations_url":"https://api.github.com/users/thinkingserious/orgs","repos_url":"https://api.github.com/users/thinkingserious/repos","events_url":"https://api.github.com/users/thinkingserious/events{/privacy}","received_events_url":"https://api.github.com/users/thinkingserious/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T01:35:50Z","updated_at":"2018-02-13T01:35:50Z","author_association":"MEMBER","body":"Thanks for the PR @jjb!\r\n\r\nI'm hoping to get your PR merged soon. "}}
{"actor":{"display_login":"thinkingserious"}}