{"action":"created","issue":{"url":"https://api.github.com/repos/savoirfairelinux/num2words/issues/231","repository_url":"https://api.github.com/repos/savoirfairelinux/num2words","labels_url":"https://api.github.com/repos/savoirfairelinux/num2words/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/savoirfairelinux/num2words/issues/231/comments","events_url":"https://api.github.com/repos/savoirfairelinux/num2words/issues/231/events","html_url":"https://github.com/savoirfairelinux/num2words/pull/231","id":387792048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjAxOTky","number":231,"title":"Issue 229: Add explicit encoding, license and unix line separators.","user":{"login":"erozqba","id":9809143,"node_id":"MDQ6VXNlcjk4MDkxNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9809143?v=4","gravatar_id":"","url":"https://api.github.com/users/erozqba","html_url":"https://github.com/erozqba","followers_url":"https://api.github.com/users/erozqba/followers","following_url":"https://api.github.com/users/erozqba/following{/other_user}","gists_url":"https://api.github.com/users/erozqba/gists{/gist_id}","starred_url":"https://api.github.com/users/erozqba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozqba/subscriptions","organizations_url":"https://api.github.com/users/erozqba/orgs","repos_url":"https://api.github.com/users/erozqba/repos","events_url":"https://api.github.com/users/erozqba/events{/privacy}","received_events_url":"https://api.github.com/users/erozqba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-05T14:50:51Z","updated_at":"2018-12-06T10:51:05Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/savoirfairelinux/num2words/pulls/231","html_url":"https://github.com/savoirfairelinux/num2words/pull/231","diff_url":"https://github.com/savoirfairelinux/num2words/pull/231.diff","patch_url":"https://github.com/savoirfairelinux/num2words/pull/231.patch"},"body":"## Fixes #229 \r\n\r\n### Changes proposed in this pull request:\r\n\r\nSome maintainers for different Linux distribution are having some\r\nproblems with the encoding in different python versions. This change\r\nintents to make all python files define explicitly the encoding, license, \r\nand Unix line separators. Remove one example of the README.rst file\r\nwhere a possible non UTF-8 character is used.\r\n\r\n### Status\r\n\r\n- [X] READY\r\n- [ ] HOLD\r\n- [ ] WIP (Work-In-Progress)\r\n\r\n### How to verify this change\r\n\r\nMake sure all tests pass and coverage remains the same.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/savoirfairelinux/num2words/issues/comments/444831006","html_url":"https://github.com/savoirfairelinux/num2words/pull/231#issuecomment-444831006","issue_url":"https://api.github.com/repos/savoirfairelinux/num2words/issues/231","id":444831006,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDgzMTAwNg==","user":{"login":"null-git","id":1078137,"node_id":"MDQ6VXNlcjEwNzgxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1078137?v=4","gravatar_id":"","url":"https://api.github.com/users/null-git","html_url":"https://github.com/null-git","followers_url":"https://api.github.com/users/null-git/followers","following_url":"https://api.github.com/users/null-git/following{/other_user}","gists_url":"https://api.github.com/users/null-git/gists{/gist_id}","starred_url":"https://api.github.com/users/null-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/null-git/subscriptions","organizations_url":"https://api.github.com/users/null-git/orgs","repos_url":"https://api.github.com/users/null-git/repos","events_url":"https://api.github.com/users/null-git/events{/privacy}","received_events_url":"https://api.github.com/users/null-git/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T10:51:05Z","updated_at":"2018-12-06T10:51:05Z","author_association":"NONE","body":"Thanks for this, but it doesn't build either:\r\n```\r\n===>  Configuring for py36-num2words-0.5.8_1\r\nTraceback (most recent call last):\r\n  File \"<string>\", line 1, in <module>\r\n  File \"setup.py\", line 59, in <module>\r\n    version=find_version(\"bin/num2words\"),\r\n  File \"setup.py\", line 47, in find_version\r\n    for line in fp:\r\n  File \"/usr/local/lib/python3.6/encodings/ascii.py\", line 26, in decode\r\n    return codecs.ascii_decode(input, self.errors)[0]\r\nUnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 747: ordinal not in range(128)\r\n*** Error code 1\r\n```\r\nThis is the same example in bin/num2words:27 that was removed from README.rst. Removing this line as well does the trick. But wouldn't it be nicer to just open those specific files as utf-8? As they are opened by open(), the \"coding: utf-8\" line doesn't do anything for this. Replacing open() with io.open() might do it? This seems to be available for python2.7 as well and to be the same as open() in python3+"}}
{"actor":{"display_login":"null-git"}}