{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/twentynineteen/issues/313","repository_url":"https://api.github.com/repos/WordPress/twentynineteen","labels_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/313/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/313/comments","events_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/313/events","html_url":"https://github.com/WordPress/twentynineteen/pull/313","id":373913891,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzMyNTU2","number":313,"title":"Automatically hide overflowing menu items in a dropdown menu","user":{"login":"youknowriad","id":272444,"node_id":"MDQ6VXNlcjI3MjQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"labels":[{"id":1104192523,"node_id":"MDU6TGFiZWwxMTA0MTkyNTIz","url":"https://api.github.com/repos/WordPress/twentynineteen/labels/has%20patch","name":"has patch","color":"2d7bb7","default":false},{"id":1093220088,"node_id":"MDU6TGFiZWwxMDkzMjIwMDg4","url":"https://api.github.com/repos/WordPress/twentynineteen/labels/in%20progress","name":"in progress","color":"ebed84","default":false},{"id":1093192454,"node_id":"MDU6TGFiZWwxMDkzMTkyNDU0","url":"https://api.github.com/repos/WordPress/twentynineteen/labels/task","name":"task","color":"57f9d1","default":false}],"state":"open","locked":false,"assignee":{"login":"youknowriad","id":272444,"node_id":"MDQ6VXNlcjI3MjQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"assignees":[{"login":"youknowriad","id":272444,"node_id":"MDQ6VXNlcjI3MjQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WordPress/twentynineteen/milestones/1","html_url":"https://github.com/WordPress/twentynineteen/milestone/1","labels_url":"https://api.github.com/repos/WordPress/twentynineteen/milestones/1/labels","id":3762003,"node_id":"MDk6TWlsZXN0b25lMzc2MjAwMw==","number":1,"title":"RC1","description":"","creator":{"login":"kjellr","id":1202812,"node_id":"MDQ6VXNlcjEyMDI4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1202812?v=4","gravatar_id":"","url":"https://api.github.com/users/kjellr","html_url":"https://github.com/kjellr","followers_url":"https://api.github.com/users/kjellr/followers","following_url":"https://api.github.com/users/kjellr/following{/other_user}","gists_url":"https://api.github.com/users/kjellr/gists{/gist_id}","starred_url":"https://api.github.com/users/kjellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjellr/subscriptions","organizations_url":"https://api.github.com/users/kjellr/orgs","repos_url":"https://api.github.com/users/kjellr/repos","events_url":"https://api.github.com/users/kjellr/events{/privacy}","received_events_url":"https://api.github.com/users/kjellr/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":54,"state":"open","created_at":"2018-10-23T14:39:25Z","updated_at":"2018-10-30T16:23:40Z","due_on":"2018-10-30T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-10-25T12:05:18Z","updated_at":"2018-10-30T18:50:26Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/WordPress/twentynineteen/pulls/313","html_url":"https://github.com/WordPress/twentynineteen/pull/313","diff_url":"https://github.com/WordPress/twentynineteen/pull/313.diff","patch_url":"https://github.com/WordPress/twentynineteen/pull/313.patch"},"body":"closes #268 \r\n\r\nThis PR tries to add the automatic hiding of menu elements overflowing with the container. That way the menu always shows up in a single line.\r\n\r\nIn its current state, I did the minimal CSS changes to make it work, it still needs to be polished design-wise and probably a11y wise too but the behavior is there.\r\n"},"comment":{"url":"https://api.github.com/repos/WordPress/twentynineteen/issues/comments/434425130","html_url":"https://github.com/WordPress/twentynineteen/pull/313#issuecomment-434425130","issue_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/313","id":434425130,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQyNTEzMA==","user":{"login":"kjellr","id":1202812,"node_id":"MDQ6VXNlcjEyMDI4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1202812?v=4","gravatar_id":"","url":"https://api.github.com/users/kjellr","html_url":"https://github.com/kjellr","followers_url":"https://api.github.com/users/kjellr/followers","following_url":"https://api.github.com/users/kjellr/following{/other_user}","gists_url":"https://api.github.com/users/kjellr/gists{/gist_id}","starred_url":"https://api.github.com/users/kjellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjellr/subscriptions","organizations_url":"https://api.github.com/users/kjellr/orgs","repos_url":"https://api.github.com/users/kjellr/repos","events_url":"https://api.github.com/users/kjellr/events{/privacy}","received_events_url":"https://api.github.com/users/kjellr/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T18:50:26Z","updated_at":"2018-10-30T18:50:26Z","author_association":"COLLABORATOR","body":"This still needs some work, but I pushed this a little closer. Some things that need to be sorted out before merge:\r\n\r\n- [ ] In my testing, the priority+ menu didn't consistently kick in on every new page load. Sometimes I had to resize the window a little bit for it to activate. \r\n- [ ] For now, I exposed and indented all submenus in this iteration. I'm thinking we'll either need to replace that with the nested solution we have from #337 ([GIF here](https://github.com/WordPress/twentynineteen/pull/337#issuecomment-433585675)), or we'll need to adapt this method for all menu items. (It's simple and it saves users a tap or two).\r\n- [ ] On mobile, you can currently scroll and see the normal page under the menu. \r\n- [ ] On mobile, we need to inject a close button.\r\n- [ ] Our current desktop menus work on hover, but this requires a click. \r\n- [ ] On desktop, the only way to close this is to click the ellipsis button again. We should have it close whenever someone hovers outside of the menu (Or clicks, depending on whether or not we use a click or a hover to trigger the menu, as per the above bullet point). As it stands now, you can activate both a submenu _and_ the priority+ menu, which leads to [some messiness](https://cloudup.com/cv-Oi-JbwCr). \r\n- [ ] On desktop, the menu is just anchored to the right of the header area. This is usually okay, but it'd be better if this was more closely aligned with the button itself. \r\n- [ ] This should be tested more. 😄 \r\n\r\nHere's the current state in GIF form:\r\n\r\n_Large screens:_\r\n![priority-plus](https://user-images.githubusercontent.com/1202812/47741543-ead32280-dc50-11e8-97cc-438c65a09c50.gif)\r\n\r\n_Small screens:_\r\n![priority-plus-mobile](https://user-images.githubusercontent.com/1202812/47741574-f58db780-dc50-11e8-805b-04719ad1b002.gif)"}}
{"actor":{"display_login":"kjellr"}}