{"action":"created","comment":{"url":"https://api.github.com/repos/awesome-academy/fenglish/pulls/comments/242024031","pull_request_review_id":185437179,"id":242024031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjAyNDAzMQ==","diff_hunk":"@@ -21,72 +21,72 @@\n @Controller\n @RequestMapping(\"/admin\")\n public class UsersController {\n-\t\n+\n \tprivate static final int maxResult = 10;\n-\t\n+\n \t@Autowired\n \tprivate UserService userService;\n \t\n \t@RequestMapping(value = \"/users/page={offset}\", method = RequestMethod.GET)\n \tpublic String index(@PathVariable(\"offset\") Integer offset, Model model) {\n-\t\t\n+\n \t\tList<UserInfo> users = userService.loadUsers(offset, maxResult);\n \t\tmodel.addAttribute(\"count\", userService.count());\n \t\tmodel.addAttribute(\"offset\", offset);\n \t\tmodel.addAttribute(\"users\", users);\n-\t\t\n+\n \t\treturn \"/users/index\";\n \t}\n \t\n \t@RequestMapping(value = \"/users/{id}\", method = RequestMethod.GET)\n \tpublic String detail(@PathVariable(\"id\") Integer id, Model model) {\n-\t\t\n+\n \t\tUserInfo user = userService.findUserById(id);\n-\t\t\n+\n \t\tif (user == null) {\n \t\t\tmodel.addAttribute(\"css\", \"danger\");\n \t\t\tmodel.addAttribute(\"msg\", \"msg.user.notfound\");\n \t\t}\n \t\tmodel.addAttribute(\"user\", user);\n-\t\t\n+\n \t\treturn \"/users/detail\";\n \t}\n-\t\n+\n \t@RequestMapping(value = \"/users/{id}\", method = RequestMethod.DELETE)\n \t@ResponseBody\n \tpublic String delete(@PathVariable(\"id\") Integer id, Model model, RedirectAttributes redirectAttributes) {\n-\t\t\n+\n \t\tif (userService.deleteUserById(id)) {\n \t\t\tredirectAttributes.addFlashAttribute(\"css\", \"success\");\n \t\t\tredirectAttributes.addFlashAttribute(\"msg\", \"msg.user.deletesuccess\");\n \t\t} else {\n \t\t\tredirectAttributes.addFlashAttribute(\"css\", \"error\");\n \t\t\tredirectAttributes.addFlashAttribute(\"css\", \"msg.user.deletefail\");\n \t\t}\n-\t\t\n+\n \t\treturn \"redirect:/admin/\";\n \t}\n-\t\n-\t@RequestMapping(value = \"/users/{id}/edit\", method = RequestMethod.GET)\n+\n+\t@RequestMapping(value = \"/users/edit/{id}\", method = RequestMethod.GET)","path":"src/main/java/vn/framgia/controller/UsersController.java","position":62,"original_position":62,"commit_id":"38a771bf986e9868e877fd841e3911f072e6f1ad","original_commit_id":"38a771bf986e9868e877fd841e3911f072e6f1ad","user":{"login":"VuThiTranVan","id":27009821,"node_id":"MDQ6VXNlcjI3MDA5ODIx","avatar_url":"https://avatars3.githubusercontent.com/u/27009821?v=4","gravatar_id":"","url":"https://api.github.com/users/VuThiTranVan","html_url":"https://github.com/VuThiTranVan","followers_url":"https://api.github.com/users/VuThiTranVan/followers","following_url":"https://api.github.com/users/VuThiTranVan/following{/other_user}","gists_url":"https://api.github.com/users/VuThiTranVan/gists{/gist_id}","starred_url":"https://api.github.com/users/VuThiTranVan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VuThiTranVan/subscriptions","organizations_url":"https://api.github.com/users/VuThiTranVan/orgs","repos_url":"https://api.github.com/users/VuThiTranVan/repos","events_url":"https://api.github.com/users/VuThiTranVan/events{/privacy}","received_events_url":"https://api.github.com/users/VuThiTranVan/received_events","type":"User","site_admin":false},"body":"chị nhớ là mi đang để `edit` phía sau đấy nhé, check lại chuẩn rest nhé","created_at":"2018-12-17T04:37:33Z","updated_at":"2018-12-17T04:37:44Z","html_url":"https://github.com/awesome-academy/fenglish/pull/10#discussion_r242024031","pull_request_url":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/fenglish/pulls/comments/242024031"},"html":{"href":"https://github.com/awesome-academy/fenglish/pull/10#discussion_r242024031"},"pull_request":{"href":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10","id":239024757,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDI0NzU3","html_url":"https://github.com/awesome-academy/fenglish/pull/10","diff_url":"https://github.com/awesome-academy/fenglish/pull/10.diff","patch_url":"https://github.com/awesome-academy/fenglish/pull/10.patch","issue_url":"https://api.github.com/repos/awesome-academy/fenglish/issues/10","number":10,"state":"open","locked":false,"title":"add multilanguage","user":{"login":"NguyenNgocVanFHN","id":44827194,"node_id":"MDQ6VXNlcjQ0ODI3MTk0","avatar_url":"https://avatars2.githubusercontent.com/u/44827194?v=4","gravatar_id":"","url":"https://api.github.com/users/NguyenNgocVanFHN","html_url":"https://github.com/NguyenNgocVanFHN","followers_url":"https://api.github.com/users/NguyenNgocVanFHN/followers","following_url":"https://api.github.com/users/NguyenNgocVanFHN/following{/other_user}","gists_url":"https://api.github.com/users/NguyenNgocVanFHN/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenNgocVanFHN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenNgocVanFHN/subscriptions","organizations_url":"https://api.github.com/users/NguyenNgocVanFHN/orgs","repos_url":"https://api.github.com/users/NguyenNgocVanFHN/repos","events_url":"https://api.github.com/users/NguyenNgocVanFHN/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenNgocVanFHN/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-17T04:35:14Z","updated_at":"2018-12-17T04:37:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bae9c3ddbc5b45d9b29abd14c2869ac59a8a745c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10/commits","review_comments_url":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10/comments","review_comment_url":"https://api.github.com/repos/awesome-academy/fenglish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesome-academy/fenglish/issues/10/comments","statuses_url":"https://api.github.com/repos/awesome-academy/fenglish/statuses/38a771bf986e9868e877fd841e3911f072e6f1ad","head":{"label":"NguyenNgocVanFHN:multilanguage","ref":"multilanguage","sha":"38a771bf986e9868e877fd841e3911f072e6f1ad","user":{"login":"NguyenNgocVanFHN","id":44827194,"node_id":"MDQ6VXNlcjQ0ODI3MTk0","avatar_url":"https://avatars2.githubusercontent.com/u/44827194?v=4","gravatar_id":"","url":"https://api.github.com/users/NguyenNgocVanFHN","html_url":"https://github.com/NguyenNgocVanFHN","followers_url":"https://api.github.com/users/NguyenNgocVanFHN/followers","following_url":"https://api.github.com/users/NguyenNgocVanFHN/following{/other_user}","gists_url":"https://api.github.com/users/NguyenNgocVanFHN/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenNgocVanFHN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenNgocVanFHN/subscriptions","organizations_url":"https://api.github.com/users/NguyenNgocVanFHN/orgs","repos_url":"https://api.github.com/users/NguyenNgocVanFHN/repos","events_url":"https://api.github.com/users/NguyenNgocVanFHN/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenNgocVanFHN/received_events","type":"User","site_admin":false},"repo":{"id":161140541,"node_id":"MDEwOlJlcG9zaXRvcnkxNjExNDA1NDE=","name":"fenglish","full_name":"NguyenNgocVanFHN/fenglish","private":false,"owner":{"login":"NguyenNgocVanFHN","id":44827194,"node_id":"MDQ6VXNlcjQ0ODI3MTk0","avatar_url":"https://avatars2.githubusercontent.com/u/44827194?v=4","gravatar_id":"","url":"https://api.github.com/users/NguyenNgocVanFHN","html_url":"https://github.com/NguyenNgocVanFHN","followers_url":"https://api.github.com/users/NguyenNgocVanFHN/followers","following_url":"https://api.github.com/users/NguyenNgocVanFHN/following{/other_user}","gists_url":"https://api.github.com/users/NguyenNgocVanFHN/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenNgocVanFHN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenNgocVanFHN/subscriptions","organizations_url":"https://api.github.com/users/NguyenNgocVanFHN/orgs","repos_url":"https://api.github.com/users/NguyenNgocVanFHN/repos","events_url":"https://api.github.com/users/NguyenNgocVanFHN/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenNgocVanFHN/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NguyenNgocVanFHN/fenglish","description":"[Java Training] Web Learn english online","fork":true,"url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish","forks_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/forks","keys_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/teams","hooks_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/hooks","issue_events_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/issues/events{/number}","events_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/events","assignees_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/assignees{/user}","branches_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/branches{/branch}","tags_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/tags","blobs_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/git/refs{/sha}","trees_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/statuses/{sha}","languages_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/languages","stargazers_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/stargazers","contributors_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/contributors","subscribers_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/subscribers","subscription_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/subscription","commits_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/commits{/sha}","git_commits_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/git/commits{/sha}","comments_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/comments{/number}","issue_comment_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/issues/comments{/number}","contents_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/contents/{+path}","compare_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/merges","archive_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/downloads","issues_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/issues{/number}","pulls_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/pulls{/number}","milestones_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/milestones{/number}","notifications_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/labels{/name}","releases_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/releases{/id}","deployments_url":"https://api.github.com/repos/NguyenNgocVanFHN/fenglish/deployments","created_at":"2018-12-10T08:15:35Z","updated_at":"2018-12-12T17:32:27Z","pushed_at":"2018-12-17T04:32:51Z","git_url":"git://github.com/NguyenNgocVanFHN/fenglish.git","ssh_url":"git@github.com:NguyenNgocVanFHN/fenglish.git","clone_url":"https://github.com/NguyenNgocVanFHN/fenglish.git","svn_url":"https://github.com/NguyenNgocVanFHN/fenglish","homepage":null,"size":4318,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"awesome-academy:develop","ref":"develop","sha":"b444882f783c31d71acaf16879f7304e954beef0","user":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"repo":{"id":160123569,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAxMjM1Njk=","name":"fenglish","full_name":"awesome-academy/fenglish","private":false,"owner":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awesome-academy/fenglish","description":"[Java Training] Web Learn english online","fork":false,"url":"https://api.github.com/repos/awesome-academy/fenglish","forks_url":"https://api.github.com/repos/awesome-academy/fenglish/forks","keys_url":"https://api.github.com/repos/awesome-academy/fenglish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesome-academy/fenglish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesome-academy/fenglish/teams","hooks_url":"https://api.github.com/repos/awesome-academy/fenglish/hooks","issue_events_url":"https://api.github.com/repos/awesome-academy/fenglish/issues/events{/number}","events_url":"https://api.github.com/repos/awesome-academy/fenglish/events","assignees_url":"https://api.github.com/repos/awesome-academy/fenglish/assignees{/user}","branches_url":"https://api.github.com/repos/awesome-academy/fenglish/branches{/branch}","tags_url":"https://api.github.com/repos/awesome-academy/fenglish/tags","blobs_url":"https://api.github.com/repos/awesome-academy/fenglish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesome-academy/fenglish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesome-academy/fenglish/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesome-academy/fenglish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesome-academy/fenglish/statuses/{sha}","languages_url":"https://api.github.com/repos/awesome-academy/fenglish/languages","stargazers_url":"https://api.github.com/repos/awesome-academy/fenglish/stargazers","contributors_url":"https://api.github.com/repos/awesome-academy/fenglish/contributors","subscribers_url":"https://api.github.com/repos/awesome-academy/fenglish/subscribers","subscription_url":"https://api.github.com/repos/awesome-academy/fenglish/subscription","commits_url":"https://api.github.com/repos/awesome-academy/fenglish/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesome-academy/fenglish/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesome-academy/fenglish/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesome-academy/fenglish/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesome-academy/fenglish/contents/{+path}","compare_url":"https://api.github.com/repos/awesome-academy/fenglish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesome-academy/fenglish/merges","archive_url":"https://api.github.com/repos/awesome-academy/fenglish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesome-academy/fenglish/downloads","issues_url":"https://api.github.com/repos/awesome-academy/fenglish/issues{/number}","pulls_url":"https://api.github.com/repos/awesome-academy/fenglish/pulls{/number}","milestones_url":"https://api.github.com/repos/awesome-academy/fenglish/milestones{/number}","notifications_url":"https://api.github.com/repos/awesome-academy/fenglish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesome-academy/fenglish/labels{/name}","releases_url":"https://api.github.com/repos/awesome-academy/fenglish/releases{/id}","deployments_url":"https://api.github.com/repos/awesome-academy/fenglish/deployments","created_at":"2018-12-03T02:52:29Z","updated_at":"2018-12-17T04:05:05Z","pushed_at":"2018-12-17T04:35:15Z","git_url":"git://github.com/awesome-academy/fenglish.git","ssh_url":"git@github.com:awesome-academy/fenglish.git","clone_url":"https://github.com/awesome-academy/fenglish.git","svn_url":"https://github.com/awesome-academy/fenglish","homepage":null,"size":4184,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10"},"html":{"href":"https://github.com/awesome-academy/fenglish/pull/10"},"issue":{"href":"https://api.github.com/repos/awesome-academy/fenglish/issues/10"},"comments":{"href":"https://api.github.com/repos/awesome-academy/fenglish/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/awesome-academy/fenglish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesome-academy/fenglish/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/awesome-academy/fenglish/statuses/38a771bf986e9868e877fd841e3911f072e6f1ad"}},"author_association":"NONE"}}
{"actor":{"display_login":"VuThiTranVan"}}