{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/243482874","pull_request_review_id":187265918,"id":243482874,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ4Mjg3NA==","diff_hunk":"@@ -172,10 +177,8 @@ ostream& operator<<(ostream& out, const entity_addr_t &addr)\n   if (addr.type == entity_addr_t::TYPE_NONE) {\n     return out << \"-\";\n   }\n-  if (addr.type != entity_addr_t::TYPE_DEFAULT) {","path":"src/msg/msg_types.cc","position":42,"original_position":42,"commit_id":"506fcd68331d6319d79256d57d37c239555eb95b","original_commit_id":"506fcd68331d6319d79256d57d37c239555eb95b","user":{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"It does.  in most cases I left the old field in place with the legacy address, and added a new 'addrs' (or whatever it was, but plural) and dump the addrvec.  I can make it leave off the prefix, but eventually we'll want to adjust the openstack code to understand the v2 and v1 addresses.  ","created_at":"2018-12-21T03:54:52Z","updated_at":"2018-12-21T03:54:52Z","html_url":"https://github.com/ceph/ceph/pull/25009#discussion_r243482874","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/25009","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/243482874"},"html":{"href":"https://github.com/ceph/ceph/pull/25009#discussion_r243482874"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25009"}},"in_reply_to_id":243473714},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25009","id":229743857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzQzODU3","html_url":"https://github.com/ceph/ceph/pull/25009","diff_url":"https://github.com/ceph/ceph/pull/25009.diff","patch_url":"https://github.com/ceph/ceph/pull/25009.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25009","number":25009,"state":"open","locked":false,"title":"mon: use v2 addrs for monmap, bootstrap, etc","user":{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"Also, change the addr formatting to have v1: and v2: prefixes consistently.","created_at":"2018-11-09T16:15:31Z","updated_at":"2018-12-21T03:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f1cd7a014f1f13072e2f43093566108f1fc2168","assignee":null,"assignees":[],"requested_reviewers":[{"login":"batrick","id":548304,"node_id":"MDQ6VXNlcjU0ODMwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/548304?v=4","gravatar_id":"","url":"https://api.github.com/users/batrick","html_url":"https://github.com/batrick","followers_url":"https://api.github.com/users/batrick/followers","following_url":"https://api.github.com/users/batrick/following{/other_user}","gists_url":"https://api.github.com/users/batrick/gists{/gist_id}","starred_url":"https://api.github.com/users/batrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batrick/subscriptions","organizations_url":"https://api.github.com/users/batrick/orgs","repos_url":"https://api.github.com/users/batrick/repos","events_url":"https://api.github.com/users/batrick/events{/privacy}","received_events_url":"https://api.github.com/users/batrick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":199292951,"node_id":"MDU6TGFiZWwxOTkyOTI5NTE=","url":"https://api.github.com/repos/ceph/ceph/labels/common","name":"common","color":"006b75","default":false},{"id":134774006,"node_id":"MDU6TGFiZWwxMzQ3NzQwMDY=","url":"https://api.github.com/repos/ceph/ceph/labels/feature","name":"feature","color":"00ff24","default":false},{"id":146926431,"node_id":"MDU6TGFiZWwxNDY5MjY0MzE=","url":"https://api.github.com/repos/ceph/ceph/labels/wip-sage-testing","name":"wip-sage-testing","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/25009/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/25009/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25009/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/506fcd68331d6319d79256d57d37c239555eb95b","head":{"label":"liewegas:wip-monmap-addrvec","ref":"wip-monmap-addrvec","sha":"506fcd68331d6319d79256d57d37c239555eb95b","user":{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"repo":{"id":2430918,"node_id":"MDEwOlJlcG9zaXRvcnkyNDMwOTE4","name":"ceph","full_name":"liewegas/ceph","private":false,"owner":{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/liewegas/ceph","description":"Ceph distributed file system","fork":true,"url":"https://api.github.com/repos/liewegas/ceph","forks_url":"https://api.github.com/repos/liewegas/ceph/forks","keys_url":"https://api.github.com/repos/liewegas/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liewegas/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liewegas/ceph/teams","hooks_url":"https://api.github.com/repos/liewegas/ceph/hooks","issue_events_url":"https://api.github.com/repos/liewegas/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/liewegas/ceph/events","assignees_url":"https://api.github.com/repos/liewegas/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/liewegas/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/liewegas/ceph/tags","blobs_url":"https://api.github.com/repos/liewegas/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liewegas/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liewegas/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/liewegas/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liewegas/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/liewegas/ceph/languages","stargazers_url":"https://api.github.com/repos/liewegas/ceph/stargazers","contributors_url":"https://api.github.com/repos/liewegas/ceph/contributors","subscribers_url":"https://api.github.com/repos/liewegas/ceph/subscribers","subscription_url":"https://api.github.com/repos/liewegas/ceph/subscription","commits_url":"https://api.github.com/repos/liewegas/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/liewegas/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/liewegas/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/liewegas/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/liewegas/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/liewegas/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liewegas/ceph/merges","archive_url":"https://api.github.com/repos/liewegas/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liewegas/ceph/downloads","issues_url":"https://api.github.com/repos/liewegas/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/liewegas/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/liewegas/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/liewegas/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liewegas/ceph/labels{/name}","releases_url":"https://api.github.com/repos/liewegas/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/liewegas/ceph/deployments","created_at":"2011-09-21T16:14:23Z","updated_at":"2018-12-13T12:55:50Z","pushed_at":"2018-12-21T03:48:50Z","git_url":"git://github.com/liewegas/ceph.git","ssh_url":"git@github.com:liewegas/ceph.git","clone_url":"https://github.com/liewegas/ceph.git","svn_url":"https://github.com/liewegas/ceph","homepage":"http://ceph.newdream.net/","size":343262,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":6,"watchers":15,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"20caf99856d529d533bd5a93fc675ee26e0239a0","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-12-21T02:20:53Z","pushed_at":"2018-12-21T03:48:55Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":339051,"stargazers_count":5421,"watchers_count":5421,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2846,"mirror_url":null,"archived":false,"open_issues_count":643,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2846,"open_issues":643,"watchers":5421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25009"},"html":{"href":"https://github.com/ceph/ceph/pull/25009"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/25009"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/25009/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25009/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25009/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/506fcd68331d6319d79256d57d37c239555eb95b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"liewegas"}}