{"action":"created","comment":{"url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/comments/166120622","pull_request_review_id":94142368,"id":166120622,"diff_hunk":"@@ -19,7 +19,7 @@ interface StateProps {\n }\n interface OwnProps {\n   onlyTransactionParameters?: boolean;\n-  Modal: typeof ConfirmationModal;\n+  Modal: typeof ConfirmationModalTemplate;","path":"common/components/SendButtonFactory/SendButtonFactory.tsx","position":14,"original_position":14,"commit_id":"e7ad06ee87ea8e63bbc4bc743fb5f775f8ad419b","original_commit_id":"e7ad06ee87ea8e63bbc4bc743fb5f775f8ad419b","user":{"login":"HenryNguyen5","id":6404866,"avatar_url":"https://avatars2.githubusercontent.com/u/6404866?v=4","gravatar_id":"","url":"https://api.github.com/users/HenryNguyen5","html_url":"https://github.com/HenryNguyen5","followers_url":"https://api.github.com/users/HenryNguyen5/followers","following_url":"https://api.github.com/users/HenryNguyen5/following{/other_user}","gists_url":"https://api.github.com/users/HenryNguyen5/gists{/gist_id}","starred_url":"https://api.github.com/users/HenryNguyen5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenryNguyen5/subscriptions","organizations_url":"https://api.github.com/users/HenryNguyen5/orgs","repos_url":"https://api.github.com/users/HenryNguyen5/repos","events_url":"https://api.github.com/users/HenryNguyen5/events{/privacy}","received_events_url":"https://api.github.com/users/HenryNguyen5/received_events","type":"User","site_admin":false},"body":"And also is not used anymore, breaking #940","created_at":"2018-02-05T21:41:02Z","updated_at":"2018-02-05T21:45:43Z","html_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/928#discussion_r166120622","pull_request_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/comments/166120622"},"html":{"href":"https://github.com/MyCryptoHQ/MyCrypto/pull/928#discussion_r166120622"},"pull_request":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928"}},"in_reply_to_id":166120556},"pull_request":{"url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928","id":165370659,"html_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/928","diff_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/928.diff","patch_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/928.patch","issue_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/928","number":928,"state":"open","locked":false,"title":"Confirm TX Modal Upgrades","user":{"login":"james-prado","id":13836920,"avatar_url":"https://avatars0.githubusercontent.com/u/13836920?v=4","gravatar_id":"","url":"https://api.github.com/users/james-prado","html_url":"https://github.com/james-prado","followers_url":"https://api.github.com/users/james-prado/followers","following_url":"https://api.github.com/users/james-prado/following{/other_user}","gists_url":"https://api.github.com/users/james-prado/gists{/gist_id}","starred_url":"https://api.github.com/users/james-prado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-prado/subscriptions","organizations_url":"https://api.github.com/users/james-prado/orgs","repos_url":"https://api.github.com/users/james-prado/repos","events_url":"https://api.github.com/users/james-prado/events{/privacy}","received_events_url":"https://api.github.com/users/james-prado/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/MyCryptoHQ/MyCrypto/issues/851\r\n\r\n- [x] Prioritize important information, like 'from', 'to', and 'amount / value being sent'\r\n- [x] Separate technical details from important information\r\n- [x] Display usd conversions along side amounts & transaction fees\r\n- [x] Update the copy\r\n\r\nalso: \r\n\r\n- Add details section\r\n- Display which contract tokens are sent through\r\n- Update `<Identicon />` styles\r\n- Animate Modal transition in & out \r\n\t- Right now it's just a simple fade, maybe it should scale instead?\r\n- Add new font [Roboto Mono](https://fonts.google.com/specimen/Roboto+Mono)\r\n\t- Provides more font-weights over our current monospaced fonts\r\n\t- Pairs really well with [Lato](https://fonts.google.com/specimen/Lato) (our primary font\r\n- Replace `.less` fonts file with `.sass`\r\n- Update generic `<Modal />` styles\r\n- Round all amounts to 6 decimal places\r\n\t- the raw value (decimals and all) is displayed in details\r\n- Add white fade on text overflow (when scrollbars appear)\r\n<img width=\"511\" alt=\"screen shot 2018-02-03 at 12 20 20 am\" src=\"https://user-images.githubusercontent.com/13836920/35763353-421225f8-0878-11e8-96dd-234d092a5c2a.png\">\r\n","created_at":"2018-01-26T14:04:50Z","updated_at":"2018-02-05T21:45:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b5db4d9e991a0a3a1ca51fcd8e28006debf860","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wbobeirne","id":649992,"avatar_url":"https://avatars0.githubusercontent.com/u/649992?v=4","gravatar_id":"","url":"https://api.github.com/users/wbobeirne","html_url":"https://github.com/wbobeirne","followers_url":"https://api.github.com/users/wbobeirne/followers","following_url":"https://api.github.com/users/wbobeirne/following{/other_user}","gists_url":"https://api.github.com/users/wbobeirne/gists{/gist_id}","starred_url":"https://api.github.com/users/wbobeirne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbobeirne/subscriptions","organizations_url":"https://api.github.com/users/wbobeirne/orgs","repos_url":"https://api.github.com/users/wbobeirne/repos","events_url":"https://api.github.com/users/wbobeirne/events{/privacy}","received_events_url":"https://api.github.com/users/wbobeirne/received_events","type":"User","site_admin":false},{"login":"dternyak","id":7861465,"avatar_url":"https://avatars2.githubusercontent.com/u/7861465?v=4","gravatar_id":"","url":"https://api.github.com/users/dternyak","html_url":"https://github.com/dternyak","followers_url":"https://api.github.com/users/dternyak/followers","following_url":"https://api.github.com/users/dternyak/following{/other_user}","gists_url":"https://api.github.com/users/dternyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dternyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dternyak/subscriptions","organizations_url":"https://api.github.com/users/dternyak/orgs","repos_url":"https://api.github.com/users/dternyak/repos","events_url":"https://api.github.com/users/dternyak/events{/privacy}","received_events_url":"https://api.github.com/users/dternyak/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928/commits","review_comments_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928/comments","review_comment_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/928/comments","statuses_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/statuses/e7ad06ee87ea8e63bbc4bc743fb5f775f8ad419b","head":{"label":"MyCryptoHQ:update-tx-modal","ref":"update-tx-modal","sha":"e7ad06ee87ea8e63bbc4bc743fb5f775f8ad419b","user":{"login":"MyCryptoHQ","id":32279762,"avatar_url":"https://avatars1.githubusercontent.com/u/32279762?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCryptoHQ","html_url":"https://github.com/MyCryptoHQ","followers_url":"https://api.github.com/users/MyCryptoHQ/followers","following_url":"https://api.github.com/users/MyCryptoHQ/following{/other_user}","gists_url":"https://api.github.com/users/MyCryptoHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCryptoHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCryptoHQ/subscriptions","organizations_url":"https://api.github.com/users/MyCryptoHQ/orgs","repos_url":"https://api.github.com/users/MyCryptoHQ/repos","events_url":"https://api.github.com/users/MyCryptoHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MyCryptoHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":75510908,"name":"MyCrypto","full_name":"MyCryptoHQ/MyCrypto","owner":{"login":"MyCryptoHQ","id":32279762,"avatar_url":"https://avatars1.githubusercontent.com/u/32279762?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCryptoHQ","html_url":"https://github.com/MyCryptoHQ","followers_url":"https://api.github.com/users/MyCryptoHQ/followers","following_url":"https://api.github.com/users/MyCryptoHQ/following{/other_user}","gists_url":"https://api.github.com/users/MyCryptoHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCryptoHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCryptoHQ/subscriptions","organizations_url":"https://api.github.com/users/MyCryptoHQ/orgs","repos_url":"https://api.github.com/users/MyCryptoHQ/repos","events_url":"https://api.github.com/users/MyCryptoHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MyCryptoHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MyCryptoHQ/MyCrypto","description":null,"fork":false,"url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto","forks_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/forks","keys_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/teams","hooks_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/hooks","issue_events_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/events{/number}","events_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/events","assignees_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/assignees{/user}","branches_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/branches{/branch}","tags_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/tags","blobs_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/statuses/{sha}","languages_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/languages","stargazers_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/stargazers","contributors_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/contributors","subscribers_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/subscribers","subscription_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/subscription","commits_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/contents/{+path}","compare_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/merges","archive_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/downloads","issues_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues{/number}","pulls_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls{/number}","milestones_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/milestones{/number}","notifications_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/labels{/name}","releases_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/releases{/id}","deployments_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/deployments","created_at":"2016-12-04T01:35:27Z","updated_at":"2018-02-01T23:23:20Z","pushed_at":"2018-02-05T20:41:59Z","git_url":"git://github.com/MyCryptoHQ/MyCrypto.git","ssh_url":"git@github.com:MyCryptoHQ/MyCrypto.git","clone_url":"https://github.com/MyCryptoHQ/MyCrypto.git","svn_url":"https://github.com/MyCryptoHQ/MyCrypto","homepage":"","size":8199,"stargazers_count":285,"watchers_count":285,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":119,"open_issues":100,"watchers":285,"default_branch":"develop"}},"base":{"label":"MyCryptoHQ:develop","ref":"develop","sha":"13d522f3f5ba7108093f24394b4c5b303e5034c4","user":{"login":"MyCryptoHQ","id":32279762,"avatar_url":"https://avatars1.githubusercontent.com/u/32279762?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCryptoHQ","html_url":"https://github.com/MyCryptoHQ","followers_url":"https://api.github.com/users/MyCryptoHQ/followers","following_url":"https://api.github.com/users/MyCryptoHQ/following{/other_user}","gists_url":"https://api.github.com/users/MyCryptoHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCryptoHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCryptoHQ/subscriptions","organizations_url":"https://api.github.com/users/MyCryptoHQ/orgs","repos_url":"https://api.github.com/users/MyCryptoHQ/repos","events_url":"https://api.github.com/users/MyCryptoHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MyCryptoHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":75510908,"name":"MyCrypto","full_name":"MyCryptoHQ/MyCrypto","owner":{"login":"MyCryptoHQ","id":32279762,"avatar_url":"https://avatars1.githubusercontent.com/u/32279762?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCryptoHQ","html_url":"https://github.com/MyCryptoHQ","followers_url":"https://api.github.com/users/MyCryptoHQ/followers","following_url":"https://api.github.com/users/MyCryptoHQ/following{/other_user}","gists_url":"https://api.github.com/users/MyCryptoHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCryptoHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCryptoHQ/subscriptions","organizations_url":"https://api.github.com/users/MyCryptoHQ/orgs","repos_url":"https://api.github.com/users/MyCryptoHQ/repos","events_url":"https://api.github.com/users/MyCryptoHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MyCryptoHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MyCryptoHQ/MyCrypto","description":null,"fork":false,"url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto","forks_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/forks","keys_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/teams","hooks_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/hooks","issue_events_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/events{/number}","events_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/events","assignees_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/assignees{/user}","branches_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/branches{/branch}","tags_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/tags","blobs_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/statuses/{sha}","languages_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/languages","stargazers_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/stargazers","contributors_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/contributors","subscribers_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/subscribers","subscription_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/subscription","commits_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/contents/{+path}","compare_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/merges","archive_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/downloads","issues_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues{/number}","pulls_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls{/number}","milestones_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/milestones{/number}","notifications_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/labels{/name}","releases_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/releases{/id}","deployments_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/deployments","created_at":"2016-12-04T01:35:27Z","updated_at":"2018-02-01T23:23:20Z","pushed_at":"2018-02-05T20:41:59Z","git_url":"git://github.com/MyCryptoHQ/MyCrypto.git","ssh_url":"git@github.com:MyCryptoHQ/MyCrypto.git","clone_url":"https://github.com/MyCryptoHQ/MyCrypto.git","svn_url":"https://github.com/MyCryptoHQ/MyCrypto","homepage":"","size":8199,"stargazers_count":285,"watchers_count":285,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":119,"open_issues":100,"watchers":285,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928"},"html":{"href":"https://github.com/MyCryptoHQ/MyCrypto/pull/928"},"issue":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/928"},"comments":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/928/comments"},"review_comments":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928/comments"},"review_comment":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/928/commits"},"statuses":{"href":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/statuses/e7ad06ee87ea8e63bbc4bc743fb5f775f8ad419b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"HenryNguyen5"}}