{"action":"closed","number":302,"pull_request":{"url":"https://api.github.com/repos/windup/windup-rulesets/pulls/302","id":166557935,"html_url":"https://github.com/windup/windup-rulesets/pull/302","diff_url":"https://github.com/windup/windup-rulesets/pull/302.diff","patch_url":"https://github.com/windup/windup-rulesets/pull/302.patch","issue_url":"https://api.github.com/repos/windup/windup-rulesets/issues/302","number":302,"state":"closed","locked":false,"title":"WINDUPRULE-103 Missing EAP 4+5 rules","user":{"login":"mrizzi","id":7288588,"avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"body":"This PR contains all the implementations for the sub-issues of the [WINDUPRULE-103](https://issues.jboss.org/browse/WINDUPRULE-103).\r\nFor every issue i reported what i've changed from the request in JIRA.\r\n\r\n[WINDUPRULE-182](https://issues.jboss.org/browse/WINDUPRULE-182)\r\nUsed link to redhat.com, NOT docs.jboss.org\r\n\r\n[WINDUPRULE-183](https://issues.jboss.org/browse/WINDUPRULE-183)\r\nAdded link to JBoss EAP 6.4 Migration guide\r\n\r\n[WINDUPRULE-185](https://issues.jboss.org/browse/WINDUPRULE-185)\r\nAdded link to JBoss EAP 6.4 Migration guide\r\n\r\n[WINDUPRULE-187](https://issues.jboss.org/browse/WINDUPRULE-187)\r\nAdded link to JBoss EAP 6.4 Migration guide\r\n\r\n[WINDUPRULE-188](https://issues.jboss.org/browse/WINDUPRULE-188)\r\nlink to javadoc for class JMX to complete the case\r\n\r\n[WINDUPRULE-190](https://issues.jboss.org/browse/WINDUPRULE-190)\r\nAdded link to JBoss EAP 6.4 Migration guide\r\nAdded link to JBoss EAP 6.4 Development guide\r\nAdded link to JBoss EAP 7.1 Development guide\r\n\r\n[WINDUPRULE-191](https://issues.jboss.org/browse/WINDUPRULE-191)\r\nConsidered a technology since no hint has been provided\r\nThis rule seems the use case of the \"technologies\" rules (in this case the clustering one as Marek wrote) since the rule's requirement is only to identify an high-available application w/o providing any further hint to the user and it has no impact on the analysis since requested effort is 0 and category optional.\r\nThe https://github.com/windup/windup-rulesets/blob/master/rules-reviewed/technology-usage/clustering.windup.xml#L16-L25 will be available in the 4.1.0 release.\r\n\r\n[WINDUPRULE-193](https://issues.jboss.org/browse/WINDUPRULE-193)\r\nRemoved one link due to \"Retired: This document is a duplicate or contains incorrect/outdated information.\"\r\n\r\n[WINDUPRULE-184](https://issues.jboss.org/browse/WINDUPRULE-184)\r\nAdded link to JBoss EAP 6.4 Development guide\r\nRule `jboss-eap5-java-01000` is just a classification so it has not been changed but rule `jboss-eap5-java-05000`, just like rule `jboss-eap5-java-04000`, is wrong so it has been fixed.\r\n","created_at":"2018-02-01T14:50:41Z","updated_at":"2018-02-06T19:18:20Z","closed_at":"2018-02-06T19:18:20Z","merged_at":"2018-02-06T19:18:20Z","merge_commit_sha":"bd39504186422fa9dbe27fb68db7a441250356a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jsight","id":1181549,"avatar_url":"https://avatars3.githubusercontent.com/u/1181549?v=4","gravatar_id":"","url":"https://api.github.com/users/jsight","html_url":"https://github.com/jsight","followers_url":"https://api.github.com/users/jsight/followers","following_url":"https://api.github.com/users/jsight/following{/other_user}","gists_url":"https://api.github.com/users/jsight/gists{/gist_id}","starred_url":"https://api.github.com/users/jsight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsight/subscriptions","organizations_url":"https://api.github.com/users/jsight/orgs","repos_url":"https://api.github.com/users/jsight/repos","events_url":"https://api.github.com/users/jsight/events{/privacy}","received_events_url":"https://api.github.com/users/jsight/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/302/commits","review_comments_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/302/comments","review_comment_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/issues/302/comments","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/e0a99771778cf08644ceaafd06c40d03ec804df4","head":{"label":"mrizzi:WINDUPRULE-103","ref":"WINDUPRULE-103","sha":"e0a99771778cf08644ceaafd06c40d03ec804df4","user":{"login":"mrizzi","id":7288588,"avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"repo":{"id":80025343,"name":"windup-rulesets","full_name":"mrizzi/windup-rulesets","owner":{"login":"mrizzi","id":7288588,"avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrizzi/windup-rulesets","description":"Windup rules and rulesets contributed by community.","fork":true,"url":"https://api.github.com/repos/mrizzi/windup-rulesets","forks_url":"https://api.github.com/repos/mrizzi/windup-rulesets/forks","keys_url":"https://api.github.com/repos/mrizzi/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrizzi/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrizzi/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/mrizzi/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/mrizzi/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/mrizzi/windup-rulesets/events","assignees_url":"https://api.github.com/repos/mrizzi/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/mrizzi/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/mrizzi/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/mrizzi/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrizzi/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrizzi/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrizzi/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrizzi/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/mrizzi/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/mrizzi/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/mrizzi/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/mrizzi/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/mrizzi/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/mrizzi/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrizzi/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrizzi/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrizzi/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrizzi/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/mrizzi/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrizzi/windup-rulesets/merges","archive_url":"https://api.github.com/repos/mrizzi/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrizzi/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/mrizzi/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/mrizzi/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/mrizzi/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/mrizzi/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrizzi/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/mrizzi/windup-rulesets/releases{/id}","deployments_url":"https://api.github.com/repos/mrizzi/windup-rulesets/deployments","created_at":"2017-01-25T15:07:28Z","updated_at":"2017-06-05T07:44:10Z","pushed_at":"2018-02-06T14:35:57Z","git_url":"git://github.com/mrizzi/windup-rulesets.git","ssh_url":"git@github.com:mrizzi/windup-rulesets.git","clone_url":"https://github.com/mrizzi/windup-rulesets.git","svn_url":"https://github.com/mrizzi/windup-rulesets","homepage":"http://windup.jboss.org","size":96012,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"351a84a96e4890acf00a13898ef77d547a56e8bc","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars1.githubusercontent.com/u/4266383?v=4","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":23937058,"name":"windup-rulesets","full_name":"windup/windup-rulesets","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars1.githubusercontent.com/u/4266383?v=4","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup-rulesets","description":"Windup rules and rulesets contributed by community.","fork":false,"url":"https://api.github.com/repos/windup/windup-rulesets","forks_url":"https://api.github.com/repos/windup/windup-rulesets/forks","keys_url":"https://api.github.com/repos/windup/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/windup/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/windup/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup-rulesets/events","assignees_url":"https://api.github.com/repos/windup/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/windup/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/windup/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/windup/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/windup/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/windup/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/windup/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup-rulesets/merges","archive_url":"https://api.github.com/repos/windup/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/windup/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup-rulesets/releases{/id}","deployments_url":"https://api.github.com/repos/windup/windup-rulesets/deployments","created_at":"2014-09-11T21:51:19Z","updated_at":"2017-11-22T16:15:40Z","pushed_at":"2018-02-06T19:18:20Z","git_url":"git://github.com/windup/windup-rulesets.git","ssh_url":"git@github.com:windup/windup-rulesets.git","clone_url":"https://github.com/windup/windup-rulesets.git","svn_url":"https://github.com/windup/windup-rulesets","homepage":"http://windup.jboss.org","size":95997,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":28,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/302"},"html":{"href":"https://github.com/windup/windup-rulesets/pull/302"},"issue":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/302"},"comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup-rulesets/statuses/e0a99771778cf08644ceaafd06c40d03ec804df4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mrizzi","id":7288588,"avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":577,"deletions":14,"changed_files":13}}
{"actor":{"display_login":"mrizzi"}}