{"action":"closed","number":2409,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/2409","id":226635390,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjM1Mzkw","html_url":"https://github.com/grpc/grpc-go/pull/2409","diff_url":"https://github.com/grpc/grpc-go/pull/2409.diff","patch_url":"https://github.com/grpc/grpc-go/pull/2409.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/2409","number":2409,"state":"closed","locked":false,"title":"client: block RPCs early until the resolver has returned addresses","user":{"login":"dfawley","id":26072277,"node_id":"MDQ6VXNlcjI2MDcyMjc3","avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"body":"This allows the initial RPC(s) an opportunity to apply settings from the service config; without this change we would still block, but only after observing the current service config settings.\r\n","created_at":"2018-10-29T16:49:16Z","updated_at":"2018-11-09T21:53:48Z","closed_at":"2018-11-09T21:53:47Z","merged_at":"2018-11-09T21:53:47Z","merge_commit_sha":"a612bb6847e6fe2e1932207096843e2784673767","assignee":{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"assignees":[{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":586671344,"node_id":"MDU6TGFiZWw1ODY2NzEzNDQ=","url":"https://api.github.com/repos/grpc/grpc-go/labels/Type:%20Bug","name":"Type: Bug","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/grpc/grpc-go/milestones/15","html_url":"https://github.com/grpc/grpc-go/milestone/15","labels_url":"https://api.github.com/repos/grpc/grpc-go/milestones/15/labels","id":3770154,"node_id":"MDk6TWlsZXN0b25lMzc3MDE1NA==","number":15,"title":"1.17 Release","description":"","creator":{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":7,"state":"open","created_at":"2018-10-25T23:40:53Z","updated_at":"2018-11-09T21:53:48Z","due_on":"2018-12-04T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2409/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2409/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/2409/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/712484af4bc9ecf4b129525d0c5f2a648631ecb2","head":{"label":"dfawley:wait_for_resolver","ref":"wait_for_resolver","sha":"712484af4bc9ecf4b129525d0c5f2a648631ecb2","user":{"login":"dfawley","id":26072277,"node_id":"MDQ6VXNlcjI2MDcyMjc3","avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"repo":{"id":83580665,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU4MDY2NQ==","name":"grpc-go","full_name":"dfawley/grpc-go","private":false,"owner":{"login":"dfawley","id":26072277,"node_id":"MDQ6VXNlcjI2MDcyMjc3","avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dfawley/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/dfawley/grpc-go","forks_url":"https://api.github.com/repos/dfawley/grpc-go/forks","keys_url":"https://api.github.com/repos/dfawley/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfawley/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfawley/grpc-go/teams","hooks_url":"https://api.github.com/repos/dfawley/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/dfawley/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/dfawley/grpc-go/events","assignees_url":"https://api.github.com/repos/dfawley/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/dfawley/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/dfawley/grpc-go/tags","blobs_url":"https://api.github.com/repos/dfawley/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfawley/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfawley/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfawley/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfawley/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/dfawley/grpc-go/languages","stargazers_url":"https://api.github.com/repos/dfawley/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/dfawley/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/dfawley/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/dfawley/grpc-go/subscription","commits_url":"https://api.github.com/repos/dfawley/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfawley/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfawley/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfawley/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfawley/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/dfawley/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfawley/grpc-go/merges","archive_url":"https://api.github.com/repos/dfawley/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfawley/grpc-go/downloads","issues_url":"https://api.github.com/repos/dfawley/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/dfawley/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/dfawley/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/dfawley/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfawley/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/dfawley/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/dfawley/grpc-go/deployments","created_at":"2017-03-01T17:14:37Z","updated_at":"2018-11-07T19:00:17Z","pushed_at":"2018-11-08T23:40:20Z","git_url":"git://github.com/dfawley/grpc-go.git","ssh_url":"git@github.com:dfawley/grpc-go.git","clone_url":"https://github.com/dfawley/grpc-go.git","svn_url":"https://github.com/dfawley/grpc-go","homepage":"","size":6982,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"59a2cfbdf9272f6334fe4856b6e7c8d212845b3d","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkwNw==","name":"grpc-go","full_name":"grpc/grpc-go","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2018-11-09T12:21:11Z","pushed_at":"2018-11-09T21:53:47Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":7635,"stargazers_count":6800,"watchers_count":6800,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1319,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1319,"open_issues":105,"watchers":6800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2409"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2409"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2409"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2409/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2409/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2409/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/712484af4bc9ecf4b129525d0c5f2a648631ecb2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dfawley","id":26072277,"node_id":"MDQ6VXNlcjI2MDcyMjc3","avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"maintainer_can_modify":false,"commits":4,"additions":96,"deletions":15,"changed_files":4}}
{"actor":{"display_login":"dfawley"}}