{"action":"closed","number":24627,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24627","id":217608973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjA4OTcz","html_url":"https://github.com/cms-sw/cmssw/pull/24627","diff_url":"https://github.com/cms-sw/cmssw/pull/24627.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/24627.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24627","number":24627,"state":"closed","locked":false,"title":"Added unit test to make sure poisoned datafiles are not read from release","user":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"body":"New `git-cms-checkdeps` ( https://github.com/cms-sw/cms-git-tools/commit/612fa046f52ef1db7335b8279fc3e987d784e93a ) now poisons deleted datafile by creating a symlink to an emptry directory. This Allow us to make sure that a deleted datafile (from a src directory) is not read from `CMSSW_RELEASE_BASE` \r\n\r\nThis unit test simulates the `git-cms-checkdeps` behaviour and poisons Geometry/CMSCommonData/data/materials.xml ","created_at":"2018-09-24T10:15:31Z","updated_at":"2018-09-25T08:45:37Z","closed_at":"2018-09-25T08:45:37Z","merged_at":"2018-09-25T08:45:37Z","merge_commit_sha":"fd7eaa2c95abf94be55fd57410f9f5884424194a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"node_id":"MDU6TGFiZWw4ODY0NTQ3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":290512994,"node_id":"MDU6TGFiZWwyOTA1MTI5OTQ=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-approved","name":"db-approved","color":"2cbe4e","default":false},{"id":53149121,"node_id":"MDU6TGFiZWw1MzE0OTEyMQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"2cbe4e","default":false},{"id":290514704,"node_id":"MDU6TGFiZWwyOTA1MTQ3MDQ=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-approved","name":"orp-approved","color":"2cbe4e","default":false},{"id":56131195,"node_id":"MDU6TGFiZWw1NjEzMTE5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77","html_url":"https://github.com/cms-sw/cmssw/milestone/77","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77/labels","id":3502981,"node_id":"MDk6TWlsZXN0b25lMzUwMjk4MQ==","number":77,"title":"CMSSW_10_3_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":64,"closed_issues":605,"state":"open","created_at":"2018-07-17T14:14:12Z","updated_at":"2018-09-25T08:45:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24627/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24627/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24627/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/74baff37c43ad44b1a8f13c98ae5b01b4a4e0a5a","head":{"label":"smuzaffar:103X-poisoned-datafiles","ref":"103X-poisoned-datafiles","sha":"74baff37c43ad44b1a8f13c98ae5b01b4a4e0a5a","user":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"repo":{"id":118622860,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MjI4NjA=","name":"cmssw","full_name":"smuzaffar/cmssw","private":false,"owner":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smuzaffar/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/smuzaffar/cmssw","forks_url":"https://api.github.com/repos/smuzaffar/cmssw/forks","keys_url":"https://api.github.com/repos/smuzaffar/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smuzaffar/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smuzaffar/cmssw/teams","hooks_url":"https://api.github.com/repos/smuzaffar/cmssw/hooks","issue_events_url":"https://api.github.com/repos/smuzaffar/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/smuzaffar/cmssw/events","assignees_url":"https://api.github.com/repos/smuzaffar/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/smuzaffar/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/smuzaffar/cmssw/tags","blobs_url":"https://api.github.com/repos/smuzaffar/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smuzaffar/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smuzaffar/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/smuzaffar/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smuzaffar/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/smuzaffar/cmssw/languages","stargazers_url":"https://api.github.com/repos/smuzaffar/cmssw/stargazers","contributors_url":"https://api.github.com/repos/smuzaffar/cmssw/contributors","subscribers_url":"https://api.github.com/repos/smuzaffar/cmssw/subscribers","subscription_url":"https://api.github.com/repos/smuzaffar/cmssw/subscription","commits_url":"https://api.github.com/repos/smuzaffar/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/smuzaffar/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/smuzaffar/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/smuzaffar/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/smuzaffar/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/smuzaffar/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smuzaffar/cmssw/merges","archive_url":"https://api.github.com/repos/smuzaffar/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smuzaffar/cmssw/downloads","issues_url":"https://api.github.com/repos/smuzaffar/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/smuzaffar/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/smuzaffar/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/smuzaffar/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smuzaffar/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/smuzaffar/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/smuzaffar/cmssw/deployments","created_at":"2018-01-23T14:39:55Z","updated_at":"2018-05-23T08:51:57Z","pushed_at":"2018-09-24T10:17:26Z","git_url":"git://github.com/smuzaffar/cmssw.git","ssh_url":"git@github.com:smuzaffar/cmssw.git","clone_url":"https://github.com/smuzaffar/cmssw.git","svn_url":"https://github.com/smuzaffar/cmssw","homepage":"http://cms-sw.github.io/","size":1034245,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"d87c6815e3c27fd7a3d18850cb4f81ec513186d1","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","private":false,"owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-09-25T08:34:04Z","pushed_at":"2018-09-25T08:45:37Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1037162,"stargazers_count":580,"watchers_count":580,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2695,"mirror_url":null,"archived":false,"open_issues_count":480,"license":null,"forks":2695,"open_issues":480,"watchers":580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24627"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/24627"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/24627"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/24627/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24627/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24627/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/74baff37c43ad44b1a8f13c98ae5b01b4a4e0a5a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"comments":14,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":19,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"cmsbuild"}}