{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/210734861","pull_request_review_id":147015350,"id":210734861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDczNDg2MQ==","diff_hunk":"@@ -400,6 +400,36 @@ def dropna(self):\n \n         return self[~self.isna()]\n \n+    def shift(self, periods=1):\n+        # type: (int) -> ExtensionArray\n+        \"\"\"\n+        Shift values by desired number.\n+\n+        Newly introduced missing values are filled with\n+        ``self.dtype.na_value``.\n+\n+        Parameters\n+        ----------\n+        periods : int, default 1\n+            The number of periods to shift. Negative values are allowed\n+            for shifting backwards.\n+\n+        Returns\n+        -------\n+        shifted : ExtensionArray\n+        \"\"\"\n+        if periods == 0:\n+            return self.copy()","path":"pandas/core/arrays/base.py","position":23,"original_position":23,"commit_id":"c4b0b9736e93f0ae1e397c0217281594dfa814cc","original_commit_id":"c4b0b9736e93f0ae1e397c0217281594dfa814cc","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"I personally find that strange behaviour to not copy then (it would be more logical to know that the result is always a copy, regardless the value of periods IMO)\r\n","created_at":"2018-08-16T20:41:21Z","updated_at":"2018-08-16T20:41:21Z","html_url":"https://github.com/pandas-dev/pandas/pull/22387#discussion_r210734861","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/210734861"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22387#discussion_r210734861"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387"}},"in_reply_to_id":210718613},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387","id":208910058,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTEwMDU4","html_url":"https://github.com/pandas-dev/pandas/pull/22387","diff_url":"https://github.com/pandas-dev/pandas/pull/22387.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/22387.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22387","number":22387,"state":"open","locked":false,"title":"Support NDFrame.shift with EAs","user":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"body":"Uses take internally.\r\n\r\nCloses https://github.com/pandas-dev/pandas/issues/22386\r\n\r\nOne question: do we want to add `shift` to the interface, and dispatch to that? This just does the right thing at the block level, by writing a `shift` that'll work with an ExtensionArray.\r\n\r\nCategoricalBlock still overrides `.shift` to call `Categorical.shift`, which uses a slightly faster implementation based around the codes and `np.roll` (~1.5-2x faster based on microbenchmarks)`.\r\n\r\nWe could add move `ExtensionBlock.shift `to `ExtensionArray.shift`, and just call that from ExtensionBlock. Then we can delete CategoricalBlock.shift.\r\n\r\nI'm 50/50 on whether it's worth adding to the interface.","created_at":"2018-08-16T16:06:27Z","updated_at":"2018-08-16T20:41:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ec4e17c3b1cb1c8871e914ab3337f07ce5ad97e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":849023693,"node_id":"MDU6TGFiZWw4NDkwMjM2OTM=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/ExtensionArray","name":"ExtensionArray","color":"6138b5","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55","html_url":"https://github.com/pandas-dev/pandas/milestone/55","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55/labels","id":3228419,"node_id":"MDk6TWlsZXN0b25lMzIyODQxOQ==","number":55,"title":"0.24.0","description":"","creator":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"open_issues":121,"closed_issues":499,"state":"open","created_at":"2018-03-29T12:00:12Z","updated_at":"2018-08-16T19:53:32Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22387/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/c4b0b9736e93f0ae1e397c0217281594dfa814cc","head":{"label":"TomAugspurger:ea-shift","ref":"ea-shift","sha":"c4b0b9736e93f0ae1e397c0217281594dfa814cc","user":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"repo":{"id":9450481,"node_id":"MDEwOlJlcG9zaXRvcnk5NDUwNDgx","name":"pandas","full_name":"TomAugspurger/pandas","owner":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomAugspurger/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/TomAugspurger/pandas","forks_url":"https://api.github.com/repos/TomAugspurger/pandas/forks","keys_url":"https://api.github.com/repos/TomAugspurger/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomAugspurger/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomAugspurger/pandas/teams","hooks_url":"https://api.github.com/repos/TomAugspurger/pandas/hooks","issue_events_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/TomAugspurger/pandas/events","assignees_url":"https://api.github.com/repos/TomAugspurger/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/TomAugspurger/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/TomAugspurger/pandas/tags","blobs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomAugspurger/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomAugspurger/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomAugspurger/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/TomAugspurger/pandas/languages","stargazers_url":"https://api.github.com/repos/TomAugspurger/pandas/stargazers","contributors_url":"https://api.github.com/repos/TomAugspurger/pandas/contributors","subscribers_url":"https://api.github.com/repos/TomAugspurger/pandas/subscribers","subscription_url":"https://api.github.com/repos/TomAugspurger/pandas/subscription","commits_url":"https://api.github.com/repos/TomAugspurger/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomAugspurger/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomAugspurger/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomAugspurger/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/TomAugspurger/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomAugspurger/pandas/merges","archive_url":"https://api.github.com/repos/TomAugspurger/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomAugspurger/pandas/downloads","issues_url":"https://api.github.com/repos/TomAugspurger/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/TomAugspurger/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/TomAugspurger/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/TomAugspurger/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomAugspurger/pandas/labels{/name}","releases_url":"https://api.github.com/repos/TomAugspurger/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/TomAugspurger/pandas/deployments","created_at":"2013-04-15T14:23:40Z","updated_at":"2018-04-03T18:53:14Z","pushed_at":"2018-08-16T19:36:44Z","git_url":"git://github.com/TomAugspurger/pandas.git","ssh_url":"git@github.com:TomAugspurger/pandas.git","clone_url":"https://github.com/TomAugspurger/pandas.git","svn_url":"https://github.com/TomAugspurger/pandas","homepage":"http://pandas.pydata.org","size":128350,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"b5d81cfe43eeccfc3641aa9578097f726da9ce9d","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-08-16T18:17:04Z","pushed_at":"2018-08-16T20:37:32Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":129496,"stargazers_count":15594,"watchers_count":15594,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6285,"mirror_url":null,"archived":false,"open_issues_count":2732,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6285,"open_issues":2732,"watchers":15594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22387"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22387"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22387/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22387/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/c4b0b9736e93f0ae1e397c0217281594dfa814cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jorisvandenbossche"}}