{"action":"created","comment":{"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments/225192983","pull_request_review_id":164740382,"id":225192983,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTE5Mjk4Mw==","diff_hunk":"@@ -15,18 +15,21 @@\n     public static final SolrClientCache SOLR_CLIENT_CACHE = new SolrClientCache();\n \n     @Bean\n-    public SolrClient solrClientBioentities(@Value(\"${solr.host}\") String solrHost) {\n-        return new HttpSolrClient.Builder(\"http://\" + solrHost + \":8983/solr/bioentities\").build();\n+    public SolrClient solrClientBioentities(@Value(\"${solr.host}\") String solrHost,\n+                                            @Value(\"${solr.port}\") String solrPort) {\n+        return new HttpSolrClient.Builder(\"http://\" + solrHost + \":\" + solrPort + \"/solr/bioentities\").build();\n     }\n \n     @Bean\n-    public SolrClient solrClientAnalytics(@Value(\"${solr.host}\") String solrHost) {\n-        return new HttpSolrClient.Builder(\"http://\" + solrHost + \":8983/solr/analytics\").build();\n+    public SolrClient solrClientAnalytics(@Value(\"${solr.host}\") String solrHost,\n+                                          @Value(\"${solr.port}\") String solrPort) {\n+        return new HttpSolrClient.Builder(\"http://\" + solrHost + \":\" + solrPort + \"/solr/analytics\").build();\n     }\n \n     @Bean\n-    public CloudSolrClient cloudSolrClient(@Value(\"${zk.host}\") String zkHost) {\n-        return new CloudSolrClient.Builder().withZkHost(zkHost + \":2181\").build();\n+    public CloudSolrClient cloudSolrClient(@Value(\"${zk.host}\") String zkHost,\n+                                           @Value(\"${zk.port}\") String zkPort) {\n+        return new CloudSolrClient.Builder().withZkHost(zkHost + \":\" + zkPort).build();\n //        return SOLR_CLIENT_CACHE.getCloudSolrClient(zkHost);","path":"base/src/main/java/uk/ac/ebi/atlas/configuration/SolrConfig.java","position":25,"original_position":25,"commit_id":"8177d6d76edcda92f33a4f07d55add566b0177d1","original_commit_id":"8177d6d76edcda92f33a4f07d55add566b0177d1","user":{"login":"monicajianu","id":5923538,"node_id":"MDQ6VXNlcjU5MjM1Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5923538?v=4","gravatar_id":"","url":"https://api.github.com/users/monicajianu","html_url":"https://github.com/monicajianu","followers_url":"https://api.github.com/users/monicajianu/followers","following_url":"https://api.github.com/users/monicajianu/following{/other_user}","gists_url":"https://api.github.com/users/monicajianu/gists{/gist_id}","starred_url":"https://api.github.com/users/monicajianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monicajianu/subscriptions","organizations_url":"https://api.github.com/users/monicajianu/orgs","repos_url":"https://api.github.com/users/monicajianu/repos","events_url":"https://api.github.com/users/monicajianu/events{/privacy}","received_events_url":"https://api.github.com/users/monicajianu/received_events","type":"User","site_admin":false},"body":"Is commented out line still needed?","created_at":"2018-10-15T14:44:49Z","updated_at":"2018-10-15T14:44:50Z","html_url":"https://github.com/ebi-gene-expression-group/atlas/pull/171#discussion_r225192983","pull_request_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments/225192983"},"html":{"href":"https://github.com/ebi-gene-expression-group/atlas/pull/171#discussion_r225192983"},"pull_request":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171","id":218041749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDQxNzQ5","html_url":"https://github.com/ebi-gene-expression-group/atlas/pull/171","diff_url":"https://github.com/ebi-gene-expression-group/atlas/pull/171.diff","patch_url":"https://github.com/ebi-gene-expression-group/atlas/pull/171.patch","issue_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/171","number":171,"state":"open","locked":false,"title":"Chore/160166795 split gxa test data","user":{"login":"alfonsomunozpomer","id":4425744,"node_id":"MDQ6VXNlcjQ0MjU3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4425744?v=4","gravatar_id":"","url":"https://api.github.com/users/alfonsomunozpomer","html_url":"https://github.com/alfonsomunozpomer","followers_url":"https://api.github.com/users/alfonsomunozpomer/followers","following_url":"https://api.github.com/users/alfonsomunozpomer/following{/other_user}","gists_url":"https://api.github.com/users/alfonsomunozpomer/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsomunozpomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsomunozpomer/subscriptions","organizations_url":"https://api.github.com/users/alfonsomunozpomer/orgs","repos_url":"https://api.github.com/users/alfonsomunozpomer/repos","events_url":"https://api.github.com/users/alfonsomunozpomer/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsomunozpomer/received_events","type":"User","site_admin":false},"body":"It’s been a long journey, but at last, here it is...\r\n\r\n# Atlas Core 1.0\r\n\r\nI think this is a fully revamped version of the module, thus new name and version. It includes a [git submodule](https://github.com/ebi-gene-expression-group/atlas-schemas) and it runs against the new [test data](https://gitlab-internal.ebi.ac.uk/amunoz/atlas-core-test-data), so I’ve set up a new Bamboo plan where it passes:\r\nhttp://bar:8085/browse/ATLAS-ATLASCORECI0\r\n\r\nThe way I envision it, once we merge this it would be a good time to split `gxa` and `sc` to their own repositories and we can have modular deployments without branch hell.\r\n\r\nIf it helps, we can have a look at it together (or parts of it) if you prefer.","created_at":"2018-09-25T16:21:53Z","updated_at":"2018-10-15T14:44:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171/commits","review_comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171/comments","review_comment_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/171/comments","statuses_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/8177d6d76edcda92f33a4f07d55add566b0177d1","head":{"label":"ebi-gene-expression-group:chore/160166795-split-gxa-test-data","ref":"chore/160166795-split-gxa-test-data","sha":"8177d6d76edcda92f33a4f07d55add566b0177d1","user":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"repo":{"id":5426219,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI2MjE5","name":"atlas","full_name":"ebi-gene-expression-group/atlas","private":false,"owner":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ebi-gene-expression-group/atlas","description":"Expression Atlas","fork":false,"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas","forks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/forks","keys_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/teams","hooks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/hooks","issue_events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/events","assignees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/tags","blobs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/languages","stargazers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/stargazers","contributors_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contributors","subscribers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscribers","subscription_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscription","commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/merges","archive_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/downloads","issues_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/labels{/name}","releases_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/deployments","created_at":"2012-08-15T13:18:18Z","updated_at":"2018-10-15T08:40:36Z","pushed_at":"2018-10-15T11:08:31Z","git_url":"git://github.com/ebi-gene-expression-group/atlas.git","ssh_url":"git@github.com:ebi-gene-expression-group/atlas.git","clone_url":"https://github.com/ebi-gene-expression-group/atlas.git","svn_url":"https://github.com/ebi-gene-expression-group/atlas","homepage":"https://www.ebi.ac.uk/gxa","size":852110,"stargazers_count":18,"watchers_count":18,"language":"Roff","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":7,"watchers":18,"default_branch":"dev"}},"base":{"label":"ebi-gene-expression-group:dev","ref":"dev","sha":"8090477cd0969edb952360aa14fdf1b49de70d00","user":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"repo":{"id":5426219,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI2MjE5","name":"atlas","full_name":"ebi-gene-expression-group/atlas","private":false,"owner":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ebi-gene-expression-group/atlas","description":"Expression Atlas","fork":false,"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas","forks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/forks","keys_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/teams","hooks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/hooks","issue_events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/events","assignees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/tags","blobs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/languages","stargazers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/stargazers","contributors_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contributors","subscribers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscribers","subscription_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscription","commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/merges","archive_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/downloads","issues_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/labels{/name}","releases_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/deployments","created_at":"2012-08-15T13:18:18Z","updated_at":"2018-10-15T08:40:36Z","pushed_at":"2018-10-15T11:08:31Z","git_url":"git://github.com/ebi-gene-expression-group/atlas.git","ssh_url":"git@github.com:ebi-gene-expression-group/atlas.git","clone_url":"https://github.com/ebi-gene-expression-group/atlas.git","svn_url":"https://github.com/ebi-gene-expression-group/atlas","homepage":"https://www.ebi.ac.uk/gxa","size":852110,"stargazers_count":18,"watchers_count":18,"language":"Roff","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":7,"watchers":18,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171"},"html":{"href":"https://github.com/ebi-gene-expression-group/atlas/pull/171"},"issue":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/171"},"comments":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/8177d6d76edcda92f33a4f07d55add566b0177d1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"monicajianu"}}