{"action":"created","issue":{"url":"https://api.github.com/repos/scalameta/scalameta/issues/1322","repository_url":"https://api.github.com/repos/scalameta/scalameta","labels_url":"https://api.github.com/repos/scalameta/scalameta/issues/1322/labels{/name}","comments_url":"https://api.github.com/repos/scalameta/scalameta/issues/1322/comments","events_url":"https://api.github.com/repos/scalameta/scalameta/issues/1322/events","html_url":"https://github.com/scalameta/scalameta/pull/1322","id":297614068,"number":1322,"title":"Add a cross-compat dialect","user":{"login":"DavidDudson","id":2680733,"avatar_url":"https://avatars1.githubusercontent.com/u/2680733?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidDudson","html_url":"https://github.com/DavidDudson","followers_url":"https://api.github.com/users/DavidDudson/followers","following_url":"https://api.github.com/users/DavidDudson/following{/other_user}","gists_url":"https://api.github.com/users/DavidDudson/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidDudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidDudson/subscriptions","organizations_url":"https://api.github.com/users/DavidDudson/orgs","repos_url":"https://api.github.com/users/DavidDudson/repos","events_url":"https://api.github.com/users/DavidDudson/events{/privacy}","received_events_url":"https://api.github.com/users/DavidDudson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-15T22:08:23Z","updated_at":"2018-02-16T10:05:48Z","closed_at":"2018-02-16T09:56:24Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/scalameta/scalameta/pulls/1322","html_url":"https://github.com/scalameta/scalameta/pull/1322","diff_url":"https://github.com/scalameta/scalameta/pull/1322.diff","patch_url":"https://github.com/scalameta/scalameta/pull/1322.patch"},"body":"Name up for discussion.\r\n\r\nIntroduce a restricted subset of all dialects to retain cross-compatibility. \r\nThis is the exact opposite of what scalafmt needs (To support every feature)\r\n\r\nThis is important for code generation, as we want to generate code to a shared folder, and have it compiled by multiple targets, including Dotty.\r\n\r\nThis allows longevity of code generators, as they will not need to be updated when scala's version changes.\r\n\r\nNote: We lose Sbt 0.13.5 here, but I would expect very few people will target sbt with code gen, and even fewer will be using 0.13.5 rather than 0.13.6."},"comment":{"url":"https://api.github.com/repos/scalameta/scalameta/issues/comments/366193335","html_url":"https://github.com/scalameta/scalameta/pull/1322#issuecomment-366193335","issue_url":"https://api.github.com/repos/scalameta/scalameta/issues/1322","id":366193335,"user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T10:05:48Z","updated_at":"2018-02-16T10:05:48Z","author_association":"OWNER","body":"I agree it's not optimal to have every tool customize it's own dialect, but as you say these custom dialects appear out of place in scala.meta.dialects when all the other ones are backed by an specific compiler/tool version. I think contrib is a better place for dialects like CrossCompat, I'd be happy to merge it here. What do you think? While we're at it, should we maybe add the scalafix default dialect too as the opposite of `CrossCompat`? We could name it `Lenient` or `BestEffort`, any suggestions?\r\n\r\nhttps://github.com/scalacenter/scalafix/blob/3d4de59322d8f63eff043f33e19e335ef59aa15a/scalafix-core/shared/src/main/scala/scalafix/internal/config/ScalafixConfig.scala#L64\r\n\r\n"}}
{"actor":{"display_login":"olafurpg"}}