{"action":"created","issue":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2073","repository_url":"https://api.github.com/repos/DivanteLtd/vue-storefront","labels_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2073/labels{/name}","comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2073/comments","events_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2073/events","html_url":"https://github.com/DivanteLtd/vue-storefront/issues/2073","id":389294191,"node_id":"MDU6SXNzdWUzODkyOTQxOTE=","number":2073,"title":"Magento2 data import doesn't take configuration from local.json","user":{"login":"Tjitse-E","id":14849044,"node_id":"MDQ6VXNlcjE0ODQ5MDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/14849044?v=4","gravatar_id":"","url":"https://api.github.com/users/Tjitse-E","html_url":"https://github.com/Tjitse-E","followers_url":"https://api.github.com/users/Tjitse-E/followers","following_url":"https://api.github.com/users/Tjitse-E/following{/other_user}","gists_url":"https://api.github.com/users/Tjitse-E/gists{/gist_id}","starred_url":"https://api.github.com/users/Tjitse-E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tjitse-E/subscriptions","organizations_url":"https://api.github.com/users/Tjitse-E/orgs","repos_url":"https://api.github.com/users/Tjitse-E/repos","events_url":"https://api.github.com/users/Tjitse-E/events{/privacy}","received_events_url":"https://api.github.com/users/Tjitse-E/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"patzick","id":13100280,"node_id":"MDQ6VXNlcjEzMTAwMjgw","avatar_url":"https://avatars0.githubusercontent.com/u/13100280?v=4","gravatar_id":"","url":"https://api.github.com/users/patzick","html_url":"https://github.com/patzick","followers_url":"https://api.github.com/users/patzick/followers","following_url":"https://api.github.com/users/patzick/following{/other_user}","gists_url":"https://api.github.com/users/patzick/gists{/gist_id}","starred_url":"https://api.github.com/users/patzick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patzick/subscriptions","organizations_url":"https://api.github.com/users/patzick/orgs","repos_url":"https://api.github.com/users/patzick/repos","events_url":"https://api.github.com/users/patzick/events{/privacy}","received_events_url":"https://api.github.com/users/patzick/received_events","type":"User","site_admin":false},"assignees":[{"login":"patzick","id":13100280,"node_id":"MDQ6VXNlcjEzMTAwMjgw","avatar_url":"https://avatars0.githubusercontent.com/u/13100280?v=4","gravatar_id":"","url":"https://api.github.com/users/patzick","html_url":"https://github.com/patzick","followers_url":"https://api.github.com/users/patzick/followers","following_url":"https://api.github.com/users/patzick/following{/other_user}","gists_url":"https://api.github.com/users/patzick/gists{/gist_id}","starred_url":"https://api.github.com/users/patzick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patzick/subscriptions","organizations_url":"https://api.github.com/users/patzick/orgs","repos_url":"https://api.github.com/users/patzick/repos","events_url":"https://api.github.com/users/patzick/events{/privacy}","received_events_url":"https://api.github.com/users/patzick/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-12-10T13:11:10Z","updated_at":"2018-12-11T06:36:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Current behavior\r\nQuote from the docs:\r\n> Magento2 data import is now integrated into vue-storefront-api for simplicity. It's still managed by the mage2vuestorefront - added as a dependency to vue-storefront-api.\r\n\r\nThe problem is that you still need to customize the configuration file in mage2vuestorefront. Now located in: `~/vue-storefront-api/node_modules/mage2vuestorefront/src/config.js`. The docs don't mention this.  \r\n\r\n<!--  Describe the current behavior pointing exactly why it's not working as intended. -->\r\n\r\n## Expected behavior\r\nIMHO, the configuration for mage2vuestorefront should be located in the `config` folder of the vue-storefront-api\r\n\r\n## Steps to reproduce the issue\r\n<!--\r\nPlease provide the steps to reproduce and if possible a *minimal reproducible example* of the problem via\r\nhttps://stackblitz.com or with a screenshot if it's more accurate.\r\n -->\r\n1. Install Vue storefront\r\n2. Connect to a Magento 2 instance\r\n3. Change elastic/host settings in vue-storefront-api/config/local.json. In my case i've changed the Elastic host.\r\n4. Run `yarn mage2vs import`\r\n5. Notice that the custom settings from step 3 aren't used. Instead the config in this location is used `~/vue-storefront-api/node_modules/mage2vuestorefront/src/config.js`\r\n\r\n## Repository\r\nhttps://github.com/DivanteLtd/mage2vuestorefront\r\n\r\n# Can you handle fixing this bug by yourself?\r\n<!-- \r\nIf you can handle fixing this bug by yourself and later propose a Pull Request with the solution please answer YES. otherwise answer NO.\r\n-->\r\nNo, we're trying to finish a Vue Storefront project before the end of the year :)\r\n\r\n## Additional information\r\n[Link to relevant the Vue storefront documentation](https://divanteltd.github.io/vue-storefront/guide/installation/magento.html#integrating-magento2-with-your-local-instance)\r\n"},"comment":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/comments/446089118","html_url":"https://github.com/DivanteLtd/vue-storefront/issues/2073#issuecomment-446089118","issue_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2073","id":446089118,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjA4OTExOA==","user":{"login":"pkarw","id":211899,"node_id":"MDQ6VXNlcjIxMTg5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/211899?v=4","gravatar_id":"","url":"https://api.github.com/users/pkarw","html_url":"https://github.com/pkarw","followers_url":"https://api.github.com/users/pkarw/followers","following_url":"https://api.github.com/users/pkarw/following{/other_user}","gists_url":"https://api.github.com/users/pkarw/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarw/subscriptions","organizations_url":"https://api.github.com/users/pkarw/orgs","repos_url":"https://api.github.com/users/pkarw/repos","events_url":"https://api.github.com/users/pkarw/events{/privacy}","received_events_url":"https://api.github.com/users/pkarw/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T06:36:06Z","updated_at":"2018-12-11T06:36:06Z","author_association":"COLLABORATOR","body":"You're right, DATABSE_URL is currently missed in the `mage2vs`. Thanks! @patzick could You please fix this ?"}}
{"actor":{"display_login":"pkarw"}}