{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590/events","html_url":"https://github.com/openshift/openshift-ansible/pull/8590","id":328298534,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODc0OTAx","number":8590,"title":"Support setting dns_domain in inventory","user":{"login":"reneklootwijk","id":915437,"node_id":"MDQ6VXNlcjkxNTQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/915437?v=4","gravatar_id":"","url":"https://api.github.com/users/reneklootwijk","html_url":"https://github.com/reneklootwijk","followers_url":"https://api.github.com/users/reneklootwijk/followers","following_url":"https://api.github.com/users/reneklootwijk/following{/other_user}","gists_url":"https://api.github.com/users/reneklootwijk/gists{/gist_id}","starred_url":"https://api.github.com/users/reneklootwijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneklootwijk/subscriptions","organizations_url":"https://api.github.com/users/reneklootwijk/orgs","repos_url":"https://api.github.com/users/reneklootwijk/repos","events_url":"https://api.github.com/users/reneklootwijk/events{/privacy}","received_events_url":"https://api.github.com/users/reneklootwijk/received_events","type":"User","site_admin":false},"labels":[{"id":687371042,"node_id":"MDU6TGFiZWw2ODczNzEwNDI=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":681633081,"node_id":"MDU6TGFiZWw2ODE2MzMwODE=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"reneklootwijk","id":915437,"node_id":"MDQ6VXNlcjkxNTQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/915437?v=4","gravatar_id":"","url":"https://api.github.com/users/reneklootwijk","html_url":"https://github.com/reneklootwijk","followers_url":"https://api.github.com/users/reneklootwijk/followers","following_url":"https://api.github.com/users/reneklootwijk/following{/other_user}","gists_url":"https://api.github.com/users/reneklootwijk/gists{/gist_id}","starred_url":"https://api.github.com/users/reneklootwijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneklootwijk/subscriptions","organizations_url":"https://api.github.com/users/reneklootwijk/orgs","repos_url":"https://api.github.com/users/reneklootwijk/repos","events_url":"https://api.github.com/users/reneklootwijk/events{/privacy}","received_events_url":"https://api.github.com/users/reneklootwijk/received_events","type":"User","site_admin":false},"assignees":[{"login":"reneklootwijk","id":915437,"node_id":"MDQ6VXNlcjkxNTQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/915437?v=4","gravatar_id":"","url":"https://api.github.com/users/reneklootwijk","html_url":"https://github.com/reneklootwijk","followers_url":"https://api.github.com/users/reneklootwijk/followers","following_url":"https://api.github.com/users/reneklootwijk/following{/other_user}","gists_url":"https://api.github.com/users/reneklootwijk/gists{/gist_id}","starred_url":"https://api.github.com/users/reneklootwijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneklootwijk/subscriptions","organizations_url":"https://api.github.com/users/reneklootwijk/orgs","repos_url":"https://api.github.com/users/reneklootwijk/repos","events_url":"https://api.github.com/users/reneklootwijk/events{/privacy}","received_events_url":"https://api.github.com/users/reneklootwijk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":24,"created_at":"2018-05-31T21:10:36Z","updated_at":"2018-06-18T16:42:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/8590","html_url":"https://github.com/openshift/openshift-ansible/pull/8590","diff_url":"https://github.com/openshift/openshift-ansible/pull/8590.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/8590.patch"},"body":"This pull requests makes the changes required to be able to change the cluster domain of a local installation from the default cluster.local to something you specify in the Ansible inventory file using the dns_domain parameter.\r\n\r\nThe pull request consists of two changes:\r\n1. Added setting the local fact openshift.common.dns_domain based on the dns_domain variable in the inventory OSEv3:vars section.\r\n2. Changed the network manager configuration task from copying a configuration file to creating a configuration file based on a template. This will eventually create a /etc/resolv.conf containing the correct search domain instead of using hardcoded cluster.local"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/398118422","html_url":"https://github.com/openshift/openshift-ansible/pull/8590#issuecomment-398118422","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590","id":398118422,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODExODQyMg==","user":{"login":"sdodson","id":48161,"node_id":"MDQ6VXNlcjQ4MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/48161?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T16:42:31Z","updated_at":"2018-06-18T16:42:31Z","author_association":"MEMBER","body":"@openshift/sig-master Can someone confirm that changing `cluster.local` is supportable both in current releases and near term future? I don't want to enable this if we're just going to take it away via some fundamental change in the future."}}
{"actor":{"display_login":"sdodson"}}