{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf/issues/210","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf/issues/210/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf/issues/210/events","html_url":"https://github.com/fgpv-vpgf/fgpa-apgf/pull/210","id":299803012,"number":210,"title":"Layers validity part 2","user":{"login":"ChrisLatRNCan","id":16193004,"avatar_url":"https://avatars2.githubusercontent.com/u/16193004?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisLatRNCan","html_url":"https://github.com/ChrisLatRNCan","followers_url":"https://api.github.com/users/ChrisLatRNCan/followers","following_url":"https://api.github.com/users/ChrisLatRNCan/following{/other_user}","gists_url":"https://api.github.com/users/ChrisLatRNCan/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisLatRNCan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisLatRNCan/subscriptions","organizations_url":"https://api.github.com/users/ChrisLatRNCan/orgs","repos_url":"https://api.github.com/users/ChrisLatRNCan/repos","events_url":"https://api.github.com/users/ChrisLatRNCan/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisLatRNCan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jolevesq","id":3472990,"avatar_url":"https://avatars3.githubusercontent.com/u/3472990?v=4","gravatar_id":"","url":"https://api.github.com/users/jolevesq","html_url":"https://github.com/jolevesq","followers_url":"https://api.github.com/users/jolevesq/followers","following_url":"https://api.github.com/users/jolevesq/following{/other_user}","gists_url":"https://api.github.com/users/jolevesq/gists{/gist_id}","starred_url":"https://api.github.com/users/jolevesq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolevesq/subscriptions","organizations_url":"https://api.github.com/users/jolevesq/orgs","repos_url":"https://api.github.com/users/jolevesq/repos","events_url":"https://api.github.com/users/jolevesq/events{/privacy}","received_events_url":"https://api.github.com/users/jolevesq/received_events","type":"User","site_admin":false},"assignees":[{"login":"jolevesq","id":3472990,"avatar_url":"https://avatars3.githubusercontent.com/u/3472990?v=4","gravatar_id":"","url":"https://api.github.com/users/jolevesq","html_url":"https://github.com/jolevesq","followers_url":"https://api.github.com/users/jolevesq/followers","following_url":"https://api.github.com/users/jolevesq/following{/other_user}","gists_url":"https://api.github.com/users/jolevesq/gists{/gist_id}","starred_url":"https://api.github.com/users/jolevesq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolevesq/subscriptions","organizations_url":"https://api.github.com/users/jolevesq/orgs","repos_url":"https://api.github.com/users/jolevesq/repos","events_url":"https://api.github.com/users/jolevesq/events{/privacy}","received_events_url":"https://api.github.com/users/jolevesq/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-23T18:15:14Z","updated_at":"2018-02-23T18:33:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf/pulls/210","html_url":"https://github.com/fgpv-vpgf/fgpa-apgf/pull/210","diff_url":"https://github.com/fgpv-vpgf/fgpa-apgf/pull/210.diff","patch_url":"https://github.com/fgpv-vpgf/fgpa-apgf/pull/210.patch"},"body":"Before: validity of layers not properly done for new layers and layers with missing required values.\r\nSolution: look in element for undefined attribute in the model and set validity to false.\r\nAfter: validity of layers is properly done and the summary reflects the right info.\r\n\r\nCloses #209\r\n\r\n## Description\r\n<!-- Link to an issue or include a description -->\r\n\r\n## Testing\r\nTest with Chrome\r\n\r\n## Documentation\r\n<!-- Which areas of documentation have been changed: jsdoc, tutorials, samples, wiki -->\r\n\r\n## Checklist\r\n<!-- Quick checklist for items that are easy to miss -->\r\n\r\n- [x] Commit messages follow [the guidelines](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/master/CONTRIBUTING.md#-git-commit-guidelines)\r\n- [ ] ~~Release notes have been updated~~\r\n- [x] PR targets the correct release version\r\n- [ ] ~~Help files and documentation have been updated~~\r\n\r\nRemember, it is a *muffin offence* to open a PR with any of the above checklist items incomplete.\r\n\r\nPlease keep the original issue up to date with the final solution, expected behaviour, and any additional notes for testers\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpa-apgf/210)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf/issues/comments/368098219","html_url":"https://github.com/fgpv-vpgf/fgpa-apgf/pull/210#issuecomment-368098219","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpa-apgf/issues/210","id":368098219,"user":{"login":"jolevesq","id":3472990,"avatar_url":"https://avatars3.githubusercontent.com/u/3472990?v=4","gravatar_id":"","url":"https://api.github.com/users/jolevesq","html_url":"https://github.com/jolevesq","followers_url":"https://api.github.com/users/jolevesq/followers","following_url":"https://api.github.com/users/jolevesq/following{/other_user}","gists_url":"https://api.github.com/users/jolevesq/gists{/gist_id}","starred_url":"https://api.github.com/users/jolevesq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolevesq/subscriptions","organizations_url":"https://api.github.com/users/jolevesq/orgs","repos_url":"https://api.github.com/users/jolevesq/repos","events_url":"https://api.github.com/users/jolevesq/events{/privacy}","received_events_url":"https://api.github.com/users/jolevesq/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T18:33:06Z","updated_at":"2018-02-23T18:33:06Z","author_association":"CONTRIBUTOR","body":"Can you modify the commit message to follow the guideline?\n\n---\n\nReviewed 3 of 4 files at r1.\nReview status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[src/app/ui/tree/tree.directive.js, line 55 at r1](https://reviewable.io:443/reviews/fgpv-vpgf/fgpa-apgf/210#-L62w2w5J58nogZ3-36V:-L62w2w5J58nogZ3-36W:bn1u56m) ([raw file](https://github.com/fgpv-vpgf/fgpa-apgf/blob/7e6cdd075a14fa920490f60502cb50b17604830f/src/app/ui/tree/tree.directive.js#L55)):*\n> ```JavaScript\n>         } else {\n>             commonService.clickSubTab(tree.masterlink, tree.hlink);\n>             if (tree.stype === 'element' || tree.stype === 'bad-element') {\n> ```\n\nIs there a typo? stype instead of type?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/fgpv-vpgf/fgpa-apgf/210#-:-L62vcOKzcno444k4jLW:bur7pzf)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jolevesq"}}