{"action":"created","comment":{"url":"https://api.github.com/repos/cdk/cdk/pulls/comments/173619500","pull_request_review_id":102848261,"id":173619500,"diff_hunk":"@@ -448,6 +448,17 @@ public void warn(Object object, Object... objects) {\n     public boolean isDebugEnabled() {\n         return doDebug;\n     }\n+    \n+    /**\n+     * Enables debugging output. \n+     * Use this method for computational demanding debug info.\n+     * \n+     * @see isDebugEnabled()\n+     */\n+    @Override\n+    public void setDebugEnabled(boolean enabled) {","path":"misc/log4j/src/main/java/org/openscience/cdk/tools/LoggingTool.java","position":12,"original_position":12,"commit_id":"7ced181206e8763f49238aa6b0b40a9c9a562667","original_commit_id":"7ced181206e8763f49238aa6b0b40a9c9a562667","user":{"login":"egonw","id":26721,"avatar_url":"https://avatars2.githubusercontent.com/u/26721?v=4","gravatar_id":"","url":"https://api.github.com/users/egonw","html_url":"https://github.com/egonw","followers_url":"https://api.github.com/users/egonw/followers","following_url":"https://api.github.com/users/egonw/following{/other_user}","gists_url":"https://api.github.com/users/egonw/gists{/gist_id}","starred_url":"https://api.github.com/users/egonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egonw/subscriptions","organizations_url":"https://api.github.com/users/egonw/orgs","repos_url":"https://api.github.com/users/egonw/repos","events_url":"https://api.github.com/users/egonw/events{/privacy}","received_events_url":"https://api.github.com/users/egonw/received_events","type":"User","site_admin":false},"body":"@johnmay, that's sort of the point... people should set Log4J to debug, and not use the Java API... one solution.","created_at":"2018-03-10T11:17:40Z","updated_at":"2018-03-10T11:17:40Z","html_url":"https://github.com/cdk/cdk/pull/430#discussion_r173619500","pull_request_url":"https://api.github.com/repos/cdk/cdk/pulls/430","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cdk/cdk/pulls/comments/173619500"},"html":{"href":"https://github.com/cdk/cdk/pull/430#discussion_r173619500"},"pull_request":{"href":"https://api.github.com/repos/cdk/cdk/pulls/430"}},"in_reply_to_id":172782882},"pull_request":{"url":"https://api.github.com/repos/cdk/cdk/pulls/430","id":173383891,"html_url":"https://github.com/cdk/cdk/pull/430","diff_url":"https://github.com/cdk/cdk/pull/430.diff","patch_url":"https://github.com/cdk/cdk/pull/430.patch","issue_url":"https://api.github.com/repos/cdk/cdk/issues/430","number":430,"state":"open","locked":false,"title":"Added a method to enable debugging output.","user":{"login":"steinbeck","id":107318,"avatar_url":"https://avatars1.githubusercontent.com/u/107318?v=4","gravatar_id":"","url":"https://api.github.com/users/steinbeck","html_url":"https://github.com/steinbeck","followers_url":"https://api.github.com/users/steinbeck/followers","following_url":"https://api.github.com/users/steinbeck/following{/other_user}","gists_url":"https://api.github.com/users/steinbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/steinbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinbeck/subscriptions","organizations_url":"https://api.github.com/users/steinbeck/orgs","repos_url":"https://api.github.com/users/steinbeck/repos","events_url":"https://api.github.com/users/steinbeck/events{/privacy}","received_events_url":"https://api.github.com/users/steinbeck/received_events","type":"User","site_admin":false},"body":"SystemOutLoggingTool is supposed to log to System.out without the help of log4j. Its ability to output relies on debugEnabled being true. There was, however, no method setDebugEnabled() to switch this on. Now added.","created_at":"2018-03-07T08:37:30Z","updated_at":"2018-03-10T11:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36fc63fba4653a0488cf636b9b1546907c2ec072","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cdk/cdk/pulls/430/commits","review_comments_url":"https://api.github.com/repos/cdk/cdk/pulls/430/comments","review_comment_url":"https://api.github.com/repos/cdk/cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cdk/cdk/issues/430/comments","statuses_url":"https://api.github.com/repos/cdk/cdk/statuses/7ced181206e8763f49238aa6b0b40a9c9a562667","head":{"label":"steinbeck:loggin-tool-debug-fix","ref":"loggin-tool-debug-fix","sha":"7ced181206e8763f49238aa6b0b40a9c9a562667","user":{"login":"steinbeck","id":107318,"avatar_url":"https://avatars1.githubusercontent.com/u/107318?v=4","gravatar_id":"","url":"https://api.github.com/users/steinbeck","html_url":"https://github.com/steinbeck","followers_url":"https://api.github.com/users/steinbeck/followers","following_url":"https://api.github.com/users/steinbeck/following{/other_user}","gists_url":"https://api.github.com/users/steinbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/steinbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinbeck/subscriptions","organizations_url":"https://api.github.com/users/steinbeck/orgs","repos_url":"https://api.github.com/users/steinbeck/repos","events_url":"https://api.github.com/users/steinbeck/events{/privacy}","received_events_url":"https://api.github.com/users/steinbeck/received_events","type":"User","site_admin":false},"repo":{"id":124196657,"name":"cdk","full_name":"steinbeck/cdk","owner":{"login":"steinbeck","id":107318,"avatar_url":"https://avatars1.githubusercontent.com/u/107318?v=4","gravatar_id":"","url":"https://api.github.com/users/steinbeck","html_url":"https://github.com/steinbeck","followers_url":"https://api.github.com/users/steinbeck/followers","following_url":"https://api.github.com/users/steinbeck/following{/other_user}","gists_url":"https://api.github.com/users/steinbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/steinbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinbeck/subscriptions","organizations_url":"https://api.github.com/users/steinbeck/orgs","repos_url":"https://api.github.com/users/steinbeck/repos","events_url":"https://api.github.com/users/steinbeck/events{/privacy}","received_events_url":"https://api.github.com/users/steinbeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steinbeck/cdk","description":"The Chemistry Development Kit","fork":true,"url":"https://api.github.com/repos/steinbeck/cdk","forks_url":"https://api.github.com/repos/steinbeck/cdk/forks","keys_url":"https://api.github.com/repos/steinbeck/cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steinbeck/cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steinbeck/cdk/teams","hooks_url":"https://api.github.com/repos/steinbeck/cdk/hooks","issue_events_url":"https://api.github.com/repos/steinbeck/cdk/issues/events{/number}","events_url":"https://api.github.com/repos/steinbeck/cdk/events","assignees_url":"https://api.github.com/repos/steinbeck/cdk/assignees{/user}","branches_url":"https://api.github.com/repos/steinbeck/cdk/branches{/branch}","tags_url":"https://api.github.com/repos/steinbeck/cdk/tags","blobs_url":"https://api.github.com/repos/steinbeck/cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steinbeck/cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steinbeck/cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/steinbeck/cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steinbeck/cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/steinbeck/cdk/languages","stargazers_url":"https://api.github.com/repos/steinbeck/cdk/stargazers","contributors_url":"https://api.github.com/repos/steinbeck/cdk/contributors","subscribers_url":"https://api.github.com/repos/steinbeck/cdk/subscribers","subscription_url":"https://api.github.com/repos/steinbeck/cdk/subscription","commits_url":"https://api.github.com/repos/steinbeck/cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/steinbeck/cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/steinbeck/cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/steinbeck/cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/steinbeck/cdk/contents/{+path}","compare_url":"https://api.github.com/repos/steinbeck/cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steinbeck/cdk/merges","archive_url":"https://api.github.com/repos/steinbeck/cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steinbeck/cdk/downloads","issues_url":"https://api.github.com/repos/steinbeck/cdk/issues{/number}","pulls_url":"https://api.github.com/repos/steinbeck/cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/steinbeck/cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/steinbeck/cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steinbeck/cdk/labels{/name}","releases_url":"https://api.github.com/repos/steinbeck/cdk/releases{/id}","deployments_url":"https://api.github.com/repos/steinbeck/cdk/deployments","created_at":"2018-03-07T07:29:01Z","updated_at":"2018-03-07T08:45:21Z","pushed_at":"2018-03-07T08:29:08Z","git_url":"git://github.com/steinbeck/cdk.git","ssh_url":"git@github.com:steinbeck/cdk.git","clone_url":"https://github.com/steinbeck/cdk.git","svn_url":"https://github.com/steinbeck/cdk","homepage":"https://cdk.github.io/","size":211384,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cdk:master","ref":"master","sha":"6fade7b5470669955835046d9fb09c48f658efde","user":{"login":"cdk","id":273111,"avatar_url":"https://avatars1.githubusercontent.com/u/273111?v=4","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"repo":{"id":660443,"name":"cdk","full_name":"cdk/cdk","owner":{"login":"cdk","id":273111,"avatar_url":"https://avatars1.githubusercontent.com/u/273111?v=4","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cdk/cdk","description":"The Chemistry Development Kit","fork":false,"url":"https://api.github.com/repos/cdk/cdk","forks_url":"https://api.github.com/repos/cdk/cdk/forks","keys_url":"https://api.github.com/repos/cdk/cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdk/cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdk/cdk/teams","hooks_url":"https://api.github.com/repos/cdk/cdk/hooks","issue_events_url":"https://api.github.com/repos/cdk/cdk/issues/events{/number}","events_url":"https://api.github.com/repos/cdk/cdk/events","assignees_url":"https://api.github.com/repos/cdk/cdk/assignees{/user}","branches_url":"https://api.github.com/repos/cdk/cdk/branches{/branch}","tags_url":"https://api.github.com/repos/cdk/cdk/tags","blobs_url":"https://api.github.com/repos/cdk/cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdk/cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdk/cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdk/cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdk/cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cdk/cdk/languages","stargazers_url":"https://api.github.com/repos/cdk/cdk/stargazers","contributors_url":"https://api.github.com/repos/cdk/cdk/contributors","subscribers_url":"https://api.github.com/repos/cdk/cdk/subscribers","subscription_url":"https://api.github.com/repos/cdk/cdk/subscription","commits_url":"https://api.github.com/repos/cdk/cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdk/cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdk/cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdk/cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdk/cdk/contents/{+path}","compare_url":"https://api.github.com/repos/cdk/cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdk/cdk/merges","archive_url":"https://api.github.com/repos/cdk/cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdk/cdk/downloads","issues_url":"https://api.github.com/repos/cdk/cdk/issues{/number}","pulls_url":"https://api.github.com/repos/cdk/cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cdk/cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cdk/cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdk/cdk/labels{/name}","releases_url":"https://api.github.com/repos/cdk/cdk/releases{/id}","deployments_url":"https://api.github.com/repos/cdk/cdk/deployments","created_at":"2010-05-11T08:30:07Z","updated_at":"2018-03-04T16:11:05Z","pushed_at":"2018-03-10T10:56:50Z","git_url":"git://github.com/cdk/cdk.git","ssh_url":"git@github.com:cdk/cdk.git","clone_url":"https://github.com/cdk/cdk.git","svn_url":"https://github.com/cdk/cdk","homepage":"https://cdk.github.io/","size":211376,"stargazers_count":136,"watchers_count":136,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":69,"open_issues":11,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cdk/cdk/pulls/430"},"html":{"href":"https://github.com/cdk/cdk/pull/430"},"issue":{"href":"https://api.github.com/repos/cdk/cdk/issues/430"},"comments":{"href":"https://api.github.com/repos/cdk/cdk/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/cdk/cdk/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/cdk/cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cdk/cdk/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/cdk/cdk/statuses/7ced181206e8763f49238aa6b0b40a9c9a562667"}},"author_association":"OWNER"}}
{"actor":{"display_login":"egonw"}}