{"action":"closed","number":3374,"pull_request":{"url":"https://api.github.com/repos/servo/webrender/pulls/3374","id":234783115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzgzMTE1","html_url":"https://github.com/servo/webrender/pull/3374","diff_url":"https://github.com/servo/webrender/pull/3374.diff","patch_url":"https://github.com/servo/webrender/pull/3374.patch","issue_url":"https://api.github.com/repos/servo/webrender/issues/3374","number":3374,"state":"closed","locked":false,"title":"Extend the scope of render target allocation strategy acrosss layers","user":{"login":"kvark","id":107301,"node_id":"MDQ6VXNlcjEwNzMwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"body":"Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1509672\r\n\r\nTechnically consists of 3 parts:\r\n  - cleanup bits, don't affect performance\r\n  - spread the dynamic target allocation bins across the layers. Previously, we had each layer with it's own allocator, and we were only ever trying to allocate from the last one. This scheme was weak against cases where we reach the ideal maximum target size, since guillotine allocation of small bits forced us to spawn more and more layers... reaching almost 150 in the target case. New scheme uses the layers more efficiently, reducing the layers to just 3 (.. 50x reduction :P). Pending [try push](https://treeherder.mozilla.org/#/jobs?repo=try&revision=27464c7d62f0f05a0bc96a7133b55e9706d3d449).\r\n  - when we reach the ideal max size, also round up the requested size to 256. This makes allocations *within a layer* to be more robust against small inputs. With this change, the number of layers drops to just 2 (.. 75x reduction lol), which appears to be minimal for this case. Pending [try push](https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f4593fd68455842a7b12f396d0abbdf887a11a0).\r\n\r\nThe page scrolls smoothly with those changes, on my GTX TI 1050 at least.\r\n\r\nr? @gw3583 \r\n\r\nNote: the bugzilla issue also suffers from poor batching, I'm going to look at it separately.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/webrender/3374)\n<!-- Reviewable:end -->\n","created_at":"2018-11-29T20:55:47Z","updated_at":"2018-11-30T15:58:21Z","closed_at":"2018-11-30T15:58:21Z","merged_at":"2018-11-30T15:58:21Z","merge_commit_sha":"3362a5e3ff59bb40f83ad442d7895ba564608b23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/webrender/pulls/3374/commits","review_comments_url":"https://api.github.com/repos/servo/webrender/pulls/3374/comments","review_comment_url":"https://api.github.com/repos/servo/webrender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/webrender/issues/3374/comments","statuses_url":"https://api.github.com/repos/servo/webrender/statuses/3362a5e3ff59bb40f83ad442d7895ba564608b23","head":{"label":"kvark:rt-alloc","ref":"rt-alloc","sha":"3362a5e3ff59bb40f83ad442d7895ba564608b23","user":{"login":"kvark","id":107301,"node_id":"MDQ6VXNlcjEwNzMwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"repo":{"id":70811310,"node_id":"MDEwOlJlcG9zaXRvcnk3MDgxMTMxMA==","name":"webrender","full_name":"kvark/webrender","private":false,"owner":{"login":"kvark","id":107301,"node_id":"MDQ6VXNlcjEwNzMwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kvark/webrender","description":"A very incomplete proof of concept GPU renderer for Servo","fork":true,"url":"https://api.github.com/repos/kvark/webrender","forks_url":"https://api.github.com/repos/kvark/webrender/forks","keys_url":"https://api.github.com/repos/kvark/webrender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kvark/webrender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kvark/webrender/teams","hooks_url":"https://api.github.com/repos/kvark/webrender/hooks","issue_events_url":"https://api.github.com/repos/kvark/webrender/issues/events{/number}","events_url":"https://api.github.com/repos/kvark/webrender/events","assignees_url":"https://api.github.com/repos/kvark/webrender/assignees{/user}","branches_url":"https://api.github.com/repos/kvark/webrender/branches{/branch}","tags_url":"https://api.github.com/repos/kvark/webrender/tags","blobs_url":"https://api.github.com/repos/kvark/webrender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kvark/webrender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kvark/webrender/git/refs{/sha}","trees_url":"https://api.github.com/repos/kvark/webrender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kvark/webrender/statuses/{sha}","languages_url":"https://api.github.com/repos/kvark/webrender/languages","stargazers_url":"https://api.github.com/repos/kvark/webrender/stargazers","contributors_url":"https://api.github.com/repos/kvark/webrender/contributors","subscribers_url":"https://api.github.com/repos/kvark/webrender/subscribers","subscription_url":"https://api.github.com/repos/kvark/webrender/subscription","commits_url":"https://api.github.com/repos/kvark/webrender/commits{/sha}","git_commits_url":"https://api.github.com/repos/kvark/webrender/git/commits{/sha}","comments_url":"https://api.github.com/repos/kvark/webrender/comments{/number}","issue_comment_url":"https://api.github.com/repos/kvark/webrender/issues/comments{/number}","contents_url":"https://api.github.com/repos/kvark/webrender/contents/{+path}","compare_url":"https://api.github.com/repos/kvark/webrender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kvark/webrender/merges","archive_url":"https://api.github.com/repos/kvark/webrender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kvark/webrender/downloads","issues_url":"https://api.github.com/repos/kvark/webrender/issues{/number}","pulls_url":"https://api.github.com/repos/kvark/webrender/pulls{/number}","milestones_url":"https://api.github.com/repos/kvark/webrender/milestones{/number}","notifications_url":"https://api.github.com/repos/kvark/webrender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kvark/webrender/labels{/name}","releases_url":"https://api.github.com/repos/kvark/webrender/releases{/id}","deployments_url":"https://api.github.com/repos/kvark/webrender/deployments","created_at":"2016-10-13T13:50:07Z","updated_at":"2018-07-19T13:37:36Z","pushed_at":"2018-11-30T14:45:38Z","git_url":"git://github.com/kvark/webrender.git","ssh_url":"git@github.com:kvark/webrender.git","clone_url":"https://github.com/kvark/webrender.git","svn_url":"https://github.com/kvark/webrender","homepage":"https://doc.servo.org/webrender/","size":44129,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"5b26863178f8533eeba2de28c6bdc019ba9ed3e8","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":42894575,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg5NDU3NQ==","name":"webrender","full_name":"servo/webrender","private":false,"owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/servo/webrender","description":"A GPU-based renderer for the web","fork":false,"url":"https://api.github.com/repos/servo/webrender","forks_url":"https://api.github.com/repos/servo/webrender/forks","keys_url":"https://api.github.com/repos/servo/webrender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/webrender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/webrender/teams","hooks_url":"https://api.github.com/repos/servo/webrender/hooks","issue_events_url":"https://api.github.com/repos/servo/webrender/issues/events{/number}","events_url":"https://api.github.com/repos/servo/webrender/events","assignees_url":"https://api.github.com/repos/servo/webrender/assignees{/user}","branches_url":"https://api.github.com/repos/servo/webrender/branches{/branch}","tags_url":"https://api.github.com/repos/servo/webrender/tags","blobs_url":"https://api.github.com/repos/servo/webrender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/webrender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/webrender/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/webrender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/webrender/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/webrender/languages","stargazers_url":"https://api.github.com/repos/servo/webrender/stargazers","contributors_url":"https://api.github.com/repos/servo/webrender/contributors","subscribers_url":"https://api.github.com/repos/servo/webrender/subscribers","subscription_url":"https://api.github.com/repos/servo/webrender/subscription","commits_url":"https://api.github.com/repos/servo/webrender/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/webrender/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/webrender/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/webrender/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/webrender/contents/{+path}","compare_url":"https://api.github.com/repos/servo/webrender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/webrender/merges","archive_url":"https://api.github.com/repos/servo/webrender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/webrender/downloads","issues_url":"https://api.github.com/repos/servo/webrender/issues{/number}","pulls_url":"https://api.github.com/repos/servo/webrender/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/webrender/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/webrender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/webrender/labels{/name}","releases_url":"https://api.github.com/repos/servo/webrender/releases{/id}","deployments_url":"https://api.github.com/repos/servo/webrender/deployments","created_at":"2015-09-21T21:27:30Z","updated_at":"2018-11-30T15:58:23Z","pushed_at":"2018-11-30T15:58:21Z","git_url":"git://github.com/servo/webrender.git","ssh_url":"git@github.com:servo/webrender.git","clone_url":"https://github.com/servo/webrender.git","svn_url":"https://github.com/servo/webrender","homepage":"https://doc.servo.org/webrender/","size":39713,"stargazers_count":1375,"watchers_count":1375,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":190,"open_issues":233,"watchers":1375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/webrender/pulls/3374"},"html":{"href":"https://github.com/servo/webrender/pull/3374"},"issue":{"href":"https://api.github.com/repos/servo/webrender/issues/3374"},"comments":{"href":"https://api.github.com/repos/servo/webrender/issues/3374/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/webrender/pulls/3374/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/webrender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/webrender/pulls/3374/commits"},"statuses":{"href":"https://api.github.com/repos/servo/webrender/statuses/3362a5e3ff59bb40f83ad442d7895ba564608b23"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bors-servo","id":4368172,"node_id":"MDQ6VXNlcjQzNjgxNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/4368172?v=4","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":260,"deletions":296,"changed_files":8}}
{"actor":{"display_login":"bors-servo"}}