{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/208546504","pull_request_review_id":144356311,"id":208546504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODU0NjUwNA==","diff_hunk":"@@ -0,0 +1,34 @@\n+<div class=\"btn-group\"\n+     dropdown>\n+  <ng-container *ngFor=\"let action of tableActions\">\n+    <button type=\"button\"\n+            class=\"btn btn-sm btn-primary\"\n+            *ngIf=\"selectButtonOnPermission(action.permission)\"\n+            [ngClass]=\"{'disabled': disableSelectionAction(action.permission)}\"\n+            (click)=\"useClickAction(action.click)\"\n+            [routerLink]=\"useRouterLink(action)\">\n+      <i class=\"fa fa-fw {{action.icon}}\"></i><span i18n>{{ action.name }}</span>\n+    </button>\n+  </ng-container>\n+  <button type=\"button\"\n+          dropdownToggle\n+          *ngIf=\"showDropDownActions()\"\n+          class=\"btn btn-sm btn-primary dropdown-toggle dropdown-toggle-split\">\n+    <span class=\"caret\"></span>\n+    <span class=\"sr-only\"></span>\n+  </button>\n+  <ul *dropdownMenu class=\"dropdown-menu\" role=\"menu\">\n+    <ng-container *ngFor=\"let action of tableDropDownActions\">\n+      <li role=\"menuitem\"\n+          *ngIf=\"permission[action.permission]\">\n+        <a class=\"dropdown-item\"\n+           [ngClass]=\"{'disabled': disableSelectionAction(action.permission)}\"","path":"src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table-actions/table-actions.component.html","position":25,"original_position":25,"commit_id":"5c710879fb276bd8295d846d502fc8f77f8747ce","original_commit_id":"5c710879fb276bd8295d846d502fc8f77f8747ce","user":{"login":"tspmelo","id":399326,"node_id":"MDQ6VXNlcjM5OTMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"body":"The text should be grey when disabled, but it stays black.","created_at":"2018-08-08T11:31:03Z","updated_at":"2018-08-08T11:55:28Z","html_url":"https://github.com/ceph/ceph/pull/21614#discussion_r208546504","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/21614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/208546504"},"html":{"href":"https://github.com/ceph/ceph/pull/21614#discussion_r208546504"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21614"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/21614","id":183682030,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzNjgyMDMw","html_url":"https://github.com/ceph/ceph/pull/21614","diff_url":"https://github.com/ceph/ceph/pull/21614.diff","patch_url":"https://github.com/ceph/ceph/pull/21614.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/21614","number":21614,"state":"open","locked":false,"title":"mgr/dashboard: Pool management","user":{"login":"Devp00l","id":16167865,"node_id":"MDQ6VXNlcjE2MTY3ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/16167865?v=4","gravatar_id":"","url":"https://api.github.com/users/Devp00l","html_url":"https://github.com/Devp00l","followers_url":"https://api.github.com/users/Devp00l/followers","following_url":"https://api.github.com/users/Devp00l/following{/other_user}","gists_url":"https://api.github.com/users/Devp00l/gists{/gist_id}","starred_url":"https://api.github.com/users/Devp00l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devp00l/subscriptions","organizations_url":"https://api.github.com/users/Devp00l/orgs","repos_url":"https://api.github.com/users/Devp00l/repos","events_url":"https://api.github.com/users/Devp00l/events{/privacy}","received_events_url":"https://api.github.com/users/Devp00l/received_events","type":"User","site_admin":false},"body":"You can create a pool through the form.\r\n\r\nYou can specify the following:\r\n* Name - can't be duplicated\r\n* Type - replicated or erasure\r\n* Crush rule set - Validates if you can use it\r\n* Replica size - depends on your selected rule and the ammount of osds\r\n* Erasure code profile\r\n* PGs - will be recalculated on form changes (type, replica size,\r\n    erasure profile, crush rule)\r\n* EC overwrites flag\r\n* Compression - Algorithm / Min/max blob size / mode / ratio\r\n* Application metadata - Predefined and custom applications\r\n\r\nSigned-off-by: Stephan Müller <smueller@suse.com>\r\n\r\n# Erasure code pool creation\r\n![ec-pool-creation](https://user-images.githubusercontent.com/16167865/43504606-62848d84-9564-11e8-9b0e-93d1b4dd8620.gif)\r\n\r\n# Replicated pool creation\r\n![replicated-pool-creation](https://user-images.githubusercontent.com/16167865/43504608-62e565b4-9564-11e8-93ce-9071744d0e99.gif)\r\n\r\n# Edit replicated pool\r\n![replicated-pool-edit](https://user-images.githubusercontent.com/16167865/43504609-63013848-9564-11e8-8b4f-978e61b7a46f.gif)\r\n\r\n# Pool deletion\r\n![pool-delete](https://user-images.githubusercontent.com/16167865/43504607-62c9304c-9564-11e8-8541-3af3fa3f7470.gif)","created_at":"2018-04-24T09:58:22Z","updated_at":"2018-08-08T11:55:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"737223d369cee20c3a51c822f99691f6d317b789","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sebastian-philipp","id":2574405,"node_id":"MDQ6VXNlcjI1NzQ0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2574405?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-philipp","html_url":"https://github.com/sebastian-philipp","followers_url":"https://api.github.com/users/sebastian-philipp/followers","following_url":"https://api.github.com/users/sebastian-philipp/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-philipp/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-philipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-philipp/subscriptions","organizations_url":"https://api.github.com/users/sebastian-philipp/orgs","repos_url":"https://api.github.com/users/sebastian-philipp/repos","events_url":"https://api.github.com/users/sebastian-philipp/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-philipp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":850326757,"node_id":"MDU6TGFiZWw4NTAzMjY3NTc=","url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false},{"id":134774006,"node_id":"MDU6TGFiZWwxMzQ3NzQwMDY=","url":"https://api.github.com/repos/ceph/ceph/labels/feature","name":"feature","color":"00ff24","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/21614/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/21614/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/21614/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/5c710879fb276bd8295d846d502fc8f77f8747ce","head":{"label":"Devp00l:pool-creation-form","ref":"pool-creation-form","sha":"5c710879fb276bd8295d846d502fc8f77f8747ce","user":{"login":"Devp00l","id":16167865,"node_id":"MDQ6VXNlcjE2MTY3ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/16167865?v=4","gravatar_id":"","url":"https://api.github.com/users/Devp00l","html_url":"https://github.com/Devp00l","followers_url":"https://api.github.com/users/Devp00l/followers","following_url":"https://api.github.com/users/Devp00l/following{/other_user}","gists_url":"https://api.github.com/users/Devp00l/gists{/gist_id}","starred_url":"https://api.github.com/users/Devp00l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devp00l/subscriptions","organizations_url":"https://api.github.com/users/Devp00l/orgs","repos_url":"https://api.github.com/users/Devp00l/repos","events_url":"https://api.github.com/users/Devp00l/events{/privacy}","received_events_url":"https://api.github.com/users/Devp00l/received_events","type":"User","site_admin":false},"repo":{"id":117702152,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MDIxNTI=","name":"ceph","full_name":"Devp00l/ceph","owner":{"login":"Devp00l","id":16167865,"node_id":"MDQ6VXNlcjE2MTY3ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/16167865?v=4","gravatar_id":"","url":"https://api.github.com/users/Devp00l","html_url":"https://github.com/Devp00l","followers_url":"https://api.github.com/users/Devp00l/followers","following_url":"https://api.github.com/users/Devp00l/following{/other_user}","gists_url":"https://api.github.com/users/Devp00l/gists{/gist_id}","starred_url":"https://api.github.com/users/Devp00l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devp00l/subscriptions","organizations_url":"https://api.github.com/users/Devp00l/orgs","repos_url":"https://api.github.com/users/Devp00l/repos","events_url":"https://api.github.com/users/Devp00l/events{/privacy}","received_events_url":"https://api.github.com/users/Devp00l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Devp00l/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/Devp00l/ceph","forks_url":"https://api.github.com/repos/Devp00l/ceph/forks","keys_url":"https://api.github.com/repos/Devp00l/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Devp00l/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Devp00l/ceph/teams","hooks_url":"https://api.github.com/repos/Devp00l/ceph/hooks","issue_events_url":"https://api.github.com/repos/Devp00l/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/Devp00l/ceph/events","assignees_url":"https://api.github.com/repos/Devp00l/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/Devp00l/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/Devp00l/ceph/tags","blobs_url":"https://api.github.com/repos/Devp00l/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Devp00l/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Devp00l/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/Devp00l/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Devp00l/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/Devp00l/ceph/languages","stargazers_url":"https://api.github.com/repos/Devp00l/ceph/stargazers","contributors_url":"https://api.github.com/repos/Devp00l/ceph/contributors","subscribers_url":"https://api.github.com/repos/Devp00l/ceph/subscribers","subscription_url":"https://api.github.com/repos/Devp00l/ceph/subscription","commits_url":"https://api.github.com/repos/Devp00l/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/Devp00l/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/Devp00l/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/Devp00l/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/Devp00l/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/Devp00l/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Devp00l/ceph/merges","archive_url":"https://api.github.com/repos/Devp00l/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Devp00l/ceph/downloads","issues_url":"https://api.github.com/repos/Devp00l/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/Devp00l/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/Devp00l/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/Devp00l/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Devp00l/ceph/labels{/name}","releases_url":"https://api.github.com/repos/Devp00l/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/Devp00l/ceph/deployments","created_at":"2018-01-16T15:31:47Z","updated_at":"2018-08-06T11:25:43Z","pushed_at":"2018-08-08T11:46:21Z","git_url":"git://github.com/Devp00l/ceph.git","ssh_url":"git@github.com:Devp00l/ceph.git","clone_url":"https://github.com/Devp00l/ceph.git","svn_url":"https://github.com/Devp00l/ceph","homepage":"http://ceph.com","size":295538,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"3988351227b8312b470db5170438bba92ec87758","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-08-07T17:14:40Z","pushed_at":"2018-08-08T11:46:24Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":303131,"stargazers_count":4901,"watchers_count":4901,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2568,"mirror_url":null,"archived":false,"open_issues_count":711,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2568,"open_issues":711,"watchers":4901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21614"},"html":{"href":"https://github.com/ceph/ceph/pull/21614"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/21614"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/21614/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21614/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21614/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/5c710879fb276bd8295d846d502fc8f77f8747ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tspmelo"}}