{"action":"created","issue":{"url":"https://api.github.com/repos/neutrinojs/neutrino/issues/1243","repository_url":"https://api.github.com/repos/neutrinojs/neutrino","labels_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/1243/labels{/name}","comments_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/1243/comments","events_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/1243/events","html_url":"https://github.com/neutrinojs/neutrino/issues/1243","id":388821223,"node_id":"MDU6SXNzdWUzODg4MjEyMjM=","number":1243,"title":"vue/v9: css modules cannot co-exist with global styles (could in v8)","user":{"login":"timkelty","id":18329,"node_id":"MDQ6VXNlcjE4MzI5","avatar_url":"https://avatars3.githubusercontent.com/u/18329?v=4","gravatar_id":"","url":"https://api.github.com/users/timkelty","html_url":"https://github.com/timkelty","followers_url":"https://api.github.com/users/timkelty/followers","following_url":"https://api.github.com/users/timkelty/following{/other_user}","gists_url":"https://api.github.com/users/timkelty/gists{/gist_id}","starred_url":"https://api.github.com/users/timkelty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkelty/subscriptions","organizations_url":"https://api.github.com/users/timkelty/orgs","repos_url":"https://api.github.com/users/timkelty/repos","events_url":"https://api.github.com/users/timkelty/events{/privacy}","received_events_url":"https://api.github.com/users/timkelty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"eliperelman","id":285899,"node_id":"MDQ6VXNlcjI4NTg5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/285899?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"assignees":[{"login":"eliperelman","id":285899,"node_id":"MDQ6VXNlcjI4NTg5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/285899?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-07T21:31:25Z","updated_at":"2018-12-10T16:17:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In v8, it was possible to have vue use css modules, but have co-existing global (non-module) styles.\r\n\r\nWith the same config in v9, this doesn't work:\r\n```\r\nModule parse failed: Unexpected token (19:0)\r\nYou may need an appropriate loader to handle this file type.\r\n```\r\n\r\nWorking v8 example: https://github.com/timkelty/vue-scss/tree/v8-working\r\nBroken v8 example: https://github.com/timkelty/vue-scss/tree/v9-broken\r\n\r\nYou can still achieve this in v9, but have to do thing differently:\r\n\r\n1. set `modulesTest` equal to `test` (https://github.com/neutrinojs/neutrino/pull/1242 should help with that)\r\n2. use `:global` in your css where you want global (non-module) styles.\r\n\r\n-----\r\n\r\nIf using modules everywhere and requiring `:global` is the only way to do it in v9, that's fine, but it should probably be noted somewhere, as you could do it in v8. A the very least I think we should merge in https://github.com/neutrinojs/neutrino/pull/1242 so you don't have to set both `test` and `modulesTest`"},"comment":{"url":"https://api.github.com/repos/neutrinojs/neutrino/issues/comments/445874114","html_url":"https://github.com/neutrinojs/neutrino/issues/1243#issuecomment-445874114","issue_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/1243","id":445874114,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTg3NDExNA==","user":{"login":"timkelty","id":18329,"node_id":"MDQ6VXNlcjE4MzI5","avatar_url":"https://avatars3.githubusercontent.com/u/18329?v=4","gravatar_id":"","url":"https://api.github.com/users/timkelty","html_url":"https://github.com/timkelty","followers_url":"https://api.github.com/users/timkelty/followers","following_url":"https://api.github.com/users/timkelty/following{/other_user}","gists_url":"https://api.github.com/users/timkelty/gists{/gist_id}","starred_url":"https://api.github.com/users/timkelty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkelty/subscriptions","organizations_url":"https://api.github.com/users/timkelty/orgs","repos_url":"https://api.github.com/users/timkelty/repos","events_url":"https://api.github.com/users/timkelty/events{/privacy}","received_events_url":"https://api.github.com/users/timkelty/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T16:17:06Z","updated_at":"2018-12-10T16:17:06Z","author_association":"CONTRIBUTOR","body":"I did a little more digging and included webpack configs from vue-cli, which works as expected:\r\n\r\n- output from vue-cli: https://github.com/timkelty/vue-scss/blob/master/vue-cli.js\r\n- output from v9/neutrino: https://github.com/timkelty/vue-scss/blob/master/v9-broken.config\r\n\r\nTo summarize, the goal is to:\r\n\r\n- by default, parse css as global (modules: false)\r\n- in a .vue component, parse `<style module>` as css modules\r\n- in a .js, parse `import 'styles.css'` as global and `import 'styles.module.css'` as css module"}}
{"actor":{"display_login":"timkelty"}}