{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/comments/169194357","pull_request_review_id":97681526,"id":169194357,"diff_hunk":"@@ -1,4 +1,5 @@\n-﻿using System;\n+﻿#if UNITY_EDITOR","path":"Scripts/Utilities/AssetDropUtils.cs","position":2,"original_position":2,"commit_id":"5b1150390359e45c5453555c7cc19197eb5ecb44","original_commit_id":"5b1150390359e45c5453555c7cc19197eb5ecb44","user":{"login":"stella3d","id":14057748,"avatar_url":"https://avatars2.githubusercontent.com/u/14057748?v=4","gravatar_id":"","url":"https://api.github.com/users/stella3d","html_url":"https://github.com/stella3d","followers_url":"https://api.github.com/users/stella3d/followers","following_url":"https://api.github.com/users/stella3d/following{/other_user}","gists_url":"https://api.github.com/users/stella3d/gists{/gist_id}","starred_url":"https://api.github.com/users/stella3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stella3d/subscriptions","organizations_url":"https://api.github.com/users/stella3d/orgs","repos_url":"https://api.github.com/users/stella3d/repos","events_url":"https://api.github.com/users/stella3d/events{/privacy}","received_events_url":"https://api.github.com/users/stella3d/received_events","type":"User","site_admin":false},"body":"i agree completely.  and yeah, we should do it in a PR that does that and only that for the whole project.","created_at":"2018-02-20T00:22:58Z","updated_at":"2018-02-20T00:22:58Z","html_url":"https://github.com/Unity-Technologies/EditorXR/pull/467#discussion_r169194357","pull_request_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/comments/169194357"},"html":{"href":"https://github.com/Unity-Technologies/EditorXR/pull/467#discussion_r169194357"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467"}},"in_reply_to_id":169193457},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467","id":170053048,"html_url":"https://github.com/Unity-Technologies/EditorXR/pull/467","diff_url":"https://github.com/Unity-Technologies/EditorXR/pull/467.diff","patch_url":"https://github.com/Unity-Technologies/EditorXR/pull/467.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/467","number":467,"state":"open","locked":false,"title":"2018 compile fixes","user":{"login":"stella3d","id":14057748,"avatar_url":"https://avatars2.githubusercontent.com/u/14057748?v=4","gravatar_id":"","url":"https://api.github.com/users/stella3d","html_url":"https://github.com/stella3d","followers_url":"https://api.github.com/users/stella3d/followers","following_url":"https://api.github.com/users/stella3d/following{/other_user}","gists_url":"https://api.github.com/users/stella3d/gists{/gist_id}","starred_url":"https://api.github.com/users/stella3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stella3d/subscriptions","organizations_url":"https://api.github.com/users/stella3d/orgs","repos_url":"https://api.github.com/users/stella3d/repos","events_url":"https://api.github.com/users/stella3d/events{/privacy}","received_events_url":"https://api.github.com/users/stella3d/received_events","type":"User","site_admin":false},"body":"adds a few `UNITY_EDITOR` defines , one i missed during the last PR and one for ComponentUtils.\r\n\r\nadds some defines to get rid of warnings about project & hierarchy change events. \r\n\r\nalso fixes the BuildPlayer test to work in Unity 2018, using the new BuildReport object instead of a string.","created_at":"2018-02-19T21:10:24Z","updated_at":"2018-02-20T00:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baee8e206a2ce148f92eac9cfce835b3b9a746c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/467/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/statuses/5b1150390359e45c5453555c7cc19197eb5ecb44","head":{"label":"Unity-Technologies:2018-compile-fixes","ref":"2018-compile-fixes","sha":"5b1150390359e45c5453555c7cc19197eb5ecb44","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":76560415,"name":"EditorXR","full_name":"Unity-Technologies/EditorXR","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/EditorXR","description":"Author XR in XR - See blog post for supporting downloads:","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/EditorXR","forks_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/deployments","created_at":"2016-12-15T13:05:40Z","updated_at":"2018-02-16T20:35:03Z","pushed_at":"2018-02-19T22:54:40Z","git_url":"git://github.com/Unity-Technologies/EditorXR.git","ssh_url":"git@github.com:Unity-Technologies/EditorXR.git","clone_url":"https://github.com/Unity-Technologies/EditorXR.git","svn_url":"https://github.com/Unity-Technologies/EditorXR","homepage":"https://blogs.unity3d.com/2016/12/15/editorvr-experimental-build-available-today/","size":11098,"stargazers_count":483,"watchers_count":483,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":98,"open_issues":88,"watchers":483,"default_branch":"development"}},"base":{"label":"Unity-Technologies:development","ref":"development","sha":"c864914630bd1738171e553027b4191c9c85184d","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":76560415,"name":"EditorXR","full_name":"Unity-Technologies/EditorXR","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/EditorXR","description":"Author XR in XR - See blog post for supporting downloads:","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/EditorXR","forks_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/EditorXR/deployments","created_at":"2016-12-15T13:05:40Z","updated_at":"2018-02-16T20:35:03Z","pushed_at":"2018-02-19T22:54:40Z","git_url":"git://github.com/Unity-Technologies/EditorXR.git","ssh_url":"git@github.com:Unity-Technologies/EditorXR.git","clone_url":"https://github.com/Unity-Technologies/EditorXR.git","svn_url":"https://github.com/Unity-Technologies/EditorXR","homepage":"https://blogs.unity3d.com/2016/12/15/editorvr-experimental-build-available-today/","size":11098,"stargazers_count":483,"watchers_count":483,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":98,"open_issues":88,"watchers":483,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467"},"html":{"href":"https://github.com/Unity-Technologies/EditorXR/pull/467"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/467"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/issues/467/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/pulls/467/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/EditorXR/statuses/5b1150390359e45c5453555c7cc19197eb5ecb44"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stella3d"}}