{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono-addins/pulls/comments/235821290","pull_request_review_id":177777480,"id":235821290,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTgyMTI5MA==","diff_hunk":"@@ -673,10 +676,22 @@ internal string DownloadFile (IProgressMonitor monitor, string url)\n \t\t\t\tthrow;\n \t\t\t} finally {\n \t\t\t\tmonitor.EndTask ();\n-\t\t\t\tmonitor.EndTask ();\n \t\t\t}\n \t\t}\n-\t\t\t\n+\n+\t\tstatic bool WaitForTask (Task<DownloadFileRequest> task, IProgressMonitor monitor)\n+\t\t{\n+\t\t\tbool result = SpinWait.SpinUntil (() => {\n+\t\t\t\treturn monitor.IsCancelRequested || task.IsCompleted || task.IsFaulted;\n+\t\t\t}, 100000); // Use same default timeout as HttpClient.","path":"Mono.Addins.Setup/Mono.Addins.Setup/AddinStore.cs","position":72,"original_position":72,"commit_id":"c3bb5b660e1a44f893dd338b82efcba561d95193","original_commit_id":"c3bb5b660e1a44f893dd338b82efcba561d95193","user":{"login":"Therzok","id":109974,"node_id":"MDQ6VXNlcjEwOTk3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/109974?v=4","gravatar_id":"","url":"https://api.github.com/users/Therzok","html_url":"https://github.com/Therzok","followers_url":"https://api.github.com/users/Therzok/followers","following_url":"https://api.github.com/users/Therzok/following{/other_user}","gists_url":"https://api.github.com/users/Therzok/gists{/gist_id}","starred_url":"https://api.github.com/users/Therzok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Therzok/subscriptions","organizations_url":"https://api.github.com/users/Therzok/orgs","repos_url":"https://api.github.com/users/Therzok/repos","events_url":"https://api.github.com/users/Therzok/events{/privacy}","received_events_url":"https://api.github.com/users/Therzok/received_events","type":"User","site_admin":false},"body":"ie. chain a continuation on the main task that toggles the manualresetevent and do a blocking wait on thsi thread rather than spinning?","created_at":"2018-11-22T21:39:55Z","updated_at":"2018-11-22T21:39:55Z","html_url":"https://github.com/mono/mono-addins/pull/127#discussion_r235821290","pull_request_url":"https://api.github.com/repos/mono/mono-addins/pulls/127","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mono/mono-addins/pulls/comments/235821290"},"html":{"href":"https://github.com/mono/mono-addins/pull/127#discussion_r235821290"},"pull_request":{"href":"https://api.github.com/repos/mono/mono-addins/pulls/127"}},"in_reply_to_id":234997136},"pull_request":{"url":"https://api.github.com/repos/mono/mono-addins/pulls/127","id":232279916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMjc5OTE2","html_url":"https://github.com/mono/mono-addins/pull/127","diff_url":"https://github.com/mono/mono-addins/pull/127.diff","patch_url":"https://github.com/mono/mono-addins/pull/127.patch","issue_url":"https://api.github.com/repos/mono/mono-addins/issues/127","number":127,"state":"closed","locked":false,"title":"Support using HttpClient when downloading files","user":{"login":"mrward","id":372361,"node_id":"MDQ6VXNlcjM3MjM2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/372361?v=4","gravatar_id":"","url":"https://api.github.com/users/mrward","html_url":"https://github.com/mrward","followers_url":"https://api.github.com/users/mrward/followers","following_url":"https://api.github.com/users/mrward/following{/other_user}","gists_url":"https://api.github.com/users/mrward/gists{/gist_id}","starred_url":"https://api.github.com/users/mrward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrward/subscriptions","organizations_url":"https://api.github.com/users/mrward/orgs","repos_url":"https://api.github.com/users/mrward/repos","events_url":"https://api.github.com/users/mrward/events{/privacy}","received_events_url":"https://api.github.com/users/mrward/received_events","type":"User","site_admin":false},"body":"By default the HttpClient will be used when downloading files such\r\nas the addin repository xml and any custom images for the addin\r\nmanager dialog. Also a custom HttpClient factory can be supplied\r\ninstead of the default HttpClient creation. The WebRequestHelper\r\nis still supported if a custom web request handler is being used\r\ninstead.","created_at":"2018-11-20T11:19:26Z","updated_at":"2018-11-22T21:39:55Z","closed_at":"2018-11-20T11:49:48Z","merged_at":"2018-11-20T11:49:48Z","merge_commit_sha":"67cd093f502afcc568383219377eab9a6720b779","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono-addins/pulls/127/commits","review_comments_url":"https://api.github.com/repos/mono/mono-addins/pulls/127/comments","review_comment_url":"https://api.github.com/repos/mono/mono-addins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono-addins/issues/127/comments","statuses_url":"https://api.github.com/repos/mono/mono-addins/statuses/c3bb5b660e1a44f893dd338b82efcba561d95193","head":{"label":"mono:http-client","ref":"http-client","sha":"c3bb5b660e1a44f893dd338b82efcba561d95193","user":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791290,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEyOTA=","name":"mono-addins","full_name":"mono/mono-addins","private":false,"owner":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mono/mono-addins","description":"Mono.Addins is a generic framework for creating extensible applications, and for creating add-ins which extend those applications.","fork":false,"url":"https://api.github.com/repos/mono/mono-addins","forks_url":"https://api.github.com/repos/mono/mono-addins/forks","keys_url":"https://api.github.com/repos/mono/mono-addins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono-addins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono-addins/teams","hooks_url":"https://api.github.com/repos/mono/mono-addins/hooks","issue_events_url":"https://api.github.com/repos/mono/mono-addins/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono-addins/events","assignees_url":"https://api.github.com/repos/mono/mono-addins/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono-addins/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono-addins/tags","blobs_url":"https://api.github.com/repos/mono/mono-addins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono-addins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono-addins/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono-addins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono-addins/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono-addins/languages","stargazers_url":"https://api.github.com/repos/mono/mono-addins/stargazers","contributors_url":"https://api.github.com/repos/mono/mono-addins/contributors","subscribers_url":"https://api.github.com/repos/mono/mono-addins/subscribers","subscription_url":"https://api.github.com/repos/mono/mono-addins/subscription","commits_url":"https://api.github.com/repos/mono/mono-addins/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono-addins/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono-addins/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono-addins/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono-addins/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono-addins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono-addins/merges","archive_url":"https://api.github.com/repos/mono/mono-addins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono-addins/downloads","issues_url":"https://api.github.com/repos/mono/mono-addins/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono-addins/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono-addins/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono-addins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono-addins/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono-addins/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono-addins/deployments","created_at":"2010-07-22T16:06:31Z","updated_at":"2018-11-20T11:49:51Z","pushed_at":"2018-11-20T11:49:51Z","git_url":"git://github.com/mono/mono-addins.git","ssh_url":"git@github.com:mono/mono-addins.git","clone_url":"https://github.com/mono/mono-addins.git","svn_url":"https://github.com/mono/mono-addins","homepage":"","size":4056,"stargazers_count":129,"watchers_count":129,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":71,"open_issues":33,"watchers":129,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"e84472dcd17b61a904538e1cc2e19f4b064c7068","user":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791290,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEyOTA=","name":"mono-addins","full_name":"mono/mono-addins","private":false,"owner":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mono/mono-addins","description":"Mono.Addins is a generic framework for creating extensible applications, and for creating add-ins which extend those applications.","fork":false,"url":"https://api.github.com/repos/mono/mono-addins","forks_url":"https://api.github.com/repos/mono/mono-addins/forks","keys_url":"https://api.github.com/repos/mono/mono-addins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono-addins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono-addins/teams","hooks_url":"https://api.github.com/repos/mono/mono-addins/hooks","issue_events_url":"https://api.github.com/repos/mono/mono-addins/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono-addins/events","assignees_url":"https://api.github.com/repos/mono/mono-addins/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono-addins/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono-addins/tags","blobs_url":"https://api.github.com/repos/mono/mono-addins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono-addins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono-addins/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono-addins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono-addins/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono-addins/languages","stargazers_url":"https://api.github.com/repos/mono/mono-addins/stargazers","contributors_url":"https://api.github.com/repos/mono/mono-addins/contributors","subscribers_url":"https://api.github.com/repos/mono/mono-addins/subscribers","subscription_url":"https://api.github.com/repos/mono/mono-addins/subscription","commits_url":"https://api.github.com/repos/mono/mono-addins/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono-addins/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono-addins/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono-addins/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono-addins/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono-addins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono-addins/merges","archive_url":"https://api.github.com/repos/mono/mono-addins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono-addins/downloads","issues_url":"https://api.github.com/repos/mono/mono-addins/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono-addins/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono-addins/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono-addins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono-addins/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono-addins/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono-addins/deployments","created_at":"2010-07-22T16:06:31Z","updated_at":"2018-11-20T11:49:51Z","pushed_at":"2018-11-20T11:49:51Z","git_url":"git://github.com/mono/mono-addins.git","ssh_url":"git@github.com:mono/mono-addins.git","clone_url":"https://github.com/mono/mono-addins.git","svn_url":"https://github.com/mono/mono-addins","homepage":"","size":4056,"stargazers_count":129,"watchers_count":129,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":71,"open_issues":33,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono-addins/pulls/127"},"html":{"href":"https://github.com/mono/mono-addins/pull/127"},"issue":{"href":"https://api.github.com/repos/mono/mono-addins/issues/127"},"comments":{"href":"https://api.github.com/repos/mono/mono-addins/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono-addins/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono-addins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono-addins/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono-addins/statuses/c3bb5b660e1a44f893dd338b82efcba561d95193"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Therzok"}}