{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/comments/188148752","pull_request_review_id":120067914,"id":188148752,"diff_hunk":"@@ -343,8 +343,7 @@ protected function addUnversionedButtons(DataObject $record, FieldList $actions)\n         if (!$saveAction) {\n             return;\n         }\n-        $ownsObjects = !empty($record->config()->get('owns'));\n-        if (!$ownsObjects) {\n+        if (!$this->record->ID) {","path":"src/VersionedGridFieldItemRequest.php","position":6,"original_position":6,"commit_id":"2d9da09472f7dbbf767d3c1cc10eff329971ed40","original_commit_id":"6393d6fd288f175c4bda3dfac02b5e24f2c649fb","user":{"login":"unclecheese","id":654636,"avatar_url":"https://avatars1.githubusercontent.com/u/654636?v=4","gravatar_id":"","url":"https://api.github.com/users/unclecheese","html_url":"https://github.com/unclecheese","followers_url":"https://api.github.com/users/unclecheese/followers","following_url":"https://api.github.com/users/unclecheese/following{/other_user}","gists_url":"https://api.github.com/users/unclecheese/gists{/gist_id}","starred_url":"https://api.github.com/users/unclecheese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unclecheese/subscriptions","organizations_url":"https://api.github.com/users/unclecheese/orgs","repos_url":"https://api.github.com/users/unclecheese/repos","events_url":"https://api.github.com/users/unclecheese/events{/privacy}","received_events_url":"https://api.github.com/users/unclecheese/received_events","type":"User","site_admin":false},"body":"I don't think so. If the record is new, the button should always read \"create,\" regardless of ownership structure.","created_at":"2018-05-15T02:16:12Z","updated_at":"2018-05-15T02:16:18Z","html_url":"https://github.com/silverstripe/silverstripe-versioned/pull/151#discussion_r188148752","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/comments/188148752"},"html":{"href":"https://github.com/silverstripe/silverstripe-versioned/pull/151#discussion_r188148752"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151"}},"in_reply_to_id":186594300},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151","id":186493202,"html_url":"https://github.com/silverstripe/silverstripe-versioned/pull/151","diff_url":"https://github.com/silverstripe/silverstripe-versioned/pull/151.diff","patch_url":"https://github.com/silverstripe/silverstripe-versioned/pull/151.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/issues/151","number":151,"state":"open","locked":false,"title":"Use record ID to detect new item for button label","user":{"login":"lukereative","id":1415622,"avatar_url":"https://avatars3.githubusercontent.com/u/1415622?v=4","gravatar_id":"","url":"https://api.github.com/users/lukereative","html_url":"https://github.com/lukereative","followers_url":"https://api.github.com/users/lukereative/followers","following_url":"https://api.github.com/users/lukereative/following{/other_user}","gists_url":"https://api.github.com/users/lukereative/gists{/gist_id}","starred_url":"https://api.github.com/users/lukereative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukereative/subscriptions","organizations_url":"https://api.github.com/users/lukereative/orgs","repos_url":"https://api.github.com/users/lukereative/repos","events_url":"https://api.github.com/users/lukereative/events{/privacy}","received_events_url":"https://api.github.com/users/lukereative/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/silverstripe/silverstripe-framework/issues/8029","created_at":"2018-05-07T23:46:31Z","updated_at":"2018-05-15T02:16:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6838262766e156347463d2338dc0912b0deb48aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/issues/151/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/statuses/2d9da09472f7dbbf767d3c1cc10eff329971ed40","head":{"label":"open-sausages:pulls/1/unapply-changes","ref":"pulls/1/unapply-changes","sha":"2d9da09472f7dbbf767d3c1cc10eff329971ed40","user":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars2.githubusercontent.com/u/12824172?v=4","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"repo":{"id":86012172,"name":"silverstripe-versioned","full_name":"open-sausages/silverstripe-versioned","owner":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars2.githubusercontent.com/u/12824172?v=4","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-sausages/silverstripe-versioned","description":"Versioning for SilverStripe model","fork":true,"url":"https://api.github.com/repos/open-sausages/silverstripe-versioned","forks_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/forks","keys_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/teams","hooks_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/hooks","issue_events_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/issues/events{/number}","events_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/events","assignees_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/assignees{/user}","branches_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/branches{/branch}","tags_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/tags","blobs_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/statuses/{sha}","languages_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/languages","stargazers_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/stargazers","contributors_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/contributors","subscribers_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/subscribers","subscription_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/subscription","commits_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/contents/{+path}","compare_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/merges","archive_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/downloads","issues_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/issues{/number}","pulls_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/pulls{/number}","milestones_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/milestones{/number}","notifications_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/labels{/name}","releases_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/releases{/id}","deployments_url":"https://api.github.com/repos/open-sausages/silverstripe-versioned/deployments","created_at":"2017-03-24T00:57:27Z","updated_at":"2017-03-24T00:57:28Z","pushed_at":"2018-05-09T21:07:25Z","git_url":"git://github.com/open-sausages/silverstripe-versioned.git","ssh_url":"git@github.com:open-sausages/silverstripe-versioned.git","clone_url":"https://github.com/open-sausages/silverstripe-versioned.git","svn_url":"https://github.com/open-sausages/silverstripe-versioned","homepage":null,"size":690,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:1","ref":"1","sha":"50278a56d564c37eca605babc861b94101ddbf78","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":85634633,"name":"silverstripe-versioned","full_name":"silverstripe/silverstripe-versioned","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-versioned","description":"Versioning for SilverStripe model","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-versioned","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-versioned/deployments","created_at":"2017-03-20T22:43:58Z","updated_at":"2018-04-23T22:40:40Z","pushed_at":"2018-05-09T21:07:27Z","git_url":"git://github.com/silverstripe/silverstripe-versioned.git","ssh_url":"git@github.com:silverstripe/silverstripe-versioned.git","clone_url":"https://github.com/silverstripe/silverstripe-versioned.git","svn_url":"https://github.com/silverstripe/silverstripe-versioned","homepage":null,"size":665,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":13,"open_issues":26,"watchers":4,"default_branch":"1"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151"},"html":{"href":"https://github.com/silverstripe/silverstripe-versioned/pull/151"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/issues/151"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-versioned/statuses/2d9da09472f7dbbf767d3c1cc10eff329971ed40"}},"author_association":"NONE"}}
{"actor":{"display_login":"unclecheese"}}