{"action":"closed","number":598,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/598","id":48164397,"html_url":"https://github.com/spring-projects/spring-security-oauth/pull/598","diff_url":"https://github.com/spring-projects/spring-security-oauth/pull/598.diff","patch_url":"https://github.com/spring-projects/spring-security-oauth/pull/598.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/issues/598","number":598,"state":"closed","locked":false,"title":"Make WebResponseExceptionTranslator generic to ease custom error formats for resource servers","user":{"login":"michaeltecourt","id":7481254,"avatar_url":"https://avatars2.githubusercontent.com/u/7481254?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltecourt","html_url":"https://github.com/michaeltecourt","followers_url":"https://api.github.com/users/michaeltecourt/followers","following_url":"https://api.github.com/users/michaeltecourt/following{/other_user}","gists_url":"https://api.github.com/users/michaeltecourt/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltecourt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltecourt/subscriptions","organizations_url":"https://api.github.com/users/michaeltecourt/orgs","repos_url":"https://api.github.com/users/michaeltecourt/repos","events_url":"https://api.github.com/users/michaeltecourt/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltecourt/received_events","type":"User","site_admin":false},"body":"The OAuth 2.0 specification defines how the authorization server error responses must be, but it does not force resource servers to adopt the same format. \nWhile adding OAuth 2.0 security to our services, we found it confusing for our clients to have to deal with two different error formats : one for \"business errors\" the other for authorization errors.\n\nMaking `WebResponseExceptionTranslator<T>` generic allows Resource Servers to easily implement their own error format on top of framework classes, instead of having to copy a bunch of classes : \n`AbstractOauth2SecurityExceptionHandler`, etc.\n\nOn the Authorization Server side, the only change is that components\nexplicitely define that the error type should be OAuth2Exception :\n`WebResponseExceptionTranslator<OAuth2Exception>`\n","created_at":"2015-10-20T07:17:55Z","updated_at":"2018-02-13T19:13:51Z","closed_at":"2018-02-13T19:13:51Z","merged_at":null,"merge_commit_sha":"adf82b4588471d1999762dd226ea495762927111","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":74113587,"url":"https://api.github.com/repos/spring-projects/spring-security-oauth/labels/Improvement","name":"Improvement","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-security-oauth/milestones/30","html_url":"https://github.com/spring-projects/spring-security-oauth/milestone/30","labels_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/milestones/30/labels","id":2774591,"number":30,"title":"2.3.0.RC1","description":"","creator":{"login":"jgrandja","id":10884212,"avatar_url":"https://avatars1.githubusercontent.com/u/10884212?v=4","gravatar_id":"","url":"https://api.github.com/users/jgrandja","html_url":"https://github.com/jgrandja","followers_url":"https://api.github.com/users/jgrandja/followers","following_url":"https://api.github.com/users/jgrandja/following{/other_user}","gists_url":"https://api.github.com/users/jgrandja/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrandja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrandja/subscriptions","organizations_url":"https://api.github.com/users/jgrandja/orgs","repos_url":"https://api.github.com/users/jgrandja/repos","events_url":"https://api.github.com/users/jgrandja/events{/privacy}","received_events_url":"https://api.github.com/users/jgrandja/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2017-09-18T16:01:12Z","updated_at":"2018-02-13T19:13:51Z","due_on":"2018-02-27T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/598/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/598/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/issues/598/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/statuses/4f2d8a9b4f71823e535d6bac6bb20dbb1658fe09","head":{"label":"michaeltecourt:ako-generic-exceptiontranslator","ref":"ako-generic-exceptiontranslator","sha":"4f2d8a9b4f71823e535d6bac6bb20dbb1658fe09","user":{"login":"michaeltecourt","id":7481254,"avatar_url":"https://avatars2.githubusercontent.com/u/7481254?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltecourt","html_url":"https://github.com/michaeltecourt","followers_url":"https://api.github.com/users/michaeltecourt/followers","following_url":"https://api.github.com/users/michaeltecourt/following{/other_user}","gists_url":"https://api.github.com/users/michaeltecourt/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltecourt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltecourt/subscriptions","organizations_url":"https://api.github.com/users/michaeltecourt/orgs","repos_url":"https://api.github.com/users/michaeltecourt/repos","events_url":"https://api.github.com/users/michaeltecourt/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltecourt/received_events","type":"User","site_admin":false},"repo":{"id":44523332,"name":"spring-security-oauth","full_name":"michaeltecourt/spring-security-oauth","owner":{"login":"michaeltecourt","id":7481254,"avatar_url":"https://avatars2.githubusercontent.com/u/7481254?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltecourt","html_url":"https://github.com/michaeltecourt","followers_url":"https://api.github.com/users/michaeltecourt/followers","following_url":"https://api.github.com/users/michaeltecourt/following{/other_user}","gists_url":"https://api.github.com/users/michaeltecourt/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltecourt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltecourt/subscriptions","organizations_url":"https://api.github.com/users/michaeltecourt/orgs","repos_url":"https://api.github.com/users/michaeltecourt/repos","events_url":"https://api.github.com/users/michaeltecourt/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltecourt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaeltecourt/spring-security-oauth","description":"Support for adding OAuth1(a) and OAuth2 features (consumer and provider) for Spring web applications.","fork":true,"url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth","forks_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/forks","keys_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/teams","hooks_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/hooks","issue_events_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/issues/events{/number}","events_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/events","assignees_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/assignees{/user}","branches_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/branches{/branch}","tags_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/tags","blobs_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/languages","stargazers_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/stargazers","contributors_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/contributors","subscribers_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/subscribers","subscription_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/subscription","commits_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/contents/{+path}","compare_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/merges","archive_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/downloads","issues_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/issues{/number}","pulls_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/labels{/name}","releases_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/releases{/id}","deployments_url":"https://api.github.com/repos/michaeltecourt/spring-security-oauth/deployments","created_at":"2015-10-19T09:11:01Z","updated_at":"2017-12-15T23:39:43Z","pushed_at":"2017-12-16T17:44:02Z","git_url":"git://github.com/michaeltecourt/spring-security-oauth.git","ssh_url":"git@github.com:michaeltecourt/spring-security-oauth.git","clone_url":"https://github.com/michaeltecourt/spring-security-oauth.git","svn_url":"https://github.com/michaeltecourt/spring-security-oauth","homepage":"http://github.com/SpringSource/spring-security-oauth","size":5674,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"fed554e6daaf7b086c2d5f22fa7b72494b6ab40f","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2108481,"name":"spring-security-oauth","full_name":"spring-projects/spring-security-oauth","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-security-oauth","description":"Support for adding OAuth1(a) and OAuth2 features (consumer and provider) for Spring web applications.","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-security-oauth","forks_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-security-oauth/deployments","created_at":"2011-07-26T18:08:49Z","updated_at":"2018-02-13T00:47:39Z","pushed_at":"2018-02-13T19:11:48Z","git_url":"git://github.com/spring-projects/spring-security-oauth.git","ssh_url":"git@github.com:spring-projects/spring-security-oauth.git","clone_url":"https://github.com/spring-projects/spring-security-oauth.git","svn_url":"https://github.com/spring-projects/spring-security-oauth","homepage":"http://github.com/SpringSource/spring-security-oauth","size":5770,"stargazers_count":2545,"watchers_count":2545,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2628,"mirror_url":null,"archived":false,"open_issues_count":483,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2628,"open_issues":483,"watchers":2545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/598"},"html":{"href":"https://github.com/spring-projects/spring-security-oauth/pull/598"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-security-oauth/issues/598"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-security-oauth/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-security-oauth/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-security-oauth/statuses/4f2d8a9b4f71823e535d6bac6bb20dbb1658fe09"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":46,"deletions":26,"changed_files":8}}
{"actor":{"display_login":"jgrandja"}}