{"action":"created","issue":{"url":"https://api.github.com/repos/glitchassassin/lackey/issues/140","repository_url":"https://api.github.com/repos/glitchassassin/lackey","labels_url":"https://api.github.com/repos/glitchassassin/lackey/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/glitchassassin/lackey/issues/140/comments","events_url":"https://api.github.com/repos/glitchassassin/lackey/issues/140/events","html_url":"https://github.com/glitchassassin/lackey/issues/140","id":381053315,"node_id":"MDU6SXNzdWUzODEwNTMzMTU=","number":140,"title":"Image Match return True when the images have different color.","user":{"login":"gzll","id":25604382,"node_id":"MDQ6VXNlcjI1NjA0Mzgy","avatar_url":"https://avatars0.githubusercontent.com/u/25604382?v=4","gravatar_id":"","url":"https://api.github.com/users/gzll","html_url":"https://github.com/gzll","followers_url":"https://api.github.com/users/gzll/followers","following_url":"https://api.github.com/users/gzll/following{/other_user}","gists_url":"https://api.github.com/users/gzll/gists{/gist_id}","starred_url":"https://api.github.com/users/gzll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzll/subscriptions","organizations_url":"https://api.github.com/users/gzll/orgs","repos_url":"https://api.github.com/users/gzll/repos","events_url":"https://api.github.com/users/gzll/events{/privacy}","received_events_url":"https://api.github.com/users/gzll/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-15T08:38:06Z","updated_at":"2018-11-16T02:48:40Z","closed_at":null,"author_association":"NONE","body":"https://github.com/glitchassassin/lackey/blob/7adadfacd7f45d81186710be992f5668b15399fe/lackey/TemplateMatchers.py#L24\r\nthe app gui have some image buttons, when click them, their color will become yellow from blue.\r\n![tradeonly_selected](https://user-images.githubusercontent.com/25604382/48539980-c4211700-e8f3-11e8-9422-d8d76ce0078a.png)\r\n![tradeonly](https://user-images.githubusercontent.com/25604382/48539999-d0a56f80-e8f3-11e8-8216-3696688d14a9.png)\r\nthe find() or exists() function will return the match info, when the button is blue, and the match image is yellow, this is  incorrect.\r\nbut if inverse, the button is yellow, and the match image is blue, the function doesn't find anything. this is correct.\r\nwhy?\r\nI compare lackey with SikuliX1's source code (doFindMatch() in Finder2.java), but cannot get any idea."},"comment":{"url":"https://api.github.com/repos/glitchassassin/lackey/issues/comments/439263987","html_url":"https://github.com/glitchassassin/lackey/issues/140#issuecomment-439263987","issue_url":"https://api.github.com/repos/glitchassassin/lackey/issues/140","id":439263987,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTI2Mzk4Nw==","user":{"login":"gzll","id":25604382,"node_id":"MDQ6VXNlcjI1NjA0Mzgy","avatar_url":"https://avatars0.githubusercontent.com/u/25604382?v=4","gravatar_id":"","url":"https://api.github.com/users/gzll","html_url":"https://github.com/gzll","followers_url":"https://api.github.com/users/gzll/followers","following_url":"https://api.github.com/users/gzll/following{/other_user}","gists_url":"https://api.github.com/users/gzll/gists{/gist_id}","starred_url":"https://api.github.com/users/gzll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzll/subscriptions","organizations_url":"https://api.github.com/users/gzll/orgs","repos_url":"https://api.github.com/users/gzll/repos","events_url":"https://api.github.com/users/gzll/events{/privacy}","received_events_url":"https://api.github.com/users/gzll/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T02:48:40Z","updated_at":"2018-11-16T02:48:40Z","author_association":"NONE","body":"Got, Convert to grayscale for performance reason.\r\nI test the scenario in lackey and SIKULIX1, but results is very different.\r\nthe scenario:  the blue image button, compared with a blue image button screen crap, and a yellow one.\r\nlackey:  if a blue crap, the confidence is 1.0, if yellow, it is something like 0.9995211958885193.\r\nSIKULIX1(test with the \"pattern setting\"'s \"Matching Preview\" GUI): if blue, 0.99, if yellow, never matched, but when the confidence is down below 0.4, the matching is another yellow image button on the GUI.\r\nso I think SIKULIX1 maybe still keeping the BGR channels for matching.\r\nhttps://github.com/RaiMan/SikuliX1/blob/98ac9872e6d186c699cebcef1dc44e72dc17f87a/API/src/main/java/org/sikuli/script/FindInput2.java#L213\r\nhttps://github.com/RaiMan/SikuliX1/blob/98ac9872e6d186c699cebcef1dc44e72dc17f87a/API/src/main/java/org/sikuli/script/Finder2.java#L605\r\nhttps://github.com/RaiMan/SikuliX1/blob/98ac9872e6d186c699cebcef1dc44e72dc17f87a/API/src/main/java/org/sikuli/script/Finder2.java#L349 "}}
{"actor":{"display_login":"gzll"}}