{"action":"created","comment":{"url":"https://api.github.com/repos/google/google-http-java-client/pulls/comments/165459251","pull_request_review_id":93403479,"id":165459251,"diff_hunk":"@@ -36,9 +40,11 @@\n  */\n public class OpenCensusUtilsTest extends TestCase {\n \n-  @Rule public ExpectedException thrown = ExpectedException.none();\n   TextFormat mockTextFormat;\n   TextFormat.Setter mockTextFormatSetter;\n+  TextFormat originTextFormat;\n+  TextFormat.Setter originTextFormatSetter;\n+  Span mockSpan;","path":"google-http-client/src/test/java/com/google/api/client/util/OpenCensusUtilsTest.java","position":34,"original_position":34,"commit_id":"7b54f656d9dbe2f92b9934eecfe16c25070cd9f8","original_commit_id":"7b54f656d9dbe2f92b9934eecfe16c25070cd9f8","user":{"login":"HailongWen","id":7017904,"avatar_url":"https://avatars1.githubusercontent.com/u/7017904?v=4","gravatar_id":"","url":"https://api.github.com/users/HailongWen","html_url":"https://github.com/HailongWen","followers_url":"https://api.github.com/users/HailongWen/followers","following_url":"https://api.github.com/users/HailongWen/following{/other_user}","gists_url":"https://api.github.com/users/HailongWen/gists{/gist_id}","starred_url":"https://api.github.com/users/HailongWen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HailongWen/subscriptions","organizations_url":"https://api.github.com/users/HailongWen/orgs","repos_url":"https://api.github.com/users/HailongWen/repos","events_url":"https://api.github.com/users/HailongWen/events{/privacy}","received_events_url":"https://api.github.com/users/HailongWen/received_events","type":"User","site_admin":false},"body":"It seems that most of the test mocks are written manually so I just followed that convention, Besides all the tests are written in JUnit3 style.\r\n\r\nBut yeah I think that is a good idea. I'll rewrite that.","created_at":"2018-02-01T19:17:45Z","updated_at":"2018-02-01T19:17:45Z","html_url":"https://github.com/google/google-http-java-client/pull/394#discussion_r165459251","pull_request_url":"https://api.github.com/repos/google/google-http-java-client/pulls/394","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/google-http-java-client/pulls/comments/165459251"},"html":{"href":"https://github.com/google/google-http-java-client/pull/394#discussion_r165459251"},"pull_request":{"href":"https://api.github.com/repos/google/google-http-java-client/pulls/394"}},"in_reply_to_id":165453298},"pull_request":{"url":"https://api.github.com/repos/google/google-http-java-client/pulls/394","id":166366708,"html_url":"https://github.com/google/google-http-java-client/pull/394","diff_url":"https://github.com/google/google-http-java-client/pull/394.diff","patch_url":"https://github.com/google/google-http-java-client/pull/394.patch","issue_url":"https://api.github.com/repos/google/google-http-java-client/issues/394","number":394,"state":"open","locked":false,"title":"Enhance OpenCensus tracing instrumentation.","user":{"login":"HailongWen","id":7017904,"avatar_url":"https://avatars1.githubusercontent.com/u/7017904?v=4","gravatar_id":"","url":"https://api.github.com/users/HailongWen","html_url":"https://github.com/HailongWen","followers_url":"https://api.github.com/users/HailongWen/followers","following_url":"https://api.github.com/users/HailongWen/following{/other_user}","gists_url":"https://api.github.com/users/HailongWen/gists{/gist_id}","starred_url":"https://api.github.com/users/HailongWen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HailongWen/subscriptions","organizations_url":"https://api.github.com/users/HailongWen/orgs","repos_url":"https://api.github.com/users/HailongWen/repos","events_url":"https://api.github.com/users/HailongWen/events{/privacy}","received_events_url":"https://api.github.com/users/HailongWen/received_events","type":"User","site_admin":false},"body":"* Add method and instrumentation to record message events with content-length when sending/receiving\r\nrequest/response.\r\n\r\n* Refine API, add `volatile` modifiers to internal attributes.\r\n\r\n* Use `registerSpanNamesForCollection` to replace `setSampleToLocalSpanStore`.\r\n\r\n* Add get/set method for recordEvent so users can controll whether to expose collected spans.\r\n\r\n* Add more tests and rewrite/fix test cases with JUnit 3 style.\r\n\r\n* Fix/refine javadoc and messages.\r\n\r\nI have done some basic integration test locally and fix some defects. Codes can be found [here](https://github.com/HailongWen/opencensus-java/blob/google-http-java-client-interop-testing/examples/src/test/java/io/opencensus/examples/trace/GoogleHttpJavaClientInteropTesting.java)\r\n\r\nPlease @mattwhisenhunt kindly help on merging this PR after @bogdandrutu 's review.\r\nThere might be 1 more PR on stats collecting.","created_at":"2018-01-31T20:24:30Z","updated_at":"2018-02-01T19:17:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"322b03920b95e964fe1b6c3c4e8b4af2aca45ec1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/google-http-java-client/pulls/394/commits","review_comments_url":"https://api.github.com/repos/google/google-http-java-client/pulls/394/comments","review_comment_url":"https://api.github.com/repos/google/google-http-java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/google-http-java-client/issues/394/comments","statuses_url":"https://api.github.com/repos/google/google-http-java-client/statuses/7b54f656d9dbe2f92b9934eecfe16c25070cd9f8","head":{"label":"HailongWen:opencensus-instrumentation-enhance","ref":"opencensus-instrumentation-enhance","sha":"7b54f656d9dbe2f92b9934eecfe16c25070cd9f8","user":{"login":"HailongWen","id":7017904,"avatar_url":"https://avatars1.githubusercontent.com/u/7017904?v=4","gravatar_id":"","url":"https://api.github.com/users/HailongWen","html_url":"https://github.com/HailongWen","followers_url":"https://api.github.com/users/HailongWen/followers","following_url":"https://api.github.com/users/HailongWen/following{/other_user}","gists_url":"https://api.github.com/users/HailongWen/gists{/gist_id}","starred_url":"https://api.github.com/users/HailongWen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HailongWen/subscriptions","organizations_url":"https://api.github.com/users/HailongWen/orgs","repos_url":"https://api.github.com/users/HailongWen/repos","events_url":"https://api.github.com/users/HailongWen/events{/privacy}","received_events_url":"https://api.github.com/users/HailongWen/received_events","type":"User","site_admin":false},"repo":{"id":117296484,"name":"google-http-java-client","full_name":"HailongWen/google-http-java-client","owner":{"login":"HailongWen","id":7017904,"avatar_url":"https://avatars1.githubusercontent.com/u/7017904?v=4","gravatar_id":"","url":"https://api.github.com/users/HailongWen","html_url":"https://github.com/HailongWen","followers_url":"https://api.github.com/users/HailongWen/followers","following_url":"https://api.github.com/users/HailongWen/following{/other_user}","gists_url":"https://api.github.com/users/HailongWen/gists{/gist_id}","starred_url":"https://api.github.com/users/HailongWen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HailongWen/subscriptions","organizations_url":"https://api.github.com/users/HailongWen/orgs","repos_url":"https://api.github.com/users/HailongWen/repos","events_url":"https://api.github.com/users/HailongWen/events{/privacy}","received_events_url":"https://api.github.com/users/HailongWen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HailongWen/google-http-java-client","description":"Google HTTP Client Library for Java","fork":true,"url":"https://api.github.com/repos/HailongWen/google-http-java-client","forks_url":"https://api.github.com/repos/HailongWen/google-http-java-client/forks","keys_url":"https://api.github.com/repos/HailongWen/google-http-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HailongWen/google-http-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HailongWen/google-http-java-client/teams","hooks_url":"https://api.github.com/repos/HailongWen/google-http-java-client/hooks","issue_events_url":"https://api.github.com/repos/HailongWen/google-http-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/HailongWen/google-http-java-client/events","assignees_url":"https://api.github.com/repos/HailongWen/google-http-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/HailongWen/google-http-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/HailongWen/google-http-java-client/tags","blobs_url":"https://api.github.com/repos/HailongWen/google-http-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HailongWen/google-http-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HailongWen/google-http-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/HailongWen/google-http-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HailongWen/google-http-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/HailongWen/google-http-java-client/languages","stargazers_url":"https://api.github.com/repos/HailongWen/google-http-java-client/stargazers","contributors_url":"https://api.github.com/repos/HailongWen/google-http-java-client/contributors","subscribers_url":"https://api.github.com/repos/HailongWen/google-http-java-client/subscribers","subscription_url":"https://api.github.com/repos/HailongWen/google-http-java-client/subscription","commits_url":"https://api.github.com/repos/HailongWen/google-http-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/HailongWen/google-http-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/HailongWen/google-http-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/HailongWen/google-http-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/HailongWen/google-http-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/HailongWen/google-http-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HailongWen/google-http-java-client/merges","archive_url":"https://api.github.com/repos/HailongWen/google-http-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HailongWen/google-http-java-client/downloads","issues_url":"https://api.github.com/repos/HailongWen/google-http-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/HailongWen/google-http-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/HailongWen/google-http-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/HailongWen/google-http-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HailongWen/google-http-java-client/labels{/name}","releases_url":"https://api.github.com/repos/HailongWen/google-http-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/HailongWen/google-http-java-client/deployments","created_at":"2018-01-12T23:09:48Z","updated_at":"2018-01-12T23:09:51Z","pushed_at":"2018-01-31T20:16:28Z","git_url":"git://github.com/HailongWen/google-http-java-client.git","ssh_url":"git@github.com:HailongWen/google-http-java-client.git","clone_url":"https://github.com/HailongWen/google-http-java-client.git","svn_url":"https://github.com/HailongWen/google-http-java-client","homepage":"","size":7277,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"google:dev","ref":"dev","sha":"2f6720576b64c344912ec79b75a879900ad424fd","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":28992330,"name":"google-http-java-client","full_name":"google/google-http-java-client","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/google-http-java-client","description":"Google HTTP Client Library for Java","fork":false,"url":"https://api.github.com/repos/google/google-http-java-client","forks_url":"https://api.github.com/repos/google/google-http-java-client/forks","keys_url":"https://api.github.com/repos/google/google-http-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/google-http-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/google-http-java-client/teams","hooks_url":"https://api.github.com/repos/google/google-http-java-client/hooks","issue_events_url":"https://api.github.com/repos/google/google-http-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/google/google-http-java-client/events","assignees_url":"https://api.github.com/repos/google/google-http-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/google/google-http-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/google/google-http-java-client/tags","blobs_url":"https://api.github.com/repos/google/google-http-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/google-http-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/google-http-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/google-http-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/google-http-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/google/google-http-java-client/languages","stargazers_url":"https://api.github.com/repos/google/google-http-java-client/stargazers","contributors_url":"https://api.github.com/repos/google/google-http-java-client/contributors","subscribers_url":"https://api.github.com/repos/google/google-http-java-client/subscribers","subscription_url":"https://api.github.com/repos/google/google-http-java-client/subscription","commits_url":"https://api.github.com/repos/google/google-http-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/google-http-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/google-http-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/google-http-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/google-http-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/google/google-http-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/google-http-java-client/merges","archive_url":"https://api.github.com/repos/google/google-http-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/google-http-java-client/downloads","issues_url":"https://api.github.com/repos/google/google-http-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/google/google-http-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/google/google-http-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/google/google-http-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/google-http-java-client/labels{/name}","releases_url":"https://api.github.com/repos/google/google-http-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/google/google-http-java-client/deployments","created_at":"2015-01-09T00:00:41Z","updated_at":"2018-02-01T00:57:43Z","pushed_at":"2018-01-31T20:24:31Z","git_url":"git://github.com/google/google-http-java-client.git","ssh_url":"git@github.com:google/google-http-java-client.git","clone_url":"https://github.com/google/google-http-java-client.git","svn_url":"https://github.com/google/google-http-java-client","homepage":"","size":7272,"stargazers_count":767,"watchers_count":767,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":273,"open_issues":142,"watchers":767,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/google-http-java-client/pulls/394"},"html":{"href":"https://github.com/google/google-http-java-client/pull/394"},"issue":{"href":"https://api.github.com/repos/google/google-http-java-client/issues/394"},"comments":{"href":"https://api.github.com/repos/google/google-http-java-client/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/google/google-http-java-client/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/google/google-http-java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/google-http-java-client/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/google/google-http-java-client/statuses/7b54f656d9dbe2f92b9934eecfe16c25070cd9f8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"HailongWen"}}