{"comment":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/comments/31109718","html_url":"https://github.com/wxWidgets/wxWidgets/commit/71bb680a93a05947b6c82842fdcf5e79c842f944#commitcomment-31109718","id":31109718,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzMTEwOTcxOA==","user":{"login":"vadz","id":146917,"node_id":"MDQ6VXNlcjE0NjkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/146917?v=4","gravatar_id":"","url":"https://api.github.com/users/vadz","html_url":"https://github.com/vadz","followers_url":"https://api.github.com/users/vadz/followers","following_url":"https://api.github.com/users/vadz/following{/other_user}","gists_url":"https://api.github.com/users/vadz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadz/subscriptions","organizations_url":"https://api.github.com/users/vadz/orgs","repos_url":"https://api.github.com/users/vadz/repos","events_url":"https://api.github.com/users/vadz/events{/privacy}","received_events_url":"https://api.github.com/users/vadz/received_events","type":"User","site_admin":false},"position":12,"line":83,"path":"src/osx/cocoa/settings.mm","commit_id":"71bb680a93a05947b6c82842fdcf5e79c842f944","created_at":"2018-10-30T20:58:18Z","updated_at":"2018-10-30T20:58:18Z","author_association":"CONTRIBUTOR","body":"This is not really a `wxBrush` neither as, if I understand correctly the previous discussions about it, its value can also change on its own if the system colours/theme change. So I think we really need some new class, `wxSystemPattern` or something like that, which could be converted to `wxColour` when possible (and this would also probably return a fixed value, which wouldn't change later, avoiding any surprises).\r\n\r\nThe question is, of course, about compatibility, but I think it could be made reasonably compatible if we provided implicit conversion from `wxColour` to this new class for the setters. Getters will need to change however, e.g. we'd need to have `GetBackgroundPattern()` instead of `GetBackgroundColour()`, but this seems better/unavoidable anyhow if there is no solid background colour to return in any case."}}
{"actor":{"display_login":"vadz"}}