{"action":"created","comment":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments/191908758","pull_request_review_id":124574867,"id":191908758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTkwODc1OA==","diff_hunk":"@@ -1009,13 +1032,29 @@ UsdMayaProxyShape::~UsdMayaProxyShape()\n MSelectionMask\n UsdMayaProxyShape::getShapeSelectionMask() const\n {\n-    if (_CanBeSoftSelected()) {\n-        // to support soft selection (mode=Object), we need to add kSelectMeshes\n-        // to our selection mask.\n-        MSelectionMask::SelectionType selType = MSelectionMask::kSelectMeshes;\n-        return MSelectionMask(selType);\n+    // The intent of this function is to control whether this object is\n+    // selectable at all in VP2\n+\n+    // However, due to a bug / quirk, it could be used to specifically control\n+    // whether the object was SOFT-selectable if you were using\n+    // MAYA_VP2_USE_VP1_SELECTON; in this mode, this setting is NOT querierd\n+    // when doing \"normal\" selection, but IS queried when doing soft\n+    // selection.\n+\n+    // Unfortunately, it is queried for both \"normal\" selection AND soft\n+    // selection if you are using \"true\" VP2 selection.  So in order to\n+    // control soft seleciton, in both modes, we keep track of whether","path":"third_party/maya/lib/usdMaya/proxyShape.cpp","position":57,"original_position":57,"commit_id":"a90c0a7a692384d9164bf7350997f4c6e4117a96","original_commit_id":"a90c0a7a692384d9164bf7350997f4c6e4117a96","user":{"login":"sunyab","id":11516093,"node_id":"MDQ6VXNlcjExNTE2MDkz","avatar_url":"https://avatars3.githubusercontent.com/u/11516093?v=4","gravatar_id":"","url":"https://api.github.com/users/sunyab","html_url":"https://github.com/sunyab","followers_url":"https://api.github.com/users/sunyab/followers","following_url":"https://api.github.com/users/sunyab/following{/other_user}","gists_url":"https://api.github.com/users/sunyab/gists{/gist_id}","starred_url":"https://api.github.com/users/sunyab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunyab/subscriptions","organizations_url":"https://api.github.com/users/sunyab/orgs","repos_url":"https://api.github.com/users/sunyab/repos","events_url":"https://api.github.com/users/sunyab/events{/privacy}","received_events_url":"https://api.github.com/users/sunyab/received_events","type":"User","site_admin":false},"body":"Small typo: \"seleciton\" instead of \"selection\"","created_at":"2018-05-30T20:18:19Z","updated_at":"2018-05-30T20:19:13Z","html_url":"https://github.com/PixarAnimationStudios/USD/pull/504#discussion_r191908758","pull_request_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments/191908758"},"html":{"href":"https://github.com/PixarAnimationStudios/USD/pull/504#discussion_r191908758"},"pull_request":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504","id":189818459,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5ODE4NDU5","html_url":"https://github.com/PixarAnimationStudios/USD/pull/504","diff_url":"https://github.com/PixarAnimationStudios/USD/pull/504.diff","patch_url":"https://github.com/PixarAnimationStudios/USD/pull/504.patch","issue_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/504","number":504,"state":"open","locked":false,"title":"[usdMaya] fix for VP2 selection when MAYA_VP2_USE_VP1_SELECTION is off","user":{"login":"elrond79","id":71800,"node_id":"MDQ6VXNlcjcxODAw","avatar_url":"https://avatars2.githubusercontent.com/u/71800?v=4","gravatar_id":"","url":"https://api.github.com/users/elrond79","html_url":"https://github.com/elrond79","followers_url":"https://api.github.com/users/elrond79/followers","following_url":"https://api.github.com/users/elrond79/following{/other_user}","gists_url":"https://api.github.com/users/elrond79/gists{/gist_id}","starred_url":"https://api.github.com/users/elrond79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elrond79/subscriptions","organizations_url":"https://api.github.com/users/elrond79/orgs","repos_url":"https://api.github.com/users/elrond79/repos","events_url":"https://api.github.com/users/elrond79/events{/privacy}","received_events_url":"https://api.github.com/users/elrond79/received_events","type":"User","site_admin":false},"body":"### Description of Change(s)\r\n\r\nCurrently, if using \"pure\" VP2 selection (ie, MAYA_VP2_USE_VP1_SELECTION is not\r\nset), then if the \"softSelectable\" attribute is off, the object cannot be\r\nselected by clicking on it in the viewport.\r\n\r\nThis is because proxyShape attempts to control soft-selection via\r\nMPxSurfaceShape::getShapeSelectionMask().  Unfortunately, the intent of this\r\nfunction is to control which selection filters the shape responds to, for any\r\nselection (ie, normal + soft selection), and it is only a quirk / bug of\r\nMAYA_VP2_USE_VP1_SELECTION mode that this setting is queried for soft selection,\r\nbut not normal selection.\r\n\r\nTo make the softSelectable attr work in both pure VP2 and\r\nMAYA_VP2_USE_VP1_SELECTION modes, we now check if object-mode soft-selection is\r\ncurrently on, and if the object is set to be not selectable; if so, we return\r\nan empty mask, disabling selection.\r\n\r\n### Fixes Issue(s)\r\n- Selection when using \"pure\" VP2 mode (no MAYA_VP2_USE_VP1_SELECTION), and softSelectable attribute is off\r\n\r\n","created_at":"2018-05-22T23:22:34Z","updated_at":"2018-05-30T20:19:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc0fd406dd0f78bb09c9f65c4532542eca9000e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":908662688,"node_id":"MDU6TGFiZWw5MDg2NjI2ODg=","url":"https://api.github.com/repos/PixarAnimationStudios/USD/labels/in%20review","name":"in review","color":"eadf7e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504/commits","review_comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504/comments","review_comment_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/504/comments","statuses_url":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/a90c0a7a692384d9164bf7350997f4c6e4117a96","head":{"label":"LumaPictures:pr/fix_selection_VP2","ref":"pr/fix_selection_VP2","sha":"a90c0a7a692384d9164bf7350997f4c6e4117a96","user":{"login":"LumaPictures","id":163925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzkyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/163925?v=4","gravatar_id":"","url":"https://api.github.com/users/LumaPictures","html_url":"https://github.com/LumaPictures","followers_url":"https://api.github.com/users/LumaPictures/followers","following_url":"https://api.github.com/users/LumaPictures/following{/other_user}","gists_url":"https://api.github.com/users/LumaPictures/gists{/gist_id}","starred_url":"https://api.github.com/users/LumaPictures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LumaPictures/subscriptions","organizations_url":"https://api.github.com/users/LumaPictures/orgs","repos_url":"https://api.github.com/users/LumaPictures/repos","events_url":"https://api.github.com/users/LumaPictures/events{/privacy}","received_events_url":"https://api.github.com/users/LumaPictures/received_events","type":"Organization","site_admin":false},"repo":{"id":69625004,"node_id":"MDEwOlJlcG9zaXRvcnk2OTYyNTAwNA==","name":"USD","full_name":"LumaPictures/USD","owner":{"login":"LumaPictures","id":163925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzkyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/163925?v=4","gravatar_id":"","url":"https://api.github.com/users/LumaPictures","html_url":"https://github.com/LumaPictures","followers_url":"https://api.github.com/users/LumaPictures/followers","following_url":"https://api.github.com/users/LumaPictures/following{/other_user}","gists_url":"https://api.github.com/users/LumaPictures/gists{/gist_id}","starred_url":"https://api.github.com/users/LumaPictures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LumaPictures/subscriptions","organizations_url":"https://api.github.com/users/LumaPictures/orgs","repos_url":"https://api.github.com/users/LumaPictures/repos","events_url":"https://api.github.com/users/LumaPictures/events{/privacy}","received_events_url":"https://api.github.com/users/LumaPictures/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LumaPictures/USD","description":"Universal Scene Description","fork":true,"url":"https://api.github.com/repos/LumaPictures/USD","forks_url":"https://api.github.com/repos/LumaPictures/USD/forks","keys_url":"https://api.github.com/repos/LumaPictures/USD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LumaPictures/USD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LumaPictures/USD/teams","hooks_url":"https://api.github.com/repos/LumaPictures/USD/hooks","issue_events_url":"https://api.github.com/repos/LumaPictures/USD/issues/events{/number}","events_url":"https://api.github.com/repos/LumaPictures/USD/events","assignees_url":"https://api.github.com/repos/LumaPictures/USD/assignees{/user}","branches_url":"https://api.github.com/repos/LumaPictures/USD/branches{/branch}","tags_url":"https://api.github.com/repos/LumaPictures/USD/tags","blobs_url":"https://api.github.com/repos/LumaPictures/USD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LumaPictures/USD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LumaPictures/USD/git/refs{/sha}","trees_url":"https://api.github.com/repos/LumaPictures/USD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LumaPictures/USD/statuses/{sha}","languages_url":"https://api.github.com/repos/LumaPictures/USD/languages","stargazers_url":"https://api.github.com/repos/LumaPictures/USD/stargazers","contributors_url":"https://api.github.com/repos/LumaPictures/USD/contributors","subscribers_url":"https://api.github.com/repos/LumaPictures/USD/subscribers","subscription_url":"https://api.github.com/repos/LumaPictures/USD/subscription","commits_url":"https://api.github.com/repos/LumaPictures/USD/commits{/sha}","git_commits_url":"https://api.github.com/repos/LumaPictures/USD/git/commits{/sha}","comments_url":"https://api.github.com/repos/LumaPictures/USD/comments{/number}","issue_comment_url":"https://api.github.com/repos/LumaPictures/USD/issues/comments{/number}","contents_url":"https://api.github.com/repos/LumaPictures/USD/contents/{+path}","compare_url":"https://api.github.com/repos/LumaPictures/USD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LumaPictures/USD/merges","archive_url":"https://api.github.com/repos/LumaPictures/USD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LumaPictures/USD/downloads","issues_url":"https://api.github.com/repos/LumaPictures/USD/issues{/number}","pulls_url":"https://api.github.com/repos/LumaPictures/USD/pulls{/number}","milestones_url":"https://api.github.com/repos/LumaPictures/USD/milestones{/number}","notifications_url":"https://api.github.com/repos/LumaPictures/USD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LumaPictures/USD/labels{/name}","releases_url":"https://api.github.com/repos/LumaPictures/USD/releases{/id}","deployments_url":"https://api.github.com/repos/LumaPictures/USD/deployments","created_at":"2016-09-30T02:09:21Z","updated_at":"2018-04-25T00:23:11Z","pushed_at":"2018-05-30T00:57:37Z","git_url":"git://github.com/LumaPictures/USD.git","ssh_url":"git@github.com:LumaPictures/USD.git","clone_url":"https://github.com/LumaPictures/USD.git","svn_url":"https://github.com/LumaPictures/USD","homepage":"http://www.openusd.org","size":51167,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":9,"default_branch":"dev"}},"base":{"label":"PixarAnimationStudios:dev","ref":"dev","sha":"65e77fcdf4f8a5f13d4eb1a065de33cd7bb67f4d","user":{"login":"PixarAnimationStudios","id":1672744,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzI3NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1672744?v=4","gravatar_id":"","url":"https://api.github.com/users/PixarAnimationStudios","html_url":"https://github.com/PixarAnimationStudios","followers_url":"https://api.github.com/users/PixarAnimationStudios/followers","following_url":"https://api.github.com/users/PixarAnimationStudios/following{/other_user}","gists_url":"https://api.github.com/users/PixarAnimationStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/PixarAnimationStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PixarAnimationStudios/subscriptions","organizations_url":"https://api.github.com/users/PixarAnimationStudios/orgs","repos_url":"https://api.github.com/users/PixarAnimationStudios/repos","events_url":"https://api.github.com/users/PixarAnimationStudios/events{/privacy}","received_events_url":"https://api.github.com/users/PixarAnimationStudios/received_events","type":"Organization","site_admin":false},"repo":{"id":58168143,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE2ODE0Mw==","name":"USD","full_name":"PixarAnimationStudios/USD","owner":{"login":"PixarAnimationStudios","id":1672744,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzI3NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1672744?v=4","gravatar_id":"","url":"https://api.github.com/users/PixarAnimationStudios","html_url":"https://github.com/PixarAnimationStudios","followers_url":"https://api.github.com/users/PixarAnimationStudios/followers","following_url":"https://api.github.com/users/PixarAnimationStudios/following{/other_user}","gists_url":"https://api.github.com/users/PixarAnimationStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/PixarAnimationStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PixarAnimationStudios/subscriptions","organizations_url":"https://api.github.com/users/PixarAnimationStudios/orgs","repos_url":"https://api.github.com/users/PixarAnimationStudios/repos","events_url":"https://api.github.com/users/PixarAnimationStudios/events{/privacy}","received_events_url":"https://api.github.com/users/PixarAnimationStudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PixarAnimationStudios/USD","description":"Universal Scene Description","fork":false,"url":"https://api.github.com/repos/PixarAnimationStudios/USD","forks_url":"https://api.github.com/repos/PixarAnimationStudios/USD/forks","keys_url":"https://api.github.com/repos/PixarAnimationStudios/USD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PixarAnimationStudios/USD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PixarAnimationStudios/USD/teams","hooks_url":"https://api.github.com/repos/PixarAnimationStudios/USD/hooks","issue_events_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/events{/number}","events_url":"https://api.github.com/repos/PixarAnimationStudios/USD/events","assignees_url":"https://api.github.com/repos/PixarAnimationStudios/USD/assignees{/user}","branches_url":"https://api.github.com/repos/PixarAnimationStudios/USD/branches{/branch}","tags_url":"https://api.github.com/repos/PixarAnimationStudios/USD/tags","blobs_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/refs{/sha}","trees_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/{sha}","languages_url":"https://api.github.com/repos/PixarAnimationStudios/USD/languages","stargazers_url":"https://api.github.com/repos/PixarAnimationStudios/USD/stargazers","contributors_url":"https://api.github.com/repos/PixarAnimationStudios/USD/contributors","subscribers_url":"https://api.github.com/repos/PixarAnimationStudios/USD/subscribers","subscription_url":"https://api.github.com/repos/PixarAnimationStudios/USD/subscription","commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/commits{/sha}","git_commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/commits{/sha}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/comments{/number}","issue_comment_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/comments{/number}","contents_url":"https://api.github.com/repos/PixarAnimationStudios/USD/contents/{+path}","compare_url":"https://api.github.com/repos/PixarAnimationStudios/USD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PixarAnimationStudios/USD/merges","archive_url":"https://api.github.com/repos/PixarAnimationStudios/USD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PixarAnimationStudios/USD/downloads","issues_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues{/number}","pulls_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls{/number}","milestones_url":"https://api.github.com/repos/PixarAnimationStudios/USD/milestones{/number}","notifications_url":"https://api.github.com/repos/PixarAnimationStudios/USD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PixarAnimationStudios/USD/labels{/name}","releases_url":"https://api.github.com/repos/PixarAnimationStudios/USD/releases{/id}","deployments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/deployments","created_at":"2016-05-06T00:02:56Z","updated_at":"2018-05-29T19:04:57Z","pushed_at":"2018-05-29T21:35:58Z","git_url":"git://github.com/PixarAnimationStudios/USD.git","ssh_url":"git@github.com:PixarAnimationStudios/USD.git","clone_url":"https://github.com/PixarAnimationStudios/USD.git","svn_url":"https://github.com/PixarAnimationStudios/USD","homepage":"http://www.openusd.org","size":34113,"stargazers_count":1337,"watchers_count":1337,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":232,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":232,"open_issues":171,"watchers":1337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504"},"html":{"href":"https://github.com/PixarAnimationStudios/USD/pull/504"},"issue":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/504"},"comments":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/a90c0a7a692384d9164bf7350997f4c6e4117a96"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sunyab"}}