{"action":"created","comment":{"url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments/208205098","pull_request_review_id":143963675,"id":208205098,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODIwNTA5OA==","diff_hunk":"@@ -157,6 +157,15 @@ def indexes(table_name) #:nodoc:\n           all_schema_indexes.select { |i| i.table == table_name }\n         end\n \n+        def columns(table_name)\n+          table_name = table_name.to_s\n+          if @columns_cache[table_name]\n+            @columns_cache[table_name]\n+          else\n+            @columns_cache[table_name] = super(table_name)\n+          end\n+          @columns_cache[table_name]","path":"lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb","position":11,"original_position":11,"commit_id":"d3a75c0c29f78c402a12f9ddce8ad71c4c09761f","original_commit_id":"d3a75c0c29f78c402a12f9ddce8ad71c4c09761f","user":{"login":"koic","id":13203,"node_id":"MDQ6VXNlcjEzMjAz","avatar_url":"https://avatars3.githubusercontent.com/u/13203?v=4","gravatar_id":"","url":"https://api.github.com/users/koic","html_url":"https://github.com/koic","followers_url":"https://api.github.com/users/koic/followers","following_url":"https://api.github.com/users/koic/following{/other_user}","gists_url":"https://api.github.com/users/koic/gists{/gist_id}","starred_url":"https://api.github.com/users/koic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koic/subscriptions","organizations_url":"https://api.github.com/users/koic/orgs","repos_url":"https://api.github.com/users/koic/repos","events_url":"https://api.github.com/users/koic/events{/privacy}","received_events_url":"https://api.github.com/users/koic/received_events","type":"User","site_admin":false},"body":"I think that this explicit return value line is unnecessary. The return value is determined by L163 or L165.","created_at":"2018-08-07T12:09:50Z","updated_at":"2018-08-07T12:09:50Z","html_url":"https://github.com/rsim/oracle-enhanced/pull/1744#discussion_r208205098","pull_request_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments/208205098"},"html":{"href":"https://github.com/rsim/oracle-enhanced/pull/1744#discussion_r208205098"},"pull_request":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744"}}},"pull_request":{"url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744","id":205397210,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mzk3MjEw","html_url":"https://github.com/rsim/oracle-enhanced/pull/1744","diff_url":"https://github.com/rsim/oracle-enhanced/pull/1744.diff","patch_url":"https://github.com/rsim/oracle-enhanced/pull/1744.patch","issue_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1744","number":1744,"state":"open","locked":false,"title":"Introduce column cache per connection","user":{"login":"yahonda","id":73684,"node_id":"MDQ6VXNlcjczNjg0","avatar_url":"https://avatars3.githubusercontent.com/u/73684?v=4","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"body":"rsim/oracle-enhanced#1490 removed Oracle enhanced adapter own column cache feature\r\nto use Rails `db:schema:cache:dump`.  However, it caused slower performance\r\nabout metadata search, such as column information.\r\n\r\nThis commit restores Oracle enhanced adapter own column cache feature.\r\nIt used to be class level caching, it is connection level caching now\r\nsince it is much easier and cleaner than class level ones.\r\n\r\nRelated to rsim/oracle-enhanced#1720","created_at":"2018-08-01T11:41:58Z","updated_at":"2018-08-07T12:09:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f98266e53f009a15711ff98b650d14565378e92f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744/commits","review_comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744/comments","review_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1744/comments","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/d3a75c0c29f78c402a12f9ddce8ad71c4c09761f","head":{"label":"yahonda:restore_column_cache","ref":"restore_column_cache","sha":"d3a75c0c29f78c402a12f9ddce8ad71c4c09761f","user":{"login":"yahonda","id":73684,"node_id":"MDQ6VXNlcjczNjg0","avatar_url":"https://avatars3.githubusercontent.com/u/73684?v=4","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"repo":{"id":1907066,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA3MDY2","name":"oracle-enhanced","full_name":"yahonda/oracle-enhanced","owner":{"login":"yahonda","id":73684,"node_id":"MDQ6VXNlcjczNjg0","avatar_url":"https://avatars3.githubusercontent.com/u/73684?v=4","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yahonda/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":true,"url":"https://api.github.com/repos/yahonda/oracle-enhanced","forks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/yahonda/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahonda/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahonda/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/yahonda/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahonda/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/yahonda/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/yahonda/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahonda/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/yahonda/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahonda/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/yahonda/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/yahonda/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/yahonda/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahonda/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/yahonda/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/deployments","created_at":"2011-06-16T18:02:51Z","updated_at":"2018-08-07T10:31:23Z","pushed_at":"2018-08-07T12:04:39Z","git_url":"git://github.com/yahonda/oracle-enhanced.git","ssh_url":"git@github.com:yahonda/oracle-enhanced.git","clone_url":"https://github.com/yahonda/oracle-enhanced.git","svn_url":"https://github.com/yahonda/oracle-enhanced","homepage":"","size":5971,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rsim:master","ref":"master","sha":"bd36fc9c8e37688ec76bc0f3a5eef8464a21a035","user":{"login":"rsim","id":4736,"node_id":"MDQ6VXNlcjQ3MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4736?v=4","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"repo":{"id":14507,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwNw==","name":"oracle-enhanced","full_name":"rsim/oracle-enhanced","owner":{"login":"rsim","id":4736,"node_id":"MDQ6VXNlcjQ3MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4736?v=4","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsim/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":false,"url":"https://api.github.com/repos/rsim/oracle-enhanced","forks_url":"https://api.github.com/repos/rsim/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/rsim/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsim/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsim/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/rsim/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/rsim/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/rsim/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/rsim/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/rsim/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/rsim/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/rsim/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsim/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/rsim/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsim/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/rsim/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsim/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/rsim/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/rsim/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsim/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/rsim/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/rsim/oracle-enhanced/deployments","created_at":"2008-05-04T22:02:14Z","updated_at":"2018-08-06T14:33:43Z","pushed_at":"2018-08-07T12:04:35Z","git_url":"git://github.com/rsim/oracle-enhanced.git","ssh_url":"git@github.com:rsim/oracle-enhanced.git","clone_url":"https://github.com/rsim/oracle-enhanced.git","svn_url":"https://github.com/rsim/oracle-enhanced","homepage":"","size":5966,"stargazers_count":485,"watchers_count":485,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":250,"open_issues":14,"watchers":485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744"},"html":{"href":"https://github.com/rsim/oracle-enhanced/pull/1744"},"issue":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1744"},"comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1744/comments"},"review_comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744/comments"},"review_comment":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1744/commits"},"statuses":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/d3a75c0c29f78c402a12f9ddce8ad71c4c09761f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"koic"}}