{"action":"created","issue":{"url":"https://api.github.com/repos/jpos/jPOS/issues/181","repository_url":"https://api.github.com/repos/jpos/jPOS","labels_url":"https://api.github.com/repos/jpos/jPOS/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/jpos/jPOS/issues/181/comments","events_url":"https://api.github.com/repos/jpos/jPOS/issues/181/events","html_url":"https://github.com/jpos/jPOS/pull/181","id":346429343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mjk1MzI1","number":181,"title":"Changes for support maxage property were added","user":{"login":"gregorioosorio","id":2178971,"node_id":"MDQ6VXNlcjIxNzg5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2178971?v=4","gravatar_id":"","url":"https://api.github.com/users/gregorioosorio","html_url":"https://github.com/gregorioosorio","followers_url":"https://api.github.com/users/gregorioosorio/followers","following_url":"https://api.github.com/users/gregorioosorio/following{/other_user}","gists_url":"https://api.github.com/users/gregorioosorio/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorioosorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorioosorio/subscriptions","organizations_url":"https://api.github.com/users/gregorioosorio/orgs","repos_url":"https://api.github.com/users/gregorioosorio/repos","events_url":"https://api.github.com/users/gregorioosorio/events{/privacy}","received_events_url":"https://api.github.com/users/gregorioosorio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-01T02:55:46Z","updated_at":"2018-08-01T21:03:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jpos/jPOS/pulls/181","html_url":"https://github.com/jpos/jPOS/pull/181","diff_url":"https://github.com/jpos/jPOS/pull/181.diff","patch_url":"https://github.com/jpos/jPOS/pull/181.patch"},"body":"Please, check if the changes accomplish with the new feature.\r\n\r\nAs you can see, I proposed the new property: _**maxage**_ instead of **_maxdays_** because is more flexible because this new property is set to seconds.\r\nFor example, if you want to set the max age to one week you should set this value:\r\n- maxage = 7*24*3600 = 604800\r\n\r\nAlso, if you want to disable this new feature just set to zero or a negative number."},"comment":{"url":"https://api.github.com/repos/jpos/jPOS/issues/comments/409722301","html_url":"https://github.com/jpos/jPOS/pull/181#issuecomment-409722301","issue_url":"https://api.github.com/repos/jpos/jPOS/issues/181","id":409722301,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTcyMjMwMQ==","user":{"login":"alcarraz","id":3778747,"node_id":"MDQ6VXNlcjM3Nzg3NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3778747?v=4","gravatar_id":"","url":"https://api.github.com/users/alcarraz","html_url":"https://github.com/alcarraz","followers_url":"https://api.github.com/users/alcarraz/followers","following_url":"https://api.github.com/users/alcarraz/following{/other_user}","gists_url":"https://api.github.com/users/alcarraz/gists{/gist_id}","starred_url":"https://api.github.com/users/alcarraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcarraz/subscriptions","organizations_url":"https://api.github.com/users/alcarraz/orgs","repos_url":"https://api.github.com/users/alcarraz/repos","events_url":"https://api.github.com/users/alcarraz/events{/privacy}","received_events_url":"https://api.github.com/users/alcarraz/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T21:03:40Z","updated_at":"2018-08-01T21:03:40Z","author_association":"CONTRIBUTOR","body":"@apr I totally agree, but I would implement that as a default regular expression for matching the prefix and suffix , and that can be overwritten by config.\r\n\r\nLet's say delete-regex, that way the implementation is pretty much the same but gives more flexibility to the user.\r\n\r\nThat said I think prefix + suffix is enough and the other can be addressed later if necessary. The DailyLogListener code is too much cumbersome as it is (totally my younger self fault :) ).  \r\n\r\nDo you agree @gregorioosorio ?"}}
{"actor":{"display_login":"alcarraz"}}