{"action":"created","issue":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1773","repository_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework","labels_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1773/labels{/name}","comments_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1773/comments","events_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1773/events","html_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1773","id":317540837,"number":1773,"title":"Remove negative margin from consecutive .p-matrix__desc","user":{"login":"Caleb-Ellis","id":25733845,"avatar_url":"https://avatars3.githubusercontent.com/u/25733845?v=4","gravatar_id":"","url":"https://api.github.com/users/Caleb-Ellis","html_url":"https://github.com/Caleb-Ellis","followers_url":"https://api.github.com/users/Caleb-Ellis/followers","following_url":"https://api.github.com/users/Caleb-Ellis/following{/other_user}","gists_url":"https://api.github.com/users/Caleb-Ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/Caleb-Ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caleb-Ellis/subscriptions","organizations_url":"https://api.github.com/users/Caleb-Ellis/orgs","repos_url":"https://api.github.com/users/Caleb-Ellis/repos","events_url":"https://api.github.com/users/Caleb-Ellis/events{/privacy}","received_events_url":"https://api.github.com/users/Caleb-Ellis/received_events","type":"User","site_admin":false},"labels":[{"id":385881405,"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/labels/Review:%20Code%20+1","name":"Review: Code +1","color":"0e8420","default":false},{"id":385881392,"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/labels/Review:%20Design%20+1","name":"Review: Design +1","color":"0e8420","default":false},{"id":385881390,"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/labels/Review:%20QA%20needed","name":"Review: QA needed","color":"cdcdcd","default":false}],"state":"open","locked":false,"assignee":{"login":"WillMoggridge","id":322693,"avatar_url":"https://avatars1.githubusercontent.com/u/322693?v=4","gravatar_id":"","url":"https://api.github.com/users/WillMoggridge","html_url":"https://github.com/WillMoggridge","followers_url":"https://api.github.com/users/WillMoggridge/followers","following_url":"https://api.github.com/users/WillMoggridge/following{/other_user}","gists_url":"https://api.github.com/users/WillMoggridge/gists{/gist_id}","starred_url":"https://api.github.com/users/WillMoggridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillMoggridge/subscriptions","organizations_url":"https://api.github.com/users/WillMoggridge/orgs","repos_url":"https://api.github.com/users/WillMoggridge/repos","events_url":"https://api.github.com/users/WillMoggridge/events{/privacy}","received_events_url":"https://api.github.com/users/WillMoggridge/received_events","type":"User","site_admin":false},"assignees":[{"login":"WillMoggridge","id":322693,"avatar_url":"https://avatars1.githubusercontent.com/u/322693?v=4","gravatar_id":"","url":"https://api.github.com/users/WillMoggridge","html_url":"https://github.com/WillMoggridge","followers_url":"https://api.github.com/users/WillMoggridge/followers","following_url":"https://api.github.com/users/WillMoggridge/following{/other_user}","gists_url":"https://api.github.com/users/WillMoggridge/gists{/gist_id}","starred_url":"https://api.github.com/users/WillMoggridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillMoggridge/subscriptions","organizations_url":"https://api.github.com/users/WillMoggridge/orgs","repos_url":"https://api.github.com/users/WillMoggridge/repos","events_url":"https://api.github.com/users/WillMoggridge/events{/privacy}","received_events_url":"https://api.github.com/users/WillMoggridge/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-04-25T09:08:49Z","updated_at":"2018-04-30T13:49:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/pulls/1773","html_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1773","diff_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1773.diff","patch_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1773.patch"},"body":"## Done\r\n\r\n- Removed negative margin on consecutive `.p-matrix__desc` so vertical spacing is like two normal paragraphs\r\n\r\n## QA\r\n\r\n- Pull code\r\n- Run `./run serve --watch`\r\n- Open http://0.0.0.0:8101/vanilla-framework/examples/patterns/matrix/\r\n- Add a second `<p class=\"p-matrix__desc\">Short description</p>` to any of the matrix cells\r\n- Check that the space between the two paragraphs is the same as any two consecutive `<p>`\r\n\r\n## Details\r\n\r\nFixes #1772 \r\n\r\n## Screenshots\r\n\r\n### Before\r\n\r\n![screenshot_3](https://user-images.githubusercontent.com/25733845/39236354-8f14b6e4-4870-11e8-9e6e-c2f2de8b63d3.png)\r\n\r\n### After\r\n\r\n![screenshot_2](https://user-images.githubusercontent.com/25733845/39236323-7231bcde-4870-11e8-8900-137d2f8c8a53.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/comments/385403463","html_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1773#issuecomment-385403463","issue_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1773","id":385403463,"user":{"login":"WillMoggridge","id":322693,"avatar_url":"https://avatars1.githubusercontent.com/u/322693?v=4","gravatar_id":"","url":"https://api.github.com/users/WillMoggridge","html_url":"https://github.com/WillMoggridge","followers_url":"https://api.github.com/users/WillMoggridge/followers","following_url":"https://api.github.com/users/WillMoggridge/following{/other_user}","gists_url":"https://api.github.com/users/WillMoggridge/gists{/gist_id}","starred_url":"https://api.github.com/users/WillMoggridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillMoggridge/subscriptions","organizations_url":"https://api.github.com/users/WillMoggridge/orgs","repos_url":"https://api.github.com/users/WillMoggridge/repos","events_url":"https://api.github.com/users/WillMoggridge/events{/privacy}","received_events_url":"https://api.github.com/users/WillMoggridge/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T13:49:50Z","updated_at":"2018-04-30T13:49:50Z","author_association":"CONTRIBUTOR","body":"Should the previous format still work?\r\nWould it be better to have the examples have mix used of the existing HTML structure and some using the new one? Maybe including:\r\n- Items with just `p`\r\n- Items with the `div` and one child `p`\r\n- Items with the `div` and a few children `p`"}}
{"actor":{"display_login":"WillMoggridge"}}