{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/47780","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/47780/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47780/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/47780/events","html_url":"https://github.com/saltstack/salt/pull/47780","id":325435863,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NzcwOTQ2","number":47780,"title":"External WAL directory and datapage checksums for PostgreSQL","user":{"login":"moench-tegeder","id":7943408,"node_id":"MDQ6VXNlcjc5NDM0MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7943408?v=4","gravatar_id":"","url":"https://api.github.com/users/moench-tegeder","html_url":"https://github.com/moench-tegeder","followers_url":"https://api.github.com/users/moench-tegeder/followers","following_url":"https://api.github.com/users/moench-tegeder/following{/other_user}","gists_url":"https://api.github.com/users/moench-tegeder/gists{/gist_id}","starred_url":"https://api.github.com/users/moench-tegeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moench-tegeder/subscriptions","organizations_url":"https://api.github.com/users/moench-tegeder/orgs","repos_url":"https://api.github.com/users/moench-tegeder/repos","events_url":"https://api.github.com/users/moench-tegeder/events{/privacy}","received_events_url":"https://api.github.com/users/moench-tegeder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-22T19:42:13Z","updated_at":"2018-06-29T19:28:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47780","html_url":"https://github.com/saltstack/salt/pull/47780","diff_url":"https://github.com/saltstack/salt/pull/47780.diff","patch_url":"https://github.com/saltstack/salt/pull/47780.patch"},"body":"Since almost forever, PostgreSQL allows storing it's transaction log\r\n(WAL, write ahead log) outside of the data directory (this improves\r\nperformance on certain setups, or may just be required by local\r\npolicy. The newly added \"waldir\" option on states.postgres_initdb.present()\r\nand modules.postgresql.initdb() is passed to initdb (the default is\r\nstill to keep the transaction log inside the data directory).\r\nAs part of the big renaming in PostgreSQL 10 the old \"xlog directory\"\r\nhas been renamed to \"wal directory\", this patch uses the new name only.\r\n\r\nSind PostgreSQL 9.3 (which is the oldest supported release as of\r\ntime of writing), there is support for checksumming the database\r\non the block level. This can only be enabled when creating the\r\ncluster (this is, at initdb time), so it should be available in\r\nmodules and states. This patch adds it in both places.\r\n\r\nDocumentation for both mini-features has been added to the doc strings.\r\n\r\n### What does this PR do?\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Previous Behavior\r\nRemove this section if not relevant\r\n\r\n### New Behavior\r\nRemove this section if not relevant\r\n\r\n### Tests written?\r\n\r\nYes/No\r\n\r\n### Commits signed with GPG?\r\n\r\nYes/No\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/401451696","html_url":"https://github.com/saltstack/salt/pull/47780#issuecomment-401451696","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47780","id":401451696,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQ1MTY5Ng==","user":{"login":"moench-tegeder","id":7943408,"node_id":"MDQ6VXNlcjc5NDM0MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7943408?v=4","gravatar_id":"","url":"https://api.github.com/users/moench-tegeder","html_url":"https://github.com/moench-tegeder","followers_url":"https://api.github.com/users/moench-tegeder/followers","following_url":"https://api.github.com/users/moench-tegeder/following{/other_user}","gists_url":"https://api.github.com/users/moench-tegeder/gists{/gist_id}","starred_url":"https://api.github.com/users/moench-tegeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moench-tegeder/subscriptions","organizations_url":"https://api.github.com/users/moench-tegeder/orgs","repos_url":"https://api.github.com/users/moench-tegeder/repos","events_url":"https://api.github.com/users/moench-tegeder/events{/privacy}","received_events_url":"https://api.github.com/users/moench-tegeder/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T19:28:47Z","updated_at":"2018-06-29T19:28:47Z","author_association":"CONTRIBUTOR","body":"Hi again,\r\nis there anything I can do here? Unless I'm missing something, thw kwargs are now in order?"}}
{"actor":{"display_login":"moench-tegeder"}}