{"action":"created","issue":{"url":"https://api.github.com/repos/UPC/ravada/issues/912","repository_url":"https://api.github.com/repos/UPC/ravada","labels_url":"https://api.github.com/repos/UPC/ravada/issues/912/labels{/name}","comments_url":"https://api.github.com/repos/UPC/ravada/issues/912/comments","events_url":"https://api.github.com/repos/UPC/ravada/issues/912/events","html_url":"https://github.com/UPC/ravada/pull/912","id":374808546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDAzODI5","number":912,"title":"feature: new button remove node","user":{"login":"cjuan","id":147216,"node_id":"MDQ6VXNlcjE0NzIxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/147216?v=4","gravatar_id":"","url":"https://api.github.com/users/cjuan","html_url":"https://github.com/cjuan","followers_url":"https://api.github.com/users/cjuan/followers","following_url":"https://api.github.com/users/cjuan/following{/other_user}","gists_url":"https://api.github.com/users/cjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/cjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjuan/subscriptions","organizations_url":"https://api.github.com/users/cjuan/orgs","repos_url":"https://api.github.com/users/cjuan/repos","events_url":"https://api.github.com/users/cjuan/events{/privacy}","received_events_url":"https://api.github.com/users/cjuan/received_events","type":"User","site_admin":false},"labels":[{"id":464511040,"node_id":"MDU6TGFiZWw0NjQ1MTEwNDA=","url":"https://api.github.com/repos/UPC/ravada/labels/frontEnd","name":"frontEnd","color":"fbca04","default":false},{"id":705411289,"node_id":"MDU6TGFiZWw3MDU0MTEyODk=","url":"https://api.github.com/repos/UPC/ravada/labels/hacktoberfest","name":"hacktoberfest","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"frankiejol","id":136835,"node_id":"MDQ6VXNlcjEzNjgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/136835?v=4","gravatar_id":"","url":"https://api.github.com/users/frankiejol","html_url":"https://github.com/frankiejol","followers_url":"https://api.github.com/users/frankiejol/followers","following_url":"https://api.github.com/users/frankiejol/following{/other_user}","gists_url":"https://api.github.com/users/frankiejol/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiejol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiejol/subscriptions","organizations_url":"https://api.github.com/users/frankiejol/orgs","repos_url":"https://api.github.com/users/frankiejol/repos","events_url":"https://api.github.com/users/frankiejol/events{/privacy}","received_events_url":"https://api.github.com/users/frankiejol/received_events","type":"User","site_admin":false},"assignees":[{"login":"frankiejol","id":136835,"node_id":"MDQ6VXNlcjEzNjgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/136835?v=4","gravatar_id":"","url":"https://api.github.com/users/frankiejol","html_url":"https://github.com/frankiejol","followers_url":"https://api.github.com/users/frankiejol/followers","following_url":"https://api.github.com/users/frankiejol/following{/other_user}","gists_url":"https://api.github.com/users/frankiejol/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiejol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiejol/subscriptions","organizations_url":"https://api.github.com/users/frankiejol/orgs","repos_url":"https://api.github.com/users/frankiejol/repos","events_url":"https://api.github.com/users/frankiejol/events{/privacy}","received_events_url":"https://api.github.com/users/frankiejol/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/UPC/ravada/milestones/13","html_url":"https://github.com/UPC/ravada/milestone/13","labels_url":"https://api.github.com/repos/UPC/ravada/milestones/13/labels","id":2548109,"node_id":"MDk6TWlsZXN0b25lMjU0ODEwOQ==","number":13,"title":"0.4","description":"Support for KVM clustering","creator":{"login":"frankiejol","id":136835,"node_id":"MDQ6VXNlcjEzNjgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/136835?v=4","gravatar_id":"","url":"https://api.github.com/users/frankiejol","html_url":"https://github.com/frankiejol","followers_url":"https://api.github.com/users/frankiejol/followers","following_url":"https://api.github.com/users/frankiejol/following{/other_user}","gists_url":"https://api.github.com/users/frankiejol/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiejol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiejol/subscriptions","organizations_url":"https://api.github.com/users/frankiejol/orgs","repos_url":"https://api.github.com/users/frankiejol/repos","events_url":"https://api.github.com/users/frankiejol/events{/privacy}","received_events_url":"https://api.github.com/users/frankiejol/received_events","type":"User","site_admin":false},"open_issues":60,"closed_issues":22,"state":"open","created_at":"2017-05-29T10:07:25Z","updated_at":"2018-10-29T07:44:55Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-10-28T22:51:07Z","updated_at":"2018-10-29T16:45:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/UPC/ravada/pulls/912","html_url":"https://github.com/UPC/ravada/pull/912","diff_url":"https://github.com/UPC/ravada/pull/912.diff","patch_url":"https://github.com/UPC/ravada/pull/912.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nNew variable in the template scope for disable (or not) the remove node button\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\ncheck if the node have active machines, is localhost or have bases\r\nif true, add a var to the list\r\nthe value of this var is shown in the template to disabled the button\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nThe directive ng-disable does not work correctly in that context.\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nhttps://github.com/UPC/ravada/issues/870\r\n\r\ncloses #870"},"comment":{"url":"https://api.github.com/repos/UPC/ravada/issues/comments/433985689","html_url":"https://github.com/UPC/ravada/pull/912#issuecomment-433985689","issue_url":"https://api.github.com/repos/UPC/ravada/issues/912","id":433985689,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzk4NTY4OQ==","user":{"login":"frankiejol","id":136835,"node_id":"MDQ6VXNlcjEzNjgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/136835?v=4","gravatar_id":"","url":"https://api.github.com/users/frankiejol","html_url":"https://github.com/frankiejol","followers_url":"https://api.github.com/users/frankiejol/followers","following_url":"https://api.github.com/users/frankiejol/following{/other_user}","gists_url":"https://api.github.com/users/frankiejol/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiejol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiejol/subscriptions","organizations_url":"https://api.github.com/users/frankiejol/orgs","repos_url":"https://api.github.com/users/frankiejol/repos","events_url":"https://api.github.com/users/frankiejol/events{/privacy}","received_events_url":"https://api.github.com/users/frankiejol/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T16:45:24Z","updated_at":"2018-10-29T16:45:24Z","author_association":"MEMBER","body":"@cjuan congrats it works, only if you could fix this warning message that pops up when the nodes are empty:\r\n```\r\nUse of uninitialized value in numeric gt (>) at lib/Ravada/Front.pm line 472.\r\nUse of uninitialized value in numeric gt (>) at lib/Ravada/Front.pm line 474.\r\n```\r\nAlso I noticed our original code had a bug, we weren't checking the bases on nodes right. you could add this line around 490. This only is triggered if a base is created in remote and then removed.\r\n```\r\n         .\" WHERE d.is_base=1\"\r\n         .\"  AND d.id = bv.id_domain \"\r\n         .\"  AND bv.id_vm=?\"\r\n +        .\"  AND bv.enabled=1\"\r\n```"}}
{"actor":{"display_login":"frankiejol"}}