{"action":"opened","number":23397,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/23397","id":212348659,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzQ4NjU5","html_url":"https://github.com/mantidproject/mantid/pull/23397","diff_url":"https://github.com/mantidproject/mantid/pull/23397.diff","patch_url":"https://github.com/mantidproject/mantid/pull/23397.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/23397","number":23397,"state":"open","locked":false,"title":"Get selected spectrum number not combobox index","user":{"login":"robertapplin","id":40830825,"node_id":"MDQ6VXNlcjQwODMwODI1","avatar_url":"https://avatars2.githubusercontent.com/u/40830825?v=4","gravatar_id":"","url":"https://api.github.com/users/robertapplin","html_url":"https://github.com/robertapplin","followers_url":"https://api.github.com/users/robertapplin/followers","following_url":"https://api.github.com/users/robertapplin/following{/other_user}","gists_url":"https://api.github.com/users/robertapplin/gists{/gist_id}","starred_url":"https://api.github.com/users/robertapplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertapplin/subscriptions","organizations_url":"https://api.github.com/users/robertapplin/orgs","repos_url":"https://api.github.com/users/robertapplin/repos","events_url":"https://api.github.com/users/robertapplin/events{/privacy}","received_events_url":"https://api.github.com/users/robertapplin/received_events","type":"User","site_admin":false},"body":"**Description of work.**\r\nThis PR fixes an issue where the parameter values are not updated for a selected spectrum when you use the  `Fit String` option in ConvFit.\r\nThe problem was that the selected spectrum number was wrong and so an update of the parameter values did not occur. Instead of retrieving the selected spectrum number, the currently selected Combobox index was returned instead.\r\n\r\n**To test:**\r\n- Go to Interfaces > Indirect > Data Analysis\r\n- Go to the Conv Fit tab\r\n- Load the reduced and resolution files below\r\n- Set `Fit spectra` to String 3\r\n- Set `Fit type` to Two Lorentzian's\r\n- Set `Max iterations` to 100\r\n- Expand the function f0-Lorentzian - note the parameters\r\n- Click `Run`\r\n- Check the parameters of f0-Lorentzian are updated\r\n\r\n- `Run` the fit for other `Fit spectra` Strings, and change between each fitted spectra to ensure that the parameter values are updating\r\n\r\n**Test Files**\r\n[irs26173_graphite002_res.zip](https://github.com/mantidproject/mantid/files/2339793/irs26173_graphite002_res.zip)\r\n[irs26176_graphite002_red.zip](https://github.com/mantidproject/mantid/files/2339794/irs26176_graphite002_red.zip)\r\n\r\nFixes ##23225\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://developer.mantidproject.org/IndividualTicketTesting/)):\r\n\r\n##### Code Review #####\r\n\r\n- Is the code of an acceptable quality?\r\n- Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)?\r\n- Are the unit tests small and test the class in isolation?\r\n- If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- Do changes function as described? Add comments below that describe the tests performed?\r\n- Do the changes handle unexpected situations, e.g. bad input?\r\n- Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2018-08-31T11:01:59Z","updated_at":"2018-08-31T11:01:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"robertapplin","id":40830825,"node_id":"MDQ6VXNlcjQwODMwODI1","avatar_url":"https://avatars2.githubusercontent.com/u/40830825?v=4","gravatar_id":"","url":"https://api.github.com/users/robertapplin","html_url":"https://github.com/robertapplin","followers_url":"https://api.github.com/users/robertapplin/followers","following_url":"https://api.github.com/users/robertapplin/following{/other_user}","gists_url":"https://api.github.com/users/robertapplin/gists{/gist_id}","starred_url":"https://api.github.com/users/robertapplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertapplin/subscriptions","organizations_url":"https://api.github.com/users/robertapplin/orgs","repos_url":"https://api.github.com/users/robertapplin/repos","events_url":"https://api.github.com/users/robertapplin/events{/privacy}","received_events_url":"https://api.github.com/users/robertapplin/received_events","type":"User","site_admin":false},"assignees":[{"login":"robertapplin","id":40830825,"node_id":"MDQ6VXNlcjQwODMwODI1","avatar_url":"https://avatars2.githubusercontent.com/u/40830825?v=4","gravatar_id":"","url":"https://api.github.com/users/robertapplin","html_url":"https://github.com/robertapplin","followers_url":"https://api.github.com/users/robertapplin/followers","following_url":"https://api.github.com/users/robertapplin/following{/other_user}","gists_url":"https://api.github.com/users/robertapplin/gists{/gist_id}","starred_url":"https://api.github.com/users/robertapplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertapplin/subscriptions","organizations_url":"https://api.github.com/users/robertapplin/orgs","repos_url":"https://api.github.com/users/robertapplin/repos","events_url":"https://api.github.com/users/robertapplin/events{/privacy}","received_events_url":"https://api.github.com/users/robertapplin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":172781547,"node_id":"MDU6TGFiZWwxNzI3ODE1NDc=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Indirect%20Inelastic","name":"Component: Indirect Inelastic","color":"009800","default":false},{"id":35408850,"node_id":"MDU6TGFiZWwzNTQwODg1MA==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21","default":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/68","html_url":"https://github.com/mantidproject/mantid/milestone/68","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/68/labels","id":3113735,"node_id":"MDk6TWlsZXN0b25lMzExMzczNQ==","number":68,"title":"Release 3.14 (4.0?)","description":"Code freeze: 23rd Nov\r\nBeta test: 27th Nov - 11th Dec","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":276,"closed_issues":223,"state":"open","created_at":"2018-02-13T15:42:17Z","updated_at":"2018-08-31T11:01:59Z","due_on":"2018-12-17T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23397/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23397/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/23397/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/559875dce0d9aada4d95bc574116928c90346637","head":{"label":"mantidproject:23225_ConvFitParametersNotUpdating","ref":"23225_ConvFitParametersNotUpdating","sha":"559875dce0d9aada4d95bc574116928c90346637","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-08-31T09:23:22Z","pushed_at":"2018-08-31T10:48:56Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":506242,"stargazers_count":76,"watchers_count":76,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":1855,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":57,"open_issues":1855,"watchers":76,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"7035a95a87bf041f1ba55f85cafbd7befa181497","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-08-31T09:23:22Z","pushed_at":"2018-08-31T10:48:56Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":506242,"stargazers_count":76,"watchers_count":76,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":1855,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":57,"open_issues":1855,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23397"},"html":{"href":"https://github.com/mantidproject/mantid/pull/23397"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/23397"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/23397/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23397/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23397/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/559875dce0d9aada4d95bc574116928c90346637"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"robertapplin"}}