{"action":"closed","number":728,"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/728","id":191006222,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMDA2MjIy","html_url":"https://github.com/sxs-collaboration/spectre/pull/728","diff_url":"https://github.com/sxs-collaboration/spectre/pull/728.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/728.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/728","number":728,"state":"closed","locked":false,"title":"Conservative actions","user":{"login":"wthrowe","id":867117,"node_id":"MDQ6VXNlcjg2NzExNw==","avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"body":"A particular thing to consider here is the handling of source terms.  I currently have the system specifying which variables have sources and then only passing those to the source calculation functions (and in a later PR to the RHS).\r\n\r\n## Proposed changes\r\n\r\n<!--\r\nAt a high level, describe what this PR does.\r\n-->\r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- Follows [code review guidelines](https://sxs-collaboration.github.io/spectre/code_review_guide.html)\r\n- Code has documentation and unit tests\r\n- Private member variables have a trailing underscore\r\n- Do not use [Hungarian notation](https://en.wikipedia.org/wiki/Hungarian_notation), e.g. `double* pd_blah` is bad\r\n- Header order:\r\n  1. hpp corresponding to cpp (only in cpp files) or `tests/Unit/TestingFramework.hpp` (only in tests)\r\n  2. Blank line (only in cpp files and tests)\r\n  3. STL and externals (in alphabetical order)\r\n  4. Blank line\r\n  5. SpECTRE includes (in alphabetical order)\r\n- File lists in CMake are alphabetical\r\n- Correct `noexcept` specification for functions (if unsure, mark `noexcept`)\r\n- Mark objects `const` whenever possible\r\n- Almost always `auto`, except with expression templates, i.e. `DataVector`\r\n- All commits for performance changes provide quantitative evidence and the tests used to obtain said evidence.\r\n- Make sure error messages are helpful, e.g. \"The number of grid points in the matrix 'F' is not the same as the number of grid points in the determinant.\"\r\n- Prefix commits addressing PR requests with `fixup`. These commits are flagged\r\n  by Travis so we do not accidentally merge them.\r\n- Include what you use, prefer forward declarations in hpp files.\r\n- Explicitly make numbers floating point, e.g. `2.` or `2.0` over `2`\r\n- Use `Tensor`'s non-member get if the indices are constant expressions, e.g.\r\n  `get<1>(tensor)`\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n","created_at":"2018-05-28T23:12:21Z","updated_at":"2018-06-08T17:09:03Z","closed_at":"2018-06-08T17:09:03Z","merged_at":"2018-06-08T17:09:03Z","merge_commit_sha":"ec2fb9e4a3fc26670b40413178ea9dc9f8bd9583","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/728/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/728/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/728/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a0268af8214c0d1c8104159df9361749792292f7","head":{"label":"wthrowe:conservative_actions","ref":"conservative_actions","sha":"a0268af8214c0d1c8104159df9361749792292f7","user":{"login":"wthrowe","id":867117,"node_id":"MDQ6VXNlcjg2NzExNw==","avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"repo":{"id":96371688,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM3MTY4OA==","name":"spectre","full_name":"wthrowe/spectre","owner":{"login":"wthrowe","id":867117,"node_id":"MDQ6VXNlcjg2NzExNw==","avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wthrowe/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/wthrowe/spectre","forks_url":"https://api.github.com/repos/wthrowe/spectre/forks","keys_url":"https://api.github.com/repos/wthrowe/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wthrowe/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wthrowe/spectre/teams","hooks_url":"https://api.github.com/repos/wthrowe/spectre/hooks","issue_events_url":"https://api.github.com/repos/wthrowe/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/wthrowe/spectre/events","assignees_url":"https://api.github.com/repos/wthrowe/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/wthrowe/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/wthrowe/spectre/tags","blobs_url":"https://api.github.com/repos/wthrowe/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wthrowe/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wthrowe/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/wthrowe/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wthrowe/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/wthrowe/spectre/languages","stargazers_url":"https://api.github.com/repos/wthrowe/spectre/stargazers","contributors_url":"https://api.github.com/repos/wthrowe/spectre/contributors","subscribers_url":"https://api.github.com/repos/wthrowe/spectre/subscribers","subscription_url":"https://api.github.com/repos/wthrowe/spectre/subscription","commits_url":"https://api.github.com/repos/wthrowe/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/wthrowe/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/wthrowe/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/wthrowe/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/wthrowe/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/wthrowe/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wthrowe/spectre/merges","archive_url":"https://api.github.com/repos/wthrowe/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wthrowe/spectre/downloads","issues_url":"https://api.github.com/repos/wthrowe/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/wthrowe/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/wthrowe/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/wthrowe/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wthrowe/spectre/labels{/name}","releases_url":"https://api.github.com/repos/wthrowe/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/wthrowe/spectre/deployments","created_at":"2017-07-06T00:23:14Z","updated_at":"2017-07-06T00:23:15Z","pushed_at":"2018-06-07T15:57:28Z","git_url":"git://github.com/wthrowe/spectre.git","ssh_url":"git@github.com:wthrowe/spectre.git","clone_url":"https://github.com/wthrowe/spectre.git","svn_url":"https://github.com/wthrowe/spectre","homepage":null,"size":11374,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"e7e5d33bf2e98c4378a1b6f1b6bece5070106083","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-06-08T17:07:50Z","pushed_at":"2018-06-08T17:09:03Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":10287,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":85,"watchers":26,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/728"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/728"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/728"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/728/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/728/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/728/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a0268af8214c0d1c8104159df9361749792292f7"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kidder","id":1264082,"node_id":"MDQ6VXNlcjEyNjQwODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1264082?v=4","gravatar_id":"","url":"https://api.github.com/users/kidder","html_url":"https://github.com/kidder","followers_url":"https://api.github.com/users/kidder/followers","following_url":"https://api.github.com/users/kidder/following{/other_user}","gists_url":"https://api.github.com/users/kidder/gists{/gist_id}","starred_url":"https://api.github.com/users/kidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidder/subscriptions","organizations_url":"https://api.github.com/users/kidder/orgs","repos_url":"https://api.github.com/users/kidder/repos","events_url":"https://api.github.com/users/kidder/events{/privacy}","received_events_url":"https://api.github.com/users/kidder/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":332,"deletions":0,"changed_files":8}}
{"actor":{"display_login":"kidder"}}