{"action":"created","issue":{"url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/51","repository_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json","labels_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/51/comments","events_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/51/events","html_url":"https://github.com/TechnionTDK/jbs-text2json/issues/51","id":345794220,"node_id":"MDU6SXNzdWUzNDU3OTQyMjA=","number":51,"title":"Create parser for Abarbanel and improve the design","user":{"login":"omishali","id":3026479,"node_id":"MDQ6VXNlcjMwMjY0Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3026479?v=4","gravatar_id":"","url":"https://api.github.com/users/omishali","html_url":"https://github.com/omishali","followers_url":"https://api.github.com/users/omishali/followers","following_url":"https://api.github.com/users/omishali/following{/other_user}","gists_url":"https://api.github.com/users/omishali/gists{/gist_id}","starred_url":"https://api.github.com/users/omishali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omishali/subscriptions","organizations_url":"https://api.github.com/users/omishali/orgs","repos_url":"https://api.github.com/users/omishali/repos","events_url":"https://api.github.com/users/omishali/events{/privacy}","received_events_url":"https://api.github.com/users/omishali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"orelkan","id":28227658,"node_id":"MDQ6VXNlcjI4MjI3NjU4","avatar_url":"https://avatars0.githubusercontent.com/u/28227658?v=4","gravatar_id":"","url":"https://api.github.com/users/orelkan","html_url":"https://github.com/orelkan","followers_url":"https://api.github.com/users/orelkan/followers","following_url":"https://api.github.com/users/orelkan/following{/other_user}","gists_url":"https://api.github.com/users/orelkan/gists{/gist_id}","starred_url":"https://api.github.com/users/orelkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orelkan/subscriptions","organizations_url":"https://api.github.com/users/orelkan/orgs","repos_url":"https://api.github.com/users/orelkan/repos","events_url":"https://api.github.com/users/orelkan/events{/privacy}","received_events_url":"https://api.github.com/users/orelkan/received_events","type":"User","site_admin":false},"assignees":[{"login":"orelkan","id":28227658,"node_id":"MDQ6VXNlcjI4MjI3NjU4","avatar_url":"https://avatars0.githubusercontent.com/u/28227658?v=4","gravatar_id":"","url":"https://api.github.com/users/orelkan","html_url":"https://github.com/orelkan","followers_url":"https://api.github.com/users/orelkan/followers","following_url":"https://api.github.com/users/orelkan/following{/other_user}","gists_url":"https://api.github.com/users/orelkan/gists{/gist_id}","starred_url":"https://api.github.com/users/orelkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orelkan/subscriptions","organizations_url":"https://api.github.com/users/orelkan/orgs","repos_url":"https://api.github.com/users/orelkan/repos","events_url":"https://api.github.com/users/orelkan/events{/privacy}","received_events_url":"https://api.github.com/users/orelkan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-07-30T14:55:56Z","updated_at":"2018-08-01T11:52:44Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Created a new raw file for \"abarbanel\". Besides implementing the parser I want you to support a different design where we do not create a new class for each new mefaresh (considering the minimal data in each new class, a different solution is needed).\r\n\r\nPlease do the following:\r\n- Create a new folder jbs-data/raw/tanachmefarshim\r\n- Place ramban.txt and abarbanel.txt within that folder.\r\n- Remove the folders ramban and abarbanel.\r\n- Keep only the MefareshParser class (no need for subclasses).\r\n- Update the configParsers file: add MefareshParser and update the input/output folder.\r\n\r\nThe Text2Json class, if it finds N files within an input directory it executes the parser N times on each of the files.\r\n\r\nThis means that we should also have one test for all the mefarshim."},"comment":{"url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/comments/409548830","html_url":"https://github.com/TechnionTDK/jbs-text2json/issues/51#issuecomment-409548830","issue_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/51","id":409548830,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTU0ODgzMA==","user":{"login":"orelkan","id":28227658,"node_id":"MDQ6VXNlcjI4MjI3NjU4","avatar_url":"https://avatars0.githubusercontent.com/u/28227658?v=4","gravatar_id":"","url":"https://api.github.com/users/orelkan","html_url":"https://github.com/orelkan","followers_url":"https://api.github.com/users/orelkan/followers","following_url":"https://api.github.com/users/orelkan/following{/other_user}","gists_url":"https://api.github.com/users/orelkan/gists{/gist_id}","starred_url":"https://api.github.com/users/orelkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orelkan/subscriptions","organizations_url":"https://api.github.com/users/orelkan/orgs","repos_url":"https://api.github.com/users/orelkan/repos","events_url":"https://api.github.com/users/orelkan/events{/privacy}","received_events_url":"https://api.github.com/users/orelkan/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T11:52:44Z","updated_at":"2018-08-01T11:52:44Z","author_association":"CONTRIBUTOR","body":"My commit finishes this assignment, I also added a test class. Please take a look.\r\nThe json files were also uploaded to jbs-data"}}
{"actor":{"display_login":"orelkan"}}