{"action":"created","comment":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/185343333","pull_request_review_id":116713413,"id":185343333,"diff_hunk":"@@ -135,4 +140,66 @@\n       end\n     end\n   end\n+\n+  describe \"#destroy\" do\n+    let(:user) { create(:user) }\n+    before do\n+      request.env[\"devise.mapping\"] = Devise.mappings[:user]\n+      sign_in user\n+    end\n+\n+    it \"logs the user out logout\" do\n+      delete :destroy\n+      expect(controller.current_user).to be_blank\n+    end\n+\n+    it \"redirects to the slo path\" do\n+      delete :destroy\n+      expect(response.location).to start_with(idp_slo_path)\n+    end\n+\n+    it \"includes the username in the logout request\" do\n+      delete :destroy\n+      uri = URI.parse(response.location)\n+      deflated = Base64.decode64 Rack::Utils.parse_query(uri.query)[\"SAMLRequest\"]\n+      xml = Zlib::Inflate.new(-Zlib::MAX_WBITS).inflate(deflated)\n+      doc = Nokogiri::XML(xml)\n+      expect(doc.css(\"saml|NameID\").first.text).to eq(user.username)\n+    end\n+  end\n+\n+  describe \"#idp_sign_out\" do\n+    let(:user) { create(:user) }\n+    before do\n+      request.env[\"devise.mapping\"] = Devise.mappings[:user]\n+      request.host = \"localhost:3000\" # without this, we're getting redirected to http://test.host/","path":"vendor/engines/saml_authentication/spec/controllers/saml_authentication/sessions_controller_spec.rb","position":50,"original_position":50,"commit_id":"adb727c861dba23c1edb56d0fd36a8f345197495","original_commit_id":"adb727c861dba23c1edb56d0fd36a8f345197495","user":{"login":"jhanggi","id":1099111,"avatar_url":"https://avatars2.githubusercontent.com/u/1099111?v=4","gravatar_id":"","url":"https://api.github.com/users/jhanggi","html_url":"https://github.com/jhanggi","followers_url":"https://api.github.com/users/jhanggi/followers","following_url":"https://api.github.com/users/jhanggi/following{/other_user}","gists_url":"https://api.github.com/users/jhanggi/gists{/gist_id}","starred_url":"https://api.github.com/users/jhanggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhanggi/subscriptions","organizations_url":"https://api.github.com/users/jhanggi/orgs","repos_url":"https://api.github.com/users/jhanggi/repos","events_url":"https://api.github.com/users/jhanggi/events{/privacy}","received_events_url":"https://api.github.com/users/jhanggi/received_events","type":"User","site_admin":false},"body":"I could not figure out what was going on here, and eventually gave up. I was expecting it to work with what we have defined in `Rails.application.routes.default_url_options` in `environments/test.rb`","created_at":"2018-05-01T21:46:49Z","updated_at":"2018-05-01T21:47:42Z","html_url":"https://github.com/tablexi/nucore-open/pull/1506#discussion_r185343333","pull_request_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/185343333"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/1506#discussion_r185343333"},"pull_request":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506"}}},"pull_request":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506","id":182293108,"html_url":"https://github.com/tablexi/nucore-open/pull/1506","diff_url":"https://github.com/tablexi/nucore-open/pull/1506.diff","patch_url":"https://github.com/tablexi/nucore-open/pull/1506.patch","issue_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1506","number":1506,"state":"open","locked":false,"title":"[#140359] Support SAML Single Logout","user":{"login":"jhanggi","id":1099111,"avatar_url":"https://avatars2.githubusercontent.com/u/1099111?v=4","gravatar_id":"","url":"https://api.github.com/users/jhanggi","html_url":"https://github.com/jhanggi","followers_url":"https://api.github.com/users/jhanggi/followers","following_url":"https://api.github.com/users/jhanggi/following{/other_user}","gists_url":"https://api.github.com/users/jhanggi/gists{/gist_id}","starred_url":"https://api.github.com/users/jhanggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhanggi/subscriptions","organizations_url":"https://api.github.com/users/jhanggi/orgs","repos_url":"https://api.github.com/users/jhanggi/repos","events_url":"https://api.github.com/users/jhanggi/events{/privacy}","received_events_url":"https://api.github.com/users/jhanggi/received_events","type":"User","site_admin":false},"body":"# Release Notes\r\n\r\nSupport Single Logout for SAML. When you are signed into NUcore via SAML, when you log out, you are also logged out of the SSO/IdP provider as well as any other applications you were signed into as part of the same session.\r\n\r\n# Additional Context\r\n\r\nThis is a second take at #1497 that is hopefully a little clearer. It probably could still use some specs, though.","created_at":"2018-04-17T20:43:14Z","updated_at":"2018-05-01T21:47:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e6a5d5e72701a1af5957510a3d3bf9b7350585a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":552635429,"url":"https://api.github.com/repos/tablexi/nucore-open/labels/RaDar","name":"RaDar","color":"00693E","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506/commits","review_comments_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506/comments","review_comment_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1506/comments","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/adb727c861dba23c1edb56d0fd36a8f345197495","head":{"label":"tablexi:saml_single_logout2","ref":"saml_single_logout2","sha":"adb727c861dba23c1edb56d0fd36a8f345197495","user":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"repo":{"id":1439473,"name":"nucore-open","full_name":"tablexi/nucore-open","owner":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tablexi/nucore-open","description":"Northwestern University Core Facility Management Software (NUCore)","fork":false,"url":"https://api.github.com/repos/tablexi/nucore-open","forks_url":"https://api.github.com/repos/tablexi/nucore-open/forks","keys_url":"https://api.github.com/repos/tablexi/nucore-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tablexi/nucore-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tablexi/nucore-open/teams","hooks_url":"https://api.github.com/repos/tablexi/nucore-open/hooks","issue_events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/events{/number}","events_url":"https://api.github.com/repos/tablexi/nucore-open/events","assignees_url":"https://api.github.com/repos/tablexi/nucore-open/assignees{/user}","branches_url":"https://api.github.com/repos/tablexi/nucore-open/branches{/branch}","tags_url":"https://api.github.com/repos/tablexi/nucore-open/tags","blobs_url":"https://api.github.com/repos/tablexi/nucore-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tablexi/nucore-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tablexi/nucore-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/tablexi/nucore-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/{sha}","languages_url":"https://api.github.com/repos/tablexi/nucore-open/languages","stargazers_url":"https://api.github.com/repos/tablexi/nucore-open/stargazers","contributors_url":"https://api.github.com/repos/tablexi/nucore-open/contributors","subscribers_url":"https://api.github.com/repos/tablexi/nucore-open/subscribers","subscription_url":"https://api.github.com/repos/tablexi/nucore-open/subscription","commits_url":"https://api.github.com/repos/tablexi/nucore-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/tablexi/nucore-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/tablexi/nucore-open/contents/{+path}","compare_url":"https://api.github.com/repos/tablexi/nucore-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tablexi/nucore-open/merges","archive_url":"https://api.github.com/repos/tablexi/nucore-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tablexi/nucore-open/downloads","issues_url":"https://api.github.com/repos/tablexi/nucore-open/issues{/number}","pulls_url":"https://api.github.com/repos/tablexi/nucore-open/pulls{/number}","milestones_url":"https://api.github.com/repos/tablexi/nucore-open/milestones{/number}","notifications_url":"https://api.github.com/repos/tablexi/nucore-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tablexi/nucore-open/labels{/name}","releases_url":"https://api.github.com/repos/tablexi/nucore-open/releases{/id}","deployments_url":"https://api.github.com/repos/tablexi/nucore-open/deployments","created_at":"2011-03-04T13:45:37Z","updated_at":"2018-05-01T16:40:40Z","pushed_at":"2018-05-01T21:45:14Z","git_url":"git://github.com/tablexi/nucore-open.git","ssh_url":"git@github.com:tablexi/nucore-open.git","clone_url":"https://github.com/tablexi/nucore-open.git","svn_url":"https://github.com/tablexi/nucore-open","homepage":"","size":72039,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":3,"watchers":10,"default_branch":"master"}},"base":{"label":"tablexi:master","ref":"master","sha":"8a230c1b9fc65f5f462343d3059d39d826282a5c","user":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"repo":{"id":1439473,"name":"nucore-open","full_name":"tablexi/nucore-open","owner":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tablexi/nucore-open","description":"Northwestern University Core Facility Management Software (NUCore)","fork":false,"url":"https://api.github.com/repos/tablexi/nucore-open","forks_url":"https://api.github.com/repos/tablexi/nucore-open/forks","keys_url":"https://api.github.com/repos/tablexi/nucore-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tablexi/nucore-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tablexi/nucore-open/teams","hooks_url":"https://api.github.com/repos/tablexi/nucore-open/hooks","issue_events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/events{/number}","events_url":"https://api.github.com/repos/tablexi/nucore-open/events","assignees_url":"https://api.github.com/repos/tablexi/nucore-open/assignees{/user}","branches_url":"https://api.github.com/repos/tablexi/nucore-open/branches{/branch}","tags_url":"https://api.github.com/repos/tablexi/nucore-open/tags","blobs_url":"https://api.github.com/repos/tablexi/nucore-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tablexi/nucore-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tablexi/nucore-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/tablexi/nucore-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/{sha}","languages_url":"https://api.github.com/repos/tablexi/nucore-open/languages","stargazers_url":"https://api.github.com/repos/tablexi/nucore-open/stargazers","contributors_url":"https://api.github.com/repos/tablexi/nucore-open/contributors","subscribers_url":"https://api.github.com/repos/tablexi/nucore-open/subscribers","subscription_url":"https://api.github.com/repos/tablexi/nucore-open/subscription","commits_url":"https://api.github.com/repos/tablexi/nucore-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/tablexi/nucore-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/tablexi/nucore-open/contents/{+path}","compare_url":"https://api.github.com/repos/tablexi/nucore-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tablexi/nucore-open/merges","archive_url":"https://api.github.com/repos/tablexi/nucore-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tablexi/nucore-open/downloads","issues_url":"https://api.github.com/repos/tablexi/nucore-open/issues{/number}","pulls_url":"https://api.github.com/repos/tablexi/nucore-open/pulls{/number}","milestones_url":"https://api.github.com/repos/tablexi/nucore-open/milestones{/number}","notifications_url":"https://api.github.com/repos/tablexi/nucore-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tablexi/nucore-open/labels{/name}","releases_url":"https://api.github.com/repos/tablexi/nucore-open/releases{/id}","deployments_url":"https://api.github.com/repos/tablexi/nucore-open/deployments","created_at":"2011-03-04T13:45:37Z","updated_at":"2018-05-01T16:40:40Z","pushed_at":"2018-05-01T21:45:14Z","git_url":"git://github.com/tablexi/nucore-open.git","ssh_url":"git@github.com:tablexi/nucore-open.git","clone_url":"https://github.com/tablexi/nucore-open.git","svn_url":"https://github.com/tablexi/nucore-open","homepage":"","size":72039,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/1506"},"issue":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/1506"},"comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/1506/comments"},"review_comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506/comments"},"review_comment":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1506/commits"},"statuses":{"href":"https://api.github.com/repos/tablexi/nucore-open/statuses/adb727c861dba23c1edb56d0fd36a8f345197495"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhanggi"}}