{"action":"created","comment":{"url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments/241951329","pull_request_review_id":185356758,"id":241951329,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk1MTMyOQ==","diff_hunk":"@@ -50,12 +50,7 @@ void Layout::checkScroll(GtkAdjustment* adjustment, double& lastScroll)\n {\n \tXOJ_CHECK_TYPE(Layout);\n \n-\tif (!view->shouldIgnoreTouchEvents())","path":"src/gui/Layout.cpp","position":4,"original_position":4,"commit_id":"f566c693f1443c90bbb0349c6cbb6f317169f414","original_commit_id":"f566c693f1443c90bbb0349c6cbb6f317169f414","user":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"body":"This does issues, therefore I removed it, I plan to add something like this, but I need a better solution.","created_at":"2018-12-15T14:40:04Z","updated_at":"2018-12-15T14:40:05Z","html_url":"https://github.com/xournalpp/xournalpp/pull/535#discussion_r241951329","pull_request_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments/241951329"},"html":{"href":"https://github.com/xournalpp/xournalpp/pull/535#discussion_r241951329"},"pull_request":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535"}}},"pull_request":{"url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535","id":238914779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTE0Nzc5","html_url":"https://github.com/xournalpp/xournalpp/pull/535","diff_url":"https://github.com/xournalpp/xournalpp/pull/535.diff","patch_url":"https://github.com/xournalpp/xournalpp/pull/535.patch","issue_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/535","number":535,"state":"open","locked":false,"title":"New input handling","user":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"body":"Should be working mostly\r\nWhat I plan to do:\r\n* Add a configurable timeout how long the pen disables the touchscreen.\r\n* Disables touch gestures (and scrolling, need a good workaround)\r\n\r\nAdditional add a timeout handling, if there is no action on an input, release the lock for it, else no input will be possible anymore. So if we miss an event, input will not be possible anymore.\r\n\r\nThe input is now handled by device, therefor this is needed.\r\n","created_at":"2018-12-15T14:39:10Z","updated_at":"2018-12-15T14:40:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bae980b75d8a3fb652e049484045cac2f16188fc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"morrolinux","id":20294254,"node_id":"MDQ6VXNlcjIwMjk0MjU0","avatar_url":"https://avatars1.githubusercontent.com/u/20294254?v=4","gravatar_id":"","url":"https://api.github.com/users/morrolinux","html_url":"https://github.com/morrolinux","followers_url":"https://api.github.com/users/morrolinux/followers","following_url":"https://api.github.com/users/morrolinux/following{/other_user}","gists_url":"https://api.github.com/users/morrolinux/gists{/gist_id}","starred_url":"https://api.github.com/users/morrolinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrolinux/subscriptions","organizations_url":"https://api.github.com/users/morrolinux/orgs","repos_url":"https://api.github.com/users/morrolinux/repos","events_url":"https://api.github.com/users/morrolinux/events{/privacy}","received_events_url":"https://api.github.com/users/morrolinux/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535/commits","review_comments_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535/comments","review_comment_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/535/comments","statuses_url":"https://api.github.com/repos/xournalpp/xournalpp/statuses/f566c693f1443c90bbb0349c6cbb6f317169f414","head":{"label":"andreasb242:gtk-input3","ref":"gtk-input3","sha":"f566c693f1443c90bbb0349c6cbb6f317169f414","user":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"repo":{"id":155748630,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3NDg2MzA=","name":"xournalpp","full_name":"andreasb242/xournalpp","private":false,"owner":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andreasb242/xournalpp","description":"Xournal++ is a handwriting Notetaking software, working on Linux, e.g. Ubuntu and supports Tablets like Wacom.","fork":true,"url":"https://api.github.com/repos/andreasb242/xournalpp","forks_url":"https://api.github.com/repos/andreasb242/xournalpp/forks","keys_url":"https://api.github.com/repos/andreasb242/xournalpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasb242/xournalpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasb242/xournalpp/teams","hooks_url":"https://api.github.com/repos/andreasb242/xournalpp/hooks","issue_events_url":"https://api.github.com/repos/andreasb242/xournalpp/issues/events{/number}","events_url":"https://api.github.com/repos/andreasb242/xournalpp/events","assignees_url":"https://api.github.com/repos/andreasb242/xournalpp/assignees{/user}","branches_url":"https://api.github.com/repos/andreasb242/xournalpp/branches{/branch}","tags_url":"https://api.github.com/repos/andreasb242/xournalpp/tags","blobs_url":"https://api.github.com/repos/andreasb242/xournalpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasb242/xournalpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasb242/xournalpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasb242/xournalpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasb242/xournalpp/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasb242/xournalpp/languages","stargazers_url":"https://api.github.com/repos/andreasb242/xournalpp/stargazers","contributors_url":"https://api.github.com/repos/andreasb242/xournalpp/contributors","subscribers_url":"https://api.github.com/repos/andreasb242/xournalpp/subscribers","subscription_url":"https://api.github.com/repos/andreasb242/xournalpp/subscription","commits_url":"https://api.github.com/repos/andreasb242/xournalpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasb242/xournalpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasb242/xournalpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasb242/xournalpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreasb242/xournalpp/contents/{+path}","compare_url":"https://api.github.com/repos/andreasb242/xournalpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasb242/xournalpp/merges","archive_url":"https://api.github.com/repos/andreasb242/xournalpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasb242/xournalpp/downloads","issues_url":"https://api.github.com/repos/andreasb242/xournalpp/issues{/number}","pulls_url":"https://api.github.com/repos/andreasb242/xournalpp/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasb242/xournalpp/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasb242/xournalpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasb242/xournalpp/labels{/name}","releases_url":"https://api.github.com/repos/andreasb242/xournalpp/releases{/id}","deployments_url":"https://api.github.com/repos/andreasb242/xournalpp/deployments","created_at":"2018-11-01T17:06:28Z","updated_at":"2018-12-14T14:31:07Z","pushed_at":"2018-12-15T14:30:56Z","git_url":"git://github.com/andreasb242/xournalpp.git","ssh_url":"git@github.com:andreasb242/xournalpp.git","clone_url":"https://github.com/andreasb242/xournalpp.git","svn_url":"https://github.com/andreasb242/xournalpp","homepage":"","size":17801,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xournalpp:master","ref":"master","sha":"9627d46beecd81514798046527cb3753ec4f22d6","user":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"repo":{"id":11986447,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4NjQ0Nw==","name":"xournalpp","full_name":"xournalpp/xournalpp","private":false,"owner":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xournalpp/xournalpp","description":"Xournal++ is a handwriting Notetaking software, working on Linux, e.g. Ubuntu and supports Tablets like Wacom.","fork":false,"url":"https://api.github.com/repos/xournalpp/xournalpp","forks_url":"https://api.github.com/repos/xournalpp/xournalpp/forks","keys_url":"https://api.github.com/repos/xournalpp/xournalpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xournalpp/xournalpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xournalpp/xournalpp/teams","hooks_url":"https://api.github.com/repos/xournalpp/xournalpp/hooks","issue_events_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/events{/number}","events_url":"https://api.github.com/repos/xournalpp/xournalpp/events","assignees_url":"https://api.github.com/repos/xournalpp/xournalpp/assignees{/user}","branches_url":"https://api.github.com/repos/xournalpp/xournalpp/branches{/branch}","tags_url":"https://api.github.com/repos/xournalpp/xournalpp/tags","blobs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xournalpp/xournalpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/xournalpp/xournalpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xournalpp/xournalpp/statuses/{sha}","languages_url":"https://api.github.com/repos/xournalpp/xournalpp/languages","stargazers_url":"https://api.github.com/repos/xournalpp/xournalpp/stargazers","contributors_url":"https://api.github.com/repos/xournalpp/xournalpp/contributors","subscribers_url":"https://api.github.com/repos/xournalpp/xournalpp/subscribers","subscription_url":"https://api.github.com/repos/xournalpp/xournalpp/subscription","commits_url":"https://api.github.com/repos/xournalpp/xournalpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/xournalpp/xournalpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/xournalpp/xournalpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/xournalpp/xournalpp/contents/{+path}","compare_url":"https://api.github.com/repos/xournalpp/xournalpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xournalpp/xournalpp/merges","archive_url":"https://api.github.com/repos/xournalpp/xournalpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xournalpp/xournalpp/downloads","issues_url":"https://api.github.com/repos/xournalpp/xournalpp/issues{/number}","pulls_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls{/number}","milestones_url":"https://api.github.com/repos/xournalpp/xournalpp/milestones{/number}","notifications_url":"https://api.github.com/repos/xournalpp/xournalpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xournalpp/xournalpp/labels{/name}","releases_url":"https://api.github.com/repos/xournalpp/xournalpp/releases{/id}","deployments_url":"https://api.github.com/repos/xournalpp/xournalpp/deployments","created_at":"2013-08-08T20:58:27Z","updated_at":"2018-12-14T18:42:26Z","pushed_at":"2018-12-15T14:39:11Z","git_url":"git://github.com/xournalpp/xournalpp.git","ssh_url":"git@github.com:xournalpp/xournalpp.git","clone_url":"https://github.com/xournalpp/xournalpp.git","svn_url":"https://github.com/xournalpp/xournalpp","homepage":"","size":17693,"stargazers_count":175,"watchers_count":175,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":46,"open_issues":31,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535"},"html":{"href":"https://github.com/xournalpp/xournalpp/pull/535"},"issue":{"href":"https://api.github.com/repos/xournalpp/xournalpp/issues/535"},"comments":{"href":"https://api.github.com/repos/xournalpp/xournalpp/issues/535/comments"},"review_comments":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535/comments"},"review_comment":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/535/commits"},"statuses":{"href":"https://api.github.com/repos/xournalpp/xournalpp/statuses/f566c693f1443c90bbb0349c6cbb6f317169f414"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andreasb242"}}