{"action":"closed","number":568,"pull_request":{"url":"https://api.github.com/repos/Shopify/shopify_app/pulls/568","id":178445434,"html_url":"https://github.com/Shopify/shopify_app/pull/568","diff_url":"https://github.com/Shopify/shopify_app/pull/568.diff","patch_url":"https://github.com/Shopify/shopify_app/pull/568.patch","issue_url":"https://api.github.com/repos/Shopify/shopify_app/issues/568","number":568,"state":"closed","locked":false,"title":"[WIP] Full page redirect if cookie can't be set","user":{"login":"Siva-Siva","id":4564260,"avatar_url":"https://avatars1.githubusercontent.com/u/4564260?v=4","gravatar_id":"","url":"https://api.github.com/users/Siva-Siva","html_url":"https://github.com/Siva-Siva","followers_url":"https://api.github.com/users/Siva-Siva/followers","following_url":"https://api.github.com/users/Siva-Siva/following{/other_user}","gists_url":"https://api.github.com/users/Siva-Siva/gists{/gist_id}","starred_url":"https://api.github.com/users/Siva-Siva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siva-Siva/subscriptions","organizations_url":"https://api.github.com/users/Siva-Siva/orgs","repos_url":"https://api.github.com/users/Siva-Siva/repos","events_url":"https://api.github.com/users/Siva-Siva/events{/privacy}","received_events_url":"https://api.github.com/users/Siva-Siva/received_events","type":"User","site_admin":false},"body":"Any browsers that disable third party cookies will need a full page redirect for login. This will check whether we can set a cookie before trying to do an app redirect.","created_at":"2018-03-29T21:23:59Z","updated_at":"2018-04-24T17:32:37Z","closed_at":"2018-04-24T17:32:37Z","merged_at":null,"merge_commit_sha":"00b5d6c29011245aef0e245e0fff6de1cebfaf10","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nwtn","id":786799,"avatar_url":"https://avatars2.githubusercontent.com/u/786799?v=4","gravatar_id":"","url":"https://api.github.com/users/nwtn","html_url":"https://github.com/nwtn","followers_url":"https://api.github.com/users/nwtn/followers","following_url":"https://api.github.com/users/nwtn/following{/other_user}","gists_url":"https://api.github.com/users/nwtn/gists{/gist_id}","starred_url":"https://api.github.com/users/nwtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwtn/subscriptions","organizations_url":"https://api.github.com/users/nwtn/orgs","repos_url":"https://api.github.com/users/nwtn/repos","events_url":"https://api.github.com/users/nwtn/events{/privacy}","received_events_url":"https://api.github.com/users/nwtn/received_events","type":"User","site_admin":false},{"login":"ShayneP","id":5500965,"avatar_url":"https://avatars3.githubusercontent.com/u/5500965?v=4","gravatar_id":"","url":"https://api.github.com/users/ShayneP","html_url":"https://github.com/ShayneP","followers_url":"https://api.github.com/users/ShayneP/followers","following_url":"https://api.github.com/users/ShayneP/following{/other_user}","gists_url":"https://api.github.com/users/ShayneP/gists{/gist_id}","starred_url":"https://api.github.com/users/ShayneP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShayneP/subscriptions","organizations_url":"https://api.github.com/users/ShayneP/orgs","repos_url":"https://api.github.com/users/ShayneP/repos","events_url":"https://api.github.com/users/ShayneP/events{/privacy}","received_events_url":"https://api.github.com/users/ShayneP/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/568/commits","review_comments_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/568/comments","review_comment_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/issues/568/comments","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/153032f4ed684e1b7a0b30513a8dc849cfd43bf4","head":{"label":"Shopify:handle-safari-session-issue","ref":"handle-safari-session-issue","sha":"153032f4ed684e1b7a0b30513a8dc849cfd43bf4","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61203,"name":"shopify_app","full_name":"Shopify/shopify_app","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_app","description":"A Rails Engine for building Shopify Apps","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_app","forks_url":"https://api.github.com/repos/Shopify/shopify_app/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_app/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_app/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_app/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_app/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_app/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_app/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_app/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_app/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_app/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_app/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_app/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_app/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_app/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_app/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_app/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_app/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_app/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_app/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_app/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_app/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_app/deployments","created_at":"2008-10-09T15:10:52Z","updated_at":"2018-04-24T15:28:32Z","pushed_at":"2018-04-23T18:06:12Z","git_url":"git://github.com/Shopify/shopify_app.git","ssh_url":"git@github.com:Shopify/shopify_app.git","clone_url":"https://github.com/Shopify/shopify_app.git","svn_url":"https://github.com/Shopify/shopify_app","homepage":"http://shopify.github.io/shopify_app","size":1039,"stargazers_count":766,"watchers_count":766,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":329,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":329,"open_issues":29,"watchers":766,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"76c23425b9dcb1eb0cd6918fde1ef32bb05310e5","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61203,"name":"shopify_app","full_name":"Shopify/shopify_app","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_app","description":"A Rails Engine for building Shopify Apps","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_app","forks_url":"https://api.github.com/repos/Shopify/shopify_app/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_app/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_app/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_app/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_app/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_app/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_app/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_app/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_app/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_app/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_app/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_app/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_app/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_app/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_app/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_app/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_app/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_app/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_app/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_app/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_app/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_app/deployments","created_at":"2008-10-09T15:10:52Z","updated_at":"2018-04-24T15:28:32Z","pushed_at":"2018-04-23T18:06:12Z","git_url":"git://github.com/Shopify/shopify_app.git","ssh_url":"git@github.com:Shopify/shopify_app.git","clone_url":"https://github.com/Shopify/shopify_app.git","svn_url":"https://github.com/Shopify/shopify_app","homepage":"http://shopify.github.io/shopify_app","size":1039,"stargazers_count":766,"watchers_count":766,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":329,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":329,"open_issues":29,"watchers":766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/568"},"html":{"href":"https://github.com/Shopify/shopify_app/pull/568"},"issue":{"href":"https://api.github.com/repos/Shopify/shopify_app/issues/568"},"comments":{"href":"https://api.github.com/repos/Shopify/shopify_app/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/shopify_app/statuses/153032f4ed684e1b7a0b30513a8dc849cfd43bf4"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"shopify-shipit"}}