{"action":"created","comment":{"url":"https://api.github.com/repos/nix-rust/nix/pulls/comments/243825748","pull_request_review_id":187693115,"id":243825748,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzgyNTc0OA==","diff_hunk":"@@ -117,6 +117,7 @@ pub fn test_socketpair() {\n     assert_eq!(&buf[..], b\"hello\");\n }\n \n+#[cfg(not(any(target_os = \"openbsd\")))]","path":"test/sys/test_socket.rs","position":4,"original_position":4,"commit_id":"dc345cfcc10402171c8a80305d44ab7a7938f212","original_commit_id":"dc345cfcc10402171c8a80305d44ab7a7938f212","user":{"login":"pusateri","id":90469,"node_id":"MDQ6VXNlcjkwNDY5","avatar_url":"https://avatars2.githubusercontent.com/u/90469?v=4","gravatar_id":"","url":"https://api.github.com/users/pusateri","html_url":"https://github.com/pusateri","followers_url":"https://api.github.com/users/pusateri/followers","following_url":"https://api.github.com/users/pusateri/following{/other_user}","gists_url":"https://api.github.com/users/pusateri/gists{/gist_id}","starred_url":"https://api.github.com/users/pusateri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusateri/subscriptions","organizations_url":"https://api.github.com/users/pusateri/orgs","repos_url":"https://api.github.com/users/pusateri/repos","events_url":"https://api.github.com/users/pusateri/events{/privacy}","received_events_url":"https://api.github.com/users/pusateri/received_events","type":"User","site_admin":false},"body":"stepping through the debugger, it crashes looping through the cmsgs:\r\n```\r\n(gdb) list\r\n1       extern crate nix;\r\n2       use std::os::unix::io::RawFd;\r\n3       \r\n4       pub fn main() {\r\n5           use nix::sys::uio::IoVec;\r\n6           use nix::unistd::{pipe, read, write, close};\r\n7           use nix::sys::socket::{socketpair, sendmsg, recvmsg,\r\n8                                  AddressFamily, SockType, SockFlag,\r\n9                                  ControlMessage, CmsgSpace, MsgFlags};\r\n10      \r\n(gdb) \r\n11          let (fd1, fd2) = socketpair(AddressFamily::Unix, SockType::Stream, None, SockFlag::empty())\r\n12                           .unwrap();\r\n13          let (r, w) = pipe().unwrap();\r\n14          let mut received_r: Option<RawFd> = None;\r\n15      \r\n16          {\r\n17              let iov = [IoVec::from_slice(b\"hello\")];\r\n18              let fds = [r];\r\n19              let cmsg = ControlMessage::ScmRights(&fds);\r\n20              assert_eq!(sendmsg(fd1, &iov, &[cmsg], MsgFlags::empty(), None).unwrap(), 5);\r\n(gdb) break 11\r\nBreakpoint 1 at 0x15ea4: file src/main.rs, line 11.\r\n(gdb) run\r\nStarting program: /home/pusateri/Projects/scm_rights/target/debug/scm_rights \r\n\r\nBreakpoint 1, scm_rights::main::h34fb823cda0cd73f () at src/main.rs:11\r\n11          let (fd1, fd2) = socketpair(AddressFamily::Unix, SockType::Stream, None, SockFlag::empty())\r\n(gdb) n\r\n13          let (r, w) = pipe().unwrap();\r\n(gdb) n\r\n14          let mut received_r: Option<RawFd> = None;\r\n(gdb) n\r\n17              let iov = [IoVec::from_slice(b\"hello\")];\r\n(gdb) \r\nwarning: (Internal error: pc 0x833443cd400 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd400 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd400 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd400 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd400 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd400 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd400 in read in psymtab, but not in symtab.)\r\n\r\n18              let fds = [r];\r\n(gdb) \r\n19              let cmsg = ControlMessage::ScmRights(&fds);\r\n(gdb) \r\n20              assert_eq!(sendmsg(fd1, &iov, &[cmsg], MsgFlags::empty(), None).unwrap(), 5);\r\n(gdb) \r\n21              close(r).unwrap();\r\n(gdb) \r\n22              close(fd1).unwrap();\r\n(gdb) \r\n26              let mut buf = [0u8; 5];\r\n(gdb) \r\n27              let iov = [IoVec::from_mut_slice(&mut buf[..])];\r\n(gdb) \r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\nwarning: (Internal error: pc 0x833443cd470 in read in psymtab, but not in symtab.)\r\n\r\n28              let mut cmsgspace: CmsgSpace<[RawFd; 1]> = CmsgSpace::new();\r\n(gdb) \r\n29              let msg = recvmsg(fd2, &iov, Some(&mut cmsgspace), MsgFlags::empty()).unwrap();\r\n(gdb) \r\n31              for cmsg in msg.cmsgs() {\r\n(gdb) \r\nthread 'main' panicked at 'slice index starts at 24 but ends at 20', libcore/slice/mod.rs:1977:5\r\nnote: Run with `RUST_BACKTRACE=1` for a backtrace.\r\n[Inferior 1 (process 45666) exited with code 0145]\r\n(gdb) \r\n```","created_at":"2018-12-24T13:02:11Z","updated_at":"2018-12-24T13:02:11Z","html_url":"https://github.com/nix-rust/nix/pull/1001#discussion_r243825748","pull_request_url":"https://api.github.com/repos/nix-rust/nix/pulls/1001","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/comments/243825748"},"html":{"href":"https://github.com/nix-rust/nix/pull/1001#discussion_r243825748"},"pull_request":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/1001"}},"in_reply_to_id":243779345},"pull_request":{"url":"https://api.github.com/repos/nix-rust/nix/pulls/1001","id":240705232,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzA1MjMy","html_url":"https://github.com/nix-rust/nix/pull/1001","diff_url":"https://github.com/nix-rust/nix/pull/1001.diff","patch_url":"https://github.com/nix-rust/nix/pull/1001.patch","issue_url":"https://api.github.com/repos/nix-rust/nix/issues/1001","number":1001,"state":"open","locked":false,"title":"Allow cargo test to complete on OpenBSD 6.4/AMD64","user":{"login":"pusateri","id":90469,"node_id":"MDQ6VXNlcjkwNDY5","avatar_url":"https://avatars2.githubusercontent.com/u/90469?v=4","gravatar_id":"","url":"https://api.github.com/users/pusateri","html_url":"https://github.com/pusateri","followers_url":"https://api.github.com/users/pusateri/followers","following_url":"https://api.github.com/users/pusateri/following{/other_user}","gists_url":"https://api.github.com/users/pusateri/gists{/gist_id}","starred_url":"https://api.github.com/users/pusateri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusateri/subscriptions","organizations_url":"https://api.github.com/users/pusateri/orgs","repos_url":"https://api.github.com/users/pusateri/repos","events_url":"https://api.github.com/users/pusateri/events{/privacy}","received_events_url":"https://api.github.com/users/pusateri/received_events","type":"User","site_admin":false},"body":"disable some features that aren't included in OpenBSD.","created_at":"2018-12-23T23:23:43Z","updated_at":"2018-12-24T13:02:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acdfccb1e17fdb65b36c42827e25ae8a76cbf8e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nix-rust/nix/pulls/1001/commits","review_comments_url":"https://api.github.com/repos/nix-rust/nix/pulls/1001/comments","review_comment_url":"https://api.github.com/repos/nix-rust/nix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nix-rust/nix/issues/1001/comments","statuses_url":"https://api.github.com/repos/nix-rust/nix/statuses/dc345cfcc10402171c8a80305d44ab7a7938f212","head":{"label":"pusateri:openbsd","ref":"openbsd","sha":"dc345cfcc10402171c8a80305d44ab7a7938f212","user":{"login":"pusateri","id":90469,"node_id":"MDQ6VXNlcjkwNDY5","avatar_url":"https://avatars2.githubusercontent.com/u/90469?v=4","gravatar_id":"","url":"https://api.github.com/users/pusateri","html_url":"https://github.com/pusateri","followers_url":"https://api.github.com/users/pusateri/followers","following_url":"https://api.github.com/users/pusateri/following{/other_user}","gists_url":"https://api.github.com/users/pusateri/gists{/gist_id}","starred_url":"https://api.github.com/users/pusateri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusateri/subscriptions","organizations_url":"https://api.github.com/users/pusateri/orgs","repos_url":"https://api.github.com/users/pusateri/repos","events_url":"https://api.github.com/users/pusateri/events{/privacy}","received_events_url":"https://api.github.com/users/pusateri/received_events","type":"User","site_admin":false},"repo":{"id":162194510,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxOTQ1MTA=","name":"nix","full_name":"pusateri/nix","private":false,"owner":{"login":"pusateri","id":90469,"node_id":"MDQ6VXNlcjkwNDY5","avatar_url":"https://avatars2.githubusercontent.com/u/90469?v=4","gravatar_id":"","url":"https://api.github.com/users/pusateri","html_url":"https://github.com/pusateri","followers_url":"https://api.github.com/users/pusateri/followers","following_url":"https://api.github.com/users/pusateri/following{/other_user}","gists_url":"https://api.github.com/users/pusateri/gists{/gist_id}","starred_url":"https://api.github.com/users/pusateri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusateri/subscriptions","organizations_url":"https://api.github.com/users/pusateri/orgs","repos_url":"https://api.github.com/users/pusateri/repos","events_url":"https://api.github.com/users/pusateri/events{/privacy}","received_events_url":"https://api.github.com/users/pusateri/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pusateri/nix","description":"Rust friendly bindings to *nix APIs","fork":true,"url":"https://api.github.com/repos/pusateri/nix","forks_url":"https://api.github.com/repos/pusateri/nix/forks","keys_url":"https://api.github.com/repos/pusateri/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pusateri/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pusateri/nix/teams","hooks_url":"https://api.github.com/repos/pusateri/nix/hooks","issue_events_url":"https://api.github.com/repos/pusateri/nix/issues/events{/number}","events_url":"https://api.github.com/repos/pusateri/nix/events","assignees_url":"https://api.github.com/repos/pusateri/nix/assignees{/user}","branches_url":"https://api.github.com/repos/pusateri/nix/branches{/branch}","tags_url":"https://api.github.com/repos/pusateri/nix/tags","blobs_url":"https://api.github.com/repos/pusateri/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pusateri/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pusateri/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/pusateri/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pusateri/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/pusateri/nix/languages","stargazers_url":"https://api.github.com/repos/pusateri/nix/stargazers","contributors_url":"https://api.github.com/repos/pusateri/nix/contributors","subscribers_url":"https://api.github.com/repos/pusateri/nix/subscribers","subscription_url":"https://api.github.com/repos/pusateri/nix/subscription","commits_url":"https://api.github.com/repos/pusateri/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/pusateri/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/pusateri/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/pusateri/nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/pusateri/nix/contents/{+path}","compare_url":"https://api.github.com/repos/pusateri/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pusateri/nix/merges","archive_url":"https://api.github.com/repos/pusateri/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pusateri/nix/downloads","issues_url":"https://api.github.com/repos/pusateri/nix/issues{/number}","pulls_url":"https://api.github.com/repos/pusateri/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/pusateri/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/pusateri/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pusateri/nix/labels{/name}","releases_url":"https://api.github.com/repos/pusateri/nix/releases{/id}","deployments_url":"https://api.github.com/repos/pusateri/nix/deployments","created_at":"2018-12-17T21:55:09Z","updated_at":"2018-12-17T21:55:11Z","pushed_at":"2018-12-23T23:17:05Z","git_url":"git://github.com/pusateri/nix.git","ssh_url":"git@github.com:pusateri/nix.git","clone_url":"https://github.com/pusateri/nix.git","svn_url":"https://github.com/pusateri/nix","homepage":"","size":2187,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nix-rust:master","ref":"master","sha":"e1bb80e8139475f30db541e49d4efb12a6dd8a6e","user":{"login":"nix-rust","id":17190941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTkwOTQx","avatar_url":"https://avatars0.githubusercontent.com/u/17190941?v=4","gravatar_id":"","url":"https://api.github.com/users/nix-rust","html_url":"https://github.com/nix-rust","followers_url":"https://api.github.com/users/nix-rust/followers","following_url":"https://api.github.com/users/nix-rust/following{/other_user}","gists_url":"https://api.github.com/users/nix-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/nix-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nix-rust/subscriptions","organizations_url":"https://api.github.com/users/nix-rust/orgs","repos_url":"https://api.github.com/users/nix-rust/repos","events_url":"https://api.github.com/users/nix-rust/events{/privacy}","received_events_url":"https://api.github.com/users/nix-rust/received_events","type":"Organization","site_admin":false},"repo":{"id":22734848,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczNDg0OA==","name":"nix","full_name":"nix-rust/nix","private":false,"owner":{"login":"nix-rust","id":17190941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTkwOTQx","avatar_url":"https://avatars0.githubusercontent.com/u/17190941?v=4","gravatar_id":"","url":"https://api.github.com/users/nix-rust","html_url":"https://github.com/nix-rust","followers_url":"https://api.github.com/users/nix-rust/followers","following_url":"https://api.github.com/users/nix-rust/following{/other_user}","gists_url":"https://api.github.com/users/nix-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/nix-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nix-rust/subscriptions","organizations_url":"https://api.github.com/users/nix-rust/orgs","repos_url":"https://api.github.com/users/nix-rust/repos","events_url":"https://api.github.com/users/nix-rust/events{/privacy}","received_events_url":"https://api.github.com/users/nix-rust/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nix-rust/nix","description":"Rust friendly bindings to *nix APIs","fork":false,"url":"https://api.github.com/repos/nix-rust/nix","forks_url":"https://api.github.com/repos/nix-rust/nix/forks","keys_url":"https://api.github.com/repos/nix-rust/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nix-rust/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nix-rust/nix/teams","hooks_url":"https://api.github.com/repos/nix-rust/nix/hooks","issue_events_url":"https://api.github.com/repos/nix-rust/nix/issues/events{/number}","events_url":"https://api.github.com/repos/nix-rust/nix/events","assignees_url":"https://api.github.com/repos/nix-rust/nix/assignees{/user}","branches_url":"https://api.github.com/repos/nix-rust/nix/branches{/branch}","tags_url":"https://api.github.com/repos/nix-rust/nix/tags","blobs_url":"https://api.github.com/repos/nix-rust/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nix-rust/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nix-rust/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/nix-rust/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nix-rust/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/nix-rust/nix/languages","stargazers_url":"https://api.github.com/repos/nix-rust/nix/stargazers","contributors_url":"https://api.github.com/repos/nix-rust/nix/contributors","subscribers_url":"https://api.github.com/repos/nix-rust/nix/subscribers","subscription_url":"https://api.github.com/repos/nix-rust/nix/subscription","commits_url":"https://api.github.com/repos/nix-rust/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/nix-rust/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/nix-rust/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/nix-rust/nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/nix-rust/nix/contents/{+path}","compare_url":"https://api.github.com/repos/nix-rust/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nix-rust/nix/merges","archive_url":"https://api.github.com/repos/nix-rust/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nix-rust/nix/downloads","issues_url":"https://api.github.com/repos/nix-rust/nix/issues{/number}","pulls_url":"https://api.github.com/repos/nix-rust/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/nix-rust/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/nix-rust/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nix-rust/nix/labels{/name}","releases_url":"https://api.github.com/repos/nix-rust/nix/releases{/id}","deployments_url":"https://api.github.com/repos/nix-rust/nix/deployments","created_at":"2014-08-07T20:03:36Z","updated_at":"2018-12-23T13:42:25Z","pushed_at":"2018-12-23T23:23:44Z","git_url":"git://github.com/nix-rust/nix.git","ssh_url":"git@github.com:nix-rust/nix.git","clone_url":"https://github.com/nix-rust/nix.git","svn_url":"https://github.com/nix-rust/nix","homepage":"","size":2195,"stargazers_count":816,"watchers_count":816,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":267,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":267,"open_issues":100,"watchers":816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/1001"},"html":{"href":"https://github.com/nix-rust/nix/pull/1001"},"issue":{"href":"https://api.github.com/repos/nix-rust/nix/issues/1001"},"comments":{"href":"https://api.github.com/repos/nix-rust/nix/issues/1001/comments"},"review_comments":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/1001/comments"},"review_comment":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/1001/commits"},"statuses":{"href":"https://api.github.com/repos/nix-rust/nix/statuses/dc345cfcc10402171c8a80305d44ab7a7938f212"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pusateri"}}