{"action":"created","issue":{"url":"https://api.github.com/repos/hashcat/hashcat/issues/1636","repository_url":"https://api.github.com/repos/hashcat/hashcat","labels_url":"https://api.github.com/repos/hashcat/hashcat/issues/1636/labels{/name}","comments_url":"https://api.github.com/repos/hashcat/hashcat/issues/1636/comments","events_url":"https://api.github.com/repos/hashcat/hashcat/issues/1636/events","html_url":"https://github.com/hashcat/hashcat/issues/1636","id":344421240,"node_id":"MDU6SXNzdWUzNDQ0MjEyNDA=","number":1636,"title":"hex notation broken in replace rule","user":{"login":"hops","id":196515,"node_id":"MDQ6VXNlcjE5NjUxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/196515?v=4","gravatar_id":"","url":"https://api.github.com/users/hops","html_url":"https://github.com/hops","followers_url":"https://api.github.com/users/hops/followers","following_url":"https://api.github.com/users/hops/following{/other_user}","gists_url":"https://api.github.com/users/hops/gists{/gist_id}","starred_url":"https://api.github.com/users/hops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hops/subscriptions","organizations_url":"https://api.github.com/users/hops/orgs","repos_url":"https://api.github.com/users/hops/repos","events_url":"https://api.github.com/users/hops/events{/privacy}","received_events_url":"https://api.github.com/users/hops/received_events","type":"User","site_admin":false},"labels":[{"id":295417775,"node_id":"MDU6TGFiZWwyOTU0MTc3NzU=","url":"https://api.github.com/repos/hashcat/hashcat/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-25T12:24:20Z","updated_at":"2018-07-26T09:42:43Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"When using the hex notation in the search part of the replace rule hashcat will produce a wrong rule.\r\nFor example:\r\n```\r\n$ cat test.rule\r\ns\\x41\\x42\r\n$ echo testA | ./hashcat -r test.rule --stdout\r\nSkipping invalid or unsupported rule in file test.rule on line 1: s\\x41\\x42\r\n```\r\n`s\\x41\\x42` will be replaced by `sA[:space:][:space:][:space:]B[:space:][:space:][:space:]` in the function _old_apply_rule().\r\nThat results in a rule which would replace A with a space and leaves a dangling B and therefore skips the rule.\r\n\r\nI believe only the replace rule is affected. And only if the search character is represented in hex notation.\r\nFor example: `sA\\x42` works fine."},"comment":{"url":"https://api.github.com/repos/hashcat/hashcat/issues/comments/408040612","html_url":"https://github.com/hashcat/hashcat/issues/1636#issuecomment-408040612","issue_url":"https://api.github.com/repos/hashcat/hashcat/issues/1636","id":408040612,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODA0MDYxMg==","user":{"login":"jsteube","id":10434361,"node_id":"MDQ6VXNlcjEwNDM0MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/10434361?v=4","gravatar_id":"","url":"https://api.github.com/users/jsteube","html_url":"https://github.com/jsteube","followers_url":"https://api.github.com/users/jsteube/followers","following_url":"https://api.github.com/users/jsteube/following{/other_user}","gists_url":"https://api.github.com/users/jsteube/gists{/gist_id}","starred_url":"https://api.github.com/users/jsteube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsteube/subscriptions","organizations_url":"https://api.github.com/users/jsteube/orgs","repos_url":"https://api.github.com/users/jsteube/repos","events_url":"https://api.github.com/users/jsteube/events{/privacy}","received_events_url":"https://api.github.com/users/jsteube/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T09:42:43Z","updated_at":"2018-07-26T09:42:43Z","author_association":"MEMBER","body":"Should be fixed with commit https://github.com/hashcat/hashcat/commit/9d431117309e51d0a29bb16daa8ac01ba15a77ee\r\n\r\nMany thanks for reporting!"}}
{"actor":{"display_login":"jsteube"}}