{"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/3941","repository_url":"https://api.github.com/repos/MetaMask/metamask-extension","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/3941/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/3941/comments","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/3941/events","html_url":"https://github.com/MetaMask/metamask-extension/issues/3941","id":312991104,"node_id":"MDU6SXNzdWUzMTI5OTExMDQ=","number":3941,"title":"Add JSDoc documentation to all background scripts","user":{"login":"danfinlay","id":542863,"node_id":"MDQ6VXNlcjU0Mjg2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/542863?v=4","gravatar_id":"","url":"https://api.github.com/users/danfinlay","html_url":"https://github.com/danfinlay","followers_url":"https://api.github.com/users/danfinlay/followers","following_url":"https://api.github.com/users/danfinlay/following{/other_user}","gists_url":"https://api.github.com/users/danfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfinlay/subscriptions","organizations_url":"https://api.github.com/users/danfinlay/orgs","repos_url":"https://api.github.com/users/danfinlay/repos","events_url":"https://api.github.com/users/danfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/danfinlay/received_events","type":"User","site_admin":false},"labels":[{"id":602338448,"node_id":"MDU6TGFiZWw2MDIzMzg0NDg=","url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/L05-documentation","name":"L05-documentation","color":"6af9a4","default":false}],"state":"open","locked":false,"assignee":{"login":"danjm","id":7499938,"node_id":"MDQ6VXNlcjc0OTk5Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7499938?v=4","gravatar_id":"","url":"https://api.github.com/users/danjm","html_url":"https://github.com/danjm","followers_url":"https://api.github.com/users/danjm/followers","following_url":"https://api.github.com/users/danjm/following{/other_user}","gists_url":"https://api.github.com/users/danjm/gists{/gist_id}","starred_url":"https://api.github.com/users/danjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danjm/subscriptions","organizations_url":"https://api.github.com/users/danjm/orgs","repos_url":"https://api.github.com/users/danjm/repos","events_url":"https://api.github.com/users/danjm/events{/privacy}","received_events_url":"https://api.github.com/users/danjm/received_events","type":"User","site_admin":false},"assignees":[{"login":"danjm","id":7499938,"node_id":"MDQ6VXNlcjc0OTk5Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7499938?v=4","gravatar_id":"","url":"https://api.github.com/users/danjm","html_url":"https://github.com/danjm","followers_url":"https://api.github.com/users/danjm/followers","following_url":"https://api.github.com/users/danjm/following{/other_user}","gists_url":"https://api.github.com/users/danjm/gists{/gist_id}","starred_url":"https://api.github.com/users/danjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danjm/subscriptions","organizations_url":"https://api.github.com/users/danjm/orgs","repos_url":"https://api.github.com/users/danjm/repos","events_url":"https://api.github.com/users/danjm/events{/privacy}","received_events_url":"https://api.github.com/users/danjm/received_events","type":"User","site_admin":false},{"login":"frankiebee","id":11225267,"node_id":"MDQ6VXNlcjExMjI1MjY3","avatar_url":"https://avatars0.githubusercontent.com/u/11225267?v=4","gravatar_id":"","url":"https://api.github.com/users/frankiebee","html_url":"https://github.com/frankiebee","followers_url":"https://api.github.com/users/frankiebee/followers","following_url":"https://api.github.com/users/frankiebee/following{/other_user}","gists_url":"https://api.github.com/users/frankiebee/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiebee/subscriptions","organizations_url":"https://api.github.com/users/frankiebee/orgs","repos_url":"https://api.github.com/users/frankiebee/repos","events_url":"https://api.github.com/users/frankiebee/events{/privacy}","received_events_url":"https://api.github.com/users/frankiebee/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/milestones/21","html_url":"https://github.com/MetaMask/metamask-extension/milestone/21","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/milestones/21/labels","id":3256376,"node_id":"MDk6TWlsZXN0b25lMzI1NjM3Ng==","number":21,"title":"Maintenance Sprint","description":"We shipped several bugs in the last week, so this milestone has no new features, and only reflects project-level improvements that will make it harder to ship bugs in the future.","creator":{"login":"danfinlay","id":542863,"node_id":"MDQ6VXNlcjU0Mjg2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/542863?v=4","gravatar_id":"","url":"https://api.github.com/users/danfinlay","html_url":"https://github.com/danfinlay","followers_url":"https://api.github.com/users/danfinlay/followers","following_url":"https://api.github.com/users/danfinlay/following{/other_user}","gists_url":"https://api.github.com/users/danfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfinlay/subscriptions","organizations_url":"https://api.github.com/users/danfinlay/orgs","repos_url":"https://api.github.com/users/danfinlay/repos","events_url":"https://api.github.com/users/danfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/danfinlay/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":17,"state":"closed","created_at":"2018-04-10T15:57:36Z","updated_at":"2018-07-09T22:02:50Z","due_on":"2018-04-19T07:00:00Z","closed_at":"2018-07-09T22:02:50Z"},"comments":10,"created_at":"2018-04-10T16:06:59Z","updated_at":"2018-09-12T19:05:44Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Multiple bugs were shipped last week, in part because interfaces to some files were not clear/understood.\r\n\r\nLong term, this looks like a good case for strong types, but in the short term, strong documentation is something our codebase lacks, and could help alleviate this kind of issue.\r\n\r\nJSDoc can generate nice readable documentation for a codebase, here is some docs added to our `KeyringController` (here called `mm-vault`):\r\nhttps://github.com/lazaridiscom/mm-vault\r\n\r\nShould be added to all scripts in `app/scripts`, especially `app/scripts/controllers` and `app/scripts/lib`."},"comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments/420762613","html_url":"https://github.com/MetaMask/metamask-extension/issues/3941#issuecomment-420762613","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/3941","id":420762613,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDc2MjYxMw==","user":{"login":"bdresser","id":1016190,"node_id":"MDQ6VXNlcjEwMTYxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1016190?v=4","gravatar_id":"","url":"https://api.github.com/users/bdresser","html_url":"https://github.com/bdresser","followers_url":"https://api.github.com/users/bdresser/followers","following_url":"https://api.github.com/users/bdresser/following{/other_user}","gists_url":"https://api.github.com/users/bdresser/gists{/gist_id}","starred_url":"https://api.github.com/users/bdresser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdresser/subscriptions","organizations_url":"https://api.github.com/users/bdresser/orgs","repos_url":"https://api.github.com/users/bdresser/repos","events_url":"https://api.github.com/users/bdresser/events{/privacy}","received_events_url":"https://api.github.com/users/bdresser/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T19:05:44Z","updated_at":"2018-09-12T19:05:44Z","author_association":"MEMBER","body":"Team is this still in play? Looks like a bunch of pieces have been merged, any outstanding? "}}
{"actor":{"display_login":"bdresser"}}