{"action":"created","comment":{"url":"https://api.github.com/repos/spacetelescope/jwst/pulls/comments/229032290","pull_request_review_id":169434895,"id":229032290,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTAzMjI5MA==","diff_hunk":"@@ -655,43 +658,19 @@ def _calc_cat_convex_hull(self):\n             # no points\n             raise RuntimeError(\"Unexpected error: Contact sofware developer\")\n \n-        elif len(x) == 1:\n-            # one point. build a small box around it:\n-            x, y = convex_hull(x, y, wcs=self.det_to_tanp)\n-\n-            xv = [x[0] - 0.5, x[0] - 0.5, x[0] + 0.5, x[0] + 0.5, x[0] - 0.5]\n-            yv = [y[0] - 0.5, y[0] + 0.5, y[0] + 0.5, y[0] - 0.5, y[0] - 0.5]\n-\n-            ra, dec = self.tanp_to_world(xv, yv)\n-\n-        elif len(x) == 3:\n-            # two points. build a small box around them:\n-            x, y = convex_hull(x, y, wcs=self.det_to_tanp)\n-\n-            vx = -(y[1] - y[0])\n-            vy = x[1] - x[0]\n-            norm = 2.0 * np.sqrt(vx * vx + vy * vy)\n-            vx /= norm\n-            vy /= norm\n-\n-            xv = [x[0] + vx, x[1] + vx, x[1] + vx, x[0] - vx, x[0] + vx]\n-            yv = [y[0] + vy, y[1] + vy, y[1] + vy, x[0] - vx, x[0] + vx]\n-\n-            ra, dec = self.tanp_to_world(xv, yv)\n-\n-        else:\n+        if len(x) > 2:","path":"jwst/tweakreg/wcsimage.py","position":48,"original_position":48,"commit_id":"8629882b6d3a7a5626f21d8dd7724cef96ac7f32","original_commit_id":"8629882b6d3a7a5626f21d8dd7724cef96ac7f32","user":{"login":"hbushouse","id":12860084,"node_id":"MDQ6VXNlcjEyODYwMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/12860084?v=4","gravatar_id":"","url":"https://api.github.com/users/hbushouse","html_url":"https://github.com/hbushouse","followers_url":"https://api.github.com/users/hbushouse/followers","following_url":"https://api.github.com/users/hbushouse/following{/other_user}","gists_url":"https://api.github.com/users/hbushouse/gists{/gist_id}","starred_url":"https://api.github.com/users/hbushouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbushouse/subscriptions","organizations_url":"https://api.github.com/users/hbushouse/orgs","repos_url":"https://api.github.com/users/hbushouse/repos","events_url":"https://api.github.com/users/hbushouse/events{/privacy}","received_events_url":"https://api.github.com/users/hbushouse/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-10-29T17:48:10Z","updated_at":"2018-10-29T17:49:01Z","html_url":"https://github.com/spacetelescope/jwst/pull/2797#discussion_r229032290","pull_request_url":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/jwst/pulls/comments/229032290"},"html":{"href":"https://github.com/spacetelescope/jwst/pull/2797#discussion_r229032290"},"pull_request":{"href":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797"}},"in_reply_to_id":229009024},"pull_request":{"url":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797","id":226449330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDQ5MzMw","html_url":"https://github.com/spacetelescope/jwst/pull/2797","diff_url":"https://github.com/spacetelescope/jwst/pull/2797.diff","patch_url":"https://github.com/spacetelescope/jwst/pull/2797.patch","issue_url":"https://api.github.com/repos/spacetelescope/jwst/issues/2797","number":2797,"state":"open","locked":false,"title":"Fix logic for computing catalog footprints","user":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"body":"This PR addresses the issue https://github.com/spacetelescope/jwst/issues/2746. However, it will only work (tests will pass *tweakreg* stage) only if https://github.com/spacetelescope/jwst/pull/2796 is merged as well.\r\n\r\nUnfortunately this PR makes algorithm a little inefficient when image catalogs contain 1 or two stars. Optimization can be addressed later if need be. For now, IMO, this should be robust enough to work.\r\n\r\nCC: @hbushouse @stscieisenhamer @stscicrawford ","created_at":"2018-10-29T06:20:01Z","updated_at":"2018-10-29T17:49:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a4e3327b95e3c3cd8421fe95bae18a01f4b67d1","assignee":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"assignees":[{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":388553031,"node_id":"MDU6TGFiZWwzODg1NTMwMzE=","url":"https://api.github.com/repos/spacetelescope/jwst/labels/bug","name":"bug","color":"ee0701","default":true},{"id":390243706,"node_id":"MDU6TGFiZWwzOTAyNDM3MDY=","url":"https://api.github.com/repos/spacetelescope/jwst/labels/tweakreg","name":"tweakreg","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/spacetelescope/jwst/milestones/16","html_url":"https://github.com/spacetelescope/jwst/milestone/16","labels_url":"https://api.github.com/repos/spacetelescope/jwst/milestones/16/labels","id":3697525,"node_id":"MDk6TWlsZXN0b25lMzY5NzUyNQ==","number":16,"title":"0.13.0","description":null,"creator":{"login":"philhodge","id":2065676,"node_id":"MDQ6VXNlcjIwNjU2NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2065676?v=4","gravatar_id":"","url":"https://api.github.com/users/philhodge","html_url":"https://github.com/philhodge","followers_url":"https://api.github.com/users/philhodge/followers","following_url":"https://api.github.com/users/philhodge/following{/other_user}","gists_url":"https://api.github.com/users/philhodge/gists{/gist_id}","starred_url":"https://api.github.com/users/philhodge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philhodge/subscriptions","organizations_url":"https://api.github.com/users/philhodge/orgs","repos_url":"https://api.github.com/users/philhodge/repos","events_url":"https://api.github.com/users/philhodge/events{/privacy}","received_events_url":"https://api.github.com/users/philhodge/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":6,"state":"open","created_at":"2018-09-28T20:15:56Z","updated_at":"2018-10-29T17:16:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797/commits","review_comments_url":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797/comments","review_comment_url":"https://api.github.com/repos/spacetelescope/jwst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetelescope/jwst/issues/2797/comments","statuses_url":"https://api.github.com/repos/spacetelescope/jwst/statuses/8629882b6d3a7a5626f21d8dd7724cef96ac7f32","head":{"label":"mcara:fix2764","ref":"fix2764","sha":"8629882b6d3a7a5626f21d8dd7724cef96ac7f32","user":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"repo":{"id":60785973,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc4NTk3Mw==","name":"jwst","full_name":"mcara/jwst","private":false,"owner":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mcara/jwst","description":null,"fork":true,"url":"https://api.github.com/repos/mcara/jwst","forks_url":"https://api.github.com/repos/mcara/jwst/forks","keys_url":"https://api.github.com/repos/mcara/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcara/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcara/jwst/teams","hooks_url":"https://api.github.com/repos/mcara/jwst/hooks","issue_events_url":"https://api.github.com/repos/mcara/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/mcara/jwst/events","assignees_url":"https://api.github.com/repos/mcara/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/mcara/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/mcara/jwst/tags","blobs_url":"https://api.github.com/repos/mcara/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcara/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcara/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcara/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcara/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/mcara/jwst/languages","stargazers_url":"https://api.github.com/repos/mcara/jwst/stargazers","contributors_url":"https://api.github.com/repos/mcara/jwst/contributors","subscribers_url":"https://api.github.com/repos/mcara/jwst/subscribers","subscription_url":"https://api.github.com/repos/mcara/jwst/subscription","commits_url":"https://api.github.com/repos/mcara/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcara/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcara/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcara/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcara/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/mcara/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcara/jwst/merges","archive_url":"https://api.github.com/repos/mcara/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcara/jwst/downloads","issues_url":"https://api.github.com/repos/mcara/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/mcara/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/mcara/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/mcara/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcara/jwst/labels{/name}","releases_url":"https://api.github.com/repos/mcara/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/mcara/jwst/deployments","created_at":"2016-06-09T15:34:37Z","updated_at":"2018-10-28T06:27:23Z","pushed_at":"2018-10-29T17:04:37Z","git_url":"git://github.com/mcara/jwst.git","ssh_url":"git@github.com:mcara/jwst.git","clone_url":"https://github.com/mcara/jwst.git","svn_url":"https://github.com/mcara/jwst","homepage":null,"size":71850,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacetelescope:master","ref":"master","sha":"d7daa6c9cc60fc9870add2950ca06a424056db28","user":{"login":"spacetelescope","id":2751928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"repo":{"id":60551519,"node_id":"MDEwOlJlcG9zaXRvcnk2MDU1MTUxOQ==","name":"jwst","full_name":"spacetelescope/jwst","private":false,"owner":{"login":"spacetelescope","id":2751928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetelescope/jwst","description":"Python library for science observations from the James Webb Space Telescope ","fork":false,"url":"https://api.github.com/repos/spacetelescope/jwst","forks_url":"https://api.github.com/repos/spacetelescope/jwst/forks","keys_url":"https://api.github.com/repos/spacetelescope/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetelescope/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetelescope/jwst/teams","hooks_url":"https://api.github.com/repos/spacetelescope/jwst/hooks","issue_events_url":"https://api.github.com/repos/spacetelescope/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/spacetelescope/jwst/events","assignees_url":"https://api.github.com/repos/spacetelescope/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/spacetelescope/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/spacetelescope/jwst/tags","blobs_url":"https://api.github.com/repos/spacetelescope/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetelescope/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetelescope/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetelescope/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetelescope/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetelescope/jwst/languages","stargazers_url":"https://api.github.com/repos/spacetelescope/jwst/stargazers","contributors_url":"https://api.github.com/repos/spacetelescope/jwst/contributors","subscribers_url":"https://api.github.com/repos/spacetelescope/jwst/subscribers","subscription_url":"https://api.github.com/repos/spacetelescope/jwst/subscription","commits_url":"https://api.github.com/repos/spacetelescope/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetelescope/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetelescope/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetelescope/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetelescope/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/spacetelescope/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetelescope/jwst/merges","archive_url":"https://api.github.com/repos/spacetelescope/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetelescope/jwst/downloads","issues_url":"https://api.github.com/repos/spacetelescope/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/spacetelescope/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetelescope/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetelescope/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetelescope/jwst/labels{/name}","releases_url":"https://api.github.com/repos/spacetelescope/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/spacetelescope/jwst/deployments","created_at":"2016-06-06T18:34:23Z","updated_at":"2018-10-29T17:30:40Z","pushed_at":"2018-10-29T17:34:20Z","git_url":"git://github.com/spacetelescope/jwst.git","ssh_url":"git@github.com:spacetelescope/jwst.git","clone_url":"https://github.com/spacetelescope/jwst.git","svn_url":"https://github.com/spacetelescope/jwst","homepage":"https://jwst-pipeline.readthedocs.io/en/latest/","size":71866,"stargazers_count":50,"watchers_count":50,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":325,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":325,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797"},"html":{"href":"https://github.com/spacetelescope/jwst/pull/2797"},"issue":{"href":"https://api.github.com/repos/spacetelescope/jwst/issues/2797"},"comments":{"href":"https://api.github.com/repos/spacetelescope/jwst/issues/2797/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetelescope/jwst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetelescope/jwst/pulls/2797/commits"},"statuses":{"href":"https://api.github.com/repos/spacetelescope/jwst/statuses/8629882b6d3a7a5626f21d8dd7724cef96ac7f32"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hbushouse"}}