{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/197041010","pull_request_review_id":130702701,"id":197041010,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzA0MTAxMA==","diff_hunk":"@@ -179,13 +197,49 @@ be nested within lists or dictionaries, such as in the case of\n ``np.concatenate([x, y, z])``. This can be problematic for two reasons:\n \n 1. Some functions are given long lists of values, and traversing them\n-   might be prohibitively expensive\n-2. Some function may have arguments that we don't want to inspect, even\n-   if they have the ``__array_function__`` method\n+   might be prohibitively expensive.\n+2. Some functions may have arguments that we don't want to inspect, even\n+   if they have the ``__array_function__`` method.\n+\n+To resolve these issues, NumPy functions should explicitly indicate which\n+of their arguments may be overloaded, and how these arguments should be\n+checked. As a rule, this should include all arguments documented as either\n+``array_like`` or ``ndarray``.\n+\n+We propose to do so by writing \"dispatcher\" functions for each overloaded\n+NumPy function:\n+- These functions will be called with the exact same arguments that were passed","path":"doc/neps/nep-0018-array-function-protocol.rst","position":115,"original_position":113,"commit_id":"1696ffe1365ba32ffb62510c6c49386866aedb39","original_commit_id":"c7c47cd7499ebd89e48571f7c9f0c1b5bb54af73","user":{"login":"hameerabbasi","id":2190658,"node_id":"MDQ6VXNlcjIxOTA2NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2190658?v=4","gravatar_id":"","url":"https://api.github.com/users/hameerabbasi","html_url":"https://github.com/hameerabbasi","followers_url":"https://api.github.com/users/hameerabbasi/followers","following_url":"https://api.github.com/users/hameerabbasi/following{/other_user}","gists_url":"https://api.github.com/users/hameerabbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/hameerabbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hameerabbasi/subscriptions","organizations_url":"https://api.github.com/users/hameerabbasi/orgs","repos_url":"https://api.github.com/users/hameerabbasi/repos","events_url":"https://api.github.com/users/hameerabbasi/events{/privacy}","received_events_url":"https://api.github.com/users/hameerabbasi/received_events","type":"User","site_admin":false},"body":"This still needs fixing.","created_at":"2018-06-21T07:55:11Z","updated_at":"2018-06-21T07:55:12Z","html_url":"https://github.com/numpy/numpy/pull/11374#discussion_r197041010","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/11374","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/197041010"},"html":{"href":"https://github.com/numpy/numpy/pull/11374#discussion_r197041010"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11374"}},"in_reply_to_id":196607809},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11374","id":195438403,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDM4NDAz","html_url":"https://github.com/numpy/numpy/pull/11374","diff_url":"https://github.com/numpy/numpy/pull/11374.diff","patch_url":"https://github.com/numpy/numpy/pull/11374.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11374","number":11374,"state":"open","locked":false,"title":"WIP: additional revision for NEP-18 (__array_function__)","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"body":"Adjusts the text to describe a variant of @eric-wieser's \"explicit decorator\" proposal from https://github.com/numpy/numpy/pull/11303#issuecomment-396638175\r\n\r\nThere are a still a number of TODOs from the last PR, and I haven't even gotten to revising the \"Alternatives\" or \"Drawbacks\" sections yet, but I thought I might as well put this up. I promise we'll send this back to the mailing list for discussion soon!\r\n\r\nCCing the usual @mrocklin @mhvk @hameerabbasi @ngoldbaum @mattip","created_at":"2018-06-18T07:14:08Z","updated_at":"2018-06-21T07:55:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cf4b1c9e2408efa842cfa510ce5460fa27ce1bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/11374/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/11374/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11374/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/1696ffe1365ba32ffb62510c6c49386866aedb39","head":{"label":"shoyer:nep18-v3","ref":"nep18-v3","sha":"1696ffe1365ba32ffb62510c6c49386866aedb39","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"repo":{"id":17073121,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3MzEyMQ==","name":"numpy","full_name":"shoyer/numpy","owner":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shoyer/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/shoyer/numpy","forks_url":"https://api.github.com/repos/shoyer/numpy/forks","keys_url":"https://api.github.com/repos/shoyer/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoyer/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoyer/numpy/teams","hooks_url":"https://api.github.com/repos/shoyer/numpy/hooks","issue_events_url":"https://api.github.com/repos/shoyer/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/shoyer/numpy/events","assignees_url":"https://api.github.com/repos/shoyer/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/shoyer/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/shoyer/numpy/tags","blobs_url":"https://api.github.com/repos/shoyer/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoyer/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoyer/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoyer/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoyer/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/shoyer/numpy/languages","stargazers_url":"https://api.github.com/repos/shoyer/numpy/stargazers","contributors_url":"https://api.github.com/repos/shoyer/numpy/contributors","subscribers_url":"https://api.github.com/repos/shoyer/numpy/subscribers","subscription_url":"https://api.github.com/repos/shoyer/numpy/subscription","commits_url":"https://api.github.com/repos/shoyer/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoyer/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoyer/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoyer/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/shoyer/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/shoyer/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoyer/numpy/merges","archive_url":"https://api.github.com/repos/shoyer/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoyer/numpy/downloads","issues_url":"https://api.github.com/repos/shoyer/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/shoyer/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/shoyer/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/shoyer/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoyer/numpy/labels{/name}","releases_url":"https://api.github.com/repos/shoyer/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/shoyer/numpy/deployments","created_at":"2014-02-21T23:15:13Z","updated_at":"2015-02-25T08:34:01Z","pushed_at":"2018-06-21T07:04:08Z","git_url":"git://github.com/shoyer/numpy.git","ssh_url":"git@github.com:shoyer/numpy.git","clone_url":"https://github.com/shoyer/numpy.git","svn_url":"https://github.com/shoyer/numpy","homepage":"http://www.numpy.org/","size":55370,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"44cfca844f043722906a9b2932a4ba03dce15c75","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-06-21T07:40:58Z","pushed_at":"2018-06-21T07:33:42Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":58753,"stargazers_count":7493,"watchers_count":7493,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2815,"mirror_url":null,"archived":false,"open_issues_count":1928,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2815,"open_issues":1928,"watchers":7493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11374"},"html":{"href":"https://github.com/numpy/numpy/pull/11374"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/11374"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/11374/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11374/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11374/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/1696ffe1365ba32ffb62510c6c49386866aedb39"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hameerabbasi"}}