{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/245272931","pull_request_review_id":189335332,"id":245272931,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTI3MjkzMQ==","diff_hunk":"@@ -110,22 +109,42 @@ case class PreAggregateTableHelper(\n     // Datamap table name and columns are automatically added prefix with parent table name\n     // in carbon. For convenient, users can type column names same as the ones in select statement\n     // when config dmproperties, and here we update column names with prefix.\n-    val longStringColumn = tableProperties.get(CarbonCommonConstants.LONG_STRING_COLUMNS)\n+    // If longStringColumn is not present in dmproperties then we take long_string_columns from\n+    // the parent table.\n+    var longStringColumn = tableProperties.get(CarbonCommonConstants.LONG_STRING_COLUMNS)\n+    val longStringColumnInParents = parentTable.getTableInfo.getFactTable.getTableProperties.asScala\n+      .getOrElse(CarbonCommonConstants.LONG_STRING_COLUMNS, \"\").split(\",\").map(_.trim)\n+    var varcharDatamapFields = \"\"\n+    fieldRelationMap foreach (fields => {\n+      val aggFunc = fields._2.aggregateFunction\n+      if (aggFunc == \"\") {","path":"integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala","position":21,"original_position":21,"commit_id":"eb428aff34249291ac40431bad0319e96b4f5bdb","original_commit_id":"eb428aff34249291ac40431bad0319e96b4f5bdb","user":{"login":"kumarvishal09","id":13032998,"node_id":"MDQ6VXNlcjEzMDMyOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/13032998?v=4","gravatar_id":"","url":"https://api.github.com/users/kumarvishal09","html_url":"https://github.com/kumarvishal09","followers_url":"https://api.github.com/users/kumarvishal09/followers","following_url":"https://api.github.com/users/kumarvishal09/following{/other_user}","gists_url":"https://api.github.com/users/kumarvishal09/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarvishal09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarvishal09/subscriptions","organizations_url":"https://api.github.com/users/kumarvishal09/orgs","repos_url":"https://api.github.com/users/kumarvishal09/repos","events_url":"https://api.github.com/users/kumarvishal09/events{/privacy}","received_events_url":"https://api.github.com/users/kumarvishal09/received_events","type":"User","site_admin":false},"body":"Please use isEmpty","created_at":"2019-01-04T11:21:37Z","updated_at":"2019-01-04T11:21:37Z","html_url":"https://github.com/apache/carbondata/pull/3045#discussion_r245272931","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/3045","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/245272931"},"html":{"href":"https://github.com/apache/carbondata/pull/3045#discussion_r245272931"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/3045"}}},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/3045","id":241700452,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzAwNDUy","html_url":"https://github.com/apache/carbondata/pull/3045","diff_url":"https://github.com/apache/carbondata/pull/3045.diff","patch_url":"https://github.com/apache/carbondata/pull/3045.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/3045","number":3045,"state":"open","locked":false,"title":"[CARBONDATA-3222]Fix dataload failure after creation of preaggregate datamap on main table with long_string_columns","user":{"login":"shardul-cr7","id":13481398,"node_id":"MDQ6VXNlcjEzNDgxMzk4","avatar_url":"https://avatars2.githubusercontent.com/u/13481398?v=4","gravatar_id":"","url":"https://api.github.com/users/shardul-cr7","html_url":"https://github.com/shardul-cr7","followers_url":"https://api.github.com/users/shardul-cr7/followers","following_url":"https://api.github.com/users/shardul-cr7/following{/other_user}","gists_url":"https://api.github.com/users/shardul-cr7/gists{/gist_id}","starred_url":"https://api.github.com/users/shardul-cr7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shardul-cr7/subscriptions","organizations_url":"https://api.github.com/users/shardul-cr7/orgs","repos_url":"https://api.github.com/users/shardul-cr7/repos","events_url":"https://api.github.com/users/shardul-cr7/events{/privacy}","received_events_url":"https://api.github.com/users/shardul-cr7/received_events","type":"User","site_admin":false},"body":"This PR is to Fix dataload failure after creation of preaggregate datamap on main table with long_string_columns.\r\n\r\nDataload is gettling failed because child table properties are not getting modified according to the parent table for long_string_columns.\r\nThis occurs only when long_string_columns is not specified in dmproperties for preaggregate datamap but the datamap was getting created and data load was failing. This PR is to avoid the dataload failure in this scenario.\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [ ] Any interfaces changed?\r\n \r\n - [ ] Any backward compatibility impacted?\r\n \r\n - [ ] Document update required?\r\n\r\n - [x] Testing done\r\n        added a testcase\r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\n\r\n","created_at":"2019-01-02T09:23:12Z","updated_at":"2019-01-04T11:21:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a9a142db69d6dabf3525704586cfb0f0a9f252c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/3045/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/3045/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/3045/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/eb428aff34249291ac40431bad0319e96b4f5bdb","head":{"label":"shardul-cr7:lsc_preagg","ref":"lsc_preagg","sha":"eb428aff34249291ac40431bad0319e96b4f5bdb","user":{"login":"shardul-cr7","id":13481398,"node_id":"MDQ6VXNlcjEzNDgxMzk4","avatar_url":"https://avatars2.githubusercontent.com/u/13481398?v=4","gravatar_id":"","url":"https://api.github.com/users/shardul-cr7","html_url":"https://github.com/shardul-cr7","followers_url":"https://api.github.com/users/shardul-cr7/followers","following_url":"https://api.github.com/users/shardul-cr7/following{/other_user}","gists_url":"https://api.github.com/users/shardul-cr7/gists{/gist_id}","starred_url":"https://api.github.com/users/shardul-cr7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shardul-cr7/subscriptions","organizations_url":"https://api.github.com/users/shardul-cr7/orgs","repos_url":"https://api.github.com/users/shardul-cr7/repos","events_url":"https://api.github.com/users/shardul-cr7/events{/privacy}","received_events_url":"https://api.github.com/users/shardul-cr7/received_events","type":"User","site_admin":false},"repo":{"id":143402382,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0MDIzODI=","name":"carbondata","full_name":"shardul-cr7/carbondata","private":false,"owner":{"login":"shardul-cr7","id":13481398,"node_id":"MDQ6VXNlcjEzNDgxMzk4","avatar_url":"https://avatars2.githubusercontent.com/u/13481398?v=4","gravatar_id":"","url":"https://api.github.com/users/shardul-cr7","html_url":"https://github.com/shardul-cr7","followers_url":"https://api.github.com/users/shardul-cr7/followers","following_url":"https://api.github.com/users/shardul-cr7/following{/other_user}","gists_url":"https://api.github.com/users/shardul-cr7/gists{/gist_id}","starred_url":"https://api.github.com/users/shardul-cr7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shardul-cr7/subscriptions","organizations_url":"https://api.github.com/users/shardul-cr7/orgs","repos_url":"https://api.github.com/users/shardul-cr7/repos","events_url":"https://api.github.com/users/shardul-cr7/events{/privacy}","received_events_url":"https://api.github.com/users/shardul-cr7/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shardul-cr7/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/shardul-cr7/carbondata","forks_url":"https://api.github.com/repos/shardul-cr7/carbondata/forks","keys_url":"https://api.github.com/repos/shardul-cr7/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shardul-cr7/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shardul-cr7/carbondata/teams","hooks_url":"https://api.github.com/repos/shardul-cr7/carbondata/hooks","issue_events_url":"https://api.github.com/repos/shardul-cr7/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/shardul-cr7/carbondata/events","assignees_url":"https://api.github.com/repos/shardul-cr7/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/shardul-cr7/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/shardul-cr7/carbondata/tags","blobs_url":"https://api.github.com/repos/shardul-cr7/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shardul-cr7/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shardul-cr7/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/shardul-cr7/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shardul-cr7/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/shardul-cr7/carbondata/languages","stargazers_url":"https://api.github.com/repos/shardul-cr7/carbondata/stargazers","contributors_url":"https://api.github.com/repos/shardul-cr7/carbondata/contributors","subscribers_url":"https://api.github.com/repos/shardul-cr7/carbondata/subscribers","subscription_url":"https://api.github.com/repos/shardul-cr7/carbondata/subscription","commits_url":"https://api.github.com/repos/shardul-cr7/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/shardul-cr7/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/shardul-cr7/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/shardul-cr7/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/shardul-cr7/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/shardul-cr7/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shardul-cr7/carbondata/merges","archive_url":"https://api.github.com/repos/shardul-cr7/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shardul-cr7/carbondata/downloads","issues_url":"https://api.github.com/repos/shardul-cr7/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/shardul-cr7/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/shardul-cr7/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/shardul-cr7/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shardul-cr7/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/shardul-cr7/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/shardul-cr7/carbondata/deployments","created_at":"2018-08-03T08:43:22Z","updated_at":"2018-09-11T13:06:34Z","pushed_at":"2019-01-03T09:13:47Z","git_url":"git://github.com/shardul-cr7/carbondata.git","ssh_url":"git@github.com:shardul-cr7/carbondata.git","clone_url":"https://github.com/shardul-cr7/carbondata.git","svn_url":"https://github.com/shardul-cr7/carbondata","homepage":"","size":200993,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7477527e91cbcc3693e8bb49449fe7c2895f8b39","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxOA==","name":"carbondata","full_name":"apache/carbondata","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2019-01-04T11:17:39Z","pushed_at":"2019-01-04T11:17:23Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":66312,"stargazers_count":833,"watchers_count":833,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":509,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":509,"open_issues":109,"watchers":833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/3045"},"html":{"href":"https://github.com/apache/carbondata/pull/3045"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/3045"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/3045/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/3045/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/3045/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/eb428aff34249291ac40431bad0319e96b4f5bdb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kumarvishal09"}}