{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments/191479487","pull_request_review_id":124058557,"id":191479487,"diff_hunk":"@@ -4,6 +4,6 @@ import { shallow } from 'enzyme';\n import VncConsole from './VncConsole';\n \n test('placeholder render test', () => {\n-  const view = shallow(<VncConsole />);\n+  const view = shallow(<VncConsole host=\"my.unknown.host\" />);\n   expect(view).toMatchSnapshot();","path":"packages/console/src/VncConsole/VncConsole.test.js","position":6,"original_position":6,"commit_id":"2b7fa5e06738d2ed2e31f65cc21ee075145f0dc4","original_commit_id":"2b7fa5e06738d2ed2e31f65cc21ee075145f0dc4","user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars1.githubusercontent.com/u/11633780?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"body":"Can we add tests to modify some of the props and verify the expected results? Simulate the connecting, disconnected, and connected states, etc.","created_at":"2018-05-29T15:56:15Z","updated_at":"2018-05-29T15:56:35Z","html_url":"https://github.com/patternfly/patternfly-react/pull/288#discussion_r191479487","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments/191479487"},"html":{"href":"https://github.com/patternfly/patternfly-react/pull/288#discussion_r191479487"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288","id":177414929,"html_url":"https://github.com/patternfly/patternfly-react/pull/288","diff_url":"https://github.com/patternfly/patternfly-react/pull/288.diff","patch_url":"https://github.com/patternfly/patternfly-react/pull/288.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/288","number":288,"state":"open","locked":false,"title":"feat(VncConsole): Introduce VncConsole component","user":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars2.githubusercontent.com/u/17194943?v=4","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your interest in patternfly-react. We appreciate all issues filed and PRs submitted!\r\n\r\nPlease make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What issue is being addressed here?) -->\r\n**What**:\r\nProvide reusable component to access server/virtual machine via VNC protocol.\r\n\r\n<!-- Please provide a link to your fork's Storybook. See README notes on how to do this. -->\r\n**Link to Storybook**:\r\nMock VNC backend is not available, so storybook is just a formal one, not showing the functionality.\r\nScreenshots will substitute it in this case.\r\n\r\nLink: https://mareklibra.github.io/patternfly-react/\r\n\r\n<!-- Are there any upstream issues or separate issues you need to reference? -->\r\n**Additional issues**:\r\nDepends on: ~~#160 (SerialConsole)~~\r\n\r\n**Future work**:\r\nIf this change is accepted, higher-level `<Consoles/>` component wrapping selection of either `VncConsole` or `SerialConsole` will be implemented.\r\n\r\n<!-- feel free to add additional comments -->","created_at":"2018-03-26T11:20:47Z","updated_at":"2018-05-29T15:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52c64cc19f98702fb857d098cf084981ee038455","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/288/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-react/statuses/2b7fa5e06738d2ed2e31f65cc21ee075145f0dc4","head":{"label":"mareklibra:vncConsole","ref":"vncConsole","sha":"2b7fa5e06738d2ed2e31f65cc21ee075145f0dc4","user":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars2.githubusercontent.com/u/17194943?v=4","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"repo":{"id":116145981,"name":"patternfly-react","full_name":"mareklibra/patternfly-react","owner":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars2.githubusercontent.com/u/17194943?v=4","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mareklibra/patternfly-react","description":"This project will provide a set of React UI components for the PatternFly project","fork":true,"url":"https://api.github.com/repos/mareklibra/patternfly-react","forks_url":"https://api.github.com/repos/mareklibra/patternfly-react/forks","keys_url":"https://api.github.com/repos/mareklibra/patternfly-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mareklibra/patternfly-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mareklibra/patternfly-react/teams","hooks_url":"https://api.github.com/repos/mareklibra/patternfly-react/hooks","issue_events_url":"https://api.github.com/repos/mareklibra/patternfly-react/issues/events{/number}","events_url":"https://api.github.com/repos/mareklibra/patternfly-react/events","assignees_url":"https://api.github.com/repos/mareklibra/patternfly-react/assignees{/user}","branches_url":"https://api.github.com/repos/mareklibra/patternfly-react/branches{/branch}","tags_url":"https://api.github.com/repos/mareklibra/patternfly-react/tags","blobs_url":"https://api.github.com/repos/mareklibra/patternfly-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mareklibra/patternfly-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mareklibra/patternfly-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/mareklibra/patternfly-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mareklibra/patternfly-react/statuses/{sha}","languages_url":"https://api.github.com/repos/mareklibra/patternfly-react/languages","stargazers_url":"https://api.github.com/repos/mareklibra/patternfly-react/stargazers","contributors_url":"https://api.github.com/repos/mareklibra/patternfly-react/contributors","subscribers_url":"https://api.github.com/repos/mareklibra/patternfly-react/subscribers","subscription_url":"https://api.github.com/repos/mareklibra/patternfly-react/subscription","commits_url":"https://api.github.com/repos/mareklibra/patternfly-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/mareklibra/patternfly-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/mareklibra/patternfly-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/mareklibra/patternfly-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/mareklibra/patternfly-react/contents/{+path}","compare_url":"https://api.github.com/repos/mareklibra/patternfly-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mareklibra/patternfly-react/merges","archive_url":"https://api.github.com/repos/mareklibra/patternfly-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mareklibra/patternfly-react/downloads","issues_url":"https://api.github.com/repos/mareklibra/patternfly-react/issues{/number}","pulls_url":"https://api.github.com/repos/mareklibra/patternfly-react/pulls{/number}","milestones_url":"https://api.github.com/repos/mareklibra/patternfly-react/milestones{/number}","notifications_url":"https://api.github.com/repos/mareklibra/patternfly-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mareklibra/patternfly-react/labels{/name}","releases_url":"https://api.github.com/repos/mareklibra/patternfly-react/releases{/id}","deployments_url":"https://api.github.com/repos/mareklibra/patternfly-react/deployments","created_at":"2018-01-03T14:27:53Z","updated_at":"2018-01-03T14:27:55Z","pushed_at":"2018-05-17T10:17:06Z","git_url":"git://github.com/mareklibra/patternfly-react.git","ssh_url":"git@github.com:mareklibra/patternfly-react.git","clone_url":"https://github.com/mareklibra/patternfly-react.git","svn_url":"https://github.com/mareklibra/patternfly-react","homepage":"https://rawgit.com/patternfly/patternfly-react/gh-pages/index.html","size":7271,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"ff09abb4e4bce12608f11312bfa56fa25954d423","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":84372347,"name":"patternfly-react","full_name":"patternfly/patternfly-react","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/patternfly-react","description":"This repo contains instructions and the code for a set of React components for the PatternFly project. ","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-react","forks_url":"https://api.github.com/repos/patternfly/patternfly-react/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-react/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-react/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-react/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-react/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-react/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-react/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-react/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-react/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-react/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-react/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-react/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-react/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-react/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-react/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-react/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-react/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-react/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-react/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-react/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-react/deployments","created_at":"2017-03-08T22:31:12Z","updated_at":"2018-05-29T13:03:20Z","pushed_at":"2018-05-29T15:25:39Z","git_url":"git://github.com/patternfly/patternfly-react.git","ssh_url":"git@github.com:patternfly/patternfly-react.git","clone_url":"https://github.com/patternfly/patternfly-react.git","svn_url":"https://github.com/patternfly/patternfly-react","homepage":"https://rawgit.com/patternfly/patternfly-react/gh-pages/index.html","size":7395,"stargazers_count":85,"watchers_count":85,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":62,"open_issues":78,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288"},"html":{"href":"https://github.com/patternfly/patternfly-react/pull/288"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-react/issues/288"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-react/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-react/statuses/2b7fa5e06738d2ed2e31f65cc21ee075145f0dc4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeff-phillips-18"}}