{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/170764926","pull_request_review_id":99501465,"id":170764926,"diff_hunk":"@@ -209,12 +206,11 @@\n  * <tt>\"group.id\"</tt>, <tt>\"enable.auto.commit\"</tt>, etc.\n  *\n  * <h3>Event Timestamp and Watermark</h3>\n- * By default record timestamp and watermark are based on processing time in KafkaIO reader.\n- * This can be overridden by providing {@code WatermarkFn} with\n- * {@link Read#withWatermarkFn(SerializableFunction)}, and {@code TimestampFn} with\n- * {@link Read#withTimestampFn(SerializableFunction)}.<br>\n- * Note that {@link KafkaRecord#getTimestamp()} reflects timestamp provided by Kafka if any,\n- * otherwise it is set to processing time.\n+ * By default, record timestamp (evnt time) is set to processing time in KafkaIO reader and","path":"sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java","position":null,"original_position":35,"commit_id":"ccf8b319c121f5d2abd558c4e036150a9692e9f1","original_commit_id":"76e41816f50bea387416ea42228bd289adebac35","user":{"login":"rangadi","id":502522,"avatar_url":"https://avatars2.githubusercontent.com/u/502522?v=4","gravatar_id":"","url":"https://api.github.com/users/rangadi","html_url":"https://github.com/rangadi","followers_url":"https://api.github.com/users/rangadi/followers","following_url":"https://api.github.com/users/rangadi/following{/other_user}","gists_url":"https://api.github.com/users/rangadi/gists{/gist_id}","starred_url":"https://api.github.com/users/rangadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangadi/subscriptions","organizations_url":"https://api.github.com/users/rangadi/orgs","repos_url":"https://api.github.com/users/rangadi/repos","events_url":"https://api.github.com/users/rangadi/events{/privacy}","received_events_url":"https://api.github.com/users/rangadi/received_events","type":"User","site_admin":false},"body":"Thanks. Fixed.","created_at":"2018-02-26T22:59:24Z","updated_at":"2018-02-26T22:59:24Z","html_url":"https://github.com/apache/beam/pull/4749#discussion_r170764926","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/4749","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/170764926"},"html":{"href":"https://github.com/apache/beam/pull/4749#discussion_r170764926"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/4749"}},"in_reply_to_id":170760322},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/4749","id":171465708,"html_url":"https://github.com/apache/beam/pull/4749","diff_url":"https://github.com/apache/beam/pull/4749.diff","patch_url":"https://github.com/apache/beam/pull/4749.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/4749","number":4749,"state":"open","locked":false,"title":"[BEAM-591]: Update KafkaIO JavaDoc to reflect new timestamp API.","user":{"login":"rangadi","id":502522,"avatar_url":"https://avatars2.githubusercontent.com/u/502522?v=4","gravatar_id":"","url":"https://api.github.com/users/rangadi","html_url":"https://github.com/rangadi","followers_url":"https://api.github.com/users/rangadi/followers","following_url":"https://api.github.com/users/rangadi/following{/other_user}","gists_url":"https://api.github.com/users/rangadi/gists{/gist_id}","starred_url":"https://api.github.com/users/rangadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangadi/subscriptions","organizations_url":"https://api.github.com/users/rangadi/orgs","repos_url":"https://api.github.com/users/rangadi/repos","events_url":"https://api.github.com/users/rangadi/events{/privacy}","received_events_url":"https://api.github.com/users/rangadi/received_events","type":"User","site_admin":false},"body":"Update KafkaIO JavaDoc to reflect new timestamp API. This is a quick follow up to #4680.\r\n","created_at":"2018-02-26T19:15:36Z","updated_at":"2018-02-26T22:59:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a3eb0ad42f0ffd2e3a433bbaaf1ba6a29fe5e2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/4749/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/4749/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/4749/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/ccf8b319c121f5d2abd558c4e036150a9692e9f1","head":{"label":"rangadi:doc_update","ref":"doc_update","sha":"ccf8b319c121f5d2abd558c4e036150a9692e9f1","user":{"login":"rangadi","id":502522,"avatar_url":"https://avatars2.githubusercontent.com/u/502522?v=4","gravatar_id":"","url":"https://api.github.com/users/rangadi","html_url":"https://github.com/rangadi","followers_url":"https://api.github.com/users/rangadi/followers","following_url":"https://api.github.com/users/rangadi/following{/other_user}","gists_url":"https://api.github.com/users/rangadi/gists{/gist_id}","starred_url":"https://api.github.com/users/rangadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangadi/subscriptions","organizations_url":"https://api.github.com/users/rangadi/orgs","repos_url":"https://api.github.com/users/rangadi/repos","events_url":"https://api.github.com/users/rangadi/events{/privacy}","received_events_url":"https://api.github.com/users/rangadi/received_events","type":"User","site_admin":false},"repo":{"id":53447194,"name":"beam","full_name":"rangadi/beam","owner":{"login":"rangadi","id":502522,"avatar_url":"https://avatars2.githubusercontent.com/u/502522?v=4","gravatar_id":"","url":"https://api.github.com/users/rangadi","html_url":"https://github.com/rangadi","followers_url":"https://api.github.com/users/rangadi/followers","following_url":"https://api.github.com/users/rangadi/following{/other_user}","gists_url":"https://api.github.com/users/rangadi/gists{/gist_id}","starred_url":"https://api.github.com/users/rangadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangadi/subscriptions","organizations_url":"https://api.github.com/users/rangadi/orgs","repos_url":"https://api.github.com/users/rangadi/repos","events_url":"https://api.github.com/users/rangadi/events{/privacy}","received_events_url":"https://api.github.com/users/rangadi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rangadi/beam","description":"Mirror of Apache Beam","fork":true,"url":"https://api.github.com/repos/rangadi/beam","forks_url":"https://api.github.com/repos/rangadi/beam/forks","keys_url":"https://api.github.com/repos/rangadi/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rangadi/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rangadi/beam/teams","hooks_url":"https://api.github.com/repos/rangadi/beam/hooks","issue_events_url":"https://api.github.com/repos/rangadi/beam/issues/events{/number}","events_url":"https://api.github.com/repos/rangadi/beam/events","assignees_url":"https://api.github.com/repos/rangadi/beam/assignees{/user}","branches_url":"https://api.github.com/repos/rangadi/beam/branches{/branch}","tags_url":"https://api.github.com/repos/rangadi/beam/tags","blobs_url":"https://api.github.com/repos/rangadi/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rangadi/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rangadi/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/rangadi/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rangadi/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/rangadi/beam/languages","stargazers_url":"https://api.github.com/repos/rangadi/beam/stargazers","contributors_url":"https://api.github.com/repos/rangadi/beam/contributors","subscribers_url":"https://api.github.com/repos/rangadi/beam/subscribers","subscription_url":"https://api.github.com/repos/rangadi/beam/subscription","commits_url":"https://api.github.com/repos/rangadi/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/rangadi/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/rangadi/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/rangadi/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/rangadi/beam/contents/{+path}","compare_url":"https://api.github.com/repos/rangadi/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rangadi/beam/merges","archive_url":"https://api.github.com/repos/rangadi/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rangadi/beam/downloads","issues_url":"https://api.github.com/repos/rangadi/beam/issues{/number}","pulls_url":"https://api.github.com/repos/rangadi/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/rangadi/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/rangadi/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rangadi/beam/labels{/name}","releases_url":"https://api.github.com/repos/rangadi/beam/releases{/id}","deployments_url":"https://api.github.com/repos/rangadi/beam/deployments","created_at":"2016-03-08T21:40:30Z","updated_at":"2017-06-30T20:25:13Z","pushed_at":"2018-02-26T22:58:54Z","git_url":"git://github.com/rangadi/beam.git","ssh_url":"git@github.com:rangadi/beam.git","clone_url":"https://github.com/rangadi/beam.git","svn_url":"https://github.com/rangadi/beam","homepage":"","size":51308,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"dbaf09838c5d064fdd6d953b91ad9a1ce61af72b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-02-26T16:48:05Z","pushed_at":"2018-02-26T22:58:56Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":53723,"stargazers_count":1707,"watchers_count":1707,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1027,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1027,"open_issues":86,"watchers":1707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/4749"},"html":{"href":"https://github.com/apache/beam/pull/4749"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/4749"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/4749/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/4749/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/4749/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/ccf8b319c121f5d2abd558c4e036150a9692e9f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rangadi"}}