{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/175667075","pull_request_review_id":105231953,"id":175667075,"diff_hunk":"@@ -110,6 +139,16 @@ void LogMessage(Class log_class, Level log_level, const char* filename, unsigned\n #endif\n     ;\n \n+/// Logs a message to the global logger, this time with 100% moar fmtlib\n+template <typename... Args>\n+void FmtLogMessage(Class log_class, Level log_level, const char* filename, unsigned int line_num,\n+                   const char* function, const char* format, const Args&... args) {\n+    Entry entry = CreateEntry(log_class, log_level, filename, line_num, function,","path":"src/common/logging/log.h","position":54,"original_position":54,"commit_id":"ceeb2810fe831fba7ad93d0b99dc4ed10a67ad9d","original_commit_id":"2b4998a122de12850509b4c12430266368430a00","user":{"login":"jroweboy","id":952515,"avatar_url":"https://avatars1.githubusercontent.com/u/952515?v=4","gravatar_id":"","url":"https://api.github.com/users/jroweboy","html_url":"https://github.com/jroweboy","followers_url":"https://api.github.com/users/jroweboy/followers","following_url":"https://api.github.com/users/jroweboy/following{/other_user}","gists_url":"https://api.github.com/users/jroweboy/gists{/gist_id}","starred_url":"https://api.github.com/users/jroweboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroweboy/subscriptions","organizations_url":"https://api.github.com/users/jroweboy/orgs","repos_url":"https://api.github.com/users/jroweboy/repos","events_url":"https://api.github.com/users/jroweboy/events{/privacy}","received_events_url":"https://api.github.com/users/jroweboy/received_events","type":"User","site_admin":false},"body":"did we try to ask them if they knew of any work arounds for our problem? We want the power of a variadic macro, but with the implementation details tucked away nicely in the cpp file. (I remember spending a lot of time just this and never got very far.)\r\n\r\nAs for pushing the filter to the log header. meh, i guess if thats the best we can do then we might as well.","created_at":"2018-03-20T06:46:22Z","updated_at":"2018-03-20T06:46:22Z","html_url":"https://github.com/citra-emu/citra/pull/3533#discussion_r175667075","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/3533","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/175667075"},"html":{"href":"https://github.com/citra-emu/citra/pull/3533#discussion_r175667075"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3533"}},"in_reply_to_id":175660506},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/3533","id":175526257,"html_url":"https://github.com/citra-emu/citra/pull/3533","diff_url":"https://github.com/citra-emu/citra/pull/3533.diff","patch_url":"https://github.com/citra-emu/citra/pull/3533.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/3533","number":3533,"state":"open","locked":false,"title":"Logging: Add fmtlib-based macros","user":{"login":"daniellimws","id":8130120,"avatar_url":"https://avatars2.githubusercontent.com/u/8130120?v=4","gravatar_id":"","url":"https://api.github.com/users/daniellimws","html_url":"https://github.com/daniellimws","followers_url":"https://api.github.com/users/daniellimws/followers","following_url":"https://api.github.com/users/daniellimws/following{/other_user}","gists_url":"https://api.github.com/users/daniellimws/gists{/gist_id}","starred_url":"https://api.github.com/users/daniellimws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniellimws/subscriptions","organizations_url":"https://api.github.com/users/daniellimws/orgs","repos_url":"https://api.github.com/users/daniellimws/repos","events_url":"https://api.github.com/users/daniellimws/events{/privacy}","received_events_url":"https://api.github.com/users/daniellimws/received_events","type":"User","site_admin":false},"body":"Continue #3449 \r\n\r\nChanges made:\r\n* Logging: Add a new set of logging macros to use fmtlib instead.\r\n* Citra: Migrate to the new logging macros\r\n* Config: Migrate to the new logging macros\r\n* SDL: Migrate to the new logging macros\r\n* Separating code for customizing multiple backends in #3449 for a different PR.\r\n\r\nAs variadic templates are required to be defined in the header file itself, `Entry` related code is moved into `common/logging/log.h`. Hopefully, such a minor design change is ok.\r\n\r\nOnce this PR is merged, I will create a PR for the second part of #3449, as well as migrating other components to use this macro.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/citra-emu/citra/3533)\n<!-- Reviewable:end -->\n","created_at":"2018-03-16T13:00:41Z","updated_at":"2018-03-20T06:46:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d3f4ae9ede78d1d816a3fa96cb25da3e58a2f58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/3533/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/3533/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/3533/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/ceeb2810fe831fba7ad93d0b99dc4ed10a67ad9d","head":{"label":"daniellimws:fmtlib-macros","ref":"fmtlib-macros","sha":"ceeb2810fe831fba7ad93d0b99dc4ed10a67ad9d","user":{"login":"daniellimws","id":8130120,"avatar_url":"https://avatars2.githubusercontent.com/u/8130120?v=4","gravatar_id":"","url":"https://api.github.com/users/daniellimws","html_url":"https://github.com/daniellimws","followers_url":"https://api.github.com/users/daniellimws/followers","following_url":"https://api.github.com/users/daniellimws/following{/other_user}","gists_url":"https://api.github.com/users/daniellimws/gists{/gist_id}","starred_url":"https://api.github.com/users/daniellimws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniellimws/subscriptions","organizations_url":"https://api.github.com/users/daniellimws/orgs","repos_url":"https://api.github.com/users/daniellimws/repos","events_url":"https://api.github.com/users/daniellimws/events{/privacy}","received_events_url":"https://api.github.com/users/daniellimws/received_events","type":"User","site_admin":false},"repo":{"id":122083259,"name":"citra","full_name":"daniellimws/citra","owner":{"login":"daniellimws","id":8130120,"avatar_url":"https://avatars2.githubusercontent.com/u/8130120?v=4","gravatar_id":"","url":"https://api.github.com/users/daniellimws","html_url":"https://github.com/daniellimws","followers_url":"https://api.github.com/users/daniellimws/followers","following_url":"https://api.github.com/users/daniellimws/following{/other_user}","gists_url":"https://api.github.com/users/daniellimws/gists{/gist_id}","starred_url":"https://api.github.com/users/daniellimws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniellimws/subscriptions","organizations_url":"https://api.github.com/users/daniellimws/orgs","repos_url":"https://api.github.com/users/daniellimws/repos","events_url":"https://api.github.com/users/daniellimws/events{/privacy}","received_events_url":"https://api.github.com/users/daniellimws/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniellimws/citra","description":"A Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/daniellimws/citra","forks_url":"https://api.github.com/repos/daniellimws/citra/forks","keys_url":"https://api.github.com/repos/daniellimws/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniellimws/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniellimws/citra/teams","hooks_url":"https://api.github.com/repos/daniellimws/citra/hooks","issue_events_url":"https://api.github.com/repos/daniellimws/citra/issues/events{/number}","events_url":"https://api.github.com/repos/daniellimws/citra/events","assignees_url":"https://api.github.com/repos/daniellimws/citra/assignees{/user}","branches_url":"https://api.github.com/repos/daniellimws/citra/branches{/branch}","tags_url":"https://api.github.com/repos/daniellimws/citra/tags","blobs_url":"https://api.github.com/repos/daniellimws/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniellimws/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniellimws/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniellimws/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniellimws/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/daniellimws/citra/languages","stargazers_url":"https://api.github.com/repos/daniellimws/citra/stargazers","contributors_url":"https://api.github.com/repos/daniellimws/citra/contributors","subscribers_url":"https://api.github.com/repos/daniellimws/citra/subscribers","subscription_url":"https://api.github.com/repos/daniellimws/citra/subscription","commits_url":"https://api.github.com/repos/daniellimws/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniellimws/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniellimws/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniellimws/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniellimws/citra/contents/{+path}","compare_url":"https://api.github.com/repos/daniellimws/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniellimws/citra/merges","archive_url":"https://api.github.com/repos/daniellimws/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniellimws/citra/downloads","issues_url":"https://api.github.com/repos/daniellimws/citra/issues{/number}","pulls_url":"https://api.github.com/repos/daniellimws/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/daniellimws/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/daniellimws/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniellimws/citra/labels{/name}","releases_url":"https://api.github.com/repos/daniellimws/citra/releases{/id}","deployments_url":"https://api.github.com/repos/daniellimws/citra/deployments","created_at":"2018-02-19T15:40:01Z","updated_at":"2018-03-09T17:22:49Z","pushed_at":"2018-03-20T06:16:31Z","git_url":"git://github.com/daniellimws/citra.git","ssh_url":"git@github.com:daniellimws/citra.git","clone_url":"https://github.com/daniellimws/citra.git","svn_url":"https://github.com/daniellimws/citra","homepage":"https://citra-emu.org","size":19500,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"935bcdbd204bfc1d601fd5d12851ded188b69266","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"A Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2018-03-19T19:59:07Z","pushed_at":"2018-03-20T06:16:38Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":24712,"stargazers_count":3825,"watchers_count":3825,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":887,"mirror_url":null,"archived":false,"open_issues_count":315,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":887,"open_issues":315,"watchers":3825,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3533"},"html":{"href":"https://github.com/citra-emu/citra/pull/3533"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/3533"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/3533/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3533/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3533/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/ceeb2810fe831fba7ad93d0b99dc4ed10a67ad9d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jroweboy"}}