{"action":"created","comment":{"url":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/comments/206567436","pull_request_review_id":142002471,"id":206567436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjU2NzQzNg==","diff_hunk":"@@ -4340,6 +4370,20 @@ private static File _testNotExists(File dir, String fileName) {\n \t\treturn file;\n \t}\n \n+\tprivate static void _testPropertyKeyExists(Path path, String key)\n+\t\tthrows Exception {\n+\n+\t\ttry (InputStream inputStream = Files.newInputStream(path)) {","path":"modules/sdk/project-templates/project-templates/src/test/java/com/liferay/project/templates/ProjectTemplatesTest.java","position":87,"original_position":87,"commit_id":"9e1821b9dd4506a0d7399d6616990440544fc745","original_commit_id":"9e1821b9dd4506a0d7399d6616990440544fc745","user":{"login":"Ithildir","id":1327160,"node_id":"MDQ6VXNlcjEzMjcxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1327160?v=4","gravatar_id":"","url":"https://api.github.com/users/Ithildir","html_url":"https://github.com/Ithildir","followers_url":"https://api.github.com/users/Ithildir/followers","following_url":"https://api.github.com/users/Ithildir/following{/other_user}","gists_url":"https://api.github.com/users/Ithildir/gists{/gist_id}","starred_url":"https://api.github.com/users/Ithildir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ithildir/subscriptions","organizations_url":"https://api.github.com/users/Ithildir/orgs","repos_url":"https://api.github.com/users/Ithildir/repos","events_url":"https://api.github.com/users/Ithildir/events{/privacy}","received_events_url":"https://api.github.com/users/Ithildir/received_events","type":"User","site_admin":false},"body":"We already have a `FileTestUtil.readProperties` method which reads from the classpath, why not adding an overload that receives a `Path`?","created_at":"2018-07-31T15:09:21Z","updated_at":"2018-07-31T15:10:57Z","html_url":"https://github.com/Ithildir/liferay-portal/pull/1079#discussion_r206567436","pull_request_url":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/comments/206567436"},"html":{"href":"https://github.com/Ithildir/liferay-portal/pull/1079#discussion_r206567436"},"pull_request":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079"}}},"pull_request":{"url":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079","id":204910170,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTEwMTcw","html_url":"https://github.com/Ithildir/liferay-portal/pull/1079","diff_url":"https://github.com/Ithildir/liferay-portal/pull/1079.diff","patch_url":"https://github.com/Ithildir/liferay-portal/pull/1079.patch","issue_url":"https://api.github.com/repos/Ithildir/liferay-portal/issues/1079","number":1079,"state":"open","locked":false,"title":"LPS-83933 rename and simplify","user":{"login":"gamerson","id":595221,"node_id":"MDQ6VXNlcjU5NTIyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/595221?v=4","gravatar_id":"","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-07-30T19:46:50Z","updated_at":"2018-07-31T15:10:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c97ada1cafdc7cfbea5b00ce98cfb7410018e67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":910385615,"node_id":"MDU6TGFiZWw5MTAzODU2MTU=","url":"https://api.github.com/repos/Ithildir/liferay-portal/labels/ci:test:relevant%20-%20pending","name":"ci:test:relevant - pending","color":"fff4c9","default":false},{"id":885260501,"node_id":"MDU6TGFiZWw4ODUyNjA1MDE=","url":"https://api.github.com/repos/Ithildir/liferay-portal/labels/ci:test:sf%20-%20success","name":"ci:test:sf - success","color":"c7e8cb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079/commits","review_comments_url":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079/comments","review_comment_url":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ithildir/liferay-portal/issues/1079/comments","statuses_url":"https://api.github.com/repos/Ithildir/liferay-portal/statuses/9e1821b9dd4506a0d7399d6616990440544fc745","head":{"label":"gamerson:pr-169","ref":"pr-169","sha":"9e1821b9dd4506a0d7399d6616990440544fc745","user":{"login":"gamerson","id":595221,"node_id":"MDQ6VXNlcjU5NTIyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/595221?v=4","gravatar_id":"","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User","site_admin":false},"repo":{"id":89949282,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk0OTI4Mg==","name":"liferay-portal","full_name":"gamerson/liferay-portal","owner":{"login":"gamerson","id":595221,"node_id":"MDQ6VXNlcjU5NTIyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/595221?v=4","gravatar_id":"","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gamerson/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/gamerson/liferay-portal","forks_url":"https://api.github.com/repos/gamerson/liferay-portal/forks","keys_url":"https://api.github.com/repos/gamerson/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamerson/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamerson/liferay-portal/teams","hooks_url":"https://api.github.com/repos/gamerson/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/gamerson/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/gamerson/liferay-portal/events","assignees_url":"https://api.github.com/repos/gamerson/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/gamerson/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/gamerson/liferay-portal/tags","blobs_url":"https://api.github.com/repos/gamerson/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamerson/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamerson/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamerson/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamerson/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/gamerson/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/gamerson/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/gamerson/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/gamerson/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/gamerson/liferay-portal/subscription","commits_url":"https://api.github.com/repos/gamerson/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamerson/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamerson/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamerson/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/gamerson/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/gamerson/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamerson/liferay-portal/merges","archive_url":"https://api.github.com/repos/gamerson/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamerson/liferay-portal/downloads","issues_url":"https://api.github.com/repos/gamerson/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/gamerson/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/gamerson/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/gamerson/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamerson/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/gamerson/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/gamerson/liferay-portal/deployments","created_at":"2017-05-01T18:10:45Z","updated_at":"2018-07-31T14:25:03Z","pushed_at":"2018-07-31T14:26:55Z","git_url":"git://github.com/gamerson/liferay-portal.git","ssh_url":"git@github.com:gamerson/liferay-portal.git","clone_url":"https://github.com/gamerson/liferay-portal.git","svn_url":"https://github.com/gamerson/liferay-portal","homepage":"http://liferay.com","size":12749339,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Ithildir:master","ref":"master","sha":"f14524a6cf1911e14601f8f52d91bedb0a620a48","user":{"login":"Ithildir","id":1327160,"node_id":"MDQ6VXNlcjEzMjcxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1327160?v=4","gravatar_id":"","url":"https://api.github.com/users/Ithildir","html_url":"https://github.com/Ithildir","followers_url":"https://api.github.com/users/Ithildir/followers","following_url":"https://api.github.com/users/Ithildir/following{/other_user}","gists_url":"https://api.github.com/users/Ithildir/gists{/gist_id}","starred_url":"https://api.github.com/users/Ithildir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ithildir/subscriptions","organizations_url":"https://api.github.com/users/Ithildir/orgs","repos_url":"https://api.github.com/users/Ithildir/repos","events_url":"https://api.github.com/users/Ithildir/events{/privacy}","received_events_url":"https://api.github.com/users/Ithildir/received_events","type":"User","site_admin":false},"repo":{"id":10120998,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyMDk5OA==","name":"liferay-portal","full_name":"Ithildir/liferay-portal","owner":{"login":"Ithildir","id":1327160,"node_id":"MDQ6VXNlcjEzMjcxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1327160?v=4","gravatar_id":"","url":"https://api.github.com/users/Ithildir","html_url":"https://github.com/Ithildir","followers_url":"https://api.github.com/users/Ithildir/followers","following_url":"https://api.github.com/users/Ithildir/following{/other_user}","gists_url":"https://api.github.com/users/Ithildir/gists{/gist_id}","starred_url":"https://api.github.com/users/Ithildir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ithildir/subscriptions","organizations_url":"https://api.github.com/users/Ithildir/orgs","repos_url":"https://api.github.com/users/Ithildir/repos","events_url":"https://api.github.com/users/Ithildir/events{/privacy}","received_events_url":"https://api.github.com/users/Ithildir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ithildir/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/Ithildir/liferay-portal","forks_url":"https://api.github.com/repos/Ithildir/liferay-portal/forks","keys_url":"https://api.github.com/repos/Ithildir/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ithildir/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ithildir/liferay-portal/teams","hooks_url":"https://api.github.com/repos/Ithildir/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/Ithildir/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/Ithildir/liferay-portal/events","assignees_url":"https://api.github.com/repos/Ithildir/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/Ithildir/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/Ithildir/liferay-portal/tags","blobs_url":"https://api.github.com/repos/Ithildir/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ithildir/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ithildir/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ithildir/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ithildir/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/Ithildir/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/Ithildir/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/Ithildir/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/Ithildir/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/Ithildir/liferay-portal/subscription","commits_url":"https://api.github.com/repos/Ithildir/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ithildir/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ithildir/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ithildir/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ithildir/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/Ithildir/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ithildir/liferay-portal/merges","archive_url":"https://api.github.com/repos/Ithildir/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ithildir/liferay-portal/downloads","issues_url":"https://api.github.com/repos/Ithildir/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/Ithildir/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/Ithildir/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/Ithildir/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ithildir/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/Ithildir/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/Ithildir/liferay-portal/deployments","created_at":"2013-05-17T10:21:53Z","updated_at":"2018-07-31T15:04:24Z","pushed_at":"2018-07-31T15:01:44Z","git_url":"git://github.com/Ithildir/liferay-portal.git","ssh_url":"git@github.com:Ithildir/liferay-portal.git","clone_url":"https://github.com/Ithildir/liferay-portal.git","svn_url":"https://github.com/Ithildir/liferay-portal","homepage":"http://liferay.com","size":12739889,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079"},"html":{"href":"https://github.com/Ithildir/liferay-portal/pull/1079"},"issue":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/issues/1079"},"comments":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/issues/1079/comments"},"review_comments":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079/comments"},"review_comment":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/pulls/1079/commits"},"statuses":{"href":"https://api.github.com/repos/Ithildir/liferay-portal/statuses/9e1821b9dd4506a0d7399d6616990440544fc745"}},"author_association":"NONE"}}
{"actor":{"display_login":"Ithildir"}}