{"action":"created","issue":{"url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar/issues/332","repository_url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar","labels_url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar/issues/332/comments","events_url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar/issues/332/events","html_url":"https://github.com/Pylons/pyramid_debugtoolbar/pull/332","id":325769486,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMDI0NTc1","number":332,"title":"show some post-data if possible","user":{"login":"jvanasco","id":204779,"node_id":"MDQ6VXNlcjIwNDc3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/204779?v=4","gravatar_id":"","url":"https://api.github.com/users/jvanasco","html_url":"https://github.com/jvanasco","followers_url":"https://api.github.com/users/jvanasco/followers","following_url":"https://api.github.com/users/jvanasco/following{/other_user}","gists_url":"https://api.github.com/users/jvanasco/gists{/gist_id}","starred_url":"https://api.github.com/users/jvanasco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvanasco/subscriptions","organizations_url":"https://api.github.com/users/jvanasco/orgs","repos_url":"https://api.github.com/users/jvanasco/repos","events_url":"https://api.github.com/users/jvanasco/events{/privacy}","received_events_url":"https://api.github.com/users/jvanasco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-23T15:52:42Z","updated_at":"2018-07-28T20:12:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar/pulls/332","html_url":"https://github.com/Pylons/pyramid_debugtoolbar/pull/332","diff_url":"https://github.com/Pylons/pyramid_debugtoolbar/pull/332.diff","patch_url":"https://github.com/Pylons/pyramid_debugtoolbar/pull/332.patch"},"body":"I went a bit crazy trying to debug a LetsEncrypt client with a fake-endpoint I put together via Pyramid.\r\n\r\nThe problem was in two parts:\r\n\r\n1. the `acme` spec doesn't POST with KV pairs, but with the encoded payload as the entire body.\r\n2. the debugtoolbar sows \"No POST Data\" when it means \"No POST Variables\".  Only parsed k/v pairs are consulted.\r\n\r\nThis suggestion simply populates `post_raw` with the first 4096 chars of the post data *as a fallback* if there are no k/v pairs present.  I limited it to 4096, so a file upload doesn't takeover the screen.\r\n\r\nThe result is \"No Post Data\" is now replaced with the data which was actually posted."},"comment":{"url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar/issues/comments/408632226","html_url":"https://github.com/Pylons/pyramid_debugtoolbar/pull/332#issuecomment-408632226","issue_url":"https://api.github.com/repos/Pylons/pyramid_debugtoolbar/issues/332","id":408632226,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODYzMjIyNg==","user":{"login":"mmerickel","id":487237,"node_id":"MDQ6VXNlcjQ4NzIzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/487237?v=4","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T20:12:38Z","updated_at":"2018-07-28T20:12:38Z","author_association":"MEMBER","body":"You could probably check `request.content_length` prior to accessing `request.POST` at least as a first step to avoid huge iterations"}}
{"actor":{"display_login":"mmerickel"}}