{"action":"created","comment":{"url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments/215728627","pull_request_review_id":153051236,"id":215728627,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTcyODYyNw==","diff_hunk":"@@ -99,6 +100,7 @@ class Image : public GenericMessage {\n   Image& operator=(Image&& other) noexcept {\n     if (this != std::addressof(other)) {\n       std::lock_guard<std::mutex> lock{mutex_};\n+      std::lock_guard<std::mutex> other_lock{other.mutex_};","path":"msgs/include/simple_msgs/image.hpp","position":21,"original_position":21,"commit_id":"a436f35b2567e9a341739ce3e53db201230eb3d5","original_commit_id":"a436f35b2567e9a341739ce3e53db201230eb3d5","user":{"login":"TheHugeManatee","id":2657288,"node_id":"MDQ6VXNlcjI2NTcyODg=","avatar_url":"https://avatars2.githubusercontent.com/u/2657288?v=4","gravatar_id":"","url":"https://api.github.com/users/TheHugeManatee","html_url":"https://github.com/TheHugeManatee","followers_url":"https://api.github.com/users/TheHugeManatee/followers","following_url":"https://api.github.com/users/TheHugeManatee/following{/other_user}","gists_url":"https://api.github.com/users/TheHugeManatee/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHugeManatee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHugeManatee/subscriptions","organizations_url":"https://api.github.com/users/TheHugeManatee/orgs","repos_url":"https://api.github.com/users/TheHugeManatee/repos","events_url":"https://api.github.com/users/TheHugeManatee/events{/privacy}","received_events_url":"https://api.github.com/users/TheHugeManatee/received_events","type":"User","site_admin":false},"body":"Same issue as before, use std::lock here","created_at":"2018-09-06T18:19:20Z","updated_at":"2018-09-06T18:57:43Z","html_url":"https://github.com/IFL-CAMP/simple/pull/39#discussion_r215728627","pull_request_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments/215728627"},"html":{"href":"https://github.com/IFL-CAMP/simple/pull/39#discussion_r215728627"},"pull_request":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39","id":212075087,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDc1MDg3","html_url":"https://github.com/IFL-CAMP/simple/pull/39","diff_url":"https://github.com/IFL-CAMP/simple/pull/39.diff","patch_url":"https://github.com/IFL-CAMP/simple/pull/39.patch","issue_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/39","number":39,"state":"open","locked":false,"title":"Feature/thread safe","user":{"login":"SalvoVirga","id":2053024,"node_id":"MDQ6VXNlcjIwNTMwMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2053024?v=4","gravatar_id":"","url":"https://api.github.com/users/SalvoVirga","html_url":"https://github.com/SalvoVirga","followers_url":"https://api.github.com/users/SalvoVirga/followers","following_url":"https://api.github.com/users/SalvoVirga/following{/other_user}","gists_url":"https://api.github.com/users/SalvoVirga/gists{/gist_id}","starred_url":"https://api.github.com/users/SalvoVirga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalvoVirga/subscriptions","organizations_url":"https://api.github.com/users/SalvoVirga/orgs","repos_url":"https://api.github.com/users/SalvoVirga/repos","events_url":"https://api.github.com/users/SalvoVirga/events{/privacy}","received_events_url":"https://api.github.com/users/SalvoVirga/received_events","type":"User","site_admin":false},"body":"simple_msgs are sockets are now thread safe","created_at":"2018-08-30T13:15:23Z","updated_at":"2018-09-06T18:57:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06981e09c64a7d3d75b140c55fc0951f464d3d98","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fernandalangsch","id":23321719,"node_id":"MDQ6VXNlcjIzMzIxNzE5","avatar_url":"https://avatars3.githubusercontent.com/u/23321719?v=4","gravatar_id":"","url":"https://api.github.com/users/fernandalangsch","html_url":"https://github.com/fernandalangsch","followers_url":"https://api.github.com/users/fernandalangsch/followers","following_url":"https://api.github.com/users/fernandalangsch/following{/other_user}","gists_url":"https://api.github.com/users/fernandalangsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandalangsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandalangsch/subscriptions","organizations_url":"https://api.github.com/users/fernandalangsch/orgs","repos_url":"https://api.github.com/users/fernandalangsch/repos","events_url":"https://api.github.com/users/fernandalangsch/events{/privacy}","received_events_url":"https://api.github.com/users/fernandalangsch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39/commits","review_comments_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39/comments","review_comment_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/39/comments","statuses_url":"https://api.github.com/repos/IFL-CAMP/simple/statuses/a436f35b2567e9a341739ce3e53db201230eb3d5","head":{"label":"IFL-CAMP:feature/ThreadSafe","ref":"feature/ThreadSafe","sha":"a436f35b2567e9a341739ce3e53db201230eb3d5","user":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"repo":{"id":118499715,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTk3MTU=","name":"simple","full_name":"IFL-CAMP/simple","owner":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IFL-CAMP/simple","description":"S.I.M.P.L.E. - Smart Intuitive Messaging Platform with Less Effort. A Cross-Platform C++ Library to Exchange Data Across Network.","fork":false,"url":"https://api.github.com/repos/IFL-CAMP/simple","forks_url":"https://api.github.com/repos/IFL-CAMP/simple/forks","keys_url":"https://api.github.com/repos/IFL-CAMP/simple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IFL-CAMP/simple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IFL-CAMP/simple/teams","hooks_url":"https://api.github.com/repos/IFL-CAMP/simple/hooks","issue_events_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/events{/number}","events_url":"https://api.github.com/repos/IFL-CAMP/simple/events","assignees_url":"https://api.github.com/repos/IFL-CAMP/simple/assignees{/user}","branches_url":"https://api.github.com/repos/IFL-CAMP/simple/branches{/branch}","tags_url":"https://api.github.com/repos/IFL-CAMP/simple/tags","blobs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IFL-CAMP/simple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/refs{/sha}","trees_url":"https://api.github.com/repos/IFL-CAMP/simple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IFL-CAMP/simple/statuses/{sha}","languages_url":"https://api.github.com/repos/IFL-CAMP/simple/languages","stargazers_url":"https://api.github.com/repos/IFL-CAMP/simple/stargazers","contributors_url":"https://api.github.com/repos/IFL-CAMP/simple/contributors","subscribers_url":"https://api.github.com/repos/IFL-CAMP/simple/subscribers","subscription_url":"https://api.github.com/repos/IFL-CAMP/simple/subscription","commits_url":"https://api.github.com/repos/IFL-CAMP/simple/commits{/sha}","git_commits_url":"https://api.github.com/repos/IFL-CAMP/simple/git/commits{/sha}","comments_url":"https://api.github.com/repos/IFL-CAMP/simple/comments{/number}","issue_comment_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/comments{/number}","contents_url":"https://api.github.com/repos/IFL-CAMP/simple/contents/{+path}","compare_url":"https://api.github.com/repos/IFL-CAMP/simple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IFL-CAMP/simple/merges","archive_url":"https://api.github.com/repos/IFL-CAMP/simple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IFL-CAMP/simple/downloads","issues_url":"https://api.github.com/repos/IFL-CAMP/simple/issues{/number}","pulls_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls{/number}","milestones_url":"https://api.github.com/repos/IFL-CAMP/simple/milestones{/number}","notifications_url":"https://api.github.com/repos/IFL-CAMP/simple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IFL-CAMP/simple/labels{/name}","releases_url":"https://api.github.com/repos/IFL-CAMP/simple/releases{/id}","deployments_url":"https://api.github.com/repos/IFL-CAMP/simple/deployments","created_at":"2018-01-22T18:47:06Z","updated_at":"2018-09-05T14:16:49Z","pushed_at":"2018-09-03T19:25:45Z","git_url":"git://github.com/IFL-CAMP/simple.git","ssh_url":"git@github.com:IFL-CAMP/simple.git","clone_url":"https://github.com/IFL-CAMP/simple.git","svn_url":"https://github.com/IFL-CAMP/simple","homepage":"","size":24258,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":3,"watchers":9,"default_branch":"master"}},"base":{"label":"IFL-CAMP:master","ref":"master","sha":"a61a15e9a6457f7f26c63ba1b1f5811c6337525c","user":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"repo":{"id":118499715,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTk3MTU=","name":"simple","full_name":"IFL-CAMP/simple","owner":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IFL-CAMP/simple","description":"S.I.M.P.L.E. - Smart Intuitive Messaging Platform with Less Effort. A Cross-Platform C++ Library to Exchange Data Across Network.","fork":false,"url":"https://api.github.com/repos/IFL-CAMP/simple","forks_url":"https://api.github.com/repos/IFL-CAMP/simple/forks","keys_url":"https://api.github.com/repos/IFL-CAMP/simple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IFL-CAMP/simple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IFL-CAMP/simple/teams","hooks_url":"https://api.github.com/repos/IFL-CAMP/simple/hooks","issue_events_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/events{/number}","events_url":"https://api.github.com/repos/IFL-CAMP/simple/events","assignees_url":"https://api.github.com/repos/IFL-CAMP/simple/assignees{/user}","branches_url":"https://api.github.com/repos/IFL-CAMP/simple/branches{/branch}","tags_url":"https://api.github.com/repos/IFL-CAMP/simple/tags","blobs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IFL-CAMP/simple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/refs{/sha}","trees_url":"https://api.github.com/repos/IFL-CAMP/simple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IFL-CAMP/simple/statuses/{sha}","languages_url":"https://api.github.com/repos/IFL-CAMP/simple/languages","stargazers_url":"https://api.github.com/repos/IFL-CAMP/simple/stargazers","contributors_url":"https://api.github.com/repos/IFL-CAMP/simple/contributors","subscribers_url":"https://api.github.com/repos/IFL-CAMP/simple/subscribers","subscription_url":"https://api.github.com/repos/IFL-CAMP/simple/subscription","commits_url":"https://api.github.com/repos/IFL-CAMP/simple/commits{/sha}","git_commits_url":"https://api.github.com/repos/IFL-CAMP/simple/git/commits{/sha}","comments_url":"https://api.github.com/repos/IFL-CAMP/simple/comments{/number}","issue_comment_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/comments{/number}","contents_url":"https://api.github.com/repos/IFL-CAMP/simple/contents/{+path}","compare_url":"https://api.github.com/repos/IFL-CAMP/simple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IFL-CAMP/simple/merges","archive_url":"https://api.github.com/repos/IFL-CAMP/simple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IFL-CAMP/simple/downloads","issues_url":"https://api.github.com/repos/IFL-CAMP/simple/issues{/number}","pulls_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls{/number}","milestones_url":"https://api.github.com/repos/IFL-CAMP/simple/milestones{/number}","notifications_url":"https://api.github.com/repos/IFL-CAMP/simple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IFL-CAMP/simple/labels{/name}","releases_url":"https://api.github.com/repos/IFL-CAMP/simple/releases{/id}","deployments_url":"https://api.github.com/repos/IFL-CAMP/simple/deployments","created_at":"2018-01-22T18:47:06Z","updated_at":"2018-09-05T14:16:49Z","pushed_at":"2018-09-03T19:25:45Z","git_url":"git://github.com/IFL-CAMP/simple.git","ssh_url":"git@github.com:IFL-CAMP/simple.git","clone_url":"https://github.com/IFL-CAMP/simple.git","svn_url":"https://github.com/IFL-CAMP/simple","homepage":"","size":24258,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39"},"html":{"href":"https://github.com/IFL-CAMP/simple/pull/39"},"issue":{"href":"https://api.github.com/repos/IFL-CAMP/simple/issues/39"},"comments":{"href":"https://api.github.com/repos/IFL-CAMP/simple/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/IFL-CAMP/simple/statuses/a436f35b2567e9a341739ce3e53db201230eb3d5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TheHugeManatee"}}