{"action":"created","comment":{"url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/comments/221812221","pull_request_review_id":160550988,"id":221812221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTgxMjIyMQ==","diff_hunk":"@@ -119,9 +157,13 @@ module.exports = class BuildCommand {\n \t */\r\n \tsaveLocales(saveBasePath) {\r\n \t\tObject.keys(this.locales).forEach(locale => {\r\n-\t\t\tconst finalPath = path.join(saveBasePath, 'assets', 'i18n', `${locale}.i18n.json`);\r\n-\t\t\tfs.outputJsonSync(finalPath, this.locales[locale]);\r\n-\t\t\tconsole.log(chalk.green(`${finalPath} written successfully`));\r\n+\t\t\tconst OBJ = this.locales[locale];\r\n+\t\t\tObject.keys(OBJ).forEach(key => {\r\n+\t\t\t\tconst FINAL_PATH = path.join(saveBasePath, 'assets', 'i18n', locale, `${key}.i18n.json`);\r","path":"projects/smarti18n/cli/commandBuild.js","position":166,"original_position":166,"commit_id":"4b9b3874038fac32693a8be87983c00f2232ef67","original_commit_id":"4b9b3874038fac32693a8be87983c00f2232ef67","user":{"login":"vertexportus","id":1386617,"node_id":"MDQ6VXNlcjEzODY2MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1386617?v=4","gravatar_id":"","url":"https://api.github.com/users/vertexportus","html_url":"https://github.com/vertexportus","followers_url":"https://api.github.com/users/vertexportus/followers","following_url":"https://api.github.com/users/vertexportus/following{/other_user}","gists_url":"https://api.github.com/users/vertexportus/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexportus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexportus/subscriptions","organizations_url":"https://api.github.com/users/vertexportus/orgs","repos_url":"https://api.github.com/users/vertexportus/repos","events_url":"https://api.github.com/users/vertexportus/events{/privacy}","received_events_url":"https://api.github.com/users/vertexportus/received_events","type":"User","site_admin":false},"body":"same here with obj and final_path","created_at":"2018-10-02T02:40:17Z","updated_at":"2018-10-02T02:41:43Z","html_url":"https://github.com/rafapaulin/smarti18n/pull/41#discussion_r221812221","pull_request_url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/comments/221812221"},"html":{"href":"https://github.com/rafapaulin/smarti18n/pull/41#discussion_r221812221"},"pull_request":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41","id":219569451,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTY5NDUx","html_url":"https://github.com/rafapaulin/smarti18n/pull/41","diff_url":"https://github.com/rafapaulin/smarti18n/pull/41.diff","patch_url":"https://github.com/rafapaulin/smarti18n/pull/41.patch","issue_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues/41","number":41,"state":"open","locked":false,"title":"refactor/CLI - Changed assets folder structure","user":{"login":"rafapaulin","id":13452406,"node_id":"MDQ6VXNlcjEzNDUyNDA2","avatar_url":"https://avatars1.githubusercontent.com/u/13452406?v=4","gravatar_id":"","url":"https://api.github.com/users/rafapaulin","html_url":"https://github.com/rafapaulin","followers_url":"https://api.github.com/users/rafapaulin/followers","following_url":"https://api.github.com/users/rafapaulin/following{/other_user}","gists_url":"https://api.github.com/users/rafapaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/rafapaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafapaulin/subscriptions","organizations_url":"https://api.github.com/users/rafapaulin/orgs","repos_url":"https://api.github.com/users/rafapaulin/repos","events_url":"https://api.github.com/users/rafapaulin/events{/privacy}","received_events_url":"https://api.github.com/users/rafapaulin/received_events","type":"User","site_admin":false},"body":"- Base path must now be set in a (optional) config.i18n.json file on the same folder as the translation files\r\n  - Config can be set in a component-level\r\n  - basePath: String: Sets the namespace of the translation file. Defaults to 'base'\r\n  - loadMode: ['lazy|'eager']: Sets how the translation file should be loaded. Defaults to 'eager'\r\n- Assets folder structure changed to support both eager and lazy loaded translation files\r\n  - All the eager-loaded translation now sits on assets/i18n/{locale}/base.i18n.json\r\n  - All the lazy-loaded translation now sits on assets/i18n/{locale}/{config.basePath}.i18n.json","created_at":"2018-10-02T02:36:33Z","updated_at":"2018-10-02T02:41:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a342357a4e21a4309af3db8a73a227a217880a24","assignee":{"login":"rafapaulin","id":13452406,"node_id":"MDQ6VXNlcjEzNDUyNDA2","avatar_url":"https://avatars1.githubusercontent.com/u/13452406?v=4","gravatar_id":"","url":"https://api.github.com/users/rafapaulin","html_url":"https://github.com/rafapaulin","followers_url":"https://api.github.com/users/rafapaulin/followers","following_url":"https://api.github.com/users/rafapaulin/following{/other_user}","gists_url":"https://api.github.com/users/rafapaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/rafapaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafapaulin/subscriptions","organizations_url":"https://api.github.com/users/rafapaulin/orgs","repos_url":"https://api.github.com/users/rafapaulin/repos","events_url":"https://api.github.com/users/rafapaulin/events{/privacy}","received_events_url":"https://api.github.com/users/rafapaulin/received_events","type":"User","site_admin":false},"assignees":[{"login":"rafapaulin","id":13452406,"node_id":"MDQ6VXNlcjEzNDUyNDA2","avatar_url":"https://avatars1.githubusercontent.com/u/13452406?v=4","gravatar_id":"","url":"https://api.github.com/users/rafapaulin","html_url":"https://github.com/rafapaulin","followers_url":"https://api.github.com/users/rafapaulin/followers","following_url":"https://api.github.com/users/rafapaulin/following{/other_user}","gists_url":"https://api.github.com/users/rafapaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/rafapaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafapaulin/subscriptions","organizations_url":"https://api.github.com/users/rafapaulin/orgs","repos_url":"https://api.github.com/users/rafapaulin/repos","events_url":"https://api.github.com/users/rafapaulin/events{/privacy}","received_events_url":"https://api.github.com/users/rafapaulin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1076212703,"node_id":"MDU6TGFiZWwxMDc2MjEyNzAz","url":"https://api.github.com/repos/rafapaulin/smarti18n/labels/Refactor","name":"Refactor","color":"b55a0a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41/commits","review_comments_url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41/comments","review_comment_url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues/41/comments","statuses_url":"https://api.github.com/repos/rafapaulin/smarti18n/statuses/4b9b3874038fac32693a8be87983c00f2232ef67","head":{"label":"rafapaulin:refactor/CLI","ref":"refactor/CLI","sha":"4b9b3874038fac32693a8be87983c00f2232ef67","user":{"login":"rafapaulin","id":13452406,"node_id":"MDQ6VXNlcjEzNDUyNDA2","avatar_url":"https://avatars1.githubusercontent.com/u/13452406?v=4","gravatar_id":"","url":"https://api.github.com/users/rafapaulin","html_url":"https://github.com/rafapaulin","followers_url":"https://api.github.com/users/rafapaulin/followers","following_url":"https://api.github.com/users/rafapaulin/following{/other_user}","gists_url":"https://api.github.com/users/rafapaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/rafapaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafapaulin/subscriptions","organizations_url":"https://api.github.com/users/rafapaulin/orgs","repos_url":"https://api.github.com/users/rafapaulin/repos","events_url":"https://api.github.com/users/rafapaulin/events{/privacy}","received_events_url":"https://api.github.com/users/rafapaulin/received_events","type":"User","site_admin":false},"repo":{"id":140326311,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjYzMTE=","name":"smarti18n","full_name":"rafapaulin/smarti18n","private":false,"owner":{"login":"rafapaulin","id":13452406,"node_id":"MDQ6VXNlcjEzNDUyNDA2","avatar_url":"https://avatars1.githubusercontent.com/u/13452406?v=4","gravatar_id":"","url":"https://api.github.com/users/rafapaulin","html_url":"https://github.com/rafapaulin","followers_url":"https://api.github.com/users/rafapaulin/followers","following_url":"https://api.github.com/users/rafapaulin/following{/other_user}","gists_url":"https://api.github.com/users/rafapaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/rafapaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafapaulin/subscriptions","organizations_url":"https://api.github.com/users/rafapaulin/orgs","repos_url":"https://api.github.com/users/rafapaulin/repos","events_url":"https://api.github.com/users/rafapaulin/events{/privacy}","received_events_url":"https://api.github.com/users/rafapaulin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rafapaulin/smarti18n","description":"A smart i18n lib for Angular","fork":false,"url":"https://api.github.com/repos/rafapaulin/smarti18n","forks_url":"https://api.github.com/repos/rafapaulin/smarti18n/forks","keys_url":"https://api.github.com/repos/rafapaulin/smarti18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafapaulin/smarti18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafapaulin/smarti18n/teams","hooks_url":"https://api.github.com/repos/rafapaulin/smarti18n/hooks","issue_events_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues/events{/number}","events_url":"https://api.github.com/repos/rafapaulin/smarti18n/events","assignees_url":"https://api.github.com/repos/rafapaulin/smarti18n/assignees{/user}","branches_url":"https://api.github.com/repos/rafapaulin/smarti18n/branches{/branch}","tags_url":"https://api.github.com/repos/rafapaulin/smarti18n/tags","blobs_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafapaulin/smarti18n/statuses/{sha}","languages_url":"https://api.github.com/repos/rafapaulin/smarti18n/languages","stargazers_url":"https://api.github.com/repos/rafapaulin/smarti18n/stargazers","contributors_url":"https://api.github.com/repos/rafapaulin/smarti18n/contributors","subscribers_url":"https://api.github.com/repos/rafapaulin/smarti18n/subscribers","subscription_url":"https://api.github.com/repos/rafapaulin/smarti18n/subscription","commits_url":"https://api.github.com/repos/rafapaulin/smarti18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafapaulin/smarti18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafapaulin/smarti18n/contents/{+path}","compare_url":"https://api.github.com/repos/rafapaulin/smarti18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafapaulin/smarti18n/merges","archive_url":"https://api.github.com/repos/rafapaulin/smarti18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafapaulin/smarti18n/downloads","issues_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues{/number}","pulls_url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls{/number}","milestones_url":"https://api.github.com/repos/rafapaulin/smarti18n/milestones{/number}","notifications_url":"https://api.github.com/repos/rafapaulin/smarti18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafapaulin/smarti18n/labels{/name}","releases_url":"https://api.github.com/repos/rafapaulin/smarti18n/releases{/id}","deployments_url":"https://api.github.com/repos/rafapaulin/smarti18n/deployments","created_at":"2018-07-09T18:25:51Z","updated_at":"2018-08-16T14:29:08Z","pushed_at":"2018-10-02T02:36:34Z","git_url":"git://github.com/rafapaulin/smarti18n.git","ssh_url":"git@github.com:rafapaulin/smarti18n.git","clone_url":"https://github.com/rafapaulin/smarti18n.git","svn_url":"https://github.com/rafapaulin/smarti18n","homepage":null,"size":384,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"base":{"label":"rafapaulin:develop","ref":"develop","sha":"28e4416a4d2dc7f7be3ba7d4ff174e5f9717b2a4","user":{"login":"rafapaulin","id":13452406,"node_id":"MDQ6VXNlcjEzNDUyNDA2","avatar_url":"https://avatars1.githubusercontent.com/u/13452406?v=4","gravatar_id":"","url":"https://api.github.com/users/rafapaulin","html_url":"https://github.com/rafapaulin","followers_url":"https://api.github.com/users/rafapaulin/followers","following_url":"https://api.github.com/users/rafapaulin/following{/other_user}","gists_url":"https://api.github.com/users/rafapaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/rafapaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafapaulin/subscriptions","organizations_url":"https://api.github.com/users/rafapaulin/orgs","repos_url":"https://api.github.com/users/rafapaulin/repos","events_url":"https://api.github.com/users/rafapaulin/events{/privacy}","received_events_url":"https://api.github.com/users/rafapaulin/received_events","type":"User","site_admin":false},"repo":{"id":140326311,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjYzMTE=","name":"smarti18n","full_name":"rafapaulin/smarti18n","private":false,"owner":{"login":"rafapaulin","id":13452406,"node_id":"MDQ6VXNlcjEzNDUyNDA2","avatar_url":"https://avatars1.githubusercontent.com/u/13452406?v=4","gravatar_id":"","url":"https://api.github.com/users/rafapaulin","html_url":"https://github.com/rafapaulin","followers_url":"https://api.github.com/users/rafapaulin/followers","following_url":"https://api.github.com/users/rafapaulin/following{/other_user}","gists_url":"https://api.github.com/users/rafapaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/rafapaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafapaulin/subscriptions","organizations_url":"https://api.github.com/users/rafapaulin/orgs","repos_url":"https://api.github.com/users/rafapaulin/repos","events_url":"https://api.github.com/users/rafapaulin/events{/privacy}","received_events_url":"https://api.github.com/users/rafapaulin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rafapaulin/smarti18n","description":"A smart i18n lib for Angular","fork":false,"url":"https://api.github.com/repos/rafapaulin/smarti18n","forks_url":"https://api.github.com/repos/rafapaulin/smarti18n/forks","keys_url":"https://api.github.com/repos/rafapaulin/smarti18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafapaulin/smarti18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafapaulin/smarti18n/teams","hooks_url":"https://api.github.com/repos/rafapaulin/smarti18n/hooks","issue_events_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues/events{/number}","events_url":"https://api.github.com/repos/rafapaulin/smarti18n/events","assignees_url":"https://api.github.com/repos/rafapaulin/smarti18n/assignees{/user}","branches_url":"https://api.github.com/repos/rafapaulin/smarti18n/branches{/branch}","tags_url":"https://api.github.com/repos/rafapaulin/smarti18n/tags","blobs_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafapaulin/smarti18n/statuses/{sha}","languages_url":"https://api.github.com/repos/rafapaulin/smarti18n/languages","stargazers_url":"https://api.github.com/repos/rafapaulin/smarti18n/stargazers","contributors_url":"https://api.github.com/repos/rafapaulin/smarti18n/contributors","subscribers_url":"https://api.github.com/repos/rafapaulin/smarti18n/subscribers","subscription_url":"https://api.github.com/repos/rafapaulin/smarti18n/subscription","commits_url":"https://api.github.com/repos/rafapaulin/smarti18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafapaulin/smarti18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafapaulin/smarti18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafapaulin/smarti18n/contents/{+path}","compare_url":"https://api.github.com/repos/rafapaulin/smarti18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafapaulin/smarti18n/merges","archive_url":"https://api.github.com/repos/rafapaulin/smarti18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafapaulin/smarti18n/downloads","issues_url":"https://api.github.com/repos/rafapaulin/smarti18n/issues{/number}","pulls_url":"https://api.github.com/repos/rafapaulin/smarti18n/pulls{/number}","milestones_url":"https://api.github.com/repos/rafapaulin/smarti18n/milestones{/number}","notifications_url":"https://api.github.com/repos/rafapaulin/smarti18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafapaulin/smarti18n/labels{/name}","releases_url":"https://api.github.com/repos/rafapaulin/smarti18n/releases{/id}","deployments_url":"https://api.github.com/repos/rafapaulin/smarti18n/deployments","created_at":"2018-07-09T18:25:51Z","updated_at":"2018-08-16T14:29:08Z","pushed_at":"2018-10-02T02:36:34Z","git_url":"git://github.com/rafapaulin/smarti18n.git","ssh_url":"git@github.com:rafapaulin/smarti18n.git","clone_url":"https://github.com/rafapaulin/smarti18n.git","svn_url":"https://github.com/rafapaulin/smarti18n","homepage":null,"size":384,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41"},"html":{"href":"https://github.com/rafapaulin/smarti18n/pull/41"},"issue":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/issues/41"},"comments":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/rafapaulin/smarti18n/statuses/4b9b3874038fac32693a8be87983c00f2232ef67"}},"author_association":"OWNER"}}
{"actor":{"display_login":"vertexportus"}}