{"action":"created","comment":{"url":"https://api.github.com/repos/rusefi/rusefi/pulls/comments/208773139","pull_request_review_id":144652646,"id":208773139,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODc3MzEzOQ==","diff_hunk":"@@ -290,8 +290,19 @@ static void cjStart(void) {\n \t\treturn;\n \t}\n \t\n+\t// Software reset cj125\n+\tfor (int i = 0; i < 2; i++)","path":"firmware/hw_layer/sensors/CJ125.cpp","position":57,"original_position":5,"commit_id":"da4ac9cb85d018e960f6967822dea7967d6ce0be","original_commit_id":"35897208f5685b2b9ec120dfb0ab71682ae88364","user":{"login":"mck1117","id":568254,"node_id":"MDQ6VXNlcjU2ODI1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/568254?v=4","gravatar_id":"","url":"https://api.github.com/users/mck1117","html_url":"https://github.com/mck1117","followers_url":"https://api.github.com/users/mck1117/followers","following_url":"https://api.github.com/users/mck1117/following{/other_user}","gists_url":"https://api.github.com/users/mck1117/gists{/gist_id}","starred_url":"https://api.github.com/users/mck1117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mck1117/subscriptions","organizations_url":"https://api.github.com/users/mck1117/orgs","repos_url":"https://api.github.com/users/mck1117/repos","events_url":"https://api.github.com/users/mck1117/events{/privacy}","received_events_url":"https://api.github.com/users/mck1117/received_events","type":"User","site_admin":false},"body":"The problem I was trying to get around here is that the SPI controller seemed to be sending a garbage first byte, which confused the cj125.  The first reset comes out as garbage, and the second resets it and puts it in a predictable (ie normal) state.  I should sort that out more completely before this is merged.","created_at":"2018-08-09T00:08:43Z","updated_at":"2018-08-09T00:08:43Z","html_url":"https://github.com/rusefi/rusefi/pull/602#discussion_r208773139","pull_request_url":"https://api.github.com/repos/rusefi/rusefi/pulls/602","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rusefi/rusefi/pulls/comments/208773139"},"html":{"href":"https://github.com/rusefi/rusefi/pull/602#discussion_r208773139"},"pull_request":{"href":"https://api.github.com/repos/rusefi/rusefi/pulls/602"}},"in_reply_to_id":208772597},"pull_request":{"url":"https://api.github.com/repos/rusefi/rusefi/pulls/602","id":205624142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjI0MTQy","html_url":"https://github.com/rusefi/rusefi/pull/602","diff_url":"https://github.com/rusefi/rusefi/pull/602.diff","patch_url":"https://github.com/rusefi/rusefi/pull/602.patch","issue_url":"https://api.github.com/repos/rusefi/rusefi/issues/602","number":602,"state":"open","locked":false,"title":"Cj125 Improvements","user":{"login":"mck1117","id":568254,"node_id":"MDQ6VXNlcjU2ODI1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/568254?v=4","gravatar_id":"","url":"https://api.github.com/users/mck1117","html_url":"https://github.com/mck1117","followers_url":"https://api.github.com/users/mck1117/followers","following_url":"https://api.github.com/users/mck1117/following{/other_user}","gists_url":"https://api.github.com/users/mck1117/gists{/gist_id}","starred_url":"https://api.github.com/users/mck1117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mck1117/subscriptions","organizations_url":"https://api.github.com/users/mck1117/orgs","repos_url":"https://api.github.com/users/mck1117/repos","events_url":"https://api.github.com/users/mck1117/events{/privacy}","received_events_url":"https://api.github.com/users/mck1117/received_events","type":"User","site_admin":false},"body":"1) Rework state machine to function correctly, and greatly improve readability.\r\n2) Add missing cases to switch statements\r\n3) Add configuration for LSU 4.2 vs 4.9.  Sets default PID constants, selects correct lookup table.\r\n\r\nNote that this does not fix whatever weird SPI issues I was having, which requires further investigation.","created_at":"2018-08-02T05:43:39Z","updated_at":"2018-08-09T00:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dd0ec59cb4301c7747f1db5a8f950039ff7baf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rusefi/rusefi/pulls/602/commits","review_comments_url":"https://api.github.com/repos/rusefi/rusefi/pulls/602/comments","review_comment_url":"https://api.github.com/repos/rusefi/rusefi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rusefi/rusefi/issues/602/comments","statuses_url":"https://api.github.com/repos/rusefi/rusefi/statuses/da4ac9cb85d018e960f6967822dea7967d6ce0be","head":{"label":"mck1117:cj125-pr2","ref":"cj125-pr2","sha":"da4ac9cb85d018e960f6967822dea7967d6ce0be","user":{"login":"mck1117","id":568254,"node_id":"MDQ6VXNlcjU2ODI1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/568254?v=4","gravatar_id":"","url":"https://api.github.com/users/mck1117","html_url":"https://github.com/mck1117","followers_url":"https://api.github.com/users/mck1117/followers","following_url":"https://api.github.com/users/mck1117/following{/other_user}","gists_url":"https://api.github.com/users/mck1117/gists{/gist_id}","starred_url":"https://api.github.com/users/mck1117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mck1117/subscriptions","organizations_url":"https://api.github.com/users/mck1117/orgs","repos_url":"https://api.github.com/users/mck1117/repos","events_url":"https://api.github.com/users/mck1117/events{/privacy}","received_events_url":"https://api.github.com/users/mck1117/received_events","type":"User","site_admin":false},"repo":{"id":81761498,"node_id":"MDEwOlJlcG9zaXRvcnk4MTc2MTQ5OA==","name":"rusefi","full_name":"mck1117/rusefi","owner":{"login":"mck1117","id":568254,"node_id":"MDQ6VXNlcjU2ODI1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/568254?v=4","gravatar_id":"","url":"https://api.github.com/users/mck1117","html_url":"https://github.com/mck1117","followers_url":"https://api.github.com/users/mck1117/followers","following_url":"https://api.github.com/users/mck1117/following{/other_user}","gists_url":"https://api.github.com/users/mck1117/gists{/gist_id}","starred_url":"https://api.github.com/users/mck1117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mck1117/subscriptions","organizations_url":"https://api.github.com/users/mck1117/orgs","repos_url":"https://api.github.com/users/mck1117/repos","events_url":"https://api.github.com/users/mck1117/events{/privacy}","received_events_url":"https://api.github.com/users/mck1117/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mck1117/rusefi","description":"Hourly snapshots of rusefi@SF - open source engine control unit","fork":true,"url":"https://api.github.com/repos/mck1117/rusefi","forks_url":"https://api.github.com/repos/mck1117/rusefi/forks","keys_url":"https://api.github.com/repos/mck1117/rusefi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mck1117/rusefi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mck1117/rusefi/teams","hooks_url":"https://api.github.com/repos/mck1117/rusefi/hooks","issue_events_url":"https://api.github.com/repos/mck1117/rusefi/issues/events{/number}","events_url":"https://api.github.com/repos/mck1117/rusefi/events","assignees_url":"https://api.github.com/repos/mck1117/rusefi/assignees{/user}","branches_url":"https://api.github.com/repos/mck1117/rusefi/branches{/branch}","tags_url":"https://api.github.com/repos/mck1117/rusefi/tags","blobs_url":"https://api.github.com/repos/mck1117/rusefi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mck1117/rusefi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mck1117/rusefi/git/refs{/sha}","trees_url":"https://api.github.com/repos/mck1117/rusefi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mck1117/rusefi/statuses/{sha}","languages_url":"https://api.github.com/repos/mck1117/rusefi/languages","stargazers_url":"https://api.github.com/repos/mck1117/rusefi/stargazers","contributors_url":"https://api.github.com/repos/mck1117/rusefi/contributors","subscribers_url":"https://api.github.com/repos/mck1117/rusefi/subscribers","subscription_url":"https://api.github.com/repos/mck1117/rusefi/subscription","commits_url":"https://api.github.com/repos/mck1117/rusefi/commits{/sha}","git_commits_url":"https://api.github.com/repos/mck1117/rusefi/git/commits{/sha}","comments_url":"https://api.github.com/repos/mck1117/rusefi/comments{/number}","issue_comment_url":"https://api.github.com/repos/mck1117/rusefi/issues/comments{/number}","contents_url":"https://api.github.com/repos/mck1117/rusefi/contents/{+path}","compare_url":"https://api.github.com/repos/mck1117/rusefi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mck1117/rusefi/merges","archive_url":"https://api.github.com/repos/mck1117/rusefi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mck1117/rusefi/downloads","issues_url":"https://api.github.com/repos/mck1117/rusefi/issues{/number}","pulls_url":"https://api.github.com/repos/mck1117/rusefi/pulls{/number}","milestones_url":"https://api.github.com/repos/mck1117/rusefi/milestones{/number}","notifications_url":"https://api.github.com/repos/mck1117/rusefi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mck1117/rusefi/labels{/name}","releases_url":"https://api.github.com/repos/mck1117/rusefi/releases{/id}","deployments_url":"https://api.github.com/repos/mck1117/rusefi/deployments","created_at":"2017-02-12T22:16:15Z","updated_at":"2018-05-08T00:31:21Z","pushed_at":"2018-08-02T05:04:56Z","git_url":"git://github.com/mck1117/rusefi.git","ssh_url":"git@github.com:mck1117/rusefi.git","clone_url":"https://github.com/mck1117/rusefi.git","svn_url":"https://github.com/mck1117/rusefi","homepage":"rusefi.com","size":498118,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rusefi:master","ref":"master","sha":"e2a2764f8a61e2408c2a907f958120f65eaf05c5","user":{"login":"rusefi","id":7377949,"node_id":"MDQ6VXNlcjczNzc5NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7377949?v=4","gravatar_id":"","url":"https://api.github.com/users/rusefi","html_url":"https://github.com/rusefi","followers_url":"https://api.github.com/users/rusefi/followers","following_url":"https://api.github.com/users/rusefi/following{/other_user}","gists_url":"https://api.github.com/users/rusefi/gists{/gist_id}","starred_url":"https://api.github.com/users/rusefi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rusefi/subscriptions","organizations_url":"https://api.github.com/users/rusefi/orgs","repos_url":"https://api.github.com/users/rusefi/repos","events_url":"https://api.github.com/users/rusefi/events{/privacy}","received_events_url":"https://api.github.com/users/rusefi/received_events","type":"User","site_admin":false},"repo":{"id":19047649,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA0NzY0OQ==","name":"rusefi","full_name":"rusefi/rusefi","owner":{"login":"rusefi","id":7377949,"node_id":"MDQ6VXNlcjczNzc5NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7377949?v=4","gravatar_id":"","url":"https://api.github.com/users/rusefi","html_url":"https://github.com/rusefi","followers_url":"https://api.github.com/users/rusefi/followers","following_url":"https://api.github.com/users/rusefi/following{/other_user}","gists_url":"https://api.github.com/users/rusefi/gists{/gist_id}","starred_url":"https://api.github.com/users/rusefi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rusefi/subscriptions","organizations_url":"https://api.github.com/users/rusefi/orgs","repos_url":"https://api.github.com/users/rusefi/repos","events_url":"https://api.github.com/users/rusefi/events{/privacy}","received_events_url":"https://api.github.com/users/rusefi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rusefi/rusefi","description":"rusefi - GPL internal combustion engine control unit","fork":false,"url":"https://api.github.com/repos/rusefi/rusefi","forks_url":"https://api.github.com/repos/rusefi/rusefi/forks","keys_url":"https://api.github.com/repos/rusefi/rusefi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rusefi/rusefi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rusefi/rusefi/teams","hooks_url":"https://api.github.com/repos/rusefi/rusefi/hooks","issue_events_url":"https://api.github.com/repos/rusefi/rusefi/issues/events{/number}","events_url":"https://api.github.com/repos/rusefi/rusefi/events","assignees_url":"https://api.github.com/repos/rusefi/rusefi/assignees{/user}","branches_url":"https://api.github.com/repos/rusefi/rusefi/branches{/branch}","tags_url":"https://api.github.com/repos/rusefi/rusefi/tags","blobs_url":"https://api.github.com/repos/rusefi/rusefi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rusefi/rusefi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rusefi/rusefi/git/refs{/sha}","trees_url":"https://api.github.com/repos/rusefi/rusefi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rusefi/rusefi/statuses/{sha}","languages_url":"https://api.github.com/repos/rusefi/rusefi/languages","stargazers_url":"https://api.github.com/repos/rusefi/rusefi/stargazers","contributors_url":"https://api.github.com/repos/rusefi/rusefi/contributors","subscribers_url":"https://api.github.com/repos/rusefi/rusefi/subscribers","subscription_url":"https://api.github.com/repos/rusefi/rusefi/subscription","commits_url":"https://api.github.com/repos/rusefi/rusefi/commits{/sha}","git_commits_url":"https://api.github.com/repos/rusefi/rusefi/git/commits{/sha}","comments_url":"https://api.github.com/repos/rusefi/rusefi/comments{/number}","issue_comment_url":"https://api.github.com/repos/rusefi/rusefi/issues/comments{/number}","contents_url":"https://api.github.com/repos/rusefi/rusefi/contents/{+path}","compare_url":"https://api.github.com/repos/rusefi/rusefi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rusefi/rusefi/merges","archive_url":"https://api.github.com/repos/rusefi/rusefi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rusefi/rusefi/downloads","issues_url":"https://api.github.com/repos/rusefi/rusefi/issues{/number}","pulls_url":"https://api.github.com/repos/rusefi/rusefi/pulls{/number}","milestones_url":"https://api.github.com/repos/rusefi/rusefi/milestones{/number}","notifications_url":"https://api.github.com/repos/rusefi/rusefi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rusefi/rusefi/labels{/name}","releases_url":"https://api.github.com/repos/rusefi/rusefi/releases{/id}","deployments_url":"https://api.github.com/repos/rusefi/rusefi/deployments","created_at":"2014-04-22T21:51:00Z","updated_at":"2018-08-08T23:57:23Z","pushed_at":"2018-08-08T23:57:22Z","git_url":"git://github.com/rusefi/rusefi.git","ssh_url":"git@github.com:rusefi/rusefi.git","clone_url":"https://github.com/rusefi/rusefi.git","svn_url":"https://github.com/rusefi/rusefi","homepage":"http://rusefi.com","size":497856,"stargazers_count":72,"watchers_count":72,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":212,"license":null,"forks":40,"open_issues":212,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rusefi/rusefi/pulls/602"},"html":{"href":"https://github.com/rusefi/rusefi/pull/602"},"issue":{"href":"https://api.github.com/repos/rusefi/rusefi/issues/602"},"comments":{"href":"https://api.github.com/repos/rusefi/rusefi/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/rusefi/rusefi/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/rusefi/rusefi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rusefi/rusefi/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/rusefi/rusefi/statuses/da4ac9cb85d018e960f6967822dea7967d6ce0be"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mck1117"}}