{"action":"created","comment":{"url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/comments/211596176","pull_request_review_id":148047717,"id":211596176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU5NjE3Ng==","diff_hunk":"@@ -5,6 +5,25 @@\n import sys\n from math import exp\n \n+effective_areas = dict(\n+    ea03 = [\n+        (1.000, 0.1440),\n+        (1.479, 0.1562),\n+        (2.000, 0.1032),\n+        (2.200, 0.0859),\n+        (2.300, 0.1116),\n+        (2.400, 0.1321),\n+        (2.500, 0.1654)        \n+        ]\n+)\n+\n+def get_effective_area(eta, area):\n+    eta = abs(eta)\n+    ea_defs = effective_areas[area]\n+    for etamax, ea in ea_defs: \n+        if eta < etamax:\n+            return ea \n+    return ea_defs[-1][1]","path":"PhysicsTools/Heppy/python/physicsobjects/Electron.py","position":22,"original_position":22,"commit_id":"53285b83db582a85d6435ebe48bd2ae01923224b","original_commit_id":"53285b83db582a85d6435ebe48bd2ae01923224b","user":{"login":"gpetruc","id":4643655,"node_id":"MDQ6VXNlcjQ2NDM2NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4643655?v=4","gravatar_id":"","url":"https://api.github.com/users/gpetruc","html_url":"https://github.com/gpetruc","followers_url":"https://api.github.com/users/gpetruc/followers","following_url":"https://api.github.com/users/gpetruc/following{/other_user}","gists_url":"https://api.github.com/users/gpetruc/gists{/gist_id}","starred_url":"https://api.github.com/users/gpetruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpetruc/subscriptions","organizations_url":"https://api.github.com/users/gpetruc/orgs","repos_url":"https://api.github.com/users/gpetruc/repos","events_url":"https://api.github.com/users/gpetruc/events{/privacy}","received_events_url":"https://api.github.com/users/gpetruc/received_events","type":"User","site_admin":false},"body":"also, I think that this and the above should be hidden from `import *` by having names starting with `_`, since they're not part of the public interface of the electron object and the name is unspecific enough that may clash with something else.","created_at":"2018-08-21T13:03:45Z","updated_at":"2018-08-21T13:03:45Z","html_url":"https://github.com/CERN-PH-CMG/cmg-cmssw/pull/738#discussion_r211596176","pull_request_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/comments/211596176"},"html":{"href":"https://github.com/CERN-PH-CMG/cmg-cmssw/pull/738#discussion_r211596176"},"pull_request":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738"}}},"pull_request":{"url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738","id":209305680,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzA1Njgw","html_url":"https://github.com/CERN-PH-CMG/cmg-cmssw/pull/738","diff_url":"https://github.com/CERN-PH-CMG/cmg-cmssw/pull/738.diff","patch_url":"https://github.com/CERN-PH-CMG/cmg-cmssw/pull/738.patch","issue_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/issues/738","number":738,"state":"open","locked":false,"title":"Heppy: streamlined isolation interface, enabling the use of electron EA iso with cone 0.3","user":{"login":"GaelTouquet","id":12496456,"node_id":"MDQ6VXNlcjEyNDk2NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/12496456?v=4","gravatar_id":"","url":"https://api.github.com/users/GaelTouquet","html_url":"https://github.com/GaelTouquet","followers_url":"https://api.github.com/users/GaelTouquet/followers","following_url":"https://api.github.com/users/GaelTouquet/following{/other_user}","gists_url":"https://api.github.com/users/GaelTouquet/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelTouquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelTouquet/subscriptions","organizations_url":"https://api.github.com/users/GaelTouquet/orgs","repos_url":"https://api.github.com/users/GaelTouquet/repos","events_url":"https://api.github.com/users/GaelTouquet/events{/privacy}","received_events_url":"https://api.github.com/users/GaelTouquet/received_events","type":"User","site_admin":false},"body":"To implement 2017 EA electron isolation properly, we realized that it was necessary to clean up the lepton isolation interface. Slight changes in client code will be necessary this time but we think that the new interface will be able to accommodate easily future implementations of the isolation.\r\n\r\nThe isolation has been perfectly synchronized with other groups in the h to tau tau analysis.","created_at":"2018-08-18T10:20:30Z","updated_at":"2018-08-21T13:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4798b8fe3528f2c09764cc13fdc6170236fd9302","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738/commits","review_comments_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738/comments","review_comment_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/issues/738/comments","statuses_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/statuses/53285b83db582a85d6435ebe48bd2ae01923224b","head":{"label":"GaelTouquet:Lepton_update","ref":"Lepton_update","sha":"53285b83db582a85d6435ebe48bd2ae01923224b","user":{"login":"GaelTouquet","id":12496456,"node_id":"MDQ6VXNlcjEyNDk2NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/12496456?v=4","gravatar_id":"","url":"https://api.github.com/users/GaelTouquet","html_url":"https://github.com/GaelTouquet","followers_url":"https://api.github.com/users/GaelTouquet/followers","following_url":"https://api.github.com/users/GaelTouquet/following{/other_user}","gists_url":"https://api.github.com/users/GaelTouquet/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelTouquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelTouquet/subscriptions","organizations_url":"https://api.github.com/users/GaelTouquet/orgs","repos_url":"https://api.github.com/users/GaelTouquet/repos","events_url":"https://api.github.com/users/GaelTouquet/events{/privacy}","received_events_url":"https://api.github.com/users/GaelTouquet/received_events","type":"User","site_admin":false},"repo":{"id":81549201,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU0OTIwMQ==","name":"cmg-cmssw","full_name":"GaelTouquet/cmg-cmssw","owner":{"login":"GaelTouquet","id":12496456,"node_id":"MDQ6VXNlcjEyNDk2NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/12496456?v=4","gravatar_id":"","url":"https://api.github.com/users/GaelTouquet","html_url":"https://github.com/GaelTouquet","followers_url":"https://api.github.com/users/GaelTouquet/followers","following_url":"https://api.github.com/users/GaelTouquet/following{/other_user}","gists_url":"https://api.github.com/users/GaelTouquet/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelTouquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelTouquet/subscriptions","organizations_url":"https://api.github.com/users/GaelTouquet/orgs","repos_url":"https://api.github.com/users/GaelTouquet/repos","events_url":"https://api.github.com/users/GaelTouquet/events{/privacy}","received_events_url":"https://api.github.com/users/GaelTouquet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GaelTouquet/cmg-cmssw","description":null,"fork":true,"url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw","forks_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/forks","keys_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/teams","hooks_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/hooks","issue_events_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/events","assignees_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/tags","blobs_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/languages","stargazers_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/stargazers","contributors_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/contributors","subscribers_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/subscribers","subscription_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/subscription","commits_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/merges","archive_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/downloads","issues_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/labels{/name}","releases_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/GaelTouquet/cmg-cmssw/deployments","created_at":"2017-02-10T09:28:14Z","updated_at":"2017-02-10T09:30:42Z","pushed_at":"2018-08-17T13:35:02Z","git_url":"git://github.com/GaelTouquet/cmg-cmssw.git","ssh_url":"git@github.com:GaelTouquet/cmg-cmssw.git","clone_url":"https://github.com/GaelTouquet/cmg-cmssw.git","svn_url":"https://github.com/GaelTouquet/cmg-cmssw","homepage":null,"size":1039847,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":0,"default_branch":"heppy_htt8025"}},"base":{"label":"CERN-PH-CMG:heppy_94X_dev","ref":"heppy_94X_dev","sha":"8c4630743a59df7f635982a184b7dfe281473834","user":{"login":"CERN-PH-CMG","id":5182689,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxODI2ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/5182689?v=4","gravatar_id":"","url":"https://api.github.com/users/CERN-PH-CMG","html_url":"https://github.com/CERN-PH-CMG","followers_url":"https://api.github.com/users/CERN-PH-CMG/followers","following_url":"https://api.github.com/users/CERN-PH-CMG/following{/other_user}","gists_url":"https://api.github.com/users/CERN-PH-CMG/gists{/gist_id}","starred_url":"https://api.github.com/users/CERN-PH-CMG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CERN-PH-CMG/subscriptions","organizations_url":"https://api.github.com/users/CERN-PH-CMG/orgs","repos_url":"https://api.github.com/users/CERN-PH-CMG/repos","events_url":"https://api.github.com/users/CERN-PH-CMG/events{/privacy}","received_events_url":"https://api.github.com/users/CERN-PH-CMG/received_events","type":"Organization","site_admin":false},"repo":{"id":13088143,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4ODE0Mw==","name":"cmg-cmssw","full_name":"CERN-PH-CMG/cmg-cmssw","owner":{"login":"CERN-PH-CMG","id":5182689,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxODI2ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/5182689?v=4","gravatar_id":"","url":"https://api.github.com/users/CERN-PH-CMG","html_url":"https://github.com/CERN-PH-CMG","followers_url":"https://api.github.com/users/CERN-PH-CMG/followers","following_url":"https://api.github.com/users/CERN-PH-CMG/following{/other_user}","gists_url":"https://api.github.com/users/CERN-PH-CMG/gists{/gist_id}","starred_url":"https://api.github.com/users/CERN-PH-CMG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CERN-PH-CMG/subscriptions","organizations_url":"https://api.github.com/users/CERN-PH-CMG/orgs","repos_url":"https://api.github.com/users/CERN-PH-CMG/repos","events_url":"https://api.github.com/users/CERN-PH-CMG/events{/privacy}","received_events_url":"https://api.github.com/users/CERN-PH-CMG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CERN-PH-CMG/cmg-cmssw","description":"CERN CMG Tools repository. Installation instructions available on the twiki: ","fork":false,"url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw","forks_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/forks","keys_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/teams","hooks_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/hooks","issue_events_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/events","assignees_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/tags","blobs_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/languages","stargazers_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/stargazers","contributors_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/contributors","subscribers_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/subscribers","subscription_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/subscription","commits_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/merges","archive_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/downloads","issues_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/labels{/name}","releases_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/deployments","created_at":"2013-09-25T08:23:20Z","updated_at":"2018-08-21T12:47:15Z","pushed_at":"2018-08-21T12:45:19Z","git_url":"git://github.com/CERN-PH-CMG/cmg-cmssw.git","ssh_url":"git@github.com:CERN-PH-CMG/cmg-cmssw.git","clone_url":"https://github.com/CERN-PH-CMG/cmg-cmssw.git","svn_url":"https://github.com/CERN-PH-CMG/cmg-cmssw","homepage":"https://twiki.cern.ch/twiki/bin/viewauth/CMS/CMGToolsReleasesExperimental","size":1476423,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":215,"open_issues":13,"watchers":14,"default_branch":"heppy_94X_dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738"},"html":{"href":"https://github.com/CERN-PH-CMG/cmg-cmssw/pull/738"},"issue":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/issues/738"},"comments":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/issues/738/comments"},"review_comments":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738/comments"},"review_comment":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/pulls/738/commits"},"statuses":{"href":"https://api.github.com/repos/CERN-PH-CMG/cmg-cmssw/statuses/53285b83db582a85d6435ebe48bd2ae01923224b"}},"author_association":"NONE"}}
{"actor":{"display_login":"gpetruc"}}