{"action":"closed","number":127,"pull_request":{"url":"https://api.github.com/repos/purescript/psc-package/pulls/127","id":201935521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTM1NTIx","html_url":"https://github.com/purescript/psc-package/pull/127","diff_url":"https://github.com/purescript/psc-package/pull/127.diff","patch_url":"https://github.com/purescript/psc-package/pull/127.patch","issue_url":"https://api.github.com/repos/purescript/psc-package/issues/127","number":127,"state":"closed","locked":false,"title":"Limit threads","user":{"login":"vladciobanu","id":1017953,"node_id":"MDQ6VXNlcjEwMTc5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017953?v=4","gravatar_id":"","url":"https://api.github.com/users/vladciobanu","html_url":"https://github.com/vladciobanu","followers_url":"https://api.github.com/users/vladciobanu/followers","following_url":"https://api.github.com/users/vladciobanu/following{/other_user}","gists_url":"https://api.github.com/users/vladciobanu/gists{/gist_id}","starred_url":"https://api.github.com/users/vladciobanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladciobanu/subscriptions","organizations_url":"https://api.github.com/users/vladciobanu/orgs","repos_url":"https://api.github.com/users/vladciobanu/repos","events_url":"https://api.github.com/users/vladciobanu/events{/privacy}","received_events_url":"https://api.github.com/users/vladciobanu/received_events","type":"User","site_admin":false},"body":"This is more of a \"is this what you had in mind\", I'm totally open to feedback.\r\n\r\nI added a `--threads N` option for all commands that (eventually) hit a `mapConcurrently` or a `forConcurrently_`. I did it by adding a `Maybe Int` parameter down the call stack (not sure if it's worth it refactoring all of the functions to some `ReaderT env IO`; probably not with this PR but I could take that on if it would get accepted).\r\n\r\nA value of `Nothing` means use old behaviour, otherwise use the method suggested by @kRITZCREEK's link in #126.\r\n\r\nI would also like to keep the changes to the import because I like them arranged nicely, but I'm totally fine reverting that chunk if you want me to.\r\n\r\nThis has been tested on Appveyor on our project and fixed our issues. We have only tested with `--threads 1` so far and that works (but is obviously a bit slow).","created_at":"2018-07-17T13:08:11Z","updated_at":"2018-07-19T16:20:10Z","closed_at":"2018-07-19T16:20:10Z","merged_at":"2018-07-19T16:20:10Z","merge_commit_sha":"8c25bb59b70181c33bf333fbc5c075800de821e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/purescript/psc-package/pulls/127/commits","review_comments_url":"https://api.github.com/repos/purescript/psc-package/pulls/127/comments","review_comment_url":"https://api.github.com/repos/purescript/psc-package/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript/psc-package/issues/127/comments","statuses_url":"https://api.github.com/repos/purescript/psc-package/statuses/14d23d94cc6da4378ad16da777f862347a06f502","head":{"label":"vladciobanu:limit-threads","ref":"limit-threads","sha":"14d23d94cc6da4378ad16da777f862347a06f502","user":{"login":"vladciobanu","id":1017953,"node_id":"MDQ6VXNlcjEwMTc5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017953?v=4","gravatar_id":"","url":"https://api.github.com/users/vladciobanu","html_url":"https://github.com/vladciobanu","followers_url":"https://api.github.com/users/vladciobanu/followers","following_url":"https://api.github.com/users/vladciobanu/following{/other_user}","gists_url":"https://api.github.com/users/vladciobanu/gists{/gist_id}","starred_url":"https://api.github.com/users/vladciobanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladciobanu/subscriptions","organizations_url":"https://api.github.com/users/vladciobanu/orgs","repos_url":"https://api.github.com/users/vladciobanu/repos","events_url":"https://api.github.com/users/vladciobanu/events{/privacy}","received_events_url":"https://api.github.com/users/vladciobanu/received_events","type":"User","site_admin":false},"repo":{"id":141124736,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExMjQ3MzY=","name":"psc-package","full_name":"vladciobanu/psc-package","owner":{"login":"vladciobanu","id":1017953,"node_id":"MDQ6VXNlcjEwMTc5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017953?v=4","gravatar_id":"","url":"https://api.github.com/users/vladciobanu","html_url":"https://github.com/vladciobanu","followers_url":"https://api.github.com/users/vladciobanu/followers","following_url":"https://api.github.com/users/vladciobanu/following{/other_user}","gists_url":"https://api.github.com/users/vladciobanu/gists{/gist_id}","starred_url":"https://api.github.com/users/vladciobanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladciobanu/subscriptions","organizations_url":"https://api.github.com/users/vladciobanu/orgs","repos_url":"https://api.github.com/users/vladciobanu/repos","events_url":"https://api.github.com/users/vladciobanu/events{/privacy}","received_events_url":"https://api.github.com/users/vladciobanu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vladciobanu/psc-package","description":"A package manager for PureScript based on package sets","fork":true,"url":"https://api.github.com/repos/vladciobanu/psc-package","forks_url":"https://api.github.com/repos/vladciobanu/psc-package/forks","keys_url":"https://api.github.com/repos/vladciobanu/psc-package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vladciobanu/psc-package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vladciobanu/psc-package/teams","hooks_url":"https://api.github.com/repos/vladciobanu/psc-package/hooks","issue_events_url":"https://api.github.com/repos/vladciobanu/psc-package/issues/events{/number}","events_url":"https://api.github.com/repos/vladciobanu/psc-package/events","assignees_url":"https://api.github.com/repos/vladciobanu/psc-package/assignees{/user}","branches_url":"https://api.github.com/repos/vladciobanu/psc-package/branches{/branch}","tags_url":"https://api.github.com/repos/vladciobanu/psc-package/tags","blobs_url":"https://api.github.com/repos/vladciobanu/psc-package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vladciobanu/psc-package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vladciobanu/psc-package/git/refs{/sha}","trees_url":"https://api.github.com/repos/vladciobanu/psc-package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vladciobanu/psc-package/statuses/{sha}","languages_url":"https://api.github.com/repos/vladciobanu/psc-package/languages","stargazers_url":"https://api.github.com/repos/vladciobanu/psc-package/stargazers","contributors_url":"https://api.github.com/repos/vladciobanu/psc-package/contributors","subscribers_url":"https://api.github.com/repos/vladciobanu/psc-package/subscribers","subscription_url":"https://api.github.com/repos/vladciobanu/psc-package/subscription","commits_url":"https://api.github.com/repos/vladciobanu/psc-package/commits{/sha}","git_commits_url":"https://api.github.com/repos/vladciobanu/psc-package/git/commits{/sha}","comments_url":"https://api.github.com/repos/vladciobanu/psc-package/comments{/number}","issue_comment_url":"https://api.github.com/repos/vladciobanu/psc-package/issues/comments{/number}","contents_url":"https://api.github.com/repos/vladciobanu/psc-package/contents/{+path}","compare_url":"https://api.github.com/repos/vladciobanu/psc-package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vladciobanu/psc-package/merges","archive_url":"https://api.github.com/repos/vladciobanu/psc-package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vladciobanu/psc-package/downloads","issues_url":"https://api.github.com/repos/vladciobanu/psc-package/issues{/number}","pulls_url":"https://api.github.com/repos/vladciobanu/psc-package/pulls{/number}","milestones_url":"https://api.github.com/repos/vladciobanu/psc-package/milestones{/number}","notifications_url":"https://api.github.com/repos/vladciobanu/psc-package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vladciobanu/psc-package/labels{/name}","releases_url":"https://api.github.com/repos/vladciobanu/psc-package/releases{/id}","deployments_url":"https://api.github.com/repos/vladciobanu/psc-package/deployments","created_at":"2018-07-16T10:41:00Z","updated_at":"2018-07-16T10:41:02Z","pushed_at":"2018-07-19T10:39:11Z","git_url":"git://github.com/vladciobanu/psc-package.git","ssh_url":"git@github.com:vladciobanu/psc-package.git","clone_url":"https://github.com/vladciobanu/psc-package.git","svn_url":"https://github.com/vladciobanu/psc-package","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript:master","ref":"master","sha":"68bac74410c010e31f56c492ef05093758e762fb","user":{"login":"purescript","id":6556677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NTY2Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6556677?v=4","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"repo":{"id":81163698,"node_id":"MDEwOlJlcG9zaXRvcnk4MTE2MzY5OA==","name":"psc-package","full_name":"purescript/psc-package","owner":{"login":"purescript","id":6556677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NTY2Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6556677?v=4","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript/psc-package","description":"A package manager for PureScript based on package sets","fork":false,"url":"https://api.github.com/repos/purescript/psc-package","forks_url":"https://api.github.com/repos/purescript/psc-package/forks","keys_url":"https://api.github.com/repos/purescript/psc-package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript/psc-package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript/psc-package/teams","hooks_url":"https://api.github.com/repos/purescript/psc-package/hooks","issue_events_url":"https://api.github.com/repos/purescript/psc-package/issues/events{/number}","events_url":"https://api.github.com/repos/purescript/psc-package/events","assignees_url":"https://api.github.com/repos/purescript/psc-package/assignees{/user}","branches_url":"https://api.github.com/repos/purescript/psc-package/branches{/branch}","tags_url":"https://api.github.com/repos/purescript/psc-package/tags","blobs_url":"https://api.github.com/repos/purescript/psc-package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript/psc-package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript/psc-package/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript/psc-package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript/psc-package/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript/psc-package/languages","stargazers_url":"https://api.github.com/repos/purescript/psc-package/stargazers","contributors_url":"https://api.github.com/repos/purescript/psc-package/contributors","subscribers_url":"https://api.github.com/repos/purescript/psc-package/subscribers","subscription_url":"https://api.github.com/repos/purescript/psc-package/subscription","commits_url":"https://api.github.com/repos/purescript/psc-package/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript/psc-package/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript/psc-package/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript/psc-package/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript/psc-package/contents/{+path}","compare_url":"https://api.github.com/repos/purescript/psc-package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript/psc-package/merges","archive_url":"https://api.github.com/repos/purescript/psc-package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript/psc-package/downloads","issues_url":"https://api.github.com/repos/purescript/psc-package/issues{/number}","pulls_url":"https://api.github.com/repos/purescript/psc-package/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript/psc-package/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript/psc-package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript/psc-package/labels{/name}","releases_url":"https://api.github.com/repos/purescript/psc-package/releases{/id}","deployments_url":"https://api.github.com/repos/purescript/psc-package/deployments","created_at":"2017-02-07T03:47:49Z","updated_at":"2018-07-16T19:42:18Z","pushed_at":"2018-07-19T16:20:10Z","git_url":"git://github.com/purescript/psc-package.git","ssh_url":"git@github.com:purescript/psc-package.git","clone_url":"https://github.com/purescript/psc-package.git","svn_url":"https://github.com/purescript/psc-package","homepage":"","size":91,"stargazers_count":146,"watchers_count":146,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":28,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript/psc-package/pulls/127"},"html":{"href":"https://github.com/purescript/psc-package/pull/127"},"issue":{"href":"https://api.github.com/repos/purescript/psc-package/issues/127"},"comments":{"href":"https://api.github.com/repos/purescript/psc-package/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript/psc-package/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript/psc-package/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript/psc-package/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/purescript/psc-package/statuses/14d23d94cc6da4378ad16da777f862347a06f502"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"justinwoo","id":2396926,"node_id":"MDQ6VXNlcjIzOTY5MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2396926?v=4","gravatar_id":"","url":"https://api.github.com/users/justinwoo","html_url":"https://github.com/justinwoo","followers_url":"https://api.github.com/users/justinwoo/followers","following_url":"https://api.github.com/users/justinwoo/following{/other_user}","gists_url":"https://api.github.com/users/justinwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/justinwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinwoo/subscriptions","organizations_url":"https://api.github.com/users/justinwoo/orgs","repos_url":"https://api.github.com/users/justinwoo/repos","events_url":"https://api.github.com/users/justinwoo/events{/privacy}","received_events_url":"https://api.github.com/users/justinwoo/received_events","type":"User","site_admin":false},"comments":5,"review_comments":6,"maintainer_can_modify":false,"commits":12,"additions":79,"deletions":24,"changed_files":2}}
{"actor":{"display_login":"justinwoo"}}