{"action":"created","comment":{"url":"https://api.github.com/repos/qubole/rubix/pulls/comments/191051328","pull_request_review_id":123559376,"id":191051328,"diff_hunk":"@@ -113,8 +116,14 @@ public static void startServer(Configuration conf, MetricRegistry metricsRegistr\n   /**\n    * Register desired metrics.\n    */\n-  private static void registerMetrics()\n+  private static void registerMetrics(Configuration conf)\n   {\n+    if (CacheConfig.isOnMaster(conf)) {","path":"rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeperServer.java","position":33,"original_position":33,"commit_id":"b2d9cdc9850ef2236a9086d52f51014208800f97","original_commit_id":"b2d9cdc9850ef2236a9086d52f51014208800f97","user":{"login":"vrajat","id":1638298,"avatar_url":"https://avatars0.githubusercontent.com/u/1638298?v=4","gravatar_id":"","url":"https://api.github.com/users/vrajat","html_url":"https://github.com/vrajat","followers_url":"https://api.github.com/users/vrajat/followers","following_url":"https://api.github.com/users/vrajat/following{/other_user}","gists_url":"https://api.github.com/users/vrajat/gists{/gist_id}","starred_url":"https://api.github.com/users/vrajat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrajat/subscriptions","organizations_url":"https://api.github.com/users/vrajat/orgs","repos_url":"https://api.github.com/users/vrajat/repos","events_url":"https://api.github.com/users/vrajat/events{/privacy}","received_events_url":"https://api.github.com/users/vrajat/received_events","type":"User","site_admin":false},"body":"`reportOnMaster` should also be `false`. We will roll it out gradually through QDS cluster configuration. ","created_at":"2018-05-26T15:07:41Z","updated_at":"2018-05-26T15:07:41Z","html_url":"https://github.com/qubole/rubix/pull/144#discussion_r191051328","pull_request_url":"https://api.github.com/repos/qubole/rubix/pulls/144","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qubole/rubix/pulls/comments/191051328"},"html":{"href":"https://github.com/qubole/rubix/pull/144#discussion_r191051328"},"pull_request":{"href":"https://api.github.com/repos/qubole/rubix/pulls/144"}},"in_reply_to_id":190784126},"pull_request":{"url":"https://api.github.com/repos/qubole/rubix/pulls/144","id":188891584,"html_url":"https://github.com/qubole/rubix/pull/144","diff_url":"https://github.com/qubole/rubix/pull/144.diff","patch_url":"https://github.com/qubole/rubix/pull/144.patch","issue_url":"https://api.github.com/repos/qubole/rubix/issues/144","number":144,"state":"open","locked":false,"title":"Send registered metrics to StatsD via StatsDReporter","user":{"login":"jordanw-bq","id":37088125,"avatar_url":"https://avatars1.githubusercontent.com/u/37088125?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanw-bq","html_url":"https://github.com/jordanw-bq","followers_url":"https://api.github.com/users/jordanw-bq/followers","following_url":"https://api.github.com/users/jordanw-bq/following{/other_user}","gists_url":"https://api.github.com/users/jordanw-bq/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanw-bq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanw-bq/subscriptions","organizations_url":"https://api.github.com/users/jordanw-bq/orgs","repos_url":"https://api.github.com/users/jordanw-bq/repos","events_url":"https://api.github.com/users/jordanw-bq/events{/privacy}","received_events_url":"https://api.github.com/users/jordanw-bq/received_events","type":"User","site_admin":false},"body":"- Passed smoke test on Qubole cluster\r\n- Currently verifying that metrics are sent to DogStatsD on Qubole cluster using default config settings (localhost:8125)","created_at":"2018-05-18T00:05:15Z","updated_at":"2018-05-26T15:07:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e9d5477f1f3daf2d43856ffd919638baf2b9b4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qubole/rubix/pulls/144/commits","review_comments_url":"https://api.github.com/repos/qubole/rubix/pulls/144/comments","review_comment_url":"https://api.github.com/repos/qubole/rubix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qubole/rubix/issues/144/comments","statuses_url":"https://api.github.com/repos/qubole/rubix/statuses/b2d9cdc9850ef2236a9086d52f51014208800f97","head":{"label":"jordanw-bq:statsd-reporter-QUB47","ref":"statsd-reporter-QUB47","sha":"b2d9cdc9850ef2236a9086d52f51014208800f97","user":{"login":"jordanw-bq","id":37088125,"avatar_url":"https://avatars1.githubusercontent.com/u/37088125?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanw-bq","html_url":"https://github.com/jordanw-bq","followers_url":"https://api.github.com/users/jordanw-bq/followers","following_url":"https://api.github.com/users/jordanw-bq/following{/other_user}","gists_url":"https://api.github.com/users/jordanw-bq/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanw-bq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanw-bq/subscriptions","organizations_url":"https://api.github.com/users/jordanw-bq/orgs","repos_url":"https://api.github.com/users/jordanw-bq/repos","events_url":"https://api.github.com/users/jordanw-bq/events{/privacy}","received_events_url":"https://api.github.com/users/jordanw-bq/received_events","type":"User","site_admin":false},"repo":{"id":124964133,"name":"rubix","full_name":"jordanw-bq/rubix","owner":{"login":"jordanw-bq","id":37088125,"avatar_url":"https://avatars1.githubusercontent.com/u/37088125?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanw-bq","html_url":"https://github.com/jordanw-bq","followers_url":"https://api.github.com/users/jordanw-bq/followers","following_url":"https://api.github.com/users/jordanw-bq/following{/other_user}","gists_url":"https://api.github.com/users/jordanw-bq/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanw-bq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanw-bq/subscriptions","organizations_url":"https://api.github.com/users/jordanw-bq/orgs","repos_url":"https://api.github.com/users/jordanw-bq/repos","events_url":"https://api.github.com/users/jordanw-bq/events{/privacy}","received_events_url":"https://api.github.com/users/jordanw-bq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordanw-bq/rubix","description":"Cache File System optimized for columnar formats and object stores ","fork":true,"url":"https://api.github.com/repos/jordanw-bq/rubix","forks_url":"https://api.github.com/repos/jordanw-bq/rubix/forks","keys_url":"https://api.github.com/repos/jordanw-bq/rubix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordanw-bq/rubix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordanw-bq/rubix/teams","hooks_url":"https://api.github.com/repos/jordanw-bq/rubix/hooks","issue_events_url":"https://api.github.com/repos/jordanw-bq/rubix/issues/events{/number}","events_url":"https://api.github.com/repos/jordanw-bq/rubix/events","assignees_url":"https://api.github.com/repos/jordanw-bq/rubix/assignees{/user}","branches_url":"https://api.github.com/repos/jordanw-bq/rubix/branches{/branch}","tags_url":"https://api.github.com/repos/jordanw-bq/rubix/tags","blobs_url":"https://api.github.com/repos/jordanw-bq/rubix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordanw-bq/rubix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordanw-bq/rubix/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordanw-bq/rubix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordanw-bq/rubix/statuses/{sha}","languages_url":"https://api.github.com/repos/jordanw-bq/rubix/languages","stargazers_url":"https://api.github.com/repos/jordanw-bq/rubix/stargazers","contributors_url":"https://api.github.com/repos/jordanw-bq/rubix/contributors","subscribers_url":"https://api.github.com/repos/jordanw-bq/rubix/subscribers","subscription_url":"https://api.github.com/repos/jordanw-bq/rubix/subscription","commits_url":"https://api.github.com/repos/jordanw-bq/rubix/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordanw-bq/rubix/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordanw-bq/rubix/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordanw-bq/rubix/issues/comments{/number}","contents_url":"https://api.github.com/repos/jordanw-bq/rubix/contents/{+path}","compare_url":"https://api.github.com/repos/jordanw-bq/rubix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordanw-bq/rubix/merges","archive_url":"https://api.github.com/repos/jordanw-bq/rubix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordanw-bq/rubix/downloads","issues_url":"https://api.github.com/repos/jordanw-bq/rubix/issues{/number}","pulls_url":"https://api.github.com/repos/jordanw-bq/rubix/pulls{/number}","milestones_url":"https://api.github.com/repos/jordanw-bq/rubix/milestones{/number}","notifications_url":"https://api.github.com/repos/jordanw-bq/rubix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordanw-bq/rubix/labels{/name}","releases_url":"https://api.github.com/repos/jordanw-bq/rubix/releases{/id}","deployments_url":"https://api.github.com/repos/jordanw-bq/rubix/deployments","created_at":"2018-03-12T23:28:16Z","updated_at":"2018-05-16T20:15:33Z","pushed_at":"2018-05-25T00:31:18Z","git_url":"git://github.com/jordanw-bq/rubix.git","ssh_url":"git@github.com:jordanw-bq/rubix.git","clone_url":"https://github.com/jordanw-bq/rubix.git","svn_url":"https://github.com/jordanw-bq/rubix","homepage":null,"size":533,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qubole:master","ref":"master","sha":"1349c65446877421031fbde16d24b7e4726d95b7","user":{"login":"qubole","id":1259448,"avatar_url":"https://avatars2.githubusercontent.com/u/1259448?v=4","gravatar_id":"","url":"https://api.github.com/users/qubole","html_url":"https://github.com/qubole","followers_url":"https://api.github.com/users/qubole/followers","following_url":"https://api.github.com/users/qubole/following{/other_user}","gists_url":"https://api.github.com/users/qubole/gists{/gist_id}","starred_url":"https://api.github.com/users/qubole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qubole/subscriptions","organizations_url":"https://api.github.com/users/qubole/orgs","repos_url":"https://api.github.com/users/qubole/repos","events_url":"https://api.github.com/users/qubole/events{/privacy}","received_events_url":"https://api.github.com/users/qubole/received_events","type":"Organization","site_admin":false},"repo":{"id":61691853,"name":"rubix","full_name":"qubole/rubix","owner":{"login":"qubole","id":1259448,"avatar_url":"https://avatars2.githubusercontent.com/u/1259448?v=4","gravatar_id":"","url":"https://api.github.com/users/qubole","html_url":"https://github.com/qubole","followers_url":"https://api.github.com/users/qubole/followers","following_url":"https://api.github.com/users/qubole/following{/other_user}","gists_url":"https://api.github.com/users/qubole/gists{/gist_id}","starred_url":"https://api.github.com/users/qubole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qubole/subscriptions","organizations_url":"https://api.github.com/users/qubole/orgs","repos_url":"https://api.github.com/users/qubole/repos","events_url":"https://api.github.com/users/qubole/events{/privacy}","received_events_url":"https://api.github.com/users/qubole/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qubole/rubix","description":"Cache File System optimized for columnar formats and object stores ","fork":false,"url":"https://api.github.com/repos/qubole/rubix","forks_url":"https://api.github.com/repos/qubole/rubix/forks","keys_url":"https://api.github.com/repos/qubole/rubix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qubole/rubix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qubole/rubix/teams","hooks_url":"https://api.github.com/repos/qubole/rubix/hooks","issue_events_url":"https://api.github.com/repos/qubole/rubix/issues/events{/number}","events_url":"https://api.github.com/repos/qubole/rubix/events","assignees_url":"https://api.github.com/repos/qubole/rubix/assignees{/user}","branches_url":"https://api.github.com/repos/qubole/rubix/branches{/branch}","tags_url":"https://api.github.com/repos/qubole/rubix/tags","blobs_url":"https://api.github.com/repos/qubole/rubix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qubole/rubix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qubole/rubix/git/refs{/sha}","trees_url":"https://api.github.com/repos/qubole/rubix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qubole/rubix/statuses/{sha}","languages_url":"https://api.github.com/repos/qubole/rubix/languages","stargazers_url":"https://api.github.com/repos/qubole/rubix/stargazers","contributors_url":"https://api.github.com/repos/qubole/rubix/contributors","subscribers_url":"https://api.github.com/repos/qubole/rubix/subscribers","subscription_url":"https://api.github.com/repos/qubole/rubix/subscription","commits_url":"https://api.github.com/repos/qubole/rubix/commits{/sha}","git_commits_url":"https://api.github.com/repos/qubole/rubix/git/commits{/sha}","comments_url":"https://api.github.com/repos/qubole/rubix/comments{/number}","issue_comment_url":"https://api.github.com/repos/qubole/rubix/issues/comments{/number}","contents_url":"https://api.github.com/repos/qubole/rubix/contents/{+path}","compare_url":"https://api.github.com/repos/qubole/rubix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qubole/rubix/merges","archive_url":"https://api.github.com/repos/qubole/rubix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qubole/rubix/downloads","issues_url":"https://api.github.com/repos/qubole/rubix/issues{/number}","pulls_url":"https://api.github.com/repos/qubole/rubix/pulls{/number}","milestones_url":"https://api.github.com/repos/qubole/rubix/milestones{/number}","notifications_url":"https://api.github.com/repos/qubole/rubix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qubole/rubix/labels{/name}","releases_url":"https://api.github.com/repos/qubole/rubix/releases{/id}","deployments_url":"https://api.github.com/repos/qubole/rubix/deployments","created_at":"2016-06-22T05:38:04Z","updated_at":"2018-05-25T07:30:46Z","pushed_at":"2018-05-26T15:04:30Z","git_url":"git://github.com/qubole/rubix.git","ssh_url":"git@github.com:qubole/rubix.git","clone_url":"https://github.com/qubole/rubix.git","svn_url":"https://github.com/qubole/rubix","homepage":null,"size":465,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":18,"open_issues":39,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qubole/rubix/pulls/144"},"html":{"href":"https://github.com/qubole/rubix/pull/144"},"issue":{"href":"https://api.github.com/repos/qubole/rubix/issues/144"},"comments":{"href":"https://api.github.com/repos/qubole/rubix/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/qubole/rubix/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/qubole/rubix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qubole/rubix/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/qubole/rubix/statuses/b2d9cdc9850ef2236a9086d52f51014208800f97"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vrajat"}}