{"action":"created","issue":{"url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/460","repository_url":"https://api.github.com/repos/RetroPie/EmulationStation","labels_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/460/labels{/name}","comments_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/460/comments","events_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/460/events","html_url":"https://github.com/RetroPie/EmulationStation/pull/460","id":343312466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDAxODAz","number":460,"title":"Enhanced Audio settings","user":{"login":"tminit","id":41322101,"node_id":"MDQ6VXNlcjQxMzIyMTAx","avatar_url":"https://avatars3.githubusercontent.com/u/41322101?v=4","gravatar_id":"","url":"https://api.github.com/users/tminit","html_url":"https://github.com/tminit","followers_url":"https://api.github.com/users/tminit/followers","following_url":"https://api.github.com/users/tminit/following{/other_user}","gists_url":"https://api.github.com/users/tminit/gists{/gist_id}","starred_url":"https://api.github.com/users/tminit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tminit/subscriptions","organizations_url":"https://api.github.com/users/tminit/orgs","repos_url":"https://api.github.com/users/tminit/repos","events_url":"https://api.github.com/users/tminit/events{/privacy}","received_events_url":"https://api.github.com/users/tminit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-21T09:15:04Z","updated_at":"2018-07-25T04:57:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/RetroPie/EmulationStation/pulls/460","html_url":"https://github.com/RetroPie/EmulationStation/pull/460","diff_url":"https://github.com/RetroPie/EmulationStation/pull/460.diff","patch_url":"https://github.com/RetroPie/EmulationStation/pull/460.patch"},"body":"Changed the selectable options for EmulationStation audio mixer\r\n(AudioDevice) to be a greater range of options on the RPi and Linux\r\nso that it will work with any aftermarket add-on audio cards and\r\nRPi Audio HATs. Hopefully this gives people the flexibility that\r\nthey need in order to avoid the issues people have with unusual RPi\r\naudio setups.\r\n\r\nAdded the ability to select the audio card as well, by surfacing\r\nthe audio card under the Audio Card setting. It was previously forced\r\nto 'default' for all linux users, which was too restrictive in some\r\ninstances. This change now adds flexbility to support additional\r\nlinux and Rpi Audio Cards.\r\n\r\nSELECTING AUDIO ON LINUX AND RPi\r\nYou now select which ALSA Audio Card you want EmulationStation to use\r\nby choosing the relevant AUDIO CARD option. If your one is not listed\r\nthen you can add a custom one in the es_settings file (see below).\r\n\r\nYou then select which ALSA Audio Mixer Control from that Audio Card\r\nthat you want EmulationStation to use, by choosing the relevant\r\nAUDIO DEVICE option. (I kept the name AUDIO DEVICE as that what\r\nEmulationStation previously recorded the Audio Mixer Name as.)\r\nIf your mixer name is not listed then you can add a custom one in\r\nthe es_settings file (see below).\r\n\r\nADDING A CUSTOM AUDIO CARD OR AUDIO DEVICE\r\nIn addition I added the ability to manually change the setting in\r\nes_settings.cfg to add anything custom that you want. Any custom\r\n\"AudioCard\" will be loaded into the GUI and shown as an option,\r\nand any custom \"AudioDevice\" (actually the mixer) on that Audio\r\nCard will be loaded into the GUI too. This will give advanced users \r\nenough extra configuration ability that should avoid problems\r\nwith even the strangest setups.\r\n\r\nNOTE: Any custom settings added to es_settings.cfg will be \r\noverwritten if you select any of the other options in the GUI and \r\nexit the Sound Settings window, as the Sound Settings GUI window \r\noverwrites the es_settings.cfg options when you exit the Sound\r\nSettings window."},"comment":{"url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/comments/407633438","html_url":"https://github.com/RetroPie/EmulationStation/pull/460#issuecomment-407633438","issue_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/460","id":407633438,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzYzMzQzOA==","user":{"login":"tminit","id":41322101,"node_id":"MDQ6VXNlcjQxMzIyMTAx","avatar_url":"https://avatars3.githubusercontent.com/u/41322101?v=4","gravatar_id":"","url":"https://api.github.com/users/tminit","html_url":"https://github.com/tminit","followers_url":"https://api.github.com/users/tminit/followers","following_url":"https://api.github.com/users/tminit/following{/other_user}","gists_url":"https://api.github.com/users/tminit/gists{/gist_id}","starred_url":"https://api.github.com/users/tminit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tminit/subscriptions","organizations_url":"https://api.github.com/users/tminit/orgs","repos_url":"https://api.github.com/users/tminit/repos","events_url":"https://api.github.com/users/tminit/events{/privacy}","received_events_url":"https://api.github.com/users/tminit/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T04:57:42Z","updated_at":"2018-07-25T04:57:42Z","author_association":"NONE","body":"Hi @jrassa,\r\n\r\nI've updated the file fully from spaces to tabs as per the project standard. Hope that's ok. It's ready for your review again.\r\n\r\nCheers\r\nTerry MacDonald"}}
{"actor":{"display_login":"tminit"}}