{"push_id":2756217939,"size":6,"distinct_size":1,"ref":"refs/heads/master","head":"25833519fc4c33bff4d5ffa1466d3f19821a8efe","before":"aa7142df21571c6b443a7bf012314b51d650ca6d","commits":[{"sha":"ad558727536932f487a0322c34bf3b66544f0b6b","author":{"name":"Matthew Wire","email":"21a6cafaf0e9b0080692d699c1538d0dfa42b47a@mrwire.co.uk"},"message":"Non functional changes towards shared functions in Core_Form_Task","distinct":false,"url":"https://api.github.com/repos/civicrm/civicrm-core/commits/ad558727536932f487a0322c34bf3b66544f0b6b"},{"sha":"f79d8a1e9b64ea295124dd42cbf56eb3fc6918bf","author":{"name":"eileen","email":"78734518be819feb35db6d6c93f6b4406c21a8c2@wikimedia.org"},"message":"Fix regression on case export from recent export fix\n\nhttps://github.com/civicrm/civicrm-core/commit/3b4adc92793dccfa446cf66f0740edb543f110d7 changed the way componentmode is defined\n\nIt now seems inconsistent","distinct":false,"url":"https://api.github.com/repos/civicrm/civicrm-core/commits/f79d8a1e9b64ea295124dd42cbf56eb3fc6918bf"},{"sha":"964025e5b5609bf927acfe1366762e669a634108","author":{"name":"Eileen McNaughton","email":"64517a7a8e5ab470725947eb472340f4fbdb9e12@mcnaughty.com"},"message":"Merge pull request #12588 from mattwire/5.4_backportcasefixes\n\nBackport \"Fix regression on case export\" to 5.4","distinct":false,"url":"https://api.github.com/repos/civicrm/civicrm-core/commits/964025e5b5609bf927acfe1366762e669a634108"},{"sha":"70423e0d7732547b95e3d9dd62e00f42b657ad21","author":{"name":"Tim Otten","email":"2a56db891c70907901517a1f205658772720d3f5@civicrm.org"},"message":"Overview\n----------------------------------------\n\n`CRM_Utils_System::flushCache()` calls `CRM_Utils_Cache::singleton()->flush()`.\nIn `5.3`, this triggered a cascading effect; in development of `5.4.alpha`,\nsome of the cascades were overzealous and we revised to get tighter control\nover cascading.\n\nWith an aim to being conservative and reproducing old behavior, I previously\npatched `5.4.alpha` to add several extra flushes and simulate the old cascades.\nHowever, it wasn't really as conservative as hoped -- because the \"old\nbehavior\" depended on the environment.  This patch brings us closer the \"old\nbehavior\".\n\nSee also: https://lab.civicrm.org/dev/core/issues/284\n\nBefore (Behavior in version <=`5.3`)\n----------------------------------------\n\nOn systems with memory-backed caches, `flushCache()` had an aggressive\ncascading side-effect where several named caches (`settings`, etc) were also\nflushed.\n\nOn systems with a default configuration (SQL+ArrayCache), `flushCache()` had a\nvery limited cascading effect -- it *only cleared the in-process ArrayCache*.\nThe bulk of the cache content was preserved in SQL.\n\nBefore (Behavior in version ~= `5.4.alpha`)\n----------------------------------------\n\nTo simulate the cascading effect, `flushCache()` explicitly flushes a\nhalf-dozen individual caches.  (These half-dozen are chosen to match the old\ncascade list and exclude some new things which would problematic.)\n\nOn systems with memory-backed caches, this reproduces the aggressive cascading\neffect.\n\nOn systems with a default configuration (SQL+ArrayCache), this amplifies the\nflushing -- because it also destroys the underlying SQL caches.\n\nThis has the side-effect of significantly degrading performance of the test\nsuite.\n\nAfter (Behavior with patch)\n----------------------------------------\n\n`CRM_Utils_System::flushCache` calls `CRM_Utils_Cache::singleton()->flush()`.\n\nTo simulate the cascading effect, `flushCache()` explicitly flushes a\nhalf-dozen individual caches...  *but only on memory-backed* systems.\n\nOn systems with memory-backed caches, this reproduces the aggressive cascading\neffect.\n\nOn systems with a default configuration (SQL+ArrayCache), this is closer to the\nold behavior.  The bulk of the cache remains available in SQL.\n\nBased on local spot-checking, this restores performance of the test suite.\n\nComments\n----------------------------------------\n\nDeep down, I don't really believe the cascading effect is a good thing.  At\nsome point, I'd rather just remove these bits.  But in absence of a crystal\nball to predict the side-effects of that, I think it's good to find a better\napproximation of the old behavior.","distinct":false,"url":"https://api.github.com/repos/civicrm/civicrm-core/commits/70423e0d7732547b95e3d9dd62e00f42b657ad21"},{"sha":"27786d5bda7b5165219205658e03dced02ed7eaa","author":{"name":"Eileen McNaughton","email":"64517a7a8e5ab470725947eb472340f4fbdb9e12@mcnaughty.com"},"message":"Merge pull request #12590 from totten/5.4-flushcache\n\n(dev/core#284) System::flushCache - Reproduce legacy cache behavior. Improve test performance.","distinct":false,"url":"https://api.github.com/repos/civicrm/civicrm-core/commits/27786d5bda7b5165219205658e03dced02ed7eaa"},{"sha":"25833519fc4c33bff4d5ffa1466d3f19821a8efe","author":{"name":"Eileen McNaughton","email":"64517a7a8e5ab470725947eb472340f4fbdb9e12@mcnaughty.com"},"message":"Merge pull request #12592 from civicrm/5.4\n\n5.4 to master","distinct":true,"url":"https://api.github.com/repos/civicrm/civicrm-core/commits/25833519fc4c33bff4d5ffa1466d3f19821a8efe"}]}
{"actor":{"display_login":"eileenmcnaughton"}}