{"action":"created","comment":{"url":"https://api.github.com/repos/ueberauth/ueberauth/pulls/comments/244443737","pull_request_review_id":188391780,"id":244443737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQ0MzczNw==","diff_hunk":"@@ -194,7 +194,7 @@ defmodule Ueberauth do\n   @doc false\n   def init(opts \\\\ []) do\n     {provider_list, opts} = Keyword.pop(opts, :providers, :all)\n-    opts = Keyword.merge(Application.get_env(:ueberauth, Ueberauth), opts)\n+    opts = Keyword.merge(Application.fetch_env!(:ueberauth, Ueberauth), opts)","path":"lib/ueberauth.ex","position":5,"original_position":5,"commit_id":"f50afb7f3b8d016509a06a2fb65e4b7ca998dd20","original_commit_id":"f50afb7f3b8d016509a06a2fb65e4b7ca998dd20","user":{"login":"yordis","id":4237280,"node_id":"MDQ6VXNlcjQyMzcyODA=","avatar_url":"https://avatars0.githubusercontent.com/u/4237280?v=4","gravatar_id":"","url":"https://api.github.com/users/yordis","html_url":"https://github.com/yordis","followers_url":"https://api.github.com/users/yordis/followers","following_url":"https://api.github.com/users/yordis/following{/other_user}","gists_url":"https://api.github.com/users/yordis/gists{/gist_id}","starred_url":"https://api.github.com/users/yordis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yordis/subscriptions","organizations_url":"https://api.github.com/users/yordis/orgs","repos_url":"https://api.github.com/users/yordis/repos","events_url":"https://api.github.com/users/yordis/events{/privacy}","received_events_url":"https://api.github.com/users/yordis/received_events","type":"User","site_admin":false},"body":"Also, this decision is based on the popular for linting `credo`, right now it is disabled, so this is not like my personal opinion only.\r\n\r\nAlso,\r\n\r\n`fetch_env/2` transform two inputs into a keyword list of configuration.\r\n`merge/2` transform two inputs into a single input by merging them together.\r\n\r\nIt is a matter of wording 😄 \r\n\r\nSo what is your definition of transformation?\r\n\r\n> BUT, if you do want this style I'm willing to make the commit.\r\n\r\nYes, please I would prefer if you change it since we will be doing this in the future anyway.\r\n\r\n> It is your library after all. :)\r\n\r\nI would say more our library. Yes, I take the responsibility to maintain it in some cases but do not feel we are authoritarian and everything have to be the way `I` want it, we are a team.\r\n\r\n","created_at":"2018-12-29T02:38:25Z","updated_at":"2018-12-29T02:38:26Z","html_url":"https://github.com/ueberauth/ueberauth/pull/91#discussion_r244443737","pull_request_url":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ueberauth/ueberauth/pulls/comments/244443737"},"html":{"href":"https://github.com/ueberauth/ueberauth/pull/91#discussion_r244443737"},"pull_request":{"href":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91"}},"in_reply_to_id":244442432},"pull_request":{"url":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91","id":241413705,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDEzNzA1","html_url":"https://github.com/ueberauth/ueberauth/pull/91","diff_url":"https://github.com/ueberauth/ueberauth/pull/91.diff","patch_url":"https://github.com/ueberauth/ueberauth/pull/91.patch","issue_url":"https://api.github.com/repos/ueberauth/ueberauth/issues/91","number":91,"state":"open","locked":false,"title":"Added exception for missing configuration.","user":{"login":"janderland","id":2797800,"node_id":"MDQ6VXNlcjI3OTc4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2797800?v=4","gravatar_id":"","url":"https://api.github.com/users/janderland","html_url":"https://github.com/janderland","followers_url":"https://api.github.com/users/janderland/followers","following_url":"https://api.github.com/users/janderland/following{/other_user}","gists_url":"https://api.github.com/users/janderland/gists{/gist_id}","starred_url":"https://api.github.com/users/janderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janderland/subscriptions","organizations_url":"https://api.github.com/users/janderland/orgs","repos_url":"https://api.github.com/users/janderland/repos","events_url":"https://api.github.com/users/janderland/events{/privacy}","received_events_url":"https://api.github.com/users/janderland/received_events","type":"User","site_admin":false},"body":"When building, if Ueberauth configuration isn't present in the\r\napplication environment an exception is now raised.","created_at":"2018-12-29T00:29:48Z","updated_at":"2018-12-29T02:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"815a06e6820231b1daf2e967c56305bb06205ea4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91/commits","review_comments_url":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91/comments","review_comment_url":"https://api.github.com/repos/ueberauth/ueberauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ueberauth/ueberauth/issues/91/comments","statuses_url":"https://api.github.com/repos/ueberauth/ueberauth/statuses/f50afb7f3b8d016509a06a2fb65e4b7ca998dd20","head":{"label":"janderland:raise_for_missing_config","ref":"raise_for_missing_config","sha":"f50afb7f3b8d016509a06a2fb65e4b7ca998dd20","user":{"login":"janderland","id":2797800,"node_id":"MDQ6VXNlcjI3OTc4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2797800?v=4","gravatar_id":"","url":"https://api.github.com/users/janderland","html_url":"https://github.com/janderland","followers_url":"https://api.github.com/users/janderland/followers","following_url":"https://api.github.com/users/janderland/following{/other_user}","gists_url":"https://api.github.com/users/janderland/gists{/gist_id}","starred_url":"https://api.github.com/users/janderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janderland/subscriptions","organizations_url":"https://api.github.com/users/janderland/orgs","repos_url":"https://api.github.com/users/janderland/repos","events_url":"https://api.github.com/users/janderland/events{/privacy}","received_events_url":"https://api.github.com/users/janderland/received_events","type":"User","site_admin":false},"repo":{"id":163439727,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM0Mzk3Mjc=","name":"ueberauth","full_name":"janderland/ueberauth","private":false,"owner":{"login":"janderland","id":2797800,"node_id":"MDQ6VXNlcjI3OTc4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2797800?v=4","gravatar_id":"","url":"https://api.github.com/users/janderland","html_url":"https://github.com/janderland","followers_url":"https://api.github.com/users/janderland/followers","following_url":"https://api.github.com/users/janderland/following{/other_user}","gists_url":"https://api.github.com/users/janderland/gists{/gist_id}","starred_url":"https://api.github.com/users/janderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janderland/subscriptions","organizations_url":"https://api.github.com/users/janderland/orgs","repos_url":"https://api.github.com/users/janderland/repos","events_url":"https://api.github.com/users/janderland/events{/privacy}","received_events_url":"https://api.github.com/users/janderland/received_events","type":"User","site_admin":false},"html_url":"https://github.com/janderland/ueberauth","description":"An Elixir Authentication System for Plug-based Web Applications","fork":true,"url":"https://api.github.com/repos/janderland/ueberauth","forks_url":"https://api.github.com/repos/janderland/ueberauth/forks","keys_url":"https://api.github.com/repos/janderland/ueberauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janderland/ueberauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janderland/ueberauth/teams","hooks_url":"https://api.github.com/repos/janderland/ueberauth/hooks","issue_events_url":"https://api.github.com/repos/janderland/ueberauth/issues/events{/number}","events_url":"https://api.github.com/repos/janderland/ueberauth/events","assignees_url":"https://api.github.com/repos/janderland/ueberauth/assignees{/user}","branches_url":"https://api.github.com/repos/janderland/ueberauth/branches{/branch}","tags_url":"https://api.github.com/repos/janderland/ueberauth/tags","blobs_url":"https://api.github.com/repos/janderland/ueberauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janderland/ueberauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janderland/ueberauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/janderland/ueberauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janderland/ueberauth/statuses/{sha}","languages_url":"https://api.github.com/repos/janderland/ueberauth/languages","stargazers_url":"https://api.github.com/repos/janderland/ueberauth/stargazers","contributors_url":"https://api.github.com/repos/janderland/ueberauth/contributors","subscribers_url":"https://api.github.com/repos/janderland/ueberauth/subscribers","subscription_url":"https://api.github.com/repos/janderland/ueberauth/subscription","commits_url":"https://api.github.com/repos/janderland/ueberauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/janderland/ueberauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/janderland/ueberauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/janderland/ueberauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/janderland/ueberauth/contents/{+path}","compare_url":"https://api.github.com/repos/janderland/ueberauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janderland/ueberauth/merges","archive_url":"https://api.github.com/repos/janderland/ueberauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janderland/ueberauth/downloads","issues_url":"https://api.github.com/repos/janderland/ueberauth/issues{/number}","pulls_url":"https://api.github.com/repos/janderland/ueberauth/pulls{/number}","milestones_url":"https://api.github.com/repos/janderland/ueberauth/milestones{/number}","notifications_url":"https://api.github.com/repos/janderland/ueberauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janderland/ueberauth/labels{/name}","releases_url":"https://api.github.com/repos/janderland/ueberauth/releases{/id}","deployments_url":"https://api.github.com/repos/janderland/ueberauth/deployments","created_at":"2018-12-28T18:41:37Z","updated_at":"2018-12-29T00:28:23Z","pushed_at":"2018-12-29T02:19:32Z","git_url":"git://github.com/janderland/ueberauth.git","ssh_url":"git@github.com:janderland/ueberauth.git","clone_url":"https://github.com/janderland/ueberauth.git","svn_url":"https://github.com/janderland/ueberauth","homepage":"","size":146,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ueberauth:master","ref":"master","sha":"ef79dfe9e395a6865954849369575cd677b2129a","user":{"login":"ueberauth","id":15901600,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTAxNjAw","avatar_url":"https://avatars3.githubusercontent.com/u/15901600?v=4","gravatar_id":"","url":"https://api.github.com/users/ueberauth","html_url":"https://github.com/ueberauth","followers_url":"https://api.github.com/users/ueberauth/followers","following_url":"https://api.github.com/users/ueberauth/following{/other_user}","gists_url":"https://api.github.com/users/ueberauth/gists{/gist_id}","starred_url":"https://api.github.com/users/ueberauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ueberauth/subscriptions","organizations_url":"https://api.github.com/users/ueberauth/orgs","repos_url":"https://api.github.com/users/ueberauth/repos","events_url":"https://api.github.com/users/ueberauth/events{/privacy}","received_events_url":"https://api.github.com/users/ueberauth/received_events","type":"Organization","site_admin":false},"repo":{"id":25178958,"node_id":"MDEwOlJlcG9zaXRvcnkyNTE3ODk1OA==","name":"ueberauth","full_name":"ueberauth/ueberauth","private":false,"owner":{"login":"ueberauth","id":15901600,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTAxNjAw","avatar_url":"https://avatars3.githubusercontent.com/u/15901600?v=4","gravatar_id":"","url":"https://api.github.com/users/ueberauth","html_url":"https://github.com/ueberauth","followers_url":"https://api.github.com/users/ueberauth/followers","following_url":"https://api.github.com/users/ueberauth/following{/other_user}","gists_url":"https://api.github.com/users/ueberauth/gists{/gist_id}","starred_url":"https://api.github.com/users/ueberauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ueberauth/subscriptions","organizations_url":"https://api.github.com/users/ueberauth/orgs","repos_url":"https://api.github.com/users/ueberauth/repos","events_url":"https://api.github.com/users/ueberauth/events{/privacy}","received_events_url":"https://api.github.com/users/ueberauth/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ueberauth/ueberauth","description":"An Elixir Authentication System for Plug-based Web Applications","fork":false,"url":"https://api.github.com/repos/ueberauth/ueberauth","forks_url":"https://api.github.com/repos/ueberauth/ueberauth/forks","keys_url":"https://api.github.com/repos/ueberauth/ueberauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ueberauth/ueberauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ueberauth/ueberauth/teams","hooks_url":"https://api.github.com/repos/ueberauth/ueberauth/hooks","issue_events_url":"https://api.github.com/repos/ueberauth/ueberauth/issues/events{/number}","events_url":"https://api.github.com/repos/ueberauth/ueberauth/events","assignees_url":"https://api.github.com/repos/ueberauth/ueberauth/assignees{/user}","branches_url":"https://api.github.com/repos/ueberauth/ueberauth/branches{/branch}","tags_url":"https://api.github.com/repos/ueberauth/ueberauth/tags","blobs_url":"https://api.github.com/repos/ueberauth/ueberauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ueberauth/ueberauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ueberauth/ueberauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/ueberauth/ueberauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ueberauth/ueberauth/statuses/{sha}","languages_url":"https://api.github.com/repos/ueberauth/ueberauth/languages","stargazers_url":"https://api.github.com/repos/ueberauth/ueberauth/stargazers","contributors_url":"https://api.github.com/repos/ueberauth/ueberauth/contributors","subscribers_url":"https://api.github.com/repos/ueberauth/ueberauth/subscribers","subscription_url":"https://api.github.com/repos/ueberauth/ueberauth/subscription","commits_url":"https://api.github.com/repos/ueberauth/ueberauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/ueberauth/ueberauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/ueberauth/ueberauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/ueberauth/ueberauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/ueberauth/ueberauth/contents/{+path}","compare_url":"https://api.github.com/repos/ueberauth/ueberauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ueberauth/ueberauth/merges","archive_url":"https://api.github.com/repos/ueberauth/ueberauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ueberauth/ueberauth/downloads","issues_url":"https://api.github.com/repos/ueberauth/ueberauth/issues{/number}","pulls_url":"https://api.github.com/repos/ueberauth/ueberauth/pulls{/number}","milestones_url":"https://api.github.com/repos/ueberauth/ueberauth/milestones{/number}","notifications_url":"https://api.github.com/repos/ueberauth/ueberauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ueberauth/ueberauth/labels{/name}","releases_url":"https://api.github.com/repos/ueberauth/ueberauth/releases{/id}","deployments_url":"https://api.github.com/repos/ueberauth/ueberauth/deployments","created_at":"2014-10-13T21:37:35Z","updated_at":"2018-12-28T11:19:02Z","pushed_at":"2018-12-29T02:19:34Z","git_url":"git://github.com/ueberauth/ueberauth.git","ssh_url":"git@github.com:ueberauth/ueberauth.git","clone_url":"https://github.com/ueberauth/ueberauth.git","svn_url":"https://github.com/ueberauth/ueberauth","homepage":"","size":161,"stargazers_count":890,"watchers_count":890,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":60,"open_issues":13,"watchers":890,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91"},"html":{"href":"https://github.com/ueberauth/ueberauth/pull/91"},"issue":{"href":"https://api.github.com/repos/ueberauth/ueberauth/issues/91"},"comments":{"href":"https://api.github.com/repos/ueberauth/ueberauth/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/ueberauth/ueberauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ueberauth/ueberauth/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/ueberauth/ueberauth/statuses/f50afb7f3b8d016509a06a2fb65e4b7ca998dd20"}},"author_association":"NONE"}}
{"actor":{"display_login":"yordis"}}