{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/177605712","pull_request_review_id":107506328,"id":177605712,"diff_hunk":"@@ -51,6 +51,38 @@ func (s *CloudCredentialsSuite) TestUpdateCloudCredentialNew(c *gc.C) {\n \tc.Assert(out, jc.DeepEquals, expected)\n }\n \n+func (s *CloudCredentialsSuite) TesCreateInvalidCredential(c *gc.C) {\n+\terr := s.State.AddCloud(cloud.Cloud{\n+\t\tName:      \"stratus\",\n+\t\tType:      \"low\",\n+\t\tAuthTypes: cloud.AuthTypes{cloud.AccessKeyAuthType, cloud.UserPassAuthType},\n+\t})\n+\tc.Assert(err, jc.ErrorIsNil)\n+\n+\tcred := cloud.NewCredential(cloud.AccessKeyAuthType, map[string]string{\n+\t\t\"foo\": \"foo val\",\n+\t\t\"bar\": \"bar val\",\n+\t})\n+\t// Setting of these properties should have no effect when creating a new credential.\n+\tcred.Invalid = true","path":"state/cloudcredentials_test.go","position":17,"original_position":17,"commit_id":"3449549747c3443a6f6927caeb6414ca3994826a","original_commit_id":"3449549747c3443a6f6927caeb6414ca3994826a","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"If these values are not supposed to be set when creating a new credential, it should error if they are set","created_at":"2018-03-27T23:52:40Z","updated_at":"2018-03-27T23:53:44Z","html_url":"https://github.com/juju/juju/pull/8543#discussion_r177605712","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/8543","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/177605712"},"html":{"href":"https://github.com/juju/juju/pull/8543#discussion_r177605712"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/8543"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/8543","id":177882248,"html_url":"https://github.com/juju/juju/pull/8543","diff_url":"https://github.com/juju/juju/pull/8543.diff","patch_url":"https://github.com/juju/juju/pull/8543.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/8543","number":8543,"state":"open","locked":false,"title":"Adding invalid flag and reason to stored credentials.","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nWe need the ability to invalidate cloud credentials. This PR adds a flag and a reason property at state layer.\r\n\r\n","created_at":"2018-03-27T22:26:19Z","updated_at":"2018-03-27T23:53:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fcc5c2f4db7f58a2b0c1a56c5d6d655786b5cf4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/8543/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/8543/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/8543/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/3449549747c3443a6f6927caeb6414ca3994826a","head":{"label":"anastasiamac:invalid-cred-flag","ref":"invalid-cred-flag","sha":"3449549747c3443a6f6927caeb6414ca3994826a","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"repo":{"id":24841340,"name":"juju","full_name":"anastasiamac/juju","owner":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anastasiamac/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/anastasiamac/juju","forks_url":"https://api.github.com/repos/anastasiamac/juju/forks","keys_url":"https://api.github.com/repos/anastasiamac/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anastasiamac/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anastasiamac/juju/teams","hooks_url":"https://api.github.com/repos/anastasiamac/juju/hooks","issue_events_url":"https://api.github.com/repos/anastasiamac/juju/issues/events{/number}","events_url":"https://api.github.com/repos/anastasiamac/juju/events","assignees_url":"https://api.github.com/repos/anastasiamac/juju/assignees{/user}","branches_url":"https://api.github.com/repos/anastasiamac/juju/branches{/branch}","tags_url":"https://api.github.com/repos/anastasiamac/juju/tags","blobs_url":"https://api.github.com/repos/anastasiamac/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anastasiamac/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anastasiamac/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/anastasiamac/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anastasiamac/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/anastasiamac/juju/languages","stargazers_url":"https://api.github.com/repos/anastasiamac/juju/stargazers","contributors_url":"https://api.github.com/repos/anastasiamac/juju/contributors","subscribers_url":"https://api.github.com/repos/anastasiamac/juju/subscribers","subscription_url":"https://api.github.com/repos/anastasiamac/juju/subscription","commits_url":"https://api.github.com/repos/anastasiamac/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/anastasiamac/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/anastasiamac/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/anastasiamac/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/anastasiamac/juju/contents/{+path}","compare_url":"https://api.github.com/repos/anastasiamac/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anastasiamac/juju/merges","archive_url":"https://api.github.com/repos/anastasiamac/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anastasiamac/juju/downloads","issues_url":"https://api.github.com/repos/anastasiamac/juju/issues{/number}","pulls_url":"https://api.github.com/repos/anastasiamac/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/anastasiamac/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/anastasiamac/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anastasiamac/juju/labels{/name}","releases_url":"https://api.github.com/repos/anastasiamac/juju/releases{/id}","deployments_url":"https://api.github.com/repos/anastasiamac/juju/deployments","created_at":"2014-10-06T10:12:53Z","updated_at":"2016-01-13T06:23:49Z","pushed_at":"2018-03-27T22:18:21Z","git_url":"git://github.com/anastasiamac/juju.git","ssh_url":"git@github.com:anastasiamac/juju.git","clone_url":"https://github.com/anastasiamac/juju.git","svn_url":"https://github.com/anastasiamac/juju","homepage":"juju.ubuntu.com","size":202812,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"14540ef25b8e34fc1ab05ad7435701b82139c12d","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-03-27T23:10:23Z","pushed_at":"2018-03-27T23:10:16Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":207524,"stargazers_count":1124,"watchers_count":1124,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":261,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":261,"open_issues":22,"watchers":1124,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/8543"},"html":{"href":"https://github.com/juju/juju/pull/8543"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/8543"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/8543/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/8543/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/8543/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/3449549747c3443a6f6927caeb6414ca3994826a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wallyworld"}}