{"action":"closed","number":27330,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/27330","id":234399569,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Mzk5NTY5","html_url":"https://github.com/angular/angular/pull/27330","diff_url":"https://github.com/angular/angular/pull/27330.diff","patch_url":"https://github.com/angular/angular/pull/27330.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/27330","number":27330,"state":"closed","locked":false,"title":"fix(ivy): avoid creating self-closing i18n instructions in case we have styling instructions (FW-751)","user":{"login":"AndrewKushnir","id":43554145,"node_id":"MDQ6VXNlcjQzNTU0MTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/43554145?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewKushnir","html_url":"https://github.com/AndrewKushnir","followers_url":"https://api.github.com/users/AndrewKushnir/followers","following_url":"https://api.github.com/users/AndrewKushnir/following{/other_user}","gists_url":"https://api.github.com/users/AndrewKushnir/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewKushnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewKushnir/subscriptions","organizations_url":"https://api.github.com/users/AndrewKushnir/orgs","repos_url":"https://api.github.com/users/AndrewKushnir/repos","events_url":"https://api.github.com/users/AndrewKushnir/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewKushnir/received_events","type":"User","site_admin":false},"body":"This PR adds extra check to make sure we do not create self-closing i18n instructions in case we have styling instructions, since it's breaking runtime logic.\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n- [x] Bugfix\r\n- [ ] Feature\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n- [ ] Yes\r\n- [x] No\r\n","created_at":"2018-11-28T19:38:01Z","updated_at":"2018-11-30T22:05:19Z","closed_at":"2018-11-30T22:05:19Z","merged_at":null,"merge_commit_sha":"7e601bd6c5a7647c832f2c338f30d2ee89c26fb0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":133556520,"node_id":"MDU6TGFiZWwxMzM1NTY1MjA=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":660621334,"node_id":"MDU6TGFiZWw2NjA2MjEzMzQ=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master-only","name":"PR target: master-only","color":"5319e7","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":251048427,"node_id":"MDU6TGFiZWwyNTEwNDg0Mjc=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20i18n","name":"comp: i18n","color":"c7def8","default":false},{"id":130606843,"node_id":"MDU6TGFiZWwxMzA2MDY4NDM=","url":"https://api.github.com/repos/angular/angular/labels/type:%20bug/fix","name":"type: bug/fix","color":"EEEEEE","default":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"node_id":"MDk6TWlsZXN0b25lMzE0Mzg4MA==","number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"node_id":"MDQ6VXNlcjI2NTM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":256,"closed_issues":960,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2018-11-30T22:05:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/27330/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/27330/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/27330/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/d0e076fab21e12bdfd25bd97a479a977f6b649cd","head":{"label":"AndrewKushnir:FW-751_i18n_and_css_classed","ref":"FW-751_i18n_and_css_classed","sha":"d0e076fab21e12bdfd25bd97a479a977f6b649cd","user":{"login":"AndrewKushnir","id":43554145,"node_id":"MDQ6VXNlcjQzNTU0MTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/43554145?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewKushnir","html_url":"https://github.com/AndrewKushnir","followers_url":"https://api.github.com/users/AndrewKushnir/followers","following_url":"https://api.github.com/users/AndrewKushnir/following{/other_user}","gists_url":"https://api.github.com/users/AndrewKushnir/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewKushnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewKushnir/subscriptions","organizations_url":"https://api.github.com/users/AndrewKushnir/orgs","repos_url":"https://api.github.com/users/AndrewKushnir/repos","events_url":"https://api.github.com/users/AndrewKushnir/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewKushnir/received_events","type":"User","site_admin":false},"repo":{"id":150310191,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMTAxOTE=","name":"angular","full_name":"AndrewKushnir/angular","private":false,"owner":{"login":"AndrewKushnir","id":43554145,"node_id":"MDQ6VXNlcjQzNTU0MTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/43554145?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewKushnir","html_url":"https://github.com/AndrewKushnir","followers_url":"https://api.github.com/users/AndrewKushnir/followers","following_url":"https://api.github.com/users/AndrewKushnir/following{/other_user}","gists_url":"https://api.github.com/users/AndrewKushnir/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewKushnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewKushnir/subscriptions","organizations_url":"https://api.github.com/users/AndrewKushnir/orgs","repos_url":"https://api.github.com/users/AndrewKushnir/repos","events_url":"https://api.github.com/users/AndrewKushnir/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewKushnir/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AndrewKushnir/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/AndrewKushnir/angular","forks_url":"https://api.github.com/repos/AndrewKushnir/angular/forks","keys_url":"https://api.github.com/repos/AndrewKushnir/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndrewKushnir/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndrewKushnir/angular/teams","hooks_url":"https://api.github.com/repos/AndrewKushnir/angular/hooks","issue_events_url":"https://api.github.com/repos/AndrewKushnir/angular/issues/events{/number}","events_url":"https://api.github.com/repos/AndrewKushnir/angular/events","assignees_url":"https://api.github.com/repos/AndrewKushnir/angular/assignees{/user}","branches_url":"https://api.github.com/repos/AndrewKushnir/angular/branches{/branch}","tags_url":"https://api.github.com/repos/AndrewKushnir/angular/tags","blobs_url":"https://api.github.com/repos/AndrewKushnir/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndrewKushnir/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndrewKushnir/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndrewKushnir/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndrewKushnir/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/AndrewKushnir/angular/languages","stargazers_url":"https://api.github.com/repos/AndrewKushnir/angular/stargazers","contributors_url":"https://api.github.com/repos/AndrewKushnir/angular/contributors","subscribers_url":"https://api.github.com/repos/AndrewKushnir/angular/subscribers","subscription_url":"https://api.github.com/repos/AndrewKushnir/angular/subscription","commits_url":"https://api.github.com/repos/AndrewKushnir/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndrewKushnir/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndrewKushnir/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndrewKushnir/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndrewKushnir/angular/contents/{+path}","compare_url":"https://api.github.com/repos/AndrewKushnir/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndrewKushnir/angular/merges","archive_url":"https://api.github.com/repos/AndrewKushnir/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndrewKushnir/angular/downloads","issues_url":"https://api.github.com/repos/AndrewKushnir/angular/issues{/number}","pulls_url":"https://api.github.com/repos/AndrewKushnir/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/AndrewKushnir/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/AndrewKushnir/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndrewKushnir/angular/labels{/name}","releases_url":"https://api.github.com/repos/AndrewKushnir/angular/releases{/id}","deployments_url":"https://api.github.com/repos/AndrewKushnir/angular/deployments","created_at":"2018-09-25T18:19:42Z","updated_at":"2018-11-06T19:12:26Z","pushed_at":"2018-11-30T18:55:19Z","git_url":"git://github.com/AndrewKushnir/angular.git","ssh_url":"git@github.com:AndrewKushnir/angular.git","clone_url":"https://github.com/AndrewKushnir/angular.git","svn_url":"https://github.com/AndrewKushnir/angular","homepage":"https://angular.io","size":94210,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"32c5be97b01d07851d2ac4f65b2cfc41cd67cdd5","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-11-30T22:04:36Z","pushed_at":"2018-11-30T22:04:58Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":94988,"stargazers_count":43147,"watchers_count":43147,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10998,"mirror_url":null,"archived":false,"open_issues_count":2589,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10998,"open_issues":2589,"watchers":43147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/27330"},"html":{"href":"https://github.com/angular/angular/pull/27330"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/27330"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/27330/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/27330/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/27330/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/d0e076fab21e12bdfd25bd97a479a977f6b649cd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":35,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"IgorMinar"}}