{"action":"created","comment":{"url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments/190978740","pull_request_review_id":123475991,"id":190978740,"diff_hunk":"@@ -105,20 +105,61 @@ export abstract class ComponentBase<TState, TProps> {\n \t\t\t\t} else if (e.which === Constants.KeyCodes.tab) {\n \t\t\t\t\t// Since they are using the keyboard, revert to the default value of the outline so it is visible\n \t\t\t\t\telement.style.outlineStyle = \"\";\n+\t\t\t\t} else if (e.which === Constants.KeyCodes.up) {\n+\t\t\t\t\tif ( setNameForArrowKeyNav === undefined) {","path":"src/scripts/clipperUI/componentBase.ts","position":30,"original_position":30,"commit_id":"f6e60199f4baed4d6eebe07a9c0f41fb2185d53c","original_commit_id":"f6e60199f4baed4d6eebe07a9c0f41fb2185d53c","user":{"login":"mttwc","id":5062223,"avatar_url":"https://avatars0.githubusercontent.com/u/5062223?v=4","gravatar_id":"","url":"https://api.github.com/users/mttwc","html_url":"https://github.com/mttwc","followers_url":"https://api.github.com/users/mttwc/followers","following_url":"https://api.github.com/users/mttwc/following{/other_user}","gists_url":"https://api.github.com/users/mttwc/gists{/gist_id}","starred_url":"https://api.github.com/users/mttwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mttwc/subscriptions","organizations_url":"https://api.github.com/users/mttwc/orgs","repos_url":"https://api.github.com/users/mttwc/repos","events_url":"https://api.github.com/users/mttwc/events{/privacy}","received_events_url":"https://api.github.com/users/mttwc/received_events","type":"User","site_admin":false},"body":"We should avoid repeated code as much as possible. You can do that by adding the check before checking if e.which === up/down. Also, you should check for null and empty string cases, which can be done with `if (!setNameForArrowKeyNav)","created_at":"2018-05-25T18:40:38Z","updated_at":"2018-05-25T18:44:06Z","html_url":"https://github.com/OneNoteDev/WebClipper/pull/397#discussion_r190978740","pull_request_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments/190978740"},"html":{"href":"https://github.com/OneNoteDev/WebClipper/pull/397#discussion_r190978740"},"pull_request":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397"}}},"pull_request":{"url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397","id":188856080,"html_url":"https://github.com/OneNoteDev/WebClipper/pull/397","diff_url":"https://github.com/OneNoteDev/WebClipper/pull/397.diff","patch_url":"https://github.com/OneNoteDev/WebClipper/pull/397.patch","issue_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/397","number":397,"state":"open","locked":false,"title":"Add groupings for mode selector buttons","user":{"login":"JaneHazen","id":28895742,"avatar_url":"https://avatars1.githubusercontent.com/u/28895742?v=4","gravatar_id":"","url":"https://api.github.com/users/JaneHazen","html_url":"https://github.com/JaneHazen","followers_url":"https://api.github.com/users/JaneHazen/followers","following_url":"https://api.github.com/users/JaneHazen/following{/other_user}","gists_url":"https://api.github.com/users/JaneHazen/gists{/gist_id}","starred_url":"https://api.github.com/users/JaneHazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaneHazen/subscriptions","organizations_url":"https://api.github.com/users/JaneHazen/orgs","repos_url":"https://api.github.com/users/JaneHazen/repos","events_url":"https://api.github.com/users/JaneHazen/events{/privacy}","received_events_url":"https://api.github.com/users/JaneHazen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-17T20:43:54Z","updated_at":"2018-05-25T18:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"007ae82dae717c699c1d2c52030288ca5cd3664e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397/commits","review_comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397/comments","review_comment_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/397/comments","statuses_url":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/f6e60199f4baed4d6eebe07a9c0f41fb2185d53c","head":{"label":"OneNoteDev:addGroupingsForModeSelectorButtons","ref":"addGroupingsForModeSelectorButtons","sha":"f6e60199f4baed4d6eebe07a9c0f41fb2185d53c","user":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars3.githubusercontent.com/u/6225732?v=4","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"repo":{"id":66974243,"name":"WebClipper","full_name":"OneNoteDev/WebClipper","owner":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars3.githubusercontent.com/u/6225732?v=4","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneNoteDev/WebClipper","description":"The OneNote Web Clipper extension","fork":false,"url":"https://api.github.com/repos/OneNoteDev/WebClipper","forks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/forks","keys_url":"https://api.github.com/repos/OneNoteDev/WebClipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneNoteDev/WebClipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneNoteDev/WebClipper/teams","hooks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/hooks","issue_events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/events{/number}","events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/events","assignees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/assignees{/user}","branches_url":"https://api.github.com/repos/OneNoteDev/WebClipper/branches{/branch}","tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/tags","blobs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/{sha}","languages_url":"https://api.github.com/repos/OneNoteDev/WebClipper/languages","stargazers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/stargazers","contributors_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contributors","subscribers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscribers","subscription_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscription","commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contents/{+path}","compare_url":"https://api.github.com/repos/OneNoteDev/WebClipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneNoteDev/WebClipper/merges","archive_url":"https://api.github.com/repos/OneNoteDev/WebClipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneNoteDev/WebClipper/downloads","issues_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues{/number}","pulls_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls{/number}","milestones_url":"https://api.github.com/repos/OneNoteDev/WebClipper/milestones{/number}","notifications_url":"https://api.github.com/repos/OneNoteDev/WebClipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneNoteDev/WebClipper/labels{/name}","releases_url":"https://api.github.com/repos/OneNoteDev/WebClipper/releases{/id}","deployments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/deployments","created_at":"2016-08-30T20:11:15Z","updated_at":"2018-05-05T09:54:51Z","pushed_at":"2018-05-25T18:23:00Z","git_url":"git://github.com/OneNoteDev/WebClipper.git","ssh_url":"git@github.com:OneNoteDev/WebClipper.git","clone_url":"https://github.com/OneNoteDev/WebClipper.git","svn_url":"https://github.com/OneNoteDev/WebClipper","homepage":"https://www.onenote.com/clipper","size":6060,"stargazers_count":111,"watchers_count":111,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":28,"open_issues":71,"watchers":111,"default_branch":"master"}},"base":{"label":"OneNoteDev:master","ref":"master","sha":"7c2d21f56ecf55911d5c2f4fe520b2868d6ab4da","user":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars3.githubusercontent.com/u/6225732?v=4","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"repo":{"id":66974243,"name":"WebClipper","full_name":"OneNoteDev/WebClipper","owner":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars3.githubusercontent.com/u/6225732?v=4","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneNoteDev/WebClipper","description":"The OneNote Web Clipper extension","fork":false,"url":"https://api.github.com/repos/OneNoteDev/WebClipper","forks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/forks","keys_url":"https://api.github.com/repos/OneNoteDev/WebClipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneNoteDev/WebClipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneNoteDev/WebClipper/teams","hooks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/hooks","issue_events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/events{/number}","events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/events","assignees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/assignees{/user}","branches_url":"https://api.github.com/repos/OneNoteDev/WebClipper/branches{/branch}","tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/tags","blobs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/{sha}","languages_url":"https://api.github.com/repos/OneNoteDev/WebClipper/languages","stargazers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/stargazers","contributors_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contributors","subscribers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscribers","subscription_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscription","commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contents/{+path}","compare_url":"https://api.github.com/repos/OneNoteDev/WebClipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneNoteDev/WebClipper/merges","archive_url":"https://api.github.com/repos/OneNoteDev/WebClipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneNoteDev/WebClipper/downloads","issues_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues{/number}","pulls_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls{/number}","milestones_url":"https://api.github.com/repos/OneNoteDev/WebClipper/milestones{/number}","notifications_url":"https://api.github.com/repos/OneNoteDev/WebClipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneNoteDev/WebClipper/labels{/name}","releases_url":"https://api.github.com/repos/OneNoteDev/WebClipper/releases{/id}","deployments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/deployments","created_at":"2016-08-30T20:11:15Z","updated_at":"2018-05-05T09:54:51Z","pushed_at":"2018-05-25T18:23:00Z","git_url":"git://github.com/OneNoteDev/WebClipper.git","ssh_url":"git@github.com:OneNoteDev/WebClipper.git","clone_url":"https://github.com/OneNoteDev/WebClipper.git","svn_url":"https://github.com/OneNoteDev/WebClipper","homepage":"https://www.onenote.com/clipper","size":6060,"stargazers_count":111,"watchers_count":111,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":28,"open_issues":71,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397"},"html":{"href":"https://github.com/OneNoteDev/WebClipper/pull/397"},"issue":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/397"},"comments":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/f6e60199f4baed4d6eebe07a9c0f41fb2185d53c"}},"author_association":"NONE"}}
{"actor":{"display_login":"mttwc"}}