{"action":"created","comment":{"url":"https://api.github.com/repos/rancher/rancher/pulls/comments/205579862","pull_request_review_id":140881107,"id":205579862,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTU3OTg2Mg==","diff_hunk":"@@ -65,9 +65,7 @@ fi\n set -e -x\n REGISTRY=$1\n \n-docker load --input rancher-images.tar.gz","path":"pkg/image/export/main.go","position":4,"original_position":4,"commit_id":"9483b291742eb22da85523f2dd6bc4888fbc058f","original_commit_id":"f164240209d1fa3f5caf36c65d587f3994dc870e","user":{"login":"mrajashree","id":10672776,"node_id":"MDQ6VXNlcjEwNjcyNzc2","avatar_url":"https://avatars2.githubusercontent.com/u/10672776?v=4","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"body":"@ibuildthecloud `go fmt` was throwing an error during drone build, that's why I couldn't not remove that line, but like you said I have added new line separately. Also I noticed  that the drone build has a couple of warnings like this initially\r\n```\r\n/tmp/go-link-559689336/000024.o: In function `_cgo_a5acef59ed3f_Cfunc_dlopen':\r\n/tmp/go-build/cgo-gcc-prolog:76: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking\r\n/tmp/go-link-559689336/000019.o: In function `mygetgrouplist':\r\n/workdir/go/src/os/user/getgrouplist_unix.go:15: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking\r\n```\r\nBut the build is still passing. Is that okay?\r\n","created_at":"2018-07-26T19:44:01Z","updated_at":"2018-07-26T19:44:01Z","html_url":"https://github.com/rancher/rancher/pull/14707#discussion_r205579862","pull_request_url":"https://api.github.com/repos/rancher/rancher/pulls/14707","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments/205579862"},"html":{"href":"https://github.com/rancher/rancher/pull/14707#discussion_r205579862"},"pull_request":{"href":"https://api.github.com/repos/rancher/rancher/pulls/14707"}},"in_reply_to_id":205529836},"pull_request":{"url":"https://api.github.com/repos/rancher/rancher/pulls/14707","id":203379033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzc5MDMz","html_url":"https://github.com/rancher/rancher/pull/14707","diff_url":"https://github.com/rancher/rancher/pull/14707.diff","patch_url":"https://github.com/rancher/rancher/pull/14707.patch","issue_url":"https://api.github.com/repos/rancher/rancher/issues/14707","number":14707,"state":"open","locked":false,"title":"Update golang version to fix golang TLS issue for AD","user":{"login":"mrajashree","id":10672776,"node_id":"MDQ6VXNlcjEwNjcyNzc2","avatar_url":"https://avatars2.githubusercontent.com/u/10672776?v=4","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"body":"https://github.com/rancher/rancher/issues/14502\r\n\r\nAfter updating to go1.10.3, the CGO_ENABLED=0 part of build command\r\nin build-server script threw this error \"loadinternal: cannot find runtime/cgo\"\r\nand then that would eventually lead to a segmentation fault. The build\r\nwould just freeze without running any tests. This commit removes CGO_ENABLED=0,\r\nsince cgo is disabled by default when cross compiling, as per https://golang.org/cmd/cgo/\r\nf164240","created_at":"2018-07-24T00:28:44Z","updated_at":"2018-07-26T19:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86a0e9e07cf0768d865bf6eebee3bf3765a4ce55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/rancher/pulls/14707/commits","review_comments_url":"https://api.github.com/repos/rancher/rancher/pulls/14707/comments","review_comment_url":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/rancher/issues/14707/comments","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/9483b291742eb22da85523f2dd6bc4888fbc058f","head":{"label":"mrajashree:updateGolang","ref":"updateGolang","sha":"9483b291742eb22da85523f2dd6bc4888fbc058f","user":{"login":"mrajashree","id":10672776,"node_id":"MDQ6VXNlcjEwNjcyNzc2","avatar_url":"https://avatars2.githubusercontent.com/u/10672776?v=4","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"repo":{"id":127054405,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwNTQ0MDU=","name":"rancher","full_name":"mrajashree/rancher","owner":{"login":"mrajashree","id":10672776,"node_id":"MDQ6VXNlcjEwNjcyNzc2","avatar_url":"https://avatars2.githubusercontent.com/u/10672776?v=4","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrajashree/rancher","description":"Complete container management platform","fork":true,"url":"https://api.github.com/repos/mrajashree/rancher","forks_url":"https://api.github.com/repos/mrajashree/rancher/forks","keys_url":"https://api.github.com/repos/mrajashree/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrajashree/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrajashree/rancher/teams","hooks_url":"https://api.github.com/repos/mrajashree/rancher/hooks","issue_events_url":"https://api.github.com/repos/mrajashree/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/mrajashree/rancher/events","assignees_url":"https://api.github.com/repos/mrajashree/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/mrajashree/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/mrajashree/rancher/tags","blobs_url":"https://api.github.com/repos/mrajashree/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrajashree/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrajashree/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrajashree/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrajashree/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/mrajashree/rancher/languages","stargazers_url":"https://api.github.com/repos/mrajashree/rancher/stargazers","contributors_url":"https://api.github.com/repos/mrajashree/rancher/contributors","subscribers_url":"https://api.github.com/repos/mrajashree/rancher/subscribers","subscription_url":"https://api.github.com/repos/mrajashree/rancher/subscription","commits_url":"https://api.github.com/repos/mrajashree/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrajashree/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrajashree/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrajashree/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrajashree/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/mrajashree/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrajashree/rancher/merges","archive_url":"https://api.github.com/repos/mrajashree/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrajashree/rancher/downloads","issues_url":"https://api.github.com/repos/mrajashree/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/mrajashree/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/mrajashree/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/mrajashree/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrajashree/rancher/labels{/name}","releases_url":"https://api.github.com/repos/mrajashree/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/mrajashree/rancher/deployments","created_at":"2018-03-27T22:47:13Z","updated_at":"2018-03-27T22:47:17Z","pushed_at":"2018-07-26T18:24:19Z","git_url":"git://github.com/mrajashree/rancher.git","ssh_url":"git@github.com:mrajashree/rancher.git","clone_url":"https://github.com/mrajashree/rancher.git","svn_url":"https://github.com/mrajashree/rancher","homepage":"http://rancher.com","size":38445,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"4ac76f41ed7246d31dc5f9d11528aacca4bece3f","user":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":26337322,"node_id":"MDEwOlJlcG9zaXRvcnkyNjMzNzMyMg==","name":"rancher","full_name":"rancher/rancher","owner":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/rancher","description":"Complete container management platform","fork":false,"url":"https://api.github.com/repos/rancher/rancher","forks_url":"https://api.github.com/repos/rancher/rancher/forks","keys_url":"https://api.github.com/repos/rancher/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/rancher/teams","hooks_url":"https://api.github.com/repos/rancher/rancher/hooks","issue_events_url":"https://api.github.com/repos/rancher/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/rancher/events","assignees_url":"https://api.github.com/repos/rancher/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/rancher/tags","blobs_url":"https://api.github.com/repos/rancher/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/rancher/languages","stargazers_url":"https://api.github.com/repos/rancher/rancher/stargazers","contributors_url":"https://api.github.com/repos/rancher/rancher/contributors","subscribers_url":"https://api.github.com/repos/rancher/rancher/subscribers","subscription_url":"https://api.github.com/repos/rancher/rancher/subscription","commits_url":"https://api.github.com/repos/rancher/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/rancher/merges","archive_url":"https://api.github.com/repos/rancher/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/rancher/downloads","issues_url":"https://api.github.com/repos/rancher/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/rancher/labels{/name}","releases_url":"https://api.github.com/repos/rancher/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/rancher/deployments","created_at":"2014-11-07T20:49:31Z","updated_at":"2018-07-26T18:30:12Z","pushed_at":"2018-07-26T18:24:20Z","git_url":"git://github.com/rancher/rancher.git","ssh_url":"git@github.com:rancher/rancher.git","clone_url":"https://github.com/rancher/rancher.git","svn_url":"https://github.com/rancher/rancher","homepage":"http://rancher.com","size":38496,"stargazers_count":9160,"watchers_count":9160,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":912,"mirror_url":null,"archived":false,"open_issues_count":2321,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":912,"open_issues":2321,"watchers":9160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/14707"},"html":{"href":"https://github.com/rancher/rancher/pull/14707"},"issue":{"href":"https://api.github.com/repos/rancher/rancher/issues/14707"},"comments":{"href":"https://api.github.com/repos/rancher/rancher/issues/14707/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/rancher/pulls/14707/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/rancher/pulls/14707/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/rancher/statuses/9483b291742eb22da85523f2dd6bc4888fbc058f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mrajashree"}}