{"action":"created","comment":{"url":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/comments/187469511","pull_request_review_id":119257558,"id":187469511,"diff_hunk":"@@ -22,18 +27,40 @@\n     webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT,\n     properties = {\n         \"vep.url=http://grch37.rest.ensembl.org/vep/human/hgvs/VARIANT?content-type=application/json&xref_refseq=1&ccds=1&canonical=1&domains=1&hgvs=1&numbers=1&protein=1\",\n-        \"hotspots.url=https://www.cancerhotspots.org/api/hotspots/single/\",\n-        \"hotspots.3d.url=https://www.3dhotspots.org/api/hotspots/3d/\",\n         \"spring.data.mongodb.uri=mongodb://localhost/integration\",\n         \"server.port=38888\"\n     }\n )\n public class CancerHotspotsIntegrationTest\n {\n+    private static List<Hotspot> HOTSPOTS;\n+\n+    @BeforeClass\n+    public static void readMockFile() throws IOException\n+    {\n+        JsonToObjectMapper objectMapper = new JsonToObjectMapper();\n+        // reading the entire DB dump for a full scale test\n+        HOTSPOTS = objectMapper.readHotspots(\"hotspots_db_dump.json\");","path":"web/src/test/java/org/cbioportal/genome_nexus/web/CancerHotspotsIntegrationTest.java","position":39,"original_position":39,"commit_id":"15115c47275a8f5d38ebf390b9bd50df21c363c9","original_commit_id":"15115c47275a8f5d38ebf390b9bd50df21c363c9","user":{"login":"onursumer","id":3604198,"avatar_url":"https://avatars2.githubusercontent.com/u/3604198?v=4","gravatar_id":"","url":"https://api.github.com/users/onursumer","html_url":"https://github.com/onursumer","followers_url":"https://api.github.com/users/onursumer/followers","following_url":"https://api.github.com/users/onursumer/following{/other_user}","gists_url":"https://api.github.com/users/onursumer/gists{/gist_id}","starred_url":"https://api.github.com/users/onursumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onursumer/subscriptions","organizations_url":"https://api.github.com/users/onursumer/orgs","repos_url":"https://api.github.com/users/onursumer/repos","events_url":"https://api.github.com/users/onursumer/events{/privacy}","received_events_url":"https://api.github.com/users/onursumer/received_events","type":"User","site_admin":false},"body":"Reading a `json` dump into memory first as `Hotspot` instances, and then inserting into the DB. There might be a faster, more straightforward way to do this.","created_at":"2018-05-10T21:46:32Z","updated_at":"2018-05-10T21:50:00Z","html_url":"https://github.com/genome-nexus/genome-nexus/pull/181#discussion_r187469511","pull_request_url":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/comments/187469511"},"html":{"href":"https://github.com/genome-nexus/genome-nexus/pull/181#discussion_r187469511"},"pull_request":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181","id":187282328,"html_url":"https://github.com/genome-nexus/genome-nexus/pull/181","diff_url":"https://github.com/genome-nexus/genome-nexus/pull/181.diff","patch_url":"https://github.com/genome-nexus/genome-nexus/pull/181.patch","issue_url":"https://api.github.com/repos/genome-nexus/genome-nexus/issues/181","number":181,"state":"open","locked":false,"title":"Cancer Hotspots endpoint improvements","user":{"login":"onursumer","id":3604198,"avatar_url":"https://avatars2.githubusercontent.com/u/3604198?v=4","gravatar_id":"","url":"https://api.github.com/users/onursumer","html_url":"https://github.com/onursumer","followers_url":"https://api.github.com/users/onursumer/followers","following_url":"https://api.github.com/users/onursumer/following{/other_user}","gists_url":"https://api.github.com/users/onursumer/gists{/gist_id}","starred_url":"https://api.github.com/users/onursumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onursumer/subscriptions","organizations_url":"https://api.github.com/users/onursumer/orgs","repos_url":"https://api.github.com/users/onursumer/repos","events_url":"https://api.github.com/users/onursumer/events{/privacy}","received_events_url":"https://api.github.com/users/onursumer/received_events","type":"User","site_admin":false},"body":"- Completely decoupled Genome Nexus from Cancer Hotspots Web API\r\n- Using database instead of in-memory cache for cancer hotspots (we need a separate PR for the importer to import hotspot data)\r\n- Added more hotspot filter criteria: `missense_fraction >= 25% && missense_count > 1`","created_at":"2018-05-10T19:21:05Z","updated_at":"2018-05-10T21:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9685f2e3a7645817af3e2a1d3fa19e380b6aa75","assignee":null,"assignees":[],"requested_reviewers":[{"login":"inodb","id":1334004,"avatar_url":"https://avatars3.githubusercontent.com/u/1334004?v=4","gravatar_id":"","url":"https://api.github.com/users/inodb","html_url":"https://github.com/inodb","followers_url":"https://api.github.com/users/inodb/followers","following_url":"https://api.github.com/users/inodb/following{/other_user}","gists_url":"https://api.github.com/users/inodb/gists{/gist_id}","starred_url":"https://api.github.com/users/inodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inodb/subscriptions","organizations_url":"https://api.github.com/users/inodb/orgs","repos_url":"https://api.github.com/users/inodb/repos","events_url":"https://api.github.com/users/inodb/events{/privacy}","received_events_url":"https://api.github.com/users/inodb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181/commits","review_comments_url":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181/comments","review_comment_url":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genome-nexus/genome-nexus/issues/181/comments","statuses_url":"https://api.github.com/repos/genome-nexus/genome-nexus/statuses/15115c47275a8f5d38ebf390b9bd50df21c363c9","head":{"label":"onursumer:cancer-hotspots-categorized","ref":"cancer-hotspots-categorized","sha":"15115c47275a8f5d38ebf390b9bd50df21c363c9","user":{"login":"onursumer","id":3604198,"avatar_url":"https://avatars2.githubusercontent.com/u/3604198?v=4","gravatar_id":"","url":"https://api.github.com/users/onursumer","html_url":"https://github.com/onursumer","followers_url":"https://api.github.com/users/onursumer/followers","following_url":"https://api.github.com/users/onursumer/following{/other_user}","gists_url":"https://api.github.com/users/onursumer/gists{/gist_id}","starred_url":"https://api.github.com/users/onursumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onursumer/subscriptions","organizations_url":"https://api.github.com/users/onursumer/orgs","repos_url":"https://api.github.com/users/onursumer/repos","events_url":"https://api.github.com/users/onursumer/events{/privacy}","received_events_url":"https://api.github.com/users/onursumer/received_events","type":"User","site_admin":false},"repo":{"id":47205128,"name":"genome-nexus","full_name":"onursumer/genome-nexus","owner":{"login":"onursumer","id":3604198,"avatar_url":"https://avatars2.githubusercontent.com/u/3604198?v=4","gravatar_id":"","url":"https://api.github.com/users/onursumer","html_url":"https://github.com/onursumer","followers_url":"https://api.github.com/users/onursumer/followers","following_url":"https://api.github.com/users/onursumer/following{/other_user}","gists_url":"https://api.github.com/users/onursumer/gists{/gist_id}","starred_url":"https://api.github.com/users/onursumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onursumer/subscriptions","organizations_url":"https://api.github.com/users/onursumer/orgs","repos_url":"https://api.github.com/users/onursumer/repos","events_url":"https://api.github.com/users/onursumer/events{/privacy}","received_events_url":"https://api.github.com/users/onursumer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onursumer/genome-nexus","description":"Interpreting cancer genomics data","fork":true,"url":"https://api.github.com/repos/onursumer/genome-nexus","forks_url":"https://api.github.com/repos/onursumer/genome-nexus/forks","keys_url":"https://api.github.com/repos/onursumer/genome-nexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onursumer/genome-nexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onursumer/genome-nexus/teams","hooks_url":"https://api.github.com/repos/onursumer/genome-nexus/hooks","issue_events_url":"https://api.github.com/repos/onursumer/genome-nexus/issues/events{/number}","events_url":"https://api.github.com/repos/onursumer/genome-nexus/events","assignees_url":"https://api.github.com/repos/onursumer/genome-nexus/assignees{/user}","branches_url":"https://api.github.com/repos/onursumer/genome-nexus/branches{/branch}","tags_url":"https://api.github.com/repos/onursumer/genome-nexus/tags","blobs_url":"https://api.github.com/repos/onursumer/genome-nexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onursumer/genome-nexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onursumer/genome-nexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/onursumer/genome-nexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onursumer/genome-nexus/statuses/{sha}","languages_url":"https://api.github.com/repos/onursumer/genome-nexus/languages","stargazers_url":"https://api.github.com/repos/onursumer/genome-nexus/stargazers","contributors_url":"https://api.github.com/repos/onursumer/genome-nexus/contributors","subscribers_url":"https://api.github.com/repos/onursumer/genome-nexus/subscribers","subscription_url":"https://api.github.com/repos/onursumer/genome-nexus/subscription","commits_url":"https://api.github.com/repos/onursumer/genome-nexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/onursumer/genome-nexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/onursumer/genome-nexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/onursumer/genome-nexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/onursumer/genome-nexus/contents/{+path}","compare_url":"https://api.github.com/repos/onursumer/genome-nexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onursumer/genome-nexus/merges","archive_url":"https://api.github.com/repos/onursumer/genome-nexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onursumer/genome-nexus/downloads","issues_url":"https://api.github.com/repos/onursumer/genome-nexus/issues{/number}","pulls_url":"https://api.github.com/repos/onursumer/genome-nexus/pulls{/number}","milestones_url":"https://api.github.com/repos/onursumer/genome-nexus/milestones{/number}","notifications_url":"https://api.github.com/repos/onursumer/genome-nexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onursumer/genome-nexus/labels{/name}","releases_url":"https://api.github.com/repos/onursumer/genome-nexus/releases{/id}","deployments_url":"https://api.github.com/repos/onursumer/genome-nexus/deployments","created_at":"2015-12-01T17:15:20Z","updated_at":"2018-05-08T19:42:56Z","pushed_at":"2018-05-10T21:17:57Z","git_url":"git://github.com/onursumer/genome-nexus.git","ssh_url":"git@github.com:onursumer/genome-nexus.git","clone_url":"https://github.com/onursumer/genome-nexus.git","svn_url":"https://github.com/onursumer/genome-nexus","homepage":null,"size":16288,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genome-nexus:master","ref":"master","sha":"eb90a5c4d88c3eed2a5478608d076284825a90e6","user":{"login":"genome-nexus","id":25486173,"avatar_url":"https://avatars0.githubusercontent.com/u/25486173?v=4","gravatar_id":"","url":"https://api.github.com/users/genome-nexus","html_url":"https://github.com/genome-nexus","followers_url":"https://api.github.com/users/genome-nexus/followers","following_url":"https://api.github.com/users/genome-nexus/following{/other_user}","gists_url":"https://api.github.com/users/genome-nexus/gists{/gist_id}","starred_url":"https://api.github.com/users/genome-nexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome-nexus/subscriptions","organizations_url":"https://api.github.com/users/genome-nexus/orgs","repos_url":"https://api.github.com/users/genome-nexus/repos","events_url":"https://api.github.com/users/genome-nexus/events{/privacy}","received_events_url":"https://api.github.com/users/genome-nexus/received_events","type":"Organization","site_admin":false},"repo":{"id":42591563,"name":"genome-nexus","full_name":"genome-nexus/genome-nexus","owner":{"login":"genome-nexus","id":25486173,"avatar_url":"https://avatars0.githubusercontent.com/u/25486173?v=4","gravatar_id":"","url":"https://api.github.com/users/genome-nexus","html_url":"https://github.com/genome-nexus","followers_url":"https://api.github.com/users/genome-nexus/followers","following_url":"https://api.github.com/users/genome-nexus/following{/other_user}","gists_url":"https://api.github.com/users/genome-nexus/gists{/gist_id}","starred_url":"https://api.github.com/users/genome-nexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome-nexus/subscriptions","organizations_url":"https://api.github.com/users/genome-nexus/orgs","repos_url":"https://api.github.com/users/genome-nexus/repos","events_url":"https://api.github.com/users/genome-nexus/events{/privacy}","received_events_url":"https://api.github.com/users/genome-nexus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genome-nexus/genome-nexus","description":"Interpreting cancer genomics data","fork":false,"url":"https://api.github.com/repos/genome-nexus/genome-nexus","forks_url":"https://api.github.com/repos/genome-nexus/genome-nexus/forks","keys_url":"https://api.github.com/repos/genome-nexus/genome-nexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genome-nexus/genome-nexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genome-nexus/genome-nexus/teams","hooks_url":"https://api.github.com/repos/genome-nexus/genome-nexus/hooks","issue_events_url":"https://api.github.com/repos/genome-nexus/genome-nexus/issues/events{/number}","events_url":"https://api.github.com/repos/genome-nexus/genome-nexus/events","assignees_url":"https://api.github.com/repos/genome-nexus/genome-nexus/assignees{/user}","branches_url":"https://api.github.com/repos/genome-nexus/genome-nexus/branches{/branch}","tags_url":"https://api.github.com/repos/genome-nexus/genome-nexus/tags","blobs_url":"https://api.github.com/repos/genome-nexus/genome-nexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genome-nexus/genome-nexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genome-nexus/genome-nexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/genome-nexus/genome-nexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genome-nexus/genome-nexus/statuses/{sha}","languages_url":"https://api.github.com/repos/genome-nexus/genome-nexus/languages","stargazers_url":"https://api.github.com/repos/genome-nexus/genome-nexus/stargazers","contributors_url":"https://api.github.com/repos/genome-nexus/genome-nexus/contributors","subscribers_url":"https://api.github.com/repos/genome-nexus/genome-nexus/subscribers","subscription_url":"https://api.github.com/repos/genome-nexus/genome-nexus/subscription","commits_url":"https://api.github.com/repos/genome-nexus/genome-nexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/genome-nexus/genome-nexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/genome-nexus/genome-nexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/genome-nexus/genome-nexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/genome-nexus/genome-nexus/contents/{+path}","compare_url":"https://api.github.com/repos/genome-nexus/genome-nexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genome-nexus/genome-nexus/merges","archive_url":"https://api.github.com/repos/genome-nexus/genome-nexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genome-nexus/genome-nexus/downloads","issues_url":"https://api.github.com/repos/genome-nexus/genome-nexus/issues{/number}","pulls_url":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls{/number}","milestones_url":"https://api.github.com/repos/genome-nexus/genome-nexus/milestones{/number}","notifications_url":"https://api.github.com/repos/genome-nexus/genome-nexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genome-nexus/genome-nexus/labels{/name}","releases_url":"https://api.github.com/repos/genome-nexus/genome-nexus/releases{/id}","deployments_url":"https://api.github.com/repos/genome-nexus/genome-nexus/deployments","created_at":"2015-09-16T14:16:27Z","updated_at":"2018-05-09T22:23:07Z","pushed_at":"2018-05-10T21:17:58Z","git_url":"git://github.com/genome-nexus/genome-nexus.git","ssh_url":"git@github.com:genome-nexus/genome-nexus.git","clone_url":"https://github.com/genome-nexus/genome-nexus.git","svn_url":"https://github.com/genome-nexus/genome-nexus","homepage":"http://genomenexus.org","size":16236,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":15,"open_issues":48,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181"},"html":{"href":"https://github.com/genome-nexus/genome-nexus/pull/181"},"issue":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/issues/181"},"comments":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/genome-nexus/genome-nexus/statuses/15115c47275a8f5d38ebf390b9bd50df21c363c9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"onursumer"}}