{"action":"created","issue":{"url":"https://api.github.com/repos/wala/WALA/issues/278","repository_url":"https://api.github.com/repos/wala/WALA","labels_url":"https://api.github.com/repos/wala/WALA/issues/278/labels{/name}","comments_url":"https://api.github.com/repos/wala/WALA/issues/278/comments","events_url":"https://api.github.com/repos/wala/WALA/issues/278/events","html_url":"https://github.com/wala/WALA/pull/278","id":284583970,"number":278,"title":"Build WALA using Gradle instead of Maven","user":{"login":"liblit","id":1759836,"avatar_url":"https://avatars3.githubusercontent.com/u/1759836?v=4","gravatar_id":"","url":"https://api.github.com/users/liblit","html_url":"https://github.com/liblit","followers_url":"https://api.github.com/users/liblit/followers","following_url":"https://api.github.com/users/liblit/following{/other_user}","gists_url":"https://api.github.com/users/liblit/gists{/gist_id}","starred_url":"https://api.github.com/users/liblit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liblit/subscriptions","organizations_url":"https://api.github.com/users/liblit/orgs","repos_url":"https://api.github.com/users/liblit/repos","events_url":"https://api.github.com/users/liblit/events{/privacy}","received_events_url":"https://api.github.com/users/liblit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-12-26T17:08:40Z","updated_at":"2018-04-14T01:05:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wala/WALA/pulls/278","html_url":"https://github.com/wala/WALA/pull/278","diff_url":"https://github.com/wala/WALA/pull/278.diff","patch_url":"https://github.com/wala/WALA/pull/278.patch"},"body":"This pull request represents work-in-progress to convert WALA’s build system from Maven to Gradle. It also adds support for Eclipse’s Buildship plugin for better Eclipse/Gradle integration.\r\n\r\nWe still have much left to do before Gradle can truly replace Maven. However, @msridhar [suggested](https://github.com/wala/WALA/pull/267#issuecomment-353740080) that a premature pull request would still be useful “for visibility / easy commenting,” so that is what we have here. I will keep working on this as time permits, but I make no exclusive claim to it. I welcome pull requests and constructive comments from any and all! I am very new to Gradle, and there are surely better ways to do some of what I am doing here. Please help me make things better.\r\n\r\nBig thanks to @SunghoLee for getting us started down this path!"},"comment":{"url":"https://api.github.com/repos/wala/WALA/issues/comments/381292699","html_url":"https://github.com/wala/WALA/pull/278#issuecomment-381292699","issue_url":"https://api.github.com/repos/wala/WALA/issues/278","id":381292699,"user":{"login":"liblit","id":1759836,"avatar_url":"https://avatars3.githubusercontent.com/u/1759836?v=4","gravatar_id":"","url":"https://api.github.com/users/liblit","html_url":"https://github.com/liblit","followers_url":"https://api.github.com/users/liblit/followers","following_url":"https://api.github.com/users/liblit/following{/other_user}","gists_url":"https://api.github.com/users/liblit/gists{/gist_id}","starred_url":"https://api.github.com/users/liblit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liblit/subscriptions","organizations_url":"https://api.github.com/users/liblit/orgs","repos_url":"https://api.github.com/users/liblit/repos","events_url":"https://api.github.com/users/liblit/events{/privacy}","received_events_url":"https://api.github.com/users/liblit/received_events","type":"User","site_admin":false},"created_at":"2018-04-14T01:05:06Z","updated_at":"2018-04-14T01:05:06Z","author_association":"CONTRIBUTOR","body":"@juliandolby, thank you for giving this your attention.\r\n\r\nIf the [failures of some Eclipse-related tests under Maven](https://github.com/wala/WALA/pull/278#issuecomment-375141177) do not concern you, then I propose that we disable these tests in the appropriate `pom.xml` files. That way Maven Travis CI testing goes back to passing status for the tests that remain. I am happy to implement this if you agree that I should.\r\n\r\nThose Eclipse-related concerns aside, yes: to the best of my knowledge, `mvn clean install -DskipTests` will still work as before. Per the second paragraph of [my discussion of known shortcomings](https://github.com/liblit/WALA/blob/gradle-and-buildship/README-Gradle.md#known-shortcomings), either Gradle or Maven can be used to build WALA from the command line. Building in Eclipse does not offer both options, but the command line does. I believe that I have kept `mvn clean install -DskipTests` working as it always did. That being said, it certainly wouldn’t hurt to actually try out some of these “various GitHub projects that use WALA and are tested using Maven build scripts on Travis” to see whether they still work if changed to use my `gradle-and-buildship` branch instead of WALA `master`.\r\n\r\nTwo other thoughts if we may finally be on the cusp of merging this pull request:\r\n\r\n1. This may warrant bumping the minor version number from `1.4.4-SNAPSHOT` to `1.5-SNAPSHOT`. That leaves you the option of doing future `1.4.5+` releases from of a pre-Gradle branch if these merged Gradle changes turn out to be more disruptive than expected. I can make this change if you agree that I should.\r\n\r\n2. @msridhar [proposed rebasing these changes on the latest WALA `master`](https://github.com/wala/WALA/pull/278#issuecomment-374028801), which [I did](https://github.com/wala/WALA/pull/278#issuecomment-374063853). However, `master` has continued to evolve since then. I am happy to rebase again if we really are just about ready to merge. I prefer not to rebase over and over, though, as doing so (1) requires moderate effort and (2) creates some disruption due to invalidation of hashes in existing clones."}}
{"actor":{"display_login":"liblit"}}