{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-containerregistry/pulls/comments/210040666","pull_request_review_id":146174134,"id":210040666,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA0MDY2Ng==","diff_hunk":"@@ -37,6 +37,15 @@ type Descriptor struct {\n \tDigest      Hash              `json:\"digest\"`\n \tURLs        []string          `json:\"urls,omitempty\"`\n \tAnnotations map[string]string `json:\"annotations,omitempty\"`\n+\tPlatform    *Platform         `json:\"platform,omitempty\"`\n+}\n+\n+// Index represents an OCI image index in a structured way.\n+type Index struct {\n+\tSchemaVersion int64             `json:\"schemaVersion\"`\n+\tMediaType     types.MediaType   `json:\"mediaType\"`\n+\tManifests     []Descriptor      `json:\"manifests\"`\n+\tAnnotations   map[string]string `json:\"annotations,omitempty\"`","path":"pkg/v1/manifest.go","position":null,"original_position":12,"commit_id":"a8196296ef7f033f53168ac6c4210cfa8dc8a822","original_commit_id":"2589fa996d794018108f1345743e570872240c0c","user":{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false},"body":"Moved some things around. I think it kind of makes sense to keep the index in `manifest.go`, since it's a _kind_ of manifest, but it's not a strong opinion.","created_at":"2018-08-14T17:38:02Z","updated_at":"2018-08-14T17:38:02Z","html_url":"https://github.com/google/go-containerregistry/pull/257#discussion_r210040666","pull_request_url":"https://api.github.com/repos/google/go-containerregistry/pulls/257","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/comments/210040666"},"html":{"href":"https://github.com/google/go-containerregistry/pull/257#discussion_r210040666"},"pull_request":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/257"}},"in_reply_to_id":209775459},"pull_request":{"url":"https://api.github.com/repos/google/go-containerregistry/pulls/257","id":208117385,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTE3Mzg1","html_url":"https://github.com/google/go-containerregistry/pull/257","diff_url":"https://github.com/google/go-containerregistry/pull/257.diff","patch_url":"https://github.com/google/go-containerregistry/pull/257.patch","issue_url":"https://api.github.com/repos/google/go-containerregistry/issues/257","number":257,"state":"open","locked":false,"title":"Add Image Index types","user":{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false},"body":"This adds minimal structs and interfaces we need to represent an image index.\r\n\r\nPlease nit names :)\r\n\r\nWe'll probably want to add some more methods to the `ImageIndex` interface for convenience in the future, but this should be a sufficient and non-controversial starting point.\r\n\r\nAlso updated the codegen.","created_at":"2018-08-13T22:06:00Z","updated_at":"2018-08-14T17:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5b8b26125d8057c1dc166b6c0fcff4533c100af","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ImJasonH","id":210737,"node_id":"MDQ6VXNlcjIxMDczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/210737?v=4","gravatar_id":"","url":"https://api.github.com/users/ImJasonH","html_url":"https://github.com/ImJasonH","followers_url":"https://api.github.com/users/ImJasonH/followers","following_url":"https://api.github.com/users/ImJasonH/following{/other_user}","gists_url":"https://api.github.com/users/ImJasonH/gists{/gist_id}","starred_url":"https://api.github.com/users/ImJasonH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImJasonH/subscriptions","organizations_url":"https://api.github.com/users/ImJasonH/orgs","repos_url":"https://api.github.com/users/ImJasonH/repos","events_url":"https://api.github.com/users/ImJasonH/events{/privacy}","received_events_url":"https://api.github.com/users/ImJasonH/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-containerregistry/pulls/257/commits","review_comments_url":"https://api.github.com/repos/google/go-containerregistry/pulls/257/comments","review_comment_url":"https://api.github.com/repos/google/go-containerregistry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-containerregistry/issues/257/comments","statuses_url":"https://api.github.com/repos/google/go-containerregistry/statuses/a8196296ef7f033f53168ac6c4210cfa8dc8a822","head":{"label":"jonjohnsonjr:manifest-lists","ref":"manifest-lists","sha":"a8196296ef7f033f53168ac6c4210cfa8dc8a822","user":{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false},"repo":{"id":126883197,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4ODMxOTc=","name":"go-containerregistry","full_name":"jonjohnsonjr/go-containerregistry","owner":{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonjohnsonjr/go-containerregistry","description":null,"fork":true,"url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry","forks_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/forks","keys_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/teams","hooks_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/hooks","issue_events_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/issues/events{/number}","events_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/events","assignees_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/assignees{/user}","branches_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/branches{/branch}","tags_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/tags","blobs_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/statuses/{sha}","languages_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/languages","stargazers_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/stargazers","contributors_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/contributors","subscribers_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/subscribers","subscription_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/subscription","commits_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/contents/{+path}","compare_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/merges","archive_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/downloads","issues_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/issues{/number}","pulls_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/pulls{/number}","milestones_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/milestones{/number}","notifications_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/labels{/name}","releases_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/releases{/id}","deployments_url":"https://api.github.com/repos/jonjohnsonjr/go-containerregistry/deployments","created_at":"2018-03-26T20:01:05Z","updated_at":"2018-05-12T03:29:40Z","pushed_at":"2018-08-14T17:37:28Z","git_url":"git://github.com/jonjohnsonjr/go-containerregistry.git","ssh_url":"git@github.com:jonjohnsonjr/go-containerregistry.git","clone_url":"https://github.com/jonjohnsonjr/go-containerregistry.git","svn_url":"https://github.com/jonjohnsonjr/go-containerregistry","homepage":null,"size":6644,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"029d4b93c31fc9e5f7ab066313372c9be77af46b","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":125253663,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNTM2NjM=","name":"go-containerregistry","full_name":"google/go-containerregistry","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/go-containerregistry","description":"Go library and CLIs for working with container registries","fork":false,"url":"https://api.github.com/repos/google/go-containerregistry","forks_url":"https://api.github.com/repos/google/go-containerregistry/forks","keys_url":"https://api.github.com/repos/google/go-containerregistry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-containerregistry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-containerregistry/teams","hooks_url":"https://api.github.com/repos/google/go-containerregistry/hooks","issue_events_url":"https://api.github.com/repos/google/go-containerregistry/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-containerregistry/events","assignees_url":"https://api.github.com/repos/google/go-containerregistry/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-containerregistry/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-containerregistry/tags","blobs_url":"https://api.github.com/repos/google/go-containerregistry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-containerregistry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-containerregistry/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-containerregistry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-containerregistry/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-containerregistry/languages","stargazers_url":"https://api.github.com/repos/google/go-containerregistry/stargazers","contributors_url":"https://api.github.com/repos/google/go-containerregistry/contributors","subscribers_url":"https://api.github.com/repos/google/go-containerregistry/subscribers","subscription_url":"https://api.github.com/repos/google/go-containerregistry/subscription","commits_url":"https://api.github.com/repos/google/go-containerregistry/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-containerregistry/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-containerregistry/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-containerregistry/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-containerregistry/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-containerregistry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-containerregistry/merges","archive_url":"https://api.github.com/repos/google/go-containerregistry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-containerregistry/downloads","issues_url":"https://api.github.com/repos/google/go-containerregistry/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-containerregistry/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-containerregistry/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-containerregistry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-containerregistry/labels{/name}","releases_url":"https://api.github.com/repos/google/go-containerregistry/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-containerregistry/deployments","created_at":"2018-03-14T18:02:49Z","updated_at":"2018-08-13T21:34:35Z","pushed_at":"2018-08-14T17:37:29Z","git_url":"git://github.com/google/go-containerregistry.git","ssh_url":"git@github.com:google/go-containerregistry.git","clone_url":"https://github.com/google/go-containerregistry.git","svn_url":"https://github.com/google/go-containerregistry","homepage":"","size":6811,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":29,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/257"},"html":{"href":"https://github.com/google/go-containerregistry/pull/257"},"issue":{"href":"https://api.github.com/repos/google/go-containerregistry/issues/257"},"comments":{"href":"https://api.github.com/repos/google/go-containerregistry/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-containerregistry/statuses/a8196296ef7f033f53168ac6c4210cfa8dc8a822"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jonjohnsonjr"}}