{"action":"created","comment":{"url":"https://api.github.com/repos/apache/mynewt-core/pulls/comments/175501466","pull_request_review_id":105040905,"id":175501466,"diff_hunk":"@@ -187,69 +187,69 @@ hal_gpio_clk_enable(uint32_t port_idx)\n                 __HAL_RCC_GPIOB_CLK_ENABLE();\n             }\n             break;\n+#endif\n #if HAL_GPIO_PORT_COUNT > 2\n         case 2:\n             if (!__HAL_RCC_GPIOC_IS_CLK_ENABLED()) {\n                 __HAL_RCC_GPIOC_CLK_ENABLE();\n             }\n             break;\n+#endif\n #if HAL_GPIO_PORT_COUNT > 3\n         case 3:\n             if (!__HAL_RCC_GPIOD_IS_CLK_ENABLED()) {\n                 __HAL_RCC_GPIOD_CLK_ENABLE();\n             }\n             break;\n+#endif\n #if HAL_GPIO_PORT_COUNT > 4 && defined GPIOE_BASE","path":"hw/mcu/stm/stm32f3xx/src/hal_gpio.c","position":19,"original_position":19,"commit_id":"5449422cb50ea1aad2824ce567b508075f84d891","original_commit_id":"5449422cb50ea1aad2824ce567b508075f84d891","user":{"login":"utzig","id":107070,"avatar_url":"https://avatars0.githubusercontent.com/u/107070?v=4","gravatar_id":"","url":"https://api.github.com/users/utzig","html_url":"https://github.com/utzig","followers_url":"https://api.github.com/users/utzig/followers","following_url":"https://api.github.com/users/utzig/following{/other_user}","gists_url":"https://api.github.com/users/utzig/gists{/gist_id}","starred_url":"https://api.github.com/users/utzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utzig/subscriptions","organizations_url":"https://api.github.com/users/utzig/orgs","repos_url":"https://api.github.com/users/utzig/repos","events_url":"https://api.github.com/users/utzig/events{/privacy}","received_events_url":"https://api.github.com/users/utzig/received_events","type":"User","site_admin":false},"body":"Cool catching this! I would just have changed this line to:\r\n\r\n```\r\n#if HAL_GPIO_PORT_COUNT > 4\r\n  #if defined(GPIOE_BASE)\r\n  ...\r\n  #endif\r\n#if HAL_GPIO_PORT_COUNT > 5\r\n```\r\nI believe it would fix the same issue without moving all those `#endif` lines around.","created_at":"2018-03-19T16:36:55Z","updated_at":"2018-03-19T16:36:55Z","html_url":"https://github.com/apache/mynewt-core/pull/902#discussion_r175501466","pull_request_url":"https://api.github.com/repos/apache/mynewt-core/pulls/902","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/comments/175501466"},"html":{"href":"https://github.com/apache/mynewt-core/pull/902#discussion_r175501466"},"pull_request":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/902"}}},"pull_request":{"url":"https://api.github.com/repos/apache/mynewt-core/pulls/902","id":174187161,"html_url":"https://github.com/apache/mynewt-core/pull/902","diff_url":"https://github.com/apache/mynewt-core/pull/902.diff","patch_url":"https://github.com/apache/mynewt-core/pull/902.patch","issue_url":"https://api.github.com/repos/apache/mynewt-core/issues/902","number":902,"state":"open","locked":false,"title":"Feature: stm32 f3/f7 pll clk off HSI","user":{"login":"mlampert","id":7856427,"avatar_url":"https://avatars0.githubusercontent.com/u/7856427?v=4","gravatar_id":"","url":"https://api.github.com/users/mlampert","html_url":"https://github.com/mlampert","followers_url":"https://api.github.com/users/mlampert/followers","following_url":"https://api.github.com/users/mlampert/following{/other_user}","gists_url":"https://api.github.com/users/mlampert/gists{/gist_id}","starred_url":"https://api.github.com/users/mlampert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlampert/subscriptions","organizations_url":"https://api.github.com/users/mlampert/orgs","repos_url":"https://api.github.com/users/mlampert/repos","events_url":"https://api.github.com/users/mlampert/events{/privacy}","received_events_url":"https://api.github.com/users/mlampert/received_events","type":"User","site_admin":false},"body":"This change adds support to use the internal PLL as the system clock, driven by the HSI.\r\nThe default for this setting is currently off to preserve existing behaviour.\r\n\r\nIt also consolidates the STM32F3 external file location with the other STM32 ports.","created_at":"2018-03-10T20:06:40Z","updated_at":"2018-03-19T16:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"482a969c166469efb7896622f6a28accb2e5dccc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mkiiskila","id":2256374,"avatar_url":"https://avatars2.githubusercontent.com/u/2256374?v=4","gravatar_id":"","url":"https://api.github.com/users/mkiiskila","html_url":"https://github.com/mkiiskila","followers_url":"https://api.github.com/users/mkiiskila/followers","following_url":"https://api.github.com/users/mkiiskila/following{/other_user}","gists_url":"https://api.github.com/users/mkiiskila/gists{/gist_id}","starred_url":"https://api.github.com/users/mkiiskila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkiiskila/subscriptions","organizations_url":"https://api.github.com/users/mkiiskila/orgs","repos_url":"https://api.github.com/users/mkiiskila/repos","events_url":"https://api.github.com/users/mkiiskila/events{/privacy}","received_events_url":"https://api.github.com/users/mkiiskila/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/mynewt-core/pulls/902/commits","review_comments_url":"https://api.github.com/repos/apache/mynewt-core/pulls/902/comments","review_comment_url":"https://api.github.com/repos/apache/mynewt-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/mynewt-core/issues/902/comments","statuses_url":"https://api.github.com/repos/apache/mynewt-core/statuses/5449422cb50ea1aad2824ce567b508075f84d891","head":{"label":"mlampert:feature/stm32-f3-f7-pll-clk","ref":"feature/stm32-f3-f7-pll-clk","sha":"5449422cb50ea1aad2824ce567b508075f84d891","user":{"login":"mlampert","id":7856427,"avatar_url":"https://avatars0.githubusercontent.com/u/7856427?v=4","gravatar_id":"","url":"https://api.github.com/users/mlampert","html_url":"https://github.com/mlampert","followers_url":"https://api.github.com/users/mlampert/followers","following_url":"https://api.github.com/users/mlampert/following{/other_user}","gists_url":"https://api.github.com/users/mlampert/gists{/gist_id}","starred_url":"https://api.github.com/users/mlampert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlampert/subscriptions","organizations_url":"https://api.github.com/users/mlampert/orgs","repos_url":"https://api.github.com/users/mlampert/repos","events_url":"https://api.github.com/users/mlampert/events{/privacy}","received_events_url":"https://api.github.com/users/mlampert/received_events","type":"User","site_admin":false},"repo":{"id":116766539,"name":"mynewt-core","full_name":"mlampert/mynewt-core","owner":{"login":"mlampert","id":7856427,"avatar_url":"https://avatars0.githubusercontent.com/u/7856427?v=4","gravatar_id":"","url":"https://api.github.com/users/mlampert","html_url":"https://github.com/mlampert","followers_url":"https://api.github.com/users/mlampert/followers","following_url":"https://api.github.com/users/mlampert/following{/other_user}","gists_url":"https://api.github.com/users/mlampert/gists{/gist_id}","starred_url":"https://api.github.com/users/mlampert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlampert/subscriptions","organizations_url":"https://api.github.com/users/mlampert/orgs","repos_url":"https://api.github.com/users/mlampert/repos","events_url":"https://api.github.com/users/mlampert/events{/privacy}","received_events_url":"https://api.github.com/users/mlampert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlampert/mynewt-core","description":"An OS to build, deploy and securely manage billions of devices","fork":true,"url":"https://api.github.com/repos/mlampert/mynewt-core","forks_url":"https://api.github.com/repos/mlampert/mynewt-core/forks","keys_url":"https://api.github.com/repos/mlampert/mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlampert/mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlampert/mynewt-core/teams","hooks_url":"https://api.github.com/repos/mlampert/mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/mlampert/mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/mlampert/mynewt-core/events","assignees_url":"https://api.github.com/repos/mlampert/mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/mlampert/mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/mlampert/mynewt-core/tags","blobs_url":"https://api.github.com/repos/mlampert/mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlampert/mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlampert/mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlampert/mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlampert/mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/mlampert/mynewt-core/languages","stargazers_url":"https://api.github.com/repos/mlampert/mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/mlampert/mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/mlampert/mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/mlampert/mynewt-core/subscription","commits_url":"https://api.github.com/repos/mlampert/mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlampert/mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlampert/mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlampert/mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlampert/mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/mlampert/mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlampert/mynewt-core/merges","archive_url":"https://api.github.com/repos/mlampert/mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlampert/mynewt-core/downloads","issues_url":"https://api.github.com/repos/mlampert/mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/mlampert/mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/mlampert/mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/mlampert/mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlampert/mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/mlampert/mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/mlampert/mynewt-core/deployments","created_at":"2018-01-09T04:39:27Z","updated_at":"2018-01-09T04:39:44Z","pushed_at":"2018-03-18T05:24:04Z","git_url":"git://github.com/mlampert/mynewt-core.git","ssh_url":"git@github.com:mlampert/mynewt-core.git","clone_url":"https://github.com/mlampert/mynewt-core.git","svn_url":"https://github.com/mlampert/mynewt-core","homepage":"https://mynewt.apache.org/","size":150443,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2be83ec642be11d5faf28c525b95740aa9aa9570","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45165993,"name":"mynewt-core","full_name":"apache/mynewt-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/mynewt-core","description":"An OS to build, deploy and securely manage billions of devices","fork":false,"url":"https://api.github.com/repos/apache/mynewt-core","forks_url":"https://api.github.com/repos/apache/mynewt-core/forks","keys_url":"https://api.github.com/repos/apache/mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/mynewt-core/teams","hooks_url":"https://api.github.com/repos/apache/mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/apache/mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/mynewt-core/events","assignees_url":"https://api.github.com/repos/apache/mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/mynewt-core/tags","blobs_url":"https://api.github.com/repos/apache/mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/mynewt-core/languages","stargazers_url":"https://api.github.com/repos/apache/mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/apache/mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/apache/mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/apache/mynewt-core/subscription","commits_url":"https://api.github.com/repos/apache/mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/mynewt-core/merges","archive_url":"https://api.github.com/repos/apache/mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/mynewt-core/downloads","issues_url":"https://api.github.com/repos/apache/mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/mynewt-core/deployments","created_at":"2015-10-29T07:00:07Z","updated_at":"2018-03-19T15:02:32Z","pushed_at":"2018-03-19T13:05:04Z","git_url":"git://github.com/apache/mynewt-core.git","ssh_url":"git@github.com:apache/mynewt-core.git","clone_url":"https://github.com/apache/mynewt-core.git","svn_url":"https://github.com/apache/mynewt-core","homepage":"https://mynewt.apache.org/","size":150404,"stargazers_count":319,"watchers_count":319,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":160,"open_issues":31,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/902"},"html":{"href":"https://github.com/apache/mynewt-core/pull/902"},"issue":{"href":"https://api.github.com/repos/apache/mynewt-core/issues/902"},"comments":{"href":"https://api.github.com/repos/apache/mynewt-core/issues/902/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/902/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/902/commits"},"statuses":{"href":"https://api.github.com/repos/apache/mynewt-core/statuses/5449422cb50ea1aad2824ce567b508075f84d891"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"utzig"}}