{"action":"created","issue":{"url":"https://api.github.com/repos/libgdx/libgdx/issues/5199","repository_url":"https://api.github.com/repos/libgdx/libgdx","labels_url":"https://api.github.com/repos/libgdx/libgdx/issues/5199/labels{/name}","comments_url":"https://api.github.com/repos/libgdx/libgdx/issues/5199/comments","events_url":"https://api.github.com/repos/libgdx/libgdx/issues/5199/events","html_url":"https://github.com/libgdx/libgdx/pull/5199","id":318051365,"number":5199,"title":"Added .isEmpty() and .nonEmpty() methods to custom LibGDX collections","user":{"login":"TCreutzenberg","id":17275393,"avatar_url":"https://avatars1.githubusercontent.com/u/17275393?v=4","gravatar_id":"","url":"https://api.github.com/users/TCreutzenberg","html_url":"https://github.com/TCreutzenberg","followers_url":"https://api.github.com/users/TCreutzenberg/followers","following_url":"https://api.github.com/users/TCreutzenberg/following{/other_user}","gists_url":"https://api.github.com/users/TCreutzenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/TCreutzenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TCreutzenberg/subscriptions","organizations_url":"https://api.github.com/users/TCreutzenberg/orgs","repos_url":"https://api.github.com/users/TCreutzenberg/repos","events_url":"https://api.github.com/users/TCreutzenberg/events{/privacy}","received_events_url":"https://api.github.com/users/TCreutzenberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-26T14:19:44Z","updated_at":"2018-05-04T16:39:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/libgdx/libgdx/pulls/5199","html_url":"https://github.com/libgdx/libgdx/pull/5199","diff_url":"https://github.com/libgdx/libgdx/pull/5199.diff","patch_url":"https://github.com/libgdx/libgdx/pull/5199.patch"},"body":"Pull request for issue https://github.com/libgdx/libgdx/issues/5196"},"comment":{"url":"https://api.github.com/repos/libgdx/libgdx/issues/comments/386658403","html_url":"https://github.com/libgdx/libgdx/pull/5199#issuecomment-386658403","issue_url":"https://api.github.com/repos/libgdx/libgdx/issues/5199","id":386658403,"user":{"login":"kalexmills","id":22620342,"avatar_url":"https://avatars0.githubusercontent.com/u/22620342?v=4","gravatar_id":"","url":"https://api.github.com/users/kalexmills","html_url":"https://github.com/kalexmills","followers_url":"https://api.github.com/users/kalexmills/followers","following_url":"https://api.github.com/users/kalexmills/following{/other_user}","gists_url":"https://api.github.com/users/kalexmills/gists{/gist_id}","starred_url":"https://api.github.com/users/kalexmills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalexmills/subscriptions","organizations_url":"https://api.github.com/users/kalexmills/orgs","repos_url":"https://api.github.com/users/kalexmills/repos","events_url":"https://api.github.com/users/kalexmills/events{/privacy}","received_events_url":"https://api.github.com/users/kalexmills/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T16:38:59Z","updated_at":"2018-05-04T16:38:59Z","author_association":"NONE","body":"IMHO, Number 4 is best. isEmpty() already has a consistent meaning with its\ncounterpart defined in java.util.Collection. In any case,  hasItems() or\neven nonEmpty() is just a convenience wrapper for !isEmpty(). We can\nprobably do without it, since the extra ! character is not very onerous to\ntype (carpal tunnel notwithstanding).\n\nOn Fri, May 4, 2018 at 11:33 AM Nathan Sweet <notifications@github.com>\nwrote:\n\n> Thanks! Javadocs look good.\n>\n> It's true hasItems isn't a good fit for maps. It seems OK for sets. Just\n> has? available? Those aren't great either. Consistent method names would\n> be nice if possible, but exchanging a list with a map will require more\n> changes than just this. FWIW, we use hasXxx elsewhere, eg in scene2d\n> hasParent, hasActions.\n>\n> Anyone else have ideas? Some options:\n>\n>    1. hasItems for all collections.\n>    2. hasItems for collections with items (arrays, sets, etc) and hasXxx\n>    where it isn't a good fit (eg hasEntries for maps).\n>    3. nonEmpty for all collections.\n>    4. !isEmpty().\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/libgdx/libgdx/pull/5199#issuecomment-386656840>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AVkoti44FS8_X4wJ0N3n91u5y5vrPn6Vks5tvILXgaJpZM4TlRjT>\n> .\n>\n-- \n\nK. Alex Mills\n"}}
{"actor":{"display_login":"kalexmills"}}