{"action":"closed","number":14177,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14177","id":201222664,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjIyNjY0","html_url":"https://github.com/xbmc/xbmc/pull/14177","diff_url":"https://github.com/xbmc/xbmc/pull/14177.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14177.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14177","number":14177,"state":"closed","locked":false,"title":"[cleanup] silence useless cast warnings","user":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"body":"## Description\r\nremove cast which do nothing as the (return) type is already the expected one\r\n\r\n## Motivation and Context\r\nI wanted to apply `google-readability-casting` clang tidy check, but it removed some casts. So I first identified the casts which are really useless.\r\n\r\n## How Has This Been Tested?\r\ncompiled for windows and linux\r\n\r\n## Types of change\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Cosmetic change (non-breaking change that doesn't touch code)\r\n- [ ] None of the above (please explain below)\r\n\r\n## Checklist:\r\n- [x] My code follows the **[Code Guidelines](CODE_GUIDELINES.md)** of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the **[Contributing](CONTRIBUTING.md)** document\r\n- [ ] I have added tests to cover my change\r\n- [x] All new and existing tests passed\r\n","created_at":"2018-07-13T08:35:11Z","updated_at":"2018-07-13T13:58:59Z","closed_at":"2018-07-13T13:58:59Z","merged_at":"2018-07-13T13:58:59Z","merge_commit_sha":"b8b4daccb1c4c4d256a1fe208f4909c8c078a508","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1659220,"node_id":"MDU6TGFiZWwxNjU5MjIw","url":"https://api.github.com/repos/xbmc/xbmc/labels/Cleanup","name":"Cleanup","color":"0b02e1","default":false},{"id":400751192,"node_id":"MDU6TGFiZWw0MDA3NTExOTI=","url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/109","html_url":"https://github.com/xbmc/xbmc/milestone/109","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/109/labels","id":3413385,"node_id":"MDk6TWlsZXN0b25lMzQxMzM4NQ==","number":109,"title":"Leia 18.0-alpha3","description":"","creator":{"login":"MartijnKaijser","id":907436,"node_id":"MDQ6VXNlcjkwNzQzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/907436?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":77,"state":"open","created_at":"2018-06-10T10:07:21Z","updated_at":"2018-07-13T13:58:59Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14177/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14177/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14177/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/b0cae1d7a0b63f0103769a324423a7378b6c4544","head":{"label":"Rechi:cleanup/warnings","ref":"cleanup/warnings","sha":"b0cae1d7a0b63f0103769a324423a7378b6c4544","user":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"repo":{"id":31212951,"node_id":"MDEwOlJlcG9zaXRvcnkzMTIxMjk1MQ==","name":"xbmc","full_name":"Rechi/xbmc","owner":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rechi/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/Rechi/xbmc","forks_url":"https://api.github.com/repos/Rechi/xbmc/forks","keys_url":"https://api.github.com/repos/Rechi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rechi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rechi/xbmc/teams","hooks_url":"https://api.github.com/repos/Rechi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Rechi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Rechi/xbmc/events","assignees_url":"https://api.github.com/repos/Rechi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Rechi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Rechi/xbmc/tags","blobs_url":"https://api.github.com/repos/Rechi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rechi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rechi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rechi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rechi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Rechi/xbmc/languages","stargazers_url":"https://api.github.com/repos/Rechi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Rechi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Rechi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Rechi/xbmc/subscription","commits_url":"https://api.github.com/repos/Rechi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rechi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rechi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rechi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rechi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Rechi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rechi/xbmc/merges","archive_url":"https://api.github.com/repos/Rechi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rechi/xbmc/downloads","issues_url":"https://api.github.com/repos/Rechi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Rechi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Rechi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Rechi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rechi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Rechi/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/Rechi/xbmc/deployments","created_at":"2015-02-23T15:03:56Z","updated_at":"2018-07-13T07:16:50Z","pushed_at":"2018-07-13T12:33:31Z","git_url":"git://github.com/Rechi/xbmc.git","ssh_url":"git@github.com:Rechi/xbmc.git","clone_url":"https://github.com/Rechi/xbmc.git","svn_url":"https://github.com/Rechi/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":608197,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"34eaf7808c0ee2246444427ceaf0760d0a8ab18e","user":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NjE0","name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, Linux, macOS, iOS and Windows.","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2018-07-13T11:29:32Z","pushed_at":"2018-07-13T13:58:59Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"https://kodi.tv/","size":1459438,"stargazers_count":7163,"watchers_count":7163,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4669,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4669,"open_issues":110,"watchers":7163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14177"},"html":{"href":"https://github.com/xbmc/xbmc/pull/14177"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14177"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14177/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14177/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14177/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/b0cae1d7a0b63f0103769a324423a7378b6c4544"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"maintainer_can_modify":false,"commits":28,"additions":248,"deletions":251,"changed_files":104}}
{"actor":{"display_login":"Rechi"}}