{"action":"created","issue":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3385","repository_url":"https://api.github.com/repos/openhab/openhab2-addons","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3385/labels{/name}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3385/comments","events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3385/events","html_url":"https://github.com/openhab/openhab2-addons/pull/3385","id":307400352,"number":3385,"title":"2.2.x","user":{"login":"ruudbeukema","id":22491155,"avatar_url":"https://avatars2.githubusercontent.com/u/22491155?v=4","gravatar_id":"","url":"https://api.github.com/users/ruudbeukema","html_url":"https://github.com/ruudbeukema","followers_url":"https://api.github.com/users/ruudbeukema/followers","following_url":"https://api.github.com/users/ruudbeukema/following{/other_user}","gists_url":"https://api.github.com/users/ruudbeukema/gists{/gist_id}","starred_url":"https://api.github.com/users/ruudbeukema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruudbeukema/subscriptions","organizations_url":"https://api.github.com/users/ruudbeukema/orgs","repos_url":"https://api.github.com/users/ruudbeukema/repos","events_url":"https://api.github.com/users/ruudbeukema/events{/privacy}","received_events_url":"https://api.github.com/users/ruudbeukema/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-21T20:10:28Z","updated_at":"2018-03-23T09:35:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/3385","html_url":"https://github.com/openhab/openhab2-addons/pull/3385","diff_url":"https://github.com/openhab/openhab2-addons/pull/3385.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/3385.patch"},"body":"[rfxcom] Add support for Mertik gas heaters\r\n\r\nThis PR adds support for controlling several types of Mertik gas heaters using the RFXComThermostat3Message communication protocol. Currently, support for the commands ON, OFF, UP, and DOWN is implemented. These commands work on all types of Mertik gas heaters.\r\n\r\nHere's the URL to the built JAR of this PR:\r\nhttps://www.ruudenmarijke.nl:668/sharing/1bPode7qO\r\n\r\nThis is my first work for OpenHAB (actually my first Java code in 10+ years) there are probably things that I should have done different. Some things I struggled a bit with are:\r\n- The sub-type enumeration: Since multiple sub-types share the same number, I've simply combined them in the enumeration. Somehow I feel that there should be one entry only for each actual sub-type, but this gives problems in the message encoding/decoding functions.\r\n- The currently unsupported commands: it seems as if I can't use the same channel for multiple commands, which means that for e.g. the RUN_UP/RUN_DOWN commands I probably need to create a new channel type?\r\n\r\nSuggestions are welcome!\r\n"},"comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments/375594455","html_url":"https://github.com/openhab/openhab2-addons/pull/3385#issuecomment-375594455","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3385","id":375594455,"user":{"login":"martinvw","id":2625279,"avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T09:35:29Z","updated_at":"2018-03-23T09:35:29Z","author_association":"MEMBER","body":"I will update my branch with your code, I'll have some time for that now as long as the baby does not wake up 😉 "}}
{"actor":{"display_login":"martinvw"}}