{"action":"closed","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/3135","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3135/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3135/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3135/events","html_url":"https://github.com/envoyproxy/envoy/issues/3135","id":315747881,"number":3135,"title":"Bad default stat prefix","user":{"login":"ofek","id":9677399,"avatar_url":"https://avatars1.githubusercontent.com/u/9677399?v=4","gravatar_id":"","url":"https://api.github.com/users/ofek","html_url":"https://github.com/ofek","followers_url":"https://api.github.com/users/ofek/followers","following_url":"https://api.github.com/users/ofek/following{/other_user}","gists_url":"https://api.github.com/users/ofek/gists{/gist_id}","starred_url":"https://api.github.com/users/ofek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofek/subscriptions","organizations_url":"https://api.github.com/users/ofek/orgs","repos_url":"https://api.github.com/users/ofek/repos","events_url":"https://api.github.com/users/ofek/events{/privacy}","received_events_url":"https://api.github.com/users/ofek/received_events","type":"User","site_admin":false},"labels":[{"id":421403907,"url":"https://api.github.com/repos/envoyproxy/envoy/labels/bug","name":"bug","color":"ee0701","default":true},{"id":645516726,"url":"https://api.github.com/repos/envoyproxy/envoy/labels/help%20wanted","name":"help wanted","color":"fbca04","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/envoyproxy/envoy/milestones/6","html_url":"https://github.com/envoyproxy/envoy/milestone/6","labels_url":"https://api.github.com/repos/envoyproxy/envoy/milestones/6/labels","id":3163642,"number":6,"title":"1.7.0","description":"","creator":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":19,"state":"open","created_at":"2018-03-05T22:43:00Z","updated_at":"2018-04-23T20:58:13Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-04-19T06:49:14Z","updated_at":"2018-04-23T20:58:13Z","closed_at":"2018-04-23T20:58:13Z","author_association":"CONTRIBUTOR","body":"Looking here https://www.envoyproxy.io/docs/envoy/latest/configuration/http_conn_man/stats#tracing-statistics\r\n\r\nIt seems the default `stat_prefix` for admin is `admin.tracing`:\r\n\r\n```\r\nhttp.admin.tracing.tracing.client_enabled: 0\r\nhttp.admin.tracing.tracing.health_check: 0\r\nhttp.admin.tracing.tracing.not_traceable: 0\r\nhttp.admin.tracing.tracing.random_sampling: 0\r\nhttp.admin.tracing.tracing.service_forced: 0\r\n```\r\n\r\nDue to our regular expressions being greedy (no way around that), Envoy extracts the stat prefix as just `admin` and gets the metric name wrong:\r\n\r\n```\r\n# TYPE envoy_http_tracing_tracing_client_enabled counter\r\nenvoy_http_tracing_tracing_client_enabled{envoy_http_conn_manager_prefix=\"admin\"} 0\r\n```\r\n\r\nWe need to change the default to something else.\r\n\r\ncc @mrice32 @jmarantz "}}
{"actor":{"display_login":"mattklein123"}}