{"action":"created","comment":{"url":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments/206171757","pull_request_review_id":141570935,"id":206171757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjE3MTc1Nw==","diff_hunk":"@@ -65,35 +60,32 @@ public function store($request): array\n      * @param int $id\n      * @return Category\n      */\n-    public function show(int $id): Category\n+    public function findById(int $id): Category\n     {\n-        $category = $this->categoryModel->with('posts')->find($id);\n-\n-        return $category;\n+        return $this->categoryModel->with('posts')->find($id);\n     }\n \n     /**\n      * Update the specified resouce in storage.\n      *\n-     * @param  \\Illuminate\\Http\\Request $request\n+     * @param  array $attributes\n      * @param  int    $id\n-     * @return array\n+     * @return Category\n      */\n-    public function update($request, int $id): array\n+    public function updateById(array $attributes, int $id): Category\n     {\n-        $category = $this->categoryModel->findOrFail($id);\n-        $category->update($request->all());\n+        $this->categoryModel->findOrFail($id)->update($attributes);\n \n-        return ['id' => $category->id];\n+        return $this->categoryModel->findOrFail($id);\n     }\n \n     /**\n      * Remove the specified resource from storage.\n      *\n      * @param  int   $id\n-     * @return array\n+     * @return void\n      */\n-    public function destroy(int $id): array\n+    public function destroyById(int $id): void","path":"src/core-app/app/Repositories/Eloquent/CategoryRepository.php","position":86,"original_position":86,"commit_id":"948b9c3b47ab6e0783db6ad0ee26d7776aea9f1a","original_commit_id":"948b9c3b47ab6e0783db6ad0ee26d7776aea9f1a","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Avoid variables with short names like $id. Configured minimum length is 3.](https://app.codacy.com/app/bmf-san/Rubel/pullRequest?prid=1958423)","created_at":"2018-07-30T14:54:02Z","updated_at":"2018-07-30T14:54:02Z","html_url":"https://github.com/bmf-san/Rubel/pull/55#discussion_r206171757","pull_request_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments/206171757"},"html":{"href":"https://github.com/bmf-san/Rubel/pull/55#discussion_r206171757"},"pull_request":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55","id":201440953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDQwOTUz","html_url":"https://github.com/bmf-san/Rubel/pull/55","diff_url":"https://github.com/bmf-san/Rubel/pull/55.diff","patch_url":"https://github.com/bmf-san/Rubel/pull/55.patch","issue_url":"https://api.github.com/repos/bmf-san/Rubel/issues/55","number":55,"state":"open","locked":false,"title":"[WIP] Implement of a function to manage theme","user":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"body":"# Overview\r\n~~Implement of a function to manage theme.~~->Implement web app as a package\r\n\r\n# Changes\r\n- [x] set up for package\r\n- [x] fix path to js file and path to css file in template files.\r\n- [x] fix webpack.config.js in theme package\r\n- [x] fix circleci setting\r\n  - npm process\r\n  - vendor publish command\r\n- [x] tests\r\n   - [x] add repository tests to core\r\n   - [x] fix package tests to package dir\r\n      - fix Integration tests\r\n- [x] fix config files\r\n- [x] fix env\r\n- [x] add pages\r\n    - profile page\r\n    - contact page   \r\n- [ ] review\r\n\r\n# MEMO\r\n- add tests\r\n    - contact mail test   \r\n- fix admin login\r\n    - can't login\r\n\r\n# Impact range\r\nclient-app\r\n\r\n# Operational Requirements\r\n\r\n# Related Issue\r\n#51 \r\n\r\n# Supplement\r\n","created_at":"2018-07-14T07:42:32Z","updated_at":"2018-07-30T14:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0de02c8ae9b234fd2d8c97400a748b825ce56904","assignee":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/commits","review_comments_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/comments","review_comment_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bmf-san/Rubel/issues/55/comments","statuses_url":"https://api.github.com/repos/bmf-san/Rubel/statuses/948b9c3b47ab6e0783db6ad0ee26d7776aea9f1a","head":{"label":"bmf-san:feature/theme","ref":"feature/theme","sha":"948b9c3b47ab6e0783db6ad0ee26d7776aea9f1a","user":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"repo":{"id":75729934,"node_id":"MDEwOlJlcG9zaXRvcnk3NTcyOTkzNA==","name":"Rubel","full_name":"bmf-san/Rubel","owner":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmf-san/Rubel","description":"Rubel - An open source cms built with Laravel and React.","fork":false,"url":"https://api.github.com/repos/bmf-san/Rubel","forks_url":"https://api.github.com/repos/bmf-san/Rubel/forks","keys_url":"https://api.github.com/repos/bmf-san/Rubel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmf-san/Rubel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmf-san/Rubel/teams","hooks_url":"https://api.github.com/repos/bmf-san/Rubel/hooks","issue_events_url":"https://api.github.com/repos/bmf-san/Rubel/issues/events{/number}","events_url":"https://api.github.com/repos/bmf-san/Rubel/events","assignees_url":"https://api.github.com/repos/bmf-san/Rubel/assignees{/user}","branches_url":"https://api.github.com/repos/bmf-san/Rubel/branches{/branch}","tags_url":"https://api.github.com/repos/bmf-san/Rubel/tags","blobs_url":"https://api.github.com/repos/bmf-san/Rubel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmf-san/Rubel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmf-san/Rubel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmf-san/Rubel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmf-san/Rubel/statuses/{sha}","languages_url":"https://api.github.com/repos/bmf-san/Rubel/languages","stargazers_url":"https://api.github.com/repos/bmf-san/Rubel/stargazers","contributors_url":"https://api.github.com/repos/bmf-san/Rubel/contributors","subscribers_url":"https://api.github.com/repos/bmf-san/Rubel/subscribers","subscription_url":"https://api.github.com/repos/bmf-san/Rubel/subscription","commits_url":"https://api.github.com/repos/bmf-san/Rubel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmf-san/Rubel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmf-san/Rubel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmf-san/Rubel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmf-san/Rubel/contents/{+path}","compare_url":"https://api.github.com/repos/bmf-san/Rubel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmf-san/Rubel/merges","archive_url":"https://api.github.com/repos/bmf-san/Rubel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmf-san/Rubel/downloads","issues_url":"https://api.github.com/repos/bmf-san/Rubel/issues{/number}","pulls_url":"https://api.github.com/repos/bmf-san/Rubel/pulls{/number}","milestones_url":"https://api.github.com/repos/bmf-san/Rubel/milestones{/number}","notifications_url":"https://api.github.com/repos/bmf-san/Rubel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmf-san/Rubel/labels{/name}","releases_url":"https://api.github.com/repos/bmf-san/Rubel/releases{/id}","deployments_url":"https://api.github.com/repos/bmf-san/Rubel/deployments","created_at":"2016-12-06T12:38:21Z","updated_at":"2018-06-23T06:00:21Z","pushed_at":"2018-07-30T14:42:51Z","git_url":"git://github.com/bmf-san/Rubel.git","ssh_url":"git@github.com:bmf-san/Rubel.git","clone_url":"https://github.com/bmf-san/Rubel.git","svn_url":"https://github.com/bmf-san/Rubel","homepage":"https://rubel-admin.bmf-tech.com/login","size":69597,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":15,"watchers":57,"default_branch":"master"}},"base":{"label":"bmf-san:master","ref":"master","sha":"9db1e95c7c5753b1b2abb94618f927813b843e8a","user":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"repo":{"id":75729934,"node_id":"MDEwOlJlcG9zaXRvcnk3NTcyOTkzNA==","name":"Rubel","full_name":"bmf-san/Rubel","owner":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmf-san/Rubel","description":"Rubel - An open source cms built with Laravel and React.","fork":false,"url":"https://api.github.com/repos/bmf-san/Rubel","forks_url":"https://api.github.com/repos/bmf-san/Rubel/forks","keys_url":"https://api.github.com/repos/bmf-san/Rubel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmf-san/Rubel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmf-san/Rubel/teams","hooks_url":"https://api.github.com/repos/bmf-san/Rubel/hooks","issue_events_url":"https://api.github.com/repos/bmf-san/Rubel/issues/events{/number}","events_url":"https://api.github.com/repos/bmf-san/Rubel/events","assignees_url":"https://api.github.com/repos/bmf-san/Rubel/assignees{/user}","branches_url":"https://api.github.com/repos/bmf-san/Rubel/branches{/branch}","tags_url":"https://api.github.com/repos/bmf-san/Rubel/tags","blobs_url":"https://api.github.com/repos/bmf-san/Rubel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmf-san/Rubel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmf-san/Rubel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmf-san/Rubel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmf-san/Rubel/statuses/{sha}","languages_url":"https://api.github.com/repos/bmf-san/Rubel/languages","stargazers_url":"https://api.github.com/repos/bmf-san/Rubel/stargazers","contributors_url":"https://api.github.com/repos/bmf-san/Rubel/contributors","subscribers_url":"https://api.github.com/repos/bmf-san/Rubel/subscribers","subscription_url":"https://api.github.com/repos/bmf-san/Rubel/subscription","commits_url":"https://api.github.com/repos/bmf-san/Rubel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmf-san/Rubel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmf-san/Rubel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmf-san/Rubel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmf-san/Rubel/contents/{+path}","compare_url":"https://api.github.com/repos/bmf-san/Rubel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmf-san/Rubel/merges","archive_url":"https://api.github.com/repos/bmf-san/Rubel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmf-san/Rubel/downloads","issues_url":"https://api.github.com/repos/bmf-san/Rubel/issues{/number}","pulls_url":"https://api.github.com/repos/bmf-san/Rubel/pulls{/number}","milestones_url":"https://api.github.com/repos/bmf-san/Rubel/milestones{/number}","notifications_url":"https://api.github.com/repos/bmf-san/Rubel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmf-san/Rubel/labels{/name}","releases_url":"https://api.github.com/repos/bmf-san/Rubel/releases{/id}","deployments_url":"https://api.github.com/repos/bmf-san/Rubel/deployments","created_at":"2016-12-06T12:38:21Z","updated_at":"2018-06-23T06:00:21Z","pushed_at":"2018-07-30T14:42:51Z","git_url":"git://github.com/bmf-san/Rubel.git","ssh_url":"git@github.com:bmf-san/Rubel.git","clone_url":"https://github.com/bmf-san/Rubel.git","svn_url":"https://github.com/bmf-san/Rubel","homepage":"https://rubel-admin.bmf-tech.com/login","size":69597,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":15,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55"},"html":{"href":"https://github.com/bmf-san/Rubel/pull/55"},"issue":{"href":"https://api.github.com/repos/bmf-san/Rubel/issues/55"},"comments":{"href":"https://api.github.com/repos/bmf-san/Rubel/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/bmf-san/Rubel/statuses/948b9c3b47ab6e0783db6ad0ee26d7776aea9f1a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"codacy-bot"}}