{"action":"closed","number":313,"pull_request":{"url":"https://api.github.com/repos/weewx/weewx/pulls/313","id":180061216,"html_url":"https://github.com/weewx/weewx/pull/313","diff_url":"https://github.com/weewx/weewx/pull/313.diff","patch_url":"https://github.com/weewx/weewx/pull/313.patch","issue_url":"https://api.github.com/repos/weewx/weewx/issues/313","number":313,"state":"closed","locked":false,"title":"make test runs ok on ubuntu 16.04 and 18.04","user":{"login":"vinceskahan","id":603690,"avatar_url":"https://avatars1.githubusercontent.com/u/603690?v=4","gravatar_id":"","url":"https://api.github.com/users/vinceskahan","html_url":"https://github.com/vinceskahan","followers_url":"https://api.github.com/users/vinceskahan/followers","following_url":"https://api.github.com/users/vinceskahan/following{/other_user}","gists_url":"https://api.github.com/users/vinceskahan/gists{/gist_id}","starred_url":"https://api.github.com/users/vinceskahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinceskahan/subscriptions","organizations_url":"https://api.github.com/users/vinceskahan/orgs","repos_url":"https://api.github.com/users/vinceskahan/repos","events_url":"https://api.github.com/users/vinceskahan/events{/privacy}","received_events_url":"https://api.github.com/users/vinceskahan/received_events","type":"User","site_admin":false},"body":"These tweaks result in 'make test' working ok on ubuntu 16.04 and 18.04 under Vagrant\r\n\r\nNothing too special here:\r\n\r\n- a note to not run the tests as root\r\n- a missing include\r\n- one place a file wasn't being deleted by make test-clean\r\n- fixed up some assertion some mysql tests where the type of error expected didn't match what weewx was throwing. \r\n\r\nWhen in doubt, I trusted weewx rather than the test assertion expected values.\r\n","created_at":"2018-04-06T21:44:35Z","updated_at":"2018-04-09T12:03:41Z","closed_at":"2018-04-09T12:03:41Z","merged_at":"2018-04-09T12:03:41Z","merge_commit_sha":"bc1f8dfd259204b6564264b78e6a1b63cd01f649","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tkeffer","id":3321259,"avatar_url":"https://avatars2.githubusercontent.com/u/3321259?v=4","gravatar_id":"","url":"https://api.github.com/users/tkeffer","html_url":"https://github.com/tkeffer","followers_url":"https://api.github.com/users/tkeffer/followers","following_url":"https://api.github.com/users/tkeffer/following{/other_user}","gists_url":"https://api.github.com/users/tkeffer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkeffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkeffer/subscriptions","organizations_url":"https://api.github.com/users/tkeffer/orgs","repos_url":"https://api.github.com/users/tkeffer/repos","events_url":"https://api.github.com/users/tkeffer/events{/privacy}","received_events_url":"https://api.github.com/users/tkeffer/received_events","type":"User","site_admin":false},{"login":"matthewwall","id":6115213,"avatar_url":"https://avatars1.githubusercontent.com/u/6115213?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewwall","html_url":"https://github.com/matthewwall","followers_url":"https://api.github.com/users/matthewwall/followers","following_url":"https://api.github.com/users/matthewwall/following{/other_user}","gists_url":"https://api.github.com/users/matthewwall/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewwall/subscriptions","organizations_url":"https://api.github.com/users/matthewwall/orgs","repos_url":"https://api.github.com/users/matthewwall/repos","events_url":"https://api.github.com/users/matthewwall/events{/privacy}","received_events_url":"https://api.github.com/users/matthewwall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weewx/weewx/pulls/313/commits","review_comments_url":"https://api.github.com/repos/weewx/weewx/pulls/313/comments","review_comment_url":"https://api.github.com/repos/weewx/weewx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weewx/weewx/issues/313/comments","statuses_url":"https://api.github.com/repos/weewx/weewx/statuses/2184f80af8d5d2a78ca2be457a458ebb164c0817","head":{"label":"vinceskahan:dev-fix-tests","ref":"dev-fix-tests","sha":"2184f80af8d5d2a78ca2be457a458ebb164c0817","user":{"login":"vinceskahan","id":603690,"avatar_url":"https://avatars1.githubusercontent.com/u/603690?v=4","gravatar_id":"","url":"https://api.github.com/users/vinceskahan","html_url":"https://github.com/vinceskahan","followers_url":"https://api.github.com/users/vinceskahan/followers","following_url":"https://api.github.com/users/vinceskahan/following{/other_user}","gists_url":"https://api.github.com/users/vinceskahan/gists{/gist_id}","starred_url":"https://api.github.com/users/vinceskahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinceskahan/subscriptions","organizations_url":"https://api.github.com/users/vinceskahan/orgs","repos_url":"https://api.github.com/users/vinceskahan/repos","events_url":"https://api.github.com/users/vinceskahan/events{/privacy}","received_events_url":"https://api.github.com/users/vinceskahan/received_events","type":"User","site_admin":false},"repo":{"id":58288617,"name":"weewx","full_name":"vinceskahan/weewx","owner":{"login":"vinceskahan","id":603690,"avatar_url":"https://avatars1.githubusercontent.com/u/603690?v=4","gravatar_id":"","url":"https://api.github.com/users/vinceskahan","html_url":"https://github.com/vinceskahan","followers_url":"https://api.github.com/users/vinceskahan/followers","following_url":"https://api.github.com/users/vinceskahan/following{/other_user}","gists_url":"https://api.github.com/users/vinceskahan/gists{/gist_id}","starred_url":"https://api.github.com/users/vinceskahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinceskahan/subscriptions","organizations_url":"https://api.github.com/users/vinceskahan/orgs","repos_url":"https://api.github.com/users/vinceskahan/repos","events_url":"https://api.github.com/users/vinceskahan/events{/privacy}","received_events_url":"https://api.github.com/users/vinceskahan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinceskahan/weewx","description":"weewx code repository","fork":true,"url":"https://api.github.com/repos/vinceskahan/weewx","forks_url":"https://api.github.com/repos/vinceskahan/weewx/forks","keys_url":"https://api.github.com/repos/vinceskahan/weewx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinceskahan/weewx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinceskahan/weewx/teams","hooks_url":"https://api.github.com/repos/vinceskahan/weewx/hooks","issue_events_url":"https://api.github.com/repos/vinceskahan/weewx/issues/events{/number}","events_url":"https://api.github.com/repos/vinceskahan/weewx/events","assignees_url":"https://api.github.com/repos/vinceskahan/weewx/assignees{/user}","branches_url":"https://api.github.com/repos/vinceskahan/weewx/branches{/branch}","tags_url":"https://api.github.com/repos/vinceskahan/weewx/tags","blobs_url":"https://api.github.com/repos/vinceskahan/weewx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinceskahan/weewx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinceskahan/weewx/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinceskahan/weewx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinceskahan/weewx/statuses/{sha}","languages_url":"https://api.github.com/repos/vinceskahan/weewx/languages","stargazers_url":"https://api.github.com/repos/vinceskahan/weewx/stargazers","contributors_url":"https://api.github.com/repos/vinceskahan/weewx/contributors","subscribers_url":"https://api.github.com/repos/vinceskahan/weewx/subscribers","subscription_url":"https://api.github.com/repos/vinceskahan/weewx/subscription","commits_url":"https://api.github.com/repos/vinceskahan/weewx/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinceskahan/weewx/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinceskahan/weewx/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinceskahan/weewx/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinceskahan/weewx/contents/{+path}","compare_url":"https://api.github.com/repos/vinceskahan/weewx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinceskahan/weewx/merges","archive_url":"https://api.github.com/repos/vinceskahan/weewx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinceskahan/weewx/downloads","issues_url":"https://api.github.com/repos/vinceskahan/weewx/issues{/number}","pulls_url":"https://api.github.com/repos/vinceskahan/weewx/pulls{/number}","milestones_url":"https://api.github.com/repos/vinceskahan/weewx/milestones{/number}","notifications_url":"https://api.github.com/repos/vinceskahan/weewx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinceskahan/weewx/labels{/name}","releases_url":"https://api.github.com/repos/vinceskahan/weewx/releases{/id}","deployments_url":"https://api.github.com/repos/vinceskahan/weewx/deployments","created_at":"2016-05-07T23:30:43Z","updated_at":"2018-04-05T17:13:51Z","pushed_at":"2018-04-08T23:57:50Z","git_url":"git://github.com/vinceskahan/weewx.git","ssh_url":"git@github.com:vinceskahan/weewx.git","clone_url":"https://github.com/vinceskahan/weewx.git","svn_url":"https://github.com/vinceskahan/weewx","homepage":"http://weewx.com","size":9886,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"weewx:development","ref":"development","sha":"f74350a0654cd44810a828311c4714bffba73312","user":{"login":"weewx","id":10202291,"avatar_url":"https://avatars2.githubusercontent.com/u/10202291?v=4","gravatar_id":"","url":"https://api.github.com/users/weewx","html_url":"https://github.com/weewx","followers_url":"https://api.github.com/users/weewx/followers","following_url":"https://api.github.com/users/weewx/following{/other_user}","gists_url":"https://api.github.com/users/weewx/gists{/gist_id}","starred_url":"https://api.github.com/users/weewx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weewx/subscriptions","organizations_url":"https://api.github.com/users/weewx/orgs","repos_url":"https://api.github.com/users/weewx/repos","events_url":"https://api.github.com/users/weewx/events{/privacy}","received_events_url":"https://api.github.com/users/weewx/received_events","type":"Organization","site_admin":false},"repo":{"id":30899362,"name":"weewx","full_name":"weewx/weewx","owner":{"login":"weewx","id":10202291,"avatar_url":"https://avatars2.githubusercontent.com/u/10202291?v=4","gravatar_id":"","url":"https://api.github.com/users/weewx","html_url":"https://github.com/weewx","followers_url":"https://api.github.com/users/weewx/followers","following_url":"https://api.github.com/users/weewx/following{/other_user}","gists_url":"https://api.github.com/users/weewx/gists{/gist_id}","starred_url":"https://api.github.com/users/weewx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weewx/subscriptions","organizations_url":"https://api.github.com/users/weewx/orgs","repos_url":"https://api.github.com/users/weewx/repos","events_url":"https://api.github.com/users/weewx/events{/privacy}","received_events_url":"https://api.github.com/users/weewx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weewx/weewx","description":"weewx code repository","fork":false,"url":"https://api.github.com/repos/weewx/weewx","forks_url":"https://api.github.com/repos/weewx/weewx/forks","keys_url":"https://api.github.com/repos/weewx/weewx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weewx/weewx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weewx/weewx/teams","hooks_url":"https://api.github.com/repos/weewx/weewx/hooks","issue_events_url":"https://api.github.com/repos/weewx/weewx/issues/events{/number}","events_url":"https://api.github.com/repos/weewx/weewx/events","assignees_url":"https://api.github.com/repos/weewx/weewx/assignees{/user}","branches_url":"https://api.github.com/repos/weewx/weewx/branches{/branch}","tags_url":"https://api.github.com/repos/weewx/weewx/tags","blobs_url":"https://api.github.com/repos/weewx/weewx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weewx/weewx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weewx/weewx/git/refs{/sha}","trees_url":"https://api.github.com/repos/weewx/weewx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weewx/weewx/statuses/{sha}","languages_url":"https://api.github.com/repos/weewx/weewx/languages","stargazers_url":"https://api.github.com/repos/weewx/weewx/stargazers","contributors_url":"https://api.github.com/repos/weewx/weewx/contributors","subscribers_url":"https://api.github.com/repos/weewx/weewx/subscribers","subscription_url":"https://api.github.com/repos/weewx/weewx/subscription","commits_url":"https://api.github.com/repos/weewx/weewx/commits{/sha}","git_commits_url":"https://api.github.com/repos/weewx/weewx/git/commits{/sha}","comments_url":"https://api.github.com/repos/weewx/weewx/comments{/number}","issue_comment_url":"https://api.github.com/repos/weewx/weewx/issues/comments{/number}","contents_url":"https://api.github.com/repos/weewx/weewx/contents/{+path}","compare_url":"https://api.github.com/repos/weewx/weewx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weewx/weewx/merges","archive_url":"https://api.github.com/repos/weewx/weewx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weewx/weewx/downloads","issues_url":"https://api.github.com/repos/weewx/weewx/issues{/number}","pulls_url":"https://api.github.com/repos/weewx/weewx/pulls{/number}","milestones_url":"https://api.github.com/repos/weewx/weewx/milestones{/number}","notifications_url":"https://api.github.com/repos/weewx/weewx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weewx/weewx/labels{/name}","releases_url":"https://api.github.com/repos/weewx/weewx/releases{/id}","deployments_url":"https://api.github.com/repos/weewx/weewx/deployments","created_at":"2015-02-17T02:32:29Z","updated_at":"2018-04-09T03:23:49Z","pushed_at":"2018-04-09T12:03:41Z","git_url":"git://github.com/weewx/weewx.git","ssh_url":"git@github.com:weewx/weewx.git","clone_url":"https://github.com/weewx/weewx.git","svn_url":"https://github.com/weewx/weewx","homepage":"http://weewx.com","size":11188,"stargazers_count":291,"watchers_count":291,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":121,"open_issues":30,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weewx/weewx/pulls/313"},"html":{"href":"https://github.com/weewx/weewx/pull/313"},"issue":{"href":"https://api.github.com/repos/weewx/weewx/issues/313"},"comments":{"href":"https://api.github.com/repos/weewx/weewx/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/weewx/weewx/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/weewx/weewx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weewx/weewx/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/weewx/weewx/statuses/2184f80af8d5d2a78ca2be457a458ebb164c0817"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tkeffer","id":3321259,"avatar_url":"https://avatars2.githubusercontent.com/u/3321259?v=4","gravatar_id":"","url":"https://api.github.com/users/tkeffer","html_url":"https://github.com/tkeffer","followers_url":"https://api.github.com/users/tkeffer/followers","following_url":"https://api.github.com/users/tkeffer/following{/other_user}","gists_url":"https://api.github.com/users/tkeffer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkeffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkeffer/subscriptions","organizations_url":"https://api.github.com/users/tkeffer/orgs","repos_url":"https://api.github.com/users/tkeffer/repos","events_url":"https://api.github.com/users/tkeffer/events{/privacy}","received_events_url":"https://api.github.com/users/tkeffer/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":4,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"tkeffer"}}