{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/flow/issues/3929","repository_url":"https://api.github.com/repos/vaadin/flow","labels_url":"https://api.github.com/repos/vaadin/flow/issues/3929/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/3929/comments","events_url":"https://api.github.com/repos/vaadin/flow/issues/3929/events","html_url":"https://github.com/vaadin/flow/pull/3929","id":315600819,"number":3929,"title":"Use VaadinService resolve methods in UidlWriter","user":{"login":"Artur-","id":260340,"avatar_url":"https://avatars3.githubusercontent.com/u/260340?v=4","gravatar_id":"","url":"https://api.github.com/users/Artur-","html_url":"https://github.com/Artur-","followers_url":"https://api.github.com/users/Artur-/followers","following_url":"https://api.github.com/users/Artur-/following{/other_user}","gists_url":"https://api.github.com/users/Artur-/gists{/gist_id}","starred_url":"https://api.github.com/users/Artur-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Artur-/subscriptions","organizations_url":"https://api.github.com/users/Artur-/orgs","repos_url":"https://api.github.com/users/Artur-/repos","events_url":"https://api.github.com/users/Artur-/events{/privacy}","received_events_url":"https://api.github.com/users/Artur-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Artur-","id":260340,"avatar_url":"https://avatars3.githubusercontent.com/u/260340?v=4","gravatar_id":"","url":"https://api.github.com/users/Artur-","html_url":"https://github.com/Artur-","followers_url":"https://api.github.com/users/Artur-/followers","following_url":"https://api.github.com/users/Artur-/following{/other_user}","gists_url":"https://api.github.com/users/Artur-/gists{/gist_id}","starred_url":"https://api.github.com/users/Artur-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Artur-/subscriptions","organizations_url":"https://api.github.com/users/Artur-/orgs","repos_url":"https://api.github.com/users/Artur-/repos","events_url":"https://api.github.com/users/Artur-/events{/privacy}","received_events_url":"https://api.github.com/users/Artur-/received_events","type":"User","site_admin":false},"assignees":[{"login":"Artur-","id":260340,"avatar_url":"https://avatars3.githubusercontent.com/u/260340?v=4","gravatar_id":"","url":"https://api.github.com/users/Artur-","html_url":"https://github.com/Artur-","followers_url":"https://api.github.com/users/Artur-/followers","following_url":"https://api.github.com/users/Artur-/following{/other_user}","gists_url":"https://api.github.com/users/Artur-/gists{/gist_id}","starred_url":"https://api.github.com/users/Artur-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Artur-/subscriptions","organizations_url":"https://api.github.com/users/Artur-/orgs","repos_url":"https://api.github.com/users/Artur-/repos","events_url":"https://api.github.com/users/Artur-/events{/privacy}","received_events_url":"https://api.github.com/users/Artur-/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-04-18T18:53:56Z","updated_at":"2018-04-25T06:41:50Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/3929","html_url":"https://github.com/vaadin/flow/pull/3929","diff_url":"https://github.com/vaadin/flow/pull/3929.diff","patch_url":"https://github.com/vaadin/flow/pull/3929.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/3929)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/flow/issues/comments/384177120","html_url":"https://github.com/vaadin/flow/pull/3929#issuecomment-384177120","issue_url":"https://api.github.com/repos/vaadin/flow/issues/3929","id":384177120,"user":{"login":"caalador","id":2726090,"avatar_url":"https://avatars2.githubusercontent.com/u/2726090?v=4","gravatar_id":"","url":"https://api.github.com/users/caalador","html_url":"https://github.com/caalador","followers_url":"https://api.github.com/users/caalador/followers","following_url":"https://api.github.com/users/caalador/following{/other_user}","gists_url":"https://api.github.com/users/caalador/gists{/gist_id}","starred_url":"https://api.github.com/users/caalador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caalador/subscriptions","organizations_url":"https://api.github.com/users/caalador/orgs","repos_url":"https://api.github.com/users/caalador/repos","events_url":"https://api.github.com/users/caalador/events{/privacy}","received_events_url":"https://api.github.com/users/caalador/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T06:41:50Z","updated_at":"2018-04-25T06:41:50Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReviewed 2 of 22 files at r1, 1 of 2 files at r4.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[flow-server/src/main/java/com/vaadin/flow/server/communication/UidlWriter.java, line 287 at r4](https://reviewable.io/reviews/vaadin/flow/3929#-LAvWxHN14Y0gL8ZSUgR:-LAvWxHN14Y0gL8ZSUgS:b-rtimc4) ([raw file](https://github.com/vaadin/flow/blob/27d28642c1e0b50ac34323b1a632e9e2fe3c9115/flow-server/src/main/java/com/vaadin/flow/server/communication/UidlWriter.java#L287)):*\n> ```Java\n>             }\n>         } else {\n>             if (getLogger().isDebugEnabled()) {\n> ```\n\nit just now clicked: `else` + `if` or just a `else if`?\nMight there be something else we might want to do if the resource exists than log a debug message?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/flow/3929)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"caalador"}}