{"action":"created","comment":{"url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/comments/237875441","pull_request_review_id":180284005,"id":237875441,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzg3NTQ0MQ==","diff_hunk":"@@ -106,9 +103,10 @@ void animation1(uint8_t& y, uint8_t& x, uint8_t& gegenstrecke) {\n }\n //----------------------------- Debug Funktion ----------------\n \n-void debugPrint(const char* output[]) {\n+void debugPrint(const char* output[], ...) {\n+  va_list args;\n   if (digitalRead(buttonPin1) && digitalRead(buttonPin2)) {\n-    Serial.println(output);\n+    Serial.println(output, args);","path":"toolboxTreppe/toolboxTreppe.ino","position":196,"original_position":37,"commit_id":"a649650ac42c19053fabb2ad99fee7f39586a1a9","original_commit_id":"a649650ac42c19053fabb2ad99fee7f39586a1a9","user":{"login":"DEvil0000","id":3344302,"node_id":"MDQ6VXNlcjMzNDQzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3344302?v=4","gravatar_id":"","url":"https://api.github.com/users/DEvil0000","html_url":"https://github.com/DEvil0000","followers_url":"https://api.github.com/users/DEvil0000/followers","following_url":"https://api.github.com/users/DEvil0000/following{/other_user}","gists_url":"https://api.github.com/users/DEvil0000/gists{/gist_id}","starred_url":"https://api.github.com/users/DEvil0000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEvil0000/subscriptions","organizations_url":"https://api.github.com/users/DEvil0000/orgs","repos_url":"https://api.github.com/users/DEvil0000/repos","events_url":"https://api.github.com/users/DEvil0000/events{/privacy}","received_events_url":"https://api.github.com/users/DEvil0000/received_events","type":"User","site_admin":false},"body":"and here its wrong.\r\nSerial.println takes 2 params: 1) the string 2) a \"mode\" like print in hex\r\nyou need to call sprintf() to get the final string and pass it to serial.println","created_at":"2018-11-30T14:21:08Z","updated_at":"2018-11-30T14:22:00Z","html_url":"https://github.com/ToolboxBodensee/fastLED-Treppe/pull/2#discussion_r237875441","pull_request_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/comments/237875441"},"html":{"href":"https://github.com/ToolboxBodensee/fastLED-Treppe/pull/2#discussion_r237875441"},"pull_request":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2","id":233086522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDg2NTIy","html_url":"https://github.com/ToolboxBodensee/fastLED-Treppe/pull/2","diff_url":"https://github.com/ToolboxBodensee/fastLED-Treppe/pull/2.diff","patch_url":"https://github.com/ToolboxBodensee/fastLED-Treppe/pull/2.patch","issue_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/issues/2","number":2,"state":"open","locked":false,"title":"noch ein paar Änderungen + Anmerkungen","user":{"login":"maxbachmann","id":44199644,"node_id":"MDQ6VXNlcjQ0MTk5NjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/44199644?v=4","gravatar_id":"","url":"https://api.github.com/users/maxbachmann","html_url":"https://github.com/maxbachmann","followers_url":"https://api.github.com/users/maxbachmann/followers","following_url":"https://api.github.com/users/maxbachmann/following{/other_user}","gists_url":"https://api.github.com/users/maxbachmann/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbachmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbachmann/subscriptions","organizations_url":"https://api.github.com/users/maxbachmann/orgs","repos_url":"https://api.github.com/users/maxbachmann/repos","events_url":"https://api.github.com/users/maxbachmann/events{/privacy}","received_events_url":"https://api.github.com/users/maxbachmann/received_events","type":"User","site_admin":false},"body":"Die entfernte Funktion kann unter keinen Umständen aufgerufen werden, da m_x immer nur erhöht oder auf 0 gesetzt wird. dh Sie ist nie unter null\r\nDas selbe gilt in Zeile 101 für die or Bedingung die ebenfalls hinfällig ist\r\n\r\ngegenstrecke wird lediglich verringert aber nie erhöht also ist eine Prüfung nach oben aus Zeile 109 hinfällig\r\n\r\nNachdem die Variablen beide nie unter 0 sind und danach immer als uint8_t übergeben werden kann man sie auch von Anfang an so definieren. Auch für gegenstrecke bietet es sich an auf uint8_t umzusteigen.\r\n\r\nm_x kann wohl maximal 6 werden da bei m_x > 5 = 0 gesetzt wird\r\nxA = 5-m_x -> kann -1 sein wird danach dann in Zeile 115 als uint8_t übergeben ist das beabsichtigt? das wäre dann der maximale Wert den eine uint8_t annehmen kann was mir irgendwie falsch erscheint\r\n\r\n\r\nin zeile 114 wird hue erhöht -> in Zeile 115 und 116 ist hue potentiell 256 da die Prüfung erst später erfolgt. Ist das beabsichtigt? das klingt für mich mal falsch\r\n\r\nIch bin mir gerade nicht mehr ganz sicher aber ich glaube die Erhöhung von hue in Zeile 115 erfolgt erst nach dem Funktionsaufruf ist das so erwünscht?","created_at":"2018-11-22T23:56:29Z","updated_at":"2018-11-30T14:22:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f20942b6b7e003ad2d4c2c72f83d7bc332700084","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/issues/2/comments","statuses_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/statuses/a649650ac42c19053fabb2ad99fee7f39586a1a9","head":{"label":"maxbachmann:master","ref":"master","sha":"a649650ac42c19053fabb2ad99fee7f39586a1a9","user":{"login":"maxbachmann","id":44199644,"node_id":"MDQ6VXNlcjQ0MTk5NjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/44199644?v=4","gravatar_id":"","url":"https://api.github.com/users/maxbachmann","html_url":"https://github.com/maxbachmann","followers_url":"https://api.github.com/users/maxbachmann/followers","following_url":"https://api.github.com/users/maxbachmann/following{/other_user}","gists_url":"https://api.github.com/users/maxbachmann/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbachmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbachmann/subscriptions","organizations_url":"https://api.github.com/users/maxbachmann/orgs","repos_url":"https://api.github.com/users/maxbachmann/repos","events_url":"https://api.github.com/users/maxbachmann/events{/privacy}","received_events_url":"https://api.github.com/users/maxbachmann/received_events","type":"User","site_admin":false},"repo":{"id":158757540,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg3NTc1NDA=","name":"fastLED-Treppe","full_name":"maxbachmann/fastLED-Treppe","private":false,"owner":{"login":"maxbachmann","id":44199644,"node_id":"MDQ6VXNlcjQ0MTk5NjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/44199644?v=4","gravatar_id":"","url":"https://api.github.com/users/maxbachmann","html_url":"https://github.com/maxbachmann","followers_url":"https://api.github.com/users/maxbachmann/followers","following_url":"https://api.github.com/users/maxbachmann/following{/other_user}","gists_url":"https://api.github.com/users/maxbachmann/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbachmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbachmann/subscriptions","organizations_url":"https://api.github.com/users/maxbachmann/orgs","repos_url":"https://api.github.com/users/maxbachmann/repos","events_url":"https://api.github.com/users/maxbachmann/events{/privacy}","received_events_url":"https://api.github.com/users/maxbachmann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/maxbachmann/fastLED-Treppe","description":"Code für die Steuerung der LEDs, die in der treppe in den 1. Stock eingebaut sind.","fork":true,"url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe","forks_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/forks","keys_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/teams","hooks_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/hooks","issue_events_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/issues/events{/number}","events_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/events","assignees_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/assignees{/user}","branches_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/branches{/branch}","tags_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/tags","blobs_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/statuses/{sha}","languages_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/languages","stargazers_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/stargazers","contributors_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/contributors","subscribers_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/subscribers","subscription_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/subscription","commits_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/contents/{+path}","compare_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/merges","archive_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/downloads","issues_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/issues{/number}","pulls_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/pulls{/number}","milestones_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/milestones{/number}","notifications_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/labels{/name}","releases_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/releases{/id}","deployments_url":"https://api.github.com/repos/maxbachmann/fastLED-Treppe/deployments","created_at":"2018-11-22T23:03:32Z","updated_at":"2018-11-29T21:18:28Z","pushed_at":"2018-11-29T21:18:26Z","git_url":"git://github.com/maxbachmann/fastLED-Treppe.git","ssh_url":"git@github.com:maxbachmann/fastLED-Treppe.git","clone_url":"https://github.com/maxbachmann/fastLED-Treppe.git","svn_url":"https://github.com/maxbachmann/fastLED-Treppe","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ToolboxBodensee:master","ref":"master","sha":"acc617919fc5682e931c4241fa89693245e89367","user":{"login":"ToolboxBodensee","id":9744766,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3NDQ3NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/9744766?v=4","gravatar_id":"","url":"https://api.github.com/users/ToolboxBodensee","html_url":"https://github.com/ToolboxBodensee","followers_url":"https://api.github.com/users/ToolboxBodensee/followers","following_url":"https://api.github.com/users/ToolboxBodensee/following{/other_user}","gists_url":"https://api.github.com/users/ToolboxBodensee/gists{/gist_id}","starred_url":"https://api.github.com/users/ToolboxBodensee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToolboxBodensee/subscriptions","organizations_url":"https://api.github.com/users/ToolboxBodensee/orgs","repos_url":"https://api.github.com/users/ToolboxBodensee/repos","events_url":"https://api.github.com/users/ToolboxBodensee/events{/privacy}","received_events_url":"https://api.github.com/users/ToolboxBodensee/received_events","type":"Organization","site_admin":false},"repo":{"id":157757123,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3NTcxMjM=","name":"fastLED-Treppe","full_name":"ToolboxBodensee/fastLED-Treppe","private":false,"owner":{"login":"ToolboxBodensee","id":9744766,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3NDQ3NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/9744766?v=4","gravatar_id":"","url":"https://api.github.com/users/ToolboxBodensee","html_url":"https://github.com/ToolboxBodensee","followers_url":"https://api.github.com/users/ToolboxBodensee/followers","following_url":"https://api.github.com/users/ToolboxBodensee/following{/other_user}","gists_url":"https://api.github.com/users/ToolboxBodensee/gists{/gist_id}","starred_url":"https://api.github.com/users/ToolboxBodensee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToolboxBodensee/subscriptions","organizations_url":"https://api.github.com/users/ToolboxBodensee/orgs","repos_url":"https://api.github.com/users/ToolboxBodensee/repos","events_url":"https://api.github.com/users/ToolboxBodensee/events{/privacy}","received_events_url":"https://api.github.com/users/ToolboxBodensee/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ToolboxBodensee/fastLED-Treppe","description":"Code für die Steuerung der LEDs, die in der treppe in den 1. Stock eingebaut sind.","fork":false,"url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe","forks_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/forks","keys_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/teams","hooks_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/hooks","issue_events_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/issues/events{/number}","events_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/events","assignees_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/assignees{/user}","branches_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/branches{/branch}","tags_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/tags","blobs_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/git/refs{/sha}","trees_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/statuses/{sha}","languages_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/languages","stargazers_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/stargazers","contributors_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/contributors","subscribers_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/subscribers","subscription_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/subscription","commits_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/commits{/sha}","git_commits_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/git/commits{/sha}","comments_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/comments{/number}","issue_comment_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/issues/comments{/number}","contents_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/contents/{+path}","compare_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/merges","archive_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/downloads","issues_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/issues{/number}","pulls_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls{/number}","milestones_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/milestones{/number}","notifications_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/labels{/name}","releases_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/releases{/id}","deployments_url":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/deployments","created_at":"2018-11-15T18:46:59Z","updated_at":"2018-11-22T20:10:31Z","pushed_at":"2018-11-29T21:18:27Z","git_url":"git://github.com/ToolboxBodensee/fastLED-Treppe.git","ssh_url":"git@github.com:ToolboxBodensee/fastLED-Treppe.git","clone_url":"https://github.com/ToolboxBodensee/fastLED-Treppe.git","svn_url":"https://github.com/ToolboxBodensee/fastLED-Treppe","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2"},"html":{"href":"https://github.com/ToolboxBodensee/fastLED-Treppe/pull/2"},"issue":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/issues/2"},"comments":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ToolboxBodensee/fastLED-Treppe/statuses/a649650ac42c19053fabb2ad99fee7f39586a1a9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DEvil0000"}}