{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/comments/212388399","pull_request_review_id":149010992,"id":212388399,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM4ODM5OQ==","diff_hunk":"@@ -43,5 +43,8 @@\n     \"eslint\": \"^5.0.0\",\n     \"rimraf\": \"^2.6.1\",\n     \"shelljs\": \"^0.7.7\"\n+  },\n+  \"eslintConfig\": {\n+    \"extends\": \"./eslint.config.js\"","path":"package.json","position":27,"original_position":6,"commit_id":"0b7c9dc038e19dff68b8adc1925a2a83ce745053","original_commit_id":"0b7c9dc038e19dff68b8adc1925a2a83ce745053","user":{"login":"bjankord","id":633148,"node_id":"MDQ6VXNlcjYzMzE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/633148?v=4","gravatar_id":"","url":"https://api.github.com/users/bjankord","html_url":"https://github.com/bjankord","followers_url":"https://api.github.com/users/bjankord/followers","following_url":"https://api.github.com/users/bjankord/following{/other_user}","gists_url":"https://api.github.com/users/bjankord/gists{/gist_id}","starred_url":"https://api.github.com/users/bjankord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjankord/subscriptions","organizations_url":"https://api.github.com/users/bjankord/orgs","repos_url":"https://api.github.com/users/bjankord/repos","events_url":"https://api.github.com/users/bjankord/events{/privacy}","received_events_url":"https://api.github.com/users/bjankord/received_events","type":"User","site_admin":false},"body":"Missed seeing this before the merged. Added in this commit: https://github.com/cerner/eslint-config-terra/commit/6265a4b245e07c3e8c7353d41d29d9c5e7f4ee34","created_at":"2018-08-23T17:14:53Z","updated_at":"2018-08-23T17:14:53Z","html_url":"https://github.com/cerner/eslint-config-terra/pull/10#discussion_r212388399","pull_request_url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/comments/212388399"},"html":{"href":"https://github.com/cerner/eslint-config-terra/pull/10#discussion_r212388399"},"pull_request":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10"}},"in_reply_to_id":212379466},"pull_request":{"url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10","id":208893019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODkzMDE5","html_url":"https://github.com/cerner/eslint-config-terra/pull/10","diff_url":"https://github.com/cerner/eslint-config-terra/pull/10.diff","patch_url":"https://github.com/cerner/eslint-config-terra/pull/10.patch","issue_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues/10","number":10,"state":"closed","locked":false,"title":"Eslint 5 compat update","user":{"login":"bjankord","id":633148,"node_id":"MDQ6VXNlcjYzMzE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/633148?v=4","gravatar_id":"","url":"https://api.github.com/users/bjankord","html_url":"https://github.com/bjankord","followers_url":"https://api.github.com/users/bjankord/followers","following_url":"https://api.github.com/users/bjankord/following{/other_user}","gists_url":"https://api.github.com/users/bjankord/gists{/gist_id}","starred_url":"https://api.github.com/users/bjankord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjankord/subscriptions","organizations_url":"https://api.github.com/users/bjankord/orgs","repos_url":"https://api.github.com/users/bjankord/repos","events_url":"https://api.github.com/users/bjankord/events{/privacy}","received_events_url":"https://api.github.com/users/bjankord/received_events","type":"User","site_admin":false},"body":"### Summary\r\n* Update dependencies to ESLint v5 compatible versions\r\n* Disabled deprecated `jsx-a11y/label-has-for` rule. More info about this rule deprecation here: https://github.com/evcohen/eslint-plugin-jsx-a11y/releases/tag/v6.1.0\r\n* Replaced `jsx-a11y/label-has-for` rule with new `jsx-a11y/label-has-associated-control`. By default, this rule wants inputs to be both wrapped in a label and include a id/for attribute mapping with label. This config updates the rule to require one or the other.\r\n* Disabled `react/destructuring-assignment`.","created_at":"2018-08-16T15:11:36Z","updated_at":"2018-08-23T17:14:53Z","closed_at":"2018-08-23T17:11:13Z","merged_at":"2018-08-23T17:11:13Z","merge_commit_sha":"cebd972a6b9c3715c561319bb281b25e1b4e3cc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1026346592,"node_id":"MDU6TGFiZWwxMDI2MzQ2NTky","url":"https://api.github.com/repos/cerner/eslint-config-terra/labels/major%20version%20bumber","name":"major version bumber","color":"eae307","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10/commits","review_comments_url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10/comments","review_comment_url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues/10/comments","statuses_url":"https://api.github.com/repos/cerner/eslint-config-terra/statuses/0b7c9dc038e19dff68b8adc1925a2a83ce745053","head":{"label":"cerner:eslint-5-compat","ref":"eslint-5-compat","sha":"0b7c9dc038e19dff68b8adc1925a2a83ce745053","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":136082241,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODIyNDE=","name":"eslint-config-terra","full_name":"cerner/eslint-config-terra","owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/eslint-config-terra","description":"Terra eslint config","fork":false,"url":"https://api.github.com/repos/cerner/eslint-config-terra","forks_url":"https://api.github.com/repos/cerner/eslint-config-terra/forks","keys_url":"https://api.github.com/repos/cerner/eslint-config-terra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/eslint-config-terra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/eslint-config-terra/teams","hooks_url":"https://api.github.com/repos/cerner/eslint-config-terra/hooks","issue_events_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/eslint-config-terra/events","assignees_url":"https://api.github.com/repos/cerner/eslint-config-terra/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/eslint-config-terra/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/eslint-config-terra/tags","blobs_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/eslint-config-terra/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/eslint-config-terra/languages","stargazers_url":"https://api.github.com/repos/cerner/eslint-config-terra/stargazers","contributors_url":"https://api.github.com/repos/cerner/eslint-config-terra/contributors","subscribers_url":"https://api.github.com/repos/cerner/eslint-config-terra/subscribers","subscription_url":"https://api.github.com/repos/cerner/eslint-config-terra/subscription","commits_url":"https://api.github.com/repos/cerner/eslint-config-terra/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/eslint-config-terra/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/eslint-config-terra/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/eslint-config-terra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/eslint-config-terra/merges","archive_url":"https://api.github.com/repos/cerner/eslint-config-terra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/eslint-config-terra/downloads","issues_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/eslint-config-terra/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/eslint-config-terra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/eslint-config-terra/labels{/name}","releases_url":"https://api.github.com/repos/cerner/eslint-config-terra/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/eslint-config-terra/deployments","created_at":"2018-06-04T20:59:49Z","updated_at":"2018-08-23T17:14:11Z","pushed_at":"2018-08-23T17:14:10Z","git_url":"git://github.com/cerner/eslint-config-terra.git","ssh_url":"git@github.com:cerner/eslint-config-terra.git","clone_url":"https://github.com/cerner/eslint-config-terra.git","svn_url":"https://github.com/cerner/eslint-config-terra","homepage":null,"size":40,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"83ed4e1d78f4daa1596df81eaa6a14dca44a0ffd","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":136082241,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODIyNDE=","name":"eslint-config-terra","full_name":"cerner/eslint-config-terra","owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/eslint-config-terra","description":"Terra eslint config","fork":false,"url":"https://api.github.com/repos/cerner/eslint-config-terra","forks_url":"https://api.github.com/repos/cerner/eslint-config-terra/forks","keys_url":"https://api.github.com/repos/cerner/eslint-config-terra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/eslint-config-terra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/eslint-config-terra/teams","hooks_url":"https://api.github.com/repos/cerner/eslint-config-terra/hooks","issue_events_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/eslint-config-terra/events","assignees_url":"https://api.github.com/repos/cerner/eslint-config-terra/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/eslint-config-terra/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/eslint-config-terra/tags","blobs_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/eslint-config-terra/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/eslint-config-terra/languages","stargazers_url":"https://api.github.com/repos/cerner/eslint-config-terra/stargazers","contributors_url":"https://api.github.com/repos/cerner/eslint-config-terra/contributors","subscribers_url":"https://api.github.com/repos/cerner/eslint-config-terra/subscribers","subscription_url":"https://api.github.com/repos/cerner/eslint-config-terra/subscription","commits_url":"https://api.github.com/repos/cerner/eslint-config-terra/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/eslint-config-terra/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/eslint-config-terra/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/eslint-config-terra/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/eslint-config-terra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/eslint-config-terra/merges","archive_url":"https://api.github.com/repos/cerner/eslint-config-terra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/eslint-config-terra/downloads","issues_url":"https://api.github.com/repos/cerner/eslint-config-terra/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/eslint-config-terra/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/eslint-config-terra/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/eslint-config-terra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/eslint-config-terra/labels{/name}","releases_url":"https://api.github.com/repos/cerner/eslint-config-terra/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/eslint-config-terra/deployments","created_at":"2018-06-04T20:59:49Z","updated_at":"2018-08-23T17:14:11Z","pushed_at":"2018-08-23T17:14:10Z","git_url":"git://github.com/cerner/eslint-config-terra.git","ssh_url":"git@github.com:cerner/eslint-config-terra.git","clone_url":"https://github.com/cerner/eslint-config-terra.git","svn_url":"https://github.com/cerner/eslint-config-terra","homepage":null,"size":40,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10"},"html":{"href":"https://github.com/cerner/eslint-config-terra/pull/10"},"issue":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/issues/10"},"comments":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/eslint-config-terra/statuses/0b7c9dc038e19dff68b8adc1925a2a83ce745053"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bjankord"}}