{"action":"created","comment":{"url":"https://api.github.com/repos/brave/brave-core/pulls/comments/217902680","pull_request_review_id":155732499,"id":217902680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkwMjY4MA==","diff_hunk":"@@ -82,10 +82,13 @@ declare namespace Rewards {\n     expiryTime: number\n   }\n \n+  export type Excluded = 0 | 1 | 2","path":"components/definitions/rewards.d.ts","position":4,"original_position":4,"commit_id":"89da6f6fe12b677298535be136dd400b94341dee","original_commit_id":"89da6f6fe12b677298535be136dd400b94341dee","user":{"login":"NejcZdovc","id":9574457,"node_id":"MDQ6VXNlcjk1NzQ0NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"body":"@ryanml ","created_at":"2018-09-16T05:31:18Z","updated_at":"2018-09-16T05:31:18Z","html_url":"https://github.com/brave/brave-core/pull/420#discussion_r217902680","pull_request_url":"https://api.github.com/repos/brave/brave-core/pulls/420","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments/217902680"},"html":{"href":"https://github.com/brave/brave-core/pull/420#discussion_r217902680"},"pull_request":{"href":"https://api.github.com/repos/brave/brave-core/pulls/420"}},"in_reply_to_id":217881707},"pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/420","id":214000435,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDAwNDM1","html_url":"https://github.com/brave/brave-core/pull/420","diff_url":"https://github.com/brave/brave-core/pull/420.diff","patch_url":"https://github.com/brave/brave-core/pull/420.patch","issue_url":"https://api.github.com/repos/brave/brave-core/issues/420","number":420,"state":"closed","locked":false,"title":"Adding option to remove sites from auto-contribute","user":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"body":"Addresses: https://github.com/brave/brave-browser/issues/967\r\n\r\nNative ledger work:\r\nhttps://github.com/brave-intl/bat-native-ledger/pull/87\r\nhttps://github.com/brave-intl/bat-native-ledger/pull/93\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone \r\n\r\n## Test Plan:\r\n1. Launch Brave, enable rewards\r\n2. Visit 6 sites to populate contributions table\r\n3. In the contribution table, click `See all ${n} sites` to display the removal modal\r\n4. Click the `x` icon next to a few publishers\r\n5. Confirm they are excluded and removed from the contribution table\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions \r\n- [ ] Verify test plan is specified in PR before merging to source","created_at":"2018-09-07T18:04:15Z","updated_at":"2018-09-16T05:31:18Z","closed_at":"2018-09-11T16:04:40Z","merged_at":"2018-09-11T16:04:40Z","merge_commit_sha":"7564b7c8e900b521750b7c5e9f6007abf21a62fa","assignee":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"assignees":[{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bbondy","id":831718,"node_id":"MDQ6VXNlcjgzMTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},{"login":"SergeyZhukovsky","id":12011303,"node_id":"MDQ6VXNlcjEyMDExMzAz","avatar_url":"https://avatars2.githubusercontent.com/u/12011303?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyZhukovsky","html_url":"https://github.com/SergeyZhukovsky","followers_url":"https://api.github.com/users/SergeyZhukovsky/followers","following_url":"https://api.github.com/users/SergeyZhukovsky/following{/other_user}","gists_url":"https://api.github.com/users/SergeyZhukovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyZhukovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyZhukovsky/subscriptions","organizations_url":"https://api.github.com/users/SergeyZhukovsky/orgs","repos_url":"https://api.github.com/users/SergeyZhukovsky/repos","events_url":"https://api.github.com/users/SergeyZhukovsky/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyZhukovsky/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1048208939,"node_id":"MDU6TGFiZWwxMDQ4MjA4OTM5","url":"https://api.github.com/repos/brave/brave-core/labels/merged/0.55.x","name":"merged/0.55.x","color":"fcc7f5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-core/pulls/420/commits","review_comments_url":"https://api.github.com/repos/brave/brave-core/pulls/420/comments","review_comment_url":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/420/comments","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/89da6f6fe12b677298535be136dd400b94341dee","head":{"label":"ryanml:remove-sites","ref":"remove-sites","sha":"89da6f6fe12b677298535be136dd400b94341dee","user":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"repo":{"id":147751489,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3NTE0ODk=","name":"brave-core","full_name":"ryanml/brave-core","private":false,"owner":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ryanml/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android. For the issue log, please see https://github.com/brave/brave-browser","fork":true,"url":"https://api.github.com/repos/ryanml/brave-core","forks_url":"https://api.github.com/repos/ryanml/brave-core/forks","keys_url":"https://api.github.com/repos/ryanml/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanml/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanml/brave-core/teams","hooks_url":"https://api.github.com/repos/ryanml/brave-core/hooks","issue_events_url":"https://api.github.com/repos/ryanml/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/ryanml/brave-core/events","assignees_url":"https://api.github.com/repos/ryanml/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/ryanml/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/ryanml/brave-core/tags","blobs_url":"https://api.github.com/repos/ryanml/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanml/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanml/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanml/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanml/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanml/brave-core/languages","stargazers_url":"https://api.github.com/repos/ryanml/brave-core/stargazers","contributors_url":"https://api.github.com/repos/ryanml/brave-core/contributors","subscribers_url":"https://api.github.com/repos/ryanml/brave-core/subscribers","subscription_url":"https://api.github.com/repos/ryanml/brave-core/subscription","commits_url":"https://api.github.com/repos/ryanml/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanml/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanml/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanml/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanml/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/ryanml/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanml/brave-core/merges","archive_url":"https://api.github.com/repos/ryanml/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanml/brave-core/downloads","issues_url":"https://api.github.com/repos/ryanml/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/ryanml/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanml/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanml/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanml/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/ryanml/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/ryanml/brave-core/deployments","created_at":"2018-09-07T01:04:11Z","updated_at":"2018-09-07T01:04:17Z","pushed_at":"2018-09-15T22:18:28Z","git_url":"git://github.com/ryanml/brave-core.git","ssh_url":"git@github.com:ryanml/brave-core.git","clone_url":"https://github.com/ryanml/brave-core.git","svn_url":"https://github.com/ryanml/brave-core","homepage":"","size":46639,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"6a7719129e8a51f3b422c56a5d64c2783bcd5e4d","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android. For the issue log, please see https://github.com/brave/brave-browser","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-09-15T23:32:02Z","pushed_at":"2018-09-15T23:33:11Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":46366,"stargazers_count":126,"watchers_count":126,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":15,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/420"},"html":{"href":"https://github.com/brave/brave-core/pull/420"},"issue":{"href":"https://api.github.com/repos/brave/brave-core/issues/420"},"comments":{"href":"https://api.github.com/repos/brave/brave-core/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-core/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-core/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-core/statuses/89da6f6fe12b677298535be136dd400b94341dee"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"NejcZdovc"}}