{"action":"closed","number":141,"pull_request":{"url":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/141","id":179178228,"html_url":"https://github.com/mvc-spec/mvc-spec/pull/141","diff_url":"https://github.com/mvc-spec/mvc-spec/pull/141.diff","patch_url":"https://github.com/mvc-spec/mvc-spec/pull/141.patch","issue_url":"https://api.github.com/repos/mvc-spec/mvc-spec/issues/141","number":141,"state":"closed","locked":false,"title":"TCK annotations for Chapter 2","user":{"login":"chkal","id":159245,"avatar_url":"https://avatars2.githubusercontent.com/u/159245?v=4","gravatar_id":"","url":"https://api.github.com/users/chkal","html_url":"https://github.com/chkal","followers_url":"https://api.github.com/users/chkal/followers","following_url":"https://api.github.com/users/chkal/following{/other_user}","gists_url":"https://api.github.com/users/chkal/gists{/gist_id}","starred_url":"https://api.github.com/users/chkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkal/subscriptions","organizations_url":"https://api.github.com/users/chkal/orgs","repos_url":"https://api.github.com/users/chkal/repos","events_url":"https://api.github.com/users/chkal/events{/privacy}","received_events_url":"https://api.github.com/users/chkal/received_events","type":"User","site_admin":false},"body":"This PR adds `[tck-testable]` annotations to chapter 2 of the specification. The chapter now contains 32 assertions we need to test in the TCK. A lot of work. :smile: \r\n\r\nA few notes:\r\n* I also reformatted some of the paragraphs to match the \"one sentence per line\" pattern.\r\n* I renamed the `[tck-test-id-FOOBAR]` annotation to `[tck-id-FOOBAR]` so it gets a bit shorter.\r\n* I removed the old assertion references pointing to the Assertions chapter. I think we can remove the Assertions chapter in the end because our new assertion tracking is much better.\r\n* I compared the old and the new PDF file and it looks like I broke nothing. Just the old assertion references were removed.\r\n\r\nI will start implementing the first TCK tests for this chapter in the next days. Just to get a feeling for how many TCK tests per hour I can write. :laughing: \r\n","created_at":"2018-04-03T18:13:21Z","updated_at":"2018-04-05T15:27:13Z","closed_at":"2018-04-05T15:27:13Z","merged_at":"2018-04-05T15:27:13Z","merge_commit_sha":"e2a8292cbf560fd7cb1680411267778cc44887e2","assignee":{"login":"chkal","id":159245,"avatar_url":"https://avatars2.githubusercontent.com/u/159245?v=4","gravatar_id":"","url":"https://api.github.com/users/chkal","html_url":"https://github.com/chkal","followers_url":"https://api.github.com/users/chkal/followers","following_url":"https://api.github.com/users/chkal/following{/other_user}","gists_url":"https://api.github.com/users/chkal/gists{/gist_id}","starred_url":"https://api.github.com/users/chkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkal/subscriptions","organizations_url":"https://api.github.com/users/chkal/orgs","repos_url":"https://api.github.com/users/chkal/repos","events_url":"https://api.github.com/users/chkal/events{/privacy}","received_events_url":"https://api.github.com/users/chkal/received_events","type":"User","site_admin":false},"assignees":[{"login":"chkal","id":159245,"avatar_url":"https://avatars2.githubusercontent.com/u/159245?v=4","gravatar_id":"","url":"https://api.github.com/users/chkal","html_url":"https://github.com/chkal","followers_url":"https://api.github.com/users/chkal/followers","following_url":"https://api.github.com/users/chkal/following{/other_user}","gists_url":"https://api.github.com/users/chkal/gists{/gist_id}","starred_url":"https://api.github.com/users/chkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkal/subscriptions","organizations_url":"https://api.github.com/users/chkal/orgs","repos_url":"https://api.github.com/users/chkal/repos","events_url":"https://api.github.com/users/chkal/events{/privacy}","received_events_url":"https://api.github.com/users/chkal/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/mvc-spec/mvc-spec/milestones/4","html_url":"https://github.com/mvc-spec/mvc-spec/milestone/4","labels_url":"https://api.github.com/repos/mvc-spec/mvc-spec/milestones/4/labels","id":3105515,"number":4,"title":"1.0-pfd","description":"Proposed Final Draft","creator":{"login":"chkal","id":159245,"avatar_url":"https://avatars2.githubusercontent.com/u/159245?v=4","gravatar_id":"","url":"https://api.github.com/users/chkal","html_url":"https://github.com/chkal","followers_url":"https://api.github.com/users/chkal/followers","following_url":"https://api.github.com/users/chkal/following{/other_user}","gists_url":"https://api.github.com/users/chkal/gists{/gist_id}","starred_url":"https://api.github.com/users/chkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkal/subscriptions","organizations_url":"https://api.github.com/users/chkal/orgs","repos_url":"https://api.github.com/users/chkal/repos","events_url":"https://api.github.com/users/chkal/events{/privacy}","received_events_url":"https://api.github.com/users/chkal/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":22,"state":"open","created_at":"2018-02-11T12:30:49Z","updated_at":"2018-04-05T15:27:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/141/commits","review_comments_url":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/141/comments","review_comment_url":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mvc-spec/mvc-spec/issues/141/comments","statuses_url":"https://api.github.com/repos/mvc-spec/mvc-spec/statuses/9a4401fa271db20abbc6f087f71eea1ae0d0ec46","head":{"label":"chkal:tck1","ref":"tck1","sha":"9a4401fa271db20abbc6f087f71eea1ae0d0ec46","user":{"login":"chkal","id":159245,"avatar_url":"https://avatars2.githubusercontent.com/u/159245?v=4","gravatar_id":"","url":"https://api.github.com/users/chkal","html_url":"https://github.com/chkal","followers_url":"https://api.github.com/users/chkal/followers","following_url":"https://api.github.com/users/chkal/following{/other_user}","gists_url":"https://api.github.com/users/chkal/gists{/gist_id}","starred_url":"https://api.github.com/users/chkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkal/subscriptions","organizations_url":"https://api.github.com/users/chkal/orgs","repos_url":"https://api.github.com/users/chkal/repos","events_url":"https://api.github.com/users/chkal/events{/privacy}","received_events_url":"https://api.github.com/users/chkal/received_events","type":"User","site_admin":false},"repo":{"id":54256356,"name":"mvc-spec","full_name":"chkal/mvc-spec","owner":{"login":"chkal","id":159245,"avatar_url":"https://avatars2.githubusercontent.com/u/159245?v=4","gravatar_id":"","url":"https://api.github.com/users/chkal","html_url":"https://github.com/chkal","followers_url":"https://api.github.com/users/chkal/followers","following_url":"https://api.github.com/users/chkal/following{/other_user}","gists_url":"https://api.github.com/users/chkal/gists{/gist_id}","starred_url":"https://api.github.com/users/chkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkal/subscriptions","organizations_url":"https://api.github.com/users/chkal/orgs","repos_url":"https://api.github.com/users/chkal/repos","events_url":"https://api.github.com/users/chkal/events{/privacy}","received_events_url":"https://api.github.com/users/chkal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chkal/mvc-spec","description":"MVC 1.0 API","fork":true,"url":"https://api.github.com/repos/chkal/mvc-spec","forks_url":"https://api.github.com/repos/chkal/mvc-spec/forks","keys_url":"https://api.github.com/repos/chkal/mvc-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chkal/mvc-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chkal/mvc-spec/teams","hooks_url":"https://api.github.com/repos/chkal/mvc-spec/hooks","issue_events_url":"https://api.github.com/repos/chkal/mvc-spec/issues/events{/number}","events_url":"https://api.github.com/repos/chkal/mvc-spec/events","assignees_url":"https://api.github.com/repos/chkal/mvc-spec/assignees{/user}","branches_url":"https://api.github.com/repos/chkal/mvc-spec/branches{/branch}","tags_url":"https://api.github.com/repos/chkal/mvc-spec/tags","blobs_url":"https://api.github.com/repos/chkal/mvc-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chkal/mvc-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chkal/mvc-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/chkal/mvc-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chkal/mvc-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/chkal/mvc-spec/languages","stargazers_url":"https://api.github.com/repos/chkal/mvc-spec/stargazers","contributors_url":"https://api.github.com/repos/chkal/mvc-spec/contributors","subscribers_url":"https://api.github.com/repos/chkal/mvc-spec/subscribers","subscription_url":"https://api.github.com/repos/chkal/mvc-spec/subscription","commits_url":"https://api.github.com/repos/chkal/mvc-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/chkal/mvc-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/chkal/mvc-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/chkal/mvc-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/chkal/mvc-spec/contents/{+path}","compare_url":"https://api.github.com/repos/chkal/mvc-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chkal/mvc-spec/merges","archive_url":"https://api.github.com/repos/chkal/mvc-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chkal/mvc-spec/downloads","issues_url":"https://api.github.com/repos/chkal/mvc-spec/issues{/number}","pulls_url":"https://api.github.com/repos/chkal/mvc-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/chkal/mvc-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/chkal/mvc-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chkal/mvc-spec/labels{/name}","releases_url":"https://api.github.com/repos/chkal/mvc-spec/releases{/id}","deployments_url":"https://api.github.com/repos/chkal/mvc-spec/deployments","created_at":"2016-03-19T08:47:19Z","updated_at":"2018-04-03T06:29:20Z","pushed_at":"2018-04-03T18:05:38Z","git_url":"git://github.com/chkal/mvc-spec.git","ssh_url":"git@github.com:chkal/mvc-spec.git","clone_url":"https://github.com/chkal/mvc-spec.git","svn_url":"https://github.com/chkal/mvc-spec","homepage":"","size":3873,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mvc-spec:master","ref":"master","sha":"f4b2465c20f1b7372bff1b085dd83cfd99305401","user":{"login":"mvc-spec","id":17296618,"avatar_url":"https://avatars3.githubusercontent.com/u/17296618?v=4","gravatar_id":"","url":"https://api.github.com/users/mvc-spec","html_url":"https://github.com/mvc-spec","followers_url":"https://api.github.com/users/mvc-spec/followers","following_url":"https://api.github.com/users/mvc-spec/following{/other_user}","gists_url":"https://api.github.com/users/mvc-spec/gists{/gist_id}","starred_url":"https://api.github.com/users/mvc-spec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvc-spec/subscriptions","organizations_url":"https://api.github.com/users/mvc-spec/orgs","repos_url":"https://api.github.com/users/mvc-spec/repos","events_url":"https://api.github.com/users/mvc-spec/events{/privacy}","received_events_url":"https://api.github.com/users/mvc-spec/received_events","type":"Organization","site_admin":false},"repo":{"id":51989047,"name":"mvc-spec","full_name":"mvc-spec/mvc-spec","owner":{"login":"mvc-spec","id":17296618,"avatar_url":"https://avatars3.githubusercontent.com/u/17296618?v=4","gravatar_id":"","url":"https://api.github.com/users/mvc-spec","html_url":"https://github.com/mvc-spec","followers_url":"https://api.github.com/users/mvc-spec/followers","following_url":"https://api.github.com/users/mvc-spec/following{/other_user}","gists_url":"https://api.github.com/users/mvc-spec/gists{/gist_id}","starred_url":"https://api.github.com/users/mvc-spec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvc-spec/subscriptions","organizations_url":"https://api.github.com/users/mvc-spec/orgs","repos_url":"https://api.github.com/users/mvc-spec/repos","events_url":"https://api.github.com/users/mvc-spec/events{/privacy}","received_events_url":"https://api.github.com/users/mvc-spec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mvc-spec/mvc-spec","description":"MVC 1.0 API","fork":false,"url":"https://api.github.com/repos/mvc-spec/mvc-spec","forks_url":"https://api.github.com/repos/mvc-spec/mvc-spec/forks","keys_url":"https://api.github.com/repos/mvc-spec/mvc-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvc-spec/mvc-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvc-spec/mvc-spec/teams","hooks_url":"https://api.github.com/repos/mvc-spec/mvc-spec/hooks","issue_events_url":"https://api.github.com/repos/mvc-spec/mvc-spec/issues/events{/number}","events_url":"https://api.github.com/repos/mvc-spec/mvc-spec/events","assignees_url":"https://api.github.com/repos/mvc-spec/mvc-spec/assignees{/user}","branches_url":"https://api.github.com/repos/mvc-spec/mvc-spec/branches{/branch}","tags_url":"https://api.github.com/repos/mvc-spec/mvc-spec/tags","blobs_url":"https://api.github.com/repos/mvc-spec/mvc-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvc-spec/mvc-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvc-spec/mvc-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvc-spec/mvc-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvc-spec/mvc-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/mvc-spec/mvc-spec/languages","stargazers_url":"https://api.github.com/repos/mvc-spec/mvc-spec/stargazers","contributors_url":"https://api.github.com/repos/mvc-spec/mvc-spec/contributors","subscribers_url":"https://api.github.com/repos/mvc-spec/mvc-spec/subscribers","subscription_url":"https://api.github.com/repos/mvc-spec/mvc-spec/subscription","commits_url":"https://api.github.com/repos/mvc-spec/mvc-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvc-spec/mvc-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvc-spec/mvc-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvc-spec/mvc-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvc-spec/mvc-spec/contents/{+path}","compare_url":"https://api.github.com/repos/mvc-spec/mvc-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvc-spec/mvc-spec/merges","archive_url":"https://api.github.com/repos/mvc-spec/mvc-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvc-spec/mvc-spec/downloads","issues_url":"https://api.github.com/repos/mvc-spec/mvc-spec/issues{/number}","pulls_url":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/mvc-spec/mvc-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/mvc-spec/mvc-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvc-spec/mvc-spec/labels{/name}","releases_url":"https://api.github.com/repos/mvc-spec/mvc-spec/releases{/id}","deployments_url":"https://api.github.com/repos/mvc-spec/mvc-spec/deployments","created_at":"2016-02-18T07:36:07Z","updated_at":"2018-03-31T06:05:19Z","pushed_at":"2018-04-05T15:27:13Z","git_url":"git://github.com/mvc-spec/mvc-spec.git","ssh_url":"git@github.com:mvc-spec/mvc-spec.git","clone_url":"https://github.com/mvc-spec/mvc-spec.git","svn_url":"https://github.com/mvc-spec/mvc-spec","homepage":"","size":3877,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":8,"open_issues":14,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/141"},"html":{"href":"https://github.com/mvc-spec/mvc-spec/pull/141"},"issue":{"href":"https://api.github.com/repos/mvc-spec/mvc-spec/issues/141"},"comments":{"href":"https://api.github.com/repos/mvc-spec/mvc-spec/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mvc-spec/mvc-spec/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/mvc-spec/mvc-spec/statuses/9a4401fa271db20abbc6f087f71eea1ae0d0ec46"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"chkal","id":159245,"avatar_url":"https://avatars2.githubusercontent.com/u/159245?v=4","gravatar_id":"","url":"https://api.github.com/users/chkal","html_url":"https://github.com/chkal","followers_url":"https://api.github.com/users/chkal/followers","following_url":"https://api.github.com/users/chkal/following{/other_user}","gists_url":"https://api.github.com/users/chkal/gists{/gist_id}","starred_url":"https://api.github.com/users/chkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkal/subscriptions","organizations_url":"https://api.github.com/users/chkal/orgs","repos_url":"https://api.github.com/users/chkal/repos","events_url":"https://api.github.com/users/chkal/events{/privacy}","received_events_url":"https://api.github.com/users/chkal/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":48,"deletions":65,"changed_files":4}}
{"actor":{"display_login":"chkal"}}