{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/726","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/726/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/726/events","html_url":"https://github.com/openjournals/joss-reviews/issues/726","id":320799645,"node_id":"MDU6SXNzdWUzMjA3OTk2NDU=","number":726,"title":"[REVIEW]: mlpack 3: a fast, flexible machine learning library","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":330465313,"node_id":"MDU6TGFiZWwzMzA0NjUzMTM=","url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"Kevin-Mattheus-Moerman","id":8392709,"node_id":"MDQ6VXNlcjgzOTI3MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/8392709?v=4","gravatar_id":"","url":"https://api.github.com/users/Kevin-Mattheus-Moerman","html_url":"https://github.com/Kevin-Mattheus-Moerman","followers_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/followers","following_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/following{/other_user}","gists_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/gists{/gist_id}","starred_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/subscriptions","organizations_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/orgs","repos_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/repos","events_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/events{/privacy}","received_events_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/received_events","type":"User","site_admin":false},"assignees":[{"login":"mlgill","id":1757241,"node_id":"MDQ6VXNlcjE3NTcyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1757241?v=4","gravatar_id":"","url":"https://api.github.com/users/mlgill","html_url":"https://github.com/mlgill","followers_url":"https://api.github.com/users/mlgill/followers","following_url":"https://api.github.com/users/mlgill/following{/other_user}","gists_url":"https://api.github.com/users/mlgill/gists{/gist_id}","starred_url":"https://api.github.com/users/mlgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlgill/subscriptions","organizations_url":"https://api.github.com/users/mlgill/orgs","repos_url":"https://api.github.com/users/mlgill/repos","events_url":"https://api.github.com/users/mlgill/events{/privacy}","received_events_url":"https://api.github.com/users/mlgill/received_events","type":"User","site_admin":false},{"login":"MikeInnes","id":2234614,"node_id":"MDQ6VXNlcjIyMzQ2MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2234614?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeInnes","html_url":"https://github.com/MikeInnes","followers_url":"https://api.github.com/users/MikeInnes/followers","following_url":"https://api.github.com/users/MikeInnes/following{/other_user}","gists_url":"https://api.github.com/users/MikeInnes/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeInnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeInnes/subscriptions","organizations_url":"https://api.github.com/users/MikeInnes/orgs","repos_url":"https://api.github.com/users/MikeInnes/repos","events_url":"https://api.github.com/users/MikeInnes/events{/privacy}","received_events_url":"https://api.github.com/users/MikeInnes/received_events","type":"User","site_admin":false},{"login":"rasbt","id":5618407,"node_id":"MDQ6VXNlcjU2MTg0MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/5618407?v=4","gravatar_id":"","url":"https://api.github.com/users/rasbt","html_url":"https://github.com/rasbt","followers_url":"https://api.github.com/users/rasbt/followers","following_url":"https://api.github.com/users/rasbt/following{/other_user}","gists_url":"https://api.github.com/users/rasbt/gists{/gist_id}","starred_url":"https://api.github.com/users/rasbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasbt/subscriptions","organizations_url":"https://api.github.com/users/rasbt/orgs","repos_url":"https://api.github.com/users/rasbt/repos","events_url":"https://api.github.com/users/rasbt/events{/privacy}","received_events_url":"https://api.github.com/users/rasbt/received_events","type":"User","site_admin":false},{"login":"Kevin-Mattheus-Moerman","id":8392709,"node_id":"MDQ6VXNlcjgzOTI3MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/8392709?v=4","gravatar_id":"","url":"https://api.github.com/users/Kevin-Mattheus-Moerman","html_url":"https://github.com/Kevin-Mattheus-Moerman","followers_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/followers","following_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/following{/other_user}","gists_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/gists{/gist_id}","starred_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/subscriptions","organizations_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/orgs","repos_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/repos","events_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/events{/privacy}","received_events_url":"https://api.github.com/users/Kevin-Mattheus-Moerman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":28,"created_at":"2018-05-07T13:13:25Z","updated_at":"2018-06-04T02:30:19Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @rcurtin (<a href=\"http://orcid.org/0000-0002-9903-8214\">Ryan Curtin</a>)\r\n**Repository:** <a href=\"https://github.com/mlpack/mlpack\" target =\"_blank\">https://github.com/mlpack/mlpack</a>\r\n**Version:** v3.0.0\r\n**Editor:** @Kevin-Mattheus-Moerman\r\n**Reviewer:** @rasbt, @MikeInnes, @mlgill\r\n**Archive:** Pending\r\n\r\n## Status\r\n\r\n[![status](http://joss.theoj.org/papers/f9fb80cf56e79edd4d87e5cf7c5f1759/status.svg)](http://joss.theoj.org/papers/f9fb80cf56e79edd4d87e5cf7c5f1759)\r\n\r\nStatus badge code:\r\n\r\n```\r\nHTML: <a href=\"http://joss.theoj.org/papers/f9fb80cf56e79edd4d87e5cf7c5f1759\"><img src=\"http://joss.theoj.org/papers/f9fb80cf56e79edd4d87e5cf7c5f1759/status.svg\"></a>\r\nMarkdown: [![status](http://joss.theoj.org/papers/f9fb80cf56e79edd4d87e5cf7c5f1759/status.svg)](http://joss.theoj.org/papers/f9fb80cf56e79edd4d87e5cf7c5f1759)\r\n```\r\n**Reviewers and authors**:\r\n\r\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://github.com/mlpack/mlpack\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\r\n\r\n## Reviewer instructions & questions\r\n\r\n@rasbt & @MikeInnes & @mlgill, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\r\n1. Make sure you're logged in to your GitHub account\r\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations\r\n\r\nThe reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.\r\n\r\n## Review checklist for @rasbt\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/mlpack/mlpack\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [ ] **Version:** Does the release version given match the GitHub release (v3.0.0)?\r\n- [x] **Authorship:** Has the submitting author (@rcurtin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [ ] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [ ] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n\r\n## Review checklist for @MikeInnes\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/mlpack/mlpack\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (v3.0.0)?\r\n- [x] **Authorship:** Has the submitting author (@rcurtin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [ ] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [ ] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [ ] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n\r\n## Review checklist for @mlgill\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/mlpack/mlpack\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [ ] **Version:** Does the release version given match the GitHub release (v3.0.0)? **MG: version is 3.0.1**\r\n- [x] **Authorship:** Has the submitting author (@rcurtin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [ ] **Installation:** Does installation proceed as outlined in the documentation? **MG: ToDo**\r\n- [ ] **Functionality:** Have the functional claims of the software been confirmed? **MG: ToDo**\r\n- [ ] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.) **MG: ToDo**\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x ] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution. \r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)? **MG: DOIs needed, have filed an issue**\r\n\r\n## Review checklist for @rstolyarov\r\n### Conflict of interest\r\n\r\n- [ ] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [ ] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [ ] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/mlpack/mlpack\">repository url</a>?\r\n- [ ] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [ ] **Version:** Does the release version given match the GitHub release (v3.0.0)?\r\n- [ ] **Authorship:** Has the submitting author (@rcurtin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [ ] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [ ] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [ ] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [ ] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [ ] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [ ] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [ ] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [ ] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [ ] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/394218294","html_url":"https://github.com/openjournals/joss-reviews/issues/726#issuecomment-394218294","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/726","id":394218294,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDIxODI5NA==","user":{"login":"mlgill","id":1757241,"node_id":"MDQ6VXNlcjE3NTcyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1757241?v=4","gravatar_id":"","url":"https://api.github.com/users/mlgill","html_url":"https://github.com/mlgill","followers_url":"https://api.github.com/users/mlgill/followers","following_url":"https://api.github.com/users/mlgill/following{/other_user}","gists_url":"https://api.github.com/users/mlgill/gists{/gist_id}","starred_url":"https://api.github.com/users/mlgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlgill/subscriptions","organizations_url":"https://api.github.com/users/mlgill/orgs","repos_url":"https://api.github.com/users/mlgill/repos","events_url":"https://api.github.com/users/mlgill/events{/privacy}","received_events_url":"https://api.github.com/users/mlgill/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T02:30:18Z","updated_at":"2018-06-04T02:30:18Z","author_association":"COLLABORATOR","body":"@Kevin-Mattheus-Moerman \r\n\r\nI am still in the process of getting the Python bindings installed. From some of @rasbt's comments on the repo issues, it seems I am not the only one. I will have to work on it later this week.\r\n\r\n@rcurtin Thanks for updating the DOIs. Can you rebuild the PDF so I can look at that directly? Thanks."}}
{"actor":{"display_login":"mlgill"}}