{"action":"created","comment":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments/174794470","pull_request_review_id":104215871,"id":174794470,"diff_hunk":"@@ -181,6 +184,18 @@ export class Editor3Component extends React.Component {\n         return getDefaultKeyBinding(e);\n     }\n \n+    handleBeforeInputCombined() {\n+        const handlers = [this.handleBeforeInput, this.handleBeforeInputHighlightsBound];\n+\n+        for (let i = 0; i < handlers.length; i++) {\n+            if (handlers[i].apply(this, arguments) === 'handled') {\n+                return 'handled';","path":"scripts/core/editor3/components/Editor3Component.jsx","position":26,"original_position":26,"commit_id":"4a0896fb40a797a1b48d59f6a5fe12e3d9e4de7f","original_commit_id":"4a0896fb40a797a1b48d59f6a5fe12e3d9e4de7f","user":{"login":"tomaskikutis","id":2076953,"avatar_url":"https://avatars0.githubusercontent.com/u/2076953?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaskikutis","html_url":"https://github.com/tomaskikutis","followers_url":"https://api.github.com/users/tomaskikutis/followers","following_url":"https://api.github.com/users/tomaskikutis/following{/other_user}","gists_url":"https://api.github.com/users/tomaskikutis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaskikutis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaskikutis/subscriptions","organizations_url":"https://api.github.com/users/tomaskikutis/orgs","repos_url":"https://api.github.com/users/tomaskikutis/repos","events_url":"https://api.github.com/users/tomaskikutis/events{/privacy}","received_events_url":"https://api.github.com/users/tomaskikutis/received_events","type":"User","site_admin":false},"body":"> When we add a new handleBefore function we need to take a look at all other handleBefore function to know where to add the new function in the list. Also can be situations when this kind of ordering is just not working.\r\n\r\nI think we are stuck in a circular reasoning. You are saying, that handlers need to be ordered, because you >need to take a look at all other handleBefore function(...)\r\n\r\nWhat I'm asking is why do you need to look at other functions? What I'm claiming with my proposal is that you don't and that handlers would work in any order. I might be wrong here since it's not an easy problem, but I'm interested if we know an exact use case where it wouldn't work?","created_at":"2018-03-15T14:09:00Z","updated_at":"2018-03-15T14:09:01Z","html_url":"https://github.com/superdesk/superdesk-client-core/pull/2149#discussion_r174794470","pull_request_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments/174794470"},"html":{"href":"https://github.com/superdesk/superdesk-client-core/pull/2149#discussion_r174794470"},"pull_request":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149"}},"in_reply_to_id":174412200},"pull_request":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149","id":174859928,"html_url":"https://github.com/superdesk/superdesk-client-core/pull/2149","diff_url":"https://github.com/superdesk/superdesk-client-core/pull/2149.diff","patch_url":"https://github.com/superdesk/superdesk-client-core/pull/2149.patch","issue_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2149","number":2149,"state":"open","locked":false,"title":" Prevent extending a text-highlight when inserting text right after it","user":{"login":"tomaskikutis","id":2076953,"avatar_url":"https://avatars0.githubusercontent.com/u/2076953?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaskikutis","html_url":"https://github.com/tomaskikutis","followers_url":"https://api.github.com/users/tomaskikutis/followers","following_url":"https://api.github.com/users/tomaskikutis/following{/other_user}","gists_url":"https://api.github.com/users/tomaskikutis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaskikutis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaskikutis/subscriptions","organizations_url":"https://api.github.com/users/tomaskikutis/orgs","repos_url":"https://api.github.com/users/tomaskikutis/repos","events_url":"https://api.github.com/users/tomaskikutis/events{/privacy}","received_events_url":"https://api.github.com/users/tomaskikutis/received_events","type":"User","site_admin":false},"body":"SDESK-2491","created_at":"2018-03-14T05:49:35Z","updated_at":"2018-03-15T14:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce79f2a54b3196a1e35bf9102edc12b4a86777e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones/27","html_url":"https://github.com/superdesk/superdesk-client-core/milestone/27","labels_url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones/27/labels","id":3155804,"number":27,"title":"1.15","description":"","creator":{"login":"petrjasek","id":179249,"avatar_url":"https://avatars1.githubusercontent.com/u/179249?v=4","gravatar_id":"","url":"https://api.github.com/users/petrjasek","html_url":"https://github.com/petrjasek","followers_url":"https://api.github.com/users/petrjasek/followers","following_url":"https://api.github.com/users/petrjasek/following{/other_user}","gists_url":"https://api.github.com/users/petrjasek/gists{/gist_id}","starred_url":"https://api.github.com/users/petrjasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrjasek/subscriptions","organizations_url":"https://api.github.com/users/petrjasek/orgs","repos_url":"https://api.github.com/users/petrjasek/repos","events_url":"https://api.github.com/users/petrjasek/events{/privacy}","received_events_url":"https://api.github.com/users/petrjasek/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":33,"state":"open","created_at":"2018-03-02T10:28:29Z","updated_at":"2018-03-15T10:25:39Z","due_on":"2018-03-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149/commits","review_comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149/comments","review_comment_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2149/comments","statuses_url":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/4a0896fb40a797a1b48d59f6a5fe12e3d9e4de7f","head":{"label":"tomaskikutis:fix-text-highlight-boundaries","ref":"fix-text-highlight-boundaries","sha":"4a0896fb40a797a1b48d59f6a5fe12e3d9e4de7f","user":{"login":"tomaskikutis","id":2076953,"avatar_url":"https://avatars0.githubusercontent.com/u/2076953?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaskikutis","html_url":"https://github.com/tomaskikutis","followers_url":"https://api.github.com/users/tomaskikutis/followers","following_url":"https://api.github.com/users/tomaskikutis/following{/other_user}","gists_url":"https://api.github.com/users/tomaskikutis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaskikutis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaskikutis/subscriptions","organizations_url":"https://api.github.com/users/tomaskikutis/orgs","repos_url":"https://api.github.com/users/tomaskikutis/repos","events_url":"https://api.github.com/users/tomaskikutis/events{/privacy}","received_events_url":"https://api.github.com/users/tomaskikutis/received_events","type":"User","site_admin":false},"repo":{"id":118113228,"name":"superdesk-client-core","full_name":"tomaskikutis/superdesk-client-core","owner":{"login":"tomaskikutis","id":2076953,"avatar_url":"https://avatars0.githubusercontent.com/u/2076953?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaskikutis","html_url":"https://github.com/tomaskikutis","followers_url":"https://api.github.com/users/tomaskikutis/followers","following_url":"https://api.github.com/users/tomaskikutis/following{/other_user}","gists_url":"https://api.github.com/users/tomaskikutis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaskikutis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaskikutis/subscriptions","organizations_url":"https://api.github.com/users/tomaskikutis/orgs","repos_url":"https://api.github.com/users/tomaskikutis/repos","events_url":"https://api.github.com/users/tomaskikutis/events{/privacy}","received_events_url":"https://api.github.com/users/tomaskikutis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomaskikutis/superdesk-client-core","description":"Common client modules for superdesk apps.","fork":true,"url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core","forks_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/forks","keys_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/teams","hooks_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/hooks","issue_events_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/events","assignees_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/tags","blobs_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/languages","stargazers_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/stargazers","contributors_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/contributors","subscribers_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/subscribers","subscription_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/subscription","commits_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/merges","archive_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/downloads","issues_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/labels{/name}","releases_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/tomaskikutis/superdesk-client-core/deployments","created_at":"2018-01-19T10:43:33Z","updated_at":"2018-03-14T06:01:36Z","pushed_at":"2018-03-14T10:59:27Z","git_url":"git://github.com/tomaskikutis/superdesk-client-core.git","ssh_url":"git@github.com:tomaskikutis/superdesk-client-core.git","clone_url":"https://github.com/tomaskikutis/superdesk-client-core.git","svn_url":"https://github.com/tomaskikutis/superdesk-client-core","homepage":"","size":13397,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superdesk:master","ref":"master","sha":"3a7365c806582a2d224a1352d5861bc5e202a14d","user":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars2.githubusercontent.com/u/5527298?v=4","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"repo":{"id":50631400,"name":"superdesk-client-core","full_name":"superdesk/superdesk-client-core","owner":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars2.githubusercontent.com/u/5527298?v=4","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superdesk/superdesk-client-core","description":"Common client modules for superdesk apps.","fork":false,"url":"https://api.github.com/repos/superdesk/superdesk-client-core","forks_url":"https://api.github.com/repos/superdesk/superdesk-client-core/forks","keys_url":"https://api.github.com/repos/superdesk/superdesk-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdesk/superdesk-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdesk/superdesk-client-core/teams","hooks_url":"https://api.github.com/repos/superdesk/superdesk-client-core/hooks","issue_events_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/superdesk/superdesk-client-core/events","assignees_url":"https://api.github.com/repos/superdesk/superdesk-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/superdesk/superdesk-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/superdesk/superdesk-client-core/tags","blobs_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/superdesk/superdesk-client-core/languages","stargazers_url":"https://api.github.com/repos/superdesk/superdesk-client-core/stargazers","contributors_url":"https://api.github.com/repos/superdesk/superdesk-client-core/contributors","subscribers_url":"https://api.github.com/repos/superdesk/superdesk-client-core/subscribers","subscription_url":"https://api.github.com/repos/superdesk/superdesk-client-core/subscription","commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdesk/superdesk-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/superdesk/superdesk-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdesk/superdesk-client-core/merges","archive_url":"https://api.github.com/repos/superdesk/superdesk-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdesk/superdesk-client-core/downloads","issues_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/superdesk/superdesk-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdesk/superdesk-client-core/labels{/name}","releases_url":"https://api.github.com/repos/superdesk/superdesk-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/deployments","created_at":"2016-01-29T02:33:16Z","updated_at":"2018-03-15T09:23:14Z","pushed_at":"2018-03-15T13:53:08Z","git_url":"git://github.com/superdesk/superdesk-client-core.git","ssh_url":"git@github.com:superdesk/superdesk-client-core.git","clone_url":"https://github.com/superdesk/superdesk-client-core.git","svn_url":"https://github.com/superdesk/superdesk-client-core","homepage":"","size":13175,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":50,"open_issues":7,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149"},"html":{"href":"https://github.com/superdesk/superdesk-client-core/pull/2149"},"issue":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2149"},"comments":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2149/comments"},"review_comments":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149/comments"},"review_comment":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2149/commits"},"statuses":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/4a0896fb40a797a1b48d59f6a5fe12e3d9e4de7f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tomaskikutis"}}