{"action":"created","issue":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/4469","repository_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore","labels_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/4469/labels{/name}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/4469/comments","events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/4469/events","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/4469","id":321690021,"number":4469,"title":"Bugfix 4027/catch invalid langs","user":{"login":"PhotoNomad0","id":14238574,"avatar_url":"https://avatars3.githubusercontent.com/u/14238574?v=4","gravatar_id":"","url":"https://api.github.com/users/PhotoNomad0","html_url":"https://github.com/PhotoNomad0","followers_url":"https://api.github.com/users/PhotoNomad0/followers","following_url":"https://api.github.com/users/PhotoNomad0/following{/other_user}","gists_url":"https://api.github.com/users/PhotoNomad0/gists{/gist_id}","starred_url":"https://api.github.com/users/PhotoNomad0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhotoNomad0/subscriptions","organizations_url":"https://api.github.com/users/PhotoNomad0/orgs","repos_url":"https://api.github.com/users/PhotoNomad0/repos","events_url":"https://api.github.com/users/PhotoNomad0/events{/privacy}","received_events_url":"https://api.github.com/users/PhotoNomad0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"PhotoNomad0","id":14238574,"avatar_url":"https://avatars3.githubusercontent.com/u/14238574?v=4","gravatar_id":"","url":"https://api.github.com/users/PhotoNomad0","html_url":"https://github.com/PhotoNomad0","followers_url":"https://api.github.com/users/PhotoNomad0/followers","following_url":"https://api.github.com/users/PhotoNomad0/following{/other_user}","gists_url":"https://api.github.com/users/PhotoNomad0/gists{/gist_id}","starred_url":"https://api.github.com/users/PhotoNomad0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhotoNomad0/subscriptions","organizations_url":"https://api.github.com/users/PhotoNomad0/orgs","repos_url":"https://api.github.com/users/PhotoNomad0/repos","events_url":"https://api.github.com/users/PhotoNomad0/events{/privacy}","received_events_url":"https://api.github.com/users/PhotoNomad0/received_events","type":"User","site_admin":false},"assignees":[{"login":"PhotoNomad0","id":14238574,"avatar_url":"https://avatars3.githubusercontent.com/u/14238574?v=4","gravatar_id":"","url":"https://api.github.com/users/PhotoNomad0","html_url":"https://github.com/PhotoNomad0","followers_url":"https://api.github.com/users/PhotoNomad0/followers","following_url":"https://api.github.com/users/PhotoNomad0/following{/other_user}","gists_url":"https://api.github.com/users/PhotoNomad0/gists{/gist_id}","starred_url":"https://api.github.com/users/PhotoNomad0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhotoNomad0/subscriptions","organizations_url":"https://api.github.com/users/PhotoNomad0/orgs","repos_url":"https://api.github.com/users/PhotoNomad0/repos","events_url":"https://api.github.com/users/PhotoNomad0/events{/privacy}","received_events_url":"https://api.github.com/users/PhotoNomad0/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-09T19:07:41Z","updated_at":"2018-05-16T18:43:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/4469","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/4469","diff_url":"https://github.com/unfoldingWord-dev/translationCore/pull/4469.diff","patch_url":"https://github.com/unfoldingWord-dev/translationCore/pull/4469.patch"},"body":"#### Describe what your pull request addresses (Please include relevant issue numbers):\r\n- Adds validation that language code is a valid code.  This should catch cases where language code and name are reversed in manifest.\r\n\r\n#### Please include detailed Test instructions for your pull request:\r\n- run the app and import from door43: https://git.door43.org/tc01/am_1co_text_ulb\r\n- should get Project details prompt showing language code and name being invalid.  Set language code to `am` and continue.  Project card should show project name as `am_1co_ulb` and have `(am)` as language code.\r\n- Now try to import from Door43: https://git.door43.org/tc02/am_1co_ulb\r\n- Should get prompt that reimporting existing projects is not supported.\r\n\r\n#### Standard Test Instructions for PR Review Process:\r\n\r\n- [ ] Double check unit tests that have been written\r\n- [ ] Check for documentation for code changes\r\n- [ ] Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR\r\n- [ ] Checkout the branch locally and ensure that app runs as expected\r\n  - [ ] Ensure tests pass\r\n  - [ ] Open and watch the console for errors\r\n  - [ ] Make sure all actions perform as expected\r\n  - [ ] Import and Load a new Project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Switch project to an existing project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Next time reverse the order of importing after loading an existing project\r\n- [ ] Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story\r\n- [ ] Ask Ben or Koz if you have any concerns about implementation (especially UI related)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/unfoldingword-dev/translationcore/4469)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/comments/389624314","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/4469#issuecomment-389624314","issue_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/4469","id":389624314,"user":{"login":"mannycolon","id":17072300,"avatar_url":"https://avatars1.githubusercontent.com/u/17072300?v=4","gravatar_id":"","url":"https://api.github.com/users/mannycolon","html_url":"https://github.com/mannycolon","followers_url":"https://api.github.com/users/mannycolon/followers","following_url":"https://api.github.com/users/mannycolon/following{/other_user}","gists_url":"https://api.github.com/users/mannycolon/gists{/gist_id}","starred_url":"https://api.github.com/users/mannycolon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mannycolon/subscriptions","organizations_url":"https://api.github.com/users/mannycolon/orgs","repos_url":"https://api.github.com/users/mannycolon/repos","events_url":"https://api.github.com/users/mannycolon/events{/privacy}","received_events_url":"https://api.github.com/users/mannycolon/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T18:43:06Z","updated_at":"2018-05-16T18:43:06Z","author_association":"COLLABORATOR","body":"\n\n\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/unfoldingword-dev/translationcore/4469)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mannycolon"}}