{"action":"opened","issue":{"url":"https://api.github.com/repos/OHDSI/WebAPI/issues/317","repository_url":"https://api.github.com/repos/OHDSI/WebAPI","labels_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/317/labels{/name}","comments_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/317/comments","events_url":"https://api.github.com/repos/OHDSI/WebAPI/issues/317/events","html_url":"https://github.com/OHDSI/WebAPI/issues/317","id":296596481,"number":317,"title":"Heracles Analysis id 108","user":{"login":"gowthamrao","id":13936600,"avatar_url":"https://avatars0.githubusercontent.com/u/13936600?v=4","gravatar_id":"","url":"https://api.github.com/users/gowthamrao","html_url":"https://github.com/gowthamrao","followers_url":"https://api.github.com/users/gowthamrao/followers","following_url":"https://api.github.com/users/gowthamrao/following{/other_user}","gists_url":"https://api.github.com/users/gowthamrao/gists{/gist_id}","starred_url":"https://api.github.com/users/gowthamrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gowthamrao/subscriptions","organizations_url":"https://api.github.com/users/gowthamrao/orgs","repos_url":"https://api.github.com/users/gowthamrao/repos","events_url":"https://api.github.com/users/gowthamrao/events{/privacy}","received_events_url":"https://api.github.com/users/gowthamrao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-13T02:49:05Z","updated_at":"2018-02-13T02:49:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://github.com/OHDSI/WebAPI/blob/c92863dbdd5cec90c5e17c29368b91f9b703c6b9/src/main/resources/resources/cohortanalysis/sql/runHeraclesAnalyses.sql#L611\r\n\r\n>   -- 108   Number of persons by length of observation period, in 30d increments\r\n\r\nShould it be\r\n>  -- 108   Number of persons by length of **first** observation period, in 30d increments\r\n\r\nIn both cases, is the 108 SQL correct? \r\n\r\nhttps://github.com/OHDSI/WebAPI/blob/c92863dbdd5cec90c5e17c29368b91f9b703c6b9/src/main/resources/resources/cohortanalysis/sql/runHeraclesAnalyses.sql#L620\r\n\r\nMaybe this is more accurate\r\n\r\n`inner join (select distinct subject_id, cohort_definition_id from #HERACLES_cohort) c1 `\r\n\r\n"}}
{"actor":{"display_login":"gowthamrao"}}