{"action":"created","issue":{"url":"https://api.github.com/repos/minad/moneta/issues/136","repository_url":"https://api.github.com/repos/minad/moneta","labels_url":"https://api.github.com/repos/minad/moneta/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/minad/moneta/issues/136/comments","events_url":"https://api.github.com/repos/minad/moneta/issues/136/events","html_url":"https://github.com/minad/moneta/pull/136","id":306302337,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1NzgzOTg5","number":136,"title":"Add each_key support to adapters","user":{"login":"brutuscat","id":301959,"node_id":"MDQ6VXNlcjMwMTk1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/301959?v=4","gravatar_id":"","url":"https://api.github.com/users/brutuscat","html_url":"https://github.com/brutuscat","followers_url":"https://api.github.com/users/brutuscat/followers","following_url":"https://api.github.com/users/brutuscat/following{/other_user}","gists_url":"https://api.github.com/users/brutuscat/gists{/gist_id}","starred_url":"https://api.github.com/users/brutuscat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutuscat/subscriptions","organizations_url":"https://api.github.com/users/brutuscat/orgs","repos_url":"https://api.github.com/users/brutuscat/repos","events_url":"https://api.github.com/users/brutuscat/events{/privacy}","received_events_url":"https://api.github.com/users/brutuscat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-19T00:42:30Z","updated_at":"2018-06-20T23:19:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/minad/moneta/pulls/136","html_url":"https://github.com/minad/moneta/pull/136","diff_url":"https://github.com/minad/moneta/pull/136.diff","patch_url":"https://github.com/minad/moneta/pull/136.patch"},"body":"Adding support for the following adapters:\r\n\r\n* LRUHash\r\n* ActiveRecord\r\n* Redis\r\n* File\r\n* PStore & YAML\r\n\r\nStill a WIP. \r\n\r\nI will try to add support for each_key for those adapters where it seems obvious and for those that I might need in the brutuscat/medusa#3 gem (fork of Anemone)"},"comment":{"url":"https://api.github.com/repos/minad/moneta/issues/comments/398927350","html_url":"https://github.com/minad/moneta/pull/136#issuecomment-398927350","issue_url":"https://api.github.com/repos/minad/moneta/issues/136","id":398927350,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODkyNzM1MA==","user":{"login":"brutuscat","id":301959,"node_id":"MDQ6VXNlcjMwMTk1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/301959?v=4","gravatar_id":"","url":"https://api.github.com/users/brutuscat","html_url":"https://github.com/brutuscat","followers_url":"https://api.github.com/users/brutuscat/followers","following_url":"https://api.github.com/users/brutuscat/following{/other_user}","gists_url":"https://api.github.com/users/brutuscat/gists{/gist_id}","starred_url":"https://api.github.com/users/brutuscat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutuscat/subscriptions","organizations_url":"https://api.github.com/users/brutuscat/orgs","repos_url":"https://api.github.com/users/brutuscat/repos","events_url":"https://api.github.com/users/brutuscat/events{/privacy}","received_events_url":"https://api.github.com/users/brutuscat/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T23:19:11Z","updated_at":"2018-06-20T23:19:11Z","author_association":"NONE","body":"@asppsa I finally ([almost](https://travis-ci.org/minad/moneta/builds/394693929?utm_source=github_status&utm_medium=notification)) fixed the specs and I implemented each_keyin both Mongo adapters.\r\n\r\nI have 2 set of problems now that I think you can help me :)\r\n\r\n- Some specs are failing and I have no clue why. See https://travis-ci.org/minad/moneta/jobs/394693960. (uninitialized constant Moneta::Expires::Utils)\r\n- For mongo (and I think other adapters too), when I instrument the with_each_key specs for the STANDARD_SPECS collection, is as if the Proxy is not picking up the [addition of :each_key in the `supports` collection](https://github.com/minad/moneta/pull/136/commits/8d0a820d6fef2113dc53100019dfc97644da32ba#diff-50b20ca84f972b8d4010e27a9124a49eR10). Therefore I get NotImplementedError: each_key is not supported on this proxy."}}
{"actor":{"display_login":"brutuscat"}}