{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/7362","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/7362/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/7362/comments","events_url":"https://api.github.com/repos/helm/charts/issues/7362/events","html_url":"https://github.com/helm/charts/pull/7362","id":354221922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDM2MzMx","number":7362,"title":"[stable/kong] Kong migration hook","user":{"login":"akhy","id":446781,"node_id":"MDQ6VXNlcjQ0Njc4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/446781?v=4","gravatar_id":"","url":"https://api.github.com/users/akhy","html_url":"https://github.com/akhy","followers_url":"https://api.github.com/users/akhy/followers","following_url":"https://api.github.com/users/akhy/following{/other_user}","gists_url":"https://api.github.com/users/akhy/gists{/gist_id}","starred_url":"https://api.github.com/users/akhy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhy/subscriptions","organizations_url":"https://api.github.com/users/akhy/orgs","repos_url":"https://api.github.com/users/akhy/repos","events_url":"https://api.github.com/users/akhy/events{/privacy}","received_events_url":"https://api.github.com/users/akhy/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676475149,"node_id":"MDU6TGFiZWw2NzY0NzUxNDk=","url":"https://api.github.com/repos/helm/charts/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"scottrigby","id":407675,"node_id":"MDQ6VXNlcjQwNzY3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/407675?v=4","gravatar_id":"","url":"https://api.github.com/users/scottrigby","html_url":"https://github.com/scottrigby","followers_url":"https://api.github.com/users/scottrigby/followers","following_url":"https://api.github.com/users/scottrigby/following{/other_user}","gists_url":"https://api.github.com/users/scottrigby/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrigby/subscriptions","organizations_url":"https://api.github.com/users/scottrigby/orgs","repos_url":"https://api.github.com/users/scottrigby/repos","events_url":"https://api.github.com/users/scottrigby/events{/privacy}","received_events_url":"https://api.github.com/users/scottrigby/received_events","type":"User","site_admin":false},"assignees":[{"login":"scottrigby","id":407675,"node_id":"MDQ6VXNlcjQwNzY3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/407675?v=4","gravatar_id":"","url":"https://api.github.com/users/scottrigby","html_url":"https://github.com/scottrigby","followers_url":"https://api.github.com/users/scottrigby/followers","following_url":"https://api.github.com/users/scottrigby/following{/other_user}","gists_url":"https://api.github.com/users/scottrigby/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrigby/subscriptions","organizations_url":"https://api.github.com/users/scottrigby/orgs","repos_url":"https://api.github.com/users/scottrigby/repos","events_url":"https://api.github.com/users/scottrigby/events{/privacy}","received_events_url":"https://api.github.com/users/scottrigby/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2018-08-27T08:09:57Z","updated_at":"2018-10-26T17:21:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/7362","html_url":"https://github.com/helm/charts/pull/7362","diff_url":"https://github.com/helm/charts/pull/7362.diff","patch_url":"https://github.com/helm/charts/pull/7362.patch"},"body":"<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR implements kong migration as [helm hook](https://docs.helm.sh/developing_charts/#hooks). \r\n\r\nCurrent `stable/kong` chart run migration as regular Kubernetes Job, that makes release upgrades failed because the Job spec is immutable. By using `before-hook-creation` hook delete policy, the old Job is guaranteed to be deleted and re-run for every release upgrades.\r\n\r\n**Special notes for your reviewer**:\r\n\r\nI'm not sure if `pre-install,pre-upgrade` is redundant or not. "},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/433481680","html_url":"https://github.com/helm/charts/pull/7362#issuecomment-433481680","issue_url":"https://api.github.com/repos/helm/charts/issues/7362","id":433481680,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQ4MTY4MA==","user":{"login":"hbagdi","id":4694585,"node_id":"MDQ6VXNlcjQ2OTQ1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/4694585?v=4","gravatar_id":"","url":"https://api.github.com/users/hbagdi","html_url":"https://github.com/hbagdi","followers_url":"https://api.github.com/users/hbagdi/followers","following_url":"https://api.github.com/users/hbagdi/following{/other_user}","gists_url":"https://api.github.com/users/hbagdi/gists{/gist_id}","starred_url":"https://api.github.com/users/hbagdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbagdi/subscriptions","organizations_url":"https://api.github.com/users/hbagdi/orgs","repos_url":"https://api.github.com/users/hbagdi/repos","events_url":"https://api.github.com/users/hbagdi/events{/privacy}","received_events_url":"https://api.github.com/users/hbagdi/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T17:21:18Z","updated_at":"2018-10-26T17:21:18Z","author_association":"COLLABORATOR","body":"Let's bump the chart version once more and test. There are not more outstanding PRs on Kong (Ingress controller will bump to 0.6.0), so this should be the last bump hopefully.\r\nThe tests should pass then and if not, then we will look into it. @akhy Ping me once you update. Thanks for your contribution!"}}
{"actor":{"display_login":"hbagdi"}}