{"action":"closed","number":144,"pull_request":{"url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/144","id":11059605,"node_id":"MDExOlB1bGxSZXF1ZXN0MTEwNTk2MDU=","html_url":"https://github.com/bitwiseshiftleft/sjcl/pull/144","diff_url":"https://github.com/bitwiseshiftleft/sjcl/pull/144.diff","patch_url":"https://github.com/bitwiseshiftleft/sjcl/pull/144.patch","issue_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/144","number":144,"state":"closed","locked":false,"title":"(X)Salsa20/r + ChaCha20 (+ChaCha8 + ChaCha12)","user":{"login":"stbuehler","id":528446,"node_id":"MDQ6VXNlcjUyODQ0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/528446?v=4","gravatar_id":"","url":"https://api.github.com/users/stbuehler","html_url":"https://github.com/stbuehler","followers_url":"https://api.github.com/users/stbuehler/followers","following_url":"https://api.github.com/users/stbuehler/following{/other_user}","gists_url":"https://api.github.com/users/stbuehler/gists{/gist_id}","starred_url":"https://api.github.com/users/stbuehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbuehler/subscriptions","organizations_url":"https://api.github.com/users/stbuehler/orgs","repos_url":"https://api.github.com/users/stbuehler/repos","events_url":"https://api.github.com/users/stbuehler/events{/privacy}","received_events_url":"https://api.github.com/users/stbuehler/received_events","type":"User","site_admin":false},"body":"Hi,\n\nI'd like to request adding some stream ciphers from the Salsa and ChaCha families; motivation for Salsa20 is already discussed in #141. ChaCha is very similar (read \"easy to maintain together with Salsa20\"), possibly faster in low-level implementations, hopefully more secure, and there is a recent draft to use it in TLS (see https://tools.ietf.org/id/draft-agl-tls-chacha20poly1305-04.html).\n\nBoth stream ciphers have a lot of KAT vectors generated with code from \"ECRYPT Stream Cipher Project\" (framework + Salsa20 implementation) + ChaCha8 reference implementation from http://cr.yp.to/chacha.html (which was not included in http://www.ecrypt.eu.org/stream/svn/viewcvs.cgi/ecrypt/trunk/, but uses the framework), modified to generate output for 12 and 20 rounds too; I modified the ecrypt source a little bit to output JavaScript readable data.\nThe test vectors for ChaCha20 also include the ones from the TLS draft, for XSalsa20 vectors from `cryptopp` are included.\n\nSalsa20 adds 2100 bytes, ChaCha20 1827 bytes (compressed with closure).\n","created_at":"2013-12-23T19:33:18Z","updated_at":"2018-12-03T14:30:28Z","closed_at":"2018-12-03T14:30:28Z","merged_at":null,"merge_commit_sha":"74b531241d1913941908d6d6e9c2b6ccb3a530a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/144/commits","review_comments_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/144/comments","review_comment_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/144/comments","statuses_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/statuses/718dcb3a140ff73eabdd16d187d1fdb804e024df","head":{"label":"stbuehler:feature-chacha20","ref":"feature-chacha20","sha":"718dcb3a140ff73eabdd16d187d1fdb804e024df","user":{"login":"stbuehler","id":528446,"node_id":"MDQ6VXNlcjUyODQ0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/528446?v=4","gravatar_id":"","url":"https://api.github.com/users/stbuehler","html_url":"https://github.com/stbuehler","followers_url":"https://api.github.com/users/stbuehler/followers","following_url":"https://api.github.com/users/stbuehler/following{/other_user}","gists_url":"https://api.github.com/users/stbuehler/gists{/gist_id}","starred_url":"https://api.github.com/users/stbuehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbuehler/subscriptions","organizations_url":"https://api.github.com/users/stbuehler/orgs","repos_url":"https://api.github.com/users/stbuehler/repos","events_url":"https://api.github.com/users/stbuehler/events{/privacy}","received_events_url":"https://api.github.com/users/stbuehler/received_events","type":"User","site_admin":false},"repo":{"id":14244855,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NDg1NQ==","name":"sjcl","full_name":"stbuehler/sjcl","private":false,"owner":{"login":"stbuehler","id":528446,"node_id":"MDQ6VXNlcjUyODQ0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/528446?v=4","gravatar_id":"","url":"https://api.github.com/users/stbuehler","html_url":"https://github.com/stbuehler","followers_url":"https://api.github.com/users/stbuehler/followers","following_url":"https://api.github.com/users/stbuehler/following{/other_user}","gists_url":"https://api.github.com/users/stbuehler/gists{/gist_id}","starred_url":"https://api.github.com/users/stbuehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbuehler/subscriptions","organizations_url":"https://api.github.com/users/stbuehler/orgs","repos_url":"https://api.github.com/users/stbuehler/repos","events_url":"https://api.github.com/users/stbuehler/events{/privacy}","received_events_url":"https://api.github.com/users/stbuehler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stbuehler/sjcl","description":"Stanford Javascript Crypto Library","fork":true,"url":"https://api.github.com/repos/stbuehler/sjcl","forks_url":"https://api.github.com/repos/stbuehler/sjcl/forks","keys_url":"https://api.github.com/repos/stbuehler/sjcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stbuehler/sjcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stbuehler/sjcl/teams","hooks_url":"https://api.github.com/repos/stbuehler/sjcl/hooks","issue_events_url":"https://api.github.com/repos/stbuehler/sjcl/issues/events{/number}","events_url":"https://api.github.com/repos/stbuehler/sjcl/events","assignees_url":"https://api.github.com/repos/stbuehler/sjcl/assignees{/user}","branches_url":"https://api.github.com/repos/stbuehler/sjcl/branches{/branch}","tags_url":"https://api.github.com/repos/stbuehler/sjcl/tags","blobs_url":"https://api.github.com/repos/stbuehler/sjcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stbuehler/sjcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stbuehler/sjcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/stbuehler/sjcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stbuehler/sjcl/statuses/{sha}","languages_url":"https://api.github.com/repos/stbuehler/sjcl/languages","stargazers_url":"https://api.github.com/repos/stbuehler/sjcl/stargazers","contributors_url":"https://api.github.com/repos/stbuehler/sjcl/contributors","subscribers_url":"https://api.github.com/repos/stbuehler/sjcl/subscribers","subscription_url":"https://api.github.com/repos/stbuehler/sjcl/subscription","commits_url":"https://api.github.com/repos/stbuehler/sjcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/stbuehler/sjcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/stbuehler/sjcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/stbuehler/sjcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/stbuehler/sjcl/contents/{+path}","compare_url":"https://api.github.com/repos/stbuehler/sjcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stbuehler/sjcl/merges","archive_url":"https://api.github.com/repos/stbuehler/sjcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stbuehler/sjcl/downloads","issues_url":"https://api.github.com/repos/stbuehler/sjcl/issues{/number}","pulls_url":"https://api.github.com/repos/stbuehler/sjcl/pulls{/number}","milestones_url":"https://api.github.com/repos/stbuehler/sjcl/milestones{/number}","notifications_url":"https://api.github.com/repos/stbuehler/sjcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stbuehler/sjcl/labels{/name}","releases_url":"https://api.github.com/repos/stbuehler/sjcl/releases{/id}","deployments_url":"https://api.github.com/repos/stbuehler/sjcl/deployments","created_at":"2013-11-08T21:31:12Z","updated_at":"2017-09-22T03:39:39Z","pushed_at":"2014-08-21T17:44:16Z","git_url":"git://github.com/stbuehler/sjcl.git","ssh_url":"git@github.com:stbuehler/sjcl.git","clone_url":"https://github.com/stbuehler/sjcl.git","svn_url":"https://github.com/stbuehler/sjcl","homepage":"http://bitwiseshiftleft.github.com/sjcl/","size":19605,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"bitwiseshiftleft:master","ref":"master","sha":"c9d263aef3f65b9ca55763a28d9ad9cf9adcd37a","user":{"login":"bitwiseshiftleft","id":288092,"node_id":"MDQ6VXNlcjI4ODA5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/288092?v=4","gravatar_id":"","url":"https://api.github.com/users/bitwiseshiftleft","html_url":"https://github.com/bitwiseshiftleft","followers_url":"https://api.github.com/users/bitwiseshiftleft/followers","following_url":"https://api.github.com/users/bitwiseshiftleft/following{/other_user}","gists_url":"https://api.github.com/users/bitwiseshiftleft/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwiseshiftleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwiseshiftleft/subscriptions","organizations_url":"https://api.github.com/users/bitwiseshiftleft/orgs","repos_url":"https://api.github.com/users/bitwiseshiftleft/repos","events_url":"https://api.github.com/users/bitwiseshiftleft/events{/privacy}","received_events_url":"https://api.github.com/users/bitwiseshiftleft/received_events","type":"User","site_admin":false},"repo":{"id":688208,"node_id":"MDEwOlJlcG9zaXRvcnk2ODgyMDg=","name":"sjcl","full_name":"bitwiseshiftleft/sjcl","private":false,"owner":{"login":"bitwiseshiftleft","id":288092,"node_id":"MDQ6VXNlcjI4ODA5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/288092?v=4","gravatar_id":"","url":"https://api.github.com/users/bitwiseshiftleft","html_url":"https://github.com/bitwiseshiftleft","followers_url":"https://api.github.com/users/bitwiseshiftleft/followers","following_url":"https://api.github.com/users/bitwiseshiftleft/following{/other_user}","gists_url":"https://api.github.com/users/bitwiseshiftleft/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwiseshiftleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwiseshiftleft/subscriptions","organizations_url":"https://api.github.com/users/bitwiseshiftleft/orgs","repos_url":"https://api.github.com/users/bitwiseshiftleft/repos","events_url":"https://api.github.com/users/bitwiseshiftleft/events{/privacy}","received_events_url":"https://api.github.com/users/bitwiseshiftleft/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bitwiseshiftleft/sjcl","description":"Stanford Javascript Crypto Library","fork":false,"url":"https://api.github.com/repos/bitwiseshiftleft/sjcl","forks_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/forks","keys_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/teams","hooks_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/hooks","issue_events_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/events{/number}","events_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/events","assignees_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/assignees{/user}","branches_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/branches{/branch}","tags_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/tags","blobs_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/statuses/{sha}","languages_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/languages","stargazers_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/stargazers","contributors_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/contributors","subscribers_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/subscribers","subscription_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/subscription","commits_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/contents/{+path}","compare_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/merges","archive_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/downloads","issues_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues{/number}","pulls_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls{/number}","milestones_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/milestones{/number}","notifications_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/labels{/name}","releases_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/releases{/id}","deployments_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/deployments","created_at":"2010-05-26T22:12:06Z","updated_at":"2018-12-03T09:59:36Z","pushed_at":"2018-11-10T14:55:13Z","git_url":"git://github.com/bitwiseshiftleft/sjcl.git","ssh_url":"git@github.com:bitwiseshiftleft/sjcl.git","clone_url":"https://github.com/bitwiseshiftleft/sjcl.git","svn_url":"https://github.com/bitwiseshiftleft/sjcl","homepage":"http://bitwiseshiftleft.github.com/sjcl/","size":44911,"stargazers_count":5246,"watchers_count":5246,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":697,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":697,"open_issues":74,"watchers":5246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/144"},"html":{"href":"https://github.com/bitwiseshiftleft/sjcl/pull/144"},"issue":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/144"},"comments":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/statuses/718dcb3a140ff73eabdd16d187d1fdb804e024df"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":9,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":3375,"deletions":1,"changed_files":9}}
{"actor":{"display_login":"Nilos"}}