{"action":"created","issue":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11196","repository_url":"https://api.github.com/repos/PrestaShop/PrestaShop","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11196/labels{/name}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11196/comments","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11196/events","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11196","id":375565745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTgxNTU3","number":11196,"title":"An employee can't set for himself or other a permission he does not have","user":{"login":"mickaelandrieu","id":1247388,"node_id":"MDQ6VXNlcjEyNDczODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1247388?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"labels":[{"id":19737369,"node_id":"MDU6TGFiZWwxOTczNzM2OQ==","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Bug","name":"Bug","color":"d4c5f9","default":false},{"id":358658003,"node_id":"MDU6TGFiZWwzNTg2NTgwMDM=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/PM%20%E2%9C%94%EF%B8%8F","name":"PM ✔️","color":"b8ed50","default":false},{"id":1126077824,"node_id":"MDU6TGFiZWwxMTI2MDc3ODI0","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Wording%20%E2%9C%94%EF%B8%8F","name":"Wording ✔️","color":"b8ed50","default":false},{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"6270ea","default":false}],"state":"open","locked":false,"assignee":{"login":"marionf","id":13449658,"node_id":"MDQ6VXNlcjEzNDQ5NjU4","avatar_url":"https://avatars3.githubusercontent.com/u/13449658?v=4","gravatar_id":"","url":"https://api.github.com/users/marionf","html_url":"https://github.com/marionf","followers_url":"https://api.github.com/users/marionf/followers","following_url":"https://api.github.com/users/marionf/following{/other_user}","gists_url":"https://api.github.com/users/marionf/gists{/gist_id}","starred_url":"https://api.github.com/users/marionf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionf/subscriptions","organizations_url":"https://api.github.com/users/marionf/orgs","repos_url":"https://api.github.com/users/marionf/repos","events_url":"https://api.github.com/users/marionf/events{/privacy}","received_events_url":"https://api.github.com/users/marionf/received_events","type":"User","site_admin":false},"assignees":[{"login":"marionf","id":13449658,"node_id":"MDQ6VXNlcjEzNDQ5NjU4","avatar_url":"https://avatars3.githubusercontent.com/u/13449658?v=4","gravatar_id":"","url":"https://api.github.com/users/marionf","html_url":"https://github.com/marionf","followers_url":"https://api.github.com/users/marionf/followers","following_url":"https://api.github.com/users/marionf/following{/other_user}","gists_url":"https://api.github.com/users/marionf/gists{/gist_id}","starred_url":"https://api.github.com/users/marionf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionf/subscriptions","organizations_url":"https://api.github.com/users/marionf/orgs","repos_url":"https://api.github.com/users/marionf/repos","events_url":"https://api.github.com/users/marionf/events{/privacy}","received_events_url":"https://api.github.com/users/marionf/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-10-30T15:58:19Z","updated_at":"2019-01-02T15:39:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11196","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11196","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/11196.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/11196.patch"},"body":"<!--\r\nThank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\n\r\nCheck out our contribution guidelines to find out how to complete it:\r\nhttps://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests\r\n -->\r\n\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | As an employee, I'm able to change my own permissions and others permissions even if I don't have these permissions formerly. This defeat the principle of permissions management :/\r\n| Type?         | bug fix\r\n| Category?     | BO\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed ticket? | Fixes https://github.com/PrestaShop/PrestaShop/issues/10216\r\n| How to test?  | Play with permissions in Advanced Parameters > Team > Permissions.\r\n\r\n<!-- Click the form's \"Preview\" button to make sure the table is functional in GitHub. Thank you! -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/11196)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments/450896061","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11196#issuecomment-450896061","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11196","id":450896061,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDg5NjA2MQ==","user":{"login":"mickaelandrieu","id":1247388,"node_id":"MDQ6VXNlcjEyNDczODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1247388?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T15:39:01Z","updated_at":"2019-01-02T15:39:01Z","author_association":"CONTRIBUTOR","body":"Thanks @matks, so I don't think it's worth to spend time to fix the bug (the error message in legacy, while correctly set up, is never displayed).\r\n\r\nCan you link this pull request to the issue of migration so the developer can use the \"right\" error message in the new page? 👼 \r\n\r\nThanks mate!"}}
{"actor":{"display_login":"mickaelandrieu"}}