{"action":"created","comment":{"url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/comments/238112259","pull_request_review_id":180575356,"id":238112259,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODExMjI1OQ==","diff_hunk":"@@ -5,11 +5,14 @@ struct node *create_node()\n \twlr_log(WLR_DEBUG, \"Creating node\");\n \tstruct node *node = malloc(sizeof(struct node));\n \n-\tnode->window = NULL;\n+\tif (node != NULL)\n+\t{","path":"bspwc/tree.c","position":6,"original_position":6,"commit_id":"de70d52a3155802e251ba336eb856cc5a9ddc983","original_commit_id":"de70d52a3155802e251ba336eb856cc5a9ddc983","user":{"login":"kenogo","id":24212659,"node_id":"MDQ6VXNlcjI0MjEyNjU5","avatar_url":"https://avatars2.githubusercontent.com/u/24212659?v=4","gravatar_id":"","url":"https://api.github.com/users/kenogo","html_url":"https://github.com/kenogo","followers_url":"https://api.github.com/users/kenogo/followers","following_url":"https://api.github.com/users/kenogo/following{/other_user}","gists_url":"https://api.github.com/users/kenogo/gists{/gist_id}","starred_url":"https://api.github.com/users/kenogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenogo/subscriptions","organizations_url":"https://api.github.com/users/kenogo/orgs","repos_url":"https://api.github.com/users/kenogo/repos","events_url":"https://api.github.com/users/kenogo/events{/privacy}","received_events_url":"https://api.github.com/users/kenogo/received_events","type":"User","site_admin":false},"body":"Does that mean I should remove the check in `tree.c:71` and put it into this function? What should the function return in that case and how should it be handled? I decided to put the check outside of the function so that this inception could be cought, with the result of `insert_node` returning `false`. This would provide an additional helpful error message.","created_at":"2018-12-02T20:02:09Z","updated_at":"2018-12-02T20:02:24Z","html_url":"https://github.com/Bl4ckb0ne/bspwc/pull/38#discussion_r238112259","pull_request_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/comments/238112259"},"html":{"href":"https://github.com/Bl4ckb0ne/bspwc/pull/38#discussion_r238112259"},"pull_request":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38"}},"in_reply_to_id":238109725},"pull_request":{"url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38","id":235252241,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjUyMjQx","html_url":"https://github.com/Bl4ckb0ne/bspwc/pull/38","diff_url":"https://github.com/Bl4ckb0ne/bspwc/pull/38.diff","patch_url":"https://github.com/Bl4ckb0ne/bspwc/pull/38.patch","issue_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/issues/38","number":38,"state":"open","locked":false,"title":"Add missing malloc checks","user":{"login":"kenogo","id":24212659,"node_id":"MDQ6VXNlcjI0MjEyNjU5","avatar_url":"https://avatars2.githubusercontent.com/u/24212659?v=4","gravatar_id":"","url":"https://api.github.com/users/kenogo","html_url":"https://github.com/kenogo","followers_url":"https://api.github.com/users/kenogo/followers","following_url":"https://api.github.com/users/kenogo/following{/other_user}","gists_url":"https://api.github.com/users/kenogo/gists{/gist_id}","starred_url":"https://api.github.com/users/kenogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenogo/subscriptions","organizations_url":"https://api.github.com/users/kenogo/orgs","repos_url":"https://api.github.com/users/kenogo/repos","events_url":"https://api.github.com/users/kenogo/events{/privacy}","received_events_url":"https://api.github.com/users/kenogo/received_events","type":"User","site_admin":false},"body":"Fixes #36 ","created_at":"2018-12-02T11:07:44Z","updated_at":"2018-12-02T20:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"418782c70f36eb316f8ad99c2d4f65f683fe8a99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38/commits","review_comments_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38/comments","review_comment_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/issues/38/comments","statuses_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/statuses/de70d52a3155802e251ba336eb856cc5a9ddc983","head":{"label":"kenogo:malloc_checks","ref":"malloc_checks","sha":"de70d52a3155802e251ba336eb856cc5a9ddc983","user":{"login":"kenogo","id":24212659,"node_id":"MDQ6VXNlcjI0MjEyNjU5","avatar_url":"https://avatars2.githubusercontent.com/u/24212659?v=4","gravatar_id":"","url":"https://api.github.com/users/kenogo","html_url":"https://github.com/kenogo","followers_url":"https://api.github.com/users/kenogo/followers","following_url":"https://api.github.com/users/kenogo/following{/other_user}","gists_url":"https://api.github.com/users/kenogo/gists{/gist_id}","starred_url":"https://api.github.com/users/kenogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenogo/subscriptions","organizations_url":"https://api.github.com/users/kenogo/orgs","repos_url":"https://api.github.com/users/kenogo/repos","events_url":"https://api.github.com/users/kenogo/events{/privacy}","received_events_url":"https://api.github.com/users/kenogo/received_events","type":"User","site_admin":false},"repo":{"id":143778728,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3Nzg3Mjg=","name":"bspwc","full_name":"kenogo/bspwc","private":false,"owner":{"login":"kenogo","id":24212659,"node_id":"MDQ6VXNlcjI0MjEyNjU5","avatar_url":"https://avatars2.githubusercontent.com/u/24212659?v=4","gravatar_id":"","url":"https://api.github.com/users/kenogo","html_url":"https://github.com/kenogo","followers_url":"https://api.github.com/users/kenogo/followers","following_url":"https://api.github.com/users/kenogo/following{/other_user}","gists_url":"https://api.github.com/users/kenogo/gists{/gist_id}","starred_url":"https://api.github.com/users/kenogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenogo/subscriptions","organizations_url":"https://api.github.com/users/kenogo/orgs","repos_url":"https://api.github.com/users/kenogo/repos","events_url":"https://api.github.com/users/kenogo/events{/privacy}","received_events_url":"https://api.github.com/users/kenogo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kenogo/bspwc","description":"Wayland compositor based on BSPWM","fork":true,"url":"https://api.github.com/repos/kenogo/bspwc","forks_url":"https://api.github.com/repos/kenogo/bspwc/forks","keys_url":"https://api.github.com/repos/kenogo/bspwc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenogo/bspwc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenogo/bspwc/teams","hooks_url":"https://api.github.com/repos/kenogo/bspwc/hooks","issue_events_url":"https://api.github.com/repos/kenogo/bspwc/issues/events{/number}","events_url":"https://api.github.com/repos/kenogo/bspwc/events","assignees_url":"https://api.github.com/repos/kenogo/bspwc/assignees{/user}","branches_url":"https://api.github.com/repos/kenogo/bspwc/branches{/branch}","tags_url":"https://api.github.com/repos/kenogo/bspwc/tags","blobs_url":"https://api.github.com/repos/kenogo/bspwc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenogo/bspwc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenogo/bspwc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenogo/bspwc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenogo/bspwc/statuses/{sha}","languages_url":"https://api.github.com/repos/kenogo/bspwc/languages","stargazers_url":"https://api.github.com/repos/kenogo/bspwc/stargazers","contributors_url":"https://api.github.com/repos/kenogo/bspwc/contributors","subscribers_url":"https://api.github.com/repos/kenogo/bspwc/subscribers","subscription_url":"https://api.github.com/repos/kenogo/bspwc/subscription","commits_url":"https://api.github.com/repos/kenogo/bspwc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenogo/bspwc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenogo/bspwc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenogo/bspwc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenogo/bspwc/contents/{+path}","compare_url":"https://api.github.com/repos/kenogo/bspwc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenogo/bspwc/merges","archive_url":"https://api.github.com/repos/kenogo/bspwc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenogo/bspwc/downloads","issues_url":"https://api.github.com/repos/kenogo/bspwc/issues{/number}","pulls_url":"https://api.github.com/repos/kenogo/bspwc/pulls{/number}","milestones_url":"https://api.github.com/repos/kenogo/bspwc/milestones{/number}","notifications_url":"https://api.github.com/repos/kenogo/bspwc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenogo/bspwc/labels{/name}","releases_url":"https://api.github.com/repos/kenogo/bspwc/releases{/id}","deployments_url":"https://api.github.com/repos/kenogo/bspwc/deployments","created_at":"2018-08-06T20:19:15Z","updated_at":"2018-12-02T10:07:34Z","pushed_at":"2018-12-02T11:05:38Z","git_url":"git://github.com/kenogo/bspwc.git","ssh_url":"git@github.com:kenogo/bspwc.git","clone_url":"https://github.com/kenogo/bspwc.git","svn_url":"https://github.com/kenogo/bspwc","homepage":"http://webchat.freenode.net/?channels=bspwc","size":155,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bl4ckb0ne:master","ref":"master","sha":"ab944c907c87ae14eafbfb42fccb5a42155fb07d","user":{"login":"Bl4ckb0ne","id":5001005,"node_id":"MDQ6VXNlcjUwMDEwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5001005?v=4","gravatar_id":"","url":"https://api.github.com/users/Bl4ckb0ne","html_url":"https://github.com/Bl4ckb0ne","followers_url":"https://api.github.com/users/Bl4ckb0ne/followers","following_url":"https://api.github.com/users/Bl4ckb0ne/following{/other_user}","gists_url":"https://api.github.com/users/Bl4ckb0ne/gists{/gist_id}","starred_url":"https://api.github.com/users/Bl4ckb0ne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bl4ckb0ne/subscriptions","organizations_url":"https://api.github.com/users/Bl4ckb0ne/orgs","repos_url":"https://api.github.com/users/Bl4ckb0ne/repos","events_url":"https://api.github.com/users/Bl4ckb0ne/events{/privacy}","received_events_url":"https://api.github.com/users/Bl4ckb0ne/received_events","type":"User","site_admin":false},"repo":{"id":117190039,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxOTAwMzk=","name":"bspwc","full_name":"Bl4ckb0ne/bspwc","private":false,"owner":{"login":"Bl4ckb0ne","id":5001005,"node_id":"MDQ6VXNlcjUwMDEwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5001005?v=4","gravatar_id":"","url":"https://api.github.com/users/Bl4ckb0ne","html_url":"https://github.com/Bl4ckb0ne","followers_url":"https://api.github.com/users/Bl4ckb0ne/followers","following_url":"https://api.github.com/users/Bl4ckb0ne/following{/other_user}","gists_url":"https://api.github.com/users/Bl4ckb0ne/gists{/gist_id}","starred_url":"https://api.github.com/users/Bl4ckb0ne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bl4ckb0ne/subscriptions","organizations_url":"https://api.github.com/users/Bl4ckb0ne/orgs","repos_url":"https://api.github.com/users/Bl4ckb0ne/repos","events_url":"https://api.github.com/users/Bl4ckb0ne/events{/privacy}","received_events_url":"https://api.github.com/users/Bl4ckb0ne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bl4ckb0ne/bspwc","description":"Wayland compositor based on BSPWM","fork":false,"url":"https://api.github.com/repos/Bl4ckb0ne/bspwc","forks_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/forks","keys_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/teams","hooks_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/hooks","issue_events_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/issues/events{/number}","events_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/events","assignees_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/assignees{/user}","branches_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/branches{/branch}","tags_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/tags","blobs_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/statuses/{sha}","languages_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/languages","stargazers_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/stargazers","contributors_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/contributors","subscribers_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/subscribers","subscription_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/subscription","commits_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/contents/{+path}","compare_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/merges","archive_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/downloads","issues_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/issues{/number}","pulls_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls{/number}","milestones_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/milestones{/number}","notifications_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/labels{/name}","releases_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/releases{/id}","deployments_url":"https://api.github.com/repos/Bl4ckb0ne/bspwc/deployments","created_at":"2018-01-12T03:57:40Z","updated_at":"2018-11-28T19:51:31Z","pushed_at":"2018-12-02T19:13:17Z","git_url":"git://github.com/Bl4ckb0ne/bspwc.git","ssh_url":"git@github.com:Bl4ckb0ne/bspwc.git","clone_url":"https://github.com/Bl4ckb0ne/bspwc.git","svn_url":"https://github.com/Bl4ckb0ne/bspwc","homepage":"http://webchat.freenode.net/?channels=bspwc","size":173,"stargazers_count":113,"watchers_count":113,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":15,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38"},"html":{"href":"https://github.com/Bl4ckb0ne/bspwc/pull/38"},"issue":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/issues/38"},"comments":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/Bl4ckb0ne/bspwc/statuses/de70d52a3155802e251ba336eb856cc5a9ddc983"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kenogo"}}