{"push_id":2472304723,"size":48,"distinct_size":48,"ref":"refs/heads/xenial-1.10-built","head":"953620e1bdf9fbf6d351720aeb05043e79535585","before":"af03b85fef4941067c232f4d81b840f75228772a","commits":[{"sha":"9aae53b5ea3b6c4cf13063a6887d267ce9980b38","author":{"name":"umohnani8","email":"ed14d56198a00c20f6cfcd6e69dfd4189930e8e4@redhat.com"},"message":"Update cri-tools commit to pick up latest tests and changes\n\nSigned-off-by: umohnani8 <umohnani@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/9aae53b5ea3b6c4cf13063a6887d267ce9980b38"},{"sha":"0792b4a318fc58cac41370c2b97c498f2afdac9c","author":{"name":"umohnani8","email":"ed14d56198a00c20f6cfcd6e69dfd4189930e8e4@redhat.com"},"message":"Update cri-tools commit to pick up latest tests and changes\n\nSigned-off-by: umohnani8 <umohnani@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/0792b4a318fc58cac41370c2b97c498f2afdac9c"},{"sha":"a00e686c2b745f24a1e0360e74984e7a125008dd","author":{"name":"Antonio Murdaca","email":"f9809039ea4850e75dcb8d80b778844aa463358f@redhat.com"},"message":"vendor: sync with kube 1.10.0\n\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/a00e686c2b745f24a1e0360e74984e7a125008dd"},{"sha":"3926b7cb30361cecb5d91e8b0e0f03a9655596b6","author":{"name":"Antonio Murdaca","email":"f9809039ea4850e75dcb8d80b778844aa463358f@redhat.com"},"message":"version: bump v1.10.0\n\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/3926b7cb30361cecb5d91e8b0e0f03a9655596b6"},{"sha":"15004dd044e690a0fe274c4971aa37acf2814fb5","author":{"name":"Antonio Murdaca","email":"f9809039ea4850e75dcb8d80b778844aa463358f@redhat.com"},"message":"version: bump v1.10.1-dev\n\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/15004dd044e690a0fe274c4971aa37acf2814fb5"},{"sha":"2ff1fad2d895d3e617a7d17aea16b0e8d0958489","author":{"name":"Sebastien Boeuf","email":"90b401417360b1924ef3f520ddee932686110f85@intel.com"},"message":"test: Fix race condition in ctr.bats\n\nWhen running BATS testing from ctr.bats, it works very well for\nrunc, but in case of Kata Containers, we can expect actions to\ntake longer time to be achieved. In the specific case of the test\n\"ctr /etc/resolv.conf rw/ro mode\" from ctr.bats, we should not expect\nthe container state to be CONTAINER_EXITED right after the start\nreturned. Indeed, it might take some time for the container to exit\nand the call to \"crictl inspect $ctr_id --output table\" should be\ntried several times before we consider the output as failing.\n\nThis patch relies on the \"ctr oom\" test as an example of how to\nimplement this retry behavior.\n\nThis is a backport of #1489\n\nFixes #1492\n\nSigned-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/2ff1fad2d895d3e617a7d17aea16b0e8d0958489"},{"sha":"591b2b6fe2baffc0049e24edaae57162c55cfe3a","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"server/sandbox_stop: Pass context through StopAllPodSandboxes\n\nAvoid [1]:\n\n  panic: runtime error: invalid memory address or nil pointer dereference\n  [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x91b13f]\n  goroutine 1 [running]:\n  ...\n  runtime.sigpanic()\n          /.../runtime/signal_unix.go:388 +0x17a fp=0xc42093a670 sp=0xc42093a620 pc=0x44816a\n  github.com/kubernetes-incubator/cri-o/oci.waitContainerStop(0x0, 0x0, 0xc4208a2140, 0x2540be400, 0x1873be0, 0xc42000e020)\n          /.../cri-o/oci/oci.go:589 +0xaf fp=0xc42093a7a0 sp=0xc42093a670 pc=0x91b13f\n  github.com/kubernetes-incubator/cri-o/oci.(*Runtime).StopContainer(0xc4205294a0, 0x0, 0x0, 0xc4208a2140, 0xa, 0x0, 0x0)\n          /.../cri-o/oci/oci.go:620 +0x57f fp=0xc42093a920 sp=0xc42093a7a0 pc=0x91b99f\n  github.com/kubernetes-incubator/cri-o/server.(*Server).StopPodSandbox(0xc4202dc000, 0x0, 0x0, 0xc4201e0fd0, 0x0, 0x0, 0x0)\n          /.../cri-o/server/sandbox_stop.go:62 +0x29c fp=0xc42093abc8 sp=0xc42093a920 pc=0x13387bc\n  github.com/kubernetes-incubator/cri-o/server.(*Server).StopAllPodSandboxes(0xc4202dc000)\n          /.../cri-o/server/sandbox_stop.go:125 +0x112 fp=0xc42093ac80 sp=0xc42093abc8 pc=0x1339712\n  github.com/kubernetes-incubator/cri-o/server.(*Server).cleanupSandboxesOnShutdown(0xc4202dc000)\n          /.../cri-o/server/server.go:153 +0x85 fp=0xc42093acd0 sp=0xc42093ac80 pc=0x133be15\n  github.com/kubernetes-incubator/cri-o/server.(*Server).Shutdown(0xc4202dc000, 0x2, 0x0)\n          /.../cri-o/server/server.go:168 +0x2b fp=0xc42093acf8 sp=0xc42093acd0 pc=0x133beeb\n  ...\n\nby passing a Context instance down the stack so we don't have to\nhard-code nil in StopAllPodSandboxes' StopPodSandbox call.\n\nBackported from d3b76361 (server/sandbox_stop: Pass context through\nStopAllPodSandboxes, 2018-04-04, #1494).\n\n[1]: https://github.com/kubernetes-incubator/cri-o/issues/1490#issue-311282538\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/591b2b6fe2baffc0049e24edaae57162c55cfe3a"},{"sha":"0abb7db49c1c2651ce4695582aec71b98b7af9f2","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"server/sandbox_status_test: Use background context instead of nil\n\nWhen calling PodSandboxStatus.  Because the tests have been passing,\nthis probably doesn't matter.  But it's easy, and it cleans up our\nlast two instances of passing nil contexts.\n\nBackported from 28a0a53a (server/sandbox_status_test: Use background\ncontext instead of nil, 2018-04-04, #1494).\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/0abb7db49c1c2651ce4695582aec71b98b7af9f2"},{"sha":"64bef47a2f01df7b94a26182510f6d2f401c4be2","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"pkg/findprocess: Add a new package for portable process detection\n\nThe traditional POSIX approach to detecting processes is to kill(pid,\n0) them and check for ESRCH [1].  However, Go's os.Process makes\ndetecting that a bit awkward.\n\nOn Unix, Go's os.FindProcess implementation always succeeds [2].  And\nos.Process's Signal translates ESRCH [3] to an internal errFinished\n[4].  The Unix wrapper here rolls the FindProcess and Signal(0) calls\ntogether, and translates os's errFinished to a public ErrNotFound\n(because gometalinter complains about ESRCH).\n\nOn Windows, os.Process's Signal only supports kills [5], so we can't\nperform a check like POSIX's kill(pid, 0) [1].  Instead, this commit\nassumes os.FindProcess will return errors on nonexistent processes,\nalthough that behavior is not covered in the Go docs [2].  The Windows\nos.FindProcess wraps an OpenProcess call [6].  OpenProcess can set a\nfew errors, including ERROR_INVALID_PARAMETER and ERROR_ACCESS_DENIED\n[7].  It's possible there's an ESRCH analog in their system error\ncodes [8], but I'm not going to dig through and find it ;).  Once\nsomeone can test this on a Windows machine, they can tell us what\nerror(s) to look for.\n\nAnother possible portability issue is the use of 'sleep' in the tests.\nThat's fine for POSIX systems [9], but we may need to slot in another\ncommand for Windows.\n\nUse the new package for portable process-existence checks in the oci\npackage.\n\n[1]: http://pubs.opengroup.org/onlinepubs/9699919799/functions/kill.html\n[2]: https://golang.org/pkg/os/#FindProcess\n     > On Unix systems, FindProcess always succeeds and returns a\n     > Process for the given pid, regardless of whether the process\n     > exists.\n[3]: https://github.com/golang/go/blob/010579c2377654e575d46857ec7dc77bab586438/src/os/exec_unix.go#L72-L73\n[4]: https://github.com/golang/go/blob/010579c2377654e575d46857ec7dc77bab586438/src/os/exec_unix.go#L53\n[5]: https://github.com/golang/go/blob/010579c2377654e575d46857ec7dc77bab586438/src/os/exec_windows.go#L65-L71\n[6]: https://github.com/golang/go/blob/010579c2377654e575d46857ec7dc77bab586438/src/os/exec_windows.go#L92-L95\n[7]: https://msdn.microsoft.com/en-us/library/windows/desktop/ms684320(v=vs.85).aspx\n[8]: https://msdn.microsoft.com/en-us/library/windows/desktop/ms681381(v=vs.85).aspx\n[9]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sleep.html\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/64bef47a2f01df7b94a26182510f6d2f401c4be2"},{"sha":"8e8ff4a1dc74d2623abc85f058e8f24aa3313e74","author":{"name":"Antonio Murdaca","email":"f9809039ea4850e75dcb8d80b778844aa463358f@redhat.com"},"message":"oci: avoid race on container stop\n\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/8e8ff4a1dc74d2623abc85f058e8f24aa3313e74"},{"sha":"dbce34bb8498b426cc0e09294ed5715f61ddeacd","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"CONTRIBUTING: Link to Prow OWNERS\n\nRemove a dead \"Becoming a Maintainer\" link and that stub section,\nsince CRI-O currently doesn't document that process.  By leaving it\nundocumented, maintainer changes falls back to the usual pull-request\nreview process.\n\nThe \"hopefully two OWNERS LGTMs\" criterion is based on Dan's comment\n[1].\n\nI'd also like to explain how OWNERS related to .github/CODEOWNERS [2],\nbut neither Dan [3] nor I are clear on the intended relationship.\n\n[1]: https://github.com/kubernetes-incubator/cri-o/pull/1272#discussion_r172746401\n[2]: https://help.github.com/articles/about-codeowners/\n[3]: https://github.com/kubernetes-incubator/cri-o/pull/1272#discussion_r172773310\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/dbce34bb8498b426cc0e09294ed5715f61ddeacd"},{"sha":"55ea29ccc565544b206b4141c84e7f2c69ccee58","author":{"name":"Chris Evich","email":"352d8596d782a469eafa66a46434e15a449859ce@redhat.com"},"message":"Fix accidental positive side-effect of RHEL 7.4- bug\n\nThere is a bug-fix in 7.5.0 which fixes containers access to cgroups on\nthe host, despite the default container_manage_cgroup == 0.  When\ntesting with 7.5.0 and later, this access will be blocked unless this\nboolean is enabled.  Since it's also required in Fedora, and there's\nno negative consequence for using it in <= 7.4, simply enable it for all\nVMs.\n\nSigned-off-by: Chris Evich <cevich@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/55ea29ccc565544b206b4141c84e7f2c69ccee58"},{"sha":"ee5e4b615db2b74e52d0bd8fcac10212f0eb26ba","author":{"name":"Mrunal Patel","email":"d389837b018b67489df74a2c5f0aca13aaed44b6@gmail.com"},"message":"travis: Bump up travis go versions\n\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/ee5e4b615db2b74e52d0bd8fcac10212f0eb26ba"},{"sha":"813ea2e8a1b43c404f72fb15684ae2f62a1c0d53","author":{"name":"Daniel J Walsh","email":"7800de746fd39599bc46177380ea6aede7e31e16@redhat.com"},"message":"Default to the storage defaults\n\nChange the config to use github.com/containers/storage by default.\nAllow users to override in the config, but if the admin does not\noverride the config.\n\nSince containers/storage default driver is overlay, I removed all\nreference to overlay2,  container/storage uses the same driver for\noverlay and overlay2.\n\nSigned-off-by: Daniel J Walsh <dwalsh@redhat.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/813ea2e8a1b43c404f72fb15684ae2f62a1c0d53"},{"sha":"3045279ce6fd2b1b8e5569e5723fe98557b14370","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"Makefile: Avoid needless binary rebuilds\n\nWith this change, we avoid needless rebuilds after a successful build:\n\n  $ make binaries\n  ...real build stuff...\n  $ make binaries\n  make -C conmon\n  make[1]: Entering directory '/home/wking/.local/lib/go/src/github.com/kubernetes-incubator/cri-o/conmon'\n  make[1]: Nothing to be done for 'all'.\n  make[1]: Leaving directory '/home/wking/.local/lib/go/src/github.com/kubernetes-incubator/cri-o/conmon'\n  make -C pause\n  make[1]: Entering directory '/home/wking/.local/lib/go/src/github.com/kubernetes-incubator/cri-o/pause'\n  make[1]: '../bin/pause' is up to date.\n  make[1]: Leaving directory '/home/wking/.local/lib/go/src/github.com/kubernetes-incubator/cri-o/pause'\n\nPreviously 'make binaries' would rebuild conmon, pause, and crio every\ntime.\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/3045279ce6fd2b1b8e5569e5723fe98557b14370"},{"sha":"40055d8762f217f59dbc6197303cfe72d07e021f","author":{"name":"Mrunal Patel","email":"d389837b018b67489df74a2c5f0aca13aaed44b6@gmail.com"},"message":"Add .clang-format style\n\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/40055d8762f217f59dbc6197303cfe72d07e021f"},{"sha":"0eba2ad5738f5f432b712760c959c8a463c3f88b","author":{"name":"Mrunal Patel","email":"d389837b018b67489df74a2c5f0aca13aaed44b6@gmail.com"},"message":"clang-format styled C code\n\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/0eba2ad5738f5f432b712760c959c8a463c3f88b"},{"sha":"53aa3f28c739ad0ae6ab49e859cc47e83c3eefb4","author":{"name":"Mrunal Patel","email":"d389837b018b67489df74a2c5f0aca13aaed44b6@gmail.com"},"message":"make: Add support for formatting C files\n\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/53aa3f28c739ad0ae6ab49e859cc47e83c3eefb4"},{"sha":"2c311a98430073efbefe793f668248e6951b0edc","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"conmon/pause: Add order-only prereq for ../bin\n\nAvoid:\n\n  $ rm -rf bin\n  $ make -C conmon\n  ...\n  cc -o ../bin/conmon config.h conmon.o cmsg.o ...\n  In file included from <command-line>:0:0:\n  /usr/include/stdc-predef.h:1:0: fatal error: can’t create precompiled header ../bin/conmon: No such file or directory\n  ...\n\nby using an order-only prerequisite [1] for the bin directory.  'mkdir\n-p dir' is in POSIX [2].\n\n[1]: https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html\n[2]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/mkdir.html\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/2c311a98430073efbefe793f668248e6951b0edc"},{"sha":"9544876242898fa8ea33f92581e702ae198ec7d9","author":{"name":"Lokesh Mandvekar","email":"46b23e80209bb43857d25fd87bafe9be89c7d33a@fedoraproject.org"},"message":"add ubuntu packaging\n\nSigned-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>","distinct":true,"url":"https://api.github.com/repos/lsm5/cri-o/commits/9544876242898fa8ea33f92581e702ae198ec7d9"}]}
{"actor":{"display_login":"lsm5"}}