{"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/comments/201996250","pull_request_review_id":136603329,"id":201996250,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTk5NjI1MA==","diff_hunk":"@@ -0,0 +1,4 @@\n+\n+\n+def test_that_full_check_will_run_this_test():\n+    assert True","path":"signing_service/tests/tests.py","position":4,"original_position":4,"commit_id":"8d29529ca499fbf5f9aedf688ee43846060d4a67","original_commit_id":"8d29529ca499fbf5f9aedf688ee43846060d4a67","user":{"login":"rwrzesien","id":10088909,"node_id":"MDQ6VXNlcjEwMDg4OTA5","avatar_url":"https://avatars0.githubusercontent.com/u/10088909?v=4","gravatar_id":"","url":"https://api.github.com/users/rwrzesien","html_url":"https://github.com/rwrzesien","followers_url":"https://api.github.com/users/rwrzesien/followers","following_url":"https://api.github.com/users/rwrzesien/following{/other_user}","gists_url":"https://api.github.com/users/rwrzesien/gists{/gist_id}","starred_url":"https://api.github.com/users/rwrzesien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwrzesien/subscriptions","organizations_url":"https://api.github.com/users/rwrzesien/orgs","repos_url":"https://api.github.com/users/rwrzesien/repos","events_url":"https://api.github.com/users/rwrzesien/events{/privacy}","received_events_url":"https://api.github.com/users/rwrzesien/received_events","type":"User","site_admin":false},"body":"I thought no one will notice ;) Yes, most of this can be tested but a good integration tests are not possible in this case I think. But I will add those which are possible.\r\n","created_at":"2018-07-12T11:09:23Z","updated_at":"2018-07-12T11:09:23Z","html_url":"https://github.com/golemfactory/concent/pull/634#discussion_r201996250","pull_request_url":"https://api.github.com/repos/golemfactory/concent/pulls/634","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments/201996250"},"html":{"href":"https://github.com/golemfactory/concent/pull/634#discussion_r201996250"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/634"}},"in_reply_to_id":201935768},"pull_request":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/634","id":200849555,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODQ5NTU1","html_url":"https://github.com/golemfactory/concent/pull/634","diff_url":"https://github.com/golemfactory/concent/pull/634.diff","patch_url":"https://github.com/golemfactory/concent/pull/634.patch","issue_url":"https://api.github.com/repos/golemfactory/concent/issues/634","number":634,"state":"open","locked":false,"title":"[WIP] Feature signing service error handling and reconnections","user":{"login":"rwrzesien","id":10088909,"node_id":"MDQ6VXNlcjEwMDg4OTA5","avatar_url":"https://avatars0.githubusercontent.com/u/10088909?v=4","gravatar_id":"","url":"https://api.github.com/users/rwrzesien","html_url":"https://github.com/rwrzesien","followers_url":"https://api.github.com/users/rwrzesien/followers","following_url":"https://api.github.com/users/rwrzesien/following{/other_user}","gists_url":"https://api.github.com/users/rwrzesien/gists{/gist_id}","starred_url":"https://api.github.com/users/rwrzesien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwrzesien/subscriptions","organizations_url":"https://api.github.com/users/rwrzesien/orgs","repos_url":"https://api.github.com/users/rwrzesien/repos","events_url":"https://api.github.com/users/rwrzesien/events{/privacy}","received_events_url":"https://api.github.com/users/rwrzesien/received_events","type":"User","site_admin":false},"body":"Resolves https://github.com/golemfactory/concent/issues/623","created_at":"2018-07-11T23:10:27Z","updated_at":"2018-07-12T11:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9aa2e89f493517f296f3c60a630da37764b505","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cameel","id":137030,"node_id":"MDQ6VXNlcjEzNzAzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/137030?v=4","gravatar_id":"","url":"https://api.github.com/users/cameel","html_url":"https://github.com/cameel","followers_url":"https://api.github.com/users/cameel/followers","following_url":"https://api.github.com/users/cameel/following{/other_user}","gists_url":"https://api.github.com/users/cameel/gists{/gist_id}","starred_url":"https://api.github.com/users/cameel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameel/subscriptions","organizations_url":"https://api.github.com/users/cameel/orgs","repos_url":"https://api.github.com/users/cameel/repos","events_url":"https://api.github.com/users/cameel/events{/privacy}","received_events_url":"https://api.github.com/users/cameel/received_events","type":"User","site_admin":false},{"login":"Jakub89","id":20682491,"node_id":"MDQ6VXNlcjIwNjgyNDkx","avatar_url":"https://avatars2.githubusercontent.com/u/20682491?v=4","gravatar_id":"","url":"https://api.github.com/users/Jakub89","html_url":"https://github.com/Jakub89","followers_url":"https://api.github.com/users/Jakub89/followers","following_url":"https://api.github.com/users/Jakub89/following{/other_user}","gists_url":"https://api.github.com/users/Jakub89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakub89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakub89/subscriptions","organizations_url":"https://api.github.com/users/Jakub89/orgs","repos_url":"https://api.github.com/users/Jakub89/repos","events_url":"https://api.github.com/users/Jakub89/events{/privacy}","received_events_url":"https://api.github.com/users/Jakub89/received_events","type":"User","site_admin":false},{"login":"bartoszbetka","id":26007109,"node_id":"MDQ6VXNlcjI2MDA3MTA5","avatar_url":"https://avatars0.githubusercontent.com/u/26007109?v=4","gravatar_id":"","url":"https://api.github.com/users/bartoszbetka","html_url":"https://github.com/bartoszbetka","followers_url":"https://api.github.com/users/bartoszbetka/followers","following_url":"https://api.github.com/users/bartoszbetka/following{/other_user}","gists_url":"https://api.github.com/users/bartoszbetka/gists{/gist_id}","starred_url":"https://api.github.com/users/bartoszbetka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartoszbetka/subscriptions","organizations_url":"https://api.github.com/users/bartoszbetka/orgs","repos_url":"https://api.github.com/users/bartoszbetka/repos","events_url":"https://api.github.com/users/bartoszbetka/events{/privacy}","received_events_url":"https://api.github.com/users/bartoszbetka/received_events","type":"User","site_admin":false},{"login":"pawelkisielewicz","id":36702174,"node_id":"MDQ6VXNlcjM2NzAyMTc0","avatar_url":"https://avatars3.githubusercontent.com/u/36702174?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelkisielewicz","html_url":"https://github.com/pawelkisielewicz","followers_url":"https://api.github.com/users/pawelkisielewicz/followers","following_url":"https://api.github.com/users/pawelkisielewicz/following{/other_user}","gists_url":"https://api.github.com/users/pawelkisielewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelkisielewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelkisielewicz/subscriptions","organizations_url":"https://api.github.com/users/pawelkisielewicz/orgs","repos_url":"https://api.github.com/users/pawelkisielewicz/repos","events_url":"https://api.github.com/users/pawelkisielewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pawelkisielewicz/received_events","type":"User","site_admin":false},{"login":"MichalW-CP","id":36954871,"node_id":"MDQ6VXNlcjM2OTU0ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/36954871?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalW-CP","html_url":"https://github.com/MichalW-CP","followers_url":"https://api.github.com/users/MichalW-CP/followers","following_url":"https://api.github.com/users/MichalW-CP/following{/other_user}","gists_url":"https://api.github.com/users/MichalW-CP/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalW-CP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalW-CP/subscriptions","organizations_url":"https://api.github.com/users/MichalW-CP/orgs","repos_url":"https://api.github.com/users/MichalW-CP/repos","events_url":"https://api.github.com/users/MichalW-CP/events{/privacy}","received_events_url":"https://api.github.com/users/MichalW-CP/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/concent/pulls/634/commits","review_comments_url":"https://api.github.com/repos/golemfactory/concent/pulls/634/comments","review_comment_url":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/concent/issues/634/comments","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/8d29529ca499fbf5f9aedf688ee43846060d4a67","head":{"label":"golemfactory:feature-signing-service-error-handling-and-reconnections","ref":"feature-signing-service-error-handling-and-reconnections","sha":"8d29529ca499fbf5f9aedf688ee43846060d4a67","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4MzY4ODU=","name":"concent","full_name":"golemfactory/concent","owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-07-11T08:50:30Z","pushed_at":"2018-07-12T11:06:29Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":2374,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":83,"license":null,"forks":1,"open_issues":83,"watchers":4,"default_branch":"master"}},"base":{"label":"golemfactory:master","ref":"master","sha":"a15ba39f17ef625f17320871d51af0fe2af2410b","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4MzY4ODU=","name":"concent","full_name":"golemfactory/concent","owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-07-11T08:50:30Z","pushed_at":"2018-07-12T11:06:29Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":2374,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":83,"license":null,"forks":1,"open_issues":83,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/634"},"html":{"href":"https://github.com/golemfactory/concent/pull/634"},"issue":{"href":"https://api.github.com/repos/golemfactory/concent/issues/634"},"comments":{"href":"https://api.github.com/repos/golemfactory/concent/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/concent/statuses/8d29529ca499fbf5f9aedf688ee43846060d4a67"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rwrzesien"}}