{"action":"closed","number":1304,"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1304","id":205819487,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODE5NDg3","html_url":"https://github.com/kubeflow/kubeflow/pull/1304","diff_url":"https://github.com/kubeflow/kubeflow/pull/1304.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/1304.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1304","number":1304,"state":"closed","locked":false,"title":"Add reasonable default to tf-serving s3 creds","user":{"login":"inc0","id":697528,"node_id":"MDQ6VXNlcjY5NzUyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/697528?v=4","gravatar_id":"","url":"https://api.github.com/users/inc0","html_url":"https://github.com/inc0","followers_url":"https://api.github.com/users/inc0/followers","following_url":"https://api.github.com/users/inc0/following{/other_user}","gists_url":"https://api.github.com/users/inc0/gists{/gist_id}","starred_url":"https://api.github.com/users/inc0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inc0/subscriptions","organizations_url":"https://api.github.com/users/inc0/orgs","repos_url":"https://api.github.com/users/inc0/repos","events_url":"https://api.github.com/users/inc0/events{/privacy}","received_events_url":"https://api.github.com/users/inc0/received_events","type":"User","site_admin":false},"body":"Most of people will use env name as key in secret, might as well make it\r\ndefault\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/1304)\n<!-- Reviewable:end -->\n","created_at":"2018-08-02T18:16:16Z","updated_at":"2018-08-02T18:38:28Z","closed_at":"2018-08-02T18:38:28Z","merged_at":"2018-08-02T18:38:28Z","merge_commit_sha":"4ec73180bec2340af37180fd4b9bed763637f208","assignee":{"login":"pdmack","id":2380545,"node_id":"MDQ6VXNlcjIzODA1NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2380545?v=4","gravatar_id":"","url":"https://api.github.com/users/pdmack","html_url":"https://github.com/pdmack","followers_url":"https://api.github.com/users/pdmack/followers","following_url":"https://api.github.com/users/pdmack/following{/other_user}","gists_url":"https://api.github.com/users/pdmack/gists{/gist_id}","starred_url":"https://api.github.com/users/pdmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdmack/subscriptions","organizations_url":"https://api.github.com/users/pdmack/orgs","repos_url":"https://api.github.com/users/pdmack/repos","events_url":"https://api.github.com/users/pdmack/events{/privacy}","received_events_url":"https://api.github.com/users/pdmack/received_events","type":"User","site_admin":false},"assignees":[{"login":"pdmack","id":2380545,"node_id":"MDQ6VXNlcjIzODA1NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2380545?v=4","gravatar_id":"","url":"https://api.github.com/users/pdmack","html_url":"https://github.com/pdmack","followers_url":"https://api.github.com/users/pdmack/followers","following_url":"https://api.github.com/users/pdmack/following{/other_user}","gists_url":"https://api.github.com/users/pdmack/gists{/gist_id}","starred_url":"https://api.github.com/users/pdmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdmack/subscriptions","organizations_url":"https://api.github.com/users/pdmack/orgs","repos_url":"https://api.github.com/users/pdmack/repos","events_url":"https://api.github.com/users/pdmack/events{/privacy}","received_events_url":"https://api.github.com/users/pdmack/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pdmack","id":2380545,"node_id":"MDQ6VXNlcjIzODA1NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2380545?v=4","gravatar_id":"","url":"https://api.github.com/users/pdmack","html_url":"https://github.com/pdmack","followers_url":"https://api.github.com/users/pdmack/followers","following_url":"https://api.github.com/users/pdmack/following{/other_user}","gists_url":"https://api.github.com/users/pdmack/gists{/gist_id}","starred_url":"https://api.github.com/users/pdmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdmack/subscriptions","organizations_url":"https://api.github.com/users/pdmack/orgs","repos_url":"https://api.github.com/users/pdmack/repos","events_url":"https://api.github.com/users/pdmack/events{/privacy}","received_events_url":"https://api.github.com/users/pdmack/received_events","type":"User","site_admin":false},{"login":"kunmingg","id":37601826,"node_id":"MDQ6VXNlcjM3NjAxODI2","avatar_url":"https://avatars2.githubusercontent.com/u/37601826?v=4","gravatar_id":"","url":"https://api.github.com/users/kunmingg","html_url":"https://github.com/kunmingg","followers_url":"https://api.github.com/users/kunmingg/followers","following_url":"https://api.github.com/users/kunmingg/following{/other_user}","gists_url":"https://api.github.com/users/kunmingg/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmingg/subscriptions","organizations_url":"https://api.github.com/users/kunmingg/orgs","repos_url":"https://api.github.com/users/kunmingg/repos","events_url":"https://api.github.com/users/kunmingg/events{/privacy}","received_events_url":"https://api.github.com/users/kunmingg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":852268762,"node_id":"MDU6TGFiZWw4NTIyNjg3NjI=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/approved","name":"approved","color":"03db12","default":false},{"id":842377274,"node_id":"MDU6TGFiZWw4NDIzNzcyNzQ=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/lgtm","name":"lgtm","color":"2efca4","default":false},{"id":796413694,"node_id":"MDU6TGFiZWw3OTY0MTM2OTQ=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/XS","name":"size/XS","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1304/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1304/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1304/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/4d3d49c4b3e93202f00cb49d44ccc81940c6a787","head":{"label":"inc0:serving-s3-defaults","ref":"serving-s3-defaults","sha":"4d3d49c4b3e93202f00cb49d44ccc81940c6a787","user":{"login":"inc0","id":697528,"node_id":"MDQ6VXNlcjY5NzUyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/697528?v=4","gravatar_id":"","url":"https://api.github.com/users/inc0","html_url":"https://github.com/inc0","followers_url":"https://api.github.com/users/inc0/followers","following_url":"https://api.github.com/users/inc0/following{/other_user}","gists_url":"https://api.github.com/users/inc0/gists{/gist_id}","starred_url":"https://api.github.com/users/inc0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inc0/subscriptions","organizations_url":"https://api.github.com/users/inc0/orgs","repos_url":"https://api.github.com/users/inc0/repos","events_url":"https://api.github.com/users/inc0/events{/privacy}","received_events_url":"https://api.github.com/users/inc0/received_events","type":"User","site_admin":false},"repo":{"id":121421148,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0MjExNDg=","name":"kubeflow","full_name":"inc0/kubeflow","owner":{"login":"inc0","id":697528,"node_id":"MDQ6VXNlcjY5NzUyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/697528?v=4","gravatar_id":"","url":"https://api.github.com/users/inc0","html_url":"https://github.com/inc0","followers_url":"https://api.github.com/users/inc0/followers","following_url":"https://api.github.com/users/inc0/following{/other_user}","gists_url":"https://api.github.com/users/inc0/gists{/gist_id}","starred_url":"https://api.github.com/users/inc0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inc0/subscriptions","organizations_url":"https://api.github.com/users/inc0/orgs","repos_url":"https://api.github.com/users/inc0/repos","events_url":"https://api.github.com/users/inc0/events{/privacy}","received_events_url":"https://api.github.com/users/inc0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inc0/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/inc0/kubeflow","forks_url":"https://api.github.com/repos/inc0/kubeflow/forks","keys_url":"https://api.github.com/repos/inc0/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inc0/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inc0/kubeflow/teams","hooks_url":"https://api.github.com/repos/inc0/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/inc0/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/inc0/kubeflow/events","assignees_url":"https://api.github.com/repos/inc0/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/inc0/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/inc0/kubeflow/tags","blobs_url":"https://api.github.com/repos/inc0/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inc0/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inc0/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/inc0/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inc0/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/inc0/kubeflow/languages","stargazers_url":"https://api.github.com/repos/inc0/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/inc0/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/inc0/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/inc0/kubeflow/subscription","commits_url":"https://api.github.com/repos/inc0/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/inc0/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/inc0/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/inc0/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/inc0/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/inc0/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inc0/kubeflow/merges","archive_url":"https://api.github.com/repos/inc0/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inc0/kubeflow/downloads","issues_url":"https://api.github.com/repos/inc0/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/inc0/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/inc0/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/inc0/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inc0/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/inc0/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/inc0/kubeflow/deployments","created_at":"2018-02-13T18:41:05Z","updated_at":"2018-04-02T21:42:17Z","pushed_at":"2018-08-02T18:15:55Z","git_url":"git://github.com/inc0/kubeflow.git","ssh_url":"git@github.com:inc0/kubeflow.git","clone_url":"https://github.com/inc0/kubeflow.git","svn_url":"https://github.com/inc0/kubeflow","homepage":"","size":121560,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"ac649bff69dbce9c4169cff5ec09d7b8da017f1c","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2NDczNDM=","name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-08-02T16:28:19Z","pushed_at":"2018-08-02T18:38:28Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":125210,"stargazers_count":4219,"watchers_count":4219,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":536,"mirror_url":null,"archived":false,"open_issues_count":261,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":536,"open_issues":261,"watchers":4219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1304"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/1304"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/1304"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/1304/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1304/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1304/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/4d3d49c4b3e93202f00cb49d44ccc81940c6a787"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"k8s-ci-robot"}}