{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/libretro/snes9x2002/pulls/29","id":239466820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDY2ODIw","html_url":"https://github.com/libretro/snes9x2002/pull/29","diff_url":"https://github.com/libretro/snes9x2002/pull/29.diff","patch_url":"https://github.com/libretro/snes9x2002/pull/29.patch","issue_url":"https://api.github.com/repos/libretro/snes9x2002/issues/29","number":29,"state":"closed","locked":false,"title":"Fix audio pitch issues (FF6)","user":{"login":"jdgleaver","id":38211560,"node_id":"MDQ6VXNlcjM4MjExNTYw","avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"body":"The 'old' snes9x cores (2002, 2005 non-plus) are notorious for murdering the soundtrack of Final Fantasy 6 (music samples play at incorrect pitch levels). Popular stand-alone emulators based on old snes9x versions do not suffer from this problem, so I performed a diff with various other repos and found a very obvious and consistent discrepancy.\r\n\r\nThis PR changes a single frequency calculation, bringing the core into line with the likes of snes9x_3ds, Snes9x EX+ and CATSFC. This fixes the music in Final Fantasy 6 (I checked the waveforms from snes9x2002 and bsnes in Audacity, and they're pretty close now), and it seems to improve a number of other games too. (This is particularly nice for 3DS users, since snes9x2002 is the only SNES core that runs full speed on n3DS)\r\n\r\nThis same fix is required for snes9x2005 (non-plus) - I'll make a PR for that repo soon.","created_at":"2018-12-18T12:11:00Z","updated_at":"2018-12-18T16:49:24Z","closed_at":"2018-12-18T16:49:23Z","merged_at":"2018-12-18T16:49:23Z","merge_commit_sha":"30352c8da713c2f344b8c4f8979067b04369cb7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libretro/snes9x2002/pulls/29/commits","review_comments_url":"https://api.github.com/repos/libretro/snes9x2002/pulls/29/comments","review_comment_url":"https://api.github.com/repos/libretro/snes9x2002/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libretro/snes9x2002/issues/29/comments","statuses_url":"https://api.github.com/repos/libretro/snes9x2002/statuses/f7422829ba18fa65da5f84bb6ca716ee15960a5b","head":{"label":"jdgleaver:pitch-fix","ref":"pitch-fix","sha":"f7422829ba18fa65da5f84bb6ca716ee15960a5b","user":{"login":"jdgleaver","id":38211560,"node_id":"MDQ6VXNlcjM4MjExNTYw","avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"repo":{"id":162264728,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIyNjQ3Mjg=","name":"snes9x2002","full_name":"jdgleaver/snes9x2002","private":false,"owner":{"login":"jdgleaver","id":38211560,"node_id":"MDQ6VXNlcjM4MjExNTYw","avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdgleaver/snes9x2002","description":"Snes9x 2002. Port of SNES9x 1.39 for libretro (was previously called PocketSNES). Heavily optimized for ARM.","fork":true,"url":"https://api.github.com/repos/jdgleaver/snes9x2002","forks_url":"https://api.github.com/repos/jdgleaver/snes9x2002/forks","keys_url":"https://api.github.com/repos/jdgleaver/snes9x2002/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdgleaver/snes9x2002/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdgleaver/snes9x2002/teams","hooks_url":"https://api.github.com/repos/jdgleaver/snes9x2002/hooks","issue_events_url":"https://api.github.com/repos/jdgleaver/snes9x2002/issues/events{/number}","events_url":"https://api.github.com/repos/jdgleaver/snes9x2002/events","assignees_url":"https://api.github.com/repos/jdgleaver/snes9x2002/assignees{/user}","branches_url":"https://api.github.com/repos/jdgleaver/snes9x2002/branches{/branch}","tags_url":"https://api.github.com/repos/jdgleaver/snes9x2002/tags","blobs_url":"https://api.github.com/repos/jdgleaver/snes9x2002/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdgleaver/snes9x2002/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdgleaver/snes9x2002/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdgleaver/snes9x2002/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdgleaver/snes9x2002/statuses/{sha}","languages_url":"https://api.github.com/repos/jdgleaver/snes9x2002/languages","stargazers_url":"https://api.github.com/repos/jdgleaver/snes9x2002/stargazers","contributors_url":"https://api.github.com/repos/jdgleaver/snes9x2002/contributors","subscribers_url":"https://api.github.com/repos/jdgleaver/snes9x2002/subscribers","subscription_url":"https://api.github.com/repos/jdgleaver/snes9x2002/subscription","commits_url":"https://api.github.com/repos/jdgleaver/snes9x2002/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdgleaver/snes9x2002/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdgleaver/snes9x2002/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdgleaver/snes9x2002/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdgleaver/snes9x2002/contents/{+path}","compare_url":"https://api.github.com/repos/jdgleaver/snes9x2002/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdgleaver/snes9x2002/merges","archive_url":"https://api.github.com/repos/jdgleaver/snes9x2002/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdgleaver/snes9x2002/downloads","issues_url":"https://api.github.com/repos/jdgleaver/snes9x2002/issues{/number}","pulls_url":"https://api.github.com/repos/jdgleaver/snes9x2002/pulls{/number}","milestones_url":"https://api.github.com/repos/jdgleaver/snes9x2002/milestones{/number}","notifications_url":"https://api.github.com/repos/jdgleaver/snes9x2002/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdgleaver/snes9x2002/labels{/name}","releases_url":"https://api.github.com/repos/jdgleaver/snes9x2002/releases{/id}","deployments_url":"https://api.github.com/repos/jdgleaver/snes9x2002/deployments","created_at":"2018-12-18T09:38:24Z","updated_at":"2018-12-18T09:38:27Z","pushed_at":"2018-12-18T12:14:42Z","git_url":"git://github.com/jdgleaver/snes9x2002.git","ssh_url":"git@github.com:jdgleaver/snes9x2002.git","clone_url":"https://github.com/jdgleaver/snes9x2002.git","svn_url":"https://github.com/jdgleaver/snes9x2002","homepage":"","size":2707,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libretro:master","ref":"master","sha":"142b0ed8aa7487f73d401736d3b24ce6e851a060","user":{"login":"libretro","id":1812827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTI4Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1812827?v=4","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"repo":{"id":4660454,"node_id":"MDEwOlJlcG9zaXRvcnk0NjYwNDU0","name":"snes9x2002","full_name":"libretro/snes9x2002","private":false,"owner":{"login":"libretro","id":1812827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTI4Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1812827?v=4","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libretro/snes9x2002","description":"Snes9x 2002. Port of SNES9x 1.39 for libretro (was previously called PocketSNES). Heavily optimized for ARM.","fork":false,"url":"https://api.github.com/repos/libretro/snes9x2002","forks_url":"https://api.github.com/repos/libretro/snes9x2002/forks","keys_url":"https://api.github.com/repos/libretro/snes9x2002/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libretro/snes9x2002/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libretro/snes9x2002/teams","hooks_url":"https://api.github.com/repos/libretro/snes9x2002/hooks","issue_events_url":"https://api.github.com/repos/libretro/snes9x2002/issues/events{/number}","events_url":"https://api.github.com/repos/libretro/snes9x2002/events","assignees_url":"https://api.github.com/repos/libretro/snes9x2002/assignees{/user}","branches_url":"https://api.github.com/repos/libretro/snes9x2002/branches{/branch}","tags_url":"https://api.github.com/repos/libretro/snes9x2002/tags","blobs_url":"https://api.github.com/repos/libretro/snes9x2002/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libretro/snes9x2002/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libretro/snes9x2002/git/refs{/sha}","trees_url":"https://api.github.com/repos/libretro/snes9x2002/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libretro/snes9x2002/statuses/{sha}","languages_url":"https://api.github.com/repos/libretro/snes9x2002/languages","stargazers_url":"https://api.github.com/repos/libretro/snes9x2002/stargazers","contributors_url":"https://api.github.com/repos/libretro/snes9x2002/contributors","subscribers_url":"https://api.github.com/repos/libretro/snes9x2002/subscribers","subscription_url":"https://api.github.com/repos/libretro/snes9x2002/subscription","commits_url":"https://api.github.com/repos/libretro/snes9x2002/commits{/sha}","git_commits_url":"https://api.github.com/repos/libretro/snes9x2002/git/commits{/sha}","comments_url":"https://api.github.com/repos/libretro/snes9x2002/comments{/number}","issue_comment_url":"https://api.github.com/repos/libretro/snes9x2002/issues/comments{/number}","contents_url":"https://api.github.com/repos/libretro/snes9x2002/contents/{+path}","compare_url":"https://api.github.com/repos/libretro/snes9x2002/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libretro/snes9x2002/merges","archive_url":"https://api.github.com/repos/libretro/snes9x2002/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libretro/snes9x2002/downloads","issues_url":"https://api.github.com/repos/libretro/snes9x2002/issues{/number}","pulls_url":"https://api.github.com/repos/libretro/snes9x2002/pulls{/number}","milestones_url":"https://api.github.com/repos/libretro/snes9x2002/milestones{/number}","notifications_url":"https://api.github.com/repos/libretro/snes9x2002/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libretro/snes9x2002/labels{/name}","releases_url":"https://api.github.com/repos/libretro/snes9x2002/releases{/id}","deployments_url":"https://api.github.com/repos/libretro/snes9x2002/deployments","created_at":"2012-06-14T07:18:06Z","updated_at":"2018-11-08T12:35:59Z","pushed_at":"2018-12-18T16:49:23Z","git_url":"git://github.com/libretro/snes9x2002.git","ssh_url":"git@github.com:libretro/snes9x2002.git","clone_url":"https://github.com/libretro/snes9x2002.git","svn_url":"https://github.com/libretro/snes9x2002","homepage":"","size":2448,"stargazers_count":21,"watchers_count":21,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":28,"open_issues":7,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libretro/snes9x2002/pulls/29"},"html":{"href":"https://github.com/libretro/snes9x2002/pull/29"},"issue":{"href":"https://api.github.com/repos/libretro/snes9x2002/issues/29"},"comments":{"href":"https://api.github.com/repos/libretro/snes9x2002/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/libretro/snes9x2002/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/libretro/snes9x2002/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libretro/snes9x2002/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/libretro/snes9x2002/statuses/f7422829ba18fa65da5f84bb6ca716ee15960a5b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hizzlekizzle","id":2805586,"node_id":"MDQ6VXNlcjI4MDU1ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/2805586?v=4","gravatar_id":"","url":"https://api.github.com/users/hizzlekizzle","html_url":"https://github.com/hizzlekizzle","followers_url":"https://api.github.com/users/hizzlekizzle/followers","following_url":"https://api.github.com/users/hizzlekizzle/following{/other_user}","gists_url":"https://api.github.com/users/hizzlekizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/hizzlekizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hizzlekizzle/subscriptions","organizations_url":"https://api.github.com/users/hizzlekizzle/orgs","repos_url":"https://api.github.com/users/hizzlekizzle/repos","events_url":"https://api.github.com/users/hizzlekizzle/events{/privacy}","received_events_url":"https://api.github.com/users/hizzlekizzle/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"hizzlekizzle"}}