{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/comments/204500790","pull_request_review_id":139589432,"id":204500790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDUwMDc5MA==","diff_hunk":"@@ -286,32 +337,44 @@ private void ConvertExceptionTree(Exception exception, ExceptionDetails parentEx\n             }\n         }\n \n-        private void UpdateExceptions(Exception exception)\n+        private void UpdateData(Exception exception, ExceptionInfo exceptionInfo)","path":"src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs","position":null,"original_position":230,"commit_id":"c2aa2c43b3e7e1e7a02c9483bdeca2bdc29d8330","original_commit_id":"137936e153e1b23b7cd3935e9bc0cb1cbcf39575","user":{"login":"tokaplan","id":8517601,"node_id":"MDQ6VXNlcjg1MTc2MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/8517601?v=4","gravatar_id":"","url":"https://api.github.com/users/tokaplan","html_url":"https://github.com/tokaplan","followers_url":"https://api.github.com/users/tokaplan/followers","following_url":"https://api.github.com/users/tokaplan/following{/other_user}","gists_url":"https://api.github.com/users/tokaplan/gists{/gist_id}","starred_url":"https://api.github.com/users/tokaplan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokaplan/subscriptions","organizations_url":"https://api.github.com/users/tokaplan/orgs","repos_url":"https://api.github.com/users/tokaplan/repos","events_url":"https://api.github.com/users/tokaplan/events{/privacy}","received_events_url":"https://api.github.com/users/tokaplan/received_events","type":"User","site_admin":false},"body":"Good catch, thank you. It fell apart during refactoring and I never noticed :)","created_at":"2018-07-23T18:02:47Z","updated_at":"2018-07-23T18:02:47Z","html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet/pull/865#discussion_r204500790","pull_request_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/comments/204500790"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-dotnet/pull/865#discussion_r204500790"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865"}},"in_reply_to_id":204454943},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865","id":202406256,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDA2MjU2","html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet/pull/865","diff_url":"https://github.com/Microsoft/ApplicationInsights-dotnet/pull/865.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-dotnet/pull/865.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/issues/865","number":865,"state":"open","locked":false,"title":"Add ExceptionDetailsInfo class","user":{"login":"kunalspathak","id":12488060,"node_id":"MDQ6VXNlcjEyNDg4MDYw","avatar_url":"https://avatars0.githubusercontent.com/u/12488060?v=4","gravatar_id":"","url":"https://api.github.com/users/kunalspathak","html_url":"https://github.com/kunalspathak","followers_url":"https://api.github.com/users/kunalspathak/followers","following_url":"https://api.github.com/users/kunalspathak/following{/other_user}","gists_url":"https://api.github.com/users/kunalspathak/gists{/gist_id}","starred_url":"https://api.github.com/users/kunalspathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunalspathak/subscriptions","organizations_url":"https://api.github.com/users/kunalspathak/orgs","repos_url":"https://api.github.com/users/kunalspathak/repos","events_url":"https://api.github.com/users/kunalspathak/events{/privacy}","received_events_url":"https://api.github.com/users/kunalspathak/received_events","type":"User","site_admin":false},"body":"Fix Issue #498 .\r\nAdds a class `ExceptionDetailsInfo` which acts as a wrapper for internal `ExceptionDetails` and is used to update the `TypeName` and `Message` fields of internal `ExceptionDetails` objects.\r\n\r\n- [X] I ran [Unit Tests](https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/.github/CONTRIBUTING.md) locally.\r\n\r\nFor significant contributions please make sure you have completed the following items:\r\n\r\n- [X] Design discussion issue #498 \r\n- [ ] Changes in public surface reviewed\r\n- [x] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.\r\n- [ ] The PR will trigger build, unit test, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.\r\n","created_at":"2018-07-18T23:22:26Z","updated_at":"2018-07-23T18:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a128b2500045037aafe47945660dd8cb8754cee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/issues/865/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/statuses/c2aa2c43b3e7e1e7a02c9483bdeca2bdc29d8330","head":{"label":"kunalspathak:ExceptionDetailsInfo","ref":"ExceptionDetailsInfo","sha":"c2aa2c43b3e7e1e7a02c9483bdeca2bdc29d8330","user":{"login":"kunalspathak","id":12488060,"node_id":"MDQ6VXNlcjEyNDg4MDYw","avatar_url":"https://avatars0.githubusercontent.com/u/12488060?v=4","gravatar_id":"","url":"https://api.github.com/users/kunalspathak","html_url":"https://github.com/kunalspathak","followers_url":"https://api.github.com/users/kunalspathak/followers","following_url":"https://api.github.com/users/kunalspathak/following{/other_user}","gists_url":"https://api.github.com/users/kunalspathak/gists{/gist_id}","starred_url":"https://api.github.com/users/kunalspathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunalspathak/subscriptions","organizations_url":"https://api.github.com/users/kunalspathak/orgs","repos_url":"https://api.github.com/users/kunalspathak/repos","events_url":"https://api.github.com/users/kunalspathak/events{/privacy}","received_events_url":"https://api.github.com/users/kunalspathak/received_events","type":"User","site_admin":false},"repo":{"id":141494476,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0OTQ0NzY=","name":"ApplicationInsights-dotnet","full_name":"kunalspathak/ApplicationInsights-dotnet","owner":{"login":"kunalspathak","id":12488060,"node_id":"MDQ6VXNlcjEyNDg4MDYw","avatar_url":"https://avatars0.githubusercontent.com/u/12488060?v=4","gravatar_id":"","url":"https://api.github.com/users/kunalspathak","html_url":"https://github.com/kunalspathak","followers_url":"https://api.github.com/users/kunalspathak/followers","following_url":"https://api.github.com/users/kunalspathak/following{/other_user}","gists_url":"https://api.github.com/users/kunalspathak/gists{/gist_id}","starred_url":"https://api.github.com/users/kunalspathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunalspathak/subscriptions","organizations_url":"https://api.github.com/users/kunalspathak/orgs","repos_url":"https://api.github.com/users/kunalspathak/repos","events_url":"https://api.github.com/users/kunalspathak/events{/privacy}","received_events_url":"https://api.github.com/users/kunalspathak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kunalspathak/ApplicationInsights-dotnet","description":"ApplicationInsights-dotnet","fork":true,"url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet","forks_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/forks","keys_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/teams","hooks_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/hooks","issue_events_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/events","assignees_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/tags","blobs_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/languages","stargazers_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/stargazers","contributors_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/contributors","subscribers_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/subscribers","subscription_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/subscription","commits_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/merges","archive_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/downloads","issues_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/kunalspathak/ApplicationInsights-dotnet/deployments","created_at":"2018-07-18T21:59:23Z","updated_at":"2018-07-18T21:59:27Z","pushed_at":"2018-07-23T18:02:27Z","git_url":"git://github.com/kunalspathak/ApplicationInsights-dotnet.git","ssh_url":"git@github.com:kunalspathak/ApplicationInsights-dotnet.git","clone_url":"https://github.com/kunalspathak/ApplicationInsights-dotnet.git","svn_url":"https://github.com/kunalspathak/ApplicationInsights-dotnet","homepage":null,"size":10586,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"4493b9e7f3e2635b684394052a9344d9ae69a209","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37284654,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI4NDY1NA==","name":"ApplicationInsights-dotnet","full_name":"Microsoft/ApplicationInsights-dotnet","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet","description":"ApplicationInsights-dotnet","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/deployments","created_at":"2015-06-11T20:34:21Z","updated_at":"2018-07-21T05:36:25Z","pushed_at":"2018-07-23T18:02:29Z","git_url":"git://github.com/Microsoft/ApplicationInsights-dotnet.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-dotnet.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-dotnet.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-dotnet","homepage":null,"size":10604,"stargazers_count":154,"watchers_count":154,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":98,"open_issues":79,"watchers":154,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-dotnet/pull/865"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/issues/865"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/issues/865/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/pulls/865/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet/statuses/c2aa2c43b3e7e1e7a02c9483bdeca2bdc29d8330"}},"author_association":"NONE"}}
{"actor":{"display_login":"tokaplan"}}