{"action":"created","issue":{"url":"https://api.github.com/repos/ng-select/ng-select/issues/712","repository_url":"https://api.github.com/repos/ng-select/ng-select","labels_url":"https://api.github.com/repos/ng-select/ng-select/issues/712/labels{/name}","comments_url":"https://api.github.com/repos/ng-select/ng-select/issues/712/comments","events_url":"https://api.github.com/repos/ng-select/ng-select/issues/712/events","html_url":"https://github.com/ng-select/ng-select/pull/712","id":345478798,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjEwNzc1","number":712,"title":"Allow customization of when triggering of scrollToEnd should happen","user":{"login":"hankolsen","id":1008390,"node_id":"MDQ6VXNlcjEwMDgzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1008390?v=4","gravatar_id":"","url":"https://api.github.com/users/hankolsen","html_url":"https://github.com/hankolsen","followers_url":"https://api.github.com/users/hankolsen/followers","following_url":"https://api.github.com/users/hankolsen/following{/other_user}","gists_url":"https://api.github.com/users/hankolsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hankolsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankolsen/subscriptions","organizations_url":"https://api.github.com/users/hankolsen/orgs","repos_url":"https://api.github.com/users/hankolsen/repos","events_url":"https://api.github.com/users/hankolsen/events{/privacy}","received_events_url":"https://api.github.com/users/hankolsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-28T21:03:33Z","updated_at":"2018-08-06T13:39:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ng-select/ng-select/pulls/712","html_url":"https://github.com/ng-select/ng-select/pull/712","diff_url":"https://github.com/ng-select/ng-select/pull/712.diff","patch_url":"https://github.com/ng-select/ng-select/pull/712.patch"},"body":"Fix for #711\r\nAdd a property `bottomDistance` to specify the distance (in pixels) from the bottom\r\nof the list where triggering of `scrollToEnd` should be done."},"comment":{"url":"https://api.github.com/repos/ng-select/ng-select/issues/comments/410711144","html_url":"https://github.com/ng-select/ng-select/pull/712#issuecomment-410711144","issue_url":"https://api.github.com/repos/ng-select/ng-select/issues/712","id":410711144,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDcxMTE0NA==","user":{"login":"hankolsen","id":1008390,"node_id":"MDQ6VXNlcjEwMDgzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1008390?v=4","gravatar_id":"","url":"https://api.github.com/users/hankolsen","html_url":"https://github.com/hankolsen","followers_url":"https://api.github.com/users/hankolsen/followers","following_url":"https://api.github.com/users/hankolsen/following{/other_user}","gists_url":"https://api.github.com/users/hankolsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hankolsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankolsen/subscriptions","organizations_url":"https://api.github.com/users/hankolsen/orgs","repos_url":"https://api.github.com/users/hankolsen/repos","events_url":"https://api.github.com/users/hankolsen/events{/privacy}","received_events_url":"https://api.github.com/users/hankolsen/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T13:39:28Z","updated_at":"2018-08-06T13:39:28Z","author_association":"NONE","body":"Ah, ok, I think I understand what you mean now.\r\n\r\nI do believe that scrollToEnd should be left untouched as it was before my updates, so it actually does what it is intended to do; trigger when it has scrolled to the end.\r\n\r\nWe should instead add another way to allow for fetching more items before reaching the end of the list. \r\n\r\nMy first idea was to reuse what I created, with a new name like \"preloadMoreItems\" or similar and a property for specifying the number of items from the bottom to trigger. Basically what my PR looks like right now.\r\nBut, I think what you are suggesting is that the event should trigger on all scroll movements, and the listener gets the index of the(first and last) items currently in the list, and it is up to the listener to decide what to do with that information.\r\n\r\nI guess your suggestion is more general and allows for more and wider use-cases.\r\nIt is not as obvious from looking at the name of the event, but on the other hand you don't need to also pass in a \"buffer\" number as in my suggestion. \r\nA hint about what the event could be used for in the docs, should solve that."}}
{"actor":{"display_login":"hankolsen"}}