{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/214839344","pull_request_review_id":151973544,"id":214839344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDgzOTM0NA==","diff_hunk":"@@ -89,6 +89,11 @@ func (txi *TxIndex) AddBatch(b *txindex.Batch) error {\n \t\t\t}\n \t\t}\n \n+\t\t// index tx by height\n+\t\tif txi.indexAllTags || cmn.StringInSlice(\"tx.height\", txi.tagsToIndex) {","path":"state/txindex/kv/kv.go","position":5,"original_position":5,"commit_id":"eb3351e0aad48e70315afd134a57d5d3d364c666","original_commit_id":"eb3351e0aad48e70315afd134a57d5d3d364c666","user":{"login":"ackratos","id":1442921,"node_id":"MDQ6VXNlcjE0NDI5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1442921?v=4","gravatar_id":"","url":"https://api.github.com/users/ackratos","html_url":"https://github.com/ackratos","followers_url":"https://api.github.com/users/ackratos/followers","following_url":"https://api.github.com/users/ackratos/following{/other_user}","gists_url":"https://api.github.com/users/ackratos/gists{/gist_id}","starred_url":"https://api.github.com/users/ackratos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackratos/subscriptions","organizations_url":"https://api.github.com/users/ackratos/orgs","repos_url":"https://api.github.com/users/ackratos/repos","events_url":"https://api.github.com/users/ackratos/events{/privacy}","received_events_url":"https://api.github.com/users/ackratos/received_events","type":"User","site_admin":false},"body":"@melekes that make sense. I will refactor in next commit (amend)","created_at":"2018-09-04T09:05:01Z","updated_at":"2018-09-04T09:05:01Z","html_url":"https://github.com/tendermint/tendermint/pull/2324#discussion_r214839344","pull_request_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2324","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/214839344"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2324#discussion_r214839344"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2324"}},"in_reply_to_id":214835104},"pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2324","id":212884351,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODg0MzUx","html_url":"https://github.com/tendermint/tendermint/pull/2324","diff_url":"https://github.com/tendermint/tendermint/pull/2324.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2324.patch","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2324","number":2324,"state":"open","locked":false,"title":"#2051 Make kv index for tx.height","user":{"login":"ackratos","id":1442921,"node_id":"MDQ6VXNlcjE0NDI5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1442921?v=4","gravatar_id":"","url":"https://api.github.com/users/ackratos","html_url":"https://github.com/ackratos","followers_url":"https://api.github.com/users/ackratos/followers","following_url":"https://api.github.com/users/ackratos/following{/other_user}","gists_url":"https://api.github.com/users/ackratos/gists{/gist_id}","starred_url":"https://api.github.com/users/ackratos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackratos/subscriptions","organizations_url":"https://api.github.com/users/ackratos/orgs","repos_url":"https://api.github.com/users/ackratos/repos","events_url":"https://api.github.com/users/ackratos/events{/privacy}","received_events_url":"https://api.github.com/users/ackratos/received_events","type":"User","site_admin":false},"body":"Partially fixed https://github.com/tendermint/tendermint/issues/2051 to make rest api request like http://127.0.0.1:8080/txs?tag=tx.height=1330 work\r\n\r\n<!-- Thanks for filing a PR! Before hitting the button, please check the following items.-->\r\n\r\n* [x] Updated all relevant documentation in docs\r\n* [x] Updated all code comments where relevant\r\n* [ ] Wrote tests\r\n* [ ] Updated CHANGELOG_PENDING.md\r\n","created_at":"2018-09-04T07:49:38Z","updated_at":"2018-09-04T09:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f7e4c1d6c457cecec59d88d87846f81785561bc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xla","id":1585,"node_id":"MDQ6VXNlcjE1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2324/commits","review_comments_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2324/comments","review_comment_url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2324/comments","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/eb3351e0aad48e70315afd134a57d5d3d364c666","head":{"label":"ackratos:2051-kv-index-txheight","ref":"2051-kv-index-txheight","sha":"eb3351e0aad48e70315afd134a57d5d3d364c666","user":{"login":"ackratos","id":1442921,"node_id":"MDQ6VXNlcjE0NDI5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1442921?v=4","gravatar_id":"","url":"https://api.github.com/users/ackratos","html_url":"https://github.com/ackratos","followers_url":"https://api.github.com/users/ackratos/followers","following_url":"https://api.github.com/users/ackratos/following{/other_user}","gists_url":"https://api.github.com/users/ackratos/gists{/gist_id}","starred_url":"https://api.github.com/users/ackratos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackratos/subscriptions","organizations_url":"https://api.github.com/users/ackratos/orgs","repos_url":"https://api.github.com/users/ackratos/repos","events_url":"https://api.github.com/users/ackratos/events{/privacy}","received_events_url":"https://api.github.com/users/ackratos/received_events","type":"User","site_admin":false},"repo":{"id":145583317,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1ODMzMTc=","name":"tendermint","full_name":"ackratos/tendermint","owner":{"login":"ackratos","id":1442921,"node_id":"MDQ6VXNlcjE0NDI5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1442921?v=4","gravatar_id":"","url":"https://api.github.com/users/ackratos","html_url":"https://github.com/ackratos","followers_url":"https://api.github.com/users/ackratos/followers","following_url":"https://api.github.com/users/ackratos/following{/other_user}","gists_url":"https://api.github.com/users/ackratos/gists{/gist_id}","starred_url":"https://api.github.com/users/ackratos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackratos/subscriptions","organizations_url":"https://api.github.com/users/ackratos/orgs","repos_url":"https://api.github.com/users/ackratos/repos","events_url":"https://api.github.com/users/ackratos/events{/privacy}","received_events_url":"https://api.github.com/users/ackratos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ackratos/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":true,"url":"https://api.github.com/repos/ackratos/tendermint","forks_url":"https://api.github.com/repos/ackratos/tendermint/forks","keys_url":"https://api.github.com/repos/ackratos/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ackratos/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ackratos/tendermint/teams","hooks_url":"https://api.github.com/repos/ackratos/tendermint/hooks","issue_events_url":"https://api.github.com/repos/ackratos/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/ackratos/tendermint/events","assignees_url":"https://api.github.com/repos/ackratos/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/ackratos/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/ackratos/tendermint/tags","blobs_url":"https://api.github.com/repos/ackratos/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ackratos/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ackratos/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ackratos/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ackratos/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/ackratos/tendermint/languages","stargazers_url":"https://api.github.com/repos/ackratos/tendermint/stargazers","contributors_url":"https://api.github.com/repos/ackratos/tendermint/contributors","subscribers_url":"https://api.github.com/repos/ackratos/tendermint/subscribers","subscription_url":"https://api.github.com/repos/ackratos/tendermint/subscription","commits_url":"https://api.github.com/repos/ackratos/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ackratos/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ackratos/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ackratos/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ackratos/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/ackratos/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ackratos/tendermint/merges","archive_url":"https://api.github.com/repos/ackratos/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ackratos/tendermint/downloads","issues_url":"https://api.github.com/repos/ackratos/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/ackratos/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/ackratos/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/ackratos/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ackratos/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/ackratos/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/ackratos/tendermint/deployments","created_at":"2018-08-21T15:26:57Z","updated_at":"2018-08-21T15:27:01Z","pushed_at":"2018-09-04T07:52:50Z","git_url":"git://github.com/ackratos/tendermint.git","ssh_url":"git@github.com:ackratos/tendermint.git","clone_url":"https://github.com/ackratos/tendermint.git","svn_url":"https://github.com/ackratos/tendermint","homepage":"https://tendermint.com/","size":50924,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"166fd82b70b76f0216cf3dacda9714e9eb19ba1c","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-09-04T05:06:01Z","pushed_at":"2018-09-04T08:21:02Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":51037,"stargazers_count":2246,"watchers_count":2246,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":534,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":534,"open_issues":316,"watchers":2246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2324"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2324"},"issue":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2324"},"comments":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2324/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2324/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2324/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tendermint/statuses/eb3351e0aad48e70315afd134a57d5d3d364c666"}},"author_association":"NONE"}}
{"actor":{"display_login":"ackratos"}}