{"action":"created","issue":{"url":"https://api.github.com/repos/rancher/rke/issues/667","repository_url":"https://api.github.com/repos/rancher/rke","labels_url":"https://api.github.com/repos/rancher/rke/issues/667/labels{/name}","comments_url":"https://api.github.com/repos/rancher/rke/issues/667/comments","events_url":"https://api.github.com/repos/rancher/rke/issues/667/events","html_url":"https://github.com/rancher/rke/pull/667","id":329284879,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTc4NjM3","number":667,"title":"Refactor cloud provider support","user":{"login":"galal-hussein","id":3309968,"node_id":"MDQ6VXNlcjMzMDk5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/3309968?v=4","gravatar_id":"","url":"https://api.github.com/users/galal-hussein","html_url":"https://github.com/galal-hussein","followers_url":"https://api.github.com/users/galal-hussein/followers","following_url":"https://api.github.com/users/galal-hussein/following{/other_user}","gists_url":"https://api.github.com/users/galal-hussein/gists{/gist_id}","starred_url":"https://api.github.com/users/galal-hussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galal-hussein/subscriptions","organizations_url":"https://api.github.com/users/galal-hussein/orgs","repos_url":"https://api.github.com/users/galal-hussein/repos","events_url":"https://api.github.com/users/galal-hussein/events{/privacy}","received_events_url":"https://api.github.com/users/galal-hussein/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-05T02:59:51Z","updated_at":"2018-06-20T10:54:09Z","closed_at":"2018-06-06T17:22:51Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rancher/rke/pulls/667","html_url":"https://github.com/rancher/rke/pull/667","diff_url":"https://github.com/rancher/rke/pull/667.diff","patch_url":"https://github.com/rancher/rke/pull/667.patch"},"body":"https://github.com/rancher/rancher/issues/13115"},"comment":{"url":"https://api.github.com/repos/rancher/rke/issues/comments/398708511","html_url":"https://github.com/rancher/rke/pull/667#issuecomment-398708511","issue_url":"https://api.github.com/repos/rancher/rke/issues/667","id":398708511,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODcwODUxMQ==","user":{"login":"dabeck","id":2900921,"node_id":"MDQ6VXNlcjI5MDA5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/2900921?v=4","gravatar_id":"","url":"https://api.github.com/users/dabeck","html_url":"https://github.com/dabeck","followers_url":"https://api.github.com/users/dabeck/followers","following_url":"https://api.github.com/users/dabeck/following{/other_user}","gists_url":"https://api.github.com/users/dabeck/gists{/gist_id}","starred_url":"https://api.github.com/users/dabeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabeck/subscriptions","organizations_url":"https://api.github.com/users/dabeck/orgs","repos_url":"https://api.github.com/users/dabeck/repos","events_url":"https://api.github.com/users/dabeck/events{/privacy}","received_events_url":"https://api.github.com/users/dabeck/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T10:54:09Z","updated_at":"2018-06-20T10:54:09Z","author_association":"NONE","body":"I just tested the new types with cloudProvider `openstack` my config:\r\n\r\n```\r\n...\r\ncloud_provider:\r\n  name: openstack\r\n  openstackCloudProvider:\r\n    global:\r\n      auth-url: \"https://example.../v3\"\r\n      domain-name: \"domain\"\r\n      password: \"password\"\r\n      region: \"eu-de\"\r\n      tenant-id:  \"id\"\r\n      username: \"user\"    \r\n    load_balancer:\r\n      subnet-id: \"4ba20e2c-bb89-468f-81c6-2c67a4bac419\"\r\n      floating-network-id: \"0a2228f2-7f8a-45f1-8e09-9039e1d09975\"\r\n```\r\n\r\nbut the generated config is corrupted:\r\n\r\n```\r\n$ cat /etc/kubernetes/cloud-config \r\n[Global,omitempty]\r\nauth-url,omitempty = https://example.../v3\r\nusername,omitempty = user\r\nuser-id,omitempty = \r\npassword,omitempty = password\r\ntenant-id,omitempty = id\r\ntenant-name,omitempty = \r\ntrust-id,omitempty = \r\ndomain-id,omitempty = \r\ndomain-name,omitempty = domain\r\nregion,omitempty = eu-de\r\nca-file,omitempty = \r\n\r\n[LoadBalancer,omitempty]\r\nlb-version,omitempty = \r\nuse-octavia,omitempty = false\r\nsubnet-id,omitempty = 4ba20e2c-bb89-468f-81c6-2c67a4bac419\r\nfloating-network-id,omitempty = 0a2228f2-7f8a-45f1-8e09-9039e1d09975\r\nlb-method,omitempty = \r\nlb-provider,omitempty = \r\ncreate-monitor,omitempty = false\r\nmonitor-delay,omitempty = 0\r\nmonitor-timeout,omitempty = 0\r\nmonitor-max-retries,omitempty = 0\r\nmanage-security-groups,omitempty = false\r\n\r\n[BlockStorage,omitempty]\r\nbs-version,omitempty = \r\ntrust-device-path,omitempty = false\r\nignore-volume-az,omitempty = false\r\n\r\n[Route,omitempty]\r\nrouter-id,omitempty = \r\n\r\n[Metadata,omitempty]\r\nsearch-order,omitempty = \r\nrequest-timeout,omitempty = 0\r\n```\r\n\r\nwhich leads to a non provisionable cluster. "}}
{"actor":{"display_login":"dabeck"}}