{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/comments/227770445","pull_request_review_id":167885252,"id":227770445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzc3MDQ0NQ==","diff_hunk":"@@ -31,6 +31,9 @@ export const PROVISION_SOURCE_TEMPLATE = 'Template';\n \n export const POD_NETWORK = 'Pod Networking';\n \n+export const ANNOTATION_PXE_INTERFACE = 'cnv.ui.pxeInterface';","path":"src/constants/index.js","position":4,"original_position":4,"commit_id":"ef34f4065ddd20bacd7c36b81e0982d34c763f19","original_commit_id":"ef34f4065ddd20bacd7c36b81e0982d34c763f19","user":{"login":"rawagner","id":2078045,"node_id":"MDQ6VXNlcjIwNzgwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2078045?v=4","gravatar_id":"","url":"https://api.github.com/users/rawagner","html_url":"https://github.com/rawagner","followers_url":"https://api.github.com/users/rawagner/followers","following_url":"https://api.github.com/users/rawagner/following{/other_user}","gists_url":"https://api.github.com/users/rawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/rawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawagner/subscriptions","organizations_url":"https://api.github.com/users/rawagner/orgs","repos_url":"https://api.github.com/users/rawagner/repos","events_url":"https://api.github.com/users/rawagner/events{/privacy}","received_events_url":"https://api.github.com/users/rawagner/received_events","type":"User","site_admin":false},"body":"For other constants..some of them are used in common-templates, but there are no docs, we could link to the common-templates repo ..?\r\nOthers are used in kubevirt itself (like API_VERSION)..we could link to user guide's VM example.. but that does not seem correct.. ","created_at":"2018-10-24T12:43:48Z","updated_at":"2018-10-24T12:43:48Z","html_url":"https://github.com/kubevirt/web-ui-components/pull/66#discussion_r227770445","pull_request_url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/comments/227770445"},"html":{"href":"https://github.com/kubevirt/web-ui-components/pull/66#discussion_r227770445"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66"}},"in_reply_to_id":227736724},"pull_request":{"url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66","id":225322520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzIyNTIw","html_url":"https://github.com/kubevirt/web-ui-components/pull/66","diff_url":"https://github.com/kubevirt/web-ui-components/pull/66.diff","patch_url":"https://github.com/kubevirt/web-ui-components/pull/66.patch","issue_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/66","number":66,"state":"open","locked":false,"title":"Make constants out of pxe annotations","user":{"login":"rawagner","id":2078045,"node_id":"MDQ6VXNlcjIwNzgwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2078045?v=4","gravatar_id":"","url":"https://api.github.com/users/rawagner","html_url":"https://github.com/rawagner","followers_url":"https://api.github.com/users/rawagner/followers","following_url":"https://api.github.com/users/rawagner/following{/other_user}","gists_url":"https://api.github.com/users/rawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/rawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawagner/subscriptions","organizations_url":"https://api.github.com/users/rawagner/orgs","repos_url":"https://api.github.com/users/rawagner/repos","events_url":"https://api.github.com/users/rawagner/events{/privacy}","received_events_url":"https://api.github.com/users/rawagner/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-24T09:10:11Z","updated_at":"2018-10-24T12:43:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8be1e066ed7de9930c6bb0e6dae1b3e5ac590b48","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1080235740,"node_id":"MDU6TGFiZWwxMDgwMjM1NzQw","url":"https://api.github.com/repos/kubevirt/web-ui-components/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66/commits","review_comments_url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66/comments","review_comment_url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/66/comments","statuses_url":"https://api.github.com/repos/kubevirt/web-ui-components/statuses/ef34f4065ddd20bacd7c36b81e0982d34c763f19","head":{"label":"rawagner:export_pxe_const","ref":"export_pxe_const","sha":"ef34f4065ddd20bacd7c36b81e0982d34c763f19","user":{"login":"rawagner","id":2078045,"node_id":"MDQ6VXNlcjIwNzgwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2078045?v=4","gravatar_id":"","url":"https://api.github.com/users/rawagner","html_url":"https://github.com/rawagner","followers_url":"https://api.github.com/users/rawagner/followers","following_url":"https://api.github.com/users/rawagner/following{/other_user}","gists_url":"https://api.github.com/users/rawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/rawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawagner/subscriptions","organizations_url":"https://api.github.com/users/rawagner/orgs","repos_url":"https://api.github.com/users/rawagner/repos","events_url":"https://api.github.com/users/rawagner/events{/privacy}","received_events_url":"https://api.github.com/users/rawagner/received_events","type":"User","site_admin":false},"repo":{"id":145989354,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5ODkzNTQ=","name":"web-ui-components","full_name":"rawagner/web-ui-components","private":false,"owner":{"login":"rawagner","id":2078045,"node_id":"MDQ6VXNlcjIwNzgwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2078045?v=4","gravatar_id":"","url":"https://api.github.com/users/rawagner","html_url":"https://github.com/rawagner","followers_url":"https://api.github.com/users/rawagner/followers","following_url":"https://api.github.com/users/rawagner/following{/other_user}","gists_url":"https://api.github.com/users/rawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/rawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawagner/subscriptions","organizations_url":"https://api.github.com/users/rawagner/orgs","repos_url":"https://api.github.com/users/rawagner/repos","events_url":"https://api.github.com/users/rawagner/events{/privacy}","received_events_url":"https://api.github.com/users/rawagner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rawagner/web-ui-components","description":"User interface project","fork":true,"url":"https://api.github.com/repos/rawagner/web-ui-components","forks_url":"https://api.github.com/repos/rawagner/web-ui-components/forks","keys_url":"https://api.github.com/repos/rawagner/web-ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rawagner/web-ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rawagner/web-ui-components/teams","hooks_url":"https://api.github.com/repos/rawagner/web-ui-components/hooks","issue_events_url":"https://api.github.com/repos/rawagner/web-ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/rawagner/web-ui-components/events","assignees_url":"https://api.github.com/repos/rawagner/web-ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/rawagner/web-ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/rawagner/web-ui-components/tags","blobs_url":"https://api.github.com/repos/rawagner/web-ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rawagner/web-ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rawagner/web-ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/rawagner/web-ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rawagner/web-ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/rawagner/web-ui-components/languages","stargazers_url":"https://api.github.com/repos/rawagner/web-ui-components/stargazers","contributors_url":"https://api.github.com/repos/rawagner/web-ui-components/contributors","subscribers_url":"https://api.github.com/repos/rawagner/web-ui-components/subscribers","subscription_url":"https://api.github.com/repos/rawagner/web-ui-components/subscription","commits_url":"https://api.github.com/repos/rawagner/web-ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/rawagner/web-ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/rawagner/web-ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/rawagner/web-ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/rawagner/web-ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/rawagner/web-ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rawagner/web-ui-components/merges","archive_url":"https://api.github.com/repos/rawagner/web-ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rawagner/web-ui-components/downloads","issues_url":"https://api.github.com/repos/rawagner/web-ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/rawagner/web-ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/rawagner/web-ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/rawagner/web-ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rawagner/web-ui-components/labels{/name}","releases_url":"https://api.github.com/repos/rawagner/web-ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/rawagner/web-ui-components/deployments","created_at":"2018-08-24T12:34:29Z","updated_at":"2018-10-02T07:50:49Z","pushed_at":"2018-10-24T12:20:28Z","git_url":"git://github.com/rawagner/web-ui-components.git","ssh_url":"git@github.com:rawagner/web-ui-components.git","clone_url":"https://github.com/rawagner/web-ui-components.git","svn_url":"https://github.com/rawagner/web-ui-components","homepage":null,"size":95777,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"9733ec7aba09c03e6ea4f6ca4c9a5dabf9b63e86","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":145694008,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2OTQwMDg=","name":"web-ui-components","full_name":"kubevirt/web-ui-components","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/web-ui-components","description":"User interface project","fork":false,"url":"https://api.github.com/repos/kubevirt/web-ui-components","forks_url":"https://api.github.com/repos/kubevirt/web-ui-components/forks","keys_url":"https://api.github.com/repos/kubevirt/web-ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/web-ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/web-ui-components/teams","hooks_url":"https://api.github.com/repos/kubevirt/web-ui-components/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/web-ui-components/events","assignees_url":"https://api.github.com/repos/kubevirt/web-ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/web-ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/web-ui-components/tags","blobs_url":"https://api.github.com/repos/kubevirt/web-ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/web-ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/web-ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/web-ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/web-ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/web-ui-components/languages","stargazers_url":"https://api.github.com/repos/kubevirt/web-ui-components/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/web-ui-components/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/web-ui-components/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/web-ui-components/subscription","commits_url":"https://api.github.com/repos/kubevirt/web-ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/web-ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/web-ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/web-ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/web-ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/web-ui-components/merges","archive_url":"https://api.github.com/repos/kubevirt/web-ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/web-ui-components/downloads","issues_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/web-ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/web-ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/web-ui-components/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/web-ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/web-ui-components/deployments","created_at":"2018-08-22T10:32:30Z","updated_at":"2018-10-24T12:16:04Z","pushed_at":"2018-10-24T12:20:29Z","git_url":"git://github.com/kubevirt/web-ui-components.git","ssh_url":"git@github.com:kubevirt/web-ui-components.git","clone_url":"https://github.com/kubevirt/web-ui-components.git","svn_url":"https://github.com/kubevirt/web-ui-components","homepage":null,"size":499,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":21,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66"},"html":{"href":"https://github.com/kubevirt/web-ui-components/pull/66"},"issue":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/issues/66"},"comments":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/web-ui-components/statuses/ef34f4065ddd20bacd7c36b81e0982d34c763f19"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rawagner"}}