{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24055","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24055/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24055/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24055/events","html_url":"https://github.com/nodejs/node/pull/24055","id":377039186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTA5MzMx","number":24055,"title":"fs: do not emit open and read if stream destroyed","user":{"login":"dexterleng","id":34204380,"node_id":"MDQ6VXNlcjM0MjA0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/34204380?v=4","gravatar_id":"","url":"https://api.github.com/users/dexterleng","html_url":"https://github.com/dexterleng","followers_url":"https://api.github.com/users/dexterleng/followers","following_url":"https://api.github.com/users/dexterleng/following{/other_user}","gists_url":"https://api.github.com/users/dexterleng/gists{/gist_id}","starred_url":"https://api.github.com/users/dexterleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexterleng/subscriptions","organizations_url":"https://api.github.com/users/dexterleng/orgs","repos_url":"https://api.github.com/users/dexterleng/repos","events_url":"https://api.github.com/users/dexterleng/events{/privacy}","received_events_url":"https://api.github.com/users/dexterleng/received_events","type":"User","site_admin":false},"labels":[{"id":155435785,"node_id":"MDU6TGFiZWwxNTU0MzU3ODU=","url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":169485514,"node_id":"MDU6TGFiZWwxNjk0ODU1MTQ=","url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false},{"id":154312478,"node_id":"MDU6TGFiZWwxNTQzMTI0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/work%20in%20progress%20(WIP)","name":"work in progress (WIP)","color":"ffff00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-03T09:36:17Z","updated_at":"2018-12-21T13:18:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24055","html_url":"https://github.com/nodejs/node/pull/24055","diff_url":"https://github.com/nodejs/node/pull/24055.diff","patch_url":"https://github.com/nodejs/node/pull/24055.patch"},"body":"WIP, will write tests ASAP.\r\n\r\nReferences: #23133\r\n\r\nAddresses this:\r\n\r\n`@mcollina I don’t understand… I’m not talking about changing emit() to be a noop function or so, I’m talking about the individual call sites in our own net, tls, fs, etc. code?`\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/449386196","html_url":"https://github.com/nodejs/node/pull/24055#issuecomment-449386196","issue_url":"https://api.github.com/repos/nodejs/node/issues/24055","id":449386196,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTM4NjE5Ng==","user":{"login":"mcollina","id":52195,"node_id":"MDQ6VXNlcjUyMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T13:18:07Z","updated_at":"2018-12-21T13:18:07Z","author_association":"MEMBER","body":"CI: https://ci.nodejs.org/job/node-test-pull-request/19715/\r\nCITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1695/"}}
{"actor":{"display_login":"mcollina"}}