{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/comments/180929869","pull_request_review_id":111439846,"id":180929869,"diff_hunk":"@@ -0,0 +1,33 @@\n+module Puppet::Parser::Functions\n+  newfunction(:ensure_php_packages, :type => :statement) do |arguments|\n+    if arguments.size > 3 or arguments.size == 0\n+      raise(Puppet::ParseError, \"ensure_php_packages(): Wrong number of arguments given (#{arguments.size} for 2 or 3)\")\n+    elsif arguments.size == 3 and !arguments[2].is_a?(Hash)\n+      raise(Puppet::ParseError, 'ensure_php_packages(): Requires third argument to be a Hash')\n+    end\n+\n+    packages = arguments[0]\n+    versions = arguments[1]\n+\n+    unless packages.is_a?(Array) && versions.is_a?(Array)\n+      raise(Puppet::ParseError, \"ensure_php_packages(): Requires 2 arrays\")\n+    end\n+\n+    if arguments[2]\n+      defaults = { \"ensure\" => \"present\" }.merge(arguments[2])\n+    else\n+      defaults = { \"ensure\" => \"present\" }\n+    end\n+\n+    versions.each do |version|\n+      packages.each do |package|\n+        # skip mcrypt on 7.2 and greater, the package was removed.","path":"lib/puppet/parser/functions/ensure_php_packages.rb","position":24,"original_position":24,"commit_id":"aa45eea5966fde61b45339a23f4371dce6390c2e","original_commit_id":"aa45eea5966fde61b45339a23f4371dce6390c2e","user":{"login":"mateusz","id":118653,"avatar_url":"https://avatars2.githubusercontent.com/u/118653?v=4","gravatar_id":"","url":"https://api.github.com/users/mateusz","html_url":"https://github.com/mateusz","followers_url":"https://api.github.com/users/mateusz/followers","following_url":"https://api.github.com/users/mateusz/following{/other_user}","gists_url":"https://api.github.com/users/mateusz/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusz/subscriptions","organizations_url":"https://api.github.com/users/mateusz/orgs","repos_url":"https://api.github.com/users/mateusz/repos","events_url":"https://api.github.com/users/mateusz/events{/privacy}","received_events_url":"https://api.github.com/users/mateusz/received_events","type":"User","site_admin":false},"body":"A bit redundant. Probably just say \"Package is now part of core\"?","created_at":"2018-04-11T23:43:40Z","updated_at":"2018-04-11T23:43:40Z","html_url":"https://github.com/silverstripeltd/puppet-ss_php/pull/3#discussion_r180929869","pull_request_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/comments/180929869"},"html":{"href":"https://github.com/silverstripeltd/puppet-ss_php/pull/3#discussion_r180929869"},"pull_request":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3","id":180778290,"html_url":"https://github.com/silverstripeltd/puppet-ss_php/pull/3","diff_url":"https://github.com/silverstripeltd/puppet-ss_php/pull/3.diff","patch_url":"https://github.com/silverstripeltd/puppet-ss_php/pull/3.patch","issue_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/3","number":3,"state":"open","locked":false,"title":"Adding helper function for installing multiple php version packages","user":{"login":"halkyon","id":138450,"avatar_url":"https://avatars1.githubusercontent.com/u/138450?v=4","gravatar_id":"","url":"https://api.github.com/users/halkyon","html_url":"https://github.com/halkyon","followers_url":"https://api.github.com/users/halkyon/followers","following_url":"https://api.github.com/users/halkyon/following{/other_user}","gists_url":"https://api.github.com/users/halkyon/gists{/gist_id}","starred_url":"https://api.github.com/users/halkyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkyon/subscriptions","organizations_url":"https://api.github.com/users/halkyon/orgs","repos_url":"https://api.github.com/users/halkyon/repos","events_url":"https://api.github.com/users/halkyon/events{/privacy}","received_events_url":"https://api.github.com/users/halkyon/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-11T02:59:59Z","updated_at":"2018-04-11T23:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eab811a12e057a5d5b11a8e1a4b0e5ff503fc010","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3/commits","review_comments_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3/comments","review_comment_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/3/comments","statuses_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/statuses/aa45eea5966fde61b45339a23f4371dce6390c2e","head":{"label":"silverstripeltd:add-helper-php-function","ref":"add-helper-php-function","sha":"aa45eea5966fde61b45339a23f4371dce6390c2e","user":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"repo":{"id":124323033,"name":"puppet-ss_php","full_name":"silverstripeltd/puppet-ss_php","owner":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripeltd/puppet-ss_php","description":null,"fork":false,"url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php","forks_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/forks","keys_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/teams","hooks_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/hooks","issue_events_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/events","assignees_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/tags","blobs_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/languages","stargazers_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/stargazers","contributors_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/contributors","subscribers_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/subscribers","subscription_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/subscription","commits_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/merges","archive_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/downloads","issues_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/labels{/name}","releases_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/deployments","created_at":"2018-03-08T02:14:19Z","updated_at":"2018-04-03T22:02:06Z","pushed_at":"2018-04-11T23:41:23Z","git_url":"git://github.com/silverstripeltd/puppet-ss_php.git","ssh_url":"git@github.com:silverstripeltd/puppet-ss_php.git","clone_url":"https://github.com/silverstripeltd/puppet-ss_php.git","svn_url":"https://github.com/silverstripeltd/puppet-ss_php","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripeltd:master","ref":"master","sha":"23af6167c4b5187095f78596e62ad8e57e432d2c","user":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"repo":{"id":124323033,"name":"puppet-ss_php","full_name":"silverstripeltd/puppet-ss_php","owner":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripeltd/puppet-ss_php","description":null,"fork":false,"url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php","forks_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/forks","keys_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/teams","hooks_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/hooks","issue_events_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/events","assignees_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/tags","blobs_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/languages","stargazers_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/stargazers","contributors_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/contributors","subscribers_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/subscribers","subscription_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/subscription","commits_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/merges","archive_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/downloads","issues_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/labels{/name}","releases_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/deployments","created_at":"2018-03-08T02:14:19Z","updated_at":"2018-04-03T22:02:06Z","pushed_at":"2018-04-11T23:41:23Z","git_url":"git://github.com/silverstripeltd/puppet-ss_php.git","ssh_url":"git@github.com:silverstripeltd/puppet-ss_php.git","clone_url":"https://github.com/silverstripeltd/puppet-ss_php.git","svn_url":"https://github.com/silverstripeltd/puppet-ss_php","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3"},"html":{"href":"https://github.com/silverstripeltd/puppet-ss_php/pull/3"},"issue":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/3"},"comments":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripeltd/puppet-ss_php/statuses/aa45eea5966fde61b45339a23f4371dce6390c2e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mateusz"}}