{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments/194815422","pull_request_review_id":128058586,"id":194815422,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDgxNTQyMg==","diff_hunk":"@@ -211,8 +216,12 @@ public void close(ScopeWrapper<S> scope)\n \n       if (entry.getValue() instanceof ResourceInstance) {\n         Object obj = ((ResourceInstance) entry.getValue()).getResource();\n-\n-        SharedResourcesBrokerUtils.shutdownObject(obj, log);\n+        // Catch unchecked exception while closing resources, make sure all resources managed by cache are closed.\n+        try {\n+          SharedResourcesBrokerUtils.shutdownObject(obj, log);\n+        } catch (Exception e) {","path":"gobblin-utility/src/main/java/org/apache/gobblin/broker/DefaultBrokerCache.java","position":37,"original_position":37,"commit_id":"989cf178baae9ce392e80f99deb3137890f0e079","original_commit_id":"989cf178baae9ce392e80f99deb3137890f0e079","user":{"login":"ibuenros","id":1364112,"node_id":"MDQ6VXNlcjEzNjQxMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1364112?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuenros","html_url":"https://github.com/ibuenros","followers_url":"https://api.github.com/users/ibuenros/followers","following_url":"https://api.github.com/users/ibuenros/following{/other_user}","gists_url":"https://api.github.com/users/ibuenros/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuenros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuenros/subscriptions","organizations_url":"https://api.github.com/users/ibuenros/orgs","repos_url":"https://api.github.com/users/ibuenros/repos","events_url":"https://api.github.com/users/ibuenros/events{/privacy}","received_events_url":"https://api.github.com/users/ibuenros/received_events","type":"User","site_admin":false},"body":"You want to catch `Throwable`, not exception.","created_at":"2018-06-12T16:58:41Z","updated_at":"2018-06-12T17:00:15Z","html_url":"https://github.com/apache/incubator-gobblin/pull/2383#discussion_r194815422","pull_request_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments/194815422"},"html":{"href":"https://github.com/apache/incubator-gobblin/pull/2383#discussion_r194815422"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383","id":193710554,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzEwNTU0","html_url":"https://github.com/apache/incubator-gobblin/pull/2383","diff_url":"https://github.com/apache/incubator-gobblin/pull/2383.diff","patch_url":"https://github.com/apache/incubator-gobblin/pull/2383.patch","issue_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/2383","number":2383,"state":"open","locked":false,"title":"[GOBBLIN-512]Add containers to hold unchecked exceptions from closing resources in broker","user":{"login":"autumnust","id":5044213,"node_id":"MDQ6VXNlcjUwNDQyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5044213?v=4","gravatar_id":"","url":"https://api.github.com/users/autumnust","html_url":"https://github.com/autumnust","followers_url":"https://api.github.com/users/autumnust/followers","following_url":"https://api.github.com/users/autumnust/following{/other_user}","gists_url":"https://api.github.com/users/autumnust/gists{/gist_id}","starred_url":"https://api.github.com/users/autumnust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autumnust/subscriptions","organizations_url":"https://api.github.com/users/autumnust/orgs","repos_url":"https://api.github.com/users/autumnust/repos","events_url":"https://api.github.com/users/autumnust/events{/privacy}","received_events_url":"https://api.github.com/users/autumnust/received_events","type":"User","site_admin":false},"body":"Add containers to hold unchecked exceptions from closing resources in broker, to make sure all resources are correctly handled, and log exceptions afterwards.\r\n\r\nDear Gobblin maintainers,\r\n\r\nPlease accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!\r\n\r\n\r\n### JIRA\r\n- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, \"[GOBBLIN-512] My Gobblin PR\"\r\n    - https://issues.apache.org/jira/browse/GOBBLIN-512\r\n\r\n\r\n### Description\r\n- [x] Here are some details about my PR, including screenshots (if applicable):\r\n\r\n\r\n### Tests\r\n- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\n\r\n### Commits\r\n- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n    1. Subject is separated from body by a blank line\r\n    2. Subject is limited to 50 characters\r\n    3. Subject does not end with a period\r\n    4. Subject uses the imperative mood (\"add\", not \"adding\")\r\n    5. Body wraps at 72 characters\r\n    6. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n","created_at":"2018-06-08T20:02:52Z","updated_at":"2018-06-12T17:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a76a31c3032267685cbe7277fd81c0d8d08e12f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/2383/comments","statuses_url":"https://api.github.com/repos/apache/incubator-gobblin/statuses/989cf178baae9ce392e80f99deb3137890f0e079","head":{"label":"autumnust:brokerguaranteecloseeverything","ref":"brokerguaranteecloseeverything","sha":"989cf178baae9ce392e80f99deb3137890f0e079","user":{"login":"autumnust","id":5044213,"node_id":"MDQ6VXNlcjUwNDQyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5044213?v=4","gravatar_id":"","url":"https://api.github.com/users/autumnust","html_url":"https://github.com/autumnust","followers_url":"https://api.github.com/users/autumnust/followers","following_url":"https://api.github.com/users/autumnust/following{/other_user}","gists_url":"https://api.github.com/users/autumnust/gists{/gist_id}","starred_url":"https://api.github.com/users/autumnust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autumnust/subscriptions","organizations_url":"https://api.github.com/users/autumnust/orgs","repos_url":"https://api.github.com/users/autumnust/repos","events_url":"https://api.github.com/users/autumnust/events{/privacy}","received_events_url":"https://api.github.com/users/autumnust/received_events","type":"User","site_admin":false},"repo":{"id":60211282,"node_id":"MDEwOlJlcG9zaXRvcnk2MDIxMTI4Mg==","name":"gobblin","full_name":"autumnust/gobblin","owner":{"login":"autumnust","id":5044213,"node_id":"MDQ6VXNlcjUwNDQyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5044213?v=4","gravatar_id":"","url":"https://api.github.com/users/autumnust","html_url":"https://github.com/autumnust","followers_url":"https://api.github.com/users/autumnust/followers","following_url":"https://api.github.com/users/autumnust/following{/other_user}","gists_url":"https://api.github.com/users/autumnust/gists{/gist_id}","starred_url":"https://api.github.com/users/autumnust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autumnust/subscriptions","organizations_url":"https://api.github.com/users/autumnust/orgs","repos_url":"https://api.github.com/users/autumnust/repos","events_url":"https://api.github.com/users/autumnust/events{/privacy}","received_events_url":"https://api.github.com/users/autumnust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/autumnust/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":true,"url":"https://api.github.com/repos/autumnust/gobblin","forks_url":"https://api.github.com/repos/autumnust/gobblin/forks","keys_url":"https://api.github.com/repos/autumnust/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autumnust/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autumnust/gobblin/teams","hooks_url":"https://api.github.com/repos/autumnust/gobblin/hooks","issue_events_url":"https://api.github.com/repos/autumnust/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/autumnust/gobblin/events","assignees_url":"https://api.github.com/repos/autumnust/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/autumnust/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/autumnust/gobblin/tags","blobs_url":"https://api.github.com/repos/autumnust/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autumnust/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autumnust/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/autumnust/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autumnust/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/autumnust/gobblin/languages","stargazers_url":"https://api.github.com/repos/autumnust/gobblin/stargazers","contributors_url":"https://api.github.com/repos/autumnust/gobblin/contributors","subscribers_url":"https://api.github.com/repos/autumnust/gobblin/subscribers","subscription_url":"https://api.github.com/repos/autumnust/gobblin/subscription","commits_url":"https://api.github.com/repos/autumnust/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/autumnust/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/autumnust/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/autumnust/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/autumnust/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/autumnust/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autumnust/gobblin/merges","archive_url":"https://api.github.com/repos/autumnust/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autumnust/gobblin/downloads","issues_url":"https://api.github.com/repos/autumnust/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/autumnust/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/autumnust/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/autumnust/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autumnust/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/autumnust/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/autumnust/gobblin/deployments","created_at":"2016-06-01T21:14:50Z","updated_at":"2016-06-01T21:14:55Z","pushed_at":"2018-06-08T18:58:39Z","git_url":"git://github.com/autumnust/gobblin.git","ssh_url":"git@github.com:autumnust/gobblin.git","clone_url":"https://github.com/autumnust/gobblin.git","svn_url":"https://github.com/autumnust/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":118777,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2c5e25d98fc0e6f388759cab56f52d2b375ab097","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"node_id":"MDEwOlJlcG9zaXRvcnkyNzM5MjU0Mw==","name":"incubator-gobblin","full_name":"apache/incubator-gobblin","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-gobblin","description":"Gobblin is a distributed big data integration framework (ingestion, replication, compliance, retention)  for batch and streaming systems. Gobblin features integrations with Apache Hadoop, Apache Kafka, Salesforce, S3, MySQL, Google etc.","fork":false,"url":"https://api.github.com/repos/apache/incubator-gobblin","forks_url":"https://api.github.com/repos/apache/incubator-gobblin/forks","keys_url":"https://api.github.com/repos/apache/incubator-gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-gobblin/teams","hooks_url":"https://api.github.com/repos/apache/incubator-gobblin/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-gobblin/events","assignees_url":"https://api.github.com/repos/apache/incubator-gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-gobblin/tags","blobs_url":"https://api.github.com/repos/apache/incubator-gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-gobblin/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-gobblin/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-gobblin/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-gobblin/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-gobblin/subscription","commits_url":"https://api.github.com/repos/apache/incubator-gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-gobblin/merges","archive_url":"https://api.github.com/repos/apache/incubator-gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-gobblin/downloads","issues_url":"https://api.github.com/repos/apache/incubator-gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-gobblin/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2018-06-12T11:37:14Z","pushed_at":"2018-06-12T13:53:47Z","git_url":"git://github.com/apache/incubator-gobblin.git","ssh_url":"git@github.com:apache/incubator-gobblin.git","clone_url":"https://github.com/apache/incubator-gobblin.git","svn_url":"https://github.com/apache/incubator-gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":122648,"stargazers_count":1309,"watchers_count":1309,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":511,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":511,"open_issues":32,"watchers":1309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383"},"html":{"href":"https://github.com/apache/incubator-gobblin/pull/2383"},"issue":{"href":"https://api.github.com/repos/apache/incubator-gobblin/issues/2383"},"comments":{"href":"https://api.github.com/repos/apache/incubator-gobblin/issues/2383/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2383/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-gobblin/statuses/989cf178baae9ce392e80f99deb3137890f0e079"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ibuenros"}}