{"action":"closed","number":1082,"pull_request":{"url":"https://api.github.com/repos/gpac/gpac/pulls/1082","id":193472519,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDcyNTE5","html_url":"https://github.com/gpac/gpac/pull/1082","diff_url":"https://github.com/gpac/gpac/pull/1082.diff","patch_url":"https://github.com/gpac/gpac/pull/1082.patch","issue_url":"https://api.github.com/repos/gpac/gpac/issues/1082","number":1082,"state":"closed","locked":false,"title":"Add AV1 support","user":{"login":"cconcolato","id":1830314,"node_id":"MDQ6VXNlcjE4MzAzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1830314?v=4","gravatar_id":"","url":"https://api.github.com/users/cconcolato","html_url":"https://github.com/cconcolato","followers_url":"https://api.github.com/users/cconcolato/followers","following_url":"https://api.github.com/users/cconcolato/following{/other_user}","gists_url":"https://api.github.com/users/cconcolato/gists{/gist_id}","starred_url":"https://api.github.com/users/cconcolato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cconcolato/subscriptions","organizations_url":"https://api.github.com/users/cconcolato/orgs","repos_url":"https://api.github.com/users/cconcolato/repos","events_url":"https://api.github.com/users/cconcolato/events{/privacy}","received_events_url":"https://api.github.com/users/cconcolato/received_events","type":"User","site_admin":false},"body":"Creating PR to ease the review\r\nShould NOT be merged now.\r\n\r\nTODO list (post-added by @rbouqueau):\r\n - [x] add MP4Box option to force the high level syntax parsing e.g. ```\"-add file.*:fmt=AnnexB\"```\r\n - [x] https://github.com/AOMediaCodec/av1-isobmff/pull/33/files\r\n - [x] round-tripping MP4->OBU->MP4 does not seem to work. One problem is the output file is called file.av01 but the import only takes file.av1. Another one is the missing temporal delimiters.\r\n - [x] AnnexB import should add the obu_size again when absent\r\n - [ ] write unit tests\r\n - [ ] compute presentation_delay whenever possible: https://github.com/AOMediaCodec/av1-isobmff/issues/31\r\n - [ ] implement sample_groups features + see https://github.com/gpac/gpac/pull/1082#discussion_r193924724 (most important is forward key frames)\r\n - [x] check to remove ```assert(obu_size == gf_bs_get_position(bs) - pos);``` => doesn't assert after JLF's commit\r\n - [ ] DISABLE_AV1 should disable more code\r\n - [ ] move av1 specific code in separate file\r\n - [ ] retrieve sample timings from IVF frame header, see https://github.com/gpac/gpac/pull/1082#discussion_r193921757\r\n - [ ] detect WebM (not supported in GPAC)\r\n - [ ] ```Intra-only frames SHOULD be signaled using the sample_depends_on flag set to 2.```\r\n - [x] add file extensions: *.ivf or *.obu files\r\n\r\nLast updated on GPAC side on libaom 265d15d46455ab4e208d3f9baaa840e05bd025fc (May 31st 2018).","created_at":"2018-06-07T23:19:21Z","updated_at":"2018-07-10T14:53:13Z","closed_at":"2018-07-10T14:53:12Z","merged_at":"2018-07-10T14:53:12Z","merge_commit_sha":"420b234b7773ab909c61d588b3188c5610238757","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gpac/gpac/pulls/1082/commits","review_comments_url":"https://api.github.com/repos/gpac/gpac/pulls/1082/comments","review_comment_url":"https://api.github.com/repos/gpac/gpac/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gpac/gpac/issues/1082/comments","statuses_url":"https://api.github.com/repos/gpac/gpac/statuses/7410b9b9cfe1d347fe10ce9d51e5e6a6fa325894","head":{"label":"gpac:buildbot-av1","ref":"buildbot-av1","sha":"7410b9b9cfe1d347fe10ce9d51e5e6a6fa325894","user":{"login":"gpac","id":7303020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMDMwMjA=","avatar_url":"https://avatars3.githubusercontent.com/u/7303020?v=4","gravatar_id":"","url":"https://api.github.com/users/gpac","html_url":"https://github.com/gpac","followers_url":"https://api.github.com/users/gpac/followers","following_url":"https://api.github.com/users/gpac/following{/other_user}","gists_url":"https://api.github.com/users/gpac/gists{/gist_id}","starred_url":"https://api.github.com/users/gpac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpac/subscriptions","organizations_url":"https://api.github.com/users/gpac/orgs","repos_url":"https://api.github.com/users/gpac/repos","events_url":"https://api.github.com/users/gpac/events{/privacy}","received_events_url":"https://api.github.com/users/gpac/received_events","type":"Organization","site_admin":false},"repo":{"id":19401646,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQwMTY0Ng==","name":"gpac","full_name":"gpac/gpac","owner":{"login":"gpac","id":7303020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMDMwMjA=","avatar_url":"https://avatars3.githubusercontent.com/u/7303020?v=4","gravatar_id":"","url":"https://api.github.com/users/gpac","html_url":"https://github.com/gpac","followers_url":"https://api.github.com/users/gpac/followers","following_url":"https://api.github.com/users/gpac/following{/other_user}","gists_url":"https://api.github.com/users/gpac/gists{/gist_id}","starred_url":"https://api.github.com/users/gpac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpac/subscriptions","organizations_url":"https://api.github.com/users/gpac/orgs","repos_url":"https://api.github.com/users/gpac/repos","events_url":"https://api.github.com/users/gpac/events{/privacy}","received_events_url":"https://api.github.com/users/gpac/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gpac/gpac","description":"GPAC main code repository","fork":false,"url":"https://api.github.com/repos/gpac/gpac","forks_url":"https://api.github.com/repos/gpac/gpac/forks","keys_url":"https://api.github.com/repos/gpac/gpac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpac/gpac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpac/gpac/teams","hooks_url":"https://api.github.com/repos/gpac/gpac/hooks","issue_events_url":"https://api.github.com/repos/gpac/gpac/issues/events{/number}","events_url":"https://api.github.com/repos/gpac/gpac/events","assignees_url":"https://api.github.com/repos/gpac/gpac/assignees{/user}","branches_url":"https://api.github.com/repos/gpac/gpac/branches{/branch}","tags_url":"https://api.github.com/repos/gpac/gpac/tags","blobs_url":"https://api.github.com/repos/gpac/gpac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpac/gpac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpac/gpac/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpac/gpac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpac/gpac/statuses/{sha}","languages_url":"https://api.github.com/repos/gpac/gpac/languages","stargazers_url":"https://api.github.com/repos/gpac/gpac/stargazers","contributors_url":"https://api.github.com/repos/gpac/gpac/contributors","subscribers_url":"https://api.github.com/repos/gpac/gpac/subscribers","subscription_url":"https://api.github.com/repos/gpac/gpac/subscription","commits_url":"https://api.github.com/repos/gpac/gpac/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpac/gpac/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpac/gpac/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpac/gpac/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpac/gpac/contents/{+path}","compare_url":"https://api.github.com/repos/gpac/gpac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpac/gpac/merges","archive_url":"https://api.github.com/repos/gpac/gpac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpac/gpac/downloads","issues_url":"https://api.github.com/repos/gpac/gpac/issues{/number}","pulls_url":"https://api.github.com/repos/gpac/gpac/pulls{/number}","milestones_url":"https://api.github.com/repos/gpac/gpac/milestones{/number}","notifications_url":"https://api.github.com/repos/gpac/gpac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpac/gpac/labels{/name}","releases_url":"https://api.github.com/repos/gpac/gpac/releases{/id}","deployments_url":"https://api.github.com/repos/gpac/gpac/deployments","created_at":"2014-05-03T11:29:57Z","updated_at":"2018-07-10T13:46:17Z","pushed_at":"2018-07-10T14:53:12Z","git_url":"git://github.com/gpac/gpac.git","ssh_url":"git@github.com:gpac/gpac.git","clone_url":"https://github.com/gpac/gpac.git","svn_url":"https://github.com/gpac/gpac","homepage":"http://www.gpac.io","size":89782,"stargazers_count":620,"watchers_count":620,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":212,"open_issues":219,"watchers":620,"default_branch":"master"}},"base":{"label":"gpac:master","ref":"master","sha":"61a50f4502b469d0cd4e96e7d7197c83d8361c42","user":{"login":"gpac","id":7303020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMDMwMjA=","avatar_url":"https://avatars3.githubusercontent.com/u/7303020?v=4","gravatar_id":"","url":"https://api.github.com/users/gpac","html_url":"https://github.com/gpac","followers_url":"https://api.github.com/users/gpac/followers","following_url":"https://api.github.com/users/gpac/following{/other_user}","gists_url":"https://api.github.com/users/gpac/gists{/gist_id}","starred_url":"https://api.github.com/users/gpac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpac/subscriptions","organizations_url":"https://api.github.com/users/gpac/orgs","repos_url":"https://api.github.com/users/gpac/repos","events_url":"https://api.github.com/users/gpac/events{/privacy}","received_events_url":"https://api.github.com/users/gpac/received_events","type":"Organization","site_admin":false},"repo":{"id":19401646,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQwMTY0Ng==","name":"gpac","full_name":"gpac/gpac","owner":{"login":"gpac","id":7303020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMDMwMjA=","avatar_url":"https://avatars3.githubusercontent.com/u/7303020?v=4","gravatar_id":"","url":"https://api.github.com/users/gpac","html_url":"https://github.com/gpac","followers_url":"https://api.github.com/users/gpac/followers","following_url":"https://api.github.com/users/gpac/following{/other_user}","gists_url":"https://api.github.com/users/gpac/gists{/gist_id}","starred_url":"https://api.github.com/users/gpac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpac/subscriptions","organizations_url":"https://api.github.com/users/gpac/orgs","repos_url":"https://api.github.com/users/gpac/repos","events_url":"https://api.github.com/users/gpac/events{/privacy}","received_events_url":"https://api.github.com/users/gpac/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gpac/gpac","description":"GPAC main code repository","fork":false,"url":"https://api.github.com/repos/gpac/gpac","forks_url":"https://api.github.com/repos/gpac/gpac/forks","keys_url":"https://api.github.com/repos/gpac/gpac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpac/gpac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpac/gpac/teams","hooks_url":"https://api.github.com/repos/gpac/gpac/hooks","issue_events_url":"https://api.github.com/repos/gpac/gpac/issues/events{/number}","events_url":"https://api.github.com/repos/gpac/gpac/events","assignees_url":"https://api.github.com/repos/gpac/gpac/assignees{/user}","branches_url":"https://api.github.com/repos/gpac/gpac/branches{/branch}","tags_url":"https://api.github.com/repos/gpac/gpac/tags","blobs_url":"https://api.github.com/repos/gpac/gpac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpac/gpac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpac/gpac/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpac/gpac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpac/gpac/statuses/{sha}","languages_url":"https://api.github.com/repos/gpac/gpac/languages","stargazers_url":"https://api.github.com/repos/gpac/gpac/stargazers","contributors_url":"https://api.github.com/repos/gpac/gpac/contributors","subscribers_url":"https://api.github.com/repos/gpac/gpac/subscribers","subscription_url":"https://api.github.com/repos/gpac/gpac/subscription","commits_url":"https://api.github.com/repos/gpac/gpac/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpac/gpac/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpac/gpac/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpac/gpac/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpac/gpac/contents/{+path}","compare_url":"https://api.github.com/repos/gpac/gpac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpac/gpac/merges","archive_url":"https://api.github.com/repos/gpac/gpac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpac/gpac/downloads","issues_url":"https://api.github.com/repos/gpac/gpac/issues{/number}","pulls_url":"https://api.github.com/repos/gpac/gpac/pulls{/number}","milestones_url":"https://api.github.com/repos/gpac/gpac/milestones{/number}","notifications_url":"https://api.github.com/repos/gpac/gpac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpac/gpac/labels{/name}","releases_url":"https://api.github.com/repos/gpac/gpac/releases{/id}","deployments_url":"https://api.github.com/repos/gpac/gpac/deployments","created_at":"2014-05-03T11:29:57Z","updated_at":"2018-07-10T13:46:17Z","pushed_at":"2018-07-10T14:53:12Z","git_url":"git://github.com/gpac/gpac.git","ssh_url":"git@github.com:gpac/gpac.git","clone_url":"https://github.com/gpac/gpac.git","svn_url":"https://github.com/gpac/gpac","homepage":"http://www.gpac.io","size":89782,"stargazers_count":620,"watchers_count":620,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":212,"open_issues":219,"watchers":620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gpac/gpac/pulls/1082"},"html":{"href":"https://github.com/gpac/gpac/pull/1082"},"issue":{"href":"https://api.github.com/repos/gpac/gpac/issues/1082"},"comments":{"href":"https://api.github.com/repos/gpac/gpac/issues/1082/comments"},"review_comments":{"href":"https://api.github.com/repos/gpac/gpac/pulls/1082/comments"},"review_comment":{"href":"https://api.github.com/repos/gpac/gpac/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gpac/gpac/pulls/1082/commits"},"statuses":{"href":"https://api.github.com/repos/gpac/gpac/statuses/7410b9b9cfe1d347fe10ce9d51e5e6a6fa325894"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jeanlf","id":7303785,"node_id":"MDQ6VXNlcjczMDM3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/7303785?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanlf","html_url":"https://github.com/jeanlf","followers_url":"https://api.github.com/users/jeanlf/followers","following_url":"https://api.github.com/users/jeanlf/following{/other_user}","gists_url":"https://api.github.com/users/jeanlf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanlf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanlf/subscriptions","organizations_url":"https://api.github.com/users/jeanlf/orgs","repos_url":"https://api.github.com/users/jeanlf/repos","events_url":"https://api.github.com/users/jeanlf/events{/privacy}","received_events_url":"https://api.github.com/users/jeanlf/received_events","type":"User","site_admin":false},"comments":8,"review_comments":31,"maintainer_can_modify":false,"commits":27,"additions":1658,"deletions":49,"changed_files":30}}
{"actor":{"display_login":"jeanlf"}}