{"action":"created","comment":{"url":"https://api.github.com/repos/brpc/brpc/pulls/comments/216000186","pull_request_review_id":153390759,"id":216000186,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjAwMDE4Ng==","diff_hunk":"@@ -0,0 +1,167 @@\n+# brpc Proposal\n+\n+## Abstract\n+\n+brpc is an industrial-grade RPC framework for building reliable and\n+high-performance services.\n+\n+## Proposal\n+\n+We propose to contribute the brpc codebase and associated artifacts\n+(e.g. documentation etc.) to the Apache Software Foundation, and aim to\n+ build an wider open community around it in the 'Apache Way'.\n+\n+\n+## Background\n+\n+RPC framework is very important for Baidu's development when building high performance services,\n+but the old existing ones can not fulfill our needs, so we build one from scratch in 2014,\n+and many core services inside Baidu have adopted it.\n+We named it as baidu rpc at first ,then change it as brpc for short.\n+In 2017, we open source it and hope to get more adoption, and get more contributions from outside.\n+\n+## Rationale\n+\n+brpc has been approved inside baidu, since many high performance core services are using it.\n+And since its open source, it has been adopted by several other companies , including Iqiyi, Didi, Sougou, BiliBili etc.\n+\n+## Current Status\n+\n+brpc has been an open source project on GitHub (https://github.com/brpc/brpc) since 2017.\n+\n+Currently it has more than 7.3k stars, 1.6k forks, and is one of the most popular repositories in topic of rpc category in GitHub rpc catelogy.\n+It has been widely used in Baidu, with 1,000,000+ instances and thousands kinds of services.\n+Besides, many other companies have already used it also, such as Iqiyi, Didi, Sougou, BiliBili etc.\n+\n+### Meritocracy\n+\n+brpc was originally created by Ge Jun and Chen zhangyi inside baidu from 2014.\n+Since its opensource in 2017, it already operates on meritocracy principles.\n+It accepts multiple contribute from other companies.\n+And now,the core developers are from several different companies.","path":"brpc_proposal.md","position":41,"original_position":41,"commit_id":"3d90ce790a42081259c69136e48b156204ca7155","original_commit_id":"3d90ce790a42081259c69136e48b156204ca7155","user":{"login":"zyearn","id":4475779,"node_id":"MDQ6VXNlcjQ0NzU3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4475779?v=4","gravatar_id":"","url":"https://api.github.com/users/zyearn","html_url":"https://github.com/zyearn","followers_url":"https://api.github.com/users/zyearn/followers","following_url":"https://api.github.com/users/zyearn/following{/other_user}","gists_url":"https://api.github.com/users/zyearn/gists{/gist_id}","starred_url":"https://api.github.com/users/zyearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyearn/subscriptions","organizations_url":"https://api.github.com/users/zyearn/orgs","repos_url":"https://api.github.com/users/zyearn/repos","events_url":"https://api.github.com/users/zyearn/events{/privacy}","received_events_url":"https://api.github.com/users/zyearn/received_events","type":"User","site_admin":false},"body":"逗号后面空格？","created_at":"2018-09-07T15:34:54Z","updated_at":"2018-09-07T15:43:07Z","html_url":"https://github.com/brpc/brpc/pull/487#discussion_r216000186","pull_request_url":"https://api.github.com/repos/brpc/brpc/pulls/487","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brpc/brpc/pulls/comments/216000186"},"html":{"href":"https://github.com/brpc/brpc/pull/487#discussion_r216000186"},"pull_request":{"href":"https://api.github.com/repos/brpc/brpc/pulls/487"}}},"pull_request":{"url":"https://api.github.com/repos/brpc/brpc/pulls/487","id":213892253,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODkyMjUz","html_url":"https://github.com/brpc/brpc/pull/487","diff_url":"https://github.com/brpc/brpc/pull/487.diff","patch_url":"https://github.com/brpc/brpc/pull/487.patch","issue_url":"https://api.github.com/repos/brpc/brpc/issues/487","number":487,"state":"open","locked":false,"title":"initial version for asf proposal","user":{"login":"tanzhongyibidu","id":20179982,"node_id":"MDQ6VXNlcjIwMTc5OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/20179982?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzhongyibidu","html_url":"https://github.com/tanzhongyibidu","followers_url":"https://api.github.com/users/tanzhongyibidu/followers","following_url":"https://api.github.com/users/tanzhongyibidu/following{/other_user}","gists_url":"https://api.github.com/users/tanzhongyibidu/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzhongyibidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzhongyibidu/subscriptions","organizations_url":"https://api.github.com/users/tanzhongyibidu/orgs","repos_url":"https://api.github.com/users/tanzhongyibidu/repos","events_url":"https://api.github.com/users/tanzhongyibidu/events{/privacy}","received_events_url":"https://api.github.com/users/tanzhongyibidu/received_events","type":"User","site_admin":false},"body":"please check, thanks","created_at":"2018-09-07T10:59:11Z","updated_at":"2018-09-07T15:43:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f24788614339e3fac0d5fdefc6cb0013804c6824","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brpc/brpc/pulls/487/commits","review_comments_url":"https://api.github.com/repos/brpc/brpc/pulls/487/comments","review_comment_url":"https://api.github.com/repos/brpc/brpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brpc/brpc/issues/487/comments","statuses_url":"https://api.github.com/repos/brpc/brpc/statuses/3d90ce790a42081259c69136e48b156204ca7155","head":{"label":"tanzhongyibidu:master","ref":"master","sha":"3d90ce790a42081259c69136e48b156204ca7155","user":{"login":"tanzhongyibidu","id":20179982,"node_id":"MDQ6VXNlcjIwMTc5OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/20179982?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzhongyibidu","html_url":"https://github.com/tanzhongyibidu","followers_url":"https://api.github.com/users/tanzhongyibidu/followers","following_url":"https://api.github.com/users/tanzhongyibidu/following{/other_user}","gists_url":"https://api.github.com/users/tanzhongyibidu/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzhongyibidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzhongyibidu/subscriptions","organizations_url":"https://api.github.com/users/tanzhongyibidu/orgs","repos_url":"https://api.github.com/users/tanzhongyibidu/repos","events_url":"https://api.github.com/users/tanzhongyibidu/events{/privacy}","received_events_url":"https://api.github.com/users/tanzhongyibidu/received_events","type":"User","site_admin":false},"repo":{"id":147811454,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4MTE0NTQ=","name":"brpc","full_name":"tanzhongyibidu/brpc","owner":{"login":"tanzhongyibidu","id":20179982,"node_id":"MDQ6VXNlcjIwMTc5OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/20179982?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzhongyibidu","html_url":"https://github.com/tanzhongyibidu","followers_url":"https://api.github.com/users/tanzhongyibidu/followers","following_url":"https://api.github.com/users/tanzhongyibidu/following{/other_user}","gists_url":"https://api.github.com/users/tanzhongyibidu/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzhongyibidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzhongyibidu/subscriptions","organizations_url":"https://api.github.com/users/tanzhongyibidu/orgs","repos_url":"https://api.github.com/users/tanzhongyibidu/repos","events_url":"https://api.github.com/users/tanzhongyibidu/events{/privacy}","received_events_url":"https://api.github.com/users/tanzhongyibidu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tanzhongyibidu/brpc","description":"Industrial-grade RPC framework used throughout Baidu, with 1,000,000+ instances and thousands kinds of services, called \"baidu-rpc\" inside Baidu.","fork":true,"url":"https://api.github.com/repos/tanzhongyibidu/brpc","forks_url":"https://api.github.com/repos/tanzhongyibidu/brpc/forks","keys_url":"https://api.github.com/repos/tanzhongyibidu/brpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tanzhongyibidu/brpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tanzhongyibidu/brpc/teams","hooks_url":"https://api.github.com/repos/tanzhongyibidu/brpc/hooks","issue_events_url":"https://api.github.com/repos/tanzhongyibidu/brpc/issues/events{/number}","events_url":"https://api.github.com/repos/tanzhongyibidu/brpc/events","assignees_url":"https://api.github.com/repos/tanzhongyibidu/brpc/assignees{/user}","branches_url":"https://api.github.com/repos/tanzhongyibidu/brpc/branches{/branch}","tags_url":"https://api.github.com/repos/tanzhongyibidu/brpc/tags","blobs_url":"https://api.github.com/repos/tanzhongyibidu/brpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tanzhongyibidu/brpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tanzhongyibidu/brpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/tanzhongyibidu/brpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tanzhongyibidu/brpc/statuses/{sha}","languages_url":"https://api.github.com/repos/tanzhongyibidu/brpc/languages","stargazers_url":"https://api.github.com/repos/tanzhongyibidu/brpc/stargazers","contributors_url":"https://api.github.com/repos/tanzhongyibidu/brpc/contributors","subscribers_url":"https://api.github.com/repos/tanzhongyibidu/brpc/subscribers","subscription_url":"https://api.github.com/repos/tanzhongyibidu/brpc/subscription","commits_url":"https://api.github.com/repos/tanzhongyibidu/brpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/tanzhongyibidu/brpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/tanzhongyibidu/brpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/tanzhongyibidu/brpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/tanzhongyibidu/brpc/contents/{+path}","compare_url":"https://api.github.com/repos/tanzhongyibidu/brpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tanzhongyibidu/brpc/merges","archive_url":"https://api.github.com/repos/tanzhongyibidu/brpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tanzhongyibidu/brpc/downloads","issues_url":"https://api.github.com/repos/tanzhongyibidu/brpc/issues{/number}","pulls_url":"https://api.github.com/repos/tanzhongyibidu/brpc/pulls{/number}","milestones_url":"https://api.github.com/repos/tanzhongyibidu/brpc/milestones{/number}","notifications_url":"https://api.github.com/repos/tanzhongyibidu/brpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tanzhongyibidu/brpc/labels{/name}","releases_url":"https://api.github.com/repos/tanzhongyibidu/brpc/releases{/id}","deployments_url":"https://api.github.com/repos/tanzhongyibidu/brpc/deployments","created_at":"2018-09-07T10:56:29Z","updated_at":"2018-09-07T11:48:04Z","pushed_at":"2018-09-07T11:48:03Z","git_url":"git://github.com/tanzhongyibidu/brpc.git","ssh_url":"git@github.com:tanzhongyibidu/brpc.git","clone_url":"https://github.com/tanzhongyibidu/brpc.git","svn_url":"https://github.com/tanzhongyibidu/brpc","homepage":"","size":25722,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brpc:master","ref":"master","sha":"0f621581b856f03136e29cb801ce0f555820ee8f","user":{"login":"brpc","id":31610676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjEwNjc2","avatar_url":"https://avatars2.githubusercontent.com/u/31610676?v=4","gravatar_id":"","url":"https://api.github.com/users/brpc","html_url":"https://github.com/brpc","followers_url":"https://api.github.com/users/brpc/followers","following_url":"https://api.github.com/users/brpc/following{/other_user}","gists_url":"https://api.github.com/users/brpc/gists{/gist_id}","starred_url":"https://api.github.com/users/brpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brpc/subscriptions","organizations_url":"https://api.github.com/users/brpc/orgs","repos_url":"https://api.github.com/users/brpc/repos","events_url":"https://api.github.com/users/brpc/events{/privacy}","received_events_url":"https://api.github.com/users/brpc/received_events","type":"Organization","site_admin":false},"repo":{"id":102343794,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzNDM3OTQ=","name":"brpc","full_name":"brpc/brpc","owner":{"login":"brpc","id":31610676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjEwNjc2","avatar_url":"https://avatars2.githubusercontent.com/u/31610676?v=4","gravatar_id":"","url":"https://api.github.com/users/brpc","html_url":"https://github.com/brpc","followers_url":"https://api.github.com/users/brpc/followers","following_url":"https://api.github.com/users/brpc/following{/other_user}","gists_url":"https://api.github.com/users/brpc/gists{/gist_id}","starred_url":"https://api.github.com/users/brpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brpc/subscriptions","organizations_url":"https://api.github.com/users/brpc/orgs","repos_url":"https://api.github.com/users/brpc/repos","events_url":"https://api.github.com/users/brpc/events{/privacy}","received_events_url":"https://api.github.com/users/brpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brpc/brpc","description":"Industrial-grade RPC framework used throughout Baidu, with 1,000,000+ instances and thousands kinds of services, called \"baidu-rpc\" inside Baidu.","fork":false,"url":"https://api.github.com/repos/brpc/brpc","forks_url":"https://api.github.com/repos/brpc/brpc/forks","keys_url":"https://api.github.com/repos/brpc/brpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brpc/brpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brpc/brpc/teams","hooks_url":"https://api.github.com/repos/brpc/brpc/hooks","issue_events_url":"https://api.github.com/repos/brpc/brpc/issues/events{/number}","events_url":"https://api.github.com/repos/brpc/brpc/events","assignees_url":"https://api.github.com/repos/brpc/brpc/assignees{/user}","branches_url":"https://api.github.com/repos/brpc/brpc/branches{/branch}","tags_url":"https://api.github.com/repos/brpc/brpc/tags","blobs_url":"https://api.github.com/repos/brpc/brpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brpc/brpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brpc/brpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/brpc/brpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brpc/brpc/statuses/{sha}","languages_url":"https://api.github.com/repos/brpc/brpc/languages","stargazers_url":"https://api.github.com/repos/brpc/brpc/stargazers","contributors_url":"https://api.github.com/repos/brpc/brpc/contributors","subscribers_url":"https://api.github.com/repos/brpc/brpc/subscribers","subscription_url":"https://api.github.com/repos/brpc/brpc/subscription","commits_url":"https://api.github.com/repos/brpc/brpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/brpc/brpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/brpc/brpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/brpc/brpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/brpc/brpc/contents/{+path}","compare_url":"https://api.github.com/repos/brpc/brpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brpc/brpc/merges","archive_url":"https://api.github.com/repos/brpc/brpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brpc/brpc/downloads","issues_url":"https://api.github.com/repos/brpc/brpc/issues{/number}","pulls_url":"https://api.github.com/repos/brpc/brpc/pulls{/number}","milestones_url":"https://api.github.com/repos/brpc/brpc/milestones{/number}","notifications_url":"https://api.github.com/repos/brpc/brpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brpc/brpc/labels{/name}","releases_url":"https://api.github.com/repos/brpc/brpc/releases{/id}","deployments_url":"https://api.github.com/repos/brpc/brpc/deployments","created_at":"2017-09-04T09:28:47Z","updated_at":"2018-09-07T14:11:09Z","pushed_at":"2018-09-07T11:48:03Z","git_url":"git://github.com/brpc/brpc.git","ssh_url":"git@github.com:brpc/brpc.git","clone_url":"https://github.com/brpc/brpc.git","svn_url":"https://github.com/brpc/brpc","homepage":"","size":25791,"stargazers_count":7403,"watchers_count":7403,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1677,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1677,"open_issues":74,"watchers":7403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brpc/brpc/pulls/487"},"html":{"href":"https://github.com/brpc/brpc/pull/487"},"issue":{"href":"https://api.github.com/repos/brpc/brpc/issues/487"},"comments":{"href":"https://api.github.com/repos/brpc/brpc/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/brpc/brpc/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/brpc/brpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brpc/brpc/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/brpc/brpc/statuses/3d90ce790a42081259c69136e48b156204ca7155"}},"author_association":"NONE"}}
{"actor":{"display_login":"zyearn"}}