{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/react-transition-group/issues/327","repository_url":"https://api.github.com/repos/reactjs/react-transition-group","labels_url":"https://api.github.com/repos/reactjs/react-transition-group/issues/327/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/react-transition-group/issues/327/comments","events_url":"https://api.github.com/repos/reactjs/react-transition-group/issues/327/events","html_url":"https://github.com/reactjs/react-transition-group/issues/327","id":319134336,"node_id":"MDU6SXNzdWUzMTkxMzQzMzY=","number":327,"title":"done classname for appearing","user":{"login":"koba04","id":250407,"node_id":"MDQ6VXNlcjI1MDQwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/250407?v=4","gravatar_id":"","url":"https://api.github.com/users/koba04","html_url":"https://github.com/koba04","followers_url":"https://api.github.com/users/koba04/followers","following_url":"https://api.github.com/users/koba04/following{/other_user}","gists_url":"https://api.github.com/users/koba04/gists{/gist_id}","starred_url":"https://api.github.com/users/koba04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koba04/subscriptions","organizations_url":"https://api.github.com/users/koba04/orgs","repos_url":"https://api.github.com/users/koba04/repos","events_url":"https://api.github.com/users/koba04/events{/privacy}","received_events_url":"https://api.github.com/users/koba04/received_events","type":"User","site_admin":false},"labels":[{"id":485435903,"node_id":"MDU6TGFiZWw0ODU0MzU5MDM=","url":"https://api.github.com/repos/reactjs/react-transition-group/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-01T07:15:41Z","updated_at":"2018-07-17T21:52:56Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Do you want to request a *feature* or report a *bug*?**\r\n\r\nbug?\r\n\r\n**What is the current behavior?**\r\n\r\n```\r\n    <CSSTransition in appear timeout={timeout} classNames=\"fade\">\r\n        {props.children}\r\n    </CSSTransition>\r\n```\r\n\r\nThe above case, CSSTransition applies the following classNames in the order.\r\n\r\n* `.fade-appear`\r\n* `.fade-appear.fade-appear-active`\r\n* `.fade-enter-done`\r\n\r\nIs adding `.fade-enter-done` classname to a component an expected behavior?\r\nI think it would be better the classname will be `.fade-appear-done` instead of `.fade-enter-done`.\r\n\r\n**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/m4mb9Lg3/4/).**\r\n\r\nhttps://codesandbox.io/s/7w59nmnn1x\r\n\r\n**What is the expected behavior?**\r\n\r\nA component is added `.fade-appear-done` instead of `.fade-enter-done`.\r\n\r\n**Which versions, and which browser / OS are affected by this issue? Did this work in previous versions?**\r\n"},"comment":{"url":"https://api.github.com/repos/reactjs/react-transition-group/issues/comments/405740444","html_url":"https://github.com/reactjs/react-transition-group/issues/327#issuecomment-405740444","issue_url":"https://api.github.com/repos/reactjs/react-transition-group/issues/327","id":405740444,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTc0MDQ0NA==","user":{"login":"silvenon","id":471278,"node_id":"MDQ6VXNlcjQ3MTI3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/471278?v=4","gravatar_id":"","url":"https://api.github.com/users/silvenon","html_url":"https://github.com/silvenon","followers_url":"https://api.github.com/users/silvenon/followers","following_url":"https://api.github.com/users/silvenon/following{/other_user}","gists_url":"https://api.github.com/users/silvenon/gists{/gist_id}","starred_url":"https://api.github.com/users/silvenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silvenon/subscriptions","organizations_url":"https://api.github.com/users/silvenon/orgs","repos_url":"https://api.github.com/users/silvenon/repos","events_url":"https://api.github.com/users/silvenon/events{/privacy}","received_events_url":"https://api.github.com/users/silvenon/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T21:52:56Z","updated_at":"2018-07-17T21:52:56Z","author_association":"COLLABORATOR","body":"I'll change this to `fade-appear-done`. That's going to be a breaking change for anyone who relied on this, but that's a weird behavior to rely on. 😅 "}}
{"actor":{"display_login":"silvenon"}}