{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/comments/189333928","pull_request_review_id":121499357,"id":189333928,"diff_hunk":"@@ -183,26 +183,15 @@ public void run() {\n   private void loadFrameworkVersions() {\n     Framework framework = new Framework();\n     framework.setName(CONFIG_FRAMEWORK_DEFAULT_NAME);\n-\n-    if (needSetFrameworkVersion()) {\n-      framework.setVersion(FrameworkVersions.allVersions());\n+    if(ServiceRegistryConfig.getMicroserviceFramework()) {\n+    \tframework.setVersion(FrameworkVersions.allVersions());\n     }\n     microservice.setFramework(framework);\n     microservice.setRegisterBy(CONFIG_DEFAULT_REGISTER_BY);\n   }\n \n-  private boolean needSetFrameworkVersion() {\n-    if (serviceCenterInfo == null) {\n-      LOGGER.warn(\"Server startup when service center not started and cannot retrieve version info, assume latest.\");\n-      return true;\n-    }\n-\n-    Version scVersion = VersionUtils.getOrCreate(serviceCenterInfo.getVersion());\n-    Version frameworkVersion = VersionUtils.getOrCreate(Const.SERVICECENTER_FRAMEWORK_VERSION);\n-    return scVersion.compareTo(frameworkVersion) >= 0;\n-  }\n \n-  private void loadStaticConfiguration() {\n+private void loadStaticConfiguration() {","path":"service-registry/src/main/java/org/apache/servicecomb/serviceregistry/registry/AbstractServiceRegistry.java","position":26,"original_position":26,"commit_id":"f20073505e588b0011b312ceb9ae22275ee76685","original_commit_id":"f20073505e588b0011b312ceb9ae22275ee76685","user":{"login":"wujimin","id":16874843,"avatar_url":"https://avatars2.githubusercontent.com/u/16874843?v=4","gravatar_id":"","url":"https://api.github.com/users/wujimin","html_url":"https://github.com/wujimin","followers_url":"https://api.github.com/users/wujimin/followers","following_url":"https://api.github.com/users/wujimin/following{/other_user}","gists_url":"https://api.github.com/users/wujimin/gists{/gist_id}","starred_url":"https://api.github.com/users/wujimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wujimin/subscriptions","organizations_url":"https://api.github.com/users/wujimin/orgs","repos_url":"https://api.github.com/users/wujimin/repos","events_url":"https://api.github.com/users/wujimin/events{/privacy}","received_events_url":"https://api.github.com/users/wujimin/received_events","type":"User","site_admin":false},"body":"it's difficult to write no problem code without IDE......","created_at":"2018-05-18T17:06:09Z","updated_at":"2018-05-18T17:06:09Z","html_url":"https://github.com/apache/incubator-servicecomb-java-chassis/pull/717#discussion_r189333928","pull_request_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/comments/189333928"},"html":{"href":"https://github.com/apache/incubator-servicecomb-java-chassis/pull/717#discussion_r189333928"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717"}},"in_reply_to_id":189333159},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717","id":189077023,"html_url":"https://github.com/apache/incubator-servicecomb-java-chassis/pull/717","diff_url":"https://github.com/apache/incubator-servicecomb-java-chassis/pull/717.diff","patch_url":"https://github.com/apache/incubator-servicecomb-java-chassis/pull/717.patch","issue_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/issues/717","number":717,"state":"open","locked":false,"title":"[SCB-607] Service registry failed when service before Service Center …","user":{"login":"laijianbin","id":26161527,"avatar_url":"https://avatars2.githubusercontent.com/u/26161527?v=4","gravatar_id":"","url":"https://api.github.com/users/laijianbin","html_url":"https://github.com/laijianbin","followers_url":"https://api.github.com/users/laijianbin/followers","following_url":"https://api.github.com/users/laijianbin/following{/other_user}","gists_url":"https://api.github.com/users/laijianbin/gists{/gist_id}","starred_url":"https://api.github.com/users/laijianbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laijianbin/subscriptions","organizations_url":"https://api.github.com/users/laijianbin/orgs","repos_url":"https://api.github.com/users/laijianbin/repos","events_url":"https://api.github.com/users/laijianbin/events{/privacy}","received_events_url":"https://api.github.com/users/laijianbin/received_events","type":"User","site_admin":false},"body":"…start complete\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.\r\n - [ ] Each commit in the pull request should have a meaningful subject line and body.\r\n - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.\r\n - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.\r\n - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\n---\r\n","created_at":"2018-05-18T16:33:44Z","updated_at":"2018-05-18T17:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acc5e99cf974193472d845fe8205df5804689cbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/issues/717/comments","statuses_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/statuses/f20073505e588b0011b312ceb9ae22275ee76685","head":{"label":"laijianbin:scb607","ref":"scb607","sha":"f20073505e588b0011b312ceb9ae22275ee76685","user":{"login":"laijianbin","id":26161527,"avatar_url":"https://avatars2.githubusercontent.com/u/26161527?v=4","gravatar_id":"","url":"https://api.github.com/users/laijianbin","html_url":"https://github.com/laijianbin","followers_url":"https://api.github.com/users/laijianbin/followers","following_url":"https://api.github.com/users/laijianbin/following{/other_user}","gists_url":"https://api.github.com/users/laijianbin/gists{/gist_id}","starred_url":"https://api.github.com/users/laijianbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laijianbin/subscriptions","organizations_url":"https://api.github.com/users/laijianbin/orgs","repos_url":"https://api.github.com/users/laijianbin/repos","events_url":"https://api.github.com/users/laijianbin/events{/privacy}","received_events_url":"https://api.github.com/users/laijianbin/received_events","type":"User","site_admin":false},"repo":{"id":133832494,"name":"incubator-servicecomb-java-chassis","full_name":"laijianbin/incubator-servicecomb-java-chassis","owner":{"login":"laijianbin","id":26161527,"avatar_url":"https://avatars2.githubusercontent.com/u/26161527?v=4","gravatar_id":"","url":"https://api.github.com/users/laijianbin","html_url":"https://github.com/laijianbin","followers_url":"https://api.github.com/users/laijianbin/followers","following_url":"https://api.github.com/users/laijianbin/following{/other_user}","gists_url":"https://api.github.com/users/laijianbin/gists{/gist_id}","starred_url":"https://api.github.com/users/laijianbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laijianbin/subscriptions","organizations_url":"https://api.github.com/users/laijianbin/orgs","repos_url":"https://api.github.com/users/laijianbin/repos","events_url":"https://api.github.com/users/laijianbin/events{/privacy}","received_events_url":"https://api.github.com/users/laijianbin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laijianbin/incubator-servicecomb-java-chassis","description":"ServiceComb Java Chassis is a Software Development Kit (SDK) for rapid development of microservices in Java, providing service registration, service discovery, dynamic routing, and service management features","fork":true,"url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis","forks_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/forks","keys_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/teams","hooks_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/hooks","issue_events_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/issues/events{/number}","events_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/events","assignees_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/assignees{/user}","branches_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/branches{/branch}","tags_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/tags","blobs_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/git/refs{/sha}","trees_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/statuses/{sha}","languages_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/languages","stargazers_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/stargazers","contributors_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/contributors","subscribers_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/subscribers","subscription_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/subscription","commits_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/commits{/sha}","git_commits_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/git/commits{/sha}","comments_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/comments{/number}","issue_comment_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/issues/comments{/number}","contents_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/contents/{+path}","compare_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/merges","archive_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/downloads","issues_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/issues{/number}","pulls_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/pulls{/number}","milestones_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/milestones{/number}","notifications_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/labels{/name}","releases_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/releases{/id}","deployments_url":"https://api.github.com/repos/laijianbin/incubator-servicecomb-java-chassis/deployments","created_at":"2018-05-17T15:22:53Z","updated_at":"2018-05-17T15:22:59Z","pushed_at":"2018-05-18T17:00:12Z","git_url":"git://github.com/laijianbin/incubator-servicecomb-java-chassis.git","ssh_url":"git@github.com:laijianbin/incubator-servicecomb-java-chassis.git","clone_url":"https://github.com/laijianbin/incubator-servicecomb-java-chassis.git","svn_url":"https://github.com/laijianbin/incubator-servicecomb-java-chassis","homepage":null,"size":11000,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bb8c7ffc4eb069c2118941291acf1ed884a56b83","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":91674936,"name":"incubator-servicecomb-java-chassis","full_name":"apache/incubator-servicecomb-java-chassis","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-servicecomb-java-chassis","description":"ServiceComb Java Chassis is a Software Development Kit (SDK) for rapid development of microservices in Java, providing service registration, service discovery, dynamic routing, and service management features","fork":false,"url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis","forks_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/forks","keys_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/teams","hooks_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/events","assignees_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/tags","blobs_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/subscription","commits_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/merges","archive_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/downloads","issues_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/deployments","created_at":"2017-05-18T09:29:30Z","updated_at":"2018-05-18T08:03:31Z","pushed_at":"2018-05-18T17:00:13Z","git_url":"git://github.com/apache/incubator-servicecomb-java-chassis.git","ssh_url":"git@github.com:apache/incubator-servicecomb-java-chassis.git","clone_url":"https://github.com/apache/incubator-servicecomb-java-chassis.git","svn_url":"https://github.com/apache/incubator-servicecomb-java-chassis","homepage":null,"size":11055,"stargazers_count":455,"watchers_count":455,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":257,"open_issues":48,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717"},"html":{"href":"https://github.com/apache/incubator-servicecomb-java-chassis/pull/717"},"issue":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/issues/717"},"comments":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/issues/717/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/pulls/717/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-servicecomb-java-chassis/statuses/f20073505e588b0011b312ceb9ae22275ee76685"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wujimin"}}