{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/190228049","pull_request_review_id":122561620,"id":190228049,"diff_hunk":"@@ -54,9 +54,11 @@ func TestImagesListRunWithCustomConfigPath(t *testing.T) {\n \t\tconfigContents          []byte\n \t}{\n \t\t{\n-\t\t\tname:               \"empty config contents\",\n+\t\t\tname:               \"empty config contents with only k8s version\",\n \t\t\texpectedImageCount: defaultNumberOfImages,\n-\t\t\tconfigContents:     []byte{},\n+\t\t\tconfigContents: []byte(dedent.Dedent(`\n+\t\t\t\tkubernetesVersion: 1.10.1","path":"cmd/kubeadm/app/cmd/config_test.go","position":9,"original_position":9,"commit_id":"d01b27e8b9465bbcf3373297475ac20e57ee7dc3","original_commit_id":"d01b27e8b9465bbcf3373297475ac20e57ee7dc3","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"Yes, please add TypeMeta content and add the v prefix and I'm good","created_at":"2018-05-23T12:35:14Z","updated_at":"2018-05-23T12:35:18Z","html_url":"https://github.com/kubernetes/kubernetes/pull/63919#discussion_r190228049","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/190228049"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63919#discussion_r190228049"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919"}},"in_reply_to_id":190206333},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919","id":188424137,"html_url":"https://github.com/kubernetes/kubernetes/pull/63919","diff_url":"https://github.com/kubernetes/kubernetes/pull/63919.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63919.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63919","number":63919,"state":"open","locked":false,"title":"kubeadm: Use the release-1.11 branch by default","user":{"login":"dixudx","id":5449021,"avatar_url":"https://avatars3.githubusercontent.com/u/5449021?v=4","gravatar_id":"","url":"https://api.github.com/users/dixudx","html_url":"https://github.com/dixudx","followers_url":"https://api.github.com/users/dixudx/followers","following_url":"https://api.github.com/users/dixudx/following{/other_user}","gists_url":"https://api.github.com/users/dixudx/gists{/gist_id}","starred_url":"https://api.github.com/users/dixudx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dixudx/subscriptions","organizations_url":"https://api.github.com/users/dixudx/orgs","repos_url":"https://api.github.com/users/dixudx/repos","events_url":"https://api.github.com/users/dixudx/events{/privacy}","received_events_url":"https://api.github.com/users/dixudx/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes kubernetes/kubeadm#820\r\n\r\n**Special notes for your reviewer**:\r\n/cc luxas \r\n/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/kubernetes-release-managers\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nkubeadm: Use the release-1.11 branch by default\r\n```\r\n","created_at":"2018-05-16T12:59:35Z","updated_at":"2018-05-23T12:35:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a9328c20a81ff2804b99a92b382f21f443dfc04","assignee":{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"assignees":[{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":451459590,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":114528223,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173494222,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false},{"id":611767149,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":118,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-05-23T11:53:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63919/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d01b27e8b9465bbcf3373297475ac20e57ee7dc3","head":{"label":"dixudx:kubeadm_bump_stable_v111","ref":"kubeadm_bump_stable_v111","sha":"d01b27e8b9465bbcf3373297475ac20e57ee7dc3","user":{"login":"dixudx","id":5449021,"avatar_url":"https://avatars3.githubusercontent.com/u/5449021?v=4","gravatar_id":"","url":"https://api.github.com/users/dixudx","html_url":"https://github.com/dixudx","followers_url":"https://api.github.com/users/dixudx/followers","following_url":"https://api.github.com/users/dixudx/following{/other_user}","gists_url":"https://api.github.com/users/dixudx/gists{/gist_id}","starred_url":"https://api.github.com/users/dixudx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dixudx/subscriptions","organizations_url":"https://api.github.com/users/dixudx/orgs","repos_url":"https://api.github.com/users/dixudx/repos","events_url":"https://api.github.com/users/dixudx/events{/privacy}","received_events_url":"https://api.github.com/users/dixudx/received_events","type":"User","site_admin":false},"repo":{"id":71526854,"name":"kubernetes","full_name":"dixudx/kubernetes","owner":{"login":"dixudx","id":5449021,"avatar_url":"https://avatars3.githubusercontent.com/u/5449021?v=4","gravatar_id":"","url":"https://api.github.com/users/dixudx","html_url":"https://github.com/dixudx","followers_url":"https://api.github.com/users/dixudx/followers","following_url":"https://api.github.com/users/dixudx/following{/other_user}","gists_url":"https://api.github.com/users/dixudx/gists{/gist_id}","starred_url":"https://api.github.com/users/dixudx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dixudx/subscriptions","organizations_url":"https://api.github.com/users/dixudx/orgs","repos_url":"https://api.github.com/users/dixudx/repos","events_url":"https://api.github.com/users/dixudx/events{/privacy}","received_events_url":"https://api.github.com/users/dixudx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dixudx/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/dixudx/kubernetes","forks_url":"https://api.github.com/repos/dixudx/kubernetes/forks","keys_url":"https://api.github.com/repos/dixudx/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dixudx/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dixudx/kubernetes/teams","hooks_url":"https://api.github.com/repos/dixudx/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dixudx/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dixudx/kubernetes/events","assignees_url":"https://api.github.com/repos/dixudx/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dixudx/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dixudx/kubernetes/tags","blobs_url":"https://api.github.com/repos/dixudx/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dixudx/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dixudx/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dixudx/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dixudx/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dixudx/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dixudx/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dixudx/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dixudx/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dixudx/kubernetes/subscription","commits_url":"https://api.github.com/repos/dixudx/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dixudx/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dixudx/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dixudx/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dixudx/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dixudx/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dixudx/kubernetes/merges","archive_url":"https://api.github.com/repos/dixudx/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dixudx/kubernetes/downloads","issues_url":"https://api.github.com/repos/dixudx/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dixudx/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dixudx/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dixudx/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dixudx/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dixudx/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dixudx/kubernetes/deployments","created_at":"2016-10-21T03:36:19Z","updated_at":"2018-05-21T01:55:18Z","pushed_at":"2018-05-23T08:24:43Z","git_url":"git://github.com/dixudx/kubernetes.git","ssh_url":"git@github.com:dixudx/kubernetes.git","clone_url":"https://github.com/dixudx/kubernetes.git","svn_url":"https://github.com/dixudx/kubernetes","homepage":"http://kubernetes.io","size":553997,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"23d9a48e6a59bc3e4faa84a7cf1416853521e60c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-05-23T11:58:07Z","pushed_at":"2018-05-23T12:22:55Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":779993,"stargazers_count":36670,"watchers_count":36670,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12896,"mirror_url":null,"archived":false,"open_issues_count":3247,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12896,"open_issues":3247,"watchers":36670,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63919"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63919"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63919/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63919/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d01b27e8b9465bbcf3373297475ac20e57ee7dc3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"luxas"}}