{"action":"created","comment":{"url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/comments/183249351","pull_request_review_id":114213190,"id":183249351,"diff_hunk":"@@ -14,6 +14,19 @@ extern frame_info frame_info;\n \n extern particle_manager *particle_man;\n \n+static bool\n+filter_matches_message(comms_msg const &msg, wire_filter_ptr const &filter) {\n+    auto &cwire_man = component_system_man.managers.wire_comms_component_man;\n+    auto sender = cwire_man.get_instance_data(msg.originator);\n+\n+    /* If we have no filter defined, we match everything. */\n+    if (!filter.wrapped)\n+        return true;\n+\n+    /* We have a filter. Sender must have a filter, and it must match. */","path":"src/component/component_system_manager.cc","position":13,"original_position":13,"commit_id":"347294c689cd227fe8fa4aca7987dcc8a907cfb3","original_commit_id":"17a580e27717041ca2bae399dabc3c8b0cc7c3cd","user":{"login":"chrisforbes","id":128877,"avatar_url":"https://avatars1.githubusercontent.com/u/128877?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisforbes","html_url":"https://github.com/chrisforbes","followers_url":"https://api.github.com/users/chrisforbes/followers","following_url":"https://api.github.com/users/chrisforbes/following{/other_user}","gists_url":"https://api.github.com/users/chrisforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisforbes/subscriptions","organizations_url":"https://api.github.com/users/chrisforbes/orgs","repos_url":"https://api.github.com/users/chrisforbes/repos","events_url":"https://api.github.com/users/chrisforbes/events{/privacy}","received_events_url":"https://api.github.com/users/chrisforbes/received_events","type":"User","site_admin":false},"body":"If filter requires a label, then yes.","created_at":"2018-04-22T20:05:01Z","updated_at":"2018-04-22T20:05:01Z","html_url":"https://github.com/engineers-nightmare/engineers-nightmare/pull/597#discussion_r183249351","pull_request_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/comments/183249351"},"html":{"href":"https://github.com/engineers-nightmare/engineers-nightmare/pull/597#discussion_r183249351"},"pull_request":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597"}},"in_reply_to_id":183249268},"pull_request":{"url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597","id":183289077,"html_url":"https://github.com/engineers-nightmare/engineers-nightmare/pull/597","diff_url":"https://github.com/engineers-nightmare/engineers-nightmare/pull/597.diff","patch_url":"https://github.com/engineers-nightmare/engineers-nightmare/pull/597.patch","issue_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/597","number":597,"state":"open","locked":false,"title":"Filter helper","user":{"login":"chrisforbes","id":128877,"avatar_url":"https://avatars1.githubusercontent.com/u/128877?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisforbes","html_url":"https://github.com/chrisforbes","followers_url":"https://api.github.com/users/chrisforbes/followers","following_url":"https://api.github.com/users/chrisforbes/following{/other_user}","gists_url":"https://api.github.com/users/chrisforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisforbes/subscriptions","organizations_url":"https://api.github.com/users/chrisforbes/orgs","repos_url":"https://api.github.com/users/chrisforbes/repos","events_url":"https://api.github.com/users/chrisforbes/events{/privacy}","received_events_url":"https://api.github.com/users/chrisforbes/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-22T19:14:18Z","updated_at":"2018-04-22T20:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c7baf2d31f3266f02506b4ecc1137d9d91dac71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597/commits","review_comments_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597/comments","review_comment_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/comments{/number}","comments_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/597/comments","statuses_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/statuses/347294c689cd227fe8fa4aca7987dcc8a907cfb3","head":{"label":"engineers-nightmare:filter-helper","ref":"filter-helper","sha":"347294c689cd227fe8fa4aca7987dcc8a907cfb3","user":{"login":"engineers-nightmare","id":11154186,"avatar_url":"https://avatars1.githubusercontent.com/u/11154186?v=4","gravatar_id":"","url":"https://api.github.com/users/engineers-nightmare","html_url":"https://github.com/engineers-nightmare","followers_url":"https://api.github.com/users/engineers-nightmare/followers","following_url":"https://api.github.com/users/engineers-nightmare/following{/other_user}","gists_url":"https://api.github.com/users/engineers-nightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/engineers-nightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engineers-nightmare/subscriptions","organizations_url":"https://api.github.com/users/engineers-nightmare/orgs","repos_url":"https://api.github.com/users/engineers-nightmare/repos","events_url":"https://api.github.com/users/engineers-nightmare/events{/privacy}","received_events_url":"https://api.github.com/users/engineers-nightmare/received_events","type":"Organization","site_admin":false},"repo":{"id":31193367,"name":"engineers-nightmare","full_name":"engineers-nightmare/engineers-nightmare","owner":{"login":"engineers-nightmare","id":11154186,"avatar_url":"https://avatars1.githubusercontent.com/u/11154186?v=4","gravatar_id":"","url":"https://api.github.com/users/engineers-nightmare","html_url":"https://github.com/engineers-nightmare","followers_url":"https://api.github.com/users/engineers-nightmare/followers","following_url":"https://api.github.com/users/engineers-nightmare/following{/other_user}","gists_url":"https://api.github.com/users/engineers-nightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/engineers-nightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engineers-nightmare/subscriptions","organizations_url":"https://api.github.com/users/engineers-nightmare/orgs","repos_url":"https://api.github.com/users/engineers-nightmare/repos","events_url":"https://api.github.com/users/engineers-nightmare/events{/privacy}","received_events_url":"https://api.github.com/users/engineers-nightmare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/engineers-nightmare/engineers-nightmare","description":"A game about keeping a spaceship from falling apart","fork":false,"url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare","forks_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/forks","keys_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/teams","hooks_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/hooks","issue_events_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/events{/number}","events_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/events","assignees_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/assignees{/user}","branches_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/branches{/branch}","tags_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/tags","blobs_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/refs{/sha}","trees_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/statuses/{sha}","languages_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/languages","stargazers_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/stargazers","contributors_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/contributors","subscribers_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/subscribers","subscription_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/subscription","commits_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/commits{/sha}","git_commits_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/commits{/sha}","comments_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/comments{/number}","issue_comment_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/comments{/number}","contents_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/contents/{+path}","compare_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/merges","archive_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/downloads","issues_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues{/number}","pulls_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls{/number}","milestones_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/milestones{/number}","notifications_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/labels{/name}","releases_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/releases{/id}","deployments_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/deployments","created_at":"2015-02-23T04:01:31Z","updated_at":"2018-04-22T19:20:01Z","pushed_at":"2018-04-22T20:00:44Z","git_url":"git://github.com/engineers-nightmare/engineers-nightmare.git","ssh_url":"git@github.com:engineers-nightmare/engineers-nightmare.git","clone_url":"https://github.com/engineers-nightmare/engineers-nightmare.git","svn_url":"https://github.com/engineers-nightmare/engineers-nightmare","homepage":null,"size":8060,"stargazers_count":38,"watchers_count":38,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":10,"open_issues":76,"watchers":38,"default_branch":"master"}},"base":{"label":"engineers-nightmare:master","ref":"master","sha":"da341ed3047f93de0a42cec2567b929d303475bd","user":{"login":"engineers-nightmare","id":11154186,"avatar_url":"https://avatars1.githubusercontent.com/u/11154186?v=4","gravatar_id":"","url":"https://api.github.com/users/engineers-nightmare","html_url":"https://github.com/engineers-nightmare","followers_url":"https://api.github.com/users/engineers-nightmare/followers","following_url":"https://api.github.com/users/engineers-nightmare/following{/other_user}","gists_url":"https://api.github.com/users/engineers-nightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/engineers-nightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engineers-nightmare/subscriptions","organizations_url":"https://api.github.com/users/engineers-nightmare/orgs","repos_url":"https://api.github.com/users/engineers-nightmare/repos","events_url":"https://api.github.com/users/engineers-nightmare/events{/privacy}","received_events_url":"https://api.github.com/users/engineers-nightmare/received_events","type":"Organization","site_admin":false},"repo":{"id":31193367,"name":"engineers-nightmare","full_name":"engineers-nightmare/engineers-nightmare","owner":{"login":"engineers-nightmare","id":11154186,"avatar_url":"https://avatars1.githubusercontent.com/u/11154186?v=4","gravatar_id":"","url":"https://api.github.com/users/engineers-nightmare","html_url":"https://github.com/engineers-nightmare","followers_url":"https://api.github.com/users/engineers-nightmare/followers","following_url":"https://api.github.com/users/engineers-nightmare/following{/other_user}","gists_url":"https://api.github.com/users/engineers-nightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/engineers-nightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engineers-nightmare/subscriptions","organizations_url":"https://api.github.com/users/engineers-nightmare/orgs","repos_url":"https://api.github.com/users/engineers-nightmare/repos","events_url":"https://api.github.com/users/engineers-nightmare/events{/privacy}","received_events_url":"https://api.github.com/users/engineers-nightmare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/engineers-nightmare/engineers-nightmare","description":"A game about keeping a spaceship from falling apart","fork":false,"url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare","forks_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/forks","keys_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/teams","hooks_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/hooks","issue_events_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/events{/number}","events_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/events","assignees_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/assignees{/user}","branches_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/branches{/branch}","tags_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/tags","blobs_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/refs{/sha}","trees_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/statuses/{sha}","languages_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/languages","stargazers_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/stargazers","contributors_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/contributors","subscribers_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/subscribers","subscription_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/subscription","commits_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/commits{/sha}","git_commits_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/git/commits{/sha}","comments_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/comments{/number}","issue_comment_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/comments{/number}","contents_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/contents/{+path}","compare_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/merges","archive_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/downloads","issues_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues{/number}","pulls_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls{/number}","milestones_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/milestones{/number}","notifications_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/labels{/name}","releases_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/releases{/id}","deployments_url":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/deployments","created_at":"2015-02-23T04:01:31Z","updated_at":"2018-04-22T19:20:01Z","pushed_at":"2018-04-22T20:00:44Z","git_url":"git://github.com/engineers-nightmare/engineers-nightmare.git","ssh_url":"git@github.com:engineers-nightmare/engineers-nightmare.git","clone_url":"https://github.com/engineers-nightmare/engineers-nightmare.git","svn_url":"https://github.com/engineers-nightmare/engineers-nightmare","homepage":null,"size":8060,"stargazers_count":38,"watchers_count":38,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":10,"open_issues":76,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597"},"html":{"href":"https://github.com/engineers-nightmare/engineers-nightmare/pull/597"},"issue":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/597"},"comments":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/issues/597/comments"},"review_comments":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597/comments"},"review_comment":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/pulls/597/commits"},"statuses":{"href":"https://api.github.com/repos/engineers-nightmare/engineers-nightmare/statuses/347294c689cd227fe8fa4aca7987dcc8a907cfb3"}},"author_association":"OWNER"}}
{"actor":{"display_login":"chrisforbes"}}