{"action":"created","comment":{"url":"https://api.github.com/repos/opnsense/plugins/pulls/comments/241981384","pull_request_review_id":185388422,"id":241981384,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk4MTM4NA==","diff_hunk":"@@ -0,0 +1,60 @@\n+var fs = require('fs');\n+var tls_fingerprints = JSON.parse(fs.readFileSync('tls_fingerprints.json'));\n+\n+function customArrayIndexOf(haystack, needle) {\n+  var element, element_id;\n+  for (element_id in haystack) {\n+    element = haystack[element_id];\n+    if (element == needle) return element_id;\n+  }\n+  return -1;\n+}","path":"www/nginx/src/opnsense/scripts/nginx/ngx_functions.js","position":11,"original_position":11,"commit_id":"78118d9604788f63086d80ffb3e19565336bbd4c","original_commit_id":"e1a00fef3901d514c7058524bf7657b9def641f7","user":{"login":"fabianfrz","id":3713914,"node_id":"MDQ6VXNlcjM3MTM5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3713914?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianfrz","html_url":"https://github.com/fabianfrz","followers_url":"https://api.github.com/users/fabianfrz/followers","following_url":"https://api.github.com/users/fabianfrz/following{/other_user}","gists_url":"https://api.github.com/users/fabianfrz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianfrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianfrz/subscriptions","organizations_url":"https://api.github.com/users/fabianfrz/orgs","repos_url":"https://api.github.com/users/fabianfrz/repos","events_url":"https://api.github.com/users/fabianfrz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianfrz/received_events","type":"User","site_admin":false},"body":"@VBart tested against nginx/njs@36f12955c906d35282c32222b99c7861a6f805f2 and it works. Do you already know a release date?\r\n\r\nBTW: thanks for spending your time on this.","created_at":"2018-12-16T13:50:29Z","updated_at":"2018-12-16T13:50:29Z","html_url":"https://github.com/opnsense/plugins/pull/1070#discussion_r241981384","pull_request_url":"https://api.github.com/repos/opnsense/plugins/pulls/1070","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/comments/241981384"},"html":{"href":"https://github.com/opnsense/plugins/pull/1070#discussion_r241981384"},"pull_request":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/1070"}},"in_reply_to_id":241950413},"pull_request":{"url":"https://api.github.com/repos/opnsense/plugins/pulls/1070","id":238913163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTEzMTYz","html_url":"https://github.com/opnsense/plugins/pull/1070","diff_url":"https://github.com/opnsense/plugins/pull/1070.diff","patch_url":"https://github.com/opnsense/plugins/pull/1070.patch","issue_url":"https://api.github.com/repos/opnsense/plugins/issues/1070","number":1070,"state":"open","locked":false,"title":"WIP: www/nginx: add njs script to detect MitM attacks on TLS connections","user":{"login":"fabianfrz","id":3713914,"node_id":"MDQ6VXNlcjM3MTM5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3713914?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianfrz","html_url":"https://github.com/fabianfrz","followers_url":"https://api.github.com/users/fabianfrz/followers","following_url":"https://api.github.com/users/fabianfrz/following{/other_user}","gists_url":"https://api.github.com/users/fabianfrz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianfrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianfrz/subscriptions","organizations_url":"https://api.github.com/users/fabianfrz/orgs","repos_url":"https://api.github.com/users/fabianfrz/repos","events_url":"https://api.github.com/users/fabianfrz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianfrz/received_events","type":"User","site_admin":false},"body":"allow the plugin to detect a MitM before us.  See: #1044. This pull request should make the feature available to nginx when done.","created_at":"2018-12-15T14:00:09Z","updated_at":"2018-12-16T13:50:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c50e455a73270a7d93dff0a2fb28dae91ed7d4d","assignee":{"login":"fabianfrz","id":3713914,"node_id":"MDQ6VXNlcjM3MTM5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3713914?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianfrz","html_url":"https://github.com/fabianfrz","followers_url":"https://api.github.com/users/fabianfrz/followers","following_url":"https://api.github.com/users/fabianfrz/following{/other_user}","gists_url":"https://api.github.com/users/fabianfrz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianfrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianfrz/subscriptions","organizations_url":"https://api.github.com/users/fabianfrz/orgs","repos_url":"https://api.github.com/users/fabianfrz/repos","events_url":"https://api.github.com/users/fabianfrz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianfrz/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabianfrz","id":3713914,"node_id":"MDQ6VXNlcjM3MTM5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3713914?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianfrz","html_url":"https://github.com/fabianfrz","followers_url":"https://api.github.com/users/fabianfrz/followers","following_url":"https://api.github.com/users/fabianfrz/following{/other_user}","gists_url":"https://api.github.com/users/fabianfrz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianfrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianfrz/subscriptions","organizations_url":"https://api.github.com/users/fabianfrz/orgs","repos_url":"https://api.github.com/users/fabianfrz/repos","events_url":"https://api.github.com/users/fabianfrz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianfrz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":234308543,"node_id":"MDU6TGFiZWwyMzQzMDg1NDM=","url":"https://api.github.com/repos/opnsense/plugins/labels/feature","name":"feature","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opnsense/plugins/pulls/1070/commits","review_comments_url":"https://api.github.com/repos/opnsense/plugins/pulls/1070/comments","review_comment_url":"https://api.github.com/repos/opnsense/plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opnsense/plugins/issues/1070/comments","statuses_url":"https://api.github.com/repos/opnsense/plugins/statuses/78118d9604788f63086d80ffb3e19565336bbd4c","head":{"label":"opnsense:ngx_mitm_detection","ref":"ngx_mitm_detection","sha":"78118d9604788f63086d80ffb3e19565336bbd4c","user":{"login":"opnsense","id":9979117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzkxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"repo":{"id":38818223,"node_id":"MDEwOlJlcG9zaXRvcnkzODgxODIyMw==","name":"plugins","full_name":"opnsense/plugins","private":false,"owner":{"login":"opnsense","id":9979117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzkxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opnsense/plugins","description":"OPNsense plugin collection","fork":false,"url":"https://api.github.com/repos/opnsense/plugins","forks_url":"https://api.github.com/repos/opnsense/plugins/forks","keys_url":"https://api.github.com/repos/opnsense/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opnsense/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opnsense/plugins/teams","hooks_url":"https://api.github.com/repos/opnsense/plugins/hooks","issue_events_url":"https://api.github.com/repos/opnsense/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/opnsense/plugins/events","assignees_url":"https://api.github.com/repos/opnsense/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/opnsense/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/opnsense/plugins/tags","blobs_url":"https://api.github.com/repos/opnsense/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opnsense/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opnsense/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/opnsense/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opnsense/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/opnsense/plugins/languages","stargazers_url":"https://api.github.com/repos/opnsense/plugins/stargazers","contributors_url":"https://api.github.com/repos/opnsense/plugins/contributors","subscribers_url":"https://api.github.com/repos/opnsense/plugins/subscribers","subscription_url":"https://api.github.com/repos/opnsense/plugins/subscription","commits_url":"https://api.github.com/repos/opnsense/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/opnsense/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/opnsense/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/opnsense/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/opnsense/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/opnsense/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opnsense/plugins/merges","archive_url":"https://api.github.com/repos/opnsense/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opnsense/plugins/downloads","issues_url":"https://api.github.com/repos/opnsense/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/opnsense/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/opnsense/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/opnsense/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opnsense/plugins/labels{/name}","releases_url":"https://api.github.com/repos/opnsense/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/opnsense/plugins/deployments","created_at":"2015-07-09T12:13:51Z","updated_at":"2018-12-16T08:38:45Z","pushed_at":"2018-12-16T08:38:42Z","git_url":"git://github.com/opnsense/plugins.git","ssh_url":"git@github.com:opnsense/plugins.git","clone_url":"https://github.com/opnsense/plugins.git","svn_url":"https://github.com/opnsense/plugins","homepage":"https://opnsense.org/","size":6262,"stargazers_count":261,"watchers_count":261,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":129,"open_issues":105,"watchers":261,"default_branch":"master"}},"base":{"label":"opnsense:master","ref":"master","sha":"8b602203c1cde907b2a9564a44a4f018d6204703","user":{"login":"opnsense","id":9979117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzkxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"repo":{"id":38818223,"node_id":"MDEwOlJlcG9zaXRvcnkzODgxODIyMw==","name":"plugins","full_name":"opnsense/plugins","private":false,"owner":{"login":"opnsense","id":9979117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzkxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opnsense/plugins","description":"OPNsense plugin collection","fork":false,"url":"https://api.github.com/repos/opnsense/plugins","forks_url":"https://api.github.com/repos/opnsense/plugins/forks","keys_url":"https://api.github.com/repos/opnsense/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opnsense/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opnsense/plugins/teams","hooks_url":"https://api.github.com/repos/opnsense/plugins/hooks","issue_events_url":"https://api.github.com/repos/opnsense/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/opnsense/plugins/events","assignees_url":"https://api.github.com/repos/opnsense/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/opnsense/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/opnsense/plugins/tags","blobs_url":"https://api.github.com/repos/opnsense/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opnsense/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opnsense/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/opnsense/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opnsense/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/opnsense/plugins/languages","stargazers_url":"https://api.github.com/repos/opnsense/plugins/stargazers","contributors_url":"https://api.github.com/repos/opnsense/plugins/contributors","subscribers_url":"https://api.github.com/repos/opnsense/plugins/subscribers","subscription_url":"https://api.github.com/repos/opnsense/plugins/subscription","commits_url":"https://api.github.com/repos/opnsense/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/opnsense/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/opnsense/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/opnsense/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/opnsense/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/opnsense/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opnsense/plugins/merges","archive_url":"https://api.github.com/repos/opnsense/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opnsense/plugins/downloads","issues_url":"https://api.github.com/repos/opnsense/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/opnsense/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/opnsense/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/opnsense/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opnsense/plugins/labels{/name}","releases_url":"https://api.github.com/repos/opnsense/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/opnsense/plugins/deployments","created_at":"2015-07-09T12:13:51Z","updated_at":"2018-12-16T08:38:45Z","pushed_at":"2018-12-16T08:38:42Z","git_url":"git://github.com/opnsense/plugins.git","ssh_url":"git@github.com:opnsense/plugins.git","clone_url":"https://github.com/opnsense/plugins.git","svn_url":"https://github.com/opnsense/plugins","homepage":"https://opnsense.org/","size":6262,"stargazers_count":261,"watchers_count":261,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":129,"open_issues":105,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/1070"},"html":{"href":"https://github.com/opnsense/plugins/pull/1070"},"issue":{"href":"https://api.github.com/repos/opnsense/plugins/issues/1070"},"comments":{"href":"https://api.github.com/repos/opnsense/plugins/issues/1070/comments"},"review_comments":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/1070/comments"},"review_comment":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/1070/commits"},"statuses":{"href":"https://api.github.com/repos/opnsense/plugins/statuses/78118d9604788f63086d80ffb3e19565336bbd4c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fabianfrz"}}