{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/181710426","pull_request_review_id":112384846,"id":181710426,"diff_hunk":"@@ -842,3 +843,51 @@ def test_if_ar_sets_correct_useragent_while_resolving_via_mesosdns(\n \n         assert len(r_reqs) == 1\n         verify_header(r_reqs[0]['headers'], 'User-Agent', 'Master Admin Router')\n+\n+    @pytest.mark.parametrize(","path":"packages/adminrouter/extra/src/test-harness/tests/test_service.py","position":13,"original_position":13,"commit_id":"a9a995f9793e56bd5dfba0e25ae73cafef1b4ab7","original_commit_id":"d77a233405289fafc5b154872375567ea66e77a6","user":{"login":"vespian","id":2124609,"avatar_url":"https://avatars3.githubusercontent.com/u/2124609?v=4","gravatar_id":"","url":"https://api.github.com/users/vespian","html_url":"https://github.com/vespian","followers_url":"https://api.github.com/users/vespian/followers","following_url":"https://api.github.com/users/vespian/following{/other_user}","gists_url":"https://api.github.com/users/vespian/gists{/gist_id}","starred_url":"https://api.github.com/users/vespian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespian/subscriptions","organizations_url":"https://api.github.com/users/vespian/orgs","repos_url":"https://api.github.com/users/vespian/repos","events_url":"https://api.github.com/users/vespian/events{/privacy}","received_events_url":"https://api.github.com/users/vespian/received_events","type":"User","site_admin":false},"body":"We ended up with not implementing it due to https://github.com/pytest-dev/pytest/issues/916. It prevents using pytest fixtures without some extra hacking :(\r\n\r\nIn overall, I find Hypothesis to be a nice tool. Once the issue is fixed I would like to try to implement test case like these using it.","created_at":"2018-04-16T12:06:43Z","updated_at":"2018-04-16T12:06:43Z","html_url":"https://github.com/dcos/dcos/pull/2714#discussion_r181710426","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/2714","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/181710426"},"html":{"href":"https://github.com/dcos/dcos/pull/2714#discussion_r181710426"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2714"}},"in_reply_to_id":180146551},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/2714","id":180019051,"html_url":"https://github.com/dcos/dcos/pull/2714","diff_url":"https://github.com/dcos/dcos/pull/2714.diff","patch_url":"https://github.com/dcos/dcos/pull/2714.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/2714","number":2714,"state":"open","locked":false,"title":"Admin Router: /service endpoint url rewriting is now configurable using the Marathon label","user":{"login":"vespian","id":2124609,"avatar_url":"https://avatars3.githubusercontent.com/u/2124609?v=4","gravatar_id":"","url":"https://api.github.com/users/vespian","html_url":"https://github.com/vespian","followers_url":"https://api.github.com/users/vespian/followers","following_url":"https://api.github.com/users/vespian/following{/other_user}","gists_url":"https://api.github.com/users/vespian/gists{/gist_id}","starred_url":"https://api.github.com/users/vespian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespian/subscriptions","organizations_url":"https://api.github.com/users/vespian/orgs","repos_url":"https://api.github.com/users/vespian/repos","events_url":"https://api.github.com/users/vespian/events{/privacy}","received_events_url":"https://api.github.com/users/vespian/received_events","type":"User","site_admin":false},"body":"## High-level description\r\n\r\nThis PR makes it possible to configure `/service` endpoint upstream request URL rewriting basing on the `DCOS_SERVICE_REWRITE_REQUEST_URLS` label. See the Jira issue for details.\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\n\r\n  - https://jira.mesosphere.com/browse/DCOS-9032 `Adminrouter option to not rewrite URLs`\r\n\r\n## Related PRs\r\n\r\nEE PR: https://github.com/mesosphere/dcos-enterprise/pull/2570","created_at":"2018-04-06T18:17:32Z","updated_at":"2018-04-16T12:06:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47e65f38d8a424c3efbe8e49e43441a07e8b6f73","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":364878184,"url":"https://api.github.com/repos/dcos/dcos/labels/Ready%20For%20Review","name":"Ready For Review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/2714/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/2714/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/2714/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/a9a995f9793e56bd5dfba0e25ae73cafef1b4ab7","head":{"label":"mesosphere:prozlach/master/DCOS-9032_option_to_not_to_rewrite_service_upstream","ref":"prozlach/master/DCOS-9032_option_to_not_to_rewrite_service_upstream","sha":"a9a995f9793e56bd5dfba0e25ae73cafef1b4ab7","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":62745648,"name":"dcos","full_name":"mesosphere/dcos","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/mesosphere/dcos","forks_url":"https://api.github.com/repos/mesosphere/dcos/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos/deployments","created_at":"2016-07-06T18:52:22Z","updated_at":"2018-04-10T19:52:54Z","pushed_at":"2018-04-16T11:39:43Z","git_url":"git://github.com/mesosphere/dcos.git","ssh_url":"git@github.com:mesosphere/dcos.git","clone_url":"https://github.com/mesosphere/dcos.git","svn_url":"https://github.com/mesosphere/dcos","homepage":"https://dcos.io","size":8621,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":0,"watchers":22,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"16ced28a63284de75096e17fa953af08905cd91d","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS - The Datacenter Operating System ","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2018-04-16T12:03:37Z","pushed_at":"2018-04-16T11:39:44Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":6052,"stargazers_count":1937,"watchers_count":1937,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":388,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":388,"open_issues":112,"watchers":1937,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2714"},"html":{"href":"https://github.com/dcos/dcos/pull/2714"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/2714"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/2714/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2714/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2714/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/a9a995f9793e56bd5dfba0e25ae73cafef1b4ab7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vespian"}}