{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/222118126","pull_request_review_id":160931026,"id":222118126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjExODEyNg==","diff_hunk":"@@ -370,6 +370,8 @@ public void persistSubscriberState(String topic, String messageId) {\n   public static void setupDatasets(DatasetFramework datasetFramework) throws IOException,\n     DatasetManagementException {\n     datasetFramework.addInstance(JobQueueDataset.class.getName(), Schedulers.JOB_QUEUE_DATASET_ID,\n-                                 DatasetProperties.EMPTY);\n+                                 DatasetProperties.builder().\n+                                   add(Constants.Scheduler.JOB_QUEUE_NUM_PARTITIONS, DEFAULT_NUM_PARTITIONS)","path":"cdap-app-fabric/src/main/java/co/cask/cdap/internal/app/runtime/schedule/queue/JobQueueDataset.java","position":6,"original_position":6,"commit_id":"bc043f80d3e47395767e3aeb37fd5a4c1bdbec40","original_commit_id":"bc043f80d3e47395767e3aeb37fd5a4c1bdbec40","user":{"login":"CuriousVini","id":14131070,"node_id":"MDQ6VXNlcjE0MTMxMDcw","avatar_url":"https://avatars0.githubusercontent.com/u/14131070?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousVini","html_url":"https://github.com/CuriousVini","followers_url":"https://api.github.com/users/CuriousVini/followers","following_url":"https://api.github.com/users/CuriousVini/following{/other_user}","gists_url":"https://api.github.com/users/CuriousVini/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousVini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousVini/subscriptions","organizations_url":"https://api.github.com/users/CuriousVini/orgs","repos_url":"https://api.github.com/users/CuriousVini/repos","events_url":"https://api.github.com/users/CuriousVini/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousVini/received_events","type":"User","site_admin":false},"body":"Its because https://github.com/caskdata/cdap/blob/release/5.1/cdap-app-fabric/src/main/java/co/cask/cdap/internal/app/runtime/schedule/queue/JobQueueDatasetDefinition.java#L48-L50 - expects it to be present","created_at":"2018-10-02T21:27:18Z","updated_at":"2018-10-02T21:27:19Z","html_url":"https://github.com/caskdata/cdap/pull/10760#discussion_r222118126","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/10760","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/222118126"},"html":{"href":"https://github.com/caskdata/cdap/pull/10760#discussion_r222118126"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10760"}},"in_reply_to_id":222116442},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/10760","id":219808099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODA4MDk5","html_url":"https://github.com/caskdata/cdap/pull/10760","diff_url":"https://github.com/caskdata/cdap/pull/10760.diff","patch_url":"https://github.com/caskdata/cdap/pull/10760.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/10760","number":10760,"state":"open","locked":false,"title":"CDAP-14314 fix upgrade tool","user":{"login":"CuriousVini","id":14131070,"node_id":"MDQ6VXNlcjE0MTMxMDcw","avatar_url":"https://avatars0.githubusercontent.com/u/14131070?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousVini","html_url":"https://github.com/CuriousVini","followers_url":"https://api.github.com/users/CuriousVini/followers","following_url":"https://api.github.com/users/CuriousVini/following{/other_user}","gists_url":"https://api.github.com/users/CuriousVini/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousVini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousVini/subscriptions","organizations_url":"https://api.github.com/users/CuriousVini/orgs","repos_url":"https://api.github.com/users/CuriousVini/repos","events_url":"https://api.github.com/users/CuriousVini/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousVini/received_events","type":"User","site_admin":false},"body":"Build: https://builds.cask.co/browse/CDAP-RUT1626-1\r\n\r\n![image](https://user-images.githubusercontent.com/14131070/46370094-903aac80-c639-11e8-8048-43bf7176cee5.png)\r\n","created_at":"2018-10-02T18:52:09Z","updated_at":"2018-10-02T21:27:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48d7d989b68ce2cc2be6a114bac9ef9ad24ac9e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1006442829,"node_id":"MDU6TGFiZWwxMDA2NDQyODI5","url":"https://api.github.com/repos/caskdata/cdap/labels/5.1","name":"5.1","color":"4fd6d3","default":false},{"id":118957809,"node_id":"MDU6TGFiZWwxMTg5NTc4MDk=","url":"https://api.github.com/repos/caskdata/cdap/labels/Bug","name":"Bug","color":"fc2929","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/10760/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/10760/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/10760/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/bc043f80d3e47395767e3aeb37fd5a4c1bdbec40","head":{"label":"caskdata:bugfix_release/CDAP-14314-upgrade","ref":"bugfix_release/CDAP-14314-upgrade","sha":"bc043f80d3e47395767e3aeb37fd5a4c1bdbec40","user":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"caskdata/cdap","private":false,"owner":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/caskdata/cdap","description":"An open source framework for building data analytic applications.","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-10-02T20:42:50Z","pushed_at":"2018-10-02T20:42:47Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"https://docs.cdap.io","size":550754,"stargazers_count":264,"watchers_count":264,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":133,"open_issues":6,"watchers":264,"default_branch":"release/5.1"}},"base":{"label":"caskdata:release/5.1","ref":"release/5.1","sha":"0805091f0a89d6eb69a59e92014c6e5780f6bf6b","user":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"caskdata/cdap","private":false,"owner":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/caskdata/cdap","description":"An open source framework for building data analytic applications.","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-10-02T20:42:50Z","pushed_at":"2018-10-02T20:42:47Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"https://docs.cdap.io","size":550754,"stargazers_count":264,"watchers_count":264,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":133,"open_issues":6,"watchers":264,"default_branch":"release/5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10760"},"html":{"href":"https://github.com/caskdata/cdap/pull/10760"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/10760"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/10760/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10760/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10760/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/bc043f80d3e47395767e3aeb37fd5a4c1bdbec40"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CuriousVini"}}