{"action":"created","issue":{"url":"https://api.github.com/repos/batfish/batfish/issues/1387","repository_url":"https://api.github.com/repos/batfish/batfish","labels_url":"https://api.github.com/repos/batfish/batfish/issues/1387/labels{/name}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/1387/comments","events_url":"https://api.github.com/repos/batfish/batfish/issues/1387/events","html_url":"https://github.com/batfish/batfish/pull/1387","id":323017409,"number":1387,"title":"Prune ACL reachability jobs to find blocking lines","user":{"login":"corinaminer","id":24902209,"avatar_url":"https://avatars2.githubusercontent.com/u/24902209?v=4","gravatar_id":"","url":"https://api.github.com/users/corinaminer","html_url":"https://github.com/corinaminer","followers_url":"https://api.github.com/users/corinaminer/followers","following_url":"https://api.github.com/users/corinaminer/following{/other_user}","gists_url":"https://api.github.com/users/corinaminer/gists{/gist_id}","starred_url":"https://api.github.com/users/corinaminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corinaminer/subscriptions","organizations_url":"https://api.github.com/users/corinaminer/orgs","repos_url":"https://api.github.com/users/corinaminer/repos","events_url":"https://api.github.com/users/corinaminer/events{/privacy}","received_events_url":"https://api.github.com/users/corinaminer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-14T23:36:05Z","updated_at":"2018-05-14T23:41:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/1387","html_url":"https://github.com/batfish/batfish/pull/1387","diff_url":"https://github.com/batfish/batfish/pull/1387.diff","patch_url":"https://github.com/batfish/batfish/pull/1387.patch"},"body":"Moves method `optimizedProgram()` from `NodJob` to its grandparent `Z3ContextJob` so that `NodJob`'s aunt/uncle (auncle?) `NodFirstUnsatJob` can also make use of it."},"comment":{"url":"https://api.github.com/repos/batfish/batfish/issues/comments/388996679","html_url":"https://github.com/batfish/batfish/pull/1387#issuecomment-388996679","issue_url":"https://api.github.com/repos/batfish/batfish/issues/1387","id":388996679,"user":{"login":"corinaminer","id":24902209,"avatar_url":"https://avatars2.githubusercontent.com/u/24902209?v=4","gravatar_id":"","url":"https://api.github.com/users/corinaminer","html_url":"https://github.com/corinaminer","followers_url":"https://api.github.com/users/corinaminer/followers","following_url":"https://api.github.com/users/corinaminer/following{/other_user}","gists_url":"https://api.github.com/users/corinaminer/gists{/gist_id}","starred_url":"https://api.github.com/users/corinaminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corinaminer/subscriptions","organizations_url":"https://api.github.com/users/corinaminer/orgs","repos_url":"https://api.github.com/users/corinaminer/repos","events_url":"https://api.github.com/users/corinaminer/events{/privacy}","received_events_url":"https://api.github.com/users/corinaminer/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T23:41:43Z","updated_at":"2018-05-14T23:41:43Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[projects/batfish/src/main/java/org/batfish/z3/NodFirstUnsatJob.java, line 72 at r1](https://reviewable.io/reviews/batfish/batfish/1387#-LCW0Gcl-WzvA7zPO56-:-LCW0pUf-R9Ub45fzENF:b-sb0i0t) ([raw file](https://github.com/batfish/batfish/blob/4e79cf7f2fbc39a144782d314784c2ae1f0693aa/projects/batfish/src/main/java/org/batfish/z3/NodFirstUnsatJob.java#L72)):*\n<details><summary><i>Previously, arifogel (Ari Fogel) wrote…</i></summary><blockquote>\n\nCould this function also be moved up to an ancestor class? Looks like the code that uses it in `NodJob` is identical.\n</blockquote></details>\n\nonly the return statement is identical. I considered raising some abstracted version of this function to an ancestor class, but didn't seem worth it.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/batfish/batfish/1387)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"corinaminer"}}