{"action":"created","issue":{"url":"https://api.github.com/repos/heptio/contour/issues/70","repository_url":"https://api.github.com/repos/heptio/contour","labels_url":"https://api.github.com/repos/heptio/contour/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/heptio/contour/issues/70/comments","events_url":"https://api.github.com/repos/heptio/contour/issues/70/events","html_url":"https://github.com/heptio/contour/issues/70","id":277250627,"number":70,"title":"Support adding / removing headers","user":{"login":"davecheney","id":7171,"avatar_url":"https://avatars0.githubusercontent.com/u/7171?v=4","gravatar_id":"","url":"https://api.github.com/users/davecheney","html_url":"https://github.com/davecheney","followers_url":"https://api.github.com/users/davecheney/followers","following_url":"https://api.github.com/users/davecheney/following{/other_user}","gists_url":"https://api.github.com/users/davecheney/gists{/gist_id}","starred_url":"https://api.github.com/users/davecheney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecheney/subscriptions","organizations_url":"https://api.github.com/users/davecheney/orgs","repos_url":"https://api.github.com/users/davecheney/repos","events_url":"https://api.github.com/users/davecheney/events{/privacy}","received_events_url":"https://api.github.com/users/davecheney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-28T03:57:06Z","updated_at":"2018-05-08T23:38:36Z","closed_at":null,"author_association":"OWNER","body":"Add support for adding / removing headers at the Ingress, namespace, and default level"},"comment":{"url":"https://api.github.com/repos/heptio/contour/issues/comments/387575336","html_url":"https://github.com/heptio/contour/issues/70#issuecomment-387575336","issue_url":"https://api.github.com/repos/heptio/contour/issues/70","id":387575336,"user":{"login":"davecheney","id":7171,"avatar_url":"https://avatars0.githubusercontent.com/u/7171?v=4","gravatar_id":"","url":"https://api.github.com/users/davecheney","html_url":"https://github.com/davecheney","followers_url":"https://api.github.com/users/davecheney/followers","following_url":"https://api.github.com/users/davecheney/following{/other_user}","gists_url":"https://api.github.com/users/davecheney/gists{/gist_id}","starred_url":"https://api.github.com/users/davecheney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecheney/subscriptions","organizations_url":"https://api.github.com/users/davecheney/orgs","repos_url":"https://api.github.com/users/davecheney/repos","events_url":"https://api.github.com/users/davecheney/events{/privacy}","received_events_url":"https://api.github.com/users/davecheney/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T23:38:35Z","updated_at":"2018-05-08T23:38:35Z","author_association":"OWNER","body":"Thanks for offering to work on this. My initial reaction to the annotation syntax is it’s pretty ugly, yaml embedded in annotations is quite verbose and not something people are going to get right first time. \n\nOne way around this might be to encode the header name in the annotation key, ie\n\ncontour.heptio.com/add-header-max-age: “...”\n\nWhere add-header- is a known prefix and there is a form for converting the suffix into a http header. This should work as http headers are not case sensitive. \n\nThe other question is should this be per ingress or per route. I can see an argument for per route. \n\n> On 9 May 2018, at 09:19, David Robinson <notifications@github.com> wrote:\n> \n> I'm interested in implementing ingress level support. Is this annotation format acceptable?\n> \n> apiVersion: extensions/v1beta1\n> kind: Ingress\n> metadata:\n>   name: example\n>   annotations:\n>     contour.heptio.com/response-headers-to-add: |\n>       Strict-Transport-Security \"max-age=31536000; includeSubDomains\"\n>       Public-Key-Pins: max-age=2592000; pin-sha256=\"E9CZ9INDbd+2eRQozYqqbQ2yXLVKB9+xcprMF+44U1g=\"\n>     contour.heptio.com/response-headers-to-remove: |\n>       X-Powered-By\n> spec:\n>   ...\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"davecheney"}}