{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/15033","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/15033/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/15033/comments","events_url":"https://api.github.com/repos/apple/swift/issues/15033/events","html_url":"https://github.com/apple/swift/pull/15033","id":302936359,"number":15033,"title":"Fill in the field-offset vector and payload size for fixed-layout value metadata","user":{"login":"rjmccall","id":793869,"avatar_url":"https://avatars1.githubusercontent.com/u/793869?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmccall","html_url":"https://github.com/rjmccall","followers_url":"https://api.github.com/users/rjmccall/followers","following_url":"https://api.github.com/users/rjmccall/following{/other_user}","gists_url":"https://api.github.com/users/rjmccall/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmccall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmccall/subscriptions","organizations_url":"https://api.github.com/users/rjmccall/orgs","repos_url":"https://api.github.com/users/rjmccall/repos","events_url":"https://api.github.com/users/rjmccall/events{/privacy}","received_events_url":"https://api.github.com/users/rjmccall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-07T01:57:50Z","updated_at":"2018-03-07T06:23:31Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/15033","html_url":"https://github.com/apple/swift/pull/15033","diff_url":"https://github.com/apple/swift/pull/15033.diff","patch_url":"https://github.com/apple/swift/pull/15033.patch"},"body":"This regression wasn't caught by normal code-generation pattern testing because the emission pattern substantially changed anyway, breaking tests that were looking for the field-offset vector, and because normal execution testing doesn't actually use the field-offset vector and enum payload size fields.\r\n\r\nReflection, which does use these fields, was skating by for common types because metadata is typically allocated out of freshly zeroed pages and most such types have only one field.  But that doesn't always happen, so there was a non-determinstic failure that caught it.\r\n\r\nAlso, don't emit a completion function for value metadata with fixed layout.\r\n\r\nWe really shouldn't have to emit field-offset vectors for fixed-layout types; the layout should just go in the type descriptor.  But for now, this is what we have to do."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/371036277","html_url":"https://github.com/apple/swift/pull/15033#issuecomment-371036277","issue_url":"https://api.github.com/repos/apple/swift/issues/15033","id":371036277,"user":{"login":"rjmccall","id":793869,"avatar_url":"https://avatars1.githubusercontent.com/u/793869?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmccall","html_url":"https://github.com/rjmccall","followers_url":"https://api.github.com/users/rjmccall/followers","following_url":"https://api.github.com/users/rjmccall/following{/other_user}","gists_url":"https://api.github.com/users/rjmccall/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmccall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmccall/subscriptions","organizations_url":"https://api.github.com/users/rjmccall/orgs","repos_url":"https://api.github.com/users/rjmccall/repos","events_url":"https://api.github.com/users/rjmccall/events{/privacy}","received_events_url":"https://api.github.com/users/rjmccall/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T06:23:31Z","updated_at":"2018-03-07T06:23:31Z","author_association":"MEMBER","body":"@swift-ci Please test and merge."}}
{"actor":{"display_login":"rjmccall"}}