{"action":"created","comment":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/comments/191187197","pull_request_review_id":123711474,"id":191187197,"diff_hunk":"@@ -4538,25 +4531,15 @@ static void free_sslproxy_cert_adapt(sslproxy_cert_adapt **cert_adapt)\n static void parse_sslproxy_cert_sign(sslproxy_cert_sign **cert_sign)\n {\n     char *al;\n-    sslproxy_cert_sign *cs = (sslproxy_cert_sign *) xcalloc(1, sizeof(sslproxy_cert_sign));\n     if ((al = ConfigParser::NextToken()) == NULL) {\n-        xfree(cs);\n         self_destruct();\n         return;\n     }\n \n-    if (strcmp(al, Ssl::CertSignAlgorithmStr[Ssl::algSignTrusted]) == 0)\n-        cs->alg = Ssl::algSignTrusted;\n-    else if (strcmp(al, Ssl::CertSignAlgorithmStr[Ssl::algSignUntrusted]) == 0)\n-        cs->alg = Ssl::algSignUntrusted;\n-    else if (strcmp(al, Ssl::CertSignAlgorithmStr[Ssl::algSignSelf]) == 0)\n-        cs->alg = Ssl::algSignSelf;\n-    else {\n-        debugs(3, DBG_CRITICAL, \"FATAL: sslproxy_cert_sign: unknown cert signing algorithm: \" << al);\n-        xfree(cs);\n-        self_destruct();\n-        return;\n-    }\n+    const auto algName = Security::certSignAlgorithmId(al); // throws on errors\n+","path":"src/cache_cf.cc","position":81,"original_position":81,"commit_id":"79b36e080ad3a61d063ed3139a087ae481fdfd0d","original_commit_id":"da2246b3d456914059ac5f3554cac300fd75b3e0","user":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-28T11:51:50Z","updated_at":"2018-05-28T11:51:50Z","html_url":"https://github.com/squid-cache/squid/pull/139#discussion_r191187197","pull_request_url":"https://api.github.com/repos/squid-cache/squid/pulls/139","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments/191187197"},"html":{"href":"https://github.com/squid-cache/squid/pull/139#discussion_r191187197"},"pull_request":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/139"}},"in_reply_to_id":169865988},"pull_request":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/139","id":166509102,"html_url":"https://github.com/squid-cache/squid/pull/139","diff_url":"https://github.com/squid-cache/squid/pull/139.diff","patch_url":"https://github.com/squid-cache/squid/pull/139.patch","issue_url":"https://api.github.com/repos/squid-cache/squid/issues/139","number":139,"state":"open","locked":false,"title":"TLS: move CertificateProperties to libsecurity","user":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"These pieces are required by certificate generation / mimic.\r\n\r\nConvert the enum type strings to auto-generated arrays instead\r\nof requiring manual work to keep in-sync.","created_at":"2018-02-01T11:18:56Z","updated_at":"2018-05-28T11:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf42420a1c736779cf44e50f267d90af60c55bd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":666339686,"url":"https://api.github.com/repos/squid-cache/squid/labels/S-waiting-for-author","name":"S-waiting-for-author","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/squid-cache/squid/pulls/139/commits","review_comments_url":"https://api.github.com/repos/squid-cache/squid/pulls/139/comments","review_comment_url":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squid-cache/squid/issues/139/comments","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/79b36e080ad3a61d063ed3139a087ae481fdfd0d","head":{"label":"yadij:tls-extras","ref":"tls-extras","sha":"79b36e080ad3a61d063ed3139a087ae481fdfd0d","user":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"repo":{"id":97826891,"name":"squid","full_name":"yadij/squid","owner":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yadij/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/yadij/squid","forks_url":"https://api.github.com/repos/yadij/squid/forks","keys_url":"https://api.github.com/repos/yadij/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yadij/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yadij/squid/teams","hooks_url":"https://api.github.com/repos/yadij/squid/hooks","issue_events_url":"https://api.github.com/repos/yadij/squid/issues/events{/number}","events_url":"https://api.github.com/repos/yadij/squid/events","assignees_url":"https://api.github.com/repos/yadij/squid/assignees{/user}","branches_url":"https://api.github.com/repos/yadij/squid/branches{/branch}","tags_url":"https://api.github.com/repos/yadij/squid/tags","blobs_url":"https://api.github.com/repos/yadij/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yadij/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yadij/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/yadij/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yadij/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/yadij/squid/languages","stargazers_url":"https://api.github.com/repos/yadij/squid/stargazers","contributors_url":"https://api.github.com/repos/yadij/squid/contributors","subscribers_url":"https://api.github.com/repos/yadij/squid/subscribers","subscription_url":"https://api.github.com/repos/yadij/squid/subscription","commits_url":"https://api.github.com/repos/yadij/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/yadij/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/yadij/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/yadij/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/yadij/squid/contents/{+path}","compare_url":"https://api.github.com/repos/yadij/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yadij/squid/merges","archive_url":"https://api.github.com/repos/yadij/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yadij/squid/downloads","issues_url":"https://api.github.com/repos/yadij/squid/issues{/number}","pulls_url":"https://api.github.com/repos/yadij/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/yadij/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/yadij/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yadij/squid/labels{/name}","releases_url":"https://api.github.com/repos/yadij/squid/releases{/id}","deployments_url":"https://api.github.com/repos/yadij/squid/deployments","created_at":"2017-07-20T11:20:53Z","updated_at":"2018-05-25T16:49:30Z","pushed_at":"2018-05-25T16:49:52Z","git_url":"git://github.com/yadij/squid.git","ssh_url":"git@github.com:yadij/squid.git","clone_url":"https://github.com/yadij/squid.git","svn_url":"https://github.com/yadij/squid","homepage":"http://www.squid-cache.org/","size":136180,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"squid-cache:master","ref":"master","sha":"a2a12dec1b0ff07da483ed8fb4ec3092946d751a","user":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":24519987,"name":"squid","full_name":"squid-cache/squid","owner":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squid-cache/squid","description":"Squid Web Proxy Cache","fork":false,"url":"https://api.github.com/repos/squid-cache/squid","forks_url":"https://api.github.com/repos/squid-cache/squid/forks","keys_url":"https://api.github.com/repos/squid-cache/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squid-cache/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squid-cache/squid/teams","hooks_url":"https://api.github.com/repos/squid-cache/squid/hooks","issue_events_url":"https://api.github.com/repos/squid-cache/squid/issues/events{/number}","events_url":"https://api.github.com/repos/squid-cache/squid/events","assignees_url":"https://api.github.com/repos/squid-cache/squid/assignees{/user}","branches_url":"https://api.github.com/repos/squid-cache/squid/branches{/branch}","tags_url":"https://api.github.com/repos/squid-cache/squid/tags","blobs_url":"https://api.github.com/repos/squid-cache/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squid-cache/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squid-cache/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/squid-cache/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/squid-cache/squid/languages","stargazers_url":"https://api.github.com/repos/squid-cache/squid/stargazers","contributors_url":"https://api.github.com/repos/squid-cache/squid/contributors","subscribers_url":"https://api.github.com/repos/squid-cache/squid/subscribers","subscription_url":"https://api.github.com/repos/squid-cache/squid/subscription","commits_url":"https://api.github.com/repos/squid-cache/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/squid-cache/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/squid-cache/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/squid-cache/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/squid-cache/squid/contents/{+path}","compare_url":"https://api.github.com/repos/squid-cache/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squid-cache/squid/merges","archive_url":"https://api.github.com/repos/squid-cache/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squid-cache/squid/downloads","issues_url":"https://api.github.com/repos/squid-cache/squid/issues{/number}","pulls_url":"https://api.github.com/repos/squid-cache/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/squid-cache/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/squid-cache/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squid-cache/squid/labels{/name}","releases_url":"https://api.github.com/repos/squid-cache/squid/releases{/id}","deployments_url":"https://api.github.com/repos/squid-cache/squid/deployments","created_at":"2014-09-27T00:59:40Z","updated_at":"2018-05-28T09:28:18Z","pushed_at":"2018-05-25T19:45:53Z","git_url":"git://github.com/squid-cache/squid.git","ssh_url":"git@github.com:squid-cache/squid.git","clone_url":"https://github.com/squid-cache/squid.git","svn_url":"https://github.com/squid-cache/squid","homepage":"http://www.squid-cache.org/","size":161184,"stargazers_count":340,"watchers_count":340,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":136,"open_issues":21,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/139"},"html":{"href":"https://github.com/squid-cache/squid/pull/139"},"issue":{"href":"https://api.github.com/repos/squid-cache/squid/issues/139"},"comments":{"href":"https://api.github.com/repos/squid-cache/squid/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/squid-cache/squid/statuses/79b36e080ad3a61d063ed3139a087ae481fdfd0d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yadij"}}