{"action":"created","issue":{"url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram/issues/24","repository_url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram","labels_url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram/issues/24/comments","events_url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram/issues/24/events","html_url":"https://github.com/wojtekmaj/react-lifecycle-methods-diagram/issues/24","id":373439944,"node_id":"MDU6SXNzdWUzNzM0Mzk5NDQ=","number":24,"title":"componentWillUnmount and refs to null?","user":{"login":"Ciantic","id":64731,"node_id":"MDQ6VXNlcjY0NzMx","avatar_url":"https://avatars2.githubusercontent.com/u/64731?v=4","gravatar_id":"","url":"https://api.github.com/users/Ciantic","html_url":"https://github.com/Ciantic","followers_url":"https://api.github.com/users/Ciantic/followers","following_url":"https://api.github.com/users/Ciantic/following{/other_user}","gists_url":"https://api.github.com/users/Ciantic/gists{/gist_id}","starred_url":"https://api.github.com/users/Ciantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ciantic/subscriptions","organizations_url":"https://api.github.com/users/Ciantic/orgs","repos_url":"https://api.github.com/users/Ciantic/repos","events_url":"https://api.github.com/users/Ciantic/events{/privacy}","received_events_url":"https://api.github.com/users/Ciantic/received_events","type":"User","site_admin":false},"labels":[{"id":891497295,"node_id":"MDU6TGFiZWw4OTE0OTcyOTU=","url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"wojtekmaj","id":5426427,"node_id":"MDQ6VXNlcjU0MjY0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5426427?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmaj","html_url":"https://github.com/wojtekmaj","followers_url":"https://api.github.com/users/wojtekmaj/followers","following_url":"https://api.github.com/users/wojtekmaj/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmaj/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmaj/subscriptions","organizations_url":"https://api.github.com/users/wojtekmaj/orgs","repos_url":"https://api.github.com/users/wojtekmaj/repos","events_url":"https://api.github.com/users/wojtekmaj/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"wojtekmaj","id":5426427,"node_id":"MDQ6VXNlcjU0MjY0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5426427?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmaj","html_url":"https://github.com/wojtekmaj","followers_url":"https://api.github.com/users/wojtekmaj/followers","following_url":"https://api.github.com/users/wojtekmaj/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmaj/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmaj/subscriptions","organizations_url":"https://api.github.com/users/wojtekmaj/orgs","repos_url":"https://api.github.com/users/wojtekmaj/repos","events_url":"https://api.github.com/users/wojtekmaj/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmaj/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-24T11:42:51Z","updated_at":"2018-10-24T13:50:39Z","closed_at":null,"author_association":"NONE","body":"I started to wonder, does React set all the refs to null before it calls componentWillUnmount or after?\r\n\r\nHowever the diagram does not tell? Which one is it?\r\n\r\n![image](https://user-images.githubusercontent.com/64731/47428115-f7f89900-d79a-11e8-8575-159b63184199.png)\r\n"},"comment":{"url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram/issues/comments/432664639","html_url":"https://github.com/wojtekmaj/react-lifecycle-methods-diagram/issues/24#issuecomment-432664639","issue_url":"https://api.github.com/repos/wojtekmaj/react-lifecycle-methods-diagram/issues/24","id":432664639,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjY2NDYzOQ==","user":{"login":"Ciantic","id":64731,"node_id":"MDQ6VXNlcjY0NzMx","avatar_url":"https://avatars2.githubusercontent.com/u/64731?v=4","gravatar_id":"","url":"https://api.github.com/users/Ciantic","html_url":"https://github.com/Ciantic","followers_url":"https://api.github.com/users/Ciantic/followers","following_url":"https://api.github.com/users/Ciantic/following{/other_user}","gists_url":"https://api.github.com/users/Ciantic/gists{/gist_id}","starred_url":"https://api.github.com/users/Ciantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ciantic/subscriptions","organizations_url":"https://api.github.com/users/Ciantic/orgs","repos_url":"https://api.github.com/users/Ciantic/repos","events_url":"https://api.github.com/users/Ciantic/events{/privacy}","received_events_url":"https://api.github.com/users/Ciantic/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T13:50:39Z","updated_at":"2018-10-24T13:50:39Z","author_association":"NONE","body":"I think during unmount it updates the DOM after the componentWillUnmount. Because it's called \"will\". \r\n\r\nSo maybe it needs a new block \"React updates refs to null\" before componentWillUnmount and another new block \"React updates DOM\" after componentWillUnmount"}}
{"actor":{"display_login":"Ciantic"}}