{"action":"created","comment":{"url":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/comments/174195828","pull_request_review_id":103507111,"id":174195828,"diff_hunk":"@@ -2,15 +2,19 @@\n \n (function() {\n \n-    if (!window.OpenSeadragon) {\n-        console.error('[openseadragon-svg-overlay] requires OpenSeadragon');\n-        return;\n+    $ = window.OpenSeadragon;\n+    \n+    if (!$) {\n+    $ = require('openseadragon');","path":"openseadragon-svg-overlay.js","position":10,"original_position":10,"commit_id":"e7bfc6725b15ff5cfa7788f01a877964e9480baf","original_commit_id":"e7bfc6725b15ff5cfa7788f01a877964e9480baf","user":{"login":"iangilman","id":338989,"avatar_url":"https://avatars3.githubusercontent.com/u/338989?v=4","gravatar_id":"","url":"https://api.github.com/users/iangilman","html_url":"https://github.com/iangilman","followers_url":"https://api.github.com/users/iangilman/followers","following_url":"https://api.github.com/users/iangilman/following{/other_user}","gists_url":"https://api.github.com/users/iangilman/gists{/gist_id}","starred_url":"https://api.github.com/users/iangilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iangilman/subscriptions","organizations_url":"https://api.github.com/users/iangilman/orgs","repos_url":"https://api.github.com/users/iangilman/repos","events_url":"https://api.github.com/users/iangilman/events{/privacy}","received_events_url":"https://api.github.com/users/iangilman/received_events","type":"User","site_admin":false},"body":"This line should be tabbed out.","created_at":"2018-03-13T16:22:58Z","updated_at":"2018-03-13T16:23:20Z","html_url":"https://github.com/openseadragon/svg-overlay/pull/23#discussion_r174195828","pull_request_url":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/comments/174195828"},"html":{"href":"https://github.com/openseadragon/svg-overlay/pull/23#discussion_r174195828"},"pull_request":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23","id":174559538,"html_url":"https://github.com/openseadragon/svg-overlay/pull/23","diff_url":"https://github.com/openseadragon/svg-overlay/pull/23.diff","patch_url":"https://github.com/openseadragon/svg-overlay/pull/23.patch","issue_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/23","number":23,"state":"open","locked":false,"title":"require openseadragon if it doesn't exist","user":{"login":"jeffpeck-readcoor","id":30411238,"avatar_url":"https://avatars1.githubusercontent.com/u/30411238?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffpeck-readcoor","html_url":"https://github.com/jeffpeck-readcoor","followers_url":"https://api.github.com/users/jeffpeck-readcoor/followers","following_url":"https://api.github.com/users/jeffpeck-readcoor/following{/other_user}","gists_url":"https://api.github.com/users/jeffpeck-readcoor/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffpeck-readcoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffpeck-readcoor/subscriptions","organizations_url":"https://api.github.com/users/jeffpeck-readcoor/orgs","repos_url":"https://api.github.com/users/jeffpeck-readcoor/repos","events_url":"https://api.github.com/users/jeffpeck-readcoor/events{/privacy}","received_events_url":"https://api.github.com/users/jeffpeck-readcoor/received_events","type":"User","site_admin":false},"body":"Fixes the `[openseadragon-svg-overlay] requires OpenSeadragon` error when doing this:\r\n\r\n```\r\nimport OpenSeadragon from 'openseadragon';\r\nimport 'svg-overlay';\r\n```\r\n\r\nBorrowed style from https://github.com/usnistgov/OpenSeadragonFiltering/blob/master/openseadragon-filtering.js\r\n\r\nsetting OpenSeadragon object to `$`","created_at":"2018-03-13T05:09:58Z","updated_at":"2018-03-13T16:23:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f68cbd7135ae6322ac4458dde82100beeb0b426f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23/commits","review_comments_url":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23/comments","review_comment_url":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/23/comments","statuses_url":"https://api.github.com/repos/openseadragon/svg-overlay/statuses/e7bfc6725b15ff5cfa7788f01a877964e9480baf","head":{"label":"jeffpeck-readcoor:patch-1","ref":"patch-1","sha":"e7bfc6725b15ff5cfa7788f01a877964e9480baf","user":{"login":"jeffpeck-readcoor","id":30411238,"avatar_url":"https://avatars1.githubusercontent.com/u/30411238?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffpeck-readcoor","html_url":"https://github.com/jeffpeck-readcoor","followers_url":"https://api.github.com/users/jeffpeck-readcoor/followers","following_url":"https://api.github.com/users/jeffpeck-readcoor/following{/other_user}","gists_url":"https://api.github.com/users/jeffpeck-readcoor/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffpeck-readcoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffpeck-readcoor/subscriptions","organizations_url":"https://api.github.com/users/jeffpeck-readcoor/orgs","repos_url":"https://api.github.com/users/jeffpeck-readcoor/repos","events_url":"https://api.github.com/users/jeffpeck-readcoor/events{/privacy}","received_events_url":"https://api.github.com/users/jeffpeck-readcoor/received_events","type":"User","site_admin":false},"repo":{"id":124995108,"name":"svg-overlay","full_name":"jeffpeck-readcoor/svg-overlay","owner":{"login":"jeffpeck-readcoor","id":30411238,"avatar_url":"https://avatars1.githubusercontent.com/u/30411238?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffpeck-readcoor","html_url":"https://github.com/jeffpeck-readcoor","followers_url":"https://api.github.com/users/jeffpeck-readcoor/followers","following_url":"https://api.github.com/users/jeffpeck-readcoor/following{/other_user}","gists_url":"https://api.github.com/users/jeffpeck-readcoor/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffpeck-readcoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffpeck-readcoor/subscriptions","organizations_url":"https://api.github.com/users/jeffpeck-readcoor/orgs","repos_url":"https://api.github.com/users/jeffpeck-readcoor/repos","events_url":"https://api.github.com/users/jeffpeck-readcoor/events{/privacy}","received_events_url":"https://api.github.com/users/jeffpeck-readcoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffpeck-readcoor/svg-overlay","description":"An OpenSeadragon plugin that adds SVG overlay capability.","fork":true,"url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay","forks_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/forks","keys_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/teams","hooks_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/hooks","issue_events_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/events","assignees_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/tags","blobs_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/languages","stargazers_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/stargazers","contributors_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/contributors","subscribers_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/subscribers","subscription_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/subscription","commits_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/merges","archive_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/downloads","issues_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/labels{/name}","releases_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/jeffpeck-readcoor/svg-overlay/deployments","created_at":"2018-03-13T05:03:09Z","updated_at":"2018-03-13T05:03:11Z","pushed_at":"2018-03-13T05:09:52Z","git_url":"git://github.com/jeffpeck-readcoor/svg-overlay.git","ssh_url":"git@github.com:jeffpeck-readcoor/svg-overlay.git","clone_url":"https://github.com/jeffpeck-readcoor/svg-overlay.git","svn_url":"https://github.com/jeffpeck-readcoor/svg-overlay","homepage":null,"size":868,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openseadragon:master","ref":"master","sha":"f32444dd20d5fe5a84780857124f7b7bd8013b44","user":{"login":"openseadragon","id":3392630,"avatar_url":"https://avatars3.githubusercontent.com/u/3392630?v=4","gravatar_id":"","url":"https://api.github.com/users/openseadragon","html_url":"https://github.com/openseadragon","followers_url":"https://api.github.com/users/openseadragon/followers","following_url":"https://api.github.com/users/openseadragon/following{/other_user}","gists_url":"https://api.github.com/users/openseadragon/gists{/gist_id}","starred_url":"https://api.github.com/users/openseadragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openseadragon/subscriptions","organizations_url":"https://api.github.com/users/openseadragon/orgs","repos_url":"https://api.github.com/users/openseadragon/repos","events_url":"https://api.github.com/users/openseadragon/events{/privacy}","received_events_url":"https://api.github.com/users/openseadragon/received_events","type":"Organization","site_admin":false},"repo":{"id":28206105,"name":"svg-overlay","full_name":"openseadragon/svg-overlay","owner":{"login":"openseadragon","id":3392630,"avatar_url":"https://avatars3.githubusercontent.com/u/3392630?v=4","gravatar_id":"","url":"https://api.github.com/users/openseadragon","html_url":"https://github.com/openseadragon","followers_url":"https://api.github.com/users/openseadragon/followers","following_url":"https://api.github.com/users/openseadragon/following{/other_user}","gists_url":"https://api.github.com/users/openseadragon/gists{/gist_id}","starred_url":"https://api.github.com/users/openseadragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openseadragon/subscriptions","organizations_url":"https://api.github.com/users/openseadragon/orgs","repos_url":"https://api.github.com/users/openseadragon/repos","events_url":"https://api.github.com/users/openseadragon/events{/privacy}","received_events_url":"https://api.github.com/users/openseadragon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openseadragon/svg-overlay","description":"An OpenSeadragon plugin that adds SVG overlay capability.","fork":false,"url":"https://api.github.com/repos/openseadragon/svg-overlay","forks_url":"https://api.github.com/repos/openseadragon/svg-overlay/forks","keys_url":"https://api.github.com/repos/openseadragon/svg-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openseadragon/svg-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openseadragon/svg-overlay/teams","hooks_url":"https://api.github.com/repos/openseadragon/svg-overlay/hooks","issue_events_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/openseadragon/svg-overlay/events","assignees_url":"https://api.github.com/repos/openseadragon/svg-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/openseadragon/svg-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/openseadragon/svg-overlay/tags","blobs_url":"https://api.github.com/repos/openseadragon/svg-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openseadragon/svg-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openseadragon/svg-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/openseadragon/svg-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openseadragon/svg-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/openseadragon/svg-overlay/languages","stargazers_url":"https://api.github.com/repos/openseadragon/svg-overlay/stargazers","contributors_url":"https://api.github.com/repos/openseadragon/svg-overlay/contributors","subscribers_url":"https://api.github.com/repos/openseadragon/svg-overlay/subscribers","subscription_url":"https://api.github.com/repos/openseadragon/svg-overlay/subscription","commits_url":"https://api.github.com/repos/openseadragon/svg-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/openseadragon/svg-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/openseadragon/svg-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/openseadragon/svg-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/openseadragon/svg-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openseadragon/svg-overlay/merges","archive_url":"https://api.github.com/repos/openseadragon/svg-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openseadragon/svg-overlay/downloads","issues_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/openseadragon/svg-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/openseadragon/svg-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/openseadragon/svg-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openseadragon/svg-overlay/labels{/name}","releases_url":"https://api.github.com/repos/openseadragon/svg-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/openseadragon/svg-overlay/deployments","created_at":"2014-12-18T23:28:14Z","updated_at":"2017-10-27T01:53:47Z","pushed_at":"2018-03-13T05:09:59Z","git_url":"git://github.com/openseadragon/svg-overlay.git","ssh_url":"git@github.com:openseadragon/svg-overlay.git","clone_url":"https://github.com/openseadragon/svg-overlay.git","svn_url":"https://github.com/openseadragon/svg-overlay","homepage":null,"size":867,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":14,"open_issues":7,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23"},"html":{"href":"https://github.com/openseadragon/svg-overlay/pull/23"},"issue":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/issues/23"},"comments":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/openseadragon/svg-overlay/statuses/e7bfc6725b15ff5cfa7788f01a877964e9480baf"}},"author_association":"NONE"}}
{"actor":{"display_login":"iangilman"}}