{"action":"closed","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_nodejs/issues/140","repository_url":"https://api.github.com/repos/bazelbuild/rules_nodejs","labels_url":"https://api.github.com/repos/bazelbuild/rules_nodejs/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_nodejs/issues/140/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_nodejs/issues/140/events","html_url":"https://github.com/bazelbuild/rules_nodejs/issues/140","id":302456741,"number":140,"title":"postinstall scripts use system node","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars2.githubusercontent.com/u/47395?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"labels":[{"id":674339026,"url":"https://api.github.com/repos/bazelbuild/rules_nodejs/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":{"login":"gregmagolan","id":520826,"avatar_url":"https://avatars1.githubusercontent.com/u/520826?v=4","gravatar_id":"","url":"https://api.github.com/users/gregmagolan","html_url":"https://github.com/gregmagolan","followers_url":"https://api.github.com/users/gregmagolan/followers","following_url":"https://api.github.com/users/gregmagolan/following{/other_user}","gists_url":"https://api.github.com/users/gregmagolan/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmagolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmagolan/subscriptions","organizations_url":"https://api.github.com/users/gregmagolan/orgs","repos_url":"https://api.github.com/users/gregmagolan/repos","events_url":"https://api.github.com/users/gregmagolan/events{/privacy}","received_events_url":"https://api.github.com/users/gregmagolan/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregmagolan","id":520826,"avatar_url":"https://avatars1.githubusercontent.com/u/520826?v=4","gravatar_id":"","url":"https://api.github.com/users/gregmagolan","html_url":"https://github.com/gregmagolan","followers_url":"https://api.github.com/users/gregmagolan/followers","following_url":"https://api.github.com/users/gregmagolan/following{/other_user}","gists_url":"https://api.github.com/users/gregmagolan/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmagolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmagolan/subscriptions","organizations_url":"https://api.github.com/users/gregmagolan/orgs","repos_url":"https://api.github.com/users/gregmagolan/repos","events_url":"https://api.github.com/users/gregmagolan/events{/privacy}","received_events_url":"https://api.github.com/users/gregmagolan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-03-05T20:49:51Z","updated_at":"2018-03-07T22:20:56Z","closed_at":"2018-03-07T22:20:56Z","author_association":"COLLABORATOR","body":"Easy to reproduce on a machine without node installed at all.\r\n\r\nWe should set `--scripts-prepend-node-path` when calling `npm install` so that the node on the path is the one invoking the `npm` command, this makes `\"postinstall\": \"node my_script.js\"` work when the user does `bazel run @nodejs//:npm install`\r\n\r\nHowever the equivalent feature for `bazel run @yarn//:yarn` seems to be broken, so we need to find some workaround? File a bug with yarn? Bazel manages its own yarn installation so patching yarn is totally an option.\r\n\r\nFinally, what do we do about cases where you run an npm bin, like `postinstall: \"ngc -p angular.tsconfig.json\"`? I think maybe this just works? but needs testing"}}
{"actor":{"display_login":"alexeagle"}}