{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/2614","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/2614/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2614/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/2614/events","html_url":"https://github.com/apache/cloudstack/pull/2614","id":318840171,"number":2614,"title":"WIP perform config drive creation on primary storage (CLOUDSTACK-10290)","user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"labels":[{"id":821716113,"url":"https://api.github.com/repos/apache/cloudstack/labels/Cleanup","name":"Cleanup","color":"0e8a16","default":false},{"id":589162089,"url":"https://api.github.com/repos/apache/cloudstack/labels/Work-in-Progress","name":"Work-in-Progress","color":"bfd4f2","default":false},{"id":584073882,"url":"https://api.github.com/repos/apache/cloudstack/labels/config","name":"config","color":"5319e7","default":false},{"id":584072971,"url":"https://api.github.com/repos/apache/cloudstack/labels/kvm","name":"kvm","color":"006b75","default":false},{"id":584073278,"url":"https://api.github.com/repos/apache/cloudstack/labels/primary-storage","name":"primary-storage","color":"5319e7","default":false},{"id":584073307,"url":"https://api.github.com/repos/apache/cloudstack/labels/secondary-storage","name":"secondary-storage","color":"f9d0c4","default":false},{"id":584074680,"url":"https://api.github.com/repos/apache/cloudstack/labels/security","name":"security","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"assignees":[{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apache/cloudstack/milestones/5","html_url":"https://github.com/apache/cloudstack/milestone/5","labels_url":"https://api.github.com/repos/apache/cloudstack/milestones/5/labels","id":3033298,"number":5,"title":"4.11.1.0","description":"Milestone covering PRs for the next 4.11.1.0 release. All PRs using this milestone should send PR against the 4.11 branch.","creator":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":92,"state":"open","created_at":"2018-01-13T20:06:17Z","updated_at":"2018-05-09T16:33:32Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-04-30T10:03:33Z","updated_at":"2018-05-09T16:39:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2614","html_url":"https://github.com/apache/cloudstack/pull/2614","diff_url":"https://github.com/apache/cloudstack/pull/2614.diff","patch_url":"https://github.com/apache/cloudstack/pull/2614.patch"},"body":"## Description\r\nThe present configdrive generation happens on secondary storage, which is also used in public facing functionality. For those that wnat it can be processed on primary storage. This will be optional for now as using localstorage will complicate things when migrating.\r\n\r\nFirst phase is factoring out the config drive creation code into a separate project (done)\r\nnext it will be made available to the host agent (KVM only)\r\nfinally the decision to look for a primary storage to do the processing on will be implemented on the basis of a global setting.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Enhancement (improves an existing feature and functionality)\r\n- [x] Cleanup (Code refactoring and cleanup, that may add test cases)\r\n\r\n## GitHub Issue/PRs\r\n<!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->\r\n<!-- When \"Fixes: #<id>\" is specified, the issue/PR will automatically be closed when this PR gets merged -->\r\n<!-- For addressing multiple issues/PRs, use multiple \"Fixes: #<id>\" -->\r\n\r\n<!-- Fixes: # -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## How Has This Been Tested?\r\n\r\n<!-- Please describe in detail how you tested your changes. -->\r\nthis is tested manually in a kvm env with a custom network offering that has everything in the VR except userdata. An isolated network created has been created using this offering. Finally a VM was succesfully deployed in this network.\r\n<!-- Include details of your testing environment, and the tests you ran to -->\r\n<!-- see how your change affects other areas of the code, etc. -->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\nTesting\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All relevant new and existing integration tests have passed.\r\n- [ ] A full integration testsuite with all test that can run on my environment has passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/387800336","html_url":"https://github.com/apache/cloudstack/pull/2614#issuecomment-387800336","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2614","id":387800336,"user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T16:39:04Z","updated_at":"2018-05-09T16:39:04Z","author_association":"CONTRIBUTOR","body":"@GabrielBrascher it is not fully functional yet. I would like review.\r\nThe problem I am facing is that ConfigDrive is part of network configuration and no Primary storage is know yet before creating or (re-)starting a VM, so no where to create the ConfigDrive on. I need to solve that. Ideas welcome."}}
{"actor":{"display_login":"DaanHoogland"}}