{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/support-frontend/issues/1203","repository_url":"https://api.github.com/repos/guardian/support-frontend","labels_url":"https://api.github.com/repos/guardian/support-frontend/issues/1203/labels{/name}","comments_url":"https://api.github.com/repos/guardian/support-frontend/issues/1203/comments","events_url":"https://api.github.com/repos/guardian/support-frontend/issues/1203/events","html_url":"https://github.com/guardian/support-frontend/pull/1203","id":382238822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTkxOTc3","number":1203,"title":"NPF: Block existing, signed in, recurring contributors from making another contribution","user":{"login":"jranks123","id":2844554,"node_id":"MDQ6VXNlcjI4NDQ1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2844554?v=4","gravatar_id":"","url":"https://api.github.com/users/jranks123","html_url":"https://github.com/jranks123","followers_url":"https://api.github.com/users/jranks123/followers","following_url":"https://api.github.com/users/jranks123/following{/other_user}","gists_url":"https://api.github.com/users/jranks123/gists{/gist_id}","starred_url":"https://api.github.com/users/jranks123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jranks123/subscriptions","organizations_url":"https://api.github.com/users/jranks123/orgs","repos_url":"https://api.github.com/users/jranks123/repos","events_url":"https://api.github.com/users/jranks123/events{/privacy}","received_events_url":"https://api.github.com/users/jranks123/received_events","type":"User","site_admin":false},"labels":[{"id":613794126,"node_id":"MDU6TGFiZWw2MTM3OTQxMjY=","url":"https://api.github.com/repos/guardian/support-frontend/labels/Seen-on-PROD","name":"Seen-on-PROD","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-19T14:26:55Z","updated_at":"2018-11-19T16:08:56Z","closed_at":"2018-11-19T16:00:34Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/guardian/support-frontend/pulls/1203","html_url":"https://github.com/guardian/support-frontend/pull/1203","diff_url":"https://github.com/guardian/support-frontend/pull/1203.diff","patch_url":"https://github.com/guardian/support-frontend/pull/1203.patch"},"body":"## Why are you doing this?\r\nStops (most) signed in, existing recurring contributors from making another recurring contributor.\r\n\r\nRather than hit the members-data-api to find out if they are a recurring contributor (which would have the side effect of having to block form submission until the request comes back, which slows down the page for slow connections), this PR relies on the existence of the `gu_recurring_contributor` cookie to determine if they are a recurring contributor. This does mean it will be possible for a signed in, exisiting recurring contributor to make another contribution, but we are already working on a process for letting people who this happens to know, via email, post checkout, which we will have to do anyway for those who aren't signed but have an existing recurring contribution.\r\n\r\n The hypothesis is that the cookie will catch nearly all cases, as most people who are signed in will have visited `gu.com` since being signed in before coming to our site, so will have the cookie, but we will need to keep an eye on this and then decide whether we want to add the call to `members-data-api` based on the % that slip through the net. \r\n\r\nThis also only applies to NPF, not OPF. We are going to try and turn off OPF as soon as possible, and from now on will stop adding features unless it is completely neccassery. Hence the splitting of `checkoutFrom` into `checkoutFormOld` and `formSubmit` into `formSubmit` and `formSubmitOld`\r\n\r\n| Example of blocking |\r\n|----------|\r\n|![image](https://user-images.githubusercontent.com/2844554/48718345-1a06ff00-ec13-11e8-969a-5032acfdd098.png)|\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/support-frontend/issues/comments/439947251","html_url":"https://github.com/guardian/support-frontend/pull/1203#issuecomment-439947251","issue_url":"https://api.github.com/repos/guardian/support-frontend/issues/1203","id":439947251,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTk0NzI1MQ==","user":{"login":"prout-bot","id":8896019,"node_id":"MDQ6VXNlcjg4OTYwMTk=","avatar_url":"https://avatars2.githubusercontent.com/u/8896019?v=4","gravatar_id":"","url":"https://api.github.com/users/prout-bot","html_url":"https://github.com/prout-bot","followers_url":"https://api.github.com/users/prout-bot/followers","following_url":"https://api.github.com/users/prout-bot/following{/other_user}","gists_url":"https://api.github.com/users/prout-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/prout-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prout-bot/subscriptions","organizations_url":"https://api.github.com/users/prout-bot/orgs","repos_url":"https://api.github.com/users/prout-bot/repos","events_url":"https://api.github.com/users/prout-bot/events{/privacy}","received_events_url":"https://api.github.com/users/prout-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T16:08:56Z","updated_at":"2018-11-19T16:08:56Z","author_association":"NONE","body":"Seen on [PROD](https://support.theguardian.com/uk) (merged by @jranks123 8 minutes and 22 seconds ago) \n- Keep an eye out for [post deployment test](https://github.com/guardian/support-frontend/wiki/Post-Deployment-Testing) results on [Travis](https://travis-ci.org/guardian/support-frontend/builds)\n\n\n#### Sentry Release: [support-client-side](https://sentry.io/the-guardian/support-client-side/releases/00e94da99bf6905fe31b54b20bb5ee01d9c3ce62/), [support](https://sentry.io/the-guardian/support/releases/00e94da99bf6905fe31b54b20bb5ee01d9c3ce62/)"}}
{"actor":{"display_login":"prout-bot"}}