{"action":"created","comment":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/218173515","pull_request_review_id":156053733,"id":218173515,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODE3MzUxNQ==","diff_hunk":"@@ -28,18 +28,14 @@ __declspec(noinline, noreturn)\n }\n \n #define ASSERT(_a_)                                                                                \\\n-    do                                                                                             \\\n-        if (!(_a_)) {                                                                              \\\n-            assert_noinline_call([] { LOG_CRITICAL(Debug, \"Assertion Failed!\"); });                \\\n-        }                                                                                          \\\n-    while (0)\n+    if (!(_a_)) {                                                                                  \\\n+        LOG_CRITICAL(Debug, \"Assertion Failed!\");                                                  \\\n+    }\n \n #define ASSERT_MSG(_a_, ...)                                                                       \\\n-    do                                                                                             \\\n-        if (!(_a_)) {                                                                              \\\n-            assert_noinline_call([&] { LOG_CRITICAL(Debug, \"Assertion Failed!\\n\" __VA_ARGS__); }); \\\n-        }                                                                                          \\\n-    while (0)\n+    if (!(_a_)) {                                                                                  \\\n+        LOG_CRITICAL(Debug, \"Assertion Failed!\\n\" __VA_ARGS__);                                    \\","path":"src/common/assert.h","position":null,"original_position":20,"commit_id":"babd3581eeb135582c50bbf30a2f72a619b98dc9","original_commit_id":"3398bac50278f47eee187d5b54dab89ca31d256d","user":{"login":"FernandoS27","id":1731197,"node_id":"MDQ6VXNlcjE3MzExOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1731197?v=4","gravatar_id":"","url":"https://api.github.com/users/FernandoS27","html_url":"https://github.com/FernandoS27","followers_url":"https://api.github.com/users/FernandoS27/followers","following_url":"https://api.github.com/users/FernandoS27/following{/other_user}","gists_url":"https://api.github.com/users/FernandoS27/gists{/gist_id}","starred_url":"https://api.github.com/users/FernandoS27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernandoS27/subscriptions","organizations_url":"https://api.github.com/users/FernandoS27/orgs","repos_url":"https://api.github.com/users/FernandoS27/repos","events_url":"https://api.github.com/users/FernandoS27/events{/privacy}","received_events_url":"https://api.github.com/users/FernandoS27/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2018-09-17T18:15:27Z","updated_at":"2018-09-17T18:15:28Z","html_url":"https://github.com/yuzu-emu/yuzu/pull/1340#discussion_r218173515","pull_request_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/218173515"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/1340#discussion_r218173515"},"pull_request":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340"}},"in_reply_to_id":218170997},"pull_request":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340","id":216066484,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDY2NDg0","html_url":"https://github.com/yuzu-emu/yuzu/pull/1340","diff_url":"https://github.com/yuzu-emu/yuzu/pull/1340.diff","patch_url":"https://github.com/yuzu-emu/yuzu/pull/1340.patch","issue_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1340","number":1340,"state":"open","locked":false,"title":"Implement a Better Ignore Assert - DO NOT CHECK IN","user":{"login":"FernandoS27","id":1731197,"node_id":"MDQ6VXNlcjE3MzExOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1731197?v=4","gravatar_id":"","url":"https://api.github.com/users/FernandoS27","html_url":"https://github.com/FernandoS27","followers_url":"https://api.github.com/users/FernandoS27/followers","following_url":"https://api.github.com/users/FernandoS27/following{/other_user}","gists_url":"https://api.github.com/users/FernandoS27/gists{/gist_id}","starred_url":"https://api.github.com/users/FernandoS27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernandoS27/subscriptions","organizations_url":"https://api.github.com/users/FernandoS27/orgs","repos_url":"https://api.github.com/users/FernandoS27/repos","events_url":"https://api.github.com/users/FernandoS27/events{/privacy}","received_events_url":"https://api.github.com/users/FernandoS27/received_events","type":"User","site_admin":false},"body":"This one prints the assert message to the log. At least it helps us figure if an assert was broken from user log.","created_at":"2018-09-17T18:03:43Z","updated_at":"2018-09-17T18:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe933778301656f838693924464d889831e8a198","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340/commits","review_comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340/comments","review_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1340/comments","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/babd3581eeb135582c50bbf30a2f72a619b98dc9","head":{"label":"FernandoS27:ignore-assert-dev","ref":"ignore-assert-dev","sha":"babd3581eeb135582c50bbf30a2f72a619b98dc9","user":{"login":"FernandoS27","id":1731197,"node_id":"MDQ6VXNlcjE3MzExOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1731197?v=4","gravatar_id":"","url":"https://api.github.com/users/FernandoS27","html_url":"https://github.com/FernandoS27","followers_url":"https://api.github.com/users/FernandoS27/followers","following_url":"https://api.github.com/users/FernandoS27/following{/other_user}","gists_url":"https://api.github.com/users/FernandoS27/gists{/gist_id}","starred_url":"https://api.github.com/users/FernandoS27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernandoS27/subscriptions","organizations_url":"https://api.github.com/users/FernandoS27/orgs","repos_url":"https://api.github.com/users/FernandoS27/repos","events_url":"https://api.github.com/users/FernandoS27/events{/privacy}","received_events_url":"https://api.github.com/users/FernandoS27/received_events","type":"User","site_admin":false},"repo":{"id":121880626,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODA2MjY=","name":"yuzu","full_name":"FernandoS27/yuzu","private":false,"owner":{"login":"FernandoS27","id":1731197,"node_id":"MDQ6VXNlcjE3MzExOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1731197?v=4","gravatar_id":"","url":"https://api.github.com/users/FernandoS27","html_url":"https://github.com/FernandoS27","followers_url":"https://api.github.com/users/FernandoS27/followers","following_url":"https://api.github.com/users/FernandoS27/following{/other_user}","gists_url":"https://api.github.com/users/FernandoS27/gists{/gist_id}","starred_url":"https://api.github.com/users/FernandoS27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernandoS27/subscriptions","organizations_url":"https://api.github.com/users/FernandoS27/orgs","repos_url":"https://api.github.com/users/FernandoS27/repos","events_url":"https://api.github.com/users/FernandoS27/events{/privacy}","received_events_url":"https://api.github.com/users/FernandoS27/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FernandoS27/yuzu","description":"Nintendo Switch Emulator","fork":true,"url":"https://api.github.com/repos/FernandoS27/yuzu","forks_url":"https://api.github.com/repos/FernandoS27/yuzu/forks","keys_url":"https://api.github.com/repos/FernandoS27/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FernandoS27/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FernandoS27/yuzu/teams","hooks_url":"https://api.github.com/repos/FernandoS27/yuzu/hooks","issue_events_url":"https://api.github.com/repos/FernandoS27/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/FernandoS27/yuzu/events","assignees_url":"https://api.github.com/repos/FernandoS27/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/FernandoS27/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/FernandoS27/yuzu/tags","blobs_url":"https://api.github.com/repos/FernandoS27/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FernandoS27/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FernandoS27/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/FernandoS27/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FernandoS27/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/FernandoS27/yuzu/languages","stargazers_url":"https://api.github.com/repos/FernandoS27/yuzu/stargazers","contributors_url":"https://api.github.com/repos/FernandoS27/yuzu/contributors","subscribers_url":"https://api.github.com/repos/FernandoS27/yuzu/subscribers","subscription_url":"https://api.github.com/repos/FernandoS27/yuzu/subscription","commits_url":"https://api.github.com/repos/FernandoS27/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/FernandoS27/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/FernandoS27/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/FernandoS27/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/FernandoS27/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/FernandoS27/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FernandoS27/yuzu/merges","archive_url":"https://api.github.com/repos/FernandoS27/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FernandoS27/yuzu/downloads","issues_url":"https://api.github.com/repos/FernandoS27/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/FernandoS27/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/FernandoS27/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/FernandoS27/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FernandoS27/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/FernandoS27/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/FernandoS27/yuzu/deployments","created_at":"2018-02-17T18:23:20Z","updated_at":"2018-09-17T00:40:39Z","pushed_at":"2018-09-17T18:15:14Z","git_url":"git://github.com/FernandoS27/yuzu.git","ssh_url":"git@github.com:FernandoS27/yuzu.git","clone_url":"https://github.com/FernandoS27/yuzu.git","svn_url":"https://github.com/FernandoS27/yuzu","homepage":"","size":23452,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yuzu-emu:master","ref":"master","sha":"a94b623dfb6f151dfa9c0a62ad30368a9c8058c2","user":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":116167731,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjc3MzE=","name":"yuzu","full_name":"yuzu-emu/yuzu","private":false,"owner":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yuzu-emu/yuzu","description":"Nintendo Switch Emulator","fork":false,"url":"https://api.github.com/repos/yuzu-emu/yuzu","forks_url":"https://api.github.com/repos/yuzu-emu/yuzu/forks","keys_url":"https://api.github.com/repos/yuzu-emu/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuzu-emu/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuzu-emu/yuzu/teams","hooks_url":"https://api.github.com/repos/yuzu-emu/yuzu/hooks","issue_events_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/yuzu-emu/yuzu/events","assignees_url":"https://api.github.com/repos/yuzu-emu/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/yuzu-emu/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/tags","blobs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/yuzu-emu/yuzu/languages","stargazers_url":"https://api.github.com/repos/yuzu-emu/yuzu/stargazers","contributors_url":"https://api.github.com/repos/yuzu-emu/yuzu/contributors","subscribers_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscribers","subscription_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscription","commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuzu-emu/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/yuzu-emu/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuzu-emu/yuzu/merges","archive_url":"https://api.github.com/repos/yuzu-emu/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuzu-emu/yuzu/downloads","issues_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/yuzu-emu/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/yuzu-emu/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuzu-emu/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/yuzu-emu/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/yuzu-emu/yuzu/deployments","created_at":"2018-01-03T18:13:57Z","updated_at":"2018-09-17T16:39:40Z","pushed_at":"2018-09-17T18:15:15Z","git_url":"git://github.com/yuzu-emu/yuzu.git","ssh_url":"git@github.com:yuzu-emu/yuzu.git","clone_url":"https://github.com/yuzu-emu/yuzu.git","svn_url":"https://github.com/yuzu-emu/yuzu","homepage":"","size":23429,"stargazers_count":5081,"watchers_count":5081,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":290,"open_issues":51,"watchers":5081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/1340"},"issue":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1340"},"comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1340/comments"},"review_comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340/comments"},"review_comment":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1340/commits"},"statuses":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/babd3581eeb135582c50bbf30a2f72a619b98dc9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FernandoS27"}}