{"action":"created","comment":{"url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/comments/182389042","pull_request_review_id":113172338,"id":182389042,"diff_hunk":"@@ -50,6 +50,24 @@ class AsyncWorker : public Nan::AsyncWorker {\n       return;\n     }\n \n+    // Overwrite the MBR with empty partitions to ensure\n+    // that it's \"Unallocated\", should the missing MBR signature be ignored","path":"src/drive-clean.cpp","position":5,"original_position":5,"commit_id":"c541494f6bc510e72d2f2a6768e3218f18ba102b","original_commit_id":"c541494f6bc510e72d2f2a6768e3218f18ba102b","user":{"login":"zvin","id":180331,"avatar_url":"https://avatars2.githubusercontent.com/u/180331?v=4","gravatar_id":"","url":"https://api.github.com/users/zvin","html_url":"https://github.com/zvin","followers_url":"https://api.github.com/users/zvin/followers","following_url":"https://api.github.com/users/zvin/following{/other_user}","gists_url":"https://api.github.com/users/zvin/gists{/gist_id}","starred_url":"https://api.github.com/users/zvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvin/subscriptions","organizations_url":"https://api.github.com/users/zvin/orgs","repos_url":"https://api.github.com/users/zvin/repos","events_url":"https://api.github.com/users/zvin/events{/privacy}","received_events_url":"https://api.github.com/users/zvin/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand the end of the comment.\r\nDo you mean \r\n>Overwrite the MBR with empty partitions to ensure that it's \"Unallocated\" if the MBR signature is missing.\r\n?","created_at":"2018-04-18T11:06:30Z","updated_at":"2018-04-18T11:06:34Z","html_url":"https://github.com/resin-io-modules/win-drive-clean/pull/7#discussion_r182389042","pull_request_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/comments/182389042"},"html":{"href":"https://github.com/resin-io-modules/win-drive-clean/pull/7#discussion_r182389042"},"pull_request":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7","id":182294241,"html_url":"https://github.com/resin-io-modules/win-drive-clean/pull/7","diff_url":"https://github.com/resin-io-modules/win-drive-clean/pull/7.diff","patch_url":"https://github.com/resin-io-modules/win-drive-clean/pull/7.patch","issue_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/7","number":7,"state":"open","locked":false,"title":"feat(win): Zero out MBR partition table entries","user":{"login":"jhermsmeier","id":244907,"avatar_url":"https://avatars3.githubusercontent.com/u/244907?v=4","gravatar_id":"","url":"https://api.github.com/users/jhermsmeier","html_url":"https://github.com/jhermsmeier","followers_url":"https://api.github.com/users/jhermsmeier/followers","following_url":"https://api.github.com/users/jhermsmeier/following{/other_user}","gists_url":"https://api.github.com/users/jhermsmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/jhermsmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhermsmeier/subscriptions","organizations_url":"https://api.github.com/users/jhermsmeier/orgs","repos_url":"https://api.github.com/users/jhermsmeier/repos","events_url":"https://api.github.com/users/jhermsmeier/events{/privacy}","received_events_url":"https://api.github.com/users/jhermsmeier/received_events","type":"User","site_admin":false},"body":"This adds a call to `IOCTL_DISK_SET_DRIVE_LAYOUT_EX` to zero\r\nout partition entries in the MBR before removing the MBR signature\r\nin order to ensure that space is treated as \"Unallocated\" should\r\nthe missing MBR signature be ignored.\r\n\r\nChange-Type: minor\r\nChangelog-Entry: Zero out MBR partition table entries","created_at":"2018-04-17T20:47:50Z","updated_at":"2018-04-18T11:06:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"600170842d384ddf1cf0d793e8041956034b3aa5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Shou","id":819413,"avatar_url":"https://avatars1.githubusercontent.com/u/819413?v=4","gravatar_id":"","url":"https://api.github.com/users/Shou","html_url":"https://github.com/Shou","followers_url":"https://api.github.com/users/Shou/followers","following_url":"https://api.github.com/users/Shou/following{/other_user}","gists_url":"https://api.github.com/users/Shou/gists{/gist_id}","starred_url":"https://api.github.com/users/Shou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shou/subscriptions","organizations_url":"https://api.github.com/users/Shou/orgs","repos_url":"https://api.github.com/users/Shou/repos","events_url":"https://api.github.com/users/Shou/events{/privacy}","received_events_url":"https://api.github.com/users/Shou/received_events","type":"User","site_admin":false},{"login":"jviotti","id":2192773,"avatar_url":"https://avatars0.githubusercontent.com/u/2192773?v=4","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7/commits","review_comments_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7/comments","review_comment_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/7/comments","statuses_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/statuses/c541494f6bc510e72d2f2a6768e3218f18ba102b","head":{"label":"resin-io-modules:zero-mbr","ref":"zero-mbr","sha":"c541494f6bc510e72d2f2a6768e3218f18ba102b","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":119749447,"name":"win-drive-clean","full_name":"resin-io-modules/win-drive-clean","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/win-drive-clean","description":"Remove a disks partition table on Windows","fork":false,"url":"https://api.github.com/repos/resin-io-modules/win-drive-clean","forks_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/forks","keys_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/events","assignees_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/merges","archive_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/deployments","created_at":"2018-01-31T22:03:35Z","updated_at":"2018-02-09T20:45:58Z","pushed_at":"2018-04-17T21:12:13Z","git_url":"git://github.com/resin-io-modules/win-drive-clean.git","ssh_url":"git@github.com:resin-io-modules/win-drive-clean.git","clone_url":"https://github.com/resin-io-modules/win-drive-clean.git","svn_url":"https://github.com/resin-io-modules/win-drive-clean","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"resin-io-modules:master","ref":"master","sha":"028ea6ebee6c107c2554ca1808c64667ea17c308","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":119749447,"name":"win-drive-clean","full_name":"resin-io-modules/win-drive-clean","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/win-drive-clean","description":"Remove a disks partition table on Windows","fork":false,"url":"https://api.github.com/repos/resin-io-modules/win-drive-clean","forks_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/forks","keys_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/events","assignees_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/merges","archive_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/win-drive-clean/deployments","created_at":"2018-01-31T22:03:35Z","updated_at":"2018-02-09T20:45:58Z","pushed_at":"2018-04-17T21:12:13Z","git_url":"git://github.com/resin-io-modules/win-drive-clean.git","ssh_url":"git@github.com:resin-io-modules/win-drive-clean.git","clone_url":"https://github.com/resin-io-modules/win-drive-clean.git","svn_url":"https://github.com/resin-io-modules/win-drive-clean","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7"},"html":{"href":"https://github.com/resin-io-modules/win-drive-clean/pull/7"},"issue":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/7"},"comments":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io-modules/win-drive-clean/statuses/c541494f6bc510e72d2f2a6768e3218f18ba102b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zvin"}}