{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/188006787","pull_request_review_id":119899216,"id":188006787,"diff_hunk":"@@ -32,6 +33,9 @@ import (\n )\n \n const (\n+\t// DefaultBackendHealthCheckPath defines the path that the system default\n+\t// backend should serve 200's on.\n+\tDefaultBackendHealthCheckPath = \"/healthz\"","path":"pkg/healthchecks/healthchecks.go","position":null,"original_position":14,"commit_id":"8ae3af93820999efff5174309d899313489ae274","original_commit_id":"f203295f73e0b7fbc9026b4d03fde989b9cd5e12","user":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-05-14T15:56:11Z","updated_at":"2018-05-14T15:56:12Z","html_url":"https://github.com/kubernetes/ingress-gce/pull/264#discussion_r188006787","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/188006787"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/264#discussion_r188006787"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264"}},"in_reply_to_id":187752559},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264","id":187525907,"html_url":"https://github.com/kubernetes/ingress-gce/pull/264","diff_url":"https://github.com/kubernetes/ingress-gce/pull/264.diff","patch_url":"https://github.com/kubernetes/ingress-gce/pull/264.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/264","number":264,"state":"open","locked":false,"title":"Condense health checkers into one health checker for all backends.","user":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"body":"This PR should wait on #262\r\n\r\nTODOs before merge:\r\n\r\n1. Manually test case of ingress using system default backend w/ other backends and verify health checks.\r\n2. Verify that users can still modify health check settings for all backends and that the controller will not reconcile. \r\n\r\n/assign @nicksardo ","created_at":"2018-05-11T17:38:25Z","updated_at":"2018-05-14T15:56:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c169e81345428b52115d345cb302fa04c3fc19a0","assignee":{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712525210,"url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":712525281,"url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/264/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/8ae3af93820999efff5174309d899313489ae274","head":{"label":"rramkumar1:fix-health-checks","ref":"fix-health-checks","sha":"8ae3af93820999efff5174309d899313489ae274","user":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"repo":{"id":114787128,"name":"ingress-gce","full_name":"rramkumar1/ingress-gce","owner":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rramkumar1/ingress-gce","description":"Ingress controller for Google Cloud","fork":true,"url":"https://api.github.com/repos/rramkumar1/ingress-gce","forks_url":"https://api.github.com/repos/rramkumar1/ingress-gce/forks","keys_url":"https://api.github.com/repos/rramkumar1/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rramkumar1/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rramkumar1/ingress-gce/teams","hooks_url":"https://api.github.com/repos/rramkumar1/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/rramkumar1/ingress-gce/events","assignees_url":"https://api.github.com/repos/rramkumar1/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/rramkumar1/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/rramkumar1/ingress-gce/tags","blobs_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rramkumar1/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/rramkumar1/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/rramkumar1/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/rramkumar1/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/rramkumar1/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/rramkumar1/ingress-gce/subscription","commits_url":"https://api.github.com/repos/rramkumar1/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/rramkumar1/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/rramkumar1/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/rramkumar1/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rramkumar1/ingress-gce/merges","archive_url":"https://api.github.com/repos/rramkumar1/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rramkumar1/ingress-gce/downloads","issues_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/rramkumar1/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/rramkumar1/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/rramkumar1/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rramkumar1/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/rramkumar1/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/rramkumar1/ingress-gce/deployments","created_at":"2017-12-19T16:25:49Z","updated_at":"2018-04-18T04:05:21Z","pushed_at":"2018-05-14T15:56:10Z","git_url":"git://github.com/rramkumar1/ingress-gce.git","ssh_url":"git@github.com:rramkumar1/ingress-gce.git","clone_url":"https://github.com/rramkumar1/ingress-gce.git","svn_url":"https://github.com/rramkumar1/ingress-gce","homepage":"","size":36330,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f6af412a219c595545e0b07863e5ccdd99b97523","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":105967469,"name":"ingress-gce","full_name":"kubernetes/ingress-gce","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress-gce","description":"Ingress controller for Google Cloud","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-gce","forks_url":"https://api.github.com/repos/kubernetes/ingress-gce/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-gce/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-gce/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-gce/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-gce/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-gce/deployments","created_at":"2017-10-06T04:32:12Z","updated_at":"2018-05-11T22:49:26Z","pushed_at":"2018-05-14T15:56:12Z","git_url":"git://github.com/kubernetes/ingress-gce.git","ssh_url":"git@github.com:kubernetes/ingress-gce.git","clone_url":"https://github.com/kubernetes/ingress-gce.git","svn_url":"https://github.com/kubernetes/ingress-gce","homepage":"","size":36271,"stargazers_count":204,"watchers_count":204,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":64,"open_issues":43,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/264"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/264"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/8ae3af93820999efff5174309d899313489ae274"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rramkumar1"}}