{"action":"created","comment":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/comments/222559732","pull_request_review_id":161473793,"id":222559732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjU1OTczMg==","diff_hunk":"@@ -244,14 +254,79 @@ func ValidateOp(st *storage.LevelDBBackend, source *block.BlockAccount, op trans\n \t\t\terr = errors.ErrorFrozenAccountNoDeposit\n \t\t\treturn\n \t\t}\n-\t\t// If it's a frozen account, everything must be withdrawn\n \t\tif source.Linked != \"\" {\n+\t\t\t// Source account's linked address must be equal to target address\n+\t\t\tif source.Linked != casted.TargetAddress() {\n+\t\t\t\terr = errors.ErrorUnfreezingToInvalidLinkedAccount","path":"lib/node/runner/checker_ballot_transaction.go","position":43,"original_position":43,"commit_id":"d10e59a265edcb33cc95d25d1d068f4624496a5c","original_commit_id":"d10e59a265edcb33cc95d25d1d068f4624496a5c","user":{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false},"body":"@Geod24 I think freezing and unfreezing should be executed only through linked general account.\r\nBecause I think frozen account are like as installment savings.\r\nSo isn't it natural to use freezing and unfreezing through only one account? ","created_at":"2018-10-04T07:19:04Z","updated_at":"2018-10-04T07:19:04Z","html_url":"https://github.com/bosnet/sebak/pull/433#discussion_r222559732","pull_request_url":"https://api.github.com/repos/bosnet/sebak/pulls/433","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments/222559732"},"html":{"href":"https://github.com/bosnet/sebak/pull/433#discussion_r222559732"},"pull_request":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/433"}},"in_reply_to_id":222545853},"pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/433","id":216479490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDc5NDkw","html_url":"https://github.com/bosnet/sebak/pull/433","diff_url":"https://github.com/bosnet/sebak/pull/433.diff","patch_url":"https://github.com/bosnet/sebak/pull/433.patch","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/433","number":433,"state":"open","locked":false,"title":"Unfreezing request operation and unfreezing","user":{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false},"body":"### Github Issue\r\n\r\nresolves #360 \r\n\r\n## Background\r\nWhen a client generates a unfreezing transaction, it really affects the balance of account after X blocks.\r\nThis is the unfreezing feature.\r\n\r\n## Solution\r\nTo implement unfreezing features, unfreezing request operation type is needed.\r\n\r\n1. Client who want to unfreeze the frozen account send unfreezing request transaction.\r\n    This transaction doesn't change the balance of the frozen account.\r\n2. After X blocks, client who already sent unfreezing request transaction send payment transaction.\r\n    This transaction affect the balance of the frozen account. a whole amount of balance is withdrawn from frozen account.\r\n\r\nMake the unfreezing-request operation. and make a test for it.(isaac_simulation_unfreezing_test.go)","created_at":"2018-09-19T00:13:20Z","updated_at":"2018-10-04T07:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e0099e7a331484f1f0b4859a75a0239057632fb","assignee":{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false},"assignees":[{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1048563463,"node_id":"MDU6TGFiZWwxMDQ4NTYzNDYz","url":"https://api.github.com/repos/bosnet/sebak/labels/frozen","name":"frozen","color":"0060ce","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bosnet/sebak/pulls/433/commits","review_comments_url":"https://api.github.com/repos/bosnet/sebak/pulls/433/comments","review_comment_url":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/433/comments","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/d10e59a265edcb33cc95d25d1d068f4624496a5c","head":{"label":"soonkuk:unfreezing","ref":"unfreezing","sha":"d10e59a265edcb33cc95d25d1d068f4624496a5c","user":{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false},"repo":{"id":146528439,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1Mjg0Mzk=","name":"sebak","full_name":"soonkuk/sebak","private":false,"owner":{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/soonkuk/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":true,"url":"https://api.github.com/repos/soonkuk/sebak","forks_url":"https://api.github.com/repos/soonkuk/sebak/forks","keys_url":"https://api.github.com/repos/soonkuk/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soonkuk/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soonkuk/sebak/teams","hooks_url":"https://api.github.com/repos/soonkuk/sebak/hooks","issue_events_url":"https://api.github.com/repos/soonkuk/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/soonkuk/sebak/events","assignees_url":"https://api.github.com/repos/soonkuk/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/soonkuk/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/soonkuk/sebak/tags","blobs_url":"https://api.github.com/repos/soonkuk/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soonkuk/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soonkuk/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/soonkuk/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soonkuk/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/soonkuk/sebak/languages","stargazers_url":"https://api.github.com/repos/soonkuk/sebak/stargazers","contributors_url":"https://api.github.com/repos/soonkuk/sebak/contributors","subscribers_url":"https://api.github.com/repos/soonkuk/sebak/subscribers","subscription_url":"https://api.github.com/repos/soonkuk/sebak/subscription","commits_url":"https://api.github.com/repos/soonkuk/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/soonkuk/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/soonkuk/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/soonkuk/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/soonkuk/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/soonkuk/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soonkuk/sebak/merges","archive_url":"https://api.github.com/repos/soonkuk/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soonkuk/sebak/downloads","issues_url":"https://api.github.com/repos/soonkuk/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/soonkuk/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/soonkuk/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/soonkuk/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soonkuk/sebak/labels{/name}","releases_url":"https://api.github.com/repos/soonkuk/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/soonkuk/sebak/deployments","created_at":"2018-08-29T01:34:39Z","updated_at":"2018-09-12T02:28:59Z","pushed_at":"2018-10-02T11:34:47Z","git_url":"git://github.com/soonkuk/sebak.git","ssh_url":"git@github.com:soonkuk/sebak.git","clone_url":"https://github.com/soonkuk/sebak.git","svn_url":"https://github.com/soonkuk/sebak","homepage":"https://boscoin.io","size":1188,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bosnet:master","ref":"master","sha":"fdd28f3de34f322be685ba38f1308ea2134c4499","user":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"repo":{"id":129848943,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4NDg5NDM=","name":"sebak","full_name":"bosnet/sebak","private":false,"owner":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bosnet/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":false,"url":"https://api.github.com/repos/bosnet/sebak","forks_url":"https://api.github.com/repos/bosnet/sebak/forks","keys_url":"https://api.github.com/repos/bosnet/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bosnet/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bosnet/sebak/teams","hooks_url":"https://api.github.com/repos/bosnet/sebak/hooks","issue_events_url":"https://api.github.com/repos/bosnet/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/bosnet/sebak/events","assignees_url":"https://api.github.com/repos/bosnet/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/bosnet/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/bosnet/sebak/tags","blobs_url":"https://api.github.com/repos/bosnet/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bosnet/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bosnet/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/bosnet/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/bosnet/sebak/languages","stargazers_url":"https://api.github.com/repos/bosnet/sebak/stargazers","contributors_url":"https://api.github.com/repos/bosnet/sebak/contributors","subscribers_url":"https://api.github.com/repos/bosnet/sebak/subscribers","subscription_url":"https://api.github.com/repos/bosnet/sebak/subscription","commits_url":"https://api.github.com/repos/bosnet/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/bosnet/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/bosnet/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/bosnet/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/bosnet/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/bosnet/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bosnet/sebak/merges","archive_url":"https://api.github.com/repos/bosnet/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bosnet/sebak/downloads","issues_url":"https://api.github.com/repos/bosnet/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/bosnet/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/bosnet/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/bosnet/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bosnet/sebak/labels{/name}","releases_url":"https://api.github.com/repos/bosnet/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/bosnet/sebak/deployments","created_at":"2018-04-17T05:05:34Z","updated_at":"2018-10-04T05:16:48Z","pushed_at":"2018-10-04T07:10:01Z","git_url":"git://github.com/bosnet/sebak.git","ssh_url":"git@github.com:bosnet/sebak.git","clone_url":"https://github.com/bosnet/sebak.git","svn_url":"https://github.com/bosnet/sebak","homepage":"https://boscoin.io","size":1193,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":82,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/433"},"html":{"href":"https://github.com/bosnet/sebak/pull/433"},"issue":{"href":"https://api.github.com/repos/bosnet/sebak/issues/433"},"comments":{"href":"https://api.github.com/repos/bosnet/sebak/issues/433/comments"},"review_comments":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/433/comments"},"review_comment":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/433/commits"},"statuses":{"href":"https://api.github.com/repos/bosnet/sebak/statuses/d10e59a265edcb33cc95d25d1d068f4624496a5c"}},"author_association":"NONE"}}
{"actor":{"display_login":"soonkuk"}}