{"action":"created","issue":{"url":"https://api.github.com/repos/adplug/adplug/issues/70","repository_url":"https://api.github.com/repos/adplug/adplug","labels_url":"https://api.github.com/repos/adplug/adplug/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/adplug/adplug/issues/70/comments","events_url":"https://api.github.com/repos/adplug/adplug/issues/70/events","html_url":"https://github.com/adplug/adplug/issues/70","id":376216334,"node_id":"MDU6SXNzdWUzNzYyMTYzMzQ=","number":70,"title":"User configurable FREQ_OFFSET? ","user":{"login":"PalMusicFan","id":25916579,"node_id":"MDQ6VXNlcjI1OTE2NTc5","avatar_url":"https://avatars1.githubusercontent.com/u/25916579?v=4","gravatar_id":"","url":"https://api.github.com/users/PalMusicFan","html_url":"https://github.com/PalMusicFan","followers_url":"https://api.github.com/users/PalMusicFan/followers","following_url":"https://api.github.com/users/PalMusicFan/following{/other_user}","gists_url":"https://api.github.com/users/PalMusicFan/gists{/gist_id}","starred_url":"https://api.github.com/users/PalMusicFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PalMusicFan/subscriptions","organizations_url":"https://api.github.com/users/PalMusicFan/orgs","repos_url":"https://api.github.com/users/PalMusicFan/repos","events_url":"https://api.github.com/users/PalMusicFan/events{/privacy}","received_events_url":"https://api.github.com/users/PalMusicFan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-01T01:11:48Z","updated_at":"2018-11-01T10:10:15Z","closed_at":null,"author_association":"NONE","body":"The surroundopl is really a fantastic enhancement of the OPL2 mono music formats. However, as I found in \"surroundopl.h\", the FREQ_OFFSET of the right channel is not configurable in run-time. Though \"128.0\" performs well in most of the tracks, we have found some percussion sound effects not compatible with it. Please refer to the DRO clip attached. As we heard, there is a percussion sound effect sounds well in the left channel while there is a distortion in the right channel. \r\n\r\nAlthough \"384.0\" solves this problem and the stereo effect is still nice, I have no idea whether this value is universally suitable. So, is it better to make it user configurable?\r\n\r\nThanks so much!  \r\n\r\n[pal_percussion.zip](https://github.com/adplug/adplug/files/2536861/pal_percussion.zip)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/adplug/adplug/issues/comments/434994165","html_url":"https://github.com/adplug/adplug/issues/70#issuecomment-434994165","issue_url":"https://api.github.com/repos/adplug/adplug/issues/70","id":434994165,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDk5NDE2NQ==","user":{"login":"Malvineous","id":171656,"node_id":"MDQ6VXNlcjE3MTY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/171656?v=4","gravatar_id":"","url":"https://api.github.com/users/Malvineous","html_url":"https://github.com/Malvineous","followers_url":"https://api.github.com/users/Malvineous/followers","following_url":"https://api.github.com/users/Malvineous/following{/other_user}","gists_url":"https://api.github.com/users/Malvineous/gists{/gist_id}","starred_url":"https://api.github.com/users/Malvineous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Malvineous/subscriptions","organizations_url":"https://api.github.com/users/Malvineous/orgs","repos_url":"https://api.github.com/users/Malvineous/repos","events_url":"https://api.github.com/users/Malvineous/events{/privacy}","received_events_url":"https://api.github.com/users/Malvineous/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T10:10:15Z","updated_at":"2018-11-01T10:10:15Z","author_association":"MEMBER","body":"I'm not sure that it's worth the effort of making it user configurable, however I'm open to accepting patches.  I will try to get some time to listen to the DRO clip as it sounds like the problem is that the frequency transposition isn't working correctly, which means changing the offset will just move the problem note to some other frequency instead.  So better to fix the frequency calculations so the problem goes away entirely.\r\n\r\nIn my own early experiments, values much below 110 made the effect difficult to notice, and values above 150 started to introduce dissonance making the songs sound off-key, so the actual range of values that sounded good was so small I didn't think it would be useful for end-users to be able to change it."}}
{"actor":{"display_login":"Malvineous"}}