{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack/issues/8409","repository_url":"https://api.github.com/repos/webpack/webpack","labels_url":"https://api.github.com/repos/webpack/webpack/issues/8409/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/8409/comments","events_url":"https://api.github.com/repos/webpack/webpack/issues/8409/events","html_url":"https://github.com/webpack/webpack/pull/8409","id":383671675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDg0NDU4","number":8409,"title":"fix: report existing errors before async queue stop error","user":{"login":"hulkish","id":139332,"node_id":"MDQ6VXNlcjEzOTMzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/139332?v=4","gravatar_id":"","url":"https://api.github.com/users/hulkish","html_url":"https://github.com/hulkish","followers_url":"https://api.github.com/users/hulkish/followers","following_url":"https://api.github.com/users/hulkish/following{/other_user}","gists_url":"https://api.github.com/users/hulkish/gists{/gist_id}","starred_url":"https://api.github.com/users/hulkish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hulkish/subscriptions","organizations_url":"https://api.github.com/users/hulkish/orgs","repos_url":"https://api.github.com/users/hulkish/repos","events_url":"https://api.github.com/users/hulkish/events{/privacy}","received_events_url":"https://api.github.com/users/hulkish/received_events","type":"User","site_admin":false},"labels":[{"id":572709861,"node_id":"MDU6TGFiZWw1NzI3MDk4NjE=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-not-ok","name":"PR: CI-not-ok","color":"d93f0b","default":false},{"id":689140390,"node_id":"MDU6TGFiZWw2ODkxNDAzOTA=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20next","name":"PR: next","color":"8b32d3","default":false},{"id":572817412,"node_id":"MDU6TGFiZWw1NzI4MTc0MTI=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20review-outdated","name":"PR: review-outdated","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-22T23:22:07Z","updated_at":"2018-11-23T11:05:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/8409","html_url":"https://github.com/webpack/webpack/pull/8409","diff_url":"https://github.com/webpack/webpack/pull/8409.diff","patch_url":"https://github.com/webpack/webpack/pull/8409.patch"},"body":"https://github.com/webpack/webpack/issues/8408\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\nbugfix\r\n\r\n**Did you add tests for your changes?**\r\n\r\nNo, should I?\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\nNo\r\n\r\n**What needs to be documented once your changes are merged?**\r\n\r\nN/A\r\n"},"comment":{"url":"https://api.github.com/repos/webpack/webpack/issues/comments/441212952","html_url":"https://github.com/webpack/webpack/pull/8409#issuecomment-441212952","issue_url":"https://api.github.com/repos/webpack/webpack/issues/8409","id":441212952,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTIxMjk1Mg==","user":{"login":"hulkish","id":139332,"node_id":"MDQ6VXNlcjEzOTMzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/139332?v=4","gravatar_id":"","url":"https://api.github.com/users/hulkish","html_url":"https://github.com/hulkish","followers_url":"https://api.github.com/users/hulkish/followers","following_url":"https://api.github.com/users/hulkish/following{/other_user}","gists_url":"https://api.github.com/users/hulkish/gists{/gist_id}","starred_url":"https://api.github.com/users/hulkish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hulkish/subscriptions","organizations_url":"https://api.github.com/users/hulkish/orgs","repos_url":"https://api.github.com/users/hulkish/repos","events_url":"https://api.github.com/users/hulkish/events{/privacy}","received_events_url":"https://api.github.com/users/hulkish/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T11:05:38Z","updated_at":"2018-11-23T11:05:38Z","author_association":"CONTRIBUTOR","body":"not really sure what to do about this:\r\n```\r\nlib/Compilation.js:842:48 - error TS2551: Property 'error' does not exist on type 'Module'. Did you mean 'errors'?\r\n\r\n842  \t\t\t\t\tif (module.error) return callback(module.error);\r\n     \t\t\t\t\t                                         ~~~~~\r\n\r\n  lib/Module.js:103:3\r\n    103  \tthis.errors = [];\r\n         \t~~~~~~~~~~~~~~~~\r\n    'errors' is declared here.\r\n```\r\n\r\nSeems like a tsdoc bug. NormalModule defines a `.error` prop."}}
{"actor":{"display_login":"hulkish"}}