{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/221409121","pull_request_review_id":160058808,"id":221409121,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQwOTEyMQ==","diff_hunk":"@@ -480,6 +484,9 @@ func (ds *DiscoveryService) ConfigUpdate(full bool) {\n \tdefer clearCacheMutex.Unlock()\n \n \tif full {\n+\t\tif !ds.fullPush && debugDebounce {","path":"pilot/pkg/proxy/envoy/discovery.go","position":119,"original_position":46,"commit_id":"eaeb7d18eba97922fbbb3e1ac7de3ca517c96cd7","original_commit_id":"eaeb7d18eba97922fbbb3e1ac7de3ca517c96cd7","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"this is very confusing and unintuitive. I agree with @incfly that the naming/structure of this stuff is not clear. Can you please rename these booleans?","created_at":"2018-09-29T00:53:37Z","updated_at":"2018-09-29T00:53:37Z","html_url":"https://github.com/istio/istio/pull/8722#discussion_r221409121","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/8722","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/221409121"},"html":{"href":"https://github.com/istio/istio/pull/8722#discussion_r221409121"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/8722"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8722","id":215660941,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjYwOTQx","html_url":"https://github.com/istio/istio/pull/8722","diff_url":"https://github.com/istio/istio/pull/8722.diff","patch_url":"https://github.com/istio/istio/pull/8722.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/8722","number":8722,"state":"open","locked":false,"title":"Incremental EDS","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"body":"- added a mechanism for service discovery to update 'shards' of endpoints\r\n- new data structures optimized for endpoint update ( IstioEndpoint has minimum info needed and allows caching the proto )\r\n- optimized the update path - only affected shard will be changed without triggering a full cache invalidation\r\n- rewrote the EDS tests - which were testing the 0.7 method, no longer used\r\n- added a ADS client mirroring envoy behavior, to simplify testing (the load tester using this will be in separate PR)\r\n- optimized the incremental push update path.","created_at":"2018-09-14T17:26:35Z","updated_at":"2018-09-29T00:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d658d2135300ccea9046a8221a354c8d2d342d32","assignee":null,"assignees":[],"requested_reviewers":[{"login":"GregHanson","id":19473391,"node_id":"MDQ6VXNlcjE5NDczMzkx","avatar_url":"https://avatars3.githubusercontent.com/u/19473391?v=4","gravatar_id":"","url":"https://api.github.com/users/GregHanson","html_url":"https://github.com/GregHanson","followers_url":"https://api.github.com/users/GregHanson/followers","following_url":"https://api.github.com/users/GregHanson/following{/other_user}","gists_url":"https://api.github.com/users/GregHanson/gists{/gist_id}","starred_url":"https://api.github.com/users/GregHanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregHanson/subscriptions","organizations_url":"https://api.github.com/users/GregHanson/orgs","repos_url":"https://api.github.com/users/GregHanson/repos","events_url":"https://api.github.com/users/GregHanson/events{/privacy}","received_events_url":"https://api.github.com/users/GregHanson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/8722/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/8722/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/8722/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/eaeb7d18eba97922fbbb3e1ac7de3ca517c96cd7","head":{"label":"costinm:103-eds","ref":"103-eds","sha":"eaeb7d18eba97922fbbb3e1ac7de3ca517c96cd7","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"repo":{"id":100538352,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MzgzNTI=","name":"istio","full_name":"costinm/istio","private":false,"owner":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/costinm/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":true,"url":"https://api.github.com/repos/costinm/istio","forks_url":"https://api.github.com/repos/costinm/istio/forks","keys_url":"https://api.github.com/repos/costinm/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/costinm/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/costinm/istio/teams","hooks_url":"https://api.github.com/repos/costinm/istio/hooks","issue_events_url":"https://api.github.com/repos/costinm/istio/issues/events{/number}","events_url":"https://api.github.com/repos/costinm/istio/events","assignees_url":"https://api.github.com/repos/costinm/istio/assignees{/user}","branches_url":"https://api.github.com/repos/costinm/istio/branches{/branch}","tags_url":"https://api.github.com/repos/costinm/istio/tags","blobs_url":"https://api.github.com/repos/costinm/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/costinm/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/costinm/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/costinm/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/costinm/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/costinm/istio/languages","stargazers_url":"https://api.github.com/repos/costinm/istio/stargazers","contributors_url":"https://api.github.com/repos/costinm/istio/contributors","subscribers_url":"https://api.github.com/repos/costinm/istio/subscribers","subscription_url":"https://api.github.com/repos/costinm/istio/subscription","commits_url":"https://api.github.com/repos/costinm/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/costinm/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/costinm/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/costinm/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/costinm/istio/contents/{+path}","compare_url":"https://api.github.com/repos/costinm/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/costinm/istio/merges","archive_url":"https://api.github.com/repos/costinm/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/costinm/istio/downloads","issues_url":"https://api.github.com/repos/costinm/istio/issues{/number}","pulls_url":"https://api.github.com/repos/costinm/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/costinm/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/costinm/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/costinm/istio/labels{/name}","releases_url":"https://api.github.com/repos/costinm/istio/releases{/id}","deployments_url":"https://api.github.com/repos/costinm/istio/deployments","created_at":"2017-08-16T22:38:24Z","updated_at":"2018-04-27T23:29:00Z","pushed_at":"2018-09-28T20:54:41Z","git_url":"git://github.com/costinm/istio.git","ssh_url":"git@github.com:costinm/istio.git","clone_url":"https://github.com/costinm/istio.git","svn_url":"https://github.com/costinm/istio","homepage":"https://istio.io","size":125849,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.0","ref":"release-1.0","sha":"cbe9c05c470ec1924f7bcf02334b183e7e6175cb","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-09-29T00:52:07Z","pushed_at":"2018-09-29T00:52:43Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":49622,"stargazers_count":12016,"watchers_count":12016,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1770,"mirror_url":null,"archived":false,"open_issues_count":960,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1770,"open_issues":960,"watchers":12016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/8722"},"html":{"href":"https://github.com/istio/istio/pull/8722"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/8722"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/8722/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/8722/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/8722/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/eaeb7d18eba97922fbbb3e1ac7de3ca517c96cd7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rshriram"}}