{"action":"created","issue":{"url":"https://api.github.com/repos/OA-PASS/java-fedora-client/issues/66","repository_url":"https://api.github.com/repos/OA-PASS/java-fedora-client","labels_url":"https://api.github.com/repos/OA-PASS/java-fedora-client/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/OA-PASS/java-fedora-client/issues/66/comments","events_url":"https://api.github.com/repos/OA-PASS/java-fedora-client/issues/66/events","html_url":"https://github.com/OA-PASS/java-fedora-client/pull/66","id":367786866,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTE0NTQw","number":66,"title":"Maven central compatibility","user":{"login":"birkland","id":517881,"node_id":"MDQ6VXNlcjUxNzg4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/517881?v=4","gravatar_id":"","url":"https://api.github.com/users/birkland","html_url":"https://github.com/birkland","followers_url":"https://api.github.com/users/birkland/followers","following_url":"https://api.github.com/users/birkland/following{/other_user}","gists_url":"https://api.github.com/users/birkland/gists{/gist_id}","starred_url":"https://api.github.com/users/birkland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birkland/subscriptions","organizations_url":"https://api.github.com/users/birkland/orgs","repos_url":"https://api.github.com/users/birkland/repos","events_url":"https://api.github.com/users/birkland/events{/privacy}","received_events_url":"https://api.github.com/users/birkland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-08T13:19:57Z","updated_at":"2018-10-08T19:31:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OA-PASS/java-fedora-client/pulls/66","html_url":"https://github.com/OA-PASS/java-fedora-client/pull/66","diff_url":"https://github.com/OA-PASS/java-fedora-client/pull/66.diff","patch_url":"https://github.com/OA-PASS/java-fedora-client/pull/66.patch"},"body":"## Overview\r\n\r\n* Adds the javadoc plugin, for attaching javadoc artifacts when deploying (a maven central requirement)\r\n  * Lots of javadoc fixes\r\n* Adds the release and GPG plugins, for releasing and signing artifacts\r\n* Adds license, developers, and scm sections to the POM, as required by Maven Central\r\n\r\nWith this, the release plugin should work, and maven artifacts should pass maven central validation\r\n\r\nPatches derived from this will be applied to `maintenance-0.3` in support of #60 \r\n\r\n## To test\r\nUse the release plugin to create a release locally\r\n\r\n    export RELEASE=0.4.1\r\n    export NEXT=0.4.2-SNAPSHOT\r\n\r\n    mvn release:prepare -DreleaseVersion=$RELEASE -Dtag=$RELEASE -DdevelopmentVersion=$NEXT -DautoVersionSubmodules=true -DpushChanges=false\r\n\r\nThe next step will upload to the maven central staging (would be nice to try out.  There is no requirement that it be promoted to maven central as a true release if you do that; it can be cancelled and deleted from stage) .  If you want to do this, [sign up with sonatype](https://issues.sonatype.org/secure/Signup!default.jspa) and ping @birkland to create a JIRA ticket with the Sonatype people to grant access to sonatype for deploying DC artifacts to the OSS snapshot repo and maven central.  You'd also want to generate [some gpg artifact signing keys](https://central.sonatype.org/pages/working-with-pgp-signatures.html) \r\n\r\n    mvn release:perform -Dgoals=deploy -DlocalCheckout\r\n\r\nIf you get that far and actualy did upload to the maven central staging repo, you can validate the uploaded artifacts by doing the following:\r\n* Go to https://oss.sonatype.org/index.html  and log in\r\n* Click Staging Repositories in left navigation, under \"Build Promotion\"\r\n* Either search for \"dataconservancy\" in upper right search box, or scroll through the liset\r\n* Select repository and verify that artifacts present in the Content tab\r\n* Read https://central.sonatype.org/pages/releasing-the-deployment.html\r\n* Click `close` near the TOP of the page.  This will make it undergo validation, which takes a little time\r\n* Click `refresh` near the TOP of the page, which will reset the status.  If the operation has completed successfully, you'll see the repository in a \"closed\" state.  Feel free to look at the activity tab to see the validation steps.\r\n* Click `release` to release (I don't think you want to to this when testing a PR!), or `drop` to drop\r\n\r\nIf this were a real release, you'd then push the tags created by the maven release plugin to github like `git push origin --tag`, and also push the branch you're on (e.g. `master`).  But since this is a PR, you'd do `git tag -d $RELEASE` to delete the tag, and also a `git reset --hard` to walk back your local tree.  The release plugin will have made commits bumping the version to the next snap.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OA-PASS/java-fedora-client/issues/comments/427952709","html_url":"https://github.com/OA-PASS/java-fedora-client/pull/66#issuecomment-427952709","issue_url":"https://api.github.com/repos/OA-PASS/java-fedora-client/issues/66","id":427952709,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzk1MjcwOQ==","user":{"login":"birkland","id":517881,"node_id":"MDQ6VXNlcjUxNzg4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/517881?v=4","gravatar_id":"","url":"https://api.github.com/users/birkland","html_url":"https://github.com/birkland","followers_url":"https://api.github.com/users/birkland/followers","following_url":"https://api.github.com/users/birkland/following{/other_user}","gists_url":"https://api.github.com/users/birkland/gists{/gist_id}","starred_url":"https://api.github.com/users/birkland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birkland/subscriptions","organizations_url":"https://api.github.com/users/birkland/orgs","repos_url":"https://api.github.com/users/birkland/repos","events_url":"https://api.github.com/users/birkland/events{/privacy}","received_events_url":"https://api.github.com/users/birkland/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T19:31:10Z","updated_at":"2018-10-08T19:31:10Z","author_association":"CONTRIBUTOR","body":"Ok, I plan on making the javadoc edits\n\nOn Mon, Oct 8, 2018, 3:24 PM Karen Hanson <notifications@github.com> wrote:\n\n> *@karenhanson* approved this pull request.\n>\n> The build works. I added some feedback on the javadoc as I went through.\n> They are all minor edits, nothing showstopping, so I have marked this as\n> approved.\n> ------------------------------\n>\n> In\n> pass-client-api/src/main/java/org/dataconservancy/pass/client/PassClient.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223419697>\n> :\n>\n> >       */\n>      public void deleteResource(URI uri);\n>\n>      /**\n>       * Retrieves the entity matching the URI provided, populates the appropriate Java class with its values.\n> -     * @param uri\n> -     * @param modelClass\n> -     * @return\n> +     * @param uri The URI if the resource to be read.\n>\n> \"The URI *of* ...\"\n> ------------------------------\n>\n> In\n> pass-client-api/src/main/java/org/dataconservancy/pass/client/PassClient.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223419958>\n> :\n>\n> >       */\n>      public <T extends PassEntity> T readResource(URI uri, Class<T> modelClass);\n>\n>      /**\n>       * Retrieves URI for a SINGLE RECORD by matching the entity type and filtering by the field\n>       * specified using the value provided. For example, to find the {@link Grant} using the {@code awardNumber}:\n> -     * <pre>\n> -     *   {@code\n> -     *   String awardNum = \"abcdef123\";\n> -     *   URI grantId = findByAttribute(Grant.class, \"awardNumber\", awardNum);\n> +     *\n> +     * <p>\n> +     * For example, to find the Grant using the\n> +     * awardNumber:\n>\n> wrapped weirdly, not sure if it matters\n> ------------------------------\n>\n> In\n> pass-client-api/src/main/java/org/dataconservancy/pass/client/PassClient.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223420637>\n> :\n>\n> >       */\n>      public <T extends PassEntity> URI findByAttribute(Class<T> modelClass, String attribute, Object value);\n>\n>\n>      /**\n>       * Retrieves URIs for MULTIPLE MATCHING RECORDS by matching the entity type and filtering by the field\n>       * specified using the value provided. For example, to find {@link Deposit}s using a {@code Repository.id}:\n> -     * <pre>\n> -     *   {@code\n> -     *   URI repositoryId = new URI(\"https://example.com/fedora/repositories/3\");\n> -     *   Set<URI> entityUris = findByAttribute(Deposit.class, \"repository\", repositoryId);\n> -     * }</pre>\n> +     * <p>\n> +     *\n> +     * For example, to find {@link Deposit}s using a Repository.id:\n> +     * </p>\n> +     * <pre>{@code\n>\n> I think this is repeating \"For example, to find... \" from previous line\n> ------------------------------\n>\n> In\n> pass-client-api/src/main/java/org/dataconservancy/pass/client/PassClient.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223421173>\n> :\n>\n> >       */\n>      public <T extends PassEntity> Set<URI> findAllByAttribute(Class<T> modelClass, String attribute, Object value, int limit, int offset);\n>\n>\n>      /**\n>       * Retrieves URIs for MULTIPLE MATCHING RECORDS by matching the entity type and filtering by the attributes\n> -     * and values specified. An \"AND\" operator will be used for searching multiple attributes.\n> +     * and values specified. An \"AND\" operator will be used for searching multiple attributes.\n> +     *\n> +     * <p>\n> +     * An \"AND\" operator will be used for searching multiple attributes.\n>\n> This is repeating previous line\n> ------------------------------\n>\n> In\n> pass-client-api/src/main/java/org/dataconservancy/pass/client/PassClient.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223421367>\n> :\n>\n> >       */\n>      public <T extends PassEntity> Set<URI> findAllByAttributes(Class<T> modelClass, Map<String, Object> attributeValuesMap);\n>\n>\n>      /**\n>       * Retrieves URIs for MULTIPLE MATCHING RECORDS by matching the entity type and filtering by the attributes\n>       * and values specified. For example, to find a Submission using a GrantId and DOI:\n> +     *\n> +     * <p>\n> +     *  For example, to find a Submission using a GrantId and DOI:\n> +     * </p>\n>\n> repeating previous line\n> ------------------------------\n>\n> In\n> pass-model/src/main/java/org/dataconservancy/pass/model/RepositoryCopy.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223423677>\n> :\n>\n> > @@ -153,7 +158,7 @@ public void setAccessUrl(URI accessUrl) {\n>\n>\n>      /**\n> -     * @param copy status the repository's status to set\n> +     * @param copyStatus status the repository's status to set\n>\n> can remove the \"status\" after \"copyStatus\"\n> ------------------------------\n>\n> In\n> pass-status-service/src/main/java/org/dataconservancy/pass/client/util/SubmissionStatusCalculator.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223424673>\n> :\n>\n> >       * Post-Submission calculations uses the {@code Deposits} and {@code RepositoryCopies} associated\n>       * with a {@code Submission's} {@code Repositories} to determine the status of a Submission\n>       * after it has been submitted ({@code Submission.status=true}.\n> -     * @param repositories\n> -     * @param deposits\n> -     * @param repositoryCopies\n> -     * @return\n> +     * </p>\n> +     * @param repositories Submission repositories\n> +     * @param deposits Submission deposits\n> +     * @param repositoryCopies Rubmission repository copies\n>\n> \"Rubmission\"\n> ------------------------------\n>\n> In\n> pass-status-service/src/main/java/org/dataconservancy/pass/client/util/SubmissionStatusCalculator.java\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#discussion_r223424838>\n> :\n>\n> > @@ -80,11 +82,14 @@ public static SubmissionStatus calculatePostSubmissionStatus(List<URI> repositor\n>\n>\n>      /**\n> -     * Calculates the appropriate pre-Submission status based on data provided. Pre-Submission\n> +     * Calculates the appropriate pre-Submission status based on data provided.\n> +     * <p>\n> +     * Pre-Submission\n>\n> wrapping\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/OA-PASS/java-fedora-client/pull/66#pullrequestreview-162542304>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAfm-Zr6UxTxCvcDNC7FnvYxuUSVlGGbks5ui6aAgaJpZM4XM69s>\n> .\n>\n"}}
{"actor":{"display_login":"birkland"}}