{"action":"created","comment":{"url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/comments/194223537","pull_request_review_id":127362494,"id":194223537,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDIyMzUzNw==","diff_hunk":"@@ -52,8 +53,16 @@ class CucumberScalaExtension extends AbstractCucumberExtension {\n \n   @NotNull override def getGlues(@NotNull file: GherkinFile, jGluesFromOtherFiles: JavaSet[String]): JavaCollection[String] = {\n     // never called? wtf\n-    LOG.debug(\"GET GLUES CALLED\")\n-    Collections.emptyList()\n+    import scala.collection.JavaConverters._","path":"src/main/scala/com/github/danielwegener/intellij/cucumber/scala/CucumberScalaExtension.scala","position":35,"original_position":35,"commit_id":"6c50c22e3c70f054c62a5becd3627ff23720ca25","original_commit_id":"6c50c22e3c70f054c62a5becd3627ff23720ca25","user":{"login":"msillence","id":1208867,"node_id":"MDQ6VXNlcjEyMDg4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1208867?v=4","gravatar_id":"","url":"https://api.github.com/users/msillence","html_url":"https://github.com/msillence","followers_url":"https://api.github.com/users/msillence/followers","following_url":"https://api.github.com/users/msillence/following{/other_user}","gists_url":"https://api.github.com/users/msillence/gists{/gist_id}","starred_url":"https://api.github.com/users/msillence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msillence/subscriptions","organizations_url":"https://api.github.com/users/msillence/orgs","repos_url":"https://api.github.com/users/msillence/repos","events_url":"https://api.github.com/users/msillence/events{/privacy}","received_events_url":"https://api.github.com/users/msillence/received_events","type":"User","site_admin":false},"body":"it's called when we right click on the feature and select run.\r\nThe glue package this returns is in the run configuration generated","created_at":"2018-06-09T11:09:35Z","updated_at":"2018-06-09T11:09:35Z","html_url":"https://github.com/danielwegener/intellij-cucumber-scala/pull/38#discussion_r194223537","pull_request_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/comments/194223537"},"html":{"href":"https://github.com/danielwegener/intellij-cucumber-scala/pull/38#discussion_r194223537"},"pull_request":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38"}},"in_reply_to_id":192795337},"pull_request":{"url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38","id":191148829,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMTQ4ODI5","html_url":"https://github.com/danielwegener/intellij-cucumber-scala/pull/38","diff_url":"https://github.com/danielwegener/intellij-cucumber-scala/pull/38.diff","patch_url":"https://github.com/danielwegener/intellij-cucumber-scala/pull/38.patch","issue_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/issues/38","number":38,"state":"open","locked":false,"title":"fix glue detection","user":{"login":"msillence","id":1208867,"node_id":"MDQ6VXNlcjEyMDg4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1208867?v=4","gravatar_id":"","url":"https://api.github.com/users/msillence","html_url":"https://github.com/msillence","followers_url":"https://api.github.com/users/msillence/followers","following_url":"https://api.github.com/users/msillence/following{/other_user}","gists_url":"https://api.github.com/users/msillence/gists{/gist_id}","starred_url":"https://api.github.com/users/msillence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msillence/subscriptions","organizations_url":"https://api.github.com/users/msillence/orgs","repos_url":"https://api.github.com/users/msillence/repos","events_url":"https://api.github.com/users/msillence/events{/privacy}","received_events_url":"https://api.github.com/users/msillence/received_events","type":"User","site_admin":false},"body":"building on pbyrne's work to make the plugin work with intellij 2018.1 I've added support so we can auto detect the glue package.","created_at":"2018-05-29T13:36:11Z","updated_at":"2018-06-09T11:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3d4e76251e376a0b2c6daeebdd8cdaeea8f5e16","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38/commits","review_comments_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38/comments","review_comment_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/issues/38/comments","statuses_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/statuses/6c50c22e3c70f054c62a5becd3627ff23720ca25","head":{"label":"msillence:master","ref":"master","sha":"6c50c22e3c70f054c62a5becd3627ff23720ca25","user":{"login":"msillence","id":1208867,"node_id":"MDQ6VXNlcjEyMDg4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1208867?v=4","gravatar_id":"","url":"https://api.github.com/users/msillence","html_url":"https://github.com/msillence","followers_url":"https://api.github.com/users/msillence/followers","following_url":"https://api.github.com/users/msillence/following{/other_user}","gists_url":"https://api.github.com/users/msillence/gists{/gist_id}","starred_url":"https://api.github.com/users/msillence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msillence/subscriptions","organizations_url":"https://api.github.com/users/msillence/orgs","repos_url":"https://api.github.com/users/msillence/repos","events_url":"https://api.github.com/users/msillence/events{/privacy}","received_events_url":"https://api.github.com/users/msillence/received_events","type":"User","site_admin":false},"repo":{"id":135300210,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMDAyMTA=","name":"intellij-cucumber-scala","full_name":"msillence/intellij-cucumber-scala","owner":{"login":"msillence","id":1208867,"node_id":"MDQ6VXNlcjEyMDg4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1208867?v=4","gravatar_id":"","url":"https://api.github.com/users/msillence","html_url":"https://github.com/msillence","followers_url":"https://api.github.com/users/msillence/followers","following_url":"https://api.github.com/users/msillence/following{/other_user}","gists_url":"https://api.github.com/users/msillence/gists{/gist_id}","starred_url":"https://api.github.com/users/msillence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msillence/subscriptions","organizations_url":"https://api.github.com/users/msillence/orgs","repos_url":"https://api.github.com/users/msillence/repos","events_url":"https://api.github.com/users/msillence/events{/privacy}","received_events_url":"https://api.github.com/users/msillence/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msillence/intellij-cucumber-scala","description":"Enables Reference tracking of glue code when using cucumber-scala DSL.","fork":true,"url":"https://api.github.com/repos/msillence/intellij-cucumber-scala","forks_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/forks","keys_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/teams","hooks_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/hooks","issue_events_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/issues/events{/number}","events_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/events","assignees_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/assignees{/user}","branches_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/branches{/branch}","tags_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/tags","blobs_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/languages","stargazers_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/stargazers","contributors_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/contributors","subscribers_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/subscribers","subscription_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/subscription","commits_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/contents/{+path}","compare_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/merges","archive_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/downloads","issues_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/issues{/number}","pulls_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/labels{/name}","releases_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/releases{/id}","deployments_url":"https://api.github.com/repos/msillence/intellij-cucumber-scala/deployments","created_at":"2018-05-29T13:27:56Z","updated_at":"2018-05-29T13:33:02Z","pushed_at":"2018-05-29T13:33:00Z","git_url":"git://github.com/msillence/intellij-cucumber-scala.git","ssh_url":"git@github.com:msillence/intellij-cucumber-scala.git","clone_url":"https://github.com/msillence/intellij-cucumber-scala.git","svn_url":"https://github.com/msillence/intellij-cucumber-scala","homepage":"https://plugins.jetbrains.com/plugin/7460","size":63,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danielwegener:master","ref":"master","sha":"20883f4be066f94667762caea95c5b7af166fafe","user":{"login":"danielwegener","id":2953619,"node_id":"MDQ6VXNlcjI5NTM2MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2953619?v=4","gravatar_id":"","url":"https://api.github.com/users/danielwegener","html_url":"https://github.com/danielwegener","followers_url":"https://api.github.com/users/danielwegener/followers","following_url":"https://api.github.com/users/danielwegener/following{/other_user}","gists_url":"https://api.github.com/users/danielwegener/gists{/gist_id}","starred_url":"https://api.github.com/users/danielwegener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielwegener/subscriptions","organizations_url":"https://api.github.com/users/danielwegener/orgs","repos_url":"https://api.github.com/users/danielwegener/repos","events_url":"https://api.github.com/users/danielwegener/events{/privacy}","received_events_url":"https://api.github.com/users/danielwegener/received_events","type":"User","site_admin":false},"repo":{"id":19645911,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY0NTkxMQ==","name":"intellij-cucumber-scala","full_name":"danielwegener/intellij-cucumber-scala","owner":{"login":"danielwegener","id":2953619,"node_id":"MDQ6VXNlcjI5NTM2MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2953619?v=4","gravatar_id":"","url":"https://api.github.com/users/danielwegener","html_url":"https://github.com/danielwegener","followers_url":"https://api.github.com/users/danielwegener/followers","following_url":"https://api.github.com/users/danielwegener/following{/other_user}","gists_url":"https://api.github.com/users/danielwegener/gists{/gist_id}","starred_url":"https://api.github.com/users/danielwegener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielwegener/subscriptions","organizations_url":"https://api.github.com/users/danielwegener/orgs","repos_url":"https://api.github.com/users/danielwegener/repos","events_url":"https://api.github.com/users/danielwegener/events{/privacy}","received_events_url":"https://api.github.com/users/danielwegener/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielwegener/intellij-cucumber-scala","description":"Enables Reference tracking of glue code when using cucumber-scala DSL.","fork":false,"url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala","forks_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/forks","keys_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/teams","hooks_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/hooks","issue_events_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/issues/events{/number}","events_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/events","assignees_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/assignees{/user}","branches_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/branches{/branch}","tags_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/tags","blobs_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/languages","stargazers_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/stargazers","contributors_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/contributors","subscribers_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/subscribers","subscription_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/subscription","commits_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/contents/{+path}","compare_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/merges","archive_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/downloads","issues_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/issues{/number}","pulls_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/labels{/name}","releases_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/releases{/id}","deployments_url":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/deployments","created_at":"2014-05-10T16:18:01Z","updated_at":"2018-06-04T20:39:21Z","pushed_at":"2018-06-04T20:40:12Z","git_url":"git://github.com/danielwegener/intellij-cucumber-scala.git","ssh_url":"git@github.com:danielwegener/intellij-cucumber-scala.git","clone_url":"https://github.com/danielwegener/intellij-cucumber-scala.git","svn_url":"https://github.com/danielwegener/intellij-cucumber-scala","homepage":"https://plugins.jetbrains.com/plugin/7460","size":63,"stargazers_count":35,"watchers_count":35,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":19,"open_issues":11,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38"},"html":{"href":"https://github.com/danielwegener/intellij-cucumber-scala/pull/38"},"issue":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/issues/38"},"comments":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/danielwegener/intellij-cucumber-scala/statuses/6c50c22e3c70f054c62a5becd3627ff23720ca25"}},"author_association":"NONE"}}
{"actor":{"display_login":"msillence"}}