{"action":"created","comment":{"url":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/comments/170537409","pull_request_review_id":99235210,"id":170537409,"diff_hunk":"@@ -10,7 +10,7 @@ namespace FuseTest\n \t\t\n \t\tNOTE: Taken from the charting in premiumlibs. Stuck in FuseTest for now since there is no use in fuselibs yet other than for testing.\n \t*/\n-\tpublic abstract class ObservableData : IObservable\n+\tabstract class ObservableData : IObservable","path":"Source/Fuse.Common/Tests/FuseTest/ObservableList.uno","position":5,"original_position":5,"commit_id":"759250a1c19ec23371738dbc90c97c39823651a2","original_commit_id":"9b4a3ac050b3f87e9241a85174af2ec9b7664123","user":{"login":"ollef","id":197549,"avatar_url":"https://avatars3.githubusercontent.com/u/197549?v=4","gravatar_id":"","url":"https://api.github.com/users/ollef","html_url":"https://github.com/ollef","followers_url":"https://api.github.com/users/ollef/followers","following_url":"https://api.github.com/users/ollef/following{/other_user}","gists_url":"https://api.github.com/users/ollef/gists{/gist_id}","starred_url":"https://api.github.com/users/ollef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollef/subscriptions","organizations_url":"https://api.github.com/users/ollef/orgs","repos_url":"https://api.github.com/users/ollef/repos","events_url":"https://api.github.com/users/ollef/events{/privacy}","received_events_url":"https://api.github.com/users/ollef/received_events","type":"User","site_admin":false},"body":"Sure, but e.g. this line basically means it's exposed publicly if the surrounding class is public.\r\n\r\n```\r\nvirtual protected void OnSubscribe(IObserver observer)\r\n```","created_at":"2018-02-26T09:44:40Z","updated_at":"2018-02-26T09:44:40Z","html_url":"https://github.com/fusetools/fuselibs-public/pull/1031#discussion_r170537409","pull_request_url":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/comments/170537409"},"html":{"href":"https://github.com/fusetools/fuselibs-public/pull/1031#discussion_r170537409"},"pull_request":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031"}},"in_reply_to_id":169615850},"pull_request":{"url":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031","id":170136508,"html_url":"https://github.com/fusetools/fuselibs-public/pull/1031","diff_url":"https://github.com/fusetools/fuselibs-public/pull/1031.diff","patch_url":"https://github.com/fusetools/fuselibs-public/pull/1031.patch","issue_url":"https://api.github.com/repos/fusetools/fuselibs-public/issues/1031","number":1031,"state":"open","locked":false,"title":"Change some members from protected internal to just internal","user":{"login":"ollef","id":197549,"avatar_url":"https://avatars3.githubusercontent.com/u/197549?v=4","gravatar_id":"","url":"https://api.github.com/users/ollef","html_url":"https://github.com/ollef","followers_url":"https://api.github.com/users/ollef/followers","following_url":"https://api.github.com/users/ollef/following{/other_user}","gists_url":"https://api.github.com/users/ollef/gists{/gist_id}","starred_url":"https://api.github.com/users/ollef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollef/subscriptions","organizations_url":"https://api.github.com/users/ollef/orgs","repos_url":"https://api.github.com/users/ollef/repos","events_url":"https://api.github.com/users/ollef/events{/privacy}","received_events_url":"https://api.github.com/users/ollef/received_events","type":"User","site_admin":false},"body":"These protected internal members returned or took as parameter internal entities, which will soon be an error in Uno (matching C#). A member being protected internal means that it's visible to derived classes outside the package, but this wasn't really possible for these members since they were mentioning internal entities.\r\n\r\nThis PR contains:\r\n- [ ] Changelog\r\n- [ ] Documentation\r\n- [ ] Tests\r\n","created_at":"2018-02-20T09:19:25Z","updated_at":"2018-02-26T09:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08f6df931723010e59b2e8209f7bf37b268e282d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fusetools/fuselibs-public/issues/1031/comments","statuses_url":"https://api.github.com/repos/fusetools/fuselibs-public/statuses/759250a1c19ec23371738dbc90c97c39823651a2","head":{"label":"ollef:protected-internal","ref":"protected-internal","sha":"759250a1c19ec23371738dbc90c97c39823651a2","user":{"login":"ollef","id":197549,"avatar_url":"https://avatars3.githubusercontent.com/u/197549?v=4","gravatar_id":"","url":"https://api.github.com/users/ollef","html_url":"https://github.com/ollef","followers_url":"https://api.github.com/users/ollef/followers","following_url":"https://api.github.com/users/ollef/following{/other_user}","gists_url":"https://api.github.com/users/ollef/gists{/gist_id}","starred_url":"https://api.github.com/users/ollef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollef/subscriptions","organizations_url":"https://api.github.com/users/ollef/orgs","repos_url":"https://api.github.com/users/ollef/repos","events_url":"https://api.github.com/users/ollef/events{/privacy}","received_events_url":"https://api.github.com/users/ollef/received_events","type":"User","site_admin":false},"repo":{"id":92834743,"name":"fuselibs-public","full_name":"ollef/fuselibs-public","owner":{"login":"ollef","id":197549,"avatar_url":"https://avatars3.githubusercontent.com/u/197549?v=4","gravatar_id":"","url":"https://api.github.com/users/ollef","html_url":"https://github.com/ollef","followers_url":"https://api.github.com/users/ollef/followers","following_url":"https://api.github.com/users/ollef/following{/other_user}","gists_url":"https://api.github.com/users/ollef/gists{/gist_id}","starred_url":"https://api.github.com/users/ollef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollef/subscriptions","organizations_url":"https://api.github.com/users/ollef/orgs","repos_url":"https://api.github.com/users/ollef/repos","events_url":"https://api.github.com/users/ollef/events{/privacy}","received_events_url":"https://api.github.com/users/ollef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ollef/fuselibs-public","description":null,"fork":true,"url":"https://api.github.com/repos/ollef/fuselibs-public","forks_url":"https://api.github.com/repos/ollef/fuselibs-public/forks","keys_url":"https://api.github.com/repos/ollef/fuselibs-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ollef/fuselibs-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ollef/fuselibs-public/teams","hooks_url":"https://api.github.com/repos/ollef/fuselibs-public/hooks","issue_events_url":"https://api.github.com/repos/ollef/fuselibs-public/issues/events{/number}","events_url":"https://api.github.com/repos/ollef/fuselibs-public/events","assignees_url":"https://api.github.com/repos/ollef/fuselibs-public/assignees{/user}","branches_url":"https://api.github.com/repos/ollef/fuselibs-public/branches{/branch}","tags_url":"https://api.github.com/repos/ollef/fuselibs-public/tags","blobs_url":"https://api.github.com/repos/ollef/fuselibs-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ollef/fuselibs-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ollef/fuselibs-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/ollef/fuselibs-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ollef/fuselibs-public/statuses/{sha}","languages_url":"https://api.github.com/repos/ollef/fuselibs-public/languages","stargazers_url":"https://api.github.com/repos/ollef/fuselibs-public/stargazers","contributors_url":"https://api.github.com/repos/ollef/fuselibs-public/contributors","subscribers_url":"https://api.github.com/repos/ollef/fuselibs-public/subscribers","subscription_url":"https://api.github.com/repos/ollef/fuselibs-public/subscription","commits_url":"https://api.github.com/repos/ollef/fuselibs-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/ollef/fuselibs-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/ollef/fuselibs-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/ollef/fuselibs-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/ollef/fuselibs-public/contents/{+path}","compare_url":"https://api.github.com/repos/ollef/fuselibs-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ollef/fuselibs-public/merges","archive_url":"https://api.github.com/repos/ollef/fuselibs-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ollef/fuselibs-public/downloads","issues_url":"https://api.github.com/repos/ollef/fuselibs-public/issues{/number}","pulls_url":"https://api.github.com/repos/ollef/fuselibs-public/pulls{/number}","milestones_url":"https://api.github.com/repos/ollef/fuselibs-public/milestones{/number}","notifications_url":"https://api.github.com/repos/ollef/fuselibs-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ollef/fuselibs-public/labels{/name}","releases_url":"https://api.github.com/repos/ollef/fuselibs-public/releases{/id}","deployments_url":"https://api.github.com/repos/ollef/fuselibs-public/deployments","created_at":"2017-05-30T13:18:04Z","updated_at":"2017-05-30T13:18:09Z","pushed_at":"2018-02-22T08:43:10Z","git_url":"git://github.com/ollef/fuselibs-public.git","ssh_url":"git@github.com:ollef/fuselibs-public.git","clone_url":"https://github.com/ollef/fuselibs-public.git","svn_url":"https://github.com/ollef/fuselibs-public","homepage":null,"size":20630,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fusetools:master","ref":"master","sha":"71b96dcacfdbd3312160ec7f7f62dd205aef3cb4","user":{"login":"fusetools","id":10243317,"avatar_url":"https://avatars1.githubusercontent.com/u/10243317?v=4","gravatar_id":"","url":"https://api.github.com/users/fusetools","html_url":"https://github.com/fusetools","followers_url":"https://api.github.com/users/fusetools/followers","following_url":"https://api.github.com/users/fusetools/following{/other_user}","gists_url":"https://api.github.com/users/fusetools/gists{/gist_id}","starred_url":"https://api.github.com/users/fusetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusetools/subscriptions","organizations_url":"https://api.github.com/users/fusetools/orgs","repos_url":"https://api.github.com/users/fusetools/repos","events_url":"https://api.github.com/users/fusetools/events{/privacy}","received_events_url":"https://api.github.com/users/fusetools/received_events","type":"Organization","site_admin":false},"repo":{"id":89240957,"name":"fuselibs-public","full_name":"fusetools/fuselibs-public","owner":{"login":"fusetools","id":10243317,"avatar_url":"https://avatars1.githubusercontent.com/u/10243317?v=4","gravatar_id":"","url":"https://api.github.com/users/fusetools","html_url":"https://github.com/fusetools","followers_url":"https://api.github.com/users/fusetools/followers","following_url":"https://api.github.com/users/fusetools/following{/other_user}","gists_url":"https://api.github.com/users/fusetools/gists{/gist_id}","starred_url":"https://api.github.com/users/fusetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusetools/subscriptions","organizations_url":"https://api.github.com/users/fusetools/orgs","repos_url":"https://api.github.com/users/fusetools/repos","events_url":"https://api.github.com/users/fusetools/events{/privacy}","received_events_url":"https://api.github.com/users/fusetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fusetools/fuselibs-public","description":"Fuselibs is the Uno-libraries that provide the UI framework used in Fuse apps.","fork":false,"url":"https://api.github.com/repos/fusetools/fuselibs-public","forks_url":"https://api.github.com/repos/fusetools/fuselibs-public/forks","keys_url":"https://api.github.com/repos/fusetools/fuselibs-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fusetools/fuselibs-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fusetools/fuselibs-public/teams","hooks_url":"https://api.github.com/repos/fusetools/fuselibs-public/hooks","issue_events_url":"https://api.github.com/repos/fusetools/fuselibs-public/issues/events{/number}","events_url":"https://api.github.com/repos/fusetools/fuselibs-public/events","assignees_url":"https://api.github.com/repos/fusetools/fuselibs-public/assignees{/user}","branches_url":"https://api.github.com/repos/fusetools/fuselibs-public/branches{/branch}","tags_url":"https://api.github.com/repos/fusetools/fuselibs-public/tags","blobs_url":"https://api.github.com/repos/fusetools/fuselibs-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fusetools/fuselibs-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fusetools/fuselibs-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/fusetools/fuselibs-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fusetools/fuselibs-public/statuses/{sha}","languages_url":"https://api.github.com/repos/fusetools/fuselibs-public/languages","stargazers_url":"https://api.github.com/repos/fusetools/fuselibs-public/stargazers","contributors_url":"https://api.github.com/repos/fusetools/fuselibs-public/contributors","subscribers_url":"https://api.github.com/repos/fusetools/fuselibs-public/subscribers","subscription_url":"https://api.github.com/repos/fusetools/fuselibs-public/subscription","commits_url":"https://api.github.com/repos/fusetools/fuselibs-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/fusetools/fuselibs-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/fusetools/fuselibs-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/fusetools/fuselibs-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/fusetools/fuselibs-public/contents/{+path}","compare_url":"https://api.github.com/repos/fusetools/fuselibs-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fusetools/fuselibs-public/merges","archive_url":"https://api.github.com/repos/fusetools/fuselibs-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fusetools/fuselibs-public/downloads","issues_url":"https://api.github.com/repos/fusetools/fuselibs-public/issues{/number}","pulls_url":"https://api.github.com/repos/fusetools/fuselibs-public/pulls{/number}","milestones_url":"https://api.github.com/repos/fusetools/fuselibs-public/milestones{/number}","notifications_url":"https://api.github.com/repos/fusetools/fuselibs-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fusetools/fuselibs-public/labels{/name}","releases_url":"https://api.github.com/repos/fusetools/fuselibs-public/releases{/id}","deployments_url":"https://api.github.com/repos/fusetools/fuselibs-public/deployments","created_at":"2017-04-24T13:04:33Z","updated_at":"2018-02-23T21:11:53Z","pushed_at":"2018-02-26T09:21:51Z","git_url":"git://github.com/fusetools/fuselibs-public.git","ssh_url":"git@github.com:fusetools/fuselibs-public.git","clone_url":"https://github.com/fusetools/fuselibs-public.git","svn_url":"https://github.com/fusetools/fuselibs-public","homepage":"https://www.fusetools.com","size":20697,"stargazers_count":79,"watchers_count":79,"language":"Uno","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":42,"open_issues":246,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031"},"html":{"href":"https://github.com/fusetools/fuselibs-public/pull/1031"},"issue":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/issues/1031"},"comments":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/fusetools/fuselibs-public/statuses/759250a1c19ec23371738dbc90c97c39823651a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ollef"}}