{"action":"closed","issue":{"url":"https://api.github.com/repos/swaywm/wlroots/issues/650","repository_url":"https://api.github.com/repos/swaywm/wlroots","labels_url":"https://api.github.com/repos/swaywm/wlroots/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/swaywm/wlroots/issues/650/comments","events_url":"https://api.github.com/repos/swaywm/wlroots/issues/650/events","html_url":"https://github.com/swaywm/wlroots/issues/650","id":298381706,"number":650,"title":"rootston: Segfault on closing some XWayland windows with opened drop down menu","user":{"login":"chebykinn","id":1508308,"avatar_url":"https://avatars2.githubusercontent.com/u/1508308?v=4","gravatar_id":"","url":"https://api.github.com/users/chebykinn","html_url":"https://github.com/chebykinn","followers_url":"https://api.github.com/users/chebykinn/followers","following_url":"https://api.github.com/users/chebykinn/following{/other_user}","gists_url":"https://api.github.com/users/chebykinn/gists{/gist_id}","starred_url":"https://api.github.com/users/chebykinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebykinn/subscriptions","organizations_url":"https://api.github.com/users/chebykinn/orgs","repos_url":"https://api.github.com/users/chebykinn/repos","events_url":"https://api.github.com/users/chebykinn/events{/privacy}","received_events_url":"https://api.github.com/users/chebykinn/received_events","type":"User","site_admin":false},"labels":[{"id":591667613,"url":"https://api.github.com/repos/swaywm/wlroots/labels/bug","name":"bug","color":"ee0701","default":true},{"id":713220712,"url":"https://api.github.com/repos/swaywm/wlroots/labels/rootston","name":"rootston","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-19T19:35:21Z","updated_at":"2018-03-17T14:00:55Z","closed_at":"2018-03-17T14:00:55Z","author_association":"NONE","body":"__Commit:__ 868ad5af69583646ba71d6e73e362818c7416941\r\n__Reproduction:__ Open some X11 application, for instance vlc, and exit via drop down menu.\r\n__Result:__\r\n```\r\nThread 1 \"rootston\" hit Breakpoint 1, roots_seat_set_focus (seat=0x561f7c9d7d00, view=0x561f7cd2fe00) at ../rootston/seat.c:713\r\n713                     wl_list_remove(&view->link);\r\n1: view = (struct roots_view *) 0x561f7cd2fe00\r\n2: view->link = {prev = 0x0, next = 0x0}\r\n(gdb) c\r\nContinuing.\r\nThread 1 \"rootston\" received signal SIGSEGV, Segmentation fault.\r\n0x00007f9d7e607137 in wl_list_remove () from /usr/lib/libwayland-server.so.0\r\n(gdb) bt\r\n#0  0x00007f9d7e607137 in wl_list_remove () at /usr/lib/libwayland-server.so.0\r\n#1  0x0000561f7b178265 in roots_seat_set_focus (seat=0x561f7c9d7d00, view=0x561f7cd2fe00) at ../rootston/seat.c:713\r\n#2  0x0000561f7b17809e in seat_view_destroy (seat_view=0x561f7ccc0ce0) at ../rootston/seat.c:656\r\n#3  0x0000561f7b1780ce in seat_view_handle_destroy (listener=0x561f7ccc0d18, data=0x561f7ccedf60) at ../rootston/seat.c:663\r\n#4  0x0000561f7b16f819 in wl_signal_emit (signal=0x561f7ccee038, data=0x561f7ccedf60) at /usr/include/wayland-server-core.h:388\r\n#5  0x0000561f7b1709ba in view_finish (view=0x561f7ccedf60) at ../rootston/desktop.c:387\r\n#6  0x0000561f7b17bdca in handle_destroy (listener=0x561f7cd48328, data=0x561f7cb3a7a0) at ../rootston/xwayland.c:124\r\n#7  0x00007f9d7e86278f in wlr_signal_emit_safe (signal=0x561f7cb3a880, data=0x561f7cb3a7a0) at ../util/signal.c:29\r\n#8  0x00007f9d7e829bb8 in wlr_xwayland_surface_destroy (xsurface=0x561f7cb3a7a0) at ../xwayland/xwm.c:215\r\n#9  0x00007f9d7e82ac1c in xwm_handle_destroy_notify (xwm=0x561f7cc4aa00, ev=0x561f7cc46a00) at ../xwayland/xwm.c:600\r\n#10 0x00007f9d7e82b8aa in x11_event_handler (fd=15, mask=1, data=0x561f7cc4aa00) at ../xwayland/xwm.c:979\r\n#11 0x00007f9d7e6049b2 in wl_event_loop_dispatch () at /usr/lib/libwayland-server.so.0\r\n#12 0x00007f9d7e60314c in wl_display_run () at /usr/lib/libwayland-server.so.0\r\n#13 0x0000561f7b1739b2 in main (argc=1, argv=0x7ffe7dde8a18) at ../rootston/main.c:81\r\n```\r\nSegfault occurs at line 713:\r\nhttps://github.com/swaywm/wlroots/blob/868ad5af69583646ba71d6e73e362818c7416941/rootston/seat.c#L709-L715\r\n\r\nAdditional check for `view->link.next` fixes this issue."}}
{"actor":{"display_login":"acrisci"}}