{"action":"created","comment":{"url":"https://api.github.com/repos/swaponline/swap.react/pulls/comments/244166421","pull_request_review_id":188106044,"id":244166421,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDE2NjQyMQ==","diff_hunk":"@@ -1,37 +1,32 @@\n-import { tradeTicker } from 'helpers/constants'\n import { getState } from 'redux/core'\n import reducers from 'redux/core/reducers'\n import config from 'app-config'\n+import { parsePair } from 'shared/pages/Home/Orders/Pair'\n+import TRADE_TICKERS from 'helpers/constants/TRADE_TICKERS'\n \n \n const selectPair = (value) => {\n   const { currencies:{ items } } = getState()\n \n-  const selectedItems = items.filter(item => pairs[value].includes(item.name))\n+  const selectedPairsBase = TRADE_TICKERS\n+    .map(ticker => parsePair(ticker))\n+    .filter(({ BASE }) => BASE.toLowerCase() === value)\n+    .map(({ MAIN, BASE }) => MAIN)\n \n-  reducers.currencies.addSelectedItems(selectedItems)\n+  const selectedPairsMain = TRADE_TICKERS\n+    .map(ticker => parsePair(ticker))\n+    .filter(({ MAIN }) => MAIN.toLowerCase() === value)\n+    .map(({ MAIN, BASE }) => BASE)\n ","path":"shared/redux/actions/pairs.js","position":23,"original_position":23,"commit_id":"ea30a666798ae04f613da4cc407dcf73b53551b9","original_commit_id":"ea30a666798ae04f613da4cc407dcf73b53551b9","user":{"login":"caffeinum","id":1909384,"node_id":"MDQ6VXNlcjE5MDkzODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1909384?v=4","gravatar_id":"","url":"https://api.github.com/users/caffeinum","html_url":"https://github.com/caffeinum","followers_url":"https://api.github.com/users/caffeinum/followers","following_url":"https://api.github.com/users/caffeinum/following{/other_user}","gists_url":"https://api.github.com/users/caffeinum/gists{/gist_id}","starred_url":"https://api.github.com/users/caffeinum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caffeinum/subscriptions","organizations_url":"https://api.github.com/users/caffeinum/orgs","repos_url":"https://api.github.com/users/caffeinum/repos","events_url":"https://api.github.com/users/caffeinum/events{/privacy}","received_events_url":"https://api.github.com/users/caffeinum/received_events","type":"User","site_admin":false},"body":"Читаемость кода важнее, тут лучше не напишешь","created_at":"2018-12-27T14:49:16Z","updated_at":"2018-12-27T14:49:17Z","html_url":"https://github.com/swaponline/swap.react/pull/1213#discussion_r244166421","pull_request_url":"https://api.github.com/repos/swaponline/swap.react/pulls/1213","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/comments/244166421"},"html":{"href":"https://github.com/swaponline/swap.react/pull/1213#discussion_r244166421"},"pull_request":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/1213"}},"in_reply_to_id":244125505},"pull_request":{"url":"https://api.github.com/repos/swaponline/swap.react/pulls/1213","id":241061021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDYxMDIx","html_url":"https://github.com/swaponline/swap.react/pull/1213","diff_url":"https://github.com/swaponline/swap.react/pull/1213.diff","patch_url":"https://github.com/swaponline/swap.react/pull/1213.patch","issue_url":"https://api.github.com/repos/swaponline/swap.react/issues/1213","number":1213,"state":"open","locked":false,"title":"сортировака по валидным парам, через конфиг","user":{"login":"Pasha8914","id":43392281,"node_id":"MDQ6VXNlcjQzMzkyMjgx","avatar_url":"https://avatars3.githubusercontent.com/u/43392281?v=4","gravatar_id":"","url":"https://api.github.com/users/Pasha8914","html_url":"https://github.com/Pasha8914","followers_url":"https://api.github.com/users/Pasha8914/followers","following_url":"https://api.github.com/users/Pasha8914/following{/other_user}","gists_url":"https://api.github.com/users/Pasha8914/gists{/gist_id}","starred_url":"https://api.github.com/users/Pasha8914/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pasha8914/subscriptions","organizations_url":"https://api.github.com/users/Pasha8914/orgs","repos_url":"https://api.github.com/users/Pasha8914/repos","events_url":"https://api.github.com/users/Pasha8914/events{/privacy}","received_events_url":"https://api.github.com/users/Pasha8914/received_events","type":"User","site_admin":false},"body":"# Pull request template\r\n\r\n## Checklist\r\n\r\n<!-- You have to tick all the boxes -->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/swaponline/swap.react/wiki/CONTRIBUTING) guide\r\n- [x] branch rebased on `develop`\r\n- [x] styleguide check `npm run validate`\r\n- [x] good naming\r\n- [x] keep simple\r\n- [x] video or screenshot attached\r\n- [x] testing instruction attached\r\n- [x] check your PR once again\r\n\r\n\r\n### Description\r\n\r\nСделал сортировку пар через конфиг, чтоб не меняться пары в 2ух местах\r\n\r\n\r\n\r\n### Video or screenshot\r\n\r\nhttps://www.useloom.com/share/5b4df04669a1482a954ce19ff176fa66\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-12-27T02:17:36Z","updated_at":"2018-12-27T14:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"845fb397dd14a14a74ac1a1ec53a5a942dc03c67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swaponline/swap.react/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/swaponline/swap.react/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swaponline/swap.react/issues/1213/comments","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/ea30a666798ae04f613da4cc407dcf73b53551b9","head":{"label":"swaponline:currencyConfigToPair","ref":"currencyConfigToPair","sha":"ea30a666798ae04f613da4cc407dcf73b53551b9","user":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"repo":{"id":130675402,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2NzU0MDI=","name":"swap.react","full_name":"swaponline/swap.react","private":false,"owner":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/swaponline/swap.react","description":"develop branch --> https://testnet.swap.online :) In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":false,"url":"https://api.github.com/repos/swaponline/swap.react","forks_url":"https://api.github.com/repos/swaponline/swap.react/forks","keys_url":"https://api.github.com/repos/swaponline/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaponline/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaponline/swap.react/teams","hooks_url":"https://api.github.com/repos/swaponline/swap.react/hooks","issue_events_url":"https://api.github.com/repos/swaponline/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/swaponline/swap.react/events","assignees_url":"https://api.github.com/repos/swaponline/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/swaponline/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/swaponline/swap.react/tags","blobs_url":"https://api.github.com/repos/swaponline/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaponline/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaponline/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaponline/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/swaponline/swap.react/languages","stargazers_url":"https://api.github.com/repos/swaponline/swap.react/stargazers","contributors_url":"https://api.github.com/repos/swaponline/swap.react/contributors","subscribers_url":"https://api.github.com/repos/swaponline/swap.react/subscribers","subscription_url":"https://api.github.com/repos/swaponline/swap.react/subscription","commits_url":"https://api.github.com/repos/swaponline/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaponline/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaponline/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaponline/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaponline/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/swaponline/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaponline/swap.react/merges","archive_url":"https://api.github.com/repos/swaponline/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaponline/swap.react/downloads","issues_url":"https://api.github.com/repos/swaponline/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/swaponline/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/swaponline/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/swaponline/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaponline/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/swaponline/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/swaponline/swap.react/deployments","created_at":"2018-04-23T09:48:44Z","updated_at":"2018-12-23T19:36:57Z","pushed_at":"2018-12-27T14:46:18Z","git_url":"git://github.com/swaponline/swap.react.git","ssh_url":"git@github.com:swaponline/swap.react.git","clone_url":"https://github.com/swaponline/swap.react.git","svn_url":"https://github.com/swaponline/swap.react","homepage":"https://swap.online","size":15161,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":15,"watchers":39,"default_branch":"master"}},"base":{"label":"swaponline:develop","ref":"develop","sha":"417878b1174f87d7f5bbe145d2a7c88ff3ae17b6","user":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"repo":{"id":130675402,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2NzU0MDI=","name":"swap.react","full_name":"swaponline/swap.react","private":false,"owner":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/swaponline/swap.react","description":"develop branch --> https://testnet.swap.online :) In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":false,"url":"https://api.github.com/repos/swaponline/swap.react","forks_url":"https://api.github.com/repos/swaponline/swap.react/forks","keys_url":"https://api.github.com/repos/swaponline/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaponline/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaponline/swap.react/teams","hooks_url":"https://api.github.com/repos/swaponline/swap.react/hooks","issue_events_url":"https://api.github.com/repos/swaponline/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/swaponline/swap.react/events","assignees_url":"https://api.github.com/repos/swaponline/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/swaponline/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/swaponline/swap.react/tags","blobs_url":"https://api.github.com/repos/swaponline/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaponline/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaponline/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaponline/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/swaponline/swap.react/languages","stargazers_url":"https://api.github.com/repos/swaponline/swap.react/stargazers","contributors_url":"https://api.github.com/repos/swaponline/swap.react/contributors","subscribers_url":"https://api.github.com/repos/swaponline/swap.react/subscribers","subscription_url":"https://api.github.com/repos/swaponline/swap.react/subscription","commits_url":"https://api.github.com/repos/swaponline/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaponline/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaponline/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaponline/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaponline/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/swaponline/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaponline/swap.react/merges","archive_url":"https://api.github.com/repos/swaponline/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaponline/swap.react/downloads","issues_url":"https://api.github.com/repos/swaponline/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/swaponline/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/swaponline/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/swaponline/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaponline/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/swaponline/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/swaponline/swap.react/deployments","created_at":"2018-04-23T09:48:44Z","updated_at":"2018-12-23T19:36:57Z","pushed_at":"2018-12-27T14:46:18Z","git_url":"git://github.com/swaponline/swap.react.git","ssh_url":"git@github.com:swaponline/swap.react.git","clone_url":"https://github.com/swaponline/swap.react.git","svn_url":"https://github.com/swaponline/swap.react","homepage":"https://swap.online","size":15161,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":15,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/1213"},"html":{"href":"https://github.com/swaponline/swap.react/pull/1213"},"issue":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/1213"},"comments":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/swaponline/swap.react/statuses/ea30a666798ae04f613da4cc407dcf73b53551b9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"caffeinum"}}