{"action":"created","comment":{"url":"https://api.github.com/repos/helium/erlang-dkg/pulls/comments/192824579","pull_request_review_id":125673775,"id":192824579,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjgyNDU3OQ==","diff_hunk":"@@ -35,6 +63,14 @@ mul(PolyA, PolyB) ->\n                         add(Acc, Temp)\n                 end, [], PolyB).\n \n+cmp(PolyA, PolyB) ->\n+    %% check f(x) - g(x) = 0,\n+    %% check that each element is the same the original\n+    %% and the degree of polyA = polyB\n+    dkg_polynomial:is_zero(dkg_polynomial:sub(PolyA, PolyB)) andalso\n+    is_equal(PolyA, PolyB) andalso\n+    degree(PolyA) == degree(PolyB).","path":"src/dkg_polynomial.erl","position":54,"original_position":54,"commit_id":"f75576ec44fe9052a330c1a3928c5923ee61ac4b","original_commit_id":"f75576ec44fe9052a330c1a3928c5923ee61ac4b","user":{"login":"Vagabond","id":86412,"node_id":"MDQ6VXNlcjg2NDEy","avatar_url":"https://avatars3.githubusercontent.com/u/86412?v=4","gravatar_id":"","url":"https://api.github.com/users/Vagabond","html_url":"https://github.com/Vagabond","followers_url":"https://api.github.com/users/Vagabond/followers","following_url":"https://api.github.com/users/Vagabond/following{/other_user}","gists_url":"https://api.github.com/users/Vagabond/gists{/gist_id}","starred_url":"https://api.github.com/users/Vagabond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vagabond/subscriptions","organizations_url":"https://api.github.com/users/Vagabond/orgs","repos_url":"https://api.github.com/users/Vagabond/repos","events_url":"https://api.github.com/users/Vagabond/events{/privacy}","received_events_url":"https://api.github.com/users/Vagabond/received_events","type":"User","site_admin":false},"body":"Zip in the previous step will fail if the 2 lengths are not the same length.","created_at":"2018-06-04T17:43:45Z","updated_at":"2018-06-04T18:00:00Z","html_url":"https://github.com/helium/erlang-dkg/pull/2#discussion_r192824579","pull_request_url":"https://api.github.com/repos/helium/erlang-dkg/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/helium/erlang-dkg/pulls/comments/192824579"},"html":{"href":"https://github.com/helium/erlang-dkg/pull/2#discussion_r192824579"},"pull_request":{"href":"https://api.github.com/repos/helium/erlang-dkg/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/helium/erlang-dkg/pulls/2","id":192479085,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNDc5MDg1","html_url":"https://github.com/helium/erlang-dkg/pull/2","diff_url":"https://github.com/helium/erlang-dkg/pull/2.diff","patch_url":"https://github.com/helium/erlang-dkg/pull/2.patch","issue_url":"https://api.github.com/repos/helium/erlang-dkg/issues/2","number":2,"state":"open","locked":false,"title":"Refactoring, more tests and more coverage","user":{"login":"vihu","id":3199183,"node_id":"MDQ6VXNlcjMxOTkxODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3199183?v=4","gravatar_id":"","url":"https://api.github.com/users/vihu","html_url":"https://github.com/vihu","followers_url":"https://api.github.com/users/vihu/followers","following_url":"https://api.github.com/users/vihu/following{/other_user}","gists_url":"https://api.github.com/users/vihu/gists{/gist_id}","starred_url":"https://api.github.com/users/vihu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vihu/subscriptions","organizations_url":"https://api.github.com/users/vihu/orgs","repos_url":"https://api.github.com/users/vihu/repos","events_url":"https://api.github.com/users/vihu/events{/privacy}","received_events_url":"https://api.github.com/users/vihu/received_events","type":"User","site_admin":false},"body":"* Add comparison functions to poly and bipoly\r\n* Code refactor\r\n* Fix more typos\r\n* Add public_key_share_test, comparison tests\r\n* Update README a bit","created_at":"2018-06-04T17:37:01Z","updated_at":"2018-06-04T18:00:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edcd298fdafbb4d1861d8adaa3a366289a80a4aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/helium/erlang-dkg/pulls/2/commits","review_comments_url":"https://api.github.com/repos/helium/erlang-dkg/pulls/2/comments","review_comment_url":"https://api.github.com/repos/helium/erlang-dkg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helium/erlang-dkg/issues/2/comments","statuses_url":"https://api.github.com/repos/helium/erlang-dkg/statuses/f75576ec44fe9052a330c1a3928c5923ee61ac4b","head":{"label":"helium:rg/share-test","ref":"rg/share-test","sha":"f75576ec44fe9052a330c1a3928c5923ee61ac4b","user":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":134891078,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4OTEwNzg=","name":"erlang-dkg","full_name":"helium/erlang-dkg","owner":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helium/erlang-dkg","description":"Distributed key generation for Erlang (using pairing based cryptography)","fork":false,"url":"https://api.github.com/repos/helium/erlang-dkg","forks_url":"https://api.github.com/repos/helium/erlang-dkg/forks","keys_url":"https://api.github.com/repos/helium/erlang-dkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/erlang-dkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/erlang-dkg/teams","hooks_url":"https://api.github.com/repos/helium/erlang-dkg/hooks","issue_events_url":"https://api.github.com/repos/helium/erlang-dkg/issues/events{/number}","events_url":"https://api.github.com/repos/helium/erlang-dkg/events","assignees_url":"https://api.github.com/repos/helium/erlang-dkg/assignees{/user}","branches_url":"https://api.github.com/repos/helium/erlang-dkg/branches{/branch}","tags_url":"https://api.github.com/repos/helium/erlang-dkg/tags","blobs_url":"https://api.github.com/repos/helium/erlang-dkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/erlang-dkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/erlang-dkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/erlang-dkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/erlang-dkg/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/erlang-dkg/languages","stargazers_url":"https://api.github.com/repos/helium/erlang-dkg/stargazers","contributors_url":"https://api.github.com/repos/helium/erlang-dkg/contributors","subscribers_url":"https://api.github.com/repos/helium/erlang-dkg/subscribers","subscription_url":"https://api.github.com/repos/helium/erlang-dkg/subscription","commits_url":"https://api.github.com/repos/helium/erlang-dkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/erlang-dkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/erlang-dkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/erlang-dkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/erlang-dkg/contents/{+path}","compare_url":"https://api.github.com/repos/helium/erlang-dkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/erlang-dkg/merges","archive_url":"https://api.github.com/repos/helium/erlang-dkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/erlang-dkg/downloads","issues_url":"https://api.github.com/repos/helium/erlang-dkg/issues{/number}","pulls_url":"https://api.github.com/repos/helium/erlang-dkg/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/erlang-dkg/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/erlang-dkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/erlang-dkg/labels{/name}","releases_url":"https://api.github.com/repos/helium/erlang-dkg/releases{/id}","deployments_url":"https://api.github.com/repos/helium/erlang-dkg/deployments","created_at":"2018-05-25T18:25:49Z","updated_at":"2018-06-03T22:34:07Z","pushed_at":"2018-06-04T17:37:02Z","git_url":"git://github.com/helium/erlang-dkg.git","ssh_url":"git@github.com:helium/erlang-dkg.git","clone_url":"https://github.com/helium/erlang-dkg.git","svn_url":"https://github.com/helium/erlang-dkg","homepage":"","size":754,"stargazers_count":3,"watchers_count":3,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"helium:master","ref":"master","sha":"1e8a0fc0c571b7aa4c3b8ea31b160986f79f028f","user":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":134891078,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4OTEwNzg=","name":"erlang-dkg","full_name":"helium/erlang-dkg","owner":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helium/erlang-dkg","description":"Distributed key generation for Erlang (using pairing based cryptography)","fork":false,"url":"https://api.github.com/repos/helium/erlang-dkg","forks_url":"https://api.github.com/repos/helium/erlang-dkg/forks","keys_url":"https://api.github.com/repos/helium/erlang-dkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/erlang-dkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/erlang-dkg/teams","hooks_url":"https://api.github.com/repos/helium/erlang-dkg/hooks","issue_events_url":"https://api.github.com/repos/helium/erlang-dkg/issues/events{/number}","events_url":"https://api.github.com/repos/helium/erlang-dkg/events","assignees_url":"https://api.github.com/repos/helium/erlang-dkg/assignees{/user}","branches_url":"https://api.github.com/repos/helium/erlang-dkg/branches{/branch}","tags_url":"https://api.github.com/repos/helium/erlang-dkg/tags","blobs_url":"https://api.github.com/repos/helium/erlang-dkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/erlang-dkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/erlang-dkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/erlang-dkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/erlang-dkg/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/erlang-dkg/languages","stargazers_url":"https://api.github.com/repos/helium/erlang-dkg/stargazers","contributors_url":"https://api.github.com/repos/helium/erlang-dkg/contributors","subscribers_url":"https://api.github.com/repos/helium/erlang-dkg/subscribers","subscription_url":"https://api.github.com/repos/helium/erlang-dkg/subscription","commits_url":"https://api.github.com/repos/helium/erlang-dkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/erlang-dkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/erlang-dkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/erlang-dkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/erlang-dkg/contents/{+path}","compare_url":"https://api.github.com/repos/helium/erlang-dkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/erlang-dkg/merges","archive_url":"https://api.github.com/repos/helium/erlang-dkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/erlang-dkg/downloads","issues_url":"https://api.github.com/repos/helium/erlang-dkg/issues{/number}","pulls_url":"https://api.github.com/repos/helium/erlang-dkg/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/erlang-dkg/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/erlang-dkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/erlang-dkg/labels{/name}","releases_url":"https://api.github.com/repos/helium/erlang-dkg/releases{/id}","deployments_url":"https://api.github.com/repos/helium/erlang-dkg/deployments","created_at":"2018-05-25T18:25:49Z","updated_at":"2018-06-03T22:34:07Z","pushed_at":"2018-06-04T17:37:02Z","git_url":"git://github.com/helium/erlang-dkg.git","ssh_url":"git@github.com:helium/erlang-dkg.git","clone_url":"https://github.com/helium/erlang-dkg.git","svn_url":"https://github.com/helium/erlang-dkg","homepage":"","size":754,"stargazers_count":3,"watchers_count":3,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helium/erlang-dkg/pulls/2"},"html":{"href":"https://github.com/helium/erlang-dkg/pull/2"},"issue":{"href":"https://api.github.com/repos/helium/erlang-dkg/issues/2"},"comments":{"href":"https://api.github.com/repos/helium/erlang-dkg/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/helium/erlang-dkg/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/helium/erlang-dkg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helium/erlang-dkg/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/helium/erlang-dkg/statuses/f75576ec44fe9052a330c1a3928c5923ee61ac4b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Vagabond"}}