{"action":"closed","number":500,"pull_request":{"url":"https://api.github.com/repos/vcmi/vcmi/pulls/500","id":226306335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzA2MzM1","html_url":"https://github.com/vcmi/vcmi/pull/500","diff_url":"https://github.com/vcmi/vcmi/pull/500.diff","patch_url":"https://github.com/vcmi/vcmi/pull/500.patch","issue_url":"https://api.github.com/repos/vcmi/vcmi/issues/500","number":500,"state":"closed","locked":false,"title":"Fix crash when generating random map with random number of players","user":{"login":"godric3","id":18197844,"node_id":"MDQ6VXNlcjE4MTk3ODQ0","avatar_url":"https://avatars3.githubusercontent.com/u/18197844?v=4","gravatar_id":"","url":"https://api.github.com/users/godric3","html_url":"https://github.com/godric3","followers_url":"https://api.github.com/users/godric3/followers","following_url":"https://api.github.com/users/godric3/following{/other_user}","gists_url":"https://api.github.com/users/godric3/gists{/gist_id}","starred_url":"https://api.github.com/users/godric3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godric3/subscriptions","organizations_url":"https://api.github.com/users/godric3/orgs","repos_url":"https://api.github.com/users/godric3/repos","events_url":"https://api.github.com/users/godric3/events{/privacy}","received_events_url":"https://api.github.com/users/godric3/received_events","type":"User","site_admin":false},"body":"Changes  in CMapGenOptions are required, because without them generated map have only AI players(it will start, but after saving you couldn't load it)","created_at":"2018-10-27T16:33:04Z","updated_at":"2018-10-28T22:38:11Z","closed_at":"2018-10-28T22:38:11Z","merged_at":"2018-10-28T22:38:11Z","merge_commit_sha":"e814aca29ff1f5fb5aa1f2ae65810603815b3443","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vcmi/vcmi/pulls/500/commits","review_comments_url":"https://api.github.com/repos/vcmi/vcmi/pulls/500/comments","review_comment_url":"https://api.github.com/repos/vcmi/vcmi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vcmi/vcmi/issues/500/comments","statuses_url":"https://api.github.com/repos/vcmi/vcmi/statuses/f563712782b0c346b59ac6731372f0bd7570e284","head":{"label":"godric3:rmgCrash","ref":"rmgCrash","sha":"f563712782b0c346b59ac6731372f0bd7570e284","user":{"login":"godric3","id":18197844,"node_id":"MDQ6VXNlcjE4MTk3ODQ0","avatar_url":"https://avatars3.githubusercontent.com/u/18197844?v=4","gravatar_id":"","url":"https://api.github.com/users/godric3","html_url":"https://github.com/godric3","followers_url":"https://api.github.com/users/godric3/followers","following_url":"https://api.github.com/users/godric3/following{/other_user}","gists_url":"https://api.github.com/users/godric3/gists{/gist_id}","starred_url":"https://api.github.com/users/godric3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godric3/subscriptions","organizations_url":"https://api.github.com/users/godric3/orgs","repos_url":"https://api.github.com/users/godric3/repos","events_url":"https://api.github.com/users/godric3/events{/privacy}","received_events_url":"https://api.github.com/users/godric3/received_events","type":"User","site_admin":false},"repo":{"id":105775704,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3NzU3MDQ=","name":"vcmi","full_name":"godric3/vcmi","private":false,"owner":{"login":"godric3","id":18197844,"node_id":"MDQ6VXNlcjE4MTk3ODQ0","avatar_url":"https://avatars3.githubusercontent.com/u/18197844?v=4","gravatar_id":"","url":"https://api.github.com/users/godric3","html_url":"https://github.com/godric3","followers_url":"https://api.github.com/users/godric3/followers","following_url":"https://api.github.com/users/godric3/following{/other_user}","gists_url":"https://api.github.com/users/godric3/gists{/gist_id}","starred_url":"https://api.github.com/users/godric3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godric3/subscriptions","organizations_url":"https://api.github.com/users/godric3/orgs","repos_url":"https://api.github.com/users/godric3/repos","events_url":"https://api.github.com/users/godric3/events{/privacy}","received_events_url":"https://api.github.com/users/godric3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/godric3/vcmi","description":"Open-source engine for Heroes of Might and Magic III","fork":true,"url":"https://api.github.com/repos/godric3/vcmi","forks_url":"https://api.github.com/repos/godric3/vcmi/forks","keys_url":"https://api.github.com/repos/godric3/vcmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godric3/vcmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godric3/vcmi/teams","hooks_url":"https://api.github.com/repos/godric3/vcmi/hooks","issue_events_url":"https://api.github.com/repos/godric3/vcmi/issues/events{/number}","events_url":"https://api.github.com/repos/godric3/vcmi/events","assignees_url":"https://api.github.com/repos/godric3/vcmi/assignees{/user}","branches_url":"https://api.github.com/repos/godric3/vcmi/branches{/branch}","tags_url":"https://api.github.com/repos/godric3/vcmi/tags","blobs_url":"https://api.github.com/repos/godric3/vcmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godric3/vcmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godric3/vcmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/godric3/vcmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godric3/vcmi/statuses/{sha}","languages_url":"https://api.github.com/repos/godric3/vcmi/languages","stargazers_url":"https://api.github.com/repos/godric3/vcmi/stargazers","contributors_url":"https://api.github.com/repos/godric3/vcmi/contributors","subscribers_url":"https://api.github.com/repos/godric3/vcmi/subscribers","subscription_url":"https://api.github.com/repos/godric3/vcmi/subscription","commits_url":"https://api.github.com/repos/godric3/vcmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/godric3/vcmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/godric3/vcmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/godric3/vcmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/godric3/vcmi/contents/{+path}","compare_url":"https://api.github.com/repos/godric3/vcmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godric3/vcmi/merges","archive_url":"https://api.github.com/repos/godric3/vcmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godric3/vcmi/downloads","issues_url":"https://api.github.com/repos/godric3/vcmi/issues{/number}","pulls_url":"https://api.github.com/repos/godric3/vcmi/pulls{/number}","milestones_url":"https://api.github.com/repos/godric3/vcmi/milestones{/number}","notifications_url":"https://api.github.com/repos/godric3/vcmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godric3/vcmi/labels{/name}","releases_url":"https://api.github.com/repos/godric3/vcmi/releases{/id}","deployments_url":"https://api.github.com/repos/godric3/vcmi/deployments","created_at":"2017-10-04T14:04:00Z","updated_at":"2018-05-26T12:55:29Z","pushed_at":"2018-10-28T15:36:11Z","git_url":"git://github.com/godric3/vcmi.git","ssh_url":"git@github.com:godric3/vcmi.git","clone_url":"https://github.com/godric3/vcmi.git","svn_url":"https://github.com/godric3/vcmi","homepage":"https://vcmi.eu/","size":36512,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"vcmi:develop","ref":"develop","sha":"0f1e853b4a1bb4e032fdfc7d2051551b6120d102","user":{"login":"vcmi","id":2861395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NjEzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2861395?v=4","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"repo":{"id":18490421,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ5MDQyMQ==","name":"vcmi","full_name":"vcmi/vcmi","private":false,"owner":{"login":"vcmi","id":2861395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NjEzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2861395?v=4","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vcmi/vcmi","description":"Open-source engine for Heroes of Might and Magic III","fork":false,"url":"https://api.github.com/repos/vcmi/vcmi","forks_url":"https://api.github.com/repos/vcmi/vcmi/forks","keys_url":"https://api.github.com/repos/vcmi/vcmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcmi/vcmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcmi/vcmi/teams","hooks_url":"https://api.github.com/repos/vcmi/vcmi/hooks","issue_events_url":"https://api.github.com/repos/vcmi/vcmi/issues/events{/number}","events_url":"https://api.github.com/repos/vcmi/vcmi/events","assignees_url":"https://api.github.com/repos/vcmi/vcmi/assignees{/user}","branches_url":"https://api.github.com/repos/vcmi/vcmi/branches{/branch}","tags_url":"https://api.github.com/repos/vcmi/vcmi/tags","blobs_url":"https://api.github.com/repos/vcmi/vcmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcmi/vcmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcmi/vcmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcmi/vcmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcmi/vcmi/statuses/{sha}","languages_url":"https://api.github.com/repos/vcmi/vcmi/languages","stargazers_url":"https://api.github.com/repos/vcmi/vcmi/stargazers","contributors_url":"https://api.github.com/repos/vcmi/vcmi/contributors","subscribers_url":"https://api.github.com/repos/vcmi/vcmi/subscribers","subscription_url":"https://api.github.com/repos/vcmi/vcmi/subscription","commits_url":"https://api.github.com/repos/vcmi/vcmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcmi/vcmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcmi/vcmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcmi/vcmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcmi/vcmi/contents/{+path}","compare_url":"https://api.github.com/repos/vcmi/vcmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcmi/vcmi/merges","archive_url":"https://api.github.com/repos/vcmi/vcmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcmi/vcmi/downloads","issues_url":"https://api.github.com/repos/vcmi/vcmi/issues{/number}","pulls_url":"https://api.github.com/repos/vcmi/vcmi/pulls{/number}","milestones_url":"https://api.github.com/repos/vcmi/vcmi/milestones{/number}","notifications_url":"https://api.github.com/repos/vcmi/vcmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcmi/vcmi/labels{/name}","releases_url":"https://api.github.com/repos/vcmi/vcmi/releases{/id}","deployments_url":"https://api.github.com/repos/vcmi/vcmi/deployments","created_at":"2014-04-06T13:42:23Z","updated_at":"2018-10-28T22:36:55Z","pushed_at":"2018-10-28T22:38:10Z","git_url":"git://github.com/vcmi/vcmi.git","ssh_url":"git@github.com:vcmi/vcmi.git","clone_url":"https://github.com/vcmi/vcmi.git","svn_url":"https://github.com/vcmi/vcmi","homepage":"https://vcmi.eu/","size":36486,"stargazers_count":906,"watchers_count":906,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":177,"open_issues":16,"watchers":906,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/500"},"html":{"href":"https://github.com/vcmi/vcmi/pull/500"},"issue":{"href":"https://api.github.com/repos/vcmi/vcmi/issues/500"},"comments":{"href":"https://api.github.com/repos/vcmi/vcmi/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/vcmi/vcmi/statuses/f563712782b0c346b59ac6731372f0bd7570e284"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alexvins","id":1083924,"node_id":"MDQ6VXNlcjEwODM5MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1083924?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvins","html_url":"https://github.com/alexvins","followers_url":"https://api.github.com/users/alexvins/followers","following_url":"https://api.github.com/users/alexvins/following{/other_user}","gists_url":"https://api.github.com/users/alexvins/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvins/subscriptions","organizations_url":"https://api.github.com/users/alexvins/orgs","repos_url":"https://api.github.com/users/alexvins/repos","events_url":"https://api.github.com/users/alexvins/events{/privacy}","received_events_url":"https://api.github.com/users/alexvins/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":13,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"alexvins"}}