{"action":"opened","number":16031,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/16031","id":182783800,"html_url":"https://github.com/apple/swift/pull/16031","diff_url":"https://github.com/apple/swift/pull/16031.diff","patch_url":"https://github.com/apple/swift/pull/16031.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/16031","number":16031,"state":"open","locked":false,"title":"Cleanup attr.def","user":{"login":"davezarzycki","id":1071982,"avatar_url":"https://avatars2.githubusercontent.com/u/1071982?v=4","gravatar_id":"","url":"https://api.github.com/users/davezarzycki","html_url":"https://github.com/davezarzycki","followers_url":"https://api.github.com/users/davezarzycki/followers","following_url":"https://api.github.com/users/davezarzycki/following{/other_user}","gists_url":"https://api.github.com/users/davezarzycki/gists{/gist_id}","starred_url":"https://api.github.com/users/davezarzycki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezarzycki/subscriptions","organizations_url":"https://api.github.com/users/davezarzycki/orgs","repos_url":"https://api.github.com/users/davezarzycki/repos","events_url":"https://api.github.com/users/davezarzycki/events{/privacy}","received_events_url":"https://api.github.com/users/davezarzycki/received_events","type":"User","site_admin":false},"body":"This builds on #16014, so please ignore the first commit.\r\n\r\n1) Formalize `OnAccessor`. A hack used to alias this to `OnFunc`.\r\n2) New aggregates: OnNominalType, OnGenericType, OnAbstractFunction.\r\n3) Consistent and self-documented (albeit custom) style in Attr.def to ease code review/audits.\r\n\r\n@rjmccall and @slavapestov – Review questions:\r\n\r\n1) Now that `OnAccessor` is formalized, should it be removed from any attributes?\r\n2) Now that `OnAccessor` is formalized, should `OnFunc` be removed from any attributes?\r\n3) Now that new aggregate \"OnXYZ\" options exist, it seems like there might be some oversights in the `.def` file. For example, it is intentional that `inline` doesn't work on destructors? There might be more oversights. Feedback would be appreciated.\r\n4) The following seems to be a common attribute requirement: `OnAbstractFunction & ~OnDestructor`. Should it be formalized? Perhaps `OnNonDestructorFunctions`?","created_at":"2018-04-19T13:52:46Z","updated_at":"2018-04-19T13:52:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/16031/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/16031/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/16031/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/cabdcda66e54dfa0ecb2f96d8b67e464c6274517","head":{"label":"davezarzycki:cleanup_Attr.def","ref":"cleanup_Attr.def","sha":"cabdcda66e54dfa0ecb2f96d8b67e464c6274517","user":{"login":"davezarzycki","id":1071982,"avatar_url":"https://avatars2.githubusercontent.com/u/1071982?v=4","gravatar_id":"","url":"https://api.github.com/users/davezarzycki","html_url":"https://github.com/davezarzycki","followers_url":"https://api.github.com/users/davezarzycki/followers","following_url":"https://api.github.com/users/davezarzycki/following{/other_user}","gists_url":"https://api.github.com/users/davezarzycki/gists{/gist_id}","starred_url":"https://api.github.com/users/davezarzycki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezarzycki/subscriptions","organizations_url":"https://api.github.com/users/davezarzycki/orgs","repos_url":"https://api.github.com/users/davezarzycki/repos","events_url":"https://api.github.com/users/davezarzycki/events{/privacy}","received_events_url":"https://api.github.com/users/davezarzycki/received_events","type":"User","site_admin":false},"repo":{"id":47463067,"name":"swift","full_name":"davezarzycki/swift","owner":{"login":"davezarzycki","id":1071982,"avatar_url":"https://avatars2.githubusercontent.com/u/1071982?v=4","gravatar_id":"","url":"https://api.github.com/users/davezarzycki","html_url":"https://github.com/davezarzycki","followers_url":"https://api.github.com/users/davezarzycki/followers","following_url":"https://api.github.com/users/davezarzycki/following{/other_user}","gists_url":"https://api.github.com/users/davezarzycki/gists{/gist_id}","starred_url":"https://api.github.com/users/davezarzycki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezarzycki/subscriptions","organizations_url":"https://api.github.com/users/davezarzycki/orgs","repos_url":"https://api.github.com/users/davezarzycki/repos","events_url":"https://api.github.com/users/davezarzycki/events{/privacy}","received_events_url":"https://api.github.com/users/davezarzycki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davezarzycki/swift","description":null,"fork":true,"url":"https://api.github.com/repos/davezarzycki/swift","forks_url":"https://api.github.com/repos/davezarzycki/swift/forks","keys_url":"https://api.github.com/repos/davezarzycki/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davezarzycki/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davezarzycki/swift/teams","hooks_url":"https://api.github.com/repos/davezarzycki/swift/hooks","issue_events_url":"https://api.github.com/repos/davezarzycki/swift/issues/events{/number}","events_url":"https://api.github.com/repos/davezarzycki/swift/events","assignees_url":"https://api.github.com/repos/davezarzycki/swift/assignees{/user}","branches_url":"https://api.github.com/repos/davezarzycki/swift/branches{/branch}","tags_url":"https://api.github.com/repos/davezarzycki/swift/tags","blobs_url":"https://api.github.com/repos/davezarzycki/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davezarzycki/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davezarzycki/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/davezarzycki/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davezarzycki/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/davezarzycki/swift/languages","stargazers_url":"https://api.github.com/repos/davezarzycki/swift/stargazers","contributors_url":"https://api.github.com/repos/davezarzycki/swift/contributors","subscribers_url":"https://api.github.com/repos/davezarzycki/swift/subscribers","subscription_url":"https://api.github.com/repos/davezarzycki/swift/subscription","commits_url":"https://api.github.com/repos/davezarzycki/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/davezarzycki/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/davezarzycki/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/davezarzycki/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/davezarzycki/swift/contents/{+path}","compare_url":"https://api.github.com/repos/davezarzycki/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davezarzycki/swift/merges","archive_url":"https://api.github.com/repos/davezarzycki/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davezarzycki/swift/downloads","issues_url":"https://api.github.com/repos/davezarzycki/swift/issues{/number}","pulls_url":"https://api.github.com/repos/davezarzycki/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/davezarzycki/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/davezarzycki/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davezarzycki/swift/labels{/name}","releases_url":"https://api.github.com/repos/davezarzycki/swift/releases{/id}","deployments_url":"https://api.github.com/repos/davezarzycki/swift/deployments","created_at":"2015-12-05T16:23:41Z","updated_at":"2017-08-16T19:02:08Z","pushed_at":"2018-04-19T13:41:35Z","git_url":"git://github.com/davezarzycki/swift.git","ssh_url":"git@github.com:davezarzycki/swift.git","clone_url":"https://github.com/davezarzycki/swift.git","svn_url":"https://github.com/davezarzycki/swift","homepage":"","size":261344,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"github_readme"}},"base":{"label":"apple:master","ref":"master","sha":"7ed7354003406c8e4a708195b86c1950b2c1f381","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-04-19T13:44:56Z","pushed_at":"2018-04-19T11:19:44Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":280722,"stargazers_count":43422,"watchers_count":43422,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6810,"mirror_url":null,"archived":false,"open_issues_count":301,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6810,"open_issues":301,"watchers":43422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/16031"},"html":{"href":"https://github.com/apple/swift/pull/16031"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/16031"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/16031/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/16031/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/16031/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/cabdcda66e54dfa0ecb2f96d8b67e464c6274517"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":317,"deletions":289,"changed_files":5}}
{"actor":{"display_login":"davezarzycki"}}