{"action":"created","comment":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/comments/231179646","pull_request_review_id":172090754,"id":231179646,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTE3OTY0Ng==","diff_hunk":"@@ -521,42 +521,68 @@ typecheck ps = void $ foldM tvarCheck M.empty ps where\n                         evalError (_tInfo t) $ \"Type error: values for variable \" ++ show _aType ++\n                         \" do not match: \" ++ show (prevTy,ty)\n \n-check1 :: forall e . Info -> Type (Term Name) -> Term Name -> Eval e (Maybe (TypeVar (Term Name),Type (Term Name)))\n-check1 i spec t = do\n+-- | 'typecheckTerm i spec t' checks a Term 't' against a specified type 'spec'.","path":"src/Pact/Eval.hs","position":135,"original_position":135,"commit_id":"c9e4f4b2c334b2f9c44aad77c61ce86d7c3d001f","original_commit_id":"c9e4f4b2c334b2f9c44aad77c61ce86d7c3d001f","user":{"login":"emilypi","id":10459342,"node_id":"MDQ6VXNlcjEwNDU5MzQy","avatar_url":"https://avatars2.githubusercontent.com/u/10459342?v=4","gravatar_id":"","url":"https://api.github.com/users/emilypi","html_url":"https://github.com/emilypi","followers_url":"https://api.github.com/users/emilypi/followers","following_url":"https://api.github.com/users/emilypi/following{/other_user}","gists_url":"https://api.github.com/users/emilypi/gists{/gist_id}","starred_url":"https://api.github.com/users/emilypi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilypi/subscriptions","organizations_url":"https://api.github.com/users/emilypi/orgs","repos_url":"https://api.github.com/users/emilypi/repos","events_url":"https://api.github.com/users/emilypi/events{/privacy}","received_events_url":"https://api.github.com/users/emilypi/received_events","type":"User","site_admin":false},"body":"(WARNING: Bikeshedding. Feel free to ignore)\r\n\r\nWhat is a 'spec', though, in this case. It looks like we're comparing argument types and their occurences, so shouldn't we just use the same 'ty' suffix to make it easier? My suggests would be `argTy` and `occTy` for argument type and occurrence type. ","created_at":"2018-11-06T15:55:12Z","updated_at":"2018-11-06T15:58:28Z","html_url":"https://github.com/kadena-io/pact/pull/279#discussion_r231179646","pull_request_url":"https://api.github.com/repos/kadena-io/pact/pulls/279","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments/231179646"},"html":{"href":"https://github.com/kadena-io/pact/pull/279#discussion_r231179646"},"pull_request":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/279"}}},"pull_request":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/279","id":228196689,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTk2Njg5","html_url":"https://github.com/kadena-io/pact/pull/279","diff_url":"https://github.com/kadena-io/pact/pull/279.diff","patch_url":"https://github.com/kadena-io/pact/pull/279.patch","issue_url":"https://api.github.com/repos/kadena-io/pact/issues/279","number":279,"state":"open","locked":false,"title":"Fix empty list runtime type enforce bug ","user":{"login":"slpopejoy","id":8353613,"node_id":"MDQ6VXNlcjgzNTM2MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8353613?v=4","gravatar_id":"","url":"https://api.github.com/users/slpopejoy","html_url":"https://github.com/slpopejoy","followers_url":"https://api.github.com/users/slpopejoy/followers","following_url":"https://api.github.com/users/slpopejoy/following{/other_user}","gists_url":"https://api.github.com/users/slpopejoy/gists{/gist_id}","starred_url":"https://api.github.com/users/slpopejoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slpopejoy/subscriptions","organizations_url":"https://api.github.com/users/slpopejoy/orgs","repos_url":"https://api.github.com/users/slpopejoy/repos","events_url":"https://api.github.com/users/slpopejoy/events{/privacy}","received_events_url":"https://api.github.com/users/slpopejoy/received_events","type":"User","site_admin":false},"body":"for #221. Note code changed considerably as I needed to doco/reformat to understand the tc code, and found additional cruft: tc was skipping type vars on lists/objects as these would never be found in user defs (not expressible in surface type lang). Bug fix is in `checkList` inner function, optimization on empty list was returning parameterized type, not list type; got rid of optimization (lesson re-learned :\\ )","created_at":"2018-11-04T19:20:56Z","updated_at":"2018-11-06T15:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3821a15a6d004c544557b9410ae9710dd90494d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kadena-io/pact/pulls/279/commits","review_comments_url":"https://api.github.com/repos/kadena-io/pact/pulls/279/comments","review_comment_url":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kadena-io/pact/issues/279/comments","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/c9e4f4b2c334b2f9c44aad77c61ce86d7c3d001f","head":{"label":"kadena-io:bug/empty-list-type-enforce-fix","ref":"bug/empty-list-type-enforce-fix","sha":"c9e4f4b2c334b2f9c44aad77c61ce86d7c3d001f","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","private":false,"owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-11-05T14:47:25Z","pushed_at":"2018-11-05T22:43:57Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":3788,"stargazers_count":227,"watchers_count":227,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":25,"open_issues":63,"watchers":227,"default_branch":"master"}},"base":{"label":"kadena-io:master","ref":"master","sha":"142333640a22e0b8c8caf9006e2a18ec51af4238","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","private":false,"owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-11-05T14:47:25Z","pushed_at":"2018-11-05T22:43:57Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":3788,"stargazers_count":227,"watchers_count":227,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":25,"open_issues":63,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/279"},"html":{"href":"https://github.com/kadena-io/pact/pull/279"},"issue":{"href":"https://api.github.com/repos/kadena-io/pact/issues/279"},"comments":{"href":"https://api.github.com/repos/kadena-io/pact/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/kadena-io/pact/statuses/c9e4f4b2c334b2f9c44aad77c61ce86d7c3d001f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emilypi"}}