{"action":"closed","number":613,"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/613","id":166548254,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow-ui/pull/613","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow-ui/pull/613.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow-ui/pull/613.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/issues/613","number":613,"state":"closed","locked":false,"title":"Applications: Manage versions, Apps Module Refactoring + Coverage Tests","user":{"login":"oodamien","id":487067,"avatar_url":"https://avatars1.githubusercontent.com/u/487067?v=4","gravatar_id":"","url":"https://api.github.com/users/oodamien","html_url":"https://github.com/oodamien","followers_url":"https://api.github.com/users/oodamien/followers","following_url":"https://api.github.com/users/oodamien/following{/other_user}","gists_url":"https://api.github.com/users/oodamien/gists{/gist_id}","starred_url":"https://api.github.com/users/oodamien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oodamien/subscriptions","organizations_url":"https://api.github.com/users/oodamien/orgs","repos_url":"https://api.github.com/users/oodamien/repos","events_url":"https://api.github.com/users/oodamien/events{/privacy}","received_events_url":"https://api.github.com/users/oodamien/received_events","type":"User","site_admin":false},"body":"**Resolves #602:**\r\n- manage versions application (skipper integration)\r\n- Application Details: display properties of a selected version\r\n- Apps: refactoring (workaround spring-cloud/spring-cloud-dataflow/#1871)\r\n\r\n**Resolves #336:**\r\n- Apps Bulk Import: refactoring using Form Reactive\r\n- Apps Register: refactoring using Form Reactive\r\n- Apps Details: added tests\r\n- Application Details: tests\r\n- Apps List: refactoring, tests\r\n- Mock App Objects\r\n\r\n**Global:**\r\n- Added service/components/pipes: `ConfirmService`, `SortComponent`, `Pipe`...\r\n- UI styles: quick improvements\r\n- List: Refactoring: search/sort/pagination/state\r\n\r\n**Other:**\r\n- `SharedAppService`: fix type variable\r\n- `Page<T>`: change Filter property (from string to object)\r\n\r\n**Nb:**\r\n- Task App can be extend the Apps List\r\n- Applications list can reload data without lost the context (filters, page, selected items...)\r\n\r\n**Todo:**\r\n- More Reactive (using async |)\r\n- Improve validator URI (bulk import, register)\r\n- Remove the context attributes from the model AppRegistration (force, selected Item)\r\n- Move some interfaces from AppsModule to SharedModule (`PaginationParams`, `SortParams`)","created_at":"2018-02-01T14:14:45Z","updated_at":"2018-02-12T12:46:08Z","closed_at":"2018-02-12T12:46:08Z","merged_at":null,"merge_commit_sha":"85203ceddb797631e9731a626a028e90e38fad3e","assignee":{"login":"ghillert","id":685363,"avatar_url":"https://avatars0.githubusercontent.com/u/685363?v=4","gravatar_id":"","url":"https://api.github.com/users/ghillert","html_url":"https://github.com/ghillert","followers_url":"https://api.github.com/users/ghillert/followers","following_url":"https://api.github.com/users/ghillert/following{/other_user}","gists_url":"https://api.github.com/users/ghillert/gists{/gist_id}","starred_url":"https://api.github.com/users/ghillert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghillert/subscriptions","organizations_url":"https://api.github.com/users/ghillert/orgs","repos_url":"https://api.github.com/users/ghillert/repos","events_url":"https://api.github.com/users/ghillert/events{/privacy}","received_events_url":"https://api.github.com/users/ghillert/received_events","type":"User","site_admin":false},"assignees":[{"login":"ghillert","id":685363,"avatar_url":"https://avatars0.githubusercontent.com/u/685363?v=4","gravatar_id":"","url":"https://api.github.com/users/ghillert","html_url":"https://github.com/ghillert","followers_url":"https://api.github.com/users/ghillert/followers","following_url":"https://api.github.com/users/ghillert/following{/other_user}","gists_url":"https://api.github.com/users/ghillert/gists{/gist_id}","starred_url":"https://api.github.com/users/ghillert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghillert/subscriptions","organizations_url":"https://api.github.com/users/ghillert/orgs","repos_url":"https://api.github.com/users/ghillert/repos","events_url":"https://api.github.com/users/ghillert/events{/privacy}","received_events_url":"https://api.github.com/users/ghillert/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":286713904,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/labels/in%20pr","name":"in pr","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/613/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/613/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/issues/613/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/statuses/4b2ce027478193b850ffdf74a6422c97e06b9343","head":{"label":"oodamien:gh-602","ref":"gh-602","sha":"4b2ce027478193b850ffdf74a6422c97e06b9343","user":{"login":"oodamien","id":487067,"avatar_url":"https://avatars1.githubusercontent.com/u/487067?v=4","gravatar_id":"","url":"https://api.github.com/users/oodamien","html_url":"https://github.com/oodamien","followers_url":"https://api.github.com/users/oodamien/followers","following_url":"https://api.github.com/users/oodamien/following{/other_user}","gists_url":"https://api.github.com/users/oodamien/gists{/gist_id}","starred_url":"https://api.github.com/users/oodamien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oodamien/subscriptions","organizations_url":"https://api.github.com/users/oodamien/orgs","repos_url":"https://api.github.com/users/oodamien/repos","events_url":"https://api.github.com/users/oodamien/events{/privacy}","received_events_url":"https://api.github.com/users/oodamien/received_events","type":"User","site_admin":false},"repo":{"id":105914163,"name":"spring-cloud-dataflow-ui","full_name":"oodamien/spring-cloud-dataflow-ui","owner":{"login":"oodamien","id":487067,"avatar_url":"https://avatars1.githubusercontent.com/u/487067?v=4","gravatar_id":"","url":"https://api.github.com/users/oodamien","html_url":"https://github.com/oodamien","followers_url":"https://api.github.com/users/oodamien/followers","following_url":"https://api.github.com/users/oodamien/following{/other_user}","gists_url":"https://api.github.com/users/oodamien/gists{/gist_id}","starred_url":"https://api.github.com/users/oodamien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oodamien/subscriptions","organizations_url":"https://api.github.com/users/oodamien/orgs","repos_url":"https://api.github.com/users/oodamien/repos","events_url":"https://api.github.com/users/oodamien/events{/privacy}","received_events_url":"https://api.github.com/users/oodamien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oodamien/spring-cloud-dataflow-ui","description":"This repo provides the Dashboard application of Spring Cloud Data Flow","fork":true,"url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui","forks_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/forks","keys_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/teams","hooks_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/hooks","issue_events_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/issues/events{/number}","events_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/events","assignees_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/assignees{/user}","branches_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/branches{/branch}","tags_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/tags","blobs_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/languages","stargazers_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/stargazers","contributors_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/contributors","subscribers_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/subscribers","subscription_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/subscription","commits_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/contents/{+path}","compare_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/merges","archive_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/downloads","issues_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/issues{/number}","pulls_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/labels{/name}","releases_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/releases{/id}","deployments_url":"https://api.github.com/repos/oodamien/spring-cloud-dataflow-ui/deployments","created_at":"2017-10-05T16:33:07Z","updated_at":"2017-10-05T16:33:09Z","pushed_at":"2018-02-12T12:46:08Z","git_url":"git://github.com/oodamien/spring-cloud-dataflow-ui.git","ssh_url":"git@github.com:oodamien/spring-cloud-dataflow-ui.git","clone_url":"https://github.com/oodamien/spring-cloud-dataflow-ui.git","svn_url":"https://github.com/oodamien/spring-cloud-dataflow-ui","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":7517,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"4b2ce027478193b850ffdf74a6422c97e06b9343","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":45694880,"name":"spring-cloud-dataflow-ui","full_name":"spring-cloud/spring-cloud-dataflow-ui","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow-ui","description":"This repo provides the Dashboard application of Spring Cloud Data Flow","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/deployments","created_at":"2015-11-06T16:57:06Z","updated_at":"2018-02-11T17:36:17Z","pushed_at":"2018-02-12T11:27:59Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow-ui.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow-ui.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow-ui.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow-ui","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":7716,"stargazers_count":38,"watchers_count":38,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":38,"open_issues":63,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/613"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow-ui/pull/613"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/issues/613"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow-ui/statuses/4b2ce027478193b850ffdf74a6422c97e06b9343"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":8,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"oodamien"}}