{"action":"created","comment":{"url":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/comments/229493478","pull_request_review_id":170009379,"id":229493478,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ5MzQ3OA==","diff_hunk":"@@ -230,6 +253,34 @@ export class EcoFabSpeedDialComponent implements AfterContentInit {\n             this.renderer.removeClass(this.elementRef.nativeElement, finalClass);\n         }\n     }\n+\n+    private _processOutsideClickState() {\n+        if (this.fixed) {\n+            return;\n+        }\n+        if (this._closeOnOutsideClick) {\n+            this._setDocumentClickBindings();\n+        } else {\n+            this._unsetDocumentClickBindings();\n+        }\n+    }\n+\n+    private _setDocumentClickBindings() {\n+        if (!this._documentListener) {\n+            this._documentListener = this.renderer.listen(this.document, 'click', () => {\n+                if (!this.fixed && this.open) {\n+                    this.open = false;\n+                }\n+            });\n+        }\n+    }\n+\n+    private _unsetDocumentClickBindings() {\n+        if (this._documentListener) {\n+            this._documentListener();","path":"projects/fab-speed-dial/src/lib/fab-speed-dial.ts","position":96,"original_position":97,"commit_id":"25173482ef52519b662ef6a9ef135b4297164ca8","original_commit_id":"b0cdc32089d13e59aeaa82db3d8f9e9debbb6d0c","user":{"login":"daimoonis","id":10496111,"node_id":"MDQ6VXNlcjEwNDk2MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/10496111?v=4","gravatar_id":"","url":"https://api.github.com/users/daimoonis","html_url":"https://github.com/daimoonis","followers_url":"https://api.github.com/users/daimoonis/followers","following_url":"https://api.github.com/users/daimoonis/following{/other_user}","gists_url":"https://api.github.com/users/daimoonis/gists{/gist_id}","starred_url":"https://api.github.com/users/daimoonis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daimoonis/subscriptions","organizations_url":"https://api.github.com/users/daimoonis/orgs","repos_url":"https://api.github.com/users/daimoonis/repos","events_url":"https://api.github.com/users/daimoonis/events{/privacy}","received_events_url":"https://api.github.com/users/daimoonis/received_events","type":"User","site_admin":false},"body":"Indeed it was missing. Anyway I also did change the listener registering/unregistering, it is registered when actions are visible and unregistered when hidden.","created_at":"2018-10-30T21:30:03Z","updated_at":"2018-10-30T21:30:03Z","html_url":"https://github.com/Ecodev/fab-speed-dial/pull/12#discussion_r229493478","pull_request_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/comments/229493478"},"html":{"href":"https://github.com/Ecodev/fab-speed-dial/pull/12#discussion_r229493478"},"pull_request":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12"}},"in_reply_to_id":229159824},"pull_request":{"url":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12","id":226735182,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzM1MTgy","html_url":"https://github.com/Ecodev/fab-speed-dial/pull/12","diff_url":"https://github.com/Ecodev/fab-speed-dial/pull/12.diff","patch_url":"https://github.com/Ecodev/fab-speed-dial/pull/12.patch","issue_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/issues/12","number":12,"state":"open","locked":false,"title":"Close on document click feature","user":{"login":"daimoonis","id":10496111,"node_id":"MDQ6VXNlcjEwNDk2MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/10496111?v=4","gravatar_id":"","url":"https://api.github.com/users/daimoonis","html_url":"https://github.com/daimoonis","followers_url":"https://api.github.com/users/daimoonis/followers","following_url":"https://api.github.com/users/daimoonis/following{/other_user}","gists_url":"https://api.github.com/users/daimoonis/gists{/gist_id}","starred_url":"https://api.github.com/users/daimoonis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daimoonis/subscriptions","organizations_url":"https://api.github.com/users/daimoonis/orgs","repos_url":"https://api.github.com/users/daimoonis/repos","events_url":"https://api.github.com/users/daimoonis/events{/privacy}","received_events_url":"https://api.github.com/users/daimoonis/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nThank you for your work at fab-speed-dial library.\r\n\r\nI would like to share my changes to my fork of your library. My changes are based on old material fab-speed-dial feature, that speed dial has been automatically closed on document click  [https://github.com/angular/material/blob/master/src/components/fabSpeedDial/fabController.js#L178](https://github.com/angular/material/blob/master/src/components/fabSpeedDial/fabController.js#L178)\r\n\r\nWhat do you think about such feature as part of your library?","created_at":"2018-10-29T22:31:38Z","updated_at":"2018-10-30T21:30:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f19a8d1cccd78a2b94bec6ca72eab61612d37e89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/issues/12/comments","statuses_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/statuses/25173482ef52519b662ef6a9ef135b4297164ca8","head":{"label":"daimoonis:master","ref":"master","sha":"25173482ef52519b662ef6a9ef135b4297164ca8","user":{"login":"daimoonis","id":10496111,"node_id":"MDQ6VXNlcjEwNDk2MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/10496111?v=4","gravatar_id":"","url":"https://api.github.com/users/daimoonis","html_url":"https://github.com/daimoonis","followers_url":"https://api.github.com/users/daimoonis/followers","following_url":"https://api.github.com/users/daimoonis/following{/other_user}","gists_url":"https://api.github.com/users/daimoonis/gists{/gist_id}","starred_url":"https://api.github.com/users/daimoonis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daimoonis/subscriptions","organizations_url":"https://api.github.com/users/daimoonis/orgs","repos_url":"https://api.github.com/users/daimoonis/repos","events_url":"https://api.github.com/users/daimoonis/events{/privacy}","received_events_url":"https://api.github.com/users/daimoonis/received_events","type":"User","site_admin":false},"repo":{"id":155286777,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUyODY3Nzc=","name":"fab-speed-dial","full_name":"daimoonis/fab-speed-dial","private":false,"owner":{"login":"daimoonis","id":10496111,"node_id":"MDQ6VXNlcjEwNDk2MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/10496111?v=4","gravatar_id":"","url":"https://api.github.com/users/daimoonis","html_url":"https://github.com/daimoonis","followers_url":"https://api.github.com/users/daimoonis/followers","following_url":"https://api.github.com/users/daimoonis/following{/other_user}","gists_url":"https://api.github.com/users/daimoonis/gists{/gist_id}","starred_url":"https://api.github.com/users/daimoonis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daimoonis/subscriptions","organizations_url":"https://api.github.com/users/daimoonis/orgs","repos_url":"https://api.github.com/users/daimoonis/repos","events_url":"https://api.github.com/users/daimoonis/events{/privacy}","received_events_url":"https://api.github.com/users/daimoonis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/daimoonis/fab-speed-dial","description":"Angular Material FAB speed dial","fork":true,"url":"https://api.github.com/repos/daimoonis/fab-speed-dial","forks_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/forks","keys_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/teams","hooks_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/hooks","issue_events_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/issues/events{/number}","events_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/events","assignees_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/assignees{/user}","branches_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/branches{/branch}","tags_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/tags","blobs_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/git/refs{/sha}","trees_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/statuses/{sha}","languages_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/languages","stargazers_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/stargazers","contributors_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/contributors","subscribers_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/subscribers","subscription_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/subscription","commits_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/commits{/sha}","git_commits_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/git/commits{/sha}","comments_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/comments{/number}","issue_comment_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/issues/comments{/number}","contents_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/contents/{+path}","compare_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/merges","archive_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/downloads","issues_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/issues{/number}","pulls_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/pulls{/number}","milestones_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/milestones{/number}","notifications_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/labels{/name}","releases_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/releases{/id}","deployments_url":"https://api.github.com/repos/daimoonis/fab-speed-dial/deployments","created_at":"2018-10-29T21:58:02Z","updated_at":"2018-10-30T21:26:05Z","pushed_at":"2018-10-30T21:26:02Z","git_url":"git://github.com/daimoonis/fab-speed-dial.git","ssh_url":"git@github.com:daimoonis/fab-speed-dial.git","clone_url":"https://github.com/daimoonis/fab-speed-dial.git","svn_url":"https://github.com/daimoonis/fab-speed-dial","homepage":"https://ecodev.github.io/fab-speed-dial","size":800,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ecodev:master","ref":"master","sha":"afb5433af478a79985a87d1d5979d3f4fe725f10","user":{"login":"Ecodev","id":1638883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzg4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1638883?v=4","gravatar_id":"","url":"https://api.github.com/users/Ecodev","html_url":"https://github.com/Ecodev","followers_url":"https://api.github.com/users/Ecodev/followers","following_url":"https://api.github.com/users/Ecodev/following{/other_user}","gists_url":"https://api.github.com/users/Ecodev/gists{/gist_id}","starred_url":"https://api.github.com/users/Ecodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ecodev/subscriptions","organizations_url":"https://api.github.com/users/Ecodev/orgs","repos_url":"https://api.github.com/users/Ecodev/repos","events_url":"https://api.github.com/users/Ecodev/events{/privacy}","received_events_url":"https://api.github.com/users/Ecodev/received_events","type":"Organization","site_admin":false},"repo":{"id":119398375,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkzOTgzNzU=","name":"fab-speed-dial","full_name":"Ecodev/fab-speed-dial","private":false,"owner":{"login":"Ecodev","id":1638883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzg4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1638883?v=4","gravatar_id":"","url":"https://api.github.com/users/Ecodev","html_url":"https://github.com/Ecodev","followers_url":"https://api.github.com/users/Ecodev/followers","following_url":"https://api.github.com/users/Ecodev/following{/other_user}","gists_url":"https://api.github.com/users/Ecodev/gists{/gist_id}","starred_url":"https://api.github.com/users/Ecodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ecodev/subscriptions","organizations_url":"https://api.github.com/users/Ecodev/orgs","repos_url":"https://api.github.com/users/Ecodev/repos","events_url":"https://api.github.com/users/Ecodev/events{/privacy}","received_events_url":"https://api.github.com/users/Ecodev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ecodev/fab-speed-dial","description":"Angular Material FAB speed dial","fork":false,"url":"https://api.github.com/repos/Ecodev/fab-speed-dial","forks_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/forks","keys_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/teams","hooks_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/hooks","issue_events_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/issues/events{/number}","events_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/events","assignees_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/assignees{/user}","branches_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/branches{/branch}","tags_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/tags","blobs_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/statuses/{sha}","languages_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/languages","stargazers_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/stargazers","contributors_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/contributors","subscribers_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/subscribers","subscription_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/subscription","commits_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/contents/{+path}","compare_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/merges","archive_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/downloads","issues_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/issues{/number}","pulls_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls{/number}","milestones_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/milestones{/number}","notifications_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/labels{/name}","releases_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/releases{/id}","deployments_url":"https://api.github.com/repos/Ecodev/fab-speed-dial/deployments","created_at":"2018-01-29T15:07:56Z","updated_at":"2018-10-27T05:53:37Z","pushed_at":"2018-10-30T21:26:04Z","git_url":"git://github.com/Ecodev/fab-speed-dial.git","ssh_url":"git@github.com:Ecodev/fab-speed-dial.git","clone_url":"https://github.com/Ecodev/fab-speed-dial.git","svn_url":"https://github.com/Ecodev/fab-speed-dial","homepage":"https://ecodev.github.io/fab-speed-dial","size":797,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":2,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12"},"html":{"href":"https://github.com/Ecodev/fab-speed-dial/pull/12"},"issue":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/issues/12"},"comments":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Ecodev/fab-speed-dial/statuses/25173482ef52519b662ef6a9ef135b4297164ca8"}},"author_association":"NONE"}}
{"actor":{"display_login":"daimoonis"}}