{"action":"created","comment":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/comments/213539257","pull_request_review_id":150395575,"id":213539257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzUzOTI1Nw==","diff_hunk":"@@ -424,8 +441,8 @@ function* fetchVmsSessions ({ vms }) {\n   })\n }\n \n-function* fetchVmCDRom ({ vmId, running }) {\n-  const cdrom = yield callExternalAction('getCDRom', Api.getCDRom, { type: 'GET_VM_CDROM', payload: { vmId, running } })\n+function* fetchVmCDRom ({ vmId }) {","path":"src/sagas.js","position":56,"original_position":56,"commit_id":"053481c6aec3dcc9d316ab28f1f22f3d093bf25c","original_commit_id":"053481c6aec3dcc9d316ab28f1f22f3d093bf25c","user":{"login":"sjd78","id":3985964,"node_id":"MDQ6VXNlcjM5ODU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3985964?v=4","gravatar_id":"","url":"https://api.github.com/users/sjd78","html_url":"https://github.com/sjd78","followers_url":"https://api.github.com/users/sjd78/followers","following_url":"https://api.github.com/users/sjd78/following{/other_user}","gists_url":"https://api.github.com/users/sjd78/gists{/gist_id}","starred_url":"https://api.github.com/users/sjd78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjd78/subscriptions","organizations_url":"https://api.github.com/users/sjd78/orgs","repos_url":"https://api.github.com/users/sjd78/repos","events_url":"https://api.github.com/users/sjd78/events{/privacy}","received_events_url":"https://api.github.com/users/sjd78/received_events","type":"User","site_admin":false},"body":"Just an inconsequential oversight  (yay destructuring doesn't break when you send in more object keys then it's looking for).  I'll clean it up.","created_at":"2018-08-29T04:07:49Z","updated_at":"2018-08-29T04:07:49Z","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/742#discussion_r213539257","pull_request_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/comments/213539257"},"html":{"href":"https://github.com/oVirt/ovirt-web-ui/pull/742#discussion_r213539257"},"pull_request":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742"}},"in_reply_to_id":212952963},"pull_request":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742","id":210776074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzc2MDc0","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/742","diff_url":"https://github.com/oVirt/ovirt-web-ui/pull/742.diff","patch_url":"https://github.com/oVirt/ovirt-web-ui/pull/742.patch","issue_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/742","number":742,"state":"open","locked":false,"title":"refactor VM cdrom handling to work on the current/running VM","user":{"login":"sjd78","id":3985964,"node_id":"MDQ6VXNlcjM5ODU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3985964?v=4","gravatar_id":"","url":"https://api.github.com/users/sjd78","html_url":"https://github.com/sjd78","followers_url":"https://api.github.com/users/sjd78/followers","following_url":"https://api.github.com/users/sjd78/following{/other_user}","gists_url":"https://api.github.com/users/sjd78/gists{/gist_id}","starred_url":"https://api.github.com/users/sjd78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjd78/subscriptions","organizations_url":"https://api.github.com/users/sjd78/orgs","repos_url":"https://api.github.com/users/sjd78/repos","events_url":"https://api.github.com/users/sjd78/events{/privacy}","received_events_url":"https://api.github.com/users/sjd78/received_events","type":"User","site_admin":false},"body":"Fixes: #698 \r\nNeeded for: #701\r\n\r\nChange details:\r\n - default REST API to use \"current=true\" on cdroms\r\n\r\n - VM single fetch saga needs to explicitly fetch the cdrom as the\r\n   VM's follow=cdrom defaults to \"current=false\"\r\n\r\n - if the VM is not running, skip fetching cdrom info\r\n\r\n - modified the internal cdrom object to make it flatter\r\n\r\n - adjusted legacy view and edit components to use the new internal\r\n   structure for cdrom\r\n\r\n\r\n","created_at":"2018-08-24T15:35:24Z","updated_at":"2018-08-29T04:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa08300f7d06cdac6360aebc9c707885162e9a2d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gregsheremeta","id":2248293,"node_id":"MDQ6VXNlcjIyNDgyOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2248293?v=4","gravatar_id":"","url":"https://api.github.com/users/gregsheremeta","html_url":"https://github.com/gregsheremeta","followers_url":"https://api.github.com/users/gregsheremeta/followers","following_url":"https://api.github.com/users/gregsheremeta/following{/other_user}","gists_url":"https://api.github.com/users/gregsheremeta/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsheremeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsheremeta/subscriptions","organizations_url":"https://api.github.com/users/gregsheremeta/orgs","repos_url":"https://api.github.com/users/gregsheremeta/repos","events_url":"https://api.github.com/users/gregsheremeta/events{/privacy}","received_events_url":"https://api.github.com/users/gregsheremeta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":968933840,"node_id":"MDU6TGFiZWw5Njg5MzM4NDA=","url":"https://api.github.com/repos/oVirt/ovirt-web-ui/labels/redesign","name":"redesign","color":"d0a9f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742/commits","review_comments_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742/comments","review_comment_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/742/comments","statuses_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/statuses/053481c6aec3dcc9d316ab28f1f22f3d093bf25c","head":{"label":"sjd78:refactor-cdrom","ref":"refactor-cdrom","sha":"053481c6aec3dcc9d316ab28f1f22f3d093bf25c","user":{"login":"sjd78","id":3985964,"node_id":"MDQ6VXNlcjM5ODU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3985964?v=4","gravatar_id":"","url":"https://api.github.com/users/sjd78","html_url":"https://github.com/sjd78","followers_url":"https://api.github.com/users/sjd78/followers","following_url":"https://api.github.com/users/sjd78/following{/other_user}","gists_url":"https://api.github.com/users/sjd78/gists{/gist_id}","starred_url":"https://api.github.com/users/sjd78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjd78/subscriptions","organizations_url":"https://api.github.com/users/sjd78/orgs","repos_url":"https://api.github.com/users/sjd78/repos","events_url":"https://api.github.com/users/sjd78/events{/privacy}","received_events_url":"https://api.github.com/users/sjd78/received_events","type":"User","site_admin":false},"repo":{"id":123598640,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1OTg2NDA=","name":"ovirt-web-ui","full_name":"sjd78/ovirt-web-ui","owner":{"login":"sjd78","id":3985964,"node_id":"MDQ6VXNlcjM5ODU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3985964?v=4","gravatar_id":"","url":"https://api.github.com/users/sjd78","html_url":"https://github.com/sjd78","followers_url":"https://api.github.com/users/sjd78/followers","following_url":"https://api.github.com/users/sjd78/following{/other_user}","gists_url":"https://api.github.com/users/sjd78/gists{/gist_id}","starred_url":"https://api.github.com/users/sjd78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjd78/subscriptions","organizations_url":"https://api.github.com/users/sjd78/orgs","repos_url":"https://api.github.com/users/sjd78/repos","events_url":"https://api.github.com/users/sjd78/events{/privacy}","received_events_url":"https://api.github.com/users/sjd78/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjd78/ovirt-web-ui","description":null,"fork":true,"url":"https://api.github.com/repos/sjd78/ovirt-web-ui","forks_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/forks","keys_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/teams","hooks_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/hooks","issue_events_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/events","assignees_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/tags","blobs_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/languages","stargazers_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/stargazers","contributors_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/contributors","subscribers_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/subscribers","subscription_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/subscription","commits_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/merges","archive_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/downloads","issues_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/labels{/name}","releases_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sjd78/ovirt-web-ui/deployments","created_at":"2018-03-02T15:51:43Z","updated_at":"2018-08-26T22:21:47Z","pushed_at":"2018-08-27T02:49:46Z","git_url":"git://github.com/sjd78/ovirt-web-ui.git","ssh_url":"git@github.com:sjd78/ovirt-web-ui.git","clone_url":"https://github.com/sjd78/ovirt-web-ui.git","svn_url":"https://github.com/sjd78/ovirt-web-ui","homepage":null,"size":3451,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"oVirt:master","ref":"master","sha":"a49fc4f3043cd18842ec953621565b0e5e5ae5d0","user":{"login":"oVirt","id":1318634,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTg2MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1318634?v=4","gravatar_id":"","url":"https://api.github.com/users/oVirt","html_url":"https://github.com/oVirt","followers_url":"https://api.github.com/users/oVirt/followers","following_url":"https://api.github.com/users/oVirt/following{/other_user}","gists_url":"https://api.github.com/users/oVirt/gists{/gist_id}","starred_url":"https://api.github.com/users/oVirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oVirt/subscriptions","organizations_url":"https://api.github.com/users/oVirt/orgs","repos_url":"https://api.github.com/users/oVirt/repos","events_url":"https://api.github.com/users/oVirt/events{/privacy}","received_events_url":"https://api.github.com/users/oVirt/received_events","type":"Organization","site_admin":false},"repo":{"id":69250383,"node_id":"MDEwOlJlcG9zaXRvcnk2OTI1MDM4Mw==","name":"ovirt-web-ui","full_name":"oVirt/ovirt-web-ui","owner":{"login":"oVirt","id":1318634,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTg2MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1318634?v=4","gravatar_id":"","url":"https://api.github.com/users/oVirt","html_url":"https://github.com/oVirt","followers_url":"https://api.github.com/users/oVirt/followers","following_url":"https://api.github.com/users/oVirt/following{/other_user}","gists_url":"https://api.github.com/users/oVirt/gists{/gist_id}","starred_url":"https://api.github.com/users/oVirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oVirt/subscriptions","organizations_url":"https://api.github.com/users/oVirt/orgs","repos_url":"https://api.github.com/users/oVirt/repos","events_url":"https://api.github.com/users/oVirt/events{/privacy}","received_events_url":"https://api.github.com/users/oVirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oVirt/ovirt-web-ui","description":"Modern lightweight UI for standard (non-admin) oVirt users","fork":false,"url":"https://api.github.com/repos/oVirt/ovirt-web-ui","forks_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/forks","keys_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/teams","hooks_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/hooks","issue_events_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/events{/number}","events_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/events","assignees_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/assignees{/user}","branches_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/branches{/branch}","tags_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/tags","blobs_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/languages","stargazers_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/stargazers","contributors_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/contributors","subscribers_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/subscribers","subscription_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/subscription","commits_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/contents/{+path}","compare_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/merges","archive_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/downloads","issues_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues{/number}","pulls_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/labels{/name}","releases_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/releases{/id}","deployments_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/deployments","created_at":"2016-09-26T13:01:02Z","updated_at":"2018-08-25T04:50:50Z","pushed_at":"2018-08-28T14:52:49Z","git_url":"git://github.com/oVirt/ovirt-web-ui.git","ssh_url":"git@github.com:oVirt/ovirt-web-ui.git","clone_url":"https://github.com/oVirt/ovirt-web-ui.git","svn_url":"https://github.com/oVirt/ovirt-web-ui","homepage":"https://www.ovirt.org","size":3616,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":88,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742"},"html":{"href":"https://github.com/oVirt/ovirt-web-ui/pull/742"},"issue":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/742"},"comments":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/742/comments"},"review_comments":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742/comments"},"review_comment":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/742/commits"},"statuses":{"href":"https://api.github.com/repos/oVirt/ovirt-web-ui/statuses/053481c6aec3dcc9d316ab28f1f22f3d093bf25c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sjd78"}}