{"action":"opened","number":6573,"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/6573","id":225517897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTE3ODk3","html_url":"https://github.com/SeleniumHQ/selenium/pull/6573","diff_url":"https://github.com/SeleniumHQ/selenium/pull/6573.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/6573.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/6573","number":6573,"state":"open","locked":false,"title":"Adding visibility, invisibility and toBeClickable conditions.","user":{"login":"vanilsonbr","id":22181861,"node_id":"MDQ6VXNlcjIyMTgxODYx","avatar_url":"https://avatars0.githubusercontent.com/u/22181861?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilsonbr","html_url":"https://github.com/vanilsonbr","followers_url":"https://api.github.com/users/vanilsonbr/followers","following_url":"https://api.github.com/users/vanilsonbr/following{/other_user}","gists_url":"https://api.github.com/users/vanilsonbr/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilsonbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilsonbr/subscriptions","organizations_url":"https://api.github.com/users/vanilsonbr/orgs","repos_url":"https://api.github.com/users/vanilsonbr/repos","events_url":"https://api.github.com/users/vanilsonbr/events{/privacy}","received_events_url":"https://api.github.com/users/vanilsonbr/received_events","type":"User","site_admin":false},"body":"My team needed to adapt the java selenium code into node coe, and we needed support to three java existing conditions in our scripts: `ExpectedConditions::elementToBeClickable`, `ExpectedConditions::visibilityOfElementLocated` and `ExpectedConditions::invisibilityOfElementLocated` . I created an Until.js module extension to add those functions so that we didn't need too much changes on ours scripts. I decided to make this Pull Request to provide my code.\r\n\r\nI was using async/await with those functions, but rewrited using Promise to follow the line of implementation that node's Until.js uses.\r\n\r\n\r\n- [X] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#step-6-sign-the-cla)\r\n\r\n","created_at":"2018-10-24T19:12:12Z","updated_at":"2018-10-24T19:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/6573/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/6573/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/6573/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/ccc3ac82ed69e91feed2bdff90ee5bb1d72c7284","head":{"label":"vanilsonbr:master","ref":"master","sha":"ccc3ac82ed69e91feed2bdff90ee5bb1d72c7284","user":{"login":"vanilsonbr","id":22181861,"node_id":"MDQ6VXNlcjIyMTgxODYx","avatar_url":"https://avatars0.githubusercontent.com/u/22181861?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilsonbr","html_url":"https://github.com/vanilsonbr","followers_url":"https://api.github.com/users/vanilsonbr/followers","following_url":"https://api.github.com/users/vanilsonbr/following{/other_user}","gists_url":"https://api.github.com/users/vanilsonbr/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilsonbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilsonbr/subscriptions","organizations_url":"https://api.github.com/users/vanilsonbr/orgs","repos_url":"https://api.github.com/users/vanilsonbr/repos","events_url":"https://api.github.com/users/vanilsonbr/events{/privacy}","received_events_url":"https://api.github.com/users/vanilsonbr/received_events","type":"User","site_admin":false},"repo":{"id":154542653,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1NDI2NTM=","name":"selenium","full_name":"vanilsonbr/selenium","private":false,"owner":{"login":"vanilsonbr","id":22181861,"node_id":"MDQ6VXNlcjIyMTgxODYx","avatar_url":"https://avatars0.githubusercontent.com/u/22181861?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilsonbr","html_url":"https://github.com/vanilsonbr","followers_url":"https://api.github.com/users/vanilsonbr/followers","following_url":"https://api.github.com/users/vanilsonbr/following{/other_user}","gists_url":"https://api.github.com/users/vanilsonbr/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilsonbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilsonbr/subscriptions","organizations_url":"https://api.github.com/users/vanilsonbr/orgs","repos_url":"https://api.github.com/users/vanilsonbr/repos","events_url":"https://api.github.com/users/vanilsonbr/events{/privacy}","received_events_url":"https://api.github.com/users/vanilsonbr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vanilsonbr/selenium","description":"A browser automation framework and ecosystem.","fork":true,"url":"https://api.github.com/repos/vanilsonbr/selenium","forks_url":"https://api.github.com/repos/vanilsonbr/selenium/forks","keys_url":"https://api.github.com/repos/vanilsonbr/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilsonbr/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilsonbr/selenium/teams","hooks_url":"https://api.github.com/repos/vanilsonbr/selenium/hooks","issue_events_url":"https://api.github.com/repos/vanilsonbr/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/vanilsonbr/selenium/events","assignees_url":"https://api.github.com/repos/vanilsonbr/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/vanilsonbr/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/vanilsonbr/selenium/tags","blobs_url":"https://api.github.com/repos/vanilsonbr/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilsonbr/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilsonbr/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilsonbr/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilsonbr/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilsonbr/selenium/languages","stargazers_url":"https://api.github.com/repos/vanilsonbr/selenium/stargazers","contributors_url":"https://api.github.com/repos/vanilsonbr/selenium/contributors","subscribers_url":"https://api.github.com/repos/vanilsonbr/selenium/subscribers","subscription_url":"https://api.github.com/repos/vanilsonbr/selenium/subscription","commits_url":"https://api.github.com/repos/vanilsonbr/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilsonbr/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilsonbr/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilsonbr/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilsonbr/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/vanilsonbr/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilsonbr/selenium/merges","archive_url":"https://api.github.com/repos/vanilsonbr/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilsonbr/selenium/downloads","issues_url":"https://api.github.com/repos/vanilsonbr/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/vanilsonbr/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilsonbr/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilsonbr/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilsonbr/selenium/labels{/name}","releases_url":"https://api.github.com/repos/vanilsonbr/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/vanilsonbr/selenium/deployments","created_at":"2018-10-24T17:39:04Z","updated_at":"2018-10-24T18:55:45Z","pushed_at":"2018-10-24T18:55:36Z","git_url":"git://github.com/vanilsonbr/selenium.git","ssh_url":"git@github.com:vanilsonbr/selenium.git","clone_url":"https://github.com/vanilsonbr/selenium.git","svn_url":"https://github.com/vanilsonbr/selenium","homepage":"https://www.seleniumhq.org","size":1660230,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"1de197b1ae7fd5133d8075be47dd83e123fcf158","user":{"login":"SeleniumHQ","id":983927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MzkyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/983927?v=4","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"node_id":"MDEwOlJlcG9zaXRvcnk3NjEzMjU3","name":"selenium","full_name":"SeleniumHQ/selenium","private":false,"owner":{"login":"SeleniumHQ","id":983927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MzkyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/983927?v=4","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SeleniumHQ/selenium","description":"A browser automation framework and ecosystem.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/SeleniumHQ/selenium/deployments","created_at":"2013-01-14T21:40:56Z","updated_at":"2018-10-24T13:51:59Z","pushed_at":"2018-10-24T09:56:33Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"https://www.seleniumhq.org","size":1660230,"stargazers_count":12313,"watchers_count":12313,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4366,"mirror_url":null,"archived":false,"open_issues_count":482,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4366,"open_issues":482,"watchers":12313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/6573"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/6573"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/6573"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/6573/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/6573/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/6573/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/ccc3ac82ed69e91feed2bdff90ee5bb1d72c7284"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":78,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"vanilsonbr"}}