{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/191233882","pull_request_review_id":123767750,"id":191233882,"diff_hunk":"@@ -404,6 +404,16 @@ void FlightPathMovementGenerator::DoFinalize(Player* player)\n     }\n \n     player->RemoveFlag(PLAYER_FLAGS, PLAYER_FLAGS_TAXI_BENCHMARK);\n+\n+    if (ShapeshiftForm form = player->GetShapeshiftForm())\n+    {\n+        SpellShapeshiftFormEntry const* shapeshift = sSpellShapeshiftFormStore.LookupEntry(form);\n+        if (!shapeshift)","path":"src/server/game/Movement/MovementGenerators/WaypointMovementGenerator.cpp","position":8,"original_position":8,"commit_id":"49870275245732621921a0fc79de92956279eb05","original_commit_id":"49870275245732621921a0fc79de92956279eb05","user":{"login":"LluisMas","id":16152037,"avatar_url":"https://avatars2.githubusercontent.com/u/16152037?v=4","gravatar_id":"","url":"https://api.github.com/users/LluisMas","html_url":"https://github.com/LluisMas","followers_url":"https://api.github.com/users/LluisMas/followers","following_url":"https://api.github.com/users/LluisMas/following{/other_user}","gists_url":"https://api.github.com/users/LluisMas/gists{/gist_id}","starred_url":"https://api.github.com/users/LluisMas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LluisMas/subscriptions","organizations_url":"https://api.github.com/users/LluisMas/orgs","repos_url":"https://api.github.com/users/LluisMas/repos","events_url":"https://api.github.com/users/LluisMas/events{/privacy}","received_events_url":"https://api.github.com/users/LluisMas/received_events","type":"User","site_admin":false},"body":"To check if the player is shapeshifted to return his displayid","created_at":"2018-05-28T15:33:02Z","updated_at":"2018-05-28T15:33:02Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/21943#discussion_r191233882","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/191233882"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/21943#discussion_r191233882"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943"}},"in_reply_to_id":191233233},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943","id":188873453,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/21943","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/21943.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/21943.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/21943","number":21943,"state":"open","locked":false,"title":"Core/Player: Proper handling mount and shapeshift on Flight Path start and end.","user":{"login":"LluisMas","id":16152037,"avatar_url":"https://avatars2.githubusercontent.com/u/16152037?v=4","gravatar_id":"","url":"https://api.github.com/users/LluisMas","html_url":"https://github.com/LluisMas","followers_url":"https://api.github.com/users/LluisMas/followers","following_url":"https://api.github.com/users/LluisMas/following{/other_user}","gists_url":"https://api.github.com/users/LluisMas/gists{/gist_id}","starred_url":"https://api.github.com/users/LluisMas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LluisMas/subscriptions","organizations_url":"https://api.github.com/users/LluisMas/orgs","repos_url":"https://api.github.com/users/LluisMas/repos","events_url":"https://api.github.com/users/LluisMas/events{/privacy}","received_events_url":"https://api.github.com/users/LluisMas/received_events","type":"User","site_admin":false},"body":"<!--- (**********************************)\r\n      (** Fill in the following fields **)\r\n      (**********************************) --->\r\n\r\n**Changes proposed:**\r\n\r\n- Making the player dismount automatically before taking a flying path.\r\n\r\n**Target branch(es):** 3.3.5/master\r\n\r\n- [x] master\r\n\r\n**Issues addressed:** Closes #  (insert issue tracker number)\r\n\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc.)\r\n\r\nTested in-game\r\n\r\n** Information of the problem: ** As you can see on the video below, it should dismount automatically when picking a flying route. Currently you get an annoying \"Already mounted\" message and you have to dismount automatically.\r\n\r\nVideo from retail: https://youtu.be/CjKve6enXX8\r\n\r\n**TODO**\r\n- [x] Reset druid shapeshift displayid and apply it again when the route is finished.\r\n\r\nPS: It's my first pull request here I hope I did okay.\r\n<!--- Notes\r\n- Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request.\r\n- If this PR only contains SQL files, open a new issue instead and post or link the SQL in the issue.\r\n- When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts.\r\n--->","created_at":"2018-05-17T22:03:07Z","updated_at":"2018-05-28T15:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a69b98a0d95c10ef6b3e2313904b2f5915497a91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/21943/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/49870275245732621921a0fc79de92956279eb05","head":{"label":"LluisMas:Fixes","ref":"Fixes","sha":"49870275245732621921a0fc79de92956279eb05","user":{"login":"LluisMas","id":16152037,"avatar_url":"https://avatars2.githubusercontent.com/u/16152037?v=4","gravatar_id":"","url":"https://api.github.com/users/LluisMas","html_url":"https://github.com/LluisMas","followers_url":"https://api.github.com/users/LluisMas/followers","following_url":"https://api.github.com/users/LluisMas/following{/other_user}","gists_url":"https://api.github.com/users/LluisMas/gists{/gist_id}","starred_url":"https://api.github.com/users/LluisMas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LluisMas/subscriptions","organizations_url":"https://api.github.com/users/LluisMas/orgs","repos_url":"https://api.github.com/users/LluisMas/repos","events_url":"https://api.github.com/users/LluisMas/events{/privacy}","received_events_url":"https://api.github.com/users/LluisMas/received_events","type":"User","site_admin":false},"repo":{"id":133870163,"name":"TrinityCore","full_name":"LluisMas/TrinityCore","owner":{"login":"LluisMas","id":16152037,"avatar_url":"https://avatars2.githubusercontent.com/u/16152037?v=4","gravatar_id":"","url":"https://api.github.com/users/LluisMas","html_url":"https://github.com/LluisMas","followers_url":"https://api.github.com/users/LluisMas/followers","following_url":"https://api.github.com/users/LluisMas/following{/other_user}","gists_url":"https://api.github.com/users/LluisMas/gists{/gist_id}","starred_url":"https://api.github.com/users/LluisMas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LluisMas/subscriptions","organizations_url":"https://api.github.com/users/LluisMas/orgs","repos_url":"https://api.github.com/users/LluisMas/repos","events_url":"https://api.github.com/users/LluisMas/events{/privacy}","received_events_url":"https://api.github.com/users/LluisMas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LluisMas/TrinityCore","description":"TrinityCore Open Source MMO Framework (master = 7.3.5.26365, 3.3.5 = 3.3.5a.12340)","fork":true,"url":"https://api.github.com/repos/LluisMas/TrinityCore","forks_url":"https://api.github.com/repos/LluisMas/TrinityCore/forks","keys_url":"https://api.github.com/repos/LluisMas/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LluisMas/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LluisMas/TrinityCore/teams","hooks_url":"https://api.github.com/repos/LluisMas/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/LluisMas/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/LluisMas/TrinityCore/events","assignees_url":"https://api.github.com/repos/LluisMas/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/LluisMas/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/LluisMas/TrinityCore/tags","blobs_url":"https://api.github.com/repos/LluisMas/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LluisMas/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LluisMas/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/LluisMas/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LluisMas/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/LluisMas/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/LluisMas/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/LluisMas/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/LluisMas/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/LluisMas/TrinityCore/subscription","commits_url":"https://api.github.com/repos/LluisMas/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/LluisMas/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/LluisMas/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/LluisMas/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/LluisMas/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/LluisMas/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LluisMas/TrinityCore/merges","archive_url":"https://api.github.com/repos/LluisMas/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LluisMas/TrinityCore/downloads","issues_url":"https://api.github.com/repos/LluisMas/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/LluisMas/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/LluisMas/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/LluisMas/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LluisMas/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/LluisMas/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/LluisMas/TrinityCore/deployments","created_at":"2018-05-17T21:27:20Z","updated_at":"2018-05-18T20:08:18Z","pushed_at":"2018-05-28T12:40:35Z","git_url":"git://github.com/LluisMas/TrinityCore.git","ssh_url":"git@github.com:LluisMas/TrinityCore.git","clone_url":"https://github.com/LluisMas/TrinityCore.git","svn_url":"https://github.com/LluisMas/TrinityCore","homepage":"http://www.trinitycore.org","size":719802,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TrinityCore:master","ref":"master","sha":"084da48ba15aab21916abd88dbe6a03aad0a0edf","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework (master = 7.3.5.26654, 3.3.5 = 3.3.5a.12340)","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2018-05-28T02:47:38Z","pushed_at":"2018-05-28T12:46:32Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":719733,"stargazers_count":4436,"watchers_count":4436,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4118,"mirror_url":null,"archived":false,"open_issues_count":1436,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":4118,"open_issues":1436,"watchers":4436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/21943"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/21943"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/21943/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/21943/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/49870275245732621921a0fc79de92956279eb05"}},"author_association":"NONE"}}
{"actor":{"display_login":"LluisMas"}}