{"action":"created","comment":{"url":"https://api.github.com/repos/sinonjs/lolex/pulls/comments/188529552","pull_request_review_id":120524193,"id":188529552,"diff_hunk":"@@ -722,6 +722,8 @@ function withGlobal(_global) {\n \n         clock.reset = function reset() {\n             clock.timers = {};","path":"src/lolex-src.js","position":3,"original_position":3,"commit_id":"a1bf36cd5e788ba3b1e11d1311a2eb56a0e6504e","original_commit_id":"a1bf36cd5e788ba3b1e11d1311a2eb56a0e6504e","user":{"login":"benjamingr","id":1315533,"avatar_url":"https://avatars2.githubusercontent.com/u/1315533?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamingr","html_url":"https://github.com/benjamingr","followers_url":"https://api.github.com/users/benjamingr/followers","following_url":"https://api.github.com/users/benjamingr/following{/other_user}","gists_url":"https://api.github.com/users/benjamingr/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingr/subscriptions","organizations_url":"https://api.github.com/users/benjamingr/orgs","repos_url":"https://api.github.com/users/benjamingr/repos","events_url":"https://api.github.com/users/benjamingr/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingr/received_events","type":"User","site_admin":false},"body":"Then I think we can do this - it seems reasonable and since lolex is mostly used by bigger consumers rather than independently I think that a big consumer (jest) wanting the feature makes it worthwhile exposing - especially since it's already implemented and probably used but doesn't work well.\r\n\r\nI think the current approach you're using is fine - I was just pointing it out.","created_at":"2018-05-16T07:42:51Z","updated_at":"2018-05-16T07:42:51Z","html_url":"https://github.com/sinonjs/lolex/pull/179#discussion_r188529552","pull_request_url":"https://api.github.com/repos/sinonjs/lolex/pulls/179","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/comments/188529552"},"html":{"href":"https://github.com/sinonjs/lolex/pull/179#discussion_r188529552"},"pull_request":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/179"}},"in_reply_to_id":188521283},"pull_request":{"url":"https://api.github.com/repos/sinonjs/lolex/pulls/179","id":188333296,"html_url":"https://github.com/sinonjs/lolex/pull/179","diff_url":"https://github.com/sinonjs/lolex/pull/179.diff","patch_url":"https://github.com/sinonjs/lolex/pull/179.patch","issue_url":"https://api.github.com/repos/sinonjs/lolex/issues/179","number":179,"state":"open","locked":false,"title":"Clear microtick jobs and set now to 0 in reset","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"body":"#### Purpose (TL;DR) - mandatory\r\n<!--\r\n> give a concise (one or two short sentences) description of what problem is being solved by this PR\r\n>\r\n> Example: Fix issue #123456 by re-structuring the colour selection conditional in method `paintBlue`\r\n-->\r\n\r\nSee #161 for justification. Fixes #161","created_at":"2018-05-16T06:47:39Z","updated_at":"2018-05-16T07:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3048075c7398b6c0da7ed752ef65571fa09b606a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sinonjs/lolex/pulls/179/commits","review_comments_url":"https://api.github.com/repos/sinonjs/lolex/pulls/179/comments","review_comment_url":"https://api.github.com/repos/sinonjs/lolex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinonjs/lolex/issues/179/comments","statuses_url":"https://api.github.com/repos/sinonjs/lolex/statuses/a1bf36cd5e788ba3b1e11d1311a2eb56a0e6504e","head":{"label":"SimenB:reset","ref":"reset","sha":"a1bf36cd5e788ba3b1e11d1311a2eb56a0e6504e","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"repo":{"id":115217099,"name":"lolex","full_name":"SimenB/lolex","owner":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimenB/lolex","description":"Fake setTimeout and friends (collectively known as \"timers\"). Useful in your JavaScript tests. Extracted from Sinon.JS","fork":true,"url":"https://api.github.com/repos/SimenB/lolex","forks_url":"https://api.github.com/repos/SimenB/lolex/forks","keys_url":"https://api.github.com/repos/SimenB/lolex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimenB/lolex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimenB/lolex/teams","hooks_url":"https://api.github.com/repos/SimenB/lolex/hooks","issue_events_url":"https://api.github.com/repos/SimenB/lolex/issues/events{/number}","events_url":"https://api.github.com/repos/SimenB/lolex/events","assignees_url":"https://api.github.com/repos/SimenB/lolex/assignees{/user}","branches_url":"https://api.github.com/repos/SimenB/lolex/branches{/branch}","tags_url":"https://api.github.com/repos/SimenB/lolex/tags","blobs_url":"https://api.github.com/repos/SimenB/lolex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimenB/lolex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimenB/lolex/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimenB/lolex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimenB/lolex/statuses/{sha}","languages_url":"https://api.github.com/repos/SimenB/lolex/languages","stargazers_url":"https://api.github.com/repos/SimenB/lolex/stargazers","contributors_url":"https://api.github.com/repos/SimenB/lolex/contributors","subscribers_url":"https://api.github.com/repos/SimenB/lolex/subscribers","subscription_url":"https://api.github.com/repos/SimenB/lolex/subscription","commits_url":"https://api.github.com/repos/SimenB/lolex/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimenB/lolex/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimenB/lolex/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimenB/lolex/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimenB/lolex/contents/{+path}","compare_url":"https://api.github.com/repos/SimenB/lolex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimenB/lolex/merges","archive_url":"https://api.github.com/repos/SimenB/lolex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimenB/lolex/downloads","issues_url":"https://api.github.com/repos/SimenB/lolex/issues{/number}","pulls_url":"https://api.github.com/repos/SimenB/lolex/pulls{/number}","milestones_url":"https://api.github.com/repos/SimenB/lolex/milestones{/number}","notifications_url":"https://api.github.com/repos/SimenB/lolex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimenB/lolex/labels{/name}","releases_url":"https://api.github.com/repos/SimenB/lolex/releases{/id}","deployments_url":"https://api.github.com/repos/SimenB/lolex/deployments","created_at":"2017-12-23T19:26:50Z","updated_at":"2018-05-13T16:36:02Z","pushed_at":"2018-05-16T06:47:37Z","git_url":"git://github.com/SimenB/lolex.git","ssh_url":"git@github.com:SimenB/lolex.git","clone_url":"https://github.com/SimenB/lolex.git","svn_url":"https://github.com/SimenB/lolex","homepage":null,"size":387,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinonjs:master","ref":"master","sha":"8fb9173a7956a1ee3657cadf3711a087e423135b","user":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":16523712,"name":"lolex","full_name":"sinonjs/lolex","owner":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinonjs/lolex","description":"Fake setTimeout and friends (collectively known as \"timers\"). Useful in your JavaScript tests. Extracted from Sinon.JS","fork":false,"url":"https://api.github.com/repos/sinonjs/lolex","forks_url":"https://api.github.com/repos/sinonjs/lolex/forks","keys_url":"https://api.github.com/repos/sinonjs/lolex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/lolex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/lolex/teams","hooks_url":"https://api.github.com/repos/sinonjs/lolex/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/lolex/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/lolex/events","assignees_url":"https://api.github.com/repos/sinonjs/lolex/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/lolex/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/lolex/tags","blobs_url":"https://api.github.com/repos/sinonjs/lolex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/lolex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/lolex/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/lolex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/lolex/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/lolex/languages","stargazers_url":"https://api.github.com/repos/sinonjs/lolex/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/lolex/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/lolex/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/lolex/subscription","commits_url":"https://api.github.com/repos/sinonjs/lolex/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/lolex/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/lolex/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/lolex/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/lolex/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/lolex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/lolex/merges","archive_url":"https://api.github.com/repos/sinonjs/lolex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/lolex/downloads","issues_url":"https://api.github.com/repos/sinonjs/lolex/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/lolex/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/lolex/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/lolex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/lolex/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/lolex/releases{/id}","deployments_url":"https://api.github.com/repos/sinonjs/lolex/deployments","created_at":"2014-02-04T19:57:17Z","updated_at":"2018-05-16T07:01:07Z","pushed_at":"2018-05-16T06:47:40Z","git_url":"git://github.com/sinonjs/lolex.git","ssh_url":"git@github.com:sinonjs/lolex.git","clone_url":"https://github.com/sinonjs/lolex.git","svn_url":"https://github.com/sinonjs/lolex","homepage":null,"size":389,"stargazers_count":274,"watchers_count":274,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":45,"open_issues":6,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/179"},"html":{"href":"https://github.com/sinonjs/lolex/pull/179"},"issue":{"href":"https://api.github.com/repos/sinonjs/lolex/issues/179"},"comments":{"href":"https://api.github.com/repos/sinonjs/lolex/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/sinonjs/lolex/statuses/a1bf36cd5e788ba3b1e11d1311a2eb56a0e6504e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benjamingr"}}