{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/215590063","pull_request_review_id":152885186,"id":215590063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTU5MDA2Mw==","diff_hunk":"@@ -117,13 +118,34 @@ in if configure == null then weechat else\n         ln -s $plugin $out/plugins\n       done\n     '';\n-  in (writeScriptBin \"weechat\" ''\n-    #!${stdenv.shell}\n-    export WEECHAT_EXTRA_LIBDIR=${pluginsDir}\n-    ${lib.concatMapStringsSep \"\\n\" (p: lib.optionalString (p ? extraEnv) p.extraEnv) plugins}\n-    exec ${weechat}/bin/weechat \"$@\"\n-  '') // {\n-    name = weechat.name;\n-    unwrapped = weechat;\n-    meta = weechat.meta;\n+\n+    init = let\n+      init = builtins.replaceStrings [ \"\\n\" ] [ \";\" ] (config.init or \"\");\n+      scripts = builtins.concatStringsSep \";\" (map (s: \"/script load ${s}\") (config.scripts or []));\n+    in init + scripts;\n+\n+    mkWeechat = bin: (writeScriptBin bin ''\n+      #!${stdenv.shell}\n+      index=0\n+      next=\n+      declare -a list=(\"$@\")\n+      for i in \"$@\"; do\n+        ((index+=1))\n+        if [[ \"$i\" = \"--run-command\" || \"$i\" = \"-r\" ]]; then\n+          next=\"$next;''${list[$index]}\"","path":"pkgs/applications/networking/irc/weechat/default.nix","position":37,"original_position":37,"commit_id":"306791e3113af06ee0a6c57b490f131e434c1dcc","original_commit_id":"306791e3113af06ee0a6c57b490f131e434c1dcc","user":{"login":"timokau","id":3799330,"node_id":"MDQ6VXNlcjM3OTkzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"body":"You currently append to `next` each time you find a `--run-command`, which is different from the default weechat behaviour.\r\n\r\nHowever somebody upstream already said they'll \"implement that quickly\", so it should be fine as-is.","created_at":"2018-09-06T11:25:59Z","updated_at":"2018-09-06T11:25:59Z","html_url":"https://github.com/NixOS/nixpkgs/pull/45728#discussion_r215590063","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/215590063"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45728#discussion_r215590063"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728"}},"in_reply_to_id":215582262},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728","id":211605707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNjA1NzA3","html_url":"https://github.com/NixOS/nixpkgs/pull/45728","diff_url":"https://github.com/NixOS/nixpkgs/pull/45728.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45728.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45728","number":45728,"state":"open","locked":false,"title":"nixos/weechat: add module","user":{"login":"Ma27","id":6025220,"node_id":"MDQ6VXNlcjYwMjUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nFollow-up for #33523. Removed static uid/gid as proposed here (https://github.com/nixos/nixpkgs/pull/33523#issuecomment-372455264) and added support for loading custom scripts.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-08-29T01:53:08Z","updated_at":"2018-09-06T11:25:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cceafb29ccb5fb64d9b46b552898683236f8f0a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122655,"node_id":"MDU6TGFiZWwyOTAxMjI2NTU=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20documentation","name":"8.has: documentation","color":"009800","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45728/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/306791e3113af06ee0a6c57b490f131e434c1dcc","head":{"label":"Ma27:nixos/weechat-module","ref":"nixos/weechat-module","sha":"306791e3113af06ee0a6c57b490f131e434c1dcc","user":{"login":"Ma27","id":6025220,"node_id":"MDQ6VXNlcjYwMjUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"repo":{"id":99414967,"node_id":"MDEwOlJlcG9zaXRvcnk5OTQxNDk2Nw==","name":"nixpkgs","full_name":"Ma27/nixpkgs","owner":{"login":"Ma27","id":6025220,"node_id":"MDQ6VXNlcjYwMjUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ma27/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Ma27/nixpkgs","forks_url":"https://api.github.com/repos/Ma27/nixpkgs/forks","keys_url":"https://api.github.com/repos/Ma27/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ma27/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ma27/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Ma27/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Ma27/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Ma27/nixpkgs/events","assignees_url":"https://api.github.com/repos/Ma27/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Ma27/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Ma27/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Ma27/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ma27/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ma27/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ma27/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ma27/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Ma27/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Ma27/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Ma27/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Ma27/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Ma27/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Ma27/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ma27/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ma27/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ma27/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ma27/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Ma27/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ma27/nixpkgs/merges","archive_url":"https://api.github.com/repos/Ma27/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ma27/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Ma27/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Ma27/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Ma27/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Ma27/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ma27/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Ma27/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Ma27/nixpkgs/deployments","created_at":"2017-08-05T10:08:19Z","updated_at":"2018-09-05T20:44:52Z","pushed_at":"2018-09-06T07:04:17Z","git_url":"git://github.com/Ma27/nixpkgs.git","ssh_url":"git@github.com:Ma27/nixpkgs.git","clone_url":"https://github.com/Ma27/nixpkgs.git","svn_url":"https://github.com/Ma27/nixpkgs","homepage":null,"size":739272,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"b285ea77c2a804333d4a5fec97017e9dccb4545d","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-09-06T10:42:24Z","pushed_at":"2018-09-06T11:07:43Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":849117,"stargazers_count":2748,"watchers_count":2748,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2990,"mirror_url":null,"archived":false,"open_issues_count":3130,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2990,"open_issues":3130,"watchers":2748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45728"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45728"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45728/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45728/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/306791e3113af06ee0a6c57b490f131e434c1dcc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timokau"}}