{"action":"created","comment":{"url":"https://api.github.com/repos/nucypher/nucypher/pulls/comments/214517126","pull_request_review_id":151596965,"id":214517126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDUxNzEyNg==","diff_hunk":"@@ -19,11 +19,17 @@ contract Upgradeable is Ownable {\n     * However the storage layout is specified here in the implementing contracts.\n     **/\n     address public target;\n+\n     /**\n     * @dev Previous contract address (if available). Used for rollback\n     **/\n     address public previousTarget;\n \n+    /**\n+    * @dev Secret hash to proof that user owns previous version of a contract\n+    **/\n+    bytes32 public secretHash;","path":"nucypher/blockchain/eth/sol/source/contracts/proxy/Upgradeable.sol","position":null,"original_position":13,"commit_id":"d320d40eead54a517995bfd05c1c834cf1e4fb62","original_commit_id":"ffe71b0cad1e7f449dc34bf4afbba0788a4fe4a3","user":{"login":"szotov","id":22225795,"node_id":"MDQ6VXNlcjIyMjI1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/22225795?v=4","gravatar_id":"","url":"https://api.github.com/users/szotov","html_url":"https://github.com/szotov","followers_url":"https://api.github.com/users/szotov/followers","following_url":"https://api.github.com/users/szotov/following{/other_user}","gists_url":"https://api.github.com/users/szotov/gists{/gist_id}","starred_url":"https://api.github.com/users/szotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szotov/subscriptions","organizations_url":"https://api.github.com/users/szotov/orgs","repos_url":"https://api.github.com/users/szotov/repos","events_url":"https://api.github.com/users/szotov/events{/privacy}","received_events_url":"https://api.github.com/users/szotov/received_events","type":"User","site_admin":false},"body":"Maybe previous version of contract is not the best name\r\nWho owns contract that already deployed also should know secret (proof of owning) to use it in upgrade","created_at":"2018-09-01T15:55:57Z","updated_at":"2018-09-01T15:55:57Z","html_url":"https://github.com/nucypher/nucypher/pull/374#discussion_r214517126","pull_request_url":"https://api.github.com/repos/nucypher/nucypher/pulls/374","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/comments/214517126"},"html":{"href":"https://github.com/nucypher/nucypher/pull/374#discussion_r214517126"},"pull_request":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/374"}},"in_reply_to_id":214515633},"pull_request":{"url":"https://api.github.com/repos/nucypher/nucypher/pulls/374","id":205971386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTcxMzg2","html_url":"https://github.com/nucypher/nucypher/pull/374","diff_url":"https://github.com/nucypher/nucypher/pull/374.diff","patch_url":"https://github.com/nucypher/nucypher/pull/374.patch","issue_url":"https://api.github.com/repos/nucypher/nucypher/issues/374","number":374,"state":"open","locked":false,"title":"Multi-signature contract with off-chain signing","user":{"login":"szotov","id":22225795,"node_id":"MDQ6VXNlcjIyMjI1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/22225795?v=4","gravatar_id":"","url":"https://api.github.com/users/szotov","html_url":"https://github.com/szotov","followers_url":"https://api.github.com/users/szotov/followers","following_url":"https://api.github.com/users/szotov/following{/other_user}","gists_url":"https://api.github.com/users/szotov/gists{/gist_id}","starred_url":"https://api.github.com/users/szotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szotov/subscriptions","organizations_url":"https://api.github.com/users/szotov/orgs","repos_url":"https://api.github.com/users/szotov/repos","events_url":"https://api.github.com/users/szotov/events{/privacy}","received_events_url":"https://api.github.com/users/szotov/received_events","type":"User","site_admin":false},"body":"Based on #371 \r\n\r\nMulti-signature contract for the upgrading management:\r\n* Contract checks pre-signed transactions\r\n* Allows to remove and add owners and change required number of signed transactions","created_at":"2018-08-03T09:15:21Z","updated_at":"2018-09-01T15:55:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7780785600925f8d1296485099f64854cc605ce7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jMyles","id":311973,"node_id":"MDQ6VXNlcjMxMTk3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/311973?v=4","gravatar_id":"","url":"https://api.github.com/users/jMyles","html_url":"https://github.com/jMyles","followers_url":"https://api.github.com/users/jMyles/followers","following_url":"https://api.github.com/users/jMyles/following{/other_user}","gists_url":"https://api.github.com/users/jMyles/gists{/gist_id}","starred_url":"https://api.github.com/users/jMyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jMyles/subscriptions","organizations_url":"https://api.github.com/users/jMyles/orgs","repos_url":"https://api.github.com/users/jMyles/repos","events_url":"https://api.github.com/users/jMyles/events{/privacy}","received_events_url":"https://api.github.com/users/jMyles/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":980142235,"node_id":"MDU6TGFiZWw5ODAxNDIyMzU=","url":"https://api.github.com/repos/nucypher/nucypher/labels/eth_contracts","name":"eth_contracts","color":"a0c4e5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nucypher/nucypher/pulls/374/commits","review_comments_url":"https://api.github.com/repos/nucypher/nucypher/pulls/374/comments","review_comment_url":"https://api.github.com/repos/nucypher/nucypher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nucypher/nucypher/issues/374/comments","statuses_url":"https://api.github.com/repos/nucypher/nucypher/statuses/d320d40eead54a517995bfd05c1c834cf1e4fb62","head":{"label":"szotov:multisig","ref":"multisig","sha":"d320d40eead54a517995bfd05c1c834cf1e4fb62","user":{"login":"szotov","id":22225795,"node_id":"MDQ6VXNlcjIyMjI1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/22225795?v=4","gravatar_id":"","url":"https://api.github.com/users/szotov","html_url":"https://github.com/szotov","followers_url":"https://api.github.com/users/szotov/followers","following_url":"https://api.github.com/users/szotov/following{/other_user}","gists_url":"https://api.github.com/users/szotov/gists{/gist_id}","starred_url":"https://api.github.com/users/szotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szotov/subscriptions","organizations_url":"https://api.github.com/users/szotov/orgs","repos_url":"https://api.github.com/users/szotov/repos","events_url":"https://api.github.com/users/szotov/events{/privacy}","received_events_url":"https://api.github.com/users/szotov/received_events","type":"User","site_admin":false},"repo":{"id":129104144,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMDQxNDQ=","name":"nucypher-kms","full_name":"szotov/nucypher-kms","owner":{"login":"szotov","id":22225795,"node_id":"MDQ6VXNlcjIyMjI1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/22225795?v=4","gravatar_id":"","url":"https://api.github.com/users/szotov","html_url":"https://github.com/szotov","followers_url":"https://api.github.com/users/szotov/followers","following_url":"https://api.github.com/users/szotov/following{/other_user}","gists_url":"https://api.github.com/users/szotov/gists{/gist_id}","starred_url":"https://api.github.com/users/szotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szotov/subscriptions","organizations_url":"https://api.github.com/users/szotov/orgs","repos_url":"https://api.github.com/users/szotov/repos","events_url":"https://api.github.com/users/szotov/events{/privacy}","received_events_url":"https://api.github.com/users/szotov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szotov/nucypher-kms","description":"Decentralized KMS","fork":true,"url":"https://api.github.com/repos/szotov/nucypher-kms","forks_url":"https://api.github.com/repos/szotov/nucypher-kms/forks","keys_url":"https://api.github.com/repos/szotov/nucypher-kms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szotov/nucypher-kms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szotov/nucypher-kms/teams","hooks_url":"https://api.github.com/repos/szotov/nucypher-kms/hooks","issue_events_url":"https://api.github.com/repos/szotov/nucypher-kms/issues/events{/number}","events_url":"https://api.github.com/repos/szotov/nucypher-kms/events","assignees_url":"https://api.github.com/repos/szotov/nucypher-kms/assignees{/user}","branches_url":"https://api.github.com/repos/szotov/nucypher-kms/branches{/branch}","tags_url":"https://api.github.com/repos/szotov/nucypher-kms/tags","blobs_url":"https://api.github.com/repos/szotov/nucypher-kms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szotov/nucypher-kms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szotov/nucypher-kms/git/refs{/sha}","trees_url":"https://api.github.com/repos/szotov/nucypher-kms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szotov/nucypher-kms/statuses/{sha}","languages_url":"https://api.github.com/repos/szotov/nucypher-kms/languages","stargazers_url":"https://api.github.com/repos/szotov/nucypher-kms/stargazers","contributors_url":"https://api.github.com/repos/szotov/nucypher-kms/contributors","subscribers_url":"https://api.github.com/repos/szotov/nucypher-kms/subscribers","subscription_url":"https://api.github.com/repos/szotov/nucypher-kms/subscription","commits_url":"https://api.github.com/repos/szotov/nucypher-kms/commits{/sha}","git_commits_url":"https://api.github.com/repos/szotov/nucypher-kms/git/commits{/sha}","comments_url":"https://api.github.com/repos/szotov/nucypher-kms/comments{/number}","issue_comment_url":"https://api.github.com/repos/szotov/nucypher-kms/issues/comments{/number}","contents_url":"https://api.github.com/repos/szotov/nucypher-kms/contents/{+path}","compare_url":"https://api.github.com/repos/szotov/nucypher-kms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szotov/nucypher-kms/merges","archive_url":"https://api.github.com/repos/szotov/nucypher-kms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szotov/nucypher-kms/downloads","issues_url":"https://api.github.com/repos/szotov/nucypher-kms/issues{/number}","pulls_url":"https://api.github.com/repos/szotov/nucypher-kms/pulls{/number}","milestones_url":"https://api.github.com/repos/szotov/nucypher-kms/milestones{/number}","notifications_url":"https://api.github.com/repos/szotov/nucypher-kms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szotov/nucypher-kms/labels{/name}","releases_url":"https://api.github.com/repos/szotov/nucypher-kms/releases{/id}","deployments_url":"https://api.github.com/repos/szotov/nucypher-kms/deployments","created_at":"2018-04-11T14:11:00Z","updated_at":"2018-04-11T14:11:02Z","pushed_at":"2018-09-01T15:48:50Z","git_url":"git://github.com/szotov/nucypher-kms.git","ssh_url":"git@github.com:szotov/nucypher-kms.git","clone_url":"https://github.com/szotov/nucypher-kms.git","svn_url":"https://github.com/szotov/nucypher-kms","homepage":null,"size":7705,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nucypher:master","ref":"master","sha":"fb53da206422df4c9838f75c552d90124d770c80","user":{"login":"nucypher","id":24552990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTUyOTkw","avatar_url":"https://avatars0.githubusercontent.com/u/24552990?v=4","gravatar_id":"","url":"https://api.github.com/users/nucypher","html_url":"https://github.com/nucypher","followers_url":"https://api.github.com/users/nucypher/followers","following_url":"https://api.github.com/users/nucypher/following{/other_user}","gists_url":"https://api.github.com/users/nucypher/gists{/gist_id}","starred_url":"https://api.github.com/users/nucypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nucypher/subscriptions","organizations_url":"https://api.github.com/users/nucypher/orgs","repos_url":"https://api.github.com/users/nucypher/repos","events_url":"https://api.github.com/users/nucypher/events{/privacy}","received_events_url":"https://api.github.com/users/nucypher/received_events","type":"Organization","site_admin":false},"repo":{"id":100446516,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0NDY1MTY=","name":"nucypher","full_name":"nucypher/nucypher","owner":{"login":"nucypher","id":24552990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTUyOTkw","avatar_url":"https://avatars0.githubusercontent.com/u/24552990?v=4","gravatar_id":"","url":"https://api.github.com/users/nucypher","html_url":"https://github.com/nucypher","followers_url":"https://api.github.com/users/nucypher/followers","following_url":"https://api.github.com/users/nucypher/following{/other_user}","gists_url":"https://api.github.com/users/nucypher/gists{/gist_id}","starred_url":"https://api.github.com/users/nucypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nucypher/subscriptions","organizations_url":"https://api.github.com/users/nucypher/orgs","repos_url":"https://api.github.com/users/nucypher/repos","events_url":"https://api.github.com/users/nucypher/events{/privacy}","received_events_url":"https://api.github.com/users/nucypher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nucypher/nucypher","description":"A proxy re-encryption network to empower privacy in decentralized systems.","fork":false,"url":"https://api.github.com/repos/nucypher/nucypher","forks_url":"https://api.github.com/repos/nucypher/nucypher/forks","keys_url":"https://api.github.com/repos/nucypher/nucypher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nucypher/nucypher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nucypher/nucypher/teams","hooks_url":"https://api.github.com/repos/nucypher/nucypher/hooks","issue_events_url":"https://api.github.com/repos/nucypher/nucypher/issues/events{/number}","events_url":"https://api.github.com/repos/nucypher/nucypher/events","assignees_url":"https://api.github.com/repos/nucypher/nucypher/assignees{/user}","branches_url":"https://api.github.com/repos/nucypher/nucypher/branches{/branch}","tags_url":"https://api.github.com/repos/nucypher/nucypher/tags","blobs_url":"https://api.github.com/repos/nucypher/nucypher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nucypher/nucypher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nucypher/nucypher/git/refs{/sha}","trees_url":"https://api.github.com/repos/nucypher/nucypher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nucypher/nucypher/statuses/{sha}","languages_url":"https://api.github.com/repos/nucypher/nucypher/languages","stargazers_url":"https://api.github.com/repos/nucypher/nucypher/stargazers","contributors_url":"https://api.github.com/repos/nucypher/nucypher/contributors","subscribers_url":"https://api.github.com/repos/nucypher/nucypher/subscribers","subscription_url":"https://api.github.com/repos/nucypher/nucypher/subscription","commits_url":"https://api.github.com/repos/nucypher/nucypher/commits{/sha}","git_commits_url":"https://api.github.com/repos/nucypher/nucypher/git/commits{/sha}","comments_url":"https://api.github.com/repos/nucypher/nucypher/comments{/number}","issue_comment_url":"https://api.github.com/repos/nucypher/nucypher/issues/comments{/number}","contents_url":"https://api.github.com/repos/nucypher/nucypher/contents/{+path}","compare_url":"https://api.github.com/repos/nucypher/nucypher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nucypher/nucypher/merges","archive_url":"https://api.github.com/repos/nucypher/nucypher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nucypher/nucypher/downloads","issues_url":"https://api.github.com/repos/nucypher/nucypher/issues{/number}","pulls_url":"https://api.github.com/repos/nucypher/nucypher/pulls{/number}","milestones_url":"https://api.github.com/repos/nucypher/nucypher/milestones{/number}","notifications_url":"https://api.github.com/repos/nucypher/nucypher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nucypher/nucypher/labels{/name}","releases_url":"https://api.github.com/repos/nucypher/nucypher/releases{/id}","deployments_url":"https://api.github.com/repos/nucypher/nucypher/deployments","created_at":"2017-08-16T04:07:25Z","updated_at":"2018-09-01T14:40:29Z","pushed_at":"2018-09-01T15:48:52Z","git_url":"git://github.com/nucypher/nucypher.git","ssh_url":"git@github.com:nucypher/nucypher.git","clone_url":"https://github.com/nucypher/nucypher.git","svn_url":"https://github.com/nucypher/nucypher","homepage":"https://nucypher.com","size":7566,"stargazers_count":94,"watchers_count":94,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":77,"license":null,"forks":27,"open_issues":77,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/374"},"html":{"href":"https://github.com/nucypher/nucypher/pull/374"},"issue":{"href":"https://api.github.com/repos/nucypher/nucypher/issues/374"},"comments":{"href":"https://api.github.com/repos/nucypher/nucypher/issues/374/comments"},"review_comments":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/374/comments"},"review_comment":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/374/commits"},"statuses":{"href":"https://api.github.com/repos/nucypher/nucypher/statuses/d320d40eead54a517995bfd05c1c834cf1e4fb62"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"szotov"}}