{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/198648824","pull_request_review_id":132618049,"id":198648824,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODY0ODgyNA==","diff_hunk":"@@ -106,4 +111,45 @@ public BytecodeNode visitVariableReference(VariableReferenceExpression reference\n     {\n         throw new UnsupportedOperationException();\n     }\n+\n+    static class InputReferenceNode\n+            implements BytecodeNode\n+    {\n+        IfStatement ifStatement;\n+        BytecodeExpression block;\n+        BytecodeExpression position;\n+\n+        public InputReferenceNode(IfStatement ifStatement, BytecodeExpression block, BytecodeExpression position)","path":"presto-main/src/main/java/com/facebook/presto/sql/gen/InputReferenceCompiler.java","position":40,"original_position":40,"commit_id":"504a57f83dc06aaf0255b8c89364243987097df6","original_commit_id":"504a57f83dc06aaf0255b8c89364243987097df6","user":{"login":"haozhun","id":2020503,"node_id":"MDQ6VXNlcjIwMjA1MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2020503?v=4","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"body":"@wenleix and I had a discussion.\r\n\r\n1. rename the field to `body`.\r\n2. Move the logic to create the field from `generateInputReference` method to the constructor of `InputReferenceNode`.","created_at":"2018-06-27T21:35:29Z","updated_at":"2018-06-27T21:35:29Z","html_url":"https://github.com/prestodb/presto/pull/10861#discussion_r198648824","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/10861","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/198648824"},"html":{"href":"https://github.com/prestodb/presto/pull/10861#discussion_r198648824"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10861"}},"in_reply_to_id":198620379},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/10861","id":195681790,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjgxNzkw","html_url":"https://github.com/prestodb/presto/pull/10861","diff_url":"https://github.com/prestodb/presto/pull/10861.diff","patch_url":"https://github.com/prestodb/presto/pull/10861.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/10861","number":10861,"state":"open","locked":false,"title":"Implement block_position parameter passing convention","user":{"login":"gerlou","id":15757526,"node_id":"MDQ6VXNlcjE1NzU3NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/15757526?v=4","gravatar_id":"","url":"https://api.github.com/users/gerlou","html_url":"https://github.com/gerlou","followers_url":"https://api.github.com/users/gerlou/followers","following_url":"https://api.github.com/users/gerlou/following{/other_user}","gists_url":"https://api.github.com/users/gerlou/gists{/gist_id}","starred_url":"https://api.github.com/users/gerlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerlou/subscriptions","organizations_url":"https://api.github.com/users/gerlou/orgs","repos_url":"https://api.github.com/users/gerlou/repos","events_url":"https://api.github.com/users/gerlou/events{/privacy}","received_events_url":"https://api.github.com/users/gerlou/received_events","type":"User","site_admin":false},"body":"Implement null convention by passing block and position","created_at":"2018-06-19T00:15:00Z","updated_at":"2018-06-27T21:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d6962f2c4fbae20d2fa25b7e101f5e29388f71","assignee":{"login":"wenleix","id":799346,"node_id":"MDQ6VXNlcjc5OTM0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/799346?v=4","gravatar_id":"","url":"https://api.github.com/users/wenleix","html_url":"https://github.com/wenleix","followers_url":"https://api.github.com/users/wenleix/followers","following_url":"https://api.github.com/users/wenleix/following{/other_user}","gists_url":"https://api.github.com/users/wenleix/gists{/gist_id}","starred_url":"https://api.github.com/users/wenleix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenleix/subscriptions","organizations_url":"https://api.github.com/users/wenleix/orgs","repos_url":"https://api.github.com/users/wenleix/repos","events_url":"https://api.github.com/users/wenleix/events{/privacy}","received_events_url":"https://api.github.com/users/wenleix/received_events","type":"User","site_admin":false},"assignees":[{"login":"wenleix","id":799346,"node_id":"MDQ6VXNlcjc5OTM0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/799346?v=4","gravatar_id":"","url":"https://api.github.com/users/wenleix","html_url":"https://github.com/wenleix","followers_url":"https://api.github.com/users/wenleix/followers","following_url":"https://api.github.com/users/wenleix/following{/other_user}","gists_url":"https://api.github.com/users/wenleix/gists{/gist_id}","starred_url":"https://api.github.com/users/wenleix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenleix/subscriptions","organizations_url":"https://api.github.com/users/wenleix/orgs","repos_url":"https://api.github.com/users/wenleix/repos","events_url":"https://api.github.com/users/wenleix/events{/privacy}","received_events_url":"https://api.github.com/users/wenleix/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/10861/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/10861/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/10861/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/504a57f83dc06aaf0255b8c89364243987097df6","head":{"label":"gerlou:block_and_position","ref":"block_and_position","sha":"504a57f83dc06aaf0255b8c89364243987097df6","user":{"login":"gerlou","id":15757526,"node_id":"MDQ6VXNlcjE1NzU3NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/15757526?v=4","gravatar_id":"","url":"https://api.github.com/users/gerlou","html_url":"https://github.com/gerlou","followers_url":"https://api.github.com/users/gerlou/followers","following_url":"https://api.github.com/users/gerlou/following{/other_user}","gists_url":"https://api.github.com/users/gerlou/gists{/gist_id}","starred_url":"https://api.github.com/users/gerlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerlou/subscriptions","organizations_url":"https://api.github.com/users/gerlou/orgs","repos_url":"https://api.github.com/users/gerlou/repos","events_url":"https://api.github.com/users/gerlou/events{/privacy}","received_events_url":"https://api.github.com/users/gerlou/received_events","type":"User","site_admin":false},"repo":{"id":135616627,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTY2Mjc=","name":"presto","full_name":"gerlou/presto","owner":{"login":"gerlou","id":15757526,"node_id":"MDQ6VXNlcjE1NzU3NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/15757526?v=4","gravatar_id":"","url":"https://api.github.com/users/gerlou","html_url":"https://github.com/gerlou","followers_url":"https://api.github.com/users/gerlou/followers","following_url":"https://api.github.com/users/gerlou/following{/other_user}","gists_url":"https://api.github.com/users/gerlou/gists{/gist_id}","starred_url":"https://api.github.com/users/gerlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerlou/subscriptions","organizations_url":"https://api.github.com/users/gerlou/orgs","repos_url":"https://api.github.com/users/gerlou/repos","events_url":"https://api.github.com/users/gerlou/events{/privacy}","received_events_url":"https://api.github.com/users/gerlou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gerlou/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/gerlou/presto","forks_url":"https://api.github.com/repos/gerlou/presto/forks","keys_url":"https://api.github.com/repos/gerlou/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerlou/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerlou/presto/teams","hooks_url":"https://api.github.com/repos/gerlou/presto/hooks","issue_events_url":"https://api.github.com/repos/gerlou/presto/issues/events{/number}","events_url":"https://api.github.com/repos/gerlou/presto/events","assignees_url":"https://api.github.com/repos/gerlou/presto/assignees{/user}","branches_url":"https://api.github.com/repos/gerlou/presto/branches{/branch}","tags_url":"https://api.github.com/repos/gerlou/presto/tags","blobs_url":"https://api.github.com/repos/gerlou/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerlou/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerlou/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerlou/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerlou/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/gerlou/presto/languages","stargazers_url":"https://api.github.com/repos/gerlou/presto/stargazers","contributors_url":"https://api.github.com/repos/gerlou/presto/contributors","subscribers_url":"https://api.github.com/repos/gerlou/presto/subscribers","subscription_url":"https://api.github.com/repos/gerlou/presto/subscription","commits_url":"https://api.github.com/repos/gerlou/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerlou/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerlou/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerlou/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerlou/presto/contents/{+path}","compare_url":"https://api.github.com/repos/gerlou/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerlou/presto/merges","archive_url":"https://api.github.com/repos/gerlou/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerlou/presto/downloads","issues_url":"https://api.github.com/repos/gerlou/presto/issues{/number}","pulls_url":"https://api.github.com/repos/gerlou/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/gerlou/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/gerlou/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerlou/presto/labels{/name}","releases_url":"https://api.github.com/repos/gerlou/presto/releases{/id}","deployments_url":"https://api.github.com/repos/gerlou/presto/deployments","created_at":"2018-05-31T17:42:15Z","updated_at":"2018-06-04T06:21:38Z","pushed_at":"2018-06-27T04:43:57Z","git_url":"git://github.com/gerlou/presto.git","ssh_url":"git@github.com:gerlou/presto.git","clone_url":"https://github.com/gerlou/presto.git","svn_url":"https://github.com/gerlou/presto","homepage":"https://prestodb.io","size":92659,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"3060c65a1812c6c8b0c2ab725b0184dbad67f0ed","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-06-27T19:30:40Z","pushed_at":"2018-06-27T20:42:11Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":93197,"stargazers_count":7707,"watchers_count":7707,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2597,"mirror_url":null,"archived":false,"open_issues_count":1316,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2597,"open_issues":1316,"watchers":7707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10861"},"html":{"href":"https://github.com/prestodb/presto/pull/10861"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/10861"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/10861/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10861/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10861/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/504a57f83dc06aaf0255b8c89364243987097df6"}},"author_association":"NONE"}}
{"actor":{"display_login":"haozhun"}}