{"action":"created","comment":{"url":"https://api.github.com/repos/floydhub/floyd-cli/pulls/comments/221338139","pull_request_review_id":159968669,"id":221338139,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTMzODEzOQ==","diff_hunk":"@@ -182,12 +182,33 @@ def get_log_id(job_id):\n     return instance_log_id\n \n \n+def check_job_termination_line(log_output_line):\n+    \"\"\"\n+    Get Job termination by inspecting if any of the termination log lines is detected\n+    in the current log output line.\n+    \"\"\"\n+    job_terminated = False\n+    success = \"[success] Finished execution\"\n+    failure = \"[failed] Task execution failed\"\n+    shutdown = \"[shutdown] Task execution cancelled\"\n+    timeout = \"[timeout] Task execution cancelled\"\n+    termination_list = [success, failure, shutdown, timeout]","path":"floyd/cli/experiment.py","position":14,"original_position":14,"commit_id":"15825337ff8ccf5155ad3e44ff77772dd8d29178","original_commit_id":"15825337ff8ccf5155ad3e44ff77772dd8d29178","user":{"login":"houqp","id":670302,"node_id":"MDQ6VXNlcjY3MDMwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/670302?v=4","gravatar_id":"","url":"https://api.github.com/users/houqp","html_url":"https://github.com/houqp","followers_url":"https://api.github.com/users/houqp/followers","following_url":"https://api.github.com/users/houqp/following{/other_user}","gists_url":"https://api.github.com/users/houqp/gists{/gist_id}","starred_url":"https://api.github.com/users/houqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houqp/subscriptions","organizations_url":"https://api.github.com/users/houqp/orgs","repos_url":"https://api.github.com/users/houqp/repos","events_url":"https://api.github.com/users/houqp/events{/privacy}","received_events_url":"https://api.github.com/users/houqp/received_events","type":"User","site_admin":false},"body":"better move this list creation outside so we are not creating a new list on every function call.","created_at":"2018-09-28T18:12:01Z","updated_at":"2018-09-28T18:12:43Z","html_url":"https://github.com/floydhub/floyd-cli/pull/207#discussion_r221338139","pull_request_url":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/floydhub/floyd-cli/pulls/comments/221338139"},"html":{"href":"https://github.com/floydhub/floyd-cli/pull/207#discussion_r221338139"},"pull_request":{"href":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207","id":219044479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDQ0NDc5","html_url":"https://github.com/floydhub/floyd-cli/pull/207","diff_url":"https://github.com/floydhub/floyd-cli/pull/207.diff","patch_url":"https://github.com/floydhub/floyd-cli/pull/207.patch","issue_url":"https://api.github.com/repos/floydhub/floyd-cli/issues/207","number":207,"state":"open","locked":false,"title":"Exit on follow by inspecting the current log line","user":{"login":"ReDeiPirati","id":5721767,"node_id":"MDQ6VXNlcjU3MjE3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5721767?v=4","gravatar_id":"","url":"https://api.github.com/users/ReDeiPirati","html_url":"https://github.com/ReDeiPirati","followers_url":"https://api.github.com/users/ReDeiPirati/followers","following_url":"https://api.github.com/users/ReDeiPirati/following{/other_user}","gists_url":"https://api.github.com/users/ReDeiPirati/gists{/gist_id}","starred_url":"https://api.github.com/users/ReDeiPirati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReDeiPirati/subscriptions","organizations_url":"https://api.github.com/users/ReDeiPirati/orgs","repos_url":"https://api.github.com/users/ReDeiPirati/repos","events_url":"https://api.github.com/users/ReDeiPirati/events{/privacy}","received_events_url":"https://api.github.com/users/ReDeiPirati/received_events","type":"User","site_admin":false},"body":"Ticket: [When using --follow from CLI, command doesn't exit when job is done](https://app.asana.com/0/817307208669065/811109963478542)","created_at":"2018-09-28T18:04:52Z","updated_at":"2018-09-28T18:12:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4f48b75d39137606e6fea9018e5b8f1dde05342","assignee":null,"assignees":[],"requested_reviewers":[{"login":"narenst","id":460436,"node_id":"MDQ6VXNlcjQ2MDQzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/460436?v=4","gravatar_id":"","url":"https://api.github.com/users/narenst","html_url":"https://github.com/narenst","followers_url":"https://api.github.com/users/narenst/followers","following_url":"https://api.github.com/users/narenst/following{/other_user}","gists_url":"https://api.github.com/users/narenst/gists{/gist_id}","starred_url":"https://api.github.com/users/narenst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narenst/subscriptions","organizations_url":"https://api.github.com/users/narenst/orgs","repos_url":"https://api.github.com/users/narenst/repos","events_url":"https://api.github.com/users/narenst/events{/privacy}","received_events_url":"https://api.github.com/users/narenst/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207/commits","review_comments_url":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207/comments","review_comment_url":"https://api.github.com/repos/floydhub/floyd-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/floydhub/floyd-cli/issues/207/comments","statuses_url":"https://api.github.com/repos/floydhub/floyd-cli/statuses/15825337ff8ccf5155ad3e44ff77772dd8d29178","head":{"label":"floydhub:exit-on-follow","ref":"exit-on-follow","sha":"15825337ff8ccf5155ad3e44ff77772dd8d29178","user":{"login":"floydhub","id":21301057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzAxMDU3","avatar_url":"https://avatars1.githubusercontent.com/u/21301057?v=4","gravatar_id":"","url":"https://api.github.com/users/floydhub","html_url":"https://github.com/floydhub","followers_url":"https://api.github.com/users/floydhub/followers","following_url":"https://api.github.com/users/floydhub/following{/other_user}","gists_url":"https://api.github.com/users/floydhub/gists{/gist_id}","starred_url":"https://api.github.com/users/floydhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floydhub/subscriptions","organizations_url":"https://api.github.com/users/floydhub/orgs","repos_url":"https://api.github.com/users/floydhub/repos","events_url":"https://api.github.com/users/floydhub/events{/privacy}","received_events_url":"https://api.github.com/users/floydhub/received_events","type":"Organization","site_admin":false},"repo":{"id":79263287,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2MzI4Nw==","name":"floyd-cli","full_name":"floydhub/floyd-cli","private":false,"owner":{"login":"floydhub","id":21301057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzAxMDU3","avatar_url":"https://avatars1.githubusercontent.com/u/21301057?v=4","gravatar_id":"","url":"https://api.github.com/users/floydhub","html_url":"https://github.com/floydhub","followers_url":"https://api.github.com/users/floydhub/followers","following_url":"https://api.github.com/users/floydhub/following{/other_user}","gists_url":"https://api.github.com/users/floydhub/gists{/gist_id}","starred_url":"https://api.github.com/users/floydhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floydhub/subscriptions","organizations_url":"https://api.github.com/users/floydhub/orgs","repos_url":"https://api.github.com/users/floydhub/repos","events_url":"https://api.github.com/users/floydhub/events{/privacy}","received_events_url":"https://api.github.com/users/floydhub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/floydhub/floyd-cli","description":"Command line tool for FloydHub - the fastest way to build, train, and deploy deep learning models","fork":false,"url":"https://api.github.com/repos/floydhub/floyd-cli","forks_url":"https://api.github.com/repos/floydhub/floyd-cli/forks","keys_url":"https://api.github.com/repos/floydhub/floyd-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floydhub/floyd-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floydhub/floyd-cli/teams","hooks_url":"https://api.github.com/repos/floydhub/floyd-cli/hooks","issue_events_url":"https://api.github.com/repos/floydhub/floyd-cli/issues/events{/number}","events_url":"https://api.github.com/repos/floydhub/floyd-cli/events","assignees_url":"https://api.github.com/repos/floydhub/floyd-cli/assignees{/user}","branches_url":"https://api.github.com/repos/floydhub/floyd-cli/branches{/branch}","tags_url":"https://api.github.com/repos/floydhub/floyd-cli/tags","blobs_url":"https://api.github.com/repos/floydhub/floyd-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floydhub/floyd-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floydhub/floyd-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/floydhub/floyd-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floydhub/floyd-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/floydhub/floyd-cli/languages","stargazers_url":"https://api.github.com/repos/floydhub/floyd-cli/stargazers","contributors_url":"https://api.github.com/repos/floydhub/floyd-cli/contributors","subscribers_url":"https://api.github.com/repos/floydhub/floyd-cli/subscribers","subscription_url":"https://api.github.com/repos/floydhub/floyd-cli/subscription","commits_url":"https://api.github.com/repos/floydhub/floyd-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/floydhub/floyd-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/floydhub/floyd-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/floydhub/floyd-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/floydhub/floyd-cli/contents/{+path}","compare_url":"https://api.github.com/repos/floydhub/floyd-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floydhub/floyd-cli/merges","archive_url":"https://api.github.com/repos/floydhub/floyd-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floydhub/floyd-cli/downloads","issues_url":"https://api.github.com/repos/floydhub/floyd-cli/issues{/number}","pulls_url":"https://api.github.com/repos/floydhub/floyd-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/floydhub/floyd-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/floydhub/floyd-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floydhub/floyd-cli/labels{/name}","releases_url":"https://api.github.com/repos/floydhub/floyd-cli/releases{/id}","deployments_url":"https://api.github.com/repos/floydhub/floyd-cli/deployments","created_at":"2017-01-17T19:26:02Z","updated_at":"2018-09-28T17:59:07Z","pushed_at":"2018-09-28T18:04:52Z","git_url":"git://github.com/floydhub/floyd-cli.git","ssh_url":"git@github.com:floydhub/floyd-cli.git","clone_url":"https://github.com/floydhub/floyd-cli.git","svn_url":"https://github.com/floydhub/floyd-cli","homepage":"https://floydhub.com","size":494,"stargazers_count":101,"watchers_count":101,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":11,"watchers":101,"default_branch":"master"}},"base":{"label":"floydhub:master","ref":"master","sha":"9519411a414ca2a9886e5b33430b2253664048c1","user":{"login":"floydhub","id":21301057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzAxMDU3","avatar_url":"https://avatars1.githubusercontent.com/u/21301057?v=4","gravatar_id":"","url":"https://api.github.com/users/floydhub","html_url":"https://github.com/floydhub","followers_url":"https://api.github.com/users/floydhub/followers","following_url":"https://api.github.com/users/floydhub/following{/other_user}","gists_url":"https://api.github.com/users/floydhub/gists{/gist_id}","starred_url":"https://api.github.com/users/floydhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floydhub/subscriptions","organizations_url":"https://api.github.com/users/floydhub/orgs","repos_url":"https://api.github.com/users/floydhub/repos","events_url":"https://api.github.com/users/floydhub/events{/privacy}","received_events_url":"https://api.github.com/users/floydhub/received_events","type":"Organization","site_admin":false},"repo":{"id":79263287,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2MzI4Nw==","name":"floyd-cli","full_name":"floydhub/floyd-cli","private":false,"owner":{"login":"floydhub","id":21301057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzAxMDU3","avatar_url":"https://avatars1.githubusercontent.com/u/21301057?v=4","gravatar_id":"","url":"https://api.github.com/users/floydhub","html_url":"https://github.com/floydhub","followers_url":"https://api.github.com/users/floydhub/followers","following_url":"https://api.github.com/users/floydhub/following{/other_user}","gists_url":"https://api.github.com/users/floydhub/gists{/gist_id}","starred_url":"https://api.github.com/users/floydhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floydhub/subscriptions","organizations_url":"https://api.github.com/users/floydhub/orgs","repos_url":"https://api.github.com/users/floydhub/repos","events_url":"https://api.github.com/users/floydhub/events{/privacy}","received_events_url":"https://api.github.com/users/floydhub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/floydhub/floyd-cli","description":"Command line tool for FloydHub - the fastest way to build, train, and deploy deep learning models","fork":false,"url":"https://api.github.com/repos/floydhub/floyd-cli","forks_url":"https://api.github.com/repos/floydhub/floyd-cli/forks","keys_url":"https://api.github.com/repos/floydhub/floyd-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floydhub/floyd-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floydhub/floyd-cli/teams","hooks_url":"https://api.github.com/repos/floydhub/floyd-cli/hooks","issue_events_url":"https://api.github.com/repos/floydhub/floyd-cli/issues/events{/number}","events_url":"https://api.github.com/repos/floydhub/floyd-cli/events","assignees_url":"https://api.github.com/repos/floydhub/floyd-cli/assignees{/user}","branches_url":"https://api.github.com/repos/floydhub/floyd-cli/branches{/branch}","tags_url":"https://api.github.com/repos/floydhub/floyd-cli/tags","blobs_url":"https://api.github.com/repos/floydhub/floyd-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floydhub/floyd-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floydhub/floyd-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/floydhub/floyd-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floydhub/floyd-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/floydhub/floyd-cli/languages","stargazers_url":"https://api.github.com/repos/floydhub/floyd-cli/stargazers","contributors_url":"https://api.github.com/repos/floydhub/floyd-cli/contributors","subscribers_url":"https://api.github.com/repos/floydhub/floyd-cli/subscribers","subscription_url":"https://api.github.com/repos/floydhub/floyd-cli/subscription","commits_url":"https://api.github.com/repos/floydhub/floyd-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/floydhub/floyd-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/floydhub/floyd-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/floydhub/floyd-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/floydhub/floyd-cli/contents/{+path}","compare_url":"https://api.github.com/repos/floydhub/floyd-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floydhub/floyd-cli/merges","archive_url":"https://api.github.com/repos/floydhub/floyd-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floydhub/floyd-cli/downloads","issues_url":"https://api.github.com/repos/floydhub/floyd-cli/issues{/number}","pulls_url":"https://api.github.com/repos/floydhub/floyd-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/floydhub/floyd-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/floydhub/floyd-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floydhub/floyd-cli/labels{/name}","releases_url":"https://api.github.com/repos/floydhub/floyd-cli/releases{/id}","deployments_url":"https://api.github.com/repos/floydhub/floyd-cli/deployments","created_at":"2017-01-17T19:26:02Z","updated_at":"2018-09-28T17:59:07Z","pushed_at":"2018-09-28T18:04:52Z","git_url":"git://github.com/floydhub/floyd-cli.git","ssh_url":"git@github.com:floydhub/floyd-cli.git","clone_url":"https://github.com/floydhub/floyd-cli.git","svn_url":"https://github.com/floydhub/floyd-cli","homepage":"https://floydhub.com","size":494,"stargazers_count":101,"watchers_count":101,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":11,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207"},"html":{"href":"https://github.com/floydhub/floyd-cli/pull/207"},"issue":{"href":"https://api.github.com/repos/floydhub/floyd-cli/issues/207"},"comments":{"href":"https://api.github.com/repos/floydhub/floyd-cli/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/floydhub/floyd-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/floydhub/floyd-cli/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/floydhub/floyd-cli/statuses/15825337ff8ccf5155ad3e44ff77772dd8d29178"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houqp"}}