{"action":"created","comment":{"url":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/comments/233345974","pull_request_review_id":174735783,"id":233345974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzM0NTk3NA==","diff_hunk":"@@ -16,9 +30,12 @@\n     </PropertyGroup>\n     <!-- Items include -->\n     <ItemGroup>\n+        <PackageReference Include=\"Microsoft.SourceLink.GitHub\" Version=\"1.0.0-beta-63127-02\" PrivateAssets=\"All\"/>\n         <Reference Include=\"System.Windows.Interactivity\">\n             <HintPath>..\\ExtLibs\\NET45\\System.Windows.Interactivity.dll</HintPath>\n         </Reference>\n     </ItemGroup>\n-    <Import Project=\"..\\..\\.paket\\Paket.Restore.targets\"/>\n+    <ItemGroup Condition=\"'$(TargetFramework)' == 'netcoreapp3.0'\">","path":"src/ControlzEx/ControlzEx.csproj","position":38,"original_position":38,"commit_id":"97234a78914da0a344da17d49bb9dcab5a70f1d1","original_commit_id":"97234a78914da0a344da17d49bb9dcab5a70f1d1","user":{"login":"batzen","id":1971030,"node_id":"MDQ6VXNlcjE5NzEwMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1971030?v=4","gravatar_id":"","url":"https://api.github.com/users/batzen","html_url":"https://github.com/batzen","followers_url":"https://api.github.com/users/batzen/followers","following_url":"https://api.github.com/users/batzen/following{/other_user}","gists_url":"https://api.github.com/users/batzen/gists{/gist_id}","starred_url":"https://api.github.com/users/batzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batzen/subscriptions","organizations_url":"https://api.github.com/users/batzen/orgs","repos_url":"https://api.github.com/users/batzen/repos","events_url":"https://api.github.com/users/batzen/events{/privacy}","received_events_url":"https://api.github.com/users/batzen/received_events","type":"User","site_admin":false},"body":"Shouldn't this block be in Direcoty.build.props?\r\nThe full framework references are placed there also. ;-)","created_at":"2018-11-14T08:11:07Z","updated_at":"2018-11-14T08:11:08Z","html_url":"https://github.com/ControlzEx/ControlzEx/pull/66#discussion_r233345974","pull_request_url":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/comments/233345974"},"html":{"href":"https://github.com/ControlzEx/ControlzEx/pull/66#discussion_r233345974"},"pull_request":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66","id":230409816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDA5ODE2","html_url":"https://github.com/ControlzEx/ControlzEx/pull/66","diff_url":"https://github.com/ControlzEx/ControlzEx/pull/66.diff","patch_url":"https://github.com/ControlzEx/ControlzEx/pull/66.patch","issue_url":"https://api.github.com/repos/ControlzEx/ControlzEx/issues/66","number":66,"state":"open","locked":false,"title":"Added dotnet core 3.0 support","user":{"login":"Lakritzator","id":708125,"node_id":"MDQ6VXNlcjcwODEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/708125?v=4","gravatar_id":"","url":"https://api.github.com/users/Lakritzator","html_url":"https://github.com/Lakritzator","followers_url":"https://api.github.com/users/Lakritzator/followers","following_url":"https://api.github.com/users/Lakritzator/following{/other_user}","gists_url":"https://api.github.com/users/Lakritzator/gists{/gist_id}","starred_url":"https://api.github.com/users/Lakritzator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lakritzator/subscriptions","organizations_url":"https://api.github.com/users/Lakritzator/orgs","repos_url":"https://api.github.com/users/Lakritzator/repos","events_url":"https://api.github.com/users/Lakritzator/events{/privacy}","received_events_url":"https://api.github.com/users/Lakritzator/received_events","type":"User","site_admin":false},"body":"For this I had to:\r\n* disable paket (doesn't support netcoreapp3.0) and use package references\r\n* add the target netcoreapp3.0 and use FrameworkReference Microsoft.DesktopUI for this\r\n* change the SDK from MSBuild.Sdk.Extras to Microsoft.NET.Sdk.Wpf, I also had to add *.xaml mapping (Directory.build.props) -> check what side effects this has, as I didn't use MSBuild.Sdk.Extras before.\r\n* remove the sdk from global.json (so it takes the latest)\r\n* Added installing the SDK to appveyor.yml\r\n\r\nI was able to run all targets (net45, net462 and netcoreapp3.0) and couldn't see any visible changes.\r\nThe question is, do you need paket or wouldn't you rather change to the build in package reference?\r\nAnyway, this is up to you!","created_at":"2018-11-13T09:51:46Z","updated_at":"2018-11-14T08:11:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c622c145d9388027215506d2aaab1aba64e1d864","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66/commits","review_comments_url":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66/comments","review_comment_url":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ControlzEx/ControlzEx/issues/66/comments","statuses_url":"https://api.github.com/repos/ControlzEx/ControlzEx/statuses/97234a78914da0a344da17d49bb9dcab5a70f1d1","head":{"label":"Lakritzator:feature/dotnetcore30","ref":"feature/dotnetcore30","sha":"97234a78914da0a344da17d49bb9dcab5a70f1d1","user":{"login":"Lakritzator","id":708125,"node_id":"MDQ6VXNlcjcwODEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/708125?v=4","gravatar_id":"","url":"https://api.github.com/users/Lakritzator","html_url":"https://github.com/Lakritzator","followers_url":"https://api.github.com/users/Lakritzator/followers","following_url":"https://api.github.com/users/Lakritzator/following{/other_user}","gists_url":"https://api.github.com/users/Lakritzator/gists{/gist_id}","starred_url":"https://api.github.com/users/Lakritzator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lakritzator/subscriptions","organizations_url":"https://api.github.com/users/Lakritzator/orgs","repos_url":"https://api.github.com/users/Lakritzator/repos","events_url":"https://api.github.com/users/Lakritzator/events{/privacy}","received_events_url":"https://api.github.com/users/Lakritzator/received_events","type":"User","site_admin":false},"repo":{"id":157352909,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczNTI5MDk=","name":"ControlzEx","full_name":"Lakritzator/ControlzEx","private":false,"owner":{"login":"Lakritzator","id":708125,"node_id":"MDQ6VXNlcjcwODEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/708125?v=4","gravatar_id":"","url":"https://api.github.com/users/Lakritzator","html_url":"https://github.com/Lakritzator","followers_url":"https://api.github.com/users/Lakritzator/followers","following_url":"https://api.github.com/users/Lakritzator/following{/other_user}","gists_url":"https://api.github.com/users/Lakritzator/gists{/gist_id}","starred_url":"https://api.github.com/users/Lakritzator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lakritzator/subscriptions","organizations_url":"https://api.github.com/users/Lakritzator/orgs","repos_url":"https://api.github.com/users/Lakritzator/repos","events_url":"https://api.github.com/users/Lakritzator/events{/privacy}","received_events_url":"https://api.github.com/users/Lakritzator/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Lakritzator/ControlzEx","description":"Shared Controlz for WPF and ... more","fork":true,"url":"https://api.github.com/repos/Lakritzator/ControlzEx","forks_url":"https://api.github.com/repos/Lakritzator/ControlzEx/forks","keys_url":"https://api.github.com/repos/Lakritzator/ControlzEx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lakritzator/ControlzEx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lakritzator/ControlzEx/teams","hooks_url":"https://api.github.com/repos/Lakritzator/ControlzEx/hooks","issue_events_url":"https://api.github.com/repos/Lakritzator/ControlzEx/issues/events{/number}","events_url":"https://api.github.com/repos/Lakritzator/ControlzEx/events","assignees_url":"https://api.github.com/repos/Lakritzator/ControlzEx/assignees{/user}","branches_url":"https://api.github.com/repos/Lakritzator/ControlzEx/branches{/branch}","tags_url":"https://api.github.com/repos/Lakritzator/ControlzEx/tags","blobs_url":"https://api.github.com/repos/Lakritzator/ControlzEx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lakritzator/ControlzEx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lakritzator/ControlzEx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lakritzator/ControlzEx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lakritzator/ControlzEx/statuses/{sha}","languages_url":"https://api.github.com/repos/Lakritzator/ControlzEx/languages","stargazers_url":"https://api.github.com/repos/Lakritzator/ControlzEx/stargazers","contributors_url":"https://api.github.com/repos/Lakritzator/ControlzEx/contributors","subscribers_url":"https://api.github.com/repos/Lakritzator/ControlzEx/subscribers","subscription_url":"https://api.github.com/repos/Lakritzator/ControlzEx/subscription","commits_url":"https://api.github.com/repos/Lakritzator/ControlzEx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lakritzator/ControlzEx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lakritzator/ControlzEx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lakritzator/ControlzEx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lakritzator/ControlzEx/contents/{+path}","compare_url":"https://api.github.com/repos/Lakritzator/ControlzEx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lakritzator/ControlzEx/merges","archive_url":"https://api.github.com/repos/Lakritzator/ControlzEx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lakritzator/ControlzEx/downloads","issues_url":"https://api.github.com/repos/Lakritzator/ControlzEx/issues{/number}","pulls_url":"https://api.github.com/repos/Lakritzator/ControlzEx/pulls{/number}","milestones_url":"https://api.github.com/repos/Lakritzator/ControlzEx/milestones{/number}","notifications_url":"https://api.github.com/repos/Lakritzator/ControlzEx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lakritzator/ControlzEx/labels{/name}","releases_url":"https://api.github.com/repos/Lakritzator/ControlzEx/releases{/id}","deployments_url":"https://api.github.com/repos/Lakritzator/ControlzEx/deployments","created_at":"2018-11-13T09:19:21Z","updated_at":"2018-11-13T09:19:24Z","pushed_at":"2018-11-13T13:55:55Z","git_url":"git://github.com/Lakritzator/ControlzEx.git","ssh_url":"git@github.com:Lakritzator/ControlzEx.git","clone_url":"https://github.com/Lakritzator/ControlzEx.git","svn_url":"https://github.com/Lakritzator/ControlzEx","homepage":"","size":12222,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ControlzEx:develop","ref":"develop","sha":"e1e1b38f60207cf775aa5ab9b7751042b05b4ddc","user":{"login":"ControlzEx","id":16021103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDIxMTAz","avatar_url":"https://avatars0.githubusercontent.com/u/16021103?v=4","gravatar_id":"","url":"https://api.github.com/users/ControlzEx","html_url":"https://github.com/ControlzEx","followers_url":"https://api.github.com/users/ControlzEx/followers","following_url":"https://api.github.com/users/ControlzEx/following{/other_user}","gists_url":"https://api.github.com/users/ControlzEx/gists{/gist_id}","starred_url":"https://api.github.com/users/ControlzEx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ControlzEx/subscriptions","organizations_url":"https://api.github.com/users/ControlzEx/orgs","repos_url":"https://api.github.com/users/ControlzEx/repos","events_url":"https://api.github.com/users/ControlzEx/events{/privacy}","received_events_url":"https://api.github.com/users/ControlzEx/received_events","type":"Organization","site_admin":false},"repo":{"id":44004571,"node_id":"MDEwOlJlcG9zaXRvcnk0NDAwNDU3MQ==","name":"ControlzEx","full_name":"ControlzEx/ControlzEx","private":false,"owner":{"login":"ControlzEx","id":16021103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDIxMTAz","avatar_url":"https://avatars0.githubusercontent.com/u/16021103?v=4","gravatar_id":"","url":"https://api.github.com/users/ControlzEx","html_url":"https://github.com/ControlzEx","followers_url":"https://api.github.com/users/ControlzEx/followers","following_url":"https://api.github.com/users/ControlzEx/following{/other_user}","gists_url":"https://api.github.com/users/ControlzEx/gists{/gist_id}","starred_url":"https://api.github.com/users/ControlzEx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ControlzEx/subscriptions","organizations_url":"https://api.github.com/users/ControlzEx/orgs","repos_url":"https://api.github.com/users/ControlzEx/repos","events_url":"https://api.github.com/users/ControlzEx/events{/privacy}","received_events_url":"https://api.github.com/users/ControlzEx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ControlzEx/ControlzEx","description":"Shared Controlz for WPF and ... more","fork":false,"url":"https://api.github.com/repos/ControlzEx/ControlzEx","forks_url":"https://api.github.com/repos/ControlzEx/ControlzEx/forks","keys_url":"https://api.github.com/repos/ControlzEx/ControlzEx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ControlzEx/ControlzEx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ControlzEx/ControlzEx/teams","hooks_url":"https://api.github.com/repos/ControlzEx/ControlzEx/hooks","issue_events_url":"https://api.github.com/repos/ControlzEx/ControlzEx/issues/events{/number}","events_url":"https://api.github.com/repos/ControlzEx/ControlzEx/events","assignees_url":"https://api.github.com/repos/ControlzEx/ControlzEx/assignees{/user}","branches_url":"https://api.github.com/repos/ControlzEx/ControlzEx/branches{/branch}","tags_url":"https://api.github.com/repos/ControlzEx/ControlzEx/tags","blobs_url":"https://api.github.com/repos/ControlzEx/ControlzEx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ControlzEx/ControlzEx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ControlzEx/ControlzEx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ControlzEx/ControlzEx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ControlzEx/ControlzEx/statuses/{sha}","languages_url":"https://api.github.com/repos/ControlzEx/ControlzEx/languages","stargazers_url":"https://api.github.com/repos/ControlzEx/ControlzEx/stargazers","contributors_url":"https://api.github.com/repos/ControlzEx/ControlzEx/contributors","subscribers_url":"https://api.github.com/repos/ControlzEx/ControlzEx/subscribers","subscription_url":"https://api.github.com/repos/ControlzEx/ControlzEx/subscription","commits_url":"https://api.github.com/repos/ControlzEx/ControlzEx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ControlzEx/ControlzEx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ControlzEx/ControlzEx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ControlzEx/ControlzEx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ControlzEx/ControlzEx/contents/{+path}","compare_url":"https://api.github.com/repos/ControlzEx/ControlzEx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ControlzEx/ControlzEx/merges","archive_url":"https://api.github.com/repos/ControlzEx/ControlzEx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ControlzEx/ControlzEx/downloads","issues_url":"https://api.github.com/repos/ControlzEx/ControlzEx/issues{/number}","pulls_url":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls{/number}","milestones_url":"https://api.github.com/repos/ControlzEx/ControlzEx/milestones{/number}","notifications_url":"https://api.github.com/repos/ControlzEx/ControlzEx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ControlzEx/ControlzEx/labels{/name}","releases_url":"https://api.github.com/repos/ControlzEx/ControlzEx/releases{/id}","deployments_url":"https://api.github.com/repos/ControlzEx/ControlzEx/deployments","created_at":"2015-10-10T09:38:46Z","updated_at":"2018-11-14T03:07:27Z","pushed_at":"2018-11-13T13:55:56Z","git_url":"git://github.com/ControlzEx/ControlzEx.git","ssh_url":"git@github.com:ControlzEx/ControlzEx.git","clone_url":"https://github.com/ControlzEx/ControlzEx.git","svn_url":"https://github.com/ControlzEx/ControlzEx","homepage":"","size":12200,"stargazers_count":225,"watchers_count":225,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":42,"open_issues":8,"watchers":225,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66"},"html":{"href":"https://github.com/ControlzEx/ControlzEx/pull/66"},"issue":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/issues/66"},"comments":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/ControlzEx/ControlzEx/statuses/97234a78914da0a344da17d49bb9dcab5a70f1d1"}},"author_association":"NONE"}}
{"actor":{"display_login":"batzen"}}