{"action":"closed","number":12792,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12792","id":179677553,"html_url":"https://github.com/hazelcast/hazelcast/pull/12792","diff_url":"https://github.com/hazelcast/hazelcast/pull/12792.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/12792.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/12792","number":12792,"state":"closed","locked":false,"title":"Use entire ringbuffers during split brain healing","user":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"body":"Previously single items were provided to the merge policy. The same item\r\nwas found by comparing the equality of the items in the ringbuffers.\r\nThis is not correct in all scenarios. To provide more flexibility and\r\nallow the user to write a more complex merge policy, we provide the\r\nentire ringbuffers to the user during split brain healing.\r\n\r\nPart of https://github.com/hazelcast/hazelcast/issues/12803\r\nPart of https://github.com/hazelcast/hazelcast/issues/12804","created_at":"2018-04-05T13:33:39Z","updated_at":"2018-04-12T10:55:27Z","closed_at":"2018-04-12T10:55:27Z","merged_at":"2018-04-12T10:55:27Z","merge_commit_sha":"c33b5fdca07ecb1ac204ead12ca57e6819165b6d","assignee":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740690,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Defect","name":"Type: Defect","color":"eb6420","default":false},{"id":1740692,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"5319e7","default":false},{"id":575277351,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Perf.%20Defect","name":"Type: Perf. Defect","color":"d93f0b","default":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/98","html_url":"https://github.com/hazelcast/hazelcast/milestone/98","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/98/labels","id":2624978,"number":98,"title":"3.10","description":null,"creator":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars1.githubusercontent.com/u/158619?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":822,"state":"open","created_at":"2017-07-06T10:25:45Z","updated_at":"2018-04-12T10:55:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12792/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12792/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/12792/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/a90009b317a9de8429cb22edbf16cd51782cf166","head":{"label":"mmedenjak:merge-spi-ringbuffer-implementation","ref":"merge-spi-ringbuffer-implementation","sha":"a90009b317a9de8429cb22edbf16cd51782cf166","user":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"repo":{"id":68697807,"name":"hazelcast","full_name":"mmedenjak/hazelcast","owner":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmedenjak/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/mmedenjak/hazelcast","forks_url":"https://api.github.com/repos/mmedenjak/hazelcast/forks","keys_url":"https://api.github.com/repos/mmedenjak/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmedenjak/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmedenjak/hazelcast/teams","hooks_url":"https://api.github.com/repos/mmedenjak/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/mmedenjak/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/mmedenjak/hazelcast/events","assignees_url":"https://api.github.com/repos/mmedenjak/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/mmedenjak/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/mmedenjak/hazelcast/tags","blobs_url":"https://api.github.com/repos/mmedenjak/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmedenjak/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmedenjak/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmedenjak/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmedenjak/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/mmedenjak/hazelcast/languages","stargazers_url":"https://api.github.com/repos/mmedenjak/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/mmedenjak/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/mmedenjak/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/mmedenjak/hazelcast/subscription","commits_url":"https://api.github.com/repos/mmedenjak/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmedenjak/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmedenjak/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmedenjak/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmedenjak/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/mmedenjak/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmedenjak/hazelcast/merges","archive_url":"https://api.github.com/repos/mmedenjak/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmedenjak/hazelcast/downloads","issues_url":"https://api.github.com/repos/mmedenjak/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/mmedenjak/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/mmedenjak/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/mmedenjak/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmedenjak/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/mmedenjak/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/mmedenjak/hazelcast/deployments","created_at":"2016-09-20T09:45:04Z","updated_at":"2018-04-12T06:33:30Z","pushed_at":"2018-04-12T07:48:12Z","git_url":"git://github.com/mmedenjak/hazelcast.git","ssh_url":"git@github.com:mmedenjak/hazelcast.git","clone_url":"https://github.com/mmedenjak/hazelcast.git","svn_url":"https://github.com/mmedenjak/hazelcast","homepage":"www.hazelcast.com","size":128698,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"78d63071d918b1abbbbb0706215d173245f2686c","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2018-04-12T10:02:45Z","pushed_at":"2018-04-12T10:55:26Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"http://www.hazelcast.org","size":128520,"stargazers_count":2532,"watchers_count":2532,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":998,"mirror_url":null,"archived":false,"open_issues_count":645,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":998,"open_issues":645,"watchers":2532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12792"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/12792"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/12792"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/12792/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12792/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12792/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/a90009b317a9de8429cb22edbf16cd51782cf166"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"comments":2,"review_comments":30,"maintainer_can_modify":false,"commits":5,"additions":1119,"deletions":408,"changed_files":21}}
{"actor":{"display_login":"mmedenjak"}}