{"action":"created","comment":{"url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments/220170284","pull_request_review_id":158513441,"id":220170284,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDE3MDI4NA==","diff_hunk":"@@ -20,3 +22,24 @@\n     </button>\n   </div>\n </form>\n+\n+<ng-template #visitorModal let-modal>\n+  <div class=\"modal-header\">\n+    <h4 class=\"modal-title\" id=\"modal-basic-title\" i18n>You are one step away from commenting</h4>\n+    <button type=\"button\" class=\"close\" aria-label=\"Close\" (click)=\"hideVisitorModal()\"></button>\n+  </div>\n+  <div class=\"modal-body\" i18n>\n+    <span i18n>\n+      If you have an account on this instance, you can <a (click)=\"gotoLogin()\" i18n>login to comment</a>.","path":"client/src/app/videos/+video-watch/comment/video-comment-add.component.html","position":25,"original_position":25,"commit_id":"41824bb770c5e0e8fbbc31a696c576cbf0e63ddb","original_commit_id":"2b7faa3fd437dc09637a6ad3e53269ad323ccaf7","user":{"login":"Chocobozzz","id":5180488,"node_id":"MDQ6VXNlcjUxODA0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5180488?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobozzz","html_url":"https://github.com/Chocobozzz","followers_url":"https://api.github.com/users/Chocobozzz/followers","following_url":"https://api.github.com/users/Chocobozzz/following{/other_user}","gists_url":"https://api.github.com/users/Chocobozzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobozzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobozzz/subscriptions","organizations_url":"https://api.github.com/users/Chocobozzz/orgs","repos_url":"https://api.github.com/users/Chocobozzz/repos","events_url":"https://api.github.com/users/Chocobozzz/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobozzz/received_events","type":"User","site_admin":false},"body":"If yo don't use a real link, prefer using a `<span role=\"button\">`.","created_at":"2018-09-25T12:26:25Z","updated_at":"2018-09-25T12:47:03Z","html_url":"https://github.com/Chocobozzz/PeerTube/pull/1100#discussion_r220170284","pull_request_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments/220170284"},"html":{"href":"https://github.com/Chocobozzz/PeerTube/pull/1100#discussion_r220170284"},"pull_request":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100"}}},"pull_request":{"url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100","id":217426941,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDI2OTQx","html_url":"https://github.com/Chocobozzz/PeerTube/pull/1100","diff_url":"https://github.com/Chocobozzz/PeerTube/pull/1100.diff","patch_url":"https://github.com/Chocobozzz/PeerTube/pull/1100.patch","issue_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1100","number":1100,"state":"open","locked":false,"title":"refactor subscribe button and comment-add for visitor-interact UX","user":{"login":"rigelk","id":6329880,"node_id":"MDQ6VXNlcjYzMjk4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/6329880?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelk","html_url":"https://github.com/rigelk","followers_url":"https://api.github.com/users/rigelk/followers","following_url":"https://api.github.com/users/rigelk/following{/other_user}","gists_url":"https://api.github.com/users/rigelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelk/subscriptions","organizations_url":"https://api.github.com/users/rigelk/orgs","repos_url":"https://api.github.com/users/rigelk/repos","events_url":"https://api.github.com/users/rigelk/events{/privacy}","received_events_url":"https://api.github.com/users/rigelk/received_events","type":"User","site_admin":false},"body":"@Chocobozzz I didn't know how to properly inject the RSS URI in the button, so I left that aside.\r\n\r\n![screenshot_2018-09-22 nay](https://user-images.githubusercontent.com/6329880/45910907-7618f700-be0d-11e8-8049-7e2c825f599c.png)\r\n\r\nThe advantage of this button is that it even shows for visitors. It gives them a tour of the available possibilities to subscribe, while also being interactive via a form for remote follow.\r\n\r\nThe appearance differs slightly if you are logged-in: the button is then a two-action button, whose left part subscribes directly with your local account (as the original button). The right part open the dropdown-menu.\r\n\r\nThe button is now put on the right side, much like with YT.","created_at":"2018-09-22T00:05:30Z","updated_at":"2018-09-25T12:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2052103ddc0da095ef3bfecb1dfdb6c6db986f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1100/comments","statuses_url":"https://api.github.com/repos/Chocobozzz/PeerTube/statuses/41824bb770c5e0e8fbbc31a696c576cbf0e63ddb","head":{"label":"rigelk:subscribe-button","ref":"subscribe-button","sha":"41824bb770c5e0e8fbbc31a696c576cbf0e63ddb","user":{"login":"rigelk","id":6329880,"node_id":"MDQ6VXNlcjYzMjk4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/6329880?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelk","html_url":"https://github.com/rigelk","followers_url":"https://api.github.com/users/rigelk/followers","following_url":"https://api.github.com/users/rigelk/following{/other_user}","gists_url":"https://api.github.com/users/rigelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelk/subscriptions","organizations_url":"https://api.github.com/users/rigelk/orgs","repos_url":"https://api.github.com/users/rigelk/repos","events_url":"https://api.github.com/users/rigelk/events{/privacy}","received_events_url":"https://api.github.com/users/rigelk/received_events","type":"User","site_admin":false},"repo":{"id":114056832,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQwNTY4MzI=","name":"PeerTube","full_name":"rigelk/PeerTube","private":false,"owner":{"login":"rigelk","id":6329880,"node_id":"MDQ6VXNlcjYzMjk4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/6329880?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelk","html_url":"https://github.com/rigelk","followers_url":"https://api.github.com/users/rigelk/followers","following_url":"https://api.github.com/users/rigelk/following{/other_user}","gists_url":"https://api.github.com/users/rigelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelk/subscriptions","organizations_url":"https://api.github.com/users/rigelk/orgs","repos_url":"https://api.github.com/users/rigelk/repos","events_url":"https://api.github.com/users/rigelk/events{/privacy}","received_events_url":"https://api.github.com/users/rigelk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rigelk/PeerTube","description":"[personal draft space to contribute to PeerTube]","fork":true,"url":"https://api.github.com/repos/rigelk/PeerTube","forks_url":"https://api.github.com/repos/rigelk/PeerTube/forks","keys_url":"https://api.github.com/repos/rigelk/PeerTube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigelk/PeerTube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigelk/PeerTube/teams","hooks_url":"https://api.github.com/repos/rigelk/PeerTube/hooks","issue_events_url":"https://api.github.com/repos/rigelk/PeerTube/issues/events{/number}","events_url":"https://api.github.com/repos/rigelk/PeerTube/events","assignees_url":"https://api.github.com/repos/rigelk/PeerTube/assignees{/user}","branches_url":"https://api.github.com/repos/rigelk/PeerTube/branches{/branch}","tags_url":"https://api.github.com/repos/rigelk/PeerTube/tags","blobs_url":"https://api.github.com/repos/rigelk/PeerTube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigelk/PeerTube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigelk/PeerTube/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigelk/PeerTube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigelk/PeerTube/statuses/{sha}","languages_url":"https://api.github.com/repos/rigelk/PeerTube/languages","stargazers_url":"https://api.github.com/repos/rigelk/PeerTube/stargazers","contributors_url":"https://api.github.com/repos/rigelk/PeerTube/contributors","subscribers_url":"https://api.github.com/repos/rigelk/PeerTube/subscribers","subscription_url":"https://api.github.com/repos/rigelk/PeerTube/subscription","commits_url":"https://api.github.com/repos/rigelk/PeerTube/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigelk/PeerTube/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigelk/PeerTube/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigelk/PeerTube/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigelk/PeerTube/contents/{+path}","compare_url":"https://api.github.com/repos/rigelk/PeerTube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigelk/PeerTube/merges","archive_url":"https://api.github.com/repos/rigelk/PeerTube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigelk/PeerTube/downloads","issues_url":"https://api.github.com/repos/rigelk/PeerTube/issues{/number}","pulls_url":"https://api.github.com/repos/rigelk/PeerTube/pulls{/number}","milestones_url":"https://api.github.com/repos/rigelk/PeerTube/milestones{/number}","notifications_url":"https://api.github.com/repos/rigelk/PeerTube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigelk/PeerTube/labels{/name}","releases_url":"https://api.github.com/repos/rigelk/PeerTube/releases{/id}","deployments_url":"https://api.github.com/repos/rigelk/PeerTube/deployments","created_at":"2017-12-13T01:12:14Z","updated_at":"2018-09-17T18:38:22Z","pushed_at":"2018-09-25T12:45:13Z","git_url":"git://github.com/rigelk/PeerTube.git","ssh_url":"git@github.com:rigelk/PeerTube.git","clone_url":"https://github.com/rigelk/PeerTube.git","svn_url":"https://github.com/rigelk/PeerTube","homepage":"","size":14804,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Chocobozzz:develop","ref":"develop","sha":"96cdbcfa072c79cd3e94fa6b012494135c2497d9","user":{"login":"Chocobozzz","id":5180488,"node_id":"MDQ6VXNlcjUxODA0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5180488?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobozzz","html_url":"https://github.com/Chocobozzz","followers_url":"https://api.github.com/users/Chocobozzz/followers","following_url":"https://api.github.com/users/Chocobozzz/following{/other_user}","gists_url":"https://api.github.com/users/Chocobozzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobozzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobozzz/subscriptions","organizations_url":"https://api.github.com/users/Chocobozzz/orgs","repos_url":"https://api.github.com/users/Chocobozzz/repos","events_url":"https://api.github.com/users/Chocobozzz/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobozzz/received_events","type":"User","site_admin":false},"repo":{"id":45213667,"node_id":"MDEwOlJlcG9zaXRvcnk0NTIxMzY2Nw==","name":"PeerTube","full_name":"Chocobozzz/PeerTube","private":false,"owner":{"login":"Chocobozzz","id":5180488,"node_id":"MDQ6VXNlcjUxODA0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5180488?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobozzz","html_url":"https://github.com/Chocobozzz","followers_url":"https://api.github.com/users/Chocobozzz/followers","following_url":"https://api.github.com/users/Chocobozzz/following{/other_user}","gists_url":"https://api.github.com/users/Chocobozzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobozzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobozzz/subscriptions","organizations_url":"https://api.github.com/users/Chocobozzz/orgs","repos_url":"https://api.github.com/users/Chocobozzz/repos","events_url":"https://api.github.com/users/Chocobozzz/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobozzz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Chocobozzz/PeerTube","description":"Federated (ActivityPub) video streaming platform using P2P (BitTorrent) directly in the web browser with WebTorrent and Angular.","fork":false,"url":"https://api.github.com/repos/Chocobozzz/PeerTube","forks_url":"https://api.github.com/repos/Chocobozzz/PeerTube/forks","keys_url":"https://api.github.com/repos/Chocobozzz/PeerTube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chocobozzz/PeerTube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chocobozzz/PeerTube/teams","hooks_url":"https://api.github.com/repos/Chocobozzz/PeerTube/hooks","issue_events_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/events{/number}","events_url":"https://api.github.com/repos/Chocobozzz/PeerTube/events","assignees_url":"https://api.github.com/repos/Chocobozzz/PeerTube/assignees{/user}","branches_url":"https://api.github.com/repos/Chocobozzz/PeerTube/branches{/branch}","tags_url":"https://api.github.com/repos/Chocobozzz/PeerTube/tags","blobs_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chocobozzz/PeerTube/statuses/{sha}","languages_url":"https://api.github.com/repos/Chocobozzz/PeerTube/languages","stargazers_url":"https://api.github.com/repos/Chocobozzz/PeerTube/stargazers","contributors_url":"https://api.github.com/repos/Chocobozzz/PeerTube/contributors","subscribers_url":"https://api.github.com/repos/Chocobozzz/PeerTube/subscribers","subscription_url":"https://api.github.com/repos/Chocobozzz/PeerTube/subscription","commits_url":"https://api.github.com/repos/Chocobozzz/PeerTube/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chocobozzz/PeerTube/contents/{+path}","compare_url":"https://api.github.com/repos/Chocobozzz/PeerTube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chocobozzz/PeerTube/merges","archive_url":"https://api.github.com/repos/Chocobozzz/PeerTube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chocobozzz/PeerTube/downloads","issues_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues{/number}","pulls_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls{/number}","milestones_url":"https://api.github.com/repos/Chocobozzz/PeerTube/milestones{/number}","notifications_url":"https://api.github.com/repos/Chocobozzz/PeerTube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chocobozzz/PeerTube/labels{/name}","releases_url":"https://api.github.com/repos/Chocobozzz/PeerTube/releases{/id}","deployments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/deployments","created_at":"2015-10-29T22:09:42Z","updated_at":"2018-09-25T12:46:06Z","pushed_at":"2018-09-25T12:46:03Z","git_url":"git://github.com/Chocobozzz/PeerTube.git","ssh_url":"git@github.com:Chocobozzz/PeerTube.git","clone_url":"https://github.com/Chocobozzz/PeerTube.git","svn_url":"https://github.com/Chocobozzz/PeerTube","homepage":"","size":14860,"stargazers_count":4022,"watchers_count":4022,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"archived":false,"open_issues_count":187,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":348,"open_issues":187,"watchers":4022,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100"},"html":{"href":"https://github.com/Chocobozzz/PeerTube/pull/1100"},"issue":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1100"},"comments":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/statuses/41824bb770c5e0e8fbbc31a696c576cbf0e63ddb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Chocobozzz"}}