{"action":"created","comment":{"url":"https://api.github.com/repos/vertexproject/synapse/pulls/comments/226763631","pull_request_review_id":166672723,"id":226763631,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjc2MzYzMQ==","diff_hunk":"@@ -102,8 +97,13 @@ def coroToSync(self, coro, timeout=None):\n         '''\n         Schedule a coro to run on this loop and return the result.\n \n-        NOTE: This API *is* thread safe\n+        NOTE: This API *is* thread safe.\n+\n+        NOTE: This function must *not* be run from inside the event loop\n         '''\n+        if self.iAmLoop():\n+            raise Exception('Already in async thread')","path":"synapse/lib/plex.py","position":88,"original_position":88,"commit_id":"0739f9e9dbd39a4d0a86671f5f0182cf923c75e3","original_commit_id":"0739f9e9dbd39a4d0a86671f5f0182cf923c75e3","user":{"login":"vEpiphyte","id":26100278,"node_id":"MDQ6VXNlcjI2MTAwMjc4","avatar_url":"https://avatars2.githubusercontent.com/u/26100278?v=4","gravatar_id":"","url":"https://api.github.com/users/vEpiphyte","html_url":"https://github.com/vEpiphyte","followers_url":"https://api.github.com/users/vEpiphyte/followers","following_url":"https://api.github.com/users/vEpiphyte/following{/other_user}","gists_url":"https://api.github.com/users/vEpiphyte/gists{/gist_id}","starred_url":"https://api.github.com/users/vEpiphyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vEpiphyte/subscriptions","organizations_url":"https://api.github.com/users/vEpiphyte/orgs","repos_url":"https://api.github.com/users/vEpiphyte/repos","events_url":"https://api.github.com/users/vEpiphyte/events{/privacy}","received_events_url":"https://api.github.com/users/vEpiphyte/received_events","type":"User","site_admin":false},"body":"Should raise a more explicit exception (either some synerr) or a runtimeerror","created_at":"2018-10-19T19:51:40Z","updated_at":"2018-10-19T19:51:40Z","html_url":"https://github.com/vertexproject/synapse/pull/965#discussion_r226763631","pull_request_url":"https://api.github.com/repos/vertexproject/synapse/pulls/965","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/comments/226763631"},"html":{"href":"https://github.com/vertexproject/synapse/pull/965#discussion_r226763631"},"pull_request":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/965"}}},"pull_request":{"url":"https://api.github.com/repos/vertexproject/synapse/pulls/965","id":220105279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTA1Mjc5","html_url":"https://github.com/vertexproject/synapse/pull/965","diff_url":"https://github.com/vertexproject/synapse/pull/965.diff","patch_url":"https://github.com/vertexproject/synapse/pull/965.patch","issue_url":"https://api.github.com/repos/vertexproject/synapse/issues/965","number":965,"state":"open","locked":false,"title":"Make synapse async","user":{"login":"jnwatson","id":3623079,"node_id":"MDQ6VXNlcjM2MjMwNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3623079?v=4","gravatar_id":"","url":"https://api.github.com/users/jnwatson","html_url":"https://github.com/jnwatson","followers_url":"https://api.github.com/users/jnwatson/followers","following_url":"https://api.github.com/users/jnwatson/following{/other_user}","gists_url":"https://api.github.com/users/jnwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/jnwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnwatson/subscriptions","organizations_url":"https://api.github.com/users/jnwatson/orgs","repos_url":"https://api.github.com/users/jnwatson/repos","events_url":"https://api.github.com/users/jnwatson/events{/privacy}","received_events_url":"https://api.github.com/users/jnwatson/received_events","type":"User","site_admin":false},"body":"Force Python 3.7. Port to use python async keywords.","created_at":"2018-10-03T16:42:26Z","updated_at":"2018-10-19T19:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ad7d3c72e836bb33eef2627bcbca5788129d74b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vertexproject/synapse/pulls/965/commits","review_comments_url":"https://api.github.com/repos/vertexproject/synapse/pulls/965/comments","review_comment_url":"https://api.github.com/repos/vertexproject/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vertexproject/synapse/issues/965/comments","statuses_url":"https://api.github.com/repos/vertexproject/synapse/statuses/0739f9e9dbd39a4d0a86671f5f0182cf923c75e3","head":{"label":"vertexproject:010-async","ref":"010-async","sha":"0739f9e9dbd39a4d0a86671f5f0182cf923c75e3","user":{"login":"vertexproject","id":21201579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAxNTc5","avatar_url":"https://avatars2.githubusercontent.com/u/21201579?v=4","gravatar_id":"","url":"https://api.github.com/users/vertexproject","html_url":"https://github.com/vertexproject","followers_url":"https://api.github.com/users/vertexproject/followers","following_url":"https://api.github.com/users/vertexproject/following{/other_user}","gists_url":"https://api.github.com/users/vertexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexproject/subscriptions","organizations_url":"https://api.github.com/users/vertexproject/orgs","repos_url":"https://api.github.com/users/vertexproject/repos","events_url":"https://api.github.com/users/vertexproject/events{/privacy}","received_events_url":"https://api.github.com/users/vertexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":37228107,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIyODEwNw==","name":"synapse","full_name":"vertexproject/synapse","private":false,"owner":{"login":"vertexproject","id":21201579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAxNTc5","avatar_url":"https://avatars2.githubusercontent.com/u/21201579?v=4","gravatar_id":"","url":"https://api.github.com/users/vertexproject","html_url":"https://github.com/vertexproject","followers_url":"https://api.github.com/users/vertexproject/followers","following_url":"https://api.github.com/users/vertexproject/following{/other_user}","gists_url":"https://api.github.com/users/vertexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexproject/subscriptions","organizations_url":"https://api.github.com/users/vertexproject/orgs","repos_url":"https://api.github.com/users/vertexproject/repos","events_url":"https://api.github.com/users/vertexproject/events{/privacy}","received_events_url":"https://api.github.com/users/vertexproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vertexproject/synapse","description":"Distributed Key-Value Hypergraph Analysis Framework","fork":false,"url":"https://api.github.com/repos/vertexproject/synapse","forks_url":"https://api.github.com/repos/vertexproject/synapse/forks","keys_url":"https://api.github.com/repos/vertexproject/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vertexproject/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vertexproject/synapse/teams","hooks_url":"https://api.github.com/repos/vertexproject/synapse/hooks","issue_events_url":"https://api.github.com/repos/vertexproject/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/vertexproject/synapse/events","assignees_url":"https://api.github.com/repos/vertexproject/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/vertexproject/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/vertexproject/synapse/tags","blobs_url":"https://api.github.com/repos/vertexproject/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vertexproject/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vertexproject/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/vertexproject/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vertexproject/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/vertexproject/synapse/languages","stargazers_url":"https://api.github.com/repos/vertexproject/synapse/stargazers","contributors_url":"https://api.github.com/repos/vertexproject/synapse/contributors","subscribers_url":"https://api.github.com/repos/vertexproject/synapse/subscribers","subscription_url":"https://api.github.com/repos/vertexproject/synapse/subscription","commits_url":"https://api.github.com/repos/vertexproject/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/vertexproject/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/vertexproject/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/vertexproject/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/vertexproject/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/vertexproject/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vertexproject/synapse/merges","archive_url":"https://api.github.com/repos/vertexproject/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vertexproject/synapse/downloads","issues_url":"https://api.github.com/repos/vertexproject/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/vertexproject/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/vertexproject/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/vertexproject/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vertexproject/synapse/labels{/name}","releases_url":"https://api.github.com/repos/vertexproject/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/vertexproject/synapse/deployments","created_at":"2015-06-10T23:29:41Z","updated_at":"2018-09-25T15:18:44Z","pushed_at":"2018-10-19T19:44:38Z","git_url":"git://github.com/vertexproject/synapse.git","ssh_url":"git@github.com:vertexproject/synapse.git","clone_url":"https://github.com/vertexproject/synapse.git","svn_url":"https://github.com/vertexproject/synapse","homepage":"","size":9695,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":21,"watchers":47,"default_branch":"master"}},"base":{"label":"vertexproject:010","ref":"010","sha":"941f18a3c180585578f64d14f0f8cb19f41a3293","user":{"login":"vertexproject","id":21201579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAxNTc5","avatar_url":"https://avatars2.githubusercontent.com/u/21201579?v=4","gravatar_id":"","url":"https://api.github.com/users/vertexproject","html_url":"https://github.com/vertexproject","followers_url":"https://api.github.com/users/vertexproject/followers","following_url":"https://api.github.com/users/vertexproject/following{/other_user}","gists_url":"https://api.github.com/users/vertexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexproject/subscriptions","organizations_url":"https://api.github.com/users/vertexproject/orgs","repos_url":"https://api.github.com/users/vertexproject/repos","events_url":"https://api.github.com/users/vertexproject/events{/privacy}","received_events_url":"https://api.github.com/users/vertexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":37228107,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIyODEwNw==","name":"synapse","full_name":"vertexproject/synapse","private":false,"owner":{"login":"vertexproject","id":21201579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAxNTc5","avatar_url":"https://avatars2.githubusercontent.com/u/21201579?v=4","gravatar_id":"","url":"https://api.github.com/users/vertexproject","html_url":"https://github.com/vertexproject","followers_url":"https://api.github.com/users/vertexproject/followers","following_url":"https://api.github.com/users/vertexproject/following{/other_user}","gists_url":"https://api.github.com/users/vertexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexproject/subscriptions","organizations_url":"https://api.github.com/users/vertexproject/orgs","repos_url":"https://api.github.com/users/vertexproject/repos","events_url":"https://api.github.com/users/vertexproject/events{/privacy}","received_events_url":"https://api.github.com/users/vertexproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vertexproject/synapse","description":"Distributed Key-Value Hypergraph Analysis Framework","fork":false,"url":"https://api.github.com/repos/vertexproject/synapse","forks_url":"https://api.github.com/repos/vertexproject/synapse/forks","keys_url":"https://api.github.com/repos/vertexproject/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vertexproject/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vertexproject/synapse/teams","hooks_url":"https://api.github.com/repos/vertexproject/synapse/hooks","issue_events_url":"https://api.github.com/repos/vertexproject/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/vertexproject/synapse/events","assignees_url":"https://api.github.com/repos/vertexproject/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/vertexproject/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/vertexproject/synapse/tags","blobs_url":"https://api.github.com/repos/vertexproject/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vertexproject/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vertexproject/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/vertexproject/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vertexproject/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/vertexproject/synapse/languages","stargazers_url":"https://api.github.com/repos/vertexproject/synapse/stargazers","contributors_url":"https://api.github.com/repos/vertexproject/synapse/contributors","subscribers_url":"https://api.github.com/repos/vertexproject/synapse/subscribers","subscription_url":"https://api.github.com/repos/vertexproject/synapse/subscription","commits_url":"https://api.github.com/repos/vertexproject/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/vertexproject/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/vertexproject/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/vertexproject/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/vertexproject/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/vertexproject/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vertexproject/synapse/merges","archive_url":"https://api.github.com/repos/vertexproject/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vertexproject/synapse/downloads","issues_url":"https://api.github.com/repos/vertexproject/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/vertexproject/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/vertexproject/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/vertexproject/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vertexproject/synapse/labels{/name}","releases_url":"https://api.github.com/repos/vertexproject/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/vertexproject/synapse/deployments","created_at":"2015-06-10T23:29:41Z","updated_at":"2018-09-25T15:18:44Z","pushed_at":"2018-10-19T19:44:38Z","git_url":"git://github.com/vertexproject/synapse.git","ssh_url":"git@github.com:vertexproject/synapse.git","clone_url":"https://github.com/vertexproject/synapse.git","svn_url":"https://github.com/vertexproject/synapse","homepage":"","size":9695,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":21,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/965"},"html":{"href":"https://github.com/vertexproject/synapse/pull/965"},"issue":{"href":"https://api.github.com/repos/vertexproject/synapse/issues/965"},"comments":{"href":"https://api.github.com/repos/vertexproject/synapse/issues/965/comments"},"review_comments":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/965/comments"},"review_comment":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/965/commits"},"statuses":{"href":"https://api.github.com/repos/vertexproject/synapse/statuses/0739f9e9dbd39a4d0a86671f5f0182cf923c75e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vEpiphyte"}}