{"action":"created","comment":{"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments/225500506","pull_request_review_id":165110952,"id":225500506,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTUwMDUwNg==","diff_hunk":"@@ -0,0 +1,124 @@\n+package uk.gov.digital.ho.pttg.application.namematching;\n+\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+import org.mockito.junit.MockitoJUnitRunner;\n+\n+import java.util.Arrays;\n+import java.util.Collections;\n+import java.util.List;\n+\n+import static org.assertj.core.api.Assertions.assertThat;\n+\n+@RunWith(MockitoJUnitRunner.class)\n+public class InputNamesTest {\n+\n+    @Test\n+    public void multiPartLastNameEmpty() {\n+        InputNames inputNames = new InputNames(\"any-name\", \"\");\n+\n+        assertThat(inputNames.multiPartLastName()).isFalse();\n+    }\n+\n+    @Test\n+    public void multiPartLastNameSingleName() {\n+        InputNames inputNames = new InputNames(\"any-name\", \"any-lastname\");\n+\n+        assertThat(inputNames.multiPartLastName()).isFalse();\n+    }\n+\n+    @Test\n+    public void multiPartLastNameSingleTwoNames() {\n+        InputNames inputNames = new InputNames(\"any-name\", \"lastname1 lastname2\");\n+\n+        assertThat(inputNames.multiPartLastName()).isTrue();\n+    }\n+\n+    @Test\n+    public void multiPartLastNameFirstNameIIrrelevant() {","path":"src/test/java/uk/gov/digital/ho/pttg/application/namematching/InputNamesTest.java","position":38,"original_position":38,"commit_id":"07ade11f361f7680eb6b344d2c396a3849237933","original_commit_id":"07ade11f361f7680eb6b344d2c396a3849237933","user":{"login":"owainrobertsbjss","id":41990779,"node_id":"MDQ6VXNlcjQxOTkwNzc5","avatar_url":"https://avatars1.githubusercontent.com/u/41990779?v=4","gravatar_id":"","url":"https://api.github.com/users/owainrobertsbjss","html_url":"https://github.com/owainrobertsbjss","followers_url":"https://api.github.com/users/owainrobertsbjss/followers","following_url":"https://api.github.com/users/owainrobertsbjss/following{/other_user}","gists_url":"https://api.github.com/users/owainrobertsbjss/gists{/gist_id}","starred_url":"https://api.github.com/users/owainrobertsbjss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owainrobertsbjss/subscriptions","organizations_url":"https://api.github.com/users/owainrobertsbjss/orgs","repos_url":"https://api.github.com/users/owainrobertsbjss/repos","events_url":"https://api.github.com/users/owainrobertsbjss/events{/privacy}","received_events_url":"https://api.github.com/users/owainrobertsbjss/received_events","type":"User","site_admin":false},"body":"I think theres an S missing? multiPartLastNameFirstNameI(s)Irrelevan not multiPartLastNameFirstNameIIrrelevant?","created_at":"2018-10-16T11:31:47Z","updated_at":"2018-10-16T11:31:47Z","html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/117#discussion_r225500506","pull_request_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments/225500506"},"html":{"href":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/117#discussion_r225500506"},"pull_request":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117","id":223209627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjA5NjI3","html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/117","diff_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/117.diff","patch_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/117.patch","issue_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/117","number":117,"state":"open","locked":false,"title":"Ee 9537/refactor names special characters","user":{"login":"mikehalmaho","id":38494033,"node_id":"MDQ6VXNlcjM4NDk0MDMz","avatar_url":"https://avatars0.githubusercontent.com/u/38494033?v=4","gravatar_id":"","url":"https://api.github.com/users/mikehalmaho","html_url":"https://github.com/mikehalmaho","followers_url":"https://api.github.com/users/mikehalmaho/followers","following_url":"https://api.github.com/users/mikehalmaho/following{/other_user}","gists_url":"https://api.github.com/users/mikehalmaho/gists{/gist_id}","starred_url":"https://api.github.com/users/mikehalmaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikehalmaho/subscriptions","organizations_url":"https://api.github.com/users/mikehalmaho/orgs","repos_url":"https://api.github.com/users/mikehalmaho/repos","events_url":"https://api.github.com/users/mikehalmaho/events{/privacy}","received_events_url":"https://api.github.com/users/mikehalmaho/received_events","type":"User","site_admin":false},"body":"- Refactor Special Character processing into its own component.\r\n- Instead of passing lists of strings around, encapsulate the input names in their own class InputNames.\r\n- Standardise terminology - use firstName and lastName everywhere, replace PersonName with CandidateName","created_at":"2018-10-16T11:15:45Z","updated_at":"2018-10-16T11:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6738e7864f54756fe8140069623800308ef85d74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117/commits","review_comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117/comments","review_comment_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/117/comments","statuses_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/07ade11f361f7680eb6b344d2c396a3849237933","head":{"label":"UKHomeOffice:EE-9537/refactor-names-special-characters","ref":"EE-9537/refactor-names-special-characters","sha":"07ade11f361f7680eb6b344d2c396a3849237933","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":97106451,"node_id":"MDEwOlJlcG9zaXRvcnk5NzEwNjQ1MQ==","name":"pttg-ip-hmrc","full_name":"UKHomeOffice/pttg-ip-hmrc","private":false,"owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","description":"Interfaces to the HMRC API for Income Proving","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc","forks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/deployments","created_at":"2017-07-13T09:42:02Z","updated_at":"2018-10-15T12:24:43Z","pushed_at":"2018-10-16T11:15:45Z","git_url":"git://github.com/UKHomeOffice/pttg-ip-hmrc.git","ssh_url":"git@github.com:UKHomeOffice/pttg-ip-hmrc.git","clone_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc.git","svn_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","homepage":null,"size":699,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"UKHomeOffice:master","ref":"master","sha":"42a1922f44b7da7e2cec1213d70703c77222b451","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":97106451,"node_id":"MDEwOlJlcG9zaXRvcnk5NzEwNjQ1MQ==","name":"pttg-ip-hmrc","full_name":"UKHomeOffice/pttg-ip-hmrc","private":false,"owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","description":"Interfaces to the HMRC API for Income Proving","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc","forks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/deployments","created_at":"2017-07-13T09:42:02Z","updated_at":"2018-10-15T12:24:43Z","pushed_at":"2018-10-16T11:15:45Z","git_url":"git://github.com/UKHomeOffice/pttg-ip-hmrc.git","ssh_url":"git@github.com:UKHomeOffice/pttg-ip-hmrc.git","clone_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc.git","svn_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","homepage":null,"size":699,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117"},"html":{"href":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/117"},"issue":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/117"},"comments":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/07ade11f361f7680eb6b344d2c396a3849237933"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"owainrobertsbjss"}}