{"action":"opened","number":8347,"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/8347","id":194104687,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTA0Njg3","html_url":"https://github.com/pytorch/pytorch/pull/8347","diff_url":"https://github.com/pytorch/pytorch/pull/8347.diff","patch_url":"https://github.com/pytorch/pytorch/pull/8347.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/8347","number":8347,"state":"open","locked":false,"title":"[C++ API] Make pImpl easy to use in modules to enable happy reference semantics","user":{"login":"goldsborough","id":6429851,"node_id":"MDQ6VXNlcjY0Mjk4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6429851?v=4","gravatar_id":"","url":"https://api.github.com/users/goldsborough","html_url":"https://github.com/goldsborough","followers_url":"https://api.github.com/users/goldsborough/followers","following_url":"https://api.github.com/users/goldsborough/following{/other_user}","gists_url":"https://api.github.com/users/goldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsborough/subscriptions","organizations_url":"https://api.github.com/users/goldsborough/orgs","repos_url":"https://api.github.com/users/goldsborough/repos","events_url":"https://api.github.com/users/goldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/goldsborough/received_events","type":"User","site_admin":false},"body":"This PR implements hopefully the last iteration of how modules should be defined and constructed in the C++ API, which was discussed a few weeks ago with @ezyang and @ebetica. The most minimal definition of a module is now:\r\n\r\n```\r\nstruct LinearImpl : public torch::nn::Module {\r\n  struct Options {\r\n    Options(int64_t in, int64_t out);\r\n    TORCH_ARG(int64_t, in);\r\n    TORCH_ARG(int64_t, out);\r\n  } options;\r\n\r\n  explicit LinearImpl(Options options);\r\n  Variable forward(Variable input);\r\n\r\n  Variable weight_;\r\n  Variable bias_;\r\n};\r\nTORCH_MODULE(Linear);\r\n```\r\n\r\nand usage is\r\n\r\n```\r\nLinear model(3, 4);\r\n```\r\n\r\n`TORCH_MODULE` defines a class `Linear` which wraps a `std::shared_ptr<LinearImpl>`, as well as providing convenient mechanisms to forward constructor arguments to the `Options` struct. Notice that I wrote `Linear(3, 4)` and not `Linear(LinearOptions(3, 4))`. This makes usage very convenient in the most common case. When default options need be changed, it becomes `Linear(LinearOptions(4, 5).default(1).default(2))`.\r\n\r\nThe most important file is `torch/csrc/api/include/torch/nn/pimpl.h`. The rest is mostly codemods.\r\n\r\nThoughts, wishes, improvements? @ebetica @ezyang  ","created_at":"2018-06-11T21:11:31Z","updated_at":"2018-06-11T21:11:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/8347/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/8347/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/8347/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/bf565daaee27937214fdab4b0a6f1dacedbab059","head":{"label":"goldsborough:pimpl","ref":"pimpl","sha":"bf565daaee27937214fdab4b0a6f1dacedbab059","user":{"login":"goldsborough","id":6429851,"node_id":"MDQ6VXNlcjY0Mjk4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6429851?v=4","gravatar_id":"","url":"https://api.github.com/users/goldsborough","html_url":"https://github.com/goldsborough","followers_url":"https://api.github.com/users/goldsborough/followers","following_url":"https://api.github.com/users/goldsborough/following{/other_user}","gists_url":"https://api.github.com/users/goldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsborough/subscriptions","organizations_url":"https://api.github.com/users/goldsborough/orgs","repos_url":"https://api.github.com/users/goldsborough/repos","events_url":"https://api.github.com/users/goldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/goldsborough/received_events","type":"User","site_admin":false},"repo":{"id":115096378,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUwOTYzNzg=","name":"pytorch","full_name":"goldsborough/pytorch","owner":{"login":"goldsborough","id":6429851,"node_id":"MDQ6VXNlcjY0Mjk4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6429851?v=4","gravatar_id":"","url":"https://api.github.com/users/goldsborough","html_url":"https://github.com/goldsborough","followers_url":"https://api.github.com/users/goldsborough/followers","following_url":"https://api.github.com/users/goldsborough/following{/other_user}","gists_url":"https://api.github.com/users/goldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsborough/subscriptions","organizations_url":"https://api.github.com/users/goldsborough/orgs","repos_url":"https://api.github.com/users/goldsborough/repos","events_url":"https://api.github.com/users/goldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/goldsborough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goldsborough/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/goldsborough/pytorch","forks_url":"https://api.github.com/repos/goldsborough/pytorch/forks","keys_url":"https://api.github.com/repos/goldsborough/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goldsborough/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goldsborough/pytorch/teams","hooks_url":"https://api.github.com/repos/goldsborough/pytorch/hooks","issue_events_url":"https://api.github.com/repos/goldsborough/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/goldsborough/pytorch/events","assignees_url":"https://api.github.com/repos/goldsborough/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/goldsborough/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/goldsborough/pytorch/tags","blobs_url":"https://api.github.com/repos/goldsborough/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goldsborough/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goldsborough/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/goldsborough/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goldsborough/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/goldsborough/pytorch/languages","stargazers_url":"https://api.github.com/repos/goldsborough/pytorch/stargazers","contributors_url":"https://api.github.com/repos/goldsborough/pytorch/contributors","subscribers_url":"https://api.github.com/repos/goldsborough/pytorch/subscribers","subscription_url":"https://api.github.com/repos/goldsborough/pytorch/subscription","commits_url":"https://api.github.com/repos/goldsborough/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/goldsborough/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/goldsborough/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/goldsborough/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/goldsborough/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/goldsborough/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goldsborough/pytorch/merges","archive_url":"https://api.github.com/repos/goldsborough/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goldsborough/pytorch/downloads","issues_url":"https://api.github.com/repos/goldsborough/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/goldsborough/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/goldsborough/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/goldsborough/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goldsborough/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/goldsborough/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/goldsborough/pytorch/deployments","created_at":"2017-12-22T08:49:57Z","updated_at":"2018-06-06T06:51:44Z","pushed_at":"2018-06-11T20:59:43Z","git_url":"git://github.com/goldsborough/pytorch.git","ssh_url":"git@github.com:goldsborough/pytorch.git","clone_url":"https://github.com/goldsborough/pytorch.git","svn_url":"https://github.com/goldsborough/pytorch","homepage":"http://pytorch.org","size":58109,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"9b1480a28e59b395a18def3b8b90c364b7a05d8a","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-06-11T20:40:08Z","pushed_at":"2018-06-11T21:03:46Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":57504,"stargazers_count":16309,"watchers_count":16309,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3694,"mirror_url":null,"archived":false,"open_issues_count":1203,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3694,"open_issues":1203,"watchers":16309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/8347"},"html":{"href":"https://github.com/pytorch/pytorch/pull/8347"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/8347"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/8347/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/8347/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/8347/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/bf565daaee27937214fdab4b0a6f1dacedbab059"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":16,"additions":1019,"deletions":523,"changed_files":33}}
{"actor":{"display_login":"goldsborough"}}