{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/529","repository_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter","labels_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/529/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/529/comments","events_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/529/events","html_url":"https://github.com/nunit/nunit3-vs-adapter/issues/529","id":340056414,"node_id":"MDU6SXNzdWUzNDAwNTY0MTQ=","number":529,"title":"Use framework prefilter for massive perf improvement when running fraction of tests","user":{"login":"jnm2","id":8040367,"node_id":"MDQ6VXNlcjgwNDAzNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"labels":[{"id":190575675,"node_id":"MDU6TGFiZWwxOTA1NzU2NzU=","url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/labels/is:enhancement","name":"is:enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-11T01:04:34Z","updated_at":"2018-07-11T15:31:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Following up from https://github.com/nunit/nunit/issues/2867: I had cut inner-loop test lag in continuous testing of a single no-op test down to nine seconds for a work project, but I could go no further without getting NUnit to skip invoking test case sources that are outside the filter. \r\n\r\n@CharliePoole has accomplished this by introducing discovery-time filtering in the framework and integrating with it in the NUnitLite runner. This pattern should be easy to follow in all the other runners: https://github.com/nunit/nunit/pull/2878\r\n\r\nFor @oznetmaster, this has resulted in roughly a 12x performance boost: https://github.com/nunit/nunit/pull/2878#issuecomment-404009088. At work, I'm expecting something similar. I'd really love to help get this in the next releases of the VS adapter and the console runner.\r\n\r\n@OsirisTerje Is this something you're interested in, or would you accept a PR?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/comments/404212618","html_url":"https://github.com/nunit/nunit3-vs-adapter/issues/529#issuecomment-404212618","issue_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/529","id":404212618,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDIxMjYxOA==","user":{"login":"jnm2","id":8040367,"node_id":"MDQ6VXNlcjgwNDAzNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T15:31:05Z","updated_at":"2018-07-11T15:31:05Z","author_association":"CONTRIBUTOR","body":"@OsirisTerje The performance benefit that I'm seeing comes mainly from skipping the invocation and enumeration of TestCaseSources. Source-based discovery does not invoke TestCaseSources, correct?"}}
{"actor":{"display_login":"jnm2"}}