{"action":"created","issue":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3840","repository_url":"https://api.github.com/repos/freedomofpress/securedrop","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3840/labels{/name}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3840/comments","events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3840/events","html_url":"https://github.com/freedomofpress/securedrop/pull/3840","id":366082382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODQ3MjU5","number":3840,"title":"Modify CI docker SD behavior to match dev env","user":{"login":"msheiny","id":1727935,"node_id":"MDQ6VXNlcjE3Mjc5MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1727935?v=4","gravatar_id":"","url":"https://api.github.com/users/msheiny","html_url":"https://github.com/msheiny","followers_url":"https://api.github.com/users/msheiny/followers","following_url":"https://api.github.com/users/msheiny/following{/other_user}","gists_url":"https://api.github.com/users/msheiny/gists{/gist_id}","starred_url":"https://api.github.com/users/msheiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheiny/subscriptions","organizations_url":"https://api.github.com/users/msheiny/orgs","repos_url":"https://api.github.com/users/msheiny/repos","events_url":"https://api.github.com/users/msheiny/events{/privacy}","received_events_url":"https://api.github.com/users/msheiny/received_events","type":"User","site_admin":false},"labels":[{"id":474552509,"node_id":"MDU6TGFiZWw0NzQ1NTI1MDk=","url":"https://api.github.com/repos/freedomofpress/securedrop/labels/PR:%20Pending%20additional%20work","name":"PR: Pending additional work","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-02T21:13:33Z","updated_at":"2018-10-03T23:14:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3840","html_url":"https://github.com/freedomofpress/securedrop/pull/3840","diff_url":"https://github.com/freedomofpress/securedrop/pull/3840.diff","patch_url":"https://github.com/freedomofpress/securedrop/pull/3840.patch"},"body":"\r\n## Status\r\n\r\nWork in progress\r\n\r\n## Description of Changes\r\n\r\nFixes #3839 \r\n\r\nChanges proposed in this pull request:\r\n\r\n* Utilize higher :dollar:  cost `machine` executor (at least they plan to charge more for it in the \"future\")\r\n* Revamp docker caching to only rebuild when `Dockerfile` changes.\r\n\r\n## Testing\r\n\r\nHow should the reviewer test this PR?\r\n\r\n* Ensure you can still spin up docker locally (tests and dev env)\r\n* Ensure CI doesn't break :crossed_fingers: \r\n\r\n## Deployment\r\n\r\nAny special considerations for deployment? Consider both:\r\n\r\nNOPE - only affects dev + CI\r\n\r\n## Checklist\r\n\r\n### If you made changes to the server application code:\r\n\r\nUmm  I didn't questionnaire... why you all up in my bizness!?\r\n\r\n### If you made changes to `securedrop-admin`:\r\n\r\nHEY! Whats with all the :fire: ?\r\n\r\n### If you made changes to the system configuration:\r\n\r\nI swear to god... \r\n\r\n### If you made non-trivial code changes:\r\n\r\n- [x] I have written a test plan and validated it for this PR\r\n\r\n### If you made changes to documentation:\r\n\r\nDocs!? we have docs!?"},"comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments/426834037","html_url":"https://github.com/freedomofpress/securedrop/pull/3840#issuecomment-426834037","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3840","id":426834037,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjgzNDAzNw==","user":{"login":"msheiny","id":1727935,"node_id":"MDQ6VXNlcjE3Mjc5MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1727935?v=4","gravatar_id":"","url":"https://api.github.com/users/msheiny","html_url":"https://github.com/msheiny","followers_url":"https://api.github.com/users/msheiny/followers","following_url":"https://api.github.com/users/msheiny/following{/other_user}","gists_url":"https://api.github.com/users/msheiny/gists{/gist_id}","starred_url":"https://api.github.com/users/msheiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheiny/subscriptions","organizations_url":"https://api.github.com/users/msheiny/orgs","repos_url":"https://api.github.com/users/msheiny/repos","events_url":"https://api.github.com/users/msheiny/events{/privacy}","received_events_url":"https://api.github.com/users/msheiny/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T23:14:42Z","updated_at":"2018-10-03T23:14:42Z","author_association":"CONTRIBUTOR","body":"I want to point out here that `lint` is failing but:\r\n* a majority of the shellcheck ones seem to be a side-effect of bumping the shellcheck version\r\n* i'm actually confused on the mypy failure here though. I also get failures on `develop` when i run it locally. I thought maybe it was just a grsec thing but I'm getting the same error in CI here.\r\n\r\n@kushaldas can you eye the mypy failure to make sure I'm not crazy?\r\n"}}
{"actor":{"display_login":"msheiny"}}