{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/188547406","pull_request_review_id":120545335,"id":188547406,"diff_hunk":"@@ -325,25 +325,28 @@ module TestDataFrame\n     df = DataFrame(a=Union{Int, Missing}[1, 2, 3], b=Union{Float64, Missing}[3.0, 4.0, 5.0])\n     @test deleterows!(df, [2, 3]) === df\n     @test df == DataFrame(a=[1], b=[3.0])\n-\n-    # describe\n-    #suppress output and test that describe() does not throw\n-    devmissing = Compat.Sys.isunix() ? \"/dev/null\" : \"nul\"\n-    open(devmissing, \"w\") do f\n-        @test nothing == describe(f, DataFrame(a=[1, 2], b=Any[\"3\", missing]))\n-        @test nothing ==\n-              describe(f, DataFrame(a=Union{Int, Missing}[1, 2],\n-                                    b=[\"3\", missing]))\n-        @test nothing ==\n-              describe(f, DataFrame(a=CategoricalArray([1, 2]),\n-                                    b=CategoricalArray([\"3\", missing])))\n-        @test nothing == describe(f, [1, 2, 3])\n-        @test nothing == describe(f, [1, 2, 3])\n-        @test nothing == describe(f, CategoricalArray([1, 2, 3]))\n-        @test nothing == describe(f, Any[\"1\", \"2\", missing])\n-        @test nothing == describe(f, [\"1\", \"2\", missing])\n-        @test nothing == describe(f, CategoricalArray([\"1\", \"2\", missing]))\n-    end\n+    \n+    # Test describe\n+    struct MySuperLongNameForAStructIsThisToolong end\n+    @testset \"describe(df)\" begin\n+        describe_output = DataFrame(variable = [:number, :number_missing, :non_number, :non_number_missing, :long_struct],\n+                                    mean = [2.5, 2.0, nothing, nothing, nothing],\n+                                    min = [1.0, 1.0, nothing, nothing, nothing],\n+                                    median = [2.5, 2.0, nothing, nothing, nothing],\n+                                    max = [4.0, 3.0, nothing, nothing, nothing],\n+                                    nmissing = [nothing, 1, nothing, 1, nothing],\n+                                    eltype= [Int64, Int64, String, String, MySuperLongNameForAStructIsThisToolong])","path":"test/dataframe.jl","position":33,"original_position":33,"commit_id":"af164d9a93a663d75e65674698e82f50f33fc6f2","original_commit_id":"af164d9a93a663d75e65674698e82f50f33fc6f2","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars3.githubusercontent.com/u/1120448?v=4","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"Ah, and use `Int` rather than `Int64` (this explains the 32-bit Windows failure).","created_at":"2018-05-16T08:47:07Z","updated_at":"2018-05-16T08:47:07Z","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1409#discussion_r188547406","pull_request_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/188547406"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1409#discussion_r188547406"},"pull_request":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409"}},"in_reply_to_id":188538188},"pull_request":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409","id":187644819,"html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1409","diff_url":"https://github.com/JuliaData/DataFrames.jl/pull/1409.diff","patch_url":"https://github.com/JuliaData/DataFrames.jl/pull/1409.patch","issue_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1409","number":1409,"state":"open","locked":false,"title":"Make `describe` return a DataFrame","user":{"login":"pdeffebach","id":23196228,"avatar_url":"https://avatars3.githubusercontent.com/u/23196228?v=4","gravatar_id":"","url":"https://api.github.com/users/pdeffebach","html_url":"https://github.com/pdeffebach","followers_url":"https://api.github.com/users/pdeffebach/followers","following_url":"https://api.github.com/users/pdeffebach/following{/other_user}","gists_url":"https://api.github.com/users/pdeffebach/gists{/gist_id}","starred_url":"https://api.github.com/users/pdeffebach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdeffebach/subscriptions","organizations_url":"https://api.github.com/users/pdeffebach/orgs","repos_url":"https://api.github.com/users/pdeffebach/repos","events_url":"https://api.github.com/users/pdeffebach/events{/privacy}","received_events_url":"https://api.github.com/users/pdeffebach/received_events","type":"User","site_admin":false},"body":"This pull request is the result of [this](https://discourse.julialang.org/t/a-proposal-for-describe-of-a-dataframe/10254) discussion on Discourse about making `describe(df::AbstractDataFrame)` return a tabular object for easier reading. \r\n\r\nThe `describe` function now works as follows:\r\n\r\n- Allows for a keyword argument `colstats` so that the user can select which summary statistics are reported\r\n- It reports `nothing` in the cell where the summary statistic is not defined. For example, the mean of a `String` column is simply `nothing`. \r\n- It reports the number of missing values, similarly reporting `nothing` if the column does not allow missing values. \r\n\r\nThe `describe(x::AbstractVector)` functions are not modified by this pull request.  This is the behavior that simply prints the results of `StatsBase.summarize` (with some additions for non-numeric vectors that DataFrames had already defined.\r\n\r\nI updated the tests and docstrings to this new behavior. \r\n\r\nI believe this PR will result in more friendly behavior for Data Exploration. It is much easier to read the printout of a DataFrame than the current behavior, where one has to scroll a good deal to see the numbers they want. ","created_at":"2018-05-12T23:28:39Z","updated_at":"2018-05-16T08:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec9067be93b7aa9c185c27a8a2faf3aa4087501c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409/commits","review_comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409/comments","review_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1409/comments","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/af164d9a93a663d75e65674698e82f50f33fc6f2","head":{"label":"pdeffebach:master","ref":"master","sha":"af164d9a93a663d75e65674698e82f50f33fc6f2","user":{"login":"pdeffebach","id":23196228,"avatar_url":"https://avatars3.githubusercontent.com/u/23196228?v=4","gravatar_id":"","url":"https://api.github.com/users/pdeffebach","html_url":"https://github.com/pdeffebach","followers_url":"https://api.github.com/users/pdeffebach/followers","following_url":"https://api.github.com/users/pdeffebach/following{/other_user}","gists_url":"https://api.github.com/users/pdeffebach/gists{/gist_id}","starred_url":"https://api.github.com/users/pdeffebach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdeffebach/subscriptions","organizations_url":"https://api.github.com/users/pdeffebach/orgs","repos_url":"https://api.github.com/users/pdeffebach/repos","events_url":"https://api.github.com/users/pdeffebach/events{/privacy}","received_events_url":"https://api.github.com/users/pdeffebach/received_events","type":"User","site_admin":false},"repo":{"id":128483920,"name":"DataFrames.jl","full_name":"pdeffebach/DataFrames.jl","owner":{"login":"pdeffebach","id":23196228,"avatar_url":"https://avatars3.githubusercontent.com/u/23196228?v=4","gravatar_id":"","url":"https://api.github.com/users/pdeffebach","html_url":"https://github.com/pdeffebach","followers_url":"https://api.github.com/users/pdeffebach/followers","following_url":"https://api.github.com/users/pdeffebach/following{/other_user}","gists_url":"https://api.github.com/users/pdeffebach/gists{/gist_id}","starred_url":"https://api.github.com/users/pdeffebach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdeffebach/subscriptions","organizations_url":"https://api.github.com/users/pdeffebach/orgs","repos_url":"https://api.github.com/users/pdeffebach/repos","events_url":"https://api.github.com/users/pdeffebach/events{/privacy}","received_events_url":"https://api.github.com/users/pdeffebach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdeffebach/DataFrames.jl","description":"Library for working with tabular data in Julia","fork":true,"url":"https://api.github.com/repos/pdeffebach/DataFrames.jl","forks_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/pdeffebach/DataFrames.jl/deployments","created_at":"2018-04-07T00:43:23Z","updated_at":"2018-05-15T14:40:03Z","pushed_at":"2018-05-15T14:40:00Z","git_url":"git://github.com/pdeffebach/DataFrames.jl.git","ssh_url":"git@github.com:pdeffebach/DataFrames.jl.git","clone_url":"https://github.com/pdeffebach/DataFrames.jl.git","svn_url":"https://github.com/pdeffebach/DataFrames.jl","homepage":"","size":9430,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaData:master","ref":"master","sha":"ff29a8185ab440f862c27c137126bd983a798a39","user":{"login":"JuliaData","id":20142970,"avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"repo":{"id":4992873,"name":"DataFrames.jl","full_name":"JuliaData/DataFrames.jl","owner":{"login":"JuliaData","id":20142970,"avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaData/DataFrames.jl","description":"Library for working with tabular data in Julia","fork":false,"url":"https://api.github.com/repos/JuliaData/DataFrames.jl","forks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/deployments","created_at":"2012-07-11T18:00:09Z","updated_at":"2018-05-10T17:30:42Z","pushed_at":"2018-05-15T14:40:02Z","git_url":"git://github.com/JuliaData/DataFrames.jl.git","ssh_url":"git@github.com:JuliaData/DataFrames.jl.git","clone_url":"https://github.com/JuliaData/DataFrames.jl.git","svn_url":"https://github.com/JuliaData/DataFrames.jl","homepage":"","size":9271,"stargazers_count":463,"watchers_count":463,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":204,"open_issues":84,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1409"},"issue":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1409"},"comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1409/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1409/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/af164d9a93a663d75e65674698e82f50f33fc6f2"}},"author_association":"NONE"}}
{"actor":{"display_login":"nalimilan"}}