{"action":"closed","number":25134,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/25134","id":206869255,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODY5MjU1","html_url":"https://github.com/laravel/framework/pull/25134","diff_url":"https://github.com/laravel/framework/pull/25134.diff","patch_url":"https://github.com/laravel/framework/pull/25134.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/25134","number":25134,"state":"closed","locked":false,"title":"[5.7] fix console getDefaultInputDefinition() docblock","user":{"login":"xuanquynh","id":16967350,"node_id":"MDQ6VXNlcjE2OTY3MzUw","avatar_url":"https://avatars3.githubusercontent.com/u/16967350?v=4","gravatar_id":"","url":"https://api.github.com/users/xuanquynh","html_url":"https://github.com/xuanquynh","followers_url":"https://api.github.com/users/xuanquynh/followers","following_url":"https://api.github.com/users/xuanquynh/following{/other_user}","gists_url":"https://api.github.com/users/xuanquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/xuanquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuanquynh/subscriptions","organizations_url":"https://api.github.com/users/xuanquynh/orgs","repos_url":"https://api.github.com/users/xuanquynh/repos","events_url":"https://api.github.com/users/xuanquynh/events{/privacy}","received_events_url":"https://api.github.com/users/xuanquynh/received_events","type":"User","site_admin":false},"body":"- I am not an English native speaker but I feel a bit \"strangely\" with the console getDefaultInputDefinition() doc-block.\r\n\r\n- Firstly, the concept \"input definitions\"  is associated with InputDefinition class, it should be \"input definition\", shouldn't it? I also refer to Symfony's documentation.\r\n\r\n```php\r\n/**\r\n * Gets the default input definition.\r\n *\r\n * @return InputDefinition An InputDefinition instance\r\n */\r\nprotected function getDefaultInputDefinition() {}\r\n```\r\n- Secondly, this method provides the default input definition for a specified application that it belongs to.\r\n\r\nInstead of using 'Get the default input definitions for the applications' (plural), I think the description 'Get the default input definition for the application' (singular) is more suitable.\r\n\r\nAnyway, this is optional. Just close it if it isn't important!\r\n\r\nThank you,\r\n\r\n\r\n","created_at":"2018-08-08T01:31:08Z","updated_at":"2018-08-08T05:33:12Z","closed_at":"2018-08-08T05:33:12Z","merged_at":"2018-08-08T05:33:12Z","merge_commit_sha":"b360a12e4400f48b51fe4af1418c375e3b5f92ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/25134/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/25134/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/25134/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/5adeb95c5426d824ee50fb1385297ed8c84094fa","head":{"label":"xuanquynh:fix-console-method-docblock","ref":"fix-console-method-docblock","sha":"5adeb95c5426d824ee50fb1385297ed8c84094fa","user":{"login":"xuanquynh","id":16967350,"node_id":"MDQ6VXNlcjE2OTY3MzUw","avatar_url":"https://avatars3.githubusercontent.com/u/16967350?v=4","gravatar_id":"","url":"https://api.github.com/users/xuanquynh","html_url":"https://github.com/xuanquynh","followers_url":"https://api.github.com/users/xuanquynh/followers","following_url":"https://api.github.com/users/xuanquynh/following{/other_user}","gists_url":"https://api.github.com/users/xuanquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/xuanquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuanquynh/subscriptions","organizations_url":"https://api.github.com/users/xuanquynh/orgs","repos_url":"https://api.github.com/users/xuanquynh/repos","events_url":"https://api.github.com/users/xuanquynh/events{/privacy}","received_events_url":"https://api.github.com/users/xuanquynh/received_events","type":"User","site_admin":false},"repo":{"id":114580836,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ1ODA4MzY=","name":"framework","full_name":"xuanquynh/framework","owner":{"login":"xuanquynh","id":16967350,"node_id":"MDQ6VXNlcjE2OTY3MzUw","avatar_url":"https://avatars3.githubusercontent.com/u/16967350?v=4","gravatar_id":"","url":"https://api.github.com/users/xuanquynh","html_url":"https://github.com/xuanquynh","followers_url":"https://api.github.com/users/xuanquynh/followers","following_url":"https://api.github.com/users/xuanquynh/following{/other_user}","gists_url":"https://api.github.com/users/xuanquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/xuanquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuanquynh/subscriptions","organizations_url":"https://api.github.com/users/xuanquynh/orgs","repos_url":"https://api.github.com/users/xuanquynh/repos","events_url":"https://api.github.com/users/xuanquynh/events{/privacy}","received_events_url":"https://api.github.com/users/xuanquynh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xuanquynh/framework","description":null,"fork":true,"url":"https://api.github.com/repos/xuanquynh/framework","forks_url":"https://api.github.com/repos/xuanquynh/framework/forks","keys_url":"https://api.github.com/repos/xuanquynh/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuanquynh/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuanquynh/framework/teams","hooks_url":"https://api.github.com/repos/xuanquynh/framework/hooks","issue_events_url":"https://api.github.com/repos/xuanquynh/framework/issues/events{/number}","events_url":"https://api.github.com/repos/xuanquynh/framework/events","assignees_url":"https://api.github.com/repos/xuanquynh/framework/assignees{/user}","branches_url":"https://api.github.com/repos/xuanquynh/framework/branches{/branch}","tags_url":"https://api.github.com/repos/xuanquynh/framework/tags","blobs_url":"https://api.github.com/repos/xuanquynh/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuanquynh/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuanquynh/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuanquynh/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuanquynh/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/xuanquynh/framework/languages","stargazers_url":"https://api.github.com/repos/xuanquynh/framework/stargazers","contributors_url":"https://api.github.com/repos/xuanquynh/framework/contributors","subscribers_url":"https://api.github.com/repos/xuanquynh/framework/subscribers","subscription_url":"https://api.github.com/repos/xuanquynh/framework/subscription","commits_url":"https://api.github.com/repos/xuanquynh/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuanquynh/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuanquynh/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuanquynh/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuanquynh/framework/contents/{+path}","compare_url":"https://api.github.com/repos/xuanquynh/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuanquynh/framework/merges","archive_url":"https://api.github.com/repos/xuanquynh/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuanquynh/framework/downloads","issues_url":"https://api.github.com/repos/xuanquynh/framework/issues{/number}","pulls_url":"https://api.github.com/repos/xuanquynh/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/xuanquynh/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/xuanquynh/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuanquynh/framework/labels{/name}","releases_url":"https://api.github.com/repos/xuanquynh/framework/releases{/id}","deployments_url":"https://api.github.com/repos/xuanquynh/framework/deployments","created_at":"2017-12-18T01:01:58Z","updated_at":"2018-07-15T13:05:51Z","pushed_at":"2018-08-08T01:15:48Z","git_url":"git://github.com/xuanquynh/framework.git","ssh_url":"git@github.com:xuanquynh/framework.git","clone_url":"https://github.com/xuanquynh/framework.git","svn_url":"https://github.com/xuanquynh/framework","homepage":"http://laravel.com","size":34343,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laravel:5.7","ref":"5.7","sha":"2104d867fd5a14753a01bec2603da0044fefa17e","user":{"login":"laravel","id":958072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1ODA3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQ4OTg2","name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1ODA3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2018-08-08T01:36:58Z","pushed_at":"2018-08-08T05:33:12Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":34432,"stargazers_count":13318,"watchers_count":13318,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5634,"mirror_url":null,"archived":false,"open_issues_count":208,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5634,"open_issues":208,"watchers":13318,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/25134"},"html":{"href":"https://github.com/laravel/framework/pull/25134"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/25134"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/25134/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/25134/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/25134/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/5adeb95c5426d824ee50fb1385297ed8c84094fa"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"node_id":"MDQ6VXNlcjQ2MzIzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/463230?v=4","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"taylorotwell"}}