{"action":"created","issue":{"url":"https://api.github.com/repos/cms-dev/cms/issues/868","repository_url":"https://api.github.com/repos/cms-dev/cms","labels_url":"https://api.github.com/repos/cms-dev/cms/issues/868/labels{/name}","comments_url":"https://api.github.com/repos/cms-dev/cms/issues/868/comments","events_url":"https://api.github.com/repos/cms-dev/cms/issues/868/events","html_url":"https://github.com/cms-dev/cms/pull/868","id":299946909,"number":868,"title":"Refactoring of OutputOnly","user":{"login":"stefano-maggiolo","id":485490,"avatar_url":"https://avatars2.githubusercontent.com/u/485490?v=4","gravatar_id":"","url":"https://api.github.com/users/stefano-maggiolo","html_url":"https://github.com/stefano-maggiolo","followers_url":"https://api.github.com/users/stefano-maggiolo/followers","following_url":"https://api.github.com/users/stefano-maggiolo/following{/other_user}","gists_url":"https://api.github.com/users/stefano-maggiolo/gists{/gist_id}","starred_url":"https://api.github.com/users/stefano-maggiolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefano-maggiolo/subscriptions","organizations_url":"https://api.github.com/users/stefano-maggiolo/orgs","repos_url":"https://api.github.com/users/stefano-maggiolo/repos","events_url":"https://api.github.com/users/stefano-maggiolo/events{/privacy}","received_events_url":"https://api.github.com/users/stefano-maggiolo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-24T15:01:16Z","updated_at":"2018-02-24T17:11:45Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cms-dev/cms/pulls/868","html_url":"https://github.com/cms-dev/cms/pull/868","diff_url":"https://github.com/cms-dev/cms/pull/868.diff","patch_url":"https://github.com/cms-dev/cms/pull/868.patch"},"body":"Similar to Batch, might want to extract some common code later.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cms-dev/cms/868)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cms-dev/cms/issues/comments/368243332","html_url":"https://github.com/cms-dev/cms/pull/868#issuecomment-368243332","issue_url":"https://api.github.com/repos/cms-dev/cms/issues/868","id":368243332,"user":{"login":"stefano-maggiolo","id":485490,"avatar_url":"https://avatars2.githubusercontent.com/u/485490?v=4","gravatar_id":"","url":"https://api.github.com/users/stefano-maggiolo","html_url":"https://github.com/stefano-maggiolo","followers_url":"https://api.github.com/users/stefano-maggiolo/followers","following_url":"https://api.github.com/users/stefano-maggiolo/following{/other_user}","gists_url":"https://api.github.com/users/stefano-maggiolo/gists{/gist_id}","starred_url":"https://api.github.com/users/stefano-maggiolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefano-maggiolo/subscriptions","organizations_url":"https://api.github.com/users/stefano-maggiolo/orgs","repos_url":"https://api.github.com/users/stefano-maggiolo/repos","events_url":"https://api.github.com/users/stefano-maggiolo/events{/privacy}","received_events_url":"https://api.github.com/users/stefano-maggiolo/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T17:11:45Z","updated_at":"2018-02-24T17:11:45Z","author_association":"OWNER","body":"Right, I'll try.\n\n---\n\nReview status: all files reviewed at latest revision, 6 unresolved discussions.\n\n---\n\n*[cms/grading/tasktypes/OutputOnly.py, line 191 at r2](https://reviewable.io:443/reviews/cms-dev/cms/868#-L67LcpN-yCjGaGFrYck:-L67mz0oA-KexG5l5wF_:bgdq6bk) ([raw file](https://github.com/cms-dev/cms/blob/da3bc0a1b93d416c3aae1b791e1843d1242a3008/cms/grading/tasktypes/OutputOnly.py#L191)):*\n<details><summary><i>Previously, lerks (Luca Wehrstedt) wrote…</i></summary><blockquote>\n\nInject constants\n</blockquote></details>\n\nIt's disappearing anyway\n\n---\n\n*[cms/grading/tasktypes/OutputOnly.py, line 149 at r3](https://reviewable.io:443/reviews/cms-dev/cms/868#-L67OlbpiNtDW6u9Ixk2:-L67l9J6kaFNLcW-0VLH:b-896fix) ([raw file](https://github.com/cms-dev/cms/blob/cd3dee101ead5ef8503fc7ceb89edd1c7440077d/cms/grading/tasktypes/OutputOnly.py#L149)):*\n<details><summary><i>Previously, lerks (Luca Wehrstedt) wrote…</i></summary><blockquote>\n\nThis means we're putting the input into the sandbox even when we don't need it (say because we're using white_diff). What's the performance impact of that?\n</blockquote></details>\n\nDone.\n\n---\n\n*[cms/grading/tasktypes/OutputOnly.py, line 152 at r3](https://reviewable.io:443/reviews/cms-dev/cms/868#-L67NzQI3dDQqHXH6Dx2:-L67lM6a9W0pcHWI8-MY:b-896fix) ([raw file](https://github.com/cms-dev/cms/blob/cd3dee101ead5ef8503fc7ceb89edd1c7440077d/cms/grading/tasktypes/OutputOnly.py#L152)):*\n<details><summary><i>Previously, lerks (Luca Wehrstedt) wrote…</i></summary><blockquote>\n\nThis seems the only place you use `output_digest`, you could avoid creating a variable\n</blockquote></details>\n\nDone.\n\n---\n\n*[cms/grading/tasktypes/OutputOnly.py, line 205 at r3](https://reviewable.io:443/reviews/cms-dev/cms/868#-L67P07L1t_6DFWUIVpu:-L67mTM2pI9ZRieiW2jK:bxukraq) ([raw file](https://github.com/cms-dev/cms/blob/cd3dee101ead5ef8503fc7ceb89edd1c7440077d/cms/grading/tasktypes/OutputOnly.py#L205)):*\n<details><summary><i>Previously, lerks (Luca Wehrstedt) wrote…</i></summary><blockquote>\n\nThere wasn't a try before, how come?\n</blockquote></details>\n\nIt's mimicking Batch. Looks sensible to me.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cms-dev/cms/868#-:-L67n0pqQ_3HcVX9vp-Y:b-kh52io)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"stefano-maggiolo"}}