{"action":"created","comment":{"url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/comments/245344358","pull_request_review_id":189429239,"id":245344358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTM0NDM1OA==","diff_hunk":"@@ -5,32 +5,42 @@ Metadata:\n     ParameterGroups:\n       -\n         Label:\n-          default: Project Configuration\n+          default: Project Metadata\n         Parameters:","path":"cloudformation/template.yml","position":6,"original_position":6,"commit_id":"0e96fc10a03567e7621e9cf89e64265506b5e095","original_commit_id":"0e96fc10a03567e7621e9cf89e64265506b5e095","user":{"login":"rbreslow","id":1774125,"node_id":"MDQ6VXNlcjE3NzQxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1774125?v=4","gravatar_id":"","url":"https://api.github.com/users/rbreslow","html_url":"https://github.com/rbreslow","followers_url":"https://api.github.com/users/rbreslow/followers","following_url":"https://api.github.com/users/rbreslow/following{/other_user}","gists_url":"https://api.github.com/users/rbreslow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbreslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbreslow/subscriptions","organizations_url":"https://api.github.com/users/rbreslow/orgs","repos_url":"https://api.github.com/users/rbreslow/repos","events_url":"https://api.github.com/users/rbreslow/events{/privacy}","received_events_url":"https://api.github.com/users/rbreslow/received_events","type":"User","site_admin":false},"body":"Ditto with these threads:\r\n\r\n* https://github.com/azavea/raster-vision-cloudformation/pull/2#discussion_r245341059\r\n* https://github.com/azavea/raster-vision-cloudformation/pull/2#discussion_r245335397","created_at":"2019-01-04T16:16:18Z","updated_at":"2019-01-04T16:17:42Z","html_url":"https://github.com/azavea/raster-vision-cloudformation/pull/6#discussion_r245344358","pull_request_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/comments/245344358"},"html":{"href":"https://github.com/azavea/raster-vision-cloudformation/pull/6#discussion_r245344358"},"pull_request":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6","id":242131047,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTMxMDQ3","html_url":"https://github.com/azavea/raster-vision-cloudformation/pull/6","diff_url":"https://github.com/azavea/raster-vision-cloudformation/pull/6.diff","patch_url":"https://github.com/azavea/raster-vision-cloudformation/pull/6.patch","issue_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/6","number":6,"state":"open","locked":false,"title":"Create Batch resources for CPU jobs and reorder CloudFormation interface","user":{"login":"jeancochrane","id":14170650,"node_id":"MDQ6VXNlcjE0MTcwNjUw","avatar_url":"https://avatars3.githubusercontent.com/u/14170650?v=4","gravatar_id":"","url":"https://api.github.com/users/jeancochrane","html_url":"https://github.com/jeancochrane","followers_url":"https://api.github.com/users/jeancochrane/followers","following_url":"https://api.github.com/users/jeancochrane/following{/other_user}","gists_url":"https://api.github.com/users/jeancochrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jeancochrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeancochrane/subscriptions","organizations_url":"https://api.github.com/users/jeancochrane/orgs","repos_url":"https://api.github.com/users/jeancochrane/repos","events_url":"https://api.github.com/users/jeancochrane/events{/privacy}","received_events_url":"https://api.github.com/users/jeancochrane/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nCreate CPU-enabled Batch resources in the CloudFormation template. In addition, reorder the template interface to make it clearer which parameters are required and which have acceptable defaults.\r\n\r\nCloses https://github.com/azavea/raster-vision-aws/issues/13.\r\n\r\n## Notes\r\n\r\n* Reordering the template interface wasn't part of https://github.com/azavea/raster-vision-aws/issues/13, but in introducing new parameters for the CPU jobs I felt that I was officially overwhelmed with parameters and needed to take a moment to make them clearer.\r\n\r\n## Testing instructions\r\n\r\n- Log into the R&D AWS console\r\n- Navigate to `CloudFormation > Create Stack`\r\n- In the `Choose a template field`, select `Upload a template to Amazon S3` and upload the template in `cloudformation/template.yml`\r\n- Specify the following required parameters:\r\n    - `Stack Name`: Any dummy stack name, e.g. `TestingCloudFormation`\r\n    - `Slug`: A slug of your choosing to namespace the resources, e.g. `foobar`\r\n    - `VPC`: `vpc-074e8ae6256f7c1ca` (the first one on the dropdown)\r\n    - `Subnets`: `subnet-033d2cbe8268c3067` (the first one on the dropdown)\r\n    - `SSH Key Name`: `raster-vision` (doesn't matter unless you want to shell into the instance)\r\n- Accept all default options on the Options screen\r\n- Accept `I acknowledge that AWS CloudFormation might create IAM resources with custom names` on the Review screen\r\n- Create the stack and confirm that it builds correctly\r\n- Navigate to `Batch > Job definitions` and confirm that you have two job definitions, one for CPU and one for GPU\r\n- Navigate to `Batch > Job queues` and confirm that you have two job queues, one for CPU and one for GPU\r\n- Navigate to `Batch > Compute environments` and confirm that you have two compute environments, one for CPU and one for GPU\r\n\r\n","created_at":"2019-01-03T22:40:05Z","updated_at":"2019-01-04T16:17:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf45135569567824ae6494e0247f370e1eb94393","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6/commits","review_comments_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6/comments","review_comment_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/6/comments","statuses_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/statuses/0e96fc10a03567e7621e9cf89e64265506b5e095","head":{"label":"azavea:feature/jfc/cpu-batch-environment","ref":"feature/jfc/cpu-batch-environment","sha":"0e96fc10a03567e7621e9cf89e64265506b5e095","user":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":162179688,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxNzk2ODg=","name":"raster-vision-cloudformation","full_name":"azavea/raster-vision-cloudformation","private":false,"owner":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/azavea/raster-vision-cloudformation","description":"A CloudFormation template for deploying Raster Vision Batch jobs to AWS.","fork":false,"url":"https://api.github.com/repos/azavea/raster-vision-cloudformation","forks_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/forks","keys_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/teams","hooks_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/hooks","issue_events_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/events","assignees_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/tags","blobs_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/languages","stargazers_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/stargazers","contributors_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/contributors","subscribers_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/subscribers","subscription_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/subscription","commits_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/merges","archive_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/downloads","issues_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/labels{/name}","releases_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/deployments","created_at":"2018-12-17T19:27:38Z","updated_at":"2019-01-03T18:45:32Z","pushed_at":"2019-01-04T16:07:25Z","git_url":"git://github.com/azavea/raster-vision-cloudformation.git","ssh_url":"git@github.com:azavea/raster-vision-cloudformation.git","clone_url":"https://github.com/azavea/raster-vision-cloudformation.git","svn_url":"https://github.com/azavea/raster-vision-cloudformation","homepage":"","size":93,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"azavea:feature/jfc/hosted-image-job-def","ref":"feature/jfc/hosted-image-job-def","sha":"cbaa802f9413ed688925e14bd69c52f9bc600a2a","user":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":162179688,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxNzk2ODg=","name":"raster-vision-cloudformation","full_name":"azavea/raster-vision-cloudformation","private":false,"owner":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/azavea/raster-vision-cloudformation","description":"A CloudFormation template for deploying Raster Vision Batch jobs to AWS.","fork":false,"url":"https://api.github.com/repos/azavea/raster-vision-cloudformation","forks_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/forks","keys_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/teams","hooks_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/hooks","issue_events_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/events","assignees_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/tags","blobs_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/languages","stargazers_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/stargazers","contributors_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/contributors","subscribers_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/subscribers","subscription_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/subscription","commits_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/merges","archive_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/downloads","issues_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/labels{/name}","releases_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/raster-vision-cloudformation/deployments","created_at":"2018-12-17T19:27:38Z","updated_at":"2019-01-03T18:45:32Z","pushed_at":"2019-01-04T16:07:25Z","git_url":"git://github.com/azavea/raster-vision-cloudformation.git","ssh_url":"git@github.com:azavea/raster-vision-cloudformation.git","clone_url":"https://github.com/azavea/raster-vision-cloudformation.git","svn_url":"https://github.com/azavea/raster-vision-cloudformation","homepage":"","size":93,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6"},"html":{"href":"https://github.com/azavea/raster-vision-cloudformation/pull/6"},"issue":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/6"},"comments":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/azavea/raster-vision-cloudformation/statuses/0e96fc10a03567e7621e9cf89e64265506b5e095"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rbreslow"}}