{"action":"created","issue":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/15935","repository_url":"https://api.github.com/repos/ionic-team/ionic","labels_url":"https://api.github.com/repos/ionic-team/ionic/issues/15935/labels{/name}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/15935/comments","events_url":"https://api.github.com/repos/ionic-team/ionic/issues/15935/events","html_url":"https://github.com/ionic-team/ionic/issues/15935","id":369633571,"node_id":"MDU6SXNzdWUzNjk2MzM1NzE=","number":15935,"title":"Ionic 4 - Unsubscribe from observables","user":{"login":"jmchaves","id":2567814,"node_id":"MDQ6VXNlcjI1Njc4MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2567814?v=4","gravatar_id":"","url":"https://api.github.com/users/jmchaves","html_url":"https://github.com/jmchaves","followers_url":"https://api.github.com/users/jmchaves/followers","following_url":"https://api.github.com/users/jmchaves/following{/other_user}","gists_url":"https://api.github.com/users/jmchaves/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchaves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchaves/subscriptions","organizations_url":"https://api.github.com/users/jmchaves/orgs","repos_url":"https://api.github.com/users/jmchaves/repos","events_url":"https://api.github.com/users/jmchaves/events{/privacy}","received_events_url":"https://api.github.com/users/jmchaves/received_events","type":"User","site_admin":false},"labels":[{"id":835668554,"node_id":"MDU6TGFiZWw4MzU2Njg1NTQ=","url":"https://api.github.com/repos/ionic-team/ionic/labels/triage","name":"triage","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-10-12T17:02:35Z","updated_at":"2018-10-15T14:09:42Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n# Bug Report\r\n\r\n**Describe the Bug**\r\n\r\nIn ionic 4, what is the way to unsubscribe from observables? In angular this should be in `ngOnDestroy` function, however according with this issue(https://github.com/ionic-team/ionic/issues/15205) the previous page does not trigger it.\r\nhttps://angular.io/guide/lifecycle-hooks#ondestroy\r\n\r\n**Related Code**\r\nhttps://github.com/777wills/destroy-ionicV4\r\n\r\n**Expected Behavior**\r\nUnsubscribe from observables in `ngOnDestroy`.\r\n\r\n**Additional Context**\r\nhttps://github.com/ionic-team/ionic/issues/15205\r\n"},"comment":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/comments/429867264","html_url":"https://github.com/ionic-team/ionic/issues/15935#issuecomment-429867264","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/15935","id":429867264,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTg2NzI2NA==","user":{"login":"jmchaves","id":2567814,"node_id":"MDQ6VXNlcjI1Njc4MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2567814?v=4","gravatar_id":"","url":"https://api.github.com/users/jmchaves","html_url":"https://github.com/jmchaves","followers_url":"https://api.github.com/users/jmchaves/followers","following_url":"https://api.github.com/users/jmchaves/following{/other_user}","gists_url":"https://api.github.com/users/jmchaves/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchaves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchaves/subscriptions","organizations_url":"https://api.github.com/users/jmchaves/orgs","repos_url":"https://api.github.com/users/jmchaves/repos","events_url":"https://api.github.com/users/jmchaves/events{/privacy}","received_events_url":"https://api.github.com/users/jmchaves/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T14:09:42Z","updated_at":"2018-10-15T14:09:42Z","author_association":"NONE","body":"@captaincaius I agree with you. And definitely this is an ionic router issue.  "}}
{"actor":{"display_login":"jmchaves"}}