{"action":"created","issue":{"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/1293","repository_url":"https://api.github.com/repos/canonical-websites/snapcraft.io","labels_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/1293/labels{/name}","comments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/1293/comments","events_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/1293/events","html_url":"https://github.com/canonical-websites/snapcraft.io/pull/1293","id":379780571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTM3MTgy","number":1293,"title":"Return last cached api call on error","user":{"login":"tbille","id":2707508,"node_id":"MDQ6VXNlcjI3MDc1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"labels":[{"id":698999577,"node_id":"MDU6TGFiZWw2OTg5OTk1Nzc=","url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels/Review:%20Code%20needed","name":"Review: Code needed","color":"cdcdcd","default":false},{"id":698999584,"node_id":"MDU6TGFiZWw2OTg5OTk1ODQ=","url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels/Review:%20QA%20needed","name":"Review: QA needed","color":"cdcdcd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-12T13:38:19Z","updated_at":"2018-11-12T13:39:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/1293","html_url":"https://github.com/canonical-websites/snapcraft.io/pull/1293","diff_url":"https://github.com/canonical-websites/snapcraft.io/pull/1293.diff","patch_url":"https://github.com/canonical-websites/snapcraft.io/pull/1293.patch"},"body":"# Summary\r\n\r\nFixes #1233 \r\nOn error return last cached api call\r\n\r\n# QA\r\n\r\n- `./run`\r\n- http://localhost:8004/toto\r\n- Disconnect from internet\r\n- http://localhost:8004/toto\r\n- Page should still show (without any images)\r\n- After 5 minutes (time for cache to expire) http://localhost:8004/toto\r\n- Page should still be accessible"},"comment":{"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/comments/437883448","html_url":"https://github.com/canonical-websites/snapcraft.io/pull/1293#issuecomment-437883448","issue_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/1293","id":437883448,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzg4MzQ0OA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T13:39:11Z","updated_at":"2018-11-12T13:39:11Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293?src=pr&el=h1) Report\n> Merging [#1293](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293?src=pr&el=desc) into [master](https://codecov.io/gh/canonical-websites/snapcraft.io/commit/76ac1a1bdad24f45e177a91b628cb58132d059f5?src=pr&el=desc) will **decrease** coverage by `1.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/graphs/tree.svg?width=650&token=OYlcY12Ia5&height=150&src=pr)](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1293      +/-   ##\n==========================================\n- Coverage   86.06%   85.05%   -1.02%     \n==========================================\n  Files          56       53       -3     \n  Lines        3660     3445     -215     \n==========================================\n- Hits         3150     2930     -220     \n- Misses        510      515       +5\n```\n\n\n| [Impacted Files](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [webapp/api/requests.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-d2ViYXBwL2FwaS9yZXF1ZXN0cy5weQ==) | `95.74% <ø> (ø)` | :arrow_up: |\n| [webapp/first\\_snap/views.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-d2ViYXBwL2ZpcnN0X3NuYXAvdmlld3MucHk=) | `56.25% <0%> (-42.17%)` | :arrow_down: |\n| [webapp/publisher/snaps/views.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-d2ViYXBwL3B1Ymxpc2hlci9zbmFwcy92aWV3cy5weQ==) | `87.36% <0%> (-0.47%)` | :arrow_down: |\n| [tests/publisher/snaps/tests\\_listing.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-dGVzdHMvcHVibGlzaGVyL3NuYXBzL3Rlc3RzX2xpc3RpbmcucHk=) | `98.43% <0%> (-0.05%)` | :arrow_down: |\n| [tests/publisher/tests\\_account\\_snaps.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-dGVzdHMvcHVibGlzaGVyL3Rlc3RzX2FjY291bnRfc25hcHMucHk=) | `98.87% <0%> (-0.02%)` | :arrow_down: |\n| [tests/first\\_snap/tests\\_views.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-dGVzdHMvZmlyc3Rfc25hcC90ZXN0c192aWV3cy5weQ==) | | |\n| [tests/publisher/tests\\_api\\_snaps.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-dGVzdHMvcHVibGlzaGVyL3Rlc3RzX2FwaV9zbmFwcy5weQ==) | | |\n| [webapp/first\\_snap/logic.py](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293/diff?src=pr&el=tree#diff-d2ViYXBwL2ZpcnN0X3NuYXAvbG9naWMucHk=) | | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293?src=pr&el=footer). Last update [76ac1a1...1a80795](https://codecov.io/gh/canonical-websites/snapcraft.io/pull/1293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}