{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments/195085475","pull_request_review_id":128375334,"id":195085475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTA4NTQ3NQ==","diff_hunk":"@@ -43,6 +48,11 @@ shadowJar {\n     classifier 'thrift92'\n }\n \n+shadowJar {","path":"jaeger-thrift/build.gradle","position":19,"original_position":19,"commit_id":"b25787dcb0d75b76c48736e189749aa38b37b876","original_commit_id":"b25787dcb0d75b76c48736e189749aa38b37b876","user":{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"Don't we just want the single shaded jar, with the dependencies relocated?","created_at":"2018-06-13T13:41:53Z","updated_at":"2018-06-13T13:45:21Z","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/449#discussion_r195085475","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments/195085475"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-java/pull/449#discussion_r195085475"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449","id":194580679,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTgwNjc5","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/449","diff_url":"https://github.com/jaegertracing/jaeger-client-java/pull/449.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-java/pull/449.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/449","number":449,"state":"open","locked":false,"title":"Remove dependency from jaeger-core to jaeger-thrift","user":{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"body":"Resolves #448 - This PR removes the dependency from jaeger-core to jaeger-thrift by loading\r\nthe appropriate Sender via either environment variables or based on existing service providers\r\non the classpath, loaded via ServiceLoader.\r\n\r\nSigned-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>","created_at":"2018-06-13T13:09:22Z","updated_at":"2018-06-13T13:45:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb1474de8ee4d80d3bc01bec83e056ef85f0a6c","assignee":{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"assignees":[{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":711415642,"node_id":"MDU6TGFiZWw3MTE0MTU2NDI=","url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/449/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/statuses/b25787dcb0d75b76c48736e189749aa38b37b876","head":{"label":"jpkrohling:448-RemoveDependencyFromCoreToThrift","ref":"448-RemoveDependencyFromCoreToThrift","sha":"b25787dcb0d75b76c48736e189749aa38b37b876","user":{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"repo":{"id":87573232,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MzIzMg==","name":"jaeger-client-java","full_name":"jpkrohling/jaeger-client-java","owner":{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpkrohling/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":true,"url":"https://api.github.com/repos/jpkrohling/jaeger-client-java","forks_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/jpkrohling/jaeger-client-java/deployments","created_at":"2017-04-07T18:02:08Z","updated_at":"2018-06-13T09:25:36Z","pushed_at":"2018-06-13T13:08:30Z","git_url":"git://github.com/jpkrohling/jaeger-client-java.git","ssh_url":"git@github.com:jpkrohling/jaeger-client-java.git","clone_url":"https://github.com/jpkrohling/jaeger-client-java.git","svn_url":"https://github.com/jpkrohling/jaeger-client-java","homepage":"http://uber.github.io/jaeger/","size":1788,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"808d6cc7d45021f32820538cd474abd9d28c023e","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56551000,"node_id":"MDEwOlJlcG9zaXRvcnk1NjU1MTAwMA==","name":"jaeger-client-java","full_name":"jaegertracing/jaeger-client-java","owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/deployments","created_at":"2016-04-19T00:10:02Z","updated_at":"2018-06-12T07:59:48Z","pushed_at":"2018-06-13T13:09:23Z","git_url":"git://github.com/jaegertracing/jaeger-client-java.git","ssh_url":"git@github.com:jaegertracing/jaeger-client-java.git","clone_url":"https://github.com/jaegertracing/jaeger-client-java.git","svn_url":"https://github.com/jaegertracing/jaeger-client-java","homepage":"https://jaegertracing.io/","size":1511,"stargazers_count":164,"watchers_count":164,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":73,"open_issues":42,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-java/pull/449"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/449"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/statuses/b25787dcb0d75b76c48736e189749aa38b37b876"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"objectiser"}}