{"action":"created","comment":{"url":"https://api.github.com/repos/CTPPS/cmssw/pulls/comments/239999480","pull_request_review_id":182938694,"id":239999480,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk5OTQ4MA==","diff_hunk":"@@ -21,22 +21,33 @@ namespace reco\n     public:\n       /// Default constructor\n       ProtonTrack();\n-      /// Constructor from refit parameters, fitted vertex and direction, and longitudinal fractional momentum loss\n-      ProtonTrack( double chi2, double ndof, const Point& vtx, const Vector& dir, float xi, const CovarianceMatrix& cov = CovarianceMatrix() );\n+\n+      /// Constructor from refit parameters, fitted vertex and momentum, and longitudinal fractional momentum loss\n+      ProtonTrack( double chi2, double ndof, const Point& vtx, const Vector& momentum, float xi, const CovarianceMatrix& cov = CovarianceMatrix() );\n \n       /// Indices to the covariance matrix\n+      // TODO: what is num_indeces, where used ??\n+      // TODO: add (formally) also vtx_x ?? the base class defines dimension = 5","path":"DataFormats/ProtonReco/interface/ProtonTrack.h","position":12,"original_position":12,"commit_id":"d1b347f13f34b982e5c172dfe5ff5b7d98cbcea7","original_commit_id":"d1b347f13f34b982e5c172dfe5ff5b7d98cbcea7","user":{"login":"forthommel","id":330969,"node_id":"MDQ6VXNlcjMzMDk2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/330969?v=4","gravatar_id":"","url":"https://api.github.com/users/forthommel","html_url":"https://github.com/forthommel","followers_url":"https://api.github.com/users/forthommel/followers","following_url":"https://api.github.com/users/forthommel/following{/other_user}","gists_url":"https://api.github.com/users/forthommel/gists{/gist_id}","starred_url":"https://api.github.com/users/forthommel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forthommel/subscriptions","organizations_url":"https://api.github.com/users/forthommel/orgs","repos_url":"https://api.github.com/users/forthommel/repos","events_url":"https://api.github.com/users/forthommel/events{/privacy}","received_events_url":"https://api.github.com/users/forthommel/received_events","type":"User","site_admin":false},"body":"Indeed, we can store whatever other element we want (only one, though... unless we break the inheritance from `reco::Track`)","created_at":"2018-12-08T09:34:15Z","updated_at":"2018-12-08T09:34:15Z","html_url":"https://github.com/CTPPS/cmssw/pull/33#discussion_r239999480","pull_request_url":"https://api.github.com/repos/CTPPS/cmssw/pulls/33","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CTPPS/cmssw/pulls/comments/239999480"},"html":{"href":"https://github.com/CTPPS/cmssw/pull/33#discussion_r239999480"},"pull_request":{"href":"https://api.github.com/repos/CTPPS/cmssw/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/CTPPS/cmssw/pulls/33","id":236996230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTk2MjMw","html_url":"https://github.com/CTPPS/cmssw/pull/33","diff_url":"https://github.com/CTPPS/cmssw/pull/33.diff","patch_url":"https://github.com/CTPPS/cmssw/pull/33.patch","issue_url":"https://api.github.com/repos/CTPPS/cmssw/issues/33","number":33,"state":"open","locked":false,"title":"Reconstruction chain","user":{"login":"jan-kaspar","id":17830858,"node_id":"MDQ6VXNlcjE3ODMwODU4","avatar_url":"https://avatars0.githubusercontent.com/u/17830858?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-kaspar","html_url":"https://github.com/jan-kaspar","followers_url":"https://api.github.com/users/jan-kaspar/followers","following_url":"https://api.github.com/users/jan-kaspar/following{/other_user}","gists_url":"https://api.github.com/users/jan-kaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-kaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-kaspar/subscriptions","organizations_url":"https://api.github.com/users/jan-kaspar/orgs","repos_url":"https://api.github.com/users/jan-kaspar/repos","events_url":"https://api.github.com/users/jan-kaspar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-kaspar/received_events","type":"User","site_admin":false},"body":"Added the principal elements of the reconstruction chain. Checked by comparing to the \"initial\" branch results for few events.\r\n\r\nNext steps\r\n  * fill properly the reco::ProtonTrack - waiting for the example from @forthommel \r\n  * finalise the direct simulation - waiting for the ES source from @wpcarvalho \r\n  * import validation modules, do validation\r\n  * code finetuning, e.g. printf --> LogXYZ","created_at":"2018-12-07T21:18:00Z","updated_at":"2018-12-08T09:34:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90b4202f2050eec12409cd6d50bc6b0c61a12ef0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CTPPS/cmssw/pulls/33/commits","review_comments_url":"https://api.github.com/repos/CTPPS/cmssw/pulls/33/comments","review_comment_url":"https://api.github.com/repos/CTPPS/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CTPPS/cmssw/issues/33/comments","statuses_url":"https://api.github.com/repos/CTPPS/cmssw/statuses/d1b347f13f34b982e5c172dfe5ff5b7d98cbcea7","head":{"label":"jan-kaspar:PR_RE_reconstruction","ref":"PR_RE_reconstruction","sha":"d1b347f13f34b982e5c172dfe5ff5b7d98cbcea7","user":{"login":"jan-kaspar","id":17830858,"node_id":"MDQ6VXNlcjE3ODMwODU4","avatar_url":"https://avatars0.githubusercontent.com/u/17830858?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-kaspar","html_url":"https://github.com/jan-kaspar","followers_url":"https://api.github.com/users/jan-kaspar/followers","following_url":"https://api.github.com/users/jan-kaspar/following{/other_user}","gists_url":"https://api.github.com/users/jan-kaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-kaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-kaspar/subscriptions","organizations_url":"https://api.github.com/users/jan-kaspar/orgs","repos_url":"https://api.github.com/users/jan-kaspar/repos","events_url":"https://api.github.com/users/jan-kaspar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-kaspar/received_events","type":"User","site_admin":false},"repo":{"id":95438478,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzODQ3OA==","name":"cmssw","full_name":"jan-kaspar/cmssw","private":false,"owner":{"login":"jan-kaspar","id":17830858,"node_id":"MDQ6VXNlcjE3ODMwODU4","avatar_url":"https://avatars0.githubusercontent.com/u/17830858?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-kaspar","html_url":"https://github.com/jan-kaspar","followers_url":"https://api.github.com/users/jan-kaspar/followers","following_url":"https://api.github.com/users/jan-kaspar/following{/other_user}","gists_url":"https://api.github.com/users/jan-kaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-kaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-kaspar/subscriptions","organizations_url":"https://api.github.com/users/jan-kaspar/orgs","repos_url":"https://api.github.com/users/jan-kaspar/repos","events_url":"https://api.github.com/users/jan-kaspar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-kaspar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jan-kaspar/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/jan-kaspar/cmssw","forks_url":"https://api.github.com/repos/jan-kaspar/cmssw/forks","keys_url":"https://api.github.com/repos/jan-kaspar/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jan-kaspar/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jan-kaspar/cmssw/teams","hooks_url":"https://api.github.com/repos/jan-kaspar/cmssw/hooks","issue_events_url":"https://api.github.com/repos/jan-kaspar/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/jan-kaspar/cmssw/events","assignees_url":"https://api.github.com/repos/jan-kaspar/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/jan-kaspar/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/jan-kaspar/cmssw/tags","blobs_url":"https://api.github.com/repos/jan-kaspar/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jan-kaspar/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jan-kaspar/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/jan-kaspar/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jan-kaspar/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/jan-kaspar/cmssw/languages","stargazers_url":"https://api.github.com/repos/jan-kaspar/cmssw/stargazers","contributors_url":"https://api.github.com/repos/jan-kaspar/cmssw/contributors","subscribers_url":"https://api.github.com/repos/jan-kaspar/cmssw/subscribers","subscription_url":"https://api.github.com/repos/jan-kaspar/cmssw/subscription","commits_url":"https://api.github.com/repos/jan-kaspar/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/jan-kaspar/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/jan-kaspar/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/jan-kaspar/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/jan-kaspar/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/jan-kaspar/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jan-kaspar/cmssw/merges","archive_url":"https://api.github.com/repos/jan-kaspar/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jan-kaspar/cmssw/downloads","issues_url":"https://api.github.com/repos/jan-kaspar/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/jan-kaspar/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/jan-kaspar/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/jan-kaspar/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jan-kaspar/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/jan-kaspar/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/jan-kaspar/cmssw/deployments","created_at":"2017-06-26T11:11:22Z","updated_at":"2017-06-26T11:15:13Z","pushed_at":"2018-12-07T21:11:25Z","git_url":"git://github.com/jan-kaspar/cmssw.git","ssh_url":"git@github.com:jan-kaspar/cmssw.git","clone_url":"https://github.com/jan-kaspar/cmssw.git","svn_url":"https://github.com/jan-kaspar/cmssw","homepage":"http://cms-sw.github.io/","size":1032238,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CTPPS:proton_reco_10_4_X","ref":"proton_reco_10_4_X","sha":"d23d6758a7749bc97406a0ab76b32aef24020154","user":{"login":"CTPPS","id":10438249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDM4MjQ5","avatar_url":"https://avatars3.githubusercontent.com/u/10438249?v=4","gravatar_id":"","url":"https://api.github.com/users/CTPPS","html_url":"https://github.com/CTPPS","followers_url":"https://api.github.com/users/CTPPS/followers","following_url":"https://api.github.com/users/CTPPS/following{/other_user}","gists_url":"https://api.github.com/users/CTPPS/gists{/gist_id}","starred_url":"https://api.github.com/users/CTPPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CTPPS/subscriptions","organizations_url":"https://api.github.com/users/CTPPS/orgs","repos_url":"https://api.github.com/users/CTPPS/repos","events_url":"https://api.github.com/users/CTPPS/events{/privacy}","received_events_url":"https://api.github.com/users/CTPPS/received_events","type":"Organization","site_admin":false},"repo":{"id":54034430,"node_id":"MDEwOlJlcG9zaXRvcnk1NDAzNDQzMA==","name":"cmssw","full_name":"CTPPS/cmssw","private":false,"owner":{"login":"CTPPS","id":10438249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDM4MjQ5","avatar_url":"https://avatars3.githubusercontent.com/u/10438249?v=4","gravatar_id":"","url":"https://api.github.com/users/CTPPS","html_url":"https://github.com/CTPPS","followers_url":"https://api.github.com/users/CTPPS/followers","following_url":"https://api.github.com/users/CTPPS/following{/other_user}","gists_url":"https://api.github.com/users/CTPPS/gists{/gist_id}","starred_url":"https://api.github.com/users/CTPPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CTPPS/subscriptions","organizations_url":"https://api.github.com/users/CTPPS/orgs","repos_url":"https://api.github.com/users/CTPPS/repos","events_url":"https://api.github.com/users/CTPPS/events{/privacy}","received_events_url":"https://api.github.com/users/CTPPS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CTPPS/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/CTPPS/cmssw","forks_url":"https://api.github.com/repos/CTPPS/cmssw/forks","keys_url":"https://api.github.com/repos/CTPPS/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CTPPS/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CTPPS/cmssw/teams","hooks_url":"https://api.github.com/repos/CTPPS/cmssw/hooks","issue_events_url":"https://api.github.com/repos/CTPPS/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/CTPPS/cmssw/events","assignees_url":"https://api.github.com/repos/CTPPS/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/CTPPS/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/CTPPS/cmssw/tags","blobs_url":"https://api.github.com/repos/CTPPS/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CTPPS/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CTPPS/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/CTPPS/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CTPPS/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/CTPPS/cmssw/languages","stargazers_url":"https://api.github.com/repos/CTPPS/cmssw/stargazers","contributors_url":"https://api.github.com/repos/CTPPS/cmssw/contributors","subscribers_url":"https://api.github.com/repos/CTPPS/cmssw/subscribers","subscription_url":"https://api.github.com/repos/CTPPS/cmssw/subscription","commits_url":"https://api.github.com/repos/CTPPS/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/CTPPS/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/CTPPS/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/CTPPS/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/CTPPS/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/CTPPS/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CTPPS/cmssw/merges","archive_url":"https://api.github.com/repos/CTPPS/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CTPPS/cmssw/downloads","issues_url":"https://api.github.com/repos/CTPPS/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/CTPPS/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/CTPPS/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/CTPPS/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CTPPS/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/CTPPS/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/CTPPS/cmssw/deployments","created_at":"2016-03-16T13:32:05Z","updated_at":"2018-08-28T16:51:36Z","pushed_at":"2018-12-07T21:23:20Z","git_url":"git://github.com/CTPPS/cmssw.git","ssh_url":"git@github.com:CTPPS/cmssw.git","clone_url":"https://github.com/CTPPS/cmssw.git","svn_url":"https://github.com/CTPPS/cmssw","homepage":"http://cms-sw.github.io/","size":1056706,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":4,"open_issues":13,"watchers":1,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/CTPPS/cmssw/pulls/33"},"html":{"href":"https://github.com/CTPPS/cmssw/pull/33"},"issue":{"href":"https://api.github.com/repos/CTPPS/cmssw/issues/33"},"comments":{"href":"https://api.github.com/repos/CTPPS/cmssw/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/CTPPS/cmssw/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/CTPPS/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CTPPS/cmssw/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/CTPPS/cmssw/statuses/d1b347f13f34b982e5c172dfe5ff5b7d98cbcea7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"forthommel"}}