{"push_id":2980945383,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"b22957261c9618ec62907b0242a7576ccfee4970","before":"879802a3a157f27b822b4d4eaccca475a423070b","commits":[{"sha":"b22957261c9618ec62907b0242a7576ccfee4970","author":{"name":"Alan Shaw","email":"236b909a1fe9fe7537305bfee56984291246badd@protocol.ai"},"message":"refactor: remove maxBytes restriction (#1645)\n\nWeirdly we're not seeing this when using Node.js - it only happens in the browser.\r\n\r\nMy _guess_ is that [`maxBytes`](https://github.com/hapijs/hapi/blob/1c9a4f3d7c8cd583650292f4284c87ac5b935107/API.md#-routeoptionspayloadmaxbytes) is actually the max bytes allowed for a given chunk and that in Node.js the underlying stream implementation chunks up the chunks you pass to it even if you only write a single huge chunk. In the browser we know that `stream-http` buffers up all the data and sends it in one go so perhaps that is what is happening.\r\n\r\nAnyway, the test in the PR using `inject` proves that with a single buffer we can get a `413` (payload too large) for any request over 1024 * 1024 bytes.\r\n\r\nThis is feature compatible with go-ipfs which has no such limit.\r\n\r\nfixes #1638\r\nrefs https://github.com/ipfs-shipyard/ipfs-webui/issues/858\r\n\r\nLicense: MIT\r\nSigned-off-by: Alan Shaw <alan.shaw@protocol.ai>","distinct":true,"url":"https://api.github.com/repos/xpucadad/js-ipfs/commits/b22957261c9618ec62907b0242a7576ccfee4970"}]}
{"actor":{"display_login":"xpucadad"}}