{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/15896","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/15896/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/15896/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/15896/events","html_url":"https://github.com/grpc/grpc/pull/15896","id":336358778,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODMwODMz","number":15896,"title":"Refactor resolver result callback","user":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-06-27T19:31:50Z","updated_at":"2018-07-03T17:13:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/15896","html_url":"https://github.com/grpc/grpc/pull/15896","diff_url":"https://github.com/grpc/grpc/pull/15896.diff","patch_url":"https://github.com/grpc/grpc/pull/15896.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/grpc/grpc/15896)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/402229755","html_url":"https://github.com/grpc/grpc/pull/15896#issuecomment-402229755","issue_url":"https://api.github.com/repos/grpc/grpc/issues/15896","id":402229755,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjIyOTc1NQ==","user":{"login":"ejona86","id":2811396,"node_id":"MDQ6VXNlcjI4MTEzOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T17:13:24Z","updated_at":"2018-07-03T17:13:24Z","author_association":"MEMBER","body":"> which is when we get a valid resolver result but fail to create the new LB policy for some reason.\r\n\r\n... like what sort of reason? Generally, for us failing to create a LB policy is a \"very bad thing\" and we go into a \"we are very broken; kill RPCs, forever\" state.\r\n\r\nDo you mean the service config chose a non-existent LB policy? That would have to happen before the discussed failure, in Java, as the resolver can only return a service config on success."}}
{"actor":{"display_login":"ejona86"}}