{"action":"created","comment":{"url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments/203499453","pull_request_review_id":138396694,"id":203499453,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ5OTQ1Mw==","diff_hunk":"@@ -0,0 +1,57 @@\n+import numpy as np\n+from numpy.testing import assert_array_almost_equal","path":"testsuite/MDAnalysisTests/analysis/test_dihedrals.py","position":2,"original_position":2,"commit_id":"ad4e598f1500464fe69b049663344931f25b4102","original_commit_id":"ad4e598f1500464fe69b049663344931f25b4102","user":{"login":"kain88-de","id":4302678,"node_id":"MDQ6VXNlcjQzMDI2Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4302678?v=4","gravatar_id":"","url":"https://api.github.com/users/kain88-de","html_url":"https://github.com/kain88-de","followers_url":"https://api.github.com/users/kain88-de/followers","following_url":"https://api.github.com/users/kain88-de/following{/other_user}","gists_url":"https://api.github.com/users/kain88-de/gists{/gist_id}","starred_url":"https://api.github.com/users/kain88-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kain88-de/subscriptions","organizations_url":"https://api.github.com/users/kain88-de/orgs","repos_url":"https://api.github.com/users/kain88-de/repos","events_url":"https://api.github.com/users/kain88-de/events{/privacy}","received_events_url":"https://api.github.com/users/kain88-de/received_events","type":"User","site_admin":false},"body":"please use `assert_almost_equal`. It does some more equality checks then `assert_array_almost_equal`","created_at":"2018-07-18T19:21:20Z","updated_at":"2018-07-18T19:25:13Z","html_url":"https://github.com/MDAnalysis/mdanalysis/pull/1997#discussion_r203499453","pull_request_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments/203499453"},"html":{"href":"https://github.com/MDAnalysis/mdanalysis/pull/1997#discussion_r203499453"},"pull_request":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997"}}},"pull_request":{"url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997","id":202346086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzQ2MDg2","html_url":"https://github.com/MDAnalysis/mdanalysis/pull/1997","diff_url":"https://github.com/MDAnalysis/mdanalysis/pull/1997.diff","patch_url":"https://github.com/MDAnalysis/mdanalysis/pull/1997.patch","issue_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1997","number":1997,"state":"open","locked":false,"title":"New Dihedral and Ramachandran Analysis","user":{"login":"hfmull","id":39925654,"node_id":"MDQ6VXNlcjM5OTI1NjU0","avatar_url":"https://avatars0.githubusercontent.com/u/39925654?v=4","gravatar_id":"","url":"https://api.github.com/users/hfmull","html_url":"https://github.com/hfmull","followers_url":"https://api.github.com/users/hfmull/followers","following_url":"https://api.github.com/users/hfmull/following{/other_user}","gists_url":"https://api.github.com/users/hfmull/gists{/gist_id}","starred_url":"https://api.github.com/users/hfmull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hfmull/subscriptions","organizations_url":"https://api.github.com/users/hfmull/orgs","repos_url":"https://api.github.com/users/hfmull/repos","events_url":"https://api.github.com/users/hfmull/events{/privacy}","received_events_url":"https://api.github.com/users/hfmull/received_events","type":"User","site_admin":false},"body":"Changes made in this Pull Request:\r\n - added new MDAnalysis.analysis.dihedrals module\r\n - use AnalysisBase for new Ramachandran class\r\n - new dihedrals_calc function \r\n\r\n\r\nPR Checklist\r\n------------\r\n - [x] Tests?\r\n - [ ] Docs?\r\n - [ ] CHANGELOG updated?\r\n - [n/a] Issue raised/referenced?\r\n","created_at":"2018-07-18T18:48:52Z","updated_at":"2018-07-18T19:25:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1b2da8d61074e2168f755d8284d7fa09532537f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997/commits","review_comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997/comments","review_comment_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1997/comments","statuses_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/ad4e598f1500464fe69b049663344931f25b4102","head":{"label":"hfmull:dihedrals","ref":"dihedrals","sha":"ad4e598f1500464fe69b049663344931f25b4102","user":{"login":"hfmull","id":39925654,"node_id":"MDQ6VXNlcjM5OTI1NjU0","avatar_url":"https://avatars0.githubusercontent.com/u/39925654?v=4","gravatar_id":"","url":"https://api.github.com/users/hfmull","html_url":"https://github.com/hfmull","followers_url":"https://api.github.com/users/hfmull/followers","following_url":"https://api.github.com/users/hfmull/following{/other_user}","gists_url":"https://api.github.com/users/hfmull/gists{/gist_id}","starred_url":"https://api.github.com/users/hfmull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hfmull/subscriptions","organizations_url":"https://api.github.com/users/hfmull/orgs","repos_url":"https://api.github.com/users/hfmull/repos","events_url":"https://api.github.com/users/hfmull/events{/privacy}","received_events_url":"https://api.github.com/users/hfmull/received_events","type":"User","site_admin":false},"repo":{"id":140338975,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMzg5NzU=","name":"mdanalysis","full_name":"hfmull/mdanalysis","owner":{"login":"hfmull","id":39925654,"node_id":"MDQ6VXNlcjM5OTI1NjU0","avatar_url":"https://avatars0.githubusercontent.com/u/39925654?v=4","gravatar_id":"","url":"https://api.github.com/users/hfmull","html_url":"https://github.com/hfmull","followers_url":"https://api.github.com/users/hfmull/followers","following_url":"https://api.github.com/users/hfmull/following{/other_user}","gists_url":"https://api.github.com/users/hfmull/gists{/gist_id}","starred_url":"https://api.github.com/users/hfmull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hfmull/subscriptions","organizations_url":"https://api.github.com/users/hfmull/orgs","repos_url":"https://api.github.com/users/hfmull/repos","events_url":"https://api.github.com/users/hfmull/events{/privacy}","received_events_url":"https://api.github.com/users/hfmull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hfmull/mdanalysis","description":"MDAnalysis is a Python library to analyze molecular dynamics trajectories.","fork":true,"url":"https://api.github.com/repos/hfmull/mdanalysis","forks_url":"https://api.github.com/repos/hfmull/mdanalysis/forks","keys_url":"https://api.github.com/repos/hfmull/mdanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hfmull/mdanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hfmull/mdanalysis/teams","hooks_url":"https://api.github.com/repos/hfmull/mdanalysis/hooks","issue_events_url":"https://api.github.com/repos/hfmull/mdanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/hfmull/mdanalysis/events","assignees_url":"https://api.github.com/repos/hfmull/mdanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/hfmull/mdanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/hfmull/mdanalysis/tags","blobs_url":"https://api.github.com/repos/hfmull/mdanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hfmull/mdanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hfmull/mdanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/hfmull/mdanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hfmull/mdanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/hfmull/mdanalysis/languages","stargazers_url":"https://api.github.com/repos/hfmull/mdanalysis/stargazers","contributors_url":"https://api.github.com/repos/hfmull/mdanalysis/contributors","subscribers_url":"https://api.github.com/repos/hfmull/mdanalysis/subscribers","subscription_url":"https://api.github.com/repos/hfmull/mdanalysis/subscription","commits_url":"https://api.github.com/repos/hfmull/mdanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/hfmull/mdanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/hfmull/mdanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/hfmull/mdanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/hfmull/mdanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/hfmull/mdanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hfmull/mdanalysis/merges","archive_url":"https://api.github.com/repos/hfmull/mdanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hfmull/mdanalysis/downloads","issues_url":"https://api.github.com/repos/hfmull/mdanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/hfmull/mdanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/hfmull/mdanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/hfmull/mdanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hfmull/mdanalysis/labels{/name}","releases_url":"https://api.github.com/repos/hfmull/mdanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/hfmull/mdanalysis/deployments","created_at":"2018-07-09T20:31:13Z","updated_at":"2018-07-12T21:07:13Z","pushed_at":"2018-07-18T17:37:27Z","git_url":"git://github.com/hfmull/mdanalysis.git","ssh_url":"git@github.com:hfmull/mdanalysis.git","clone_url":"https://github.com/hfmull/mdanalysis.git","svn_url":"https://github.com/hfmull/mdanalysis","homepage":"https://mdanalysis.org","size":203303,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MDAnalysis:develop","ref":"develop","sha":"d7cfc27978a8104c17340eac8339560eabde15c6","user":{"login":"MDAnalysis","id":11445951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDQ1OTUx","avatar_url":"https://avatars1.githubusercontent.com/u/11445951?v=4","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"repo":{"id":33389183,"node_id":"MDEwOlJlcG9zaXRvcnkzMzM4OTE4Mw==","name":"mdanalysis","full_name":"MDAnalysis/mdanalysis","owner":{"login":"MDAnalysis","id":11445951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDQ1OTUx","avatar_url":"https://avatars1.githubusercontent.com/u/11445951?v=4","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MDAnalysis/mdanalysis","description":"MDAnalysis is a Python library to analyze molecular dynamics trajectories.","fork":false,"url":"https://api.github.com/repos/MDAnalysis/mdanalysis","forks_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/forks","keys_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/teams","hooks_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/hooks","issue_events_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/events","assignees_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/tags","blobs_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/languages","stargazers_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/stargazers","contributors_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/contributors","subscribers_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/subscribers","subscription_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/subscription","commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/merges","archive_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/downloads","issues_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/labels{/name}","releases_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/deployments","created_at":"2015-04-04T00:39:41Z","updated_at":"2018-07-17T22:31:33Z","pushed_at":"2018-07-18T19:23:50Z","git_url":"git://github.com/MDAnalysis/mdanalysis.git","ssh_url":"git@github.com:MDAnalysis/mdanalysis.git","clone_url":"https://github.com/MDAnalysis/mdanalysis.git","svn_url":"https://github.com/MDAnalysis/mdanalysis","homepage":"https://mdanalysis.org","size":203530,"stargazers_count":216,"watchers_count":216,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":128,"open_issues":177,"watchers":216,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997"},"html":{"href":"https://github.com/MDAnalysis/mdanalysis/pull/1997"},"issue":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1997"},"comments":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1997/comments"},"review_comments":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997/comments"},"review_comment":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1997/commits"},"statuses":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/ad4e598f1500464fe69b049663344931f25b4102"}},"author_association":"NONE"}}
{"actor":{"display_login":"kain88-de"}}