{"action":"created","issue":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/2533","repository_url":"https://api.github.com/repos/rstudio/rstudio","labels_url":"https://api.github.com/repos/rstudio/rstudio/issues/2533/labels{/name}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/2533/comments","events_url":"https://api.github.com/repos/rstudio/rstudio/issues/2533/events","html_url":"https://github.com/rstudio/rstudio/pull/2533","id":309568661,"number":2533,"title":"clamp htmlwidget height; tweak propagation of wheel events","user":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars1.githubusercontent.com/u/1976582?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-28T23:31:47Z","updated_at":"2018-03-29T17:13:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/2533","html_url":"https://github.com/rstudio/rstudio/pull/2533","diff_url":"https://github.com/rstudio/rstudio/pull/2533.diff","patch_url":"https://github.com/rstudio/rstudio/pull/2533.patch"},"body":"Closes https://github.com/rstudio/rstudio/issues/2174.\r\n\r\nNote that this does tweak the scroll behavior for HTML widgets in Notebooks: widgets no longer unilaterally propagate wheel events; rather, they only propagate them when they have reached their scroll bounds and cannot be scrolled anymore.\r\n\r\n(I initially wanted to test this by looking at e.g. the height of the iframe, but that was always reported as 0 -- or perhaps I'm misunderstanding some interplay between how an iframe's scroll position is reported)"},"comment":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/comments/377306425","html_url":"https://github.com/rstudio/rstudio/pull/2533#issuecomment-377306425","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/2533","id":377306425,"user":{"login":"rstudio-build","id":514685,"avatar_url":"https://avatars1.githubusercontent.com/u/514685?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio-build","html_url":"https://github.com/rstudio-build","followers_url":"https://api.github.com/users/rstudio-build/followers","following_url":"https://api.github.com/users/rstudio-build/following{/other_user}","gists_url":"https://api.github.com/users/rstudio-build/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio-build/subscriptions","organizations_url":"https://api.github.com/users/rstudio-build/orgs","repos_url":"https://api.github.com/users/rstudio-build/repos","events_url":"https://api.github.com/users/rstudio-build/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio-build/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T17:13:04Z","updated_at":"2018-03-29T17:13:04Z","author_association":"NONE","body":"Yeah, the dueling scrollbars is extremely frustrating (because it\nessentially prevents you from scrolling the main document). I think the\nbehavior we have now is preferable.\n\nOn Thu, Mar 29, 2018 at 1:07 PM, Jonathan <notifications@github.com> wrote:\n\n> We used to do almost exactly this, and we turned it off intentionally\n> because the double vertical scrollbar experience is very unpleasant; in\n> addition to the weirdness of having two scrollbars right next to each\n> other, it makes scroll events ambiguous (did you mean to scroll the editor\n> surface, or the chunk contents?), and scrolling kind of fiddly. There's\n> still a MAX_CHUNK_HEIGHT constant, though I don't think it's used any\n> more:\n>\n> https://github.com/rstudio/rstudio/blob/2d36df72dde5beb5326b40dbc4d24d\n> 58fa922919/src/gwt/src/org/rstudio/studio/client/workbench/views/source/\n> editors/text/rmd/ChunkOutputUi.java#L264\n>\n> I think @javierluraschi <https://github.com/javierluraschi> turned this\n> off in 8355ca7#diff-87d1d99a586cdc6353e7d3188d20305b\n> <https://github.com/rstudio/rstudio/commit/8355ca7221acf6f60fd46910cc5b84ce465b827f#diff-87d1d99a586cdc6353e7d3188d20305b>\n> .\n>\n> Realize that allowing the output to grow without bounds has its own set of\n> downsides, too, but if we're going to tweak the experience we should try to\n> find a third way (let me know what you think).\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/rstudio/rstudio/pull/2533#issuecomment-377304525>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAfafVqewzQQqoTsRcZq8uS-nw7-zdf5ks5tjRS-gaJpZM4S_hkT>\n> .\n>\n"}}
{"actor":{"display_login":"rstudio-build"}}