{"action":"created","comment":{"url":"https://api.github.com/repos/meetalva/alva/pulls/comments/183476290","pull_request_review_id":114481683,"id":183476290,"diff_hunk":"@@ -106,12 +106,15 @@ export class PatternListContainer extends React.Component {\n \tprotected handlePatternClick(pattern: Pattern): void {\n \t\tconst store: Store = Store.getInstance();\n \t\tconst selectedElement: PageElement | undefined = store.getSelectedElement();\n+\t\tconst selectedSlot = store.getSelectedSlot();\n \t\tif (selectedElement) {\n \t\t\tconst newPageElement = new PageElement({\n \t\t\t\tpattern,\n \t\t\t\tsetDefaults: true\n \t\t\t});\n-\t\t\tstore.execute(ElementLocationCommand.addSibling(selectedElement, newPageElement));\n+\t\t\tstore.execute(\n+\t\t\t\tElementLocationCommand.addChild(selectedElement, newPageElement, selectedSlot)","path":"src/component/container/pattern-list.tsx","position":12,"original_position":12,"commit_id":"8dbd5ea22a8bd4c9d22df479f69e057cc9767212","original_commit_id":"1945dfabcbf8d8e6c0abe34a4f7d25100d3585d7","user":{"login":"faselbaum","id":7253851,"avatar_url":"https://avatars1.githubusercontent.com/u/7253851?v=4","gravatar_id":"","url":"https://api.github.com/users/faselbaum","html_url":"https://github.com/faselbaum","followers_url":"https://api.github.com/users/faselbaum/followers","following_url":"https://api.github.com/users/faselbaum/following{/other_user}","gists_url":"https://api.github.com/users/faselbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/faselbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faselbaum/subscriptions","organizations_url":"https://api.github.com/users/faselbaum/orgs","repos_url":"https://api.github.com/users/faselbaum/repos","events_url":"https://api.github.com/users/faselbaum/events{/privacy}","received_events_url":"https://api.github.com/users/faselbaum/received_events","type":"User","site_admin":false},"body":"i think addChild fits a little better. otherwise we would need the extra step to `selectedElement.getParent()` which could be undefined","created_at":"2018-04-23T17:29:40Z","updated_at":"2018-04-23T17:29:41Z","html_url":"https://github.com/meetalva/alva/pull/380#discussion_r183476290","pull_request_url":"https://api.github.com/repos/meetalva/alva/pulls/380","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/meetalva/alva/pulls/comments/183476290"},"html":{"href":"https://github.com/meetalva/alva/pull/380#discussion_r183476290"},"pull_request":{"href":"https://api.github.com/repos/meetalva/alva/pulls/380"}},"in_reply_to_id":183068856},"pull_request":{"url":"https://api.github.com/repos/meetalva/alva/pulls/380","id":182014250,"html_url":"https://github.com/meetalva/alva/pull/380","diff_url":"https://github.com/meetalva/alva/pull/380.diff","patch_url":"https://github.com/meetalva/alva/pull/380.patch","issue_url":"https://api.github.com/repos/meetalva/alva/issues/380","number":380,"state":"open","locked":false,"title":"feat(page-element): visualize component properties (fixes #150)","user":{"login":"faselbaum","id":7253851,"avatar_url":"https://avatars1.githubusercontent.com/u/7253851?v=4","gravatar_id":"","url":"https://api.github.com/users/faselbaum","html_url":"https://github.com/faselbaum","followers_url":"https://api.github.com/users/faselbaum/followers","following_url":"https://api.github.com/users/faselbaum/following{/other_user}","gists_url":"https://api.github.com/users/faselbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/faselbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faselbaum/subscriptions","organizations_url":"https://api.github.com/users/faselbaum/orgs","repos_url":"https://api.github.com/users/faselbaum/repos","events_url":"https://api.github.com/users/faselbaum/events{/privacy}","received_events_url":"https://api.github.com/users/faselbaum/received_events","type":"User","site_admin":false},"body":"This feature allows interpreting component properties that have one of the following types (React.ReactNode, JSX.Element, React.ReactChild) as a special kind of property.\r\n\r\nThese properties will be handled as \"Slots\" that you can then drop other page elements into in the left hand tree-view. These slots are marked with a special icon. They can't be moved, renamed or otherwise edited. Only the slots contents are modifiable.\r\n\r\nCloses https://github.com/meetalva/alva/issues/150\r\nFixes #370","created_at":"2018-04-16T23:27:19Z","updated_at":"2018-04-23T17:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edf1ecaabbf0c72a212610135f661be0de6d9b37","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TheReincarnator","id":840370,"avatar_url":"https://avatars2.githubusercontent.com/u/840370?v=4","gravatar_id":"","url":"https://api.github.com/users/TheReincarnator","html_url":"https://github.com/TheReincarnator","followers_url":"https://api.github.com/users/TheReincarnator/followers","following_url":"https://api.github.com/users/TheReincarnator/following{/other_user}","gists_url":"https://api.github.com/users/TheReincarnator/gists{/gist_id}","starred_url":"https://api.github.com/users/TheReincarnator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheReincarnator/subscriptions","organizations_url":"https://api.github.com/users/TheReincarnator/orgs","repos_url":"https://api.github.com/users/TheReincarnator/repos","events_url":"https://api.github.com/users/TheReincarnator/events{/privacy}","received_events_url":"https://api.github.com/users/TheReincarnator/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/meetalva/alva/pulls/380/commits","review_comments_url":"https://api.github.com/repos/meetalva/alva/pulls/380/comments","review_comment_url":"https://api.github.com/repos/meetalva/alva/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meetalva/alva/issues/380/comments","statuses_url":"https://api.github.com/repos/meetalva/alva/statuses/8dbd5ea22a8bd4c9d22df479f69e057cc9767212","head":{"label":"meetalva:feat/page-element-slots","ref":"feat/page-element-slots","sha":"8dbd5ea22a8bd4c9d22df479f69e057cc9767212","user":{"login":"meetalva","id":33702914,"avatar_url":"https://avatars3.githubusercontent.com/u/33702914?v=4","gravatar_id":"","url":"https://api.github.com/users/meetalva","html_url":"https://github.com/meetalva","followers_url":"https://api.github.com/users/meetalva/followers","following_url":"https://api.github.com/users/meetalva/following{/other_user}","gists_url":"https://api.github.com/users/meetalva/gists{/gist_id}","starred_url":"https://api.github.com/users/meetalva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetalva/subscriptions","organizations_url":"https://api.github.com/users/meetalva/orgs","repos_url":"https://api.github.com/users/meetalva/repos","events_url":"https://api.github.com/users/meetalva/events{/privacy}","received_events_url":"https://api.github.com/users/meetalva/received_events","type":"Organization","site_admin":false},"repo":{"id":110887441,"name":"alva","full_name":"meetalva/alva","owner":{"login":"meetalva","id":33702914,"avatar_url":"https://avatars3.githubusercontent.com/u/33702914?v=4","gravatar_id":"","url":"https://api.github.com/users/meetalva","html_url":"https://github.com/meetalva","followers_url":"https://api.github.com/users/meetalva/followers","following_url":"https://api.github.com/users/meetalva/following{/other_user}","gists_url":"https://api.github.com/users/meetalva/gists{/gist_id}","starred_url":"https://api.github.com/users/meetalva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetalva/subscriptions","organizations_url":"https://api.github.com/users/meetalva/orgs","repos_url":"https://api.github.com/users/meetalva/repos","events_url":"https://api.github.com/users/meetalva/events{/privacy}","received_events_url":"https://api.github.com/users/meetalva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetalva/alva","description":"Alva is a radically new design tool that enables cross-functional teams to design digital products.","fork":false,"url":"https://api.github.com/repos/meetalva/alva","forks_url":"https://api.github.com/repos/meetalva/alva/forks","keys_url":"https://api.github.com/repos/meetalva/alva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetalva/alva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetalva/alva/teams","hooks_url":"https://api.github.com/repos/meetalva/alva/hooks","issue_events_url":"https://api.github.com/repos/meetalva/alva/issues/events{/number}","events_url":"https://api.github.com/repos/meetalva/alva/events","assignees_url":"https://api.github.com/repos/meetalva/alva/assignees{/user}","branches_url":"https://api.github.com/repos/meetalva/alva/branches{/branch}","tags_url":"https://api.github.com/repos/meetalva/alva/tags","blobs_url":"https://api.github.com/repos/meetalva/alva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetalva/alva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetalva/alva/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetalva/alva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetalva/alva/statuses/{sha}","languages_url":"https://api.github.com/repos/meetalva/alva/languages","stargazers_url":"https://api.github.com/repos/meetalva/alva/stargazers","contributors_url":"https://api.github.com/repos/meetalva/alva/contributors","subscribers_url":"https://api.github.com/repos/meetalva/alva/subscribers","subscription_url":"https://api.github.com/repos/meetalva/alva/subscription","commits_url":"https://api.github.com/repos/meetalva/alva/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetalva/alva/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetalva/alva/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetalva/alva/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetalva/alva/contents/{+path}","compare_url":"https://api.github.com/repos/meetalva/alva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetalva/alva/merges","archive_url":"https://api.github.com/repos/meetalva/alva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetalva/alva/downloads","issues_url":"https://api.github.com/repos/meetalva/alva/issues{/number}","pulls_url":"https://api.github.com/repos/meetalva/alva/pulls{/number}","milestones_url":"https://api.github.com/repos/meetalva/alva/milestones{/number}","notifications_url":"https://api.github.com/repos/meetalva/alva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetalva/alva/labels{/name}","releases_url":"https://api.github.com/repos/meetalva/alva/releases{/id}","deployments_url":"https://api.github.com/repos/meetalva/alva/deployments","created_at":"2017-11-15T21:16:50Z","updated_at":"2018-04-23T15:57:19Z","pushed_at":"2018-04-23T17:26:30Z","git_url":"git://github.com/meetalva/alva.git","ssh_url":"git@github.com:meetalva/alva.git","clone_url":"https://github.com/meetalva/alva.git","svn_url":"https://github.com/meetalva/alva","homepage":"https://meetalva.io","size":2438,"stargazers_count":1965,"watchers_count":1965,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":79,"open_issues":77,"watchers":1965,"default_branch":"master"}},"base":{"label":"meetalva:master","ref":"master","sha":"38a7dbaf96b6ba5cdf88f30979d515052c7c5cbf","user":{"login":"meetalva","id":33702914,"avatar_url":"https://avatars3.githubusercontent.com/u/33702914?v=4","gravatar_id":"","url":"https://api.github.com/users/meetalva","html_url":"https://github.com/meetalva","followers_url":"https://api.github.com/users/meetalva/followers","following_url":"https://api.github.com/users/meetalva/following{/other_user}","gists_url":"https://api.github.com/users/meetalva/gists{/gist_id}","starred_url":"https://api.github.com/users/meetalva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetalva/subscriptions","organizations_url":"https://api.github.com/users/meetalva/orgs","repos_url":"https://api.github.com/users/meetalva/repos","events_url":"https://api.github.com/users/meetalva/events{/privacy}","received_events_url":"https://api.github.com/users/meetalva/received_events","type":"Organization","site_admin":false},"repo":{"id":110887441,"name":"alva","full_name":"meetalva/alva","owner":{"login":"meetalva","id":33702914,"avatar_url":"https://avatars3.githubusercontent.com/u/33702914?v=4","gravatar_id":"","url":"https://api.github.com/users/meetalva","html_url":"https://github.com/meetalva","followers_url":"https://api.github.com/users/meetalva/followers","following_url":"https://api.github.com/users/meetalva/following{/other_user}","gists_url":"https://api.github.com/users/meetalva/gists{/gist_id}","starred_url":"https://api.github.com/users/meetalva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetalva/subscriptions","organizations_url":"https://api.github.com/users/meetalva/orgs","repos_url":"https://api.github.com/users/meetalva/repos","events_url":"https://api.github.com/users/meetalva/events{/privacy}","received_events_url":"https://api.github.com/users/meetalva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetalva/alva","description":"Alva is a radically new design tool that enables cross-functional teams to design digital products.","fork":false,"url":"https://api.github.com/repos/meetalva/alva","forks_url":"https://api.github.com/repos/meetalva/alva/forks","keys_url":"https://api.github.com/repos/meetalva/alva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetalva/alva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetalva/alva/teams","hooks_url":"https://api.github.com/repos/meetalva/alva/hooks","issue_events_url":"https://api.github.com/repos/meetalva/alva/issues/events{/number}","events_url":"https://api.github.com/repos/meetalva/alva/events","assignees_url":"https://api.github.com/repos/meetalva/alva/assignees{/user}","branches_url":"https://api.github.com/repos/meetalva/alva/branches{/branch}","tags_url":"https://api.github.com/repos/meetalva/alva/tags","blobs_url":"https://api.github.com/repos/meetalva/alva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetalva/alva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetalva/alva/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetalva/alva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetalva/alva/statuses/{sha}","languages_url":"https://api.github.com/repos/meetalva/alva/languages","stargazers_url":"https://api.github.com/repos/meetalva/alva/stargazers","contributors_url":"https://api.github.com/repos/meetalva/alva/contributors","subscribers_url":"https://api.github.com/repos/meetalva/alva/subscribers","subscription_url":"https://api.github.com/repos/meetalva/alva/subscription","commits_url":"https://api.github.com/repos/meetalva/alva/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetalva/alva/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetalva/alva/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetalva/alva/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetalva/alva/contents/{+path}","compare_url":"https://api.github.com/repos/meetalva/alva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetalva/alva/merges","archive_url":"https://api.github.com/repos/meetalva/alva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetalva/alva/downloads","issues_url":"https://api.github.com/repos/meetalva/alva/issues{/number}","pulls_url":"https://api.github.com/repos/meetalva/alva/pulls{/number}","milestones_url":"https://api.github.com/repos/meetalva/alva/milestones{/number}","notifications_url":"https://api.github.com/repos/meetalva/alva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetalva/alva/labels{/name}","releases_url":"https://api.github.com/repos/meetalva/alva/releases{/id}","deployments_url":"https://api.github.com/repos/meetalva/alva/deployments","created_at":"2017-11-15T21:16:50Z","updated_at":"2018-04-23T15:57:19Z","pushed_at":"2018-04-23T17:26:30Z","git_url":"git://github.com/meetalva/alva.git","ssh_url":"git@github.com:meetalva/alva.git","clone_url":"https://github.com/meetalva/alva.git","svn_url":"https://github.com/meetalva/alva","homepage":"https://meetalva.io","size":2438,"stargazers_count":1965,"watchers_count":1965,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":79,"open_issues":77,"watchers":1965,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meetalva/alva/pulls/380"},"html":{"href":"https://github.com/meetalva/alva/pull/380"},"issue":{"href":"https://api.github.com/repos/meetalva/alva/issues/380"},"comments":{"href":"https://api.github.com/repos/meetalva/alva/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/meetalva/alva/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/meetalva/alva/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meetalva/alva/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/meetalva/alva/statuses/8dbd5ea22a8bd4c9d22df479f69e057cc9767212"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"faselbaum"}}