{"action":"created","comment":{"url":"https://api.github.com/repos/Lightricks/expecta/pulls/comments/211107156","pull_request_review_id":147461146,"id":211107156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEwNzE1Ng==","diff_hunk":"@@ -16,15 +16,15 @@\n         return expectedExceptionCaught;\n     });\n     \n-    failureMessageForTo(^NSString *{\n+    failureMessageForTo(^NSString *(id actual) {","path":"Expecta/Matchers/EXPMatchers+raiseWithReason.m","position":14,"original_position":14,"commit_id":"8123cc4ad1769afccf6538428f466978ab3fcf83","original_commit_id":"8123cc4ad1769afccf6538428f466978ab3fcf83","user":{"login":"DekelAvrahami","id":30690177,"node_id":"MDQ6VXNlcjMwNjkwMTc3","avatar_url":"https://avatars0.githubusercontent.com/u/30690177?v=4","gravatar_id":"","url":"https://api.github.com/users/DekelAvrahami","html_url":"https://github.com/DekelAvrahami","followers_url":"https://api.github.com/users/DekelAvrahami/followers","following_url":"https://api.github.com/users/DekelAvrahami/following{/other_user}","gists_url":"https://api.github.com/users/DekelAvrahami/gists{/gist_id}","starred_url":"https://api.github.com/users/DekelAvrahami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DekelAvrahami/subscriptions","organizations_url":"https://api.github.com/users/DekelAvrahami/orgs","repos_url":"https://api.github.com/users/DekelAvrahami/repos","events_url":"https://api.github.com/users/DekelAvrahami/events{/privacy}","received_events_url":"https://api.github.com/users/DekelAvrahami/received_events","type":"User","site_admin":false},"body":"`actual` is not used in the block. Should it be marked with `__unused`? Same for next block.","created_at":"2018-08-19T15:49:34Z","updated_at":"2018-08-19T15:53:37Z","html_url":"https://github.com/Lightricks/expecta/pull/7#discussion_r211107156","pull_request_url":"https://api.github.com/repos/Lightricks/expecta/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Lightricks/expecta/pulls/comments/211107156"},"html":{"href":"https://github.com/Lightricks/expecta/pull/7#discussion_r211107156"},"pull_request":{"href":"https://api.github.com/repos/Lightricks/expecta/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Lightricks/expecta/pulls/7","id":208822258,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODIyMjU4","html_url":"https://github.com/Lightricks/expecta/pull/7","diff_url":"https://github.com/Lightricks/expecta/pull/7.diff","patch_url":"https://github.com/Lightricks/expecta/pull/7.patch","issue_url":"https://api.github.com/repos/Lightricks/expecta/issues/7","number":7,"state":"open","locked":false,"title":"Expecta: pass actual to block matchers.","user":{"login":"StatusReport","id":1927614,"node_id":"MDQ6VXNlcjE5Mjc2MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1927614?v=4","gravatar_id":"","url":"https://api.github.com/users/StatusReport","html_url":"https://github.com/StatusReport","followers_url":"https://api.github.com/users/StatusReport/followers","following_url":"https://api.github.com/users/StatusReport/following{/other_user}","gists_url":"https://api.github.com/users/StatusReport/gists{/gist_id}","starred_url":"https://api.github.com/users/StatusReport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StatusReport/subscriptions","organizations_url":"https://api.github.com/users/StatusReport/orgs","repos_url":"https://api.github.com/users/StatusReport/repos","events_url":"https://api.github.com/users/StatusReport/events{/privacy}","received_events_url":"https://api.github.com/users/StatusReport/received_events","type":"User","site_admin":false},"body":"The current implementation of Expecta passes `actual` as a captured\r\nvariable to the `prerequisite`, `match`, `failureMessageForTo` and\r\n`failureMessageForNotTo` blocks, and overwrites `actual` via a pointer\r\nto an ObjC object.\r\n\r\nFrom experimentation, it seems that matchers that are written in ARC do\r\nnot work well with this method - if `will` or `after` is used, `actual`\r\nwill not get updated on each iteration of the matcher. Additionally, we\r\nsuspect that this implementation may create memory leaks, as the object\r\npointed to is not being explicitly `release`ed.\r\n\r\nThis commit makes the code more straightforward and clean, by passing\r\n`actual` to the aforementioned blocks, and removing it from the capture\r\nlist of these blocks.\r\n\r\nSince this is an Expecta API change, it requires changes across all the\r\nmatchers.","created_at":"2018-08-16T11:04:36Z","updated_at":"2018-08-19T15:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16fa74af81c8fbe892c9cd092470bd80ebab2e7c","assignee":{"login":"DekelAvrahami","id":30690177,"node_id":"MDQ6VXNlcjMwNjkwMTc3","avatar_url":"https://avatars0.githubusercontent.com/u/30690177?v=4","gravatar_id":"","url":"https://api.github.com/users/DekelAvrahami","html_url":"https://github.com/DekelAvrahami","followers_url":"https://api.github.com/users/DekelAvrahami/followers","following_url":"https://api.github.com/users/DekelAvrahami/following{/other_user}","gists_url":"https://api.github.com/users/DekelAvrahami/gists{/gist_id}","starred_url":"https://api.github.com/users/DekelAvrahami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DekelAvrahami/subscriptions","organizations_url":"https://api.github.com/users/DekelAvrahami/orgs","repos_url":"https://api.github.com/users/DekelAvrahami/repos","events_url":"https://api.github.com/users/DekelAvrahami/events{/privacy}","received_events_url":"https://api.github.com/users/DekelAvrahami/received_events","type":"User","site_admin":false},"assignees":[{"login":"DekelAvrahami","id":30690177,"node_id":"MDQ6VXNlcjMwNjkwMTc3","avatar_url":"https://avatars0.githubusercontent.com/u/30690177?v=4","gravatar_id":"","url":"https://api.github.com/users/DekelAvrahami","html_url":"https://github.com/DekelAvrahami","followers_url":"https://api.github.com/users/DekelAvrahami/followers","following_url":"https://api.github.com/users/DekelAvrahami/following{/other_user}","gists_url":"https://api.github.com/users/DekelAvrahami/gists{/gist_id}","starred_url":"https://api.github.com/users/DekelAvrahami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DekelAvrahami/subscriptions","organizations_url":"https://api.github.com/users/DekelAvrahami/orgs","repos_url":"https://api.github.com/users/DekelAvrahami/repos","events_url":"https://api.github.com/users/DekelAvrahami/events{/privacy}","received_events_url":"https://api.github.com/users/DekelAvrahami/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lightricks/expecta/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Lightricks/expecta/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Lightricks/expecta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lightricks/expecta/issues/7/comments","statuses_url":"https://api.github.com/repos/Lightricks/expecta/statuses/8123cc4ad1769afccf6538428f466978ab3fcf83","head":{"label":"Lightricks:feature/pass-actual-to-matcher","ref":"feature/pass-actual-to-matcher","sha":"8123cc4ad1769afccf6538428f466978ab3fcf83","user":{"login":"Lightricks","id":3170348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzAzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3170348?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightricks","html_url":"https://github.com/Lightricks","followers_url":"https://api.github.com/users/Lightricks/followers","following_url":"https://api.github.com/users/Lightricks/following{/other_user}","gists_url":"https://api.github.com/users/Lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightricks/subscriptions","organizations_url":"https://api.github.com/users/Lightricks/orgs","repos_url":"https://api.github.com/users/Lightricks/repos","events_url":"https://api.github.com/users/Lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/Lightricks/received_events","type":"Organization","site_admin":false},"repo":{"id":15261078,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2MTA3OA==","name":"expecta","full_name":"Lightricks/expecta","owner":{"login":"Lightricks","id":3170348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzAzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3170348?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightricks","html_url":"https://github.com/Lightricks","followers_url":"https://api.github.com/users/Lightricks/followers","following_url":"https://api.github.com/users/Lightricks/following{/other_user}","gists_url":"https://api.github.com/users/Lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightricks/subscriptions","organizations_url":"https://api.github.com/users/Lightricks/orgs","repos_url":"https://api.github.com/users/Lightricks/repos","events_url":"https://api.github.com/users/Lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/Lightricks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lightricks/expecta","description":"A Matcher Framework for Objective-C/Cocoa","fork":true,"url":"https://api.github.com/repos/Lightricks/expecta","forks_url":"https://api.github.com/repos/Lightricks/expecta/forks","keys_url":"https://api.github.com/repos/Lightricks/expecta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lightricks/expecta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lightricks/expecta/teams","hooks_url":"https://api.github.com/repos/Lightricks/expecta/hooks","issue_events_url":"https://api.github.com/repos/Lightricks/expecta/issues/events{/number}","events_url":"https://api.github.com/repos/Lightricks/expecta/events","assignees_url":"https://api.github.com/repos/Lightricks/expecta/assignees{/user}","branches_url":"https://api.github.com/repos/Lightricks/expecta/branches{/branch}","tags_url":"https://api.github.com/repos/Lightricks/expecta/tags","blobs_url":"https://api.github.com/repos/Lightricks/expecta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lightricks/expecta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lightricks/expecta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lightricks/expecta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lightricks/expecta/statuses/{sha}","languages_url":"https://api.github.com/repos/Lightricks/expecta/languages","stargazers_url":"https://api.github.com/repos/Lightricks/expecta/stargazers","contributors_url":"https://api.github.com/repos/Lightricks/expecta/contributors","subscribers_url":"https://api.github.com/repos/Lightricks/expecta/subscribers","subscription_url":"https://api.github.com/repos/Lightricks/expecta/subscription","commits_url":"https://api.github.com/repos/Lightricks/expecta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lightricks/expecta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lightricks/expecta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lightricks/expecta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lightricks/expecta/contents/{+path}","compare_url":"https://api.github.com/repos/Lightricks/expecta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lightricks/expecta/merges","archive_url":"https://api.github.com/repos/Lightricks/expecta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lightricks/expecta/downloads","issues_url":"https://api.github.com/repos/Lightricks/expecta/issues{/number}","pulls_url":"https://api.github.com/repos/Lightricks/expecta/pulls{/number}","milestones_url":"https://api.github.com/repos/Lightricks/expecta/milestones{/number}","notifications_url":"https://api.github.com/repos/Lightricks/expecta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lightricks/expecta/labels{/name}","releases_url":"https://api.github.com/repos/Lightricks/expecta/releases{/id}","deployments_url":"https://api.github.com/repos/Lightricks/expecta/deployments","created_at":"2013-12-17T17:24:26Z","updated_at":"2015-10-22T11:25:57Z","pushed_at":"2018-08-19T14:28:10Z","git_url":"git://github.com/Lightricks/expecta.git","ssh_url":"git@github.com:Lightricks/expecta.git","clone_url":"https://github.com/Lightricks/expecta.git","svn_url":"https://github.com/Lightricks/expecta","homepage":"","size":628,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Lightricks:develop","ref":"develop","sha":"dbb10ce98262673cd04d93f0a5cb189550bf6d6d","user":{"login":"Lightricks","id":3170348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzAzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3170348?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightricks","html_url":"https://github.com/Lightricks","followers_url":"https://api.github.com/users/Lightricks/followers","following_url":"https://api.github.com/users/Lightricks/following{/other_user}","gists_url":"https://api.github.com/users/Lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightricks/subscriptions","organizations_url":"https://api.github.com/users/Lightricks/orgs","repos_url":"https://api.github.com/users/Lightricks/repos","events_url":"https://api.github.com/users/Lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/Lightricks/received_events","type":"Organization","site_admin":false},"repo":{"id":15261078,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2MTA3OA==","name":"expecta","full_name":"Lightricks/expecta","owner":{"login":"Lightricks","id":3170348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzAzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3170348?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightricks","html_url":"https://github.com/Lightricks","followers_url":"https://api.github.com/users/Lightricks/followers","following_url":"https://api.github.com/users/Lightricks/following{/other_user}","gists_url":"https://api.github.com/users/Lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightricks/subscriptions","organizations_url":"https://api.github.com/users/Lightricks/orgs","repos_url":"https://api.github.com/users/Lightricks/repos","events_url":"https://api.github.com/users/Lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/Lightricks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lightricks/expecta","description":"A Matcher Framework for Objective-C/Cocoa","fork":true,"url":"https://api.github.com/repos/Lightricks/expecta","forks_url":"https://api.github.com/repos/Lightricks/expecta/forks","keys_url":"https://api.github.com/repos/Lightricks/expecta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lightricks/expecta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lightricks/expecta/teams","hooks_url":"https://api.github.com/repos/Lightricks/expecta/hooks","issue_events_url":"https://api.github.com/repos/Lightricks/expecta/issues/events{/number}","events_url":"https://api.github.com/repos/Lightricks/expecta/events","assignees_url":"https://api.github.com/repos/Lightricks/expecta/assignees{/user}","branches_url":"https://api.github.com/repos/Lightricks/expecta/branches{/branch}","tags_url":"https://api.github.com/repos/Lightricks/expecta/tags","blobs_url":"https://api.github.com/repos/Lightricks/expecta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lightricks/expecta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lightricks/expecta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lightricks/expecta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lightricks/expecta/statuses/{sha}","languages_url":"https://api.github.com/repos/Lightricks/expecta/languages","stargazers_url":"https://api.github.com/repos/Lightricks/expecta/stargazers","contributors_url":"https://api.github.com/repos/Lightricks/expecta/contributors","subscribers_url":"https://api.github.com/repos/Lightricks/expecta/subscribers","subscription_url":"https://api.github.com/repos/Lightricks/expecta/subscription","commits_url":"https://api.github.com/repos/Lightricks/expecta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lightricks/expecta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lightricks/expecta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lightricks/expecta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lightricks/expecta/contents/{+path}","compare_url":"https://api.github.com/repos/Lightricks/expecta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lightricks/expecta/merges","archive_url":"https://api.github.com/repos/Lightricks/expecta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lightricks/expecta/downloads","issues_url":"https://api.github.com/repos/Lightricks/expecta/issues{/number}","pulls_url":"https://api.github.com/repos/Lightricks/expecta/pulls{/number}","milestones_url":"https://api.github.com/repos/Lightricks/expecta/milestones{/number}","notifications_url":"https://api.github.com/repos/Lightricks/expecta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lightricks/expecta/labels{/name}","releases_url":"https://api.github.com/repos/Lightricks/expecta/releases{/id}","deployments_url":"https://api.github.com/repos/Lightricks/expecta/deployments","created_at":"2013-12-17T17:24:26Z","updated_at":"2015-10-22T11:25:57Z","pushed_at":"2018-08-19T14:28:10Z","git_url":"git://github.com/Lightricks/expecta.git","ssh_url":"git@github.com:Lightricks/expecta.git","clone_url":"https://github.com/Lightricks/expecta.git","svn_url":"https://github.com/Lightricks/expecta","homepage":"","size":628,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lightricks/expecta/pulls/7"},"html":{"href":"https://github.com/Lightricks/expecta/pull/7"},"issue":{"href":"https://api.github.com/repos/Lightricks/expecta/issues/7"},"comments":{"href":"https://api.github.com/repos/Lightricks/expecta/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Lightricks/expecta/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Lightricks/expecta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lightricks/expecta/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Lightricks/expecta/statuses/8123cc4ad1769afccf6538428f466978ab3fcf83"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"DekelAvrahami"}}