{"action":"created","issue":{"url":"https://api.github.com/repos/DataBiosphere/azul/issues/263","repository_url":"https://api.github.com/repos/DataBiosphere/azul","labels_url":"https://api.github.com/repos/DataBiosphere/azul/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/DataBiosphere/azul/issues/263/comments","events_url":"https://api.github.com/repos/DataBiosphere/azul/issues/263/events","html_url":"https://github.com/DataBiosphere/azul/pull/263","id":355340853,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODkzMTI4","number":263,"title":"Add \"null\" counter to facets (fixes #99)","user":{"login":"Ben-Wu","id":12437227,"node_id":"MDQ6VXNlcjEyNDM3MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/12437227?v=4","gravatar_id":"","url":"https://api.github.com/users/Ben-Wu","html_url":"https://github.com/Ben-Wu","followers_url":"https://api.github.com/users/Ben-Wu/followers","following_url":"https://api.github.com/users/Ben-Wu/following{/other_user}","gists_url":"https://api.github.com/users/Ben-Wu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ben-Wu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ben-Wu/subscriptions","organizations_url":"https://api.github.com/users/Ben-Wu/orgs","repos_url":"https://api.github.com/users/Ben-Wu/repos","events_url":"https://api.github.com/users/Ben-Wu/events{/privacy}","received_events_url":"https://api.github.com/users/Ben-Wu/received_events","type":"User","site_admin":false},"labels":[{"id":993268552,"node_id":"MDU6TGFiZWw5OTMyNjg1NTI=","url":"https://api.github.com/repos/DataBiosphere/azul/labels/HCA","name":"HCA","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"hannes-ucsc","id":5143256,"node_id":"MDQ6VXNlcjUxNDMyNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5143256?v=4","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false},"assignees":[{"login":"hannes-ucsc","id":5143256,"node_id":"MDQ6VXNlcjUxNDMyNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5143256?v=4","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/DataBiosphere/azul/milestones/4","html_url":"https://github.com/DataBiosphere/azul/milestone/4","labels_url":"https://api.github.com/repos/DataBiosphere/azul/milestones/4/labels","id":3577535,"node_id":"MDk6TWlsZXN0b25lMzU3NzUzNQ==","number":4,"title":"Sprint 8 - August 31","description":"","creator":{"login":"theathorn","id":38867406,"node_id":"MDQ6VXNlcjM4ODY3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/38867406?v=4","gravatar_id":"","url":"https://api.github.com/users/theathorn","html_url":"https://github.com/theathorn","followers_url":"https://api.github.com/users/theathorn/followers","following_url":"https://api.github.com/users/theathorn/following{/other_user}","gists_url":"https://api.github.com/users/theathorn/gists{/gist_id}","starred_url":"https://api.github.com/users/theathorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theathorn/subscriptions","organizations_url":"https://api.github.com/users/theathorn/orgs","repos_url":"https://api.github.com/users/theathorn/repos","events_url":"https://api.github.com/users/theathorn/events{/privacy}","received_events_url":"https://api.github.com/users/theathorn/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":31,"state":"open","created_at":"2018-08-16T23:09:28Z","updated_at":"2018-08-31T20:17:34Z","due_on":"2018-08-31T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-08-29T21:30:02Z","updated_at":"2018-08-31T21:16:51Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/DataBiosphere/azul/pulls/263","html_url":"https://github.com/DataBiosphere/azul/pull/263","diff_url":"https://github.com/DataBiosphere/azul/pull/263.diff","patch_url":"https://github.com/DataBiosphere/azul/pull/263.patch"},"body":"(fixes #99)\r\n\r\nThis pull request adds a counter for facets that do not have a value in the ES aggregation.  The response will have in `termFacets` something like this (using `null` value as the term):\r\n\r\n```js\r\n{\r\n  \"biologicalSex\":{\r\n    \"terms\":[\r\n      {\r\n        \"term\":\"female\",\r\n        \"count\":6220\r\n      },\r\n      {\r\n        \"term\":\"unknown\",\r\n        \"count\":4\r\n      },\r\n      {\r\n        \"term\":null,\r\n        \"count\":10\r\n      }\r\n    ]\r\n  }\r\n}\r\n```\r\n\r\nAnother change is to allow querying for missing values through the api.  This is done with a filter in the query like:\r\n```\r\n{\"file\":{\"fieldA\":{\"is\": None}}}\r\n```\r\nLet me know if you have ideas on how to make this query better.\r\n\r\n@hannes-ucsc Also as per our previous discussion let me know if this should be separated into multiple PRs as the changes aren't really dependent on each other."},"comment":{"url":"https://api.github.com/repos/DataBiosphere/azul/issues/comments/417791391","html_url":"https://github.com/DataBiosphere/azul/pull/263#issuecomment-417791391","issue_url":"https://api.github.com/repos/DataBiosphere/azul/issues/263","id":417791391,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzc5MTM5MQ==","user":{"login":"hannes-ucsc","id":5143256,"node_id":"MDQ6VXNlcjUxNDMyNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5143256?v=4","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T21:16:51Z","updated_at":"2018-08-31T21:16:51Z","author_association":"COLLABORATOR","body":"You've retained the existing behavior for `is` being absent and that's what we should concerned with here. I will create a separate ticket."}}
{"actor":{"display_login":"hannes-ucsc"}}