{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20070","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20070/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20070/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20070/events","html_url":"https://github.com/nodejs/node/pull/20070","id":314582541,"number":20070,"title":"lib: use object destructuring for canonicalizeIP","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"labels":[{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":155267349,"url":"https://api.github.com/repos/nodejs/node/labels/tls","name":"tls","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-16T10:05:44Z","updated_at":"2018-04-19T03:17:13Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20070","html_url":"https://github.com/nodejs/node/pull/20070","diff_url":"https://github.com/nodejs/node/pull/20070.diff","patch_url":"https://github.com/nodejs/node/pull/20070.patch"},"body":"This commit updates canonicalizeIP to use object destructuring which is\r\ndone for other functions in lib/tls.js\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/382597140","html_url":"https://github.com/nodejs/node/pull/20070#issuecomment-382597140","issue_url":"https://api.github.com/repos/nodejs/node/issues/20070","id":382597140,"user":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T03:17:13Z","updated_at":"2018-04-19T03:17:13Z","author_association":"OWNER","body":"<details>\r\n<summary>node-test-commit failure looks unrelated</summary>\r\n\r\n[console output](https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian8-64/18098/console):\r\n\r\n```console\r\n06:36:40 not ok 2170 es-module/test-esm-preserve-symlinks-not-found\r\n06:36:40   ---\r\n06:36:40   duration_ms: 0.264\r\n06:36:40   severity: crashed\r\n06:36:40   exitcode: -6\r\n06:36:40   stack: |-\r\n06:36:40     oh no!\r\n06:36:40     exit code: CRASHED (Signal: 6)\r\n06:36:40   ...\r\n ```\r\n</details>"}}
{"actor":{"display_login":"danbev"}}