{"action":"created","comment":{"url":"https://api.github.com/repos/riboseinc/rnp/pulls/comments/165395939","pull_request_review_id":93328207,"id":165395939,"diff_hunk":"@@ -1018,6 +1018,46 @@ def test_encrypt_P3072_3072(self):\n         cmd = EncryptElgamal.GPG_GENERATE_DSA_ELGAMAL_PATERN.format(3072, 3072, self.rnp.userid)\n         self._encrypt_decrypt(self.gpg, self.rnp, 1, cmd)\n \n+class EncryptEcdh(Encrypt):\n+\n+    GPG_GENERATE_ECDH_ECDSA_PATERN = \"\"\"\n+        Key-Type: ecdsa\n+        Key-Curve: {0}\n+        Key-Usage: sign auth\n+        Subkey-Type: ecdh\n+        Subkey-Usage: encrypt\n+        Subkey-Curve: {0}\n+        Name-Real: Test Testovich\n+        Expire-Date: 1y\n+        Preferences: twofish sha256 sha384 sha512 sha1 zlib\n+        Name-Email: {1}\"\"\"\n+\n+    RNP_GENERATE_ECDH_ECDSA_PATERN = \"18\\n{0}\\n\"\n+\n+    def test_encrypt_nistP256(self):\n+        cmd = EncryptEcdh.GPG_GENERATE_ECDH_ECDSA_PATERN.format(\"nistp256\", self.rnp.userid)\n+        self._encrypt_decrypt(self.gpg, self.rnp, 1, cmd)","path":"src/tests/cli_tests.py","position":22,"original_position":22,"commit_id":"aa7ed36c7ff00fa250f4e057a7321db72be3d343","original_commit_id":"aa7ed36c7ff00fa250f4e057a7321db72be3d343","user":{"login":"flowher","id":1159844,"avatar_url":"https://avatars0.githubusercontent.com/u/1159844?v=4","gravatar_id":"","url":"https://api.github.com/users/flowher","html_url":"https://github.com/flowher","followers_url":"https://api.github.com/users/flowher/followers","following_url":"https://api.github.com/users/flowher/following{/other_user}","gists_url":"https://api.github.com/users/flowher/gists{/gist_id}","starred_url":"https://api.github.com/users/flowher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowher/subscriptions","organizations_url":"https://api.github.com/users/flowher/orgs","repos_url":"https://api.github.com/users/flowher/repos","events_url":"https://api.github.com/users/flowher/events{/privacy}","received_events_url":"https://api.github.com/users/flowher/received_events","type":"User","site_admin":false},"body":"Indeed, this needs to be merged with \"new approach\" now. I'll do it just after ECDH fix is merged. So please don't merge until done","created_at":"2018-02-01T15:45:51Z","updated_at":"2018-02-01T15:45:51Z","html_url":"https://github.com/riboseinc/rnp/pull/608#discussion_r165395939","pull_request_url":"https://api.github.com/repos/riboseinc/rnp/pulls/608","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/comments/165395939"},"html":{"href":"https://github.com/riboseinc/rnp/pull/608#discussion_r165395939"},"pull_request":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/608"}},"in_reply_to_id":165224067},"pull_request":{"url":"https://api.github.com/repos/riboseinc/rnp/pulls/608","id":165849534,"html_url":"https://github.com/riboseinc/rnp/pull/608","diff_url":"https://github.com/riboseinc/rnp/pull/608.diff","patch_url":"https://github.com/riboseinc/rnp/pull/608.patch","issue_url":"https://api.github.com/repos/riboseinc/rnp/issues/608","number":608,"state":"open","locked":false,"title":"(tests) ECDH tests against GnuPG","user":{"login":"flowher","id":1159844,"avatar_url":"https://avatars0.githubusercontent.com/u/1159844?v=4","gravatar_id":"","url":"https://api.github.com/users/flowher","html_url":"https://github.com/flowher","followers_url":"https://api.github.com/users/flowher/followers","following_url":"https://api.github.com/users/flowher/following{/other_user}","gists_url":"https://api.github.com/users/flowher/gists{/gist_id}","starred_url":"https://api.github.com/users/flowher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowher/subscriptions","organizations_url":"https://api.github.com/users/flowher/orgs","repos_url":"https://api.github.com/users/flowher/repos","events_url":"https://api.github.com/users/flowher/events{/privacy}","received_events_url":"https://api.github.com/users/flowher/received_events","type":"User","site_admin":false},"body":"Encryption and decryption tests for ECDH against GnuPG\r\n\r\nRequires: #605 and #607 to be merged before (otherwise tests will break)\r\nCloses #27 ","created_at":"2018-01-29T23:42:30Z","updated_at":"2018-02-01T15:45:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85261dbcffcc62fe2b9014d2271b333154db0ce7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ronaldtse","id":11865,"avatar_url":"https://avatars1.githubusercontent.com/u/11865?v=4","gravatar_id":"","url":"https://api.github.com/users/ronaldtse","html_url":"https://github.com/ronaldtse","followers_url":"https://api.github.com/users/ronaldtse/followers","following_url":"https://api.github.com/users/ronaldtse/following{/other_user}","gists_url":"https://api.github.com/users/ronaldtse/gists{/gist_id}","starred_url":"https://api.github.com/users/ronaldtse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronaldtse/subscriptions","organizations_url":"https://api.github.com/users/ronaldtse/orgs","repos_url":"https://api.github.com/users/ronaldtse/repos","events_url":"https://api.github.com/users/ronaldtse/events{/privacy}","received_events_url":"https://api.github.com/users/ronaldtse/received_events","type":"User","site_admin":false},{"login":"randombit","id":469092,"avatar_url":"https://avatars0.githubusercontent.com/u/469092?v=4","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/riboseinc/rnp/pulls/608/commits","review_comments_url":"https://api.github.com/repos/riboseinc/rnp/pulls/608/comments","review_comment_url":"https://api.github.com/repos/riboseinc/rnp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riboseinc/rnp/issues/608/comments","statuses_url":"https://api.github.com/repos/riboseinc/rnp/statuses/aa7ed36c7ff00fa250f4e057a7321db72be3d343","head":{"label":"flowher:features/ecdh_gpg_tests","ref":"features/ecdh_gpg_tests","sha":"aa7ed36c7ff00fa250f4e057a7321db72be3d343","user":{"login":"flowher","id":1159844,"avatar_url":"https://avatars0.githubusercontent.com/u/1159844?v=4","gravatar_id":"","url":"https://api.github.com/users/flowher","html_url":"https://github.com/flowher","followers_url":"https://api.github.com/users/flowher/followers","following_url":"https://api.github.com/users/flowher/following{/other_user}","gists_url":"https://api.github.com/users/flowher/gists{/gist_id}","starred_url":"https://api.github.com/users/flowher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowher/subscriptions","organizations_url":"https://api.github.com/users/flowher/orgs","repos_url":"https://api.github.com/users/flowher/repos","events_url":"https://api.github.com/users/flowher/events{/privacy}","received_events_url":"https://api.github.com/users/flowher/received_events","type":"User","site_admin":false},"repo":{"id":88359561,"name":"rnp","full_name":"flowher/rnp","owner":{"login":"flowher","id":1159844,"avatar_url":"https://avatars0.githubusercontent.com/u/1159844?v=4","gravatar_id":"","url":"https://api.github.com/users/flowher","html_url":"https://github.com/flowher","followers_url":"https://api.github.com/users/flowher/followers","following_url":"https://api.github.com/users/flowher/following{/other_user}","gists_url":"https://api.github.com/users/flowher/gists{/gist_id}","starred_url":"https://api.github.com/users/flowher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowher/subscriptions","organizations_url":"https://api.github.com/users/flowher/orgs","repos_url":"https://api.github.com/users/flowher/repos","events_url":"https://api.github.com/users/flowher/events{/privacy}","received_events_url":"https://api.github.com/users/flowher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flowher/rnp","description":"rnp is the Ribose fork of NetPGP, containing a number of functionality improvements to make it on par with GnuPG","fork":true,"url":"https://api.github.com/repos/flowher/rnp","forks_url":"https://api.github.com/repos/flowher/rnp/forks","keys_url":"https://api.github.com/repos/flowher/rnp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flowher/rnp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flowher/rnp/teams","hooks_url":"https://api.github.com/repos/flowher/rnp/hooks","issue_events_url":"https://api.github.com/repos/flowher/rnp/issues/events{/number}","events_url":"https://api.github.com/repos/flowher/rnp/events","assignees_url":"https://api.github.com/repos/flowher/rnp/assignees{/user}","branches_url":"https://api.github.com/repos/flowher/rnp/branches{/branch}","tags_url":"https://api.github.com/repos/flowher/rnp/tags","blobs_url":"https://api.github.com/repos/flowher/rnp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flowher/rnp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flowher/rnp/git/refs{/sha}","trees_url":"https://api.github.com/repos/flowher/rnp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flowher/rnp/statuses/{sha}","languages_url":"https://api.github.com/repos/flowher/rnp/languages","stargazers_url":"https://api.github.com/repos/flowher/rnp/stargazers","contributors_url":"https://api.github.com/repos/flowher/rnp/contributors","subscribers_url":"https://api.github.com/repos/flowher/rnp/subscribers","subscription_url":"https://api.github.com/repos/flowher/rnp/subscription","commits_url":"https://api.github.com/repos/flowher/rnp/commits{/sha}","git_commits_url":"https://api.github.com/repos/flowher/rnp/git/commits{/sha}","comments_url":"https://api.github.com/repos/flowher/rnp/comments{/number}","issue_comment_url":"https://api.github.com/repos/flowher/rnp/issues/comments{/number}","contents_url":"https://api.github.com/repos/flowher/rnp/contents/{+path}","compare_url":"https://api.github.com/repos/flowher/rnp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flowher/rnp/merges","archive_url":"https://api.github.com/repos/flowher/rnp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flowher/rnp/downloads","issues_url":"https://api.github.com/repos/flowher/rnp/issues{/number}","pulls_url":"https://api.github.com/repos/flowher/rnp/pulls{/number}","milestones_url":"https://api.github.com/repos/flowher/rnp/milestones{/number}","notifications_url":"https://api.github.com/repos/flowher/rnp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flowher/rnp/labels{/name}","releases_url":"https://api.github.com/repos/flowher/rnp/releases{/id}","deployments_url":"https://api.github.com/repos/flowher/rnp/deployments","created_at":"2017-04-15T16:29:27Z","updated_at":"2017-04-15T16:29:29Z","pushed_at":"2018-02-01T08:08:39Z","git_url":"git://github.com/flowher/rnp.git","ssh_url":"git@github.com:flowher/rnp.git","clone_url":"https://github.com/flowher/rnp.git","svn_url":"https://github.com/flowher/rnp","homepage":"","size":8234,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"riboseinc:master","ref":"master","sha":"fb1bd7a56bd1fe3325bb39079e1ca97ac6bdd997","user":{"login":"riboseinc","id":24904375,"avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"repo":{"id":84580444,"name":"rnp","full_name":"riboseinc/rnp","owner":{"login":"riboseinc","id":24904375,"avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riboseinc/rnp","description":"rnp is a C library approach to OpenPGP; GnuPG alternative","fork":false,"url":"https://api.github.com/repos/riboseinc/rnp","forks_url":"https://api.github.com/repos/riboseinc/rnp/forks","keys_url":"https://api.github.com/repos/riboseinc/rnp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riboseinc/rnp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riboseinc/rnp/teams","hooks_url":"https://api.github.com/repos/riboseinc/rnp/hooks","issue_events_url":"https://api.github.com/repos/riboseinc/rnp/issues/events{/number}","events_url":"https://api.github.com/repos/riboseinc/rnp/events","assignees_url":"https://api.github.com/repos/riboseinc/rnp/assignees{/user}","branches_url":"https://api.github.com/repos/riboseinc/rnp/branches{/branch}","tags_url":"https://api.github.com/repos/riboseinc/rnp/tags","blobs_url":"https://api.github.com/repos/riboseinc/rnp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riboseinc/rnp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riboseinc/rnp/git/refs{/sha}","trees_url":"https://api.github.com/repos/riboseinc/rnp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riboseinc/rnp/statuses/{sha}","languages_url":"https://api.github.com/repos/riboseinc/rnp/languages","stargazers_url":"https://api.github.com/repos/riboseinc/rnp/stargazers","contributors_url":"https://api.github.com/repos/riboseinc/rnp/contributors","subscribers_url":"https://api.github.com/repos/riboseinc/rnp/subscribers","subscription_url":"https://api.github.com/repos/riboseinc/rnp/subscription","commits_url":"https://api.github.com/repos/riboseinc/rnp/commits{/sha}","git_commits_url":"https://api.github.com/repos/riboseinc/rnp/git/commits{/sha}","comments_url":"https://api.github.com/repos/riboseinc/rnp/comments{/number}","issue_comment_url":"https://api.github.com/repos/riboseinc/rnp/issues/comments{/number}","contents_url":"https://api.github.com/repos/riboseinc/rnp/contents/{+path}","compare_url":"https://api.github.com/repos/riboseinc/rnp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riboseinc/rnp/merges","archive_url":"https://api.github.com/repos/riboseinc/rnp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riboseinc/rnp/downloads","issues_url":"https://api.github.com/repos/riboseinc/rnp/issues{/number}","pulls_url":"https://api.github.com/repos/riboseinc/rnp/pulls{/number}","milestones_url":"https://api.github.com/repos/riboseinc/rnp/milestones{/number}","notifications_url":"https://api.github.com/repos/riboseinc/rnp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riboseinc/rnp/labels{/name}","releases_url":"https://api.github.com/repos/riboseinc/rnp/releases{/id}","deployments_url":"https://api.github.com/repos/riboseinc/rnp/deployments","created_at":"2017-03-10T16:41:47Z","updated_at":"2018-01-30T10:03:21Z","pushed_at":"2018-02-01T09:38:24Z","git_url":"git://github.com/riboseinc/rnp.git","ssh_url":"git@github.com:riboseinc/rnp.git","clone_url":"https://github.com/riboseinc/rnp.git","svn_url":"https://github.com/riboseinc/rnp","homepage":"","size":10250,"stargazers_count":21,"watchers_count":21,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":141,"license":null,"forks":8,"open_issues":141,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/608"},"html":{"href":"https://github.com/riboseinc/rnp/pull/608"},"issue":{"href":"https://api.github.com/repos/riboseinc/rnp/issues/608"},"comments":{"href":"https://api.github.com/repos/riboseinc/rnp/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/riboseinc/rnp/statuses/aa7ed36c7ff00fa250f4e057a7321db72be3d343"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"flowher"}}