{"action":"created","comment":{"url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments/206513118","pull_request_review_id":141935510,"id":206513118,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjUxMzExOA==","diff_hunk":"@@ -5,7 +5,7 @@\n     on_supported_os.each do |os, facts|\n       context \"on #{os}\" do\n         let(:facts) do\n-          if ['RedHat','CentOS'].include?(facts[:operatingsystem]) && facts[:operatingsystemmajrelease].to_s < '7'\n+          if facts[:operatingsystemmajrelease].to_s < '7'","path":"spec/classes/server/ldap_spec.rb","position":5,"original_position":5,"commit_id":"5cd45fd4ca4096eeaf48f671a8e6ec4257ed459a","original_commit_id":"5cd45fd4ca4096eeaf48f671a8e6ec4257ed459a","user":{"login":"trevor-vaughan","id":4982601,"node_id":"MDQ6VXNlcjQ5ODI2MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/4982601?v=4","gravatar_id":"","url":"https://api.github.com/users/trevor-vaughan","html_url":"https://github.com/trevor-vaughan","followers_url":"https://api.github.com/users/trevor-vaughan/followers","following_url":"https://api.github.com/users/trevor-vaughan/following{/other_user}","gists_url":"https://api.github.com/users/trevor-vaughan/gists{/gist_id}","starred_url":"https://api.github.com/users/trevor-vaughan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevor-vaughan/subscriptions","organizations_url":"https://api.github.com/users/trevor-vaughan/orgs","repos_url":"https://api.github.com/users/trevor-vaughan/repos","events_url":"https://api.github.com/users/trevor-vaughan/events{/privacy}","received_events_url":"https://api.github.com/users/trevor-vaughan/received_events","type":"User","site_admin":false},"body":"This really should be matched against the supported list as it was before. It's more tedious, but we have added SuSE to a few modules and may add it to more and we'll have to go through and re-fix all of these.","created_at":"2018-07-31T12:52:37Z","updated_at":"2018-07-31T12:53:13Z","html_url":"https://github.com/simp/pupmod-simp-simp/pull/165#discussion_r206513118","pull_request_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments/206513118"},"html":{"href":"https://github.com/simp/pupmod-simp-simp/pull/165#discussion_r206513118"},"pull_request":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165","id":203354329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzU0MzI5","html_url":"https://github.com/simp/pupmod-simp-simp/pull/165","diff_url":"https://github.com/simp/pupmod-simp-simp/pull/165.diff","patch_url":"https://github.com/simp/pupmod-simp-simp/pull/165.patch","issue_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/165","number":165,"state":"open","locked":false,"title":"(SIMP-4009) Update to support Puppet 5 and OEL","user":{"login":"jeefberkey","id":8931085,"node_id":"MDQ6VXNlcjg5MzEwODU=","avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"body":" - Added tests and support for OEL and Puppet 5\r\n  - Setting the default filebucket in a module no longer works, so\r\n    ``simp::enable_filebucketing`` will do nothing in puppet version >= 5\r\n- Fixed some linting issues \r\n\r\nSIMP-4009 #comment update simp","created_at":"2018-07-23T21:52:07Z","updated_at":"2018-07-31T12:53:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95572076de5e1cd5a14857f3a29359d64a85b017","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165/commits","review_comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165/comments","review_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/165/comments","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/5cd45fd4ca4096eeaf48f671a8e6ec4257ed459a","head":{"label":"jeefberkey:SIMP-4009","ref":"SIMP-4009","sha":"5cd45fd4ca4096eeaf48f671a8e6ec4257ed459a","user":{"login":"jeefberkey","id":8931085,"node_id":"MDQ6VXNlcjg5MzEwODU=","avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"repo":{"id":41604145,"node_id":"MDEwOlJlcG9zaXRvcnk0MTYwNDE0NQ==","name":"pupmod-simp-simp","full_name":"jeefberkey/pupmod-simp-simp","owner":{"login":"jeefberkey","id":8931085,"node_id":"MDQ6VXNlcjg5MzEwODU=","avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeefberkey/pupmod-simp-simp","description":"The SIMP simp Puppet Module","fork":true,"url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp","forks_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/forks","keys_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/teams","hooks_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/hooks","issue_events_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/issues/events{/number}","events_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/events","assignees_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/assignees{/user}","branches_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/branches{/branch}","tags_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/tags","blobs_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/statuses/{sha}","languages_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/languages","stargazers_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/stargazers","contributors_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/contributors","subscribers_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/subscribers","subscription_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/subscription","commits_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/contents/{+path}","compare_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/merges","archive_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/downloads","issues_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/issues{/number}","pulls_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/pulls{/number}","milestones_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/milestones{/number}","notifications_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/labels{/name}","releases_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/releases{/id}","deployments_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/deployments","created_at":"2015-08-29T19:05:35Z","updated_at":"2018-06-19T14:54:01Z","pushed_at":"2018-07-25T19:26:43Z","git_url":"git://github.com/jeefberkey/pupmod-simp-simp.git","ssh_url":"git@github.com:jeefberkey/pupmod-simp-simp.git","clone_url":"https://github.com/jeefberkey/pupmod-simp-simp.git","svn_url":"https://github.com/jeefberkey/pupmod-simp-simp","homepage":null,"size":628,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simp:master","ref":"master","sha":"c8a7b531f9dce2d761c658f4b0b3113c16850b13","user":{"login":"simp","id":12174186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTc0MTg2","avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"repo":{"id":35873685,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg3MzY4NQ==","name":"pupmod-simp-simp","full_name":"simp/pupmod-simp-simp","owner":{"login":"simp","id":12174186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTc0MTg2","avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simp/pupmod-simp-simp","description":"The SIMP simp Puppet Module","fork":false,"url":"https://api.github.com/repos/simp/pupmod-simp-simp","forks_url":"https://api.github.com/repos/simp/pupmod-simp-simp/forks","keys_url":"https://api.github.com/repos/simp/pupmod-simp-simp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simp/pupmod-simp-simp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simp/pupmod-simp-simp/teams","hooks_url":"https://api.github.com/repos/simp/pupmod-simp-simp/hooks","issue_events_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/events{/number}","events_url":"https://api.github.com/repos/simp/pupmod-simp-simp/events","assignees_url":"https://api.github.com/repos/simp/pupmod-simp-simp/assignees{/user}","branches_url":"https://api.github.com/repos/simp/pupmod-simp-simp/branches{/branch}","tags_url":"https://api.github.com/repos/simp/pupmod-simp-simp/tags","blobs_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/refs{/sha}","trees_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/{sha}","languages_url":"https://api.github.com/repos/simp/pupmod-simp-simp/languages","stargazers_url":"https://api.github.com/repos/simp/pupmod-simp-simp/stargazers","contributors_url":"https://api.github.com/repos/simp/pupmod-simp-simp/contributors","subscribers_url":"https://api.github.com/repos/simp/pupmod-simp-simp/subscribers","subscription_url":"https://api.github.com/repos/simp/pupmod-simp-simp/subscription","commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/commits{/sha}","git_commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/commits{/sha}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/comments{/number}","issue_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/comments{/number}","contents_url":"https://api.github.com/repos/simp/pupmod-simp-simp/contents/{+path}","compare_url":"https://api.github.com/repos/simp/pupmod-simp-simp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simp/pupmod-simp-simp/merges","archive_url":"https://api.github.com/repos/simp/pupmod-simp-simp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simp/pupmod-simp-simp/downloads","issues_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues{/number}","pulls_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls{/number}","milestones_url":"https://api.github.com/repos/simp/pupmod-simp-simp/milestones{/number}","notifications_url":"https://api.github.com/repos/simp/pupmod-simp-simp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simp/pupmod-simp-simp/labels{/name}","releases_url":"https://api.github.com/repos/simp/pupmod-simp-simp/releases{/id}","deployments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/deployments","created_at":"2015-05-19T09:49:41Z","updated_at":"2018-07-23T19:12:24Z","pushed_at":"2018-07-25T19:26:44Z","git_url":"git://github.com/simp/pupmod-simp-simp.git","ssh_url":"git@github.com:simp/pupmod-simp-simp.git","clone_url":"https://github.com/simp/pupmod-simp-simp.git","svn_url":"https://github.com/simp/pupmod-simp-simp","homepage":null,"size":633,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165"},"html":{"href":"https://github.com/simp/pupmod-simp-simp/pull/165"},"issue":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/165"},"comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/5cd45fd4ca4096eeaf48f671a8e6ec4257ed459a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"trevor-vaughan"}}