{"action":"created","comment":{"url":"https://api.github.com/repos/gae123/sd2/pulls/comments/221434868","pull_request_review_id":160088176,"id":221434868,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQzNDg2OA==","diff_hunk":"@@ -156,33 +164,32 @@ def __init__(self, args, workspaces):\n             logging.info(\"%s %s\", wi['name'], strcmd)\n             wi['fswatchproc'] = subprocess.Popen(\n                 strcmd,\n-                shell=True,\n-                bufsize=1,  # line buffered\n+                shell=True, # with this option the pid returned is of the shell: https://docs.python.org/2/library/subprocess.html#subprocess.Popen.pid\n+                bufsize=1, # line buffered\n                 stdout=subprocess.PIPE,\n                 # stderr=subprocess.PIPE,\n                 close_fds=ON_POSIX\n             )\n             fl = fcntl.fcntl(wi['fswatchproc'].stdout, fcntl.F_GETFL)\n-            fcntl.fcntl(wi['fswatchproc'].stdout, fcntl.F_SETFL,\n-                        fl | os.O_NONBLOCK)\n+            fcntl.fcntl(wi['fswatchproc'].stdout, fcntl.F_SETFL, fl | os.O_NONBLOCK)\n         logging.debug(\"FSW:LL\")\n \n     def poll(self):\n         for ws in self._workspaces:\n             proc = ws['fswatchproc']\n             try:\n-                line = proc.stdout.readline().strip()\n+                line = proc.stdout.readline()","path":"src/lib/sd2/fswatch_connections.py","position":46,"original_position":38,"commit_id":"9bcd16a11d76fb5127e601913d252e4779f3ec40","original_commit_id":"1efff84dc4bb2fd69ac002e4e6671c4bd58f9a70","user":{"login":"zachkont","id":17274058,"node_id":"MDQ6VXNlcjE3Mjc0MDU4","avatar_url":"https://avatars0.githubusercontent.com/u/17274058?v=4","gravatar_id":"","url":"https://api.github.com/users/zachkont","html_url":"https://github.com/zachkont","followers_url":"https://api.github.com/users/zachkont/followers","following_url":"https://api.github.com/users/zachkont/following{/other_user}","gists_url":"https://api.github.com/users/zachkont/gists{/gist_id}","starred_url":"https://api.github.com/users/zachkont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachkont/subscriptions","organizations_url":"https://api.github.com/users/zachkont/orgs","repos_url":"https://api.github.com/users/zachkont/repos","events_url":"https://api.github.com/users/zachkont/events{/privacy}","received_events_url":"https://api.github.com/users/zachkont/received_events","type":"User","site_admin":false},"body":"As they are all part of the same logic I though it best to group them up. Reverted anyway","created_at":"2018-09-29T17:35:27Z","updated_at":"2018-09-29T17:35:28Z","html_url":"https://github.com/gae123/sd2/pull/3#discussion_r221434868","pull_request_url":"https://api.github.com/repos/gae123/sd2/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gae123/sd2/pulls/comments/221434868"},"html":{"href":"https://github.com/gae123/sd2/pull/3#discussion_r221434868"},"pull_request":{"href":"https://api.github.com/repos/gae123/sd2/pulls/3"}},"in_reply_to_id":221331596},"pull_request":{"url":"https://api.github.com/repos/gae123/sd2/pulls/3","id":218920801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTIwODAx","html_url":"https://github.com/gae123/sd2/pull/3","diff_url":"https://github.com/gae123/sd2/pull/3.diff","patch_url":"https://github.com/gae123/sd2/pull/3.patch","issue_url":"https://api.github.com/repos/gae123/sd2/issues/3","number":3,"state":"open","locked":false,"title":"Fix fswatch behaviour on linux","user":{"login":"zachkont","id":17274058,"node_id":"MDQ6VXNlcjE3Mjc0MDU4","avatar_url":"https://avatars0.githubusercontent.com/u/17274058?v=4","gravatar_id":"","url":"https://api.github.com/users/zachkont","html_url":"https://github.com/zachkont","followers_url":"https://api.github.com/users/zachkont/followers","following_url":"https://api.github.com/users/zachkont/following{/other_user}","gists_url":"https://api.github.com/users/zachkont/gists{/gist_id}","starred_url":"https://api.github.com/users/zachkont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachkont/subscriptions","organizations_url":"https://api.github.com/users/zachkont/orgs","repos_url":"https://api.github.com/users/zachkont/repos","events_url":"https://api.github.com/users/zachkont/events{/privacy}","received_events_url":"https://api.github.com/users/zachkont/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-28T10:19:06Z","updated_at":"2018-09-29T17:35:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7568f7dfa2fec1ae83762478e4e3cf59f2065a2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gae123/sd2/pulls/3/commits","review_comments_url":"https://api.github.com/repos/gae123/sd2/pulls/3/comments","review_comment_url":"https://api.github.com/repos/gae123/sd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gae123/sd2/issues/3/comments","statuses_url":"https://api.github.com/repos/gae123/sd2/statuses/9bcd16a11d76fb5127e601913d252e4779f3ec40","head":{"label":"zachkont:linux-amends","ref":"linux-amends","sha":"9bcd16a11d76fb5127e601913d252e4779f3ec40","user":{"login":"zachkont","id":17274058,"node_id":"MDQ6VXNlcjE3Mjc0MDU4","avatar_url":"https://avatars0.githubusercontent.com/u/17274058?v=4","gravatar_id":"","url":"https://api.github.com/users/zachkont","html_url":"https://github.com/zachkont","followers_url":"https://api.github.com/users/zachkont/followers","following_url":"https://api.github.com/users/zachkont/following{/other_user}","gists_url":"https://api.github.com/users/zachkont/gists{/gist_id}","starred_url":"https://api.github.com/users/zachkont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachkont/subscriptions","organizations_url":"https://api.github.com/users/zachkont/orgs","repos_url":"https://api.github.com/users/zachkont/repos","events_url":"https://api.github.com/users/zachkont/events{/privacy}","received_events_url":"https://api.github.com/users/zachkont/received_events","type":"User","site_admin":false},"repo":{"id":150722875,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3MjI4NzU=","name":"sd2","full_name":"zachkont/sd2","private":false,"owner":{"login":"zachkont","id":17274058,"node_id":"MDQ6VXNlcjE3Mjc0MDU4","avatar_url":"https://avatars0.githubusercontent.com/u/17274058?v=4","gravatar_id":"","url":"https://api.github.com/users/zachkont","html_url":"https://github.com/zachkont","followers_url":"https://api.github.com/users/zachkont/followers","following_url":"https://api.github.com/users/zachkont/following{/other_user}","gists_url":"https://api.github.com/users/zachkont/gists{/gist_id}","starred_url":"https://api.github.com/users/zachkont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachkont/subscriptions","organizations_url":"https://api.github.com/users/zachkont/orgs","repos_url":"https://api.github.com/users/zachkont/repos","events_url":"https://api.github.com/users/zachkont/events{/privacy}","received_events_url":"https://api.github.com/users/zachkont/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zachkont/sd2","description":"A tool to support SD2™, the Software Defined Software Development Process","fork":true,"url":"https://api.github.com/repos/zachkont/sd2","forks_url":"https://api.github.com/repos/zachkont/sd2/forks","keys_url":"https://api.github.com/repos/zachkont/sd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zachkont/sd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zachkont/sd2/teams","hooks_url":"https://api.github.com/repos/zachkont/sd2/hooks","issue_events_url":"https://api.github.com/repos/zachkont/sd2/issues/events{/number}","events_url":"https://api.github.com/repos/zachkont/sd2/events","assignees_url":"https://api.github.com/repos/zachkont/sd2/assignees{/user}","branches_url":"https://api.github.com/repos/zachkont/sd2/branches{/branch}","tags_url":"https://api.github.com/repos/zachkont/sd2/tags","blobs_url":"https://api.github.com/repos/zachkont/sd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zachkont/sd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zachkont/sd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/zachkont/sd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zachkont/sd2/statuses/{sha}","languages_url":"https://api.github.com/repos/zachkont/sd2/languages","stargazers_url":"https://api.github.com/repos/zachkont/sd2/stargazers","contributors_url":"https://api.github.com/repos/zachkont/sd2/contributors","subscribers_url":"https://api.github.com/repos/zachkont/sd2/subscribers","subscription_url":"https://api.github.com/repos/zachkont/sd2/subscription","commits_url":"https://api.github.com/repos/zachkont/sd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/zachkont/sd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/zachkont/sd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/zachkont/sd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/zachkont/sd2/contents/{+path}","compare_url":"https://api.github.com/repos/zachkont/sd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zachkont/sd2/merges","archive_url":"https://api.github.com/repos/zachkont/sd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zachkont/sd2/downloads","issues_url":"https://api.github.com/repos/zachkont/sd2/issues{/number}","pulls_url":"https://api.github.com/repos/zachkont/sd2/pulls{/number}","milestones_url":"https://api.github.com/repos/zachkont/sd2/milestones{/number}","notifications_url":"https://api.github.com/repos/zachkont/sd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zachkont/sd2/labels{/name}","releases_url":"https://api.github.com/repos/zachkont/sd2/releases{/id}","deployments_url":"https://api.github.com/repos/zachkont/sd2/deployments","created_at":"2018-09-28T10:15:14Z","updated_at":"2018-09-28T10:15:16Z","pushed_at":"2018-09-29T17:34:37Z","git_url":"git://github.com/zachkont/sd2.git","ssh_url":"git@github.com:zachkont/sd2.git","clone_url":"https://github.com/zachkont/sd2.git","svn_url":"https://github.com/zachkont/sd2","homepage":"","size":204,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gae123:master","ref":"master","sha":"57780b14e7d9a4d9fec175a1a20c35a2631b6660","user":{"login":"gae123","id":6157123,"node_id":"MDQ6VXNlcjYxNTcxMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6157123?v=4","gravatar_id":"","url":"https://api.github.com/users/gae123","html_url":"https://github.com/gae123","followers_url":"https://api.github.com/users/gae123/followers","following_url":"https://api.github.com/users/gae123/following{/other_user}","gists_url":"https://api.github.com/users/gae123/gists{/gist_id}","starred_url":"https://api.github.com/users/gae123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gae123/subscriptions","organizations_url":"https://api.github.com/users/gae123/orgs","repos_url":"https://api.github.com/users/gae123/repos","events_url":"https://api.github.com/users/gae123/events{/privacy}","received_events_url":"https://api.github.com/users/gae123/received_events","type":"User","site_admin":false},"repo":{"id":90093371,"node_id":"MDEwOlJlcG9zaXRvcnk5MDA5MzM3MQ==","name":"sd2","full_name":"gae123/sd2","private":false,"owner":{"login":"gae123","id":6157123,"node_id":"MDQ6VXNlcjYxNTcxMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6157123?v=4","gravatar_id":"","url":"https://api.github.com/users/gae123","html_url":"https://github.com/gae123","followers_url":"https://api.github.com/users/gae123/followers","following_url":"https://api.github.com/users/gae123/following{/other_user}","gists_url":"https://api.github.com/users/gae123/gists{/gist_id}","starred_url":"https://api.github.com/users/gae123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gae123/subscriptions","organizations_url":"https://api.github.com/users/gae123/orgs","repos_url":"https://api.github.com/users/gae123/repos","events_url":"https://api.github.com/users/gae123/events{/privacy}","received_events_url":"https://api.github.com/users/gae123/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gae123/sd2","description":"A tool to support SD2™, the Software Defined Software Development Process","fork":false,"url":"https://api.github.com/repos/gae123/sd2","forks_url":"https://api.github.com/repos/gae123/sd2/forks","keys_url":"https://api.github.com/repos/gae123/sd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gae123/sd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gae123/sd2/teams","hooks_url":"https://api.github.com/repos/gae123/sd2/hooks","issue_events_url":"https://api.github.com/repos/gae123/sd2/issues/events{/number}","events_url":"https://api.github.com/repos/gae123/sd2/events","assignees_url":"https://api.github.com/repos/gae123/sd2/assignees{/user}","branches_url":"https://api.github.com/repos/gae123/sd2/branches{/branch}","tags_url":"https://api.github.com/repos/gae123/sd2/tags","blobs_url":"https://api.github.com/repos/gae123/sd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gae123/sd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gae123/sd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gae123/sd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gae123/sd2/statuses/{sha}","languages_url":"https://api.github.com/repos/gae123/sd2/languages","stargazers_url":"https://api.github.com/repos/gae123/sd2/stargazers","contributors_url":"https://api.github.com/repos/gae123/sd2/contributors","subscribers_url":"https://api.github.com/repos/gae123/sd2/subscribers","subscription_url":"https://api.github.com/repos/gae123/sd2/subscription","commits_url":"https://api.github.com/repos/gae123/sd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gae123/sd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gae123/sd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gae123/sd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gae123/sd2/contents/{+path}","compare_url":"https://api.github.com/repos/gae123/sd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gae123/sd2/merges","archive_url":"https://api.github.com/repos/gae123/sd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gae123/sd2/downloads","issues_url":"https://api.github.com/repos/gae123/sd2/issues{/number}","pulls_url":"https://api.github.com/repos/gae123/sd2/pulls{/number}","milestones_url":"https://api.github.com/repos/gae123/sd2/milestones{/number}","notifications_url":"https://api.github.com/repos/gae123/sd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gae123/sd2/labels{/name}","releases_url":"https://api.github.com/repos/gae123/sd2/releases{/id}","deployments_url":"https://api.github.com/repos/gae123/sd2/deployments","created_at":"2017-05-03T01:06:30Z","updated_at":"2018-08-03T22:01:46Z","pushed_at":"2018-09-29T17:34:38Z","git_url":"git://github.com/gae123/sd2.git","ssh_url":"git@github.com:gae123/sd2.git","clone_url":"https://github.com/gae123/sd2.git","svn_url":"https://github.com/gae123/sd2","homepage":"","size":203,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gae123/sd2/pulls/3"},"html":{"href":"https://github.com/gae123/sd2/pull/3"},"issue":{"href":"https://api.github.com/repos/gae123/sd2/issues/3"},"comments":{"href":"https://api.github.com/repos/gae123/sd2/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/gae123/sd2/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/gae123/sd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gae123/sd2/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/gae123/sd2/statuses/9bcd16a11d76fb5127e601913d252e4779f3ec40"}},"author_association":"NONE"}}
{"actor":{"display_login":"zachkont"}}