{"action":"closed","number":6632,"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6632","id":197476509,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDc2NTA5","html_url":"https://github.com/istio/istio/pull/6632","diff_url":"https://github.com/istio/istio/pull/6632.diff","patch_url":"https://github.com/istio/istio/pull/6632.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/6632","number":6632,"state":"closed","locked":false,"title":"Fixed a flaky controller test","user":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"body":"The Kube ServiceRegistry controller test was very flaky and often fails in tests with:\r\n\r\n```sh\r\n--- FAIL: TestServices (0.63s)\r\n\tcontroller_test.go:120: Invalid response for GetInstancesByPort []\r\nFAIL\r\nFAIL\tistio.io/istio/pilot/pkg/serviceregistry/kube\t0.704s\r\n```\r\n\r\nThe reason is that the test continued immediately after the matching service was found and before waiting for the endpoints to propagate correctly.","created_at":"2018-06-26T16:09:07Z","updated_at":"2018-06-26T18:45:38Z","closed_at":"2018-06-26T18:45:38Z","merged_at":"2018-06-26T18:45:38Z","merge_commit_sha":"6ae8a4abe3e93b56a5170312bb3ac979e9a68401","assignee":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"assignees":[{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"ayj","id":116378,"node_id":"MDQ6VXNlcjExNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"node_id":"MDU6TGFiZWw2NjA1NTY5ODY=","url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/6632/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/6632/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/6632/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/efa504b01f115f3bcc87c3464674cde68c022922","head":{"label":"ymesika:flakeFix","ref":"flakeFix","sha":"efa504b01f115f3bcc87c3464674cde68c022922","user":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"repo":{"id":109562402,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1NjI0MDI=","name":"istio","full_name":"ymesika/istio","owner":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ymesika/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/ymesika/istio","forks_url":"https://api.github.com/repos/ymesika/istio/forks","keys_url":"https://api.github.com/repos/ymesika/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ymesika/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ymesika/istio/teams","hooks_url":"https://api.github.com/repos/ymesika/istio/hooks","issue_events_url":"https://api.github.com/repos/ymesika/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ymesika/istio/events","assignees_url":"https://api.github.com/repos/ymesika/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ymesika/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ymesika/istio/tags","blobs_url":"https://api.github.com/repos/ymesika/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ymesika/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ymesika/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ymesika/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ymesika/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ymesika/istio/languages","stargazers_url":"https://api.github.com/repos/ymesika/istio/stargazers","contributors_url":"https://api.github.com/repos/ymesika/istio/contributors","subscribers_url":"https://api.github.com/repos/ymesika/istio/subscribers","subscription_url":"https://api.github.com/repos/ymesika/istio/subscription","commits_url":"https://api.github.com/repos/ymesika/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ymesika/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ymesika/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ymesika/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ymesika/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ymesika/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ymesika/istio/merges","archive_url":"https://api.github.com/repos/ymesika/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ymesika/istio/downloads","issues_url":"https://api.github.com/repos/ymesika/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ymesika/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ymesika/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ymesika/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ymesika/istio/labels{/name}","releases_url":"https://api.github.com/repos/ymesika/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ymesika/istio/deployments","created_at":"2017-11-05T09:15:48Z","updated_at":"2018-05-13T07:28:45Z","pushed_at":"2018-06-26T16:06:24Z","git_url":"git://github.com/ymesika/istio.git","ssh_url":"git@github.com:ymesika/istio.git","clone_url":"https://github.com/ymesika/istio.git","svn_url":"https://github.com/ymesika/istio","homepage":"https://istio.io","size":39471,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"beceb07af9bb63b83691bf7df10231a7ac6c0e55","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-06-26T17:17:52Z","pushed_at":"2018-06-26T18:45:38Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":39950,"stargazers_count":8879,"watchers_count":8879,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1220,"mirror_url":null,"archived":false,"open_issues_count":798,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1220,"open_issues":798,"watchers":8879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/6632"},"html":{"href":"https://github.com/istio/istio/pull/6632"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/6632"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/6632/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/6632/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/6632/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/efa504b01f115f3bcc87c3464674cde68c022922"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":7,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"istio-testing"}}