{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/tsdb/pulls/comments/227683193","pull_request_review_id":167778818,"id":227683193,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzY4MzE5Mw==","diff_hunk":"@@ -29,7 +30,8 @@ import (\n )\n \n func BenchmarkCreateSeries(b *testing.B) {\n-\tlbls, err := labels.ReadLabels(\"testdata/20kseries.json\", b.N)\n+\tseriesPath := filepath.Join(\"testdata\", \"20kseries.json\")\n+\tlbls, err := labels.ReadLabels(seriesPath, b.N)","path":"head_test.go","position":14,"original_position":14,"commit_id":"d2bb3f3fbbd10bde3039114b822a09349b53529c","original_commit_id":"d2bb3f3fbbd10bde3039114b822a09349b53529c","user":{"login":"krasi-georgiev","id":8903888,"node_id":"MDQ6VXNlcjg5MDM4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/8903888?v=4","gravatar_id":"","url":"https://api.github.com/users/krasi-georgiev","html_url":"https://github.com/krasi-georgiev","followers_url":"https://api.github.com/users/krasi-georgiev/followers","following_url":"https://api.github.com/users/krasi-georgiev/following{/other_user}","gists_url":"https://api.github.com/users/krasi-georgiev/gists{/gist_id}","starred_url":"https://api.github.com/users/krasi-georgiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasi-georgiev/subscriptions","organizations_url":"https://api.github.com/users/krasi-georgiev/orgs","repos_url":"https://api.github.com/users/krasi-georgiev/repos","events_url":"https://api.github.com/users/krasi-georgiev/events{/privacy}","received_events_url":"https://api.github.com/users/krasi-georgiev/received_events","type":"User","site_admin":false},"body":"no need for a separate var\r\n`lbls, err := labels.ReadLabels(filepath.Join(\"testdata\", \"20kseries.json\"), b.N)`\r\n\r\nthe same for the other places","created_at":"2018-10-24T08:12:42Z","updated_at":"2018-10-24T08:13:55Z","html_url":"https://github.com/prometheus/tsdb/pull/428#discussion_r227683193","pull_request_url":"https://api.github.com/repos/prometheus/tsdb/pulls/428","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prometheus/tsdb/pulls/comments/227683193"},"html":{"href":"https://github.com/prometheus/tsdb/pull/428#discussion_r227683193"},"pull_request":{"href":"https://api.github.com/repos/prometheus/tsdb/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/tsdb/pulls/428","id":225218190,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjE4MTkw","html_url":"https://github.com/prometheus/tsdb/pull/428","diff_url":"https://github.com/prometheus/tsdb/pull/428.diff","patch_url":"https://github.com/prometheus/tsdb/pull/428.patch","issue_url":"https://api.github.com/repos/prometheus/tsdb/issues/428","number":428,"state":"open","locked":false,"title":"Using filepath.Join() instead of strings with slashes","user":{"login":"ben-dasilva","id":151104,"node_id":"MDQ6VXNlcjE1MTEwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/151104?v=4","gravatar_id":"","url":"https://api.github.com/users/ben-dasilva","html_url":"https://github.com/ben-dasilva","followers_url":"https://api.github.com/users/ben-dasilva/followers","following_url":"https://api.github.com/users/ben-dasilva/following{/other_user}","gists_url":"https://api.github.com/users/ben-dasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-dasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-dasilva/subscriptions","organizations_url":"https://api.github.com/users/ben-dasilva/orgs","repos_url":"https://api.github.com/users/ben-dasilva/repos","events_url":"https://api.github.com/users/ben-dasilva/events{/privacy}","received_events_url":"https://api.github.com/users/ben-dasilva/received_events","type":"User","site_admin":false},"body":"fixes: https://github.com/prometheus/tsdb/issues/426\r\nUsing `filepath.Join()` instead of strings containing forward slash path delimiters (needed for non-*nix OSes), as suggested by @krasi-georgiev \r\n\r\nI hope it can be useful.\r\n\r\nThanks & best regards,\r\n- Ben","created_at":"2018-10-23T23:23:59Z","updated_at":"2018-10-24T08:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4a2ae6fc5bbdef7e0a5a493ede63b88edcd15c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/tsdb/pulls/428/commits","review_comments_url":"https://api.github.com/repos/prometheus/tsdb/pulls/428/comments","review_comment_url":"https://api.github.com/repos/prometheus/tsdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/tsdb/issues/428/comments","statuses_url":"https://api.github.com/repos/prometheus/tsdb/statuses/d2bb3f3fbbd10bde3039114b822a09349b53529c","head":{"label":"ben-dasilva:feature/426-replace-path-delimiter","ref":"feature/426-replace-path-delimiter","sha":"d2bb3f3fbbd10bde3039114b822a09349b53529c","user":{"login":"ben-dasilva","id":151104,"node_id":"MDQ6VXNlcjE1MTEwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/151104?v=4","gravatar_id":"","url":"https://api.github.com/users/ben-dasilva","html_url":"https://github.com/ben-dasilva","followers_url":"https://api.github.com/users/ben-dasilva/followers","following_url":"https://api.github.com/users/ben-dasilva/following{/other_user}","gists_url":"https://api.github.com/users/ben-dasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-dasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-dasilva/subscriptions","organizations_url":"https://api.github.com/users/ben-dasilva/orgs","repos_url":"https://api.github.com/users/ben-dasilva/repos","events_url":"https://api.github.com/users/ben-dasilva/events{/privacy}","received_events_url":"https://api.github.com/users/ben-dasilva/received_events","type":"User","site_admin":false},"repo":{"id":154407436,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0MDc0MzY=","name":"tsdb","full_name":"ben-dasilva/tsdb","private":false,"owner":{"login":"ben-dasilva","id":151104,"node_id":"MDQ6VXNlcjE1MTEwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/151104?v=4","gravatar_id":"","url":"https://api.github.com/users/ben-dasilva","html_url":"https://github.com/ben-dasilva","followers_url":"https://api.github.com/users/ben-dasilva/followers","following_url":"https://api.github.com/users/ben-dasilva/following{/other_user}","gists_url":"https://api.github.com/users/ben-dasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-dasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-dasilva/subscriptions","organizations_url":"https://api.github.com/users/ben-dasilva/orgs","repos_url":"https://api.github.com/users/ben-dasilva/repos","events_url":"https://api.github.com/users/ben-dasilva/events{/privacy}","received_events_url":"https://api.github.com/users/ben-dasilva/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ben-dasilva/tsdb","description":"The Prometheus time series database layer.","fork":true,"url":"https://api.github.com/repos/ben-dasilva/tsdb","forks_url":"https://api.github.com/repos/ben-dasilva/tsdb/forks","keys_url":"https://api.github.com/repos/ben-dasilva/tsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ben-dasilva/tsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ben-dasilva/tsdb/teams","hooks_url":"https://api.github.com/repos/ben-dasilva/tsdb/hooks","issue_events_url":"https://api.github.com/repos/ben-dasilva/tsdb/issues/events{/number}","events_url":"https://api.github.com/repos/ben-dasilva/tsdb/events","assignees_url":"https://api.github.com/repos/ben-dasilva/tsdb/assignees{/user}","branches_url":"https://api.github.com/repos/ben-dasilva/tsdb/branches{/branch}","tags_url":"https://api.github.com/repos/ben-dasilva/tsdb/tags","blobs_url":"https://api.github.com/repos/ben-dasilva/tsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ben-dasilva/tsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ben-dasilva/tsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ben-dasilva/tsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ben-dasilva/tsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ben-dasilva/tsdb/languages","stargazers_url":"https://api.github.com/repos/ben-dasilva/tsdb/stargazers","contributors_url":"https://api.github.com/repos/ben-dasilva/tsdb/contributors","subscribers_url":"https://api.github.com/repos/ben-dasilva/tsdb/subscribers","subscription_url":"https://api.github.com/repos/ben-dasilva/tsdb/subscription","commits_url":"https://api.github.com/repos/ben-dasilva/tsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ben-dasilva/tsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ben-dasilva/tsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ben-dasilva/tsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ben-dasilva/tsdb/contents/{+path}","compare_url":"https://api.github.com/repos/ben-dasilva/tsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ben-dasilva/tsdb/merges","archive_url":"https://api.github.com/repos/ben-dasilva/tsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ben-dasilva/tsdb/downloads","issues_url":"https://api.github.com/repos/ben-dasilva/tsdb/issues{/number}","pulls_url":"https://api.github.com/repos/ben-dasilva/tsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ben-dasilva/tsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ben-dasilva/tsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ben-dasilva/tsdb/labels{/name}","releases_url":"https://api.github.com/repos/ben-dasilva/tsdb/releases{/id}","deployments_url":"https://api.github.com/repos/ben-dasilva/tsdb/deployments","created_at":"2018-10-23T22:58:49Z","updated_at":"2018-10-23T22:58:51Z","pushed_at":"2018-10-23T23:36:20Z","git_url":"git://github.com/ben-dasilva/tsdb.git","ssh_url":"git@github.com:ben-dasilva/tsdb.git","clone_url":"https://github.com/ben-dasilva/tsdb.git","svn_url":"https://github.com/ben-dasilva/tsdb","homepage":"","size":6052,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"f4afc7dff27bb6552c48b189f1f3cfdcf1e8114d","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":73823302,"node_id":"MDEwOlJlcG9zaXRvcnk3MzgyMzMwMg==","name":"tsdb","full_name":"prometheus/tsdb","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/tsdb","description":"The Prometheus time series database layer.","fork":false,"url":"https://api.github.com/repos/prometheus/tsdb","forks_url":"https://api.github.com/repos/prometheus/tsdb/forks","keys_url":"https://api.github.com/repos/prometheus/tsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/tsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/tsdb/teams","hooks_url":"https://api.github.com/repos/prometheus/tsdb/hooks","issue_events_url":"https://api.github.com/repos/prometheus/tsdb/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/tsdb/events","assignees_url":"https://api.github.com/repos/prometheus/tsdb/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/tsdb/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/tsdb/tags","blobs_url":"https://api.github.com/repos/prometheus/tsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/tsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/tsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/tsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/tsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/tsdb/languages","stargazers_url":"https://api.github.com/repos/prometheus/tsdb/stargazers","contributors_url":"https://api.github.com/repos/prometheus/tsdb/contributors","subscribers_url":"https://api.github.com/repos/prometheus/tsdb/subscribers","subscription_url":"https://api.github.com/repos/prometheus/tsdb/subscription","commits_url":"https://api.github.com/repos/prometheus/tsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/tsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/tsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/tsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/tsdb/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/tsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/tsdb/merges","archive_url":"https://api.github.com/repos/prometheus/tsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/tsdb/downloads","issues_url":"https://api.github.com/repos/prometheus/tsdb/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/tsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/tsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/tsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/tsdb/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/tsdb/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/tsdb/deployments","created_at":"2016-11-15T14:50:03Z","updated_at":"2018-10-23T21:35:59Z","pushed_at":"2018-10-23T23:36:21Z","git_url":"git://github.com/prometheus/tsdb.git","ssh_url":"git@github.com:prometheus/tsdb.git","clone_url":"https://github.com/prometheus/tsdb.git","svn_url":"https://github.com/prometheus/tsdb","homepage":"","size":6080,"stargazers_count":448,"watchers_count":448,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":95,"open_issues":69,"watchers":448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/tsdb/pulls/428"},"html":{"href":"https://github.com/prometheus/tsdb/pull/428"},"issue":{"href":"https://api.github.com/repos/prometheus/tsdb/issues/428"},"comments":{"href":"https://api.github.com/repos/prometheus/tsdb/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/tsdb/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/tsdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/tsdb/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/tsdb/statuses/d2bb3f3fbbd10bde3039114b822a09349b53529c"}},"author_association":"NONE"}}
{"actor":{"display_login":"krasi-georgiev"}}