{"action":"created","comment":{"url":"https://api.github.com/repos/mholt/caddy/pulls/comments/190791598","pull_request_review_id":123244971,"id":190791598,"diff_hunk":"@@ -90,6 +90,7 @@ func trapSignalsPosix() {\n \t\t\t\tpurgeEventHooks()\n \n \t\t\t\t// Kick off the restart; our work is done\n+\t\t\t\tEmitEvent(InstanceRestart, nil)","path":"sigtrap_posix.go","position":4,"original_position":4,"commit_id":"3338b7baa69a00ef6b0c78913b1bc7d480760c8d","original_commit_id":"3338b7baa69a00ef6b0c78913b1bc7d480760c8d","user":{"login":"francislavoie","id":2111701,"avatar_url":"https://avatars3.githubusercontent.com/u/2111701?v=4","gravatar_id":"","url":"https://api.github.com/users/francislavoie","html_url":"https://github.com/francislavoie","followers_url":"https://api.github.com/users/francislavoie/followers","following_url":"https://api.github.com/users/francislavoie/following{/other_user}","gists_url":"https://api.github.com/users/francislavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/francislavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francislavoie/subscriptions","organizations_url":"https://api.github.com/users/francislavoie/orgs","repos_url":"https://api.github.com/users/francislavoie/repos","events_url":"https://api.github.com/users/francislavoie/events{/privacy}","received_events_url":"https://api.github.com/users/francislavoie/received_events","type":"User","site_admin":false},"body":"You missed this one 😛 needs to be `InstanceRestartEvent` too","created_at":"2018-05-25T05:00:59Z","updated_at":"2018-05-25T05:00:59Z","html_url":"https://github.com/mholt/caddy/pull/2178#discussion_r190791598","pull_request_url":"https://api.github.com/repos/mholt/caddy/pulls/2178","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mholt/caddy/pulls/comments/190791598"},"html":{"href":"https://github.com/mholt/caddy/pull/2178#discussion_r190791598"},"pull_request":{"href":"https://api.github.com/repos/mholt/caddy/pulls/2178"}}},"pull_request":{"url":"https://api.github.com/repos/mholt/caddy/pulls/2178","id":189994694,"html_url":"https://github.com/mholt/caddy/pull/2178","diff_url":"https://github.com/mholt/caddy/pull/2178.diff","patch_url":"https://github.com/mholt/caddy/pull/2178.patch","issue_url":"https://api.github.com/repos/mholt/caddy/issues/2178","number":2178,"state":"open","locked":false,"title":"instance restart (reload) event","user":{"login":"sirkon","id":56399,"avatar_url":"https://avatars2.githubusercontent.com/u/56399?v=4","gravatar_id":"","url":"https://api.github.com/users/sirkon","html_url":"https://github.com/sirkon","followers_url":"https://api.github.com/users/sirkon/followers","following_url":"https://api.github.com/users/sirkon/following{/other_user}","gists_url":"https://api.github.com/users/sirkon/gists{/gist_id}","starred_url":"https://api.github.com/users/sirkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirkon/subscriptions","organizations_url":"https://api.github.com/users/sirkon/orgs","repos_url":"https://api.github.com/users/sirkon/repos","events_url":"https://api.github.com/users/sirkon/events{/privacy}","received_events_url":"https://api.github.com/users/sirkon/received_events","type":"User","site_admin":false},"body":"### 1. What does this change do, exactly?\r\nNew event type called *restart* added which is emitted at server restart (at SIGUSR1)\r\n\r\n\r\n### 2. Please link to the relevant issues.\r\nWe are using caddy as embedded server and we need to make preparations before restarts\r\n\r\n\r\n### 3. Which documentation changes (if any) need to be made because of this PR?\r\nNothing\r\n\r\n### 4. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [x] I have squashed any insignificant commits\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I am willing to help maintain this change if there are issues with it later\r\n","created_at":"2018-05-23T14:25:33Z","updated_at":"2018-05-25T05:00:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f22e6174961b6684c065a90a63cec1978f2fbbf3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mholt/caddy/pulls/2178/commits","review_comments_url":"https://api.github.com/repos/mholt/caddy/pulls/2178/comments","review_comment_url":"https://api.github.com/repos/mholt/caddy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mholt/caddy/issues/2178/comments","statuses_url":"https://api.github.com/repos/mholt/caddy/statuses/3338b7baa69a00ef6b0c78913b1bc7d480760c8d","head":{"label":"sirkon:master","ref":"master","sha":"3338b7baa69a00ef6b0c78913b1bc7d480760c8d","user":{"login":"sirkon","id":56399,"avatar_url":"https://avatars2.githubusercontent.com/u/56399?v=4","gravatar_id":"","url":"https://api.github.com/users/sirkon","html_url":"https://github.com/sirkon","followers_url":"https://api.github.com/users/sirkon/followers","following_url":"https://api.github.com/users/sirkon/following{/other_user}","gists_url":"https://api.github.com/users/sirkon/gists{/gist_id}","starred_url":"https://api.github.com/users/sirkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirkon/subscriptions","organizations_url":"https://api.github.com/users/sirkon/orgs","repos_url":"https://api.github.com/users/sirkon/repos","events_url":"https://api.github.com/users/sirkon/events{/privacy}","received_events_url":"https://api.github.com/users/sirkon/received_events","type":"User","site_admin":false},"repo":{"id":134578473,"name":"caddy","full_name":"sirkon/caddy","owner":{"login":"sirkon","id":56399,"avatar_url":"https://avatars2.githubusercontent.com/u/56399?v=4","gravatar_id":"","url":"https://api.github.com/users/sirkon","html_url":"https://github.com/sirkon","followers_url":"https://api.github.com/users/sirkon/followers","following_url":"https://api.github.com/users/sirkon/following{/other_user}","gists_url":"https://api.github.com/users/sirkon/gists{/gist_id}","starred_url":"https://api.github.com/users/sirkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirkon/subscriptions","organizations_url":"https://api.github.com/users/sirkon/orgs","repos_url":"https://api.github.com/users/sirkon/repos","events_url":"https://api.github.com/users/sirkon/events{/privacy}","received_events_url":"https://api.github.com/users/sirkon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sirkon/caddy","description":"Fast, cross-platform HTTP/2 web server with automatic HTTPS","fork":true,"url":"https://api.github.com/repos/sirkon/caddy","forks_url":"https://api.github.com/repos/sirkon/caddy/forks","keys_url":"https://api.github.com/repos/sirkon/caddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirkon/caddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirkon/caddy/teams","hooks_url":"https://api.github.com/repos/sirkon/caddy/hooks","issue_events_url":"https://api.github.com/repos/sirkon/caddy/issues/events{/number}","events_url":"https://api.github.com/repos/sirkon/caddy/events","assignees_url":"https://api.github.com/repos/sirkon/caddy/assignees{/user}","branches_url":"https://api.github.com/repos/sirkon/caddy/branches{/branch}","tags_url":"https://api.github.com/repos/sirkon/caddy/tags","blobs_url":"https://api.github.com/repos/sirkon/caddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirkon/caddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirkon/caddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirkon/caddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirkon/caddy/statuses/{sha}","languages_url":"https://api.github.com/repos/sirkon/caddy/languages","stargazers_url":"https://api.github.com/repos/sirkon/caddy/stargazers","contributors_url":"https://api.github.com/repos/sirkon/caddy/contributors","subscribers_url":"https://api.github.com/repos/sirkon/caddy/subscribers","subscription_url":"https://api.github.com/repos/sirkon/caddy/subscription","commits_url":"https://api.github.com/repos/sirkon/caddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirkon/caddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirkon/caddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirkon/caddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirkon/caddy/contents/{+path}","compare_url":"https://api.github.com/repos/sirkon/caddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirkon/caddy/merges","archive_url":"https://api.github.com/repos/sirkon/caddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirkon/caddy/downloads","issues_url":"https://api.github.com/repos/sirkon/caddy/issues{/number}","pulls_url":"https://api.github.com/repos/sirkon/caddy/pulls{/number}","milestones_url":"https://api.github.com/repos/sirkon/caddy/milestones{/number}","notifications_url":"https://api.github.com/repos/sirkon/caddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirkon/caddy/labels{/name}","releases_url":"https://api.github.com/repos/sirkon/caddy/releases{/id}","deployments_url":"https://api.github.com/repos/sirkon/caddy/deployments","created_at":"2018-05-23T14:03:34Z","updated_at":"2018-05-24T21:01:37Z","pushed_at":"2018-05-24T21:01:34Z","git_url":"git://github.com/sirkon/caddy.git","ssh_url":"git@github.com:sirkon/caddy.git","clone_url":"https://github.com/sirkon/caddy.git","svn_url":"https://github.com/sirkon/caddy","homepage":"https://caddyserver.com","size":7340,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mholt:master","ref":"master","sha":"60a0208e8dc36fe2a0d71f8c12520e18351a2aeb","user":{"login":"mholt","id":1128849,"avatar_url":"https://avatars2.githubusercontent.com/u/1128849?v=4","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"repo":{"id":29207621,"name":"caddy","full_name":"mholt/caddy","owner":{"login":"mholt","id":1128849,"avatar_url":"https://avatars2.githubusercontent.com/u/1128849?v=4","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mholt/caddy","description":"Fast, cross-platform HTTP/2 web server with automatic HTTPS","fork":false,"url":"https://api.github.com/repos/mholt/caddy","forks_url":"https://api.github.com/repos/mholt/caddy/forks","keys_url":"https://api.github.com/repos/mholt/caddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mholt/caddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mholt/caddy/teams","hooks_url":"https://api.github.com/repos/mholt/caddy/hooks","issue_events_url":"https://api.github.com/repos/mholt/caddy/issues/events{/number}","events_url":"https://api.github.com/repos/mholt/caddy/events","assignees_url":"https://api.github.com/repos/mholt/caddy/assignees{/user}","branches_url":"https://api.github.com/repos/mholt/caddy/branches{/branch}","tags_url":"https://api.github.com/repos/mholt/caddy/tags","blobs_url":"https://api.github.com/repos/mholt/caddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mholt/caddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mholt/caddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mholt/caddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mholt/caddy/statuses/{sha}","languages_url":"https://api.github.com/repos/mholt/caddy/languages","stargazers_url":"https://api.github.com/repos/mholt/caddy/stargazers","contributors_url":"https://api.github.com/repos/mholt/caddy/contributors","subscribers_url":"https://api.github.com/repos/mholt/caddy/subscribers","subscription_url":"https://api.github.com/repos/mholt/caddy/subscription","commits_url":"https://api.github.com/repos/mholt/caddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mholt/caddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mholt/caddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mholt/caddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mholt/caddy/contents/{+path}","compare_url":"https://api.github.com/repos/mholt/caddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mholt/caddy/merges","archive_url":"https://api.github.com/repos/mholt/caddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mholt/caddy/downloads","issues_url":"https://api.github.com/repos/mholt/caddy/issues{/number}","pulls_url":"https://api.github.com/repos/mholt/caddy/pulls{/number}","milestones_url":"https://api.github.com/repos/mholt/caddy/milestones{/number}","notifications_url":"https://api.github.com/repos/mholt/caddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mholt/caddy/labels{/name}","releases_url":"https://api.github.com/repos/mholt/caddy/releases{/id}","deployments_url":"https://api.github.com/repos/mholt/caddy/deployments","created_at":"2015-01-13T19:45:03Z","updated_at":"2018-05-25T04:24:48Z","pushed_at":"2018-05-24T23:15:18Z","git_url":"git://github.com/mholt/caddy.git","ssh_url":"git@github.com:mholt/caddy.git","clone_url":"https://github.com/mholt/caddy.git","svn_url":"https://github.com/mholt/caddy","homepage":"https://caddyserver.com","size":7339,"stargazers_count":17243,"watchers_count":17243,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1315,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1315,"open_issues":111,"watchers":17243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mholt/caddy/pulls/2178"},"html":{"href":"https://github.com/mholt/caddy/pull/2178"},"issue":{"href":"https://api.github.com/repos/mholt/caddy/issues/2178"},"comments":{"href":"https://api.github.com/repos/mholt/caddy/issues/2178/comments"},"review_comments":{"href":"https://api.github.com/repos/mholt/caddy/pulls/2178/comments"},"review_comment":{"href":"https://api.github.com/repos/mholt/caddy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mholt/caddy/pulls/2178/commits"},"statuses":{"href":"https://api.github.com/repos/mholt/caddy/statuses/3338b7baa69a00ef6b0c78913b1bc7d480760c8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"francislavoie"}}