{"action":"created","issue":{"url":"https://api.github.com/repos/wowserhq/stormjs/issues/23","repository_url":"https://api.github.com/repos/wowserhq/stormjs","labels_url":"https://api.github.com/repos/wowserhq/stormjs/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/wowserhq/stormjs/issues/23/comments","events_url":"https://api.github.com/repos/wowserhq/stormjs/issues/23/events","html_url":"https://github.com/wowserhq/stormjs/pull/23","id":295701149,"number":23,"title":"Implement file reading","user":{"login":"fallenoak","id":13418124,"avatar_url":"https://avatars1.githubusercontent.com/u/13418124?v=4","gravatar_id":"","url":"https://api.github.com/users/fallenoak","html_url":"https://github.com/fallenoak","followers_url":"https://api.github.com/users/fallenoak/followers","following_url":"https://api.github.com/users/fallenoak/following{/other_user}","gists_url":"https://api.github.com/users/fallenoak/gists{/gist_id}","starred_url":"https://api.github.com/users/fallenoak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fallenoak/subscriptions","organizations_url":"https://api.github.com/users/fallenoak/orgs","repos_url":"https://api.github.com/users/fallenoak/repos","events_url":"https://api.github.com/users/fallenoak/events{/privacy}","received_events_url":"https://api.github.com/users/fallenoak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-08T23:21:26Z","updated_at":"2018-02-08T23:23:24Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/wowserhq/stormjs/pulls/23","html_url":"https://github.com/wowserhq/stormjs/pull/23","diff_url":"https://github.com/wowserhq/stormjs/pull/23.diff","patch_url":"https://github.com/wowserhq/stormjs/pull/23.patch"},"body":"This implements two forms of file reading:\r\n\r\n- `pipe()` pipes the file in 128KB chunks into a writable stream; useful to prevent allocating large chunks of memory when reading bigger files\r\n\r\n- `read()` returns a `Uint8Array` containing the entire file; use of the array after a file is closed is dangerous\r\n\r\nCloses #6 "},"comment":{"url":"https://api.github.com/repos/wowserhq/stormjs/issues/comments/364283097","html_url":"https://github.com/wowserhq/stormjs/pull/23#issuecomment-364283097","issue_url":"https://api.github.com/repos/wowserhq/stormjs/issues/23","id":364283097,"user":{"login":"fallenoak","id":13418124,"avatar_url":"https://avatars1.githubusercontent.com/u/13418124?v=4","gravatar_id":"","url":"https://api.github.com/users/fallenoak","html_url":"https://github.com/fallenoak","followers_url":"https://api.github.com/users/fallenoak/followers","following_url":"https://api.github.com/users/fallenoak/following{/other_user}","gists_url":"https://api.github.com/users/fallenoak/gists{/gist_id}","starred_url":"https://api.github.com/users/fallenoak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fallenoak/subscriptions","organizations_url":"https://api.github.com/users/fallenoak/orgs","repos_url":"https://api.github.com/users/fallenoak/repos","events_url":"https://api.github.com/users/fallenoak/events{/privacy}","received_events_url":"https://api.github.com/users/fallenoak/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T23:23:24Z","updated_at":"2018-02-08T23:23:24Z","author_association":"OWNER","body":"@timkurvers Now that I'm thinking of it, `pipe()` potentially isn't super useful in its current form. It really should yield control back to the main event loop on each chunk. I'll have to think a bit more about this, since there's no async FS operations in `StormLib`."}}
{"actor":{"display_login":"fallenoak"}}