{"action":"created","comment":{"url":"https://api.github.com/repos/canjs/can-observation/pulls/comments/226753526","pull_request_review_id":166659812,"id":226753526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjc1MzUyNg==","diff_hunk":"@@ -527,12 +527,17 @@ QUnit.test(\"a bound observation with no dependencies will keep calling its funct\n QUnit.test(\"log observable changes\", function(assert) {\n \tvar dev = require(\"can-log/dev/dev\");\n \tvar name = simpleObservable(\"John Doe\");\n+\tvar fn = function() {};\n \n-\tassert.expect(3);\n+\t//assert.expect(3);\n \tvar log = dev.log;\n \tdev.log = function() {\n \t\tdev.log = log;\n-\t\tassert.equal(arguments[0], \"Observation<>\", \"should use can.getName\");\n+\t\t// Functions in IE11 dont have name property\n+\t\t// this test is ignored under IE11\n+\t\tif (fn.name) {\n+\t\t\tassert.equal(arguments[0], \"Observation<>\", \"should use can.getName\");","path":"can-observation_test.js","position":15,"original_position":15,"commit_id":"006561b7f239d061bbf76c28822bd8d6e70a5e46","original_commit_id":"7e9bd678cbcc4791f35770e6684cd0f50ea8dc63","user":{"login":"cherifGsoul","id":109013,"node_id":"MDQ6VXNlcjEwOTAxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/109013?v=4","gravatar_id":"","url":"https://api.github.com/users/cherifGsoul","html_url":"https://github.com/cherifGsoul","followers_url":"https://api.github.com/users/cherifGsoul/followers","following_url":"https://api.github.com/users/cherifGsoul/following{/other_user}","gists_url":"https://api.github.com/users/cherifGsoul/gists{/gist_id}","starred_url":"https://api.github.com/users/cherifGsoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherifGsoul/subscriptions","organizations_url":"https://api.github.com/users/cherifGsoul/orgs","repos_url":"https://api.github.com/users/cherifGsoul/repos","events_url":"https://api.github.com/users/cherifGsoul/events{/privacy}","received_events_url":"https://api.github.com/users/cherifGsoul/received_events","type":"User","site_admin":false},"body":"Done!","created_at":"2018-10-19T19:11:45Z","updated_at":"2018-10-19T19:11:45Z","html_url":"https://github.com/canjs/can-observation/pull/139#discussion_r226753526","pull_request_url":"https://api.github.com/repos/canjs/can-observation/pulls/139","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/canjs/can-observation/pulls/comments/226753526"},"html":{"href":"https://github.com/canjs/can-observation/pull/139#discussion_r226753526"},"pull_request":{"href":"https://api.github.com/repos/canjs/can-observation/pulls/139"}},"in_reply_to_id":226751591},"pull_request":{"url":"https://api.github.com/repos/canjs/can-observation/pulls/139","id":224380888,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzgwODg4","html_url":"https://github.com/canjs/can-observation/pull/139","diff_url":"https://github.com/canjs/can-observation/pull/139.diff","patch_url":"https://github.com/canjs/can-observation/pull/139.patch","issue_url":"https://api.github.com/repos/canjs/can-observation/issues/139","number":139,"state":"open","locked":false,"title":"Ie11 compat","user":{"login":"cherifGsoul","id":109013,"node_id":"MDQ6VXNlcjEwOTAxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/109013?v=4","gravatar_id":"","url":"https://api.github.com/users/cherifGsoul","html_url":"https://github.com/cherifGsoul","followers_url":"https://api.github.com/users/cherifGsoul/followers","following_url":"https://api.github.com/users/cherifGsoul/following{/other_user}","gists_url":"https://api.github.com/users/cherifGsoul/gists{/gist_id}","starred_url":"https://api.github.com/users/cherifGsoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherifGsoul/subscriptions","organizations_url":"https://api.github.com/users/cherifGsoul/orgs","repos_url":"https://api.github.com/users/cherifGsoul/repos","events_url":"https://api.github.com/users/cherifGsoul/events{/privacy}","received_events_url":"https://api.github.com/users/cherifGsoul/received_events","type":"User","site_admin":false},"body":"- Fix the tests for IE11","created_at":"2018-10-19T18:59:25Z","updated_at":"2018-10-19T19:11:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a78f5e086f8eb29cd683b5a9e21185cbe26db14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/canjs/can-observation/pulls/139/commits","review_comments_url":"https://api.github.com/repos/canjs/can-observation/pulls/139/comments","review_comment_url":"https://api.github.com/repos/canjs/can-observation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canjs/can-observation/issues/139/comments","statuses_url":"https://api.github.com/repos/canjs/can-observation/statuses/006561b7f239d061bbf76c28822bd8d6e70a5e46","head":{"label":"canjs:ie11-compat","ref":"ie11-compat","sha":"006561b7f239d061bbf76c28822bd8d6e70a5e46","user":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":56465879,"node_id":"MDEwOlJlcG9zaXRvcnk1NjQ2NTg3OQ==","name":"can-observation","full_name":"canjs/can-observation","private":false,"owner":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/canjs/can-observation","description":"Computed values","fork":false,"url":"https://api.github.com/repos/canjs/can-observation","forks_url":"https://api.github.com/repos/canjs/can-observation/forks","keys_url":"https://api.github.com/repos/canjs/can-observation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-observation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-observation/teams","hooks_url":"https://api.github.com/repos/canjs/can-observation/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-observation/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-observation/events","assignees_url":"https://api.github.com/repos/canjs/can-observation/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-observation/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-observation/tags","blobs_url":"https://api.github.com/repos/canjs/can-observation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-observation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-observation/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-observation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-observation/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-observation/languages","stargazers_url":"https://api.github.com/repos/canjs/can-observation/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-observation/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-observation/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-observation/subscription","commits_url":"https://api.github.com/repos/canjs/can-observation/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-observation/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-observation/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-observation/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-observation/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-observation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-observation/merges","archive_url":"https://api.github.com/repos/canjs/can-observation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-observation/downloads","issues_url":"https://api.github.com/repos/canjs/can-observation/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-observation/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-observation/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-observation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-observation/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-observation/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-observation/deployments","created_at":"2016-04-18T00:38:29Z","updated_at":"2018-09-07T21:05:26Z","pushed_at":"2018-10-19T19:11:12Z","git_url":"git://github.com/canjs/can-observation.git","ssh_url":"git@github.com:canjs/can-observation.git","clone_url":"https://github.com/canjs/can-observation.git","svn_url":"https://github.com/canjs/can-observation","homepage":"https://canjs.com/doc/can-observation.html","size":715,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":10,"watchers":5,"default_branch":"master"}},"base":{"label":"canjs:master","ref":"master","sha":"1e735fc38038c1ec4bdce64f77193cc91cc0adb2","user":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":56465879,"node_id":"MDEwOlJlcG9zaXRvcnk1NjQ2NTg3OQ==","name":"can-observation","full_name":"canjs/can-observation","private":false,"owner":{"login":"canjs","id":11798761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4NzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/canjs/can-observation","description":"Computed values","fork":false,"url":"https://api.github.com/repos/canjs/can-observation","forks_url":"https://api.github.com/repos/canjs/can-observation/forks","keys_url":"https://api.github.com/repos/canjs/can-observation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-observation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-observation/teams","hooks_url":"https://api.github.com/repos/canjs/can-observation/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-observation/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-observation/events","assignees_url":"https://api.github.com/repos/canjs/can-observation/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-observation/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-observation/tags","blobs_url":"https://api.github.com/repos/canjs/can-observation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-observation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-observation/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-observation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-observation/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-observation/languages","stargazers_url":"https://api.github.com/repos/canjs/can-observation/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-observation/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-observation/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-observation/subscription","commits_url":"https://api.github.com/repos/canjs/can-observation/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-observation/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-observation/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-observation/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-observation/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-observation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-observation/merges","archive_url":"https://api.github.com/repos/canjs/can-observation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-observation/downloads","issues_url":"https://api.github.com/repos/canjs/can-observation/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-observation/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-observation/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-observation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-observation/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-observation/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-observation/deployments","created_at":"2016-04-18T00:38:29Z","updated_at":"2018-09-07T21:05:26Z","pushed_at":"2018-10-19T19:11:12Z","git_url":"git://github.com/canjs/can-observation.git","ssh_url":"git@github.com:canjs/can-observation.git","clone_url":"https://github.com/canjs/can-observation.git","svn_url":"https://github.com/canjs/can-observation","homepage":"https://canjs.com/doc/can-observation.html","size":715,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":10,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canjs/can-observation/pulls/139"},"html":{"href":"https://github.com/canjs/can-observation/pull/139"},"issue":{"href":"https://api.github.com/repos/canjs/can-observation/issues/139"},"comments":{"href":"https://api.github.com/repos/canjs/can-observation/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/canjs/can-observation/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/canjs/can-observation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canjs/can-observation/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/canjs/can-observation/statuses/006561b7f239d061bbf76c28822bd8d6e70a5e46"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cherifGsoul"}}