{"action":"closed","number":1139,"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/1139","id":195233183,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjMzMTgz","html_url":"https://github.com/pytorch/glow/pull/1139","diff_url":"https://github.com/pytorch/glow/pull/1139.diff","patch_url":"https://github.com/pytorch/glow/pull/1139.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/1139","number":1139,"state":"closed","locked":false,"title":"[llvm-func-specializer] Don't specialize any arguments that are buffers of quantized values","user":{"login":"opti-mix","id":33707249,"node_id":"MDQ6VXNlcjMzNzA3MjQ5","avatar_url":"https://avatars3.githubusercontent.com/u/33707249?v=4","gravatar_id":"","url":"https://api.github.com/users/opti-mix","html_url":"https://github.com/opti-mix","followers_url":"https://api.github.com/users/opti-mix/followers","following_url":"https://api.github.com/users/opti-mix/following{/other_user}","gists_url":"https://api.github.com/users/opti-mix/gists{/gist_id}","starred_url":"https://api.github.com/users/opti-mix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opti-mix/subscriptions","organizations_url":"https://api.github.com/users/opti-mix/orgs","repos_url":"https://api.github.com/users/opti-mix/repos","events_url":"https://api.github.com/users/opti-mix/events{/privacy}","received_events_url":"https://api.github.com/users/opti-mix/received_events","type":"User","site_admin":false},"body":"We don't want to specialize arguments which are pointers to floating point and quantized buffers, because this is likely to significantly increase the code size without any big performance benefits.\r\n\r\nAlso, improve the comments and describe this logic.","created_at":"2018-06-15T17:00:35Z","updated_at":"2018-06-15T18:17:59Z","closed_at":"2018-06-15T18:17:59Z","merged_at":"2018-06-15T18:17:59Z","merge_commit_sha":"fc3c6d7239a4d64a4432f8c491ce631fb29c340a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706497924,"node_id":"MDU6TGFiZWw3MDY0OTc5MjQ=","url":"https://api.github.com/repos/pytorch/glow/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/1139/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/1139/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/1139/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/f8d7441a15f86e83b5cd51d56d04fead049f138c","head":{"label":"opti-mix:minor-cleanups","ref":"minor-cleanups","sha":"f8d7441a15f86e83b5cd51d56d04fead049f138c","user":{"login":"opti-mix","id":33707249,"node_id":"MDQ6VXNlcjMzNzA3MjQ5","avatar_url":"https://avatars3.githubusercontent.com/u/33707249?v=4","gravatar_id":"","url":"https://api.github.com/users/opti-mix","html_url":"https://github.com/opti-mix","followers_url":"https://api.github.com/users/opti-mix/followers","following_url":"https://api.github.com/users/opti-mix/following{/other_user}","gists_url":"https://api.github.com/users/opti-mix/gists{/gist_id}","starred_url":"https://api.github.com/users/opti-mix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opti-mix/subscriptions","organizations_url":"https://api.github.com/users/opti-mix/orgs","repos_url":"https://api.github.com/users/opti-mix/repos","events_url":"https://api.github.com/users/opti-mix/events{/privacy}","received_events_url":"https://api.github.com/users/opti-mix/received_events","type":"User","site_admin":false},"repo":{"id":131890172,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4OTAxNzI=","name":"glow","full_name":"opti-mix/glow","owner":{"login":"opti-mix","id":33707249,"node_id":"MDQ6VXNlcjMzNzA3MjQ5","avatar_url":"https://avatars3.githubusercontent.com/u/33707249?v=4","gravatar_id":"","url":"https://api.github.com/users/opti-mix","html_url":"https://github.com/opti-mix","followers_url":"https://api.github.com/users/opti-mix/followers","following_url":"https://api.github.com/users/opti-mix/following{/other_user}","gists_url":"https://api.github.com/users/opti-mix/gists{/gist_id}","starred_url":"https://api.github.com/users/opti-mix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opti-mix/subscriptions","organizations_url":"https://api.github.com/users/opti-mix/orgs","repos_url":"https://api.github.com/users/opti-mix/repos","events_url":"https://api.github.com/users/opti-mix/events{/privacy}","received_events_url":"https://api.github.com/users/opti-mix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opti-mix/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/opti-mix/glow","forks_url":"https://api.github.com/repos/opti-mix/glow/forks","keys_url":"https://api.github.com/repos/opti-mix/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opti-mix/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opti-mix/glow/teams","hooks_url":"https://api.github.com/repos/opti-mix/glow/hooks","issue_events_url":"https://api.github.com/repos/opti-mix/glow/issues/events{/number}","events_url":"https://api.github.com/repos/opti-mix/glow/events","assignees_url":"https://api.github.com/repos/opti-mix/glow/assignees{/user}","branches_url":"https://api.github.com/repos/opti-mix/glow/branches{/branch}","tags_url":"https://api.github.com/repos/opti-mix/glow/tags","blobs_url":"https://api.github.com/repos/opti-mix/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opti-mix/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opti-mix/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/opti-mix/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opti-mix/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/opti-mix/glow/languages","stargazers_url":"https://api.github.com/repos/opti-mix/glow/stargazers","contributors_url":"https://api.github.com/repos/opti-mix/glow/contributors","subscribers_url":"https://api.github.com/repos/opti-mix/glow/subscribers","subscription_url":"https://api.github.com/repos/opti-mix/glow/subscription","commits_url":"https://api.github.com/repos/opti-mix/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/opti-mix/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/opti-mix/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/opti-mix/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/opti-mix/glow/contents/{+path}","compare_url":"https://api.github.com/repos/opti-mix/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opti-mix/glow/merges","archive_url":"https://api.github.com/repos/opti-mix/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opti-mix/glow/downloads","issues_url":"https://api.github.com/repos/opti-mix/glow/issues{/number}","pulls_url":"https://api.github.com/repos/opti-mix/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/opti-mix/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/opti-mix/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opti-mix/glow/labels{/name}","releases_url":"https://api.github.com/repos/opti-mix/glow/releases{/id}","deployments_url":"https://api.github.com/repos/opti-mix/glow/deployments","created_at":"2018-05-02T18:22:50Z","updated_at":"2018-05-02T18:22:53Z","pushed_at":"2018-06-15T17:00:15Z","git_url":"git://github.com/opti-mix/glow.git","ssh_url":"git@github.com:opti-mix/glow.git","clone_url":"https://github.com/opti-mix/glow.git","svn_url":"https://github.com/opti-mix/glow","homepage":null,"size":6413,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"e05895507f47a94d452c5d9837cbaba6363b8eac","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2018-06-15T15:52:17Z","pushed_at":"2018-06-15T18:17:59Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"git@github.com:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":6344,"stargazers_count":600,"watchers_count":600,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":61,"open_issues":13,"watchers":600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1139"},"html":{"href":"https://github.com/pytorch/glow/pull/1139"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/1139"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/1139/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1139/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1139/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/f8d7441a15f86e83b5cd51d56d04fead049f138c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"opti-mix","id":33707249,"node_id":"MDQ6VXNlcjMzNzA3MjQ5","avatar_url":"https://avatars3.githubusercontent.com/u/33707249?v=4","gravatar_id":"","url":"https://api.github.com/users/opti-mix","html_url":"https://github.com/opti-mix","followers_url":"https://api.github.com/users/opti-mix/followers","following_url":"https://api.github.com/users/opti-mix/following{/other_user}","gists_url":"https://api.github.com/users/opti-mix/gists{/gist_id}","starred_url":"https://api.github.com/users/opti-mix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opti-mix/subscriptions","organizations_url":"https://api.github.com/users/opti-mix/orgs","repos_url":"https://api.github.com/users/opti-mix/repos","events_url":"https://api.github.com/users/opti-mix/events{/privacy}","received_events_url":"https://api.github.com/users/opti-mix/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"opti-mix"}}