{"action":"created","comment":{"url":"https://api.github.com/repos/GepardGraphics/gepard/pulls/comments/221941220","pull_request_review_id":160701340,"id":221941220,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk0MTIyMA==","diff_hunk":"@@ -27,6 +27,15 @@ elseif (BACKEND STREQUAL \"VULKAN\")\n \n     set(VULKAN_INCLUDE_DIR ${PROJECT_BINARY_DIR}/thirdparty/include)\n   endif()\n+  add_custom_command(OUTPUT ${PROJECT_SOURCE_DIR}/src/engines/vulkan/shaders/gepard-vulkan-spirv-binaries.h\n+                            ${PROJECT_SOURCE_DIR}/src/engines/vulkan/shaders/gepard-vulkan-spirv-binaries.inc.h","path":"cmake/Dependencies.cmake","position":5,"original_position":5,"commit_id":"420decb00aea01571b8bf5546bc41bfb1bbfb7c6","original_commit_id":"420decb00aea01571b8bf5546bc41bfb1bbfb7c6","user":{"login":"dbatyai","id":12066566,"node_id":"MDQ6VXNlcjEyMDY2NTY2","avatar_url":"https://avatars1.githubusercontent.com/u/12066566?v=4","gravatar_id":"","url":"https://api.github.com/users/dbatyai","html_url":"https://github.com/dbatyai","followers_url":"https://api.github.com/users/dbatyai/followers","following_url":"https://api.github.com/users/dbatyai/following{/other_user}","gists_url":"https://api.github.com/users/dbatyai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbatyai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbatyai/subscriptions","organizations_url":"https://api.github.com/users/dbatyai/orgs","repos_url":"https://api.github.com/users/dbatyai/repos","events_url":"https://api.github.com/users/dbatyai/events{/privacy}","received_events_url":"https://api.github.com/users/dbatyai/received_events","type":"User","site_admin":false},"body":"These generated files should be added to gitignore to prevent them from accidentally getting committed. As a matter of fact, it would be best if these would be in the build directory, so they don't mess up the source tree.","created_at":"2018-10-02T13:04:14Z","updated_at":"2018-10-02T13:10:58Z","html_url":"https://github.com/GepardGraphics/gepard/pull/119#discussion_r221941220","pull_request_url":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GepardGraphics/gepard/pulls/comments/221941220"},"html":{"href":"https://github.com/GepardGraphics/gepard/pull/119#discussion_r221941220"},"pull_request":{"href":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119","id":219446843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDQ2ODQz","html_url":"https://github.com/GepardGraphics/gepard/pull/119","diff_url":"https://github.com/GepardGraphics/gepard/pull/119.diff","patch_url":"https://github.com/GepardGraphics/gepard/pull/119.patch","issue_url":"https://api.github.com/repos/GepardGraphics/gepard/issues/119","number":119,"state":"open","locked":false,"title":"Merge the current vulkan-dev to the master","user":{"login":"kkristof","id":820112,"node_id":"MDQ6VXNlcjgyMDExMg==","avatar_url":"https://avatars0.githubusercontent.com/u/820112?v=4","gravatar_id":"","url":"https://api.github.com/users/kkristof","html_url":"https://github.com/kkristof","followers_url":"https://api.github.com/users/kkristof/followers","following_url":"https://api.github.com/users/kkristof/following{/other_user}","gists_url":"https://api.github.com/users/kkristof/gists{/gist_id}","starred_url":"https://api.github.com/users/kkristof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkristof/subscriptions","organizations_url":"https://api.github.com/users/kkristof/orgs","repos_url":"https://api.github.com/users/kkristof/repos","events_url":"https://api.github.com/users/kkristof/events{/privacy}","received_events_url":"https://api.github.com/users/kkristof/received_events","type":"User","site_admin":false},"body":"There has been a while since the last merge, sorry about that :)\r\nNew things:\r\n- SPIR-V generator, which creates a nice header from the shader sources\r\n- Basic image implementation\r\n- Image support for the vulkan backend\r\n  - Every image related canvas function is supported\r\n- New utility functions for the vulkan backend, these should streamline the development\r\n- Compile time SPIR-V generation\r\n\r\nI know this is a bit big chunk of code to review, so please take your time.\r\nCheers!","created_at":"2018-10-01T17:00:54Z","updated_at":"2018-10-02T13:10:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaabac055a942305e07d8676bdb6c57ba86dcc5b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"elecro","id":1829644,"node_id":"MDQ6VXNlcjE4Mjk2NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1829644?v=4","gravatar_id":"","url":"https://api.github.com/users/elecro","html_url":"https://github.com/elecro","followers_url":"https://api.github.com/users/elecro/followers","following_url":"https://api.github.com/users/elecro/following{/other_user}","gists_url":"https://api.github.com/users/elecro/gists{/gist_id}","starred_url":"https://api.github.com/users/elecro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elecro/subscriptions","organizations_url":"https://api.github.com/users/elecro/orgs","repos_url":"https://api.github.com/users/elecro/repos","events_url":"https://api.github.com/users/elecro/events{/privacy}","received_events_url":"https://api.github.com/users/elecro/received_events","type":"User","site_admin":false},{"login":"szledan","id":3430092,"node_id":"MDQ6VXNlcjM0MzAwOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3430092?v=4","gravatar_id":"","url":"https://api.github.com/users/szledan","html_url":"https://github.com/szledan","followers_url":"https://api.github.com/users/szledan/followers","following_url":"https://api.github.com/users/szledan/following{/other_user}","gists_url":"https://api.github.com/users/szledan/gists{/gist_id}","starred_url":"https://api.github.com/users/szledan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szledan/subscriptions","organizations_url":"https://api.github.com/users/szledan/orgs","repos_url":"https://api.github.com/users/szledan/repos","events_url":"https://api.github.com/users/szledan/events{/privacy}","received_events_url":"https://api.github.com/users/szledan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":347951869,"node_id":"MDU6TGFiZWwzNDc5NTE4Njk=","url":"https://api.github.com/repos/GepardGraphics/gepard/labels/backend","name":"backend","color":"006b75","default":false},{"id":262487291,"node_id":"MDU6TGFiZWwyNjI0ODcyOTE=","url":"https://api.github.com/repos/GepardGraphics/gepard/labels/feature","name":"feature","color":"fbca04","default":false},{"id":391106960,"node_id":"MDU6TGFiZWwzOTExMDY5NjA=","url":"https://api.github.com/repos/GepardGraphics/gepard/labels/important","name":"important","color":"d4c5f9","default":false},{"id":295009710,"node_id":"MDU6TGFiZWwyOTUwMDk3MTA=","url":"https://api.github.com/repos/GepardGraphics/gepard/labels/infrastructure","name":"infrastructure","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119/commits","review_comments_url":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119/comments","review_comment_url":"https://api.github.com/repos/GepardGraphics/gepard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GepardGraphics/gepard/issues/119/comments","statuses_url":"https://api.github.com/repos/GepardGraphics/gepard/statuses/420decb00aea01571b8bf5546bc41bfb1bbfb7c6","head":{"label":"kkristof:vulkan-dev","ref":"vulkan-dev","sha":"420decb00aea01571b8bf5546bc41bfb1bbfb7c6","user":{"login":"kkristof","id":820112,"node_id":"MDQ6VXNlcjgyMDExMg==","avatar_url":"https://avatars0.githubusercontent.com/u/820112?v=4","gravatar_id":"","url":"https://api.github.com/users/kkristof","html_url":"https://github.com/kkristof","followers_url":"https://api.github.com/users/kkristof/followers","following_url":"https://api.github.com/users/kkristof/following{/other_user}","gists_url":"https://api.github.com/users/kkristof/gists{/gist_id}","starred_url":"https://api.github.com/users/kkristof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkristof/subscriptions","organizations_url":"https://api.github.com/users/kkristof/orgs","repos_url":"https://api.github.com/users/kkristof/repos","events_url":"https://api.github.com/users/kkristof/events{/privacy}","received_events_url":"https://api.github.com/users/kkristof/received_events","type":"User","site_admin":false},"repo":{"id":42885363,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg4NTM2Mw==","name":"gepard","full_name":"kkristof/gepard","private":false,"owner":{"login":"kkristof","id":820112,"node_id":"MDQ6VXNlcjgyMDExMg==","avatar_url":"https://avatars0.githubusercontent.com/u/820112?v=4","gravatar_id":"","url":"https://api.github.com/users/kkristof","html_url":"https://github.com/kkristof","followers_url":"https://api.github.com/users/kkristof/followers","following_url":"https://api.github.com/users/kkristof/following{/other_user}","gists_url":"https://api.github.com/users/kkristof/gists{/gist_id}","starred_url":"https://api.github.com/users/kkristof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkristof/subscriptions","organizations_url":"https://api.github.com/users/kkristof/orgs","repos_url":"https://api.github.com/users/kkristof/repos","events_url":"https://api.github.com/users/kkristof/events{/privacy}","received_events_url":"https://api.github.com/users/kkristof/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kkristof/gepard","description":"Gepard - HW accelerated 2D engine","fork":true,"url":"https://api.github.com/repos/kkristof/gepard","forks_url":"https://api.github.com/repos/kkristof/gepard/forks","keys_url":"https://api.github.com/repos/kkristof/gepard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkristof/gepard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkristof/gepard/teams","hooks_url":"https://api.github.com/repos/kkristof/gepard/hooks","issue_events_url":"https://api.github.com/repos/kkristof/gepard/issues/events{/number}","events_url":"https://api.github.com/repos/kkristof/gepard/events","assignees_url":"https://api.github.com/repos/kkristof/gepard/assignees{/user}","branches_url":"https://api.github.com/repos/kkristof/gepard/branches{/branch}","tags_url":"https://api.github.com/repos/kkristof/gepard/tags","blobs_url":"https://api.github.com/repos/kkristof/gepard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkristof/gepard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkristof/gepard/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkristof/gepard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkristof/gepard/statuses/{sha}","languages_url":"https://api.github.com/repos/kkristof/gepard/languages","stargazers_url":"https://api.github.com/repos/kkristof/gepard/stargazers","contributors_url":"https://api.github.com/repos/kkristof/gepard/contributors","subscribers_url":"https://api.github.com/repos/kkristof/gepard/subscribers","subscription_url":"https://api.github.com/repos/kkristof/gepard/subscription","commits_url":"https://api.github.com/repos/kkristof/gepard/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkristof/gepard/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkristof/gepard/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkristof/gepard/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkristof/gepard/contents/{+path}","compare_url":"https://api.github.com/repos/kkristof/gepard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkristof/gepard/merges","archive_url":"https://api.github.com/repos/kkristof/gepard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkristof/gepard/downloads","issues_url":"https://api.github.com/repos/kkristof/gepard/issues{/number}","pulls_url":"https://api.github.com/repos/kkristof/gepard/pulls{/number}","milestones_url":"https://api.github.com/repos/kkristof/gepard/milestones{/number}","notifications_url":"https://api.github.com/repos/kkristof/gepard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkristof/gepard/labels{/name}","releases_url":"https://api.github.com/repos/kkristof/gepard/releases{/id}","deployments_url":"https://api.github.com/repos/kkristof/gepard/deployments","created_at":"2015-09-21T18:22:05Z","updated_at":"2016-05-02T16:31:27Z","pushed_at":"2018-10-01T20:23:35Z","git_url":"git://github.com/kkristof/gepard.git","ssh_url":"git@github.com:kkristof/gepard.git","clone_url":"https://github.com/kkristof/gepard.git","svn_url":"https://github.com/kkristof/gepard","homepage":"","size":811,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GepardGraphics:master","ref":"master","sha":"a5f588161a8f8821903ad1aa560f6a9b23836430","user":{"login":"GepardGraphics","id":14358513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzU4NTEz","avatar_url":"https://avatars2.githubusercontent.com/u/14358513?v=4","gravatar_id":"","url":"https://api.github.com/users/GepardGraphics","html_url":"https://github.com/GepardGraphics","followers_url":"https://api.github.com/users/GepardGraphics/followers","following_url":"https://api.github.com/users/GepardGraphics/following{/other_user}","gists_url":"https://api.github.com/users/GepardGraphics/gists{/gist_id}","starred_url":"https://api.github.com/users/GepardGraphics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GepardGraphics/subscriptions","organizations_url":"https://api.github.com/users/GepardGraphics/orgs","repos_url":"https://api.github.com/users/GepardGraphics/repos","events_url":"https://api.github.com/users/GepardGraphics/events{/privacy}","received_events_url":"https://api.github.com/users/GepardGraphics/received_events","type":"Organization","site_admin":false},"repo":{"id":42766147,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc2NjE0Nw==","name":"gepard","full_name":"GepardGraphics/gepard","private":false,"owner":{"login":"GepardGraphics","id":14358513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzU4NTEz","avatar_url":"https://avatars2.githubusercontent.com/u/14358513?v=4","gravatar_id":"","url":"https://api.github.com/users/GepardGraphics","html_url":"https://github.com/GepardGraphics","followers_url":"https://api.github.com/users/GepardGraphics/followers","following_url":"https://api.github.com/users/GepardGraphics/following{/other_user}","gists_url":"https://api.github.com/users/GepardGraphics/gists{/gist_id}","starred_url":"https://api.github.com/users/GepardGraphics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GepardGraphics/subscriptions","organizations_url":"https://api.github.com/users/GepardGraphics/orgs","repos_url":"https://api.github.com/users/GepardGraphics/repos","events_url":"https://api.github.com/users/GepardGraphics/events{/privacy}","received_events_url":"https://api.github.com/users/GepardGraphics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GepardGraphics/gepard","description":"Gepard - HW accelerated 2D engine","fork":true,"url":"https://api.github.com/repos/GepardGraphics/gepard","forks_url":"https://api.github.com/repos/GepardGraphics/gepard/forks","keys_url":"https://api.github.com/repos/GepardGraphics/gepard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GepardGraphics/gepard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GepardGraphics/gepard/teams","hooks_url":"https://api.github.com/repos/GepardGraphics/gepard/hooks","issue_events_url":"https://api.github.com/repos/GepardGraphics/gepard/issues/events{/number}","events_url":"https://api.github.com/repos/GepardGraphics/gepard/events","assignees_url":"https://api.github.com/repos/GepardGraphics/gepard/assignees{/user}","branches_url":"https://api.github.com/repos/GepardGraphics/gepard/branches{/branch}","tags_url":"https://api.github.com/repos/GepardGraphics/gepard/tags","blobs_url":"https://api.github.com/repos/GepardGraphics/gepard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GepardGraphics/gepard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GepardGraphics/gepard/git/refs{/sha}","trees_url":"https://api.github.com/repos/GepardGraphics/gepard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GepardGraphics/gepard/statuses/{sha}","languages_url":"https://api.github.com/repos/GepardGraphics/gepard/languages","stargazers_url":"https://api.github.com/repos/GepardGraphics/gepard/stargazers","contributors_url":"https://api.github.com/repos/GepardGraphics/gepard/contributors","subscribers_url":"https://api.github.com/repos/GepardGraphics/gepard/subscribers","subscription_url":"https://api.github.com/repos/GepardGraphics/gepard/subscription","commits_url":"https://api.github.com/repos/GepardGraphics/gepard/commits{/sha}","git_commits_url":"https://api.github.com/repos/GepardGraphics/gepard/git/commits{/sha}","comments_url":"https://api.github.com/repos/GepardGraphics/gepard/comments{/number}","issue_comment_url":"https://api.github.com/repos/GepardGraphics/gepard/issues/comments{/number}","contents_url":"https://api.github.com/repos/GepardGraphics/gepard/contents/{+path}","compare_url":"https://api.github.com/repos/GepardGraphics/gepard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GepardGraphics/gepard/merges","archive_url":"https://api.github.com/repos/GepardGraphics/gepard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GepardGraphics/gepard/downloads","issues_url":"https://api.github.com/repos/GepardGraphics/gepard/issues{/number}","pulls_url":"https://api.github.com/repos/GepardGraphics/gepard/pulls{/number}","milestones_url":"https://api.github.com/repos/GepardGraphics/gepard/milestones{/number}","notifications_url":"https://api.github.com/repos/GepardGraphics/gepard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GepardGraphics/gepard/labels{/name}","releases_url":"https://api.github.com/repos/GepardGraphics/gepard/releases{/id}","deployments_url":"https://api.github.com/repos/GepardGraphics/gepard/deployments","created_at":"2015-09-19T08:44:50Z","updated_at":"2018-10-02T12:05:42Z","pushed_at":"2018-10-02T12:16:26Z","git_url":"git://github.com/GepardGraphics/gepard.git","ssh_url":"git@github.com:GepardGraphics/gepard.git","clone_url":"https://github.com/GepardGraphics/gepard.git","svn_url":"https://github.com/GepardGraphics/gepard","homepage":"","size":663,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":25,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119"},"html":{"href":"https://github.com/GepardGraphics/gepard/pull/119"},"issue":{"href":"https://api.github.com/repos/GepardGraphics/gepard/issues/119"},"comments":{"href":"https://api.github.com/repos/GepardGraphics/gepard/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/GepardGraphics/gepard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GepardGraphics/gepard/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/GepardGraphics/gepard/statuses/420decb00aea01571b8bf5546bc41bfb1bbfb7c6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dbatyai"}}