{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/234027233","pull_request_review_id":175579768,"id":234027233,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDAyNzIzMw==","diff_hunk":"@@ -326,6 +326,13 @@ func (c *client) createWindows(id string, spec *specs.Spec, runtimeOptions inter\n \t}\n \tconfiguration.MappedPipes = mps\n \n+\t// Add any device assignments\n+\tif len(spec.Windows.Devices) > 0 {\n+\t\tfor _, d := range spec.Windows.Devices {","path":"libcontainerd/client_local_windows.go","position":6,"original_position":6,"commit_id":"c2964489f3543b8f78d91b7185b23333b56ca0a3","original_commit_id":"c2964489f3543b8f78d91b7185b23333b56ca0a3","user":{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"body":"Should an error be returned here if assigned devices are specified on Windows builds lower than RS5, or is the check in oci_windows.go sufficient? A version check for named pipes is done in this function.","created_at":"2018-11-15T22:09:57Z","updated_at":"2018-11-15T22:15:45Z","html_url":"https://github.com/moby/moby/pull/37638#discussion_r234027233","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/37638","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/234027233"},"html":{"href":"https://github.com/moby/moby/pull/37638#discussion_r234027233"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/37638"}}},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/37638","id":208320784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzIwNzg0","html_url":"https://github.com/moby/moby/pull/37638","diff_url":"https://github.com/moby/moby/pull/37638.diff","patch_url":"https://github.com/moby/moby/pull/37638.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/37638","number":37638,"state":"open","locked":false,"title":"Add --device support for Windows","user":{"login":"jterry75","id":5858142,"node_id":"MDQ6VXNlcjU4NTgxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5858142?v=4","gravatar_id":"","url":"https://api.github.com/users/jterry75","html_url":"https://github.com/jterry75","followers_url":"https://api.github.com/users/jterry75/followers","following_url":"https://api.github.com/users/jterry75/following{/other_user}","gists_url":"https://api.github.com/users/jterry75/gists{/gist_id}","starred_url":"https://api.github.com/users/jterry75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jterry75/subscriptions","organizations_url":"https://api.github.com/users/jterry75/orgs","repos_url":"https://api.github.com/users/jterry75/repos","events_url":"https://api.github.com/users/jterry75/events{/privacy}","received_events_url":"https://api.github.com/users/jterry75/received_events","type":"User","site_admin":false},"body":"Implements the --device forwarding for Windows daemons. This maps the physical\r\ndevice into the container at runtime.\r\n\r\nEx:\r\n\r\ndocker run --device=\"class/<clsid>\" <image> <cmd>\r\n\r\nSigned-off-by: Justin Terry (VM) <juterry@microsoft.com>\r\n\r\n@jhowardmsft - FYI","created_at":"2018-08-14T15:26:06Z","updated_at":"2018-11-15T22:15:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"902dee97fbe8a1f753ea8a74bfef1d8cc9878247","assignee":{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"assignees":[{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":175375407,"node_id":"MDU6TGFiZWwxNzUzNzU0MDc=","url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/37638/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/37638/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/37638/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/c2964489f3543b8f78d91b7185b23333b56ca0a3","head":{"label":"jterry75:devices_windows","ref":"devices_windows","sha":"c2964489f3543b8f78d91b7185b23333b56ca0a3","user":{"login":"jterry75","id":5858142,"node_id":"MDQ6VXNlcjU4NTgxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5858142?v=4","gravatar_id":"","url":"https://api.github.com/users/jterry75","html_url":"https://github.com/jterry75","followers_url":"https://api.github.com/users/jterry75/followers","following_url":"https://api.github.com/users/jterry75/following{/other_user}","gists_url":"https://api.github.com/users/jterry75/gists{/gist_id}","starred_url":"https://api.github.com/users/jterry75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jterry75/subscriptions","organizations_url":"https://api.github.com/users/jterry75/orgs","repos_url":"https://api.github.com/users/jterry75/repos","events_url":"https://api.github.com/users/jterry75/events{/privacy}","received_events_url":"https://api.github.com/users/jterry75/received_events","type":"User","site_admin":false},"repo":{"id":141350960,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzNTA5NjA=","name":"moby","full_name":"jterry75/moby","private":false,"owner":{"login":"jterry75","id":5858142,"node_id":"MDQ6VXNlcjU4NTgxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5858142?v=4","gravatar_id":"","url":"https://api.github.com/users/jterry75","html_url":"https://github.com/jterry75","followers_url":"https://api.github.com/users/jterry75/followers","following_url":"https://api.github.com/users/jterry75/following{/other_user}","gists_url":"https://api.github.com/users/jterry75/gists{/gist_id}","starred_url":"https://api.github.com/users/jterry75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jterry75/subscriptions","organizations_url":"https://api.github.com/users/jterry75/orgs","repos_url":"https://api.github.com/users/jterry75/repos","events_url":"https://api.github.com/users/jterry75/events{/privacy}","received_events_url":"https://api.github.com/users/jterry75/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jterry75/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":true,"url":"https://api.github.com/repos/jterry75/moby","forks_url":"https://api.github.com/repos/jterry75/moby/forks","keys_url":"https://api.github.com/repos/jterry75/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jterry75/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jterry75/moby/teams","hooks_url":"https://api.github.com/repos/jterry75/moby/hooks","issue_events_url":"https://api.github.com/repos/jterry75/moby/issues/events{/number}","events_url":"https://api.github.com/repos/jterry75/moby/events","assignees_url":"https://api.github.com/repos/jterry75/moby/assignees{/user}","branches_url":"https://api.github.com/repos/jterry75/moby/branches{/branch}","tags_url":"https://api.github.com/repos/jterry75/moby/tags","blobs_url":"https://api.github.com/repos/jterry75/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jterry75/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jterry75/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jterry75/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jterry75/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/jterry75/moby/languages","stargazers_url":"https://api.github.com/repos/jterry75/moby/stargazers","contributors_url":"https://api.github.com/repos/jterry75/moby/contributors","subscribers_url":"https://api.github.com/repos/jterry75/moby/subscribers","subscription_url":"https://api.github.com/repos/jterry75/moby/subscription","commits_url":"https://api.github.com/repos/jterry75/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jterry75/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jterry75/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jterry75/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jterry75/moby/contents/{+path}","compare_url":"https://api.github.com/repos/jterry75/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jterry75/moby/merges","archive_url":"https://api.github.com/repos/jterry75/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jterry75/moby/downloads","issues_url":"https://api.github.com/repos/jterry75/moby/issues{/number}","pulls_url":"https://api.github.com/repos/jterry75/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/jterry75/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/jterry75/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jterry75/moby/labels{/name}","releases_url":"https://api.github.com/repos/jterry75/moby/releases{/id}","deployments_url":"https://api.github.com/repos/jterry75/moby/deployments","created_at":"2018-07-17T22:15:28Z","updated_at":"2018-07-17T22:15:39Z","pushed_at":"2018-11-06T23:49:47Z","git_url":"git://github.com/jterry75/moby.git","ssh_url":"git@github.com:jterry75/moby.git","clone_url":"https://github.com/jterry75/moby.git","svn_url":"https://github.com/jterry75/moby","homepage":"https://mobyproject.org/","size":139628,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"2f902930e97fea52edb1a089b379792bd8e9df44","user":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"node_id":"MDEwOlJlcG9zaXRvcnk3NjkxNjMx","name":"moby","full_name":"moby/moby","private":false,"owner":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-11-15T21:53:02Z","pushed_at":"2018-11-15T17:05:48Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":139780,"stargazers_count":51090,"watchers_count":51090,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14863,"mirror_url":null,"archived":false,"open_issues_count":3473,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14863,"open_issues":3473,"watchers":51090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/37638"},"html":{"href":"https://github.com/moby/moby/pull/37638"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/37638"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/37638/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/37638/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/37638/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/c2964489f3543b8f78d91b7185b23333b56ca0a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johnstep"}}