{"action":"created","comment":{"url":"https://api.github.com/repos/sonodtt/cbmc/pulls/comments/213922372","pull_request_review_id":150859948,"id":213922372,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzkyMjM3Mg==","diff_hunk":"@@ -311,8 +311,8 @@ std::string ieee_floatt::to_string_scientific(std::size_t precision) const\n \n void ieee_floatt::unpack(const mp_integer &i)\n {\n-  assert(spec.f!=0);\n-  assert(spec.e!=0);\n+  PRECONDITION(spec.f!=0);\n+  PRECONDITION(spec.e!=0);","path":"src/util/ieee_float.cpp","position":36,"original_position":36,"commit_id":"492b8735e8c812dcc26242be54d90c5b5f30bc01","original_commit_id":"492b8735e8c812dcc26242be54d90c5b5f30bc01","user":{"login":"sonodtt","id":33834914,"node_id":"MDQ6VXNlcjMzODM0OTE0","avatar_url":"https://avatars0.githubusercontent.com/u/33834914?v=4","gravatar_id":"","url":"https://api.github.com/users/sonodtt","html_url":"https://github.com/sonodtt","followers_url":"https://api.github.com/users/sonodtt/followers","following_url":"https://api.github.com/users/sonodtt/following{/other_user}","gists_url":"https://api.github.com/users/sonodtt/gists{/gist_id}","starred_url":"https://api.github.com/users/sonodtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonodtt/subscriptions","organizations_url":"https://api.github.com/users/sonodtt/orgs","repos_url":"https://api.github.com/users/sonodtt/repos","events_url":"https://api.github.com/users/sonodtt/events{/privacy}","received_events_url":"https://api.github.com/users/sonodtt/received_events","type":"User","site_admin":false},"body":"Noted. ","created_at":"2018-08-30T07:02:14Z","updated_at":"2018-08-30T07:02:14Z","html_url":"https://github.com/sonodtt/cbmc/pull/2#discussion_r213922372","pull_request_url":"https://api.github.com/repos/sonodtt/cbmc/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sonodtt/cbmc/pulls/comments/213922372"},"html":{"href":"https://github.com/sonodtt/cbmc/pull/2#discussion_r213922372"},"pull_request":{"href":"https://api.github.com/repos/sonodtt/cbmc/pulls/2"}},"in_reply_to_id":211194115},"pull_request":{"url":"https://api.github.com/repos/sonodtt/cbmc/pulls/2","id":209449956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDQ5OTU2","html_url":"https://github.com/sonodtt/cbmc/pull/2","diff_url":"https://github.com/sonodtt/cbmc/pull/2.diff","patch_url":"https://github.com/sonodtt/cbmc/pull/2.patch","issue_url":"https://api.github.com/repos/sonodtt/cbmc/issues/2","number":2,"state":"open","locked":false,"title":"Cleanup asserts/throws in util.ieee_float.cpp","user":{"login":"sonodtt","id":33834914,"node_id":"MDQ6VXNlcjMzODM0OTE0","avatar_url":"https://avatars0.githubusercontent.com/u/33834914?v=4","gravatar_id":"","url":"https://api.github.com/users/sonodtt","html_url":"https://github.com/sonodtt","followers_url":"https://api.github.com/users/sonodtt/followers","following_url":"https://api.github.com/users/sonodtt/following{/other_user}","gists_url":"https://api.github.com/users/sonodtt/gists{/gist_id}","starred_url":"https://api.github.com/users/sonodtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonodtt/subscriptions","organizations_url":"https://api.github.com/users/sonodtt/orgs","repos_url":"https://api.github.com/users/sonodtt/repos","events_url":"https://api.github.com/users/sonodtt/events{/privacy}","received_events_url":"https://api.github.com/users/sonodtt/received_events","type":"User","site_admin":false},"body":"Flagging the lines below - advice on a suitable invariant message is welcome.\r\n[ @hannes-steffenhagen-diffblue (?) ]\r\n\r\nassert(fractionpower(2, (spec.f-lowPower2))>=f_power);\r\nassert(fractionpower(2, (spec.f-lowPower2))<f_power_next);\r\nassert(fraction/power(2, (lowPower2-spec.f))>=f_power);\r\nassert(fraction/power(2, (lowPower2-spec.f))<f_power_next);","created_at":"2018-08-20T08:43:38Z","updated_at":"2018-08-30T07:02:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a81dda9c8166db3d7467d86b06b38f2a325da1b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonodtt/cbmc/pulls/2/commits","review_comments_url":"https://api.github.com/repos/sonodtt/cbmc/pulls/2/comments","review_comment_url":"https://api.github.com/repos/sonodtt/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonodtt/cbmc/issues/2/comments","statuses_url":"https://api.github.com/repos/sonodtt/cbmc/statuses/492b8735e8c812dcc26242be54d90c5b5f30bc01","head":{"label":"sonodtt:invariant-cleanup-ieee_float","ref":"invariant-cleanup-ieee_float","sha":"492b8735e8c812dcc26242be54d90c5b5f30bc01","user":{"login":"sonodtt","id":33834914,"node_id":"MDQ6VXNlcjMzODM0OTE0","avatar_url":"https://avatars0.githubusercontent.com/u/33834914?v=4","gravatar_id":"","url":"https://api.github.com/users/sonodtt","html_url":"https://github.com/sonodtt","followers_url":"https://api.github.com/users/sonodtt/followers","following_url":"https://api.github.com/users/sonodtt/following{/other_user}","gists_url":"https://api.github.com/users/sonodtt/gists{/gist_id}","starred_url":"https://api.github.com/users/sonodtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonodtt/subscriptions","organizations_url":"https://api.github.com/users/sonodtt/orgs","repos_url":"https://api.github.com/users/sonodtt/repos","events_url":"https://api.github.com/users/sonodtt/events{/privacy}","received_events_url":"https://api.github.com/users/sonodtt/received_events","type":"User","site_admin":false},"repo":{"id":132635540,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2MzU1NDA=","name":"cbmc","full_name":"sonodtt/cbmc","owner":{"login":"sonodtt","id":33834914,"node_id":"MDQ6VXNlcjMzODM0OTE0","avatar_url":"https://avatars0.githubusercontent.com/u/33834914?v=4","gravatar_id":"","url":"https://api.github.com/users/sonodtt","html_url":"https://github.com/sonodtt","followers_url":"https://api.github.com/users/sonodtt/followers","following_url":"https://api.github.com/users/sonodtt/following{/other_user}","gists_url":"https://api.github.com/users/sonodtt/gists{/gist_id}","starred_url":"https://api.github.com/users/sonodtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonodtt/subscriptions","organizations_url":"https://api.github.com/users/sonodtt/orgs","repos_url":"https://api.github.com/users/sonodtt/repos","events_url":"https://api.github.com/users/sonodtt/events{/privacy}","received_events_url":"https://api.github.com/users/sonodtt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sonodtt/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/sonodtt/cbmc","forks_url":"https://api.github.com/repos/sonodtt/cbmc/forks","keys_url":"https://api.github.com/repos/sonodtt/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonodtt/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonodtt/cbmc/teams","hooks_url":"https://api.github.com/repos/sonodtt/cbmc/hooks","issue_events_url":"https://api.github.com/repos/sonodtt/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/sonodtt/cbmc/events","assignees_url":"https://api.github.com/repos/sonodtt/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/sonodtt/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/sonodtt/cbmc/tags","blobs_url":"https://api.github.com/repos/sonodtt/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonodtt/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonodtt/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonodtt/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonodtt/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/sonodtt/cbmc/languages","stargazers_url":"https://api.github.com/repos/sonodtt/cbmc/stargazers","contributors_url":"https://api.github.com/repos/sonodtt/cbmc/contributors","subscribers_url":"https://api.github.com/repos/sonodtt/cbmc/subscribers","subscription_url":"https://api.github.com/repos/sonodtt/cbmc/subscription","commits_url":"https://api.github.com/repos/sonodtt/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonodtt/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonodtt/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonodtt/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonodtt/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/sonodtt/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonodtt/cbmc/merges","archive_url":"https://api.github.com/repos/sonodtt/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonodtt/cbmc/downloads","issues_url":"https://api.github.com/repos/sonodtt/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/sonodtt/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/sonodtt/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/sonodtt/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonodtt/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/sonodtt/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/sonodtt/cbmc/deployments","created_at":"2018-05-08T16:23:07Z","updated_at":"2018-08-29T12:19:25Z","pushed_at":"2018-08-29T13:53:32Z","git_url":"git://github.com/sonodtt/cbmc.git","ssh_url":"git@github.com:sonodtt/cbmc.git","clone_url":"https://github.com/sonodtt/cbmc.git","svn_url":"https://github.com/sonodtt/cbmc","homepage":"http://www.cprover.org/cbmc","size":34799,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"sonodtt:develop","ref":"develop","sha":"8640288662b77e21ca532642d8f9a99f165f6912","user":{"login":"sonodtt","id":33834914,"node_id":"MDQ6VXNlcjMzODM0OTE0","avatar_url":"https://avatars0.githubusercontent.com/u/33834914?v=4","gravatar_id":"","url":"https://api.github.com/users/sonodtt","html_url":"https://github.com/sonodtt","followers_url":"https://api.github.com/users/sonodtt/followers","following_url":"https://api.github.com/users/sonodtt/following{/other_user}","gists_url":"https://api.github.com/users/sonodtt/gists{/gist_id}","starred_url":"https://api.github.com/users/sonodtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonodtt/subscriptions","organizations_url":"https://api.github.com/users/sonodtt/orgs","repos_url":"https://api.github.com/users/sonodtt/repos","events_url":"https://api.github.com/users/sonodtt/events{/privacy}","received_events_url":"https://api.github.com/users/sonodtt/received_events","type":"User","site_admin":false},"repo":{"id":132635540,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2MzU1NDA=","name":"cbmc","full_name":"sonodtt/cbmc","owner":{"login":"sonodtt","id":33834914,"node_id":"MDQ6VXNlcjMzODM0OTE0","avatar_url":"https://avatars0.githubusercontent.com/u/33834914?v=4","gravatar_id":"","url":"https://api.github.com/users/sonodtt","html_url":"https://github.com/sonodtt","followers_url":"https://api.github.com/users/sonodtt/followers","following_url":"https://api.github.com/users/sonodtt/following{/other_user}","gists_url":"https://api.github.com/users/sonodtt/gists{/gist_id}","starred_url":"https://api.github.com/users/sonodtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonodtt/subscriptions","organizations_url":"https://api.github.com/users/sonodtt/orgs","repos_url":"https://api.github.com/users/sonodtt/repos","events_url":"https://api.github.com/users/sonodtt/events{/privacy}","received_events_url":"https://api.github.com/users/sonodtt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sonodtt/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/sonodtt/cbmc","forks_url":"https://api.github.com/repos/sonodtt/cbmc/forks","keys_url":"https://api.github.com/repos/sonodtt/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonodtt/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonodtt/cbmc/teams","hooks_url":"https://api.github.com/repos/sonodtt/cbmc/hooks","issue_events_url":"https://api.github.com/repos/sonodtt/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/sonodtt/cbmc/events","assignees_url":"https://api.github.com/repos/sonodtt/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/sonodtt/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/sonodtt/cbmc/tags","blobs_url":"https://api.github.com/repos/sonodtt/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonodtt/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonodtt/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonodtt/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonodtt/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/sonodtt/cbmc/languages","stargazers_url":"https://api.github.com/repos/sonodtt/cbmc/stargazers","contributors_url":"https://api.github.com/repos/sonodtt/cbmc/contributors","subscribers_url":"https://api.github.com/repos/sonodtt/cbmc/subscribers","subscription_url":"https://api.github.com/repos/sonodtt/cbmc/subscription","commits_url":"https://api.github.com/repos/sonodtt/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonodtt/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonodtt/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonodtt/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonodtt/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/sonodtt/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonodtt/cbmc/merges","archive_url":"https://api.github.com/repos/sonodtt/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonodtt/cbmc/downloads","issues_url":"https://api.github.com/repos/sonodtt/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/sonodtt/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/sonodtt/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/sonodtt/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonodtt/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/sonodtt/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/sonodtt/cbmc/deployments","created_at":"2018-05-08T16:23:07Z","updated_at":"2018-08-29T12:19:25Z","pushed_at":"2018-08-29T13:53:32Z","git_url":"git://github.com/sonodtt/cbmc.git","ssh_url":"git@github.com:sonodtt/cbmc.git","clone_url":"https://github.com/sonodtt/cbmc.git","svn_url":"https://github.com/sonodtt/cbmc","homepage":"http://www.cprover.org/cbmc","size":34799,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sonodtt/cbmc/pulls/2"},"html":{"href":"https://github.com/sonodtt/cbmc/pull/2"},"issue":{"href":"https://api.github.com/repos/sonodtt/cbmc/issues/2"},"comments":{"href":"https://api.github.com/repos/sonodtt/cbmc/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/sonodtt/cbmc/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/sonodtt/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonodtt/cbmc/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/sonodtt/cbmc/statuses/492b8735e8c812dcc26242be54d90c5b5f30bc01"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sonodtt"}}