{"action":"created","comment":{"url":"https://api.github.com/repos/pry/pry/pulls/comments/236092936","pull_request_review_id":178100047,"id":236092936,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA5MjkzNg==","diff_hunk":"@@ -54,6 +59,10 @@\n         expect(ring[-3]).to eq(3)\n       end\n \n+      it \"reads elements via single range\" do","path":"spec/ring_spec.rb","position":16,"original_position":16,"commit_id":"04f900b9a1c677dd5442bccffae85a1dd2d25af8","original_commit_id":"04f900b9a1c677dd5442bccffae85a1dd2d25af8","user":{"login":"r-obert","id":8934693,"node_id":"MDQ6VXNlcjg5MzQ2OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8934693?v=4","gravatar_id":"","url":"https://api.github.com/users/r-obert","html_url":"https://github.com/r-obert","followers_url":"https://api.github.com/users/r-obert/followers","following_url":"https://api.github.com/users/r-obert/following{/other_user}","gists_url":"https://api.github.com/users/r-obert/gists{/gist_id}","starred_url":"https://api.github.com/users/r-obert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-obert/subscriptions","organizations_url":"https://api.github.com/users/r-obert/orgs","repos_url":"https://api.github.com/users/r-obert/repos","events_url":"https://api.github.com/users/r-obert/events{/privacy}","received_events_url":"https://api.github.com/users/r-obert/received_events","type":"User","site_admin":false},"body":"```ruby\r\nit \"returns the first element when accessed through 0..0\"  do \r\n ..\r\nend\r\n```\r\nmight remove the complexity of trying to describe what `0..0` is. ","created_at":"2018-11-25T22:18:49Z","updated_at":"2018-11-25T22:18:49Z","html_url":"https://github.com/pry/pry/pull/1898#discussion_r236092936","pull_request_url":"https://api.github.com/repos/pry/pry/pulls/1898","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pry/pry/pulls/comments/236092936"},"html":{"href":"https://github.com/pry/pry/pull/1898#discussion_r236092936"},"pull_request":{"href":"https://api.github.com/repos/pry/pry/pulls/1898"}},"in_reply_to_id":236089804},"pull_request":{"url":"https://api.github.com/repos/pry/pry/pulls/1898","id":233362286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzYyMjg2","html_url":"https://github.com/pry/pry/pull/1898","diff_url":"https://github.com/pry/pry/pull/1898.diff","patch_url":"https://github.com/pry/pry/pull/1898.patch","issue_url":"https://api.github.com/repos/pry/pry/issues/1898","number":1898,"state":"open","locked":false,"title":"ring: fix swap parts of array in to_a and index access","user":{"login":"zaru","id":235650,"node_id":"MDQ6VXNlcjIzNTY1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/235650?v=4","gravatar_id":"","url":"https://api.github.com/users/zaru","html_url":"https://github.com/zaru","followers_url":"https://api.github.com/users/zaru/followers","following_url":"https://api.github.com/users/zaru/following{/other_user}","gists_url":"https://api.github.com/users/zaru/gists{/gist_id}","starred_url":"https://api.github.com/users/zaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaru/subscriptions","organizations_url":"https://api.github.com/users/zaru/orgs","repos_url":"https://api.github.com/users/zaru/repos","events_url":"https://api.github.com/users/zaru/events{/privacy}","received_events_url":"https://api.github.com/users/zaru/received_events","type":"User","site_admin":false},"body":"I fixed a bug where the same value disappears when swapping parts of the array. \r\n\r\nexample\r\n\r\n`Pry.config.memory_size = 3`\r\n\r\nbefore\r\n\r\n```\r\n[1] pry(main)> 1\r\n=> 1\r\n[2] pry(main)> 1\r\n=> 1\r\n[3] pry(main)> 1\r\n=> 1\r\n[3] pry(main)> 1\r\n=> 1\r\n[4] pry(main)> _pry_.input_ring.to_a\r\n=> [\"1\\n\"]\r\n```\r\n\r\nafter\r\n\r\n```\r\n[1] pry(main)> 1\r\n=> 1\r\n[2] pry(main)> 1\r\n=> 1\r\n[3] pry(main)> 1\r\n=> 1\r\n[4] pry(main)> 1\r\n=> 1\r\n[5] pry(main)> _pry_.input_ring.to_a\r\n=> [\"1\\n\", \"1\\n\", \"1\\n\"]\r\n```\r\n\r\nand I fixed a bug that different values will be returned for Integer and Range.\r\n\r\n```\r\n[1] pry(main)> 1\r\n=> 1\r\n[2] pry(main)> 2\r\n=> 2\r\n[3] pry(main)> 3\r\n=> 3\r\n[4] pry(main)> 4\r\n=> 4\r\n```\r\n\r\n```\r\n[4] pry(main)> _pry_.input_ring[0]\r\n=> \"2\\n\"\r\n\r\n[4] pry(main)> _pry_.input_ring[0..0]\r\n=> \"3\\n\"\r\n```","created_at":"2018-11-25T08:11:05Z","updated_at":"2018-11-25T22:18:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a9bf40d1e19ed32e29f8d71b5668a59632fcec2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pry/pry/pulls/1898/commits","review_comments_url":"https://api.github.com/repos/pry/pry/pulls/1898/comments","review_comment_url":"https://api.github.com/repos/pry/pry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pry/pry/issues/1898/comments","statuses_url":"https://api.github.com/repos/pry/pry/statuses/04f900b9a1c677dd5442bccffae85a1dd2d25af8","head":{"label":"zaru:fix-input-ring","ref":"fix-input-ring","sha":"04f900b9a1c677dd5442bccffae85a1dd2d25af8","user":{"login":"zaru","id":235650,"node_id":"MDQ6VXNlcjIzNTY1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/235650?v=4","gravatar_id":"","url":"https://api.github.com/users/zaru","html_url":"https://github.com/zaru","followers_url":"https://api.github.com/users/zaru/followers","following_url":"https://api.github.com/users/zaru/following{/other_user}","gists_url":"https://api.github.com/users/zaru/gists{/gist_id}","starred_url":"https://api.github.com/users/zaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaru/subscriptions","organizations_url":"https://api.github.com/users/zaru/orgs","repos_url":"https://api.github.com/users/zaru/repos","events_url":"https://api.github.com/users/zaru/events{/privacy}","received_events_url":"https://api.github.com/users/zaru/received_events","type":"User","site_admin":false},"repo":{"id":159009120,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkwMDkxMjA=","name":"pry","full_name":"zaru/pry","private":false,"owner":{"login":"zaru","id":235650,"node_id":"MDQ6VXNlcjIzNTY1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/235650?v=4","gravatar_id":"","url":"https://api.github.com/users/zaru","html_url":"https://github.com/zaru","followers_url":"https://api.github.com/users/zaru/followers","following_url":"https://api.github.com/users/zaru/following{/other_user}","gists_url":"https://api.github.com/users/zaru/gists{/gist_id}","starred_url":"https://api.github.com/users/zaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaru/subscriptions","organizations_url":"https://api.github.com/users/zaru/orgs","repos_url":"https://api.github.com/users/zaru/repos","events_url":"https://api.github.com/users/zaru/events{/privacy}","received_events_url":"https://api.github.com/users/zaru/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zaru/pry","description":"A runtime developer console and IRB alternative with powerful introspection capabilities.","fork":true,"url":"https://api.github.com/repos/zaru/pry","forks_url":"https://api.github.com/repos/zaru/pry/forks","keys_url":"https://api.github.com/repos/zaru/pry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaru/pry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaru/pry/teams","hooks_url":"https://api.github.com/repos/zaru/pry/hooks","issue_events_url":"https://api.github.com/repos/zaru/pry/issues/events{/number}","events_url":"https://api.github.com/repos/zaru/pry/events","assignees_url":"https://api.github.com/repos/zaru/pry/assignees{/user}","branches_url":"https://api.github.com/repos/zaru/pry/branches{/branch}","tags_url":"https://api.github.com/repos/zaru/pry/tags","blobs_url":"https://api.github.com/repos/zaru/pry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaru/pry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaru/pry/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaru/pry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaru/pry/statuses/{sha}","languages_url":"https://api.github.com/repos/zaru/pry/languages","stargazers_url":"https://api.github.com/repos/zaru/pry/stargazers","contributors_url":"https://api.github.com/repos/zaru/pry/contributors","subscribers_url":"https://api.github.com/repos/zaru/pry/subscribers","subscription_url":"https://api.github.com/repos/zaru/pry/subscription","commits_url":"https://api.github.com/repos/zaru/pry/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaru/pry/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaru/pry/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaru/pry/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaru/pry/contents/{+path}","compare_url":"https://api.github.com/repos/zaru/pry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaru/pry/merges","archive_url":"https://api.github.com/repos/zaru/pry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaru/pry/downloads","issues_url":"https://api.github.com/repos/zaru/pry/issues{/number}","pulls_url":"https://api.github.com/repos/zaru/pry/pulls{/number}","milestones_url":"https://api.github.com/repos/zaru/pry/milestones{/number}","notifications_url":"https://api.github.com/repos/zaru/pry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaru/pry/labels{/name}","releases_url":"https://api.github.com/repos/zaru/pry/releases{/id}","deployments_url":"https://api.github.com/repos/zaru/pry/deployments","created_at":"2018-11-25T07:40:53Z","updated_at":"2018-11-25T07:40:55Z","pushed_at":"2018-11-25T13:54:04Z","git_url":"git://github.com/zaru/pry.git","ssh_url":"git@github.com:zaru/pry.git","clone_url":"https://github.com/zaru/pry.git","svn_url":"https://github.com/zaru/pry","homepage":"http://pryrepl.org","size":7292,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pry:master","ref":"master","sha":"85850f47e074fe01f93e5cb7d561e7c2de7aede9","user":{"login":"pry","id":845682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTY4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/845682?v=4","gravatar_id":"","url":"https://api.github.com/users/pry","html_url":"https://github.com/pry","followers_url":"https://api.github.com/users/pry/followers","following_url":"https://api.github.com/users/pry/following{/other_user}","gists_url":"https://api.github.com/users/pry/gists{/gist_id}","starred_url":"https://api.github.com/users/pry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pry/subscriptions","organizations_url":"https://api.github.com/users/pry/orgs","repos_url":"https://api.github.com/users/pry/repos","events_url":"https://api.github.com/users/pry/events{/privacy}","received_events_url":"https://api.github.com/users/pry/received_events","type":"Organization","site_admin":false},"repo":{"id":1145832,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ1ODMy","name":"pry","full_name":"pry/pry","private":false,"owner":{"login":"pry","id":845682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTY4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/845682?v=4","gravatar_id":"","url":"https://api.github.com/users/pry","html_url":"https://github.com/pry","followers_url":"https://api.github.com/users/pry/followers","following_url":"https://api.github.com/users/pry/following{/other_user}","gists_url":"https://api.github.com/users/pry/gists{/gist_id}","starred_url":"https://api.github.com/users/pry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pry/subscriptions","organizations_url":"https://api.github.com/users/pry/orgs","repos_url":"https://api.github.com/users/pry/repos","events_url":"https://api.github.com/users/pry/events{/privacy}","received_events_url":"https://api.github.com/users/pry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pry/pry","description":"A runtime developer console and IRB alternative with powerful introspection capabilities.","fork":false,"url":"https://api.github.com/repos/pry/pry","forks_url":"https://api.github.com/repos/pry/pry/forks","keys_url":"https://api.github.com/repos/pry/pry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pry/pry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pry/pry/teams","hooks_url":"https://api.github.com/repos/pry/pry/hooks","issue_events_url":"https://api.github.com/repos/pry/pry/issues/events{/number}","events_url":"https://api.github.com/repos/pry/pry/events","assignees_url":"https://api.github.com/repos/pry/pry/assignees{/user}","branches_url":"https://api.github.com/repos/pry/pry/branches{/branch}","tags_url":"https://api.github.com/repos/pry/pry/tags","blobs_url":"https://api.github.com/repos/pry/pry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pry/pry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pry/pry/git/refs{/sha}","trees_url":"https://api.github.com/repos/pry/pry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pry/pry/statuses/{sha}","languages_url":"https://api.github.com/repos/pry/pry/languages","stargazers_url":"https://api.github.com/repos/pry/pry/stargazers","contributors_url":"https://api.github.com/repos/pry/pry/contributors","subscribers_url":"https://api.github.com/repos/pry/pry/subscribers","subscription_url":"https://api.github.com/repos/pry/pry/subscription","commits_url":"https://api.github.com/repos/pry/pry/commits{/sha}","git_commits_url":"https://api.github.com/repos/pry/pry/git/commits{/sha}","comments_url":"https://api.github.com/repos/pry/pry/comments{/number}","issue_comment_url":"https://api.github.com/repos/pry/pry/issues/comments{/number}","contents_url":"https://api.github.com/repos/pry/pry/contents/{+path}","compare_url":"https://api.github.com/repos/pry/pry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pry/pry/merges","archive_url":"https://api.github.com/repos/pry/pry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pry/pry/downloads","issues_url":"https://api.github.com/repos/pry/pry/issues{/number}","pulls_url":"https://api.github.com/repos/pry/pry/pulls{/number}","milestones_url":"https://api.github.com/repos/pry/pry/milestones{/number}","notifications_url":"https://api.github.com/repos/pry/pry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pry/pry/labels{/name}","releases_url":"https://api.github.com/repos/pry/pry/releases{/id}","deployments_url":"https://api.github.com/repos/pry/pry/deployments","created_at":"2010-12-07T08:10:47Z","updated_at":"2018-11-24T14:26:12Z","pushed_at":"2018-11-25T13:54:05Z","git_url":"git://github.com/pry/pry.git","ssh_url":"git@github.com:pry/pry.git","clone_url":"https://github.com/pry/pry.git","svn_url":"https://github.com/pry/pry","homepage":"http://pryrepl.org","size":7282,"stargazers_count":5377,"watchers_count":5377,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":491,"mirror_url":null,"archived":false,"open_issues_count":184,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":491,"open_issues":184,"watchers":5377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pry/pry/pulls/1898"},"html":{"href":"https://github.com/pry/pry/pull/1898"},"issue":{"href":"https://api.github.com/repos/pry/pry/issues/1898"},"comments":{"href":"https://api.github.com/repos/pry/pry/issues/1898/comments"},"review_comments":{"href":"https://api.github.com/repos/pry/pry/pulls/1898/comments"},"review_comment":{"href":"https://api.github.com/repos/pry/pry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pry/pry/pulls/1898/commits"},"statuses":{"href":"https://api.github.com/repos/pry/pry/statuses/04f900b9a1c677dd5442bccffae85a1dd2d25af8"}},"author_association":"NONE"}}
{"actor":{"display_login":"r-obert"}}