{"push_id":2730380745,"size":7,"distinct_size":1,"ref":"refs/heads/commitfest/18/1637","head":"b2baf409763f38f7fa4c23f9073b16936d1bac3c","before":"3ff32690a205f67d33a6e6cf4555eab9c8c2dd89","commits":[{"sha":"6b387179baab8d0e5da6570678eefbe61f3acc79","author":{"name":"Heikki Linnakangas","email":"ac1e0af1ee8efe15f889b38482e897ff7d0f0432@iki.fi"},"message":"Fix misc typos, mostly in comments.\n\nA collection of typos I happened to spot while reading code, as well as\ngrepping for common mistakes.\n\nBackpatch to all supported versions, as applicable, to avoid conflicts\nwhen backporting other commits in the future.","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/6b387179baab8d0e5da6570678eefbe61f3acc79"},{"sha":"3cb646264e8ced9f25557ce271284da512d92043","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Use a ResourceOwner to track buffer pins in all cases.\n\nHistorically, we've allowed auxiliary processes to take buffer pins without\ntracking them in a ResourceOwner.  However, that creates problems for error\nrecovery.  In particular, we've seen multiple reports of assertion crashes\nin the startup process when it gets an error while holding a buffer pin,\nas for example if it gets ENOSPC during a write.  In a non-assert build,\nthe process would simply exit without releasing the pin at all.  We've\ngotten away with that so far just because a failure exit of the startup\nprocess translates to a database crash anyhow; but any similar behavior\nin other aux processes could result in stuck pins and subsequent problems\nin vacuum.\n\nTo improve this, institute a policy that we must *always* have a resowner\nbacking any attempt to pin a buffer, which we can enforce just by removing\nthe previous special-case code in resowner.c.  Add infrastructure to make\nit easy to create a process-lifespan AuxProcessResourceOwner and clear\nout its contents at appropriate times.  Replace existing ad-hoc resowner\nmanagement in bgwriter.c and other aux processes with that.  (Thus, while\nthe startup process gains a resowner where it had none at all before, some\nother aux process types are replacing an ad-hoc resowner with this code.)\nAlso use the AuxProcessResourceOwner to manage buffer pins taken during\nStartupXLOG and ShutdownXLOG, even when those are being run in a bootstrap\nprocess or a standalone backend rather than a true auxiliary process.\n\nIn passing, remove some other ad-hoc resource owner creations that had\ngotten cargo-culted into various other places.  As far as I can tell\nthat was all unnecessary, and if it had been necessary it was incomplete,\ndue to lacking any provision for clearing those resowners later.\n(Also worth noting in this connection is that a process that hasn't called\nInitBufferPoolBackend has no business accessing buffers; so there's more\nto do than just add the resowner if we want to touch buffers in processes\nnot covered by this patch.)\n\nAlthough this fixes a very old bug, no back-patch, because there's no\nevidence of any significant problem in non-assert builds.\n\nPatch by me, pursuant to a report from Justin Pryzby.  Thanks to\nRobert Haas and Kyotaro Horiguchi for reviews.\n\nDiscussion: https://postgr.es/m/20180627233939.GA10276@telsasoft.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/3cb646264e8ced9f25557ce271284da512d92043"},{"sha":"701fd0bbc98fe8211d36e96f90753985104cd295","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Drop the rule against included index columns duplicating key columns.\n\nThe initial version of the included-index-column feature stated that\nincluded columns couldn't be the same as any key column of the index.\nWhile it'd be pretty silly to do that, since the included column would be\nentirely redundant, we've never prohibited redundant index columns before\nso it's not very consistent to do so here.  Moreover, the prohibition\nwas itself badly implemented, so that it failed to reject columns that\nwere effectively identical but not spelled quite alike, as reported by\nAditya Toshniwal.\n\n(Moreover, it's not hard to imagine that for some non-btree index types,\nsuch cases would be non-silly anyhow: the index might use a lossy\nrepresentation for key columns but be able to support retrieval of the\noriginal form of included columns.)\n\nHence, let's just drop the prohibition.\n\nIn passing, do some copy-editing on the documentation for the\nincluded-column feature.\n\nYugo Nagata; documentation and test corrections by me\n\nDiscussion: https://postgr.es/m/CAM9w-_mhBCys4fQNfaiQKTRrVWtoFrZ-wXmDuE9Nj5y-Y7aDKQ@mail.gmail.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/701fd0bbc98fe8211d36e96f90753985104cd295"},{"sha":"a360f952ff028f8b85029334c54c025c716eb68e","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Remove race-prone hot_standby_feedback test cases in 001_stream_rep.pl.\n\nThis script supposed that if it turned hot_standby_feedback on and then\nshut down the standby server, at least one feedback message would be\nguaranteed to be sent before the standby stops.  But there is no such\nguarantee, if the standby's walreceiver process is slow enough --- and\nwe've seen multiple failures in the buildfarm showing that that does\nhappen in practice.  While we could rearrange the walreceiver logic to\nmake it less likely, it seems probably impossible to create a really\nbulletproof guarantee of that sort; and if we tried, we might create\nsituations where the walreceiver wouldn't react in a timely manner to\nshutdown commands.  It seems better instead to remove the script's\nassumption that feedback will occur before shutdown.\n\nBut once we do that, these last few tests seem quite redundant with\nthe earlier tests in the script.  So let's just drop them altogether\nand save some buildfarm cycles.\n\nBackpatch to v10 where these tests were added.\n\nDiscussion: https://postgr.es/m/1922.1531592205@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/a360f952ff028f8b85029334c54c025c716eb68e"},{"sha":"c6598b8b0514bcb9b4c99f2412927368a7514180","author":{"name":"Michael Paquier","email":"17b9e1c64588c7fa6419b4d29dc1f4426279ba01@paquier.xyz"},"message":"Fix re-parameterize of MergeAppendPath\n\nInstead of MergeAppendPath, MergeAppend nodes were considered.  This\ncode is not covered by any tests now, which should be addressed at some\npoint.\n\nThis is an oversight from f49842d, which introduced partition-wise joins\nin v11, so back-patch down to that.\n\nAuthor: Michael Paquier\nReviewed-by: Ashutosh Bapat\nDiscussion: https://postgr.es/m/20180718062202.GC8565@paquier.xyz","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/c6598b8b0514bcb9b4c99f2412927368a7514180"},{"sha":"b33ef397a1698ddd06f325d0f92a6643ec55577f","author":{"name":"Michael Paquier","email":"17b9e1c64588c7fa6419b4d29dc1f4426279ba01@paquier.xyz"},"message":"Fix print of Path nodes when using OPTIMIZER_DEBUG\n\nGatherMergePath (introduced in 10) and CustomPath (introduced in 9.5)\nhave gone missing.  The order of the Path nodes was inconsistent with\nwhat is listed in nodes.h, so make the order consistent at the same time\nto ease future checks and additions.\n\nAuthor: Sawada Masahiko\nReviewed-by: Michael Paquier\nDiscussion: https://postgr.es/m/CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/b33ef397a1698ddd06f325d0f92a6643ec55577f"},{"sha":"b2baf409763f38f7fa4c23f9073b16936d1bac3c","author":{"name":"Commitfest Bot","email":"b9e638e07cc2e2abf56c9c0cad7954f2e3bc1641@cputube.org"},"message":"[CF 18/1637] pg_ugprade test failure on data set with column with default value with type bit/varbit\n\nThis commit was automatically generated by cfbot at commitfest.cputube.org.\nIt is based on patches submitted to the PostgreSQL mailing lists and\nregistered in the PostgreSQL Commitfest application.\n\nThis branch will be overwritten each time a new patch version is posted to\nthe email thread, and also periodically to check for bitrot caused by changes\non the master branch.\n\nCommitfest entry: https://commitfest.postgresql.org/18/1637\nPatch(es): https://www.postgresql.org/message-id/CABQrizc90sfkZgi4=+0Bbp1Zu3yEx9sM4rjBE1YNCvzf3qKHkA@mail.gmail.com\nAuthor(s): Paul Guo","distinct":true,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/b2baf409763f38f7fa4c23f9073b16936d1bac3c"}]}
{"actor":{"display_login":"postgresql-cfbot"}}