{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/214492297","pull_request_review_id":151569248,"id":214492297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ5MjI5Nw==","diff_hunk":"@@ -72,12 +72,33 @@ private[spark] trait PythonTestsSuite { k8sSuite: KubernetesSuite =>\n       isJVM = false,\n       pyFiles = Some(PYSPARK_CONTAINER_TESTS))\n   }\n+\n+  test(\"Run PySpark with memory customization\", k8sTestTag) {\n+    sparkAppConf\n+      .set(\"spark.kubernetes.container.image\", s\"${getTestImageRepo}/spark-py:${getTestImageTag}\")","path":"resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala","position":null,"original_position":7,"commit_id":"467703bfb8bde570b5b0cad11904cb92641dcd84","original_commit_id":"46c30cc27cd3a7279a116ec6a70a937b8502cd73","user":{"login":"mccheah","id":8975385,"node_id":"MDQ6VXNlcjg5NzUzODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8975385?v=4","gravatar_id":"","url":"https://api.github.com/users/mccheah","html_url":"https://github.com/mccheah","followers_url":"https://api.github.com/users/mccheah/followers","following_url":"https://api.github.com/users/mccheah/following{/other_user}","gists_url":"https://api.github.com/users/mccheah/gists{/gist_id}","starred_url":"https://api.github.com/users/mccheah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccheah/subscriptions","organizations_url":"https://api.github.com/users/mccheah/orgs","repos_url":"https://api.github.com/users/mccheah/repos","events_url":"https://api.github.com/users/mccheah/events{/privacy}","received_events_url":"https://api.github.com/users/mccheah/received_events","type":"User","site_admin":false},"body":"Some of this stuff can be factored out I think, we just haven't done so yet. I wouldn't block a merge of this on such a refactor, but this entire test class could probably use some cleanup with respect to how the code is structured.","created_at":"2018-08-31T23:02:09Z","updated_at":"2018-08-31T23:02:09Z","html_url":"https://github.com/apache/spark/pull/22298#discussion_r214492297","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22298","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/214492297"},"html":{"href":"https://github.com/apache/spark/pull/22298#discussion_r214492297"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22298"}},"in_reply_to_id":214408969},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22298","id":212272795,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjcyNzk1","html_url":"https://github.com/apache/spark/pull/22298","diff_url":"https://github.com/apache/spark/pull/22298.diff","patch_url":"https://github.com/apache/spark/pull/22298.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22298","number":22298,"state":"open","locked":false,"title":"[SPARK-25021][K8S] Add spark.executor.pyspark.memory limit for K8S","user":{"login":"ifilonenko","id":4926714,"node_id":"MDQ6VXNlcjQ5MjY3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4926714?v=4","gravatar_id":"","url":"https://api.github.com/users/ifilonenko","html_url":"https://github.com/ifilonenko","followers_url":"https://api.github.com/users/ifilonenko/followers","following_url":"https://api.github.com/users/ifilonenko/following{/other_user}","gists_url":"https://api.github.com/users/ifilonenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ifilonenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifilonenko/subscriptions","organizations_url":"https://api.github.com/users/ifilonenko/orgs","repos_url":"https://api.github.com/users/ifilonenko/repos","events_url":"https://api.github.com/users/ifilonenko/events{/privacy}","received_events_url":"https://api.github.com/users/ifilonenko/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nAdd spark.executor.pyspark.memory limit for K8S\r\n\r\n## How was this patch tested?\r\n\r\nUnit and Integration tests","created_at":"2018-08-31T04:46:27Z","updated_at":"2018-08-31T23:02:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9137d3709e11a70c512f09f358a11c678af1b4c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22298/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22298/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22298/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/467703bfb8bde570b5b0cad11904cb92641dcd84","head":{"label":"ifilonenko:SPARK-25021","ref":"SPARK-25021","sha":"467703bfb8bde570b5b0cad11904cb92641dcd84","user":{"login":"ifilonenko","id":4926714,"node_id":"MDQ6VXNlcjQ5MjY3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4926714?v=4","gravatar_id":"","url":"https://api.github.com/users/ifilonenko","html_url":"https://github.com/ifilonenko","followers_url":"https://api.github.com/users/ifilonenko/followers","following_url":"https://api.github.com/users/ifilonenko/following{/other_user}","gists_url":"https://api.github.com/users/ifilonenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ifilonenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifilonenko/subscriptions","organizations_url":"https://api.github.com/users/ifilonenko/orgs","repos_url":"https://api.github.com/users/ifilonenko/repos","events_url":"https://api.github.com/users/ifilonenko/events{/privacy}","received_events_url":"https://api.github.com/users/ifilonenko/received_events","type":"User","site_admin":false},"repo":{"id":92633687,"node_id":"MDEwOlJlcG9zaXRvcnk5MjYzMzY4Nw==","name":"spark","full_name":"ifilonenko/spark","owner":{"login":"ifilonenko","id":4926714,"node_id":"MDQ6VXNlcjQ5MjY3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4926714?v=4","gravatar_id":"","url":"https://api.github.com/users/ifilonenko","html_url":"https://github.com/ifilonenko","followers_url":"https://api.github.com/users/ifilonenko/followers","following_url":"https://api.github.com/users/ifilonenko/following{/other_user}","gists_url":"https://api.github.com/users/ifilonenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ifilonenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifilonenko/subscriptions","organizations_url":"https://api.github.com/users/ifilonenko/orgs","repos_url":"https://api.github.com/users/ifilonenko/repos","events_url":"https://api.github.com/users/ifilonenko/events{/privacy}","received_events_url":"https://api.github.com/users/ifilonenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifilonenko/spark","description":"Apache Spark enhanced with native Kubernetes scheduler back-end","fork":true,"url":"https://api.github.com/repos/ifilonenko/spark","forks_url":"https://api.github.com/repos/ifilonenko/spark/forks","keys_url":"https://api.github.com/repos/ifilonenko/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifilonenko/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifilonenko/spark/teams","hooks_url":"https://api.github.com/repos/ifilonenko/spark/hooks","issue_events_url":"https://api.github.com/repos/ifilonenko/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ifilonenko/spark/events","assignees_url":"https://api.github.com/repos/ifilonenko/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ifilonenko/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ifilonenko/spark/tags","blobs_url":"https://api.github.com/repos/ifilonenko/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifilonenko/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifilonenko/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifilonenko/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifilonenko/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ifilonenko/spark/languages","stargazers_url":"https://api.github.com/repos/ifilonenko/spark/stargazers","contributors_url":"https://api.github.com/repos/ifilonenko/spark/contributors","subscribers_url":"https://api.github.com/repos/ifilonenko/spark/subscribers","subscription_url":"https://api.github.com/repos/ifilonenko/spark/subscription","commits_url":"https://api.github.com/repos/ifilonenko/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifilonenko/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifilonenko/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifilonenko/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifilonenko/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ifilonenko/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifilonenko/spark/merges","archive_url":"https://api.github.com/repos/ifilonenko/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifilonenko/spark/downloads","issues_url":"https://api.github.com/repos/ifilonenko/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ifilonenko/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ifilonenko/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ifilonenko/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifilonenko/spark/labels{/name}","releases_url":"https://api.github.com/repos/ifilonenko/spark/releases{/id}","deployments_url":"https://api.github.com/repos/ifilonenko/spark/deployments","created_at":"2017-05-28T01:38:35Z","updated_at":"2017-05-28T01:38:58Z","pushed_at":"2018-08-31T21:30:49Z","git_url":"git://github.com/ifilonenko/spark.git","ssh_url":"git@github.com:ifilonenko/spark.git","clone_url":"https://github.com/ifilonenko/spark.git","svn_url":"https://github.com/ifilonenko/spark","homepage":"","size":276643,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"branch-2.1-kubernetes"}},"base":{"label":"apache:master","ref":"master","sha":"f29c2b5287563c0d6f55f936bd5a75707d7b2b1f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-08-31T22:51:02Z","pushed_at":"2018-08-31T22:47:07Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":280551,"stargazers_count":18597,"watchers_count":18597,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16797,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16797,"open_issues":501,"watchers":18597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22298"},"html":{"href":"https://github.com/apache/spark/pull/22298"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22298"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22298/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22298/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22298/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/467703bfb8bde570b5b0cad11904cb92641dcd84"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mccheah"}}