{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/48523","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/48523/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/48523/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/48523/events","html_url":"https://github.com/rust-lang/rust/pull/48523","id":299987339,"number":48523,"title":"The Great Generics Generalisation: Ty Edition","user":{"login":"varkor","id":3943692,"avatar_url":"https://avatars1.githubusercontent.com/u/3943692?v=4","gravatar_id":"","url":"https://api.github.com/users/varkor","html_url":"https://github.com/varkor","followers_url":"https://api.github.com/users/varkor/followers","following_url":"https://api.github.com/users/varkor/following{/other_user}","gists_url":"https://api.github.com/users/varkor/gists{/gist_id}","starred_url":"https://api.github.com/users/varkor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkor/subscriptions","organizations_url":"https://api.github.com/users/varkor/orgs","repos_url":"https://api.github.com/users/varkor/repos","events_url":"https://api.github.com/users/varkor/events{/privacy}","received_events_url":"https://api.github.com/users/varkor/received_events","type":"User","site_admin":false},"labels":[{"id":31942528,"url":"https://api.github.com/repos/rust-lang/rust/labels/I-nominated","name":"I-nominated","color":"e10c02","default":false},{"id":583426710,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false},{"id":211668100,"url":"https://api.github.com/repos/rust-lang/rust/labels/T-compiler","name":"T-compiler","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":22,"created_at":"2018-02-25T01:08:05Z","updated_at":"2018-04-14T23:59:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/48523","html_url":"https://github.com/rust-lang/rust/pull/48523","diff_url":"https://github.com/rust-lang/rust/pull/48523.diff","patch_url":"https://github.com/rust-lang/rust/pull/48523.patch"},"body":"Part of the generic parameter refactoring effort, split off from https://github.com/rust-lang/rust/pull/48149. Contains the `ty`-relative refactoring.\r\n\r\nr? @eddyb"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/381369208","html_url":"https://github.com/rust-lang/rust/pull/48523#issuecomment-381369208","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/48523","id":381369208,"user":{"login":"rust-highfive","id":7378925,"avatar_url":"https://avatars3.githubusercontent.com/u/7378925?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-highfive","html_url":"https://github.com/rust-highfive","followers_url":"https://api.github.com/users/rust-highfive/followers","following_url":"https://api.github.com/users/rust-highfive/following{/other_user}","gists_url":"https://api.github.com/users/rust-highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-highfive/subscriptions","organizations_url":"https://api.github.com/users/rust-highfive/orgs","repos_url":"https://api.github.com/users/rust-highfive/repos","events_url":"https://api.github.com/users/rust-highfive/events{/privacy}","received_events_url":"https://api.github.com/users/rust-highfive/received_events","type":"User","site_admin":false},"created_at":"2018-04-14T23:59:37Z","updated_at":"2018-04-14T23:59:37Z","author_association":"COLLABORATOR","body":"\nYour PR [failed on Travis](https://travis-ci.org/rust-lang/rust/jobs/366639418) ([raw log](https://api.travis-ci.org/v3/job/366639418/log.txt)). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.\n\n<details><summary><i>Click to expand the log.</i></summary>\n\n```plain\nReceiving objects: 100% (365/365), 37.38 KiB | 37.38 MiB/s, done.\n---\nResolving deltas: 100% (332/332), completed with 70 local objects.\n---\n[00:00:47] configure: rust.quiet-tests     := True\n---\n[00:35:24] 2676 |                                 GenericParamDef::Type(ty_param) => {\n[00:35:24]      |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected enum `rustc::hir::GenericParam`, found enum `clean::GenericParamDef`\n[00:35:24]      |\n[00:35:24]      = note: expected type `rustc::hir::GenericParam`\n[00:35:24]                 found type `clean::GenericParamDef`\n[00:35:24]\n[00:35:24] error[E0308]: mismatched types\n[00:35:24]     --> librustdoc/clean/mod.rs:2688:33\n[00:35:24]      |\n[00:35:24] 2688 |                                 GenericParamDef::Lifetime(lt_param) => {\n[00:35:24]      |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected enum `rustc::hir::GenericParam`, found enum `clean::GenericParamDef`\n[00:35:24]      |\n[00:35:24]      = note: expected type `rustc::hir::GenericParam`\n[00:35:24]                 found type `clean::GenericParamDef`\n[00:35:24]\n[00:35:24] error[E0609]: no field `id` on type `&clean::TyParam`\n[00:35:24]     --> librustdoc/clean/mod.rs:2679:87\n[00:35:24]      |\n[00:35:24] 2679 |                                         Def::TyParam(cx.tcx.hir.local_def_id(ty_param.id));\n[00:35:24]      |                                                                                       ^^\n[00:35:24]\n[00:35:24] error[E0599]: no method named `into_inner` found for type `clean::Type` in the current scope\n[00:35:24]     --> librustdoc/clean/mod.rs:2684:66\n[00:35:24]      |\n[00:35:24] 2350 | pub enum Type {\n[00:35:24]      | ------------- method `into_inner` not found for this\n[00:35:24] ...\n[00:35:24] 2684 |                                                          default.into_inner().clean(cx));\n[00:35:24]      |                                                                  ^^^^^^^^^^\n[00:35:24]      |\n[00:35:24]      = help: items from traits can only be used if the trait is implemented and in scope\n[00:35:24]      = note: the following traits define an item `into_inner`, perhaps you need to implement one of them:\n[00:35:24]              candidate #1: `std::sys_common::IntoInner`\n[00:35:24]              candidate #2: `term::Terminal`\n[00:35:24]\n[00:35:24] error[E0609]: no field `lifetime` on type `&clean::Lifetime`\n[00:35:24]     --> librustdoc/clean/mod.rs:2693:82\n[00:35:24]      |\n[00:35:24] 2693 |                                                 cx.tcx.hir.local_def_id(lt_param.lifetime.id);\n---\n121760 ./obj/build/bootstrap/debug/incremental/bootstrap-351vorei3hhuv/s-f04gc1cdhk-196yhu-3ssff2uugm5rt\n---\n$ ls -lat $HOME/Library/Logs/DiagnosticReports/\nls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory\ntravis_time:end:1f6c5deb:start=1523750374925352432,finish=1523750374933065454,duration=7713022\ntravis_fold:end:after_failure.2\ntravis_fold:start:after_failure.3\ntravis_time:start:0fc83304\n$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold\":start:crashlog\\n\\033[31;1m%s\\033[0m\\n\" {} \\; -exec head -750 {} \\; -exec echo travis_fold\":\"end:crashlog \\; || true\nfind: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory\ntravis_time:end:0fc83304:start=1523750374940603151,finish=1523750374947208421,duration=6605270\ntravis_fold:end:after_failure.3\ntravis_fold:start:after_failure.4\ntravis_time:start:1ef4f58d\n$ dmesg | grep -i kill\n[   10.318431] init: failsafe main process (1093) killed by TERM signal\n```\n\n</details><p></p>\n\n[I'm a bot](https://github.com/rust-ops/rust-log-analyzer)! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact **`@TimNN`**. ([Feature Requests](https://github.com/rust-ops/rust-log-analyzer/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request))\n    "}}
{"actor":{"display_login":"rust-highfive"}}