{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/9694","repository_url":"https://api.github.com/repos/rapid7/metasploit-framework","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/9694/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/9694/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/9694/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/9694","id":303703185,"number":9694,"title":"move ssh platforms to lib","user":{"login":"h00die","id":752491,"avatar_url":"https://avatars3.githubusercontent.com/u/752491?v=4","gravatar_id":"","url":"https://api.github.com/users/h00die","html_url":"https://github.com/h00die","followers_url":"https://api.github.com/users/h00die/followers","following_url":"https://api.github.com/users/h00die/following{/other_user}","gists_url":"https://api.github.com/users/h00die/gists{/gist_id}","starred_url":"https://api.github.com/users/h00die/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h00die/subscriptions","organizations_url":"https://api.github.com/users/h00die/orgs","repos_url":"https://api.github.com/users/h00die/repos","events_url":"https://api.github.com/users/h00die/events{/privacy}","received_events_url":"https://api.github.com/users/h00die/received_events","type":"User","site_admin":false},"labels":[{"id":103436071,"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/library","name":"library","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-09T02:34:10Z","updated_at":"2018-03-12T21:08:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/9694","html_url":"https://github.com/rapid7/metasploit-framework/pull/9694","diff_url":"https://github.com/rapid7/metasploit-framework/pull/9694.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/9694.patch"},"body":"`ssh_login` and `ssh_login_pubkey` contain the same case statement for setting the platform.  Moved that to a function call in the ssh lib to prevent duplication and the two lists from getting out of sync.\r\n\r\n## Verification\r\n\r\n- [ ] Start `msfconsole`\r\n- [ ] `use auxiliary/scanner/ssh/ssh_login` and `use auxiliary/scanner/ssh/ssh_login_pubkey`\r\n- [ ] set rhosts/username/password\r\n- [ ] `run`\r\n- [ ] `sessions`\r\n- [ ] **Verify** the type field has the right OS/platform set\r\n\r\n\r\nI ran this for `ssh_login`, and not pubkey but the changes were the same.  Attempted against linux (ubuntu 16.04) and solaris (10).\r\n```\r\nmsf5 auxiliary(scanner/ssh/ssh_login) > sessions\r\n\r\nActive sessions\r\n===============\r\n\r\n  Id  Name  Type            Information                           Connection\r\n  --  ----  ----            -----------                           ----------\r\n  1         shell /linux    SSH ubuntu:ubuntu (1.2.3.4:22)  9.9.9.9:37057 -> 1.2.3.4:22 (1.2.3.4)\r\n  2         shell /solaris  SSH root:solaris (6.6.6.6:22)    9.9.9.9:44851 -> 6.6.6.6:22 (6.6.6.6)\r\n```"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/372463190","html_url":"https://github.com/rapid7/metasploit-framework/pull/9694#issuecomment-372463190","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/9694","id":372463190,"user":{"login":"h00die","id":752491,"avatar_url":"https://avatars3.githubusercontent.com/u/752491?v=4","gravatar_id":"","url":"https://api.github.com/users/h00die","html_url":"https://github.com/h00die","followers_url":"https://api.github.com/users/h00die/followers","following_url":"https://api.github.com/users/h00die/following{/other_user}","gists_url":"https://api.github.com/users/h00die/gists{/gist_id}","starred_url":"https://api.github.com/users/h00die/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h00die/subscriptions","organizations_url":"https://api.github.com/users/h00die/orgs","repos_url":"https://api.github.com/users/h00die/repos","events_url":"https://api.github.com/users/h00die/events{/privacy}","received_events_url":"https://api.github.com/users/h00die/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T21:08:39Z","updated_at":"2018-03-12T21:08:39Z","author_association":"CONTRIBUTOR","body":"I didn't really like changing that either, passing a larger object isn't a great way to do it. However I wanted to get the ball rolling on this change, and am VERY open to suggestions from a) ruby programmers (im not one), b) compsci majors (wasn't one), c) smart people (...obvi not one...), or d) r7 employees or other committers.\r\n\r\nIdea is in the water, lemme know a better way and i'll get to writing and testing!"}}
{"actor":{"display_login":"h00die"}}