{"action":"created","issue":{"url":"https://api.github.com/repos/Leanplum/Leanplum-Android-SDK/issues/279","repository_url":"https://api.github.com/repos/Leanplum/Leanplum-Android-SDK","labels_url":"https://api.github.com/repos/Leanplum/Leanplum-Android-SDK/issues/279/labels{/name}","comments_url":"https://api.github.com/repos/Leanplum/Leanplum-Android-SDK/issues/279/comments","events_url":"https://api.github.com/repos/Leanplum/Leanplum-Android-SDK/issues/279/events","html_url":"https://github.com/Leanplum/Leanplum-Android-SDK/issues/279","id":378379282,"node_id":"MDU6SXNzdWUzNzgzNzkyODI=","number":279,"title":"Leanplum fails to compile with targetSdkVersion 28","user":{"login":"lolsheeplol","id":4597494,"node_id":"MDQ6VXNlcjQ1OTc0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4597494?v=4","gravatar_id":"","url":"https://api.github.com/users/lolsheeplol","html_url":"https://github.com/lolsheeplol","followers_url":"https://api.github.com/users/lolsheeplol/followers","following_url":"https://api.github.com/users/lolsheeplol/following{/other_user}","gists_url":"https://api.github.com/users/lolsheeplol/gists{/gist_id}","starred_url":"https://api.github.com/users/lolsheeplol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolsheeplol/subscriptions","organizations_url":"https://api.github.com/users/lolsheeplol/orgs","repos_url":"https://api.github.com/users/lolsheeplol/repos","events_url":"https://api.github.com/users/lolsheeplol/events{/privacy}","received_events_url":"https://api.github.com/users/lolsheeplol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T16:57:11Z","updated_at":"2018-11-07T17:10:40Z","closed_at":null,"author_association":"NONE","body":"## Expected Behavior\r\nProject compiles without issues\r\n\r\n## Actual Behavior\r\nProject gradle sync fails with an error\r\n\r\n## Steps to Reproduce the Problem\r\n\r\n  1. Update targetSdkVersion to 28\r\n  2. Update support library versions to 28.0.0\r\n  3. Use google-services plugin 4.2.0\r\n  4. Add Leanplum-fcm dependency\r\n  5. Sync gradle\r\n\r\nGradle outputs a build error:\r\n```registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)\r\nregisterResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)\r\n\r\nCONFIGURE SUCCESSFUL in 0s\r\nDependency resolved to an incompatible version: Dependency(fromArtifactVersion=ArtifactVersion(groupId=com.leanplum, artifactId=leanplum-core, version=4.2.1), toArtifact=Artifact(groupId=com.android.support, artifactId=support-v4), toArtifactVersionString=[22.0.0,27.0.2])\r\nIn project 'app' a resolved Google Play services library dependency depends on another at an exact version (e.g. \"[22.0.\r\n0,27.0.2]\", but isn't being resolved to that version. Behavior exhibited by the library will be unknown.\r\n\r\nDependency failing: com.leanplum:leanplum-core:4.2.1 -> com.android.support:supportv4@[22.0.0,27.0.2], but support-v4 version was 27.0.2.\r\n\r\nThe following dependencies are project dependencies that are direct or have transitive dependencies that lead to the artifact with the issue.\r\n-- Project 'app' depends onto com.leanplum:leanplum-fcm@4.2.1\r\n\r\nFor extended debugging info execute Gradle from the command line with ./gradlew --info\r\n:app:assembleDebug to see the dependency paths to the artifact. This error message came from the google-services Gradle plugin, report issues at https://github.com/google/play-services-plugins and disable by adding \"googleServices { disableVersionCheck = false }\" to your build.gradle file.\r\n```\r\n\r\nI've included a sample project that you should be able to just clone and try to sync, and the build should fail with the same output.  https://github.com/lolsheeplol/LeanplumPie\r\n\r\n## Specifications\r\n\r\n  - Version: 4.2.1\r\n  - Platform: Android\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Leanplum/Leanplum-Android-SDK/issues/comments/436701454","html_url":"https://github.com/Leanplum/Leanplum-Android-SDK/issues/279#issuecomment-436701454","issue_url":"https://api.github.com/repos/Leanplum/Leanplum-Android-SDK/issues/279","id":436701454,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjcwMTQ1NA==","user":{"login":"lolsheeplol","id":4597494,"node_id":"MDQ6VXNlcjQ1OTc0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4597494?v=4","gravatar_id":"","url":"https://api.github.com/users/lolsheeplol","html_url":"https://github.com/lolsheeplol","followers_url":"https://api.github.com/users/lolsheeplol/followers","following_url":"https://api.github.com/users/lolsheeplol/following{/other_user}","gists_url":"https://api.github.com/users/lolsheeplol/gists{/gist_id}","starred_url":"https://api.github.com/users/lolsheeplol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolsheeplol/subscriptions","organizations_url":"https://api.github.com/users/lolsheeplol/orgs","repos_url":"https://api.github.com/users/lolsheeplol/repos","events_url":"https://api.github.com/users/lolsheeplol/events{/privacy}","received_events_url":"https://api.github.com/users/lolsheeplol/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T17:10:40Z","updated_at":"2018-11-07T17:10:40Z","author_association":"NONE","body":"On second inspection, it looks like it's actually the `google-services:4.2.0` plugin that is causing the build failure.  The build succeeds on plugin version 4.1.0.  \r\n\r\nHowever, it seems the strict version matcher is still problematic for us as we run `./gradlew lintDevDebug` on our CircleCi configuration, and that step now fails due to the major version of the support libraries changing.  \r\n"}}
{"actor":{"display_login":"lolsheeplol"}}