{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/235152639","pull_request_review_id":176953820,"id":235152639,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTE1MjYzOQ==","diff_hunk":"@@ -549,6 +556,38 @@ v: 1.0, stage: prod   v: 1.1, stage: canary            v: 1.1, stage: canary\n v: 1.0                (none)                           v: 1.0\n ====================  ===============================  ====================\n \n+Scaled Locality Weights\n+***********************","path":"docs/root/intro/arch_overview/load_balancing.rst","position":19,"original_position":19,"commit_id":"2ed7b579a7819c7af008d14bc2058c88aa582aac","original_commit_id":"2ed7b579a7819c7af008d14bc2058c88aa582aac","user":{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"body":"Should this be `----` etc. to indicate a linkable section?","created_at":"2018-11-20T20:10:24Z","updated_at":"2018-11-20T20:13:50Z","html_url":"https://github.com/envoyproxy/envoy/pull/5074#discussion_r235152639","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/235152639"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/5074#discussion_r235152639"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074","id":231736876,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzM2ODc2","html_url":"https://github.com/envoyproxy/envoy/pull/5074","diff_url":"https://github.com/envoyproxy/envoy/pull/5074.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/5074.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5074","number":5074,"state":"open","locked":false,"title":"upstream: add option to scale locality weights in subset lb","user":{"login":"snowp","id":2023366,"node_id":"MDQ6VXNlcjIwMjMzNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2023366?v=4","gravatar_id":"","url":"https://api.github.com/users/snowp","html_url":"https://github.com/snowp","followers_url":"https://api.github.com/users/snowp/followers","following_url":"https://api.github.com/users/snowp/following{/other_user}","gists_url":"https://api.github.com/users/snowp/gists{/gist_id}","starred_url":"https://api.github.com/users/snowp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowp/subscriptions","organizations_url":"https://api.github.com/users/snowp/orgs","repos_url":"https://api.github.com/users/snowp/repos","events_url":"https://api.github.com/users/snowp/events{/privacy}","received_events_url":"https://api.github.com/users/snowp/received_events","type":"User","site_admin":false},"body":"Adds an option that allows smoothing out the locality weights when used\r\nwith subset lb: weights are scaled by the number of hosts that were\r\nremoved due to the subset filter. This allows for less of a step\r\nfunction when a small number of hosts in a locality are updated to be\r\nincluded in the subset.\r\n\r\nFixes #4837\r\n\r\nSigned-off-by: Snow Pettersen <snowp@squareup.com>\r\n\r\n*Risk Level*: Low, new optional feature\r\n*Testing*: UTs\r\n*Docs Changes*:  Inline in protos\r\n*Release Notes*: added release note","created_at":"2018-11-17T16:26:34Z","updated_at":"2018-11-20T20:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ea1aff5c3f219edf02a1abe7bedb4d2e274d5ea","assignee":{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"assignees":[{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5074/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/2ed7b579a7819c7af008d14bc2058c88aa582aac","head":{"label":"snowp:subset-scale","ref":"subset-scale","sha":"2ed7b579a7819c7af008d14bc2058c88aa582aac","user":{"login":"snowp","id":2023366,"node_id":"MDQ6VXNlcjIwMjMzNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2023366?v=4","gravatar_id":"","url":"https://api.github.com/users/snowp","html_url":"https://github.com/snowp","followers_url":"https://api.github.com/users/snowp/followers","following_url":"https://api.github.com/users/snowp/following{/other_user}","gists_url":"https://api.github.com/users/snowp/gists{/gist_id}","starred_url":"https://api.github.com/users/snowp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowp/subscriptions","organizations_url":"https://api.github.com/users/snowp/orgs","repos_url":"https://api.github.com/users/snowp/repos","events_url":"https://api.github.com/users/snowp/events{/privacy}","received_events_url":"https://api.github.com/users/snowp/received_events","type":"User","site_admin":false},"repo":{"id":121560175,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1NjAxNzU=","name":"envoy","full_name":"snowp/envoy","private":false,"owner":{"login":"snowp","id":2023366,"node_id":"MDQ6VXNlcjIwMjMzNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2023366?v=4","gravatar_id":"","url":"https://api.github.com/users/snowp","html_url":"https://github.com/snowp","followers_url":"https://api.github.com/users/snowp/followers","following_url":"https://api.github.com/users/snowp/following{/other_user}","gists_url":"https://api.github.com/users/snowp/gists{/gist_id}","starred_url":"https://api.github.com/users/snowp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowp/subscriptions","organizations_url":"https://api.github.com/users/snowp/orgs","repos_url":"https://api.github.com/users/snowp/repos","events_url":"https://api.github.com/users/snowp/events{/privacy}","received_events_url":"https://api.github.com/users/snowp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/snowp/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/snowp/envoy","forks_url":"https://api.github.com/repos/snowp/envoy/forks","keys_url":"https://api.github.com/repos/snowp/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowp/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowp/envoy/teams","hooks_url":"https://api.github.com/repos/snowp/envoy/hooks","issue_events_url":"https://api.github.com/repos/snowp/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/snowp/envoy/events","assignees_url":"https://api.github.com/repos/snowp/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/snowp/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/snowp/envoy/tags","blobs_url":"https://api.github.com/repos/snowp/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowp/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowp/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowp/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowp/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/snowp/envoy/languages","stargazers_url":"https://api.github.com/repos/snowp/envoy/stargazers","contributors_url":"https://api.github.com/repos/snowp/envoy/contributors","subscribers_url":"https://api.github.com/repos/snowp/envoy/subscribers","subscription_url":"https://api.github.com/repos/snowp/envoy/subscription","commits_url":"https://api.github.com/repos/snowp/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowp/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowp/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowp/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowp/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/snowp/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowp/envoy/merges","archive_url":"https://api.github.com/repos/snowp/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowp/envoy/downloads","issues_url":"https://api.github.com/repos/snowp/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/snowp/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/snowp/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/snowp/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowp/envoy/labels{/name}","releases_url":"https://api.github.com/repos/snowp/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/snowp/envoy/deployments","created_at":"2018-02-14T20:53:42Z","updated_at":"2018-11-17T17:06:01Z","pushed_at":"2018-11-20T19:31:16Z","git_url":"git://github.com/snowp/envoy.git","ssh_url":"git@github.com:snowp/envoy.git","clone_url":"https://github.com/snowp/envoy.git","svn_url":"https://github.com/snowp/envoy","homepage":"https://envoyproxy.github.io/","size":24476,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"200b0e41641be46471c2ce3d230aae395fda7ded","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-11-20T19:18:53Z","pushed_at":"2018-11-20T20:07:17Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":23738,"stargazers_count":7240,"watchers_count":7240,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1002,"mirror_url":null,"archived":false,"open_issues_count":365,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1002,"open_issues":365,"watchers":7240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/5074"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/5074"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/5074/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5074/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/2ed7b579a7819c7af008d14bc2058c88aa582aac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"htuch"}}