{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70472","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70472/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70472/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70472/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70472","id":375848168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTk2Mjc1","number":70472,"title":"[*-controller-manager]get rid of copied fields in the options and using componentconfig fields","user":{"login":"stewart-yu","id":30410021,"node_id":"MDQ6VXNlcjMwNDEwMDIx","avatar_url":"https://avatars2.githubusercontent.com/u/30410021?v=4","gravatar_id":"","url":"https://api.github.com/users/stewart-yu","html_url":"https://github.com/stewart-yu","followers_url":"https://api.github.com/users/stewart-yu/followers","following_url":"https://api.github.com/users/stewart-yu/following{/other_user}","gists_url":"https://api.github.com/users/stewart-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/stewart-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewart-yu/subscriptions","organizations_url":"https://api.github.com/users/stewart-yu/orgs","repos_url":"https://api.github.com/users/stewart-yu/repos","events_url":"https://api.github.com/users/stewart-yu/events{/privacy}","received_events_url":"https://api.github.com/users/stewart-yu/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"e11d21","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":240247879,"node_id":"MDU6TGFiZWwyNDAyNDc4Nzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"cheftako","id":947971,"node_id":"MDQ6VXNlcjk0Nzk3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/947971?v=4","gravatar_id":"","url":"https://api.github.com/users/cheftako","html_url":"https://github.com/cheftako","followers_url":"https://api.github.com/users/cheftako/followers","following_url":"https://api.github.com/users/cheftako/following{/other_user}","gists_url":"https://api.github.com/users/cheftako/gists{/gist_id}","starred_url":"https://api.github.com/users/cheftako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheftako/subscriptions","organizations_url":"https://api.github.com/users/cheftako/orgs","repos_url":"https://api.github.com/users/cheftako/repos","events_url":"https://api.github.com/users/cheftako/events{/privacy}","received_events_url":"https://api.github.com/users/cheftako/received_events","type":"User","site_admin":false},"assignees":[{"login":"cheftako","id":947971,"node_id":"MDQ6VXNlcjk0Nzk3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/947971?v=4","gravatar_id":"","url":"https://api.github.com/users/cheftako","html_url":"https://github.com/cheftako","followers_url":"https://api.github.com/users/cheftako/followers","following_url":"https://api.github.com/users/cheftako/following{/other_user}","gists_url":"https://api.github.com/users/cheftako/gists{/gist_id}","starred_url":"https://api.github.com/users/cheftako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheftako/subscriptions","organizations_url":"https://api.github.com/users/cheftako/orgs","repos_url":"https://api.github.com/users/cheftako/repos","events_url":"https://api.github.com/users/cheftako/events{/privacy}","received_events_url":"https://api.github.com/users/cheftako/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-10-31T08:25:38Z","updated_at":"2018-11-29T23:17:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70472","html_url":"https://github.com/kubernetes/kubernetes/pull/70472","diff_url":"https://github.com/kubernetes/kubernetes/pull/70472.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70472.patch"},"body":"**What type of PR is this?**\r\n/kind cleanup\r\n/kind feature\r\n\r\n**What this PR does / why we need it**:\r\nGet rid of copied fields in the options and directly point the flags to the componentconfig fields, so that we can add validate for componentconfig field(move all validate function into api directory).\r\nOnce we get it merged, \r\n\r\n1. just part one, we can do others option, for the PR not completely;\r\n2. we can make put  https://github.com/kubernetes/kubernetes/pull/69959 forward.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\nXref https://github.com/kubernetes/kubernetes/issues/68244\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/443030127","html_url":"https://github.com/kubernetes/kubernetes/pull/70472#issuecomment-443030127","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70472","id":443030127,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzAzMDEyNw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T23:17:21Z","updated_at":"2018-11-29T23:17:21Z","author_association":"CONTRIBUTOR","body":"@stewart-yu: PR needs rebase.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>"}}
{"actor":{"display_login":"k8s-ci-robot"}}