{"action":"created","issue":{"url":"https://api.github.com/repos/metabase/metabase/issues/7556","repository_url":"https://api.github.com/repos/metabase/metabase","labels_url":"https://api.github.com/repos/metabase/metabase/issues/7556/labels{/name}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/7556/comments","events_url":"https://api.github.com/repos/metabase/metabase/issues/7556/events","html_url":"https://github.com/metabase/metabase/pull/7556","id":320438440,"number":7556,"title":"Allow saving FieldValues for list Fields if over the limit","user":{"login":"camsaul","id":1455846,"avatar_url":"https://avatars3.githubusercontent.com/u/1455846?v=4","gravatar_id":"","url":"https://api.github.com/users/camsaul","html_url":"https://github.com/camsaul","followers_url":"https://api.github.com/users/camsaul/followers","following_url":"https://api.github.com/users/camsaul/following{/other_user}","gists_url":"https://api.github.com/users/camsaul/gists{/gist_id}","starred_url":"https://api.github.com/users/camsaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camsaul/subscriptions","organizations_url":"https://api.github.com/users/camsaul/orgs","repos_url":"https://api.github.com/users/camsaul/repos","events_url":"https://api.github.com/users/camsaul/events{/privacy}","received_events_url":"https://api.github.com/users/camsaul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-04T21:40:18Z","updated_at":"2018-05-04T21:44:24Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/7556","html_url":"https://github.com/metabase/metabase/pull/7556","diff_url":"https://github.com/metabase/metabase/pull/7556.diff","patch_url":"https://github.com/metabase/metabase/pull/7556.patch"},"body":"Used Common Lisp [`format`](http://www.gigamonkeys.com/book/a-few-format-recipes.html) to cook up a list of a hundred and one different numbers written out and then tested the way things are supposed to work with that dataset.\r\n\r\n```common-lisp\r\n(format nil \"~r\" 1234) ; -> \"one thousand two hundred thirty-four\"\r\n```\r\n\r\nSome of our code was refusing to do FieldValues even if you manually asked for them by marking a Field as \"list\" (or if it was a legacy Category that was migrated over) if they were over the new lower threshold of 100 distinct values. Changed this so the constraint is only done for new Fields and not when you set it yourself\r\n\r\nIncludes tests\r\n\r\nFixes #7542 and #7543"},"comment":{"url":"https://api.github.com/repos/metabase/metabase/issues/comments/386743153","html_url":"https://github.com/metabase/metabase/pull/7556#issuecomment-386743153","issue_url":"https://api.github.com/repos/metabase/metabase/issues/7556","id":386743153,"user":{"login":"mazameli","id":2223916,"avatar_url":"https://avatars0.githubusercontent.com/u/2223916?v=4","gravatar_id":"","url":"https://api.github.com/users/mazameli","html_url":"https://github.com/mazameli","followers_url":"https://api.github.com/users/mazameli/followers","following_url":"https://api.github.com/users/mazameli/following{/other_user}","gists_url":"https://api.github.com/users/mazameli/gists{/gist_id}","starred_url":"https://api.github.com/users/mazameli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazameli/subscriptions","organizations_url":"https://api.github.com/users/mazameli/orgs","repos_url":"https://api.github.com/users/mazameli/repos","events_url":"https://api.github.com/users/mazameli/events{/privacy}","received_events_url":"https://api.github.com/users/mazameli/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T21:44:24Z","updated_at":"2018-05-04T21:44:24Z","author_association":"CONTRIBUTOR","body":"Sure. Should I also expect this to fix the scenario of upgrading from an earlier version, and having my existing filters using high cardinality fields incorrectly getting set to \"a list of values?\""}}
{"actor":{"display_login":"mazameli"}}