{"action":"created","issue":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1508","repository_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop","labels_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1508/labels{/name}","comments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1508/comments","events_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1508/events","html_url":"https://github.com/OpenBazaar/openbazaar-desktop/issues/1508","id":348515804,"node_id":"MDU6SXNzdWUzNDg1MTU4MDQ=","number":1508,"title":"Show \"Publish Reviews\" Button When Unpublished Reviews Exist","user":{"login":"jjeffryes","id":1584275,"node_id":"MDQ6VXNlcjE1ODQyNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1584275?v=4","gravatar_id":"","url":"https://api.github.com/users/jjeffryes","html_url":"https://github.com/jjeffryes","followers_url":"https://api.github.com/users/jjeffryes/followers","following_url":"https://api.github.com/users/jjeffryes/following{/other_user}","gists_url":"https://api.github.com/users/jjeffryes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeffryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeffryes/subscriptions","organizations_url":"https://api.github.com/users/jjeffryes/orgs","repos_url":"https://api.github.com/users/jjeffryes/repos","events_url":"https://api.github.com/users/jjeffryes/events{/privacy}","received_events_url":"https://api.github.com/users/jjeffryes/received_events","type":"User","site_admin":false},"labels":[{"id":543746117,"node_id":"MDU6TGFiZWw1NDM3NDYxMTc=","url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/labels/Needs%20Requirements","name":"Needs Requirements","color":"d4c5f9","default":false},{"id":396208958,"node_id":"MDU6TGFiZWwzOTYyMDg5NTg=","url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-07T22:57:38Z","updated_at":"2018-11-16T21:14:48Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently, new reviews for a listing aren't published until the user makes some other change to public information.\r\n\r\nWe should show a button to publish new reviews somewhere in the UI when unpublished reviews exist."},"comment":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/comments/439529614","html_url":"https://github.com/OpenBazaar/openbazaar-desktop/issues/1508#issuecomment-439529614","issue_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1508","id":439529614,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTUyOTYxNA==","user":{"login":"rmisio","id":794517,"node_id":"MDQ6VXNlcjc5NDUxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/794517?v=4","gravatar_id":"","url":"https://api.github.com/users/rmisio","html_url":"https://github.com/rmisio","followers_url":"https://api.github.com/users/rmisio/followers","following_url":"https://api.github.com/users/rmisio/following{/other_user}","gists_url":"https://api.github.com/users/rmisio/gists{/gist_id}","starred_url":"https://api.github.com/users/rmisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmisio/subscriptions","organizations_url":"https://api.github.com/users/rmisio/orgs","repos_url":"https://api.github.com/users/rmisio/repos","events_url":"https://api.github.com/users/rmisio/events{/privacy}","received_events_url":"https://api.github.com/users/rmisio/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T21:14:48Z","updated_at":"2018-11-16T21:14:48Z","author_association":"CONTRIBUTOR","body":"> The original rationale for new reviews not triggering a publish was that it renders the existing reseeded store / listings outdated, and we didn't want that to be able to be triggered by external actions. I think we thought it could have been abused.\r\n\r\nWell, but this would require a purchase of a listing... right? If that's so, I think most every vendor would trade an outdated IPFS hash for a sale.\r\n\r\nI thought the original rational may have been similar to the following rational where we don't want to publish and break caching if potentially dozens of reviews are coming in, in a small window.\r\n\r\nIf that's true, then I think this fixes things:\r\n\r\n```\r\nhave some process that is checking and if it sees more than X unpublished reviews or a single unpublished review older than Y, it publishes.\r\n```"}}
{"actor":{"display_login":"rmisio"}}