{"action":"created","issue":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/1585","repository_url":"https://api.github.com/repos/apache/bookkeeper","labels_url":"https://api.github.com/repos/apache/bookkeeper/issues/1585/labels{/name}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1585/comments","events_url":"https://api.github.com/repos/apache/bookkeeper/issues/1585/events","html_url":"https://github.com/apache/bookkeeper/pull/1585","id":348120017,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTQ2MjQx","number":1585,"title":"Issue #1584: LedgerHandleAdv should expose asyncAddEntry variant that takes ByteBuf (LedgerHandle exposes it as public)","user":{"login":"dlg99","id":8622884,"node_id":"MDQ6VXNlcjg2MjI4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"labels":[{"id":636301949,"node_id":"MDU6TGFiZWw2MzYzMDE5NDk=","url":"https://api.github.com/repos/apache/bookkeeper/labels/area/client","name":"area/client","color":"f9d0c4","default":false},{"id":636301341,"node_id":"MDU6TGFiZWw2MzYzMDEzNDE=","url":"https://api.github.com/repos/apache/bookkeeper/labels/priority/blocker","name":"priority/blocker","color":"b60205","default":false},{"id":823586081,"node_id":"MDU6TGFiZWw4MjM1ODYwODE=","url":"https://api.github.com/repos/apache/bookkeeper/labels/release/4.8.0","name":"release/4.8.0","color":"1d76db","default":false},{"id":636301000,"node_id":"MDU6TGFiZWw2MzYzMDEwMDA=","url":"https://api.github.com/repos/apache/bookkeeper/labels/type/bug","name":"type/bug","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"dlg99","id":8622884,"node_id":"MDQ6VXNlcjg2MjI4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"assignees":[{"login":"dlg99","id":8622884,"node_id":"MDQ6VXNlcjg2MjI4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apache/bookkeeper/milestones/4","html_url":"https://github.com/apache/bookkeeper/milestone/4","labels_url":"https://api.github.com/repos/apache/bookkeeper/milestones/4/labels","id":3081917,"node_id":"MDk6TWlsZXN0b25lMzA4MTkxNw==","number":4,"title":"4.8.0","description":"Release 4.8.0","creator":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":190,"state":"open","created_at":"2018-02-01T19:35:05Z","updated_at":"2018-08-16T16:54:11Z","due_on":"2018-08-02T07:00:00Z","closed_at":null},"comments":20,"created_at":"2018-08-06T23:58:26Z","updated_at":"2018-08-17T01:45:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1585","html_url":"https://github.com/apache/bookkeeper/pull/1585","diff_url":"https://github.com/apache/bookkeeper/pull/1585.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1585.patch"},"body":"Descriptions of the changes in this PR:\r\n\r\n- exposed asyncAddEntry as public, similarly to other variants.\r\n- fixed ByteBuf retention\r\n\r\n### Motivation\r\n\r\nIt's useful to have this exposed as public for clients to make use of netty's allocator and pass ByteBuf directly.\r\n\r\n### Changes\r\n\r\nexposed asyncAddEntry as public, similarly to other variants.\r\n\r\nMaster Issue: #1584 \r\n\r\n> ---\r\n> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit\r\n> checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all\r\n> the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You\r\n> can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if\r\n> you are not sure, committers will help you:\r\n>\r\n> - [ ] [skip bookkeeper-server bookie tests]: skip testing `org.apache.bookkeeper.bookie` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server client tests]: skip testing `org.apache.bookkeeper.client` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server replication tests]: skip testing `org.apache.bookkeeper.replication` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server tls tests]: skip testing `org.apache.bookkeeper.tls` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.\r\n> - [ ] [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.\r\n> - [ ] [skip build java8]: skip build on java8. *ONLY* skip this when *ONLY* changing files under documentation under `site`.\r\n> - [ ] [skip build java9]: skip build on java9. *ONLY* skip this when *ONLY* changing files under documentation under `site`.\r\n> ---\r\n\r\n> ---\r\n> Be sure to do all of the following to help us incorporate your contribution\r\n> quickly and easily:\r\n>\r\n> If this PR is a BookKeeper Proposal (BP):\r\n>\r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<BP-#>: Description of bookkeeper proposal`\r\n>     `e.g. BP-1: 64 bits ledger is support`\r\n> - [ ] Attach the master issue link in the description of this PR.\r\n> - [ ] Attach the google doc link if the BP is written in Google Doc.\r\n>\r\n> Otherwise:\r\n> \r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<Issue #>: Description of pull request`\r\n>     `e.g. Issue 123: Description ...`\r\n> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.\r\n> - [ ] Replace `<Issue #>` in the title with the actual Issue number.\r\n> \r\n> ---\r\n"},"comment":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/comments/413733224","html_url":"https://github.com/apache/bookkeeper/pull/1585#issuecomment-413733224","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1585","id":413733224,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzczMzIyNA==","user":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T01:45:08Z","updated_at":"2018-08-17T01:45:08Z","author_association":"CONTRIBUTOR","body":"@dlg99 let's wait one night for @merlimat . if there is no objections from him, we can merge tomorrow morning."}}
{"actor":{"display_login":"sijie"}}