{"push_id":2641570929,"size":3,"distinct_size":1,"ref":"refs/heads/rootmap","head":"7f9dfa5eb4605abd6196eec1705bc9a896a3f5b9","before":"b646b9bd748654590aecf7794e5900c0e51f8c72","commits":[{"sha":"785ef46e1a485a7cc338c1e6d7c1405a1047433c","author":{"name":"Yuka Takahashi","email":"a303e2e6270912310689301f23a968169714facc@gmail.com"},"message":"[cxxmodules] Fix nightlies by autoload dependency libraries\n\nWe had test failures in runtime nightlies such as this one:\nhttps://epsft-jenkins.cern.ch/view/ROOT/job/root-nightly-runtime-cxxmodules/95/BUILDTYPE=Debug,COMPILER=gcc62,LABEL=slc6/testReport/junit/projectroot.roottest.root.math/smatrix/roottest_root_math_smatrix_testKalman/\n\nFailures were due to what @pcanal commented in #2135, that some so files in\nroottest doesn't have external linkage. (It means that if you call\n    dlopen(libfoo.so), linux kernel can't find dependency libraries and it\n    emits \"undefined symbol\" error when they try to initialize global\n    variables in libfoo.so but couldn't find symbol definition)\nWith pch, rootmap files were providing information about the depending library.\n\nHowever we stopped generating rootmap files in #2127 and that's why we\ngot these failures. To fix this issue, I implemented a callback to\nTCling which gets called when DynamicLibraryManager fails. The callback\npass error message to TCling and it handles message if it contains \"undefined error\".","distinct":false,"url":"https://api.github.com/repos/yamaguchi1024/root/commits/785ef46e1a485a7cc338c1e6d7c1405a1047433c"},{"sha":"95dd9b3b21c43ddcb1dd0792c2992244b9bf003a","author":{"name":"Yuka Takahashi","email":"a303e2e6270912310689301f23a968169714facc@gmail.com"},"message":"Revert \"Revert \"Add the cwg to the prebuilt module cache path.\" (#2160)\"\n\nThis reverts commit 011aa8200277cd31957e222afd9b37415458b31f.\n\nThis is a revert of revert. I reverted the first commit because adding\n\".\" to prebuiltmodulepath was causing failure in runtime modules, but\nnow we're skipping \".\" in TCling::LazyFunctionCreatorAutoloadForModule so\ndoesn't matter even if we have \".\".","distinct":false,"url":"https://api.github.com/repos/yamaguchi1024/root/commits/95dd9b3b21c43ddcb1dd0792c2992244b9bf003a"},{"sha":"7f9dfa5eb4605abd6196eec1705bc9a896a3f5b9","author":{"name":"Yuka Takahashi","email":"a303e2e6270912310689301f23a968169714facc@gmail.com"},"message":"Revert \"[cxxmodules] Don't generate rootmap files with cxxmodules\"\n\nThis reverts commit 8bb0a978a34e8f026a98642afe118e15d2356b6c.\n\nWith ACLiC, which means if you do \"root.exe hsimple.C+\", ROOT generates\nlibrary for hsimple.C and execute this library instead of interpreting it at\nruntime. This didn't work with our \"preloading modules\" infrastructure,\nas it's not even interpreting.\n\nWe can fix this by\n1. Adding NEEDED section when generating so files.\n   This is like a \"static linker\" solution, which means we'll change\n   rootcling_impl to properly add dependency libraries.\n2. Try to get callback from library\n   I think this makes ACLiC slower, so I like the 1st solution\n\nHowever, for now, let's just revert this patch.","distinct":true,"url":"https://api.github.com/repos/yamaguchi1024/root/commits/7f9dfa5eb4605abd6196eec1705bc9a896a3f5b9"}]}
{"actor":{"display_login":"yamaguchi1024"}}