{"action":"created","comment":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments/235722205","pull_request_review_id":177653002,"id":235722205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTcyMjIwNQ==","diff_hunk":"@@ -45,20 +45,19 @@ const connectSteps = {\n \taddConnectionOptions: peer => {\n \t\tconst systemHeaders = System.getHeaders();\n \t\tconst queryParams = {};\n-\n-\t\tif (systemHeaders.version != null) {","path":"api/ws/rpc/connect.js","position":5,"original_position":5,"commit_id":"771e77ce25c579e7ea7f947fb38cf1005940c405","original_commit_id":"771e77ce25c579e7ea7f947fb38cf1005940c405","user":{"login":"MaciejBaj","id":6909553,"node_id":"MDQ6VXNlcjY5MDk1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6909553?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciejBaj","html_url":"https://github.com/MaciejBaj","followers_url":"https://api.github.com/users/MaciejBaj/followers","following_url":"https://api.github.com/users/MaciejBaj/following{/other_user}","gists_url":"https://api.github.com/users/MaciejBaj/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciejBaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciejBaj/subscriptions","organizations_url":"https://api.github.com/users/MaciejBaj/orgs","repos_url":"https://api.github.com/users/MaciejBaj/repos","events_url":"https://api.github.com/users/MaciejBaj/events{/privacy}","received_events_url":"https://api.github.com/users/MaciejBaj/received_events","type":"User","site_admin":false},"body":"The logic is changed here, previously for every undefined and null a header wasn't assigned, now it will not be assigned for every falsy value (\"\", NaN, 0, false in addition).\r\n","created_at":"2018-11-22T13:18:50Z","updated_at":"2018-11-22T13:18:54Z","html_url":"https://github.com/LiskHQ/lisk/pull/2562#discussion_r235722205","pull_request_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments/235722205"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/2562#discussion_r235722205"},"pull_request":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562"}}},"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562","id":232636506,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjM2NTA2","html_url":"https://github.com/LiskHQ/lisk/pull/2562","diff_url":"https://github.com/LiskHQ/lisk/pull/2562.diff","patch_url":"https://github.com/LiskHQ/lisk/pull/2562.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk/issues/2562","number":2562,"state":"open","locked":false,"title":"Apply eslint-rule eqeqeq - Related to #1597","user":{"login":"diego-G","id":1387244,"node_id":"MDQ6VXNlcjEzODcyNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1387244?v=4","gravatar_id":"","url":"https://api.github.com/users/diego-G","html_url":"https://github.com/diego-G","followers_url":"https://api.github.com/users/diego-G/followers","following_url":"https://api.github.com/users/diego-G/following{/other_user}","gists_url":"https://api.github.com/users/diego-G/gists{/gist_id}","starred_url":"https://api.github.com/users/diego-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diego-G/subscriptions","organizations_url":"https://api.github.com/users/diego-G/orgs","repos_url":"https://api.github.com/users/diego-G/repos","events_url":"https://api.github.com/users/diego-G/events{/privacy}","received_events_url":"https://api.github.com/users/diego-G/received_events","type":"User","site_admin":false},"body":"### Review checklist\r\n\r\n* The PR is related to #1597\r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the [commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n","created_at":"2018-11-21T11:54:07Z","updated_at":"2018-11-22T13:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08a0b53fe09e07ecae11363fa95a750716fa8fc1","assignee":{"login":"diego-G","id":1387244,"node_id":"MDQ6VXNlcjEzODcyNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1387244?v=4","gravatar_id":"","url":"https://api.github.com/users/diego-G","html_url":"https://github.com/diego-G","followers_url":"https://api.github.com/users/diego-G/followers","following_url":"https://api.github.com/users/diego-G/following{/other_user}","gists_url":"https://api.github.com/users/diego-G/gists{/gist_id}","starred_url":"https://api.github.com/users/diego-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diego-G/subscriptions","organizations_url":"https://api.github.com/users/diego-G/orgs","repos_url":"https://api.github.com/users/diego-G/repos","events_url":"https://api.github.com/users/diego-G/events{/privacy}","received_events_url":"https://api.github.com/users/diego-G/received_events","type":"User","site_admin":false},"assignees":[{"login":"diego-G","id":1387244,"node_id":"MDQ6VXNlcjEzODcyNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1387244?v=4","gravatar_id":"","url":"https://api.github.com/users/diego-G","html_url":"https://github.com/diego-G","followers_url":"https://api.github.com/users/diego-G/followers","following_url":"https://api.github.com/users/diego-G/following{/other_user}","gists_url":"https://api.github.com/users/diego-G/gists{/gist_id}","starred_url":"https://api.github.com/users/diego-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diego-G/subscriptions","organizations_url":"https://api.github.com/users/diego-G/orgs","repos_url":"https://api.github.com/users/diego-G/repos","events_url":"https://api.github.com/users/diego-G/events{/privacy}","received_events_url":"https://api.github.com/users/diego-G/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"4miners","id":22824146,"node_id":"MDQ6VXNlcjIyODI0MTQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22824146?v=4","gravatar_id":"","url":"https://api.github.com/users/4miners","html_url":"https://github.com/4miners","followers_url":"https://api.github.com/users/4miners/followers","following_url":"https://api.github.com/users/4miners/following{/other_user}","gists_url":"https://api.github.com/users/4miners/gists{/gist_id}","starred_url":"https://api.github.com/users/4miners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4miners/subscriptions","organizations_url":"https://api.github.com/users/4miners/orgs","repos_url":"https://api.github.com/users/4miners/repos","events_url":"https://api.github.com/users/4miners/events{/privacy}","received_events_url":"https://api.github.com/users/4miners/received_events","type":"User","site_admin":false},{"login":"yatki","id":26697004,"node_id":"MDQ6VXNlcjI2Njk3MDA0","avatar_url":"https://avatars1.githubusercontent.com/u/26697004?v=4","gravatar_id":"","url":"https://api.github.com/users/yatki","html_url":"https://github.com/yatki","followers_url":"https://api.github.com/users/yatki/followers","following_url":"https://api.github.com/users/yatki/following{/other_user}","gists_url":"https://api.github.com/users/yatki/gists{/gist_id}","starred_url":"https://api.github.com/users/yatki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatki/subscriptions","organizations_url":"https://api.github.com/users/yatki/orgs","repos_url":"https://api.github.com/users/yatki/repos","events_url":"https://api.github.com/users/yatki/events{/privacy}","received_events_url":"https://api.github.com/users/yatki/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":655482394,"node_id":"MDU6TGFiZWw2NTU0ODIzOTQ=","url":"https://api.github.com/repos/LiskHQ/lisk/labels/:eye:%20pending%20review","name":":eye: pending review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/2562/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/771e77ce25c579e7ea7f947fb38cf1005940c405","head":{"label":"LiskHQ:1597-apply-eslint-rule-eqeqeq","ref":"1597-apply-eslint-rule-eqeqeq","sha":"771e77ce25c579e7ea7f947fb38cf1005940c405","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk","full_name":"LiskHQ/lisk","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk","description":"📟 Lisk blockchain application platform","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2018-11-22T09:54:29Z","pushed_at":"2018-11-22T13:13:49Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":22332,"stargazers_count":2565,"watchers_count":2565,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":404,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":404,"open_issues":85,"watchers":2565,"default_branch":"development"}},"base":{"label":"LiskHQ:development","ref":"development","sha":"a1c16b05a07d0ec9cee126a247f5f7c1e762828e","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk","full_name":"LiskHQ/lisk","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk","description":"📟 Lisk blockchain application platform","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2018-11-22T09:54:29Z","pushed_at":"2018-11-22T13:13:49Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":22332,"stargazers_count":2565,"watchers_count":2565,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":404,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":404,"open_issues":85,"watchers":2565,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/2562"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/2562"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/2562/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2562/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk/statuses/771e77ce25c579e7ea7f947fb38cf1005940c405"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MaciejBaj"}}