{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments/205736077","pull_request_review_id":141066488,"id":205736077,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTczNjA3Nw==","diff_hunk":"@@ -110,8 +110,12 @@ func runSetupError(cmd *cobra.Command, args []string) error {\n \tpa := patterns.New(logger)\n \tw := wait.New(logger, d, pa)\n \tpCfg := &project.Config{\n-\t\tName: projectName,\n-\t\tTag:  projectTag,\n+\t\tName:       projectName,\n+\t\tK8sContext: \"minikube\",\n+\t\tTag:        projectTag,\n+\t}\n+\tif existingCluster {\n+\t\tpCfg.K8sContext = \"giantswarm-e2e\"\n \t}","path":"cmd/setup.go","position":12,"original_position":12,"commit_id":"3d89b578c331bb15df39a351df0eeb26fc509576","original_commit_id":"3d89b578c331bb15df39a351df0eeb26fc509576","user":{"login":"calvix","id":7136358,"node_id":"MDQ6VXNlcjcxMzYzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"body":"That would probably complicate things as when running teardown steps it already expects that correct context is used. Lots of stuff would have to be rewritten. Maybe that is out of scope for this PR?","created_at":"2018-07-27T10:48:02Z","updated_at":"2018-07-27T10:48:02Z","html_url":"https://github.com/giantswarm/e2e-harness/pull/101#discussion_r205736077","pull_request_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments/205736077"},"html":{"href":"https://github.com/giantswarm/e2e-harness/pull/101#discussion_r205736077"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101"}},"in_reply_to_id":205733278},"pull_request":{"url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101","id":204379778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mzc5Nzc4","html_url":"https://github.com/giantswarm/e2e-harness/pull/101","diff_url":"https://github.com/giantswarm/e2e-harness/pull/101.diff","patch_url":"https://github.com/giantswarm/e2e-harness/pull/101.patch","issue_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/101","number":101,"state":"open","locked":false,"title":"use-custom-k8s-context","user":{"login":"calvix","id":7136358,"node_id":"MDQ6VXNlcjcxMzYzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"body":"By default, e2e-harness has hardcoded `minikube` k8s context so this little change allows use context from existing cluster template\r\n\r\ntowards e2e for kvm https://github.com/giantswarm/giantswarm/issues/2440","created_at":"2018-07-27T09:37:03Z","updated_at":"2018-07-27T10:48:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7087607b4aae812538e4bdcdb744be6a78e47347","assignee":{"login":"calvix","id":7136358,"node_id":"MDQ6VXNlcjcxMzYzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"assignees":[{"login":"calvix","id":7136358,"node_id":"MDQ6VXNlcjcxMzYzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fgimenez","id":70376,"node_id":"MDQ6VXNlcjcwMzc2","avatar_url":"https://avatars2.githubusercontent.com/u/70376?v=4","gravatar_id":"","url":"https://api.github.com/users/fgimenez","html_url":"https://github.com/fgimenez","followers_url":"https://api.github.com/users/fgimenez/followers","following_url":"https://api.github.com/users/fgimenez/following{/other_user}","gists_url":"https://api.github.com/users/fgimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/fgimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgimenez/subscriptions","organizations_url":"https://api.github.com/users/fgimenez/orgs","repos_url":"https://api.github.com/users/fgimenez/repos","events_url":"https://api.github.com/users/fgimenez/events{/privacy}","received_events_url":"https://api.github.com/users/fgimenez/received_events","type":"User","site_admin":false},{"login":"JosephSalisbury","id":297653,"node_id":"MDQ6VXNlcjI5NzY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/297653?v=4","gravatar_id":"","url":"https://api.github.com/users/JosephSalisbury","html_url":"https://github.com/JosephSalisbury","followers_url":"https://api.github.com/users/JosephSalisbury/followers","following_url":"https://api.github.com/users/JosephSalisbury/following{/other_user}","gists_url":"https://api.github.com/users/JosephSalisbury/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSalisbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSalisbury/subscriptions","organizations_url":"https://api.github.com/users/JosephSalisbury/orgs","repos_url":"https://api.github.com/users/JosephSalisbury/repos","events_url":"https://api.github.com/users/JosephSalisbury/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSalisbury/received_events","type":"User","site_admin":false},{"login":"rossf7","id":311527,"node_id":"MDQ6VXNlcjMxMTUyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/311527?v=4","gravatar_id":"","url":"https://api.github.com/users/rossf7","html_url":"https://github.com/rossf7","followers_url":"https://api.github.com/users/rossf7/followers","following_url":"https://api.github.com/users/rossf7/following{/other_user}","gists_url":"https://api.github.com/users/rossf7/gists{/gist_id}","starred_url":"https://api.github.com/users/rossf7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossf7/subscriptions","organizations_url":"https://api.github.com/users/rossf7/orgs","repos_url":"https://api.github.com/users/rossf7/repos","events_url":"https://api.github.com/users/rossf7/events{/privacy}","received_events_url":"https://api.github.com/users/rossf7/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101/commits","review_comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101/comments","review_comment_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/101/comments","statuses_url":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/3d89b578c331bb15df39a351df0eeb26fc509576","head":{"label":"giantswarm:use-custom-k8s-context","ref":"use-custom-k8s-context","sha":"3d89b578c331bb15df39a351df0eeb26fc509576","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":107268623,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyNjg2MjM=","name":"e2e-harness","full_name":"giantswarm/e2e-harness","owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/e2e-harness","description":"Harness for custom kubernetes e2e testing.","fork":false,"url":"https://api.github.com/repos/giantswarm/e2e-harness","forks_url":"https://api.github.com/repos/giantswarm/e2e-harness/forks","keys_url":"https://api.github.com/repos/giantswarm/e2e-harness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/e2e-harness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/e2e-harness/teams","hooks_url":"https://api.github.com/repos/giantswarm/e2e-harness/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/e2e-harness/events","assignees_url":"https://api.github.com/repos/giantswarm/e2e-harness/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/e2e-harness/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/tags","blobs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/e2e-harness/languages","stargazers_url":"https://api.github.com/repos/giantswarm/e2e-harness/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/e2e-harness/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscription","commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/e2e-harness/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/e2e-harness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/e2e-harness/merges","archive_url":"https://api.github.com/repos/giantswarm/e2e-harness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/e2e-harness/downloads","issues_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/e2e-harness/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/e2e-harness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/e2e-harness/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/e2e-harness/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/e2e-harness/deployments","created_at":"2017-10-17T12:56:25Z","updated_at":"2018-07-27T08:59:58Z","pushed_at":"2018-07-27T09:37:04Z","git_url":"git://github.com/giantswarm/e2e-harness.git","ssh_url":"git@github.com:giantswarm/e2e-harness.git","clone_url":"https://github.com/giantswarm/e2e-harness.git","svn_url":"https://github.com/giantswarm/e2e-harness","homepage":"","size":20293,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"f4a0289c65b6e1f859fc0c960c2904b4e6dff5a8","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":107268623,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyNjg2MjM=","name":"e2e-harness","full_name":"giantswarm/e2e-harness","owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/e2e-harness","description":"Harness for custom kubernetes e2e testing.","fork":false,"url":"https://api.github.com/repos/giantswarm/e2e-harness","forks_url":"https://api.github.com/repos/giantswarm/e2e-harness/forks","keys_url":"https://api.github.com/repos/giantswarm/e2e-harness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/e2e-harness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/e2e-harness/teams","hooks_url":"https://api.github.com/repos/giantswarm/e2e-harness/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/e2e-harness/events","assignees_url":"https://api.github.com/repos/giantswarm/e2e-harness/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/e2e-harness/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/tags","blobs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/e2e-harness/languages","stargazers_url":"https://api.github.com/repos/giantswarm/e2e-harness/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/e2e-harness/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscription","commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/e2e-harness/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/e2e-harness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/e2e-harness/merges","archive_url":"https://api.github.com/repos/giantswarm/e2e-harness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/e2e-harness/downloads","issues_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/e2e-harness/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/e2e-harness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/e2e-harness/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/e2e-harness/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/e2e-harness/deployments","created_at":"2017-10-17T12:56:25Z","updated_at":"2018-07-27T08:59:58Z","pushed_at":"2018-07-27T09:37:04Z","git_url":"git://github.com/giantswarm/e2e-harness.git","ssh_url":"git@github.com:giantswarm/e2e-harness.git","clone_url":"https://github.com/giantswarm/e2e-harness.git","svn_url":"https://github.com/giantswarm/e2e-harness","homepage":"","size":20293,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101"},"html":{"href":"https://github.com/giantswarm/e2e-harness/pull/101"},"issue":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/issues/101"},"comments":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/3d89b578c331bb15df39a351df0eeb26fc509576"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"calvix"}}