{"action":"created","comment":{"url":"https://api.github.com/repos/pnp/generator-spfx/pulls/comments/219707392","pull_request_review_id":157947650,"id":219707392,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTcwNzM5Mg==","diff_hunk":"@@ -0,0 +1,57 @@\n+const { VueLoaderPlugin } = require('vue-loader');\n+\n+const plugin = new VueLoaderPlugin();\n+const loaderConfig = {\n+    test: /\\.vue$/,\n+    use: [{\n+        loader: 'vue-loader',\n+        options: {\n+            esModule: true,","path":"generators/vuejs/templates/gulpfile.js","position":9,"original_position":9,"commit_id":"60e2cafd5dbe287c5559a7fa5f4c6229cbe6e4dd","original_commit_id":"60e2cafd5dbe287c5559a7fa5f4c6229cbe6e4dd","user":{"login":"StfBauer","id":5503835,"node_id":"MDQ6VXNlcjU1MDM4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5503835?v=4","gravatar_id":"","url":"https://api.github.com/users/StfBauer","html_url":"https://github.com/StfBauer","followers_url":"https://api.github.com/users/StfBauer/followers","following_url":"https://api.github.com/users/StfBauer/following{/other_user}","gists_url":"https://api.github.com/users/StfBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/StfBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StfBauer/subscriptions","organizations_url":"https://api.github.com/users/StfBauer/orgs","repos_url":"https://api.github.com/users/StfBauer/repos","events_url":"https://api.github.com/users/StfBauer/events{/privacy}","received_events_url":"https://api.github.com/users/StfBauer/received_events","type":"User","site_admin":false},"body":"SFC is not just a name - It is a way VueJS developer define their components in the same way you define web components in the future. Please make sure SFC is working.","created_at":"2018-09-23T18:33:18Z","updated_at":"2018-09-23T18:33:18Z","html_url":"https://github.com/pnp/generator-spfx/pull/73#discussion_r219707392","pull_request_url":"https://api.github.com/repos/pnp/generator-spfx/pulls/73","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pnp/generator-spfx/pulls/comments/219707392"},"html":{"href":"https://github.com/pnp/generator-spfx/pull/73#discussion_r219707392"},"pull_request":{"href":"https://api.github.com/repos/pnp/generator-spfx/pulls/73"}},"in_reply_to_id":217911894},"pull_request":{"url":"https://api.github.com/repos/pnp/generator-spfx/pulls/73","id":215478361,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDc4MzYx","html_url":"https://github.com/pnp/generator-spfx/pull/73","diff_url":"https://github.com/pnp/generator-spfx/pull/73.diff","patch_url":"https://github.com/pnp/generator-spfx/pull/73.patch","issue_url":"https://api.github.com/repos/pnp/generator-spfx/issues/73","number":73,"state":"open","locked":false,"title":"Vuejs Support","user":{"login":"AJIXuMuK","id":17036219,"node_id":"MDQ6VXNlcjE3MDM2MjE5","avatar_url":"https://avatars3.githubusercontent.com/u/17036219?v=4","gravatar_id":"","url":"https://api.github.com/users/AJIXuMuK","html_url":"https://github.com/AJIXuMuK","followers_url":"https://api.github.com/users/AJIXuMuK/followers","following_url":"https://api.github.com/users/AJIXuMuK/following{/other_user}","gists_url":"https://api.github.com/users/AJIXuMuK/gists{/gist_id}","starred_url":"https://api.github.com/users/AJIXuMuK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJIXuMuK/subscriptions","organizations_url":"https://api.github.com/users/AJIXuMuK/orgs","repos_url":"https://api.github.com/users/AJIXuMuK/repos","events_url":"https://api.github.com/users/AJIXuMuK/events{/privacy}","received_events_url":"https://api.github.com/users/AJIXuMuK/received_events","type":"User","site_admin":false},"body":"* added `Vue.js` framework support\r\n* new methods in `util.js`: `addPackageDependencies` and `injectToGulpFile`\r\n* `util._writeTemplateFile` has been changed to log relative path of the updated file instead of file name\r\n* documentation has been updated to include Vue.js and to describe new `util.addPackageDependencies` usage\r\n* tests have been updated to include `Vue.js`","created_at":"2018-09-14T04:28:16Z","updated_at":"2018-09-23T18:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e08d3524973256e979df6c51ce7ae9cf24be50a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pnp/generator-spfx/pulls/73/commits","review_comments_url":"https://api.github.com/repos/pnp/generator-spfx/pulls/73/comments","review_comment_url":"https://api.github.com/repos/pnp/generator-spfx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pnp/generator-spfx/issues/73/comments","statuses_url":"https://api.github.com/repos/pnp/generator-spfx/statuses/60e2cafd5dbe287c5559a7fa5f4c6229cbe6e4dd","head":{"label":"AJIXuMuK:vuejs","ref":"vuejs","sha":"60e2cafd5dbe287c5559a7fa5f4c6229cbe6e4dd","user":{"login":"AJIXuMuK","id":17036219,"node_id":"MDQ6VXNlcjE3MDM2MjE5","avatar_url":"https://avatars3.githubusercontent.com/u/17036219?v=4","gravatar_id":"","url":"https://api.github.com/users/AJIXuMuK","html_url":"https://github.com/AJIXuMuK","followers_url":"https://api.github.com/users/AJIXuMuK/followers","following_url":"https://api.github.com/users/AJIXuMuK/following{/other_user}","gists_url":"https://api.github.com/users/AJIXuMuK/gists{/gist_id}","starred_url":"https://api.github.com/users/AJIXuMuK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJIXuMuK/subscriptions","organizations_url":"https://api.github.com/users/AJIXuMuK/orgs","repos_url":"https://api.github.com/users/AJIXuMuK/repos","events_url":"https://api.github.com/users/AJIXuMuK/events{/privacy}","received_events_url":"https://api.github.com/users/AJIXuMuK/received_events","type":"User","site_admin":false},"repo":{"id":146949437,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NDk0Mzc=","name":"generator-spfx","full_name":"AJIXuMuK/generator-spfx","private":false,"owner":{"login":"AJIXuMuK","id":17036219,"node_id":"MDQ6VXNlcjE3MDM2MjE5","avatar_url":"https://avatars3.githubusercontent.com/u/17036219?v=4","gravatar_id":"","url":"https://api.github.com/users/AJIXuMuK","html_url":"https://github.com/AJIXuMuK","followers_url":"https://api.github.com/users/AJIXuMuK/followers","following_url":"https://api.github.com/users/AJIXuMuK/following{/other_user}","gists_url":"https://api.github.com/users/AJIXuMuK/gists{/gist_id}","starred_url":"https://api.github.com/users/AJIXuMuK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJIXuMuK/subscriptions","organizations_url":"https://api.github.com/users/AJIXuMuK/orgs","repos_url":"https://api.github.com/users/AJIXuMuK/repos","events_url":"https://api.github.com/users/AJIXuMuK/events{/privacy}","received_events_url":"https://api.github.com/users/AJIXuMuK/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AJIXuMuK/generator-spfx","description":"Open-source extension for native oob SPFx generator to introduce additional scaffolding support","fork":true,"url":"https://api.github.com/repos/AJIXuMuK/generator-spfx","forks_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/forks","keys_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/teams","hooks_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/hooks","issue_events_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/issues/events{/number}","events_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/events","assignees_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/assignees{/user}","branches_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/branches{/branch}","tags_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/tags","blobs_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/statuses/{sha}","languages_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/languages","stargazers_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/stargazers","contributors_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/contributors","subscribers_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/subscribers","subscription_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/subscription","commits_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/contents/{+path}","compare_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/merges","archive_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/downloads","issues_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/issues{/number}","pulls_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/pulls{/number}","milestones_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/milestones{/number}","notifications_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/labels{/name}","releases_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/releases{/id}","deployments_url":"https://api.github.com/repos/AJIXuMuK/generator-spfx/deployments","created_at":"2018-08-31T23:00:05Z","updated_at":"2018-08-31T23:00:07Z","pushed_at":"2018-09-14T16:00:53Z","git_url":"git://github.com/AJIXuMuK/generator-spfx.git","ssh_url":"git@github.com:AJIXuMuK/generator-spfx.git","clone_url":"https://github.com/AJIXuMuK/generator-spfx.git","svn_url":"https://github.com/AJIXuMuK/generator-spfx","homepage":"https://pnp.github.io/generator-spfx/","size":1398,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pnp:dev","ref":"dev","sha":"9851b6dfa60a76e2705b174129f3baddf75d011a","user":{"login":"pnp","id":31443929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDQzOTI5","avatar_url":"https://avatars0.githubusercontent.com/u/31443929?v=4","gravatar_id":"","url":"https://api.github.com/users/pnp","html_url":"https://github.com/pnp","followers_url":"https://api.github.com/users/pnp/followers","following_url":"https://api.github.com/users/pnp/following{/other_user}","gists_url":"https://api.github.com/users/pnp/gists{/gist_id}","starred_url":"https://api.github.com/users/pnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnp/subscriptions","organizations_url":"https://api.github.com/users/pnp/orgs","repos_url":"https://api.github.com/users/pnp/repos","events_url":"https://api.github.com/users/pnp/events{/privacy}","received_events_url":"https://api.github.com/users/pnp/received_events","type":"Organization","site_admin":false},"repo":{"id":135309172,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMDkxNzI=","name":"generator-spfx","full_name":"pnp/generator-spfx","private":false,"owner":{"login":"pnp","id":31443929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDQzOTI5","avatar_url":"https://avatars0.githubusercontent.com/u/31443929?v=4","gravatar_id":"","url":"https://api.github.com/users/pnp","html_url":"https://github.com/pnp","followers_url":"https://api.github.com/users/pnp/followers","following_url":"https://api.github.com/users/pnp/following{/other_user}","gists_url":"https://api.github.com/users/pnp/gists{/gist_id}","starred_url":"https://api.github.com/users/pnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnp/subscriptions","organizations_url":"https://api.github.com/users/pnp/orgs","repos_url":"https://api.github.com/users/pnp/repos","events_url":"https://api.github.com/users/pnp/events{/privacy}","received_events_url":"https://api.github.com/users/pnp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pnp/generator-spfx","description":"Open-source generator to extend the capabilities of the Microsoft SPFx generator","fork":false,"url":"https://api.github.com/repos/pnp/generator-spfx","forks_url":"https://api.github.com/repos/pnp/generator-spfx/forks","keys_url":"https://api.github.com/repos/pnp/generator-spfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnp/generator-spfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnp/generator-spfx/teams","hooks_url":"https://api.github.com/repos/pnp/generator-spfx/hooks","issue_events_url":"https://api.github.com/repos/pnp/generator-spfx/issues/events{/number}","events_url":"https://api.github.com/repos/pnp/generator-spfx/events","assignees_url":"https://api.github.com/repos/pnp/generator-spfx/assignees{/user}","branches_url":"https://api.github.com/repos/pnp/generator-spfx/branches{/branch}","tags_url":"https://api.github.com/repos/pnp/generator-spfx/tags","blobs_url":"https://api.github.com/repos/pnp/generator-spfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnp/generator-spfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnp/generator-spfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnp/generator-spfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnp/generator-spfx/statuses/{sha}","languages_url":"https://api.github.com/repos/pnp/generator-spfx/languages","stargazers_url":"https://api.github.com/repos/pnp/generator-spfx/stargazers","contributors_url":"https://api.github.com/repos/pnp/generator-spfx/contributors","subscribers_url":"https://api.github.com/repos/pnp/generator-spfx/subscribers","subscription_url":"https://api.github.com/repos/pnp/generator-spfx/subscription","commits_url":"https://api.github.com/repos/pnp/generator-spfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnp/generator-spfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnp/generator-spfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnp/generator-spfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnp/generator-spfx/contents/{+path}","compare_url":"https://api.github.com/repos/pnp/generator-spfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnp/generator-spfx/merges","archive_url":"https://api.github.com/repos/pnp/generator-spfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnp/generator-spfx/downloads","issues_url":"https://api.github.com/repos/pnp/generator-spfx/issues{/number}","pulls_url":"https://api.github.com/repos/pnp/generator-spfx/pulls{/number}","milestones_url":"https://api.github.com/repos/pnp/generator-spfx/milestones{/number}","notifications_url":"https://api.github.com/repos/pnp/generator-spfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnp/generator-spfx/labels{/name}","releases_url":"https://api.github.com/repos/pnp/generator-spfx/releases{/id}","deployments_url":"https://api.github.com/repos/pnp/generator-spfx/deployments","created_at":"2018-05-29T14:33:38Z","updated_at":"2018-09-22T21:11:04Z","pushed_at":"2018-09-22T21:11:25Z","git_url":"git://github.com/pnp/generator-spfx.git","ssh_url":"git@github.com:pnp/generator-spfx.git","clone_url":"https://github.com/pnp/generator-spfx.git","svn_url":"https://github.com/pnp/generator-spfx","homepage":"https://pnp.github.io/generator-spfx/","size":1561,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":3,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pnp/generator-spfx/pulls/73"},"html":{"href":"https://github.com/pnp/generator-spfx/pull/73"},"issue":{"href":"https://api.github.com/repos/pnp/generator-spfx/issues/73"},"comments":{"href":"https://api.github.com/repos/pnp/generator-spfx/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/pnp/generator-spfx/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/pnp/generator-spfx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pnp/generator-spfx/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/pnp/generator-spfx/statuses/60e2cafd5dbe287c5559a7fa5f4c6229cbe6e4dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"StfBauer"}}