{"action":"created","comment":{"url":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/comments/223955891","pull_request_review_id":163207074,"id":223955891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzk1NTg5MQ==","diff_hunk":"@@ -65,19 +63,26 @@ def enable_chef\n     # - Install the Chef service\r\n     # - Start the Chef service\r\n     begin\r\n-      configure_chef_only_once\r\n+      # \"node-registered\" file also indicates that enabled was called once and\r\n+      # configs are already generated.\r\n+      if File.exist?(\"#{bootstrap_directory}/node-registered\")\r\n+        puts \"#{Time.now} Node is already registered...\"\r\n+      else\r\n+        configure_chef_only_once\r\n+      end\r\n+\r\n+      @daemon = value_from_json_file(handler_settings_file, 'runtimeSettings', '0', 'handlerSettings', 'publicSettings', 'daemon')\r\n+      @daemon = (@daemon.nil? || @daemon.empty? || @daemon == \"service\") ? \"service\" : \"task\"\r","path":"lib/chef/azure/commands/enable.rb","position":40,"original_position":40,"commit_id":"67ed323bdf963ae9e276db6911f80d4cbb79cde3","original_commit_id":"67ed323bdf963ae9e276db6911f80d4cbb79cde3","user":{"login":"Vasu1105","id":4181545,"node_id":"MDQ6VXNlcjQxODE1NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4181545?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasu1105","html_url":"https://github.com/Vasu1105","followers_url":"https://api.github.com/users/Vasu1105/followers","following_url":"https://api.github.com/users/Vasu1105/following{/other_user}","gists_url":"https://api.github.com/users/Vasu1105/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasu1105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasu1105/subscriptions","organizations_url":"https://api.github.com/users/Vasu1105/orgs","repos_url":"https://api.github.com/users/Vasu1105/repos","events_url":"https://api.github.com/users/Vasu1105/events{/privacy}","received_events_url":"https://api.github.com/users/Vasu1105/received_events","type":"User","site_admin":false},"body":"True. Will update this. Thanks","created_at":"2018-10-10T06:58:02Z","updated_at":"2018-10-10T06:58:02Z","html_url":"https://github.com/chef-partners/azure-chef-extension/pull/255#discussion_r223955891","pull_request_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/comments/223955891"},"html":{"href":"https://github.com/chef-partners/azure-chef-extension/pull/255#discussion_r223955891"},"pull_request":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255"}},"in_reply_to_id":223680627},"pull_request":{"url":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255","id":220311015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzExMDE1","html_url":"https://github.com/chef-partners/azure-chef-extension/pull/255","diff_url":"https://github.com/chef-partners/azure-chef-extension/pull/255.diff","patch_url":"https://github.com/chef-partners/azure-chef-extension/pull/255.patch","issue_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/issues/255","number":255,"state":"open","locked":false,"title":"Fixes environment and run_list params not recognised","user":{"login":"Vasu1105","id":4181545,"node_id":"MDQ6VXNlcjQxODE1NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4181545?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasu1105","html_url":"https://github.com/Vasu1105","followers_url":"https://api.github.com/users/Vasu1105/followers","following_url":"https://api.github.com/users/Vasu1105/following{/other_user}","gists_url":"https://api.github.com/users/Vasu1105/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasu1105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasu1105/subscriptions","organizations_url":"https://api.github.com/users/Vasu1105/orgs","repos_url":"https://api.github.com/users/Vasu1105/repos","events_url":"https://api.github.com/users/Vasu1105/events{/privacy}","received_events_url":"https://api.github.com/users/Vasu1105/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>\r\n\r\nThis resolves the empty run_list and wrong chef environment was getting set.\r\nThis behaviour was found on the images where Microsoft windows agent version is getting updated. And which results in chef-client with run_list is not executed correctly. We fixed this by setting the node run_list and environment in chef_server first and then running the chef-client to execute the run_list.\r\nAlso replace background process to run chef-client with Scheduled task in Windows.\r\n\r\nFixes #248 ","created_at":"2018-10-04T09:39:26Z","updated_at":"2018-10-10T06:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f155e1af0b548e6deeabf7a7c8d3fe47ae11d23f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"btm","id":4381,"node_id":"MDQ6VXNlcjQzODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4381?v=4","gravatar_id":"","url":"https://api.github.com/users/btm","html_url":"https://github.com/btm","followers_url":"https://api.github.com/users/btm/followers","following_url":"https://api.github.com/users/btm/following{/other_user}","gists_url":"https://api.github.com/users/btm/gists{/gist_id}","starred_url":"https://api.github.com/users/btm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btm/subscriptions","organizations_url":"https://api.github.com/users/btm/orgs","repos_url":"https://api.github.com/users/btm/repos","events_url":"https://api.github.com/users/btm/events{/privacy}","received_events_url":"https://api.github.com/users/btm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255/commits","review_comments_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255/comments","review_comment_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/issues/255/comments","statuses_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/statuses/67ed323bdf963ae9e276db6911f80d4cbb79cde3","head":{"label":"MsysTechnologiesllc:vasundhara/MSYS-882_Fixes_environment_and_run_list_params_not_recognised","ref":"vasundhara/MSYS-882_Fixes_environment_and_run_list_params_not_recognised","sha":"67ed323bdf963ae9e276db6911f80d4cbb79cde3","user":{"login":"MsysTechnologiesllc","id":2493241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTMyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2493241?v=4","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"repo":{"id":25916223,"node_id":"MDEwOlJlcG9zaXRvcnkyNTkxNjIyMw==","name":"azure-chef-extension","full_name":"MsysTechnologiesllc/azure-chef-extension","private":false,"owner":{"login":"MsysTechnologiesllc","id":2493241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTMyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2493241?v=4","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MsysTechnologiesllc/azure-chef-extension","description":null,"fork":true,"url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension","forks_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/forks","keys_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/teams","hooks_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/hooks","issue_events_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/issues/events{/number}","events_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/events","assignees_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/assignees{/user}","branches_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/branches{/branch}","tags_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/tags","blobs_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/languages","stargazers_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/stargazers","contributors_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/contributors","subscribers_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/subscribers","subscription_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/subscription","commits_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/contents/{+path}","compare_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/merges","archive_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/downloads","issues_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/issues{/number}","pulls_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/labels{/name}","releases_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/releases{/id}","deployments_url":"https://api.github.com/repos/MsysTechnologiesllc/azure-chef-extension/deployments","created_at":"2014-10-29T10:43:56Z","updated_at":"2018-05-15T11:06:12Z","pushed_at":"2018-10-09T08:43:04Z","git_url":"git://github.com/MsysTechnologiesllc/azure-chef-extension.git","ssh_url":"git@github.com:MsysTechnologiesllc/azure-chef-extension.git","clone_url":"https://github.com/MsysTechnologiesllc/azure-chef-extension.git","svn_url":"https://github.com/MsysTechnologiesllc/azure-chef-extension","homepage":null,"size":906,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-partners:master","ref":"master","sha":"3d4e4960dffcb461f785dc241082cc47a2fb8548","user":{"login":"chef-partners","id":6988876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODg4NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6988876?v=4","gravatar_id":"","url":"https://api.github.com/users/chef-partners","html_url":"https://github.com/chef-partners","followers_url":"https://api.github.com/users/chef-partners/followers","following_url":"https://api.github.com/users/chef-partners/following{/other_user}","gists_url":"https://api.github.com/users/chef-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-partners/subscriptions","organizations_url":"https://api.github.com/users/chef-partners/orgs","repos_url":"https://api.github.com/users/chef-partners/repos","events_url":"https://api.github.com/users/chef-partners/events{/privacy}","received_events_url":"https://api.github.com/users/chef-partners/received_events","type":"Organization","site_admin":false},"repo":{"id":25906808,"node_id":"MDEwOlJlcG9zaXRvcnkyNTkwNjgwOA==","name":"azure-chef-extension","full_name":"chef-partners/azure-chef-extension","private":false,"owner":{"login":"chef-partners","id":6988876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODg4NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6988876?v=4","gravatar_id":"","url":"https://api.github.com/users/chef-partners","html_url":"https://github.com/chef-partners","followers_url":"https://api.github.com/users/chef-partners/followers","following_url":"https://api.github.com/users/chef-partners/following{/other_user}","gists_url":"https://api.github.com/users/chef-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-partners/subscriptions","organizations_url":"https://api.github.com/users/chef-partners/orgs","repos_url":"https://api.github.com/users/chef-partners/repos","events_url":"https://api.github.com/users/chef-partners/events{/privacy}","received_events_url":"https://api.github.com/users/chef-partners/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef-partners/azure-chef-extension","description":"The development repository for the Chef Extension available through Azure","fork":false,"url":"https://api.github.com/repos/chef-partners/azure-chef-extension","forks_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/forks","keys_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/teams","hooks_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/hooks","issue_events_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/issues/events{/number}","events_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/events","assignees_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/assignees{/user}","branches_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/branches{/branch}","tags_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/tags","blobs_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/languages","stargazers_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/stargazers","contributors_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/contributors","subscribers_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/subscribers","subscription_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/subscription","commits_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/contents/{+path}","compare_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/merges","archive_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/downloads","issues_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/issues{/number}","pulls_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/labels{/name}","releases_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/releases{/id}","deployments_url":"https://api.github.com/repos/chef-partners/azure-chef-extension/deployments","created_at":"2014-10-29T05:59:11Z","updated_at":"2018-05-14T15:18:11Z","pushed_at":"2018-10-09T08:43:05Z","git_url":"git://github.com/chef-partners/azure-chef-extension.git","ssh_url":"git@github.com:chef-partners/azure-chef-extension.git","clone_url":"https://github.com/chef-partners/azure-chef-extension.git","svn_url":"https://github.com/chef-partners/azure-chef-extension","homepage":"","size":869,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":21,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255"},"html":{"href":"https://github.com/chef-partners/azure-chef-extension/pull/255"},"issue":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/issues/255"},"comments":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/chef-partners/azure-chef-extension/statuses/67ed323bdf963ae9e276db6911f80d4cbb79cde3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Vasu1105"}}