{"action":"created","issue":{"url":"https://api.github.com/repos/dib-lab/sourmash/issues/529","repository_url":"https://api.github.com/repos/dib-lab/sourmash","labels_url":"https://api.github.com/repos/dib-lab/sourmash/issues/529/labels{/name}","comments_url":"https://api.github.com/repos/dib-lab/sourmash/issues/529/comments","events_url":"https://api.github.com/repos/dib-lab/sourmash/issues/529/events","html_url":"https://github.com/dib-lab/sourmash/pull/529","id":349251000,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDEyNDkx","number":529,"title":"Olgabot/use x if codon not found","user":{"login":"olgabot","id":806256,"node_id":"MDQ6VXNlcjgwNjI1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/806256?v=4","gravatar_id":"","url":"https://api.github.com/users/olgabot","html_url":"https://github.com/olgabot","followers_url":"https://api.github.com/users/olgabot/followers","following_url":"https://api.github.com/users/olgabot/following{/other_user}","gists_url":"https://api.github.com/users/olgabot/gists{/gist_id}","starred_url":"https://api.github.com/users/olgabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olgabot/subscriptions","organizations_url":"https://api.github.com/users/olgabot/orgs","repos_url":"https://api.github.com/users/olgabot/repos","events_url":"https://api.github.com/users/olgabot/events{/privacy}","received_events_url":"https://api.github.com/users/olgabot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-09T19:02:03Z","updated_at":"2018-09-10T21:29:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dib-lab/sourmash/pulls/529","html_url":"https://github.com/dib-lab/sourmash/pull/529","diff_url":"https://github.com/dib-lab/sourmash/pull/529.diff","patch_url":"https://github.com/dib-lab/sourmash/pull/529.patch"},"body":"This adjusts the `_dna_to_aa` code to fallback on the \"X\" if the codon was not found. Hopefully addresses https://github.com/dib-lab/sourmash/issues/502 because `std::map::operator[]` inserts a new element and returns it, in this case the empty string, and then the protein kmers built on DNA seuqences with \"N\"s are an incorrect length because they are too short.\r\n\r\nCan't get sourmash to install via conda on my mac laptop right now so I haven't been able to run the tests.\r\n\r\n- [x] Is it mergeable?\r\n- [x] `make test` Did it pass the tests?\r\n- [x] `make coverage` Is the new code covered?\r\n- [x] ~Did it change the command-line interface? Only additions are allowed\r\n  without a major version increment. Changing file formats also requires a\r\n  major version number increment.~\r\n- [x] Was a spellchecker run on the source code and documentation after\r\n  changes were made?\r\n"},"comment":{"url":"https://api.github.com/repos/dib-lab/sourmash/issues/comments/420067654","html_url":"https://github.com/dib-lab/sourmash/pull/529#issuecomment-420067654","issue_url":"https://api.github.com/repos/dib-lab/sourmash/issues/529","id":420067654,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDA2NzY1NA==","user":{"login":"luizirber","id":6642,"node_id":"MDQ6VXNlcjY2NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/6642?v=4","gravatar_id":"","url":"https://api.github.com/users/luizirber","html_url":"https://github.com/luizirber","followers_url":"https://api.github.com/users/luizirber/followers","following_url":"https://api.github.com/users/luizirber/following{/other_user}","gists_url":"https://api.github.com/users/luizirber/gists{/gist_id}","starred_url":"https://api.github.com/users/luizirber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luizirber/subscriptions","organizations_url":"https://api.github.com/users/luizirber/orgs","repos_url":"https://api.github.com/users/luizirber/repos","events_url":"https://api.github.com/users/luizirber/events{/privacy}","received_events_url":"https://api.github.com/users/luizirber/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T21:29:24Z","updated_at":"2018-09-10T21:29:24Z","author_association":"MEMBER","body":"I think this sounds reasonable, any comments @ctb ?"}}
{"actor":{"display_login":"luizirber"}}