{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/193581541","pull_request_review_id":126581904,"id":193581541,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzU4MTU0MQ==","diff_hunk":"@@ -16,6 +16,21 @@ class Mode\n {\n public:\n \n+    // Auto Pilot modes\n+    // ----------------\n+    enum number {","path":"APMrover2/mode.h","position":6,"original_position":6,"commit_id":"c6d56d1b23b87b5a32b94a0efe354185358a0721","original_commit_id":"c6d56d1b23b87b5a32b94a0efe354185358a0721","user":{"login":"OXINARF","id":1778527,"node_id":"MDQ6VXNlcjE3Nzg1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1778527?v=4","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},"body":"Can we make it Number?","created_at":"2018-06-06T22:43:24Z","updated_at":"2018-06-06T22:44:48Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/8585#discussion_r193581541","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/193581541"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8585#discussion_r193581541"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585"}}},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585","id":192914382,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTE0Mzgy","html_url":"https://github.com/ArduPilot/ardupilot/pull/8585","diff_url":"https://github.com/ArduPilot/ardupilot/pull/8585.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/8585.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8585","number":8585,"state":"open","locked":false,"title":"Rover: create an enumeration to hold vehicle mode constants","user":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"body":"This gives us type-safety on the mode numbers.  This is advantageous as\r\nsome of these symbols exist with different values elsewhere in the code.","created_at":"2018-06-06T06:44:08Z","updated_at":"2018-06-06T22:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"681c0f934e3eb0454de966053051967ebe7b05af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":24269282,"node_id":"MDU6TGFiZWwyNDI2OTI4Mg==","url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Rover","name":"Rover","color":"B36F30","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8585/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/c6d56d1b23b87b5a32b94a0efe354185358a0721","head":{"label":"peterbarker:mode-enumeration","ref":"mode-enumeration","sha":"c6d56d1b23b87b5a32b94a0efe354185358a0721","user":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"repo":{"id":34165570,"node_id":"MDEwOlJlcG9zaXRvcnkzNDE2NTU3MA==","name":"ardupilot","full_name":"peterbarker/ardupilot","owner":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterbarker/ardupilot","description":"APM Plane, APM Copter, APM Rover source","fork":true,"url":"https://api.github.com/repos/peterbarker/ardupilot","forks_url":"https://api.github.com/repos/peterbarker/ardupilot/forks","keys_url":"https://api.github.com/repos/peterbarker/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterbarker/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterbarker/ardupilot/teams","hooks_url":"https://api.github.com/repos/peterbarker/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/peterbarker/ardupilot/events","assignees_url":"https://api.github.com/repos/peterbarker/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/peterbarker/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/peterbarker/ardupilot/tags","blobs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterbarker/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterbarker/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterbarker/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/peterbarker/ardupilot/languages","stargazers_url":"https://api.github.com/repos/peterbarker/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/peterbarker/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/peterbarker/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/peterbarker/ardupilot/subscription","commits_url":"https://api.github.com/repos/peterbarker/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterbarker/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterbarker/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterbarker/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/peterbarker/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterbarker/ardupilot/merges","archive_url":"https://api.github.com/repos/peterbarker/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterbarker/ardupilot/downloads","issues_url":"https://api.github.com/repos/peterbarker/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/peterbarker/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/peterbarker/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/peterbarker/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterbarker/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/peterbarker/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/peterbarker/ardupilot/deployments","created_at":"2015-04-18T12:46:36Z","updated_at":"2016-11-30T01:59:51Z","pushed_at":"2018-06-06T07:02:20Z","git_url":"git://github.com/peterbarker/ardupilot.git","ssh_url":"git@github.com:peterbarker/ardupilot.git","clone_url":"https://github.com/peterbarker/ardupilot.git","svn_url":"https://github.com/peterbarker/ardupilot","homepage":"http://ardupilot.com/","size":104156,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"3be9077ba98f8a933055fe588aab8a4f5c8bc502","user":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEyNDg0","name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2018-06-06T19:38:58Z","pushed_at":"2018-06-06T21:50:54Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":103198,"stargazers_count":3256,"watchers_count":3256,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6456,"mirror_url":null,"archived":false,"open_issues_count":1164,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":6456,"open_issues":1164,"watchers":3256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8585"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8585"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8585/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8585/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/c6d56d1b23b87b5a32b94a0efe354185358a0721"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OXINARF"}}