{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments/167294933","pull_request_review_id":95501253,"id":167294933,"diff_hunk":"@@ -98,6 +98,12 @@ object GenericCountView {\n     }\n   }\n \n+  private def getBucket(value: Float, splits: Seq[Int]): Int = {","path":"src/main/scala/com/mozilla/telemetry/views/GenericCountView.scala","position":null,"original_position":4,"commit_id":"c39b98682330d48cd512406897a59b8ef619ac7f","original_commit_id":"2d14b2898041bd3391bc4fde43ace76f9bae9aee","user":{"login":"relud","id":433717,"avatar_url":"https://avatars0.githubusercontent.com/u/433717?v=4","gravatar_id":"","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-02-09T17:34:22Z","updated_at":"2018-02-09T17:34:22Z","html_url":"https://github.com/mozilla/telemetry-batch-view/pull/370#discussion_r167294933","pull_request_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments/167294933"},"html":{"href":"https://github.com/mozilla/telemetry-batch-view/pull/370#discussion_r167294933"},"pull_request":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370"}},"in_reply_to_id":167293058},"pull_request":{"url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370","id":167289563,"html_url":"https://github.com/mozilla/telemetry-batch-view/pull/370","diff_url":"https://github.com/mozilla/telemetry-batch-view/pull/370.diff","patch_url":"https://github.com/mozilla/telemetry-batch-view/pull/370.patch","issue_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/370","number":370,"state":"open","locked":false,"title":"Bug 1434991 - add bucketed() udf to GenericCountView","user":{"login":"relud","id":433717,"avatar_url":"https://avatars0.githubusercontent.com/u/433717?v=4","gravatar_id":"","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"body":"the buckets are specified like `--bucket-splits 0 5 10 100`\r\n\r\n`bucketed(value)` returns the next split bigger than value, or the largest split + 1 for values bigger than all splits.\r\n\r\nThe test changes show how telemetry-airflow can use this to generate a `bucketed_uri_count` field. ","created_at":"2018-02-06T00:17:43Z","updated_at":"2018-02-09T17:34:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d41896c224aa05ecb30cb2217435e222c936ac9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370/commits","review_comments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370/comments","review_comment_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/370/comments","statuses_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/statuses/c39b98682330d48cd512406897a59b8ef619ac7f","head":{"label":"relud:ccd_uri_count","ref":"ccd_uri_count","sha":"c39b98682330d48cd512406897a59b8ef619ac7f","user":{"login":"relud","id":433717,"avatar_url":"https://avatars0.githubusercontent.com/u/433717?v=4","gravatar_id":"","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"repo":{"id":109740668,"name":"telemetry-batch-view","full_name":"relud/telemetry-batch-view","owner":{"login":"relud","id":433717,"avatar_url":"https://avatars0.githubusercontent.com/u/433717?v=4","gravatar_id":"","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/relud/telemetry-batch-view","description":"A Scala framework to build derived datasets, aka batch views, of Telemetry data.","fork":true,"url":"https://api.github.com/repos/relud/telemetry-batch-view","forks_url":"https://api.github.com/repos/relud/telemetry-batch-view/forks","keys_url":"https://api.github.com/repos/relud/telemetry-batch-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/relud/telemetry-batch-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/relud/telemetry-batch-view/teams","hooks_url":"https://api.github.com/repos/relud/telemetry-batch-view/hooks","issue_events_url":"https://api.github.com/repos/relud/telemetry-batch-view/issues/events{/number}","events_url":"https://api.github.com/repos/relud/telemetry-batch-view/events","assignees_url":"https://api.github.com/repos/relud/telemetry-batch-view/assignees{/user}","branches_url":"https://api.github.com/repos/relud/telemetry-batch-view/branches{/branch}","tags_url":"https://api.github.com/repos/relud/telemetry-batch-view/tags","blobs_url":"https://api.github.com/repos/relud/telemetry-batch-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/relud/telemetry-batch-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/relud/telemetry-batch-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/relud/telemetry-batch-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/relud/telemetry-batch-view/statuses/{sha}","languages_url":"https://api.github.com/repos/relud/telemetry-batch-view/languages","stargazers_url":"https://api.github.com/repos/relud/telemetry-batch-view/stargazers","contributors_url":"https://api.github.com/repos/relud/telemetry-batch-view/contributors","subscribers_url":"https://api.github.com/repos/relud/telemetry-batch-view/subscribers","subscription_url":"https://api.github.com/repos/relud/telemetry-batch-view/subscription","commits_url":"https://api.github.com/repos/relud/telemetry-batch-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/relud/telemetry-batch-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/relud/telemetry-batch-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/relud/telemetry-batch-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/relud/telemetry-batch-view/contents/{+path}","compare_url":"https://api.github.com/repos/relud/telemetry-batch-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/relud/telemetry-batch-view/merges","archive_url":"https://api.github.com/repos/relud/telemetry-batch-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/relud/telemetry-batch-view/downloads","issues_url":"https://api.github.com/repos/relud/telemetry-batch-view/issues{/number}","pulls_url":"https://api.github.com/repos/relud/telemetry-batch-view/pulls{/number}","milestones_url":"https://api.github.com/repos/relud/telemetry-batch-view/milestones{/number}","notifications_url":"https://api.github.com/repos/relud/telemetry-batch-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/relud/telemetry-batch-view/labels{/name}","releases_url":"https://api.github.com/repos/relud/telemetry-batch-view/releases{/id}","deployments_url":"https://api.github.com/repos/relud/telemetry-batch-view/deployments","created_at":"2017-11-06T19:34:36Z","updated_at":"2017-11-06T19:34:38Z","pushed_at":"2018-02-09T17:34:07Z","git_url":"git://github.com/relud/telemetry-batch-view.git","ssh_url":"git@github.com:relud/telemetry-batch-view.git","clone_url":"https://github.com/relud/telemetry-batch-view.git","svn_url":"https://github.com/relud/telemetry-batch-view","homepage":"","size":1535,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"5a2308d02c744a278f2c23d1d1b179f5f90bbbc8","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":44998549,"name":"telemetry-batch-view","full_name":"mozilla/telemetry-batch-view","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/telemetry-batch-view","description":"A Scala framework to build derived datasets, aka batch views, of Telemetry data.","fork":false,"url":"https://api.github.com/repos/mozilla/telemetry-batch-view","forks_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/forks","keys_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/teams","hooks_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/hooks","issue_events_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/events","assignees_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/tags","blobs_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/languages","stargazers_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/stargazers","contributors_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/contributors","subscribers_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/subscribers","subscription_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/subscription","commits_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/merges","archive_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/downloads","issues_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/telemetry-batch-view/deployments","created_at":"2015-10-26T21:29:57Z","updated_at":"2018-02-08T00:11:05Z","pushed_at":"2018-02-09T17:34:08Z","git_url":"git://github.com/mozilla/telemetry-batch-view.git","ssh_url":"git@github.com:mozilla/telemetry-batch-view.git","clone_url":"https://github.com/mozilla/telemetry-batch-view.git","svn_url":"https://github.com/mozilla/telemetry-batch-view","homepage":"","size":11792,"stargazers_count":22,"watchers_count":22,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":40,"open_issues":5,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370"},"html":{"href":"https://github.com/mozilla/telemetry-batch-view/pull/370"},"issue":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/370"},"comments":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/telemetry-batch-view/statuses/c39b98682330d48cd512406897a59b8ef619ac7f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"relud"}}