{"action":"created","issue":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2979","repository_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2979/labels{/name}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2979/comments","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2979/events","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/2979","id":362753915,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Mzg1NzE1","number":2979,"title":"MapShed Manual Entry: Design Review","user":{"login":"rajadain","id":1430060,"node_id":"MDQ6VXNlcjE0MzAwNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1430060?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"labels":[{"id":556091444,"node_id":"MDU6TGFiZWw1NTYwOTE0NDQ=","url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/WPF","name":"WPF","color":"1d76db","default":false},{"id":194213367,"node_id":"MDU6TGFiZWwxOTQyMTMzNjc=","url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"kellyi","id":4165523,"node_id":"MDQ6VXNlcjQxNjU1MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4165523?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"assignees":[{"login":"kellyi","id":4165523,"node_id":"MDQ6VXNlcjQxNjU1MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4165523?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-09-21T19:55:31Z","updated_at":"2018-09-24T15:34:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/2979","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/2979","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/2979.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/2979.patch"},"body":"## Overview\r\n\r\nFixes various design issues.\r\n\r\nConnects #2976 \r\n\r\n### Demo\r\n\r\nLong Scenario Names:\r\n\r\n![2018-09-21 13 54 28](https://user-images.githubusercontent.com/1430060/45902945-180cf500-bdb6-11e8-90b9-54c285114e94.gif)\r\n\r\nRight-aligned Settings button, Hide Undo after click, Thousands Separator in Land Use Area:\r\n\r\n![2018-09-21 15 52 16](https://user-images.githubusercontent.com/1430060/45903107-98335a80-bdb6-11e8-887a-3eeea25e27ba.gif)\r\n\r\nUndo button working with dropdowns:\r\n\r\n![2018-09-21 15 52 49](https://user-images.githubusercontent.com/1430060/45903123-a2edef80-bdb6-11e8-8878-76e518b3a448.gif)\r\n\r\nAlso tagging @jfrankl for visual review.\r\n\r\n## Testing Instructions\r\n\r\n* Checkout this branch and `bundle`\r\n* Open a MapShed project and add a scenario to it\r\n* Go through the list of items in the original issue and ensure they have been fixed"},"comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments/424019086","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/2979#issuecomment-424019086","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2979","id":424019086,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDAxOTA4Ng==","user":{"login":"kellyi","id":4165523,"node_id":"MDQ6VXNlcjQxNjU1MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4165523?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T15:34:47Z","updated_at":"2018-09-24T15:34:47Z","author_association":"MEMBER","body":"Looks good. Everything described in the original PR comment has been remedied.\r\n\r\nI do think we should add the thousands-separator to the validation area number as part of this PR.\r\n\r\nFor the \"Conservation Practice\" menu, it seems like it should close on opening another modal but that could either be part of this work or a separate issue."}}
{"actor":{"display_login":"kellyi"}}