{"action":"created","comment":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/216865877","pull_request_review_id":154441177,"id":216865877,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjg2NTg3Nw==","diff_hunk":"@@ -0,0 +1,42 @@\n+﻿using System;\n+using System.Collections.Generic;\n+\n+namespace Rubberduck.UnitTesting\n+{\n+    public class TestResult\n+    {\n+        public TestResult(TestOutcome outcome, string output = \"\", long duration = 0)\n+        {\n+            Outcome = outcome;\n+            Output = output;\n+            Duration = duration;\n+        }\n+\n+        public long Duration { get; private set; }\n+        public TestOutcome Outcome { get; private set; }\n+        public string Output { get; private set; }\n+\n+        public override bool Equals(object obj)\n+        {\n+            if (obj is TestResult other)\n+            {\n+                return Outcome == other.Outcome\n+                    && Output == other.Output;\n+            }\n+            return false;\n+        }\n+\n+        public override int GetHashCode()\n+        {\n+            var hashCode = -1268493841;\n+            hashCode = hashCode * -1521134295 + Outcome.GetHashCode();\n+            hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(Output);\n+            return hashCode;","path":"Rubberduck.UnitTesting/UnitTesting/TestResult.cs","position":34,"original_position":34,"commit_id":"36d1fb12f4ca39f63a356a795ede9feb7851d7a5","original_commit_id":"36d1fb12f4ca39f63a356a795ede9feb7851d7a5","user":{"login":"retailcoder","id":5751684,"node_id":"MDQ6VXNlcjU3NTE2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5751684?v=4","gravatar_id":"","url":"https://api.github.com/users/retailcoder","html_url":"https://github.com/retailcoder","followers_url":"https://api.github.com/users/retailcoder/followers","following_url":"https://api.github.com/users/retailcoder/following{/other_user}","gists_url":"https://api.github.com/users/retailcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/retailcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retailcoder/subscriptions","organizations_url":"https://api.github.com/users/retailcoder/orgs","repos_url":"https://api.github.com/users/retailcoder/repos","events_url":"https://api.github.com/users/retailcoder/events{/privacy}","received_events_url":"https://api.github.com/users/retailcoder/received_events","type":"User","site_admin":false},"body":"Why not `return HashCode.Compute(Outcome, Output);`?","created_at":"2018-09-12T00:33:27Z","updated_at":"2018-09-12T00:39:32Z","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4146#discussion_r216865877","pull_request_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/216865877"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/4146#discussion_r216865877"},"pull_request":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146"}}},"pull_request":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146","id":198533554,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTMzNTU0","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4146","diff_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4146.diff","patch_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4146.patch","issue_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4146","number":4146,"state":"open","locked":false,"title":"Splice unit testing away from Rubberduck.Core","user":{"login":"Vogel612","id":7288995,"node_id":"MDQ6VXNlcjcyODg5OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7288995?v=4","gravatar_id":"","url":"https://api.github.com/users/Vogel612","html_url":"https://github.com/Vogel612","followers_url":"https://api.github.com/users/Vogel612/followers","following_url":"https://api.github.com/users/Vogel612/following{/other_user}","gists_url":"https://api.github.com/users/Vogel612/gists{/gist_id}","starred_url":"https://api.github.com/users/Vogel612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vogel612/subscriptions","organizations_url":"https://api.github.com/users/Vogel612/orgs","repos_url":"https://api.github.com/users/Vogel612/repos","events_url":"https://api.github.com/users/Vogel612/events{/privacy}","received_events_url":"https://api.github.com/users/Vogel612/received_events","type":"User","site_admin":false},"body":"In line with #3862 this PR is splitting the UnitTesting functionality into a separate project,\r\n\r\nAdditionally this PR includes the following more or less major changes:\r\n\r\n - Command implementations can now be wired into ViewModels via PropertyInjection\r\n - The TestEngine has been completely overhauled and does more work that was originally done by the TestExplorerModel\r\n - TestMethods are now dumber, also the ViewModel has been separated from the functionality needed for the TestEngine\r\n - The CodeExplorerViewModel has been updated to get it's commands via PropertyInjection\r\n - The CodeExplorerCommand attribute has been dropped along the way\r\n - CommandMenuItem constructor arguments are now wired by command name and not by convention\r\n - the TestEngine is the sole source of truth and sole arbitrator for everything related to tests now\r\n - The TestEngineModel has been heavily simplified as the TestEngine took over part of it's responsibilities\r\n - INavigateCommand and related classes have been moved to Rubberduck.Interaction\r\n - IVBETypeLibsAPI now is wired against the TypeLibWrapper interface instead of the implementation \r\n - The TestEngine is now \"testable\" with some effort","created_at":"2018-07-01T17:13:13Z","updated_at":"2018-09-12T00:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b13504e7c598c948c318d26c35371871b5c49210","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MDoerner","id":22868956,"node_id":"MDQ6VXNlcjIyODY4OTU2","avatar_url":"https://avatars1.githubusercontent.com/u/22868956?v=4","gravatar_id":"","url":"https://api.github.com/users/MDoerner","html_url":"https://github.com/MDoerner","followers_url":"https://api.github.com/users/MDoerner/followers","following_url":"https://api.github.com/users/MDoerner/following{/other_user}","gists_url":"https://api.github.com/users/MDoerner/gists{/gist_id}","starred_url":"https://api.github.com/users/MDoerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDoerner/subscriptions","organizations_url":"https://api.github.com/users/MDoerner/orgs","repos_url":"https://api.github.com/users/MDoerner/repos","events_url":"https://api.github.com/users/MDoerner/events{/privacy}","received_events_url":"https://api.github.com/users/MDoerner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":765570372,"node_id":"MDU6TGFiZWw3NjU1NzAzNzI=","url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels/PR-Status:%20Review%20Requested","name":"PR-Status: Review Requested","color":"584daf","default":false},{"id":175492176,"node_id":"MDU6TGFiZWwxNzU0OTIxNzY=","url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels/feature-unit-testing","name":"feature-unit-testing","color":"DDDDDd","default":false},{"id":347783794,"node_id":"MDU6TGFiZWwzNDc3ODM3OTQ=","url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels/technical-debt","name":"technical-debt","color":"444444","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146/commits","review_comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146/comments","review_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4146/comments","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/36d1fb12f4ca39f63a356a795ede9feb7851d7a5","head":{"label":"Vogel612:splice-unit-testing","ref":"splice-unit-testing","sha":"36d1fb12f4ca39f63a356a795ede9feb7851d7a5","user":{"login":"Vogel612","id":7288995,"node_id":"MDQ6VXNlcjcyODg5OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7288995?v=4","gravatar_id":"","url":"https://api.github.com/users/Vogel612","html_url":"https://github.com/Vogel612","followers_url":"https://api.github.com/users/Vogel612/followers","following_url":"https://api.github.com/users/Vogel612/following{/other_user}","gists_url":"https://api.github.com/users/Vogel612/gists{/gist_id}","starred_url":"https://api.github.com/users/Vogel612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vogel612/subscriptions","organizations_url":"https://api.github.com/users/Vogel612/orgs","repos_url":"https://api.github.com/users/Vogel612/repos","events_url":"https://api.github.com/users/Vogel612/events{/privacy}","received_events_url":"https://api.github.com/users/Vogel612/received_events","type":"User","site_admin":false},"repo":{"id":36952874,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk1Mjg3NA==","name":"Rubberduck","full_name":"Vogel612/Rubberduck","owner":{"login":"Vogel612","id":7288995,"node_id":"MDQ6VXNlcjcyODg5OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7288995?v=4","gravatar_id":"","url":"https://api.github.com/users/Vogel612","html_url":"https://github.com/Vogel612","followers_url":"https://api.github.com/users/Vogel612/followers","following_url":"https://api.github.com/users/Vogel612/following{/other_user}","gists_url":"https://api.github.com/users/Vogel612/gists{/gist_id}","starred_url":"https://api.github.com/users/Vogel612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vogel612/subscriptions","organizations_url":"https://api.github.com/users/Vogel612/orgs","repos_url":"https://api.github.com/users/Vogel612/repos","events_url":"https://api.github.com/users/Vogel612/events{/privacy}","received_events_url":"https://api.github.com/users/Vogel612/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vogel612/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":true,"url":"https://api.github.com/repos/Vogel612/Rubberduck","forks_url":"https://api.github.com/repos/Vogel612/Rubberduck/forks","keys_url":"https://api.github.com/repos/Vogel612/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vogel612/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vogel612/Rubberduck/teams","hooks_url":"https://api.github.com/repos/Vogel612/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/Vogel612/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/Vogel612/Rubberduck/events","assignees_url":"https://api.github.com/repos/Vogel612/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/Vogel612/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/Vogel612/Rubberduck/tags","blobs_url":"https://api.github.com/repos/Vogel612/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vogel612/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vogel612/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vogel612/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vogel612/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/Vogel612/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/Vogel612/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/Vogel612/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/Vogel612/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/Vogel612/Rubberduck/subscription","commits_url":"https://api.github.com/repos/Vogel612/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vogel612/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vogel612/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vogel612/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vogel612/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/Vogel612/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vogel612/Rubberduck/merges","archive_url":"https://api.github.com/repos/Vogel612/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vogel612/Rubberduck/downloads","issues_url":"https://api.github.com/repos/Vogel612/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/Vogel612/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/Vogel612/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/Vogel612/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vogel612/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/Vogel612/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/Vogel612/Rubberduck/deployments","created_at":"2015-06-05T20:03:56Z","updated_at":"2018-09-10T22:04:31Z","pushed_at":"2018-09-10T22:33:08Z","git_url":"git://github.com/Vogel612/Rubberduck.git","ssh_url":"git@github.com:Vogel612/Rubberduck.git","clone_url":"https://github.com/Vogel612/Rubberduck.git","svn_url":"https://github.com/Vogel612/Rubberduck","homepage":"","size":67531,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"rubberduck-vba:next","ref":"next","sha":"4df720727b79b29cd87363152ce5f7beef3446d8","user":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"repo":{"id":25800128,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgwMDEyOA==","name":"Rubberduck","full_name":"rubberduck-vba/Rubberduck","owner":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubberduck-vba/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":false,"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck","forks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/forks","keys_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/teams","hooks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/events","assignees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/tags","blobs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscription","commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/merges","archive_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/downloads","issues_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/deployments","created_at":"2014-10-27T02:35:11Z","updated_at":"2018-09-11T01:36:11Z","pushed_at":"2018-09-11T23:56:08Z","git_url":"git://github.com/rubberduck-vba/Rubberduck.git","ssh_url":"git@github.com:rubberduck-vba/Rubberduck.git","clone_url":"https://github.com/rubberduck-vba/Rubberduck.git","svn_url":"https://github.com/rubberduck-vba/Rubberduck","homepage":"","size":67632,"stargazers_count":651,"watchers_count":651,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":756,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":164,"open_issues":756,"watchers":651,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/4146"},"issue":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4146"},"comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4146/comments"},"review_comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146/comments"},"review_comment":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4146/commits"},"statuses":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/36d1fb12f4ca39f63a356a795ede9feb7851d7a5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"retailcoder"}}