{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/4857","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/4857/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/4857/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/4857/events","html_url":"https://github.com/kubernetes/kops/pull/4857","id":310373696,"number":4857,"title":"only enable SSE when not using custom s3 endpoint","user":{"login":"andrewsykim","id":12699319,"avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"labels":[{"id":655705079,"url":"https://api.github.com/repos/kubernetes/kops/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485059302,"url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676714365,"url":"https://api.github.com/repos/kubernetes/kops/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-02T01:55:55Z","updated_at":"2018-04-02T02:18:09Z","closed_at":"2018-04-02T02:08:09Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/4857","html_url":"https://github.com/kubernetes/kops/pull/4857","diff_url":"https://github.com/kubernetes/kops/pull/4857.diff","patch_url":"https://github.com/kubernetes/kops/pull/4857.patch"},"body":"This was originally brought up since using SSE on a custom endpoint that is S3 compatible does not work (digitalocean spaces for example), if this is not a desired behaviour for other custom endpoints I can start work for creating a `do://` VFS instead of piggybacking off of S3 VFS.\r\n\r\nre: https://github.com/kubernetes/kops/pull/4697#discussion_r178475607"},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/377838165","html_url":"https://github.com/kubernetes/kops/pull/4857#issuecomment-377838165","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/4857","id":377838165,"user":{"login":"andrewsykim","id":12699319,"avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"created_at":"2018-04-02T02:18:09Z","updated_at":"2018-04-02T02:18:09Z","author_association":"MEMBER","body":"@justinsb there are more changes for this to work in 1.9 so feel free to hold off on PRs until 1.10 :) "}}
{"actor":{"display_login":"andrewsykim"}}