{"action":"created","comment":{"url":"https://api.github.com/repos/mimblewimble/grin/pulls/comments/206576173","pull_request_review_id":142013753,"id":206576173,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjU3NjE3Mw==","diff_hunk":"@@ -297,9 +297,9 @@ fn validate_header(header: &BlockHeader, ctx: &mut BlockContext) -> Result<(), E\n \t\tif target_difficulty != network_difficulty.clone() {\n \t\t\terror!(\n \t\t\t\tLOGGER,\n-\t\t\t\t\"validate_header: BANNABLE OFFENCE: header cumulative difficulty {} != {}\",\n+\t\t\t\t\"validate_header: BANNABLE OFFENCE: header target difficulty {} != {}\",\n \t\t\t\ttarget_difficulty.to_num(),\n-\t\t\t\tprev.total_difficulty.to_num() + network_difficulty.to_num()\n+\t\t\t\tnetwork_difficulty.to_num()","path":"chain/src/pipe.rs","position":8,"original_position":8,"commit_id":"ed9d990297e3cda6ed9950c4ee325e279857ef6b","original_commit_id":"ed9d990297e3cda6ed9950c4ee325e279857ef6b","user":{"login":"garyyu","id":1852227,"node_id":"MDQ6VXNlcjE4NTIyMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1852227?v=4","gravatar_id":"","url":"https://api.github.com/users/garyyu","html_url":"https://github.com/garyyu","followers_url":"https://api.github.com/users/garyyu/followers","following_url":"https://api.github.com/users/garyyu/following{/other_user}","gists_url":"https://api.github.com/users/garyyu/gists{/gist_id}","starred_url":"https://api.github.com/users/garyyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyyu/subscriptions","organizations_url":"https://api.github.com/users/garyyu/orgs","repos_url":"https://api.github.com/users/garyyu/repos","events_url":"https://api.github.com/users/garyyu/events{/privacy}","received_events_url":"https://api.github.com/users/garyyu/received_events","type":"User","site_admin":false},"body":"The misleading log.","created_at":"2018-07-31T15:31:24Z","updated_at":"2018-07-31T15:31:24Z","html_url":"https://github.com/mimblewimble/grin/pull/1305#discussion_r206576173","pull_request_url":"https://api.github.com/repos/mimblewimble/grin/pulls/1305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/comments/206576173"},"html":{"href":"https://github.com/mimblewimble/grin/pull/1305#discussion_r206576173"},"pull_request":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/1305"}},"in_reply_to_id":206575690},"pull_request":{"url":"https://api.github.com/repos/mimblewimble/grin/pulls/1305","id":205151047,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTUxMDQ3","html_url":"https://github.com/mimblewimble/grin/pull/1305","diff_url":"https://github.com/mimblewimble/grin/pull/1305.diff","patch_url":"https://github.com/mimblewimble/grin/pull/1305.patch","issue_url":"https://api.github.com/repos/mimblewimble/grin/issues/1305","number":1305,"state":"open","locked":false,"title":"fix: old time crate use 0..11 as the month, make mistake with chrono Utc.ymd (#1304)","user":{"login":"garyyu","id":1852227,"node_id":"MDQ6VXNlcjE4NTIyMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1852227?v=4","gravatar_id":"","url":"https://api.github.com/users/garyyu","html_url":"https://github.com/garyyu","followers_url":"https://api.github.com/users/garyyu/followers","following_url":"https://api.github.com/users/garyyu/following{/other_user}","gists_url":"https://api.github.com/users/garyyu/gists{/gist_id}","starred_url":"https://api.github.com/users/garyyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyyu/subscriptions","organizations_url":"https://api.github.com/users/garyyu/orgs","repos_url":"https://api.github.com/users/garyyu/repos","events_url":"https://api.github.com/users/garyyu/events{/privacy}","received_events_url":"https://api.github.com/users/garyyu/received_events","type":"User","site_admin":false},"body":"\r\nThe old time crate use 0..11 as `tm_mon`, but chrono has `Utc.ymd(year, month, day)` api with 1..12 as month.\r\nFor example, this old code was saying \"8th July\", not \"8th June\".\r\n```\r\n            timestamp: time::Tm {\r\n                tm_year: 2018 - 1900,\r\n                tm_mon: 6,\r\n                tm_mday: 8,\r\n                tm_hour: 18,\r\n                ..time::empty_tm()\r\n            },\r\n```","created_at":"2018-07-31T15:23:37Z","updated_at":"2018-07-31T15:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b1bd14e20a1c33daf3e30961e53cb884dd0f831","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mimblewimble/grin/pulls/1305/commits","review_comments_url":"https://api.github.com/repos/mimblewimble/grin/pulls/1305/comments","review_comment_url":"https://api.github.com/repos/mimblewimble/grin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mimblewimble/grin/issues/1305/comments","statuses_url":"https://api.github.com/repos/mimblewimble/grin/statuses/ed9d990297e3cda6ed9950c4ee325e279857ef6b","head":{"label":"garyyu:fix-1304","ref":"fix-1304","sha":"ed9d990297e3cda6ed9950c4ee325e279857ef6b","user":{"login":"garyyu","id":1852227,"node_id":"MDQ6VXNlcjE4NTIyMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1852227?v=4","gravatar_id":"","url":"https://api.github.com/users/garyyu","html_url":"https://github.com/garyyu","followers_url":"https://api.github.com/users/garyyu/followers","following_url":"https://api.github.com/users/garyyu/following{/other_user}","gists_url":"https://api.github.com/users/garyyu/gists{/gist_id}","starred_url":"https://api.github.com/users/garyyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyyu/subscriptions","organizations_url":"https://api.github.com/users/garyyu/orgs","repos_url":"https://api.github.com/users/garyyu/repos","events_url":"https://api.github.com/users/garyyu/events{/privacy}","received_events_url":"https://api.github.com/users/garyyu/received_events","type":"User","site_admin":false},"repo":{"id":131562603,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1NjI2MDM=","name":"grin","full_name":"garyyu/grin","owner":{"login":"garyyu","id":1852227,"node_id":"MDQ6VXNlcjE4NTIyMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1852227?v=4","gravatar_id":"","url":"https://api.github.com/users/garyyu","html_url":"https://github.com/garyyu","followers_url":"https://api.github.com/users/garyyu/followers","following_url":"https://api.github.com/users/garyyu/following{/other_user}","gists_url":"https://api.github.com/users/garyyu/gists{/gist_id}","starred_url":"https://api.github.com/users/garyyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyyu/subscriptions","organizations_url":"https://api.github.com/users/garyyu/orgs","repos_url":"https://api.github.com/users/garyyu/repos","events_url":"https://api.github.com/users/garyyu/events{/privacy}","received_events_url":"https://api.github.com/users/garyyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garyyu/grin","description":"Minimal implementation of the MimbleWimble protocol.","fork":true,"url":"https://api.github.com/repos/garyyu/grin","forks_url":"https://api.github.com/repos/garyyu/grin/forks","keys_url":"https://api.github.com/repos/garyyu/grin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garyyu/grin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garyyu/grin/teams","hooks_url":"https://api.github.com/repos/garyyu/grin/hooks","issue_events_url":"https://api.github.com/repos/garyyu/grin/issues/events{/number}","events_url":"https://api.github.com/repos/garyyu/grin/events","assignees_url":"https://api.github.com/repos/garyyu/grin/assignees{/user}","branches_url":"https://api.github.com/repos/garyyu/grin/branches{/branch}","tags_url":"https://api.github.com/repos/garyyu/grin/tags","blobs_url":"https://api.github.com/repos/garyyu/grin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garyyu/grin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garyyu/grin/git/refs{/sha}","trees_url":"https://api.github.com/repos/garyyu/grin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garyyu/grin/statuses/{sha}","languages_url":"https://api.github.com/repos/garyyu/grin/languages","stargazers_url":"https://api.github.com/repos/garyyu/grin/stargazers","contributors_url":"https://api.github.com/repos/garyyu/grin/contributors","subscribers_url":"https://api.github.com/repos/garyyu/grin/subscribers","subscription_url":"https://api.github.com/repos/garyyu/grin/subscription","commits_url":"https://api.github.com/repos/garyyu/grin/commits{/sha}","git_commits_url":"https://api.github.com/repos/garyyu/grin/git/commits{/sha}","comments_url":"https://api.github.com/repos/garyyu/grin/comments{/number}","issue_comment_url":"https://api.github.com/repos/garyyu/grin/issues/comments{/number}","contents_url":"https://api.github.com/repos/garyyu/grin/contents/{+path}","compare_url":"https://api.github.com/repos/garyyu/grin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garyyu/grin/merges","archive_url":"https://api.github.com/repos/garyyu/grin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garyyu/grin/downloads","issues_url":"https://api.github.com/repos/garyyu/grin/issues{/number}","pulls_url":"https://api.github.com/repos/garyyu/grin/pulls{/number}","milestones_url":"https://api.github.com/repos/garyyu/grin/milestones{/number}","notifications_url":"https://api.github.com/repos/garyyu/grin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garyyu/grin/labels{/name}","releases_url":"https://api.github.com/repos/garyyu/grin/releases{/id}","deployments_url":"https://api.github.com/repos/garyyu/grin/deployments","created_at":"2018-04-30T06:22:04Z","updated_at":"2018-06-06T09:43:34Z","pushed_at":"2018-07-31T15:17:18Z","git_url":"git://github.com/garyyu/grin.git","ssh_url":"git@github.com:garyyu/grin.git","clone_url":"https://github.com/garyyu/grin.git","svn_url":"https://github.com/garyyu/grin","homepage":"http://grin-tech.org/","size":9108,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mimblewimble:master","ref":"master","sha":"84e46c2872629ff0447884a6201a738070bcbbbd","user":{"login":"mimblewimble","id":23646132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjQ2MTMy","avatar_url":"https://avatars0.githubusercontent.com/u/23646132?v=4","gravatar_id":"","url":"https://api.github.com/users/mimblewimble","html_url":"https://github.com/mimblewimble","followers_url":"https://api.github.com/users/mimblewimble/followers","following_url":"https://api.github.com/users/mimblewimble/following{/other_user}","gists_url":"https://api.github.com/users/mimblewimble/gists{/gist_id}","starred_url":"https://api.github.com/users/mimblewimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimblewimble/subscriptions","organizations_url":"https://api.github.com/users/mimblewimble/orgs","repos_url":"https://api.github.com/users/mimblewimble/repos","events_url":"https://api.github.com/users/mimblewimble/events{/privacy}","received_events_url":"https://api.github.com/users/mimblewimble/received_events","type":"Organization","site_admin":false},"repo":{"id":71514072,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUxNDA3Mg==","name":"grin","full_name":"mimblewimble/grin","owner":{"login":"mimblewimble","id":23646132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjQ2MTMy","avatar_url":"https://avatars0.githubusercontent.com/u/23646132?v=4","gravatar_id":"","url":"https://api.github.com/users/mimblewimble","html_url":"https://github.com/mimblewimble","followers_url":"https://api.github.com/users/mimblewimble/followers","following_url":"https://api.github.com/users/mimblewimble/following{/other_user}","gists_url":"https://api.github.com/users/mimblewimble/gists{/gist_id}","starred_url":"https://api.github.com/users/mimblewimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimblewimble/subscriptions","organizations_url":"https://api.github.com/users/mimblewimble/orgs","repos_url":"https://api.github.com/users/mimblewimble/repos","events_url":"https://api.github.com/users/mimblewimble/events{/privacy}","received_events_url":"https://api.github.com/users/mimblewimble/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mimblewimble/grin","description":"Minimal implementation of the MimbleWimble protocol.","fork":false,"url":"https://api.github.com/repos/mimblewimble/grin","forks_url":"https://api.github.com/repos/mimblewimble/grin/forks","keys_url":"https://api.github.com/repos/mimblewimble/grin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mimblewimble/grin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mimblewimble/grin/teams","hooks_url":"https://api.github.com/repos/mimblewimble/grin/hooks","issue_events_url":"https://api.github.com/repos/mimblewimble/grin/issues/events{/number}","events_url":"https://api.github.com/repos/mimblewimble/grin/events","assignees_url":"https://api.github.com/repos/mimblewimble/grin/assignees{/user}","branches_url":"https://api.github.com/repos/mimblewimble/grin/branches{/branch}","tags_url":"https://api.github.com/repos/mimblewimble/grin/tags","blobs_url":"https://api.github.com/repos/mimblewimble/grin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mimblewimble/grin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mimblewimble/grin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mimblewimble/grin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mimblewimble/grin/statuses/{sha}","languages_url":"https://api.github.com/repos/mimblewimble/grin/languages","stargazers_url":"https://api.github.com/repos/mimblewimble/grin/stargazers","contributors_url":"https://api.github.com/repos/mimblewimble/grin/contributors","subscribers_url":"https://api.github.com/repos/mimblewimble/grin/subscribers","subscription_url":"https://api.github.com/repos/mimblewimble/grin/subscription","commits_url":"https://api.github.com/repos/mimblewimble/grin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mimblewimble/grin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mimblewimble/grin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mimblewimble/grin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mimblewimble/grin/contents/{+path}","compare_url":"https://api.github.com/repos/mimblewimble/grin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mimblewimble/grin/merges","archive_url":"https://api.github.com/repos/mimblewimble/grin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mimblewimble/grin/downloads","issues_url":"https://api.github.com/repos/mimblewimble/grin/issues{/number}","pulls_url":"https://api.github.com/repos/mimblewimble/grin/pulls{/number}","milestones_url":"https://api.github.com/repos/mimblewimble/grin/milestones{/number}","notifications_url":"https://api.github.com/repos/mimblewimble/grin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mimblewimble/grin/labels{/name}","releases_url":"https://api.github.com/repos/mimblewimble/grin/releases{/id}","deployments_url":"https://api.github.com/repos/mimblewimble/grin/deployments","created_at":"2016-10-21T00:02:23Z","updated_at":"2018-07-31T14:33:30Z","pushed_at":"2018-07-31T15:23:38Z","git_url":"git://github.com/mimblewimble/grin.git","ssh_url":"git@github.com:mimblewimble/grin.git","clone_url":"https://github.com/mimblewimble/grin.git","svn_url":"https://github.com/mimblewimble/grin","homepage":"http://grin-tech.org/","size":9345,"stargazers_count":1280,"watchers_count":1280,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":239,"open_issues":70,"watchers":1280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/1305"},"html":{"href":"https://github.com/mimblewimble/grin/pull/1305"},"issue":{"href":"https://api.github.com/repos/mimblewimble/grin/issues/1305"},"comments":{"href":"https://api.github.com/repos/mimblewimble/grin/issues/1305/comments"},"review_comments":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/1305/comments"},"review_comment":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/1305/commits"},"statuses":{"href":"https://api.github.com/repos/mimblewimble/grin/statuses/ed9d990297e3cda6ed9950c4ee325e279857ef6b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"garyyu"}}