{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/23155","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/23155/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23155/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/23155/events","html_url":"https://github.com/nodejs/node/pull/23155","id":365082735,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTE2MDYx","number":23155,"title":"doc: formalize non-const reference usage in C++ style guide","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":678967957,"node_id":"MDU6TGFiZWw2Nzg5Njc5NTc=","url":"https://api.github.com/repos/nodejs/node/labels/tsc-agenda","name":"tsc-agenda","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-09-29T01:15:04Z","updated_at":"2018-10-03T12:06:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23155","html_url":"https://github.com/nodejs/node/pull/23155","diff_url":"https://github.com/nodejs/node/pull/23155.diff","patch_url":"https://github.com/nodejs/node/pull/23155.patch"},"body":"Split out from #23028 by request from @refack. I’ve added people who approved the other PR as reviewers on the commit. I’m also moving the `tsc-agenda` label over here, assuming @refack’s objection stands.\r\n\r\n---\r\n\r\nWe generally avoid using non-const references if not necessary. This\r\nformalizes this rules by writing them down in the C++ style guide.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/426612266","html_url":"https://github.com/nodejs/node/pull/23155#issuecomment-426612266","issue_url":"https://api.github.com/repos/nodejs/node/issues/23155","id":426612266,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjYxMjI2Ng==","user":{"login":"rvagg","id":495647,"node_id":"MDQ6VXNlcjQ5NTY0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/495647?v=4","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T12:06:02Z","updated_at":"2018-10-03T12:06:02Z","author_association":"MEMBER","body":"Abstain, although I'm more than happy to defer to @addaleax to make a good call on this one"}}
{"actor":{"display_login":"rvagg"}}