{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/observable/pulls/comments/174189061","pull_request_review_id":103498959,"id":174189061,"diff_hunk":"@@ -155,65 +155,37 @@ class ObservableMap<K, V> extends Observable implements Map<K, V> {\n   String toString() => MapBase.mapToString(this);\n \n   @override\n-  // TODO: Dart 2.0 requires this method to be implemented.\n-  // ignore: override_on_non_overriding_method\n-  Map<K2, V2> cast<K2, V2>() {\n-    throw new UnimplementedError(\"cast\");\n-  }\n+  Map<K2, V2> cast<K2, V2>() => _map.cast<K2, V2>();\n \n   @override\n-  // TODO: Dart 2.0 requires this method to be implemented.\n-  // ignore: override_on_non_overriding_method\n-  Map<K2, V2> retype<K2, V2>() {\n-    throw new UnimplementedError(\"retype\");\n-  }\n+  Map<K2, V2> retype<K2, V2>() => _map.retype<K2, V2>();\n \n   @override\n-  // TODO: Dart 2.0 requires this method to be implemented.\n-  // ignore: override_on_non_overriding_getter\n-  Iterable<Null> get entries {\n-    // Change Iterable<Null> to Iterable<MapEntry<K, V>> when\n-    // the MapEntry class has been added.\n-    throw new UnimplementedError(\"entries\");\n-  }\n+  Iterable<MapEntry<K, V>> get entries => _map.entries;\n \n   @override\n-  // TODO: Dart 2.0 requires this method to be implemented.\n-  // ignore: override_on_non_overriding_method\n-  void addEntries(Iterable<Object> entries) {\n-    // Change Iterable<Object> to Iterable<MapEntry<K, V>> when\n-    // the MapEntry class has been added.\n-    throw new UnimplementedError(\"addEntries\");\n+  void addEntries(Iterable<MapEntry<K, V>> entries) {\n+    _map.addEntries(entries);\n   }\n \n   @override\n-  // TODO: Dart 2.0 requires this method to be implemented.\n-  // ignore: override_on_non_overriding_method\n-  Map<K2, V2> map<K2, V2>(Object transform(K key, V value)) {\n-    // Change Object to MapEntry<K2, V2> when\n-    // the MapEntry class has been added.\n-    throw new UnimplementedError(\"map\");\n+  Map<K2, V2> map<K2, V2>(MapEntry<K2, V2> transform(K key, V value)) {\n+    return _map.map(transform);\n   }\n \n   @override\n-  // TODO: Dart 2.0 requires this method to be implemented.\n-  // ignore: override_on_non_overriding_method\n   V update(K key, V update(V value), {V ifAbsent()}) {\n-    throw new UnimplementedError(\"update\");\n+    return _map.update(key, update, ifAbsent: ifAbsent);\n   }\n \n   @override\n-  // TODO: Dart 2.0 requires this method to be implemented.\n-  // ignore: override_on_non_overriding_method\n   void updateAll(V update(K key, V value)) {\n-    throw new UnimplementedError(\"updateAll\");\n+    return _map.updateAll(update);","path":"lib/src/observable_map.dart","position":64,"original_position":64,"commit_id":"aadce84ab5c8af6a72e99afa28c74a1d96638368","original_commit_id":"aadce84ab5c8af6a72e99afa28c74a1d96638368","user":{"login":"munificent","id":46275,"avatar_url":"https://avatars0.githubusercontent.com/u/46275?v=4","gravatar_id":"","url":"https://api.github.com/users/munificent","html_url":"https://github.com/munificent","followers_url":"https://api.github.com/users/munificent/followers","following_url":"https://api.github.com/users/munificent/following{/other_user}","gists_url":"https://api.github.com/users/munificent/gists{/gist_id}","starred_url":"https://api.github.com/users/munificent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munificent/subscriptions","organizations_url":"https://api.github.com/users/munificent/orgs","repos_url":"https://api.github.com/users/munificent/repos","events_url":"https://api.github.com/users/munificent/events{/privacy}","received_events_url":"https://api.github.com/users/munificent/received_events","type":"User","site_admin":false},"body":"No return needed here.","created_at":"2018-03-13T16:04:10Z","updated_at":"2018-03-13T16:14:18Z","html_url":"https://github.com/dart-lang/observable/pull/62#discussion_r174189061","pull_request_url":"https://api.github.com/repos/dart-lang/observable/pulls/62","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/observable/pulls/comments/174189061"},"html":{"href":"https://github.com/dart-lang/observable/pull/62#discussion_r174189061"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/observable/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/observable/pulls/62","id":174550146,"html_url":"https://github.com/dart-lang/observable/pull/62","diff_url":"https://github.com/dart-lang/observable/pull/62.diff","patch_url":"https://github.com/dart-lang/observable/pull/62.patch","issue_url":"https://api.github.com/repos/dart-lang/observable/issues/62","number":62,"state":"open","locked":false,"title":"Add implementations of Dart 2 methods.","user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-13T03:36:36Z","updated_at":"2018-03-13T16:14:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fa467f8154b7939884737ec1017771ef5cd5ef5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nshahan","id":2498387,"avatar_url":"https://avatars2.githubusercontent.com/u/2498387?v=4","gravatar_id":"","url":"https://api.github.com/users/nshahan","html_url":"https://github.com/nshahan","followers_url":"https://api.github.com/users/nshahan/followers","following_url":"https://api.github.com/users/nshahan/following{/other_user}","gists_url":"https://api.github.com/users/nshahan/gists{/gist_id}","starred_url":"https://api.github.com/users/nshahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshahan/subscriptions","organizations_url":"https://api.github.com/users/nshahan/orgs","repos_url":"https://api.github.com/users/nshahan/repos","events_url":"https://api.github.com/users/nshahan/events{/privacy}","received_events_url":"https://api.github.com/users/nshahan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":452981799,"url":"https://api.github.com/repos/dart-lang/observable/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/observable/pulls/62/commits","review_comments_url":"https://api.github.com/repos/dart-lang/observable/pulls/62/comments","review_comment_url":"https://api.github.com/repos/dart-lang/observable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/observable/issues/62/comments","statuses_url":"https://api.github.com/repos/dart-lang/observable/statuses/aadce84ab5c8af6a72e99afa28c74a1d96638368","head":{"label":"dart-lang:implement-dart-2","ref":"implement-dart-2","sha":"aadce84ab5c8af6a72e99afa28c74a1d96638368","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":69056672,"name":"observable","full_name":"dart-lang/observable","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/observable","description":"Support for marking objects as observable, and getting notifications when those objects are mutated.","fork":false,"url":"https://api.github.com/repos/dart-lang/observable","forks_url":"https://api.github.com/repos/dart-lang/observable/forks","keys_url":"https://api.github.com/repos/dart-lang/observable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/observable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/observable/teams","hooks_url":"https://api.github.com/repos/dart-lang/observable/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/observable/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/observable/events","assignees_url":"https://api.github.com/repos/dart-lang/observable/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/observable/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/observable/tags","blobs_url":"https://api.github.com/repos/dart-lang/observable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/observable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/observable/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/observable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/observable/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/observable/languages","stargazers_url":"https://api.github.com/repos/dart-lang/observable/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/observable/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/observable/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/observable/subscription","commits_url":"https://api.github.com/repos/dart-lang/observable/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/observable/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/observable/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/observable/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/observable/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/observable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/observable/merges","archive_url":"https://api.github.com/repos/dart-lang/observable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/observable/downloads","issues_url":"https://api.github.com/repos/dart-lang/observable/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/observable/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/observable/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/observable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/observable/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/observable/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/observable/deployments","created_at":"2016-09-23T20:00:28Z","updated_at":"2018-01-25T12:29:11Z","pushed_at":"2018-03-13T04:03:01Z","git_url":"git://github.com/dart-lang/observable.git","ssh_url":"git@github.com:dart-lang/observable.git","clone_url":"https://github.com/dart-lang/observable.git","svn_url":"https://github.com/dart-lang/observable","homepage":"https://pub.dartlang.org/packages/observable","size":119,"stargazers_count":12,"watchers_count":12,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":9,"open_issues":5,"watchers":12,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"d62a16397c0a398b8f815d52978dfa86a14c8cfc","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":69056672,"name":"observable","full_name":"dart-lang/observable","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/observable","description":"Support for marking objects as observable, and getting notifications when those objects are mutated.","fork":false,"url":"https://api.github.com/repos/dart-lang/observable","forks_url":"https://api.github.com/repos/dart-lang/observable/forks","keys_url":"https://api.github.com/repos/dart-lang/observable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/observable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/observable/teams","hooks_url":"https://api.github.com/repos/dart-lang/observable/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/observable/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/observable/events","assignees_url":"https://api.github.com/repos/dart-lang/observable/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/observable/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/observable/tags","blobs_url":"https://api.github.com/repos/dart-lang/observable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/observable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/observable/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/observable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/observable/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/observable/languages","stargazers_url":"https://api.github.com/repos/dart-lang/observable/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/observable/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/observable/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/observable/subscription","commits_url":"https://api.github.com/repos/dart-lang/observable/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/observable/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/observable/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/observable/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/observable/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/observable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/observable/merges","archive_url":"https://api.github.com/repos/dart-lang/observable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/observable/downloads","issues_url":"https://api.github.com/repos/dart-lang/observable/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/observable/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/observable/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/observable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/observable/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/observable/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/observable/deployments","created_at":"2016-09-23T20:00:28Z","updated_at":"2018-01-25T12:29:11Z","pushed_at":"2018-03-13T04:03:01Z","git_url":"git://github.com/dart-lang/observable.git","ssh_url":"git@github.com:dart-lang/observable.git","clone_url":"https://github.com/dart-lang/observable.git","svn_url":"https://github.com/dart-lang/observable","homepage":"https://pub.dartlang.org/packages/observable","size":119,"stargazers_count":12,"watchers_count":12,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":9,"open_issues":5,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/observable/pulls/62"},"html":{"href":"https://github.com/dart-lang/observable/pull/62"},"issue":{"href":"https://api.github.com/repos/dart-lang/observable/issues/62"},"comments":{"href":"https://api.github.com/repos/dart-lang/observable/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/observable/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/observable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/observable/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/observable/statuses/aadce84ab5c8af6a72e99afa28c74a1d96638368"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"munificent"}}