{"action":"opened","issue":{"url":"https://api.github.com/repos/adafruit/Adafruit-GFX-Library/issues/167","repository_url":"https://api.github.com/repos/adafruit/Adafruit-GFX-Library","labels_url":"https://api.github.com/repos/adafruit/Adafruit-GFX-Library/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/adafruit/Adafruit-GFX-Library/issues/167/comments","events_url":"https://api.github.com/repos/adafruit/Adafruit-GFX-Library/issues/167/events","html_url":"https://github.com/adafruit/Adafruit-GFX-Library/issues/167","id":344896316,"node_id":"MDU6SXNzdWUzNDQ4OTYzMTY=","number":167,"title":"Compile errors  USE_FAST_PINIO is not defined.... And compile on OpenCM and OpenCR boards","user":{"login":"KurtE","id":1558080,"node_id":"MDQ6VXNlcjE1NTgwODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1558080?v=4","gravatar_id":"","url":"https://api.github.com/users/KurtE","html_url":"https://github.com/KurtE","followers_url":"https://api.github.com/users/KurtE/followers","following_url":"https://api.github.com/users/KurtE/following{/other_user}","gists_url":"https://api.github.com/users/KurtE/gists{/gist_id}","starred_url":"https://api.github.com/users/KurtE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurtE/subscriptions","organizations_url":"https://api.github.com/users/KurtE/orgs","repos_url":"https://api.github.com/users/KurtE/repos","events_url":"https://api.github.com/users/KurtE/events{/privacy}","received_events_url":"https://api.github.com/users/KurtE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-26T15:35:02Z","updated_at":"2018-07-26T15:35:02Z","closed_at":null,"author_association":"NONE","body":"First part of this issue, is there are compile issues if you try to undefine USE_FAST_PINIO.   \r\nYou need ;'s after the digitalWrite commands in the macros.  Also in your header file in the \r\n#else clause for which board is used, the source file uses #undefine where it should be #undef\r\n\r\nI found these trying to get the code to build for a couple of the Robotis boards:\r\nOpenCR1.0 and the OpenCM9.04 boards.  \r\n\r\nI was able to make it build using the following changes:\r\n\r\nIn Adafruit_SPITFT.h:\r\n```\r\n@@ -16,12 +16,14 @@\r\ntypedef volatile uint8_t RwReg;\r\n#elif defined(ARDUINO_STM32_FEATHER)\r\ntypedef volatile uint32 RwReg;\r\n#elif defined(__OPENCR__) || defined (__OPENCM904__)\r\n#undef USE_FAST_PINIO\r\n#elif defined(ARDUINO_FEATHER52) || defined(__arm__)\r\ntypedef volatile uint32_t RwReg;\r\n#elif defined(ESP32) || defined(ESP8266)\r\ntypedef volatile uint32_t RwReg;\r\n#else\r\n#undefine USE_FAST_PINIO\r\n#undef USE_FAST_PINIO\r\n#endif\r\n\r\n#include \"Adafruit_SPITFT_Macros.h\"\r\n```\r\n\r\nThen fix a few of their issues in Adafruit_SPITFT_Machros.h\r\n```\r\n@@ -13,8 +13,8 @@\r\n#else\r\n#define SPI_DC_HIGH()           digitalWrite(_dc, HIGH)\r\n#define SPI_DC_LOW()            digitalWrite(_dc, LOW)\r\n#define SPI_CS_HIGH()           { if(_cs >= 0) digitalWrite(_cs, HIGH) }\r\n#define SPI_CS_LOW()            { if(_cs >= 0) digitalWrite(_cs, LOW)  }\r\n#define SPI_CS_HIGH()           { if(_cs >= 0) digitalWrite(_cs, HIGH); }\r\n#define SPI_CS_LOW()            { if(_cs >= 0) digitalWrite(_cs, LOW);  }\r\n#endif\r\n\r\n```\r\nAs these boards do not have the same concept of being able to write a bit to a specific memory location to turn on or off an IO pin.\r\n\r\nWould be great if you added this to your sources.\r\n\r\nThanks"}}
{"actor":{"display_login":"KurtE"}}