{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/12998","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/12998/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/12998/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/12998/events","html_url":"https://github.com/ampproject/amphtml/issues/12998","id":291048641,"node_id":"MDU6SXNzdWUyOTEwNDg2NDE=","number":12998,"title":"Safari button nav overlaps amp-sidebar","user":{"login":"dryleaf","id":16116003,"node_id":"MDQ6VXNlcjE2MTE2MDAz","avatar_url":"https://avatars2.githubusercontent.com/u/16116003?v=4","gravatar_id":"","url":"https://api.github.com/users/dryleaf","html_url":"https://github.com/dryleaf","followers_url":"https://api.github.com/users/dryleaf/followers","following_url":"https://api.github.com/users/dryleaf/following{/other_user}","gists_url":"https://api.github.com/users/dryleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/dryleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryleaf/subscriptions","organizations_url":"https://api.github.com/users/dryleaf/orgs","repos_url":"https://api.github.com/users/dryleaf/repos","events_url":"https://api.github.com/users/dryleaf/events{/privacy}","received_events_url":"https://api.github.com/users/dryleaf/received_events","type":"User","site_admin":false},"labels":[{"id":284525535,"node_id":"MDU6TGFiZWwyODQ1MjU1MzU=","url":"https://api.github.com/repos/ampproject/amphtml/labels/P3:%20When%20Possible","name":"P3: When Possible","color":"e99695","default":false},{"id":255304066,"node_id":"MDU6TGFiZWwyNTUzMDQwNjY=","url":"https://api.github.com/repos/ampproject/amphtml/labels/Type:%20Bug","name":"Type: Bug","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"assignees":[{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/4","html_url":"https://github.com/ampproject/amphtml/milestone/4","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/4/labels","id":1537240,"node_id":"MDk6TWlsZXN0b25lMTUzNzI0MA==","number":4,"title":"Backlog Bugs","description":"This milestone tracks all bugs opened for the projects that are not yet assigned to a sprint milestone. Bugs within this milestone will be fixed based on the priority of the issue. ","creator":{"login":"rudygalfi","id":3888212,"node_id":"MDQ6VXNlcjM4ODgyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3888212?v=4","gravatar_id":"","url":"https://api.github.com/users/rudygalfi","html_url":"https://github.com/rudygalfi","followers_url":"https://api.github.com/users/rudygalfi/followers","following_url":"https://api.github.com/users/rudygalfi/following{/other_user}","gists_url":"https://api.github.com/users/rudygalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/rudygalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudygalfi/subscriptions","organizations_url":"https://api.github.com/users/rudygalfi/orgs","repos_url":"https://api.github.com/users/rudygalfi/repos","events_url":"https://api.github.com/users/rudygalfi/events{/privacy}","received_events_url":"https://api.github.com/users/rudygalfi/received_events","type":"User","site_admin":false},"open_issues":483,"closed_issues":683,"state":"open","created_at":"2016-01-22T23:51:53Z","updated_at":"2018-06-05T08:11:11Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-01-24T01:01:08Z","updated_at":"2018-06-05T08:47:13Z","closed_at":null,"author_association":"NONE","body":"To fix safari bottom navigation bar from overlapping my *amp-sidebar* I have added the following css:\r\n```\r\namp-sidebar {\r\n   mas-height: 100%!important; \r\n}\r\n```\r\ni.e. I changed **vh** to **%**, and it works fine. but the amp-validation fails because it does not allow *!important* in css.\r\n\r\nAccording to amp-sidebar css source, the *max-height* property is set to `max-height: 100vh!important;`. \r\n- reference: https://github.com/ampproject/amphtml/blob/7e2ec79855e8325ac5d1cca0e15ed5aef8f50877/extensions/amp-sidebar/0.1/amp-sidebar.css#L20\r\n\r\nMy question is:\r\n- How am I supposed to change the amp-sidebar's _max-height_ property without having validation errors?"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/394631440","html_url":"https://github.com/ampproject/amphtml/issues/12998#issuecomment-394631440","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/12998","id":394631440,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDYzMTQ0MA==","user":{"login":"ampprojectbot","id":23269078,"node_id":"MDQ6VXNlcjIzMjY5MDc4","avatar_url":"https://avatars3.githubusercontent.com/u/23269078?v=4","gravatar_id":"","url":"https://api.github.com/users/ampprojectbot","html_url":"https://github.com/ampprojectbot","followers_url":"https://api.github.com/users/ampprojectbot/followers","following_url":"https://api.github.com/users/ampprojectbot/following{/other_user}","gists_url":"https://api.github.com/users/ampprojectbot/gists{/gist_id}","starred_url":"https://api.github.com/users/ampprojectbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampprojectbot/subscriptions","organizations_url":"https://api.github.com/users/ampprojectbot/orgs","repos_url":"https://api.github.com/users/ampprojectbot/repos","events_url":"https://api.github.com/users/ampprojectbot/events{/privacy}","received_events_url":"https://api.github.com/users/ampprojectbot/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T08:47:13Z","updated_at":"2018-06-05T08:47:13Z","author_association":"COLLABORATOR","body":"This issue doesn't have a category which makes it harder for us to keep track of it. @aghassemi Please add an appropriate category."}}
{"actor":{"display_login":"ampprojectbot"}}