{"action":"created","issue":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1270","repository_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1270/labels{/name}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1270/comments","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1270/events","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1270","id":297527326,"number":1270,"title":"Redefine SMC_UNK as -1 instead of 0xFFFFFFFF","user":{"login":"antonio-nino-diaz-arm","id":16819896,"avatar_url":"https://avatars3.githubusercontent.com/u/16819896?v=4","gravatar_id":"","url":"https://api.github.com/users/antonio-nino-diaz-arm","html_url":"https://github.com/antonio-nino-diaz-arm","followers_url":"https://api.github.com/users/antonio-nino-diaz-arm/followers","following_url":"https://api.github.com/users/antonio-nino-diaz-arm/following{/other_user}","gists_url":"https://api.github.com/users/antonio-nino-diaz-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/antonio-nino-diaz-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonio-nino-diaz-arm/subscriptions","organizations_url":"https://api.github.com/users/antonio-nino-diaz-arm/orgs","repos_url":"https://api.github.com/users/antonio-nino-diaz-arm/repos","events_url":"https://api.github.com/users/antonio-nino-diaz-arm/events{/privacy}","received_events_url":"https://api.github.com/users/antonio-nino-diaz-arm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-15T17:16:44Z","updated_at":"2018-02-20T09:00:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1270","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1270","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1270.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1270.patch"},"body":"According to the SMC Calling Convention (ARM DEN0028B):\r\n\r\n> The Unknown SMC Function Identifier is a sign-extended value of (-1) that is returned in R0, W0 or X0 register.\r\n\r\nThe value wasn't sign-extended because it was defined as a 32-bit unsigned value (`0xFFFFFFFF`).\r\n\r\n`SMC_PREEMPT` has been redefined as -2 for the same reason.\r\n\r\nNOTE: This might be a compatibility break for some AArch64 platforms that don't follow the previous version of the SMCCC (ARM DEN0028A) correctly. That document specifies that only the bottom 32 bits of the returned value must be checked. If a platform relies on the top 32 bits of the result being 0 (so that `SMC_UNK` is `0x00000000FFFFFFFF`), it will have to fix its code to comply with the SMCCC."},"comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments/366911091","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1270#issuecomment-366911091","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1270","id":366911091,"user":{"login":"davidcunado-arm","id":19822500,"avatar_url":"https://avatars2.githubusercontent.com/u/19822500?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcunado-arm","html_url":"https://github.com/davidcunado-arm","followers_url":"https://api.github.com/users/davidcunado-arm/followers","following_url":"https://api.github.com/users/davidcunado-arm/following{/other_user}","gists_url":"https://api.github.com/users/davidcunado-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcunado-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcunado-arm/subscriptions","organizations_url":"https://api.github.com/users/davidcunado-arm/orgs","repos_url":"https://api.github.com/users/davidcunado-arm/repos","events_url":"https://api.github.com/users/davidcunado-arm/events{/privacy}","received_events_url":"https://api.github.com/users/davidcunado-arm/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T09:00:21Z","updated_at":"2018-02-20T09:00:21Z","author_association":"CONTRIBUTOR","body":"Check fails - due to corresponding change needed in internal test framework; will be applied once PR merged."}}
{"actor":{"display_login":"davidcunado-arm"}}