{"action":"created","comment":{"url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments/237114890","pull_request_review_id":179334619,"id":237114890,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzExNDg5MA==","diff_hunk":"@@ -1,7 +1,8 @@\n import html from 'nanohtml';\n import raw from 'nanohtml/raw';\n \n-export default ({ src, alt = 'AXA Logo', href = '#' } = {}) => html`\n+export default ({ src, alt = 'AXA Logo', href = '#' } = {","path":"src/components/m-header-logo/_template.js","position":5,"original_position":5,"commit_id":"935a4e48506595f188413dd55d8c890057a66bd2","original_commit_id":"935a4e48506595f188413dd55d8c890057a66bd2","user":{"login":"LucaMele","id":275235,"node_id":"MDQ6VXNlcjI3NTIzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/275235?v=4","gravatar_id":"","url":"https://api.github.com/users/LucaMele","html_url":"https://github.com/LucaMele","followers_url":"https://api.github.com/users/LucaMele/followers","following_url":"https://api.github.com/users/LucaMele/following{/other_user}","gists_url":"https://api.github.com/users/LucaMele/gists{/gist_id}","starred_url":"https://api.github.com/users/LucaMele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucaMele/subscriptions","organizations_url":"https://api.github.com/users/LucaMele/orgs","repos_url":"https://api.github.com/users/LucaMele/repos","events_url":"https://api.github.com/users/LucaMele/events{/privacy}","received_events_url":"https://api.github.com/users/LucaMele/received_events","type":"User","site_admin":false},"body":"Touche :)","created_at":"2018-11-28T14:51:31Z","updated_at":"2018-11-28T14:51:31Z","html_url":"https://github.com/axa-ch/patterns-library/pull/695#discussion_r237114890","pull_request_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments/237114890"},"html":{"href":"https://github.com/axa-ch/patterns-library/pull/695#discussion_r237114890"},"pull_request":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695"}},"in_reply_to_id":237109217},"pull_request":{"url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695","id":234224010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MjI0MDEw","html_url":"https://github.com/axa-ch/patterns-library/pull/695","diff_url":"https://github.com/axa-ch/patterns-library/pull/695.diff","patch_url":"https://github.com/axa-ch/patterns-library/pull/695.patch","issue_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/695","number":695,"state":"open","locked":false,"title":"Feature/build improvements","user":{"login":"jackblackCH","id":2416200,"node_id":"MDQ6VXNlcjI0MTYyMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2416200?v=4","gravatar_id":"","url":"https://api.github.com/users/jackblackCH","html_url":"https://github.com/jackblackCH","followers_url":"https://api.github.com/users/jackblackCH/followers","following_url":"https://api.github.com/users/jackblackCH/following{/other_user}","gists_url":"https://api.github.com/users/jackblackCH/gists{/gist_id}","starred_url":"https://api.github.com/users/jackblackCH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackblackCH/subscriptions","organizations_url":"https://api.github.com/users/jackblackCH/orgs","repos_url":"https://api.github.com/users/jackblackCH/repos","events_url":"https://api.github.com/users/jackblackCH/events{/privacy}","received_events_url":"https://api.github.com/users/jackblackCH/received_events","type":"User","site_admin":false},"body":"Rel #592\r\n\r\nI felt really sluggish in development, so I improved the build (only) as much as it was necessary for the moment.\r\n\r\nThe improved build increases the developer experience a lot.\r\n\r\nEdit: There were lot of temporary datepicker changes.\r\nI reverted them, they will be handled in another PR.\r\n\r\n## Changes\r\n- Remove console logs\r\n   - it was hard to see actual errors and dev output while working on a component\r\n   - I commented the logs for the moment, for those who need them in dev.\r\n      - In the future, logs should be set behind a `-v` flag #673 \r\n- Improves build time. It's much faster (improved multi loops, combined in less loops)\r\n   - makes build easier to understand #592 \r\n- Generates a single view per component to develop encapsulated without side effects\r\n   - each component has it's own view, for instance, /component/a-datepicker/index.html\r\n   - To create this, the code had to be refactored, now there are simpler methods, purer.\r\n\r\n## Type of change\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)","created_at":"2018-11-28T10:31:42Z","updated_at":"2018-11-28T14:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"378b24e4e1aadaa6902f61e4e7a387370c991093","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695/commits","review_comments_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695/comments","review_comment_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/695/comments","statuses_url":"https://api.github.com/repos/axa-ch/patterns-library/statuses/935a4e48506595f188413dd55d8c890057a66bd2","head":{"label":"axa-ch:feature/build-improvements","ref":"feature/build-improvements","sha":"935a4e48506595f188413dd55d8c890057a66bd2","user":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":112588368,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1ODgzNjg=","name":"patterns-library","full_name":"axa-ch/patterns-library","private":false,"owner":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/axa-ch/patterns-library","description":"Please share, comment, make issues and work with us! ","fork":false,"url":"https://api.github.com/repos/axa-ch/patterns-library","forks_url":"https://api.github.com/repos/axa-ch/patterns-library/forks","keys_url":"https://api.github.com/repos/axa-ch/patterns-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axa-ch/patterns-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axa-ch/patterns-library/teams","hooks_url":"https://api.github.com/repos/axa-ch/patterns-library/hooks","issue_events_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/events{/number}","events_url":"https://api.github.com/repos/axa-ch/patterns-library/events","assignees_url":"https://api.github.com/repos/axa-ch/patterns-library/assignees{/user}","branches_url":"https://api.github.com/repos/axa-ch/patterns-library/branches{/branch}","tags_url":"https://api.github.com/repos/axa-ch/patterns-library/tags","blobs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axa-ch/patterns-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/axa-ch/patterns-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axa-ch/patterns-library/statuses/{sha}","languages_url":"https://api.github.com/repos/axa-ch/patterns-library/languages","stargazers_url":"https://api.github.com/repos/axa-ch/patterns-library/stargazers","contributors_url":"https://api.github.com/repos/axa-ch/patterns-library/contributors","subscribers_url":"https://api.github.com/repos/axa-ch/patterns-library/subscribers","subscription_url":"https://api.github.com/repos/axa-ch/patterns-library/subscription","commits_url":"https://api.github.com/repos/axa-ch/patterns-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/axa-ch/patterns-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/axa-ch/patterns-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/axa-ch/patterns-library/contents/{+path}","compare_url":"https://api.github.com/repos/axa-ch/patterns-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axa-ch/patterns-library/merges","archive_url":"https://api.github.com/repos/axa-ch/patterns-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axa-ch/patterns-library/downloads","issues_url":"https://api.github.com/repos/axa-ch/patterns-library/issues{/number}","pulls_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls{/number}","milestones_url":"https://api.github.com/repos/axa-ch/patterns-library/milestones{/number}","notifications_url":"https://api.github.com/repos/axa-ch/patterns-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axa-ch/patterns-library/labels{/name}","releases_url":"https://api.github.com/repos/axa-ch/patterns-library/releases{/id}","deployments_url":"https://api.github.com/repos/axa-ch/patterns-library/deployments","created_at":"2017-11-30T08:55:17Z","updated_at":"2018-11-27T13:08:26Z","pushed_at":"2018-11-28T14:15:41Z","git_url":"git://github.com/axa-ch/patterns-library.git","ssh_url":"git@github.com:axa-ch/patterns-library.git","clone_url":"https://github.com/axa-ch/patterns-library.git","svn_url":"https://github.com/axa-ch/patterns-library","homepage":"https://www.axa.ch","size":23499,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":154,"license":null,"forks":2,"open_issues":154,"watchers":14,"default_branch":"develop"}},"base":{"label":"axa-ch:develop","ref":"develop","sha":"81600105b06c9ae4566a36a4ed4ee60a9306be17","user":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":112588368,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1ODgzNjg=","name":"patterns-library","full_name":"axa-ch/patterns-library","private":false,"owner":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/axa-ch/patterns-library","description":"Please share, comment, make issues and work with us! ","fork":false,"url":"https://api.github.com/repos/axa-ch/patterns-library","forks_url":"https://api.github.com/repos/axa-ch/patterns-library/forks","keys_url":"https://api.github.com/repos/axa-ch/patterns-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axa-ch/patterns-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axa-ch/patterns-library/teams","hooks_url":"https://api.github.com/repos/axa-ch/patterns-library/hooks","issue_events_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/events{/number}","events_url":"https://api.github.com/repos/axa-ch/patterns-library/events","assignees_url":"https://api.github.com/repos/axa-ch/patterns-library/assignees{/user}","branches_url":"https://api.github.com/repos/axa-ch/patterns-library/branches{/branch}","tags_url":"https://api.github.com/repos/axa-ch/patterns-library/tags","blobs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axa-ch/patterns-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/axa-ch/patterns-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axa-ch/patterns-library/statuses/{sha}","languages_url":"https://api.github.com/repos/axa-ch/patterns-library/languages","stargazers_url":"https://api.github.com/repos/axa-ch/patterns-library/stargazers","contributors_url":"https://api.github.com/repos/axa-ch/patterns-library/contributors","subscribers_url":"https://api.github.com/repos/axa-ch/patterns-library/subscribers","subscription_url":"https://api.github.com/repos/axa-ch/patterns-library/subscription","commits_url":"https://api.github.com/repos/axa-ch/patterns-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/axa-ch/patterns-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/axa-ch/patterns-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/axa-ch/patterns-library/contents/{+path}","compare_url":"https://api.github.com/repos/axa-ch/patterns-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axa-ch/patterns-library/merges","archive_url":"https://api.github.com/repos/axa-ch/patterns-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axa-ch/patterns-library/downloads","issues_url":"https://api.github.com/repos/axa-ch/patterns-library/issues{/number}","pulls_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls{/number}","milestones_url":"https://api.github.com/repos/axa-ch/patterns-library/milestones{/number}","notifications_url":"https://api.github.com/repos/axa-ch/patterns-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axa-ch/patterns-library/labels{/name}","releases_url":"https://api.github.com/repos/axa-ch/patterns-library/releases{/id}","deployments_url":"https://api.github.com/repos/axa-ch/patterns-library/deployments","created_at":"2017-11-30T08:55:17Z","updated_at":"2018-11-27T13:08:26Z","pushed_at":"2018-11-28T14:15:41Z","git_url":"git://github.com/axa-ch/patterns-library.git","ssh_url":"git@github.com:axa-ch/patterns-library.git","clone_url":"https://github.com/axa-ch/patterns-library.git","svn_url":"https://github.com/axa-ch/patterns-library","homepage":"https://www.axa.ch","size":23499,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":154,"license":null,"forks":2,"open_issues":154,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695"},"html":{"href":"https://github.com/axa-ch/patterns-library/pull/695"},"issue":{"href":"https://api.github.com/repos/axa-ch/patterns-library/issues/695"},"comments":{"href":"https://api.github.com/repos/axa-ch/patterns-library/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/axa-ch/patterns-library/statuses/935a4e48506595f188413dd55d8c890057a66bd2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"LucaMele"}}