{"action":"created","issue":{"url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms/issues/525","repository_url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms","labels_url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms/issues/525/labels{/name}","comments_url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms/issues/525/comments","events_url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms/issues/525/events","html_url":"https://github.com/RefugeRestrooms/refugerestrooms/pull/525","id":378496135,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTg5MjQy","number":525,"title":"Ruby 2.5","user":{"login":"DeeDeeG","id":20157115,"node_id":"MDQ6VXNlcjIwMTU3MTE1","avatar_url":"https://avatars2.githubusercontent.com/u/20157115?v=4","gravatar_id":"","url":"https://api.github.com/users/DeeDeeG","html_url":"https://github.com/DeeDeeG","followers_url":"https://api.github.com/users/DeeDeeG/followers","following_url":"https://api.github.com/users/DeeDeeG/following{/other_user}","gists_url":"https://api.github.com/users/DeeDeeG/gists{/gist_id}","starred_url":"https://api.github.com/users/DeeDeeG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeeDeeG/subscriptions","organizations_url":"https://api.github.com/users/DeeDeeG/orgs","repos_url":"https://api.github.com/users/DeeDeeG/repos","events_url":"https://api.github.com/users/DeeDeeG/events{/privacy}","received_events_url":"https://api.github.com/users/DeeDeeG/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T22:26:48Z","updated_at":"2018-11-14T14:12:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms/pulls/525","html_url":"https://github.com/RefugeRestrooms/refugerestrooms/pull/525","diff_url":"https://github.com/RefugeRestrooms/refugerestrooms/pull/525.diff","patch_url":"https://github.com/RefugeRestrooms/refugerestrooms/pull/525.patch"},"body":"# Context\r\n- Fixes #523\r\n- Update Ruby (and the Webmock gem).\r\n\r\n# Summary of Changes\r\n\r\n- Update all references to a specific Ruby version from `2.3.7` --> `2.5.3`\r\n- Update `webmock` gem (the new version of webmock is compatible with Ruby 2.5; old version has errors when used with Ruby 2.5 even though it worked fine with 2.3.7)\r\n\r\n# Checklist\r\n\r\n- [ ] Tested Mobile Responsiveness\r\n- [ ] Added Unit Tests\r\n- [ ] CI Passes\r\n- [ ] Deploys to Heroku on test Correctly (Maintainers will handle)\r\n- [ ] Added Documentation (Service and Code when required)\r\n\r\n# Screenshots\r\n\r\n## Before\r\n\r\n## After\r\n"},"comment":{"url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms/issues/comments/438675131","html_url":"https://github.com/RefugeRestrooms/refugerestrooms/pull/525#issuecomment-438675131","issue_url":"https://api.github.com/repos/RefugeRestrooms/refugerestrooms/issues/525","id":438675131,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODY3NTEzMQ==","user":{"login":"DeeDeeG","id":20157115,"node_id":"MDQ6VXNlcjIwMTU3MTE1","avatar_url":"https://avatars2.githubusercontent.com/u/20157115?v=4","gravatar_id":"","url":"https://api.github.com/users/DeeDeeG","html_url":"https://github.com/DeeDeeG","followers_url":"https://api.github.com/users/DeeDeeG/followers","following_url":"https://api.github.com/users/DeeDeeG/following{/other_user}","gists_url":"https://api.github.com/users/DeeDeeG/gists{/gist_id}","starred_url":"https://api.github.com/users/DeeDeeG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeeDeeG/subscriptions","organizations_url":"https://api.github.com/users/DeeDeeG/orgs","repos_url":"https://api.github.com/users/DeeDeeG/repos","events_url":"https://api.github.com/users/DeeDeeG/events{/privacy}","received_events_url":"https://api.github.com/users/DeeDeeG/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T14:12:39Z","updated_at":"2018-11-14T14:12:39Z","author_association":"CONTRIBUTOR","body":"I did a test deploy of this.\r\n\r\nIt seems to work fine.\r\n\r\n...\r\n\r\nBit of a red herring, but worth explaining: In general, when I have deployed to (my personal account at) Heroku recently, the \"Add a new restroom\" page breaks. This happens with Ruby 2.3 (See: https://refuge-cedar-14.herokuapp.com/) or Ruby 2.5 (See: https://refuge-ruby-25.herokuapp.com/).\r\nAnd I used to get so many errors when I tried to deploy to my personal Heroku account that the whole deploy was just error messages. Meanwhile, our normal deploy process for production has always gone better than that.\r\n\r\nSo I do think it's an issue with how _I'm set up with/using Heroku_, rather than a problem with our code or our actual deploy process for production."}}
{"actor":{"display_login":"DeeDeeG"}}