{"action":"created","issue":{"url":"https://api.github.com/repos/atom/about/issues/81","repository_url":"https://api.github.com/repos/atom/about","labels_url":"https://api.github.com/repos/atom/about/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/atom/about/issues/81/comments","events_url":"https://api.github.com/repos/atom/about/issues/81/events","html_url":"https://github.com/atom/about/pull/81","id":335115983,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTExNjU1","number":81,"title":"Adding Additional Information to About Page","user":{"login":"trevorrl","id":1477223,"node_id":"MDQ6VXNlcjE0NzcyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1477223?v=4","gravatar_id":"","url":"https://api.github.com/users/trevorrl","html_url":"https://github.com/trevorrl","followers_url":"https://api.github.com/users/trevorrl/followers","following_url":"https://api.github.com/users/trevorrl/following{/other_user}","gists_url":"https://api.github.com/users/trevorrl/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorrl/subscriptions","organizations_url":"https://api.github.com/users/trevorrl/orgs","repos_url":"https://api.github.com/users/trevorrl/repos","events_url":"https://api.github.com/users/trevorrl/events{/privacy}","received_events_url":"https://api.github.com/users/trevorrl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-23T17:04:42Z","updated_at":"2018-07-11T16:31:32Z","closed_at":"2018-07-10T20:22:58Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/atom/about/pulls/81","html_url":"https://github.com/atom/about/pull/81","diff_url":"https://github.com/atom/about/pull/81.diff","patch_url":"https://github.com/atom/about/pull/81.patch"},"body":"### Requirements\r\n\r\n* Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.\r\n* All new code requires tests to ensure against regressions\r\n\r\n### Description of the Change\r\n\r\nI've added the information provided via `atom -v` on the command line to the About page, as suggested here: https://github.com/atom/atom/issues/17547\r\n\r\nThe about page already provides the Atom version, I simply use the process.versions helper to get the Electron and Chrome versions, and the process.version to get the Node version. \r\n\r\nThese are shown by clicking a `Show more` link directly below the existing atom version number, and are smaller in order to not clutter up the design. \r\n\r\n*Edit by @rsese to drop in before/after screenshots*\r\n\r\nBefore: \r\n![before](https://user-images.githubusercontent.com/1477223/42094441-d2d0cea0-7b7d-11e8-8353-7f5e6776d4b9.png)\r\nAfter, collapsed: \r\n![after-collapsed](https://user-images.githubusercontent.com/1477223/42094467-e6b80d52-7b7d-11e8-9cfa-078f86c950d2.png)\r\nAfter, expanded: \r\n![after-expanded](https://user-images.githubusercontent.com/1477223/42094487-f138292e-7b7d-11e8-86f8-c454a71b3685.png)\r\n\r\n### Alternate Designs\r\n\r\nI at first just had the new version numbers shown by default directly below the Atom version, in the same font size, and this looked cluttered and busy. I decided since it was extra info and only useful to a subset of people, I'd put it behind a `Show more` button. This prevents cluttering the view, but allows additional useful information if desired. \r\n\r\n### Benefits\r\n\r\nThis change will give people the ability to quickly view the current versions of Electron, Chrome and Node being used in their build of Atom without having to open a terminal, and is more discoverable than a terminal command. \r\n\r\n### Possible Drawbacks\r\n\r\nI haven't noticed any drawbacks in my testing, and no changes in performance of the About page when opening or reloading. It doesn't hide any existing info or add steps to get to existing info, so those who don't need / want the additional version numbers provided won't notice a difference. \r\n\r\n### Applicable Issues\r\n\r\nn/a\r\n"},"comment":{"url":"https://api.github.com/repos/atom/about/issues/comments/404232496","html_url":"https://github.com/atom/about/pull/81#issuecomment-404232496","issue_url":"https://api.github.com/repos/atom/about/issues/81","id":404232496,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDIzMjQ5Ng==","user":{"login":"daviwil","id":79405,"node_id":"MDQ6VXNlcjc5NDA1","avatar_url":"https://avatars3.githubusercontent.com/u/79405?v=4","gravatar_id":"","url":"https://api.github.com/users/daviwil","html_url":"https://github.com/daviwil","followers_url":"https://api.github.com/users/daviwil/followers","following_url":"https://api.github.com/users/daviwil/following{/other_user}","gists_url":"https://api.github.com/users/daviwil/gists{/gist_id}","starred_url":"https://api.github.com/users/daviwil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviwil/subscriptions","organizations_url":"https://api.github.com/users/daviwil/orgs","repos_url":"https://api.github.com/users/daviwil/repos","events_url":"https://api.github.com/users/daviwil/events{/privacy}","received_events_url":"https://api.github.com/users/daviwil/received_events","type":"User","site_admin":true},"created_at":"2018-07-11T16:31:32Z","updated_at":"2018-07-11T16:31:32Z","author_association":"MEMBER","body":"This has been shipped as part of `about` 1.10.0 and will be in Atom 1.30.0-beta0.  Thanks again for your contribution! :tada: "}}
{"actor":{"display_login":"daviwil"}}