{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/172976970","pull_request_review_id":102085998,"id":172976970,"diff_hunk":"@@ -16,65 +16,31 @@\n using Microsoft.VisualStudio.Text.Editor.Commanding.Commands;\n using Microsoft.VisualStudio.Utilities;\n \n-#pragma warning disable CS0618 // IQuickInfo* is obsolete, tracked by https://github.com/dotnet/roslyn/issues/24094\n namespace Microsoft.CodeAnalysis.Editor.CommandHandlers\n {\n     [Export]\n     [Order(After = PredefinedQuickInfoPresenterNames.RoslynQuickInfoPresenter)]","path":"src/EditorFeatures/Core/CommandHandlers/QuickInfoCommandHandlerAndSourceProvider.cs","position":8,"original_position":8,"commit_id":"866bb2403121080a02a2907f1a3a94a10b2be12e","original_commit_id":"866bb2403121080a02a2907f1a3a94a10b2be12e","user":{"login":"gundermanc","id":5387680,"avatar_url":"https://avatars0.githubusercontent.com/u/5387680?v=4","gravatar_id":"","url":"https://api.github.com/users/gundermanc","html_url":"https://github.com/gundermanc","followers_url":"https://api.github.com/users/gundermanc/followers","following_url":"https://api.github.com/users/gundermanc/following{/other_user}","gists_url":"https://api.github.com/users/gundermanc/gists{/gist_id}","starred_url":"https://api.github.com/users/gundermanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gundermanc/subscriptions","organizations_url":"https://api.github.com/users/gundermanc/orgs","repos_url":"https://api.github.com/users/gundermanc/repos","events_url":"https://api.github.com/users/gundermanc/events{/privacy}","received_events_url":"https://api.github.com/users/gundermanc/received_events","type":"User","site_admin":false},"body":"Is this Order attribute still needed? From what I can tell, it looks like this previously existed because there were 2 distinct quick info sources for Roslyn (excluding the event hookup case):\r\n\r\n1) Quick Info Controller source: this source would listen for quick info computations, cancel the quick info session, and queue an async computation of the quick info items.\r\n2) Quick Info Presenter source: once the async computation of items had completed, this source is updated with a reference to these items, and quick info is invoked via the quick info broker.\r\n\r\nAs part of your PR, you deleted the Quick Info Presenter source so I think this is no longer needed.","created_at":"2018-03-07T20:38:27Z","updated_at":"2018-03-07T21:05:02Z","html_url":"https://github.com/dotnet/roslyn/pull/25181#discussion_r172976970","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/25181","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/172976970"},"html":{"href":"https://github.com/dotnet/roslyn/pull/25181#discussion_r172976970"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/25181"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/25181","id":172396861,"html_url":"https://github.com/dotnet/roslyn/pull/25181","diff_url":"https://github.com/dotnet/roslyn/pull/25181.diff","patch_url":"https://github.com/dotnet/roslyn/pull/25181.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/25181","number":25181,"state":"open","locked":false,"title":"Migrate to the new async QuickInfo API (Tooltips UI will be fixed in next PR)","user":{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"body":"<details><summary>Migrate to the new async QuickInfo API (Tooltips UI will be fixed in next PR)</summary>\r\n\r\n### Customer scenario\r\nMigrate to the new async QuickInfo API\r\nTooltips UI is currently broken by this change, and will be fixed in the next PR\r\n\r\n### Bugs this fixes\r\nhttps://github.com/dotnet/roslyn/issues/24094\r\n\r\n### Workarounds, if any\r\n\r\nAlso, why we think they are insufficient for RC vs. RC2, RC3, or RTW\r\n\r\n### Risk\r\n\r\nThis is generally a measure our how central the affected code is to adjacent\r\nscenarios and thus how likely your fix is to destabilize a broader area of code\r\n\r\n### Performance impact\r\n\r\n(with a brief justification for that assessment (e.g. \"Low perf impact because no extra allocations/no complexity changes\" vs. \"Low\")\r\n\r\n### Is this a regression from a previous update?\r\n\r\n### Root cause analysis\r\n\r\nHow did we miss it?  What tests are we adding to guard against it in the future?\r\n\r\n### How was the bug found?\r\n\r\n(E.g. customer reported it vs. ad hoc testing)\r\n\r\n### Test documentation updated?\r\n\r\nIf this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.\r\n\r\n</details>\r\n","created_at":"2018-03-02T01:02:06Z","updated_at":"2018-03-07T21:05:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c37d1068f8d861aa664da5b9dbbfee1f857a4ba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars3.githubusercontent.com/u/201340?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"roslyn-ide","id":1781706,"slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/25181/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/25181/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/25181/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/866bb2403121080a02a2907f1a3a94a10b2be12e","head":{"label":"JieCarolHu:quickInfoAsync3","ref":"quickInfoAsync3","sha":"866bb2403121080a02a2907f1a3a94a10b2be12e","user":{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"repo":{"id":117298628,"name":"roslyn","full_name":"JieCarolHu/roslyn","owner":{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JieCarolHu/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/JieCarolHu/roslyn","forks_url":"https://api.github.com/repos/JieCarolHu/roslyn/forks","keys_url":"https://api.github.com/repos/JieCarolHu/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JieCarolHu/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JieCarolHu/roslyn/teams","hooks_url":"https://api.github.com/repos/JieCarolHu/roslyn/hooks","issue_events_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/JieCarolHu/roslyn/events","assignees_url":"https://api.github.com/repos/JieCarolHu/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/JieCarolHu/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/JieCarolHu/roslyn/tags","blobs_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JieCarolHu/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/JieCarolHu/roslyn/languages","stargazers_url":"https://api.github.com/repos/JieCarolHu/roslyn/stargazers","contributors_url":"https://api.github.com/repos/JieCarolHu/roslyn/contributors","subscribers_url":"https://api.github.com/repos/JieCarolHu/roslyn/subscribers","subscription_url":"https://api.github.com/repos/JieCarolHu/roslyn/subscription","commits_url":"https://api.github.com/repos/JieCarolHu/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/JieCarolHu/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/JieCarolHu/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/JieCarolHu/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JieCarolHu/roslyn/merges","archive_url":"https://api.github.com/repos/JieCarolHu/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JieCarolHu/roslyn/downloads","issues_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/JieCarolHu/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/JieCarolHu/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/JieCarolHu/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JieCarolHu/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/JieCarolHu/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/JieCarolHu/roslyn/deployments","created_at":"2018-01-12T23:44:20Z","updated_at":"2018-01-12T23:45:01Z","pushed_at":"2018-03-07T02:11:35Z","git_url":"git://github.com/JieCarolHu/roslyn.git","ssh_url":"git@github.com:JieCarolHu/roslyn.git","clone_url":"https://github.com/JieCarolHu/roslyn.git","svn_url":"https://github.com/JieCarolHu/roslyn","homepage":"","size":293404,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:features/quick-info-party","ref":"features/quick-info-party","sha":"fd64fb213de8e1dbd72d03a1cd0cbf94be108710","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-03-07T20:25:56Z","pushed_at":"2018-03-07T20:47:05Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":305304,"stargazers_count":8950,"watchers_count":8950,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2155,"mirror_url":null,"archived":false,"open_issues_count":4526,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2155,"open_issues":4526,"watchers":8950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/25181"},"html":{"href":"https://github.com/dotnet/roslyn/pull/25181"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/25181"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/25181/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/25181/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/25181/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/866bb2403121080a02a2907f1a3a94a10b2be12e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gundermanc"}}