{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71298","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71298/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71298/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71298/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71298","id":382938183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTI2NTg0","number":71298,"title":"add missing flags in *-controller-manager --help","user":{"login":"stewart-yu","id":30410021,"node_id":"MDQ6VXNlcjMwNDEwMDIx","avatar_url":"https://avatars2.githubusercontent.com/u/30410021?v=4","gravatar_id":"","url":"https://api.github.com/users/stewart-yu","html_url":"https://github.com/stewart-yu","followers_url":"https://api.github.com/users/stewart-yu/followers","following_url":"https://api.github.com/users/stewart-yu/following{/other_user}","gists_url":"https://api.github.com/users/stewart-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/stewart-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewart-yu/subscriptions","organizations_url":"https://api.github.com/users/stewart-yu/orgs","repos_url":"https://api.github.com/users/stewart-yu/repos","events_url":"https://api.github.com/users/stewart-yu/events{/privacy}","received_events_url":"https://api.github.com/users/stewart-yu/received_events","type":"User","site_admin":false},"labels":[{"id":136601536,"node_id":"MDU6TGFiZWwxMzY2MDE1MzY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/apiserver","name":"area/apiserver","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1047217136,"node_id":"MDU6TGFiZWwxMDQ3MjE3MTM2","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-kind","name":"needs-kind","color":"ededed","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"luxas","id":5442475,"node_id":"MDQ6VXNlcjU0NDI0NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},{"login":"luxas","id":5442475,"node_id":"MDQ6VXNlcjU0NDI0NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},{"login":"andrewsykim","id":12699319,"node_id":"MDQ6VXNlcjEyNjk5MzE5","avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-11-21T03:18:40Z","updated_at":"2018-11-21T08:48:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71298","html_url":"https://github.com/kubernetes/kubernetes/pull/71298","diff_url":"https://github.com/kubernetes/kubernetes/pull/71298.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71298.patch"},"body":"**What type of PR is this?**\r\n /kind bug\r\n /kind cleanup\r\n\r\n**What this PR does / why we need it**:\r\nIn #67362 introduce print section part, but seems missing some global flag and `cloud-provider-gce-lb-src-cidrs` flag for *-controller-manager, so we add it in this PR:\r\npart of output:\r\n```\r\nGeneric flags:\r\n\r\n      --allocate-node-cidrs                                                                           \r\n                Should CIDRs for Pods be allocated and set on the cloud provider.\r\n     ....\r\n      --cloud-provider-gce-lb-src-cidrs cidrs                                                         \r\n                CIDRs opened in GCE firewall for LB traffic proxy & health checks (default\r\n                130.211.0.0/22,209.85.152.0/22,209.85.204.0/22,35.191.0.0/16)\r\n      --cluster-cidr string                                                                           \r\n                CIDR Range for Pods in cluster. Requires --allocate-node-cidrs to be true\r\n     .....\r\n\r\nGlobal flags:\r\n\r\n      --alsologtostderr                                                                               \r\n                log to standard error as well as files\r\n  -h, --help                                                                                          \r\n                help for kube-controller-manager\r\n      --log-backtrace-at traceLocation                                                                \r\n                when logging hits line file:N, emit a stack trace (default :0)\r\n      --log-dir string                                                                                \r\n                If non-empty, write log files in this directory\r\n      --log-file string                                                                               \r\n                If non-empty, use this log file\r\n      --log-flush-frequency duration                                                                  \r\n                Maximum number of seconds between log flushes (default 5s)\r\n      --logtostderr                                                                                   \r\n                log to standard error instead of files (default true)\r\n      --skip-headers                                                                                  \r\n                If true, avoid header prefixes in the log messages\r\n      --stderrthreshold severity                                                                      \r\n                logs at or above this threshold go to stderr (default 2)\r\n  -v, --v Level                                                                                       \r\n                log level for V logs\r\n      --version version[=true]                                                                        \r\n                Print version information and quit\r\n      --vmodule moduleSpec                                                                            \r\n                comma-separated list of pattern=N settings for file-filtered loggin\r\n```\r\n\r\nSimilar to #70205 and #70216 \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\nxresf #70145\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nFix missing flags in *-controller-manager --help.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/440583679","html_url":"https://github.com/kubernetes/kubernetes/pull/71298#issuecomment-440583679","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71298","id":440583679,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDU4MzY3OQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T08:48:35Z","updated_at":"2018-11-21T08:48:35Z","author_association":"CONTRIBUTOR","body":"@stewart-yu: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-build | 93f40bd859557398133cac70384cb4c3aa48c960 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71298/pull-kubernetes-bazel-build/65801/) | `/test pull-kubernetes-bazel-build`\n\n[Full PR test history](https://gubernator.k8s.io/pr/71298). [Your PR dashboard](https://gubernator.k8s.io/pr/stewart-yu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}