{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/216116963","pull_request_review_id":153537096,"id":216116963,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjExNjk2Mw==","diff_hunk":"@@ -1277,74 +1279,87 @@ func getMatchingTopologyPairs(pod *v1.Pod, nodeInfoMap map[string]*schedulercach\n \t\t\tcatchError(fmt.Errorf(\"node not found\"))\n \t\t\treturn\n \t\t}\n-\t\tnodeTopologyMaps := newTopologyPairsMaps()\n \t\tfor _, existingPod := range nodeInfo.PodsWithAffinity() {\n-\t\t\taffinity := existingPod.Spec.Affinity\n-\t\t\tif affinity == nil {\n-\t\t\t\tcontinue\n-\t\t\t}\n-\t\t\tfor _, term := range GetPodAntiAffinityTerms(affinity.PodAntiAffinity) {\n-\t\t\t\tnamespaces := priorityutil.GetNamespacesFromPodAffinityTerm(existingPod, &term)\n-\t\t\t\tselector, err := metav1.LabelSelectorAsSelector(term.LabelSelector)\n-\t\t\t\tif err != nil {\n-\t\t\t\t\tcatchError(err)\n-\t\t\t\t\treturn\n-\t\t\t\t}\n-\t\t\t\tif priorityutil.PodMatchesTermsNamespaceAndSelector(pod, namespaces, selector) {\n-\t\t\t\t\tif topologyValue, ok := node.Labels[term.TopologyKey]; ok {\n-\t\t\t\t\t\tpair := topologyPair{key: term.TopologyKey, value: topologyValue}\n-\t\t\t\t\t\tnodeTopologyMaps.addTopologyPair(pair, existingPod)\n-\t\t\t\t\t}\n-\t\t\t\t}\n+\t\t\texistingPodTopologyMaps, err := getMatchingTopologyPairsOfExistingPod(pod, existingPod, node)\n+\t\t\tif err != nil {\n+\t\t\t\tcatchError(err)\n+\t\t\t\treturn\n \t\t\t}\n-\t\t\tif len(nodeTopologyMaps.podToTopologyPairs) > 0 {\n-\t\t\t\tappendTopologyPairsMaps(nodeTopologyMaps)\n+\n+\t\t\tif len(existingPodTopologyMaps.podToTopologyPairs) > 0 {\n+\t\t\t\tappendTopologyPairsMaps(existingPodTopologyMaps)\n \t\t\t}\n \t\t}\n \t}\n \tworkqueue.Parallelize(16, len(allNodeNames), processNode)\n \treturn topologyMaps, firstError\n }\n \n+// getMatchingTopologyPairsOfExistingPod is a helper to calculate on each existing pod\n+// of given node, whether (1) it has PodAntiAffinity and (2) AffinityTerms matches incoming pod\n func getMatchingTopologyPairsOfExistingPod(newPod *v1.Pod, existingPod *v1.Pod, node *v1.Node) (*topologyPairsMaps, error) {\n \ttopologyMaps := newTopologyPairsMaps()\n \taffinity := existingPod.Spec.Affinity\n-\tif affinity != nil && affinity.PodAntiAffinity != nil {\n-\t\tfor _, term := range GetPodAntiAffinityTerms(affinity.PodAntiAffinity) {\n-\t\t\tnamespaces := priorityutil.GetNamespacesFromPodAffinityTerm(existingPod, &term)\n-\t\t\tselector, err := metav1.LabelSelectorAsSelector(term.LabelSelector)\n-\t\t\tif err != nil {\n-\t\t\t\treturn nil, err\n-\t\t\t}\n-\t\t\tif priorityutil.PodMatchesTermsNamespaceAndSelector(newPod, namespaces, selector) {\n-\t\t\t\tif topologyValue, ok := node.Labels[term.TopologyKey]; ok {\n-\t\t\t\t\tpair := topologyPair{key: term.TopologyKey, value: topologyValue}\n-\t\t\t\t\ttopologyMaps.addTopologyPair(pair, existingPod)\n-\t\t\t\t}\n-\t\t\t}\n+\tif affinity == nil || affinity.PodAntiAffinity == nil {\n+\t\treturn topologyMaps, nil\n+\t}\n+\n+\tmatchMap := make(map[string]bool) // key is TopologyKey\n+\tterms := GetPodAntiAffinityTerms(affinity.PodAntiAffinity)\n+\tfor _, term := range terms {\n+\t\t// if topologyKey in term is invalid, simply return as terms of existingPod\n+\t\t// have no chance to match labels of incomingPod\n+\t\tif _, ok := node.Labels[term.TopologyKey]; !ok {","path":"pkg/scheduler/algorithm/predicates/predicates.go","position":76,"original_position":76,"commit_id":"00ffe6dc83067b4291e7413d86fa463384b67c52","original_commit_id":"00ffe6dc83067b4291e7413d86fa463384b67c52","user":{"login":"bsalamat","id":14308438,"node_id":"MDQ6VXNlcjE0MzA4NDM4","avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"body":"This is not true. If a term topologyKey does not exist on the node, we should still check that the pod matches the term and other terms. This term does not add any pair to our topology pairs though.","created_at":"2018-09-08T01:47:46Z","updated_at":"2018-09-08T01:47:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/68301#discussion_r216116963","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/216116963"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/68301#discussion_r216116963"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301","id":213386381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzg2Mzgx","html_url":"https://github.com/kubernetes/kubernetes/pull/68301","diff_url":"https://github.com/kubernetes/kubernetes/pull/68301.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68301.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68301","number":68301,"state":"open","locked":false,"title":"Fix symmetrical issues in PodAntiAffinity","user":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n- correct behavior of getMatchingTopologyPairsOfExistingPod() to create topologyPair until all terms match\r\n- dedup code and add some comments\r\n- add unit tests\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #68101\r\n\r\n**Special notes for your reviewer**:\r\nThis is a replacement PR of #68173.\r\n\r\n**Release note**:\r\n```release-note\r\nFix symmetrical issues in PodAntiAffinity.\r\n```\r\n","created_at":"2018-09-05T18:25:42Z","updated_at":"2018-09-08T01:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"097ae8798e8dfbd81a5e2649a1f213b15d0bea43","assignee":{"login":"resouer","id":1701782,"node_id":"MDQ6VXNlcjE3MDE3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1701782?v=4","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"assignees":[{"login":"resouer","id":1701782,"node_id":"MDQ6VXNlcjE3MDE3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1701782?v=4","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"misterikkit","id":1796778,"node_id":"MDQ6VXNlcjE3OTY3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1796778?v=4","gravatar_id":"","url":"https://api.github.com/users/misterikkit","html_url":"https://github.com/misterikkit","followers_url":"https://api.github.com/users/misterikkit/followers","following_url":"https://api.github.com/users/misterikkit/following{/other_user}","gists_url":"https://api.github.com/users/misterikkit/gists{/gist_id}","starred_url":"https://api.github.com/users/misterikkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterikkit/subscriptions","organizations_url":"https://api.github.com/users/misterikkit/orgs","repos_url":"https://api.github.com/users/misterikkit/repos","events_url":"https://api.github.com/users/misterikkit/events{/privacy}","received_events_url":"https://api.github.com/users/misterikkit/received_events","type":"User","site_admin":false},{"login":"davidopp","id":8264113,"node_id":"MDQ6VXNlcjgyNjQxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8264113?v=4","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":114528068,"node_id":"MDU6TGFiZWwxMTQ1MjgwNjg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39","html_url":"https://github.com/kubernetes/kubernetes/milestone/39","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39/labels","id":2913712,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMg==","number":39,"title":"v1.12","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":238,"state":"open","created_at":"2017-11-15T06:32:51Z","updated_at":"2018-09-07T22:59:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68301/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/00ffe6dc83067b4291e7413d86fa463384b67c52","head":{"label":"Huang-Wei:fix-anti-affinity-symmetry-issue","ref":"fix-anti-affinity-symmetry-issue","sha":"00ffe6dc83067b4291e7413d86fa463384b67c52","user":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"repo":{"id":140890403,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4OTA0MDM=","name":"kubernetes","full_name":"Huang-Wei/kubernetes","owner":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Huang-Wei/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/Huang-Wei/kubernetes","forks_url":"https://api.github.com/repos/Huang-Wei/kubernetes/forks","keys_url":"https://api.github.com/repos/Huang-Wei/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Huang-Wei/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Huang-Wei/kubernetes/teams","hooks_url":"https://api.github.com/repos/Huang-Wei/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Huang-Wei/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Huang-Wei/kubernetes/events","assignees_url":"https://api.github.com/repos/Huang-Wei/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Huang-Wei/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Huang-Wei/kubernetes/tags","blobs_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Huang-Wei/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Huang-Wei/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Huang-Wei/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Huang-Wei/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Huang-Wei/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Huang-Wei/kubernetes/subscription","commits_url":"https://api.github.com/repos/Huang-Wei/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Huang-Wei/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Huang-Wei/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Huang-Wei/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Huang-Wei/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Huang-Wei/kubernetes/merges","archive_url":"https://api.github.com/repos/Huang-Wei/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Huang-Wei/kubernetes/downloads","issues_url":"https://api.github.com/repos/Huang-Wei/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Huang-Wei/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Huang-Wei/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Huang-Wei/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Huang-Wei/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Huang-Wei/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Huang-Wei/kubernetes/deployments","created_at":"2018-07-13T20:30:19Z","updated_at":"2018-09-06T05:40:23Z","pushed_at":"2018-09-07T23:00:49Z","git_url":"git://github.com/Huang-Wei/kubernetes.git","ssh_url":"git@github.com:Huang-Wei/kubernetes.git","clone_url":"https://github.com/Huang-Wei/kubernetes.git","svn_url":"https://github.com/Huang-Wei/kubernetes","homepage":"http://kubernetes.io","size":588516,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"26403b758b174a64017651e31ffc782cea730c4a","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-09-08T01:02:07Z","pushed_at":"2018-09-08T01:26:23Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":807844,"stargazers_count":41155,"watchers_count":41155,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14301,"mirror_url":null,"archived":false,"open_issues_count":3128,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14301,"open_issues":3128,"watchers":41155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/68301"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68301"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68301/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68301/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/00ffe6dc83067b4291e7413d86fa463384b67c52"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bsalamat"}}