{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/31989","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/31989/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/31989/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/31989/events","html_url":"https://github.com/dotnet/corefx/pull/31989","id":354507827,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjU0NzMw","number":31989,"title":"Port Fix Icon overflow bug when image entry is a PNG file","user":{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"labels":[{"id":948598575,"node_id":"MDU6TGFiZWw5NDg1OTg1NzU=","url":"https://api.github.com/repos/dotnet/corefx/labels/Servicing-consider","name":"Servicing-consider","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/22","html_url":"https://github.com/dotnet/corefx/milestone/22","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/22/labels","id":3358829,"node_id":"MDk6TWlsZXN0b25lMzM1ODgyOQ==","number":22,"title":"2.1.x","description":".NET Core 2.1 Servicing Updates - https://github.com/dotnet/core/tree/master/release-notes (pending 2.1 final RTW release)","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":129,"state":"open","created_at":"2018-05-19T17:01:49Z","updated_at":"2018-08-30T18:08:00Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-08-27T22:57:13Z","updated_at":"2018-08-30T18:49:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/31989","html_url":"https://github.com/dotnet/corefx/pull/31989","diff_url":"https://github.com/dotnet/corefx/pull/31989.diff","patch_url":"https://github.com/dotnet/corefx/pull/31989.patch"},"body":"Port of PR #31819 -- No issue, internally reported\r\n\r\n**Description**\r\nCurrently in Unix, whenever an Icon has a PNG image under its images and this image doesn't have the width and height == 0 (as the Windows Vista specs states it should be) it blows up. This happens because currently we only check for the width and height to be == 0, but we don't check if the image header signature describes a PNG image. PNG images are special and in Unix when we find a PNG file under the icon entries, we just store the raw bytes so that Icon.Save works. In this case since we are not checking the header signature, we were treating this special cases as a BMP and getting a stack overflow when trying to read the BMP bytes because PNG raw data is way bigger.\r\n\r\n**Customer Impact**\r\nWe had a report from some Microsoft Internal customers that are trying to load icons in Unix using .NET Core and are hitting this.\r\n\r\n**Regresion?**\r\nno\r\n\r\n**Risk**\r\nI don't think there is a big risk here, actually we're adding an extra validation here to not blow up. Plus testing has mitigated the risk.\r\n\r\ncc: @danmosemsft \r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/417427533","html_url":"https://github.com/dotnet/corefx/pull/31989#issuecomment-417427533","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/31989","id":417427533,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzQyNzUzMw==","user":{"login":"jamshedd","id":9440640,"node_id":"MDQ6VXNlcjk0NDA2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9440640?v=4","gravatar_id":"","url":"https://api.github.com/users/jamshedd","html_url":"https://github.com/jamshedd","followers_url":"https://api.github.com/users/jamshedd/followers","following_url":"https://api.github.com/users/jamshedd/following{/other_user}","gists_url":"https://api.github.com/users/jamshedd/gists{/gist_id}","starred_url":"https://api.github.com/users/jamshedd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamshedd/subscriptions","organizations_url":"https://api.github.com/users/jamshedd/orgs","repos_url":"https://api.github.com/users/jamshedd/repos","events_url":"https://api.github.com/users/jamshedd/events{/privacy}","received_events_url":"https://api.github.com/users/jamshedd/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T18:49:22Z","updated_at":"2018-08-30T18:49:22Z","author_association":"NONE","body":"Approved for 2.1.5"}}
{"actor":{"display_login":"jamshedd"}}