{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/console/issues/713","repository_url":"https://api.github.com/repos/openshift/console","labels_url":"https://api.github.com/repos/openshift/console/issues/713/labels{/name}","comments_url":"https://api.github.com/repos/openshift/console/issues/713/comments","events_url":"https://api.github.com/repos/openshift/console/issues/713/events","html_url":"https://github.com/openshift/console/pull/713","id":375093321,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjIwMTA2","number":713,"title":"Persisting Catalog category and filter selections in url","user":{"login":"dtaylor113","id":12733153,"node_id":"MDQ6VXNlcjEyNzMzMTUz","avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"labels":[{"id":926924366,"node_id":"MDU6TGFiZWw5MjY5MjQzNjY=","url":"https://api.github.com/repos/openshift/console/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-29T16:06:35Z","updated_at":"2018-11-12T15:09:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/713","html_url":"https://github.com/openshift/console/pull/713","diff_url":"https://github.com/openshift/console/pull/713.diff","patch_url":"https://github.com/openshift/console/pull/713.patch"},"body":"Catalog category and filter selections are now being persisted in the url.\r\n\r\nEx (using JSON.stringify/JSON.parse for search params):\r\nhttp://0.0.0.0:9001/catalog/ns/default?category=%5B%22languages%22%2C%22dotnet%22%5D&by-type=%5B%22clusterServiceClass%22%2C%22imageStream%22%5D&keyword=ex\r\n\r\nIn general, not happy with hardcoded category levels (2) and filtering by known types (service-class and imagestream).  Hopefully, when #643 merges we can start working on shared catalog utils and support any number of category/subcategory levels, and dynamic filtering categories (ex. by vendor, where vendor filter values are dynamic, gathered from passed in items)."},"comment":{"url":"https://api.github.com/repos/openshift/console/issues/comments/437915314","html_url":"https://github.com/openshift/console/pull/713#issuecomment-437915314","issue_url":"https://api.github.com/repos/openshift/console/issues/713","id":437915314,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzkxNTMxNA==","user":{"login":"jeff-phillips-18","id":11633780,"node_id":"MDQ6VXNlcjExNjMzNzgw","avatar_url":"https://avatars1.githubusercontent.com/u/11633780?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T15:09:12Z","updated_at":"2018-11-12T15:09:12Z","author_association":"MEMBER","body":"The code at https://github.com/openshift/console/pull/713/files#diff-d539d30d1e509584711e060db3e0f849R108 is there to prevent reload on each keystroke. So there should be no performance hit there. It reloads just once on the first URL param change (due to changing from `<LazyRoute>` to `<Route>` once it is loaded)."}}
{"actor":{"display_login":"jeff-phillips-18"}}