{"action":"created","comment":{"url":"https://api.github.com/repos/libgd/libgd/pulls/comments/181649361","pull_request_review_id":112310454,"id":181649361,"diff_hunk":"@@ -1713,8 +1726,26 @@ static void dashedSet (gdImagePtr im, int x, int y, int color,\n \t\t\t\t\t   int *onP, int *dashStepP, int wid, int vert);\n \n /*\n-\tFunction: gdImageDashedLine\n-*/\n+ * Function: gdImageDashedLine\n+ *\n+ * Draws a dashed line\n+ *\n+ * Deprecated:\n+ *   This function has been deprecated as of GD 2.3.0.  Use an appropriate\n+ *   combination of <gdImageLine> and <gdImageSetStyle> instead.\n+ *\n+ * Parameters:\n+ *   im    - The image.\n+ *   x1    - The x-coordinate of the start point.\n+ *   y1    - The y-coordinate of the start point.\n+ *   x2    - The x-coordinate of the end point.\n+ *   y2    - The y-coordinate of the end point.\n+ *   color - The color.\n+ *\n+ * See also:\n+ *   - <gdImageLine>\n+ *   - <gdImageSetStyle>\n+ */\n BGD_DECLARE(void) gdImageDashedLine (gdImagePtr im, int x1, int y1, int x2, int y2, int color)\n {\n \tint dx, dy, incr1, incr2, d, x, y, xend, yend, xdirflag, ydirflag;","path":"src/gd.c","position":56,"original_position":56,"commit_id":"ec28ea65b37ff080cf64fe60992698e271ab2b48","original_commit_id":"ec28ea65b37ff080cf64fe60992698e271ab2b48","user":{"login":"vapier","id":176950,"avatar_url":"https://avatars3.githubusercontent.com/u/176950?v=4","gravatar_id":"","url":"https://api.github.com/users/vapier","html_url":"https://github.com/vapier","followers_url":"https://api.github.com/users/vapier/followers","following_url":"https://api.github.com/users/vapier/following{/other_user}","gists_url":"https://api.github.com/users/vapier/gists{/gist_id}","starred_url":"https://api.github.com/users/vapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapier/subscriptions","organizations_url":"https://api.github.com/users/vapier/orgs","repos_url":"https://api.github.com/users/vapier/repos","events_url":"https://api.github.com/users/vapier/events{/privacy}","received_events_url":"https://api.github.com/users/vapier/received_events","type":"User","site_admin":false},"body":"seems like we should be able to gut this function and make it call `gdImageLine` & `gdImageSetStyle` ?  it'd simplify, shrink the code (compiled & source), and be a stronger proof that this func is indeed fully redundant with those other two.","created_at":"2018-04-16T07:57:48Z","updated_at":"2018-04-16T08:00:00Z","html_url":"https://github.com/libgd/libgd/pull/438#discussion_r181649361","pull_request_url":"https://api.github.com/repos/libgd/libgd/pulls/438","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libgd/libgd/pulls/comments/181649361"},"html":{"href":"https://github.com/libgd/libgd/pull/438#discussion_r181649361"},"pull_request":{"href":"https://api.github.com/repos/libgd/libgd/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/libgd/libgd/pulls/438","id":179693690,"html_url":"https://github.com/libgd/libgd/pull/438","diff_url":"https://github.com/libgd/libgd/pull/438.diff","patch_url":"https://github.com/libgd/libgd/pull/438.patch","issue_url":"https://api.github.com/repos/libgd/libgd/issues/438","number":438,"state":"open","locked":false,"title":"Close #435: Deprecate gdImageDashedLine()","user":{"login":"cmb69","id":2306138,"avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"body":"`gdImageDashedLine()` is a legacy from GD 1, and has been superseded\r\nby the more flexible `gdImageLine()` in combination with\r\n`gdImageSetStyle()`.  We therefore deprecate `gdImageDashedLine()`:\r\n\r\n* document the deprecation\r\n* raise a compile time warning for supporting compilers\r\n* raise a GD_NOTICE whenever the function is called","created_at":"2018-04-05T14:27:15Z","updated_at":"2018-04-16T08:00:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c54d269dad3a9e017824a5218890cb1aca7f7425","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libgd/libgd/pulls/438/commits","review_comments_url":"https://api.github.com/repos/libgd/libgd/pulls/438/comments","review_comment_url":"https://api.github.com/repos/libgd/libgd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgd/libgd/issues/438/comments","statuses_url":"https://api.github.com/repos/libgd/libgd/statuses/ec28ea65b37ff080cf64fe60992698e271ab2b48","head":{"label":"cmb69:deprecate-gdImageDashedLine","ref":"deprecate-gdImageDashedLine","sha":"ec28ea65b37ff080cf64fe60992698e271ab2b48","user":{"login":"cmb69","id":2306138,"avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"repo":{"id":60856754,"name":"libgd","full_name":"cmb69/libgd","owner":{"login":"cmb69","id":2306138,"avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmb69/libgd","description":"GD Graphics Library","fork":true,"url":"https://api.github.com/repos/cmb69/libgd","forks_url":"https://api.github.com/repos/cmb69/libgd/forks","keys_url":"https://api.github.com/repos/cmb69/libgd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmb69/libgd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmb69/libgd/teams","hooks_url":"https://api.github.com/repos/cmb69/libgd/hooks","issue_events_url":"https://api.github.com/repos/cmb69/libgd/issues/events{/number}","events_url":"https://api.github.com/repos/cmb69/libgd/events","assignees_url":"https://api.github.com/repos/cmb69/libgd/assignees{/user}","branches_url":"https://api.github.com/repos/cmb69/libgd/branches{/branch}","tags_url":"https://api.github.com/repos/cmb69/libgd/tags","blobs_url":"https://api.github.com/repos/cmb69/libgd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmb69/libgd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmb69/libgd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmb69/libgd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmb69/libgd/statuses/{sha}","languages_url":"https://api.github.com/repos/cmb69/libgd/languages","stargazers_url":"https://api.github.com/repos/cmb69/libgd/stargazers","contributors_url":"https://api.github.com/repos/cmb69/libgd/contributors","subscribers_url":"https://api.github.com/repos/cmb69/libgd/subscribers","subscription_url":"https://api.github.com/repos/cmb69/libgd/subscription","commits_url":"https://api.github.com/repos/cmb69/libgd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmb69/libgd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmb69/libgd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmb69/libgd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmb69/libgd/contents/{+path}","compare_url":"https://api.github.com/repos/cmb69/libgd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmb69/libgd/merges","archive_url":"https://api.github.com/repos/cmb69/libgd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmb69/libgd/downloads","issues_url":"https://api.github.com/repos/cmb69/libgd/issues{/number}","pulls_url":"https://api.github.com/repos/cmb69/libgd/pulls{/number}","milestones_url":"https://api.github.com/repos/cmb69/libgd/milestones{/number}","notifications_url":"https://api.github.com/repos/cmb69/libgd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmb69/libgd/labels{/name}","releases_url":"https://api.github.com/repos/cmb69/libgd/releases{/id}","deployments_url":"https://api.github.com/repos/cmb69/libgd/deployments","created_at":"2016-06-10T15:11:37Z","updated_at":"2018-04-05T14:25:33Z","pushed_at":"2018-04-05T14:26:33Z","git_url":"git://github.com/cmb69/libgd.git","ssh_url":"git@github.com:cmb69/libgd.git","clone_url":"https://github.com/cmb69/libgd.git","svn_url":"https://github.com/cmb69/libgd","homepage":"http://libgd.org","size":23023,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libgd:master","ref":"master","sha":"7f1b92b461618b2e8c59ba48082d6e93c46bef53","user":{"login":"libgd","id":10650789,"avatar_url":"https://avatars1.githubusercontent.com/u/10650789?v=4","gravatar_id":"","url":"https://api.github.com/users/libgd","html_url":"https://github.com/libgd","followers_url":"https://api.github.com/users/libgd/followers","following_url":"https://api.github.com/users/libgd/following{/other_user}","gists_url":"https://api.github.com/users/libgd/gists{/gist_id}","starred_url":"https://api.github.com/users/libgd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgd/subscriptions","organizations_url":"https://api.github.com/users/libgd/orgs","repos_url":"https://api.github.com/users/libgd/repos","events_url":"https://api.github.com/users/libgd/events{/privacy}","received_events_url":"https://api.github.com/users/libgd/received_events","type":"Organization","site_admin":false},"repo":{"id":29669711,"name":"libgd","full_name":"libgd/libgd","owner":{"login":"libgd","id":10650789,"avatar_url":"https://avatars1.githubusercontent.com/u/10650789?v=4","gravatar_id":"","url":"https://api.github.com/users/libgd","html_url":"https://github.com/libgd","followers_url":"https://api.github.com/users/libgd/followers","following_url":"https://api.github.com/users/libgd/following{/other_user}","gists_url":"https://api.github.com/users/libgd/gists{/gist_id}","starred_url":"https://api.github.com/users/libgd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgd/subscriptions","organizations_url":"https://api.github.com/users/libgd/orgs","repos_url":"https://api.github.com/users/libgd/repos","events_url":"https://api.github.com/users/libgd/events{/privacy}","received_events_url":"https://api.github.com/users/libgd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgd/libgd","description":"GD Graphics Library","fork":false,"url":"https://api.github.com/repos/libgd/libgd","forks_url":"https://api.github.com/repos/libgd/libgd/forks","keys_url":"https://api.github.com/repos/libgd/libgd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgd/libgd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgd/libgd/teams","hooks_url":"https://api.github.com/repos/libgd/libgd/hooks","issue_events_url":"https://api.github.com/repos/libgd/libgd/issues/events{/number}","events_url":"https://api.github.com/repos/libgd/libgd/events","assignees_url":"https://api.github.com/repos/libgd/libgd/assignees{/user}","branches_url":"https://api.github.com/repos/libgd/libgd/branches{/branch}","tags_url":"https://api.github.com/repos/libgd/libgd/tags","blobs_url":"https://api.github.com/repos/libgd/libgd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgd/libgd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgd/libgd/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgd/libgd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgd/libgd/statuses/{sha}","languages_url":"https://api.github.com/repos/libgd/libgd/languages","stargazers_url":"https://api.github.com/repos/libgd/libgd/stargazers","contributors_url":"https://api.github.com/repos/libgd/libgd/contributors","subscribers_url":"https://api.github.com/repos/libgd/libgd/subscribers","subscription_url":"https://api.github.com/repos/libgd/libgd/subscription","commits_url":"https://api.github.com/repos/libgd/libgd/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgd/libgd/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgd/libgd/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgd/libgd/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgd/libgd/contents/{+path}","compare_url":"https://api.github.com/repos/libgd/libgd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgd/libgd/merges","archive_url":"https://api.github.com/repos/libgd/libgd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgd/libgd/downloads","issues_url":"https://api.github.com/repos/libgd/libgd/issues{/number}","pulls_url":"https://api.github.com/repos/libgd/libgd/pulls{/number}","milestones_url":"https://api.github.com/repos/libgd/libgd/milestones{/number}","notifications_url":"https://api.github.com/repos/libgd/libgd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgd/libgd/labels{/name}","releases_url":"https://api.github.com/repos/libgd/libgd/releases{/id}","deployments_url":"https://api.github.com/repos/libgd/libgd/deployments","created_at":"2015-01-22T08:50:57Z","updated_at":"2018-04-09T19:18:26Z","pushed_at":"2018-04-05T14:47:36Z","git_url":"git://github.com/libgd/libgd.git","ssh_url":"git@github.com:libgd/libgd.git","clone_url":"https://github.com/libgd/libgd.git","svn_url":"https://github.com/libgd/libgd","homepage":"http://libgd.org","size":23165,"stargazers_count":331,"watchers_count":331,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":122,"open_issues":103,"watchers":331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgd/libgd/pulls/438"},"html":{"href":"https://github.com/libgd/libgd/pull/438"},"issue":{"href":"https://api.github.com/repos/libgd/libgd/issues/438"},"comments":{"href":"https://api.github.com/repos/libgd/libgd/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/libgd/libgd/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/libgd/libgd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgd/libgd/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/libgd/libgd/statuses/ec28ea65b37ff080cf64fe60992698e271ab2b48"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vapier"}}