{"action":"closed","number":8429,"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/8429","id":203383351,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzgzMzUx","html_url":"https://github.com/python/cpython/pull/8429","diff_url":"https://github.com/python/cpython/pull/8429.diff","patch_url":"https://github.com/python/cpython/pull/8429.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/8429","number":8429,"state":"closed","locked":false,"title":"bpo-34198: Additional encoding options to tkinter.filedialog","user":{"login":"naritotakizawa","id":28292340,"node_id":"MDQ6VXNlcjI4MjkyMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/28292340?v=4","gravatar_id":"","url":"https://api.github.com/users/naritotakizawa","html_url":"https://github.com/naritotakizawa","followers_url":"https://api.github.com/users/naritotakizawa/followers","following_url":"https://api.github.com/users/naritotakizawa/following{/other_user}","gists_url":"https://api.github.com/users/naritotakizawa/gists{/gist_id}","starred_url":"https://api.github.com/users/naritotakizawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naritotakizawa/subscriptions","organizations_url":"https://api.github.com/users/naritotakizawa/orgs","repos_url":"https://api.github.com/users/naritotakizawa/repos","events_url":"https://api.github.com/users/naritotakizawa/events{/privacy}","received_events_url":"https://api.github.com/users/naritotakizawa/received_events","type":"User","site_admin":false},"body":"These call builtin `open`, but don't have encoding args.\r\n- `askopenfile`\r\n- `askopenfiles`\r\n- `asksaveasfile`\r\n\r\n\r\nIn many Windows environments it will write as follows:\r\n```\r\nfile_path = filedialog.askopenfilename()\r\nfile = open(file_path, 'r', encoding='utf-8')\r\nprint(file.read())\r\n```\r\n\r\nI want to write as follows:\r\n```\r\nfile = filedialog.askopenfile('r', encoding='utf-8')\r\nprint(file.read())\r\n```\r\n\r\n<!-- issue-number: bpo-34198 -->\r\nhttps://bugs.python.org/issue34198\r\n<!-- /issue-number -->\r\n","created_at":"2018-07-24T01:06:15Z","updated_at":"2018-10-29T01:57:50Z","closed_at":"2018-10-29T01:57:50Z","merged_at":null,"merge_commit_sha":"0674a44859dfb2ebaa9c25a1b0858bda28f8fc6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979821,"node_id":"MDU6TGFiZWw2NjY5Nzk4MjE=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/8429/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/8429/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/8429/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/2a734c51f389b8831f6eef6dcd8d770e801a442c","head":{"label":"naritotakizawa:fix-issue-34198","ref":"fix-issue-34198","sha":"2a734c51f389b8831f6eef6dcd8d770e801a442c","user":{"login":"naritotakizawa","id":28292340,"node_id":"MDQ6VXNlcjI4MjkyMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/28292340?v=4","gravatar_id":"","url":"https://api.github.com/users/naritotakizawa","html_url":"https://github.com/naritotakizawa","followers_url":"https://api.github.com/users/naritotakizawa/followers","following_url":"https://api.github.com/users/naritotakizawa/following{/other_user}","gists_url":"https://api.github.com/users/naritotakizawa/gists{/gist_id}","starred_url":"https://api.github.com/users/naritotakizawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naritotakizawa/subscriptions","organizations_url":"https://api.github.com/users/naritotakizawa/orgs","repos_url":"https://api.github.com/users/naritotakizawa/repos","events_url":"https://api.github.com/users/naritotakizawa/events{/privacy}","received_events_url":"https://api.github.com/users/naritotakizawa/received_events","type":"User","site_admin":false},"repo":{"id":142007006,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwMDcwMDY=","name":"cpython","full_name":"naritotakizawa/cpython","private":false,"owner":{"login":"naritotakizawa","id":28292340,"node_id":"MDQ6VXNlcjI4MjkyMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/28292340?v=4","gravatar_id":"","url":"https://api.github.com/users/naritotakizawa","html_url":"https://github.com/naritotakizawa","followers_url":"https://api.github.com/users/naritotakizawa/followers","following_url":"https://api.github.com/users/naritotakizawa/following{/other_user}","gists_url":"https://api.github.com/users/naritotakizawa/gists{/gist_id}","starred_url":"https://api.github.com/users/naritotakizawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naritotakizawa/subscriptions","organizations_url":"https://api.github.com/users/naritotakizawa/orgs","repos_url":"https://api.github.com/users/naritotakizawa/repos","events_url":"https://api.github.com/users/naritotakizawa/events{/privacy}","received_events_url":"https://api.github.com/users/naritotakizawa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/naritotakizawa/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/naritotakizawa/cpython","forks_url":"https://api.github.com/repos/naritotakizawa/cpython/forks","keys_url":"https://api.github.com/repos/naritotakizawa/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naritotakizawa/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naritotakizawa/cpython/teams","hooks_url":"https://api.github.com/repos/naritotakizawa/cpython/hooks","issue_events_url":"https://api.github.com/repos/naritotakizawa/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/naritotakizawa/cpython/events","assignees_url":"https://api.github.com/repos/naritotakizawa/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/naritotakizawa/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/naritotakizawa/cpython/tags","blobs_url":"https://api.github.com/repos/naritotakizawa/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naritotakizawa/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naritotakizawa/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/naritotakizawa/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naritotakizawa/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/naritotakizawa/cpython/languages","stargazers_url":"https://api.github.com/repos/naritotakizawa/cpython/stargazers","contributors_url":"https://api.github.com/repos/naritotakizawa/cpython/contributors","subscribers_url":"https://api.github.com/repos/naritotakizawa/cpython/subscribers","subscription_url":"https://api.github.com/repos/naritotakizawa/cpython/subscription","commits_url":"https://api.github.com/repos/naritotakizawa/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/naritotakizawa/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/naritotakizawa/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/naritotakizawa/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/naritotakizawa/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/naritotakizawa/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naritotakizawa/cpython/merges","archive_url":"https://api.github.com/repos/naritotakizawa/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naritotakizawa/cpython/downloads","issues_url":"https://api.github.com/repos/naritotakizawa/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/naritotakizawa/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/naritotakizawa/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/naritotakizawa/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naritotakizawa/cpython/labels{/name}","releases_url":"https://api.github.com/repos/naritotakizawa/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/naritotakizawa/cpython/deployments","created_at":"2018-07-23T11:48:43Z","updated_at":"2018-07-23T11:49:07Z","pushed_at":"2018-07-24T02:45:25Z","git_url":"git://github.com/naritotakizawa/cpython.git","ssh_url":"git@github.com:naritotakizawa/cpython.git","clone_url":"https://github.com/naritotakizawa/cpython.git","svn_url":"https://github.com/naritotakizawa/cpython","homepage":"https://www.python.org/","size":244031,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"bde782bb594edffeabe978abeee2b7082ab9bc2a","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-10-29T00:45:28Z","pushed_at":"2018-10-29T01:51:46Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":253943,"stargazers_count":20526,"watchers_count":20526,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7426,"mirror_url":null,"archived":false,"open_issues_count":931,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7426,"open_issues":931,"watchers":20526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/8429"},"html":{"href":"https://github.com/python/cpython/pull/8429"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/8429"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/8429/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/8429/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/8429/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/2a734c51f389b8831f6eef6dcd8d770e801a442c"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":7,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"naritotakizawa"}}