{"action":"created","comment":{"url":"https://api.github.com/repos/tripal/tripal/pulls/comments/245129749","pull_request_review_id":189178432,"id":245129749,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTEyOTc0OQ==","diff_hunk":"@@ -1139,6 +1156,38 @@ function tripal_chado_field_storage_bundle_mapping_form_summary(&$form, &$form_s\n     ];\n   }\n \n+  //\n+  // Add the row for cvterm options\n+  //\n+  if ($default['use_cvterm']) {\n+    $message = 'No. All records belong to a single controlled vocabulary.';\n+    if ($default['use_cvterm'] == 'parent') {\n+      $message = 'Yes. Records should include all child records of the specified term.';","path":"tripal_chado/includes/tripal_chado.field_storage.inc","position":50,"original_position":50,"commit_id":"17e4d18f6e44d649d616a0a8be855859a7ff60c6","original_commit_id":"17e4d18f6e44d649d616a0a8be855859a7ff60c6","user":{"login":"bradfordcondon","id":7063154,"node_id":"MDQ6VXNlcjcwNjMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7063154?v=4","gravatar_id":"","url":"https://api.github.com/users/bradfordcondon","html_url":"https://github.com/bradfordcondon","followers_url":"https://api.github.com/users/bradfordcondon/followers","following_url":"https://api.github.com/users/bradfordcondon/following{/other_user}","gists_url":"https://api.github.com/users/bradfordcondon/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfordcondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfordcondon/subscriptions","organizations_url":"https://api.github.com/users/bradfordcondon/orgs","repos_url":"https://api.github.com/users/bradfordcondon/repos","events_url":"https://api.github.com/users/bradfordcondon/events{/privacy}","received_events_url":"https://api.github.com/users/bradfordcondon/received_events","type":"User","site_admin":false},"body":"I think I see what direction this is headed in, but does it really make sense to include?  Is the use case something like having a \"branch\" of a CV dedicated to user-submitted terms?  Is that really the right solution as opposed to a user-specific CV (which would be the other case)?\r\n\r\nIf theres not a good use for this alternate schema i propose dropping.","created_at":"2019-01-03T20:53:26Z","updated_at":"2019-01-03T20:53:26Z","html_url":"https://github.com/tripal/tripal/pull/814#discussion_r245129749","pull_request_url":"https://api.github.com/repos/tripal/tripal/pulls/814","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tripal/tripal/pulls/comments/245129749"},"html":{"href":"https://github.com/tripal/tripal/pull/814#discussion_r245129749"},"pull_request":{"href":"https://api.github.com/repos/tripal/tripal/pulls/814"}}},"pull_request":{"url":"https://api.github.com/repos/tripal/tripal/pulls/814","id":242065317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDY1MzE3","html_url":"https://github.com/tripal/tripal/pull/814","diff_url":"https://github.com/tripal/tripal/pull/814.diff","patch_url":"https://github.com/tripal/tripal/pull/814.patch","issue_url":"https://api.github.com/repos/tripal/tripal/issues/814","number":814,"state":"open","locked":false,"title":" Unable to create cvterm-based content type","user":{"login":"laceysanderson","id":1566301,"node_id":"MDQ6VXNlcjE1NjYzMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1566301?v=4","gravatar_id":"","url":"https://api.github.com/users/laceysanderson","html_url":"https://github.com/laceysanderson","followers_url":"https://api.github.com/users/laceysanderson/followers","following_url":"https://api.github.com/users/laceysanderson/following{/other_user}","gists_url":"https://api.github.com/users/laceysanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/laceysanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laceysanderson/subscriptions","organizations_url":"https://api.github.com/users/laceysanderson/orgs","repos_url":"https://api.github.com/users/laceysanderson/repos","events_url":"https://api.github.com/users/laceysanderson/events{/privacy}","received_events_url":"https://api.github.com/users/laceysanderson/received_events","type":"User","site_admin":false},"body":"# Bug Fix\r\n\r\nIssue #813 \r\n\r\n## Description\r\nOriginally I got a WSOD when I trying to create a content type where the base table is cvterm. This was caused by a missing function (`tripal_chado_field_storage_bundle_mapping_form_add_cvterm`) which generates the options for a cvterm content type. Additionally, cvterm logic had been removed from the whole process. This PR brings back this functionality.\r\n\r\n## Testing?\r\n\r\nAttempt to create as content type where the base table is cvterm and...\r\n### All records in a cv become pages of the selected type.\r\n1. Go to Admin > Structure > Tripal Content Types > Add Tripal Content Type\r\n2. **Step 1:** choose any term (e.g. \"Trait\")\r\n3. **Step 2:** storage method is chado\r\n4. **Step 3:** \r\n        - chado table: cvterm; \r\n        - Select \"All records that belong to a single controlled vocabulary \"\r\n        - Select any cv with terms.\r\n5. Click \"Create content type\"\r\n\r\nOn 7.x-3.x you would see a blank screen after clicking continue with \"cvterm\" chosen as the chado table. On this branch you will be able to create the content type.\r\n\r\n## Known Limitations\r\nChoosing \"All child records of the specified term\" is still not supported as I do not know the storage arguments needed for this. @spficklin do you know what they should be?","created_at":"2019-01-03T17:48:16Z","updated_at":"2019-01-03T20:53:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6c7b9246c7748fe5b89650ad4f78b707d503a09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":261706545,"node_id":"MDU6TGFiZWwyNjE3MDY1NDU=","url":"https://api.github.com/repos/tripal/tripal/labels/bug","name":"bug","color":"b60205","default":true},{"id":573232953,"node_id":"MDU6TGFiZWw1NzMyMzI5NTM=","url":"https://api.github.com/repos/tripal/tripal/labels/tripal-7.x-3.x","name":"tripal-7.x-3.x","color":"ffffff","default":false}],"milestone":{"url":"https://api.github.com/repos/tripal/tripal/milestones/2","html_url":"https://github.com/tripal/tripal/milestone/2","labels_url":"https://api.github.com/repos/tripal/tripal/milestones/2/labels","id":3678267,"node_id":"MDk6TWlsZXN0b25lMzY3ODI2Nw==","number":2,"title":"7.x-3.1","description":"Tripal 3 Release","creator":{"login":"bradfordcondon","id":7063154,"node_id":"MDQ6VXNlcjcwNjMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7063154?v=4","gravatar_id":"","url":"https://api.github.com/users/bradfordcondon","html_url":"https://github.com/bradfordcondon","followers_url":"https://api.github.com/users/bradfordcondon/followers","following_url":"https://api.github.com/users/bradfordcondon/following{/other_user}","gists_url":"https://api.github.com/users/bradfordcondon/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfordcondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfordcondon/subscriptions","organizations_url":"https://api.github.com/users/bradfordcondon/orgs","repos_url":"https://api.github.com/users/bradfordcondon/repos","events_url":"https://api.github.com/users/bradfordcondon/events{/privacy}","received_events_url":"https://api.github.com/users/bradfordcondon/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":30,"state":"open","created_at":"2018-09-21T16:08:28Z","updated_at":"2019-01-03T17:48:16Z","due_on":"2018-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/tripal/tripal/pulls/814/commits","review_comments_url":"https://api.github.com/repos/tripal/tripal/pulls/814/comments","review_comment_url":"https://api.github.com/repos/tripal/tripal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tripal/tripal/issues/814/comments","statuses_url":"https://api.github.com/repos/tripal/tripal/statuses/17e4d18f6e44d649d616a0a8be855859a7ff60c6","head":{"label":"tripal:813-cvterm_entitytype","ref":"813-cvterm_entitytype","sha":"17e4d18f6e44d649d616a0a8be855859a7ff60c6","user":{"login":"tripal","id":14332698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzMyNjk4","avatar_url":"https://avatars1.githubusercontent.com/u/14332698?v=4","gravatar_id":"","url":"https://api.github.com/users/tripal","html_url":"https://github.com/tripal","followers_url":"https://api.github.com/users/tripal/followers","following_url":"https://api.github.com/users/tripal/following{/other_user}","gists_url":"https://api.github.com/users/tripal/gists{/gist_id}","starred_url":"https://api.github.com/users/tripal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tripal/subscriptions","organizations_url":"https://api.github.com/users/tripal/orgs","repos_url":"https://api.github.com/users/tripal/repos","events_url":"https://api.github.com/users/tripal/events{/privacy}","received_events_url":"https://api.github.com/users/tripal/received_events","type":"Organization","site_admin":false},"repo":{"id":42666405,"node_id":"MDEwOlJlcG9zaXRvcnk0MjY2NjQwNQ==","name":"tripal","full_name":"tripal/tripal","private":false,"owner":{"login":"tripal","id":14332698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzMyNjk4","avatar_url":"https://avatars1.githubusercontent.com/u/14332698?v=4","gravatar_id":"","url":"https://api.github.com/users/tripal","html_url":"https://github.com/tripal","followers_url":"https://api.github.com/users/tripal/followers","following_url":"https://api.github.com/users/tripal/following{/other_user}","gists_url":"https://api.github.com/users/tripal/gists{/gist_id}","starred_url":"https://api.github.com/users/tripal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tripal/subscriptions","organizations_url":"https://api.github.com/users/tripal/orgs","repos_url":"https://api.github.com/users/tripal/repos","events_url":"https://api.github.com/users/tripal/events{/privacy}","received_events_url":"https://api.github.com/users/tripal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tripal/tripal","description":"The Tripal package is  a suite of Drupal modules for creating biological (genomic, genetic, breeding) websites. Visit the Tripal homepage at http://tripal.info for documentation, support, and other information.  The Drupal project page is at http://drupal.org/project/tripal.","fork":false,"url":"https://api.github.com/repos/tripal/tripal","forks_url":"https://api.github.com/repos/tripal/tripal/forks","keys_url":"https://api.github.com/repos/tripal/tripal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tripal/tripal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tripal/tripal/teams","hooks_url":"https://api.github.com/repos/tripal/tripal/hooks","issue_events_url":"https://api.github.com/repos/tripal/tripal/issues/events{/number}","events_url":"https://api.github.com/repos/tripal/tripal/events","assignees_url":"https://api.github.com/repos/tripal/tripal/assignees{/user}","branches_url":"https://api.github.com/repos/tripal/tripal/branches{/branch}","tags_url":"https://api.github.com/repos/tripal/tripal/tags","blobs_url":"https://api.github.com/repos/tripal/tripal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tripal/tripal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tripal/tripal/git/refs{/sha}","trees_url":"https://api.github.com/repos/tripal/tripal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tripal/tripal/statuses/{sha}","languages_url":"https://api.github.com/repos/tripal/tripal/languages","stargazers_url":"https://api.github.com/repos/tripal/tripal/stargazers","contributors_url":"https://api.github.com/repos/tripal/tripal/contributors","subscribers_url":"https://api.github.com/repos/tripal/tripal/subscribers","subscription_url":"https://api.github.com/repos/tripal/tripal/subscription","commits_url":"https://api.github.com/repos/tripal/tripal/commits{/sha}","git_commits_url":"https://api.github.com/repos/tripal/tripal/git/commits{/sha}","comments_url":"https://api.github.com/repos/tripal/tripal/comments{/number}","issue_comment_url":"https://api.github.com/repos/tripal/tripal/issues/comments{/number}","contents_url":"https://api.github.com/repos/tripal/tripal/contents/{+path}","compare_url":"https://api.github.com/repos/tripal/tripal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tripal/tripal/merges","archive_url":"https://api.github.com/repos/tripal/tripal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tripal/tripal/downloads","issues_url":"https://api.github.com/repos/tripal/tripal/issues{/number}","pulls_url":"https://api.github.com/repos/tripal/tripal/pulls{/number}","milestones_url":"https://api.github.com/repos/tripal/tripal/milestones{/number}","notifications_url":"https://api.github.com/repos/tripal/tripal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tripal/tripal/labels{/name}","releases_url":"https://api.github.com/repos/tripal/tripal/releases{/id}","deployments_url":"https://api.github.com/repos/tripal/tripal/deployments","created_at":"2015-09-17T16:04:23Z","updated_at":"2019-01-03T15:31:30Z","pushed_at":"2019-01-03T20:42:57Z","git_url":"git://github.com/tripal/tripal.git","ssh_url":"git@github.com:tripal/tripal.git","clone_url":"https://github.com/tripal/tripal.git","svn_url":"https://github.com/tripal/tripal","homepage":"","size":34195,"stargazers_count":31,"watchers_count":31,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":29,"open_issues":147,"watchers":31,"default_branch":"7.x-3.x"}},"base":{"label":"tripal:7.x-3.x","ref":"7.x-3.x","sha":"32264515df93d61bc2318bfaf73e7c81eaf8ab7b","user":{"login":"tripal","id":14332698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzMyNjk4","avatar_url":"https://avatars1.githubusercontent.com/u/14332698?v=4","gravatar_id":"","url":"https://api.github.com/users/tripal","html_url":"https://github.com/tripal","followers_url":"https://api.github.com/users/tripal/followers","following_url":"https://api.github.com/users/tripal/following{/other_user}","gists_url":"https://api.github.com/users/tripal/gists{/gist_id}","starred_url":"https://api.github.com/users/tripal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tripal/subscriptions","organizations_url":"https://api.github.com/users/tripal/orgs","repos_url":"https://api.github.com/users/tripal/repos","events_url":"https://api.github.com/users/tripal/events{/privacy}","received_events_url":"https://api.github.com/users/tripal/received_events","type":"Organization","site_admin":false},"repo":{"id":42666405,"node_id":"MDEwOlJlcG9zaXRvcnk0MjY2NjQwNQ==","name":"tripal","full_name":"tripal/tripal","private":false,"owner":{"login":"tripal","id":14332698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzMyNjk4","avatar_url":"https://avatars1.githubusercontent.com/u/14332698?v=4","gravatar_id":"","url":"https://api.github.com/users/tripal","html_url":"https://github.com/tripal","followers_url":"https://api.github.com/users/tripal/followers","following_url":"https://api.github.com/users/tripal/following{/other_user}","gists_url":"https://api.github.com/users/tripal/gists{/gist_id}","starred_url":"https://api.github.com/users/tripal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tripal/subscriptions","organizations_url":"https://api.github.com/users/tripal/orgs","repos_url":"https://api.github.com/users/tripal/repos","events_url":"https://api.github.com/users/tripal/events{/privacy}","received_events_url":"https://api.github.com/users/tripal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tripal/tripal","description":"The Tripal package is  a suite of Drupal modules for creating biological (genomic, genetic, breeding) websites. Visit the Tripal homepage at http://tripal.info for documentation, support, and other information.  The Drupal project page is at http://drupal.org/project/tripal.","fork":false,"url":"https://api.github.com/repos/tripal/tripal","forks_url":"https://api.github.com/repos/tripal/tripal/forks","keys_url":"https://api.github.com/repos/tripal/tripal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tripal/tripal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tripal/tripal/teams","hooks_url":"https://api.github.com/repos/tripal/tripal/hooks","issue_events_url":"https://api.github.com/repos/tripal/tripal/issues/events{/number}","events_url":"https://api.github.com/repos/tripal/tripal/events","assignees_url":"https://api.github.com/repos/tripal/tripal/assignees{/user}","branches_url":"https://api.github.com/repos/tripal/tripal/branches{/branch}","tags_url":"https://api.github.com/repos/tripal/tripal/tags","blobs_url":"https://api.github.com/repos/tripal/tripal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tripal/tripal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tripal/tripal/git/refs{/sha}","trees_url":"https://api.github.com/repos/tripal/tripal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tripal/tripal/statuses/{sha}","languages_url":"https://api.github.com/repos/tripal/tripal/languages","stargazers_url":"https://api.github.com/repos/tripal/tripal/stargazers","contributors_url":"https://api.github.com/repos/tripal/tripal/contributors","subscribers_url":"https://api.github.com/repos/tripal/tripal/subscribers","subscription_url":"https://api.github.com/repos/tripal/tripal/subscription","commits_url":"https://api.github.com/repos/tripal/tripal/commits{/sha}","git_commits_url":"https://api.github.com/repos/tripal/tripal/git/commits{/sha}","comments_url":"https://api.github.com/repos/tripal/tripal/comments{/number}","issue_comment_url":"https://api.github.com/repos/tripal/tripal/issues/comments{/number}","contents_url":"https://api.github.com/repos/tripal/tripal/contents/{+path}","compare_url":"https://api.github.com/repos/tripal/tripal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tripal/tripal/merges","archive_url":"https://api.github.com/repos/tripal/tripal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tripal/tripal/downloads","issues_url":"https://api.github.com/repos/tripal/tripal/issues{/number}","pulls_url":"https://api.github.com/repos/tripal/tripal/pulls{/number}","milestones_url":"https://api.github.com/repos/tripal/tripal/milestones{/number}","notifications_url":"https://api.github.com/repos/tripal/tripal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tripal/tripal/labels{/name}","releases_url":"https://api.github.com/repos/tripal/tripal/releases{/id}","deployments_url":"https://api.github.com/repos/tripal/tripal/deployments","created_at":"2015-09-17T16:04:23Z","updated_at":"2019-01-03T15:31:30Z","pushed_at":"2019-01-03T20:42:57Z","git_url":"git://github.com/tripal/tripal.git","ssh_url":"git@github.com:tripal/tripal.git","clone_url":"https://github.com/tripal/tripal.git","svn_url":"https://github.com/tripal/tripal","homepage":"","size":34195,"stargazers_count":31,"watchers_count":31,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":29,"open_issues":147,"watchers":31,"default_branch":"7.x-3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/tripal/tripal/pulls/814"},"html":{"href":"https://github.com/tripal/tripal/pull/814"},"issue":{"href":"https://api.github.com/repos/tripal/tripal/issues/814"},"comments":{"href":"https://api.github.com/repos/tripal/tripal/issues/814/comments"},"review_comments":{"href":"https://api.github.com/repos/tripal/tripal/pulls/814/comments"},"review_comment":{"href":"https://api.github.com/repos/tripal/tripal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tripal/tripal/pulls/814/commits"},"statuses":{"href":"https://api.github.com/repos/tripal/tripal/statuses/17e4d18f6e44d649d616a0a8be855859a7ff60c6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bradfordcondon"}}