{"action":"created","comment":{"url":"https://api.github.com/repos/hughsie/fwupd/pulls/comments/241062024","pull_request_review_id":184239183,"id":241062024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTA2MjAyNA==","diff_hunk":"@@ -370,12 +370,17 @@ fu_uefi_device_write_firmware (FuDevice *device, GBytes *fw, GError **error)\n static gboolean\n fu_uefi_device_add_system_checksum (FuDevice *device, GError **error)\n {\n-\tconst gchar *fn = \"/sys/class/tpm/tpm0/pcrs\";\n \tg_autofree gchar *buf = NULL;\n \tg_auto(GStrv) lines = NULL;\n \n+\t/* maybe no TPM */\n+\tif (!g_file_test (\"/sys/class/tpm\", G_FILE_TEST_EXISTS)) {\n+\t\tg_debug (\"no TPM device, skipping\");\n+\t\treturn TRUE;\n+\t}\n+\n \t/* get all PCRs */\n-\tif (!g_file_get_contents (fn, &buf, NULL, error))\n+\tif (!g_file_get_contents (\"/sys/class/tpm/tpm0/pcrs\", &buf, NULL, error))","path":"plugins/uefi/fu-uefi-device.c","position":17,"original_position":16,"commit_id":"b70c39cb3086e1917191a787dc9a84fc70405850","original_commit_id":"b70c39cb3086e1917191a787dc9a84fc70405850","user":{"login":"superm1","id":494526,"node_id":"MDQ6VXNlcjQ5NDUyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/494526?v=4","gravatar_id":"","url":"https://api.github.com/users/superm1","html_url":"https://github.com/superm1","followers_url":"https://api.github.com/users/superm1/followers","following_url":"https://api.github.com/users/superm1/following{/other_user}","gists_url":"https://api.github.com/users/superm1/gists{/gist_id}","starred_url":"https://api.github.com/users/superm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superm1/subscriptions","organizations_url":"https://api.github.com/users/superm1/orgs","repos_url":"https://api.github.com/users/superm1/repos","events_url":"https://api.github.com/users/superm1/events{/privacy}","received_events_url":"https://api.github.com/users/superm1/received_events","type":"User","site_admin":false},"body":"I'm not even seeing an `owned` file.\r\n\r\n```\r\n/sys/class/tpm/tpm0$ ls -alhR\r\n.:\r\ntotal 0\r\ndrwxr-xr-x 4 root root    0 Dec 12 09:32 .\r\ndrwxr-xr-x 3 root root    0 Dec 12 09:32 ..\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 dev\r\nlrwxrwxrwx 1 root root    0 Dec 12 09:32 device -> ../../../MSFT0101:00\r\ndrwxr-xr-x 2 root root    0 Dec 12 09:32 power\r\ndrwxr-xr-x 2 root root    0 Dec 12 09:32 ppi\r\nlrwxrwxrwx 1 root root    0 Dec 12 09:32 subsystem -> ../../../../../class/tpm\r\n-rw-r--r-- 1 root root 4.0K Dec 12 09:32 uevent\r\n\r\n./power:\r\ntotal 0\r\ndrwxr-xr-x 2 root root    0 Dec 12 09:32 .\r\ndrwxr-xr-x 4 root root    0 Dec 12 09:32 ..\r\n-rw-r--r-- 1 root root 4.0K Dec 12 09:32 async\r\n-rw-r--r-- 1 root root 4.0K Dec 12 09:32 autosuspend_delay_ms\r\n-rw-r--r-- 1 root root 4.0K Dec 12 09:32 control\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 runtime_active_kids\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 runtime_active_time\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 runtime_enabled\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 runtime_status\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 runtime_suspended_time\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 runtime_usage\r\n\r\n./ppi:\r\ntotal 0\r\ndrwxr-xr-x 2 root root    0 Dec 12 09:32 .\r\ndrwxr-xr-x 4 root root    0 Dec 12 09:32 ..\r\n-rw-rw-r-- 1 root root 4.0K Dec 12 09:32 request\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 response\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 tcg_operations\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 transition_action\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 version\r\n-r--r--r-- 1 root root 4.0K Dec 12 09:32 vs_operations\r\n```","created_at":"2018-12-12T15:32:50Z","updated_at":"2018-12-12T15:32:51Z","html_url":"https://github.com/hughsie/fwupd/pull/896#discussion_r241062024","pull_request_url":"https://api.github.com/repos/hughsie/fwupd/pulls/896","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/comments/241062024"},"html":{"href":"https://github.com/hughsie/fwupd/pull/896#discussion_r241062024"},"pull_request":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/896"}},"in_reply_to_id":241050397},"pull_request":{"url":"https://api.github.com/repos/hughsie/fwupd/pulls/896","id":238005253,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDA1MjUz","html_url":"https://github.com/hughsie/fwupd/pull/896","diff_url":"https://github.com/hughsie/fwupd/pull/896.diff","patch_url":"https://github.com/hughsie/fwupd/pull/896.patch","issue_url":"https://api.github.com/repos/hughsie/fwupd/issues/896","number":896,"state":"open","locked":false,"title":"Wip/hughsie/attestation","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-12T11:35:32Z","updated_at":"2018-12-12T15:32:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bfd2922d04c5a5e8fde7983839d0d46711a3e47","assignee":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"assignees":[{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":181181879,"node_id":"MDU6TGFiZWwxODExODE4Nzk=","url":"https://api.github.com/repos/hughsie/fwupd/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/hughsie/fwupd/pulls/896/commits","review_comments_url":"https://api.github.com/repos/hughsie/fwupd/pulls/896/comments","review_comment_url":"https://api.github.com/repos/hughsie/fwupd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hughsie/fwupd/issues/896/comments","statuses_url":"https://api.github.com/repos/hughsie/fwupd/statuses/b70c39cb3086e1917191a787dc9a84fc70405850","head":{"label":"hughsie:wip/hughsie/attestation","ref":"wip/hughsie/attestation","sha":"b70c39cb3086e1917191a787dc9a84fc70405850","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":31374735,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM3NDczNQ==","name":"fwupd","full_name":"hughsie/fwupd","private":false,"owner":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hughsie/fwupd","description":"A simple daemon to allow session software to update firmware","fork":false,"url":"https://api.github.com/repos/hughsie/fwupd","forks_url":"https://api.github.com/repos/hughsie/fwupd/forks","keys_url":"https://api.github.com/repos/hughsie/fwupd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/fwupd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/fwupd/teams","hooks_url":"https://api.github.com/repos/hughsie/fwupd/hooks","issue_events_url":"https://api.github.com/repos/hughsie/fwupd/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/fwupd/events","assignees_url":"https://api.github.com/repos/hughsie/fwupd/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/fwupd/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/fwupd/tags","blobs_url":"https://api.github.com/repos/hughsie/fwupd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/fwupd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/fwupd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/fwupd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/fwupd/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/fwupd/languages","stargazers_url":"https://api.github.com/repos/hughsie/fwupd/stargazers","contributors_url":"https://api.github.com/repos/hughsie/fwupd/contributors","subscribers_url":"https://api.github.com/repos/hughsie/fwupd/subscribers","subscription_url":"https://api.github.com/repos/hughsie/fwupd/subscription","commits_url":"https://api.github.com/repos/hughsie/fwupd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/fwupd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/fwupd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/fwupd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/fwupd/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/fwupd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/fwupd/merges","archive_url":"https://api.github.com/repos/hughsie/fwupd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/fwupd/downloads","issues_url":"https://api.github.com/repos/hughsie/fwupd/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/fwupd/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/fwupd/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/fwupd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/fwupd/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/fwupd/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/fwupd/deployments","created_at":"2015-02-26T15:52:25Z","updated_at":"2018-12-12T15:24:34Z","pushed_at":"2018-12-12T14:22:07Z","git_url":"git://github.com/hughsie/fwupd.git","ssh_url":"git@github.com:hughsie/fwupd.git","clone_url":"https://github.com/hughsie/fwupd.git","svn_url":"https://github.com/hughsie/fwupd","homepage":"","size":9415,"stargazers_count":463,"watchers_count":463,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":78,"open_issues":24,"watchers":463,"default_branch":"master"}},"base":{"label":"hughsie:master","ref":"master","sha":"8612318158c9d199d539dd4d0dfcc33d4264d8fa","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":31374735,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM3NDczNQ==","name":"fwupd","full_name":"hughsie/fwupd","private":false,"owner":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hughsie/fwupd","description":"A simple daemon to allow session software to update firmware","fork":false,"url":"https://api.github.com/repos/hughsie/fwupd","forks_url":"https://api.github.com/repos/hughsie/fwupd/forks","keys_url":"https://api.github.com/repos/hughsie/fwupd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/fwupd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/fwupd/teams","hooks_url":"https://api.github.com/repos/hughsie/fwupd/hooks","issue_events_url":"https://api.github.com/repos/hughsie/fwupd/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/fwupd/events","assignees_url":"https://api.github.com/repos/hughsie/fwupd/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/fwupd/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/fwupd/tags","blobs_url":"https://api.github.com/repos/hughsie/fwupd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/fwupd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/fwupd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/fwupd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/fwupd/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/fwupd/languages","stargazers_url":"https://api.github.com/repos/hughsie/fwupd/stargazers","contributors_url":"https://api.github.com/repos/hughsie/fwupd/contributors","subscribers_url":"https://api.github.com/repos/hughsie/fwupd/subscribers","subscription_url":"https://api.github.com/repos/hughsie/fwupd/subscription","commits_url":"https://api.github.com/repos/hughsie/fwupd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/fwupd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/fwupd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/fwupd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/fwupd/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/fwupd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/fwupd/merges","archive_url":"https://api.github.com/repos/hughsie/fwupd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/fwupd/downloads","issues_url":"https://api.github.com/repos/hughsie/fwupd/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/fwupd/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/fwupd/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/fwupd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/fwupd/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/fwupd/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/fwupd/deployments","created_at":"2015-02-26T15:52:25Z","updated_at":"2018-12-12T15:24:34Z","pushed_at":"2018-12-12T14:22:07Z","git_url":"git://github.com/hughsie/fwupd.git","ssh_url":"git@github.com:hughsie/fwupd.git","clone_url":"https://github.com/hughsie/fwupd.git","svn_url":"https://github.com/hughsie/fwupd","homepage":"","size":9415,"stargazers_count":463,"watchers_count":463,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":78,"open_issues":24,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/896"},"html":{"href":"https://github.com/hughsie/fwupd/pull/896"},"issue":{"href":"https://api.github.com/repos/hughsie/fwupd/issues/896"},"comments":{"href":"https://api.github.com/repos/hughsie/fwupd/issues/896/comments"},"review_comments":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/896/comments"},"review_comment":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/896/commits"},"statuses":{"href":"https://api.github.com/repos/hughsie/fwupd/statuses/b70c39cb3086e1917191a787dc9a84fc70405850"}},"author_association":"OWNER"}}
{"actor":{"display_login":"superm1"}}