{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/3197","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/3197/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/3197/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/3197/events","html_url":"https://github.com/publiclab/plots2/pull/3197","id":347586236,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTc1MTkw","number":3197,"title":"Add test task to Makefile","user":{"login":"icarito","id":199755,"node_id":"MDQ6VXNlcjE5OTc1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/199755?v=4","gravatar_id":"","url":"https://api.github.com/users/icarito","html_url":"https://github.com/icarito","followers_url":"https://api.github.com/users/icarito/followers","following_url":"https://api.github.com/users/icarito/following{/other_user}","gists_url":"https://api.github.com/users/icarito/gists{/gist_id}","starred_url":"https://api.github.com/users/icarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icarito/subscriptions","organizations_url":"https://api.github.com/users/icarito/orgs","repos_url":"https://api.github.com/users/icarito/repos","events_url":"https://api.github.com/users/icarito/events{/privacy}","received_events_url":"https://api.github.com/users/icarito/received_events","type":"User","site_admin":false},"labels":[{"id":189388513,"node_id":"MDU6TGFiZWwxODkzODg1MTM=","url":"https://api.github.com/repos/publiclab/plots2/labels/ready","name":"ready","color":"0edd56","default":false}],"state":"open","locked":false,"assignee":{"login":"icarito","id":199755,"node_id":"MDQ6VXNlcjE5OTc1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/199755?v=4","gravatar_id":"","url":"https://api.github.com/users/icarito","html_url":"https://github.com/icarito","followers_url":"https://api.github.com/users/icarito/followers","following_url":"https://api.github.com/users/icarito/following{/other_user}","gists_url":"https://api.github.com/users/icarito/gists{/gist_id}","starred_url":"https://api.github.com/users/icarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icarito/subscriptions","organizations_url":"https://api.github.com/users/icarito/orgs","repos_url":"https://api.github.com/users/icarito/repos","events_url":"https://api.github.com/users/icarito/events{/privacy}","received_events_url":"https://api.github.com/users/icarito/received_events","type":"User","site_admin":false},"assignees":[{"login":"icarito","id":199755,"node_id":"MDQ6VXNlcjE5OTc1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/199755?v=4","gravatar_id":"","url":"https://api.github.com/users/icarito","html_url":"https://github.com/icarito","followers_url":"https://api.github.com/users/icarito/followers","following_url":"https://api.github.com/users/icarito/following{/other_user}","gists_url":"https://api.github.com/users/icarito/gists{/gist_id}","starred_url":"https://api.github.com/users/icarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icarito/subscriptions","organizations_url":"https://api.github.com/users/icarito/orgs","repos_url":"https://api.github.com/users/icarito/repos","events_url":"https://api.github.com/users/icarito/events{/privacy}","received_events_url":"https://api.github.com/users/icarito/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-08-04T04:29:26Z","updated_at":"2018-08-04T15:12:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/3197","html_url":"https://github.com/publiclab/plots2/pull/3197","diff_url":"https://github.com/publiclab/plots2/pull/3197.diff","patch_url":"https://github.com/publiclab/plots2/pull/3197.patch"},"body":"This adds a command that we use in Jenkins to build : `make test-container`.\r\n\r\nMake sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!\r\n\r\n* [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `rake test`\r\n* [x] code is in uniquely-named feature branch and has no merge conflicts\r\n* [x] PR is descriptively titled\r\n* [ ] PR body includes `fixes #0000`-style reference to original issue #\r\n* [ ] ask `@publiclab/reviewers` for help, in a comment below\r\n\r\n> We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first!\r\n\r\nIf tests do fail, click on the red `X` to learn why by reading the logs.\r\n\r\nPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software\r\n\r\nWe have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. \r\n\r\nThanks!\r\n"},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/410456156","html_url":"https://github.com/publiclab/plots2/pull/3197#issuecomment-410456156","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/3197","id":410456156,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDQ1NjE1Ng==","user":{"login":"jywarren","id":24359,"node_id":"MDQ6VXNlcjI0MzU5","avatar_url":"https://avatars1.githubusercontent.com/u/24359?v=4","gravatar_id":"","url":"https://api.github.com/users/jywarren","html_url":"https://github.com/jywarren","followers_url":"https://api.github.com/users/jywarren/followers","following_url":"https://api.github.com/users/jywarren/following{/other_user}","gists_url":"https://api.github.com/users/jywarren/gists{/gist_id}","starred_url":"https://api.github.com/users/jywarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jywarren/subscriptions","organizations_url":"https://api.github.com/users/jywarren/orgs","repos_url":"https://api.github.com/users/jywarren/repos","events_url":"https://api.github.com/users/jywarren/events{/privacy}","received_events_url":"https://api.github.com/users/jywarren/received_events","type":"User","site_admin":false},"created_at":"2018-08-04T15:12:39Z","updated_at":"2018-08-04T15:12:39Z","author_association":"CONTRIBUTOR","body":"Oh cool, is it the tests? Did it fail on the same issue?\n\nOn Sat, Aug 4, 2018, 4:12 AM Sebastian Silva <notifications@github.com>\nwrote:\n\n> This is bulding in Jenkins now too (can only be triggered by members of\n> publiclab organization). The build is real fast too because it caches the\n> docker image!\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/publiclab/plots2/pull/3197#issuecomment-410432917>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AABfJ00QjfQFZ4l81fgEbHwZBM_rcOtZks5uNVdggaJpZM4Vu1up>\n> .\n>\n"}}
{"actor":{"display_login":"jywarren"}}