{"action":"created","comment":{"url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments/217156507","pull_request_review_id":154803514,"id":217156507,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE1NjUwNw==","diff_hunk":"@@ -34,39 +34,45 @@ NS_ASSUME_NONNULL_END\n /**\n  * Create the parameters for an impression event.\n  *\n- * @param config The project config object.\n  * @param userId The ID of the user.\n- * @param experimentKey The experiment name.\n- * @param variationId The variation ID.\n+ * @param experiment The experiment.\n+ * @param variation The variation.\n  * @param attributes A map of attribute names to current user attribute values.\n  * @return A map of parameters for an impression event. This value can be nil.\n  *\n  */\n-- (nullable NSDictionary *)buildImpressionEventTicket:(nonnull OPTLYProjectConfig *)config\n-                                         userId:(nonnull NSString *)userId\n-                                  experimentKey:(nonnull NSString *)experimentKey\n-                                    variationId:(nonnull NSString *)variationId\n-                                     attributes:(nullable NSDictionary<NSString *, NSString *> *)attributes;\n+- (nullable NSDictionary *)buildImpressionEventTicketForUser:(nonnull NSString *)userId","path":"OptimizelySDKCore/OptimizelySDKCore/OPTLYEventBuilder.h","position":28,"original_position":28,"commit_id":"0e2dc8cc1da4e58114c79966d4ddbeed30d1569b","original_commit_id":"0e2dc8cc1da4e58114c79966d4ddbeed30d1569b","user":{"login":"msohailhussain","id":3163521,"node_id":"MDQ6VXNlcjMxNjM1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3163521?v=4","gravatar_id":"","url":"https://api.github.com/users/msohailhussain","html_url":"https://github.com/msohailhussain","followers_url":"https://api.github.com/users/msohailhussain/followers","following_url":"https://api.github.com/users/msohailhussain/following{/other_user}","gists_url":"https://api.github.com/users/msohailhussain/gists{/gist_id}","starred_url":"https://api.github.com/users/msohailhussain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msohailhussain/subscriptions","organizations_url":"https://api.github.com/users/msohailhussain/orgs","repos_url":"https://api.github.com/users/msohailhussain/repos","events_url":"https://api.github.com/users/msohailhussain/events{/privacy}","received_events_url":"https://api.github.com/users/msohailhussain/received_events","type":"User","site_admin":false},"body":"Why did you rename it? \r\nWhat's the purpose to use Ticket in the name? ","created_at":"2018-09-12T19:17:33Z","updated_at":"2018-09-12T19:17:33Z","html_url":"https://github.com/optimizely/objective-c-sdk/pull/306#discussion_r217156507","pull_request_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments/217156507"},"html":{"href":"https://github.com/optimizely/objective-c-sdk/pull/306#discussion_r217156507"},"pull_request":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306","id":214941348,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTQxMzQ4","html_url":"https://github.com/optimizely/objective-c-sdk/pull/306","diff_url":"https://github.com/optimizely/objective-c-sdk/pull/306.diff","patch_url":"https://github.com/optimizely/objective-c-sdk/pull/306.patch","issue_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/306","number":306,"state":"open","locked":false,"title":"refactor(EventBuilder): Moved decision service and bucketing from EventBuilder to Optimizely ","user":{"login":"AbdurRafay","id":11155446,"node_id":"MDQ6VXNlcjExMTU1NDQ2","avatar_url":"https://avatars3.githubusercontent.com/u/11155446?v=4","gravatar_id":"","url":"https://api.github.com/users/AbdurRafay","html_url":"https://github.com/AbdurRafay","followers_url":"https://api.github.com/users/AbdurRafay/followers","following_url":"https://api.github.com/users/AbdurRafay/following{/other_user}","gists_url":"https://api.github.com/users/AbdurRafay/gists{/gist_id}","starred_url":"https://api.github.com/users/AbdurRafay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbdurRafay/subscriptions","organizations_url":"https://api.github.com/users/AbdurRafay/orgs","repos_url":"https://api.github.com/users/AbdurRafay/repos","events_url":"https://api.github.com/users/AbdurRafay/events{/privacy}","received_events_url":"https://api.github.com/users/AbdurRafay/received_events","type":"User","site_admin":false},"body":"### Summary\r\n- Moved decision service and bucketing from EventBuilder to Optimizely.\r\n- Pulled eventTag stuff into another method.\r\n- Revised activate & track methods to validate inputs.\r\n- Revised test cases of Optimizely & EventBuilder.\r\n","created_at":"2018-09-12T12:23:28Z","updated_at":"2018-09-12T19:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60e3ccfce938833bb15b936d7f4445392b334899","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mikeng13","id":1365958,"node_id":"MDQ6VXNlcjEzNjU5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1365958?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false},{"login":"thomaszurkan-optimizely","id":28317449,"node_id":"MDQ6VXNlcjI4MzE3NDQ5","avatar_url":"https://avatars3.githubusercontent.com/u/28317449?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaszurkan-optimizely","html_url":"https://github.com/thomaszurkan-optimizely","followers_url":"https://api.github.com/users/thomaszurkan-optimizely/followers","following_url":"https://api.github.com/users/thomaszurkan-optimizely/following{/other_user}","gists_url":"https://api.github.com/users/thomaszurkan-optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaszurkan-optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaszurkan-optimizely/subscriptions","organizations_url":"https://api.github.com/users/thomaszurkan-optimizely/orgs","repos_url":"https://api.github.com/users/thomaszurkan-optimizely/repos","events_url":"https://api.github.com/users/thomaszurkan-optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/thomaszurkan-optimizely/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306/commits","review_comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306/comments","review_comment_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/306/comments","statuses_url":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/0e2dc8cc1da4e58114c79966d4ddbeed30d1569b","head":{"label":"optimizely:arafay/refactor-event-builder","ref":"arafay/refactor-event-builder","sha":"0e2dc8cc1da4e58114c79966d4ddbeed30d1569b","user":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":69407259,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwNzI1OQ==","name":"objective-c-sdk","full_name":"optimizely/objective-c-sdk","owner":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/objective-c-sdk","description":"Optimizely X Objective-C SDK for iOS and tvOS","fork":false,"url":"https://api.github.com/repos/optimizely/objective-c-sdk","forks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/objective-c-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/objective-c-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/objective-c-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/objective-c-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/objective-c-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/objective-c-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/objective-c-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/objective-c-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/objective-c-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/objective-c-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/objective-c-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/objective-c-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/objective-c-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/deployments","created_at":"2016-09-27T23:32:27Z","updated_at":"2018-09-07T20:05:37Z","pushed_at":"2018-09-12T12:23:28Z","git_url":"git://github.com/optimizely/objective-c-sdk.git","ssh_url":"git@github.com:optimizely/objective-c-sdk.git","clone_url":"https://github.com/optimizely/objective-c-sdk.git","svn_url":"https://github.com/optimizely/objective-c-sdk","homepage":"","size":223029,"stargazers_count":13,"watchers_count":13,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":10,"watchers":13,"default_branch":"master"}},"base":{"label":"optimizely:master","ref":"master","sha":"12bf48ac48d71d3e3fec0f602b2c0ca8d39d3e0c","user":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":69407259,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwNzI1OQ==","name":"objective-c-sdk","full_name":"optimizely/objective-c-sdk","owner":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/objective-c-sdk","description":"Optimizely X Objective-C SDK for iOS and tvOS","fork":false,"url":"https://api.github.com/repos/optimizely/objective-c-sdk","forks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/objective-c-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/objective-c-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/objective-c-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/objective-c-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/objective-c-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/objective-c-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/objective-c-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/objective-c-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/objective-c-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/objective-c-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/objective-c-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/objective-c-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/objective-c-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/objective-c-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/objective-c-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/objective-c-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/objective-c-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/objective-c-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/objective-c-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/objective-c-sdk/deployments","created_at":"2016-09-27T23:32:27Z","updated_at":"2018-09-07T20:05:37Z","pushed_at":"2018-09-12T12:23:28Z","git_url":"git://github.com/optimizely/objective-c-sdk.git","ssh_url":"git@github.com:optimizely/objective-c-sdk.git","clone_url":"https://github.com/optimizely/objective-c-sdk.git","svn_url":"https://github.com/optimizely/objective-c-sdk","homepage":"","size":223029,"stargazers_count":13,"watchers_count":13,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":10,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306"},"html":{"href":"https://github.com/optimizely/objective-c-sdk/pull/306"},"issue":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/306"},"comments":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/optimizely/objective-c-sdk/statuses/0e2dc8cc1da4e58114c79966d4ddbeed30d1569b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"msohailhussain"}}