{"action":"created","issue":{"url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1332","repository_url":"https://api.github.com/repos/bitshares/bitshares-core","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1332/labels{/name}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1332/comments","events_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1332/events","html_url":"https://github.com/bitshares/bitshares-core/pull/1332","id":360739754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODg0ODQ4","number":1332,"title":"Terminate block production loop when shutting down witness plugin #1314","user":{"login":"cogutvalera","id":36471515,"node_id":"MDQ6VXNlcjM2NDcxNTE1","avatar_url":"https://avatars0.githubusercontent.com/u/36471515?v=4","gravatar_id":"","url":"https://api.github.com/users/cogutvalera","html_url":"https://github.com/cogutvalera","followers_url":"https://api.github.com/users/cogutvalera/followers","following_url":"https://api.github.com/users/cogutvalera/following{/other_user}","gists_url":"https://api.github.com/users/cogutvalera/gists{/gist_id}","starred_url":"https://api.github.com/users/cogutvalera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogutvalera/subscriptions","organizations_url":"https://api.github.com/users/cogutvalera/orgs","repos_url":"https://api.github.com/users/cogutvalera/repos","events_url":"https://api.github.com/users/cogutvalera/events{/privacy}","received_events_url":"https://api.github.com/users/cogutvalera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-17T06:41:24Z","updated_at":"2018-09-21T10:08:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1332","html_url":"https://github.com/bitshares/bitshares-core/pull/1332","diff_url":"https://github.com/bitshares/bitshares-core/pull/1332.diff","patch_url":"https://github.com/bitshares/bitshares-core/pull/1332.patch"},"body":"PR for **\"Terminate block production loop when shutting down witness plugin #1314\"**"},"comment":{"url":"https://api.github.com/repos/bitshares/bitshares-core/issues/comments/423483102","html_url":"https://github.com/bitshares/bitshares-core/pull/1332#issuecomment-423483102","issue_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1332","id":423483102,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzQ4MzEwMg==","user":{"login":"cogutvalera","id":36471515,"node_id":"MDQ6VXNlcjM2NDcxNTE1","avatar_url":"https://avatars0.githubusercontent.com/u/36471515?v=4","gravatar_id":"","url":"https://api.github.com/users/cogutvalera","html_url":"https://github.com/cogutvalera","followers_url":"https://api.github.com/users/cogutvalera/followers","following_url":"https://api.github.com/users/cogutvalera/following{/other_user}","gists_url":"https://api.github.com/users/cogutvalera/gists{/gist_id}","starred_url":"https://api.github.com/users/cogutvalera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogutvalera/subscriptions","organizations_url":"https://api.github.com/users/cogutvalera/orgs","repos_url":"https://api.github.com/users/cogutvalera/repos","events_url":"https://api.github.com/users/cogutvalera/events{/privacy}","received_events_url":"https://api.github.com/users/cogutvalera/received_events","type":"User","site_admin":false},"created_at":"2018-09-21T10:08:40Z","updated_at":"2018-09-21T10:08:40Z","author_association":"MEMBER","body":"> cancel_and_wait sends the cancel signal and waits for the task to be canceled.\r\n> Where does it wait for the currently running task to finish before sending the cancel signal?\r\n\r\n1. Yes, right, it will wait currently running task after sending cancel signal.\r\n2. It won't schedule the next one loop, why it will ? So which another currently running task do you mean if `cancel_and_wait` will wait it ?"}}
{"actor":{"display_login":"cogutvalera"}}