{"action":"created","issue":{"url":"https://api.github.com/repos/OsmSharp/core/issues/46","repository_url":"https://api.github.com/repos/OsmSharp/core","labels_url":"https://api.github.com/repos/OsmSharp/core/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/OsmSharp/core/issues/46/comments","events_url":"https://api.github.com/repos/OsmSharp/core/issues/46/events","html_url":"https://github.com/OsmSharp/core/issues/46","id":283945724,"number":46,"title":"Implement complete PBF write support","user":{"login":"xivk","id":1128068,"avatar_url":"https://avatars2.githubusercontent.com/u/1128068?v=4","gravatar_id":"","url":"https://api.github.com/users/xivk","html_url":"https://github.com/xivk","followers_url":"https://api.github.com/users/xivk/followers","following_url":"https://api.github.com/users/xivk/following{/other_user}","gists_url":"https://api.github.com/users/xivk/gists{/gist_id}","starred_url":"https://api.github.com/users/xivk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivk/subscriptions","organizations_url":"https://api.github.com/users/xivk/orgs","repos_url":"https://api.github.com/users/xivk/repos","events_url":"https://api.github.com/users/xivk/events{/privacy}","received_events_url":"https://api.github.com/users/xivk/received_events","type":"User","site_admin":false},"labels":[{"id":252555269,"url":"https://api.github.com/repos/OsmSharp/core/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":793849318,"url":"https://api.github.com/repos/OsmSharp/core/labels/planned","name":"planned","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"xivk","id":1128068,"avatar_url":"https://avatars2.githubusercontent.com/u/1128068?v=4","gravatar_id":"","url":"https://api.github.com/users/xivk","html_url":"https://github.com/xivk","followers_url":"https://api.github.com/users/xivk/followers","following_url":"https://api.github.com/users/xivk/following{/other_user}","gists_url":"https://api.github.com/users/xivk/gists{/gist_id}","starred_url":"https://api.github.com/users/xivk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivk/subscriptions","organizations_url":"https://api.github.com/users/xivk/orgs","repos_url":"https://api.github.com/users/xivk/repos","events_url":"https://api.github.com/users/xivk/events{/privacy}","received_events_url":"https://api.github.com/users/xivk/received_events","type":"User","site_admin":false},"assignees":[{"login":"xivk","id":1128068,"avatar_url":"https://avatars2.githubusercontent.com/u/1128068?v=4","gravatar_id":"","url":"https://api.github.com/users/xivk","html_url":"https://github.com/xivk","followers_url":"https://api.github.com/users/xivk/followers","following_url":"https://api.github.com/users/xivk/following{/other_user}","gists_url":"https://api.github.com/users/xivk/gists{/gist_id}","starred_url":"https://api.github.com/users/xivk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivk/subscriptions","organizations_url":"https://api.github.com/users/xivk/orgs","repos_url":"https://api.github.com/users/xivk/repos","events_url":"https://api.github.com/users/xivk/events{/privacy}","received_events_url":"https://api.github.com/users/xivk/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/OsmSharp/core/milestones/1","html_url":"https://github.com/OsmSharp/core/milestone/1","labels_url":"https://api.github.com/repos/OsmSharp/core/milestones/1/labels","id":3009764,"number":1,"title":"Version 6.1","description":"This is a milestone for Version 6.1","creator":{"login":"xivk","id":1128068,"avatar_url":"https://avatars2.githubusercontent.com/u/1128068?v=4","gravatar_id":"","url":"https://api.github.com/users/xivk","html_url":"https://github.com/xivk","followers_url":"https://api.github.com/users/xivk/followers","following_url":"https://api.github.com/users/xivk/following{/other_user}","gists_url":"https://api.github.com/users/xivk/gists{/gist_id}","starred_url":"https://api.github.com/users/xivk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivk/subscriptions","organizations_url":"https://api.github.com/users/xivk/orgs","repos_url":"https://api.github.com/users/xivk/repos","events_url":"https://api.github.com/users/xivk/events{/privacy}","received_events_url":"https://api.github.com/users/xivk/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":6,"state":"open","created_at":"2018-01-03T11:06:12Z","updated_at":"2018-02-08T20:40:06Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-12-21T17:05:24Z","updated_at":"2018-05-03T14:18:31Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Implement full PBF write support. OsmSharp only supports a simple (but compatible) version of the OSM PBF format. This leads to bigger files than expected."},"comment":{"url":"https://api.github.com/repos/OsmSharp/core/issues/comments/386311373","html_url":"https://github.com/OsmSharp/core/issues/46#issuecomment-386311373","issue_url":"https://api.github.com/repos/OsmSharp/core/issues/46","id":386311373,"user":{"login":"HarelM","id":3269297,"avatar_url":"https://avatars3.githubusercontent.com/u/3269297?v=4","gravatar_id":"","url":"https://api.github.com/users/HarelM","html_url":"https://github.com/HarelM","followers_url":"https://api.github.com/users/HarelM/followers","following_url":"https://api.github.com/users/HarelM/following{/other_user}","gists_url":"https://api.github.com/users/HarelM/gists{/gist_id}","starred_url":"https://api.github.com/users/HarelM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarelM/subscriptions","organizations_url":"https://api.github.com/users/HarelM/orgs","repos_url":"https://api.github.com/users/HarelM/repos","events_url":"https://api.github.com/users/HarelM/events{/privacy}","received_events_url":"https://api.github.com/users/HarelM/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T14:18:31Z","updated_at":"2018-05-03T14:18:31Z","author_association":"CONTRIBUTOR","body":"I have looked through the code again, and I now think I fully understand it.\r\nThe only thing that I'm not sure about it the following comment - is it for performance sake?\r\nhttps://github.com/OsmSharp/core/blob/e951c41f824aa4dc3afd79538ae29f3c1edf627a/src/OsmSharp/IO/PBF/Encoder.cs#L206\r\nAnd it needs the following \"if\" as well...?\r\nhttps://github.com/OsmSharp/core/blob/e951c41f824aa4dc3afd79538ae29f3c1edf627a/src/OsmSharp/IO/PBF/Encoder.cs#L225\r\nIn any case, adding EncodeDenseNode shouldn't be difficult now that I think I understand the code.\r\nbut removing this \"if\" and uncommenting the above comment would make the code much more simple, IMO.\r\n@xivk let me know what you think and if you think this is the right course of action. \r\nAlso, assuming I can send a pull request, could you create a pre-release NuGet package I can use?"}}
{"actor":{"display_login":"HarelM"}}