{"action":"created","issue":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1793","repository_url":"https://api.github.com/repos/rails-api/active_model_serializers","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1793/labels{/name}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1793/comments","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1793/events","html_url":"https://github.com/rails-api/active_model_serializers/issues/1793","id":159473626,"number":1793,"title":"reserved characters in `json_api` adapter","user":{"login":"KevinColemanInc","id":2381771,"avatar_url":"https://avatars1.githubusercontent.com/u/2381771?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinColemanInc","html_url":"https://github.com/KevinColemanInc","followers_url":"https://api.github.com/users/KevinColemanInc/followers","following_url":"https://api.github.com/users/KevinColemanInc/following{/other_user}","gists_url":"https://api.github.com/users/KevinColemanInc/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinColemanInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinColemanInc/subscriptions","organizations_url":"https://api.github.com/users/KevinColemanInc/orgs","repos_url":"https://api.github.com/users/KevinColemanInc/repos","events_url":"https://api.github.com/users/KevinColemanInc/events{/privacy}","received_events_url":"https://api.github.com/users/KevinColemanInc/received_events","type":"User","site_admin":false},"labels":[{"id":187758411,"url":"https://api.github.com/repos/rails-api/active_model_serializers/labels/C:%20JSON%20API","name":"C: JSON API","color":"CCCCCC","default":false},{"id":350630555,"url":"https://api.github.com/repos/rails-api/active_model_serializers/labels/C:%20Keys%20and%20Transform","name":"C: Keys and Transform","color":"CCCCCC","default":false},{"id":184618099,"url":"https://api.github.com/repos/rails-api/active_model_serializers/labels/S:%20Ready%20for%20PR","name":"S: Ready for PR","color":"009800","default":false},{"id":123839730,"url":"https://api.github.com/repos/rails-api/active_model_serializers/labels/V:%200.10.x","name":"V: 0.10.x","color":"bfd4f2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-09T18:15:19Z","updated_at":"2018-03-15T05:26:41Z","closed_at":"2018-03-15T05:20:29Z","author_association":"NONE","body":"#### Expected behavior vs actual behavior\n\nversion 0.8.x removed reserved characters, but 0.10.0 does not seem to follow the guidelines laid out by [jsonapi.org](http://jsonapi.org/format/#document-member-names).\n\nI think the documentation should stop claiming to follow the jsonapi.org or prevent reserved characters from being rendered.\n\ntwo examples I have found so far:\n##### Question marks are against spec.\n\nActual\n`attributes :is_a_admin?`\n   `{ \"is_a_admin?\": true }`\n\nExpected\nversion 0.8.x would drop the \"?\" from the name.\n##### Slashes in member names\n\nActual\nif the class is Review::Current, 0.10.0 will render the root key by default to 'review/current'.\n\nExpected\n@NullVoxPopuli suggested the correct way to handle modularized class names would be to say `review--current`\n"},"comment":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments/373265011","html_url":"https://github.com/rails-api/active_model_serializers/issues/1793#issuecomment-373265011","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1793","id":373265011,"user":{"login":"KevinColemanInc","id":2381771,"avatar_url":"https://avatars1.githubusercontent.com/u/2381771?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinColemanInc","html_url":"https://github.com/KevinColemanInc","followers_url":"https://api.github.com/users/KevinColemanInc/followers","following_url":"https://api.github.com/users/KevinColemanInc/following{/other_user}","gists_url":"https://api.github.com/users/KevinColemanInc/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinColemanInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinColemanInc/subscriptions","organizations_url":"https://api.github.com/users/KevinColemanInc/orgs","repos_url":"https://api.github.com/users/KevinColemanInc/repos","events_url":"https://api.github.com/users/KevinColemanInc/events{/privacy}","received_events_url":"https://api.github.com/users/KevinColemanInc/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T05:26:41Z","updated_at":"2018-03-15T05:26:41Z","author_association":"NONE","body":"@bf4 / @leoskyrocker \r\n\r\nI see there is some consensus about how to fix the \"?\", but I don't see a solution for polymorphic attribute names.\r\n\r\nIs there a PR for resolving the \"/\" issue?"}}
{"actor":{"display_login":"KevinColemanInc"}}