{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/183302072","pull_request_review_id":114272252,"id":183302072,"diff_hunk":"@@ -17,6 +17,7 @@ import (\n \tawsclient \"github.com/giantswarm/aws-operator/client/aws\"\n \t\"github.com/giantswarm/aws-operator/service/controller/v1\"\n \t\"github.com/giantswarm/aws-operator/service/controller/v10\"\n+\tv10adapter \"github.com/giantswarm/aws-operator/service/controller/v10/adapter\"\n \tv10cloudconfig \"github.com/giantswarm/aws-operator/service/controller/v10/cloudconfig\"","path":"service/controller/cluster_framework.go","position":5,"original_position":5,"commit_id":"02d9ebfc829c4db57297e02c73dc34eb3faeb77c","original_commit_id":"02d9ebfc829c4db57297e02c73dc34eb3faeb77c","user":{"login":"kopiczko","id":4608994,"avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":"General question: why we need `v10` imports here? It feels like some bug potential.","created_at":"2018-04-23T07:50:10Z","updated_at":"2018-04-23T07:56:05Z","html_url":"https://github.com/giantswarm/aws-operator/pull/904#discussion_r183302072","pull_request_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/183302072"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/904#discussion_r183302072"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904","id":182848275,"html_url":"https://github.com/giantswarm/aws-operator/pull/904","diff_url":"https://github.com/giantswarm/aws-operator/pull/904.diff","patch_url":"https://github.com/giantswarm/aws-operator/pull/904.patch","issue_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/904","number":904,"state":"open","locked":false,"title":"add-api-whitelist-support","user":{"login":"calvix","id":7136358,"avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"body":"towards https://github.com/giantswarm/giantswarm/issues/2882\r\n\r\nThis PR wants to make k8s guest cluster API whitelisting possible.\r\n\r\nIf its enabled in installation it will take the values from installation and then put them into Master security group for port 443.\r\n\r\nby default access is enabled from cidr `0.0.0.0/0` if whitelisting is enabled we restrict to: `hostClusterCIDR,guestClusterCIDR, whitelistSubnets`, where `whitelistSubnets` is defined in `installation` repo.\r\n\r\n\r\nThis is my wild guess as I am not familiar with the new aws-operator. ","created_at":"2018-04-19T17:37:37Z","updated_at":"2018-04-23T07:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"651f878b59be3d3a581b64611deddf935bdac283","assignee":{"login":"calvix","id":7136358,"avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"assignees":[{"login":"calvix","id":7136358,"avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904/commits","review_comments_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904/comments","review_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/904/comments","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/02d9ebfc829c4db57297e02c73dc34eb3faeb77c","head":{"label":"giantswarm:add-api-whitelist-support","ref":"add-api-whitelist-support","sha":"02d9ebfc829c4db57297e02c73dc34eb3faeb77c","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"name":"aws-operator","full_name":"giantswarm/aws-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-04-18T11:20:06Z","pushed_at":"2018-04-20T17:15:49Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":60248,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":5,"watchers":38,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"edc2c2e5afc5fa31beb85ca7578a1d2b910cfc8d","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"name":"aws-operator","full_name":"giantswarm/aws-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-04-18T11:20:06Z","pushed_at":"2018-04-20T17:15:49Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":60248,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":5,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/904"},"issue":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/904"},"comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/aws-operator/statuses/02d9ebfc829c4db57297e02c73dc34eb3faeb77c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kopiczko"}}