{"action":"closed","issue":{"url":"https://api.github.com/repos/cake-contrib/Cake_Git/issues/85","repository_url":"https://api.github.com/repos/cake-contrib/Cake_Git","labels_url":"https://api.github.com/repos/cake-contrib/Cake_Git/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/cake-contrib/Cake_Git/issues/85/comments","events_url":"https://api.github.com/repos/cake-contrib/Cake_Git/issues/85/events","html_url":"https://github.com/cake-contrib/Cake_Git/issues/85","id":389198749,"node_id":"MDU6SXNzdWUzODkxOTg3NDk=","number":85,"title":"Log and describe don't work correctly","user":{"login":"mariusGundersen","id":464152,"node_id":"MDQ6VXNlcjQ2NDE1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/464152?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusGundersen","html_url":"https://github.com/mariusGundersen","followers_url":"https://api.github.com/users/mariusGundersen/followers","following_url":"https://api.github.com/users/mariusGundersen/following{/other_user}","gists_url":"https://api.github.com/users/mariusGundersen/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusGundersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusGundersen/subscriptions","organizations_url":"https://api.github.com/users/mariusGundersen/orgs","repos_url":"https://api.github.com/users/mariusGundersen/repos","events_url":"https://api.github.com/users/mariusGundersen/events{/privacy}","received_events_url":"https://api.github.com/users/mariusGundersen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-10T08:55:57Z","updated_at":"2018-12-14T12:06:39Z","closed_at":"2018-12-14T12:06:39Z","author_association":"NONE","body":"There is a [simple command in git](https://stackoverflow.com/questions/12082981/get-all-git-commits-since-last-tag) to get every commit since previous tags, something that is useful when creating release notes:\r\n\r\n    git log $(git describe --tags --abbrev=0)..HEAD --oneline\r\n\r\nThe equivalent code for Cake.Git would be\r\n\r\n    GitLog(rootDir, GitDescribe(rootDir,  GitDescribeStrategy.Tags));\r\n\r\nUnfortunately this does not produce the same result. From the source code it looks like it uses a simple linq expression that stops when it finds the tag, while the [libgit2sharp documentation recommends a different way to do it](https://github.com/libgit2/libgit2sharp/wiki/git-log). For example, given the following git history:\r\n\r\n```\r\n        * - HEAD - merge\r\n        |\\\r\n        | * - commit1\r\n        | |\r\n        | * - commit2\r\n Tag2 - * |\r\n        |/\r\n        * - Tag1\r\n        |\r\n```\r\n\r\nThe command line snippet above lists three lines, the `merge`, `commit1` and `commit2`, but Cake.Git only lists the `merge` commit, since it stops when the linq expression reaches the first tag. \r\n\r\nIf Cake.Git instead use `ExcludeReachableFrom` as described in the libgit2sharp documentation it would produce the correct output."}}
{"actor":{"display_login":"mariusGundersen"}}