{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/183517080","pull_request_review_id":114530807,"id":183517080,"diff_hunk":"@@ -0,0 +1,51 @@\n+//  Copyright 2018 Istio Authors\n+//\n+//  Licensed under the Apache License, Version 2.0 (the \"License\");\n+//  you may not use this file except in compliance with the License.\n+//  You may obtain a copy of the License at\n+//\n+//      http://www.apache.org/licenses/LICENSE-2.0\n+//\n+//  Unless required by applicable law or agreed to in writing, software\n+//  distributed under the License is distributed on an \"AS IS\" BASIS,\n+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+//  See the License for the specific language governing permissions and\n+//  limitations under the License.\n+\n+package api","path":"pkg/test/api/api.go","position":15,"original_position":15,"commit_id":"ddc79b68a3242bae16a16013ea8e9e2992da56cb","original_commit_id":"ddc79b68a3242bae16a16013ea8e9e2992da56cb","user":{"login":"ozevren","id":17071139,"avatar_url":"https://avatars0.githubusercontent.com/u/17071139?v=4","gravatar_id":"","url":"https://api.github.com/users/ozevren","html_url":"https://github.com/ozevren","followers_url":"https://api.github.com/users/ozevren/followers","following_url":"https://api.github.com/users/ozevren/following{/other_user}","gists_url":"https://api.github.com/users/ozevren/gists{/gist_id}","starred_url":"https://api.github.com/users/ozevren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozevren/subscriptions","organizations_url":"https://api.github.com/users/ozevren/orgs","repos_url":"https://api.github.com/users/ozevren/repos","events_url":"https://api.github.com/users/ozevren/events{/privacy}","received_events_url":"https://api.github.com/users/ozevren/received_events","type":"User","site_admin":false},"body":"I think we can get rid of them and come up with a slightly different entry point.\r\nloca.NewEnvironment() and cluster.GetEnvironment() perhaps?","created_at":"2018-04-23T19:51:57Z","updated_at":"2018-04-23T19:51:57Z","html_url":"https://github.com/istio/istio/pull/5128#discussion_r183517080","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/5128","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/183517080"},"html":{"href":"https://github.com/istio/istio/pull/5128#discussion_r183517080"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/5128"}},"in_reply_to_id":183504446},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5128","id":183487167,"html_url":"https://github.com/istio/istio/pull/5128","diff_url":"https://github.com/istio/istio/pull/5128.diff","patch_url":"https://github.com/istio/istio/pull/5128.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/5128","number":5128,"state":"open","locked":false,"title":"[test-framework] Reorgnanization and linter fixes","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-23T16:17:45Z","updated_at":"2018-04-23T19:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bd25ede68ab12e29c20f9037fc56ce49ca8c38b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kimikowang","id":25443800,"avatar_url":"https://avatars3.githubusercontent.com/u/25443800?v=4","gravatar_id":"","url":"https://api.github.com/users/kimikowang","html_url":"https://github.com/kimikowang","followers_url":"https://api.github.com/users/kimikowang/followers","following_url":"https://api.github.com/users/kimikowang/following{/other_user}","gists_url":"https://api.github.com/users/kimikowang/gists{/gist_id}","starred_url":"https://api.github.com/users/kimikowang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimikowang/subscriptions","organizations_url":"https://api.github.com/users/kimikowang/orgs","repos_url":"https://api.github.com/users/kimikowang/repos","events_url":"https://api.github.com/users/kimikowang/events{/privacy}","received_events_url":"https://api.github.com/users/kimikowang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/5128/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/5128/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/5128/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/ddc79b68a3242bae16a16013ea8e9e2992da56cb","head":{"label":"nmittler:test-cleanup","ref":"test-cleanup","sha":"ddc79b68a3242bae16a16013ea8e9e2992da56cb","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"repo":{"id":105299964,"name":"istio","full_name":"nmittler/istio","owner":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmittler/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":true,"url":"https://api.github.com/repos/nmittler/istio","forks_url":"https://api.github.com/repos/nmittler/istio/forks","keys_url":"https://api.github.com/repos/nmittler/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmittler/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmittler/istio/teams","hooks_url":"https://api.github.com/repos/nmittler/istio/hooks","issue_events_url":"https://api.github.com/repos/nmittler/istio/issues/events{/number}","events_url":"https://api.github.com/repos/nmittler/istio/events","assignees_url":"https://api.github.com/repos/nmittler/istio/assignees{/user}","branches_url":"https://api.github.com/repos/nmittler/istio/branches{/branch}","tags_url":"https://api.github.com/repos/nmittler/istio/tags","blobs_url":"https://api.github.com/repos/nmittler/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmittler/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmittler/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmittler/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmittler/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/nmittler/istio/languages","stargazers_url":"https://api.github.com/repos/nmittler/istio/stargazers","contributors_url":"https://api.github.com/repos/nmittler/istio/contributors","subscribers_url":"https://api.github.com/repos/nmittler/istio/subscribers","subscription_url":"https://api.github.com/repos/nmittler/istio/subscription","commits_url":"https://api.github.com/repos/nmittler/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmittler/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmittler/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmittler/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmittler/istio/contents/{+path}","compare_url":"https://api.github.com/repos/nmittler/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmittler/istio/merges","archive_url":"https://api.github.com/repos/nmittler/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmittler/istio/downloads","issues_url":"https://api.github.com/repos/nmittler/istio/issues{/number}","pulls_url":"https://api.github.com/repos/nmittler/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/nmittler/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/nmittler/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmittler/istio/labels{/name}","releases_url":"https://api.github.com/repos/nmittler/istio/releases{/id}","deployments_url":"https://api.github.com/repos/nmittler/istio/deployments","created_at":"2017-09-29T17:33:39Z","updated_at":"2017-09-29T17:33:41Z","pushed_at":"2018-04-23T16:41:29Z","git_url":"git://github.com/nmittler/istio.git","ssh_url":"git@github.com:nmittler/istio.git","clone_url":"https://github.com/nmittler/istio.git","svn_url":"https://github.com/nmittler/istio","homepage":"https://istio.io","size":112675,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:test-framework","ref":"test-framework","sha":"5bb7b509e09cebfefe94910d7d0fe57101c34970","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-04-23T19:07:47Z","pushed_at":"2018-04-23T19:51:26Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":106659,"stargazers_count":7447,"watchers_count":7447,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":974,"mirror_url":null,"archived":false,"open_issues_count":785,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":974,"open_issues":785,"watchers":7447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/5128"},"html":{"href":"https://github.com/istio/istio/pull/5128"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/5128"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/5128/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/5128/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/5128/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/ddc79b68a3242bae16a16013ea8e9e2992da56cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ozevren"}}