{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments/189375240","pull_request_review_id":121548872,"id":189375240,"diff_hunk":"@@ -201,12 +212,20 @@ private Environment getRemoteEnvironment(RestTemplate restTemplate, ConfigClient\n \t\t\t\tthrow e;\n \t\t\t}\n \t\t}\n-\n+\t\tcatch(ResourceAccessException e) {\n+\t\t\tlogger.info(\"Connect Timeout Exception on Url-\"+uri+\".Will be trying the next url if available\");\n+\t\t\tif(i==noOfUrls-1)\n+\t\t\t\tthrow e;\n+\t\t\telse\n+\t\t\t\tcontinue;\n+\t\t}\n \t\tif (response == null || response.getStatusCode() != HttpStatus.OK) {\n \t\t\treturn null;\n \t\t}\n \t\tEnvironment result = response.getBody();\n \t\treturn result;\n+\t\t}","path":"spring-cloud-config-client/src/main/java/org/springframework/cloud/config/client/ConfigServicePropertySourceLocator.java","position":94,"original_position":94,"commit_id":"86cc867f20651a8eeae112aa92837d02de35ec8c","original_commit_id":"86cc867f20651a8eeae112aa92837d02de35ec8c","user":{"login":"ryanjbaxter","id":524254,"avatar_url":"https://avatars1.githubusercontent.com/u/524254?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjbaxter","html_url":"https://github.com/ryanjbaxter","followers_url":"https://api.github.com/users/ryanjbaxter/followers","following_url":"https://api.github.com/users/ryanjbaxter/following{/other_user}","gists_url":"https://api.github.com/users/ryanjbaxter/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjbaxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjbaxter/subscriptions","organizations_url":"https://api.github.com/users/ryanjbaxter/orgs","repos_url":"https://api.github.com/users/ryanjbaxter/repos","events_url":"https://api.github.com/users/ryanjbaxter/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjbaxter/received_events","type":"User","site_admin":false},"body":"spacing","created_at":"2018-05-18T19:44:41Z","updated_at":"2018-05-18T19:46:47Z","html_url":"https://github.com/spring-cloud/spring-cloud-config/pull/1017#discussion_r189375240","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments/189375240"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-config/pull/1017#discussion_r189375240"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017","id":188916014,"html_url":"https://github.com/spring-cloud/spring-cloud-config/pull/1017","diff_url":"https://github.com/spring-cloud/spring-cloud-config/pull/1017.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-config/pull/1017.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/1017","number":1017,"state":"open","locked":false,"title":"Changes for High Availability for the config Server","user":{"login":"indraneelb1903","id":15349225,"avatar_url":"https://avatars3.githubusercontent.com/u/15349225?v=4","gravatar_id":"","url":"https://api.github.com/users/indraneelb1903","html_url":"https://github.com/indraneelb1903","followers_url":"https://api.github.com/users/indraneelb1903/followers","following_url":"https://api.github.com/users/indraneelb1903/following{/other_user}","gists_url":"https://api.github.com/users/indraneelb1903/gists{/gist_id}","starred_url":"https://api.github.com/users/indraneelb1903/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indraneelb1903/subscriptions","organizations_url":"https://api.github.com/users/indraneelb1903/orgs","repos_url":"https://api.github.com/users/indraneelb1903/repos","events_url":"https://api.github.com/users/indraneelb1903/events{/privacy}","received_events_url":"https://api.github.com/users/indraneelb1903/received_events","type":"User","site_admin":false},"body":"Original Issue is here - https://github.com/spring-cloud/spring-cloud-config/issues/87\r\n\r\nI have made the changes required to support multiple urls for the config-Server. One can mention multiple urls under the property **spring.cloud.config.uri** or if one is using service discovery like Eureka, the config Client will consider all the instances registered in service locator. \r\n\r\nLike I have mentioned in my comments in the issue above, the definition of a configServer being UP is subjective. As, we want 'high availability' ,I am only considering further urls( if multiple urls are given) , if there is a ResourceAccessException(Connect Exception) thrown while fetching properties from the current url. Any error with status code of 401,403,500 etc indicates issue in the security configuration on the client/server side , yaml files in invalid format etc, and it needs rectification.    \r\n","created_at":"2018-05-18T03:57:07Z","updated_at":"2018-05-18T19:46:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"577dcc3b8bb3c98790e45ae76c7d49f559a7efcf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/1017/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/statuses/86cc867f20651a8eeae112aa92837d02de35ec8c","head":{"label":"indraneelb1903:master","ref":"master","sha":"86cc867f20651a8eeae112aa92837d02de35ec8c","user":{"login":"indraneelb1903","id":15349225,"avatar_url":"https://avatars3.githubusercontent.com/u/15349225?v=4","gravatar_id":"","url":"https://api.github.com/users/indraneelb1903","html_url":"https://github.com/indraneelb1903","followers_url":"https://api.github.com/users/indraneelb1903/followers","following_url":"https://api.github.com/users/indraneelb1903/following{/other_user}","gists_url":"https://api.github.com/users/indraneelb1903/gists{/gist_id}","starred_url":"https://api.github.com/users/indraneelb1903/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indraneelb1903/subscriptions","organizations_url":"https://api.github.com/users/indraneelb1903/orgs","repos_url":"https://api.github.com/users/indraneelb1903/repos","events_url":"https://api.github.com/users/indraneelb1903/events{/privacy}","received_events_url":"https://api.github.com/users/indraneelb1903/received_events","type":"User","site_admin":false},"repo":{"id":133741615,"name":"spring-cloud-config","full_name":"indraneelb1903/spring-cloud-config","owner":{"login":"indraneelb1903","id":15349225,"avatar_url":"https://avatars3.githubusercontent.com/u/15349225?v=4","gravatar_id":"","url":"https://api.github.com/users/indraneelb1903","html_url":"https://github.com/indraneelb1903","followers_url":"https://api.github.com/users/indraneelb1903/followers","following_url":"https://api.github.com/users/indraneelb1903/following{/other_user}","gists_url":"https://api.github.com/users/indraneelb1903/gists{/gist_id}","starred_url":"https://api.github.com/users/indraneelb1903/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indraneelb1903/subscriptions","organizations_url":"https://api.github.com/users/indraneelb1903/orgs","repos_url":"https://api.github.com/users/indraneelb1903/repos","events_url":"https://api.github.com/users/indraneelb1903/events{/privacy}","received_events_url":"https://api.github.com/users/indraneelb1903/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indraneelb1903/spring-cloud-config","description":"External configuration (server and client) for Spring Cloud","fork":true,"url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config","forks_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/forks","keys_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/teams","hooks_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/hooks","issue_events_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/issues/events{/number}","events_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/events","assignees_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/assignees{/user}","branches_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/branches{/branch}","tags_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/tags","blobs_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/statuses/{sha}","languages_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/languages","stargazers_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/stargazers","contributors_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/contributors","subscribers_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/subscribers","subscription_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/subscription","commits_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/contents/{+path}","compare_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/merges","archive_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/downloads","issues_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/issues{/number}","pulls_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/pulls{/number}","milestones_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/milestones{/number}","notifications_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/labels{/name}","releases_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/releases{/id}","deployments_url":"https://api.github.com/repos/indraneelb1903/spring-cloud-config/deployments","created_at":"2018-05-17T01:22:37Z","updated_at":"2018-05-18T03:36:52Z","pushed_at":"2018-05-18T03:36:50Z","git_url":"git://github.com/indraneelb1903/spring-cloud-config.git","ssh_url":"git@github.com:indraneelb1903/spring-cloud-config.git","clone_url":"https://github.com/indraneelb1903/spring-cloud-config.git","svn_url":"https://github.com/indraneelb1903/spring-cloud-config","homepage":"","size":33640,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"ab35034b989bcb4f91626dff15af018f6ec679eb","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":20811348,"name":"spring-cloud-config","full_name":"spring-cloud/spring-cloud-config","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-config","description":"External configuration (server and client) for Spring Cloud","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-config","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/deployments","created_at":"2014-06-13T16:59:44Z","updated_at":"2018-05-18T16:29:00Z","pushed_at":"2018-05-18T16:27:27Z","git_url":"git://github.com/spring-cloud/spring-cloud-config.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-config.git","clone_url":"https://github.com/spring-cloud/spring-cloud-config.git","svn_url":"https://github.com/spring-cloud/spring-cloud-config","homepage":"","size":33694,"stargazers_count":886,"watchers_count":886,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":666,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":666,"open_issues":192,"watchers":886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-config/pull/1017"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/1017"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/statuses/86cc867f20651a8eeae112aa92837d02de35ec8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ryanjbaxter"}}