{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/comments/211107060","pull_request_review_id":147462994,"id":211107060,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEwNzA2MA==","diff_hunk":"@@ -19,14 +19,6 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla\n         return $platform->getVarcharTypeDeclarationSQL($fieldDeclaration);\n     }\n \n-    /**\n-     * {@inheritdoc}\n-     */\n-    public function getDefaultLength(AbstractPlatform $platform)\n-    {\n-        return $platform->getVarcharDefaultLength();","path":"lib/Doctrine/DBAL/Types/StringType.php","position":9,"original_position":9,"commit_id":"1306c3d08f370a55d2ce9b44f9dbcdca474ac654","original_commit_id":"1306c3d08f370a55d2ce9b44f9dbcdca474ac654","user":{"login":"Ocramius","id":154256,"node_id":"MDQ6VXNlcjE1NDI1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"Completely unspecified length is probably better: should be explicitly specified by developers anyway.","created_at":"2018-08-19T15:45:30Z","updated_at":"2018-08-19T15:45:30Z","html_url":"https://github.com/doctrine/dbal/pull/3255#discussion_r211107060","pull_request_url":"https://api.github.com/repos/doctrine/dbal/pulls/3255","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments/211107060"},"html":{"href":"https://github.com/doctrine/dbal/pull/3255#discussion_r211107060"},"pull_request":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3255"}},"in_reply_to_id":211107019},"pull_request":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/3255","id":209246373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjQ2Mzcz","html_url":"https://github.com/doctrine/dbal/pull/3255","diff_url":"https://github.com/doctrine/dbal/pull/3255.diff","patch_url":"https://github.com/doctrine/dbal/pull/3255.patch","issue_url":"https://api.github.com/repos/doctrine/dbal/issues/3255","number":3255,"state":"open","locked":false,"title":"Remove Doctrine\\DBAL\\Types\\Type::getDefaultLength()","user":{"login":"Majkl578","id":144181,"node_id":"MDQ6VXNlcjE0NDE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/144181?v=4","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"body":"|      Q       |   A\r\n|------------- | -----------\r\n| Type         | improvement\r\n| BC Break     | yes\r\n\r\n#### Summary\r\n\r\nNot used by DBAL itself, only overridden by StringType. Some other types (DateIntervalType) hardcode limits in `getSQLDeclaration()` directly.\r\n\r\n1st step towards #2841 (_Refactoring type system_).","created_at":"2018-08-17T20:11:45Z","updated_at":"2018-08-19T15:45:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b4469d3fded38d7c1f311c873a2b95792c71f61","assignee":{"login":"Ocramius","id":154256,"node_id":"MDQ6VXNlcjE1NDI1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ocramius","id":154256,"node_id":"MDQ6VXNlcjE1NDI1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":308827849,"node_id":"MDU6TGFiZWwzMDg4Mjc4NDk=","url":"https://api.github.com/repos/doctrine/dbal/labels/BC%20Break","name":"BC Break","color":"e11d21","default":false},{"id":225630784,"node_id":"MDU6TGFiZWwyMjU2MzA3ODQ=","url":"https://api.github.com/repos/doctrine/dbal/labels/Improvement","name":"Improvement","color":"0052cc","default":false},{"id":308808049,"node_id":"MDU6TGFiZWwzMDg4MDgwNDk=","url":"https://api.github.com/repos/doctrine/dbal/labels/Types","name":"Types","color":"bfe5bf","default":false}],"milestone":{"url":"https://api.github.com/repos/doctrine/dbal/milestones/3","html_url":"https://github.com/doctrine/dbal/milestone/3","labels_url":"https://api.github.com/repos/doctrine/dbal/milestones/3/labels","id":1446225,"node_id":"MDk6TWlsZXN0b25lMTQ0NjIyNQ==","number":3,"title":"3.0.0","description":"","creator":{"login":"beberlei","id":26936,"node_id":"MDQ6VXNlcjI2OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/26936?v=4","gravatar_id":"","url":"https://api.github.com/users/beberlei","html_url":"https://github.com/beberlei","followers_url":"https://api.github.com/users/beberlei/followers","following_url":"https://api.github.com/users/beberlei/following{/other_user}","gists_url":"https://api.github.com/users/beberlei/gists{/gist_id}","starred_url":"https://api.github.com/users/beberlei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beberlei/subscriptions","organizations_url":"https://api.github.com/users/beberlei/orgs","repos_url":"https://api.github.com/users/beberlei/repos","events_url":"https://api.github.com/users/beberlei/events{/privacy}","received_events_url":"https://api.github.com/users/beberlei/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":32,"state":"open","created_at":"2015-12-06T13:18:43Z","updated_at":"2018-08-19T15:44:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/doctrine/dbal/pulls/3255/commits","review_comments_url":"https://api.github.com/repos/doctrine/dbal/pulls/3255/comments","review_comment_url":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/dbal/issues/3255/comments","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/1306c3d08f370a55d2ce9b44f9dbcdca474ac654","head":{"label":"Majkl578:dev/removal/Type-getDefaultLength","ref":"dev/removal/Type-getDefaultLength","sha":"1306c3d08f370a55d2ce9b44f9dbcdca474ac654","user":{"login":"Majkl578","id":144181,"node_id":"MDQ6VXNlcjE0NDE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/144181?v=4","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"repo":{"id":4296125,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjk2MTI1","name":"doctrine-dbal","full_name":"Majkl578/doctrine-dbal","owner":{"login":"Majkl578","id":144181,"node_id":"MDQ6VXNlcjE0NDE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/144181?v=4","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Majkl578/doctrine-dbal","description":"Doctrine Database Abstraction Layer","fork":true,"url":"https://api.github.com/repos/Majkl578/doctrine-dbal","forks_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/forks","keys_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/teams","hooks_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/hooks","issue_events_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/issues/events{/number}","events_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/events","assignees_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/assignees{/user}","branches_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/branches{/branch}","tags_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/tags","blobs_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/languages","stargazers_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/stargazers","contributors_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/contributors","subscribers_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/subscribers","subscription_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/subscription","commits_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/contents/{+path}","compare_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/merges","archive_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/downloads","issues_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/issues{/number}","pulls_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/labels{/name}","releases_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/releases{/id}","deployments_url":"https://api.github.com/repos/Majkl578/doctrine-dbal/deployments","created_at":"2012-05-11T11:20:00Z","updated_at":"2013-01-09T03:33:47Z","pushed_at":"2018-08-18T19:35:43Z","git_url":"git://github.com/Majkl578/doctrine-dbal.git","ssh_url":"git@github.com:Majkl578/doctrine-dbal.git","clone_url":"https://github.com/Majkl578/doctrine-dbal.git","svn_url":"https://github.com/Majkl578/doctrine-dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":24178,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"doctrine:develop","ref":"develop","sha":"b59f84b15a6bdeaa1556b37ae4cdeddc44d8677c","user":{"login":"doctrine","id":209254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTI1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677464,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzc0NjQ=","name":"dbal","full_name":"doctrine/dbal","owner":{"login":"doctrine","id":209254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTI1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/dbal","description":"Doctrine Database Abstraction Layer","fork":false,"url":"https://api.github.com/repos/doctrine/dbal","forks_url":"https://api.github.com/repos/doctrine/dbal/forks","keys_url":"https://api.github.com/repos/doctrine/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/dbal/teams","hooks_url":"https://api.github.com/repos/doctrine/dbal/hooks","issue_events_url":"https://api.github.com/repos/doctrine/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/dbal/events","assignees_url":"https://api.github.com/repos/doctrine/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/dbal/tags","blobs_url":"https://api.github.com/repos/doctrine/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/dbal/languages","stargazers_url":"https://api.github.com/repos/doctrine/dbal/stargazers","contributors_url":"https://api.github.com/repos/doctrine/dbal/contributors","subscribers_url":"https://api.github.com/repos/doctrine/dbal/subscribers","subscription_url":"https://api.github.com/repos/doctrine/dbal/subscription","commits_url":"https://api.github.com/repos/doctrine/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/dbal/merges","archive_url":"https://api.github.com/repos/doctrine/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/dbal/downloads","issues_url":"https://api.github.com/repos/doctrine/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/dbal/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/dbal/deployments","created_at":"2010-05-20T17:01:42Z","updated_at":"2018-08-19T13:53:28Z","pushed_at":"2018-08-18T20:42:02Z","git_url":"git://github.com/doctrine/dbal.git","ssh_url":"git@github.com:doctrine/dbal.git","clone_url":"https://github.com/doctrine/dbal.git","svn_url":"https://github.com/doctrine/dbal","homepage":"https://www.doctrine-project.org/projects/dbal.html","size":24904,"stargazers_count":3059,"watchers_count":3059,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":900,"mirror_url":null,"archived":false,"open_issues_count":436,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":900,"open_issues":436,"watchers":3059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3255"},"html":{"href":"https://github.com/doctrine/dbal/pull/3255"},"issue":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3255"},"comments":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3255/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3255/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3255/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/dbal/statuses/1306c3d08f370a55d2ce9b44f9dbcdca474ac654"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Ocramius"}}