{"action":"closed","number":3298,"pull_request":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/3298","id":217082007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDgyMDA3","html_url":"https://github.com/toggl/mobileapp/pull/3298","diff_url":"https://github.com/toggl/mobileapp/pull/3298.diff","patch_url":"https://github.com/toggl/mobileapp/pull/3298.patch","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/3298","number":3298,"state":"closed","locked":false,"title":"Fix a crash when presenting a popup window and the activity is not running","user":{"login":"juanlaube","id":8163330,"node_id":"MDQ6VXNlcjgxNjMzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8163330?v=4","gravatar_id":"","url":"https://api.github.com/users/juanlaube","html_url":"https://github.com/juanlaube","followers_url":"https://api.github.com/users/juanlaube/followers","following_url":"https://api.github.com/users/juanlaube/following{/other_user}","gists_url":"https://api.github.com/users/juanlaube/gists{/gist_id}","starred_url":"https://api.github.com/users/juanlaube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanlaube/subscriptions","organizations_url":"https://api.github.com/users/juanlaube/orgs","repos_url":"https://api.github.com/users/juanlaube/repos","events_url":"https://api.github.com/users/juanlaube/events{/privacy}","received_events_url":"https://api.github.com/users/juanlaube/received_events","type":"User","site_admin":false},"body":"## What's this?\r\nAn attempt to fix a crash when presenting a popup window and the activity where it is presented is not running. I couldn't reproduce the issue in the first place, so it's not guaranteed this actually fixes the bug.\r\n\r\n### Relationships\r\n\r\nCloses #3296\r\n\r\n## Why do we want this?\r\n🚫 💥 🤖 \r\n\r\n## How is it done?\r\nBy checking that the activity is not finishing.\r\n\r\n### Side effects\r\nNone.\r\n\r\n## :squid: Permissions\r\nWhenever, anyone.","created_at":"2018-09-20T19:29:52Z","updated_at":"2018-09-21T10:36:26Z","closed_at":"2018-09-21T10:36:26Z","merged_at":null,"merge_commit_sha":"8916bb3b182dbbab04b1110b8b8af3b8cf646461","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":772341325,"node_id":"MDU6TGFiZWw3NzIzNDEzMjU=","url":"https://api.github.com/repos/toggl/mobileapp/labels/android","name":"android","color":"A4C639","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/toggl/mobileapp/pulls/3298/commits","review_comments_url":"https://api.github.com/repos/toggl/mobileapp/pulls/3298/comments","review_comment_url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/3298/comments","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/4cde31f4a5883c6553d86f4096b44436c9509239","head":{"label":"toggl:maybe-fix-popupwindow-crash","ref":"maybe-fix-popupwindow-crash","sha":"4cde31f4a5883c6553d86f4096b44436c9509239","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","private":false,"owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-09-21T08:06:20Z","pushed_at":"2018-09-21T10:35:50Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":25297,"stargazers_count":89,"watchers_count":89,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":164,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":164,"watchers":89,"default_branch":"develop"}},"base":{"label":"toggl:develop","ref":"develop","sha":"55f1ed1a10a73a154a82d8a8be5014ab46ffcb45","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","private":false,"owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-09-21T08:06:20Z","pushed_at":"2018-09-21T10:35:50Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":25297,"stargazers_count":89,"watchers_count":89,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":164,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":164,"watchers":89,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/3298"},"html":{"href":"https://github.com/toggl/mobileapp/pull/3298"},"issue":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/3298"},"comments":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/3298/comments"},"review_comments":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/3298/comments"},"review_comment":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/3298/commits"},"statuses":{"href":"https://api.github.com/repos/toggl/mobileapp/statuses/4cde31f4a5883c6553d86f4096b44436c9509239"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"juanlaube"}}