{"action":"created","issue":{"url":"https://api.github.com/repos/sparkfun/OpenLCD/issues/12","repository_url":"https://api.github.com/repos/sparkfun/OpenLCD","labels_url":"https://api.github.com/repos/sparkfun/OpenLCD/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/sparkfun/OpenLCD/issues/12/comments","events_url":"https://api.github.com/repos/sparkfun/OpenLCD/issues/12/events","html_url":"https://github.com/sparkfun/OpenLCD/issues/12","id":354890104,"node_id":"MDU6SXNzdWUzNTQ4OTAxMDQ=","number":12,"title":"Create library","user":{"login":"nseidle","id":117102,"node_id":"MDQ6VXNlcjExNzEwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/117102?v=4","gravatar_id":"","url":"https://api.github.com/users/nseidle","html_url":"https://github.com/nseidle","followers_url":"https://api.github.com/users/nseidle/followers","following_url":"https://api.github.com/users/nseidle/following{/other_user}","gists_url":"https://api.github.com/users/nseidle/gists{/gist_id}","starred_url":"https://api.github.com/users/nseidle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nseidle/subscriptions","organizations_url":"https://api.github.com/users/nseidle/orgs","repos_url":"https://api.github.com/users/nseidle/repos","events_url":"https://api.github.com/users/nseidle/events{/privacy}","received_events_url":"https://api.github.com/users/nseidle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-08-28T20:25:34Z","updated_at":"2018-09-14T16:59:33Z","closed_at":null,"author_association":"MEMBER","body":"We should really write a library for this device. It would be much easier if a .begin() function took a TwoWire, Serial, or SPI stream and then over-wrote the .print function. We did this on the Qwiic OpenLog product."},"comment":{"url":"https://api.github.com/repos/sparkfun/OpenLCD/issues/comments/421421258","html_url":"https://github.com/sparkfun/OpenLCD/issues/12#issuecomment-421421258","issue_url":"https://api.github.com/repos/sparkfun/OpenLCD/issues/12","id":421421258,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQyMTI1OA==","user":{"login":"nseidle","id":117102,"node_id":"MDQ6VXNlcjExNzEwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/117102?v=4","gravatar_id":"","url":"https://api.github.com/users/nseidle","html_url":"https://github.com/nseidle","followers_url":"https://api.github.com/users/nseidle/followers","following_url":"https://api.github.com/users/nseidle/following{/other_user}","gists_url":"https://api.github.com/users/nseidle/gists{/gist_id}","starred_url":"https://api.github.com/users/nseidle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nseidle/subscriptions","organizations_url":"https://api.github.com/users/nseidle/orgs","repos_url":"https://api.github.com/users/nseidle/repos","events_url":"https://api.github.com/users/nseidle/events{/privacy}","received_events_url":"https://api.github.com/users/nseidle/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T16:59:33Z","updated_at":"2018-09-14T16:59:33Z","author_association":"MEMBER","body":"This is really good. I'm going through converting it to fit our lib format. Couple things:\r\n\r\n* You shouldn't do a Wire.setClock() before lcd.begin because the .begin() does a Wire.begin which reset the clock back to 100kHz. The fix is to move Wire.setClock after lcd.begin.\r\n* Lots of examples is *really* good. But it's hard to tell where to begin. We put 'ExampleX-' before each example name so it's clear how the examples escalate.\r\n* I changed name to \"SerLCD\" (dropped Qwiic) since your lib looks to work (nice job!) with SPI. We'll make it work with serial as well. We'll have to tailor a few examples (sub directories) so user knows which examples go with which communication protocol."}}
{"actor":{"display_login":"nseidle"}}