{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67252","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67252/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67252/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67252/events","html_url":"https://github.com/kubernetes/kubernetes/pull/67252","id":349494194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTk1MTcz","number":67252,"title":"Improve HPA sample sanitization","user":{"login":"jbartosik","id":277062,"node_id":"MDQ6VXNlcjI3NzA2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/277062?v=4","gravatar_id":"","url":"https://api.github.com/users/jbartosik","html_url":"https://github.com/jbartosik","followers_url":"https://api.github.com/users/jbartosik/followers","following_url":"https://api.github.com/users/jbartosik/following{/other_user}","gists_url":"https://api.github.com/users/jbartosik/gists{/gist_id}","starred_url":"https://api.github.com/users/jbartosik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbartosik/subscriptions","organizations_url":"https://api.github.com/users/jbartosik/orgs","repos_url":"https://api.github.com/users/jbartosik/repos","events_url":"https://api.github.com/users/jbartosik/events{/privacy}","received_events_url":"https://api.github.com/users/jbartosik/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-10T12:19:08Z","updated_at":"2018-08-10T12:19:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67252","html_url":"https://github.com/kubernetes/kubernetes/pull/67252","diff_url":"https://github.com/kubernetes/kubernetes/pull/67252.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/67252.patch"},"body":"**What this PR does / why we need it**: @mwielgus pointed out a case when HPA fails as a result of my changes to HPA algorithm:\r\n- Have pods that use a lot of CPU during initilization, become ready right after they initialize,\r\n- Trigger a scale up,\r\n- When new pods become ready will will count their usage (even though it's not related to any work that needs doing),\r\n- This triggers another scale up, even though existing pods can handle work, no problem.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/412065604","html_url":"https://github.com/kubernetes/kubernetes/pull/67252#issuecomment-412065604","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67252","id":412065604,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjA2NTYwNA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T12:19:16Z","updated_at":"2018-08-10T12:19:16Z","author_association":"COLLABORATOR","body":"Hi @jbartosik. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}