{"action":"closed","number":5581,"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5581","id":187751040,"html_url":"https://github.com/istio/istio/pull/5581","diff_url":"https://github.com/istio/istio/pull/5581.diff","patch_url":"https://github.com/istio/istio/pull/5581.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/5581","number":5581,"state":"closed","locked":false,"title":"Provide default requested resources for cpu/mem for sidecar","user":{"login":"ymesika","id":26809068,"avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"body":"Adding resources limits/requests default values to injected sidecar configuration.\r\nInjected sidecar can be injected either manually or automatically.\r\nThe update of the helm charts for istio-injector will add the default values to the automatically injected sidecar while the update of the istioctl will add it to the manually injected (when users runs istioctl kube-inject).\r\n\r\nReplaces #5358\r\nFixes #5175\r\n\r\n/hold","created_at":"2018-05-14T08:20:21Z","updated_at":"2018-05-14T16:56:23Z","closed_at":"2018-05-14T16:56:23Z","merged_at":null,"merge_commit_sha":"a12fbf904ae7df86aac86da2e4c6d39d01be8887","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":780123031,"url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/5581/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/5581/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/5581/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/953b46beb47bc50a3dc72845c8328bd60a36d36c","head":{"label":"ymesika:issue-5175","ref":"issue-5175","sha":"953b46beb47bc50a3dc72845c8328bd60a36d36c","user":{"login":"ymesika","id":26809068,"avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"repo":{"id":109562402,"name":"istio","full_name":"ymesika/istio","owner":{"login":"ymesika","id":26809068,"avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ymesika/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/ymesika/istio","forks_url":"https://api.github.com/repos/ymesika/istio/forks","keys_url":"https://api.github.com/repos/ymesika/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ymesika/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ymesika/istio/teams","hooks_url":"https://api.github.com/repos/ymesika/istio/hooks","issue_events_url":"https://api.github.com/repos/ymesika/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ymesika/istio/events","assignees_url":"https://api.github.com/repos/ymesika/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ymesika/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ymesika/istio/tags","blobs_url":"https://api.github.com/repos/ymesika/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ymesika/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ymesika/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ymesika/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ymesika/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ymesika/istio/languages","stargazers_url":"https://api.github.com/repos/ymesika/istio/stargazers","contributors_url":"https://api.github.com/repos/ymesika/istio/contributors","subscribers_url":"https://api.github.com/repos/ymesika/istio/subscribers","subscription_url":"https://api.github.com/repos/ymesika/istio/subscription","commits_url":"https://api.github.com/repos/ymesika/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ymesika/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ymesika/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ymesika/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ymesika/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ymesika/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ymesika/istio/merges","archive_url":"https://api.github.com/repos/ymesika/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ymesika/istio/downloads","issues_url":"https://api.github.com/repos/ymesika/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ymesika/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ymesika/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ymesika/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ymesika/istio/labels{/name}","releases_url":"https://api.github.com/repos/ymesika/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ymesika/istio/deployments","created_at":"2017-11-05T09:15:48Z","updated_at":"2018-05-13T07:28:45Z","pushed_at":"2018-05-14T15:38:06Z","git_url":"git://github.com/ymesika/istio.git","ssh_url":"git@github.com:ymesika/istio.git","clone_url":"https://github.com/ymesika/istio.git","svn_url":"https://github.com/ymesika/istio","homepage":"https://istio.io","size":32167,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-0.8","ref":"release-0.8","sha":"05f6d18b1a594d76c378b31eb36ce53754ec6f8d","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-05-14T15:51:59Z","pushed_at":"2018-05-14T16:48:54Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":32985,"stargazers_count":7972,"watchers_count":7972,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1069,"mirror_url":null,"archived":false,"open_issues_count":863,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1069,"open_issues":863,"watchers":7972,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/5581"},"html":{"href":"https://github.com/istio/istio/pull/5581"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/5581"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/5581/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/5581/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/5581/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/953b46beb47bc50a3dc72845c8328bd60a36d36c"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":323,"deletions":70,"changed_files":36}}
{"actor":{"display_login":"ymesika"}}