{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61818","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61818/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61818/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61818/events","html_url":"https://github.com/kubernetes/kubernetes/pull/61818","id":309263226,"number":61818,"title":"Add CRI container log format support back for elastic search.","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"labels":[{"id":242155350,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cherrypick-candidate","name":"cherrypick-candidate","color":"fef2c0","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":711852570,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/milestone/incomplete-labels","name":"milestone/incomplete-labels","color":"ededed","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":482207917,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/instrumentation","name":"sig/instrumentation","color":"d2b48c","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"coffeepac","id":677786,"avatar_url":"https://avatars3.githubusercontent.com/u/677786?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeepac","html_url":"https://github.com/coffeepac","followers_url":"https://api.github.com/users/coffeepac/followers","following_url":"https://api.github.com/users/coffeepac/following{/other_user}","gists_url":"https://api.github.com/users/coffeepac/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeepac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeepac/subscriptions","organizations_url":"https://api.github.com/users/coffeepac/orgs","repos_url":"https://api.github.com/users/coffeepac/repos","events_url":"https://api.github.com/users/coffeepac/events{/privacy}","received_events_url":"https://api.github.com/users/coffeepac/received_events","type":"User","site_admin":false},"assignees":[{"login":"coffeepac","id":677786,"avatar_url":"https://avatars3.githubusercontent.com/u/677786?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeepac","html_url":"https://github.com/coffeepac","followers_url":"https://api.github.com/users/coffeepac/followers","following_url":"https://api.github.com/users/coffeepac/following{/other_user}","gists_url":"https://api.github.com/users/coffeepac/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeepac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeepac/subscriptions","organizations_url":"https://api.github.com/users/coffeepac/orgs","repos_url":"https://api.github.com/users/coffeepac/repos","events_url":"https://api.github.com/users/coffeepac/events{/privacy}","received_events_url":"https://api.github.com/users/coffeepac/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/37","html_url":"https://github.com/kubernetes/kubernetes/milestone/37","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/37/labels","id":2659046,"number":37,"title":"v1.10","description":"","creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":471,"state":"open","created_at":"2017-07-24T18:50:54Z","updated_at":"2018-03-28T08:13:50Z","due_on":"2018-03-26T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-03-28T08:13:39Z","updated_at":"2018-03-28T08:53:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61818","html_url":"https://github.com/kubernetes/kubernetes/pull/61818","diff_url":"https://github.com/kubernetes/kubernetes/pull/61818.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61818.patch"},"body":"The CRI container log format support was removed accidentally in https://github.com/kubernetes/kubernetes/pull/58525. This PR adds that back.\r\n\r\nI've tested it, and it works:\r\n```\r\nSSSSS\r\n------------------------------\r\n[sig-instrumentation] Cluster level logging using Elasticsearch [Feature:Elasticsearch] \r\n  should check that logs from containers are ingested into Elasticsearch\r\n  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/instrumentation/logging/elasticsearch/basic.go:39\r\n[BeforeEach] [sig-instrumentation] Cluster level logging using Elasticsearch [Feature:Elasticsearch]\r\n  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:141\r\nSTEP: Creating a kubernetes client\r\nMar 28 08:09:01.724: INFO: >>> kubeConfig: /home/lantaol/.kube/config\r\nSTEP: Building a namespace api object\r\nMar 28 08:09:02.952: INFO: No PodSecurityPolicies found; assuming PodSecurityPolicy is disabled.\r\nSTEP: Waiting for a default service account to be provisioned in namespace\r\n[BeforeEach] [sig-instrumentation] Cluster level logging using Elasticsearch [Feature:Elasticsearch]\r\n  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/instrumentation/logging/elasticsearch/basic.go:32\r\n[It] should check that logs from containers are ingested into Elasticsearch\r\n  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/instrumentation/logging/elasticsearch/basic.go:39\r\nMar 28 08:09:02.988: INFO: Checking the Elasticsearch service exists.\r\nMar 28 08:09:03.025: INFO: Checking to make sure the Elasticsearch pods are running\r\nMar 28 08:09:03.066: INFO: Checking to make sure we are talking to an Elasticsearch service.\r\nMar 28 08:09:03.176: INFO: Checking health of Elasticsearch service.\r\nMar 28 08:09:03.299: INFO: Starting repeating logging pod synthlogger\r\nSTEP: Waiting for logs to ingest\r\nMar 28 08:09:17.420: INFO: Sending a search request to Elasticsearch with the following query: kubernetes.pod_name:synthlogger AND kubernetes.namespace_name:e2e-tests-es-logging-pqlx7\r\nMar 28 08:09:27.420: INFO: Sending a search request to Elasticsearch with the following query: kubernetes.pod_name:synthlogger AND kubernetes.namespace_name:e2e-tests-es-logging-pqlx7\r\nMar 28 08:09:37.420: INFO: Sending a search request to Elasticsearch with the following query: kubernetes.pod_name:synthlogger AND kubernetes.namespace_name:e2e-tests-es-logging-pqlx7\r\nMar 28 08:09:47.420: INFO: Sending a search request to Elasticsearch with the following query: kubernetes.pod_name:synthlogger AND kubernetes.namespace_name:e2e-tests-es-logging-pqlx7\r\nMar 28 08:09:57.420: INFO: Sending a search request to Elasticsearch with the following query: kubernetes.pod_name:synthlogger AND kubernetes.namespace_name:e2e-tests-es-logging-pqlx7\r\nMar 28 08:10:07.420: INFO: Sending a search request to Elasticsearch with the following query: kubernetes.pod_name:synthlogger AND kubernetes.namespace_name:e2e-tests-es-logging-pqlx7\r\n[AfterEach] [sig-instrumentation] Cluster level logging using Elasticsearch [Feature:Elasticsearch]\r\n  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:142\r\nMar 28 08:10:07.607: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready\r\nSTEP: Destroying namespace \"e2e-tests-es-logging-pqlx7\" for this suite.\r\nMar 28 08:10:57.758: INFO: Waiting up to 30s for server preferred namespaced resources to be successfully discovered\r\nMar 28 08:11:00.046: INFO: namespace: e2e-tests-es-logging-pqlx7, resource: bindings, ignored listing per whitelist\r\nMar 28 08:11:00.338: INFO: namespace e2e-tests-es-logging-pqlx7 deletion completed in 52.693713026s\r\n\r\n• [SLOW TEST:118.614 seconds]\r\n[sig-instrumentation] Cluster level logging using Elasticsearch [Feature:Elasticsearch]\r\n/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/instrumentation/common/framework.go:23\r\n  should check that logs from containers are ingested into Elasticsearch\r\n  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/instrumentation/logging/elasticsearch/basic.go:39\r\n------------------------------\r\nSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSMar 28 08:11:00.346: INFO: Running AfterSuite actions on all node\r\nMar 28 08:11:00.346: INFO: Running AfterSuite actions on node 1\r\n\r\nRan 1 of 845 Specs in 123.981 seconds\r\nSUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 844 Skipped PASS\r\n\r\nGinkgo ran 1 suite in 2m4.323020647s\r\nTest Suite Passed\r\n2018/03/28 08:11:00 process.go:152: Step './hack/ginkgo-e2e.sh --ginkgo.focus=Cluster\\slevel\\slogging\\susing\\sElasticsearch' finished in 2m5.943972428s\r\n2018/03/28 08:11:00 e2e.go:83: Done\r\n```\r\n\r\nMark 1.10, because this is a regression for CRI container runtimes in 1.10.\r\n\r\nThe original support was added in 1.9. https://github.com/kubernetes/kubernetes/pull/54777\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nnone\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/376811787","html_url":"https://github.com/kubernetes/kubernetes/pull/61818#issuecomment-376811787","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61818","id":376811787,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T08:53:23Z","updated_at":"2018-03-28T08:53:23Z","author_association":"COLLABORATOR","body":"[MILESTONENOTIFIER] Milestone Pull Request Labels **Incomplete**\n\n@Random-Liu @coffeepac\n\n\n**Action required**: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.10 milestone.\n\n_**kind**_: Must specify exactly one of `kind/bug`, `kind/cleanup` or `kind/feature`.\n_**priority**_: Must specify exactly one of `priority/critical-urgent`, `priority/important-longterm` or `priority/important-soon`.\n\n<details>\n<summary>Help</summary>\n<ul>\n <li><a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/release/issues.md\">Additional instructions</a></li>\n <li><a href=\"https://go.k8s.io/bot-commands\">Commands for setting labels</a></li>\n</ul>\n</details>"}}
{"actor":{"display_login":"k8s-merge-robot"}}