{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/14421","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/14421/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/14421/comments","events_url":"https://api.github.com/repos/keybase/client/issues/14421/events","html_url":"https://github.com/keybase/client/pull/14421","id":374124477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODk3NDM0","number":14421,"title":"remove reselect","user":{"login":"chrisnojima","id":516435,"node_id":"MDQ6VXNlcjUxNjQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/516435?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-25T20:43:13Z","updated_at":"2018-10-26T14:32:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/14421","html_url":"https://github.com/keybase/client/pull/14421","diff_url":"https://github.com/keybase/client/pull/14421.diff","patch_url":"https://github.com/keybase/client/pull/14421.patch"},"body":"this removes reselect\r\nUsed a bunch of old search (which'll be gone soon i hope)\r\nand used once by git and multiavatar\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/433428111","html_url":"https://github.com/keybase/client/pull/14421#issuecomment-433428111","issue_url":"https://api.github.com/repos/keybase/client/issues/14421","id":433428111,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQyODExMQ==","user":{"login":"zanderz","id":862397,"node_id":"MDQ6VXNlcjg2MjM5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/862397?v=4","gravatar_id":"","url":"https://api.github.com/users/zanderz","html_url":"https://github.com/zanderz","followers_url":"https://api.github.com/users/zanderz/followers","following_url":"https://api.github.com/users/zanderz/following{/other_user}","gists_url":"https://api.github.com/users/zanderz/gists{/gist_id}","starred_url":"https://api.github.com/users/zanderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanderz/subscriptions","organizations_url":"https://api.github.com/users/zanderz/orgs","repos_url":"https://api.github.com/users/zanderz/repos","events_url":"https://api.github.com/users/zanderz/events{/privacy}","received_events_url":"https://api.github.com/users/zanderz/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T14:32:10Z","updated_at":"2018-10-26T14:32:10Z","author_association":"CONTRIBUTOR","body":"I got an error clicking around on this branch: searched in chat for team keybase.sf and clicked it, then:\r\n```\r\nGot boundary error: {name: \"Error\", message: \"Invalid empty converationidkey. Did you mean Constants.noConversationIDKey?\", stack: \"Error: Invalid empty converationidkey. Did you mea…///./common-adapters/markdown/shared.js?:372:227)\", componentStack: \"↵    in SimpleMarkdownComponent (created by Markdo…GlobalEscapeHandler (created by Root)↵    in Root\"}componentStack: \"↵    in SimpleMarkdownComponent (created by Markdown)↵    in Markdown (created by MessageText)↵    in MessageText (created by mapProps(MessageText))↵    in mapProps(MessageText) (created by WrapperAuthor)↵    in div (created by Box)↵    in Box (created by WrapperAuthor)↵    in div (created by Box)↵    in Box (created by WrapperAuthor)↵    in div (created by Box)↵    in Box (created by WrapperAuthor)↵    in div (created by Box)↵    in Box (created by WrapperAuthor)↵    in div (created by Box)↵    in Box (created by WrapperAuthor)↵    in WrapperAuthor (created by Connect(WrapperAuthor))↵    in Connect(WrapperAuthor) (created by _WrapperTimestamp)↵    in div (created by Box2)↵    in Box2 (created by _WrapperTimestamp)↵    in div (created by Box)↵    in Box (created by _WrapperTimestamp)↵    in div (created by Box2)↵    in Box2 (created by _WrapperTimestamp)↵    in div (created by Box)↵    in Box (created by _WrapperTimestamp)↵    in _WrapperTimestamp (created by OverlayParent)↵    in OverlayParent (created by Connect(WrapperTimestamp))↵    in Connect(WrapperTimestamp) (created by MessageFactory)↵    in MessageFactory (created by MessageFactory)↵    in MessageFactory (created by Connect(MessageFactory))↵    in Connect(MessageFactory) (created by OrdinalWaypoint)↵    in div (created by Measure)↵    in Measure (created by Measure)↵    in Measure (created by OrdinalWaypoint)↵    in Waypoint (created by OrdinalWaypoint)↵    in OrdinalWaypoint (created by Thread)↵    in div (created by Measure)↵    in div (created by Measure)↵    in Measure (created by Measure)↵    in Measure (created by Thread)↵    in div (created by Thread)↵    in div (created by Thread)↵    in ErrorBoundary (created by Thread)↵    in Thread (created by lifecycle(Thread))↵    in lifecycle(Thread) (created by withStateHandlers(lifecycle(Thread)))↵    in withStateHandlers(lifecycle(Thread)) (created by Connect(withStateHandlers(lifecycle(Thread))))↵    in Connect(withStateHandlers(lifecycle(Thread))) (created by ListArea)↵    in ListArea (created by Connect(ListArea))↵    in Connect(ListArea) (created by Conversation)↵    in div (created by Box)↵    in Box (created by Conversation)↵    in Conversation (created by withStateHandlers(Conversation))↵    in withStateHandlers(Conversation) (created by Connect(withStateHandlers(Conversation)))↵    in Connect(withStateHandlers(Conversation)) (created by Conversation)↵    in Conversation (created by Connect(Conversation))↵    in Connect(Conversation) (created by RenderRouteNode)↵    in RenderRouteNode (created by Nav)↵    in div (created by Render)↵    in Render (created by RenderRouteNode)↵    in RenderRouteNode (created by Nav)↵    in div (created by Box)↵    in Box (created by Nav)↵    in ErrorBoundary (created by Nav)↵    in div (created by Box)↵    in Box (created by Nav)↵    in ErrorBoundary (created by Nav)↵    in Nav (created by Connect(Nav))↵    in Connect(Nav) (created by RenderRouteNode)↵    in RenderRouteNode (created by RenderRoute)↵    in RenderRoute (created by Main)↵    in Main (created by Connect(Main))↵    in Connect(Main) (created by HotExportedConnect(Main))↵    in AppContainer (created by HotExportedConnect(Main))↵    in HotExportedConnect(Main)↵    in div↵    in Provider (created by Root)↵    in GlobalEscapeHandler (created by Root)↵    in Root\"message: \"Invalid empty converationidkey. Did you mean Constants.noConversationIDKey?\"name: \"Error\"stack: \"Error: Invalid empty converationidkey. Did you mean Constants.noConversationIDKey?↵    at Module.s (webpack:///./constants/types/chat2/common.js?:18:11)↵    at Object.channel (webpack:///./common-adapters/markdown/react.js?:295:95)↵    at eval (webpack:///./common-adapters/markdown/react.js?:323:70)↵    at nestedOutput (webpack:///./node_modules/simple-markdown/simple-markdown.js?:1690:20)↵    at nestedOutput (webpack:///./node_modules/simple-markdown/simple-markdown.js?:1677:31)↵    at Object.paragraph (webpack:///./common-adapters/markdown/react.js?:246:8)↵    at eval (webpack:///./common-adapters/markdown/react.js?:323:70)↵    at nestedOutput (webpack:///./node_modules/simple-markdown/simple-markdown.js?:1690:20)↵    at nestedOutput (webpack:///./node_modules/simple-markdown/simple-markdown.js?:1677:31)↵    at ProxyComponent.render (webpack:///./common-adapters/markdown/shared.js?:372:227)\"__proto__: Object\r\n_otherLoggers.map.l @ tee-logger.js:16\r\nTeeLogger.args @ tee-logger.js:16\r\ncomponentDidCatch @ error-boundary.js:151\r\ncomponentDidCatch @ react-hot-loader.development.js:580\r\ncallback @ react-dom.development.js:15441\r\ncallCallback @ react-dom.development.js:11137\r\ncommitUpdateEffects @ react-dom.development.js:11176\r\ncommitUpdateQueue @ react-dom.development.js:11167\r\ncommitLifeCycles @ react-dom.development.js:14841\r\ncommitAllLifeCycles @ react-dom.development.js:16047\r\ncallCallback @ react-dom.development.js:149\r\ninvokeGuardedCallbackDev @ react-dom.development.js:199\r\ninvokeGuardedCallback @ react-dom.development.js:256\r\ncommitRoot @ react-dom.development.js:16201\r\ncompleteRoot @ react-dom.development.js:17576\r\nperformWorkOnRoot @ react-dom.development.js:17504\r\nperformWork @ react-dom.development.js:17408\r\nperformSyncWork @ react-dom.development.js:17380\r\nrequestWork @ react-dom.development.js:17268\r\nscheduleWork @ react-dom.development.js:17073\r\nenqueueSetState @ react-dom.development.js:11631\r\nComponent.setState @ react.development.js:372\r\nonStateChange @ connectAdvanced.js:261\r\nonStateChange @ react-hot-loader.development.js:580\r\nnotify @ Subscription.js:37\r\nnotifyNestedSubs @ Subscription.js:74\r\nonStateChange @ connectAdvanced.js:258\r\nonStateChange @ react-hot-loader.development.js:580\r\nnotify @ Subscription.js:37\r\nnotifyNestedSubs @ Subscription.js:74\r\nonStateChange @ connectAdvanced.js:258\r\nonStateChange @ react-hot-loader.development.js:580\r\nnotify @ Subscription.js:37\r\nnotifyNestedSubs @ Subscription.js:74\r\nonStateChange @ connectAdvanced.js:258\r\nonStateChange @ react-hot-loader.development.js:580\r\nnotify @ Subscription.js:37\r\nnotifyNestedSubs @ Subscription.js:74\r\nonStateChange @ connectAdvanced.js:258\r\nonStateChange @ react-hot-loader.development.js:580\r\nnotify @ Subscription.js:37\r\nnotifyNestedSubs @ Subscription.js:74\r\nonStateChange @ connectAdvanced.js:258\r\nonStateChange @ react-hot-loader.development.js:580\r\ndispatch @ redux.js:222\r\n(anonymous) @ redux-logger.js:1\r\n(anonymous) @ middleware.js:69\r\naction @ configure-store.js:96\r\ndispatch @ redux.js:619\r\n(anonymous) @ utils.js:283\r\n(anonymous) @ proc.js:499\r\nexec @ scheduler.js:23\r\nflush @ scheduler.js:64\r\nasap @ scheduler.js:37\r\nrunPutEffect @ proc.js:496\r\nrunEffect @ proc.js:445\r\nnext @ proc.js:325\r\nproc @ proc.js:280\r\nresolveIterator @ proc.js:466\r\nrunEffect @ proc.js:442\r\nnext @ proc.js:325\r\ncurrCb @ proc.js:398\r\nrunCallEffect @ proc.js:527\r\nrunEffect @ proc.js:445\r\nnext @ proc.js:325\r\ncurrCb @ proc.js:398\r\ntakeCb @ proc.js:476\r\nput @ channel.js:85\r\n(anonymous) @ channel.js:173\r\nsetTimeout @ saga.js:116\r\nsetTimeout (async)\r\nmap.(anonymous function) @ saga.js:110\r\nhandle @ request.js:69\r\nincomingCall @ session.js:185\r\n_rpcIncoming @ index.js:243\r\n_rpcClient.payload @ index.js:102\r\nhandler @ transport-shared.js:112\r\nwrapped @ transport-shared.js:64\r\nexports.Dispatch.Dispatch._serve @ dispatch.js:253\r\nexports.Dispatch.Dispatch._dispatch @ dispatch.js:85\r\nexports.Packetizer.Packetizer._get_msg @ packetizer.js:105\r\nexports.Packetizer.Packetizer.packetize_data @ packetizer.js:118\r\npacketize_data @ index.platform.desktop.js:60\r\n(anonymous) @ transport.js:325\r\nemit @ events.js:182\r\naddChunk @ _stream_readable.js:279\r\nreadableAddChunk @ _stream_readable.js:264\r\nReadable.push @ _stream_readable.js:219\r\nonread @ net.js:636\r\nreact-dom.development.js:14690 The above error occurred in the <SimpleMarkdownComponent> component:\r\n    in SimpleMarkdownComponent (created by Markdown)\r\n    in Markdown (created by MessageText)\r\n    in MessageText (created by mapProps(MessageText))\r\n    in mapProps(MessageText) (created by WrapperAuthor)\r\n    in div (created by Box)\r\n    in Box (created by WrapperAuthor)\r\n    in div (created by Box)\r\n    in Box (created by WrapperAuthor)\r\n    in div (created by Box)\r\n    in Box (created by WrapperAuthor)\r\n    in div (created by Box)\r\n    in Box (created by WrapperAuthor)\r\n    in div (created by Box)\r\n    in Box (created by WrapperAuthor)\r\n    in WrapperAuthor (created by Connect(WrapperAuthor))\r\n    in Connect(WrapperAuthor) (created by _WrapperTimestamp)\r\n    in div (created by Box2)\r\n    in Box2 (created by _WrapperTimestamp)\r\n    in div (created by Box)\r\n    in Box (created by _WrapperTimestamp)\r\n    in div (created by Box2)\r\n    in Box2 (created by _WrapperTimestamp)\r\n    in div (created by Box)\r\n    in Box (created by _WrapperTimestamp)\r\n    in _WrapperTimestamp (created by OverlayParent)\r\n    in OverlayParent (created by Connect(WrapperTimestamp))\r\n    in Connect(WrapperTimestamp) (created by MessageFactory)\r\n    in MessageFactory (created by MessageFactory)\r\n    in MessageFactory (created by Connect(MessageFactory))\r\n    in Connect(MessageFactory) (created by OrdinalWaypoint)\r\n    in div (created by Measure)\r\n    in Measure (created by Measure)\r\n    in Measure (created by OrdinalWaypoint)\r\n    in Waypoint (created by OrdinalWaypoint)\r\n    in OrdinalWaypoint (created by Thread)\r\n    in div (created by Measure)\r\n    in div (created by Measure)\r\n    in Measure (created by Measure)\r\n    in Measure (created by Thread)\r\n    in div (created by Thread)\r\n    in div (created by Thread)\r\n    in ErrorBoundary (created by Thread)\r\n    in Thread (created by lifecycle(Thread))\r\n    in lifecycle(Thread) (created by withStateHandlers(lifecycle(Thread)))\r\n    in withStateHandlers(lifecycle(Thread)) (created by Connect(withStateHandlers(lifecycle(Thread))))\r\n    in Connect(withStateHandlers(lifecycle(Thread))) (created by ListArea)\r\n    in ListArea (created by Connect(ListArea))\r\n    in Connect(ListArea) (created by Conversation)\r\n    in div (created by Box)\r\n    in Box (created by Conversation)\r\n    in Conversation (created by withStateHandlers(Conversation))\r\n    in withStateHandlers(Conversation) (created by Connect(withStateHandlers(Conversation)))\r\n    in Connect(withStateHandlers(Conversation)) (created by Conversation)\r\n    in Conversation (created by Connect(Conversation))\r\n    in Connect(Conversation) (created by RenderRouteNode)\r\n    in RenderRouteNode (created by Nav)\r\n    in div (created by Render)\r\n    in Render (created by RenderRouteNode)\r\n    in RenderRouteNode (created by Nav)\r\n    in div (created by Box)\r\n    in Box (created by Nav)\r\n    in ErrorBoundary (created by Nav)\r\n    in div (created by Box)\r\n    in Box (created by Nav)\r\n    in ErrorBoundary (created by Nav)\r\n    in Nav (created by Connect(Nav))\r\n    in Connect(Nav) (created by RenderRouteNode)\r\n    in RenderRouteNode (created by RenderRoute)\r\n    in RenderRoute (created by Main)\r\n    in Main (created by Connect(Main))\r\n    in Connect(Main) (created by HotExportedConnect(Main))\r\n    in AppContainer (created by HotExportedConnect(Main))\r\n    in HotExportedConnect(Main)\r\n    in div\r\n    in Provider (created by Root)\r\n    in GlobalEscapeHandler (created by Root)\r\n    in Root\r\n\r\nReact will try to recreate this component tree from scratch using the error boundary you provided, ErrorBoundary.\r\n```\r\nswitched back to master and it was ok"}}
{"actor":{"display_login":"zanderz"}}