{"action":"created","issue":{"url":"https://api.github.com/repos/bbatsov/solarized-emacs/issues/282","repository_url":"https://api.github.com/repos/bbatsov/solarized-emacs","labels_url":"https://api.github.com/repos/bbatsov/solarized-emacs/issues/282/labels{/name}","comments_url":"https://api.github.com/repos/bbatsov/solarized-emacs/issues/282/comments","events_url":"https://api.github.com/repos/bbatsov/solarized-emacs/issues/282/events","html_url":"https://github.com/bbatsov/solarized-emacs/pull/282","id":284470821,"number":282,"title":"Fix #194 Unified diff diff-hl ediff and smerge faces","user":{"login":"wyuenho","id":160028,"avatar_url":"https://avatars1.githubusercontent.com/u/160028?v=4","gravatar_id":"","url":"https://api.github.com/users/wyuenho","html_url":"https://github.com/wyuenho","followers_url":"https://api.github.com/users/wyuenho/followers","following_url":"https://api.github.com/users/wyuenho/following{/other_user}","gists_url":"https://api.github.com/users/wyuenho/gists{/gist_id}","starred_url":"https://api.github.com/users/wyuenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyuenho/subscriptions","organizations_url":"https://api.github.com/users/wyuenho/orgs","repos_url":"https://api.github.com/users/wyuenho/repos","events_url":"https://api.github.com/users/wyuenho/events{/privacy}","received_events_url":"https://api.github.com/users/wyuenho/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-12-25T22:00:27Z","updated_at":"2018-03-16T16:05:55Z","closed_at":"2018-03-15T10:22:08Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bbatsov/solarized-emacs/pulls/282","html_url":"https://github.com/bbatsov/solarized-emacs/pull/282","diff_url":"https://github.com/bbatsov/solarized-emacs/pull/282.diff","patch_url":"https://github.com/bbatsov/solarized-emacs/pull/282.patch"},"body":"This should fix #192 and #134. In this PR I've unified the colors as much as I could. Some modes have extra faces for changed blocks, in contexts where there are only 2 major color values (red and green), I've used yellow to indicate changes. When there's more, I've used blue-lc background and cyan-hc foreground to make the text more legible.\r\n\r\nWhen outside of changed blocks (added and deleted), the foreground is highlighted with a slightly higher contrast color (base3), for legibility again. Font locking weights and slants are removed in all hunks to improved legibility.\r\n\r\nFor diff and ediff, refined blocks are highlighted by using the high contrast version of the background color on the foreground. They are underlined too.\r\n\r\nFor ediff and smerge, anything other than the hunks are only subtlely highlighted to minimize distraction.\r\n\r\nOh, did I mention there's smerge theme now? Merry Christmas!\r\n\r\n<img width=\"1440\" alt=\"screen shot 2017-12-25 at 20 02 28\" src=\"https://user-images.githubusercontent.com/160028/34343085-f66ceb9a-e9bb-11e7-92ce-3205482ba1f9.png\">\r\n<img width=\"1440\" alt=\"screen shot 2017-12-25 at 20 03 02\" src=\"https://user-images.githubusercontent.com/160028/34343087-f67fdc3c-e9bb-11e7-9a83-b02a5fba515a.png\">\r\n<img width=\"1440\" alt=\"screen shot 2017-12-25 at 20 05 36\" src=\"https://user-images.githubusercontent.com/160028/34343088-f6926960-e9bb-11e7-9c80-5a9723c3aaf1.png\">\r\n<img width=\"1440\" alt=\"screen shot 2017-12-25 at 20 06 18\" src=\"https://user-images.githubusercontent.com/160028/34343089-f6a86436-e9bb-11e7-8c97-8e2120c7eca7.png\">\r\n<img width=\"1440\" alt=\"screen shot 2017-12-25 at 21 26 53\" src=\"https://user-images.githubusercontent.com/160028/34343090-f6bb1b26-e9bb-11e7-9ba7-a2291c523de3.png\">\r\n<img width=\"1440\" alt=\"screen shot 2017-12-25 at 21 28 31\" src=\"https://user-images.githubusercontent.com/160028/34343091-f6cdbcb8-e9bb-11e7-86d3-f536af3c2337.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/bbatsov/solarized-emacs/issues/comments/373761776","html_url":"https://github.com/bbatsov/solarized-emacs/pull/282#issuecomment-373761776","issue_url":"https://api.github.com/repos/bbatsov/solarized-emacs/issues/282","id":373761776,"user":{"login":"tarsius","id":25046,"avatar_url":"https://avatars2.githubusercontent.com/u/25046?v=4","gravatar_id":"","url":"https://api.github.com/users/tarsius","html_url":"https://github.com/tarsius","followers_url":"https://api.github.com/users/tarsius/followers","following_url":"https://api.github.com/users/tarsius/following{/other_user}","gists_url":"https://api.github.com/users/tarsius/gists{/gist_id}","starred_url":"https://api.github.com/users/tarsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarsius/subscriptions","organizations_url":"https://api.github.com/users/tarsius/orgs","repos_url":"https://api.github.com/users/tarsius/repos","events_url":"https://api.github.com/users/tarsius/events{/privacy}","received_events_url":"https://api.github.com/users/tarsius/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T16:05:55Z","updated_at":"2018-03-16T16:05:55Z","author_association":"CONTRIBUTOR","body":"> I have also spent many hours on diff mode(s) faces :)\r\n\r\nI was talking about the Magit faces when I said \"they is me\". Didn't want to imply I did all the work."}}
{"actor":{"display_login":"tarsius"}}