{"action":"created","comment":{"url":"https://api.github.com/repos/capsule8/capsule8/pulls/comments/171627554","pull_request_review_id":100514650,"id":171627554,"diff_hunk":"@@ -61,7 +61,7 @@ BINS=$(patsubst %,bin/%,$(CMDS)) \\\n \ttest/functional/functional.test\n \n # All source directories that need to be checked, compiled, tested, etc.\n-SRC=./cmd/... ./pkg/... ./examples/...\n+SRC=./cmd/... ./pkg/... ./examples/... ./test/benchmark/...","path":"Makefile","position":5,"original_position":5,"commit_id":"cdd3f0f66d6d108b7d45a462e6c3985085b6cc90","original_commit_id":"cdd3f0f66d6d108b7d45a462e6c3985085b6cc90","user":{"login":"orangematt","id":41119,"avatar_url":"https://avatars0.githubusercontent.com/u/41119?v=4","gravatar_id":"","url":"https://api.github.com/users/orangematt","html_url":"https://github.com/orangematt","followers_url":"https://api.github.com/users/orangematt/followers","following_url":"https://api.github.com/users/orangematt/following{/other_user}","gists_url":"https://api.github.com/users/orangematt/gists{/gist_id}","starred_url":"https://api.github.com/users/orangematt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangematt/subscriptions","organizations_url":"https://api.github.com/users/orangematt/orgs","repos_url":"https://api.github.com/users/orangematt/repos","events_url":"https://api.github.com/users/orangematt/events{/privacy}","received_events_url":"https://api.github.com/users/orangematt/received_events","type":"User","site_admin":false},"body":"Makes sense not adding to `SRC`. It would be nice for `gofmt`, `go vet`, and `golint` to run on those sources, though. Is there any reason that cannot be done in the check rule? Maybe add `CHECKSRC=$(SRC) ./test/...` and then use `CHECKSRC` in the check rule?","created_at":"2018-03-01T17:09:00Z","updated_at":"2018-03-01T17:09:00Z","html_url":"https://github.com/capsule8/capsule8/pull/157#discussion_r171627554","pull_request_url":"https://api.github.com/repos/capsule8/capsule8/pulls/157","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/capsule8/capsule8/pulls/comments/171627554"},"html":{"href":"https://github.com/capsule8/capsule8/pull/157#discussion_r171627554"},"pull_request":{"href":"https://api.github.com/repos/capsule8/capsule8/pulls/157"}},"in_reply_to_id":171626025},"pull_request":{"url":"https://api.github.com/repos/capsule8/capsule8/pulls/157","id":171130569,"html_url":"https://github.com/capsule8/capsule8/pull/157","diff_url":"https://github.com/capsule8/capsule8/pull/157.diff","patch_url":"https://github.com/capsule8/capsule8/pull/157.patch","issue_url":"https://api.github.com/repos/capsule8/capsule8/issues/157","number":157,"state":"open","locked":false,"title":"Update benchmark test to latest changes of subscription logic","user":{"login":"GrantSeltzer","id":10857349,"avatar_url":"https://avatars3.githubusercontent.com/u/10857349?v=4","gravatar_id":"","url":"https://api.github.com/users/GrantSeltzer","html_url":"https://github.com/GrantSeltzer","followers_url":"https://api.github.com/users/GrantSeltzer/followers","following_url":"https://api.github.com/users/GrantSeltzer/following{/other_user}","gists_url":"https://api.github.com/users/GrantSeltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/GrantSeltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrantSeltzer/subscriptions","organizations_url":"https://api.github.com/users/GrantSeltzer/orgs","repos_url":"https://api.github.com/users/GrantSeltzer/repos","events_url":"https://api.github.com/users/GrantSeltzer/events{/privacy}","received_events_url":"https://api.github.com/users/GrantSeltzer/received_events","type":"User","site_admin":false},"body":"This updates `test/benchmark` to the latest state of the repository\r\n\r\nSigned-off-by: grant <grant@capsule8.com>","created_at":"2018-02-23T22:22:57Z","updated_at":"2018-03-01T17:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16bf6d44886ab0c49f752feabc6ce38c34cc52e3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ddz","id":3083278,"avatar_url":"https://avatars1.githubusercontent.com/u/3083278?v=4","gravatar_id":"","url":"https://api.github.com/users/ddz","html_url":"https://github.com/ddz","followers_url":"https://api.github.com/users/ddz/followers","following_url":"https://api.github.com/users/ddz/following{/other_user}","gists_url":"https://api.github.com/users/ddz/gists{/gist_id}","starred_url":"https://api.github.com/users/ddz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddz/subscriptions","organizations_url":"https://api.github.com/users/ddz/orgs","repos_url":"https://api.github.com/users/ddz/repos","events_url":"https://api.github.com/users/ddz/events{/privacy}","received_events_url":"https://api.github.com/users/ddz/received_events","type":"User","site_admin":false},{"login":"travertischio","id":8041974,"avatar_url":"https://avatars3.githubusercontent.com/u/8041974?v=4","gravatar_id":"","url":"https://api.github.com/users/travertischio","html_url":"https://github.com/travertischio","followers_url":"https://api.github.com/users/travertischio/followers","following_url":"https://api.github.com/users/travertischio/following{/other_user}","gists_url":"https://api.github.com/users/travertischio/gists{/gist_id}","starred_url":"https://api.github.com/users/travertischio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travertischio/subscriptions","organizations_url":"https://api.github.com/users/travertischio/orgs","repos_url":"https://api.github.com/users/travertischio/repos","events_url":"https://api.github.com/users/travertischio/events{/privacy}","received_events_url":"https://api.github.com/users/travertischio/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/capsule8/capsule8/pulls/157/commits","review_comments_url":"https://api.github.com/repos/capsule8/capsule8/pulls/157/comments","review_comment_url":"https://api.github.com/repos/capsule8/capsule8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/capsule8/capsule8/issues/157/comments","statuses_url":"https://api.github.com/repos/capsule8/capsule8/statuses/cdd3f0f66d6d108b7d45a462e6c3985085b6cc90","head":{"label":"capsule8:gs/update-benchmark-test","ref":"gs/update-benchmark-test","sha":"cdd3f0f66d6d108b7d45a462e6c3985085b6cc90","user":{"login":"capsule8","id":22600059,"avatar_url":"https://avatars3.githubusercontent.com/u/22600059?v=4","gravatar_id":"","url":"https://api.github.com/users/capsule8","html_url":"https://github.com/capsule8","followers_url":"https://api.github.com/users/capsule8/followers","following_url":"https://api.github.com/users/capsule8/following{/other_user}","gists_url":"https://api.github.com/users/capsule8/gists{/gist_id}","starred_url":"https://api.github.com/users/capsule8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capsule8/subscriptions","organizations_url":"https://api.github.com/users/capsule8/orgs","repos_url":"https://api.github.com/users/capsule8/repos","events_url":"https://api.github.com/users/capsule8/events{/privacy}","received_events_url":"https://api.github.com/users/capsule8/received_events","type":"Organization","site_admin":false},"repo":{"id":105391850,"name":"capsule8","full_name":"capsule8/capsule8","owner":{"login":"capsule8","id":22600059,"avatar_url":"https://avatars3.githubusercontent.com/u/22600059?v=4","gravatar_id":"","url":"https://api.github.com/users/capsule8","html_url":"https://github.com/capsule8","followers_url":"https://api.github.com/users/capsule8/followers","following_url":"https://api.github.com/users/capsule8/following{/other_user}","gists_url":"https://api.github.com/users/capsule8/gists{/gist_id}","starred_url":"https://api.github.com/users/capsule8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capsule8/subscriptions","organizations_url":"https://api.github.com/users/capsule8/orgs","repos_url":"https://api.github.com/users/capsule8/repos","events_url":"https://api.github.com/users/capsule8/events{/privacy}","received_events_url":"https://api.github.com/users/capsule8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/capsule8/capsule8","description":"Capsule8: open-source cloud-native behavioral security monitoring","fork":false,"url":"https://api.github.com/repos/capsule8/capsule8","forks_url":"https://api.github.com/repos/capsule8/capsule8/forks","keys_url":"https://api.github.com/repos/capsule8/capsule8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capsule8/capsule8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capsule8/capsule8/teams","hooks_url":"https://api.github.com/repos/capsule8/capsule8/hooks","issue_events_url":"https://api.github.com/repos/capsule8/capsule8/issues/events{/number}","events_url":"https://api.github.com/repos/capsule8/capsule8/events","assignees_url":"https://api.github.com/repos/capsule8/capsule8/assignees{/user}","branches_url":"https://api.github.com/repos/capsule8/capsule8/branches{/branch}","tags_url":"https://api.github.com/repos/capsule8/capsule8/tags","blobs_url":"https://api.github.com/repos/capsule8/capsule8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capsule8/capsule8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capsule8/capsule8/git/refs{/sha}","trees_url":"https://api.github.com/repos/capsule8/capsule8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capsule8/capsule8/statuses/{sha}","languages_url":"https://api.github.com/repos/capsule8/capsule8/languages","stargazers_url":"https://api.github.com/repos/capsule8/capsule8/stargazers","contributors_url":"https://api.github.com/repos/capsule8/capsule8/contributors","subscribers_url":"https://api.github.com/repos/capsule8/capsule8/subscribers","subscription_url":"https://api.github.com/repos/capsule8/capsule8/subscription","commits_url":"https://api.github.com/repos/capsule8/capsule8/commits{/sha}","git_commits_url":"https://api.github.com/repos/capsule8/capsule8/git/commits{/sha}","comments_url":"https://api.github.com/repos/capsule8/capsule8/comments{/number}","issue_comment_url":"https://api.github.com/repos/capsule8/capsule8/issues/comments{/number}","contents_url":"https://api.github.com/repos/capsule8/capsule8/contents/{+path}","compare_url":"https://api.github.com/repos/capsule8/capsule8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capsule8/capsule8/merges","archive_url":"https://api.github.com/repos/capsule8/capsule8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capsule8/capsule8/downloads","issues_url":"https://api.github.com/repos/capsule8/capsule8/issues{/number}","pulls_url":"https://api.github.com/repos/capsule8/capsule8/pulls{/number}","milestones_url":"https://api.github.com/repos/capsule8/capsule8/milestones{/number}","notifications_url":"https://api.github.com/repos/capsule8/capsule8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capsule8/capsule8/labels{/name}","releases_url":"https://api.github.com/repos/capsule8/capsule8/releases{/id}","deployments_url":"https://api.github.com/repos/capsule8/capsule8/deployments","created_at":"2017-09-30T18:35:31Z","updated_at":"2018-02-26T16:50:20Z","pushed_at":"2018-03-01T17:03:35Z","git_url":"git://github.com/capsule8/capsule8.git","ssh_url":"git@github.com:capsule8/capsule8.git","clone_url":"https://github.com/capsule8/capsule8.git","svn_url":"https://github.com/capsule8/capsule8","homepage":"","size":10232,"stargazers_count":215,"watchers_count":215,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":4,"watchers":215,"default_branch":"master"}},"base":{"label":"capsule8:master","ref":"master","sha":"b68226d317a0d13473e6bdc19195b21aadf727e8","user":{"login":"capsule8","id":22600059,"avatar_url":"https://avatars3.githubusercontent.com/u/22600059?v=4","gravatar_id":"","url":"https://api.github.com/users/capsule8","html_url":"https://github.com/capsule8","followers_url":"https://api.github.com/users/capsule8/followers","following_url":"https://api.github.com/users/capsule8/following{/other_user}","gists_url":"https://api.github.com/users/capsule8/gists{/gist_id}","starred_url":"https://api.github.com/users/capsule8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capsule8/subscriptions","organizations_url":"https://api.github.com/users/capsule8/orgs","repos_url":"https://api.github.com/users/capsule8/repos","events_url":"https://api.github.com/users/capsule8/events{/privacy}","received_events_url":"https://api.github.com/users/capsule8/received_events","type":"Organization","site_admin":false},"repo":{"id":105391850,"name":"capsule8","full_name":"capsule8/capsule8","owner":{"login":"capsule8","id":22600059,"avatar_url":"https://avatars3.githubusercontent.com/u/22600059?v=4","gravatar_id":"","url":"https://api.github.com/users/capsule8","html_url":"https://github.com/capsule8","followers_url":"https://api.github.com/users/capsule8/followers","following_url":"https://api.github.com/users/capsule8/following{/other_user}","gists_url":"https://api.github.com/users/capsule8/gists{/gist_id}","starred_url":"https://api.github.com/users/capsule8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capsule8/subscriptions","organizations_url":"https://api.github.com/users/capsule8/orgs","repos_url":"https://api.github.com/users/capsule8/repos","events_url":"https://api.github.com/users/capsule8/events{/privacy}","received_events_url":"https://api.github.com/users/capsule8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/capsule8/capsule8","description":"Capsule8: open-source cloud-native behavioral security monitoring","fork":false,"url":"https://api.github.com/repos/capsule8/capsule8","forks_url":"https://api.github.com/repos/capsule8/capsule8/forks","keys_url":"https://api.github.com/repos/capsule8/capsule8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capsule8/capsule8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capsule8/capsule8/teams","hooks_url":"https://api.github.com/repos/capsule8/capsule8/hooks","issue_events_url":"https://api.github.com/repos/capsule8/capsule8/issues/events{/number}","events_url":"https://api.github.com/repos/capsule8/capsule8/events","assignees_url":"https://api.github.com/repos/capsule8/capsule8/assignees{/user}","branches_url":"https://api.github.com/repos/capsule8/capsule8/branches{/branch}","tags_url":"https://api.github.com/repos/capsule8/capsule8/tags","blobs_url":"https://api.github.com/repos/capsule8/capsule8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capsule8/capsule8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capsule8/capsule8/git/refs{/sha}","trees_url":"https://api.github.com/repos/capsule8/capsule8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capsule8/capsule8/statuses/{sha}","languages_url":"https://api.github.com/repos/capsule8/capsule8/languages","stargazers_url":"https://api.github.com/repos/capsule8/capsule8/stargazers","contributors_url":"https://api.github.com/repos/capsule8/capsule8/contributors","subscribers_url":"https://api.github.com/repos/capsule8/capsule8/subscribers","subscription_url":"https://api.github.com/repos/capsule8/capsule8/subscription","commits_url":"https://api.github.com/repos/capsule8/capsule8/commits{/sha}","git_commits_url":"https://api.github.com/repos/capsule8/capsule8/git/commits{/sha}","comments_url":"https://api.github.com/repos/capsule8/capsule8/comments{/number}","issue_comment_url":"https://api.github.com/repos/capsule8/capsule8/issues/comments{/number}","contents_url":"https://api.github.com/repos/capsule8/capsule8/contents/{+path}","compare_url":"https://api.github.com/repos/capsule8/capsule8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capsule8/capsule8/merges","archive_url":"https://api.github.com/repos/capsule8/capsule8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capsule8/capsule8/downloads","issues_url":"https://api.github.com/repos/capsule8/capsule8/issues{/number}","pulls_url":"https://api.github.com/repos/capsule8/capsule8/pulls{/number}","milestones_url":"https://api.github.com/repos/capsule8/capsule8/milestones{/number}","notifications_url":"https://api.github.com/repos/capsule8/capsule8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capsule8/capsule8/labels{/name}","releases_url":"https://api.github.com/repos/capsule8/capsule8/releases{/id}","deployments_url":"https://api.github.com/repos/capsule8/capsule8/deployments","created_at":"2017-09-30T18:35:31Z","updated_at":"2018-02-26T16:50:20Z","pushed_at":"2018-03-01T17:03:35Z","git_url":"git://github.com/capsule8/capsule8.git","ssh_url":"git@github.com:capsule8/capsule8.git","clone_url":"https://github.com/capsule8/capsule8.git","svn_url":"https://github.com/capsule8/capsule8","homepage":"","size":10232,"stargazers_count":215,"watchers_count":215,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":4,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/capsule8/capsule8/pulls/157"},"html":{"href":"https://github.com/capsule8/capsule8/pull/157"},"issue":{"href":"https://api.github.com/repos/capsule8/capsule8/issues/157"},"comments":{"href":"https://api.github.com/repos/capsule8/capsule8/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/capsule8/capsule8/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/capsule8/capsule8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/capsule8/capsule8/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/capsule8/capsule8/statuses/cdd3f0f66d6d108b7d45a462e6c3985085b6cc90"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"orangematt"}}