{"action":"opened","number":1347,"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1347","id":192101141,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTAxMTQx","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1347","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1347.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1347.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1347","number":1347,"state":"open","locked":false,"title":"user-manual: add note that some Grantlee variables need '|safe'","user":{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"body":"### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [ ] Code cleanup\r\n- [ ] Build system change\r\n- [x] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\n\r\nGrantlee variables need the '|safe' extension, so that they can use\r\nHTML tags. Without it, tags like 'br' would not be converted to line\r\nbreaks - e.g. when exporting planned dive notes.\r\n\r\nAdd a note about that in the user manual.\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n- added note in manual\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\nwe have forum/ML reports for this\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\nnone\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\n\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n@willemferguson @dirkhh \r\n","created_at":"2018-06-01T17:50:02Z","updated_at":"2018-06-01T17:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":700899996,"node_id":"MDU6TGFiZWw3MDA4OTk5OTY=","url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/documentation","name":"documentation","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1347/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1347/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1347/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/9aaa257dc7852b4aaa29743d88e270fbf9c7d779","head":{"label":"neolit123:grantlee_notes_html","ref":"grantlee_notes_html","sha":"9aaa257dc7852b4aaa29743d88e270fbf9c7d779","user":{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"repo":{"id":5906383,"node_id":"MDEwOlJlcG9zaXRvcnk1OTA2Mzgz","name":"subsurface","full_name":"neolit123/subsurface","owner":{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neolit123/subsurface","description":"Advanced multi-platform divelog based on Qt","fork":true,"url":"https://api.github.com/repos/neolit123/subsurface","forks_url":"https://api.github.com/repos/neolit123/subsurface/forks","keys_url":"https://api.github.com/repos/neolit123/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neolit123/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neolit123/subsurface/teams","hooks_url":"https://api.github.com/repos/neolit123/subsurface/hooks","issue_events_url":"https://api.github.com/repos/neolit123/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/neolit123/subsurface/events","assignees_url":"https://api.github.com/repos/neolit123/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/neolit123/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/neolit123/subsurface/tags","blobs_url":"https://api.github.com/repos/neolit123/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neolit123/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neolit123/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/neolit123/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neolit123/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/neolit123/subsurface/languages","stargazers_url":"https://api.github.com/repos/neolit123/subsurface/stargazers","contributors_url":"https://api.github.com/repos/neolit123/subsurface/contributors","subscribers_url":"https://api.github.com/repos/neolit123/subsurface/subscribers","subscription_url":"https://api.github.com/repos/neolit123/subsurface/subscription","commits_url":"https://api.github.com/repos/neolit123/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/neolit123/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/neolit123/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/neolit123/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/neolit123/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/neolit123/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neolit123/subsurface/merges","archive_url":"https://api.github.com/repos/neolit123/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neolit123/subsurface/downloads","issues_url":"https://api.github.com/repos/neolit123/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/neolit123/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/neolit123/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/neolit123/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neolit123/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/neolit123/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/neolit123/subsurface/deployments","created_at":"2012-09-21T19:34:43Z","updated_at":"2017-01-01T01:10:35Z","pushed_at":"2018-06-01T17:47:29Z","git_url":"git://github.com/neolit123/subsurface.git","ssh_url":"git@github.com:neolit123/subsurface.git","clone_url":"https://github.com/neolit123/subsurface.git","svn_url":"https://github.com/neolit123/subsurface","homepage":"https://subsurface-divelog.org/","size":87975,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"9611e92cf0d90e4ce1eaf3c3adbaac0f78f4c884","user":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"node_id":"MDEwOlJlcG9zaXRvcnkyMzE5NDk4","name":"subsurface","full_name":"Subsurface-divelog/subsurface","owner":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2018-06-01T03:40:05Z","pushed_at":"2018-05-31T18:41:53Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":89854,"stargazers_count":1381,"watchers_count":1381,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":348,"open_issues":79,"watchers":1381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1347"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1347"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1347"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1347/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1347/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1347/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/9aaa257dc7852b4aaa29743d88e270fbf9c7d779"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"neolit123"}}