{"push_id":2981815794,"size":7,"distinct_size":6,"ref":"refs/heads/change_check_for_cython","head":"87a677498266f69b73aa6bb60c41c34205ceaa24","before":"5a94cb734548e3863f0c4b1d9aa27b0df74d110c","commits":[{"sha":"12eca447ee31a1968a565c4217ba2a78891ebc95","author":{"name":"maddyaby","email":"7b051b7214c5ddd6beedab849397abc726b8faca@amazon.com"},"message":"Issue #5956: Fix casts in texture.blit_buffer for ushort and uint types.\n\nIssue: When trying to use ushort and uint types, the cast to short and int\nctypes fail and result in an exception.\n\nFix: Do a cast to unsigned short and unsigned int instead.\n\nTesting: Tested with the same diff on the release version 1.10.1. Tested\nblitting a buffer of type int16, uint16, int32 and uint32. All types now\nwork as expected with no exceptions.","distinct":false,"url":"https://api.github.com/repos/flaviusb/kivy/commits/12eca447ee31a1968a565c4217ba2a78891ebc95"},{"sha":"648d06e55036b2f9912b0115fd42b89cc9712d51","author":{"name":"Justin Marsh (:flaviusb)","email":"7bcf6a77597d65c6f8a0bb95935dec5e4789b8ba@flaviusb.net"},"message":"Change check for Cython to attempt fallback to setuptools on supported platforms.\n\nThis attempts to solve Issue #5984 without causing more problems for Issue #5558.","distinct":true,"url":"https://api.github.com/repos/flaviusb/kivy/commits/648d06e55036b2f9912b0115fd42b89cc9712d51"},{"sha":"5dd87205368316c93b9f0b5da7b8c1c568a6997e","author":{"name":"Tommy Yu","email":"95cb0bfd2977c761298d9624e4b4d4c72a39974a@metatoaster.com"},"message":"Correct argument to extras_require.","distinct":true,"url":"https://api.github.com/repos/flaviusb/kivy/commits/5dd87205368316c93b9f0b5da7b8c1c568a6997e"},{"sha":"4026c1f3773778dc4b5c6474e4d7a5bbecddba66","author":{"name":"Tommy Yu","email":"95cb0bfd2977c761298d9624e4b4d4c72a39974a@metatoaster.com"},"message":"Refactor the declaration and usage of Cython\n\n- Use setuptools.setup by default if available for import.\n- The objective for that complicated import/cython is commented.\n- Also have more specific variable names, and have their usage be\n  clarified.\n\n- Remove Cython from install_requires as it already is declared under\n  setup_requires, and that it conflicts with install_requires due to\n  issues in setuptools.\n\n  - https://github.com/pypa/setuptools/issues/209\n  - https://github.com/pypa/setuptools/issues/391\n\n- This commit goes back to breaking installation in environments without\n  Cython, but should be rectified in the next commit.","distinct":true,"url":"https://api.github.com/repos/flaviusb/kivy/commits/4026c1f3773778dc4b5c6474e4d7a5bbecddba66"},{"sha":"cc0529963855bb0d1f69e3215bd67fd58ca1f54e","author":{"name":"Tommy Yu","email":"95cb0bfd2977c761298d9624e4b4d4c72a39974a@metatoaster.com"},"message":"Actually fix the specific usage of Cython\n\n- In order for setup.py to make use of the Cython installed during by\n  the setup_requires to be usable, it must be imported after it is\n  installed by that step, thus it cannot be done at the top level and\n  this can be achieved by importing it when it's actually called. A\n  build_ext factory function is created for this.\n- Still allow whatever Cython already present on the current environment\n  be attempted to be used.  This may end up being unnecessary as if it\n  is always declared in setup_requires (which isn't currently the case\n  due to the complicated/documented block), it _should_ pull in the\n  exact/supported version of Cython for usage.  This should be\n  investigated so that this complicated logic may be avoided.","distinct":true,"url":"https://api.github.com/repos/flaviusb/kivy/commits/cc0529963855bb0d1f69e3215bd67fd58ca1f54e"},{"sha":"cb23dbc764bb4de16204123d2c480827cf7126da","author":{"name":"Tommy Yu","email":"95cb0bfd2977c761298d9624e4b4d4c72a39974a@metatoaster.com"},"message":"Make distutils happy by not using factory function\n\n- As it turns out, calling setup.py build_ext will result in a code path\n  within setuptools that will invoke distutils in a way that forces an\n  issubclass check, which ultimately results in an exception due to that\n  function not being a class.\n- To fix this, we go back to constructing a base class except also using\n  the \"new\" style class (to make Python 2 happy) so that the __new__\n  method will actually be called so that the logic to select the Cython\n  version of build_ext will be invoked.\n- Also use the super class protocol to invoke parent methods.","distinct":true,"url":"https://api.github.com/repos/flaviusb/kivy/commits/cb23dbc764bb4de16204123d2c480827cf7126da"},{"sha":"87a677498266f69b73aa6bb60c41c34205ceaa24","author":{"name":"Tommy Yu","email":"95cb0bfd2977c761298d9624e4b4d4c72a39974a@metatoaster.com"},"message":"Declare version bounds directly on setup_requires\n\n- This allows us to fully remove the brittle version checks\n- Also this allows us to directly declare setup_requires if Cython is\n  definitely required, as this would allow the correct version to be\n  installed directly by setuptools during the execution of the setup\n  step.\n- No need to check for failed Cython imports due to the presence of the\n  setup_requires declaration.","distinct":true,"url":"https://api.github.com/repos/flaviusb/kivy/commits/87a677498266f69b73aa6bb60c41c34205ceaa24"}]}
{"actor":{"display_login":"flaviusb"}}