{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/comments/197959391","pull_request_review_id":131804194,"id":197959391,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk1OTM5MQ==","diff_hunk":"@@ -333,12 +346,13 @@ namespace\n \r\n                 for (auto &primitive : mesh.primitives)\r\n                 {\r\n-                    AddIndexOffset(primitive.positionsAccessorId, accessorOffset);\r\n-                    AddIndexOffset(primitive.normalsAccessorId, accessorOffset);\r\n                     AddIndexOffset(primitive.indicesAccessorId, accessorOffset);\r","path":"glTF-Toolkit/src/GLTFLODUtils.cpp","position":100,"original_position":100,"commit_id":"adb281f118d4637a9e6723d82fb43af7feaab854","original_commit_id":"adb281f118d4637a9e6723d82fb43af7feaab854","user":{"login":"najadojo","id":17411617,"node_id":"MDQ6VXNlcjE3NDExNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/17411617?v=4","gravatar_id":"","url":"https://api.github.com/users/najadojo","html_url":"https://github.com/najadojo","followers_url":"https://api.github.com/users/najadojo/followers","following_url":"https://api.github.com/users/najadojo/following{/other_user}","gists_url":"https://api.github.com/users/najadojo/gists{/gist_id}","starred_url":"https://api.github.com/users/najadojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/najadojo/subscriptions","organizations_url":"https://api.github.com/users/najadojo/orgs","repos_url":"https://api.github.com/users/najadojo/repos","events_url":"https://api.github.com/users/najadojo/events{/privacy}","received_events_url":"https://api.github.com/users/najadojo/received_events","type":"User","site_admin":false},"body":"Indices is still its own field where empty string implies not present in the json. So no it doesn't need to change.","created_at":"2018-06-25T22:14:34Z","updated_at":"2018-06-25T22:14:34Z","html_url":"https://github.com/Microsoft/glTF-Toolkit/pull/34#discussion_r197959391","pull_request_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/comments/197959391"},"html":{"href":"https://github.com/Microsoft/glTF-Toolkit/pull/34#discussion_r197959391"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34"}},"in_reply_to_id":197958325},"pull_request":{"url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34","id":197232317,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjMyMzE3","html_url":"https://github.com/Microsoft/glTF-Toolkit/pull/34","diff_url":"https://github.com/Microsoft/glTF-Toolkit/pull/34.diff","patch_url":"https://github.com/Microsoft/glTF-Toolkit/pull/34.patch","issue_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/issues/34","number":34,"state":"open","locked":false,"title":"Update glTF.CPP to 1.5.19","user":{"login":"najadojo","id":17411617,"node_id":"MDQ6VXNlcjE3NDExNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/17411617?v=4","gravatar_id":"","url":"https://api.github.com/users/najadojo","html_url":"https://github.com/najadojo","followers_url":"https://api.github.com/users/najadojo/followers","following_url":"https://api.github.com/users/najadojo/following{/other_user}","gists_url":"https://api.github.com/users/najadojo/gists{/gist_id}","starred_url":"https://api.github.com/users/najadojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/najadojo/subscriptions","organizations_url":"https://api.github.com/users/najadojo/orgs","repos_url":"https://api.github.com/users/najadojo/repos","events_url":"https://api.github.com/users/najadojo/events{/privacy}","received_events_url":"https://api.github.com/users/najadojo/received_events","type":"User","site_admin":false},"body":"Update driectxtex to 2018.6.1.2\r\nNo functional changes.","created_at":"2018-06-25T20:52:10Z","updated_at":"2018-06-25T22:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ef52ff91f959a85b3cf046091025177fa5adc32","assignee":null,"assignees":[],"requested_reviewers":[{"login":"agrittmsft","id":25353211,"node_id":"MDQ6VXNlcjI1MzUzMjEx","avatar_url":"https://avatars2.githubusercontent.com/u/25353211?v=4","gravatar_id":"","url":"https://api.github.com/users/agrittmsft","html_url":"https://github.com/agrittmsft","followers_url":"https://api.github.com/users/agrittmsft/followers","following_url":"https://api.github.com/users/agrittmsft/following{/other_user}","gists_url":"https://api.github.com/users/agrittmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/agrittmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrittmsft/subscriptions","organizations_url":"https://api.github.com/users/agrittmsft/orgs","repos_url":"https://api.github.com/users/agrittmsft/repos","events_url":"https://api.github.com/users/agrittmsft/events{/privacy}","received_events_url":"https://api.github.com/users/agrittmsft/received_events","type":"User","site_admin":false},{"login":"chriche-ms","id":34072661,"node_id":"MDQ6VXNlcjM0MDcyNjYx","avatar_url":"https://avatars1.githubusercontent.com/u/34072661?v=4","gravatar_id":"","url":"https://api.github.com/users/chriche-ms","html_url":"https://github.com/chriche-ms","followers_url":"https://api.github.com/users/chriche-ms/followers","following_url":"https://api.github.com/users/chriche-ms/following{/other_user}","gists_url":"https://api.github.com/users/chriche-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/chriche-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriche-ms/subscriptions","organizations_url":"https://api.github.com/users/chriche-ms/orgs","repos_url":"https://api.github.com/users/chriche-ms/repos","events_url":"https://api.github.com/users/chriche-ms/events{/privacy}","received_events_url":"https://api.github.com/users/chriche-ms/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34/commits","review_comments_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34/comments","review_comment_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/issues/34/comments","statuses_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/statuses/adb281f118d4637a9e6723d82fb43af7feaab854","head":{"label":"najadojo:gltfsdk-update","ref":"gltfsdk-update","sha":"adb281f118d4637a9e6723d82fb43af7feaab854","user":{"login":"najadojo","id":17411617,"node_id":"MDQ6VXNlcjE3NDExNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/17411617?v=4","gravatar_id":"","url":"https://api.github.com/users/najadojo","html_url":"https://github.com/najadojo","followers_url":"https://api.github.com/users/najadojo/followers","following_url":"https://api.github.com/users/najadojo/following{/other_user}","gists_url":"https://api.github.com/users/najadojo/gists{/gist_id}","starred_url":"https://api.github.com/users/najadojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/najadojo/subscriptions","organizations_url":"https://api.github.com/users/najadojo/orgs","repos_url":"https://api.github.com/users/najadojo/repos","events_url":"https://api.github.com/users/najadojo/events{/privacy}","received_events_url":"https://api.github.com/users/najadojo/received_events","type":"User","site_admin":false},"repo":{"id":120650425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2NTA0MjU=","name":"glTF-Toolkit","full_name":"najadojo/glTF-Toolkit","owner":{"login":"najadojo","id":17411617,"node_id":"MDQ6VXNlcjE3NDExNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/17411617?v=4","gravatar_id":"","url":"https://api.github.com/users/najadojo","html_url":"https://github.com/najadojo","followers_url":"https://api.github.com/users/najadojo/followers","following_url":"https://api.github.com/users/najadojo/following{/other_user}","gists_url":"https://api.github.com/users/najadojo/gists{/gist_id}","starred_url":"https://api.github.com/users/najadojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/najadojo/subscriptions","organizations_url":"https://api.github.com/users/najadojo/orgs","repos_url":"https://api.github.com/users/najadojo/repos","events_url":"https://api.github.com/users/najadojo/events{/privacy}","received_events_url":"https://api.github.com/users/najadojo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/najadojo/glTF-Toolkit","description":"A collection of tools for modifying and optimizing glTF assets","fork":true,"url":"https://api.github.com/repos/najadojo/glTF-Toolkit","forks_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/forks","keys_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/teams","hooks_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/hooks","issue_events_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/events","assignees_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/tags","blobs_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/languages","stargazers_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/stargazers","contributors_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/contributors","subscribers_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/subscribers","subscription_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/subscription","commits_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/merges","archive_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/downloads","issues_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/labels{/name}","releases_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/najadojo/glTF-Toolkit/deployments","created_at":"2018-02-07T17:54:01Z","updated_at":"2018-02-07T17:54:05Z","pushed_at":"2018-06-25T20:48:35Z","git_url":"git://github.com/najadojo/glTF-Toolkit.git","ssh_url":"git@github.com:najadojo/glTF-Toolkit.git","clone_url":"https://github.com/najadojo/glTF-Toolkit.git","svn_url":"https://github.com/najadojo/glTF-Toolkit","homepage":null,"size":44828,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"727f720349ba03a0e169661cdcd47fdbd9cfdc04","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":111733420,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3MzM0MjA=","name":"glTF-Toolkit","full_name":"Microsoft/glTF-Toolkit","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/glTF-Toolkit","description":"A collection of tools for modifying and optimizing glTF assets","fork":false,"url":"https://api.github.com/repos/Microsoft/glTF-Toolkit","forks_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/forks","keys_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/teams","hooks_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/events","assignees_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/tags","blobs_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/subscription","commits_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/merges","archive_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/downloads","issues_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/glTF-Toolkit/deployments","created_at":"2017-11-22T21:19:49Z","updated_at":"2018-06-25T22:07:05Z","pushed_at":"2018-06-25T22:07:01Z","git_url":"git://github.com/Microsoft/glTF-Toolkit.git","ssh_url":"git@github.com:Microsoft/glTF-Toolkit.git","clone_url":"https://github.com/Microsoft/glTF-Toolkit.git","svn_url":"https://github.com/Microsoft/glTF-Toolkit","homepage":null,"size":53411,"stargazers_count":88,"watchers_count":88,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":8,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34"},"html":{"href":"https://github.com/Microsoft/glTF-Toolkit/pull/34"},"issue":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/issues/34"},"comments":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/glTF-Toolkit/statuses/adb281f118d4637a9e6723d82fb43af7feaab854"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"najadojo"}}