{"action":"created","issue":{"url":"https://api.github.com/repos/Perl5-FFI/FFI-CheckLib/issues/10","repository_url":"https://api.github.com/repos/Perl5-FFI/FFI-CheckLib","labels_url":"https://api.github.com/repos/Perl5-FFI/FFI-CheckLib/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Perl5-FFI/FFI-CheckLib/issues/10/comments","events_url":"https://api.github.com/repos/Perl5-FFI/FFI-CheckLib/issues/10/events","html_url":"https://github.com/Perl5-FFI/FFI-CheckLib/issues/10","id":381041452,"node_id":"MDU6SXNzdWUzODEwNDE0NTI=","number":10,"title":"regex $pattern does not match name part of geos-3-7-0.dll on windows","user":{"login":"shawnlaffan","id":1332405,"node_id":"MDQ6VXNlcjEzMzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1332405?v=4","gravatar_id":"","url":"https://api.github.com/users/shawnlaffan","html_url":"https://github.com/shawnlaffan","followers_url":"https://api.github.com/users/shawnlaffan/followers","following_url":"https://api.github.com/users/shawnlaffan/following{/other_user}","gists_url":"https://api.github.com/users/shawnlaffan/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnlaffan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnlaffan/subscriptions","organizations_url":"https://api.github.com/users/shawnlaffan/orgs","repos_url":"https://api.github.com/users/shawnlaffan/repos","events_url":"https://api.github.com/users/shawnlaffan/events{/privacy}","received_events_url":"https://api.github.com/users/shawnlaffan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-15T07:59:16Z","updated_at":"2018-11-16T22:36:44Z","closed_at":null,"author_association":"NONE","body":"The GEOS library on windows generates a DLL called geos-3-7-0.dll.  This does not work with the regex used in ```FFI::CheckLib::_matches```, as the name part appears invalid.  ```FFI::CheckLib::find_lib``` returns ```undef```, while the assert method dies with ```library not found```.  \r\n\r\n```perl\r\nmy $pat  = qr{^(?:lib)?(.*?)(?:-([0-9])+)?\\.dll$}i;  #  current regexp\r\nmy $pat2 = qr{^(?:lib)?(.*?)(?:-([0-9]+))?(?:-[0-9]+)*\\.dll$}i;  #  revised regexp\r\n\r\nmy $string = 'geos-3-7-0.dll';\r\n\r\nsay 'gives: ' . join ', ', ($string =~ $pat);\r\n#  gives: geos-3-7, 0\r\nsay 'gives: ' . join ', ', ($string =~ $pat2);\r\n# gives: geos, 3\r\n```\r\n\r\nI'm not sure what you want to do with the remaining version components.  They could be used in the _sort sub, but hopefully they are not needed as that would make it more complex.  If you have a preference then I can work up a PR and test.\r\n\r\nThere are other complications in that some of the other DLLs I have under strawberry perl look like ```s1sgdk-win32-2.0-0.dll``` and ```libgd-3__.dll```.  I have nothing that uses them, but they are valid DLL names. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Perl5-FFI/FFI-CheckLib/issues/comments/439550420","html_url":"https://github.com/Perl5-FFI/FFI-CheckLib/issues/10#issuecomment-439550420","issue_url":"https://api.github.com/repos/Perl5-FFI/FFI-CheckLib/issues/10","id":439550420,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTU1MDQyMA==","user":{"login":"shawnlaffan","id":1332405,"node_id":"MDQ6VXNlcjEzMzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1332405?v=4","gravatar_id":"","url":"https://api.github.com/users/shawnlaffan","html_url":"https://github.com/shawnlaffan","followers_url":"https://api.github.com/users/shawnlaffan/followers","following_url":"https://api.github.com/users/shawnlaffan/following{/other_user}","gists_url":"https://api.github.com/users/shawnlaffan/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnlaffan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnlaffan/subscriptions","organizations_url":"https://api.github.com/users/shawnlaffan/orgs","repos_url":"https://api.github.com/users/shawnlaffan/repos","events_url":"https://api.github.com/users/shawnlaffan/events{/privacy}","received_events_url":"https://api.github.com/users/shawnlaffan/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T22:36:44Z","updated_at":"2018-11-16T22:36:44Z","author_association":"NONE","body":"No worries.  \r\n\r\nFor those reading later, the PR is #11 \r\n"}}
{"actor":{"display_login":"shawnlaffan"}}