{"action":"created","comment":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/comments/208402927","pull_request_review_id":144206164,"id":208402927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQwMjkyNw==","diff_hunk":"@@ -79,4 +79,26 @@ class ImageControllerTest < ActionDispatch::IntegrationTest\n     assert_redirected_to images_path\n     assert_equal 'Image does not exist', flash[:error]\n   end\n+\n+  test 'should delete image' do\n+    image1 = Image.create!(url: 'http://www.image1.com',\n+                           created_at: '2009-03-27 23:53:38',\n+                           tag_list: 'Good Boy, Pupper')\n+    Image.create!(url: 'http://www.image2.com',\n+                  tag_list: 'Good Boy, Pupper')\n+    assert_difference 'Image.count', -1 do","path":"test/controllers/image_controller_test.rb","position":11,"original_position":11,"commit_id":"686eb024ad688502d8a59c36a85daf077f09d35c","original_commit_id":"686eb024ad688502d8a59c36a85daf077f09d35c","user":{"login":"almgong","id":10444881,"node_id":"MDQ6VXNlcjEwNDQ0ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/10444881?v=4","gravatar_id":"","url":"https://api.github.com/users/almgong","html_url":"https://github.com/almgong","followers_url":"https://api.github.com/users/almgong/followers","following_url":"https://api.github.com/users/almgong/following{/other_user}","gists_url":"https://api.github.com/users/almgong/gists{/gist_id}","starred_url":"https://api.github.com/users/almgong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almgong/subscriptions","organizations_url":"https://api.github.com/users/almgong/orgs","repos_url":"https://api.github.com/users/almgong/repos","events_url":"https://api.github.com/users/almgong/events{/privacy}","received_events_url":"https://api.github.com/users/almgong/received_events","type":"User","site_admin":false},"body":"I believe that the default difference value is 1, so the -1 may be unneeded. Up to you if you want to leave it like this","created_at":"2018-08-07T22:17:17Z","updated_at":"2018-08-07T22:17:17Z","html_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds/pull/22#discussion_r208402927","pull_request_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/comments/208402927"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-abineetds/pull/22#discussion_r208402927"},"pull_request":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22","id":206792645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzkyNjQ1","html_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds/pull/22","diff_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds/pull/22.diff","patch_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds/pull/22.patch","issue_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/22","number":22,"state":"open","locked":false,"title":"ads - Added deletion functionality to application","user":{"login":"abineetds","id":10578131,"node_id":"MDQ6VXNlcjEwNTc4MTMx","avatar_url":"https://avatars1.githubusercontent.com/u/10578131?v=4","gravatar_id":"","url":"https://api.github.com/users/abineetds","html_url":"https://github.com/abineetds","followers_url":"https://api.github.com/users/abineetds/followers","following_url":"https://api.github.com/users/abineetds/following{/other_user}","gists_url":"https://api.github.com/users/abineetds/gists{/gist_id}","starred_url":"https://api.github.com/users/abineetds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abineetds/subscriptions","organizations_url":"https://api.github.com/users/abineetds/orgs","repos_url":"https://api.github.com/users/abineetds/repos","events_url":"https://api.github.com/users/abineetds/events{/privacy}","received_events_url":"https://api.github.com/users/abineetds/received_events","type":"User","site_admin":false},"body":" Not Closing a Story. Adding this feature as a part of Delete Image Issue.\r\n\r\n---\r\n\r\nThe following is a checklist to remind you of the steps to take when opening a\r\nnew PR. The horizontal line above and everything below can be removed from the\r\npull request description.\r\n\r\n- [ ] I have replaced `X` above with the associated issue number.\r\n- [ ] I have changed the issue's label to \"pull request\".\r\n- [ ] I have assigned the designated reviewer to this PR.\r\n- [ ] I have set the appropriate label on this PR.\r\n- [ ] I have written clear commit messages ([ref](http://chris.beams.io/posts/git-commit/)).\r\n\r\nIf needed, please review the document on the\r\n[Image Sharing Project](https://sites.google.com/a/appfolio.com/eng/new-hire-resources/engineering-academy/ropes/image-sharing-project)\r\nfor information on how labels should be used.\r\n","created_at":"2018-08-07T18:48:26Z","updated_at":"2018-08-07T22:17:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96f059b1fb4ede5f9725772b4894e2e44861cddd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22/commits","review_comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22/comments","review_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/22/comments","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/statuses/686eb024ad688502d8a59c36a85daf077f09d35c","head":{"label":"AppFolioOnboarding:delete-images","ref":"delete-images","sha":"686eb024ad688502d8a59c36a85daf077f09d35c","user":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":142223136,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyMjMxMzY=","name":"image-sharer-abineetds","full_name":"AppFolioOnboarding/image-sharer-abineetds","owner":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds","description":"image-sharer-abineetds created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/deployments","created_at":"2018-07-24T23:33:03Z","updated_at":"2018-08-07T00:13:39Z","pushed_at":"2018-08-07T22:05:50Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-abineetds.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-abineetds.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds","homepage":null,"size":399,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"AppFolioOnboarding:master","ref":"master","sha":"66ac39f85dfca512a55c9567aed55ade62e00c0b","user":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":142223136,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyMjMxMzY=","name":"image-sharer-abineetds","full_name":"AppFolioOnboarding/image-sharer-abineetds","owner":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds","description":"image-sharer-abineetds created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/deployments","created_at":"2018-07-24T23:33:03Z","updated_at":"2018-08-07T00:13:39Z","pushed_at":"2018-08-07T22:05:50Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-abineetds.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-abineetds.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-abineetds","homepage":null,"size":399,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-abineetds/pull/22"},"issue":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/22"},"comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-abineetds/statuses/686eb024ad688502d8a59c36a85daf077f09d35c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"almgong"}}