{"action":"created","issue":{"url":"https://api.github.com/repos/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/11","repository_url":"https://api.github.com/repos/InteractiveAdvertisingBureau/Consent-String-SDK-JS","labels_url":"https://api.github.com/repos/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/11/comments","events_url":"https://api.github.com/repos/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/11/events","html_url":"https://github.com/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/11","id":326135574,"number":11,"title":"defaultConsent is not optimized","user":{"login":"CanardSauvage","id":3428674,"avatar_url":"https://avatars1.githubusercontent.com/u/3428674?v=4","gravatar_id":"","url":"https://api.github.com/users/CanardSauvage","html_url":"https://github.com/CanardSauvage","followers_url":"https://api.github.com/users/CanardSauvage/followers","following_url":"https://api.github.com/users/CanardSauvage/following{/other_user}","gists_url":"https://api.github.com/users/CanardSauvage/gists{/gist_id}","starred_url":"https://api.github.com/users/CanardSauvage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanardSauvage/subscriptions","organizations_url":"https://api.github.com/users/CanardSauvage/orgs","repos_url":"https://api.github.com/users/CanardSauvage/repos","events_url":"https://api.github.com/users/CanardSauvage/events{/privacy}","received_events_url":"https://api.github.com/users/CanardSauvage/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-24T14:00:02Z","updated_at":"2018-05-30T16:02:57Z","closed_at":null,"author_association":"NONE","body":"If every vendor is true, I get this result (the range is wrong, see #10, but it's more about we really need the range):\r\n\r\nBOOQvTDOOQvTDABABBENAU-AAAALeABgAQALQA\r\n\r\n```json\r\n{\r\n  \"cookieVersion\": 1,\r\n  \"created\": \"2018-05-24T12:37:39.500Z\",\r\n  \"lastUpdated\": \"2018-05-24T12:37:39.500Z\",\r\n  \"cmpId\": 1,\r\n  \"cmpVersion\": 1,\r\n  \"consentScreen\": 1,\r\n  \"consentLanguage\": \"EN\",\r\n  \"vendorListVersion\": 20,\r\n  \"purposeIdBitString\": \"111110000000000000000000\",\r\n  \"maxVendorId\": 183,\r\n  \"isRange\": true,\r\n  \"defaultConsent\": false,\r\n  \"numEntries\": 1,\r\n  \"vendorRangeList\": [\r\n    {\r\n      \"isRange\": true,\r\n      \"startVendorId\": 8,\r\n      \"endVendorId\": 90\r\n    }\r\n  ]\r\n}\r\n```\r\n\r\nBut I would expect it to be:\r\n\r\n```json\r\n{\r\n  \"cookieVersion\": 1,\r\n  \"created\": \"2018-05-24T12:37:39.500Z\",\r\n  \"lastUpdated\": \"2018-05-24T12:37:39.500Z\",\r\n  \"cmpId\": 1,\r\n  \"cmpVersion\": 1,\r\n  \"consentScreen\": 1,\r\n  \"consentLanguage\": \"EN\",\r\n  \"vendorListVersion\": 20,\r\n  \"purposeIdBitString\": \"111110000000000000000000\",\r\n  \"maxVendorId\": 183,\r\n  \"isRange\": true,\r\n  \"defaultConsent\": true,\r\n  \"numEntries\": 0,\r\n  \"vendorRangeList\": []\r\n}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/comments/393218329","html_url":"https://github.com/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/11#issuecomment-393218329","issue_url":"https://api.github.com/repos/InteractiveAdvertisingBureau/Consent-String-SDK-JS/issues/11","id":393218329,"user":{"login":"ltparis2018","id":35994641,"avatar_url":"https://avatars1.githubusercontent.com/u/35994641?v=4","gravatar_id":"","url":"https://api.github.com/users/ltparis2018","html_url":"https://github.com/ltparis2018","followers_url":"https://api.github.com/users/ltparis2018/followers","following_url":"https://api.github.com/users/ltparis2018/following{/other_user}","gists_url":"https://api.github.com/users/ltparis2018/gists{/gist_id}","starred_url":"https://api.github.com/users/ltparis2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltparis2018/subscriptions","organizations_url":"https://api.github.com/users/ltparis2018/orgs","repos_url":"https://api.github.com/users/ltparis2018/repos","events_url":"https://api.github.com/users/ltparis2018/events{/privacy}","received_events_url":"https://api.github.com/users/ltparis2018/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T16:02:57Z","updated_at":"2018-05-30T16:02:57Z","author_association":"NONE","body":"It seems that new version (1.2.4) does not create a range anymore if all vendors are allowed.\r\nI set the global vendor list (version 27 in our tests) and then a list of ids of all vendors (from this global vendor list) using setVendorsAllowed().\r\nLibrary version 1.2.1 gives me the following consent string: BOOk8eaOOk8eaBQABBENAb-AAAAT2ABgACAnoA\r\n```\r\n{\r\n  \"cookieVersion\": 1,\r\n  \"created\": \"2018-05-30T15:45:45.000Z\",\r\n  \"lastUpdated\": \"2018-05-30T15:45:45.000Z\",\r\n  \"cmpId\": 80,\r\n  \"cmpVersion\": 1,\r\n  \"consentScreen\": 1,\r\n  \"consentLanguage\": \"EN\",\r\n  \"vendorListVersion\": 27,\r\n  \"purposeIdBitString\": \"111110000000000000000000\",\r\n  \"maxVendorId\": 317,\r\n  \"isRange\": true,\r\n  \"defaultConsent\": false,\r\n  \"numEntries\": 1,\r\n  \"vendorRangeList\": [\r\n    {\r\n      \"isRange\": true,\r\n      \"startVendorId\": 1,\r\n      \"endVendorId\": 317\r\n    }\r\n  ]\r\n}\r\n```\r\nWith version 1.2.4 the consent string is a little bit longer (for the same global vendor list and allowed vendors): BOOk-PMOOk-PMBQABBENAb-AAAAT17______b9_3__7_9uz_Kv_K7Xf_nnW0721PVA_rXOz_gE7YRAEIAkA\r\n```\r\n{\r\n  \"cookieVersion\": 1,\r\n  \"created\": \"2018-05-30T15:57:46.800Z\",\r\n  \"lastUpdated\": \"2018-05-30T15:57:46.800Z\",\r\n  \"cmpId\": 80,\r\n  \"cmpVersion\": 1,\r\n  \"consentScreen\": 1,\r\n  \"consentLanguage\": \"EN\",\r\n  \"vendorListVersion\": 27,\r\n  \"purposeIdBitString\": \"111110000000000000000000\",\r\n  \"maxVendorId\": 317,\r\n  \"isRange\": false,\r\n  \"vendorIdBitString\": \"11110111111111111111111111111111111111111110110111111011111111101111111111111111110111111111111011011101100111111110010101011111111110010101110110101110111111111111001111001110101101101001110111101101101010011110101010000001111111010110101110011101100111111111000000001001110110110000100010000000001000010000000001001\"\r\n}\r\n```"}}
{"actor":{"display_login":"ltparis2018"}}