{"action":"created","comment":{"url":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/comments/223188915","pull_request_review_id":162264685,"id":223188915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE4ODkxNQ==","diff_hunk":"@@ -0,0 +1,37 @@\n+def knapsack(v, w, n, W):\n+    \"\"\"\n+    Function solves 0/1 Knapsack problem\n+    Function to calculate frequency of items to be added to knapsack to maximise value\n+    such that total weight is less than or equal to W\n+    :param v: set of values of n objects,\n+    :param w: set of weights of n objects,\n+    first element in v, w is useless\n+    relevant values start from index 1\n+    :param n: number of items\n+    :pram W: maximum weight allowd by knapsack\n+    \"\"\"\n+    m = [[0 for j in range(W+1)] for i in range(n+1)]\n+    for j in range(W+1):\n+        m[0][j] = 0\n+\n+    for i in range(1, n+1):\n+        for j in range(W+1):\n+            if w[i] > j:","path":"knapsack/Python/knapsack.py","position":19,"original_position":19,"commit_id":"e2f77c3082282eb22b86771ad8cff5ac194ad35e","original_commit_id":"e2f77c3082282eb22b86771ad8cff5ac194ad35e","user":{"login":"Sartech-B","id":17451447,"node_id":"MDQ6VXNlcjE3NDUxNDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/17451447?v=4","gravatar_id":"","url":"https://api.github.com/users/Sartech-B","html_url":"https://github.com/Sartech-B","followers_url":"https://api.github.com/users/Sartech-B/followers","following_url":"https://api.github.com/users/Sartech-B/following{/other_user}","gists_url":"https://api.github.com/users/Sartech-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Sartech-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sartech-B/subscriptions","organizations_url":"https://api.github.com/users/Sartech-B/orgs","repos_url":"https://api.github.com/users/Sartech-B/repos","events_url":"https://api.github.com/users/Sartech-B/events{/privacy}","received_events_url":"https://api.github.com/users/Sartech-B/received_events","type":"User","site_admin":false},"body":"How to fix this one?\r\n","created_at":"2018-10-06T17:46:23Z","updated_at":"2018-10-06T17:46:24Z","html_url":"https://github.com/NITSkmOS/Algorithms/pull/331#discussion_r223188915","pull_request_url":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/comments/223188915"},"html":{"href":"https://github.com/NITSkmOS/Algorithms/pull/331#discussion_r223188915"},"pull_request":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331"}},"in_reply_to_id":223188845},"pull_request":{"url":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331","id":220899882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODk5ODgy","html_url":"https://github.com/NITSkmOS/Algorithms/pull/331","diff_url":"https://github.com/NITSkmOS/Algorithms/pull/331.diff","patch_url":"https://github.com/NITSkmOS/Algorithms/pull/331.patch","issue_url":"https://api.github.com/repos/NITSkmOS/Algorithms/issues/331","number":331,"state":"open","locked":false,"title":"Added knapsack-python and bubble-sort python","user":{"login":"Sartech-B","id":17451447,"node_id":"MDQ6VXNlcjE3NDUxNDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/17451447?v=4","gravatar_id":"","url":"https://api.github.com/users/Sartech-B","html_url":"https://github.com/Sartech-B","followers_url":"https://api.github.com/users/Sartech-B/followers","following_url":"https://api.github.com/users/Sartech-B/following{/other_user}","gists_url":"https://api.github.com/users/Sartech-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Sartech-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sartech-B/subscriptions","organizations_url":"https://api.github.com/users/Sartech-B/orgs","repos_url":"https://api.github.com/users/Sartech-B/repos","events_url":"https://api.github.com/users/Sartech-B/events{/privacy}","received_events_url":"https://api.github.com/users/Sartech-B/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your contribution!\r\n\r\nPlease take a quick look at those things down there. They're quite important.\r\nReally! We wrote them for you. Yes you! With utmost care. Read them.\r\n\r\nIn order to help us evaluate PRs better, we ask you to have a look at the\r\nfollowing declaration and check the points you agree with. ( [x] )\r\nPRs which don't agree to all the points mentioned below will be rejected.\r\n\r\nAlso make sure that this PR corresponds to one and only one issue. Write the\r\nissue number in the space provided below.\r\n-->\r\n\r\n**For short term contributors:** we understand that getting your commits well\r\ndefined like we require is a hard task and takes some learning. If you\r\nlook to help without wanting to contribute long term there's no need\r\nfor you to learn this. Just drop us a message and we'll take care of brushing\r\nup your stuff for merge!\r\n\r\nFixes #{ISSUE_NUMBER}\r\n\r\n\r\n**By submitting this pull request I confirm I've read and complied with the\r\nbelow declarations.**\r\n\r\n- [ ] I have read the [Contribution guidelines](https://github.com/NITSkmOS/Algorithms/blob/master/CONTRIBUTING.md) and I am confident that my PR reflects them.\r\n- [ ] I have followed the [commit guidelines](https://github.com/NITSkmOS/Algorithms/blob/master/CONTRIBUTING.md#write-good-commit-messages) for this project.\r\n- [ ] My code follows the [standard code structure](https://github.com/NITSkmOS/Algorithms/blob/master/CONTRIBUTING.md#samples-code).\r\n- [ ] This pull request has a descriptive title. For example, `{Tag}: Add {Algorithm/DS name} [{Language}]`, not `Update README.md` or `Added new code`.\r\n- [ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.\r\n- [ ] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.\r\n- [ ] I have mentioned the issue number correctly (with hyperlink) in this pull request description.\r\n\r\nAfter you submit your pull request, **DO NOT** click the 'Update Branch' button.\r\n\r\nissues fixed #305, #302 \r\n","created_at":"2018-10-06T17:27:55Z","updated_at":"2018-10-06T17:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78dd7e0c93dcbc82eb28e445697a91523b9579f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1054793018,"node_id":"MDU6TGFiZWwxMDU0NzkzMDE4","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/difficulty/low","name":"difficulty/low","color":"fff000","default":false},{"id":1073865315,"node_id":"MDU6TGFiZWwxMDczODY1MzE1","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/difficulty/medium","name":"difficulty/medium","color":"3c44d1","default":false},{"id":1054793016,"node_id":"MDU6TGFiZWwxMDU0NzkzMDE2","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1073867409,"node_id":"MDU6TGFiZWwxMDczODY3NDA5","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/hacktoberfest","name":"hacktoberfest","color":"411e2f","default":false},{"id":1073873337,"node_id":"MDU6TGFiZWwxMDczODczMzM3","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/lang/C","name":"lang/C","color":"1d76db","default":false},{"id":1073873710,"node_id":"MDU6TGFiZWwxMDczODczNzEw","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/lang/Python","name":"lang/Python","color":"817dd1","default":false},{"id":1075526358,"node_id":"MDU6TGFiZWwxMDc1NTI2MzU4","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/process/pending_review","name":"process/pending_review","color":"ededed","default":false},{"id":1073867618,"node_id":"MDU6TGFiZWwxMDczODY3NjE4","url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels/type/algo","name":"type/algo","color":"6237b2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331/commits","review_comments_url":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331/comments","review_comment_url":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NITSkmOS/Algorithms/issues/331/comments","statuses_url":"https://api.github.com/repos/NITSkmOS/Algorithms/statuses/e2f77c3082282eb22b86771ad8cff5ac194ad35e","head":{"label":"Sartech-B:master","ref":"master","sha":"e2f77c3082282eb22b86771ad8cff5ac194ad35e","user":{"login":"Sartech-B","id":17451447,"node_id":"MDQ6VXNlcjE3NDUxNDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/17451447?v=4","gravatar_id":"","url":"https://api.github.com/users/Sartech-B","html_url":"https://github.com/Sartech-B","followers_url":"https://api.github.com/users/Sartech-B/followers","following_url":"https://api.github.com/users/Sartech-B/following{/other_user}","gists_url":"https://api.github.com/users/Sartech-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Sartech-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sartech-B/subscriptions","organizations_url":"https://api.github.com/users/Sartech-B/orgs","repos_url":"https://api.github.com/users/Sartech-B/repos","events_url":"https://api.github.com/users/Sartech-B/events{/privacy}","received_events_url":"https://api.github.com/users/Sartech-B/received_events","type":"User","site_admin":false},"repo":{"id":151858585,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE4NTg1ODU=","name":"Algorithms","full_name":"Sartech-B/Algorithms","private":false,"owner":{"login":"Sartech-B","id":17451447,"node_id":"MDQ6VXNlcjE3NDUxNDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/17451447?v=4","gravatar_id":"","url":"https://api.github.com/users/Sartech-B","html_url":"https://github.com/Sartech-B","followers_url":"https://api.github.com/users/Sartech-B/followers","following_url":"https://api.github.com/users/Sartech-B/following{/other_user}","gists_url":"https://api.github.com/users/Sartech-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Sartech-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sartech-B/subscriptions","organizations_url":"https://api.github.com/users/Sartech-B/orgs","repos_url":"https://api.github.com/users/Sartech-B/repos","events_url":"https://api.github.com/users/Sartech-B/events{/privacy}","received_events_url":"https://api.github.com/users/Sartech-B/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Sartech-B/Algorithms","description":"In case you want to contribute, ping on https://gitter.im/NITSkmOS/algo.","fork":true,"url":"https://api.github.com/repos/Sartech-B/Algorithms","forks_url":"https://api.github.com/repos/Sartech-B/Algorithms/forks","keys_url":"https://api.github.com/repos/Sartech-B/Algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sartech-B/Algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sartech-B/Algorithms/teams","hooks_url":"https://api.github.com/repos/Sartech-B/Algorithms/hooks","issue_events_url":"https://api.github.com/repos/Sartech-B/Algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/Sartech-B/Algorithms/events","assignees_url":"https://api.github.com/repos/Sartech-B/Algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/Sartech-B/Algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/Sartech-B/Algorithms/tags","blobs_url":"https://api.github.com/repos/Sartech-B/Algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sartech-B/Algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sartech-B/Algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sartech-B/Algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sartech-B/Algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/Sartech-B/Algorithms/languages","stargazers_url":"https://api.github.com/repos/Sartech-B/Algorithms/stargazers","contributors_url":"https://api.github.com/repos/Sartech-B/Algorithms/contributors","subscribers_url":"https://api.github.com/repos/Sartech-B/Algorithms/subscribers","subscription_url":"https://api.github.com/repos/Sartech-B/Algorithms/subscription","commits_url":"https://api.github.com/repos/Sartech-B/Algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sartech-B/Algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sartech-B/Algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sartech-B/Algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sartech-B/Algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/Sartech-B/Algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sartech-B/Algorithms/merges","archive_url":"https://api.github.com/repos/Sartech-B/Algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sartech-B/Algorithms/downloads","issues_url":"https://api.github.com/repos/Sartech-B/Algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/Sartech-B/Algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/Sartech-B/Algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/Sartech-B/Algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sartech-B/Algorithms/labels{/name}","releases_url":"https://api.github.com/repos/Sartech-B/Algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/Sartech-B/Algorithms/deployments","created_at":"2018-10-06T16:23:08Z","updated_at":"2018-10-06T17:42:10Z","pushed_at":"2018-10-06T17:42:09Z","git_url":"git://github.com/Sartech-B/Algorithms.git","ssh_url":"git@github.com:Sartech-B/Algorithms.git","clone_url":"https://github.com/Sartech-B/Algorithms.git","svn_url":"https://github.com/Sartech-B/Algorithms","homepage":"https://nitskmos.github.io/Algorithms","size":100,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NITSkmOS:master","ref":"master","sha":"e72f3e1b209d5f0cb0854398bfb806d94891ae30","user":{"login":"NITSkmOS","id":38863995,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYzOTk1","avatar_url":"https://avatars3.githubusercontent.com/u/38863995?v=4","gravatar_id":"","url":"https://api.github.com/users/NITSkmOS","html_url":"https://github.com/NITSkmOS","followers_url":"https://api.github.com/users/NITSkmOS/followers","following_url":"https://api.github.com/users/NITSkmOS/following{/other_user}","gists_url":"https://api.github.com/users/NITSkmOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NITSkmOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NITSkmOS/subscriptions","organizations_url":"https://api.github.com/users/NITSkmOS/orgs","repos_url":"https://api.github.com/users/NITSkmOS/repos","events_url":"https://api.github.com/users/NITSkmOS/events{/privacy}","received_events_url":"https://api.github.com/users/NITSkmOS/received_events","type":"Organization","site_admin":false},"repo":{"id":148530970,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1MzA5NzA=","name":"Algorithms","full_name":"NITSkmOS/Algorithms","private":false,"owner":{"login":"NITSkmOS","id":38863995,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYzOTk1","avatar_url":"https://avatars3.githubusercontent.com/u/38863995?v=4","gravatar_id":"","url":"https://api.github.com/users/NITSkmOS","html_url":"https://github.com/NITSkmOS","followers_url":"https://api.github.com/users/NITSkmOS/followers","following_url":"https://api.github.com/users/NITSkmOS/following{/other_user}","gists_url":"https://api.github.com/users/NITSkmOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NITSkmOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NITSkmOS/subscriptions","organizations_url":"https://api.github.com/users/NITSkmOS/orgs","repos_url":"https://api.github.com/users/NITSkmOS/repos","events_url":"https://api.github.com/users/NITSkmOS/events{/privacy}","received_events_url":"https://api.github.com/users/NITSkmOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NITSkmOS/Algorithms","description":"In case you want to contribute, ping on https://gitter.im/NITSkmOS/algo.","fork":false,"url":"https://api.github.com/repos/NITSkmOS/Algorithms","forks_url":"https://api.github.com/repos/NITSkmOS/Algorithms/forks","keys_url":"https://api.github.com/repos/NITSkmOS/Algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NITSkmOS/Algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NITSkmOS/Algorithms/teams","hooks_url":"https://api.github.com/repos/NITSkmOS/Algorithms/hooks","issue_events_url":"https://api.github.com/repos/NITSkmOS/Algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/NITSkmOS/Algorithms/events","assignees_url":"https://api.github.com/repos/NITSkmOS/Algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/NITSkmOS/Algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/NITSkmOS/Algorithms/tags","blobs_url":"https://api.github.com/repos/NITSkmOS/Algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NITSkmOS/Algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NITSkmOS/Algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/NITSkmOS/Algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NITSkmOS/Algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/NITSkmOS/Algorithms/languages","stargazers_url":"https://api.github.com/repos/NITSkmOS/Algorithms/stargazers","contributors_url":"https://api.github.com/repos/NITSkmOS/Algorithms/contributors","subscribers_url":"https://api.github.com/repos/NITSkmOS/Algorithms/subscribers","subscription_url":"https://api.github.com/repos/NITSkmOS/Algorithms/subscription","commits_url":"https://api.github.com/repos/NITSkmOS/Algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/NITSkmOS/Algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/NITSkmOS/Algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/NITSkmOS/Algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/NITSkmOS/Algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/NITSkmOS/Algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NITSkmOS/Algorithms/merges","archive_url":"https://api.github.com/repos/NITSkmOS/Algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NITSkmOS/Algorithms/downloads","issues_url":"https://api.github.com/repos/NITSkmOS/Algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/NITSkmOS/Algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/NITSkmOS/Algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NITSkmOS/Algorithms/labels{/name}","releases_url":"https://api.github.com/repos/NITSkmOS/Algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/NITSkmOS/Algorithms/deployments","created_at":"2018-09-12T19:26:40Z","updated_at":"2018-10-06T16:13:56Z","pushed_at":"2018-10-06T17:42:10Z","git_url":"git://github.com/NITSkmOS/Algorithms.git","ssh_url":"git@github.com:NITSkmOS/Algorithms.git","clone_url":"https://github.com/NITSkmOS/Algorithms.git","svn_url":"https://github.com/NITSkmOS/Algorithms","homepage":"https://nitskmos.github.io/Algorithms","size":91,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":178,"open_issues":138,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331"},"html":{"href":"https://github.com/NITSkmOS/Algorithms/pull/331"},"issue":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/issues/331"},"comments":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/NITSkmOS/Algorithms/statuses/e2f77c3082282eb22b86771ad8cff5ac194ad35e"}},"author_association":"NONE"}}
{"actor":{"display_login":"Sartech-B"}}