{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/flux/issues/913","repository_url":"https://api.github.com/repos/weaveworks/flux","labels_url":"https://api.github.com/repos/weaveworks/flux/issues/913/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/flux/issues/913/comments","events_url":"https://api.github.com/repos/weaveworks/flux/issues/913/events","html_url":"https://github.com/weaveworks/flux/issues/913","id":291221960,"number":913,"title":"/api/flux/v6/images?service=<all> returns context deadline exceeded","user":{"login":"foot","id":22008,"avatar_url":"https://avatars0.githubusercontent.com/u/22008?v=4","gravatar_id":"","url":"https://api.github.com/users/foot","html_url":"https://github.com/foot","followers_url":"https://api.github.com/users/foot/followers","following_url":"https://api.github.com/users/foot/following{/other_user}","gists_url":"https://api.github.com/users/foot/gists{/gist_id}","starred_url":"https://api.github.com/users/foot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foot/subscriptions","organizations_url":"https://api.github.com/users/foot/orgs","repos_url":"https://api.github.com/users/foot/repos","events_url":"https://api.github.com/users/foot/events{/privacy}","received_events_url":"https://api.github.com/users/foot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-01-24T14:09:40Z","updated_at":"2018-05-08T12:15:47Z","closed_at":null,"author_association":"NONE","body":"The query is probably too big to lookup/encode/transmit in 10s.\r\n\r\nUse cases: \r\n - \"Deploy Status\" Dashboard\r\n - building web-UI equivalent `fluxctl release --all --update-image=library/hello:v2`\r\n\r\nWe need to choose a subset of the tags.\r\n\r\nIdeal response:\r\n - `/images?service=<all>&tagCreatedAt=gtCurrent`: Include all the tags where tag.CreatedAt > Current.CreatedAt\r\n     - This would allow us to display in the UI:\r\n        - \"You are 4 tags behind latest\"\r\n        - \"You are 3 weeks behind latest tag\"\r\n\r\nSmall caveat: the ideal response might be too big sometimes? The next idealist response would be:\r\n - `/images?service=<all>&tagLimit=1&onlyFilteredTags=true`: include 1 tag for each image that matches whatever tagFilter is set.\r\n    - Which would allow us to say in the ui:\r\n        - \"You are 3 weeks behind latest tag\"\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/flux/issues/comments/387382577","html_url":"https://github.com/weaveworks/flux/issues/913#issuecomment-387382577","issue_url":"https://api.github.com/repos/weaveworks/flux/issues/913","id":387382577,"user":{"login":"squaremo","id":62033,"avatar_url":"https://avatars3.githubusercontent.com/u/62033?v=4","gravatar_id":"","url":"https://api.github.com/users/squaremo","html_url":"https://github.com/squaremo","followers_url":"https://api.github.com/users/squaremo/followers","following_url":"https://api.github.com/users/squaremo/following{/other_user}","gists_url":"https://api.github.com/users/squaremo/gists{/gist_id}","starred_url":"https://api.github.com/users/squaremo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squaremo/subscriptions","organizations_url":"https://api.github.com/users/squaremo/orgs","repos_url":"https://api.github.com/users/squaremo/repos","events_url":"https://api.github.com/users/squaremo/events{/privacy}","received_events_url":"https://api.github.com/users/squaremo/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T12:15:47Z","updated_at":"2018-05-08T12:15:47Z","author_association":"OWNER","body":"> We would like to add some summary information for objects under the list of Containers:\r\n> \r\n> availableTagsCount - count of all the available tags\r\n> newAvailableTagsCount - count of all the new available tags (ones after the current)\r\n> @squaremo is tags the right word to use here or would images be more suitable?\r\n\r\n`images` is better here; although the base, untagged image will be the same for a particular container, with only the tag varying, we typically use whole image refs (i.e., both the base and the tag) as a unit, and don't use tags on their own.\r\n\r\n> These will be added as extra fields and all requests will include these by default. We will however introduce a new query parameter to allow the client to only request specific fields.\r\n\r\n... within the container struct.\r\n\r\n> i.e. ?containerFields=name,current,availableTagsCount would only return the name, current tag object and the count of available tags. If this query parameter is not used, by default all fields would be returned.\r\n\r\n:heavy_check_mark: I like this approach, because it's both forward- and backward-compatible (or at least, it punts compatibility to another layer). NB we would want to return a HTTP 40x status if we don't understand any of the fields mentioned."}}
{"actor":{"display_login":"squaremo"}}