{"action":"created","issue":{"url":"https://api.github.com/repos/HadoukenIO/js-adapter/issues/119","repository_url":"https://api.github.com/repos/HadoukenIO/js-adapter","labels_url":"https://api.github.com/repos/HadoukenIO/js-adapter/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/HadoukenIO/js-adapter/issues/119/comments","events_url":"https://api.github.com/repos/HadoukenIO/js-adapter/issues/119/events","html_url":"https://github.com/HadoukenIO/js-adapter/pull/119","id":319581296,"number":119,"title":"Feature/test sledghammer","user":{"login":"rdepena","id":3679449,"avatar_url":"https://avatars3.githubusercontent.com/u/3679449?v=4","gravatar_id":"","url":"https://api.github.com/users/rdepena","html_url":"https://github.com/rdepena","followers_url":"https://api.github.com/users/rdepena/followers","following_url":"https://api.github.com/users/rdepena/following{/other_user}","gists_url":"https://api.github.com/users/rdepena/gists{/gist_id}","starred_url":"https://api.github.com/users/rdepena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdepena/subscriptions","organizations_url":"https://api.github.com/users/rdepena/orgs","repos_url":"https://api.github.com/users/rdepena/repos","events_url":"https://api.github.com/users/rdepena/events{/privacy}","received_events_url":"https://api.github.com/users/rdepena/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-02T14:40:52Z","updated_at":"2018-05-04T15:26:24Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/HadoukenIO/js-adapter/pulls/119","html_url":"https://github.com/HadoukenIO/js-adapter/pull/119","diff_url":"https://github.com/HadoukenIO/js-adapter/pull/119.diff","patch_url":"https://github.com/HadoukenIO/js-adapter/pull/119.patch"},"body":"## Had to make a number of changes to make the Multi Runtime tests reliable.\r\n\r\n#### Remove the conn.clean function\r\nWithout the main runtime instance where all tests are run the RVM closes, the multi runtime tests run on disconnected runtimes(directly launched without the RVM) so they do not keep the RVM open.\r\n\r\n#### Added cleanOpenruntimes to all tests\r\nafterEach does not seem to run reliably on tests that timeout, this is a way to ensure a clean test bed before each test module.\r\n\r\n#### Added conn to multi runtime tests\r\nIf you launch the Multi runtime tests directly with a --grep, they should be anchored by the main runtime instance.\r\n\r\n#### Added retries to multi runtime tests\r\nArguably not needed but this rules out odd timing we could face while cleaning directories or closing active runtimes.\r\n\r\n#### Multi Runtime tests no longer open Apps\r\nWe did not need applications on the Multi Runtime tests, so removed them. Cleaner shutdown sequences.\r\n\r\n#### Moved all tests to use `function` instead of arrow syntax.\r\nLimitation with mocha and `this` scoping.\r\n\r\n#### Moved launching runtimes from serial (`launchX`) to Promise.all\r\nUnderstand why we did this but we no longer need to do it.\r\n\r\n#### Moved Multi Runtime `closed` tests to started\r\nCurrently a runtime Bug.\r\n\r\n#### Multi Runtime tests assign a port to be used instead of \"discovering\" it.\r\nThis is related to a Runtime bug where attaching to the console alters it's behaviour.\r\n\r\n#### Added standard set of tslint ignore rules for tests.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/HadoukenIO/js-adapter/issues/comments/386636479","html_url":"https://github.com/HadoukenIO/js-adapter/pull/119#issuecomment-386636479","issue_url":"https://api.github.com/repos/HadoukenIO/js-adapter/issues/119","id":386636479,"user":{"login":"rdepena","id":3679449,"avatar_url":"https://avatars3.githubusercontent.com/u/3679449?v=4","gravatar_id":"","url":"https://api.github.com/users/rdepena","html_url":"https://github.com/rdepena","followers_url":"https://api.github.com/users/rdepena/followers","following_url":"https://api.github.com/users/rdepena/following{/other_user}","gists_url":"https://api.github.com/users/rdepena/gists{/gist_id}","starred_url":"https://api.github.com/users/rdepena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdepena/subscriptions","organizations_url":"https://api.github.com/users/rdepena/orgs","repos_url":"https://api.github.com/users/rdepena/repos","events_url":"https://api.github.com/users/rdepena/events{/privacy}","received_events_url":"https://api.github.com/users/rdepena/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T15:26:24Z","updated_at":"2018-05-04T15:26:24Z","author_association":"OWNER","body":"@pbaize @licui3936 the return thing made no difference but changed it."}}
{"actor":{"display_login":"rdepena"}}