{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/fullsailor/pkcs7/pulls/28","id":170604855,"html_url":"https://github.com/fullsailor/pkcs7/pull/28","diff_url":"https://github.com/fullsailor/pkcs7/pull/28.diff","patch_url":"https://github.com/fullsailor/pkcs7/pull/28.patch","issue_url":"https://api.github.com/repos/fullsailor/pkcs7/issues/28","number":28,"state":"closed","locked":false,"title":"verifySignature: always use the certificate's algorithm","user":{"login":"mariusae","id":32104,"avatar_url":"https://avatars2.githubusercontent.com/u/32104?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusae","html_url":"https://github.com/mariusae","followers_url":"https://api.github.com/users/mariusae/followers","following_url":"https://api.github.com/users/mariusae/following{/other_user}","gists_url":"https://api.github.com/users/mariusae/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusae/subscriptions","organizations_url":"https://api.github.com/users/mariusae/orgs","repos_url":"https://api.github.com/users/mariusae/repos","events_url":"https://api.github.com/users/mariusae/events{/privacy}","received_events_url":"https://api.github.com/users/mariusae/received_events","type":"User","site_admin":false},"body":"VerifySignature previously hardcoded x509.SHA1WithRSA as the \r\nverification signature. As of Go 1.10, the x509 package verifies that \r\nthe requested algorithm matches the certificate's public key type.\r\nVerifySignature would then fail for certificates with DSA keys, such\r\nas AWS's EC2 instance identity documents.\r\n\r\nFix this by always using the certificate's algorithm directly.","created_at":"2018-02-21T22:20:13Z","updated_at":"2018-02-23T00:09:31Z","closed_at":"2018-02-23T00:09:31Z","merged_at":null,"merge_commit_sha":"022f5a35273ac309f3807fe03208bcb78fda867f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fullsailor/pkcs7/pulls/28/commits","review_comments_url":"https://api.github.com/repos/fullsailor/pkcs7/pulls/28/comments","review_comment_url":"https://api.github.com/repos/fullsailor/pkcs7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fullsailor/pkcs7/issues/28/comments","statuses_url":"https://api.github.com/repos/fullsailor/pkcs7/statuses/5d6c9218bac2a44f16e9e1991ed4f77a952aee08","head":{"label":"mariusae:patch-1","ref":"patch-1","sha":"5d6c9218bac2a44f16e9e1991ed4f77a952aee08","user":{"login":"mariusae","id":32104,"avatar_url":"https://avatars2.githubusercontent.com/u/32104?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusae","html_url":"https://github.com/mariusae","followers_url":"https://api.github.com/users/mariusae/followers","following_url":"https://api.github.com/users/mariusae/following{/other_user}","gists_url":"https://api.github.com/users/mariusae/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusae/subscriptions","organizations_url":"https://api.github.com/users/mariusae/orgs","repos_url":"https://api.github.com/users/mariusae/repos","events_url":"https://api.github.com/users/mariusae/events{/privacy}","received_events_url":"https://api.github.com/users/mariusae/received_events","type":"User","site_admin":false},"repo":{"id":122400760,"name":"pkcs7","full_name":"mariusae/pkcs7","owner":{"login":"mariusae","id":32104,"avatar_url":"https://avatars2.githubusercontent.com/u/32104?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusae","html_url":"https://github.com/mariusae","followers_url":"https://api.github.com/users/mariusae/followers","following_url":"https://api.github.com/users/mariusae/following{/other_user}","gists_url":"https://api.github.com/users/mariusae/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusae/subscriptions","organizations_url":"https://api.github.com/users/mariusae/orgs","repos_url":"https://api.github.com/users/mariusae/repos","events_url":"https://api.github.com/users/mariusae/events{/privacy}","received_events_url":"https://api.github.com/users/mariusae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariusae/pkcs7","description":"Implements a subset of PKCS#7/Crytpographic Message Syntax (rfc2315, rfc5652)","fork":true,"url":"https://api.github.com/repos/mariusae/pkcs7","forks_url":"https://api.github.com/repos/mariusae/pkcs7/forks","keys_url":"https://api.github.com/repos/mariusae/pkcs7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariusae/pkcs7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariusae/pkcs7/teams","hooks_url":"https://api.github.com/repos/mariusae/pkcs7/hooks","issue_events_url":"https://api.github.com/repos/mariusae/pkcs7/issues/events{/number}","events_url":"https://api.github.com/repos/mariusae/pkcs7/events","assignees_url":"https://api.github.com/repos/mariusae/pkcs7/assignees{/user}","branches_url":"https://api.github.com/repos/mariusae/pkcs7/branches{/branch}","tags_url":"https://api.github.com/repos/mariusae/pkcs7/tags","blobs_url":"https://api.github.com/repos/mariusae/pkcs7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariusae/pkcs7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariusae/pkcs7/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariusae/pkcs7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariusae/pkcs7/statuses/{sha}","languages_url":"https://api.github.com/repos/mariusae/pkcs7/languages","stargazers_url":"https://api.github.com/repos/mariusae/pkcs7/stargazers","contributors_url":"https://api.github.com/repos/mariusae/pkcs7/contributors","subscribers_url":"https://api.github.com/repos/mariusae/pkcs7/subscribers","subscription_url":"https://api.github.com/repos/mariusae/pkcs7/subscription","commits_url":"https://api.github.com/repos/mariusae/pkcs7/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariusae/pkcs7/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariusae/pkcs7/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariusae/pkcs7/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariusae/pkcs7/contents/{+path}","compare_url":"https://api.github.com/repos/mariusae/pkcs7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariusae/pkcs7/merges","archive_url":"https://api.github.com/repos/mariusae/pkcs7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariusae/pkcs7/downloads","issues_url":"https://api.github.com/repos/mariusae/pkcs7/issues{/number}","pulls_url":"https://api.github.com/repos/mariusae/pkcs7/pulls{/number}","milestones_url":"https://api.github.com/repos/mariusae/pkcs7/milestones{/number}","notifications_url":"https://api.github.com/repos/mariusae/pkcs7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariusae/pkcs7/labels{/name}","releases_url":"https://api.github.com/repos/mariusae/pkcs7/releases{/id}","deployments_url":"https://api.github.com/repos/mariusae/pkcs7/deployments","created_at":"2018-02-21T22:16:19Z","updated_at":"2018-02-21T22:16:21Z","pushed_at":"2018-02-21T22:20:05Z","git_url":"git://github.com/mariusae/pkcs7.git","ssh_url":"git@github.com:mariusae/pkcs7.git","clone_url":"https://github.com/mariusae/pkcs7.git","svn_url":"https://github.com/mariusae/pkcs7","homepage":"","size":79,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fullsailor:master","ref":"master","sha":"a009d8d7de53d9503c797cb8ec66fa3b21eed209","user":{"login":"fullsailor","id":154187,"avatar_url":"https://avatars1.githubusercontent.com/u/154187?v=4","gravatar_id":"","url":"https://api.github.com/users/fullsailor","html_url":"https://github.com/fullsailor","followers_url":"https://api.github.com/users/fullsailor/followers","following_url":"https://api.github.com/users/fullsailor/following{/other_user}","gists_url":"https://api.github.com/users/fullsailor/gists{/gist_id}","starred_url":"https://api.github.com/users/fullsailor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullsailor/subscriptions","organizations_url":"https://api.github.com/users/fullsailor/orgs","repos_url":"https://api.github.com/users/fullsailor/repos","events_url":"https://api.github.com/users/fullsailor/events{/privacy}","received_events_url":"https://api.github.com/users/fullsailor/received_events","type":"User","site_admin":false},"repo":{"id":33678195,"name":"pkcs7","full_name":"fullsailor/pkcs7","owner":{"login":"fullsailor","id":154187,"avatar_url":"https://avatars1.githubusercontent.com/u/154187?v=4","gravatar_id":"","url":"https://api.github.com/users/fullsailor","html_url":"https://github.com/fullsailor","followers_url":"https://api.github.com/users/fullsailor/followers","following_url":"https://api.github.com/users/fullsailor/following{/other_user}","gists_url":"https://api.github.com/users/fullsailor/gists{/gist_id}","starred_url":"https://api.github.com/users/fullsailor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullsailor/subscriptions","organizations_url":"https://api.github.com/users/fullsailor/orgs","repos_url":"https://api.github.com/users/fullsailor/repos","events_url":"https://api.github.com/users/fullsailor/events{/privacy}","received_events_url":"https://api.github.com/users/fullsailor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fullsailor/pkcs7","description":"Implements a subset of PKCS#7/Crytpographic Message Syntax (rfc2315, rfc5652)","fork":false,"url":"https://api.github.com/repos/fullsailor/pkcs7","forks_url":"https://api.github.com/repos/fullsailor/pkcs7/forks","keys_url":"https://api.github.com/repos/fullsailor/pkcs7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fullsailor/pkcs7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fullsailor/pkcs7/teams","hooks_url":"https://api.github.com/repos/fullsailor/pkcs7/hooks","issue_events_url":"https://api.github.com/repos/fullsailor/pkcs7/issues/events{/number}","events_url":"https://api.github.com/repos/fullsailor/pkcs7/events","assignees_url":"https://api.github.com/repos/fullsailor/pkcs7/assignees{/user}","branches_url":"https://api.github.com/repos/fullsailor/pkcs7/branches{/branch}","tags_url":"https://api.github.com/repos/fullsailor/pkcs7/tags","blobs_url":"https://api.github.com/repos/fullsailor/pkcs7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fullsailor/pkcs7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fullsailor/pkcs7/git/refs{/sha}","trees_url":"https://api.github.com/repos/fullsailor/pkcs7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fullsailor/pkcs7/statuses/{sha}","languages_url":"https://api.github.com/repos/fullsailor/pkcs7/languages","stargazers_url":"https://api.github.com/repos/fullsailor/pkcs7/stargazers","contributors_url":"https://api.github.com/repos/fullsailor/pkcs7/contributors","subscribers_url":"https://api.github.com/repos/fullsailor/pkcs7/subscribers","subscription_url":"https://api.github.com/repos/fullsailor/pkcs7/subscription","commits_url":"https://api.github.com/repos/fullsailor/pkcs7/commits{/sha}","git_commits_url":"https://api.github.com/repos/fullsailor/pkcs7/git/commits{/sha}","comments_url":"https://api.github.com/repos/fullsailor/pkcs7/comments{/number}","issue_comment_url":"https://api.github.com/repos/fullsailor/pkcs7/issues/comments{/number}","contents_url":"https://api.github.com/repos/fullsailor/pkcs7/contents/{+path}","compare_url":"https://api.github.com/repos/fullsailor/pkcs7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fullsailor/pkcs7/merges","archive_url":"https://api.github.com/repos/fullsailor/pkcs7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fullsailor/pkcs7/downloads","issues_url":"https://api.github.com/repos/fullsailor/pkcs7/issues{/number}","pulls_url":"https://api.github.com/repos/fullsailor/pkcs7/pulls{/number}","milestones_url":"https://api.github.com/repos/fullsailor/pkcs7/milestones{/number}","notifications_url":"https://api.github.com/repos/fullsailor/pkcs7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fullsailor/pkcs7/labels{/name}","releases_url":"https://api.github.com/repos/fullsailor/pkcs7/releases{/id}","deployments_url":"https://api.github.com/repos/fullsailor/pkcs7/deployments","created_at":"2015-04-09T15:53:01Z","updated_at":"2018-02-22T15:03:34Z","pushed_at":"2018-02-23T00:09:29Z","git_url":"git://github.com/fullsailor/pkcs7.git","ssh_url":"git@github.com:fullsailor/pkcs7.git","clone_url":"https://github.com/fullsailor/pkcs7.git","svn_url":"https://github.com/fullsailor/pkcs7","homepage":"","size":63,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":39,"open_issues":12,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fullsailor/pkcs7/pulls/28"},"html":{"href":"https://github.com/fullsailor/pkcs7/pull/28"},"issue":{"href":"https://api.github.com/repos/fullsailor/pkcs7/issues/28"},"comments":{"href":"https://api.github.com/repos/fullsailor/pkcs7/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/fullsailor/pkcs7/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/fullsailor/pkcs7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fullsailor/pkcs7/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/fullsailor/pkcs7/statuses/5d6c9218bac2a44f16e9e1991ed4f77a952aee08"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"fullsailor"}}