{"action":"created","issue":{"url":"https://api.github.com/repos/Bouke/NetService/issues/27","repository_url":"https://api.github.com/repos/Bouke/NetService","labels_url":"https://api.github.com/repos/Bouke/NetService/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/Bouke/NetService/issues/27/comments","events_url":"https://api.github.com/repos/Bouke/NetService/issues/27/events","html_url":"https://github.com/Bouke/NetService/issues/27","id":391956404,"node_id":"MDU6SXNzdWUzOTE5NTY0MDQ=","number":27,"title":"Disabled didAcceptConnectionWith in the \"dns_sd\" branch","user":{"login":"robreuss","id":588682,"node_id":"MDQ6VXNlcjU4ODY4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/588682?v=4","gravatar_id":"","url":"https://api.github.com/users/robreuss","html_url":"https://github.com/robreuss","followers_url":"https://api.github.com/users/robreuss/followers","following_url":"https://api.github.com/users/robreuss/following{/other_user}","gists_url":"https://api.github.com/users/robreuss/gists{/gist_id}","starred_url":"https://api.github.com/users/robreuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robreuss/subscriptions","organizations_url":"https://api.github.com/users/robreuss/orgs","repos_url":"https://api.github.com/users/robreuss/repos","events_url":"https://api.github.com/users/robreuss/events{/privacy}","received_events_url":"https://api.github.com/users/robreuss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-18T01:16:49Z","updated_at":"2018-12-18T22:53:10Z","closed_at":null,"author_association":"NONE","body":"Looks like the delegate \"didAcceptConnectionWith\" has been disabled in the \"dns_sd\" branch.  Is that a temporary or permanent change?"},"comment":{"url":"https://api.github.com/repos/Bouke/NetService/issues/comments/448402147","html_url":"https://github.com/Bouke/NetService/issues/27#issuecomment-448402147","issue_url":"https://api.github.com/repos/Bouke/NetService/issues/27","id":448402147,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODQwMjE0Nw==","user":{"login":"Bouke","id":235882,"node_id":"MDQ6VXNlcjIzNTg4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/235882?v=4","gravatar_id":"","url":"https://api.github.com/users/Bouke","html_url":"https://github.com/Bouke","followers_url":"https://api.github.com/users/Bouke/followers","following_url":"https://api.github.com/users/Bouke/following{/other_user}","gists_url":"https://api.github.com/users/Bouke/gists{/gist_id}","starred_url":"https://api.github.com/users/Bouke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bouke/subscriptions","organizations_url":"https://api.github.com/users/Bouke/orgs","repos_url":"https://api.github.com/users/Bouke/repos","events_url":"https://api.github.com/users/Bouke/events{/privacy}","received_events_url":"https://api.github.com/users/Bouke/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T22:53:10Z","updated_at":"2018-12-18T22:53:10Z","author_association":"OWNER","body":"No it's a shortcoming currently that the parameters aren't checked correctly. Either you pass in a specific port, or you set \"listenForConnections\".\r\n\r\nThe OS will provide you with a dynamic port if you open a socket and don't bind it to a specific port. NetService doesn't do anything magical here, if you ask it to open a port on 0, it'll be assigned a port by the OS. That port will be used for the bonjour advertisements.\r\n\r\nSo the current master branch does support listenForConnections. In contrast to Apple's implementation it'll send a (BlueSocket) Socket when a client connects. The dns_sd branch doesn't support listenForConnections, and should probably reject that option and also require the port > 0. Using the dns_sd branch, you'd currently have to setup your own listening socket prior to the bonjour broadcast. You could use BlueSocket for example. Once you have the listening socket up, you'll know the port and you can use NetService to broadcast that port."}}
{"actor":{"display_login":"Bouke"}}