{"action":"created","comment":{"url":"https://api.github.com/repos/tikv/tikv/pulls/comments/244466317","pull_request_review_id":188398069,"id":244466317,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQ2NjMxNw==","diff_hunk":"@@ -30,35 +30,36 @@ use util::transport::SendCh;\n use util::worker::Scheduler;\n use util::HandyRwLock;\n \n+/// Routes messages to the raftstore.\n pub trait RaftStoreRouter: Send + Clone {\n     /// Send StoreMsg, retry if failed. Try times may vary from implementation.\n     fn send(&self, msg: StoreMsg) -> RaftStoreResult<()>;\n \n     /// Send StoreMsg.\n     fn try_send(&self, msg: StoreMsg) -> RaftStoreResult<()>;\n \n-    // Send RaftMessage to local store.\n+    /// Sends RaftMessage to local store.\n     fn send_raft_msg(&self, msg: RaftMessage) -> RaftStoreResult<()> {\n         self.try_send(StoreMsg::RaftMessage(msg))\n     }\n \n-    // Send RaftCmdRequest to local store.\n+    /// Sends RaftCmdRequest to local store.\n     fn send_command(&self, req: RaftCmdRequest, cb: Callback) -> RaftStoreResult<()> {\n         self.try_send(StoreMsg::new_raft_cmd(req, cb))\n     }\n \n-    // Send significant message. We should guarantee that the message can't be dropped.\n+    /// Sends a significant message. We should guarantee that the message can't be dropped.\n     fn significant_send(&self, msg: SignificantMsg) -> RaftStoreResult<()>;\n \n-    // Report the peer of the region is unreachable.\n+    /// Reports the peer of the region is unreachable.","path":"src/server/transport.rs","position":29,"original_position":29,"commit_id":"5155ba5a9b64ed1f3c3b05ad3f30614935d12832","original_commit_id":"5155ba5a9b64ed1f3c3b05ad3f30614935d12832","user":{"login":"CaitinChen","id":34535727,"node_id":"MDQ6VXNlcjM0NTM1NzI3","avatar_url":"https://avatars2.githubusercontent.com/u/34535727?v=4","gravatar_id":"","url":"https://api.github.com/users/CaitinChen","html_url":"https://github.com/CaitinChen","followers_url":"https://api.github.com/users/CaitinChen/followers","following_url":"https://api.github.com/users/CaitinChen/following{/other_user}","gists_url":"https://api.github.com/users/CaitinChen/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitinChen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitinChen/subscriptions","organizations_url":"https://api.github.com/users/CaitinChen/orgs","repos_url":"https://api.github.com/users/CaitinChen/repos","events_url":"https://api.github.com/users/CaitinChen/events{/privacy}","received_events_url":"https://api.github.com/users/CaitinChen/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    /// Reports the Region being unreachable to the peer.\r\n```","created_at":"2018-12-29T08:02:35Z","updated_at":"2018-12-29T08:05:40Z","html_url":"https://github.com/tikv/tikv/pull/3991#discussion_r244466317","pull_request_url":"https://api.github.com/repos/tikv/tikv/pulls/3991","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments/244466317"},"html":{"href":"https://github.com/tikv/tikv/pull/3991#discussion_r244466317"},"pull_request":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3991"}}},"pull_request":{"url":"https://api.github.com/repos/tikv/tikv/pulls/3991","id":241303802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzAzODAy","html_url":"https://github.com/tikv/tikv/pull/3991","diff_url":"https://github.com/tikv/tikv/pull/3991.diff","patch_url":"https://github.com/tikv/tikv/pull/3991.patch","issue_url":"https://api.github.com/repos/tikv/tikv/issues/3991","number":3991,"state":"open","locked":false,"title":"server: add comments for public API","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"## What have you changed? (mandatory)\r\n\r\nAdd comments for public API\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\n- Improvement (non-breaking change which is an improvement to an existing feature)\r\n","created_at":"2018-12-28T10:05:25Z","updated_at":"2018-12-29T08:05:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a949b325b7e5cabbb07793cccfe92bd8a81a119","assignee":{"login":"CaitinChen","id":34535727,"node_id":"MDQ6VXNlcjM0NTM1NzI3","avatar_url":"https://avatars2.githubusercontent.com/u/34535727?v=4","gravatar_id":"","url":"https://api.github.com/users/CaitinChen","html_url":"https://github.com/CaitinChen","followers_url":"https://api.github.com/users/CaitinChen/followers","following_url":"https://api.github.com/users/CaitinChen/following{/other_user}","gists_url":"https://api.github.com/users/CaitinChen/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitinChen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitinChen/subscriptions","organizations_url":"https://api.github.com/users/CaitinChen/orgs","repos_url":"https://api.github.com/users/CaitinChen/repos","events_url":"https://api.github.com/users/CaitinChen/events{/privacy}","received_events_url":"https://api.github.com/users/CaitinChen/received_events","type":"User","site_admin":false},"assignees":[{"login":"CaitinChen","id":34535727,"node_id":"MDQ6VXNlcjM0NTM1NzI3","avatar_url":"https://avatars2.githubusercontent.com/u/34535727?v=4","gravatar_id":"","url":"https://api.github.com/users/CaitinChen","html_url":"https://github.com/CaitinChen","followers_url":"https://api.github.com/users/CaitinChen/followers","following_url":"https://api.github.com/users/CaitinChen/following{/other_user}","gists_url":"https://api.github.com/users/CaitinChen/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitinChen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitinChen/subscriptions","organizations_url":"https://api.github.com/users/CaitinChen/orgs","repos_url":"https://api.github.com/users/CaitinChen/repos","events_url":"https://api.github.com/users/CaitinChen/events{/privacy}","received_events_url":"https://api.github.com/users/CaitinChen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lilin90","id":30922556,"node_id":"MDQ6VXNlcjMwOTIyNTU2","avatar_url":"https://avatars1.githubusercontent.com/u/30922556?v=4","gravatar_id":"","url":"https://api.github.com/users/lilin90","html_url":"https://github.com/lilin90","followers_url":"https://api.github.com/users/lilin90/followers","following_url":"https://api.github.com/users/lilin90/following{/other_user}","gists_url":"https://api.github.com/users/lilin90/gists{/gist_id}","starred_url":"https://api.github.com/users/lilin90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilin90/subscriptions","organizations_url":"https://api.github.com/users/lilin90/orgs","repos_url":"https://api.github.com/users/lilin90/repos","events_url":"https://api.github.com/users/lilin90/events{/privacy}","received_events_url":"https://api.github.com/users/lilin90/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tikv/tikv/pulls/3991/commits","review_comments_url":"https://api.github.com/repos/tikv/tikv/pulls/3991/comments","review_comment_url":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tikv/tikv/issues/3991/comments","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/5155ba5a9b64ed1f3c3b05ad3f30614935d12832","head":{"label":"overvenus:docs/server","ref":"docs/server","sha":"5155ba5a9b64ed1f3c3b05ad3f30614935d12832","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"repo":{"id":58031891,"node_id":"MDEwOlJlcG9zaXRvcnk1ODAzMTg5MQ==","name":"tikv","full_name":"overvenus/tikv","private":false,"owner":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/overvenus/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/overvenus/tikv","forks_url":"https://api.github.com/repos/overvenus/tikv/forks","keys_url":"https://api.github.com/repos/overvenus/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overvenus/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overvenus/tikv/teams","hooks_url":"https://api.github.com/repos/overvenus/tikv/hooks","issue_events_url":"https://api.github.com/repos/overvenus/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/overvenus/tikv/events","assignees_url":"https://api.github.com/repos/overvenus/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/overvenus/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/overvenus/tikv/tags","blobs_url":"https://api.github.com/repos/overvenus/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overvenus/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overvenus/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/overvenus/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overvenus/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/overvenus/tikv/languages","stargazers_url":"https://api.github.com/repos/overvenus/tikv/stargazers","contributors_url":"https://api.github.com/repos/overvenus/tikv/contributors","subscribers_url":"https://api.github.com/repos/overvenus/tikv/subscribers","subscription_url":"https://api.github.com/repos/overvenus/tikv/subscription","commits_url":"https://api.github.com/repos/overvenus/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/overvenus/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/overvenus/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/overvenus/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/overvenus/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/overvenus/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overvenus/tikv/merges","archive_url":"https://api.github.com/repos/overvenus/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overvenus/tikv/downloads","issues_url":"https://api.github.com/repos/overvenus/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/overvenus/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/overvenus/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/overvenus/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overvenus/tikv/labels{/name}","releases_url":"https://api.github.com/repos/overvenus/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/overvenus/tikv/deployments","created_at":"2016-05-04T07:29:33Z","updated_at":"2018-08-09T17:18:43Z","pushed_at":"2018-12-29T07:43:51Z","git_url":"git://github.com/overvenus/tikv.git","ssh_url":"git@github.com:overvenus/tikv.git","clone_url":"https://github.com/overvenus/tikv.git","svn_url":"https://github.com/overvenus/tikv","homepage":"","size":17471,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tikv:master","ref":"master","sha":"75254d54b6e7869f2aded66c0a5f70d1a6035673","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"tikv/tikv","private":false,"owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tikv/tikv","description":"Distributed transactional key-value database, originally created to complement TiDB","fork":false,"url":"https://api.github.com/repos/tikv/tikv","forks_url":"https://api.github.com/repos/tikv/tikv/forks","keys_url":"https://api.github.com/repos/tikv/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/tikv/teams","hooks_url":"https://api.github.com/repos/tikv/tikv/hooks","issue_events_url":"https://api.github.com/repos/tikv/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/tikv/events","assignees_url":"https://api.github.com/repos/tikv/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/tikv/tags","blobs_url":"https://api.github.com/repos/tikv/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/tikv/languages","stargazers_url":"https://api.github.com/repos/tikv/tikv/stargazers","contributors_url":"https://api.github.com/repos/tikv/tikv/contributors","subscribers_url":"https://api.github.com/repos/tikv/tikv/subscribers","subscription_url":"https://api.github.com/repos/tikv/tikv/subscription","commits_url":"https://api.github.com/repos/tikv/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/tikv/merges","archive_url":"https://api.github.com/repos/tikv/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/tikv/downloads","issues_url":"https://api.github.com/repos/tikv/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/tikv/labels{/name}","releases_url":"https://api.github.com/repos/tikv/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-12-29T07:57:30Z","pushed_at":"2018-12-29T07:21:49Z","git_url":"git://github.com/tikv/tikv.git","ssh_url":"git@github.com:tikv/tikv.git","clone_url":"https://github.com/tikv/tikv.git","svn_url":"https://github.com/tikv/tikv","homepage":"https://tikv.org","size":18667,"stargazers_count":4271,"watchers_count":4271,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":614,"mirror_url":null,"archived":false,"open_issues_count":326,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":614,"open_issues":326,"watchers":4271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3991"},"html":{"href":"https://github.com/tikv/tikv/pull/3991"},"issue":{"href":"https://api.github.com/repos/tikv/tikv/issues/3991"},"comments":{"href":"https://api.github.com/repos/tikv/tikv/issues/3991/comments"},"review_comments":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3991/comments"},"review_comment":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3991/commits"},"statuses":{"href":"https://api.github.com/repos/tikv/tikv/statuses/5155ba5a9b64ed1f3c3b05ad3f30614935d12832"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CaitinChen"}}