{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/229788329","pull_request_review_id":170372445,"id":229788329,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTc4ODMyOQ==","diff_hunk":"@@ -0,0 +1,86 @@\n+#\n+# Copyright 2018, SUSE LLC\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#   http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+class SesService < OpenstackServiceObject\n+  def initialize(thelogger = nil)\n+    super(thelogger)\n+    @bc_name = \"ses\"\n+    @logger = thelogger\n+  end\n+\n+  class << self\n+    # turn off multi proposal support till it really works and people ask for\n+    # it.\n+    def self.allow_multiple_proposals?\n+      false\n+    end\n+\n+    def role_constraints\n+      {\n+        \"ses-controller\" => {\n+          \"unique\" => true,\n+          \"count\" => 1,\n+          \"cluster\" => false,\n+          \"admin\" => false,\n+          \"exclude_platform\" => {\n+            \"suse\" => \"< 12.3\",\n+            \"windows\" => \"/.*/\"\n+          }\n+        }\n+      }\n+    end\n+  end\n+\n+  def proposal_dependencies(role)\n+    answer = []\n+    deps = [\"keystone\"]\n+    deps.each do |dep|\n+      answer << {\n+        \"barclamp\" => dep,\n+        \"inst\" => role.default_attributes[@bc_name][\"#{dep}_instance\"]\n+      }\n+    end\n+    answer\n+  end\n+\n+  def create_proposal\n+    @logger.debug(\"SES create_proposal: entering\")\n+    base = super\n+\n+    #base[\"attributes\"][@bc_name][\"cinder_instance\"] = Proposal.find_by(barclamp: \"cinder\")","path":"crowbar_framework/app/models/ses_service.rb","position":63,"original_position":63,"commit_id":"68a064a40a33f9d666927056f168550f64ea4ce7","original_commit_id":"68a064a40a33f9d666927056f168550f64ea4ce7","user":{"login":"hound[bot]","id":30008653,"node_id":"MDM6Qm90MzAwMDg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/in/3598?v=4","gravatar_id":"","url":"https://api.github.com/users/hound%5Bbot%5D","html_url":"https://github.com/apps/hound","followers_url":"https://api.github.com/users/hound%5Bbot%5D/followers","following_url":"https://api.github.com/users/hound%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/hound%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/hound%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hound%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/hound%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/hound%5Bbot%5D/repos","events_url":"https://api.github.com/users/hound%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/hound%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Layout/LeadingCommentSpace: Missing space after #. (https://github.com/bbatsov/ruby-style-guide#hash-space)","created_at":"2018-10-31T17:13:15Z","updated_at":"2018-10-31T17:13:15Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1859#discussion_r229788329","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/229788329"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1859#discussion_r229788329"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859","id":224742020,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzQyMDIw","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1859","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/1859.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/1859.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1859","number":1859,"state":"open","locked":false,"title":"Add the SES Barclamp","user":{"login":"hemna","id":672207,"node_id":"MDQ6VXNlcjY3MjIwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/672207?v=4","gravatar_id":"","url":"https://api.github.com/users/hemna","html_url":"https://github.com/hemna","followers_url":"https://api.github.com/users/hemna/followers","following_url":"https://api.github.com/users/hemna/following{/other_user}","gists_url":"https://api.github.com/users/hemna/gists{/gist_id}","starred_url":"https://api.github.com/users/hemna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemna/subscriptions","organizations_url":"https://api.github.com/users/hemna/orgs","repos_url":"https://api.github.com/users/hemna/repos","events_url":"https://api.github.com/users/hemna/events{/privacy}","received_events_url":"https://api.github.com/users/hemna/received_events","type":"User","site_admin":false},"body":"This padds the new SUSE Enterprise Storage (SES) barclamp.\r\nThis barclamp can accept the SES 5.5 openstack runner's\r\nconfig.yml output.  The config.yml is added to a UI textbox\r\nand then parsed into the required fields in the barclamp ui,\r\nto support integration with an external SES/ceph cluster.\r\n\r\nTODO:\r\n  The only portion of the barclamp that currently works is the UI.\r\n  Still have to add the required service node's system level packages.\r\n  Still have to add the libvirt secret on all of the nova compute nodes.\r\n  Still have to make the required changes to support the ceph backend\r\n  settings in each of the service config files (cinder.conf, etc.)","created_at":"2018-10-22T16:48:18Z","updated_at":"2018-10-31T17:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27af3290041ec3654b6e87a7183dcf5f262d4aa7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"toabctl","id":276317,"node_id":"MDQ6VXNlcjI3NjMxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/276317?v=4","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1859/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/68a064a40a33f9d666927056f168550f64ea4ce7","head":{"label":"hemna:ses","ref":"ses","sha":"68a064a40a33f9d666927056f168550f64ea4ce7","user":{"login":"hemna","id":672207,"node_id":"MDQ6VXNlcjY3MjIwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/672207?v=4","gravatar_id":"","url":"https://api.github.com/users/hemna","html_url":"https://github.com/hemna","followers_url":"https://api.github.com/users/hemna/followers","following_url":"https://api.github.com/users/hemna/following{/other_user}","gists_url":"https://api.github.com/users/hemna/gists{/gist_id}","starred_url":"https://api.github.com/users/hemna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemna/subscriptions","organizations_url":"https://api.github.com/users/hemna/orgs","repos_url":"https://api.github.com/users/hemna/repos","events_url":"https://api.github.com/users/hemna/events{/privacy}","received_events_url":"https://api.github.com/users/hemna/received_events","type":"User","site_admin":false},"repo":{"id":151582990,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1ODI5OTA=","name":"crowbar-openstack","full_name":"hemna/crowbar-openstack","private":false,"owner":{"login":"hemna","id":672207,"node_id":"MDQ6VXNlcjY3MjIwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/672207?v=4","gravatar_id":"","url":"https://api.github.com/users/hemna","html_url":"https://github.com/hemna","followers_url":"https://api.github.com/users/hemna/followers","following_url":"https://api.github.com/users/hemna/following{/other_user}","gists_url":"https://api.github.com/users/hemna/gists{/gist_id}","starred_url":"https://api.github.com/users/hemna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemna/subscriptions","organizations_url":"https://api.github.com/users/hemna/orgs","repos_url":"https://api.github.com/users/hemna/repos","events_url":"https://api.github.com/users/hemna/events{/privacy}","received_events_url":"https://api.github.com/users/hemna/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hemna/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/hemna/crowbar-openstack","forks_url":"https://api.github.com/repos/hemna/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/hemna/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hemna/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hemna/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/hemna/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/hemna/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/hemna/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/hemna/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/hemna/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/hemna/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/hemna/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hemna/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hemna/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/hemna/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hemna/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/hemna/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/hemna/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/hemna/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/hemna/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/hemna/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/hemna/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/hemna/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/hemna/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/hemna/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/hemna/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/hemna/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hemna/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/hemna/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hemna/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/hemna/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/hemna/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/hemna/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/hemna/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hemna/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/hemna/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/hemna/crowbar-openstack/deployments","created_at":"2018-10-04T14:12:33Z","updated_at":"2018-10-11T16:24:08Z","pushed_at":"2018-10-31T17:12:53Z","git_url":"git://github.com/hemna/crowbar-openstack.git","ssh_url":"git@github.com:hemna/crowbar-openstack.git","clone_url":"https://github.com/hemna/crowbar-openstack.git","svn_url":"https://github.com/hemna/crowbar-openstack","homepage":null,"size":21532,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"cc8287034a3f141713c2bfdf610165889fe92be7","user":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"node_id":"MDEwOlJlcG9zaXRvcnkzOTAwNjkwMw==","name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","private":false,"owner":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2018-10-31T12:49:02Z","pushed_at":"2018-10-31T17:12:56Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":21583,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":86,"open_issues":88,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1859"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1859"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1859/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1859/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/68a064a40a33f9d666927056f168550f64ea4ce7"}},"author_association":"NONE"}}
{"actor":{"display_login":"hound"}}