{"action":"created","comment":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/comments/240030902","pull_request_review_id":182972176,"id":240030902,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDAzMDkwMg==","diff_hunk":"@@ -138,11 +138,7 @@\n \tstatus = \"okay\";\n \n \tath9k: wifi@0,0 {\n-\t\tcompatible = \"pci168c,0030\";","path":"target/linux/ath79/dts/ar9342_pcs_cr5000.dts","position":40,"original_position":40,"commit_id":"c1e56ecfc902ea34d5b091ae9d3671f01da5b419","original_commit_id":"c1e56ecfc902ea34d5b091ae9d3671f01da5b419","user":{"login":"chunkeey","id":787046,"node_id":"MDQ6VXNlcjc4NzA0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/787046?v=4","gravatar_id":"","url":"https://api.github.com/users/chunkeey","html_url":"https://github.com/chunkeey","followers_url":"https://api.github.com/users/chunkeey/followers","following_url":"https://api.github.com/users/chunkeey/following{/other_user}","gists_url":"https://api.github.com/users/chunkeey/gists{/gist_id}","starred_url":"https://api.github.com/users/chunkeey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunkeey/subscriptions","organizations_url":"https://api.github.com/users/chunkeey/orgs","repos_url":"https://api.github.com/users/chunkeey/repos","events_url":"https://api.github.com/users/chunkeey/events{/privacy}","received_events_url":"https://api.github.com/users/chunkeey/received_events","type":"User","site_admin":false},"body":"Please keep the compatible and reg properties around. Reason being: The AR9300/AR9380 chip on the pcie is real hardware. The unit-address 0,0 in wifi@0,0 is supposed to have a corresponding reg property, otherwise the dtc compiler will complain about it.","created_at":"2018-12-09T10:11:31Z","updated_at":"2018-12-09T10:11:48Z","html_url":"https://github.com/openwrt/openwrt/pull/1613#discussion_r240030902","pull_request_url":"https://api.github.com/repos/openwrt/openwrt/pulls/1613","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/comments/240030902"},"html":{"href":"https://github.com/openwrt/openwrt/pull/1613#discussion_r240030902"},"pull_request":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/1613"}}},"pull_request":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/1613","id":237090096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDkwMDk2","html_url":"https://github.com/openwrt/openwrt/pull/1613","diff_url":"https://github.com/openwrt/openwrt/pull/1613.diff","patch_url":"https://github.com/openwrt/openwrt/pull/1613.patch","issue_url":"https://api.github.com/repos/openwrt/openwrt/issues/1613","number":1613,"state":"open","locked":false,"title":"ath79: dts: update PowerCloud CR5000 support","user":{"login":"cshoredaniel","id":20735818,"node_id":"MDQ6VXNlcjIwNzM1ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/20735818?v=4","gravatar_id":"","url":"https://api.github.com/users/cshoredaniel","html_url":"https://github.com/cshoredaniel","followers_url":"https://api.github.com/users/cshoredaniel/followers","following_url":"https://api.github.com/users/cshoredaniel/following{/other_user}","gists_url":"https://api.github.com/users/cshoredaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/cshoredaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshoredaniel/subscriptions","organizations_url":"https://api.github.com/users/cshoredaniel/orgs","repos_url":"https://api.github.com/users/cshoredaniel/repos","events_url":"https://api.github.com/users/cshoredaniel/events{/privacy}","received_events_url":"https://api.github.com/users/cshoredaniel/received_events","type":"User","site_admin":false},"body":"* The PowerCloud CR5000 uses AR1022 SoC (detects as AR9342) not\r\n  an AR9344.\r\n* Fix PCIe to use the same settings as ap94_pci_init for ar71xx.\r\n* Some DTS renaming (e.g. to gpio-keys-polls from keys)\r\n\r\n\r\nSigned-off-by: Daniel F. Dickinson <cshored@thecshore.com>\r\n\r\n@mkresin (or anyone else): Any idea why ``mtd-mac-address`` is not being used for the PCIe ath9k wireless?  The mac address from the PCI EEPROM is being used instead (which is not the OEM's MAC address which is at art + 0x5002 on the flash).\r\n\r\nAlso, while this gets 5GHz wireless working again on the CR5000, I'm not sure the wifi@0,12 and reg = <0x9000 0 0 0 0x10000> are actually right, and am wondering how to determine (for certain) the correct values.","created_at":"2018-12-08T20:39:15Z","updated_at":"2018-12-09T10:11:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4879f7486c1429e802e7f91e1df6416a8b973653","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openwrt/openwrt/pulls/1613/commits","review_comments_url":"https://api.github.com/repos/openwrt/openwrt/pulls/1613/comments","review_comment_url":"https://api.github.com/repos/openwrt/openwrt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openwrt/openwrt/issues/1613/comments","statuses_url":"https://api.github.com/repos/openwrt/openwrt/statuses/c1e56ecfc902ea34d5b091ae9d3671f01da5b419","head":{"label":"cshoredaniel:pr-cr5000-fix-support","ref":"pr-cr5000-fix-support","sha":"c1e56ecfc902ea34d5b091ae9d3671f01da5b419","user":{"login":"cshoredaniel","id":20735818,"node_id":"MDQ6VXNlcjIwNzM1ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/20735818?v=4","gravatar_id":"","url":"https://api.github.com/users/cshoredaniel","html_url":"https://github.com/cshoredaniel","followers_url":"https://api.github.com/users/cshoredaniel/followers","following_url":"https://api.github.com/users/cshoredaniel/following{/other_user}","gists_url":"https://api.github.com/users/cshoredaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/cshoredaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshoredaniel/subscriptions","organizations_url":"https://api.github.com/users/cshoredaniel/orgs","repos_url":"https://api.github.com/users/cshoredaniel/repos","events_url":"https://api.github.com/users/cshoredaniel/events{/privacy}","received_events_url":"https://api.github.com/users/cshoredaniel/received_events","type":"User","site_admin":false},"repo":{"id":117382738,"node_id":"MDEwOlJlcG9zaXRvcnkxMTczODI3Mzg=","name":"openwrt-openwrt","full_name":"cshoredaniel/openwrt-openwrt","private":false,"owner":{"login":"cshoredaniel","id":20735818,"node_id":"MDQ6VXNlcjIwNzM1ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/20735818?v=4","gravatar_id":"","url":"https://api.github.com/users/cshoredaniel","html_url":"https://github.com/cshoredaniel","followers_url":"https://api.github.com/users/cshoredaniel/followers","following_url":"https://api.github.com/users/cshoredaniel/following{/other_user}","gists_url":"https://api.github.com/users/cshoredaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/cshoredaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshoredaniel/subscriptions","organizations_url":"https://api.github.com/users/cshoredaniel/orgs","repos_url":"https://api.github.com/users/cshoredaniel/repos","events_url":"https://api.github.com/users/cshoredaniel/events{/privacy}","received_events_url":"https://api.github.com/users/cshoredaniel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cshoredaniel/openwrt-openwrt","description":"Fork of OpenWrt main repo for my PR's","fork":true,"url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt","forks_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/forks","keys_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/teams","hooks_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/hooks","issue_events_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/issues/events{/number}","events_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/events","assignees_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/assignees{/user}","branches_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/branches{/branch}","tags_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/tags","blobs_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/statuses/{sha}","languages_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/languages","stargazers_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/stargazers","contributors_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/contributors","subscribers_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/subscribers","subscription_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/subscription","commits_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/contents/{+path}","compare_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/merges","archive_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/downloads","issues_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/issues{/number}","pulls_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/pulls{/number}","milestones_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/milestones{/number}","notifications_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/labels{/name}","releases_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/releases{/id}","deployments_url":"https://api.github.com/repos/cshoredaniel/openwrt-openwrt/deployments","created_at":"2018-01-13T22:16:39Z","updated_at":"2018-12-08T20:58:04Z","pushed_at":"2018-12-09T00:20:54Z","git_url":"git://github.com/cshoredaniel/openwrt-openwrt.git","ssh_url":"git@github.com:cshoredaniel/openwrt-openwrt.git","clone_url":"https://github.com/cshoredaniel/openwrt-openwrt.git","svn_url":"https://github.com/cshoredaniel/openwrt-openwrt","homepage":"https://openwrt.org","size":157814,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openwrt:master","ref":"master","sha":"f939598b7a7ce2079722295603e2dcee93ad310d","user":{"login":"openwrt","id":2528830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjg4MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"repo":{"id":45821540,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgyMTU0MA==","name":"openwrt","full_name":"openwrt/openwrt","private":false,"owner":{"login":"openwrt","id":2528830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjg4MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openwrt/openwrt","description":"This repository is a mirror of https://git.openwrt.org/openwrt/openwrt.git It is for reference only and is not active for check-ins or for reporting issues.  We will continue to accept Pull Requests here. They will be merged via staging trees then into openwrt.git. All issues should be reported at: https://bugs.openwrt.org","fork":false,"url":"https://api.github.com/repos/openwrt/openwrt","forks_url":"https://api.github.com/repos/openwrt/openwrt/forks","keys_url":"https://api.github.com/repos/openwrt/openwrt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openwrt/openwrt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openwrt/openwrt/teams","hooks_url":"https://api.github.com/repos/openwrt/openwrt/hooks","issue_events_url":"https://api.github.com/repos/openwrt/openwrt/issues/events{/number}","events_url":"https://api.github.com/repos/openwrt/openwrt/events","assignees_url":"https://api.github.com/repos/openwrt/openwrt/assignees{/user}","branches_url":"https://api.github.com/repos/openwrt/openwrt/branches{/branch}","tags_url":"https://api.github.com/repos/openwrt/openwrt/tags","blobs_url":"https://api.github.com/repos/openwrt/openwrt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openwrt/openwrt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openwrt/openwrt/git/refs{/sha}","trees_url":"https://api.github.com/repos/openwrt/openwrt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openwrt/openwrt/statuses/{sha}","languages_url":"https://api.github.com/repos/openwrt/openwrt/languages","stargazers_url":"https://api.github.com/repos/openwrt/openwrt/stargazers","contributors_url":"https://api.github.com/repos/openwrt/openwrt/contributors","subscribers_url":"https://api.github.com/repos/openwrt/openwrt/subscribers","subscription_url":"https://api.github.com/repos/openwrt/openwrt/subscription","commits_url":"https://api.github.com/repos/openwrt/openwrt/commits{/sha}","git_commits_url":"https://api.github.com/repos/openwrt/openwrt/git/commits{/sha}","comments_url":"https://api.github.com/repos/openwrt/openwrt/comments{/number}","issue_comment_url":"https://api.github.com/repos/openwrt/openwrt/issues/comments{/number}","contents_url":"https://api.github.com/repos/openwrt/openwrt/contents/{+path}","compare_url":"https://api.github.com/repos/openwrt/openwrt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openwrt/openwrt/merges","archive_url":"https://api.github.com/repos/openwrt/openwrt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openwrt/openwrt/downloads","issues_url":"https://api.github.com/repos/openwrt/openwrt/issues{/number}","pulls_url":"https://api.github.com/repos/openwrt/openwrt/pulls{/number}","milestones_url":"https://api.github.com/repos/openwrt/openwrt/milestones{/number}","notifications_url":"https://api.github.com/repos/openwrt/openwrt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openwrt/openwrt/labels{/name}","releases_url":"https://api.github.com/repos/openwrt/openwrt/releases{/id}","deployments_url":"https://api.github.com/repos/openwrt/openwrt/deployments","created_at":"2015-11-09T07:13:55Z","updated_at":"2018-12-09T07:54:28Z","pushed_at":"2018-12-09T02:52:54Z","git_url":"git://github.com/openwrt/openwrt.git","ssh_url":"git@github.com:openwrt/openwrt.git","clone_url":"https://github.com/openwrt/openwrt.git","svn_url":"https://github.com/openwrt/openwrt","homepage":"","size":157945,"stargazers_count":3221,"watchers_count":3221,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1975,"mirror_url":null,"archived":false,"open_issues_count":319,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1975,"open_issues":319,"watchers":3221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/1613"},"html":{"href":"https://github.com/openwrt/openwrt/pull/1613"},"issue":{"href":"https://api.github.com/repos/openwrt/openwrt/issues/1613"},"comments":{"href":"https://api.github.com/repos/openwrt/openwrt/issues/1613/comments"},"review_comments":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/1613/comments"},"review_comment":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/1613/commits"},"statuses":{"href":"https://api.github.com/repos/openwrt/openwrt/statuses/c1e56ecfc902ea34d5b091ae9d3671f01da5b419"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chunkeey"}}