{"action":"created","comment":{"url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/comments/225676786","pull_request_review_id":165323751,"id":225676786,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTY3Njc4Ng==","diff_hunk":"@@ -2,48 +2,58 @@ import * as React from 'react'\n import { findDOMNode } from 'react-dom'\n \n interface Props {\n+  page: number\n   onPage: (number: number) => void\n }\n \n+const noop = () => {}\n+\n class ScrollMonitor extends React.Component<Props, null> {\n-  page = 0\n-  threshold = 0\n-  teardown: () => void\n+  teardown: () => void = noop","path":"src/components/scroll-monitor.tsx","position":14,"original_position":14,"commit_id":"91bdd013d8deed1b6d3e95c35edf2ab50fdba640","original_commit_id":"b1cfedf1b1bff7362e0996405197f126d3dd53c2","user":{"login":"joeyjoejoejr","id":1141502,"node_id":"MDQ6VXNlcjExNDE1MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1141502?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyjoejoejr","html_url":"https://github.com/joeyjoejoejr","followers_url":"https://api.github.com/users/joeyjoejoejr/followers","following_url":"https://api.github.com/users/joeyjoejoejr/following{/other_user}","gists_url":"https://api.github.com/users/joeyjoejoejr/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyjoejoejr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyjoejoejr/subscriptions","organizations_url":"https://api.github.com/users/joeyjoejoejr/orgs","repos_url":"https://api.github.com/users/joeyjoejoejr/repos","events_url":"https://api.github.com/users/joeyjoejoejr/events{/privacy}","received_events_url":"https://api.github.com/users/joeyjoejoejr/received_events","type":"User","site_admin":false},"body":"I might opt for just inlining the noop. Then you don't really need the type declaration, right?  Inference would take care of that for you.","created_at":"2018-10-16T19:24:12Z","updated_at":"2018-10-16T19:28:56Z","html_url":"https://github.com/vigetlabs/ars-arsenal/pull/55#discussion_r225676786","pull_request_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/comments/225676786"},"html":{"href":"https://github.com/vigetlabs/ars-arsenal/pull/55#discussion_r225676786"},"pull_request":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55","id":223362727,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzYyNzI3","html_url":"https://github.com/vigetlabs/ars-arsenal/pull/55","diff_url":"https://github.com/vigetlabs/ars-arsenal/pull/55.diff","patch_url":"https://github.com/vigetlabs/ars-arsenal/pull/55.patch","issue_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/55","number":55,"state":"open","locked":false,"title":"Fix sorting","user":{"login":"nhunzaker","id":590904,"node_id":"MDQ6VXNlcjU5MDkwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/590904?v=4","gravatar_id":"","url":"https://api.github.com/users/nhunzaker","html_url":"https://github.com/nhunzaker","followers_url":"https://api.github.com/users/nhunzaker/followers","following_url":"https://api.github.com/users/nhunzaker/following{/other_user}","gists_url":"https://api.github.com/users/nhunzaker/gists{/gist_id}","starred_url":"https://api.github.com/users/nhunzaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhunzaker/subscriptions","organizations_url":"https://api.github.com/users/nhunzaker/orgs","repos_url":"https://api.github.com/users/nhunzaker/repos","events_url":"https://api.github.com/users/nhunzaker/events{/privacy}","received_events_url":"https://api.github.com/users/nhunzaker/received_events","type":"User","site_admin":false},"body":"Sorting was happening client side, however we can't do that in a world\r\nwith pagination.\r\n\r\nThis commit adds server-backed sorting to the app. This is more\r\ncomplicated than I'd like, but it got really tricky to keep the\r\ncurrent content while cancelling outstanding requests and waiting for\r\nnew results.","created_at":"2018-10-16T19:06:16Z","updated_at":"2018-10-16T19:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bda3669eb61458418c37ea97ecfe8ddd6d498e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55/commits","review_comments_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55/comments","review_comment_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/55/comments","statuses_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/statuses/91bdd013d8deed1b6d3e95c35edf2ab50fdba640","head":{"label":"vigetlabs:sorting","ref":"sorting","sha":"91bdd013d8deed1b6d3e95c35edf2ab50fdba640","user":{"login":"vigetlabs","id":4845,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4845?v=4","gravatar_id":"","url":"https://api.github.com/users/vigetlabs","html_url":"https://github.com/vigetlabs","followers_url":"https://api.github.com/users/vigetlabs/followers","following_url":"https://api.github.com/users/vigetlabs/following{/other_user}","gists_url":"https://api.github.com/users/vigetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vigetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vigetlabs/subscriptions","organizations_url":"https://api.github.com/users/vigetlabs/orgs","repos_url":"https://api.github.com/users/vigetlabs/repos","events_url":"https://api.github.com/users/vigetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vigetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":27774541,"node_id":"MDEwOlJlcG9zaXRvcnkyNzc3NDU0MQ==","name":"ars-arsenal","full_name":"vigetlabs/ars-arsenal","private":false,"owner":{"login":"vigetlabs","id":4845,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4845?v=4","gravatar_id":"","url":"https://api.github.com/users/vigetlabs","html_url":"https://github.com/vigetlabs","followers_url":"https://api.github.com/users/vigetlabs/followers","following_url":"https://api.github.com/users/vigetlabs/following{/other_user}","gists_url":"https://api.github.com/users/vigetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vigetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vigetlabs/subscriptions","organizations_url":"https://api.github.com/users/vigetlabs/orgs","repos_url":"https://api.github.com/users/vigetlabs/repos","events_url":"https://api.github.com/users/vigetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vigetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vigetlabs/ars-arsenal","description":"A react gallery picker","fork":false,"url":"https://api.github.com/repos/vigetlabs/ars-arsenal","forks_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/forks","keys_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/teams","hooks_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/hooks","issue_events_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/events{/number}","events_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/events","assignees_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/assignees{/user}","branches_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/branches{/branch}","tags_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/tags","blobs_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/refs{/sha}","trees_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/statuses/{sha}","languages_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/languages","stargazers_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/stargazers","contributors_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/contributors","subscribers_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/subscribers","subscription_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/subscription","commits_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/commits{/sha}","git_commits_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/commits{/sha}","comments_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/comments{/number}","issue_comment_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/comments{/number}","contents_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/contents/{+path}","compare_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/merges","archive_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/downloads","issues_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues{/number}","pulls_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls{/number}","milestones_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/milestones{/number}","notifications_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/labels{/name}","releases_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/releases{/id}","deployments_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/deployments","created_at":"2014-12-09T16:03:37Z","updated_at":"2018-10-15T17:49:00Z","pushed_at":"2018-10-16T19:17:48Z","git_url":"git://github.com/vigetlabs/ars-arsenal.git","ssh_url":"git@github.com:vigetlabs/ars-arsenal.git","clone_url":"https://github.com/vigetlabs/ars-arsenal.git","svn_url":"https://github.com/vigetlabs/ars-arsenal","homepage":"https://ars-arsenal.netlify.com/","size":2561,"stargazers_count":17,"watchers_count":17,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":6,"watchers":17,"default_branch":"master"}},"base":{"label":"vigetlabs:docs-3.0.0","ref":"docs-3.0.0","sha":"7cd5d15db8fd5bf15bceffa93ca2a1b43e0182a0","user":{"login":"vigetlabs","id":4845,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4845?v=4","gravatar_id":"","url":"https://api.github.com/users/vigetlabs","html_url":"https://github.com/vigetlabs","followers_url":"https://api.github.com/users/vigetlabs/followers","following_url":"https://api.github.com/users/vigetlabs/following{/other_user}","gists_url":"https://api.github.com/users/vigetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vigetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vigetlabs/subscriptions","organizations_url":"https://api.github.com/users/vigetlabs/orgs","repos_url":"https://api.github.com/users/vigetlabs/repos","events_url":"https://api.github.com/users/vigetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vigetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":27774541,"node_id":"MDEwOlJlcG9zaXRvcnkyNzc3NDU0MQ==","name":"ars-arsenal","full_name":"vigetlabs/ars-arsenal","private":false,"owner":{"login":"vigetlabs","id":4845,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4845?v=4","gravatar_id":"","url":"https://api.github.com/users/vigetlabs","html_url":"https://github.com/vigetlabs","followers_url":"https://api.github.com/users/vigetlabs/followers","following_url":"https://api.github.com/users/vigetlabs/following{/other_user}","gists_url":"https://api.github.com/users/vigetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vigetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vigetlabs/subscriptions","organizations_url":"https://api.github.com/users/vigetlabs/orgs","repos_url":"https://api.github.com/users/vigetlabs/repos","events_url":"https://api.github.com/users/vigetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vigetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vigetlabs/ars-arsenal","description":"A react gallery picker","fork":false,"url":"https://api.github.com/repos/vigetlabs/ars-arsenal","forks_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/forks","keys_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/teams","hooks_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/hooks","issue_events_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/events{/number}","events_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/events","assignees_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/assignees{/user}","branches_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/branches{/branch}","tags_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/tags","blobs_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/refs{/sha}","trees_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/statuses/{sha}","languages_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/languages","stargazers_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/stargazers","contributors_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/contributors","subscribers_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/subscribers","subscription_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/subscription","commits_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/commits{/sha}","git_commits_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/git/commits{/sha}","comments_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/comments{/number}","issue_comment_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/comments{/number}","contents_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/contents/{+path}","compare_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/merges","archive_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/downloads","issues_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues{/number}","pulls_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls{/number}","milestones_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/milestones{/number}","notifications_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/labels{/name}","releases_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/releases{/id}","deployments_url":"https://api.github.com/repos/vigetlabs/ars-arsenal/deployments","created_at":"2014-12-09T16:03:37Z","updated_at":"2018-10-15T17:49:00Z","pushed_at":"2018-10-16T19:17:48Z","git_url":"git://github.com/vigetlabs/ars-arsenal.git","ssh_url":"git@github.com:vigetlabs/ars-arsenal.git","clone_url":"https://github.com/vigetlabs/ars-arsenal.git","svn_url":"https://github.com/vigetlabs/ars-arsenal","homepage":"https://ars-arsenal.netlify.com/","size":2561,"stargazers_count":17,"watchers_count":17,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":6,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55"},"html":{"href":"https://github.com/vigetlabs/ars-arsenal/pull/55"},"issue":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/55"},"comments":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/vigetlabs/ars-arsenal/statuses/91bdd013d8deed1b6d3e95c35edf2ab50fdba640"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joeyjoejoejr"}}