{"action":"closed","number":8527,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/8527","id":234859782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODU5Nzgy","html_url":"https://github.com/pingcap/tidb/pull/8527","diff_url":"https://github.com/pingcap/tidb/pull/8527.diff","patch_url":"https://github.com/pingcap/tidb/pull/8527.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/8527","number":8527,"state":"closed","locked":false,"title":" tidb/kv: remove useless errors.Trace","user":{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"body":"### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\n`ErrNotExist` no need to get stack, so we see it use much time in pprof\r\n\r\n### What is changed and how it works?\r\n\r\nIn this PR just remove it to quickly fix.\r\n\r\nmaybe we should refine our pingcap/errors to meet `no need stack error` situation\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Old test\r\n\r\nCode changes\r\n\r\n - Impl change\r\n\r\nSide effects\r\n\r\n - N/A\r\n\r\nRelated changes\r\n\r\n - Need to cherry-pick to the release branch\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pingcap/tidb/8527)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-11-30T03:20:31Z","updated_at":"2018-11-30T06:30:32Z","closed_at":"2018-11-30T06:30:32Z","merged_at":"2018-11-30T06:30:32Z","merge_commit_sha":"36bcf5db4ab610aff7287081da04e2893760a45a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":972099262,"node_id":"MDU6TGFiZWw5NzIwOTkyNjI=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/tikv-client","name":"component/tikv-client","color":"8bef73","default":false},{"id":770872605,"node_id":"MDU6TGFiZWw3NzA4NzI2MDU=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/all%20tests%20passed","name":"status/all tests passed","color":"2cbe4e","default":false},{"id":256872088,"node_id":"MDU6TGFiZWwyNTY4NzIwODg=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/enhancement","name":"type/enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/8527/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/8527/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/8527/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/e485999a33a6e4434ed37321aa5f50965a86fd75","head":{"label":"lysu:remove-useless-errors-trace","ref":"remove-useless-errors-trace","sha":"e485999a33a6e4434ed37321aa5f50965a86fd75","user":{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"repo":{"id":133315666,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMTU2NjY=","name":"tidb","full_name":"lysu/tidb","private":false,"owner":{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lysu/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":true,"url":"https://api.github.com/repos/lysu/tidb","forks_url":"https://api.github.com/repos/lysu/tidb/forks","keys_url":"https://api.github.com/repos/lysu/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lysu/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lysu/tidb/teams","hooks_url":"https://api.github.com/repos/lysu/tidb/hooks","issue_events_url":"https://api.github.com/repos/lysu/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/lysu/tidb/events","assignees_url":"https://api.github.com/repos/lysu/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/lysu/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/lysu/tidb/tags","blobs_url":"https://api.github.com/repos/lysu/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lysu/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lysu/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/lysu/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lysu/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/lysu/tidb/languages","stargazers_url":"https://api.github.com/repos/lysu/tidb/stargazers","contributors_url":"https://api.github.com/repos/lysu/tidb/contributors","subscribers_url":"https://api.github.com/repos/lysu/tidb/subscribers","subscription_url":"https://api.github.com/repos/lysu/tidb/subscription","commits_url":"https://api.github.com/repos/lysu/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/lysu/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/lysu/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/lysu/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/lysu/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/lysu/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lysu/tidb/merges","archive_url":"https://api.github.com/repos/lysu/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lysu/tidb/downloads","issues_url":"https://api.github.com/repos/lysu/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/lysu/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/lysu/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/lysu/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lysu/tidb/labels{/name}","releases_url":"https://api.github.com/repos/lysu/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/lysu/tidb/deployments","created_at":"2018-05-14T06:37:16Z","updated_at":"2018-11-27T08:57:51Z","pushed_at":"2018-11-30T03:47:44Z","git_url":"git://github.com/lysu/tidb.git","ssh_url":"git@github.com:lysu/tidb.git","clone_url":"https://github.com/lysu/tidb.git","svn_url":"https://github.com/lysu/tidb","homepage":"https://pingcap.com","size":65895,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"4bcdb6d8ee7906947008603d95c543cd978b1106","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-11-30T06:30:27Z","pushed_at":"2018-11-30T06:30:32Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":95003,"stargazers_count":16132,"watchers_count":16132,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2289,"mirror_url":null,"archived":false,"open_issues_count":589,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2289,"open_issues":589,"watchers":16132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8527"},"html":{"href":"https://github.com/pingcap/tidb/pull/8527"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/8527"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/8527/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8527/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8527/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/e485999a33a6e4434ed37321aa5f50965a86fd75"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tiancaiamao","id":1420062,"node_id":"MDQ6VXNlcjE0MjAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":9,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"tiancaiamao"}}