{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24478","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24478/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24478/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24478/events","html_url":"https://github.com/nodejs/node/pull/24478","id":382104529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODg4Mzk2","number":24478,"title":"test: replace anonymous closure functions with arrow functions","user":{"login":"sagirk","id":2608321,"node_id":"MDQ6VXNlcjI2MDgzMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2608321?v=4","gravatar_id":"","url":"https://api.github.com/users/sagirk","html_url":"https://github.com/sagirk","followers_url":"https://api.github.com/users/sagirk/followers","following_url":"https://api.github.com/users/sagirk/following{/other_user}","gists_url":"https://api.github.com/users/sagirk/gists{/gist_id}","starred_url":"https://api.github.com/users/sagirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagirk/subscriptions","organizations_url":"https://api.github.com/users/sagirk/orgs","repos_url":"https://api.github.com/users/sagirk/repos","events_url":"https://api.github.com/users/sagirk/events{/privacy}","received_events_url":"https://api.github.com/users/sagirk/received_events","type":"User","site_admin":false},"labels":[{"id":492471325,"node_id":"MDU6TGFiZWw0OTI0NzEzMjU=","url":"https://api.github.com/repos/nodejs/node/labels/code-and-learn","name":"code-and-learn","color":"bfd4f2","default":false},{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-19T08:28:43Z","updated_at":"2018-11-19T11:30:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24478","html_url":"https://github.com/nodejs/node/pull/24478","diff_url":"https://github.com/nodejs/node/pull/24478.diff","patch_url":"https://github.com/nodejs/node/pull/24478.patch"},"body":"In `test/parallel/test-fs-truncate-fd.js`, callbacks use anonymous\r\nclosure functions. It is safe to replace them with arrow functions since\r\nthese callbacks don't alter their context (`this`). This results in\r\nshorter functions.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/439862660","html_url":"https://github.com/nodejs/node/pull/24478#issuecomment-439862660","issue_url":"https://api.github.com/repos/nodejs/node/issues/24478","id":439862660,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTg2MjY2MA==","user":{"login":"gireeshpunathil","id":6447530,"node_id":"MDQ6VXNlcjY0NDc1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6447530?v=4","gravatar_id":"","url":"https://api.github.com/users/gireeshpunathil","html_url":"https://github.com/gireeshpunathil","followers_url":"https://api.github.com/users/gireeshpunathil/followers","following_url":"https://api.github.com/users/gireeshpunathil/following{/other_user}","gists_url":"https://api.github.com/users/gireeshpunathil/gists{/gist_id}","starred_url":"https://api.github.com/users/gireeshpunathil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gireeshpunathil/subscriptions","organizations_url":"https://api.github.com/users/gireeshpunathil/orgs","repos_url":"https://api.github.com/users/gireeshpunathil/repos","events_url":"https://api.github.com/users/gireeshpunathil/events{/privacy}","received_events_url":"https://api.github.com/users/gireeshpunathil/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T11:30:47Z","updated_at":"2018-11-19T11:30:47Z","author_association":"MEMBER","body":"CI: https://ci.nodejs.org/job/node-test-pull-request/18753/"}}
{"actor":{"display_login":"gireeshpunathil"}}