{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/233502273","pull_request_review_id":174930050,"id":233502273,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzUwMjI3Mw==","diff_hunk":"@@ -2896,6 +2896,53 @@ MAV_RESULT GCS_MAVLINK::handle_command_do_set_roi(const Location &roi_loc)\n     return MAV_RESULT_ACCEPTED;\n }\n \n+MAV_RESULT GCS_MAVLINK::handle_command_int_do_set_home(const mavlink_command_int_t &packet)\n+{\n+    if (is_equal(packet.param1, 1.0f)) {\n+        // if param1 is 1, use current location\n+        if (!set_home_to_current_location(true)) {\n+            return MAV_RESULT_FAILED;\n+        }\n+        return MAV_RESULT_ACCEPTED;\n+    }\n+    // ensure param1 is zero\n+    if (!is_zero(packet.param1)) {\n+        return MAV_RESULT_FAILED;\n+    }\n+    if ((packet.x == 0) && (packet.y == 0) && is_zero(packet.z)) {\n+        // don't allow the 0,0 position","path":"libraries/GCS_MAVLink/GCS_Common.cpp","position":45,"original_position":44,"commit_id":"9e5e9318c91650d7afdcd879c05e28538924c4b1","original_commit_id":"0f059f643824c7830f51171f7f0b85c466aee76c","user":{"login":"OXINARF","id":1778527,"node_id":"MDQ6VXNlcjE3Nzg1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1778527?v=4","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},"body":"@peterbarker I'm not sure how it saves GCSs from themselves when all vehicles except Plane currently allow (0,0).\r\n\r\n@WickedShell That might be true, I don't know, but we should be removing that behaviour from Plane instead of putting it additionally on other vehicles.","created_at":"2018-11-14T15:47:04Z","updated_at":"2018-11-14T15:47:05Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/8839#discussion_r233502273","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/233502273"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8839#discussion_r233502273"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839"}},"in_reply_to_id":232670394},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839","id":199636895,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjM2ODk1","html_url":"https://github.com/ArduPilot/ardupilot/pull/8839","diff_url":"https://github.com/ArduPilot/ardupilot/pull/8839.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/8839.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839","number":8839,"state":"open","locked":false,"title":"Move handling of DO_SET_HOME via command_int up","user":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-06T03:33:33Z","updated_at":"2018-11-14T15:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38e20c4212db56781b6289191e7255bba668f44d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/9e5e9318c91650d7afdcd879c05e28538924c4b1","head":{"label":"peterbarker:do-set-home-up","ref":"do-set-home-up","sha":"9e5e9318c91650d7afdcd879c05e28538924c4b1","user":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"repo":{"id":34165570,"node_id":"MDEwOlJlcG9zaXRvcnkzNDE2NTU3MA==","name":"ardupilot","full_name":"peterbarker/ardupilot","private":false,"owner":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/peterbarker/ardupilot","description":"APM Plane, APM Copter, APM Rover source","fork":true,"url":"https://api.github.com/repos/peterbarker/ardupilot","forks_url":"https://api.github.com/repos/peterbarker/ardupilot/forks","keys_url":"https://api.github.com/repos/peterbarker/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterbarker/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterbarker/ardupilot/teams","hooks_url":"https://api.github.com/repos/peterbarker/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/peterbarker/ardupilot/events","assignees_url":"https://api.github.com/repos/peterbarker/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/peterbarker/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/peterbarker/ardupilot/tags","blobs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterbarker/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterbarker/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterbarker/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/peterbarker/ardupilot/languages","stargazers_url":"https://api.github.com/repos/peterbarker/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/peterbarker/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/peterbarker/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/peterbarker/ardupilot/subscription","commits_url":"https://api.github.com/repos/peterbarker/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterbarker/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterbarker/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterbarker/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/peterbarker/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterbarker/ardupilot/merges","archive_url":"https://api.github.com/repos/peterbarker/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterbarker/ardupilot/downloads","issues_url":"https://api.github.com/repos/peterbarker/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/peterbarker/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/peterbarker/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/peterbarker/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterbarker/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/peterbarker/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/peterbarker/ardupilot/deployments","created_at":"2015-04-18T12:46:36Z","updated_at":"2016-11-30T01:59:51Z","pushed_at":"2018-11-14T10:13:19Z","git_url":"git://github.com/peterbarker/ardupilot.git","ssh_url":"git@github.com:peterbarker/ardupilot.git","clone_url":"https://github.com/peterbarker/ardupilot.git","svn_url":"https://github.com/peterbarker/ardupilot","homepage":"http://ardupilot.com/","size":117338,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"d824cf0a4086f83ed43e9d460f42cb766906f11d","user":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEyNDg0","name":"ardupilot","full_name":"ArduPilot/ardupilot","private":false,"owner":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2018-11-14T11:44:33Z","pushed_at":"2018-11-14T11:43:14Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":116513,"stargazers_count":3580,"watchers_count":3580,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7118,"mirror_url":null,"archived":false,"open_issues_count":1312,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7118,"open_issues":1312,"watchers":3580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8839"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/9e5e9318c91650d7afdcd879c05e28538924c4b1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OXINARF"}}