{"action":"created","issue":{"url":"https://api.github.com/repos/servo/webrender/issues/2556","repository_url":"https://api.github.com/repos/servo/webrender","labels_url":"https://api.github.com/repos/servo/webrender/issues/2556/labels{/name}","comments_url":"https://api.github.com/repos/servo/webrender/issues/2556/comments","events_url":"https://api.github.com/repos/servo/webrender/issues/2556/events","html_url":"https://github.com/servo/webrender/pull/2556","id":307524791,"number":2556,"title":"Unify text-shadows with the blur filter.","user":{"login":"glennw","id":2350882,"avatar_url":"https://avatars0.githubusercontent.com/u/2350882?v=4","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-22T06:48:05Z","updated_at":"2018-03-22T12:24:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/servo/webrender/pulls/2556","html_url":"https://github.com/servo/webrender/pull/2556","diff_url":"https://github.com/servo/webrender/pull/2556.diff","patch_url":"https://github.com/servo/webrender/pull/2556.patch"},"body":"This removes any special code for text shadows. A text shadow is\r\nnow simply a Picture with text runs and/or line decorations that\r\nhas a blur filter applied to it.\r\n\r\nThis is possible due to the recent work related to removing the line\r\ndecoration and cached text run primitives.\r\n\r\nThis greatly simplifies the shadow code, and a lot of the functionality\r\nof the text shadows (e.g. fast path shadows) just fall out of the\r\nexisting Picture functionality for blur filters.\r\n\r\nNext step is to expand the primitive types that can run through the\r\nshadow paths, which will then allow us to unify the drop-shadow\r\nfilter to be a simple shadow + blur filter.\r\n\r\nNOTE: The PictureKind enum now has only a single kind (Image). I could\r\n      have removed that in this PR, and added the fields to Picture\r\n      directly. However, that will result in a lot of indentation\r\n      changes. So I'll do that as a follow up PR to make this one\r\n      easier to review.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/webrender/2556)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/webrender/issues/comments/375285733","html_url":"https://github.com/servo/webrender/pull/2556#issuecomment-375285733","issue_url":"https://api.github.com/repos/servo/webrender/issues/2556","id":375285733,"user":{"login":"staktrace","id":485789,"avatar_url":"https://avatars3.githubusercontent.com/u/485789?v=4","gravatar_id":"","url":"https://api.github.com/users/staktrace","html_url":"https://github.com/staktrace","followers_url":"https://api.github.com/users/staktrace/followers","following_url":"https://api.github.com/users/staktrace/following{/other_user}","gists_url":"https://api.github.com/users/staktrace/gists{/gist_id}","starred_url":"https://api.github.com/users/staktrace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staktrace/subscriptions","organizations_url":"https://api.github.com/users/staktrace/orgs","repos_url":"https://api.github.com/users/staktrace/repos","events_url":"https://api.github.com/users/staktrace/events{/privacy}","received_events_url":"https://api.github.com/users/staktrace/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T12:24:40Z","updated_at":"2018-03-22T12:24:40Z","author_association":"CONTRIBUTOR","body":"@glennw I agree with your try push assessment, I think this is fine to land."}}
{"actor":{"display_login":"staktrace"}}