{"action":"created","issue":{"url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive/issues/201","repository_url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive","labels_url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive/issues/201/comments","events_url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive/issues/201/events","html_url":"https://github.com/algorithm-archivists/algorithm-archive/issues/201","id":337515404,"node_id":"MDU6SXNzdWUzMzc1MTU0MDQ=","number":201,"title":"Gauss elimination code (Julia) is wrong ","user":{"login":"VikingScientist","id":3500376,"node_id":"MDQ6VXNlcjM1MDAzNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3500376?v=4","gravatar_id":"","url":"https://api.github.com/users/VikingScientist","html_url":"https://github.com/VikingScientist","followers_url":"https://api.github.com/users/VikingScientist/followers","following_url":"https://api.github.com/users/VikingScientist/following{/other_user}","gists_url":"https://api.github.com/users/VikingScientist/gists{/gist_id}","starred_url":"https://api.github.com/users/VikingScientist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VikingScientist/subscriptions","organizations_url":"https://api.github.com/users/VikingScientist/orgs","repos_url":"https://api.github.com/users/VikingScientist/repos","events_url":"https://api.github.com/users/VikingScientist/events{/privacy}","received_events_url":"https://api.github.com/users/VikingScientist/received_events","type":"User","site_admin":false},"labels":[{"id":537229263,"node_id":"MDU6TGFiZWw1MzcyMjkyNjM=","url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive/labels/Problem","name":"Problem","color":"ee0701","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-02T13:19:38Z","updated_at":"2018-07-03T04:38:52Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Basically\r\n* Don't check for singularity as Gauss Elimination can be done on singular matrices\r\n* Pivots are not neccessarily on the diagonal\r\n* Cover the general case and don't assume triangular matrices\r\n\r\nThis issue affects PR #200 (contains more details on the bugs) and PR #195 "},"comment":{"url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive/issues/comments/402011041","html_url":"https://github.com/algorithm-archivists/algorithm-archive/issues/201#issuecomment-402011041","issue_url":"https://api.github.com/repos/algorithm-archivists/algorithm-archive/issues/201","id":402011041,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjAxMTA0MQ==","user":{"login":"jiegillet","id":16929078,"node_id":"MDQ6VXNlcjE2OTI5MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/16929078?v=4","gravatar_id":"","url":"https://api.github.com/users/jiegillet","html_url":"https://github.com/jiegillet","followers_url":"https://api.github.com/users/jiegillet/followers","following_url":"https://api.github.com/users/jiegillet/following{/other_user}","gists_url":"https://api.github.com/users/jiegillet/gists{/gist_id}","starred_url":"https://api.github.com/users/jiegillet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiegillet/subscriptions","organizations_url":"https://api.github.com/users/jiegillet/orgs","repos_url":"https://api.github.com/users/jiegillet/repos","events_url":"https://api.github.com/users/jiegillet/events{/privacy}","received_events_url":"https://api.github.com/users/jiegillet/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T04:38:52Z","updated_at":"2018-07-03T04:38:52Z","author_association":"MEMBER","body":"The best is 4. In general, almost nothing you state in the chapter is wrong so it doesn't need that much rewrite. Back substitution DOES make sense in the case of singular matrices, you just need to travel through the pivots, not the diagonal. Again, very little rewrite, I believe. And yes, putting a couple more examples of non-physical examples will help with intuition.\r\n\r\nI'm very happy to try and add something to my PR tonight, I've already modified the chapter anyway."}}
{"actor":{"display_login":"jiegillet"}}