{"action":"created","comment":{"url":"https://api.github.com/repos/databrary/databrary/pulls/comments/200484889","pull_request_review_id":134812211,"id":200484889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQ4NDg4OQ==","diff_hunk":"@@ -462,6 +463,19 @@ test_15 = Test.stepsWithTransaction \"test_15\" $ \\step cn2 -> do\n           <> (BSLC.pack . Data.Maybe.maybe \"\" T.unpack . containerName . containerRow) cntr <> \",\"\n           <> \",\\n\")\n \n+test_15b :: TestTree\n+test_15b = Test.stepsWithTransaction \"test_15b\" $ \\step cn2 -> do\n+    step \"Given a created volume\"\n+    (aiAcct, aiCtxt) <- addAuthorizedInvestigatorWithInstitution' cn2\n+    -- TODO: should be lookup auth on rootParty\n+    v <- runReaderT (addVolumeWithAccess aiAcct) aiCtxt\n+    step \"When a link is added to the volume\"\n+    link <- Gen.sample genVolumeLink","path":"test/ModelTest.hs","position":19,"original_position":19,"commit_id":"5b6a85afc6aeffa821c192d26466ab0472bae3b9","original_commit_id":"5b6a85afc6aeffa821c192d26466ab0472bae3b9","user":{"login":"kanishka-azimi","id":1385802,"node_id":"MDQ6VXNlcjEzODU4MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1385802?v=4","gravatar_id":"","url":"https://api.github.com/users/kanishka-azimi","html_url":"https://github.com/kanishka-azimi","followers_url":"https://api.github.com/users/kanishka-azimi/followers","following_url":"https://api.github.com/users/kanishka-azimi/following{/other_user}","gists_url":"https://api.github.com/users/kanishka-azimi/gists{/gist_id}","starred_url":"https://api.github.com/users/kanishka-azimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanishka-azimi/subscriptions","organizations_url":"https://api.github.com/users/kanishka-azimi/orgs","repos_url":"https://api.github.com/users/kanishka-azimi/repos","events_url":"https://api.github.com/users/kanishka-azimi/events{/privacy}","received_events_url":"https://api.github.com/users/kanishka-azimi/received_events","type":"User","site_admin":false},"body":"might be more readable if the link and name are explicitly overridden here in the test and checked explicitly below.","created_at":"2018-07-05T20:46:05Z","updated_at":"2018-07-05T20:46:05Z","html_url":"https://github.com/databrary/databrary/pull/628#discussion_r200484889","pull_request_url":"https://api.github.com/repos/databrary/databrary/pulls/628","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/databrary/databrary/pulls/comments/200484889"},"html":{"href":"https://github.com/databrary/databrary/pull/628#discussion_r200484889"},"pull_request":{"href":"https://api.github.com/repos/databrary/databrary/pulls/628"}}},"pull_request":{"url":"https://api.github.com/repos/databrary/databrary/pulls/628","id":199582413,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTgyNDEz","html_url":"https://github.com/databrary/databrary/pull/628","diff_url":"https://github.com/databrary/databrary/pull/628.diff","patch_url":"https://github.com/databrary/databrary/pull/628.patch","issue_url":"https://api.github.com/repos/databrary/databrary/issues/628","number":628,"state":"open","locked":false,"title":"Test adding a link to a volume","user":{"login":"kanishka-azimi","id":1385802,"node_id":"MDQ6VXNlcjEzODU4MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1385802?v=4","gravatar_id":"","url":"https://api.github.com/users/kanishka-azimi","html_url":"https://github.com/kanishka-azimi","followers_url":"https://api.github.com/users/kanishka-azimi/followers","following_url":"https://api.github.com/users/kanishka-azimi/following{/other_user}","gists_url":"https://api.github.com/users/kanishka-azimi/gists{/gist_id}","starred_url":"https://api.github.com/users/kanishka-azimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanishka-azimi/subscriptions","organizations_url":"https://api.github.com/users/kanishka-azimi/orgs","repos_url":"https://api.github.com/users/kanishka-azimi/repos","events_url":"https://api.github.com/users/kanishka-azimi/events{/privacy}","received_events_url":"https://api.github.com/users/kanishka-azimi/received_events","type":"User","site_admin":false},"body":"- a link is added mostly for someone to read the link on the volume later\r\n- start the generator for a volume link\r\n- fix bug in URI scheme generation\r\n\r\n## Description\r\nA new test to cover a common usage of links.\r\n\r\n## Motivation and Context\r\nI'm building up towards replacing link query implementation. We also need general test coverage of this feature.\r\n\r\n## How Has This Been Tested?\r\nThat's the change\r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n- [x] I have run the unit tests.\r\n- [x] I am sick of writing content for this PR, let's get this over with.\r\n","created_at":"2018-07-05T20:43:33Z","updated_at":"2018-07-05T20:46:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61f91247236228dc080cf5d1361ae220489f61d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chreekat","id":538538,"node_id":"MDQ6VXNlcjUzODUzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/538538?v=4","gravatar_id":"","url":"https://api.github.com/users/chreekat","html_url":"https://github.com/chreekat","followers_url":"https://api.github.com/users/chreekat/followers","following_url":"https://api.github.com/users/chreekat/following{/other_user}","gists_url":"https://api.github.com/users/chreekat/gists{/gist_id}","starred_url":"https://api.github.com/users/chreekat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chreekat/subscriptions","organizations_url":"https://api.github.com/users/chreekat/orgs","repos_url":"https://api.github.com/users/chreekat/repos","events_url":"https://api.github.com/users/chreekat/events{/privacy}","received_events_url":"https://api.github.com/users/chreekat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/databrary/databrary/pulls/628/commits","review_comments_url":"https://api.github.com/repos/databrary/databrary/pulls/628/comments","review_comment_url":"https://api.github.com/repos/databrary/databrary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/databrary/databrary/issues/628/comments","statuses_url":"https://api.github.com/repos/databrary/databrary/statuses/5b6a85afc6aeffa821c192d26466ab0472bae3b9","head":{"label":"databrary:kanishka-expand-0705","ref":"kanishka-expand-0705","sha":"5b6a85afc6aeffa821c192d26466ab0472bae3b9","user":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"repo":{"id":9753621,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUzNjIx","name":"databrary","full_name":"databrary/databrary","owner":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/databrary/databrary","description":"behavioral science research media data sharing web application","fork":false,"url":"https://api.github.com/repos/databrary/databrary","forks_url":"https://api.github.com/repos/databrary/databrary/forks","keys_url":"https://api.github.com/repos/databrary/databrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databrary/databrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databrary/databrary/teams","hooks_url":"https://api.github.com/repos/databrary/databrary/hooks","issue_events_url":"https://api.github.com/repos/databrary/databrary/issues/events{/number}","events_url":"https://api.github.com/repos/databrary/databrary/events","assignees_url":"https://api.github.com/repos/databrary/databrary/assignees{/user}","branches_url":"https://api.github.com/repos/databrary/databrary/branches{/branch}","tags_url":"https://api.github.com/repos/databrary/databrary/tags","blobs_url":"https://api.github.com/repos/databrary/databrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databrary/databrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databrary/databrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/databrary/databrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databrary/databrary/statuses/{sha}","languages_url":"https://api.github.com/repos/databrary/databrary/languages","stargazers_url":"https://api.github.com/repos/databrary/databrary/stargazers","contributors_url":"https://api.github.com/repos/databrary/databrary/contributors","subscribers_url":"https://api.github.com/repos/databrary/databrary/subscribers","subscription_url":"https://api.github.com/repos/databrary/databrary/subscription","commits_url":"https://api.github.com/repos/databrary/databrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/databrary/databrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/databrary/databrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/databrary/databrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/databrary/databrary/contents/{+path}","compare_url":"https://api.github.com/repos/databrary/databrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databrary/databrary/merges","archive_url":"https://api.github.com/repos/databrary/databrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databrary/databrary/downloads","issues_url":"https://api.github.com/repos/databrary/databrary/issues{/number}","pulls_url":"https://api.github.com/repos/databrary/databrary/pulls{/number}","milestones_url":"https://api.github.com/repos/databrary/databrary/milestones{/number}","notifications_url":"https://api.github.com/repos/databrary/databrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databrary/databrary/labels{/name}","releases_url":"https://api.github.com/repos/databrary/databrary/releases{/id}","deployments_url":"https://api.github.com/repos/databrary/databrary/deployments","created_at":"2013-04-29T17:20:15Z","updated_at":"2018-07-05T19:57:34Z","pushed_at":"2018-07-05T20:43:34Z","git_url":"git://github.com/databrary/databrary.git","ssh_url":"git@github.com:databrary/databrary.git","clone_url":"https://github.com/databrary/databrary.git","svn_url":"https://github.com/databrary/databrary","homepage":"http://databrary.org","size":218379,"stargazers_count":40,"watchers_count":40,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":12,"open_issues":16,"watchers":40,"default_branch":"master"}},"base":{"label":"databrary:master","ref":"master","sha":"34a3bcc9cc647f8d2bb9584ec6c05d23caeab914","user":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"repo":{"id":9753621,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUzNjIx","name":"databrary","full_name":"databrary/databrary","owner":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/databrary/databrary","description":"behavioral science research media data sharing web application","fork":false,"url":"https://api.github.com/repos/databrary/databrary","forks_url":"https://api.github.com/repos/databrary/databrary/forks","keys_url":"https://api.github.com/repos/databrary/databrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databrary/databrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databrary/databrary/teams","hooks_url":"https://api.github.com/repos/databrary/databrary/hooks","issue_events_url":"https://api.github.com/repos/databrary/databrary/issues/events{/number}","events_url":"https://api.github.com/repos/databrary/databrary/events","assignees_url":"https://api.github.com/repos/databrary/databrary/assignees{/user}","branches_url":"https://api.github.com/repos/databrary/databrary/branches{/branch}","tags_url":"https://api.github.com/repos/databrary/databrary/tags","blobs_url":"https://api.github.com/repos/databrary/databrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databrary/databrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databrary/databrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/databrary/databrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databrary/databrary/statuses/{sha}","languages_url":"https://api.github.com/repos/databrary/databrary/languages","stargazers_url":"https://api.github.com/repos/databrary/databrary/stargazers","contributors_url":"https://api.github.com/repos/databrary/databrary/contributors","subscribers_url":"https://api.github.com/repos/databrary/databrary/subscribers","subscription_url":"https://api.github.com/repos/databrary/databrary/subscription","commits_url":"https://api.github.com/repos/databrary/databrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/databrary/databrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/databrary/databrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/databrary/databrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/databrary/databrary/contents/{+path}","compare_url":"https://api.github.com/repos/databrary/databrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databrary/databrary/merges","archive_url":"https://api.github.com/repos/databrary/databrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databrary/databrary/downloads","issues_url":"https://api.github.com/repos/databrary/databrary/issues{/number}","pulls_url":"https://api.github.com/repos/databrary/databrary/pulls{/number}","milestones_url":"https://api.github.com/repos/databrary/databrary/milestones{/number}","notifications_url":"https://api.github.com/repos/databrary/databrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databrary/databrary/labels{/name}","releases_url":"https://api.github.com/repos/databrary/databrary/releases{/id}","deployments_url":"https://api.github.com/repos/databrary/databrary/deployments","created_at":"2013-04-29T17:20:15Z","updated_at":"2018-07-05T19:57:34Z","pushed_at":"2018-07-05T20:43:34Z","git_url":"git://github.com/databrary/databrary.git","ssh_url":"git@github.com:databrary/databrary.git","clone_url":"https://github.com/databrary/databrary.git","svn_url":"https://github.com/databrary/databrary","homepage":"http://databrary.org","size":218379,"stargazers_count":40,"watchers_count":40,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":12,"open_issues":16,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/databrary/databrary/pulls/628"},"html":{"href":"https://github.com/databrary/databrary/pull/628"},"issue":{"href":"https://api.github.com/repos/databrary/databrary/issues/628"},"comments":{"href":"https://api.github.com/repos/databrary/databrary/issues/628/comments"},"review_comments":{"href":"https://api.github.com/repos/databrary/databrary/pulls/628/comments"},"review_comment":{"href":"https://api.github.com/repos/databrary/databrary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/databrary/databrary/pulls/628/commits"},"statuses":{"href":"https://api.github.com/repos/databrary/databrary/statuses/5b6a85afc6aeffa821c192d26466ab0472bae3b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kanishka-azimi"}}