{"action":"created","issue":{"url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1370","repository_url":"https://api.github.com/repos/CorsixTH/CorsixTH","labels_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1370/labels{/name}","comments_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1370/comments","events_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1370/events","html_url":"https://github.com/CorsixTH/CorsixTH/pull/1370","id":308781121,"number":1370,"title":"[WIP] Naming & Layout Part 1","user":{"login":"TheCycoONE","id":823433,"avatar_url":"https://avatars3.githubusercontent.com/u/823433?v=4","gravatar_id":"","url":"https://api.github.com/users/TheCycoONE","html_url":"https://github.com/TheCycoONE","followers_url":"https://api.github.com/users/TheCycoONE/followers","following_url":"https://api.github.com/users/TheCycoONE/following{/other_user}","gists_url":"https://api.github.com/users/TheCycoONE/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCycoONE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCycoONE/subscriptions","organizations_url":"https://api.github.com/users/TheCycoONE/orgs","repos_url":"https://api.github.com/users/TheCycoONE/repos","events_url":"https://api.github.com/users/TheCycoONE/events{/privacy}","received_events_url":"https://api.github.com/users/TheCycoONE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-27T00:32:42Z","updated_at":"2018-03-27T00:42:32Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/CorsixTH/CorsixTH/pulls/1370","html_url":"https://github.com/CorsixTH/CorsixTH/pull/1370","diff_url":"https://github.com/CorsixTH/CorsixTH/pull/1370.diff","patch_url":"https://github.com/CorsixTH/CorsixTH/pull/1370.patch"},"body":"This pull request updates CorsixTH to consistently use ISO standard naming conventions as part of the effort to conform to the C++ Core Guidelines.\r\n\r\nIn particular, type prefixes have been removed from all class variables as per: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#nl5-avoid-encoding-type-information-in-names\r\n\r\nISO Standard style class and function names are used throughout, which conforms to:\r\nhttps://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#nl8-use-a-consistent-naming-style\r\nhttps://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#nl10-avoid-camelcase\r\n\r\nConstants have also been changed to lower snake case conforming to:\r\nhttps://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#nl9-use-all_caps-for-macro-names-only\r\n\r\nFuture pull requests in this series are planned."},"comment":{"url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/comments/376357700","html_url":"https://github.com/CorsixTH/CorsixTH/pull/1370#issuecomment-376357700","issue_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1370","id":376357700,"user":{"login":"TheCycoONE","id":823433,"avatar_url":"https://avatars3.githubusercontent.com/u/823433?v=4","gravatar_id":"","url":"https://api.github.com/users/TheCycoONE","html_url":"https://github.com/TheCycoONE","followers_url":"https://api.github.com/users/TheCycoONE/followers","following_url":"https://api.github.com/users/TheCycoONE/following{/other_user}","gists_url":"https://api.github.com/users/TheCycoONE/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCycoONE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCycoONE/subscriptions","organizations_url":"https://api.github.com/users/TheCycoONE/orgs","repos_url":"https://api.github.com/users/TheCycoONE/repos","events_url":"https://api.github.com/users/TheCycoONE/events{/privacy}","received_events_url":"https://api.github.com/users/TheCycoONE/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T00:42:32Z","updated_at":"2018-03-27T00:42:32Z","author_association":"OWNER","body":"MSVC failure is from doxygen error that is likely a simple oversight. g++ error is more fundamental; it seems to dislike variables with the same names as classes even when the classes are explicitly namespaced (allowed in clang and msvc)"}}
{"actor":{"display_login":"TheCycoONE"}}