{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47252","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47252/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47252/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47252/events","html_url":"https://github.com/NixOS/nixpkgs/pull/47252","id":362978841,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTMyMTg1","number":47252,"title":"nixos/network-interfaces-scripted: fix a container networking bug","user":{"login":"xeji","id":36407913,"node_id":"MDQ6VXNlcjM2NDA3OTEz","avatar_url":"https://avatars2.githubusercontent.com/u/36407913?v=4","gravatar_id":"","url":"https://api.github.com/users/xeji","html_url":"https://github.com/xeji","followers_url":"https://api.github.com/users/xeji/followers","following_url":"https://api.github.com/users/xeji/following{/other_user}","gists_url":"https://api.github.com/users/xeji/gists{/gist_id}","starred_url":"https://api.github.com/users/xeji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeji/subscriptions","organizations_url":"https://api.github.com/users/xeji/orgs","repos_url":"https://api.github.com/users/xeji/repos","events_url":"https://api.github.com/users/xeji/events{/privacy}","received_events_url":"https://api.github.com/users/xeji/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-23T21:25:37Z","updated_at":"2018-09-23T21:52:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47252","html_url":"https://github.com/NixOS/nixpkgs/pull/47252","diff_url":"https://github.com/NixOS/nixpkgs/pull/47252.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/47252.patch"},"body":"###### Motivation for this change\r\n\r\nFixes #47210:  When a bridge interface was reconfigured, running containers using this bridge lost connectivity: restarting `network-addresses-brN.service` triggered a restart of `network-setup.service` via a `partOf` relationship introduced in 07e0c0e0a2f237639600f2a0d62f6eac748b1e6e. This in turn restarted `brN-netdev.service`.\r\n\r\nThe bridge was thus destroyed and recreated with the same name but a new interface id, causing attached `veth` interfaces to lose their connection.\r\n\r\nThis change removes the `partOf` relationship between `network-setup.service` and `network-addresses-brN.service` for all bridges so they can be reconfigured without being destroyed and recreated.\r\n\r\nI don't see any negative side effects atm, but would kindly ask the the authors of of 07e0c0e0a2f237639600f2a0d62f6eac748b1e6e (which introduced the bug while fixing https://github.com/NixOS/nixops/issues/640) to have a look:  cc @nh2, @domenkozar, @fpletz, @aszlig, @basvandijk\r\n\r\nThere's also an (uglier) alternative solution without changing the `partOf` relationships: modify the start/stop scripts to skip deleting and recreating a bridge while there's still a veth interface attached.\r\n\r\n###### Things done\r\n\r\nNixOS tests:\r\n- [x] `containers-restart_networking` now passes (which failed before due to the bug)\r\n- [x] all other container tests still pass\r\n- [x] all networking tests still pass\r\n\r\n---\r\n\r\ncc @srhb \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/423850749","html_url":"https://github.com/NixOS/nixpkgs/pull/47252#issuecomment-423850749","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47252","id":423850749,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzg1MDc0OQ==","user":{"login":"nh2","id":399535,"node_id":"MDQ6VXNlcjM5OTUzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/399535?v=4","gravatar_id":"","url":"https://api.github.com/users/nh2","html_url":"https://github.com/nh2","followers_url":"https://api.github.com/users/nh2/followers","following_url":"https://api.github.com/users/nh2/following{/other_user}","gists_url":"https://api.github.com/users/nh2/gists{/gist_id}","starred_url":"https://api.github.com/users/nh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nh2/subscriptions","organizations_url":"https://api.github.com/users/nh2/orgs","repos_url":"https://api.github.com/users/nh2/repos","events_url":"https://api.github.com/users/nh2/events{/privacy}","received_events_url":"https://api.github.com/users/nh2/received_events","type":"User","site_admin":false},"created_at":"2018-09-23T21:52:35Z","updated_at":"2018-09-23T21:52:35Z","author_association":"CONTRIBUTOR","body":"Perhaps we'll figure it out for good at NixCon? That'd be awesome."}}
{"actor":{"display_login":"nh2"}}