{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/217660323","pull_request_review_id":155426349,"id":217660323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzY2MDMyMw==","diff_hunk":"@@ -52,7 +49,6 @@\n \n <ng-template #deletionHeading>\n   <ng-container i18n>\n-    Delete\n+    {{ actionDescription | titlecase }} {{ itemDescription | titlecase }}","path":"src/pybind/mgr/dashboard/frontend/src/app/shared/components/deletion-modal/deletion-modal.component.html","position":40,"original_position":40,"commit_id":"f6dd8aded552b87555f189573f3e9d201813c874","original_commit_id":"f6dd8aded552b87555f189573f3e9d201813c874","user":{"login":"votdev","id":1897962,"node_id":"MDQ6VXNlcjE4OTc5NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1897962?v=4","gravatar_id":"","url":"https://api.github.com/users/votdev","html_url":"https://github.com/votdev","followers_url":"https://api.github.com/users/votdev/followers","following_url":"https://api.github.com/users/votdev/following{/other_user}","gists_url":"https://api.github.com/users/votdev/gists{/gist_id}","starred_url":"https://api.github.com/users/votdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votdev/subscriptions","organizations_url":"https://api.github.com/users/votdev/orgs","repos_url":"https://api.github.com/users/votdev/repos","events_url":"https://api.github.com/users/votdev/events{/privacy}","received_events_url":"https://api.github.com/users/votdev/received_events","type":"User","site_admin":false},"body":"Don't use the [titlecase pipe](https://angular.io/api/common/TitleCasePipe) for ``itemDescription``, otherwise ``RBD snapshot`` will be transformed to ``Rbd Snapshot``.\r\n","created_at":"2018-09-14T09:50:14Z","updated_at":"2018-09-14T09:52:43Z","html_url":"https://github.com/ceph/ceph/pull/24005#discussion_r217660323","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/24005","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/217660323"},"html":{"href":"https://github.com/ceph/ceph/pull/24005#discussion_r217660323"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24005"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24005","id":214261928,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MjYxOTI4","html_url":"https://github.com/ceph/ceph/pull/24005","diff_url":"https://github.com/ceph/ceph/pull/24005.diff","patch_url":"https://github.com/ceph/ceph/pull/24005.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24005","number":24005,"state":"open","locked":false,"title":"mgr/dashboard: Refactoring of `DeletionModalComponent`","user":{"login":"p-na","id":9606095,"node_id":"MDQ6VXNlcjk2MDYwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9606095?v=4","gravatar_id":"","url":"https://api.github.com/users/p-na","html_url":"https://github.com/p-na","followers_url":"https://api.github.com/users/p-na/followers","following_url":"https://api.github.com/users/p-na/following{/other_user}","gists_url":"https://api.github.com/users/p-na/gists{/gist_id}","starred_url":"https://api.github.com/users/p-na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-na/subscriptions","organizations_url":"https://api.github.com/users/p-na/orgs","repos_url":"https://api.github.com/users/p-na/repos","events_url":"https://api.github.com/users/p-na/events{/privacy}","received_events_url":"https://api.github.com/users/p-na/received_events","type":"User","site_admin":false},"body":"- Simpler variable names:\r\n\r\n    Examples:\r\n\r\n\t- `actionDescription` instead of `metaType`\r\n\t- `bodyTemplate` instead of `description`\r\n\t- `validationPattern` instead of `pattern`\r\n\r\n    Some of these variable names have been generalized to ease the\r\n    unification/generalization of dialog components:\r\n\r\n\t- `submitAction` instead of `deletionMethod`\r\n\r\n- Removed unique `setUp` method.\r\n\r\n    Benefits:\r\n\r\n    - Creation of the component is done as intended by the developers of\r\n    the `ngx-boostrap` package and as expected by developers which use\r\n    the package. The `setUp` method does not have to be called anymore\r\n    on the `DeletionModalComponent` exclusively but instead the\r\n    component is instantiated as all other modals. Property assignment\r\n    on the instantiated object isn't handled by the `setUp` method\r\n    anymore but by the `modalService`.\r\n\r\n    - With the removal of the `setUp` method, some tests could be\r\n    removed as well.\r\n\r\n    - No need to pass the reference of the created modal to the modal\r\n    manually.\r\n\r\n    Preserved:\r\n\r\n    - The provided check within the `setUp` method, which checked if the\r\n    component had been correctly instantiated, has been moved to the\r\n    `ngOnInit` method of the component.\r\n\r\nSigned-off-by: Patrick Nawracay <pnawracay@suse.com>\r\n\r\n","created_at":"2018-09-10T10:08:19Z","updated_at":"2018-09-14T09:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9aeb61fb945c917c84d35adabb3076e547f1a86","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tspmelo","id":399326,"node_id":"MDQ6VXNlcjM5OTMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},{"login":"ricardoasmarques","id":14297426,"node_id":"MDQ6VXNlcjE0Mjk3NDI2","avatar_url":"https://avatars2.githubusercontent.com/u/14297426?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardoasmarques","html_url":"https://github.com/ricardoasmarques","followers_url":"https://api.github.com/users/ricardoasmarques/followers","following_url":"https://api.github.com/users/ricardoasmarques/following{/other_user}","gists_url":"https://api.github.com/users/ricardoasmarques/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardoasmarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardoasmarques/subscriptions","organizations_url":"https://api.github.com/users/ricardoasmarques/orgs","repos_url":"https://api.github.com/users/ricardoasmarques/repos","events_url":"https://api.github.com/users/ricardoasmarques/events{/privacy}","received_events_url":"https://api.github.com/users/ricardoasmarques/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":140959062,"node_id":"MDU6TGFiZWwxNDA5NTkwNjI=","url":"https://api.github.com/repos/ceph/ceph/labels/cleanup","name":"cleanup","color":"009800","default":false},{"id":850326757,"node_id":"MDU6TGFiZWw4NTAzMjY3NTc=","url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false},{"id":340048817,"node_id":"MDU6TGFiZWwzNDAwNDg4MTc=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/24005/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/24005/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24005/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/f6dd8aded552b87555f189573f3e9d201813c874","head":{"label":"p-na:refactor-deletion-modal-component","ref":"refactor-deletion-modal-component","sha":"f6dd8aded552b87555f189573f3e9d201813c874","user":{"login":"p-na","id":9606095,"node_id":"MDQ6VXNlcjk2MDYwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9606095?v=4","gravatar_id":"","url":"https://api.github.com/users/p-na","html_url":"https://github.com/p-na","followers_url":"https://api.github.com/users/p-na/followers","following_url":"https://api.github.com/users/p-na/following{/other_user}","gists_url":"https://api.github.com/users/p-na/gists{/gist_id}","starred_url":"https://api.github.com/users/p-na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-na/subscriptions","organizations_url":"https://api.github.com/users/p-na/orgs","repos_url":"https://api.github.com/users/p-na/repos","events_url":"https://api.github.com/users/p-na/events{/privacy}","received_events_url":"https://api.github.com/users/p-na/received_events","type":"User","site_admin":false},"repo":{"id":117105163,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMDUxNjM=","name":"ceph","full_name":"p-na/ceph","owner":{"login":"p-na","id":9606095,"node_id":"MDQ6VXNlcjk2MDYwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9606095?v=4","gravatar_id":"","url":"https://api.github.com/users/p-na","html_url":"https://github.com/p-na","followers_url":"https://api.github.com/users/p-na/followers","following_url":"https://api.github.com/users/p-na/following{/other_user}","gists_url":"https://api.github.com/users/p-na/gists{/gist_id}","starred_url":"https://api.github.com/users/p-na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-na/subscriptions","organizations_url":"https://api.github.com/users/p-na/orgs","repos_url":"https://api.github.com/users/p-na/repos","events_url":"https://api.github.com/users/p-na/events{/privacy}","received_events_url":"https://api.github.com/users/p-na/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/p-na/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/p-na/ceph","forks_url":"https://api.github.com/repos/p-na/ceph/forks","keys_url":"https://api.github.com/repos/p-na/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p-na/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p-na/ceph/teams","hooks_url":"https://api.github.com/repos/p-na/ceph/hooks","issue_events_url":"https://api.github.com/repos/p-na/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/p-na/ceph/events","assignees_url":"https://api.github.com/repos/p-na/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/p-na/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/p-na/ceph/tags","blobs_url":"https://api.github.com/repos/p-na/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p-na/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p-na/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/p-na/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p-na/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/p-na/ceph/languages","stargazers_url":"https://api.github.com/repos/p-na/ceph/stargazers","contributors_url":"https://api.github.com/repos/p-na/ceph/contributors","subscribers_url":"https://api.github.com/repos/p-na/ceph/subscribers","subscription_url":"https://api.github.com/repos/p-na/ceph/subscription","commits_url":"https://api.github.com/repos/p-na/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/p-na/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/p-na/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/p-na/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/p-na/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/p-na/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p-na/ceph/merges","archive_url":"https://api.github.com/repos/p-na/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p-na/ceph/downloads","issues_url":"https://api.github.com/repos/p-na/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/p-na/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/p-na/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/p-na/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p-na/ceph/labels{/name}","releases_url":"https://api.github.com/repos/p-na/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/p-na/ceph/deployments","created_at":"2018-01-11T13:38:30Z","updated_at":"2018-01-11T13:38:52Z","pushed_at":"2018-09-12T12:56:41Z","git_url":"git://github.com/p-na/ceph.git","ssh_url":"git@github.com:p-na/ceph.git","clone_url":"https://github.com/p-na/ceph.git","svn_url":"https://github.com/p-na/ceph","homepage":"http://ceph.com","size":300123,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"f9d57a0b55c436d871a0e7667dd573a596c81af3","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-09-14T07:54:44Z","pushed_at":"2018-09-14T09:23:55Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":309236,"stargazers_count":5054,"watchers_count":5054,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2626,"mirror_url":null,"archived":false,"open_issues_count":752,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2626,"open_issues":752,"watchers":5054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24005"},"html":{"href":"https://github.com/ceph/ceph/pull/24005"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/24005"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/24005/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24005/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24005/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/f6dd8aded552b87555f189573f3e9d201813c874"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"votdev"}}