{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/166472485","pull_request_review_id":94540310,"id":166472485,"diff_hunk":"@@ -265,11 +259,8 @@ Result CommitTransaction(CWallet* wallet, const uint256& txid, CMutableTransacti\n     wtxBumped.fTimeReceivedIsTxTime = true;\n     wtxBumped.fFromMe = true;\n     CValidationState state;\n-    if (!wallet->CommitTransaction(wtxBumped, reservekey, g_connman.get(), state)) {\n-        // NOTE: CommitTransaction never returns false, so this should never happen.\n-        errors.push_back(strprintf(\"The transaction was rejected: %s\", state.GetRejectReason()));\n-        return Result::WALLET_ERROR;\n-    }\n+    // NOTE: CommitTransaction never returns false.\n+    assert(wallet->CommitTransaction(wtxBumped, reservekey, g_connman.get(), state));","path":"src/wallet/feebumper.cpp","position":36,"original_position":36,"commit_id":"2d58539a1fa7a47b43b3284840c38b09b682a313","original_commit_id":"2d58539a1fa7a47b43b3284840c38b09b682a313","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"Could make sense to move it out of the assertion, such that the code continues to run if assertions are not compiled.","created_at":"2018-02-06T23:09:42Z","updated_at":"2018-02-06T23:09:42Z","html_url":"https://github.com/bitcoin/bitcoin/pull/12361#discussion_r166472485","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/166472485"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12361#discussion_r166472485"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361","id":167271687,"html_url":"https://github.com/bitcoin/bitcoin/pull/12361","diff_url":"https://github.com/bitcoin/bitcoin/pull/12361.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/12361.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12361","number":12361,"state":"open","locked":false,"title":"Replace unreachable error handling with assertions in feebumper","user":{"login":"promag","id":3534524,"avatar_url":"https://avatars1.githubusercontent.com/u/3534524?v=4","gravatar_id":"","url":"https://api.github.com/users/promag","html_url":"https://github.com/promag","followers_url":"https://api.github.com/users/promag/followers","following_url":"https://api.github.com/users/promag/following{/other_user}","gists_url":"https://api.github.com/users/promag/gists{/gist_id}","starred_url":"https://api.github.com/users/promag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promag/subscriptions","organizations_url":"https://api.github.com/users/promag/orgs","repos_url":"https://api.github.com/users/promag/repos","events_url":"https://api.github.com/users/promag/events{/privacy}","received_events_url":"https://api.github.com/users/promag/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-05T22:27:31Z","updated_at":"2018-02-06T23:09:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1fcc4e6ffb2dff1887dae8cecc492b2df6a4724","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12361/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2d58539a1fa7a47b43b3284840c38b09b682a313","head":{"label":"promag:2018-02-feebumper","ref":"2018-02-feebumper","sha":"2d58539a1fa7a47b43b3284840c38b09b682a313","user":{"login":"promag","id":3534524,"avatar_url":"https://avatars1.githubusercontent.com/u/3534524?v=4","gravatar_id":"","url":"https://api.github.com/users/promag","html_url":"https://github.com/promag","followers_url":"https://api.github.com/users/promag/followers","following_url":"https://api.github.com/users/promag/following{/other_user}","gists_url":"https://api.github.com/users/promag/gists{/gist_id}","starred_url":"https://api.github.com/users/promag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promag/subscriptions","organizations_url":"https://api.github.com/users/promag/orgs","repos_url":"https://api.github.com/users/promag/repos","events_url":"https://api.github.com/users/promag/events{/privacy}","received_events_url":"https://api.github.com/users/promag/received_events","type":"User","site_admin":false},"repo":{"id":95606613,"name":"bitcoin","full_name":"promag/bitcoin","owner":{"login":"promag","id":3534524,"avatar_url":"https://avatars1.githubusercontent.com/u/3534524?v=4","gravatar_id":"","url":"https://api.github.com/users/promag","html_url":"https://github.com/promag","followers_url":"https://api.github.com/users/promag/followers","following_url":"https://api.github.com/users/promag/following{/other_user}","gists_url":"https://api.github.com/users/promag/gists{/gist_id}","starred_url":"https://api.github.com/users/promag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promag/subscriptions","organizations_url":"https://api.github.com/users/promag/orgs","repos_url":"https://api.github.com/users/promag/repos","events_url":"https://api.github.com/users/promag/events{/privacy}","received_events_url":"https://api.github.com/users/promag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/promag/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/promag/bitcoin","forks_url":"https://api.github.com/repos/promag/bitcoin/forks","keys_url":"https://api.github.com/repos/promag/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/promag/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/promag/bitcoin/teams","hooks_url":"https://api.github.com/repos/promag/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/promag/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/promag/bitcoin/events","assignees_url":"https://api.github.com/repos/promag/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/promag/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/promag/bitcoin/tags","blobs_url":"https://api.github.com/repos/promag/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/promag/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/promag/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/promag/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/promag/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/promag/bitcoin/languages","stargazers_url":"https://api.github.com/repos/promag/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/promag/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/promag/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/promag/bitcoin/subscription","commits_url":"https://api.github.com/repos/promag/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/promag/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/promag/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/promag/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/promag/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/promag/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/promag/bitcoin/merges","archive_url":"https://api.github.com/repos/promag/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/promag/bitcoin/downloads","issues_url":"https://api.github.com/repos/promag/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/promag/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/promag/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/promag/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/promag/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/promag/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/promag/bitcoin/deployments","created_at":"2017-06-27T22:37:11Z","updated_at":"2017-06-27T22:37:29Z","pushed_at":"2018-02-06T22:55:04Z","git_url":"git://github.com/promag/bitcoin.git","ssh_url":"git@github.com:promag/bitcoin.git","clone_url":"https://github.com/promag/bitcoin.git","svn_url":"https://github.com/promag/bitcoin","homepage":"https://bitcoin.org/en/download","size":96216,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"1462bde767a121233118c04c5629bd9de1ba0f16","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-02-06T22:55:38Z","pushed_at":"2018-02-06T23:03:46Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":97130,"stargazers_count":27217,"watchers_count":27217,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":16069,"mirror_url":null,"archived":false,"open_issues_count":870,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":16069,"open_issues":870,"watchers":27217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12361"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12361"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12361/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12361/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2d58539a1fa7a47b43b3284840c38b09b682a313"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MarcoFalke"}}