{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/172872763","pull_request_review_id":101964387,"id":172872763,"diff_hunk":"@@ -55,7 +55,7 @@ export default class Settings extends EventEmitter {\n \n     // Defaults for a Jest project\n     this.settings = {\n-      testMatch: ['**/__tests__/**/*.js?(x)', '**/?(*.)(spec|test).js?(x)'],\n+      testMatch: ['**/__tests__/**/*.js?(x)', '**/?(*.)+(spec|test).js?(x)'],\n       testRegex: '(/__tests__/.*|\\\\.(test|spec))\\\\.jsx?$',","path":"packages/jest-editor-support/src/Settings.js","position":6,"original_position":6,"commit_id":"22716babf5e4964787a2e62e05d943e6442fd651","original_commit_id":"002f751f1a3f4aaf16069f06413874ea03d981ff","user":{"login":"orta","id":49038,"avatar_url":"https://avatars2.githubusercontent.com/u/49038?v=4","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"body":"These are used to determine if we should show dots on a page etc, not passed forwards to Jest - so it won't conflict","created_at":"2018-03-07T15:11:21Z","updated_at":"2018-03-07T15:11:21Z","html_url":"https://github.com/facebook/jest/pull/5744#discussion_r172872763","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/5744","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/172872763"},"html":{"href":"https://github.com/facebook/jest/pull/5744#discussion_r172872763"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/5744"}},"in_reply_to_id":172835209},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/5744","id":173445549,"html_url":"https://github.com/facebook/jest/pull/5744","diff_url":"https://github.com/facebook/jest/pull/5744.diff","patch_url":"https://github.com/facebook/jest/pull/5744.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/5744","number":5744,"state":"open","locked":false,"title":"Use valid glob pattern instead of micromatch-specific","user":{"login":"thymikee","id":5106466,"avatar_url":"https://avatars2.githubusercontent.com/u/5106466?v=4","gravatar_id":"","url":"https://api.github.com/users/thymikee","html_url":"https://github.com/thymikee","followers_url":"https://api.github.com/users/thymikee/followers","following_url":"https://api.github.com/users/thymikee/following{/other_user}","gists_url":"https://api.github.com/users/thymikee/gists{/gist_id}","starred_url":"https://api.github.com/users/thymikee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thymikee/subscriptions","organizations_url":"https://api.github.com/users/thymikee/orgs","repos_url":"https://api.github.com/users/thymikee/repos","events_url":"https://api.github.com/users/thymikee/events{/privacy}","received_events_url":"https://api.github.com/users/thymikee/received_events","type":"User","site_admin":false},"body":"\r\n\r\n## Summary\r\n\r\nI just noticed we use non-idiomatic glob pattern as a default `testMatch`. It works only because of `micromatch` (glob lib we use) special feature called [_regex logical \"or\"_](https://github.com/micromatch/micromatch#matching-features). \r\nI think we shouldn't spread invalid glob patterns, so instead of `something.(foo|bar)` we should go with `something.+(foo|bar)` for example.\r\n\r\n## Test plan\r\n\r\nTests should pass","created_at":"2018-03-07T13:03:42Z","updated_at":"2018-03-07T15:11:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bd6a58286f90bce4ef8a823b706144745ff7b37","assignee":null,"assignees":[],"requested_reviewers":[{"login":"orta","id":49038,"avatar_url":"https://avatars2.githubusercontent.com/u/49038?v=4","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":847426897,"url":"https://api.github.com/repos/facebook/jest/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/5744/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/5744/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/5744/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/22716babf5e4964787a2e62e05d943e6442fd651","head":{"label":"thymikee:fix/testmatch","ref":"fix/testmatch","sha":"22716babf5e4964787a2e62e05d943e6442fd651","user":{"login":"thymikee","id":5106466,"avatar_url":"https://avatars2.githubusercontent.com/u/5106466?v=4","gravatar_id":"","url":"https://api.github.com/users/thymikee","html_url":"https://github.com/thymikee","followers_url":"https://api.github.com/users/thymikee/followers","following_url":"https://api.github.com/users/thymikee/following{/other_user}","gists_url":"https://api.github.com/users/thymikee/gists{/gist_id}","starred_url":"https://api.github.com/users/thymikee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thymikee/subscriptions","organizations_url":"https://api.github.com/users/thymikee/orgs","repos_url":"https://api.github.com/users/thymikee/repos","events_url":"https://api.github.com/users/thymikee/events{/privacy}","received_events_url":"https://api.github.com/users/thymikee/received_events","type":"User","site_admin":false},"repo":{"id":68306172,"name":"jest","full_name":"thymikee/jest","owner":{"login":"thymikee","id":5106466,"avatar_url":"https://avatars2.githubusercontent.com/u/5106466?v=4","gravatar_id":"","url":"https://api.github.com/users/thymikee","html_url":"https://github.com/thymikee","followers_url":"https://api.github.com/users/thymikee/followers","following_url":"https://api.github.com/users/thymikee/following{/other_user}","gists_url":"https://api.github.com/users/thymikee/gists{/gist_id}","starred_url":"https://api.github.com/users/thymikee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thymikee/subscriptions","organizations_url":"https://api.github.com/users/thymikee/orgs","repos_url":"https://api.github.com/users/thymikee/repos","events_url":"https://api.github.com/users/thymikee/events{/privacy}","received_events_url":"https://api.github.com/users/thymikee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thymikee/jest","description":"Painless JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/thymikee/jest","forks_url":"https://api.github.com/repos/thymikee/jest/forks","keys_url":"https://api.github.com/repos/thymikee/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thymikee/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thymikee/jest/teams","hooks_url":"https://api.github.com/repos/thymikee/jest/hooks","issue_events_url":"https://api.github.com/repos/thymikee/jest/issues/events{/number}","events_url":"https://api.github.com/repos/thymikee/jest/events","assignees_url":"https://api.github.com/repos/thymikee/jest/assignees{/user}","branches_url":"https://api.github.com/repos/thymikee/jest/branches{/branch}","tags_url":"https://api.github.com/repos/thymikee/jest/tags","blobs_url":"https://api.github.com/repos/thymikee/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thymikee/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thymikee/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/thymikee/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thymikee/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/thymikee/jest/languages","stargazers_url":"https://api.github.com/repos/thymikee/jest/stargazers","contributors_url":"https://api.github.com/repos/thymikee/jest/contributors","subscribers_url":"https://api.github.com/repos/thymikee/jest/subscribers","subscription_url":"https://api.github.com/repos/thymikee/jest/subscription","commits_url":"https://api.github.com/repos/thymikee/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/thymikee/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/thymikee/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/thymikee/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/thymikee/jest/contents/{+path}","compare_url":"https://api.github.com/repos/thymikee/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thymikee/jest/merges","archive_url":"https://api.github.com/repos/thymikee/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thymikee/jest/downloads","issues_url":"https://api.github.com/repos/thymikee/jest/issues{/number}","pulls_url":"https://api.github.com/repos/thymikee/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/thymikee/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/thymikee/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thymikee/jest/labels{/name}","releases_url":"https://api.github.com/repos/thymikee/jest/releases{/id}","deployments_url":"https://api.github.com/repos/thymikee/jest/deployments","created_at":"2016-09-15T15:25:55Z","updated_at":"2016-09-15T15:25:58Z","pushed_at":"2018-03-07T15:04:51Z","git_url":"git://github.com/thymikee/jest.git","ssh_url":"git@github.com:thymikee/jest.git","clone_url":"https://github.com/thymikee/jest.git","svn_url":"https://github.com/thymikee/jest","homepage":"http://facebook.github.io/jest/","size":25288,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f1c422f58ab05010ccbfd42902248946e5924860","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"name":"jest","full_name":"facebook/jest","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2018-03-07T14:06:01Z","pushed_at":"2018-03-07T15:04:55Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"https://facebook.github.io/jest/","size":39145,"stargazers_count":16123,"watchers_count":16123,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2087,"mirror_url":null,"archived":false,"open_issues_count":252,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2087,"open_issues":252,"watchers":16123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/5744"},"html":{"href":"https://github.com/facebook/jest/pull/5744"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/5744"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/5744/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/5744/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/5744/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/22716babf5e4964787a2e62e05d943e6442fd651"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"orta"}}