{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/dispatch/pulls/comments/199014021","pull_request_review_id":133053130,"id":199014021,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTAxNDAyMQ==","diff_hunk":"@@ -0,0 +1,96 @@\n+///////////////////////////////////////////////////////////////////////\n+// Copyright (c) 2017 VMware, Inc. All Rights Reserved.\n+// SPDX-License-Identifier: Apache-2.0\n+///////////////////////////////////////////////////////////////////////\n+\n+package v1\n+\n+import (\n+\tstrfmt \"github.com/go-openapi/strfmt\"\n+\n+\t\"github.com/go-openapi/errors\"\n+\t\"github.com/go-openapi/swag\"\n+\t\"github.com/go-openapi/validate\"\n+)\n+\n+// NO TESTS\n+\n+// Source source\n+// swagger:model Source\n+type Source struct {\n+\n+\t// code\n+\tCode strfmt.Base64 `json:\"code,omitempty\"`\n+\n+\t// the name of the function associated with\n+\t// Required: true","path":"pkg/api/v1/source.go","position":26,"original_position":26,"commit_id":"3db9a6134f2051d0e284346519119a85e8cbfdc5","original_commit_id":"3db9a6134f2051d0e284346519119a85e8cbfdc5","user":{"login":"rjew","id":10606568,"node_id":"MDQ6VXNlcjEwNjA2NTY4","avatar_url":"https://avatars0.githubusercontent.com/u/10606568?v=4","gravatar_id":"","url":"https://api.github.com/users/rjew","html_url":"https://github.com/rjew","followers_url":"https://api.github.com/users/rjew/followers","following_url":"https://api.github.com/users/rjew/following{/other_user}","gists_url":"https://api.github.com/users/rjew/gists{/gist_id}","starred_url":"https://api.github.com/users/rjew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjew/subscriptions","organizations_url":"https://api.github.com/users/rjew/orgs","repos_url":"https://api.github.com/users/rjew/repos","events_url":"https://api.github.com/users/rjew/events{/privacy}","received_events_url":"https://api.github.com/users/rjew/received_events","type":"User","site_admin":false},"body":"Yeah good point it does seem a bit redundant. Probably don't need them in the API model and just have the `Name` field in the entity be an ID like you and @kars7e mentioned.","created_at":"2018-06-28T23:11:23Z","updated_at":"2018-06-28T23:11:23Z","html_url":"https://github.com/vmware/dispatch/pull/548#discussion_r199014021","pull_request_url":"https://api.github.com/repos/vmware/dispatch/pulls/548","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/comments/199014021"},"html":{"href":"https://github.com/vmware/dispatch/pull/548#discussion_r199014021"},"pull_request":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/548"}},"in_reply_to_id":199001026},"pull_request":{"url":"https://api.github.com/repos/vmware/dispatch/pulls/548","id":197798432,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Nzk4NDMy","html_url":"https://github.com/vmware/dispatch/pull/548","diff_url":"https://github.com/vmware/dispatch/pull/548.diff","patch_url":"https://github.com/vmware/dispatch/pull/548.patch","issue_url":"https://api.github.com/repos/vmware/dispatch/issues/548","number":548,"state":"open","locked":false,"title":"Move source out of function entity and into its own entity store","user":{"login":"rjew","id":10606568,"node_id":"MDQ6VXNlcjEwNjA2NTY4","avatar_url":"https://avatars0.githubusercontent.com/u/10606568?v=4","gravatar_id":"","url":"https://api.github.com/users/rjew","html_url":"https://github.com/rjew","followers_url":"https://api.github.com/users/rjew/followers","following_url":"https://api.github.com/users/rjew/following{/other_user}","gists_url":"https://api.github.com/users/rjew/gists{/gist_id}","starred_url":"https://api.github.com/users/rjew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjew/subscriptions","organizations_url":"https://api.github.com/users/rjew/orgs","repos_url":"https://api.github.com/users/rjew/repos","events_url":"https://api.github.com/users/rjew/events{/privacy}","received_events_url":"https://api.github.com/users/rjew/received_events","type":"User","site_admin":false},"body":"* `Source` is now its own entity in the store, where `Function` now references the source by its entity name\r\n* Add `sourceEntityHandler` in controller to handle source entities that need to be resolved such as when a source is added but its corresponding function fails to be added\r\n* Add `Source` api model","created_at":"2018-06-27T17:14:19Z","updated_at":"2018-06-28T23:11:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d47360914599f3a60d11ffa17a1daaee52350dde","assignee":null,"assignees":[],"requested_reviewers":[{"login":"berndtj","id":78191,"node_id":"MDQ6VXNlcjc4MTkx","avatar_url":"https://avatars2.githubusercontent.com/u/78191?v=4","gravatar_id":"","url":"https://api.github.com/users/berndtj","html_url":"https://github.com/berndtj","followers_url":"https://api.github.com/users/berndtj/followers","following_url":"https://api.github.com/users/berndtj/following{/other_user}","gists_url":"https://api.github.com/users/berndtj/gists{/gist_id}","starred_url":"https://api.github.com/users/berndtj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndtj/subscriptions","organizations_url":"https://api.github.com/users/berndtj/orgs","repos_url":"https://api.github.com/users/berndtj/repos","events_url":"https://api.github.com/users/berndtj/events{/privacy}","received_events_url":"https://api.github.com/users/berndtj/received_events","type":"User","site_admin":false},{"login":"kars7e","id":1920092,"node_id":"MDQ6VXNlcjE5MjAwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1920092?v=4","gravatar_id":"","url":"https://api.github.com/users/kars7e","html_url":"https://github.com/kars7e","followers_url":"https://api.github.com/users/kars7e/followers","following_url":"https://api.github.com/users/kars7e/following{/other_user}","gists_url":"https://api.github.com/users/kars7e/gists{/gist_id}","starred_url":"https://api.github.com/users/kars7e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kars7e/subscriptions","organizations_url":"https://api.github.com/users/kars7e/orgs","repos_url":"https://api.github.com/users/kars7e/repos","events_url":"https://api.github.com/users/kars7e/events{/privacy}","received_events_url":"https://api.github.com/users/kars7e/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":776104285,"node_id":"MDU6TGFiZWw3NzYxMDQyODU=","url":"https://api.github.com/repos/vmware/dispatch/labels/cla-not-required","name":"cla-not-required","color":"159818","default":false},{"id":784322750,"node_id":"MDU6TGFiZWw3ODQzMjI3NTA=","url":"https://api.github.com/repos/vmware/dispatch/labels/run-e2e","name":"run-e2e","color":"1cbc67","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/dispatch/pulls/548/commits","review_comments_url":"https://api.github.com/repos/vmware/dispatch/pulls/548/comments","review_comment_url":"https://api.github.com/repos/vmware/dispatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/dispatch/issues/548/comments","statuses_url":"https://api.github.com/repos/vmware/dispatch/statuses/3db9a6134f2051d0e284346519119a85e8cbfdc5","head":{"label":"rjew:source-entity-store","ref":"source-entity-store","sha":"3db9a6134f2051d0e284346519119a85e8cbfdc5","user":{"login":"rjew","id":10606568,"node_id":"MDQ6VXNlcjEwNjA2NTY4","avatar_url":"https://avatars0.githubusercontent.com/u/10606568?v=4","gravatar_id":"","url":"https://api.github.com/users/rjew","html_url":"https://github.com/rjew","followers_url":"https://api.github.com/users/rjew/followers","following_url":"https://api.github.com/users/rjew/following{/other_user}","gists_url":"https://api.github.com/users/rjew/gists{/gist_id}","starred_url":"https://api.github.com/users/rjew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjew/subscriptions","organizations_url":"https://api.github.com/users/rjew/orgs","repos_url":"https://api.github.com/users/rjew/repos","events_url":"https://api.github.com/users/rjew/events{/privacy}","received_events_url":"https://api.github.com/users/rjew/received_events","type":"User","site_admin":false},"repo":{"id":124154369,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxNTQzNjk=","name":"dispatch","full_name":"rjew/dispatch","owner":{"login":"rjew","id":10606568,"node_id":"MDQ6VXNlcjEwNjA2NTY4","avatar_url":"https://avatars0.githubusercontent.com/u/10606568?v=4","gravatar_id":"","url":"https://api.github.com/users/rjew","html_url":"https://github.com/rjew","followers_url":"https://api.github.com/users/rjew/followers","following_url":"https://api.github.com/users/rjew/following{/other_user}","gists_url":"https://api.github.com/users/rjew/gists{/gist_id}","starred_url":"https://api.github.com/users/rjew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjew/subscriptions","organizations_url":"https://api.github.com/users/rjew/orgs","repos_url":"https://api.github.com/users/rjew/repos","events_url":"https://api.github.com/users/rjew/events{/privacy}","received_events_url":"https://api.github.com/users/rjew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjew/dispatch","description":"Dispatch is a framework for deploying and managing serverless style applications.","fork":true,"url":"https://api.github.com/repos/rjew/dispatch","forks_url":"https://api.github.com/repos/rjew/dispatch/forks","keys_url":"https://api.github.com/repos/rjew/dispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjew/dispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjew/dispatch/teams","hooks_url":"https://api.github.com/repos/rjew/dispatch/hooks","issue_events_url":"https://api.github.com/repos/rjew/dispatch/issues/events{/number}","events_url":"https://api.github.com/repos/rjew/dispatch/events","assignees_url":"https://api.github.com/repos/rjew/dispatch/assignees{/user}","branches_url":"https://api.github.com/repos/rjew/dispatch/branches{/branch}","tags_url":"https://api.github.com/repos/rjew/dispatch/tags","blobs_url":"https://api.github.com/repos/rjew/dispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjew/dispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjew/dispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjew/dispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjew/dispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/rjew/dispatch/languages","stargazers_url":"https://api.github.com/repos/rjew/dispatch/stargazers","contributors_url":"https://api.github.com/repos/rjew/dispatch/contributors","subscribers_url":"https://api.github.com/repos/rjew/dispatch/subscribers","subscription_url":"https://api.github.com/repos/rjew/dispatch/subscription","commits_url":"https://api.github.com/repos/rjew/dispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjew/dispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjew/dispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjew/dispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjew/dispatch/contents/{+path}","compare_url":"https://api.github.com/repos/rjew/dispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjew/dispatch/merges","archive_url":"https://api.github.com/repos/rjew/dispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjew/dispatch/downloads","issues_url":"https://api.github.com/repos/rjew/dispatch/issues{/number}","pulls_url":"https://api.github.com/repos/rjew/dispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/rjew/dispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/rjew/dispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjew/dispatch/labels{/name}","releases_url":"https://api.github.com/repos/rjew/dispatch/releases{/id}","deployments_url":"https://api.github.com/repos/rjew/dispatch/deployments","created_at":"2018-03-07T00:07:49Z","updated_at":"2018-06-27T23:48:44Z","pushed_at":"2018-06-27T23:48:41Z","git_url":"git://github.com/rjew/dispatch.git","ssh_url":"git@github.com:rjew/dispatch.git","clone_url":"https://github.com/rjew/dispatch.git","svn_url":"https://github.com/rjew/dispatch","homepage":"","size":17201,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"215e0c7b8f8757275b71edc004f69646203b6e5a","user":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":113911425,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5MTE0MjU=","name":"dispatch","full_name":"vmware/dispatch","owner":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/dispatch","description":"Dispatch is a framework for deploying and managing serverless style applications.","fork":false,"url":"https://api.github.com/repos/vmware/dispatch","forks_url":"https://api.github.com/repos/vmware/dispatch/forks","keys_url":"https://api.github.com/repos/vmware/dispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/dispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/dispatch/teams","hooks_url":"https://api.github.com/repos/vmware/dispatch/hooks","issue_events_url":"https://api.github.com/repos/vmware/dispatch/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/dispatch/events","assignees_url":"https://api.github.com/repos/vmware/dispatch/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/dispatch/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/dispatch/tags","blobs_url":"https://api.github.com/repos/vmware/dispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/dispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/dispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/dispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/dispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/dispatch/languages","stargazers_url":"https://api.github.com/repos/vmware/dispatch/stargazers","contributors_url":"https://api.github.com/repos/vmware/dispatch/contributors","subscribers_url":"https://api.github.com/repos/vmware/dispatch/subscribers","subscription_url":"https://api.github.com/repos/vmware/dispatch/subscription","commits_url":"https://api.github.com/repos/vmware/dispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/dispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/dispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/dispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/dispatch/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/dispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/dispatch/merges","archive_url":"https://api.github.com/repos/vmware/dispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/dispatch/downloads","issues_url":"https://api.github.com/repos/vmware/dispatch/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/dispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/dispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/dispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/dispatch/labels{/name}","releases_url":"https://api.github.com/repos/vmware/dispatch/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/dispatch/deployments","created_at":"2017-12-11T21:39:57Z","updated_at":"2018-06-27T03:27:23Z","pushed_at":"2018-06-28T23:00:00Z","git_url":"git://github.com/vmware/dispatch.git","ssh_url":"git@github.com:vmware/dispatch.git","clone_url":"https://github.com/vmware/dispatch.git","svn_url":"https://github.com/vmware/dispatch","homepage":"http://dispatchframework.io","size":21500,"stargazers_count":434,"watchers_count":434,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":45,"open_issues":92,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/548"},"html":{"href":"https://github.com/vmware/dispatch/pull/548"},"issue":{"href":"https://api.github.com/repos/vmware/dispatch/issues/548"},"comments":{"href":"https://api.github.com/repos/vmware/dispatch/issues/548/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/548/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/548/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/dispatch/statuses/3db9a6134f2051d0e284346519119a85e8cbfdc5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rjew"}}