{"action":"created","comment":{"url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/comments/184327138","pull_request_review_id":115497870,"id":184327138,"diff_hunk":"@@ -0,0 +1,91 @@\n+package rpc\n+\n+import (\n+\t\"github.com/hashicorp/yamux\"\n+\tlog \"github.com/sirupsen/logrus\"\n+\t\"net\"\n+\t\"net/rpc\"\n+\t\"net/rpc/jsonrpc\"\n+\t\"sync\"\n+\n+\t\"github.com/thunderdb/ThunderDB/proto\"\n+)\n+\n+type ServiceMap map[string]interface{}\n+\n+type Server struct {\n+\tnode       *proto.Node\n+\tsessions   sync.Map // map[id]*Session\n+\trpcServer  *rpc.Server\n+\tstopCh     chan interface{}\n+\tserviceMap ServiceMap\n+}\n+\n+func NewServer() *Server {\n+\treturn &Server{","path":"rpc/server.go","position":25,"original_position":25,"commit_id":"3216c2fd342af8e264a0aa8658dcf9cdb6a5a710","original_commit_id":"3216c2fd342af8e264a0aa8658dcf9cdb6a5a710","user":{"login":"auxten","id":240147,"avatar_url":"https://avatars0.githubusercontent.com/u/240147?v=4","gravatar_id":"","url":"https://api.github.com/users/auxten","html_url":"https://github.com/auxten","followers_url":"https://api.github.com/users/auxten/followers","following_url":"https://api.github.com/users/auxten/following{/other_user}","gists_url":"https://api.github.com/users/auxten/gists{/gist_id}","starred_url":"https://api.github.com/users/auxten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auxten/subscriptions","organizations_url":"https://api.github.com/users/auxten/orgs","repos_url":"https://api.github.com/users/auxten/repos","events_url":"https://api.github.com/users/auxten/events{/privacy}","received_events_url":"https://api.github.com/users/auxten/received_events","type":"User","site_admin":false},"body":"**[golint]** <sub>reported by [reviewdog](https://github.com/haya14busa/reviewdog) :dog:</sub>\nexported function NewServer should have comment or be unexported","created_at":"2018-04-26T09:33:58Z","updated_at":"2018-04-26T09:33:59Z","html_url":"https://github.com/thunderdb/ThunderDB/pull/1#discussion_r184327138","pull_request_url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/comments/184327138"},"html":{"href":"https://github.com/thunderdb/ThunderDB/pull/1#discussion_r184327138"},"pull_request":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1","id":184080019,"html_url":"https://github.com/thunderdb/ThunderDB/pull/1","diff_url":"https://github.com/thunderdb/ThunderDB/pull/1.diff","patch_url":"https://github.com/thunderdb/ThunderDB/pull/1.patch","issue_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues/1","number":1,"state":"open","locked":false,"title":"Feature/routing","user":{"login":"auxten","id":240147,"avatar_url":"https://avatars0.githubusercontent.com/u/240147?v=4","gravatar_id":"","url":"https://api.github.com/users/auxten","html_url":"https://github.com/auxten","followers_url":"https://api.github.com/users/auxten/followers","following_url":"https://api.github.com/users/auxten/following{/other_user}","gists_url":"https://api.github.com/users/auxten/gists{/gist_id}","starred_url":"https://api.github.com/users/auxten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auxten/subscriptions","organizations_url":"https://api.github.com/users/auxten/orgs","repos_url":"https://api.github.com/users/auxten/repos","events_url":"https://api.github.com/users/auxten/events{/privacy}","received_events_url":"https://api.github.com/users/auxten/received_events","type":"User","site_admin":false},"body":"consistent hash RPC works now\r\n","created_at":"2018-04-25T15:42:51Z","updated_at":"2018-04-26T09:33:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"758d84fee7292ef61bcb3d63572ee300bc7cf0cf","assignee":{"login":"xq262144","id":434146,"avatar_url":"https://avatars0.githubusercontent.com/u/434146?v=4","gravatar_id":"","url":"https://api.github.com/users/xq262144","html_url":"https://github.com/xq262144","followers_url":"https://api.github.com/users/xq262144/followers","following_url":"https://api.github.com/users/xq262144/following{/other_user}","gists_url":"https://api.github.com/users/xq262144/gists{/gist_id}","starred_url":"https://api.github.com/users/xq262144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xq262144/subscriptions","organizations_url":"https://api.github.com/users/xq262144/orgs","repos_url":"https://api.github.com/users/xq262144/repos","events_url":"https://api.github.com/users/xq262144/events{/privacy}","received_events_url":"https://api.github.com/users/xq262144/received_events","type":"User","site_admin":false},"assignees":[{"login":"xq262144","id":434146,"avatar_url":"https://avatars0.githubusercontent.com/u/434146?v=4","gravatar_id":"","url":"https://api.github.com/users/xq262144","html_url":"https://github.com/xq262144","followers_url":"https://api.github.com/users/xq262144/followers","following_url":"https://api.github.com/users/xq262144/following{/other_user}","gists_url":"https://api.github.com/users/xq262144/gists{/gist_id}","starred_url":"https://api.github.com/users/xq262144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xq262144/subscriptions","organizations_url":"https://api.github.com/users/xq262144/orgs","repos_url":"https://api.github.com/users/xq262144/repos","events_url":"https://api.github.com/users/xq262144/events{/privacy}","received_events_url":"https://api.github.com/users/xq262144/received_events","type":"User","site_admin":false},{"login":"zeqing-guo","id":4294005,"avatar_url":"https://avatars1.githubusercontent.com/u/4294005?v=4","gravatar_id":"","url":"https://api.github.com/users/zeqing-guo","html_url":"https://github.com/zeqing-guo","followers_url":"https://api.github.com/users/zeqing-guo/followers","following_url":"https://api.github.com/users/zeqing-guo/following{/other_user}","gists_url":"https://api.github.com/users/zeqing-guo/gists{/gist_id}","starred_url":"https://api.github.com/users/zeqing-guo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeqing-guo/subscriptions","organizations_url":"https://api.github.com/users/zeqing-guo/orgs","repos_url":"https://api.github.com/users/zeqing-guo/repos","events_url":"https://api.github.com/users/zeqing-guo/events{/privacy}","received_events_url":"https://api.github.com/users/zeqing-guo/received_events","type":"User","site_admin":false},{"login":"leventeliu","id":5905469,"avatar_url":"https://avatars0.githubusercontent.com/u/5905469?v=4","gravatar_id":"","url":"https://api.github.com/users/leventeliu","html_url":"https://github.com/leventeliu","followers_url":"https://api.github.com/users/leventeliu/followers","following_url":"https://api.github.com/users/leventeliu/following{/other_user}","gists_url":"https://api.github.com/users/leventeliu/gists{/gist_id}","starred_url":"https://api.github.com/users/leventeliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventeliu/subscriptions","organizations_url":"https://api.github.com/users/leventeliu/orgs","repos_url":"https://api.github.com/users/leventeliu/repos","events_url":"https://api.github.com/users/leventeliu/events{/privacy}","received_events_url":"https://api.github.com/users/leventeliu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1/commits","review_comments_url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1/comments","review_comment_url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues/1/comments","statuses_url":"https://api.github.com/repos/thunderdb/ThunderDB/statuses/3216c2fd342af8e264a0aa8658dcf9cdb6a5a710","head":{"label":"thunderdb:feature/routing","ref":"feature/routing","sha":"3216c2fd342af8e264a0aa8658dcf9cdb6a5a710","user":{"login":"thunderdb","id":38064281,"avatar_url":"https://avatars1.githubusercontent.com/u/38064281?v=4","gravatar_id":"","url":"https://api.github.com/users/thunderdb","html_url":"https://github.com/thunderdb","followers_url":"https://api.github.com/users/thunderdb/followers","following_url":"https://api.github.com/users/thunderdb/following{/other_user}","gists_url":"https://api.github.com/users/thunderdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderdb/subscriptions","organizations_url":"https://api.github.com/users/thunderdb/orgs","repos_url":"https://api.github.com/users/thunderdb/repos","events_url":"https://api.github.com/users/thunderdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunderdb/received_events","type":"Organization","site_admin":false},"repo":{"id":129072319,"name":"ThunderDB","full_name":"thunderdb/ThunderDB","owner":{"login":"thunderdb","id":38064281,"avatar_url":"https://avatars1.githubusercontent.com/u/38064281?v=4","gravatar_id":"","url":"https://api.github.com/users/thunderdb","html_url":"https://github.com/thunderdb","followers_url":"https://api.github.com/users/thunderdb/followers","following_url":"https://api.github.com/users/thunderdb/following{/other_user}","gists_url":"https://api.github.com/users/thunderdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderdb/subscriptions","organizations_url":"https://api.github.com/users/thunderdb/orgs","repos_url":"https://api.github.com/users/thunderdb/repos","events_url":"https://api.github.com/users/thunderdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunderdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thunderdb/ThunderDB","description":"ThunderDB is a database","fork":false,"url":"https://api.github.com/repos/thunderdb/ThunderDB","forks_url":"https://api.github.com/repos/thunderdb/ThunderDB/forks","keys_url":"https://api.github.com/repos/thunderdb/ThunderDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thunderdb/ThunderDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thunderdb/ThunderDB/teams","hooks_url":"https://api.github.com/repos/thunderdb/ThunderDB/hooks","issue_events_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues/events{/number}","events_url":"https://api.github.com/repos/thunderdb/ThunderDB/events","assignees_url":"https://api.github.com/repos/thunderdb/ThunderDB/assignees{/user}","branches_url":"https://api.github.com/repos/thunderdb/ThunderDB/branches{/branch}","tags_url":"https://api.github.com/repos/thunderdb/ThunderDB/tags","blobs_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thunderdb/ThunderDB/statuses/{sha}","languages_url":"https://api.github.com/repos/thunderdb/ThunderDB/languages","stargazers_url":"https://api.github.com/repos/thunderdb/ThunderDB/stargazers","contributors_url":"https://api.github.com/repos/thunderdb/ThunderDB/contributors","subscribers_url":"https://api.github.com/repos/thunderdb/ThunderDB/subscribers","subscription_url":"https://api.github.com/repos/thunderdb/ThunderDB/subscription","commits_url":"https://api.github.com/repos/thunderdb/ThunderDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/thunderdb/ThunderDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/thunderdb/ThunderDB/contents/{+path}","compare_url":"https://api.github.com/repos/thunderdb/ThunderDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thunderdb/ThunderDB/merges","archive_url":"https://api.github.com/repos/thunderdb/ThunderDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thunderdb/ThunderDB/downloads","issues_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues{/number}","pulls_url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls{/number}","milestones_url":"https://api.github.com/repos/thunderdb/ThunderDB/milestones{/number}","notifications_url":"https://api.github.com/repos/thunderdb/ThunderDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thunderdb/ThunderDB/labels{/name}","releases_url":"https://api.github.com/repos/thunderdb/ThunderDB/releases{/id}","deployments_url":"https://api.github.com/repos/thunderdb/ThunderDB/deployments","created_at":"2018-04-11T09:52:58Z","updated_at":"2018-04-26T03:57:55Z","pushed_at":"2018-04-26T07:45:38Z","git_url":"git://github.com/thunderdb/ThunderDB.git","ssh_url":"git@github.com:thunderdb/ThunderDB.git","clone_url":"https://github.com/thunderdb/ThunderDB.git","svn_url":"https://github.com/thunderdb/ThunderDB","homepage":null,"size":3089,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":9,"default_branch":"develop"}},"base":{"label":"thunderdb:develop","ref":"develop","sha":"8596a1299bb3b35e2fd853b742ac5ceebb3f29f5","user":{"login":"thunderdb","id":38064281,"avatar_url":"https://avatars1.githubusercontent.com/u/38064281?v=4","gravatar_id":"","url":"https://api.github.com/users/thunderdb","html_url":"https://github.com/thunderdb","followers_url":"https://api.github.com/users/thunderdb/followers","following_url":"https://api.github.com/users/thunderdb/following{/other_user}","gists_url":"https://api.github.com/users/thunderdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderdb/subscriptions","organizations_url":"https://api.github.com/users/thunderdb/orgs","repos_url":"https://api.github.com/users/thunderdb/repos","events_url":"https://api.github.com/users/thunderdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunderdb/received_events","type":"Organization","site_admin":false},"repo":{"id":129072319,"name":"ThunderDB","full_name":"thunderdb/ThunderDB","owner":{"login":"thunderdb","id":38064281,"avatar_url":"https://avatars1.githubusercontent.com/u/38064281?v=4","gravatar_id":"","url":"https://api.github.com/users/thunderdb","html_url":"https://github.com/thunderdb","followers_url":"https://api.github.com/users/thunderdb/followers","following_url":"https://api.github.com/users/thunderdb/following{/other_user}","gists_url":"https://api.github.com/users/thunderdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderdb/subscriptions","organizations_url":"https://api.github.com/users/thunderdb/orgs","repos_url":"https://api.github.com/users/thunderdb/repos","events_url":"https://api.github.com/users/thunderdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunderdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thunderdb/ThunderDB","description":"ThunderDB is a database","fork":false,"url":"https://api.github.com/repos/thunderdb/ThunderDB","forks_url":"https://api.github.com/repos/thunderdb/ThunderDB/forks","keys_url":"https://api.github.com/repos/thunderdb/ThunderDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thunderdb/ThunderDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thunderdb/ThunderDB/teams","hooks_url":"https://api.github.com/repos/thunderdb/ThunderDB/hooks","issue_events_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues/events{/number}","events_url":"https://api.github.com/repos/thunderdb/ThunderDB/events","assignees_url":"https://api.github.com/repos/thunderdb/ThunderDB/assignees{/user}","branches_url":"https://api.github.com/repos/thunderdb/ThunderDB/branches{/branch}","tags_url":"https://api.github.com/repos/thunderdb/ThunderDB/tags","blobs_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thunderdb/ThunderDB/statuses/{sha}","languages_url":"https://api.github.com/repos/thunderdb/ThunderDB/languages","stargazers_url":"https://api.github.com/repos/thunderdb/ThunderDB/stargazers","contributors_url":"https://api.github.com/repos/thunderdb/ThunderDB/contributors","subscribers_url":"https://api.github.com/repos/thunderdb/ThunderDB/subscribers","subscription_url":"https://api.github.com/repos/thunderdb/ThunderDB/subscription","commits_url":"https://api.github.com/repos/thunderdb/ThunderDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/thunderdb/ThunderDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/thunderdb/ThunderDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/thunderdb/ThunderDB/contents/{+path}","compare_url":"https://api.github.com/repos/thunderdb/ThunderDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thunderdb/ThunderDB/merges","archive_url":"https://api.github.com/repos/thunderdb/ThunderDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thunderdb/ThunderDB/downloads","issues_url":"https://api.github.com/repos/thunderdb/ThunderDB/issues{/number}","pulls_url":"https://api.github.com/repos/thunderdb/ThunderDB/pulls{/number}","milestones_url":"https://api.github.com/repos/thunderdb/ThunderDB/milestones{/number}","notifications_url":"https://api.github.com/repos/thunderdb/ThunderDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thunderdb/ThunderDB/labels{/name}","releases_url":"https://api.github.com/repos/thunderdb/ThunderDB/releases{/id}","deployments_url":"https://api.github.com/repos/thunderdb/ThunderDB/deployments","created_at":"2018-04-11T09:52:58Z","updated_at":"2018-04-26T03:57:55Z","pushed_at":"2018-04-26T07:45:38Z","git_url":"git://github.com/thunderdb/ThunderDB.git","ssh_url":"git@github.com:thunderdb/ThunderDB.git","clone_url":"https://github.com/thunderdb/ThunderDB.git","svn_url":"https://github.com/thunderdb/ThunderDB","homepage":null,"size":3089,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1"},"html":{"href":"https://github.com/thunderdb/ThunderDB/pull/1"},"issue":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/issues/1"},"comments":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/thunderdb/ThunderDB/statuses/3216c2fd342af8e264a0aa8658dcf9cdb6a5a710"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"auxten"}}