{"action":"created","issue":{"url":"https://api.github.com/repos/brave/brave-core/issues/316","repository_url":"https://api.github.com/repos/brave/brave-core","labels_url":"https://api.github.com/repos/brave/brave-core/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/316/comments","events_url":"https://api.github.com/repos/brave/brave-core/issues/316/events","html_url":"https://github.com/brave/brave-core/pull/316","id":349252173,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDEzNDAz","number":316,"title":"Implement Tor client updater as component extension","user":{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false},"assignees":[{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-08-09T19:05:46Z","updated_at":"2018-08-24T22:19:29Z","closed_at":"2018-08-09T20:06:48Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/316","html_url":"https://github.com/brave/brave-core/pull/316","diff_url":"https://github.com/brave/brave-core/pull/316.diff","patch_url":"https://github.com/brave/brave-core/pull/316.patch"},"body":"Fixes brave/brave-browser#724\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n\r\n## Test Plan:\r\n\r\n- Extension download and installation\r\n  - Start with a clean profile\r\n  - Launch Brave\r\n  - Visit chrome://components\r\n  - Verify that Tor Client Updater is listed and version number is not `0.0.0.0`\r\n  - Verify that name of component contains platform identifier (Windows/Mac/Linux)\r\n\r\n- Command-line switch to disable extension\r\n  - Start with a clean profile\r\n  - Launch Brave with `--disable-tor-client-updater-extension`\r\n  - Visit chrome://components and verify that Tor Client Updater is not listed\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n"},"comment":{"url":"https://api.github.com/repos/brave/brave-core/issues/comments/415897115","html_url":"https://github.com/brave/brave-core/pull/316#issuecomment-415897115","issue_url":"https://api.github.com/repos/brave/brave-core/issues/316","id":415897115,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTg5NzExNQ==","user":{"login":"riastradh-brave","id":34034191,"node_id":"MDQ6VXNlcjM0MDM0MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/34034191?v=4","gravatar_id":"","url":"https://api.github.com/users/riastradh-brave","html_url":"https://github.com/riastradh-brave","followers_url":"https://api.github.com/users/riastradh-brave/followers","following_url":"https://api.github.com/users/riastradh-brave/following{/other_user}","gists_url":"https://api.github.com/users/riastradh-brave/gists{/gist_id}","starred_url":"https://api.github.com/users/riastradh-brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riastradh-brave/subscriptions","organizations_url":"https://api.github.com/users/riastradh-brave/orgs","repos_url":"https://api.github.com/users/riastradh-brave/repos","events_url":"https://api.github.com/users/riastradh-brave/events{/privacy}","received_events_url":"https://api.github.com/users/riastradh-brave/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T22:19:29Z","updated_at":"2018-08-24T22:19:29Z","author_association":"CONTRIBUTOR","body":"Is the security model of extensions documented anywhere?  I gather that there is a public key for verifying signatures, but I'm interested in making sure that there's, e.g., no vector for rollback attacks with valid signatures."}}
{"actor":{"display_login":"riastradh-brave"}}