{"action":"closed","number":199,"pull_request":{"url":"https://api.github.com/repos/fixie/fixie/pulls/199","id":230344330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzQ0MzMw","html_url":"https://github.com/fixie/fixie/pull/199","diff_url":"https://github.com/fixie/fixie/pull/199.diff","patch_url":"https://github.com/fixie/fixie/pull/199.patch","issue_url":"https://api.github.com/repos/fixie/fixie/issues/199","number":199,"state":"closed","locked":false,"title":"Add support for F# methods that return Async<T> or Task/Task<T>.","user":{"login":"petejohanson","id":202695,"node_id":"MDQ6VXNlcjIwMjY5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/202695?v=4","gravatar_id":"","url":"https://api.github.com/users/petejohanson","html_url":"https://github.com/petejohanson","followers_url":"https://api.github.com/users/petejohanson/followers","following_url":"https://api.github.com/users/petejohanson/following{/other_user}","gists_url":"https://api.github.com/users/petejohanson/gists{/gist_id}","starred_url":"https://api.github.com/users/petejohanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petejohanson/subscriptions","organizations_url":"https://api.github.com/users/petejohanson/orgs","repos_url":"https://api.github.com/users/petejohanson/repos","events_url":"https://api.github.com/users/petejohanson/events{/privacy}","received_events_url":"https://api.github.com/users/petejohanson/received_events","type":"User","site_admin":false},"body":"With these changes, the following types of F# test functions seem to work as expected:\r\n\r\n1. Returning native F# async (the signature here would be `unit -> Async<unit>`):\r\n\r\n```\r\nlet ``it should async return the expected results``() =\r\n    async {\r\n        let! result = someAsyncMethod \"test\"\r\n        result.ShouldBe(\"testtest\")\r\n    }\r\n```\r\n\r\n2. Or the version that returns a `Task<T>`, but doesn't have the attribute that's added for `async` C# methods (the signature here would be `unit -> Task<unit>`):\r\n\r\n```\r\nlet ``it should async return the expected results``() =\r\n    async {\r\n        let! result = someAsyncMethod \"test\"\r\n        result.ShouldBe(\"testtest\")\r\n    } |> Async.StartAsTask\r\n```\r\n\r\nI'm not honestly sure how to easily test this without dragging F# into the tests, or writing a second test assembly in F#.\r\n\r\nThoughts?\r\n\r\n","created_at":"2018-11-13T04:26:32Z","updated_at":"2018-11-21T19:33:09Z","closed_at":"2018-11-21T19:33:08Z","merged_at":"2018-11-21T19:33:08Z","merge_commit_sha":"de4064f9f06655587ded01877d73590a13572575","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fixie/fixie/pulls/199/commits","review_comments_url":"https://api.github.com/repos/fixie/fixie/pulls/199/comments","review_comment_url":"https://api.github.com/repos/fixie/fixie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fixie/fixie/issues/199/comments","statuses_url":"https://api.github.com/repos/fixie/fixie/statuses/f07ab5f3c0a11db0438334761a2055964b969caf","head":{"label":"petejohanson:first-class-fsharp-async","ref":"first-class-fsharp-async","sha":"f07ab5f3c0a11db0438334761a2055964b969caf","user":{"login":"petejohanson","id":202695,"node_id":"MDQ6VXNlcjIwMjY5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/202695?v=4","gravatar_id":"","url":"https://api.github.com/users/petejohanson","html_url":"https://github.com/petejohanson","followers_url":"https://api.github.com/users/petejohanson/followers","following_url":"https://api.github.com/users/petejohanson/following{/other_user}","gists_url":"https://api.github.com/users/petejohanson/gists{/gist_id}","starred_url":"https://api.github.com/users/petejohanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petejohanson/subscriptions","organizations_url":"https://api.github.com/users/petejohanson/orgs","repos_url":"https://api.github.com/users/petejohanson/repos","events_url":"https://api.github.com/users/petejohanson/events{/privacy}","received_events_url":"https://api.github.com/users/petejohanson/received_events","type":"User","site_admin":false},"repo":{"id":15759321,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1OTMyMQ==","name":"fixie","full_name":"petejohanson/fixie","private":false,"owner":{"login":"petejohanson","id":202695,"node_id":"MDQ6VXNlcjIwMjY5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/202695?v=4","gravatar_id":"","url":"https://api.github.com/users/petejohanson","html_url":"https://github.com/petejohanson","followers_url":"https://api.github.com/users/petejohanson/followers","following_url":"https://api.github.com/users/petejohanson/following{/other_user}","gists_url":"https://api.github.com/users/petejohanson/gists{/gist_id}","starred_url":"https://api.github.com/users/petejohanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petejohanson/subscriptions","organizations_url":"https://api.github.com/users/petejohanson/orgs","repos_url":"https://api.github.com/users/petejohanson/repos","events_url":"https://api.github.com/users/petejohanson/events{/privacy}","received_events_url":"https://api.github.com/users/petejohanson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/petejohanson/fixie","description":"Conventional Testing for .NET","fork":true,"url":"https://api.github.com/repos/petejohanson/fixie","forks_url":"https://api.github.com/repos/petejohanson/fixie/forks","keys_url":"https://api.github.com/repos/petejohanson/fixie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petejohanson/fixie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petejohanson/fixie/teams","hooks_url":"https://api.github.com/repos/petejohanson/fixie/hooks","issue_events_url":"https://api.github.com/repos/petejohanson/fixie/issues/events{/number}","events_url":"https://api.github.com/repos/petejohanson/fixie/events","assignees_url":"https://api.github.com/repos/petejohanson/fixie/assignees{/user}","branches_url":"https://api.github.com/repos/petejohanson/fixie/branches{/branch}","tags_url":"https://api.github.com/repos/petejohanson/fixie/tags","blobs_url":"https://api.github.com/repos/petejohanson/fixie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petejohanson/fixie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petejohanson/fixie/git/refs{/sha}","trees_url":"https://api.github.com/repos/petejohanson/fixie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petejohanson/fixie/statuses/{sha}","languages_url":"https://api.github.com/repos/petejohanson/fixie/languages","stargazers_url":"https://api.github.com/repos/petejohanson/fixie/stargazers","contributors_url":"https://api.github.com/repos/petejohanson/fixie/contributors","subscribers_url":"https://api.github.com/repos/petejohanson/fixie/subscribers","subscription_url":"https://api.github.com/repos/petejohanson/fixie/subscription","commits_url":"https://api.github.com/repos/petejohanson/fixie/commits{/sha}","git_commits_url":"https://api.github.com/repos/petejohanson/fixie/git/commits{/sha}","comments_url":"https://api.github.com/repos/petejohanson/fixie/comments{/number}","issue_comment_url":"https://api.github.com/repos/petejohanson/fixie/issues/comments{/number}","contents_url":"https://api.github.com/repos/petejohanson/fixie/contents/{+path}","compare_url":"https://api.github.com/repos/petejohanson/fixie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petejohanson/fixie/merges","archive_url":"https://api.github.com/repos/petejohanson/fixie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petejohanson/fixie/downloads","issues_url":"https://api.github.com/repos/petejohanson/fixie/issues{/number}","pulls_url":"https://api.github.com/repos/petejohanson/fixie/pulls{/number}","milestones_url":"https://api.github.com/repos/petejohanson/fixie/milestones{/number}","notifications_url":"https://api.github.com/repos/petejohanson/fixie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petejohanson/fixie/labels{/name}","releases_url":"https://api.github.com/repos/petejohanson/fixie/releases{/id}","deployments_url":"https://api.github.com/repos/petejohanson/fixie/deployments","created_at":"2014-01-09T07:09:34Z","updated_at":"2018-11-12T18:59:06Z","pushed_at":"2018-11-21T04:06:43Z","git_url":"git://github.com/petejohanson/fixie.git","ssh_url":"git@github.com:petejohanson/fixie.git","clone_url":"https://github.com/petejohanson/fixie.git","svn_url":"https://github.com/petejohanson/fixie","homepage":"http://plioi.github.io/fixie","size":4529,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fixie:develop","ref":"develop","sha":"1f1ac4f73bf703f74058e32324e58d2c392506b1","user":{"login":"fixie","id":8389680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzODk2ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8389680?v=4","gravatar_id":"","url":"https://api.github.com/users/fixie","html_url":"https://github.com/fixie","followers_url":"https://api.github.com/users/fixie/followers","following_url":"https://api.github.com/users/fixie/following{/other_user}","gists_url":"https://api.github.com/users/fixie/gists{/gist_id}","starred_url":"https://api.github.com/users/fixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fixie/subscriptions","organizations_url":"https://api.github.com/users/fixie/orgs","repos_url":"https://api.github.com/users/fixie/repos","events_url":"https://api.github.com/users/fixie/events{/privacy}","received_events_url":"https://api.github.com/users/fixie/received_events","type":"Organization","site_admin":false},"repo":{"id":8524668,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI0NjY4","name":"fixie","full_name":"fixie/fixie","private":false,"owner":{"login":"fixie","id":8389680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzODk2ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8389680?v=4","gravatar_id":"","url":"https://api.github.com/users/fixie","html_url":"https://github.com/fixie","followers_url":"https://api.github.com/users/fixie/followers","following_url":"https://api.github.com/users/fixie/following{/other_user}","gists_url":"https://api.github.com/users/fixie/gists{/gist_id}","starred_url":"https://api.github.com/users/fixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fixie/subscriptions","organizations_url":"https://api.github.com/users/fixie/orgs","repos_url":"https://api.github.com/users/fixie/repos","events_url":"https://api.github.com/users/fixie/events{/privacy}","received_events_url":"https://api.github.com/users/fixie/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fixie/fixie","description":"Modern Testing for .NET","fork":false,"url":"https://api.github.com/repos/fixie/fixie","forks_url":"https://api.github.com/repos/fixie/fixie/forks","keys_url":"https://api.github.com/repos/fixie/fixie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fixie/fixie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fixie/fixie/teams","hooks_url":"https://api.github.com/repos/fixie/fixie/hooks","issue_events_url":"https://api.github.com/repos/fixie/fixie/issues/events{/number}","events_url":"https://api.github.com/repos/fixie/fixie/events","assignees_url":"https://api.github.com/repos/fixie/fixie/assignees{/user}","branches_url":"https://api.github.com/repos/fixie/fixie/branches{/branch}","tags_url":"https://api.github.com/repos/fixie/fixie/tags","blobs_url":"https://api.github.com/repos/fixie/fixie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fixie/fixie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fixie/fixie/git/refs{/sha}","trees_url":"https://api.github.com/repos/fixie/fixie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fixie/fixie/statuses/{sha}","languages_url":"https://api.github.com/repos/fixie/fixie/languages","stargazers_url":"https://api.github.com/repos/fixie/fixie/stargazers","contributors_url":"https://api.github.com/repos/fixie/fixie/contributors","subscribers_url":"https://api.github.com/repos/fixie/fixie/subscribers","subscription_url":"https://api.github.com/repos/fixie/fixie/subscription","commits_url":"https://api.github.com/repos/fixie/fixie/commits{/sha}","git_commits_url":"https://api.github.com/repos/fixie/fixie/git/commits{/sha}","comments_url":"https://api.github.com/repos/fixie/fixie/comments{/number}","issue_comment_url":"https://api.github.com/repos/fixie/fixie/issues/comments{/number}","contents_url":"https://api.github.com/repos/fixie/fixie/contents/{+path}","compare_url":"https://api.github.com/repos/fixie/fixie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fixie/fixie/merges","archive_url":"https://api.github.com/repos/fixie/fixie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fixie/fixie/downloads","issues_url":"https://api.github.com/repos/fixie/fixie/issues{/number}","pulls_url":"https://api.github.com/repos/fixie/fixie/pulls{/number}","milestones_url":"https://api.github.com/repos/fixie/fixie/milestones{/number}","notifications_url":"https://api.github.com/repos/fixie/fixie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fixie/fixie/labels{/name}","releases_url":"https://api.github.com/repos/fixie/fixie/releases{/id}","deployments_url":"https://api.github.com/repos/fixie/fixie/deployments","created_at":"2013-03-02T18:05:22Z","updated_at":"2018-11-15T06:50:16Z","pushed_at":"2018-11-21T19:33:08Z","git_url":"git://github.com/fixie/fixie.git","ssh_url":"git@github.com:fixie/fixie.git","clone_url":"https://github.com/fixie/fixie.git","svn_url":"https://github.com/fixie/fixie","homepage":"http://fixie.github.io","size":5230,"stargazers_count":369,"watchers_count":369,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":61,"open_issues":14,"watchers":369,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/fixie/fixie/pulls/199"},"html":{"href":"https://github.com/fixie/fixie/pull/199"},"issue":{"href":"https://api.github.com/repos/fixie/fixie/issues/199"},"comments":{"href":"https://api.github.com/repos/fixie/fixie/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/fixie/fixie/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/fixie/fixie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fixie/fixie/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/fixie/fixie/statuses/f07ab5f3c0a11db0438334761a2055964b969caf"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"plioi","id":652745,"node_id":"MDQ6VXNlcjY1Mjc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/652745?v=4","gravatar_id":"","url":"https://api.github.com/users/plioi","html_url":"https://github.com/plioi","followers_url":"https://api.github.com/users/plioi/followers","following_url":"https://api.github.com/users/plioi/following{/other_user}","gists_url":"https://api.github.com/users/plioi/gists{/gist_id}","starred_url":"https://api.github.com/users/plioi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plioi/subscriptions","organizations_url":"https://api.github.com/users/plioi/orgs","repos_url":"https://api.github.com/users/plioi/repos","events_url":"https://api.github.com/users/plioi/events{/privacy}","received_events_url":"https://api.github.com/users/plioi/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":97,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"plioi"}}