{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/comments/178541265","pull_request_review_id":108612010,"id":178541265,"diff_hunk":"@@ -0,0 +1,59 @@\n+'use strict';","path":"custom_modules/react-diff-custom/dist/react-diff-custom.js","position":1,"original_position":1,"commit_id":"4c791ecfabc3b04ebdcb8b021b8a18b68247eed8","original_commit_id":"4c791ecfabc3b04ebdcb8b021b8a18b68247eed8","user":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars0.githubusercontent.com/u/285899?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"body":"We already have a `components` directory inside `src`, and this can go there. Some things to change:\r\n\r\n- Use ES `import` and `export` instead of CommonJS `require` and `module.exports`.\r\n- Use `const` over `var`, which the linter will enforce once this is moved into `src`.\r\n- `React.createClass` isn't used in this codebase, as ES classes are used. See all other components in this repo for examples.\r\n- React isn't going to have `PropTypes` on it, as we are importing the `prop-types` package.\r\n- Use JSX.","created_at":"2018-04-02T13:13:48Z","updated_at":"2018-04-02T13:16:28Z","html_url":"https://github.com/taskcluster/taskcluster-tools/pull/513#discussion_r178541265","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/comments/178541265"},"html":{"href":"https://github.com/taskcluster/taskcluster-tools/pull/513#discussion_r178541265"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513"}}},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513","id":178737277,"html_url":"https://github.com/taskcluster/taskcluster-tools/pull/513","diff_url":"https://github.com/taskcluster/taskcluster-tools/pull/513.diff","patch_url":"https://github.com/taskcluster/taskcluster-tools/pull/513.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/issues/513","number":513,"state":"open","locked":false,"title":"Add a diff view before saving changes in the ScopeEditor","user":{"login":"MynahMarie","id":24983802,"avatar_url":"https://avatars3.githubusercontent.com/u/24983802?v=4","gravatar_id":"","url":"https://api.github.com/users/MynahMarie","html_url":"https://github.com/MynahMarie","followers_url":"https://api.github.com/users/MynahMarie/followers","following_url":"https://api.github.com/users/MynahMarie/following{/other_user}","gists_url":"https://api.github.com/users/MynahMarie/gists{/gist_id}","starred_url":"https://api.github.com/users/MynahMarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MynahMarie/subscriptions","organizations_url":"https://api.github.com/users/MynahMarie/orgs","repos_url":"https://api.github.com/users/MynahMarie/repos","events_url":"https://api.github.com/users/MynahMarie/events{/privacy}","received_events_url":"https://api.github.com/users/MynahMarie/received_events","type":"User","site_admin":false},"body":"In this PR I have:\r\n\r\n- added a 4th button to the `ButtonToolbar` which toggles between \"**Review**\" and \"**Edit**\"\r\n- created a new rendering function that shows the changes the user made if he/she wishes to review them before saving.\r\n- created a customized version of the `react-diff` module in order to create a component that renders those changes\r\n- created a new directory in the project's root to store the custom `react-diff` module I've created\r\n\r\nRelates Bugzilla 1306494","created_at":"2018-04-01T16:46:13Z","updated_at":"2018-04-02T13:16:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d4a59584683c5d8e287b40e77527ff40070d22c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/issues/513/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/statuses/4c791ecfabc3b04ebdcb8b021b8a18b68247eed8","head":{"label":"MynahMarie:addDiffView","ref":"addDiffView","sha":"4c791ecfabc3b04ebdcb8b021b8a18b68247eed8","user":{"login":"MynahMarie","id":24983802,"avatar_url":"https://avatars3.githubusercontent.com/u/24983802?v=4","gravatar_id":"","url":"https://api.github.com/users/MynahMarie","html_url":"https://github.com/MynahMarie","followers_url":"https://api.github.com/users/MynahMarie/followers","following_url":"https://api.github.com/users/MynahMarie/following{/other_user}","gists_url":"https://api.github.com/users/MynahMarie/gists{/gist_id}","starred_url":"https://api.github.com/users/MynahMarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MynahMarie/subscriptions","organizations_url":"https://api.github.com/users/MynahMarie/orgs","repos_url":"https://api.github.com/users/MynahMarie/repos","events_url":"https://api.github.com/users/MynahMarie/events{/privacy}","received_events_url":"https://api.github.com/users/MynahMarie/received_events","type":"User","site_admin":false},"repo":{"id":125740680,"name":"taskcluster-tools","full_name":"MynahMarie/taskcluster-tools","owner":{"login":"MynahMarie","id":24983802,"avatar_url":"https://avatars3.githubusercontent.com/u/24983802?v=4","gravatar_id":"","url":"https://api.github.com/users/MynahMarie","html_url":"https://github.com/MynahMarie","followers_url":"https://api.github.com/users/MynahMarie/followers","following_url":"https://api.github.com/users/MynahMarie/following{/other_user}","gists_url":"https://api.github.com/users/MynahMarie/gists{/gist_id}","starred_url":"https://api.github.com/users/MynahMarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MynahMarie/subscriptions","organizations_url":"https://api.github.com/users/MynahMarie/orgs","repos_url":"https://api.github.com/users/MynahMarie/repos","events_url":"https://api.github.com/users/MynahMarie/events{/privacy}","received_events_url":"https://api.github.com/users/MynahMarie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MynahMarie/taskcluster-tools","description":"Tools for debugging, inspecting and managing Taskcluster","fork":true,"url":"https://api.github.com/repos/MynahMarie/taskcluster-tools","forks_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/forks","keys_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/teams","hooks_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/hooks","issue_events_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/issues/events{/number}","events_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/events","assignees_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/assignees{/user}","branches_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/branches{/branch}","tags_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/tags","blobs_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/languages","stargazers_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/stargazers","contributors_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/contributors","subscribers_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/subscribers","subscription_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/subscription","commits_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/contents/{+path}","compare_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/merges","archive_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/downloads","issues_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/issues{/number}","pulls_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/labels{/name}","releases_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/releases{/id}","deployments_url":"https://api.github.com/repos/MynahMarie/taskcluster-tools/deployments","created_at":"2018-03-18T15:42:18Z","updated_at":"2018-03-18T15:42:20Z","pushed_at":"2018-04-02T09:40:21Z","git_url":"git://github.com/MynahMarie/taskcluster-tools.git","ssh_url":"git@github.com:MynahMarie/taskcluster-tools.git","clone_url":"https://github.com/MynahMarie/taskcluster-tools.git","svn_url":"https://github.com/MynahMarie/taskcluster-tools","homepage":"https://tools.taskcluster.net/","size":5860,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"aa11a968af0eeb4a758a828451cb9c480ffbb80c","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":25545398,"name":"taskcluster-tools","full_name":"taskcluster/taskcluster-tools","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-tools","description":"Tools for debugging, inspecting and managing Taskcluster","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-tools","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-tools/deployments","created_at":"2014-10-21T20:51:27Z","updated_at":"2018-03-22T21:44:07Z","pushed_at":"2018-04-02T09:40:22Z","git_url":"git://github.com/taskcluster/taskcluster-tools.git","ssh_url":"git@github.com:taskcluster/taskcluster-tools.git","clone_url":"https://github.com/taskcluster/taskcluster-tools.git","svn_url":"https://github.com/taskcluster/taskcluster-tools","homepage":"https://tools.taskcluster.net/","size":5848,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":76,"open_issues":15,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513"},"html":{"href":"https://github.com/taskcluster/taskcluster-tools/pull/513"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/issues/513"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-tools/statuses/4c791ecfabc3b04ebdcb8b021b8a18b68247eed8"}},"author_association":"NONE"}}
{"actor":{"display_login":"eliperelman"}}