{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/installer/issues/174","repository_url":"https://api.github.com/repos/openshift/installer","labels_url":"https://api.github.com/repos/openshift/installer/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/openshift/installer/issues/174/comments","events_url":"https://api.github.com/repos/openshift/installer/issues/174/events","html_url":"https://github.com/openshift/installer/pull/174","id":353933650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODUzMDY3","number":174,"title":"hack: Add :z to --volume mounts","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959732398,"node_id":"MDU6TGFiZWw5NTk3MzIzOTg=","url":"https://api.github.com/repos/openshift/installer/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":959729794,"node_id":"MDU6TGFiZWw5NTk3Mjk3OTQ=","url":"https://api.github.com/repos/openshift/installer/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"yifan-gu","id":3278588,"node_id":"MDQ6VXNlcjMyNzg1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3278588?v=4","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"assignees":[{"login":"yifan-gu","id":3278588,"node_id":"MDQ6VXNlcjMyNzg1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3278588?v=4","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-08-24T21:27:50Z","updated_at":"2018-08-30T23:43:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/174","html_url":"https://github.com/openshift/installer/pull/174","diff_url":"https://github.com/openshift/installer/pull/174.diff","patch_url":"https://github.com/openshift/installer/pull/174.patch"},"body":"Like we did in bootkube.sh in 0fa4eb13 (#134).  This gives us permission to access the mounted volume when SELinux is enabled (docs [here][1]).\n\nI've also normalized these invocations for consistency between the various `hack/` scripts:\n\n* Adding slash separators to put each option on its own line, excepting the final command being run in the container.  This makes the long commands slightly easier to skim.  It will also make it easier to track down motivation for an option with `git blame`, because commits touching options on other lines won't clutter the blame.\n\n* Use long-form options (`-v` -> `--volume`, etc.).  This makes the options a bit more accessible to newcomers, and now that each option is on it's own line we have plenty of space.\n\n* Dropped single quotes from `'TRUE'`.  There are no shell-sensitive characters in `TRUE`, so there's no need to quote it.\n\n* Use `${PWD}` consistently.  [It's in POSIX][2], so there's no need to execute a `pwd` process to get this value.\n\n* Drop `-t`.  None of these commands should need a pseudoterminal.\n\n* Drop explicit `rw` `--volume` options.  They're [the default][3].\n\n[1]: https://github.com/containers/libpod/blame/v0.8.3/docs/podman-run.1.md#L628\n[2]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03\n[3]: https://github.com/containers/libpod/blame/v0.8.3/docs/podman-run.1.md#L646"},"comment":{"url":"https://api.github.com/repos/openshift/installer/issues/comments/417502910","html_url":"https://github.com/openshift/installer/pull/174#issuecomment-417502910","issue_url":"https://api.github.com/repos/openshift/installer/issues/174","id":417502910,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzUwMjkxMA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T23:43:28Z","updated_at":"2018-08-30T23:43:28Z","author_association":"NONE","body":"@wking: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/e2e-aws | 4ba649b150219f8da550a314c171bcdd32f58865 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/174/pull-ci-origin-installer-e2e-aws/799/) | `/test e2e-aws`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_installer/174). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/wking). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/installer/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}