{"action":"created","comment":{"url":"https://api.github.com/repos/irisnet/irishub/pulls/comments/204963088","pull_request_review_id":140139895,"id":204963088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk2MzA4OA==","diff_hunk":"@@ -0,0 +1,53 @@\n+# Upgrade Module\n+\n+本module作为支持区块链软件平滑升级的基础设施，通过upgradeProposal和switch两阶段的投票来在约定高度切换到新版的代码，并对历史版本的链上数据完全兼容。\n+\n+key point：\n+\n+* upgradeProposal投票通过后各个节点下载安装新版本软件，并启动软件发送switch投票，表明已经可以切换到新版本\n+* switch的投票将在约定高度进行检查，需要95%的Voting Power才视为投票通过\n+* switch通过后开启切换流程：\n+   1. check_tx全部返回fail，以拒绝新tx的处理\n+   2. 处理mempool中留存的tx，直到生成一个empty block","path":"docs/modules/README.md","position":11,"original_position":11,"commit_id":"e79ec37a9682c24c8474f8c3bce20adbfcd71158","original_commit_id":"e79ec37a9682c24c8474f8c3bce20adbfcd71158","user":{"login":"wukongcheng","id":6427270,"node_id":"MDQ6VXNlcjY0MjcyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6427270?v=4","gravatar_id":"","url":"https://api.github.com/users/wukongcheng","html_url":"https://github.com/wukongcheng","followers_url":"https://api.github.com/users/wukongcheng/followers","following_url":"https://api.github.com/users/wukongcheng/following{/other_user}","gists_url":"https://api.github.com/users/wukongcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wukongcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wukongcheng/subscriptions","organizations_url":"https://api.github.com/users/wukongcheng/orgs","repos_url":"https://api.github.com/users/wukongcheng/repos","events_url":"https://api.github.com/users/wukongcheng/events{/privacy}","received_events_url":"https://api.github.com/users/wukongcheng/received_events","type":"User","site_admin":false},"body":"社区会公告在第多少高度进行版本升级，提醒届时会终止服务，不要在升级时间段内发交易。所以这里算是一个防御检查，保守一点可以先等两个空块，后续压测发现不足的话再调整。","created_at":"2018-07-25T02:05:09Z","updated_at":"2018-07-25T02:05:09Z","html_url":"https://github.com/irisnet/irishub/pull/46#discussion_r204963088","pull_request_url":"https://api.github.com/repos/irisnet/irishub/pulls/46","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/irisnet/irishub/pulls/comments/204963088"},"html":{"href":"https://github.com/irisnet/irishub/pull/46#discussion_r204963088"},"pull_request":{"href":"https://api.github.com/repos/irisnet/irishub/pulls/46"}},"in_reply_to_id":204960567},"pull_request":{"url":"https://api.github.com/repos/irisnet/irishub/pulls/46","id":203538181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTM4MTgx","html_url":"https://github.com/irisnet/irishub/pull/46","diff_url":"https://github.com/irisnet/irishub/pull/46.diff","patch_url":"https://github.com/irisnet/irishub/pull/46.patch","issue_url":"https://api.github.com/repos/irisnet/irishub/issues/46","number":46,"state":"open","locked":false,"title":"upgrade module : design doc and the framework codes","user":{"login":"wukongcheng","id":6427270,"node_id":"MDQ6VXNlcjY0MjcyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6427270?v=4","gravatar_id":"","url":"https://api.github.com/users/wukongcheng","html_url":"https://github.com/wukongcheng","followers_url":"https://api.github.com/users/wukongcheng/followers","following_url":"https://api.github.com/users/wukongcheng/following{/other_user}","gists_url":"https://api.github.com/users/wukongcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wukongcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wukongcheng/subscriptions","organizations_url":"https://api.github.com/users/wukongcheng/orgs","repos_url":"https://api.github.com/users/wukongcheng/repos","events_url":"https://api.github.com/users/wukongcheng/events{/privacy}","received_events_url":"https://api.github.com/users/wukongcheng/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-24T14:02:39Z","updated_at":"2018-07-25T02:05:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36f0d7bf688a39e1e3cbae5b9cc75575ac0c73a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/irisnet/irishub/pulls/46/commits","review_comments_url":"https://api.github.com/repos/irisnet/irishub/pulls/46/comments","review_comment_url":"https://api.github.com/repos/irisnet/irishub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/irisnet/irishub/issues/46/comments","statuses_url":"https://api.github.com/repos/irisnet/irishub/statuses/e79ec37a9682c24c8474f8c3bce20adbfcd71158","head":{"label":"wukongcheng:silei/software-upgrade","ref":"silei/software-upgrade","sha":"e79ec37a9682c24c8474f8c3bce20adbfcd71158","user":{"login":"wukongcheng","id":6427270,"node_id":"MDQ6VXNlcjY0MjcyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6427270?v=4","gravatar_id":"","url":"https://api.github.com/users/wukongcheng","html_url":"https://github.com/wukongcheng","followers_url":"https://api.github.com/users/wukongcheng/followers","following_url":"https://api.github.com/users/wukongcheng/following{/other_user}","gists_url":"https://api.github.com/users/wukongcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wukongcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wukongcheng/subscriptions","organizations_url":"https://api.github.com/users/wukongcheng/orgs","repos_url":"https://api.github.com/users/wukongcheng/repos","events_url":"https://api.github.com/users/wukongcheng/events{/privacy}","received_events_url":"https://api.github.com/users/wukongcheng/received_events","type":"User","site_admin":false},"repo":{"id":141723105,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MjMxMDU=","name":"irishub","full_name":"wukongcheng/irishub","owner":{"login":"wukongcheng","id":6427270,"node_id":"MDQ6VXNlcjY0MjcyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6427270?v=4","gravatar_id":"","url":"https://api.github.com/users/wukongcheng","html_url":"https://github.com/wukongcheng","followers_url":"https://api.github.com/users/wukongcheng/followers","following_url":"https://api.github.com/users/wukongcheng/following{/other_user}","gists_url":"https://api.github.com/users/wukongcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wukongcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wukongcheng/subscriptions","organizations_url":"https://api.github.com/users/wukongcheng/orgs","repos_url":"https://api.github.com/users/wukongcheng/repos","events_url":"https://api.github.com/users/wukongcheng/events{/privacy}","received_events_url":"https://api.github.com/users/wukongcheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wukongcheng/irishub","description":"Cosmos regional hub with a built-in Service Infrastructure","fork":true,"url":"https://api.github.com/repos/wukongcheng/irishub","forks_url":"https://api.github.com/repos/wukongcheng/irishub/forks","keys_url":"https://api.github.com/repos/wukongcheng/irishub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wukongcheng/irishub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wukongcheng/irishub/teams","hooks_url":"https://api.github.com/repos/wukongcheng/irishub/hooks","issue_events_url":"https://api.github.com/repos/wukongcheng/irishub/issues/events{/number}","events_url":"https://api.github.com/repos/wukongcheng/irishub/events","assignees_url":"https://api.github.com/repos/wukongcheng/irishub/assignees{/user}","branches_url":"https://api.github.com/repos/wukongcheng/irishub/branches{/branch}","tags_url":"https://api.github.com/repos/wukongcheng/irishub/tags","blobs_url":"https://api.github.com/repos/wukongcheng/irishub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wukongcheng/irishub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wukongcheng/irishub/git/refs{/sha}","trees_url":"https://api.github.com/repos/wukongcheng/irishub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wukongcheng/irishub/statuses/{sha}","languages_url":"https://api.github.com/repos/wukongcheng/irishub/languages","stargazers_url":"https://api.github.com/repos/wukongcheng/irishub/stargazers","contributors_url":"https://api.github.com/repos/wukongcheng/irishub/contributors","subscribers_url":"https://api.github.com/repos/wukongcheng/irishub/subscribers","subscription_url":"https://api.github.com/repos/wukongcheng/irishub/subscription","commits_url":"https://api.github.com/repos/wukongcheng/irishub/commits{/sha}","git_commits_url":"https://api.github.com/repos/wukongcheng/irishub/git/commits{/sha}","comments_url":"https://api.github.com/repos/wukongcheng/irishub/comments{/number}","issue_comment_url":"https://api.github.com/repos/wukongcheng/irishub/issues/comments{/number}","contents_url":"https://api.github.com/repos/wukongcheng/irishub/contents/{+path}","compare_url":"https://api.github.com/repos/wukongcheng/irishub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wukongcheng/irishub/merges","archive_url":"https://api.github.com/repos/wukongcheng/irishub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wukongcheng/irishub/downloads","issues_url":"https://api.github.com/repos/wukongcheng/irishub/issues{/number}","pulls_url":"https://api.github.com/repos/wukongcheng/irishub/pulls{/number}","milestones_url":"https://api.github.com/repos/wukongcheng/irishub/milestones{/number}","notifications_url":"https://api.github.com/repos/wukongcheng/irishub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wukongcheng/irishub/labels{/name}","releases_url":"https://api.github.com/repos/wukongcheng/irishub/releases{/id}","deployments_url":"https://api.github.com/repos/wukongcheng/irishub/deployments","created_at":"2018-07-20T14:38:22Z","updated_at":"2018-07-24T14:52:28Z","pushed_at":"2018-07-24T13:57:48Z","git_url":"git://github.com/wukongcheng/irishub.git","ssh_url":"git@github.com:wukongcheng/irishub.git","clone_url":"https://github.com/wukongcheng/irishub.git","svn_url":"https://github.com/wukongcheng/irishub","homepage":"","size":202,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"irisnet:feature/software-upgrade","ref":"feature/software-upgrade","sha":"0cc58b1302c63d21f230a93837f6bbd42684e41d","user":{"login":"irisnet","id":33032395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDMyMzk1","avatar_url":"https://avatars0.githubusercontent.com/u/33032395?v=4","gravatar_id":"","url":"https://api.github.com/users/irisnet","html_url":"https://github.com/irisnet","followers_url":"https://api.github.com/users/irisnet/followers","following_url":"https://api.github.com/users/irisnet/following{/other_user}","gists_url":"https://api.github.com/users/irisnet/gists{/gist_id}","starred_url":"https://api.github.com/users/irisnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisnet/subscriptions","organizations_url":"https://api.github.com/users/irisnet/orgs","repos_url":"https://api.github.com/users/irisnet/repos","events_url":"https://api.github.com/users/irisnet/events{/privacy}","received_events_url":"https://api.github.com/users/irisnet/received_events","type":"Organization","site_admin":false},"repo":{"id":124037656,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwMzc2NTY=","name":"irishub","full_name":"irisnet/irishub","owner":{"login":"irisnet","id":33032395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDMyMzk1","avatar_url":"https://avatars0.githubusercontent.com/u/33032395?v=4","gravatar_id":"","url":"https://api.github.com/users/irisnet","html_url":"https://github.com/irisnet","followers_url":"https://api.github.com/users/irisnet/followers","following_url":"https://api.github.com/users/irisnet/following{/other_user}","gists_url":"https://api.github.com/users/irisnet/gists{/gist_id}","starred_url":"https://api.github.com/users/irisnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisnet/subscriptions","organizations_url":"https://api.github.com/users/irisnet/orgs","repos_url":"https://api.github.com/users/irisnet/repos","events_url":"https://api.github.com/users/irisnet/events{/privacy}","received_events_url":"https://api.github.com/users/irisnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/irisnet/irishub","description":"Cosmos regional hub with a built-in Service Infrastructure","fork":false,"url":"https://api.github.com/repos/irisnet/irishub","forks_url":"https://api.github.com/repos/irisnet/irishub/forks","keys_url":"https://api.github.com/repos/irisnet/irishub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irisnet/irishub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irisnet/irishub/teams","hooks_url":"https://api.github.com/repos/irisnet/irishub/hooks","issue_events_url":"https://api.github.com/repos/irisnet/irishub/issues/events{/number}","events_url":"https://api.github.com/repos/irisnet/irishub/events","assignees_url":"https://api.github.com/repos/irisnet/irishub/assignees{/user}","branches_url":"https://api.github.com/repos/irisnet/irishub/branches{/branch}","tags_url":"https://api.github.com/repos/irisnet/irishub/tags","blobs_url":"https://api.github.com/repos/irisnet/irishub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irisnet/irishub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irisnet/irishub/git/refs{/sha}","trees_url":"https://api.github.com/repos/irisnet/irishub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irisnet/irishub/statuses/{sha}","languages_url":"https://api.github.com/repos/irisnet/irishub/languages","stargazers_url":"https://api.github.com/repos/irisnet/irishub/stargazers","contributors_url":"https://api.github.com/repos/irisnet/irishub/contributors","subscribers_url":"https://api.github.com/repos/irisnet/irishub/subscribers","subscription_url":"https://api.github.com/repos/irisnet/irishub/subscription","commits_url":"https://api.github.com/repos/irisnet/irishub/commits{/sha}","git_commits_url":"https://api.github.com/repos/irisnet/irishub/git/commits{/sha}","comments_url":"https://api.github.com/repos/irisnet/irishub/comments{/number}","issue_comment_url":"https://api.github.com/repos/irisnet/irishub/issues/comments{/number}","contents_url":"https://api.github.com/repos/irisnet/irishub/contents/{+path}","compare_url":"https://api.github.com/repos/irisnet/irishub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irisnet/irishub/merges","archive_url":"https://api.github.com/repos/irisnet/irishub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irisnet/irishub/downloads","issues_url":"https://api.github.com/repos/irisnet/irishub/issues{/number}","pulls_url":"https://api.github.com/repos/irisnet/irishub/pulls{/number}","milestones_url":"https://api.github.com/repos/irisnet/irishub/milestones{/number}","notifications_url":"https://api.github.com/repos/irisnet/irishub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irisnet/irishub/labels{/name}","releases_url":"https://api.github.com/repos/irisnet/irishub/releases{/id}","deployments_url":"https://api.github.com/repos/irisnet/irishub/deployments","created_at":"2018-03-06T07:20:56Z","updated_at":"2018-07-24T10:00:52Z","pushed_at":"2018-07-24T14:41:10Z","git_url":"git://github.com/irisnet/irishub.git","ssh_url":"git@github.com:irisnet/irishub.git","clone_url":"https://github.com/irisnet/irishub.git","svn_url":"https://github.com/irisnet/irishub","homepage":"","size":226,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/irisnet/irishub/pulls/46"},"html":{"href":"https://github.com/irisnet/irishub/pull/46"},"issue":{"href":"https://api.github.com/repos/irisnet/irishub/issues/46"},"comments":{"href":"https://api.github.com/repos/irisnet/irishub/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/irisnet/irishub/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/irisnet/irishub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/irisnet/irishub/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/irisnet/irishub/statuses/e79ec37a9682c24c8474f8c3bce20adbfcd71158"}},"author_association":"NONE"}}
{"actor":{"display_login":"wukongcheng"}}