{"action":"created","comment":{"url":"https://api.github.com/repos/babel/babel/pulls/comments/185594712","pull_request_review_id":116976550,"id":185594712,"diff_hunk":"@@ -141,22 +331,31 @@ export default declare((api, options) => {\n           }\n         }\n \n+        // Transform private props before publics.\n+        const privates = [];\n+        const privateInits = [];\n         for (const prop of props) {\n-          const propNode = prop.node;\n-          if (propNode.decorators && propNode.decorators.length > 0) continue;\n+          const inits = [];\n+          privateInits.push(inits);","path":"packages/babel-plugin-proposal-class-properties/src/index.js","position":277,"original_position":277,"commit_id":"7e087e5866d2ba56015a8ca5f9f2c191db093f8b","original_commit_id":"7e087e5866d2ba56015a8ca5f9f2c191db093f8b","user":{"login":"nicolo-ribaudo","id":7000710,"avatar_url":"https://avatars3.githubusercontent.com/u/7000710?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolo-ribaudo","html_url":"https://github.com/nicolo-ribaudo","followers_url":"https://api.github.com/users/nicolo-ribaudo/followers","following_url":"https://api.github.com/users/nicolo-ribaudo/following{/other_user}","gists_url":"https://api.github.com/users/nicolo-ribaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolo-ribaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolo-ribaudo/subscriptions","organizations_url":"https://api.github.com/users/nicolo-ribaudo/orgs","repos_url":"https://api.github.com/users/nicolo-ribaudo/repos","events_url":"https://api.github.com/users/nicolo-ribaudo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolo-ribaudo/received_events","type":"User","site_admin":false},"body":"Nit: this two lines can be moved inside the if statement.\r\n\r\nAlso, why can't these loops be merged?","created_at":"2018-05-02T18:27:50Z","updated_at":"2018-05-02T18:30:18Z","html_url":"https://github.com/babel/babel/pull/7842#discussion_r185594712","pull_request_url":"https://api.github.com/repos/babel/babel/pulls/7842","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/babel/babel/pulls/comments/185594712"},"html":{"href":"https://github.com/babel/babel/pull/7842#discussion_r185594712"},"pull_request":{"href":"https://api.github.com/repos/babel/babel/pulls/7842"}}},"pull_request":{"url":"https://api.github.com/repos/babel/babel/pulls/7842","id":185084460,"html_url":"https://github.com/babel/babel/pull/7842","diff_url":"https://github.com/babel/babel/pull/7842.diff","patch_url":"https://github.com/babel/babel/pull/7842.patch","issue_url":"https://api.github.com/repos/babel/babel/issues/7842","number":7842,"state":"open","locked":false,"title":"Class private properties","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"Supersedes #7555.\r\n\r\nLet's see if we can land it this time.\r\n\r\n/cc @littledan ","created_at":"2018-04-30T22:49:58Z","updated_at":"2018-05-02T18:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9beef83a2c2ae2cbbed47b555a2dc8f808205133","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/babel/babel/pulls/7842/commits","review_comments_url":"https://api.github.com/repos/babel/babel/pulls/7842/comments","review_comment_url":"https://api.github.com/repos/babel/babel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babel/babel/issues/7842/comments","statuses_url":"https://api.github.com/repos/babel/babel/statuses/7e087e5866d2ba56015a8ca5f9f2c191db093f8b","head":{"label":"jridgewell:class-private-properties","ref":"class-private-properties","sha":"7e087e5866d2ba56015a8ca5f9f2c191db093f8b","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":43450298,"name":"babel","full_name":"jridgewell/babel","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/babel","description":"Babel is a compiler for writing next generation JavaScript.","fork":true,"url":"https://api.github.com/repos/jridgewell/babel","forks_url":"https://api.github.com/repos/jridgewell/babel/forks","keys_url":"https://api.github.com/repos/jridgewell/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/babel/teams","hooks_url":"https://api.github.com/repos/jridgewell/babel/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/babel/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/babel/events","assignees_url":"https://api.github.com/repos/jridgewell/babel/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/babel/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/babel/tags","blobs_url":"https://api.github.com/repos/jridgewell/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/babel/languages","stargazers_url":"https://api.github.com/repos/jridgewell/babel/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/babel/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/babel/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/babel/subscription","commits_url":"https://api.github.com/repos/jridgewell/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/babel/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/babel/merges","archive_url":"https://api.github.com/repos/jridgewell/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/babel/downloads","issues_url":"https://api.github.com/repos/jridgewell/babel/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/babel/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/babel/releases{/id}","deployments_url":"https://api.github.com/repos/jridgewell/babel/deployments","created_at":"2015-09-30T18:12:49Z","updated_at":"2018-04-14T17:52:32Z","pushed_at":"2018-04-28T02:50:18Z","git_url":"git://github.com/jridgewell/babel.git","ssh_url":"git@github.com:jridgewell/babel.git","clone_url":"https://github.com/jridgewell/babel.git","svn_url":"https://github.com/jridgewell/babel","homepage":"https://babeljs.io/","size":32564,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"babel:master","ref":"master","sha":"e9d5073af1653187e551eed6eae36685cfe51fab","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars1.githubusercontent.com/u/9637642?v=4","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":24560307,"name":"babel","full_name":"babel/babel","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars1.githubusercontent.com/u/9637642?v=4","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/babel","description":":tropical_fish: Babel is a compiler for writing next generation JavaScript.","fork":false,"url":"https://api.github.com/repos/babel/babel","forks_url":"https://api.github.com/repos/babel/babel/forks","keys_url":"https://api.github.com/repos/babel/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/babel/teams","hooks_url":"https://api.github.com/repos/babel/babel/hooks","issue_events_url":"https://api.github.com/repos/babel/babel/issues/events{/number}","events_url":"https://api.github.com/repos/babel/babel/events","assignees_url":"https://api.github.com/repos/babel/babel/assignees{/user}","branches_url":"https://api.github.com/repos/babel/babel/branches{/branch}","tags_url":"https://api.github.com/repos/babel/babel/tags","blobs_url":"https://api.github.com/repos/babel/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/babel/languages","stargazers_url":"https://api.github.com/repos/babel/babel/stargazers","contributors_url":"https://api.github.com/repos/babel/babel/contributors","subscribers_url":"https://api.github.com/repos/babel/babel/subscribers","subscription_url":"https://api.github.com/repos/babel/babel/subscription","commits_url":"https://api.github.com/repos/babel/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/babel/contents/{+path}","compare_url":"https://api.github.com/repos/babel/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/babel/merges","archive_url":"https://api.github.com/repos/babel/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/babel/downloads","issues_url":"https://api.github.com/repos/babel/babel/issues{/number}","pulls_url":"https://api.github.com/repos/babel/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/babel/labels{/name}","releases_url":"https://api.github.com/repos/babel/babel/releases{/id}","deployments_url":"https://api.github.com/repos/babel/babel/deployments","created_at":"2014-09-28T13:38:23Z","updated_at":"2018-05-02T17:50:12Z","pushed_at":"2018-05-02T18:27:25Z","git_url":"git://github.com/babel/babel.git","ssh_url":"git@github.com:babel/babel.git","clone_url":"https://github.com/babel/babel.git","svn_url":"https://github.com/babel/babel","homepage":"https://babeljs.io/","size":32653,"stargazers_count":27368,"watchers_count":27368,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2669,"mirror_url":null,"archived":false,"open_issues_count":629,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2669,"open_issues":629,"watchers":27368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/babel/babel/pulls/7842"},"html":{"href":"https://github.com/babel/babel/pull/7842"},"issue":{"href":"https://api.github.com/repos/babel/babel/issues/7842"},"comments":{"href":"https://api.github.com/repos/babel/babel/issues/7842/comments"},"review_comments":{"href":"https://api.github.com/repos/babel/babel/pulls/7842/comments"},"review_comment":{"href":"https://api.github.com/repos/babel/babel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babel/babel/pulls/7842/commits"},"statuses":{"href":"https://api.github.com/repos/babel/babel/statuses/7e087e5866d2ba56015a8ca5f9f2c191db093f8b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nicolo-ribaudo"}}