{"action":"closed","number":2485,"pull_request":{"url":"https://api.github.com/repos/servo/webrender/pulls/2485","id":172383128,"html_url":"https://github.com/servo/webrender/pull/2485","diff_url":"https://github.com/servo/webrender/pull/2485.diff","patch_url":"https://github.com/servo/webrender/pull/2485.patch","issue_url":"https://api.github.com/repos/servo/webrender/issues/2485","number":2485,"state":"closed","locked":false,"title":"Synchronously shut the render backend down after reftests and rawtests.","user":{"login":"nical","id":264854,"avatar_url":"https://avatars2.githubusercontent.com/u/264854?v=4","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"body":"To avoid going through the debacle of the infinite render backend loop after the async scene building PR, let's make sure we do get at least a test that checks that the render backend does not spin forever.\r\n\r\nThe first commit rearranges the the condition that breaks out of the render backend loop in a way that is slightly less error prone.\r\n\r\nThe second commit makes sure we wait for the shut down notification to have been propagated to the render notifier before exiting reftests and rawtests.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/webrender/2485)\n<!-- Reviewable:end -->\n","created_at":"2018-03-01T23:26:01Z","updated_at":"2018-03-19T02:01:05Z","closed_at":"2018-03-19T02:01:05Z","merged_at":"2018-03-19T02:01:05Z","merge_commit_sha":"9ac5d39c3e8937a743eb4bac3f504f4437bd820f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/webrender/pulls/2485/commits","review_comments_url":"https://api.github.com/repos/servo/webrender/pulls/2485/comments","review_comment_url":"https://api.github.com/repos/servo/webrender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/webrender/issues/2485/comments","statuses_url":"https://api.github.com/repos/servo/webrender/statuses/9ac5d39c3e8937a743eb4bac3f504f4437bd820f","head":{"label":"nical:sync-shutdown","ref":"sync-shutdown","sha":"9ac5d39c3e8937a743eb4bac3f504f4437bd820f","user":{"login":"nical","id":264854,"avatar_url":"https://avatars2.githubusercontent.com/u/264854?v=4","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"repo":{"id":65930655,"name":"webrender","full_name":"nical/webrender","owner":{"login":"nical","id":264854,"avatar_url":"https://avatars2.githubusercontent.com/u/264854?v=4","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nical/webrender","description":"A very incomplete proof of concept GPU renderer for Servo","fork":true,"url":"https://api.github.com/repos/nical/webrender","forks_url":"https://api.github.com/repos/nical/webrender/forks","keys_url":"https://api.github.com/repos/nical/webrender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nical/webrender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nical/webrender/teams","hooks_url":"https://api.github.com/repos/nical/webrender/hooks","issue_events_url":"https://api.github.com/repos/nical/webrender/issues/events{/number}","events_url":"https://api.github.com/repos/nical/webrender/events","assignees_url":"https://api.github.com/repos/nical/webrender/assignees{/user}","branches_url":"https://api.github.com/repos/nical/webrender/branches{/branch}","tags_url":"https://api.github.com/repos/nical/webrender/tags","blobs_url":"https://api.github.com/repos/nical/webrender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nical/webrender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nical/webrender/git/refs{/sha}","trees_url":"https://api.github.com/repos/nical/webrender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nical/webrender/statuses/{sha}","languages_url":"https://api.github.com/repos/nical/webrender/languages","stargazers_url":"https://api.github.com/repos/nical/webrender/stargazers","contributors_url":"https://api.github.com/repos/nical/webrender/contributors","subscribers_url":"https://api.github.com/repos/nical/webrender/subscribers","subscription_url":"https://api.github.com/repos/nical/webrender/subscription","commits_url":"https://api.github.com/repos/nical/webrender/commits{/sha}","git_commits_url":"https://api.github.com/repos/nical/webrender/git/commits{/sha}","comments_url":"https://api.github.com/repos/nical/webrender/comments{/number}","issue_comment_url":"https://api.github.com/repos/nical/webrender/issues/comments{/number}","contents_url":"https://api.github.com/repos/nical/webrender/contents/{+path}","compare_url":"https://api.github.com/repos/nical/webrender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nical/webrender/merges","archive_url":"https://api.github.com/repos/nical/webrender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nical/webrender/downloads","issues_url":"https://api.github.com/repos/nical/webrender/issues{/number}","pulls_url":"https://api.github.com/repos/nical/webrender/pulls{/number}","milestones_url":"https://api.github.com/repos/nical/webrender/milestones{/number}","notifications_url":"https://api.github.com/repos/nical/webrender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nical/webrender/labels{/name}","releases_url":"https://api.github.com/repos/nical/webrender/releases{/id}","deployments_url":"https://api.github.com/repos/nical/webrender/deployments","created_at":"2016-08-17T18:05:18Z","updated_at":"2016-08-17T18:05:19Z","pushed_at":"2018-03-16T13:29:09Z","git_url":"git://github.com/nical/webrender.git","ssh_url":"git@github.com:nical/webrender.git","clone_url":"https://github.com/nical/webrender.git","svn_url":"https://github.com/nical/webrender","homepage":"https://doc.servo.org/webrender/","size":22907,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"486ee5f3aefb0172c2c5703e19f833e63eb295b9","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":42894575,"name":"webrender","full_name":"servo/webrender","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/webrender","description":"A GPU-based renderer for the web","fork":false,"url":"https://api.github.com/repos/servo/webrender","forks_url":"https://api.github.com/repos/servo/webrender/forks","keys_url":"https://api.github.com/repos/servo/webrender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/webrender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/webrender/teams","hooks_url":"https://api.github.com/repos/servo/webrender/hooks","issue_events_url":"https://api.github.com/repos/servo/webrender/issues/events{/number}","events_url":"https://api.github.com/repos/servo/webrender/events","assignees_url":"https://api.github.com/repos/servo/webrender/assignees{/user}","branches_url":"https://api.github.com/repos/servo/webrender/branches{/branch}","tags_url":"https://api.github.com/repos/servo/webrender/tags","blobs_url":"https://api.github.com/repos/servo/webrender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/webrender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/webrender/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/webrender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/webrender/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/webrender/languages","stargazers_url":"https://api.github.com/repos/servo/webrender/stargazers","contributors_url":"https://api.github.com/repos/servo/webrender/contributors","subscribers_url":"https://api.github.com/repos/servo/webrender/subscribers","subscription_url":"https://api.github.com/repos/servo/webrender/subscription","commits_url":"https://api.github.com/repos/servo/webrender/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/webrender/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/webrender/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/webrender/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/webrender/contents/{+path}","compare_url":"https://api.github.com/repos/servo/webrender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/webrender/merges","archive_url":"https://api.github.com/repos/servo/webrender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/webrender/downloads","issues_url":"https://api.github.com/repos/servo/webrender/issues{/number}","pulls_url":"https://api.github.com/repos/servo/webrender/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/webrender/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/webrender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/webrender/labels{/name}","releases_url":"https://api.github.com/repos/servo/webrender/releases{/id}","deployments_url":"https://api.github.com/repos/servo/webrender/deployments","created_at":"2015-09-21T21:27:30Z","updated_at":"2018-03-19T01:44:34Z","pushed_at":"2018-03-19T02:01:03Z","git_url":"git://github.com/servo/webrender.git","ssh_url":"git@github.com:servo/webrender.git","clone_url":"https://github.com/servo/webrender.git","svn_url":"https://github.com/servo/webrender","homepage":"https://doc.servo.org/webrender/","size":26102,"stargazers_count":1046,"watchers_count":1046,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":158,"open_issues":172,"watchers":1046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/webrender/pulls/2485"},"html":{"href":"https://github.com/servo/webrender/pull/2485"},"issue":{"href":"https://api.github.com/repos/servo/webrender/issues/2485"},"comments":{"href":"https://api.github.com/repos/servo/webrender/issues/2485/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/webrender/pulls/2485/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/webrender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/webrender/pulls/2485/commits"},"statuses":{"href":"https://api.github.com/repos/servo/webrender/statuses/9ac5d39c3e8937a743eb4bac3f504f4437bd820f"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars1.githubusercontent.com/u/4368172?v=4","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":52,"deletions":26,"changed_files":7}}
{"actor":{"display_login":"bors-servo"}}