{"action":"opened","number":2004,"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/2004","id":200405933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDA1OTMz","html_url":"https://github.com/hyperspy/hyperspy/pull/2004","diff_url":"https://github.com/hyperspy/hyperspy/pull/2004.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/2004.patch","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/2004","number":2004,"state":"open","locked":false,"title":"Check microscope parameters only when necessary","user":{"login":"ericpre","id":11851990,"node_id":"MDQ6VXNlcjExODUxOTkw","avatar_url":"https://avatars1.githubusercontent.com/u/11851990?v=4","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"body":"For EELSmodel, it is necessary to check missing microscope parameters only when adding EELSCLEdge to a model or when performing kramers kronig analysis and not when removing background, for example.\r\n\r\n### Progress of the PR\r\n- [x] Move the `_are_microscope_parameters_missing` to where it is actually required,\r\n- [x] add `ignore_parameters` argument to `_are_microscope_parameters_missing`,\r\n- [x] ready for review.\r\n\r\n","created_at":"2018-07-10T13:58:31Z","updated_at":"2018-07-10T13:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/2004/commits","review_comments_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/2004/comments","review_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/2004/comments","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/7aa9bdd6e54e1ed6493d17511fbc2b9fc6f23e03","head":{"label":"ericpre:fix_issue_with_setting_microscope_parameter_EELS","ref":"fix_issue_with_setting_microscope_parameter_EELS","sha":"7aa9bdd6e54e1ed6493d17511fbc2b9fc6f23e03","user":{"login":"ericpre","id":11851990,"node_id":"MDQ6VXNlcjExODUxOTkw","avatar_url":"https://avatars1.githubusercontent.com/u/11851990?v=4","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"repo":{"id":41250647,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI1MDY0Nw==","name":"hyperspy","full_name":"ericpre/hyperspy","owner":{"login":"ericpre","id":11851990,"node_id":"MDQ6VXNlcjExODUxOTkw","avatar_url":"https://avatars1.githubusercontent.com/u/11851990?v=4","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericpre/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/ericpre/hyperspy","forks_url":"https://api.github.com/repos/ericpre/hyperspy/forks","keys_url":"https://api.github.com/repos/ericpre/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericpre/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericpre/hyperspy/teams","hooks_url":"https://api.github.com/repos/ericpre/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/ericpre/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/ericpre/hyperspy/events","assignees_url":"https://api.github.com/repos/ericpre/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/ericpre/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/ericpre/hyperspy/tags","blobs_url":"https://api.github.com/repos/ericpre/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericpre/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericpre/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericpre/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericpre/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/ericpre/hyperspy/languages","stargazers_url":"https://api.github.com/repos/ericpre/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/ericpre/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/ericpre/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/ericpre/hyperspy/subscription","commits_url":"https://api.github.com/repos/ericpre/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericpre/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericpre/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericpre/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericpre/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/ericpre/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericpre/hyperspy/merges","archive_url":"https://api.github.com/repos/ericpre/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericpre/hyperspy/downloads","issues_url":"https://api.github.com/repos/ericpre/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/ericpre/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/ericpre/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/ericpre/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericpre/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/ericpre/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/ericpre/hyperspy/deployments","created_at":"2015-08-23T13:30:33Z","updated_at":"2018-04-19T10:56:09Z","pushed_at":"2018-07-10T10:16:20Z","git_url":"git://github.com/ericpre/hyperspy.git","ssh_url":"git@github.com:ericpre/hyperspy.git","clone_url":"https://github.com/ericpre/hyperspy.git","svn_url":"https://github.com/ericpre/hyperspy","homepage":"http://www.hyperspy.org","size":206144,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"RELEASE_next_minor"}},"base":{"label":"hyperspy:RELEASE_next_patch","ref":"RELEASE_next_patch","sha":"0a4e431956c70201ac209cfc0bafd03e9b42360c","user":{"login":"hyperspy","id":989756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4OTc1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/989756?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"repo":{"id":2233998,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMzOTk4","name":"hyperspy","full_name":"hyperspy/hyperspy","owner":{"login":"hyperspy","id":989756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4OTc1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/989756?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperspy/hyperspy","description":"Multidimensional data analysis","fork":false,"url":"https://api.github.com/repos/hyperspy/hyperspy","forks_url":"https://api.github.com/repos/hyperspy/hyperspy/forks","keys_url":"https://api.github.com/repos/hyperspy/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperspy/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperspy/hyperspy/teams","hooks_url":"https://api.github.com/repos/hyperspy/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/hyperspy/hyperspy/events","assignees_url":"https://api.github.com/repos/hyperspy/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/hyperspy/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/hyperspy/hyperspy/tags","blobs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperspy/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperspy/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperspy/hyperspy/languages","stargazers_url":"https://api.github.com/repos/hyperspy/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/hyperspy/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/hyperspy/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/hyperspy/hyperspy/subscription","commits_url":"https://api.github.com/repos/hyperspy/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperspy/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperspy/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/hyperspy/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperspy/hyperspy/merges","archive_url":"https://api.github.com/repos/hyperspy/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperspy/hyperspy/downloads","issues_url":"https://api.github.com/repos/hyperspy/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperspy/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/hyperspy/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/hyperspy/hyperspy/deployments","created_at":"2011-08-19T13:14:36Z","updated_at":"2018-07-02T09:24:32Z","pushed_at":"2018-07-06T16:21:47Z","git_url":"git://github.com/hyperspy/hyperspy.git","ssh_url":"git@github.com:hyperspy/hyperspy.git","clone_url":"https://github.com/hyperspy/hyperspy.git","svn_url":"https://github.com/hyperspy/hyperspy","homepage":"http://www.hyperspy.org","size":202839,"stargazers_count":140,"watchers_count":140,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":304,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":98,"open_issues":304,"watchers":140,"default_branch":"RELEASE_next_minor"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/2004"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/2004"},"issue":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/2004"},"comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/2004/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/2004/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/2004/commits"},"statuses":{"href":"https://api.github.com/repos/hyperspy/hyperspy/statuses/7aa9bdd6e54e1ed6493d17511fbc2b9fc6f23e03"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":18,"deletions":23,"changed_files":2}}
{"actor":{"display_login":"ericpre"}}