{"action":"created","comment":{"url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/comments/209147712","pull_request_review_id":145104924,"id":209147712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTE0NzcxMg==","diff_hunk":"@@ -0,0 +1,36 @@\n+package com.assemblypayments.spi.model;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+import com.assemblypayments.spi.util.Events;\n+import com.assemblypayments.spi.util.RequestIdHelper;\n+\n+public class SetPosInfoRequest {\n+\n+    public final String version;\n+    public final String vendorId;\n+    public final String libraryLanguage;\n+    public final String libraryVersion;\n+    public final Map<String, String> otherInfo;\n+    \n+    public SetPosInfoRequest(String version, String vendorId, String libraryLanguage, String libraryVersion, Map<String, String> otherInfo) {","path":"client/src/main/java/com/assemblypayments/spi/model/SetPosInfoRequest.java","position":17,"original_position":17,"commit_id":"2905c4c628c7b589cecf658ff9e9072103b31031","original_commit_id":"2905c4c628c7b589cecf658ff9e9072103b31031","user":{"login":"mgouline","id":1960272,"node_id":"MDQ6VXNlcjE5NjAyNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1960272?v=4","gravatar_id":"","url":"https://api.github.com/users/mgouline","html_url":"https://github.com/mgouline","followers_url":"https://api.github.com/users/mgouline/followers","following_url":"https://api.github.com/users/mgouline/following{/other_user}","gists_url":"https://api.github.com/users/mgouline/gists{/gist_id}","starred_url":"https://api.github.com/users/mgouline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgouline/subscriptions","organizations_url":"https://api.github.com/users/mgouline/orgs","repos_url":"https://api.github.com/users/mgouline/repos","events_url":"https://api.github.com/users/mgouline/events{/privacy}","received_events_url":"https://api.github.com/users/mgouline/received_events","type":"User","site_admin":false},"body":"I would recommend either setters for all values or builder pattern.","created_at":"2018-08-10T05:28:49Z","updated_at":"2018-08-10T05:33:11Z","html_url":"https://github.com/AssemblyPayments/spi-client-java/pull/2#discussion_r209147712","pull_request_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/comments/209147712"},"html":{"href":"https://github.com/AssemblyPayments/spi-client-java/pull/2#discussion_r209147712"},"pull_request":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2","id":206882995,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODgyOTk1","html_url":"https://github.com/AssemblyPayments/spi-client-java/pull/2","diff_url":"https://github.com/AssemblyPayments/spi-client-java/pull/2.diff","patch_url":"https://github.com/AssemblyPayments/spi-client-java/pull/2.patch","issue_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/issues/2","number":2,"state":"open","locked":false,"title":"Upgrade 2.3","user":{"login":"metinavci","id":1993928,"node_id":"MDQ6VXNlcjE5OTM5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1993928?v=4","gravatar_id":"","url":"https://api.github.com/users/metinavci","html_url":"https://github.com/metinavci","followers_url":"https://api.github.com/users/metinavci/followers","following_url":"https://api.github.com/users/metinavci/following{/other_user}","gists_url":"https://api.github.com/users/metinavci/gists{/gist_id}","starred_url":"https://api.github.com/users/metinavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metinavci/subscriptions","organizations_url":"https://api.github.com/users/metinavci/orgs","repos_url":"https://api.github.com/users/metinavci/repos","events_url":"https://api.github.com/users/metinavci/events{/privacy}","received_events_url":"https://api.github.com/users/metinavci/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-08T03:29:32Z","updated_at":"2018-08-10T05:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2df4b495756d645d44a250e93cdc9bb98e9957c","assignee":{"login":"metinavci","id":1993928,"node_id":"MDQ6VXNlcjE5OTM5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1993928?v=4","gravatar_id":"","url":"https://api.github.com/users/metinavci","html_url":"https://github.com/metinavci","followers_url":"https://api.github.com/users/metinavci/followers","following_url":"https://api.github.com/users/metinavci/following{/other_user}","gists_url":"https://api.github.com/users/metinavci/gists{/gist_id}","starred_url":"https://api.github.com/users/metinavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metinavci/subscriptions","organizations_url":"https://api.github.com/users/metinavci/orgs","repos_url":"https://api.github.com/users/metinavci/repos","events_url":"https://api.github.com/users/metinavci/events{/privacy}","received_events_url":"https://api.github.com/users/metinavci/received_events","type":"User","site_admin":false},"assignees":[{"login":"metinavci","id":1993928,"node_id":"MDQ6VXNlcjE5OTM5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1993928?v=4","gravatar_id":"","url":"https://api.github.com/users/metinavci","html_url":"https://github.com/metinavci","followers_url":"https://api.github.com/users/metinavci/followers","following_url":"https://api.github.com/users/metinavci/following{/other_user}","gists_url":"https://api.github.com/users/metinavci/gists{/gist_id}","starred_url":"https://api.github.com/users/metinavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metinavci/subscriptions","organizations_url":"https://api.github.com/users/metinavci/orgs","repos_url":"https://api.github.com/users/metinavci/repos","events_url":"https://api.github.com/users/metinavci/events{/privacy}","received_events_url":"https://api.github.com/users/metinavci/received_events","type":"User","site_admin":false},{"login":"RaymondK-AP","id":16125144,"node_id":"MDQ6VXNlcjE2MTI1MTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16125144?v=4","gravatar_id":"","url":"https://api.github.com/users/RaymondK-AP","html_url":"https://github.com/RaymondK-AP","followers_url":"https://api.github.com/users/RaymondK-AP/followers","following_url":"https://api.github.com/users/RaymondK-AP/following{/other_user}","gists_url":"https://api.github.com/users/RaymondK-AP/gists{/gist_id}","starred_url":"https://api.github.com/users/RaymondK-AP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaymondK-AP/subscriptions","organizations_url":"https://api.github.com/users/RaymondK-AP/orgs","repos_url":"https://api.github.com/users/RaymondK-AP/repos","events_url":"https://api.github.com/users/RaymondK-AP/events{/privacy}","received_events_url":"https://api.github.com/users/RaymondK-AP/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":888235303,"node_id":"MDU6TGFiZWw4ODgyMzUzMDM=","url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2/commits","review_comments_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2/comments","review_comment_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/issues/2/comments","statuses_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/statuses/2905c4c628c7b589cecf658ff9e9072103b31031","head":{"label":"metinavci:master","ref":"master","sha":"2905c4c628c7b589cecf658ff9e9072103b31031","user":{"login":"metinavci","id":1993928,"node_id":"MDQ6VXNlcjE5OTM5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1993928?v=4","gravatar_id":"","url":"https://api.github.com/users/metinavci","html_url":"https://github.com/metinavci","followers_url":"https://api.github.com/users/metinavci/followers","following_url":"https://api.github.com/users/metinavci/following{/other_user}","gists_url":"https://api.github.com/users/metinavci/gists{/gist_id}","starred_url":"https://api.github.com/users/metinavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metinavci/subscriptions","organizations_url":"https://api.github.com/users/metinavci/orgs","repos_url":"https://api.github.com/users/metinavci/repos","events_url":"https://api.github.com/users/metinavci/events{/privacy}","received_events_url":"https://api.github.com/users/metinavci/received_events","type":"User","site_admin":false},"repo":{"id":142376054,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNzYwNTQ=","name":"spi-client-java","full_name":"metinavci/spi-client-java","owner":{"login":"metinavci","id":1993928,"node_id":"MDQ6VXNlcjE5OTM5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1993928?v=4","gravatar_id":"","url":"https://api.github.com/users/metinavci","html_url":"https://github.com/metinavci","followers_url":"https://api.github.com/users/metinavci/followers","following_url":"https://api.github.com/users/metinavci/following{/other_user}","gists_url":"https://api.github.com/users/metinavci/gists{/gist_id}","starred_url":"https://api.github.com/users/metinavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metinavci/subscriptions","organizations_url":"https://api.github.com/users/metinavci/orgs","repos_url":"https://api.github.com/users/metinavci/repos","events_url":"https://api.github.com/users/metinavci/events{/privacy}","received_events_url":"https://api.github.com/users/metinavci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/metinavci/spi-client-java","description":"Java client library for Assembly Payments in-store integration.","fork":true,"url":"https://api.github.com/repos/metinavci/spi-client-java","forks_url":"https://api.github.com/repos/metinavci/spi-client-java/forks","keys_url":"https://api.github.com/repos/metinavci/spi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metinavci/spi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metinavci/spi-client-java/teams","hooks_url":"https://api.github.com/repos/metinavci/spi-client-java/hooks","issue_events_url":"https://api.github.com/repos/metinavci/spi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/metinavci/spi-client-java/events","assignees_url":"https://api.github.com/repos/metinavci/spi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/metinavci/spi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/metinavci/spi-client-java/tags","blobs_url":"https://api.github.com/repos/metinavci/spi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metinavci/spi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metinavci/spi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/metinavci/spi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metinavci/spi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/metinavci/spi-client-java/languages","stargazers_url":"https://api.github.com/repos/metinavci/spi-client-java/stargazers","contributors_url":"https://api.github.com/repos/metinavci/spi-client-java/contributors","subscribers_url":"https://api.github.com/repos/metinavci/spi-client-java/subscribers","subscription_url":"https://api.github.com/repos/metinavci/spi-client-java/subscription","commits_url":"https://api.github.com/repos/metinavci/spi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/metinavci/spi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/metinavci/spi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/metinavci/spi-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/metinavci/spi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/metinavci/spi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metinavci/spi-client-java/merges","archive_url":"https://api.github.com/repos/metinavci/spi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metinavci/spi-client-java/downloads","issues_url":"https://api.github.com/repos/metinavci/spi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/metinavci/spi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/metinavci/spi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/metinavci/spi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metinavci/spi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/metinavci/spi-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/metinavci/spi-client-java/deployments","created_at":"2018-07-26T02:11:51Z","updated_at":"2018-08-06T00:01:07Z","pushed_at":"2018-08-06T00:01:06Z","git_url":"git://github.com/metinavci/spi-client-java.git","ssh_url":"git@github.com:metinavci/spi-client-java.git","clone_url":"https://github.com/metinavci/spi-client-java.git","svn_url":"https://github.com/metinavci/spi-client-java","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AssemblyPayments:master","ref":"master","sha":"4c81e94789a4815cb0302a2c826c44cef3a82bbf","user":{"login":"AssemblyPayments","id":12454199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDU0MTk5","avatar_url":"https://avatars0.githubusercontent.com/u/12454199?v=4","gravatar_id":"","url":"https://api.github.com/users/AssemblyPayments","html_url":"https://github.com/AssemblyPayments","followers_url":"https://api.github.com/users/AssemblyPayments/followers","following_url":"https://api.github.com/users/AssemblyPayments/following{/other_user}","gists_url":"https://api.github.com/users/AssemblyPayments/gists{/gist_id}","starred_url":"https://api.github.com/users/AssemblyPayments/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AssemblyPayments/subscriptions","organizations_url":"https://api.github.com/users/AssemblyPayments/orgs","repos_url":"https://api.github.com/users/AssemblyPayments/repos","events_url":"https://api.github.com/users/AssemblyPayments/events{/privacy}","received_events_url":"https://api.github.com/users/AssemblyPayments/received_events","type":"Organization","site_admin":false},"repo":{"id":127853275,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4NTMyNzU=","name":"spi-client-java","full_name":"AssemblyPayments/spi-client-java","owner":{"login":"AssemblyPayments","id":12454199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDU0MTk5","avatar_url":"https://avatars0.githubusercontent.com/u/12454199?v=4","gravatar_id":"","url":"https://api.github.com/users/AssemblyPayments","html_url":"https://github.com/AssemblyPayments","followers_url":"https://api.github.com/users/AssemblyPayments/followers","following_url":"https://api.github.com/users/AssemblyPayments/following{/other_user}","gists_url":"https://api.github.com/users/AssemblyPayments/gists{/gist_id}","starred_url":"https://api.github.com/users/AssemblyPayments/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AssemblyPayments/subscriptions","organizations_url":"https://api.github.com/users/AssemblyPayments/orgs","repos_url":"https://api.github.com/users/AssemblyPayments/repos","events_url":"https://api.github.com/users/AssemblyPayments/events{/privacy}","received_events_url":"https://api.github.com/users/AssemblyPayments/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AssemblyPayments/spi-client-java","description":"Java client library for Assembly Payments in-store integration.","fork":false,"url":"https://api.github.com/repos/AssemblyPayments/spi-client-java","forks_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/forks","keys_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/teams","hooks_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/hooks","issue_events_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/events","assignees_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/tags","blobs_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/languages","stargazers_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/stargazers","contributors_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/contributors","subscribers_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/subscribers","subscription_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/subscription","commits_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/merges","archive_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/downloads","issues_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/AssemblyPayments/spi-client-java/deployments","created_at":"2018-04-03T05:00:59Z","updated_at":"2018-06-19T02:50:13Z","pushed_at":"2018-08-08T03:29:33Z","git_url":"git://github.com/AssemblyPayments/spi-client-java.git","ssh_url":"git@github.com:AssemblyPayments/spi-client-java.git","clone_url":"https://github.com/AssemblyPayments/spi-client-java.git","svn_url":"https://github.com/AssemblyPayments/spi-client-java","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2"},"html":{"href":"https://github.com/AssemblyPayments/spi-client-java/pull/2"},"issue":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/issues/2"},"comments":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/AssemblyPayments/spi-client-java/statuses/2905c4c628c7b589cecf658ff9e9072103b31031"}},"author_association":"NONE"}}
{"actor":{"display_login":"mgouline"}}