{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/216084684","pull_request_review_id":153489020,"id":216084684,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA4NDY4NA==","diff_hunk":"@@ -482,43 +484,37 @@ public void unmount(AlluxioURI path, UnmountOptions options)\n   }\n \n   /**\n-   * Alluxio URIs in the Filesystem don't need a scheme or host. Warn the user and throw an\n+   * Checks an {@link AlluxioURI} for scheme and authority information. Warn the user and throw an\n    * exception if necessary.\n    */\n-  protected static void UriCheck(AlluxioURI uri) {\n-    boolean logWarning = false;\n+  private static void uriCheck(AlluxioURI uri) {\n     if (uri.hasScheme()) {\n-      if (uri.getScheme().compareTo(\"alluxio\") == 0\n-          || uri.getScheme().compareTo(\"alluxio-ft\") == 0) {\n-        logWarning = true;\n+      if (uri.getScheme().equals(Constants.SCHEME) || uri.getScheme().equals(Constants.SCHEME_FT)) {\n+        LOG.warn(String.format(\"The URI schemes \\\"%s\\\" or \\\"%s\\\" are not required in URIs passed to\"\n+            + \" the Alluxio Filesystem client.\", Constants.SCHEME, Constants.SCHEME_FT));\n       } else {\n-        // Throw Exception\n         throw new IllegalArgumentException(\n-            \"Valid scheme values in filesystem URI operations are \\\"alluxio\\\" and \\\"alluxio-ft\\\".\"\n-                + \" Note that the scheme is not required for filesystem operations\");\n+            String.format(\"Scheme %s:// in AlluxioURI is invalid. Valid scheme values in filesystem\"\n+                + \" operations are \\\"alluxio://\\\" or no scheme at all.\", uri.getScheme()));\n       }\n     }\n \n     if (uri.hasAuthority()) {\n-      logWarning = true;\n+      LOG.warn(\"The URI authority (hostname and port) are not required in URIs passed to the \"","path":"core/client/fs/src/main/java/alluxio/client/file/BaseFileSystem.java","position":null,"original_position":174,"commit_id":"e9fd4adcbc7e075d5364f780e3272576a2dd92bd","original_commit_id":"e9fd4adcbc7e075d5364f780e3272576a2dd92bd","user":{"login":"aaudiber","id":3455177,"node_id":"MDQ6VXNlcjM0NTUxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"good to clarify that they will be ignored","created_at":"2018-09-07T20:54:53Z","updated_at":"2018-09-07T20:56:40Z","html_url":"https://github.com/Alluxio/alluxio/pull/7823#discussion_r216084684","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/216084684"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7823#discussion_r216084684"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823","id":213790692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzkwNjky","html_url":"https://github.com/Alluxio/alluxio/pull/7823","diff_url":"https://github.com/Alluxio/alluxio/pull/7823.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/7823.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7823","number":7823,"state":"open","locked":false,"title":"[ALLUXIO-2396] Warn users of unecessary URI information","user":{"login":"ZacBlanco","id":3464508,"node_id":"MDQ6VXNlcjM0NjQ1MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3464508?v=4","gravatar_id":"","url":"https://api.github.com/users/ZacBlanco","html_url":"https://github.com/ZacBlanco","followers_url":"https://api.github.com/users/ZacBlanco/followers","following_url":"https://api.github.com/users/ZacBlanco/following{/other_user}","gists_url":"https://api.github.com/users/ZacBlanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacBlanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacBlanco/subscriptions","organizations_url":"https://api.github.com/users/ZacBlanco/orgs","repos_url":"https://api.github.com/users/ZacBlanco/repos","events_url":"https://api.github.com/users/ZacBlanco/events{/privacy}","received_events_url":"https://api.github.com/users/ZacBlanco/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-2396\r\n\r\n@aaudiber ","created_at":"2018-09-07T01:10:34Z","updated_at":"2018-09-07T20:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7472e8c709fae578619029e63ca2333c14d32daf","assignee":{"login":"gpang","id":429032,"node_id":"MDQ6VXNlcjQyOTAzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/429032?v=4","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false},"assignees":[{"login":"gpang","id":429032,"node_id":"MDQ6VXNlcjQyOTAzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/429032?v=4","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7823/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/e9fd4adcbc7e075d5364f780e3272576a2dd92bd","head":{"label":"ZacBlanco:uriexception","ref":"uriexception","sha":"e9fd4adcbc7e075d5364f780e3272576a2dd92bd","user":{"login":"ZacBlanco","id":3464508,"node_id":"MDQ6VXNlcjM0NjQ1MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3464508?v=4","gravatar_id":"","url":"https://api.github.com/users/ZacBlanco","html_url":"https://github.com/ZacBlanco","followers_url":"https://api.github.com/users/ZacBlanco/followers","following_url":"https://api.github.com/users/ZacBlanco/following{/other_user}","gists_url":"https://api.github.com/users/ZacBlanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacBlanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacBlanco/subscriptions","organizations_url":"https://api.github.com/users/ZacBlanco/orgs","repos_url":"https://api.github.com/users/ZacBlanco/repos","events_url":"https://api.github.com/users/ZacBlanco/events{/privacy}","received_events_url":"https://api.github.com/users/ZacBlanco/received_events","type":"User","site_admin":false},"repo":{"id":147438165,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc0MzgxNjU=","name":"alluxio","full_name":"ZacBlanco/alluxio","owner":{"login":"ZacBlanco","id":3464508,"node_id":"MDQ6VXNlcjM0NjQ1MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3464508?v=4","gravatar_id":"","url":"https://api.github.com/users/ZacBlanco","html_url":"https://github.com/ZacBlanco","followers_url":"https://api.github.com/users/ZacBlanco/followers","following_url":"https://api.github.com/users/ZacBlanco/following{/other_user}","gists_url":"https://api.github.com/users/ZacBlanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacBlanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacBlanco/subscriptions","organizations_url":"https://api.github.com/users/ZacBlanco/orgs","repos_url":"https://api.github.com/users/ZacBlanco/repos","events_url":"https://api.github.com/users/ZacBlanco/events{/privacy}","received_events_url":"https://api.github.com/users/ZacBlanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZacBlanco/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/ZacBlanco/alluxio","forks_url":"https://api.github.com/repos/ZacBlanco/alluxio/forks","keys_url":"https://api.github.com/repos/ZacBlanco/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZacBlanco/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZacBlanco/alluxio/teams","hooks_url":"https://api.github.com/repos/ZacBlanco/alluxio/hooks","issue_events_url":"https://api.github.com/repos/ZacBlanco/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/ZacBlanco/alluxio/events","assignees_url":"https://api.github.com/repos/ZacBlanco/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/ZacBlanco/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/ZacBlanco/alluxio/tags","blobs_url":"https://api.github.com/repos/ZacBlanco/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZacBlanco/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZacBlanco/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZacBlanco/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZacBlanco/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/ZacBlanco/alluxio/languages","stargazers_url":"https://api.github.com/repos/ZacBlanco/alluxio/stargazers","contributors_url":"https://api.github.com/repos/ZacBlanco/alluxio/contributors","subscribers_url":"https://api.github.com/repos/ZacBlanco/alluxio/subscribers","subscription_url":"https://api.github.com/repos/ZacBlanco/alluxio/subscription","commits_url":"https://api.github.com/repos/ZacBlanco/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZacBlanco/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZacBlanco/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZacBlanco/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZacBlanco/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/ZacBlanco/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZacBlanco/alluxio/merges","archive_url":"https://api.github.com/repos/ZacBlanco/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZacBlanco/alluxio/downloads","issues_url":"https://api.github.com/repos/ZacBlanco/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/ZacBlanco/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/ZacBlanco/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/ZacBlanco/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZacBlanco/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/ZacBlanco/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/ZacBlanco/alluxio/deployments","created_at":"2018-09-05T00:47:03Z","updated_at":"2018-09-05T00:47:11Z","pushed_at":"2018-09-07T20:05:15Z","git_url":"git://github.com/ZacBlanco/alluxio.git","ssh_url":"git@github.com:ZacBlanco/alluxio.git","clone_url":"https://github.com/ZacBlanco/alluxio.git","svn_url":"https://github.com/ZacBlanco/alluxio","homepage":"http://www.alluxio.org/","size":91487,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"3e298c52fb5634531cca86437cd85e9ce7cf2a51","user":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc2OTU0","name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-09-07T20:25:28Z","pushed_at":"2018-09-07T20:42:42Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":91480,"stargazers_count":3646,"watchers_count":3646,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1927,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1927,"open_issues":17,"watchers":3646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7823"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7823"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7823/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7823/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/e9fd4adcbc7e075d5364f780e3272576a2dd92bd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aaudiber"}}