{"action":"created","issue":{"url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp/issues/96","repository_url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp","labels_url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp/issues/96/comments","events_url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp/issues/96/events","html_url":"https://github.com/NYPL/MyLibraryNYCApp/pull/96","id":356097686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDczOTkw","number":96,"title":"Send hold cancellation email even if no reason MLN-236","user":{"login":"LucasCioffi","id":1825103,"node_id":"MDQ6VXNlcjE4MjUxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1825103?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasCioffi","html_url":"https://github.com/LucasCioffi","followers_url":"https://api.github.com/users/LucasCioffi/followers","following_url":"https://api.github.com/users/LucasCioffi/following{/other_user}","gists_url":"https://api.github.com/users/LucasCioffi/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasCioffi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasCioffi/subscriptions","organizations_url":"https://api.github.com/users/LucasCioffi/orgs","repos_url":"https://api.github.com/users/LucasCioffi/repos","events_url":"https://api.github.com/users/LucasCioffi/events{/privacy}","received_events_url":"https://api.github.com/users/LucasCioffi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-31T19:23:32Z","updated_at":"2018-09-04T20:27:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp/pulls/96","html_url":"https://github.com/NYPL/MyLibraryNYCApp/pull/96","diff_url":"https://github.com/NYPL/MyLibraryNYCApp/pull/96.diff","patch_url":"https://github.com/NYPL/MyLibraryNYCApp/pull/96.patch"},"body":"Previously, if the user didn't enter a reason for cancellation, they didn't receive an email.  We want the email to be sent in both situations.\r\n\r\nI also added local.rb because emails weren't being sent without this being set: `config.action_mailer.default_url_options = { :host => 'localhost:3000' }` and without that file, it wasn't set.\r\n\r\nI also turned off `send_admin_notification_email` if the user is in a local or development environment.\r\n\r\n# Order & Cancellation Emails\r\n![screen shot 2018-08-31 at 3 20 02 pm](https://user-images.githubusercontent.com/1825103/44932046-cf6f9800-ad31-11e8-8505-c4452256e0dc.png)\r\n\r\n# Cancellation Email\r\n![screen shot 2018-08-31 at 3 20 11 pm](https://user-images.githubusercontent.com/1825103/44932045-cf6f9800-ad31-11e8-8b7b-f3bf9d41a9a0.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp/issues/comments/418506528","html_url":"https://github.com/NYPL/MyLibraryNYCApp/pull/96#issuecomment-418506528","issue_url":"https://api.github.com/repos/NYPL/MyLibraryNYCApp/issues/96","id":418506528,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODUwNjUyOA==","user":{"login":"LucasCioffi","id":1825103,"node_id":"MDQ6VXNlcjE4MjUxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1825103?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasCioffi","html_url":"https://github.com/LucasCioffi","followers_url":"https://api.github.com/users/LucasCioffi/followers","following_url":"https://api.github.com/users/LucasCioffi/following{/other_user}","gists_url":"https://api.github.com/users/LucasCioffi/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasCioffi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasCioffi/subscriptions","organizations_url":"https://api.github.com/users/LucasCioffi/orgs","repos_url":"https://api.github.com/users/LucasCioffi/repos","events_url":"https://api.github.com/users/LucasCioffi/events{/privacy}","received_events_url":"https://api.github.com/users/LucasCioffi/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T20:27:09Z","updated_at":"2018-09-04T20:27:09Z","author_association":"CONTRIBUTOR","body":"@daryanypl @nnat425 any other thoughts prior to approval?"}}
{"actor":{"display_login":"LucasCioffi"}}