{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/38","id":195362672,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzYyNjcy","html_url":"https://github.com/zenorogue/hyperrogue/pull/38","diff_url":"https://github.com/zenorogue/hyperrogue/pull/38.diff","patch_url":"https://github.com/zenorogue/hyperrogue/pull/38.patch","issue_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/38","number":38,"state":"closed","locked":false,"title":"Minor fixes for Mac and MinGW.","user":{"login":"Quuxplusone","id":702021,"node_id":"MDQ6VXNlcjcwMjAyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/702021?v=4","gravatar_id":"","url":"https://api.github.com/users/Quuxplusone","html_url":"https://github.com/Quuxplusone","followers_url":"https://api.github.com/users/Quuxplusone/followers","following_url":"https://api.github.com/users/Quuxplusone/following{/other_user}","gists_url":"https://api.github.com/users/Quuxplusone/gists{/gist_id}","starred_url":"https://api.github.com/users/Quuxplusone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quuxplusone/subscriptions","organizations_url":"https://api.github.com/users/Quuxplusone/orgs","repos_url":"https://api.github.com/users/Quuxplusone/repos","events_url":"https://api.github.com/users/Quuxplusone/events{/privacy}","received_events_url":"https://api.github.com/users/Quuxplusone/received_events","type":"User","site_admin":false},"body":"Eliminate a format-string warning by using less template magic:\r\nhttps://stackoverflow.com/questions/12573968/how-to-use-gccs-printf-format-attribute-with-c11-variadic-templates\r\n\r\nFix one `%Ld` in `rogueviz.cpp` that should have been `%lld`.\r\n\r\nRename `savepng.c` into `savepng.cpp` so that we don't have to care about the system's C compiler; it builds fine using the same C++ options as HyperRogue itself.\r\n\r\nFigure out how to get `-DCAP_PNG` and `-DCAP_ROGUEVIZ` working on Mac, and document them.\r\nAssume that roughly the same things should also work on MinGW.\r\n\r\nConsistency on `STDSIZE`. The one place where Clang still complains even with `-std=c++17 -DSTDSIZE -Wno-sign-compare` is here:\r\n\r\n    ./fieldpattern.cpp:757:51: error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'int' in initializer list\r\n          [-Wc++11-narrowing]\r\n          ex.primes.emplace_back(primeinfo{nextprime, size(fp.matrices) / S7, (bool) fp.wsquare});\r\n                                                      ^~~~~~~~~~~~~~~~~~~~~~\r\n\r\nSo, we fix that up too, in this patch.","created_at":"2018-06-17T05:45:15Z","updated_at":"2018-06-17T16:22:46Z","closed_at":"2018-06-17T16:22:46Z","merged_at":"2018-06-17T16:22:46Z","merge_commit_sha":"dabf322095fe3273c23f5c5d02ad1107d1010205","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/38/commits","review_comments_url":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/38/comments","review_comment_url":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/38/comments","statuses_url":"https://api.github.com/repos/zenorogue/hyperrogue/statuses/b6f47dd907dcbe0bfa5a7b3e1958ac9580c2034d","head":{"label":"Quuxplusone:makefile-fixes","ref":"makefile-fixes","sha":"b6f47dd907dcbe0bfa5a7b3e1958ac9580c2034d","user":{"login":"Quuxplusone","id":702021,"node_id":"MDQ6VXNlcjcwMjAyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/702021?v=4","gravatar_id":"","url":"https://api.github.com/users/Quuxplusone","html_url":"https://github.com/Quuxplusone","followers_url":"https://api.github.com/users/Quuxplusone/followers","following_url":"https://api.github.com/users/Quuxplusone/following{/other_user}","gists_url":"https://api.github.com/users/Quuxplusone/gists{/gist_id}","starred_url":"https://api.github.com/users/Quuxplusone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quuxplusone/subscriptions","organizations_url":"https://api.github.com/users/Quuxplusone/orgs","repos_url":"https://api.github.com/users/Quuxplusone/repos","events_url":"https://api.github.com/users/Quuxplusone/events{/privacy}","received_events_url":"https://api.github.com/users/Quuxplusone/received_events","type":"User","site_admin":false},"repo":{"id":107224354,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyMjQzNTQ=","name":"hyperrogue","full_name":"Quuxplusone/hyperrogue","owner":{"login":"Quuxplusone","id":702021,"node_id":"MDQ6VXNlcjcwMjAyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/702021?v=4","gravatar_id":"","url":"https://api.github.com/users/Quuxplusone","html_url":"https://github.com/Quuxplusone","followers_url":"https://api.github.com/users/Quuxplusone/followers","following_url":"https://api.github.com/users/Quuxplusone/following{/other_user}","gists_url":"https://api.github.com/users/Quuxplusone/gists{/gist_id}","starred_url":"https://api.github.com/users/Quuxplusone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quuxplusone/subscriptions","organizations_url":"https://api.github.com/users/Quuxplusone/orgs","repos_url":"https://api.github.com/users/Quuxplusone/repos","events_url":"https://api.github.com/users/Quuxplusone/events{/privacy}","received_events_url":"https://api.github.com/users/Quuxplusone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quuxplusone/hyperrogue","description":"A SDL roguelike in a non-euclidean world","fork":true,"url":"https://api.github.com/repos/Quuxplusone/hyperrogue","forks_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/forks","keys_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/teams","hooks_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/hooks","issue_events_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/issues/events{/number}","events_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/events","assignees_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/assignees{/user}","branches_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/branches{/branch}","tags_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/tags","blobs_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/statuses/{sha}","languages_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/languages","stargazers_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/stargazers","contributors_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/contributors","subscribers_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/subscribers","subscription_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/subscription","commits_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/contents/{+path}","compare_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/merges","archive_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/downloads","issues_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/issues{/number}","pulls_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/pulls{/number}","milestones_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/milestones{/number}","notifications_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/labels{/name}","releases_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/releases{/id}","deployments_url":"https://api.github.com/repos/Quuxplusone/hyperrogue/deployments","created_at":"2017-10-17T05:59:21Z","updated_at":"2018-06-17T04:57:07Z","pushed_at":"2018-06-17T16:22:21Z","git_url":"git://github.com/Quuxplusone/hyperrogue.git","ssh_url":"git@github.com:Quuxplusone/hyperrogue.git","clone_url":"https://github.com/Quuxplusone/hyperrogue.git","svn_url":"https://github.com/Quuxplusone/hyperrogue","homepage":null,"size":62515,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zenorogue:master","ref":"master","sha":"b2cc825ec9b2142a3d7e40b3e62d252c4ef3f641","user":{"login":"zenorogue","id":13761592,"node_id":"MDQ6VXNlcjEzNzYxNTky","avatar_url":"https://avatars0.githubusercontent.com/u/13761592?v=4","gravatar_id":"","url":"https://api.github.com/users/zenorogue","html_url":"https://github.com/zenorogue","followers_url":"https://api.github.com/users/zenorogue/followers","following_url":"https://api.github.com/users/zenorogue/following{/other_user}","gists_url":"https://api.github.com/users/zenorogue/gists{/gist_id}","starred_url":"https://api.github.com/users/zenorogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenorogue/subscriptions","organizations_url":"https://api.github.com/users/zenorogue/orgs","repos_url":"https://api.github.com/users/zenorogue/repos","events_url":"https://api.github.com/users/zenorogue/events{/privacy}","received_events_url":"https://api.github.com/users/zenorogue/received_events","type":"User","site_admin":false},"repo":{"id":40404373,"node_id":"MDEwOlJlcG9zaXRvcnk0MDQwNDM3Mw==","name":"hyperrogue","full_name":"zenorogue/hyperrogue","owner":{"login":"zenorogue","id":13761592,"node_id":"MDQ6VXNlcjEzNzYxNTky","avatar_url":"https://avatars0.githubusercontent.com/u/13761592?v=4","gravatar_id":"","url":"https://api.github.com/users/zenorogue","html_url":"https://github.com/zenorogue","followers_url":"https://api.github.com/users/zenorogue/followers","following_url":"https://api.github.com/users/zenorogue/following{/other_user}","gists_url":"https://api.github.com/users/zenorogue/gists{/gist_id}","starred_url":"https://api.github.com/users/zenorogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenorogue/subscriptions","organizations_url":"https://api.github.com/users/zenorogue/orgs","repos_url":"https://api.github.com/users/zenorogue/repos","events_url":"https://api.github.com/users/zenorogue/events{/privacy}","received_events_url":"https://api.github.com/users/zenorogue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zenorogue/hyperrogue","description":"A SDL roguelike in a non-euclidean world","fork":false,"url":"https://api.github.com/repos/zenorogue/hyperrogue","forks_url":"https://api.github.com/repos/zenorogue/hyperrogue/forks","keys_url":"https://api.github.com/repos/zenorogue/hyperrogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenorogue/hyperrogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenorogue/hyperrogue/teams","hooks_url":"https://api.github.com/repos/zenorogue/hyperrogue/hooks","issue_events_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/events{/number}","events_url":"https://api.github.com/repos/zenorogue/hyperrogue/events","assignees_url":"https://api.github.com/repos/zenorogue/hyperrogue/assignees{/user}","branches_url":"https://api.github.com/repos/zenorogue/hyperrogue/branches{/branch}","tags_url":"https://api.github.com/repos/zenorogue/hyperrogue/tags","blobs_url":"https://api.github.com/repos/zenorogue/hyperrogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenorogue/hyperrogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenorogue/hyperrogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenorogue/hyperrogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenorogue/hyperrogue/statuses/{sha}","languages_url":"https://api.github.com/repos/zenorogue/hyperrogue/languages","stargazers_url":"https://api.github.com/repos/zenorogue/hyperrogue/stargazers","contributors_url":"https://api.github.com/repos/zenorogue/hyperrogue/contributors","subscribers_url":"https://api.github.com/repos/zenorogue/hyperrogue/subscribers","subscription_url":"https://api.github.com/repos/zenorogue/hyperrogue/subscription","commits_url":"https://api.github.com/repos/zenorogue/hyperrogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenorogue/hyperrogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenorogue/hyperrogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenorogue/hyperrogue/contents/{+path}","compare_url":"https://api.github.com/repos/zenorogue/hyperrogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenorogue/hyperrogue/merges","archive_url":"https://api.github.com/repos/zenorogue/hyperrogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenorogue/hyperrogue/downloads","issues_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues{/number}","pulls_url":"https://api.github.com/repos/zenorogue/hyperrogue/pulls{/number}","milestones_url":"https://api.github.com/repos/zenorogue/hyperrogue/milestones{/number}","notifications_url":"https://api.github.com/repos/zenorogue/hyperrogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenorogue/hyperrogue/labels{/name}","releases_url":"https://api.github.com/repos/zenorogue/hyperrogue/releases{/id}","deployments_url":"https://api.github.com/repos/zenorogue/hyperrogue/deployments","created_at":"2015-08-08T13:53:43Z","updated_at":"2018-06-17T16:18:39Z","pushed_at":"2018-06-17T16:22:46Z","git_url":"git://github.com/zenorogue/hyperrogue.git","ssh_url":"git@github.com:zenorogue/hyperrogue.git","clone_url":"https://github.com/zenorogue/hyperrogue.git","svn_url":"https://github.com/zenorogue/hyperrogue","homepage":null,"size":62573,"stargazers_count":42,"watchers_count":42,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":8,"open_issues":6,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/38"},"html":{"href":"https://github.com/zenorogue/hyperrogue/pull/38"},"issue":{"href":"https://api.github.com/repos/zenorogue/hyperrogue/issues/38"},"comments":{"href":"https://api.github.com/repos/zenorogue/hyperrogue/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/zenorogue/hyperrogue/statuses/b6f47dd907dcbe0bfa5a7b3e1958ac9580c2034d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zenorogue","id":13761592,"node_id":"MDQ6VXNlcjEzNzYxNTky","avatar_url":"https://avatars0.githubusercontent.com/u/13761592?v=4","gravatar_id":"","url":"https://api.github.com/users/zenorogue","html_url":"https://github.com/zenorogue","followers_url":"https://api.github.com/users/zenorogue/followers","following_url":"https://api.github.com/users/zenorogue/following{/other_user}","gists_url":"https://api.github.com/users/zenorogue/gists{/gist_id}","starred_url":"https://api.github.com/users/zenorogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenorogue/subscriptions","organizations_url":"https://api.github.com/users/zenorogue/orgs","repos_url":"https://api.github.com/users/zenorogue/repos","events_url":"https://api.github.com/users/zenorogue/events{/privacy}","received_events_url":"https://api.github.com/users/zenorogue/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":74,"deletions":19,"changed_files":8}}
{"actor":{"display_login":"zenorogue"}}