{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/gitbase/pulls/comments/222251876","pull_request_review_id":161090557,"id":222251876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjI1MTg3Ng==","diff_hunk":"@@ -34,3 +34,10 @@ static-package:\n \tcd build && \\\n \ttar czvf $${PACKAGE_NAME}.tar.gz $${PACKAGE_NAME} && \\\n \tdocker rm gitbase-temp\n+\n+# target used in the Dockerfile to build the static binary\n+static-build: VERSION = $(shell git describe --exact-match --tags 2>/dev/null || dev-$(git rev-parse --short HEAD)$(test -n \"`git status --porcelain`\" && echo \"-dirty\" || true))","path":"Makefile","position":6,"original_position":6,"commit_id":"5386887a2a398eb30118c32548c5e5c97887af1a","original_commit_id":"5386887a2a398eb30118c32548c5e5c97887af1a","user":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"body":"`GO_BUILD_FLAGS`, `LD_FLAGS` and `VERSION` are defined as  recursively-expanded variables so the when you use `+=` you are not adding that value to an already evaluated expression, it expands later.\r\n\r\nsee https://www.gnu.org/software/make/manual/html_node/Appending.html#Appending","created_at":"2018-10-03T10:00:51Z","updated_at":"2018-10-03T10:00:52Z","html_url":"https://github.com/src-d/gitbase/pull/512#discussion_r222251876","pull_request_url":"https://api.github.com/repos/src-d/gitbase/pulls/512","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/comments/222251876"},"html":{"href":"https://github.com/src-d/gitbase/pull/512#discussion_r222251876"},"pull_request":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/512"}},"in_reply_to_id":221961878},"pull_request":{"url":"https://api.github.com/repos/src-d/gitbase/pulls/512","id":219663314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjYzMzE0","html_url":"https://github.com/src-d/gitbase/pull/512","diff_url":"https://github.com/src-d/gitbase/pull/512.diff","patch_url":"https://github.com/src-d/gitbase/pull/512.patch","issue_url":"https://api.github.com/repos/src-d/gitbase/issues/512","number":512,"state":"open","locked":false,"title":"Dockerfile: add gitbase version to the binary","user":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"body":"Closes #508 ","created_at":"2018-10-02T10:59:38Z","updated_at":"2018-10-03T10:00:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffc7abc04d564b3aa3ecbfd2047b488375377f30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/gitbase/pulls/512/commits","review_comments_url":"https://api.github.com/repos/src-d/gitbase/pulls/512/comments","review_comment_url":"https://api.github.com/repos/src-d/gitbase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/gitbase/issues/512/comments","statuses_url":"https://api.github.com/repos/src-d/gitbase/statuses/5386887a2a398eb30118c32548c5e5c97887af1a","head":{"label":"mcarmonaa:fix/add-gitbase-version-to-docker-image","ref":"fix/add-gitbase-version-to-docker-image","sha":"5386887a2a398eb30118c32548c5e5c97887af1a","user":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"repo":{"id":124059996,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwNTk5OTY=","name":"gitbase","full_name":"mcarmonaa/gitbase","private":false,"owner":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mcarmonaa/gitbase","description":"SQL interface to Git repositories, written in Go.","fork":true,"url":"https://api.github.com/repos/mcarmonaa/gitbase","forks_url":"https://api.github.com/repos/mcarmonaa/gitbase/forks","keys_url":"https://api.github.com/repos/mcarmonaa/gitbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcarmonaa/gitbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcarmonaa/gitbase/teams","hooks_url":"https://api.github.com/repos/mcarmonaa/gitbase/hooks","issue_events_url":"https://api.github.com/repos/mcarmonaa/gitbase/issues/events{/number}","events_url":"https://api.github.com/repos/mcarmonaa/gitbase/events","assignees_url":"https://api.github.com/repos/mcarmonaa/gitbase/assignees{/user}","branches_url":"https://api.github.com/repos/mcarmonaa/gitbase/branches{/branch}","tags_url":"https://api.github.com/repos/mcarmonaa/gitbase/tags","blobs_url":"https://api.github.com/repos/mcarmonaa/gitbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcarmonaa/gitbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcarmonaa/gitbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcarmonaa/gitbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcarmonaa/gitbase/statuses/{sha}","languages_url":"https://api.github.com/repos/mcarmonaa/gitbase/languages","stargazers_url":"https://api.github.com/repos/mcarmonaa/gitbase/stargazers","contributors_url":"https://api.github.com/repos/mcarmonaa/gitbase/contributors","subscribers_url":"https://api.github.com/repos/mcarmonaa/gitbase/subscribers","subscription_url":"https://api.github.com/repos/mcarmonaa/gitbase/subscription","commits_url":"https://api.github.com/repos/mcarmonaa/gitbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcarmonaa/gitbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcarmonaa/gitbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcarmonaa/gitbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcarmonaa/gitbase/contents/{+path}","compare_url":"https://api.github.com/repos/mcarmonaa/gitbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcarmonaa/gitbase/merges","archive_url":"https://api.github.com/repos/mcarmonaa/gitbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcarmonaa/gitbase/downloads","issues_url":"https://api.github.com/repos/mcarmonaa/gitbase/issues{/number}","pulls_url":"https://api.github.com/repos/mcarmonaa/gitbase/pulls{/number}","milestones_url":"https://api.github.com/repos/mcarmonaa/gitbase/milestones{/number}","notifications_url":"https://api.github.com/repos/mcarmonaa/gitbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcarmonaa/gitbase/labels{/name}","releases_url":"https://api.github.com/repos/mcarmonaa/gitbase/releases{/id}","deployments_url":"https://api.github.com/repos/mcarmonaa/gitbase/deployments","created_at":"2018-03-06T10:13:59Z","updated_at":"2018-10-02T11:00:17Z","pushed_at":"2018-10-02T14:04:27Z","git_url":"git://github.com/mcarmonaa/gitbase.git","ssh_url":"git@github.com:mcarmonaa/gitbase.git","clone_url":"https://github.com/mcarmonaa/gitbase.git","svn_url":"https://github.com/mcarmonaa/gitbase","homepage":"","size":81018,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"7c35fd32c3a246e71f5b6c06154865df19972f3a","user":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":68594286,"node_id":"MDEwOlJlcG9zaXRvcnk2ODU5NDI4Ng==","name":"gitbase","full_name":"src-d/gitbase","private":false,"owner":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/src-d/gitbase","description":"SQL interface to Git repositories, written in Go. https://docs.sourced.tech/gitbase","fork":false,"url":"https://api.github.com/repos/src-d/gitbase","forks_url":"https://api.github.com/repos/src-d/gitbase/forks","keys_url":"https://api.github.com/repos/src-d/gitbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/gitbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/gitbase/teams","hooks_url":"https://api.github.com/repos/src-d/gitbase/hooks","issue_events_url":"https://api.github.com/repos/src-d/gitbase/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/gitbase/events","assignees_url":"https://api.github.com/repos/src-d/gitbase/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/gitbase/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/gitbase/tags","blobs_url":"https://api.github.com/repos/src-d/gitbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/gitbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/gitbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/gitbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/gitbase/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/gitbase/languages","stargazers_url":"https://api.github.com/repos/src-d/gitbase/stargazers","contributors_url":"https://api.github.com/repos/src-d/gitbase/contributors","subscribers_url":"https://api.github.com/repos/src-d/gitbase/subscribers","subscription_url":"https://api.github.com/repos/src-d/gitbase/subscription","commits_url":"https://api.github.com/repos/src-d/gitbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/gitbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/gitbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/gitbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/gitbase/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/gitbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/gitbase/merges","archive_url":"https://api.github.com/repos/src-d/gitbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/gitbase/downloads","issues_url":"https://api.github.com/repos/src-d/gitbase/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/gitbase/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/gitbase/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/gitbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/gitbase/labels{/name}","releases_url":"https://api.github.com/repos/src-d/gitbase/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/gitbase/deployments","created_at":"2016-09-19T10:14:13Z","updated_at":"2018-10-03T09:56:55Z","pushed_at":"2018-10-03T09:56:53Z","git_url":"git://github.com/src-d/gitbase.git","ssh_url":"git@github.com:src-d/gitbase.git","clone_url":"https://github.com/src-d/gitbase.git","svn_url":"https://github.com/src-d/gitbase","homepage":"","size":81020,"stargazers_count":1189,"watchers_count":1189,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":13,"watchers":1189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/512"},"html":{"href":"https://github.com/src-d/gitbase/pull/512"},"issue":{"href":"https://api.github.com/repos/src-d/gitbase/issues/512"},"comments":{"href":"https://api.github.com/repos/src-d/gitbase/issues/512/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/512/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/512/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/gitbase/statuses/5386887a2a398eb30118c32548c5e5c97887af1a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mcarmonaa"}}