{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/1419","repository_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs","labels_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/1419/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/1419/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/1419/events","html_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/1419","id":326806024,"number":1419,"title":"Remove components if they don't exist anymore during an update","user":{"login":"pietroalbini","id":2299951,"avatar_url":"https://avatars3.githubusercontent.com/u/2299951?v=4","gravatar_id":"","url":"https://api.github.com/users/pietroalbini","html_url":"https://github.com/pietroalbini","followers_url":"https://api.github.com/users/pietroalbini/followers","following_url":"https://api.github.com/users/pietroalbini/following{/other_user}","gists_url":"https://api.github.com/users/pietroalbini/gists{/gist_id}","starred_url":"https://api.github.com/users/pietroalbini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietroalbini/subscriptions","organizations_url":"https://api.github.com/users/pietroalbini/orgs","repos_url":"https://api.github.com/users/pietroalbini/repos","events_url":"https://api.github.com/users/pietroalbini/events{/privacy}","received_events_url":"https://api.github.com/users/pietroalbini/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-27T10:51:07Z","updated_at":"2018-05-27T14:59:17Z","closed_at":"2018-05-27T14:57:06Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/1419","html_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/1419","diff_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/1419.diff","patch_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/1419.patch"},"body":"At the moment, if a new release removes a component from its manifest, the `install` command works fine but the `update` command fails because that component is missing. This is just an hassle for the user, who has to remove the toolchain and reinstall it again.\r\n\r\nThis PR changes the behavior of rustup so that if a component is missing (so it's not in either the `components` or `extensions` list of the `rust` component) a warning is shown to alert the user about this and the component is simply removed. If the component is just marked as `available = false` the old behavior (erroring out) is still used, since that might be caused by a CI failure (if I understand correctly).\r\n\r\nPart of https://github.com/rust-lang/rust/issues/51097.\r\n\r\nr? @Mark-Simulacrum @alexcrichton \r\n\r\n![screenshot from 2018-05-27 12-48-00](https://user-images.githubusercontent.com/2299951/40585059-35bca408-61ac-11e8-8c09-16535e18c763.png)\r\n"},"comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/comments/392337434","html_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/1419#issuecomment-392337434","issue_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/1419","id":392337434,"user":{"login":"pietroalbini","id":2299951,"avatar_url":"https://avatars3.githubusercontent.com/u/2299951?v=4","gravatar_id":"","url":"https://api.github.com/users/pietroalbini","html_url":"https://github.com/pietroalbini","followers_url":"https://api.github.com/users/pietroalbini/followers","following_url":"https://api.github.com/users/pietroalbini/following{/other_user}","gists_url":"https://api.github.com/users/pietroalbini/gists{/gist_id}","starred_url":"https://api.github.com/users/pietroalbini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietroalbini/subscriptions","organizations_url":"https://api.github.com/users/pietroalbini/orgs","repos_url":"https://api.github.com/users/pietroalbini/repos","events_url":"https://api.github.com/users/pietroalbini/events{/privacy}","received_events_url":"https://api.github.com/users/pietroalbini/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T14:59:17Z","updated_at":"2018-05-27T14:59:17Z","author_association":"CONTRIBUTOR","body":"Can we get this released before 1.26.1 (tuesday)?"}}
{"actor":{"display_login":"pietroalbini"}}