{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3317","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3317/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3317/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3317/events","html_url":"https://github.com/ReactiveX/rxjs/pull/3317","id":296931342,"number":3317,"title":"[pending] fix(typings): updated typings to support symbol based observables (ObservableLike<T>) and iterables","user":{"login":"david-driscoll","id":1269157,"avatar_url":"https://avatars0.githubusercontent.com/u/1269157?v=4","gravatar_id":"","url":"https://api.github.com/users/david-driscoll","html_url":"https://github.com/david-driscoll","followers_url":"https://api.github.com/users/david-driscoll/followers","following_url":"https://api.github.com/users/david-driscoll/following{/other_user}","gists_url":"https://api.github.com/users/david-driscoll/gists{/gist_id}","starred_url":"https://api.github.com/users/david-driscoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-driscoll/subscriptions","organizations_url":"https://api.github.com/users/david-driscoll/orgs","repos_url":"https://api.github.com/users/david-driscoll/repos","events_url":"https://api.github.com/users/david-driscoll/events{/privacy}","received_events_url":"https://api.github.com/users/david-driscoll/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-14T00:06:26Z","updated_at":"2018-02-14T00:30:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3317","html_url":"https://github.com/ReactiveX/rxjs/pull/3317","diff_url":"https://github.com/ReactiveX/rxjs/pull/3317.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/3317.patch"},"body":"**Description:**\r\nFollow up to #3265 (merge/rebase after the above is done).  The best commit to compare against is https://github.com/ReactiveX/rxjs/pull/3317/commits/43fdddc03a9459a19a853534686aa10be2133a1b\r\n\r\n* Moved `Subscribable<T>`, `SubscribableOrPromise<T>` and `ObservableInput<T>` to `types.ts`.\r\n* Added `ObservableLike<T>` using `[Symbol.observable]()`\r\n* Added augmentation to make `Symbol.observable` resolve properly.\r\n* `fromObservable` now requires `ObservableLike<T>`\r\n* `of` now creates a type union for the first few overloads of the method.\r\n* `isIterable` now returns `input is Iterable<any>`\r\n* `isObservable` now returns `input is ObservableLike<any>`\r\n* `isPromise` now returns `value is PromiseLike<any>` instead of `Promise<T>`\r\n* Cleaned up tests for the related specs that were touched with this PR\r\n* Added `tsconfig.vscode.json`, this can be used to get errors back in VSCode's problems window\r\n  * NOTE: There are lots of errors for the `spec` folder still.\r\n  * Almost all of the tests have been updated @ https://github.com/david-driscoll/RxJS-1/tree/compiled-tests\r\n* `add/observable/throw` now adds `throwError` to `Observable.prototype` (`throw` cannot be augmented because it's a keyword)\r\n\r\n**Related issue (if exists):**\r\n#3265\r\n"},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/365453676","html_url":"https://github.com/ReactiveX/rxjs/pull/3317#issuecomment-365453676","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3317","id":365453676,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T00:30:12Z","updated_at":"2018-02-14T00:30:12Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/15513899/badge)](https://coveralls.io/builds/15513899)\n\nCoverage increased (+0.06%) to 97.56% when pulling **643bf616b77fe6a3c2316f2defc120e530e42ccd on david-driscoll:fix-typings2** into **92dd3d135d3fcf7fa98526a2ba0493754407a94a on ReactiveX:master**.\n"}}
{"actor":{"display_login":"coveralls"}}