{"action":"created","issue":{"url":"https://api.github.com/repos/WCSim/WCSim/issues/254","repository_url":"https://api.github.com/repos/WCSim/WCSim","labels_url":"https://api.github.com/repos/WCSim/WCSim/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/WCSim/WCSim/issues/254/comments","events_url":"https://api.github.com/repos/WCSim/WCSim/issues/254/events","html_url":"https://github.com/WCSim/WCSim/pull/254","id":379210372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzMxOTQ2","number":254,"title":"Add an equality method for WCSimRootGeom & WCSimRootPMT","user":{"login":"tdealtry","id":11757479,"node_id":"MDQ6VXNlcjExNzU3NDc5","avatar_url":"https://avatars2.githubusercontent.com/u/11757479?v=4","gravatar_id":"","url":"https://api.github.com/users/tdealtry","html_url":"https://github.com/tdealtry","followers_url":"https://api.github.com/users/tdealtry/followers","following_url":"https://api.github.com/users/tdealtry/following{/other_user}","gists_url":"https://api.github.com/users/tdealtry/gists{/gist_id}","starred_url":"https://api.github.com/users/tdealtry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdealtry/subscriptions","organizations_url":"https://api.github.com/users/tdealtry/orgs","repos_url":"https://api.github.com/users/tdealtry/repos","events_url":"https://api.github.com/users/tdealtry/events{/privacy}","received_events_url":"https://api.github.com/users/tdealtry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-09T15:38:20Z","updated_at":"2018-11-23T13:21:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WCSim/WCSim/pulls/254","html_url":"https://github.com/WCSim/WCSim/pull/254","diff_url":"https://github.com/WCSim/WCSim/pull/254.diff","patch_url":"https://github.com/WCSim/WCSim/pull/254.patch"},"body":"In a similar vein to #166 but for geometries"},"comment":{"url":"https://api.github.com/repos/WCSim/WCSim/issues/comments/441239899","html_url":"https://github.com/WCSim/WCSim/pull/254#issuecomment-441239899","issue_url":"https://api.github.com/repos/WCSim/WCSim/issues/254","id":441239899,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTIzOTg5OQ==","user":{"login":"tdealtry","id":11757479,"node_id":"MDQ6VXNlcjExNzU3NDc5","avatar_url":"https://avatars2.githubusercontent.com/u/11757479?v=4","gravatar_id":"","url":"https://api.github.com/users/tdealtry","html_url":"https://github.com/tdealtry","followers_url":"https://api.github.com/users/tdealtry/followers","following_url":"https://api.github.com/users/tdealtry/following{/other_user}","gists_url":"https://api.github.com/users/tdealtry/gists{/gist_id}","starred_url":"https://api.github.com/users/tdealtry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdealtry/subscriptions","organizations_url":"https://api.github.com/users/tdealtry/orgs","repos_url":"https://api.github.com/users/tdealtry/repos","events_url":"https://api.github.com/users/tdealtry/events{/privacy}","received_events_url":"https://api.github.com/users/tdealtry/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T13:21:42Z","updated_at":"2018-11-23T13:21:42Z","author_association":"CONTRIBUTOR","body":"Just a quick explanation here. ComparisonPassed() was defined in the .cc files of both WCSimRootEvent & WCSimRootGeom. This obviously wouldn't compile (same function declared twice). So I moved it into new WCSimRootTools .cc & .hh files\r\n\r\nIn WCSimRootTools there are template versions of the ComparisonPassed() methods. But these are commented out due to them not correctly linking. If anyone can work out how to correctly add them to the LinkDef.h file, then please do! I'll create an issue for it."}}
{"actor":{"display_login":"tdealtry"}}