{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/211086363","pull_request_review_id":147441543,"id":211086363,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA4NjM2Mw==","diff_hunk":"@@ -40,6 +49,8 @@ func SwarmFromGRPC(c swarmapi.Cluster) types.Swarm {\n \t\t\t\tTrustRoot: string(c.RootCA.CACert),\n \t\t\t},\n \t\t\tRootRotationInProgress: c.RootCA.RootRotation != nil,\n+\t\t\tDefaultAddrPool:        defaultAddrPool,\n+\t\t\tSubnetSize:             int(c.SubnetSize),","path":"daemon/cluster/convert/swarm.go","position":28,"original_position":28,"commit_id":"08d6f19ee9b50f1a634cb221f181e94923d3a671","original_commit_id":"08d6f19ee9b50f1a634cb221f181e94923d3a671","user":{"login":"thaJeztah","id":1804568,"node_id":"MDQ6VXNlcjE4MDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Wondering why this value has to be cast to an integer here; `c.SubnetSize` is an `uint32`, but `ClusterInfo.SubnetSize` is an `int`. Why?","created_at":"2018-08-18T21:45:56Z","updated_at":"2018-08-18T21:50:42Z","html_url":"https://github.com/moby/moby/pull/37558#discussion_r211086363","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/37558","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/211086363"},"html":{"href":"https://github.com/moby/moby/pull/37558#discussion_r211086363"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/37558"}}},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/37558","id":204843404,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODQzNDA0","html_url":"https://github.com/moby/moby/pull/37558","diff_url":"https://github.com/moby/moby/pull/37558.diff","patch_url":"https://github.com/moby/moby/pull/37558.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/37558","number":37558,"state":"open","locked":false,"title":"Global Default Address Pool feature support","user":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"body":"This feature allows user to specify list of subnets for global\r\ndefault address pool. User can configure subnet list using\r\n'swarm init' command. Daemon passes the information to swarmkit.\r\nWe validate the information in swarmkit, then store it in cluster\r\nobject. when IPAM init is called, we pass subnet list to IPAM driver.\r\n\r\nSigned-off-by: selansen <elango.siva@docker.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n","created_at":"2018-07-30T15:30:37Z","updated_at":"2018-08-18T21:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4536382682a3a86eb4c8bb0fbad112614eba737c","assignee":{"login":"yongtang","id":6932348,"node_id":"MDQ6VXNlcjY5MzIzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6932348?v=4","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"assignees":[{"login":"yongtang","id":6932348,"node_id":"MDQ6VXNlcjY5MzIzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6932348?v=4","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tianon","id":161631,"node_id":"MDQ6VXNlcjE2MTYzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/161631?v=4","gravatar_id":"","url":"https://api.github.com/users/tianon","html_url":"https://github.com/tianon","followers_url":"https://api.github.com/users/tianon/followers","following_url":"https://api.github.com/users/tianon/following{/other_user}","gists_url":"https://api.github.com/users/tianon/gists{/gist_id}","starred_url":"https://api.github.com/users/tianon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianon/subscriptions","organizations_url":"https://api.github.com/users/tianon/orgs","repos_url":"https://api.github.com/users/tianon/repos","events_url":"https://api.github.com/users/tianon/events{/privacy}","received_events_url":"https://api.github.com/users/tianon/received_events","type":"User","site_admin":false},{"login":"tonistiigi","id":585223,"node_id":"MDQ6VXNlcjU4NTIyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/585223?v=4","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":237472034,"node_id":"MDU6TGFiZWwyMzc0NzIwMzQ=","url":"https://api.github.com/repos/moby/moby/labels/area/networking","name":"area/networking","color":"fbca04","default":false},{"id":237472255,"node_id":"MDU6TGFiZWwyMzc0NzIyNTU=","url":"https://api.github.com/repos/moby/moby/labels/impact/api","name":"impact/api","color":"bfe5bf","default":false},{"id":175375318,"node_id":"MDU6TGFiZWwxNzUzNzUzMTg=","url":"https://api.github.com/repos/moby/moby/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/37558/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/37558/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/37558/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/08d6f19ee9b50f1a634cb221f181e94923d3a671","head":{"label":"selansen:master","ref":"master","sha":"08d6f19ee9b50f1a634cb221f181e94923d3a671","user":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"repo":{"id":112528409,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1Mjg0MDk=","name":"moby","full_name":"selansen/moby","owner":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/selansen/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":true,"url":"https://api.github.com/repos/selansen/moby","forks_url":"https://api.github.com/repos/selansen/moby/forks","keys_url":"https://api.github.com/repos/selansen/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selansen/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selansen/moby/teams","hooks_url":"https://api.github.com/repos/selansen/moby/hooks","issue_events_url":"https://api.github.com/repos/selansen/moby/issues/events{/number}","events_url":"https://api.github.com/repos/selansen/moby/events","assignees_url":"https://api.github.com/repos/selansen/moby/assignees{/user}","branches_url":"https://api.github.com/repos/selansen/moby/branches{/branch}","tags_url":"https://api.github.com/repos/selansen/moby/tags","blobs_url":"https://api.github.com/repos/selansen/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selansen/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selansen/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/selansen/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selansen/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/selansen/moby/languages","stargazers_url":"https://api.github.com/repos/selansen/moby/stargazers","contributors_url":"https://api.github.com/repos/selansen/moby/contributors","subscribers_url":"https://api.github.com/repos/selansen/moby/subscribers","subscription_url":"https://api.github.com/repos/selansen/moby/subscription","commits_url":"https://api.github.com/repos/selansen/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/selansen/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/selansen/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/selansen/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/selansen/moby/contents/{+path}","compare_url":"https://api.github.com/repos/selansen/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selansen/moby/merges","archive_url":"https://api.github.com/repos/selansen/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selansen/moby/downloads","issues_url":"https://api.github.com/repos/selansen/moby/issues{/number}","pulls_url":"https://api.github.com/repos/selansen/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/selansen/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/selansen/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selansen/moby/labels{/name}","releases_url":"https://api.github.com/repos/selansen/moby/releases{/id}","deployments_url":"https://api.github.com/repos/selansen/moby/deployments","created_at":"2017-11-29T21:13:12Z","updated_at":"2018-08-18T04:41:15Z","pushed_at":"2018-08-18T04:41:01Z","git_url":"git://github.com/selansen/moby.git","ssh_url":"git@github.com:selansen/moby.git","clone_url":"https://github.com/selansen/moby.git","svn_url":"https://github.com/selansen/moby","homepage":"https://mobyproject.org/","size":137683,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"896d1b1c61a48e2df1a7b4644ddde6ee97db6111","user":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"node_id":"MDEwOlJlcG9zaXRvcnk3NjkxNjMx","name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-08-18T21:23:20Z","pushed_at":"2018-08-18T21:22:42Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":137672,"stargazers_count":49998,"watchers_count":49998,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14577,"mirror_url":null,"archived":false,"open_issues_count":3314,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14577,"open_issues":3314,"watchers":49998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/37558"},"html":{"href":"https://github.com/moby/moby/pull/37558"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/37558"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/37558/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/37558/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/37558/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/08d6f19ee9b50f1a634cb221f181e94923d3a671"}},"author_association":"NONE"}}
{"actor":{"display_login":"thaJeztah"}}