{"action":"created","comment":{"url":"https://api.github.com/repos/cupy/cupy/pulls/comments/208097882","pull_request_review_id":143839154,"id":208097882,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODA5Nzg4Mg==","diff_hunk":"@@ -2118,6 +2126,63 @@ cdef _argmax = create_reduction_func(\n     None, _min_max_preamble)\n \n \n+cdef _round_preamble = '''\n+template<typename T> __device__ T pow10(long long n){\n+  T x = 1, a = 10;\n+  while (n) {\n+    if (n & 1) x *= a;\n+    a *= a;\n+    n >>= 1;\n+  }\n+  return x;\n+};\n+'''\n+\n+\n+cdef _round_float = '''\n+if (in1 == 0) {\n+    out0 = round(in0);\n+} else {\n+    double x = pow10<double>(abs(in1));","path":"cupy/core/core.pyx","position":38,"original_position":38,"commit_id":"3728a97c22d4680bf032b0677d635c839bb77d1f","original_commit_id":"3728a97c22d4680bf032b0677d635c839bb77d1f","user":{"login":"asi1024","id":5086403,"node_id":"MDQ6VXNlcjUwODY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5086403?v=4","gravatar_id":"","url":"https://api.github.com/users/asi1024","html_url":"https://github.com/asi1024","followers_url":"https://api.github.com/users/asi1024/followers","following_url":"https://api.github.com/users/asi1024/following{/other_user}","gists_url":"https://api.github.com/users/asi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/asi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi1024/subscriptions","organizations_url":"https://api.github.com/users/asi1024/orgs","repos_url":"https://api.github.com/users/asi1024/repos","events_url":"https://api.github.com/users/asi1024/events{/privacy}","received_events_url":"https://api.github.com/users/asi1024/received_events","type":"User","site_admin":false},"body":"Should not calculate this in the loop body.","created_at":"2018-08-07T04:49:15Z","updated_at":"2018-08-07T04:49:32Z","html_url":"https://github.com/cupy/cupy/pull/1499#discussion_r208097882","pull_request_url":"https://api.github.com/repos/cupy/cupy/pulls/1499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cupy/cupy/pulls/comments/208097882"},"html":{"href":"https://github.com/cupy/cupy/pull/1499#discussion_r208097882"},"pull_request":{"href":"https://api.github.com/repos/cupy/cupy/pulls/1499"}}},"pull_request":{"url":"https://api.github.com/repos/cupy/cupy/pulls/1499","id":204648244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjQ4MjQ0","html_url":"https://github.com/cupy/cupy/pull/1499","diff_url":"https://github.com/cupy/cupy/pull/1499.diff","patch_url":"https://github.com/cupy/cupy/pull/1499.patch","issue_url":"https://api.github.com/repos/cupy/cupy/issues/1499","number":1499,"state":"open","locked":false,"title":"Implement round function","user":{"login":"okuta","id":7133388,"node_id":"MDQ6VXNlcjcxMzMzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/7133388?v=4","gravatar_id":"","url":"https://api.github.com/users/okuta","html_url":"https://github.com/okuta","followers_url":"https://api.github.com/users/okuta/followers","following_url":"https://api.github.com/users/okuta/following{/other_user}","gists_url":"https://api.github.com/users/okuta/gists{/gist_id}","starred_url":"https://api.github.com/users/okuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okuta/subscriptions","organizations_url":"https://api.github.com/users/okuta/orgs","repos_url":"https://api.github.com/users/okuta/repos","events_url":"https://api.github.com/users/okuta/events{/privacy}","received_events_url":"https://api.github.com/users/okuta/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-29T15:45:28Z","updated_at":"2018-08-07T04:49:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42f606e395b4d42bb2a2f7ce9832eb335d7972ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":545923268,"node_id":"MDU6TGFiZWw1NDU5MjMyNjg=","url":"https://api.github.com/repos/cupy/cupy/labels/feature","name":"feature","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cupy/cupy/pulls/1499/commits","review_comments_url":"https://api.github.com/repos/cupy/cupy/pulls/1499/comments","review_comment_url":"https://api.github.com/repos/cupy/cupy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cupy/cupy/issues/1499/comments","statuses_url":"https://api.github.com/repos/cupy/cupy/statuses/3728a97c22d4680bf032b0677d635c839bb77d1f","head":{"label":"okuta:impl-round","ref":"impl-round","sha":"3728a97c22d4680bf032b0677d635c839bb77d1f","user":{"login":"okuta","id":7133388,"node_id":"MDQ6VXNlcjcxMzMzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/7133388?v=4","gravatar_id":"","url":"https://api.github.com/users/okuta","html_url":"https://github.com/okuta","followers_url":"https://api.github.com/users/okuta/followers","following_url":"https://api.github.com/users/okuta/following{/other_user}","gists_url":"https://api.github.com/users/okuta/gists{/gist_id}","starred_url":"https://api.github.com/users/okuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okuta/subscriptions","organizations_url":"https://api.github.com/users/okuta/orgs","repos_url":"https://api.github.com/users/okuta/repos","events_url":"https://api.github.com/users/okuta/events{/privacy}","received_events_url":"https://api.github.com/users/okuta/received_events","type":"User","site_admin":false},"repo":{"id":92201297,"node_id":"MDEwOlJlcG9zaXRvcnk5MjIwMTI5Nw==","name":"cupy","full_name":"okuta/cupy","owner":{"login":"okuta","id":7133388,"node_id":"MDQ6VXNlcjcxMzMzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/7133388?v=4","gravatar_id":"","url":"https://api.github.com/users/okuta","html_url":"https://github.com/okuta","followers_url":"https://api.github.com/users/okuta/followers","following_url":"https://api.github.com/users/okuta/following{/other_user}","gists_url":"https://api.github.com/users/okuta/gists{/gist_id}","starred_url":"https://api.github.com/users/okuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okuta/subscriptions","organizations_url":"https://api.github.com/users/okuta/orgs","repos_url":"https://api.github.com/users/okuta/repos","events_url":"https://api.github.com/users/okuta/events{/privacy}","received_events_url":"https://api.github.com/users/okuta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/okuta/cupy","description":"NumPy-like API accelerated with CUDA","fork":true,"url":"https://api.github.com/repos/okuta/cupy","forks_url":"https://api.github.com/repos/okuta/cupy/forks","keys_url":"https://api.github.com/repos/okuta/cupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okuta/cupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okuta/cupy/teams","hooks_url":"https://api.github.com/repos/okuta/cupy/hooks","issue_events_url":"https://api.github.com/repos/okuta/cupy/issues/events{/number}","events_url":"https://api.github.com/repos/okuta/cupy/events","assignees_url":"https://api.github.com/repos/okuta/cupy/assignees{/user}","branches_url":"https://api.github.com/repos/okuta/cupy/branches{/branch}","tags_url":"https://api.github.com/repos/okuta/cupy/tags","blobs_url":"https://api.github.com/repos/okuta/cupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okuta/cupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okuta/cupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/okuta/cupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okuta/cupy/statuses/{sha}","languages_url":"https://api.github.com/repos/okuta/cupy/languages","stargazers_url":"https://api.github.com/repos/okuta/cupy/stargazers","contributors_url":"https://api.github.com/repos/okuta/cupy/contributors","subscribers_url":"https://api.github.com/repos/okuta/cupy/subscribers","subscription_url":"https://api.github.com/repos/okuta/cupy/subscription","commits_url":"https://api.github.com/repos/okuta/cupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/okuta/cupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/okuta/cupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/okuta/cupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/okuta/cupy/contents/{+path}","compare_url":"https://api.github.com/repos/okuta/cupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okuta/cupy/merges","archive_url":"https://api.github.com/repos/okuta/cupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okuta/cupy/downloads","issues_url":"https://api.github.com/repos/okuta/cupy/issues{/number}","pulls_url":"https://api.github.com/repos/okuta/cupy/pulls{/number}","milestones_url":"https://api.github.com/repos/okuta/cupy/milestones{/number}","notifications_url":"https://api.github.com/repos/okuta/cupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okuta/cupy/labels{/name}","releases_url":"https://api.github.com/repos/okuta/cupy/releases{/id}","deployments_url":"https://api.github.com/repos/okuta/cupy/deployments","created_at":"2017-05-23T17:33:17Z","updated_at":"2018-07-22T07:12:39Z","pushed_at":"2018-08-06T08:50:45Z","git_url":"git://github.com/okuta/cupy.git","ssh_url":"git@github.com:okuta/cupy.git","clone_url":"https://github.com/okuta/cupy.git","svn_url":"https://github.com/okuta/cupy","homepage":null,"size":14961,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cupy:master","ref":"master","sha":"f94c699831b16afad273aa3ecfe302147a8984e6","user":{"login":"cupy","id":23187665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTg3NjY1","avatar_url":"https://avatars2.githubusercontent.com/u/23187665?v=4","gravatar_id":"","url":"https://api.github.com/users/cupy","html_url":"https://github.com/cupy","followers_url":"https://api.github.com/users/cupy/followers","following_url":"https://api.github.com/users/cupy/following{/other_user}","gists_url":"https://api.github.com/users/cupy/gists{/gist_id}","starred_url":"https://api.github.com/users/cupy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupy/subscriptions","organizations_url":"https://api.github.com/users/cupy/orgs","repos_url":"https://api.github.com/users/cupy/repos","events_url":"https://api.github.com/users/cupy/events{/privacy}","received_events_url":"https://api.github.com/users/cupy/received_events","type":"Organization","site_admin":false},"repo":{"id":72523920,"node_id":"MDEwOlJlcG9zaXRvcnk3MjUyMzkyMA==","name":"cupy","full_name":"cupy/cupy","owner":{"login":"cupy","id":23187665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTg3NjY1","avatar_url":"https://avatars2.githubusercontent.com/u/23187665?v=4","gravatar_id":"","url":"https://api.github.com/users/cupy","html_url":"https://github.com/cupy","followers_url":"https://api.github.com/users/cupy/followers","following_url":"https://api.github.com/users/cupy/following{/other_user}","gists_url":"https://api.github.com/users/cupy/gists{/gist_id}","starred_url":"https://api.github.com/users/cupy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupy/subscriptions","organizations_url":"https://api.github.com/users/cupy/orgs","repos_url":"https://api.github.com/users/cupy/repos","events_url":"https://api.github.com/users/cupy/events{/privacy}","received_events_url":"https://api.github.com/users/cupy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cupy/cupy","description":"NumPy-like API accelerated with CUDA","fork":false,"url":"https://api.github.com/repos/cupy/cupy","forks_url":"https://api.github.com/repos/cupy/cupy/forks","keys_url":"https://api.github.com/repos/cupy/cupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cupy/cupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cupy/cupy/teams","hooks_url":"https://api.github.com/repos/cupy/cupy/hooks","issue_events_url":"https://api.github.com/repos/cupy/cupy/issues/events{/number}","events_url":"https://api.github.com/repos/cupy/cupy/events","assignees_url":"https://api.github.com/repos/cupy/cupy/assignees{/user}","branches_url":"https://api.github.com/repos/cupy/cupy/branches{/branch}","tags_url":"https://api.github.com/repos/cupy/cupy/tags","blobs_url":"https://api.github.com/repos/cupy/cupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cupy/cupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cupy/cupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cupy/cupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cupy/cupy/statuses/{sha}","languages_url":"https://api.github.com/repos/cupy/cupy/languages","stargazers_url":"https://api.github.com/repos/cupy/cupy/stargazers","contributors_url":"https://api.github.com/repos/cupy/cupy/contributors","subscribers_url":"https://api.github.com/repos/cupy/cupy/subscribers","subscription_url":"https://api.github.com/repos/cupy/cupy/subscription","commits_url":"https://api.github.com/repos/cupy/cupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cupy/cupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cupy/cupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cupy/cupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cupy/cupy/contents/{+path}","compare_url":"https://api.github.com/repos/cupy/cupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cupy/cupy/merges","archive_url":"https://api.github.com/repos/cupy/cupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cupy/cupy/downloads","issues_url":"https://api.github.com/repos/cupy/cupy/issues{/number}","pulls_url":"https://api.github.com/repos/cupy/cupy/pulls{/number}","milestones_url":"https://api.github.com/repos/cupy/cupy/milestones{/number}","notifications_url":"https://api.github.com/repos/cupy/cupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cupy/cupy/labels{/name}","releases_url":"https://api.github.com/repos/cupy/cupy/releases{/id}","deployments_url":"https://api.github.com/repos/cupy/cupy/deployments","created_at":"2016-11-01T09:54:45Z","updated_at":"2018-08-07T04:46:47Z","pushed_at":"2018-08-06T09:27:15Z","git_url":"git://github.com/cupy/cupy.git","ssh_url":"git@github.com:cupy/cupy.git","clone_url":"https://github.com/cupy/cupy.git","svn_url":"https://github.com/cupy/cupy","homepage":"https://cupy.chainer.org","size":14947,"stargazers_count":1981,"watchers_count":1981,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":170,"open_issues":182,"watchers":1981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cupy/cupy/pulls/1499"},"html":{"href":"https://github.com/cupy/cupy/pull/1499"},"issue":{"href":"https://api.github.com/repos/cupy/cupy/issues/1499"},"comments":{"href":"https://api.github.com/repos/cupy/cupy/issues/1499/comments"},"review_comments":{"href":"https://api.github.com/repos/cupy/cupy/pulls/1499/comments"},"review_comment":{"href":"https://api.github.com/repos/cupy/cupy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cupy/cupy/pulls/1499/commits"},"statuses":{"href":"https://api.github.com/repos/cupy/cupy/statuses/3728a97c22d4680bf032b0677d635c839bb77d1f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"asi1024"}}