{"action":"created","comment":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments/221814286","pull_request_review_id":160553642,"id":221814286,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTgxNDI4Ng==","diff_hunk":"@@ -18,9 +17,10 @@ contract('TokenVesting', function ([_, owner, beneficiary]) {\n   const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000';\n \n   beforeEach(async function () {\n-    this.start = (await latestTime()) + duration.minutes(1); // +1 minute so it starts after contract instantiation\n-    this.cliffDuration = duration.years(1);\n-    this.duration = duration.years(2);\n+    // +1 minute so it starts after contract instantiation","path":"test/token/ERC20/TokenVesting.test.js","position":16,"original_position":16,"commit_id":"3214f858c85276efe64156a184691761e3f2080b","original_commit_id":"3214f858c85276efe64156a184691761e3f2080b","user":{"login":"frangio","id":481465,"node_id":"MDQ6VXNlcjQ4MTQ2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/481465?v=4","gravatar_id":"","url":"https://api.github.com/users/frangio","html_url":"https://github.com/frangio","followers_url":"https://api.github.com/users/frangio/followers","following_url":"https://api.github.com/users/frangio/following{/other_user}","gists_url":"https://api.github.com/users/frangio/gists{/gist_id}","starred_url":"https://api.github.com/users/frangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frangio/subscriptions","organizations_url":"https://api.github.com/users/frangio/orgs","repos_url":"https://api.github.com/users/frangio/repos","events_url":"https://api.github.com/users/frangio/events{/privacy}","received_events_url":"https://api.github.com/users/frangio/received_events","type":"User","site_admin":false},"body":"Also thinking about how we can make the whole time testing work on an actual node at some point... Perhaps the more robust thing would be to have a mock of a timestamp `ts` for which `ts.greaterThan(now)` is always true.","created_at":"2018-10-02T03:00:42Z","updated_at":"2018-10-02T03:00:42Z","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1364#discussion_r221814286","pull_request_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments/221814286"},"html":{"href":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1364#discussion_r221814286"},"pull_request":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364"}},"in_reply_to_id":221813644},"pull_request":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364","id":218953972,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTUzOTcy","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1364","diff_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1364.diff","patch_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1364.patch","issue_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1364","number":1364,"state":"open","locked":false,"title":"Merged latestTime, increaseTime and duration into a single time helper.","user":{"login":"nventuro","id":2530770,"node_id":"MDQ6VXNlcjI1MzA3NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2530770?v=4","gravatar_id":"","url":"https://api.github.com/users/nventuro","html_url":"https://github.com/nventuro","followers_url":"https://api.github.com/users/nventuro/followers","following_url":"https://api.github.com/users/nventuro/following{/other_user}","gists_url":"https://api.github.com/users/nventuro/gists{/gist_id}","starred_url":"https://api.github.com/users/nventuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventuro/subscriptions","organizations_url":"https://api.github.com/users/nventuro/orgs","repos_url":"https://api.github.com/users/nventuro/repos","events_url":"https://api.github.com/users/nventuro/events{/privacy}","received_events_url":"https://api.github.com/users/nventuro/received_events","type":"User","site_admin":false},"body":"Could be considered part of #1362.","created_at":"2018-09-28T12:37:18Z","updated_at":"2018-10-02T03:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2071b7fc5a03330c7a8298925ae36dad697167a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1000188800,"node_id":"MDU6TGFiZWwxMDAwMTg4ODAw","url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/labels/area:tests","name":"area:tests","color":"1d76db","default":false},{"id":1000230196,"node_id":"MDU6TGFiZWwxMDAwMjMwMTk2","url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/labels/breaking%20change","name":"breaking change","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/milestones/4","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/milestone/4","labels_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/milestones/4/labels","id":3563304,"node_id":"MDk6TWlsZXN0b25lMzU2MzMwNA==","number":4,"title":"v2.1","description":"Bundling of test suite (incl. suite improvements, testing of the suite, testing guide)","creator":{"login":"frangio","id":481465,"node_id":"MDQ6VXNlcjQ4MTQ2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/481465?v=4","gravatar_id":"","url":"https://api.github.com/users/frangio","html_url":"https://github.com/frangio","followers_url":"https://api.github.com/users/frangio/followers","following_url":"https://api.github.com/users/frangio/following{/other_user}","gists_url":"https://api.github.com/users/frangio/gists{/gist_id}","starred_url":"https://api.github.com/users/frangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frangio/subscriptions","organizations_url":"https://api.github.com/users/frangio/orgs","repos_url":"https://api.github.com/users/frangio/repos","events_url":"https://api.github.com/users/frangio/events{/privacy}","received_events_url":"https://api.github.com/users/frangio/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":14,"state":"open","created_at":"2018-08-12T19:24:59Z","updated_at":"2018-10-01T15:23:48Z","due_on":"2018-11-26T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364/commits","review_comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364/comments","review_comment_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1364/comments","statuses_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/statuses/3214f858c85276efe64156a184691761e3f2080b","head":{"label":"nventuro:time-helper","ref":"time-helper","sha":"3214f858c85276efe64156a184691761e3f2080b","user":{"login":"nventuro","id":2530770,"node_id":"MDQ6VXNlcjI1MzA3NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2530770?v=4","gravatar_id":"","url":"https://api.github.com/users/nventuro","html_url":"https://github.com/nventuro","followers_url":"https://api.github.com/users/nventuro/followers","following_url":"https://api.github.com/users/nventuro/following{/other_user}","gists_url":"https://api.github.com/users/nventuro/gists{/gist_id}","starred_url":"https://api.github.com/users/nventuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventuro/subscriptions","organizations_url":"https://api.github.com/users/nventuro/orgs","repos_url":"https://api.github.com/users/nventuro/repos","events_url":"https://api.github.com/users/nventuro/events{/privacy}","received_events_url":"https://api.github.com/users/nventuro/received_events","type":"User","site_admin":false},"repo":{"id":133691319,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM2OTEzMTk=","name":"openzeppelin-solidity","full_name":"nventuro/openzeppelin-solidity","private":false,"owner":{"login":"nventuro","id":2530770,"node_id":"MDQ6VXNlcjI1MzA3NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2530770?v=4","gravatar_id":"","url":"https://api.github.com/users/nventuro","html_url":"https://github.com/nventuro","followers_url":"https://api.github.com/users/nventuro/followers","following_url":"https://api.github.com/users/nventuro/following{/other_user}","gists_url":"https://api.github.com/users/nventuro/gists{/gist_id}","starred_url":"https://api.github.com/users/nventuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventuro/subscriptions","organizations_url":"https://api.github.com/users/nventuro/orgs","repos_url":"https://api.github.com/users/nventuro/repos","events_url":"https://api.github.com/users/nventuro/events{/privacy}","received_events_url":"https://api.github.com/users/nventuro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nventuro/openzeppelin-solidity","description":"OpenZeppelin, a framework to build secure smart contracts on Ethereum","fork":true,"url":"https://api.github.com/repos/nventuro/openzeppelin-solidity","forks_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/forks","keys_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/teams","hooks_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/hooks","issue_events_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/issues/events{/number}","events_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/events","assignees_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/assignees{/user}","branches_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/branches{/branch}","tags_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/tags","blobs_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/languages","stargazers_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/stargazers","contributors_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/contributors","subscribers_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/subscribers","subscription_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/subscription","commits_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/contents/{+path}","compare_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/merges","archive_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/downloads","issues_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/issues{/number}","pulls_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/labels{/name}","releases_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/releases{/id}","deployments_url":"https://api.github.com/repos/nventuro/openzeppelin-solidity/deployments","created_at":"2018-05-16T16:01:49Z","updated_at":"2018-10-01T10:35:41Z","pushed_at":"2018-10-02T02:43:15Z","git_url":"git://github.com/nventuro/openzeppelin-solidity.git","ssh_url":"git@github.com:nventuro/openzeppelin-solidity.git","clone_url":"https://github.com/nventuro/openzeppelin-solidity.git","svn_url":"https://github.com/nventuro/openzeppelin-solidity","homepage":"https://openzeppelin.org","size":2424,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenZeppelin:master","ref":"master","sha":"1a4e5346ed40e5c02f5ca75d3cdfccb694c641d9","user":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"repo":{"id":64700934,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcwMDkzNA==","name":"openzeppelin-solidity","full_name":"OpenZeppelin/openzeppelin-solidity","private":false,"owner":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity","description":"OpenZeppelin is a library for secure smart contract development","fork":false,"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity","forks_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/forks","keys_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/teams","hooks_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/hooks","issue_events_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/events{/number}","events_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/events","assignees_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/assignees{/user}","branches_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/branches{/branch}","tags_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/tags","blobs_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/languages","stargazers_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/stargazers","contributors_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/contributors","subscribers_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/subscribers","subscription_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/subscription","commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/contents/{+path}","compare_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/merges","archive_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/downloads","issues_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues{/number}","pulls_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/labels{/name}","releases_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/releases{/id}","deployments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/deployments","created_at":"2016-08-01T20:54:54Z","updated_at":"2018-10-01T21:23:43Z","pushed_at":"2018-10-02T02:43:18Z","git_url":"git://github.com/OpenZeppelin/openzeppelin-solidity.git","ssh_url":"git@github.com:OpenZeppelin/openzeppelin-solidity.git","clone_url":"https://github.com/OpenZeppelin/openzeppelin-solidity.git","svn_url":"https://github.com/OpenZeppelin/openzeppelin-solidity","homepage":"https://openzeppelin.org","size":2422,"stargazers_count":6057,"watchers_count":6057,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2116,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2116,"open_issues":179,"watchers":6057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364"},"html":{"href":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1364"},"issue":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1364"},"comments":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1364/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1364/commits"},"statuses":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/statuses/3214f858c85276efe64156a184691761e3f2080b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"frangio"}}