{"action":"created","comment":{"url":"https://api.github.com/repos/ilastik/ilastik/pulls/comments/229357374","pull_request_review_id":169828172,"id":229357374,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTM1NzM3NA==","diff_hunk":"@@ -29,14 +29,15 @@ def export(self, filename, hypothesesGraph, *, labelImageSlot, **kwargs):\n \n         :param filename: string of the FILE where to save the result (different .xml files were)\n         :param hypothesesGraph: hytra.core.hypothesesgraph.HypothesesGraph filled with a solution\n-        :param labelImageSlot: lazyflow.graph.InputSlot, labeled image slot\n-        :param kwargs: dict containing additional context info\n+        :param pluginExportContext: instance of ilastik.plugins.PluginExportContext containing:\n+            - labelImageSlot: lazyflow.graph.InputSlot, labeled image slot","path":"ilastik/plugins_default/tracking_contour_export.py","position":16,"original_position":16,"commit_id":"9dd12c2e30e6ab996bce53e7369a66389d024bf3","original_commit_id":"9dd12c2e30e6ab996bce53e7369a66389d024bf3","user":{"login":"k-dominik","id":24434157,"node_id":"MDQ6VXNlcjI0NDM0MTU3","avatar_url":"https://avatars3.githubusercontent.com/u/24434157?v=4","gravatar_id":"","url":"https://api.github.com/users/k-dominik","html_url":"https://github.com/k-dominik","followers_url":"https://api.github.com/users/k-dominik/followers","following_url":"https://api.github.com/users/k-dominik/following{/other_user}","gists_url":"https://api.github.com/users/k-dominik/gists{/gist_id}","starred_url":"https://api.github.com/users/k-dominik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-dominik/subscriptions","organizations_url":"https://api.github.com/users/k-dominik/orgs","repos_url":"https://api.github.com/users/k-dominik/repos","events_url":"https://api.github.com/users/k-dominik/events{/privacy}","received_events_url":"https://api.github.com/users/k-dominik/received_events","type":"User","site_admin":false},"body":"i wonder if that's obvious, or if one should say that this is the only _mandatory_ key in the `PluginExportContext`, as `PluginExportContext` contains more!","created_at":"2018-10-30T15:31:08Z","updated_at":"2018-10-30T15:49:57Z","html_url":"https://github.com/ilastik/ilastik/pull/1836#discussion_r229357374","pull_request_url":"https://api.github.com/repos/ilastik/ilastik/pulls/1836","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ilastik/ilastik/pulls/comments/229357374"},"html":{"href":"https://github.com/ilastik/ilastik/pull/1836#discussion_r229357374"},"pull_request":{"href":"https://api.github.com/repos/ilastik/ilastik/pulls/1836"}}},"pull_request":{"url":"https://api.github.com/repos/ilastik/ilastik/pulls/1836","id":215947157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTQ3MTU3","html_url":"https://github.com/ilastik/ilastik/pull/1836","diff_url":"https://github.com/ilastik/ilastik/pull/1836.diff","patch_url":"https://github.com/ilastik/ilastik/pull/1836.patch","issue_url":"https://api.github.com/repos/ilastik/ilastik/issues/1836","number":1836,"state":"open","locked":false,"title":"Remove plugin specific slots from the OpTrackingBaseDataExport","user":{"login":"wolny","id":706781,"node_id":"MDQ6VXNlcjcwNjc4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/706781?v=4","gravatar_id":"","url":"https://api.github.com/users/wolny","html_url":"https://github.com/wolny","followers_url":"https://api.github.com/users/wolny/followers","following_url":"https://api.github.com/users/wolny/following{/other_user}","gists_url":"https://api.github.com/users/wolny/gists{/gist_id}","starred_url":"https://api.github.com/users/wolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolny/subscriptions","organizations_url":"https://api.github.com/users/wolny/orgs","repos_url":"https://api.github.com/users/wolny/repos","events_url":"https://api.github.com/users/wolny/events{/privacy}","received_events_url":"https://api.github.com/users/wolny/received_events","type":"User","site_admin":false},"body":"As suggested by @akreshuk we should avoid adding plugin specific state to the `OpTrackingBaseDataExport`. This PR replaces Fiji-MaMuT specific `BigDataViewerFilepath` slots with a more generic `AdditionalPluginArguments` holding a dictionary with additional context information that can be used by the plugins, e.g. user input.\r\n\r\nAdditional changes:\r\n* Add missing serialization to `TrackingBaseDataExportApplet`\r\n* Refactor `TrackingExportFormatPlugin.export` interface to be consistent among its implementations and got rid of the `kwargs`\r\n\r\n","created_at":"2018-09-17T11:17:56Z","updated_at":"2018-10-30T15:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"779800e4b176b217c9315d11e085ac8a109b5211","assignee":null,"assignees":[],"requested_reviewers":[{"login":"akreshuk","id":901064,"node_id":"MDQ6VXNlcjkwMTA2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/901064?v=4","gravatar_id":"","url":"https://api.github.com/users/akreshuk","html_url":"https://github.com/akreshuk","followers_url":"https://api.github.com/users/akreshuk/followers","following_url":"https://api.github.com/users/akreshuk/following{/other_user}","gists_url":"https://api.github.com/users/akreshuk/gists{/gist_id}","starred_url":"https://api.github.com/users/akreshuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akreshuk/subscriptions","organizations_url":"https://api.github.com/users/akreshuk/orgs","repos_url":"https://api.github.com/users/akreshuk/repos","events_url":"https://api.github.com/users/akreshuk/events{/privacy}","received_events_url":"https://api.github.com/users/akreshuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ilastik/ilastik/pulls/1836/commits","review_comments_url":"https://api.github.com/repos/ilastik/ilastik/pulls/1836/comments","review_comment_url":"https://api.github.com/repos/ilastik/ilastik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ilastik/ilastik/issues/1836/comments","statuses_url":"https://api.github.com/repos/ilastik/ilastik/statuses/9dd12c2e30e6ab996bce53e7369a66389d024bf3","head":{"label":"wolny:op-tracking-base-improvement","ref":"op-tracking-base-improvement","sha":"9dd12c2e30e6ab996bce53e7369a66389d024bf3","user":{"login":"wolny","id":706781,"node_id":"MDQ6VXNlcjcwNjc4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/706781?v=4","gravatar_id":"","url":"https://api.github.com/users/wolny","html_url":"https://github.com/wolny","followers_url":"https://api.github.com/users/wolny/followers","following_url":"https://api.github.com/users/wolny/following{/other_user}","gists_url":"https://api.github.com/users/wolny/gists{/gist_id}","starred_url":"https://api.github.com/users/wolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolny/subscriptions","organizations_url":"https://api.github.com/users/wolny/orgs","repos_url":"https://api.github.com/users/wolny/repos","events_url":"https://api.github.com/users/wolny/events{/privacy}","received_events_url":"https://api.github.com/users/wolny/received_events","type":"User","site_admin":false},"repo":{"id":114391881,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQzOTE4ODE=","name":"ilastik","full_name":"wolny/ilastik","private":false,"owner":{"login":"wolny","id":706781,"node_id":"MDQ6VXNlcjcwNjc4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/706781?v=4","gravatar_id":"","url":"https://api.github.com/users/wolny","html_url":"https://github.com/wolny","followers_url":"https://api.github.com/users/wolny/followers","following_url":"https://api.github.com/users/wolny/following{/other_user}","gists_url":"https://api.github.com/users/wolny/gists{/gist_id}","starred_url":"https://api.github.com/users/wolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolny/subscriptions","organizations_url":"https://api.github.com/users/wolny/orgs","repos_url":"https://api.github.com/users/wolny/repos","events_url":"https://api.github.com/users/wolny/events{/privacy}","received_events_url":"https://api.github.com/users/wolny/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wolny/ilastik","description":"ilastik-shell, applets, and workflows to string them together.","fork":true,"url":"https://api.github.com/repos/wolny/ilastik","forks_url":"https://api.github.com/repos/wolny/ilastik/forks","keys_url":"https://api.github.com/repos/wolny/ilastik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolny/ilastik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolny/ilastik/teams","hooks_url":"https://api.github.com/repos/wolny/ilastik/hooks","issue_events_url":"https://api.github.com/repos/wolny/ilastik/issues/events{/number}","events_url":"https://api.github.com/repos/wolny/ilastik/events","assignees_url":"https://api.github.com/repos/wolny/ilastik/assignees{/user}","branches_url":"https://api.github.com/repos/wolny/ilastik/branches{/branch}","tags_url":"https://api.github.com/repos/wolny/ilastik/tags","blobs_url":"https://api.github.com/repos/wolny/ilastik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolny/ilastik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolny/ilastik/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolny/ilastik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolny/ilastik/statuses/{sha}","languages_url":"https://api.github.com/repos/wolny/ilastik/languages","stargazers_url":"https://api.github.com/repos/wolny/ilastik/stargazers","contributors_url":"https://api.github.com/repos/wolny/ilastik/contributors","subscribers_url":"https://api.github.com/repos/wolny/ilastik/subscribers","subscription_url":"https://api.github.com/repos/wolny/ilastik/subscription","commits_url":"https://api.github.com/repos/wolny/ilastik/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolny/ilastik/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolny/ilastik/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolny/ilastik/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolny/ilastik/contents/{+path}","compare_url":"https://api.github.com/repos/wolny/ilastik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolny/ilastik/merges","archive_url":"https://api.github.com/repos/wolny/ilastik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolny/ilastik/downloads","issues_url":"https://api.github.com/repos/wolny/ilastik/issues{/number}","pulls_url":"https://api.github.com/repos/wolny/ilastik/pulls{/number}","milestones_url":"https://api.github.com/repos/wolny/ilastik/milestones{/number}","notifications_url":"https://api.github.com/repos/wolny/ilastik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolny/ilastik/labels{/name}","releases_url":"https://api.github.com/repos/wolny/ilastik/releases{/id}","deployments_url":"https://api.github.com/repos/wolny/ilastik/deployments","created_at":"2017-12-15T16:45:02Z","updated_at":"2018-10-22T13:01:21Z","pushed_at":"2018-10-27T17:22:58Z","git_url":"git://github.com/wolny/ilastik.git","ssh_url":"git@github.com:wolny/ilastik.git","clone_url":"https://github.com/wolny/ilastik.git","svn_url":"https://github.com/wolny/ilastik","homepage":null,"size":102085,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ilastik:master","ref":"master","sha":"b3847044258e623b424ffe14519fb4ae8543d047","user":{"login":"ilastik","id":895767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NTc2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/895767?v=4","gravatar_id":"","url":"https://api.github.com/users/ilastik","html_url":"https://github.com/ilastik","followers_url":"https://api.github.com/users/ilastik/followers","following_url":"https://api.github.com/users/ilastik/following{/other_user}","gists_url":"https://api.github.com/users/ilastik/gists{/gist_id}","starred_url":"https://api.github.com/users/ilastik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilastik/subscriptions","organizations_url":"https://api.github.com/users/ilastik/orgs","repos_url":"https://api.github.com/users/ilastik/repos","events_url":"https://api.github.com/users/ilastik/events{/privacy}","received_events_url":"https://api.github.com/users/ilastik/received_events","type":"Organization","site_admin":false},"repo":{"id":4262493,"node_id":"MDEwOlJlcG9zaXRvcnk0MjYyNDkz","name":"ilastik","full_name":"ilastik/ilastik","private":false,"owner":{"login":"ilastik","id":895767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NTc2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/895767?v=4","gravatar_id":"","url":"https://api.github.com/users/ilastik","html_url":"https://github.com/ilastik","followers_url":"https://api.github.com/users/ilastik/followers","following_url":"https://api.github.com/users/ilastik/following{/other_user}","gists_url":"https://api.github.com/users/ilastik/gists{/gist_id}","starred_url":"https://api.github.com/users/ilastik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilastik/subscriptions","organizations_url":"https://api.github.com/users/ilastik/orgs","repos_url":"https://api.github.com/users/ilastik/repos","events_url":"https://api.github.com/users/ilastik/events{/privacy}","received_events_url":"https://api.github.com/users/ilastik/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ilastik/ilastik","description":"ilastik-shell, applets, and workflows to string them together.","fork":false,"url":"https://api.github.com/repos/ilastik/ilastik","forks_url":"https://api.github.com/repos/ilastik/ilastik/forks","keys_url":"https://api.github.com/repos/ilastik/ilastik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilastik/ilastik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilastik/ilastik/teams","hooks_url":"https://api.github.com/repos/ilastik/ilastik/hooks","issue_events_url":"https://api.github.com/repos/ilastik/ilastik/issues/events{/number}","events_url":"https://api.github.com/repos/ilastik/ilastik/events","assignees_url":"https://api.github.com/repos/ilastik/ilastik/assignees{/user}","branches_url":"https://api.github.com/repos/ilastik/ilastik/branches{/branch}","tags_url":"https://api.github.com/repos/ilastik/ilastik/tags","blobs_url":"https://api.github.com/repos/ilastik/ilastik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilastik/ilastik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilastik/ilastik/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilastik/ilastik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilastik/ilastik/statuses/{sha}","languages_url":"https://api.github.com/repos/ilastik/ilastik/languages","stargazers_url":"https://api.github.com/repos/ilastik/ilastik/stargazers","contributors_url":"https://api.github.com/repos/ilastik/ilastik/contributors","subscribers_url":"https://api.github.com/repos/ilastik/ilastik/subscribers","subscription_url":"https://api.github.com/repos/ilastik/ilastik/subscription","commits_url":"https://api.github.com/repos/ilastik/ilastik/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilastik/ilastik/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilastik/ilastik/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilastik/ilastik/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilastik/ilastik/contents/{+path}","compare_url":"https://api.github.com/repos/ilastik/ilastik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilastik/ilastik/merges","archive_url":"https://api.github.com/repos/ilastik/ilastik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilastik/ilastik/downloads","issues_url":"https://api.github.com/repos/ilastik/ilastik/issues{/number}","pulls_url":"https://api.github.com/repos/ilastik/ilastik/pulls{/number}","milestones_url":"https://api.github.com/repos/ilastik/ilastik/milestones{/number}","notifications_url":"https://api.github.com/repos/ilastik/ilastik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilastik/ilastik/labels{/name}","releases_url":"https://api.github.com/repos/ilastik/ilastik/releases{/id}","deployments_url":"https://api.github.com/repos/ilastik/ilastik/deployments","created_at":"2012-05-08T15:59:36Z","updated_at":"2018-10-30T08:51:20Z","pushed_at":"2018-10-30T13:14:25Z","git_url":"git://github.com/ilastik/ilastik.git","ssh_url":"git@github.com:ilastik/ilastik.git","clone_url":"https://github.com/ilastik/ilastik.git","svn_url":"https://github.com/ilastik/ilastik","homepage":null,"size":102157,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":417,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":417,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ilastik/ilastik/pulls/1836"},"html":{"href":"https://github.com/ilastik/ilastik/pull/1836"},"issue":{"href":"https://api.github.com/repos/ilastik/ilastik/issues/1836"},"comments":{"href":"https://api.github.com/repos/ilastik/ilastik/issues/1836/comments"},"review_comments":{"href":"https://api.github.com/repos/ilastik/ilastik/pulls/1836/comments"},"review_comment":{"href":"https://api.github.com/repos/ilastik/ilastik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ilastik/ilastik/pulls/1836/commits"},"statuses":{"href":"https://api.github.com/repos/ilastik/ilastik/statuses/9dd12c2e30e6ab996bce53e7369a66389d024bf3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"k-dominik"}}