{"action":"created","comment":{"url":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments/210145440","pull_request_review_id":146300917,"id":210145440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDE0NTQ0MA==","diff_hunk":"@@ -1150,16 +1152,32 @@ session.\n \n ```\n PortId_t         egress_port;\n+MulticastGroup_t multicast_group;\n ClassOfService_t class_of_service;\n bool             truncate;\n PacketLength_t   packet_length_bytes;  /// only used if truncate is true\n ```\n \n The `egress_port` may be any port that can be used for normal unicast\n-packets, i.e. any normal port, `PSA_PORT_CPU`, or `PSA_PORT_RECIRCULATE`.  For\n-the latter two values, the cloned packet will be sent to the CPU, or\n-recirculated at the end of egress processing, as a normal unicast\n-packet would at the end of egress processing.\n+packets, i.e. any normal port, `PSA_PORT_CPU`, or\n+`PSA_PORT_RECIRCULATE`. For the latter two values, the cloned packet\n+will be sent to the CPU, or recirculated at the end of egress\n+processing, as a normal unicast packet would at the end of egress\n+processing.\n+\n+The `multicast_group` may be any multicast group configured by the\n+control plane in the PRE. Sending a packet to a clone session with a\n+multicast group configured would cause the cloned packet to be\n+replicated to each `egress_port` in the multicast group. If the\n+`multicast_group` specified in a clone session is not configured in\n+the PRE by the control plane, the cloned packet will not be\n+multicasted. A PSA target may need extra effort to check the validity\n+of the multicast group in a clone session. Therefore, sending a packet\n+to a clone session with un-configured multicast group may have\n+performance impact. A clone session can configure both `egress_port`\n+and `multicast_group` simultaneously. In addition, an `egress_port`","path":"p4-16/psa/PSA.mdk","position":72,"original_position":60,"commit_id":"f22ec00022153097ef851be881c0c44d9e9f960c","original_commit_id":"afde58361cb1393f6358ab29ebcc2e8e6114bb73","user":{"login":"jafingerhut","id":109629,"node_id":"MDQ6VXNlcjEwOTYyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/109629?v=4","gravatar_id":"","url":"https://api.github.com/users/jafingerhut","html_url":"https://github.com/jafingerhut","followers_url":"https://api.github.com/users/jafingerhut/followers","following_url":"https://api.github.com/users/jafingerhut/following{/other_user}","gists_url":"https://api.github.com/users/jafingerhut/gists{/gist_id}","starred_url":"https://api.github.com/users/jafingerhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafingerhut/subscriptions","organizations_url":"https://api.github.com/users/jafingerhut/orgs","repos_url":"https://api.github.com/users/jafingerhut/repos","events_url":"https://api.github.com/users/jafingerhut/events{/privacy}","received_events_url":"https://api.github.com/users/jafingerhut/received_events","type":"User","site_admin":false},"body":"\\Given the P4Runtime message you show above, it is kind of invisible to the P4Runtime client how it is done, and the data plane might use a multicast_group value to implement it, or it might not.  Documenting in PSA that there is an egress_port or multicast_group in the per-clone-session state is potentially misleading.  Perhaps PSA should document the clone session state more similarly to how the P4Runtime message contents look, and not mention a multicast_group value at all, just a \"set of (egress_port, instance) pairs\"?","created_at":"2018-08-15T00:40:56Z","updated_at":"2018-08-15T00:40:56Z","html_url":"https://github.com/p4lang/p4-spec/pull/665#discussion_r210145440","pull_request_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/665","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments/210145440"},"html":{"href":"https://github.com/p4lang/p4-spec/pull/665#discussion_r210145440"},"pull_request":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/665"}},"in_reply_to_id":210120124},"pull_request":{"url":"https://api.github.com/repos/p4lang/p4-spec/pulls/665","id":208414386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDE0Mzg2","html_url":"https://github.com/p4lang/p4-spec/pull/665","diff_url":"https://github.com/p4lang/p4-spec/pull/665.diff","patch_url":"https://github.com/p4lang/p4-spec/pull/665.patch","issue_url":"https://api.github.com/repos/p4lang/p4-spec/issues/665","number":665,"state":"open","locked":false,"title":"add text to support sending cloned packet to multicast group","user":{"login":"hanw","id":125978,"node_id":"MDQ6VXNlcjEyNTk3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/125978?v=4","gravatar_id":"","url":"https://api.github.com/users/hanw","html_url":"https://github.com/hanw","followers_url":"https://api.github.com/users/hanw/followers","following_url":"https://api.github.com/users/hanw/following{/other_user}","gists_url":"https://api.github.com/users/hanw/gists{/gist_id}","starred_url":"https://api.github.com/users/hanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanw/subscriptions","organizations_url":"https://api.github.com/users/hanw/orgs","repos_url":"https://api.github.com/users/hanw/repos","events_url":"https://api.github.com/users/hanw/events{/privacy}","received_events_url":"https://api.github.com/users/hanw/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-14T21:22:08Z","updated_at":"2018-08-15T00:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96e1b6a28c19286af76fc03102c4b8a6e4f0786b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cc10512","id":3770874,"node_id":"MDQ6VXNlcjM3NzA4NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3770874?v=4","gravatar_id":"","url":"https://api.github.com/users/cc10512","html_url":"https://github.com/cc10512","followers_url":"https://api.github.com/users/cc10512/followers","following_url":"https://api.github.com/users/cc10512/following{/other_user}","gists_url":"https://api.github.com/users/cc10512/gists{/gist_id}","starred_url":"https://api.github.com/users/cc10512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc10512/subscriptions","organizations_url":"https://api.github.com/users/cc10512/orgs","repos_url":"https://api.github.com/users/cc10512/repos","events_url":"https://api.github.com/users/cc10512/events{/privacy}","received_events_url":"https://api.github.com/users/cc10512/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/665/commits","review_comments_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/665/comments","review_comment_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p4lang/p4-spec/issues/665/comments","statuses_url":"https://api.github.com/repos/p4lang/p4-spec/statuses/f22ec00022153097ef851be881c0c44d9e9f960c","head":{"label":"p4lang:hanw/clone-session-fix","ref":"hanw/clone-session-fix","sha":"f22ec00022153097ef851be881c0c44d9e9f960c","user":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":40704988,"node_id":"MDEwOlJlcG9zaXRvcnk0MDcwNDk4OA==","name":"p4-spec","full_name":"p4lang/p4-spec","owner":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/p4-spec","description":null,"fork":false,"url":"https://api.github.com/repos/p4lang/p4-spec","forks_url":"https://api.github.com/repos/p4lang/p4-spec/forks","keys_url":"https://api.github.com/repos/p4lang/p4-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/p4-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/p4-spec/teams","hooks_url":"https://api.github.com/repos/p4lang/p4-spec/hooks","issue_events_url":"https://api.github.com/repos/p4lang/p4-spec/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/p4-spec/events","assignees_url":"https://api.github.com/repos/p4lang/p4-spec/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/p4-spec/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/p4-spec/tags","blobs_url":"https://api.github.com/repos/p4lang/p4-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/p4-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/p4-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/p4-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/p4-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/p4-spec/languages","stargazers_url":"https://api.github.com/repos/p4lang/p4-spec/stargazers","contributors_url":"https://api.github.com/repos/p4lang/p4-spec/contributors","subscribers_url":"https://api.github.com/repos/p4lang/p4-spec/subscribers","subscription_url":"https://api.github.com/repos/p4lang/p4-spec/subscription","commits_url":"https://api.github.com/repos/p4lang/p4-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/p4-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/p4-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/p4-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/p4-spec/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/p4-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/p4-spec/merges","archive_url":"https://api.github.com/repos/p4lang/p4-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/p4-spec/downloads","issues_url":"https://api.github.com/repos/p4lang/p4-spec/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/p4-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/p4-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/p4-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/p4-spec/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/p4-spec/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/p4-spec/deployments","created_at":"2015-08-14T08:45:53Z","updated_at":"2018-08-11T17:12:19Z","pushed_at":"2018-08-14T23:29:51Z","git_url":"git://github.com/p4lang/p4-spec.git","ssh_url":"git@github.com:p4lang/p4-spec.git","clone_url":"https://github.com/p4lang/p4-spec.git","svn_url":"https://github.com/p4lang/p4-spec","homepage":null,"size":74237,"stargazers_count":42,"watchers_count":42,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":23,"open_issues":70,"watchers":42,"default_branch":"master"}},"base":{"label":"p4lang:master","ref":"master","sha":"1460dceb197477c95201fdff9871052552c0e8d3","user":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":40704988,"node_id":"MDEwOlJlcG9zaXRvcnk0MDcwNDk4OA==","name":"p4-spec","full_name":"p4lang/p4-spec","owner":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/p4-spec","description":null,"fork":false,"url":"https://api.github.com/repos/p4lang/p4-spec","forks_url":"https://api.github.com/repos/p4lang/p4-spec/forks","keys_url":"https://api.github.com/repos/p4lang/p4-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/p4-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/p4-spec/teams","hooks_url":"https://api.github.com/repos/p4lang/p4-spec/hooks","issue_events_url":"https://api.github.com/repos/p4lang/p4-spec/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/p4-spec/events","assignees_url":"https://api.github.com/repos/p4lang/p4-spec/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/p4-spec/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/p4-spec/tags","blobs_url":"https://api.github.com/repos/p4lang/p4-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/p4-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/p4-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/p4-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/p4-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/p4-spec/languages","stargazers_url":"https://api.github.com/repos/p4lang/p4-spec/stargazers","contributors_url":"https://api.github.com/repos/p4lang/p4-spec/contributors","subscribers_url":"https://api.github.com/repos/p4lang/p4-spec/subscribers","subscription_url":"https://api.github.com/repos/p4lang/p4-spec/subscription","commits_url":"https://api.github.com/repos/p4lang/p4-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/p4-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/p4-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/p4-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/p4-spec/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/p4-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/p4-spec/merges","archive_url":"https://api.github.com/repos/p4lang/p4-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/p4-spec/downloads","issues_url":"https://api.github.com/repos/p4lang/p4-spec/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/p4-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/p4-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/p4-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/p4-spec/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/p4-spec/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/p4-spec/deployments","created_at":"2015-08-14T08:45:53Z","updated_at":"2018-08-11T17:12:19Z","pushed_at":"2018-08-14T23:29:51Z","git_url":"git://github.com/p4lang/p4-spec.git","ssh_url":"git@github.com:p4lang/p4-spec.git","clone_url":"https://github.com/p4lang/p4-spec.git","svn_url":"https://github.com/p4lang/p4-spec","homepage":null,"size":74237,"stargazers_count":42,"watchers_count":42,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":23,"open_issues":70,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/665"},"html":{"href":"https://github.com/p4lang/p4-spec/pull/665"},"issue":{"href":"https://api.github.com/repos/p4lang/p4-spec/issues/665"},"comments":{"href":"https://api.github.com/repos/p4lang/p4-spec/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/p4lang/p4-spec/statuses/f22ec00022153097ef851be881c0c44d9e9f960c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jafingerhut"}}