{"action":"created","issue":{"url":"https://api.github.com/repos/sul-dlss/argo/issues/1256","repository_url":"https://api.github.com/repos/sul-dlss/argo","labels_url":"https://api.github.com/repos/sul-dlss/argo/issues/1256/labels{/name}","comments_url":"https://api.github.com/repos/sul-dlss/argo/issues/1256/comments","events_url":"https://api.github.com/repos/sul-dlss/argo/issues/1256/events","html_url":"https://github.com/sul-dlss/argo/pull/1256","id":392730896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTM3NTUx","number":1256,"title":"create collection modal should not render layout from an ajax call","user":{"login":"peetucket","id":47137,"node_id":"MDQ6VXNlcjQ3MTM3","avatar_url":"https://avatars1.githubusercontent.com/u/47137?v=4","gravatar_id":"","url":"https://api.github.com/users/peetucket","html_url":"https://github.com/peetucket","followers_url":"https://api.github.com/users/peetucket/followers","following_url":"https://api.github.com/users/peetucket/following{/other_user}","gists_url":"https://api.github.com/users/peetucket/gists{/gist_id}","starred_url":"https://api.github.com/users/peetucket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peetucket/subscriptions","organizations_url":"https://api.github.com/users/peetucket/orgs","repos_url":"https://api.github.com/users/peetucket/repos","events_url":"https://api.github.com/users/peetucket/events{/privacy}","received_events_url":"https://api.github.com/users/peetucket/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-19T18:44:46Z","updated_at":"2018-12-20T17:31:02Z","closed_at":"2018-12-19T20:11:32Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sul-dlss/argo/pulls/1256","html_url":"https://github.com/sul-dlss/argo/pull/1256","diff_url":"https://github.com/sul-dlss/argo/pull/1256.diff","patch_url":"https://github.com/sul-dlss/argo/pull/1256.patch"},"body":"* creating a collection makes an ajax call which should not render the layout (else you get JS classes when all of the JS tries to load again)\r\n* also hide the cancel button from an ajax call to be consistent with other modals, since you already have a close modal button and the cancel would have forced a full page reload"},"comment":{"url":"https://api.github.com/repos/sul-dlss/argo/issues/comments/449075798","html_url":"https://github.com/sul-dlss/argo/pull/1256#issuecomment-449075798","issue_url":"https://api.github.com/repos/sul-dlss/argo/issues/1256","id":449075798,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTA3NTc5OA==","user":{"login":"peetucket","id":47137,"node_id":"MDQ6VXNlcjQ3MTM3","avatar_url":"https://avatars1.githubusercontent.com/u/47137?v=4","gravatar_id":"","url":"https://api.github.com/users/peetucket","html_url":"https://github.com/peetucket","followers_url":"https://api.github.com/users/peetucket/followers","following_url":"https://api.github.com/users/peetucket/following{/other_user}","gists_url":"https://api.github.com/users/peetucket/gists{/gist_id}","starred_url":"https://api.github.com/users/peetucket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peetucket/subscriptions","organizations_url":"https://api.github.com/users/peetucket/orgs","repos_url":"https://api.github.com/users/peetucket/repos","events_url":"https://api.github.com/users/peetucket/events{/privacy}","received_events_url":"https://api.github.com/users/peetucket/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T17:31:02Z","updated_at":"2018-12-20T17:31:02Z","author_association":"MEMBER","body":"i decided to just matched the same style that was used in all other the similar \"blue button\" modals in the item controller, e.g. https://github.com/sul-dlss/argo/blob/master/app/controllers/items_controller.rb#L692-L696\r\n\r\nI guess I'd vote for consistency for now (those other modals work with no JS on, even if that is not a stated requirement).  Though I know turning of JS breaks other stuff (like item registration) so its not all totally consistent either."}}
{"actor":{"display_login":"peetucket"}}