{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/169305493","pull_request_review_id":97806437,"id":169305493,"diff_hunk":"@@ -1069,46 +1065,32 @@ let mkClassUnionDef (addMethodGeneratedAttrs, addPropertyGeneratedAttrs, addProp\n         if tagEnumFields.Length <= 1 then \n             None\n         else\n-            Some \n+            Some( \n                 { Name = \"Tags\"\n                   NestedTypes = emptyILTypeDefs\n                   GenericParams= td.GenericParams\n-                  Access = ILTypeDefAccess.Nested cud.cudReprAccess\n-                  IsAbstract = true\n-                  IsSealed = true\n-                  IsSerializable=false\n-                  IsComInterop=false\n+                  Attributes = enum 0\n                   Layout=ILTypeDefLayout.Auto \n-                  IsSpecialName=false\n-                  Encoding=ILDefaultPInvokeEncoding.Ansi\n                   Implements = []\n                   Extends= Some ilg.typ_Object \n                   Methods= emptyILMethods\n                   SecurityDecls=emptyILSecurityDecls\n-                  HasSecurity=false \n                   Fields=mkILFields tagEnumFields\n                   MethodImpls=emptyILMethodImpls\n-                  InitSemantics=ILTypeInit.OnAny\n                   Events=emptyILEvents\n                   Properties=emptyILProperties\n-                  CustomAttrs= emptyILCustomAttrs\n-                  tdKind = ILTypeDefKind.Enum }\n+                  CustomAttrs= emptyILCustomAttrs }.WithNestedAccess(cud.cudReprAccess).WithAbstract(true).WithSealed(true).WithImport(false).WithEncoding(ILDefaultPInvokeEncoding.Ansi).WithHasSecurity(false))","path":"src/ilx/EraseUnions.fs","position":272,"original_position":272,"commit_id":"5a7a0fae6a86cfe0d36e857fc92bfa8d37833334","original_commit_id":"5a7a0fae6a86cfe0d36e857fc92bfa8d37833334","user":{"login":"forki","id":57396,"avatar_url":"https://avatars1.githubusercontent.com/u/57396?v=4","gravatar_id":"","url":"https://api.github.com/users/forki","html_url":"https://github.com/forki","followers_url":"https://api.github.com/users/forki/followers","following_url":"https://api.github.com/users/forki/following{/other_user}","gists_url":"https://api.github.com/users/forki/gists{/gist_id}","starred_url":"https://api.github.com/users/forki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forki/subscriptions","organizations_url":"https://api.github.com/users/forki/orgs","repos_url":"https://api.github.com/users/forki/repos","events_url":"https://api.github.com/users/forki/events{/privacy}","received_events_url":"https://api.github.com/users/forki/received_events","type":"User","site_admin":false},"body":"many many records","created_at":"2018-02-20T12:40:59Z","updated_at":"2018-02-20T12:41:09Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/4272#discussion_r169305493","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/169305493"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/4272#discussion_r169305493"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272","id":165342197,"html_url":"https://github.com/Microsoft/visualfsharp/pull/4272","diff_url":"https://github.com/Microsoft/visualfsharp/pull/4272.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/4272.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/4272","number":4272,"state":"open","locked":false,"title":"[WIP] Reduce FCS memory footprint","user":{"login":"AviAvni","id":1097246,"avatar_url":"https://avatars2.githubusercontent.com/u/1097246?v=4","gravatar_id":"","url":"https://api.github.com/users/AviAvni","html_url":"https://github.com/AviAvni","followers_url":"https://api.github.com/users/AviAvni/followers","following_url":"https://api.github.com/users/AviAvni/following{/other_user}","gists_url":"https://api.github.com/users/AviAvni/gists{/gist_id}","starred_url":"https://api.github.com/users/AviAvni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AviAvni/subscriptions","organizations_url":"https://api.github.com/users/AviAvni/orgs","repos_url":"https://api.github.com/users/AviAvni/repos","events_url":"https://api.github.com/users/AviAvni/events{/privacy}","received_events_url":"https://api.github.com/users/AviAvni/received_events","type":"User","site_admin":false},"body":"I started with ILEventDef ILPropertyDef and ILFieldDef \r\nI'll continue working on ILMethodDef and ILTypeDef\r\nLink https://github.com/Microsoft/visualfsharp/issues/4258","created_at":"2018-01-26T11:21:25Z","updated_at":"2018-02-20T12:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80fb4c07c6f8f777c25484fd8a0ad094903e7e8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/4272/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/5a7a0fae6a86cfe0d36e857fc92bfa8d37833334","head":{"label":"AviAvni:fcs-memory","ref":"fcs-memory","sha":"5a7a0fae6a86cfe0d36e857fc92bfa8d37833334","user":{"login":"AviAvni","id":1097246,"avatar_url":"https://avatars2.githubusercontent.com/u/1097246?v=4","gravatar_id":"","url":"https://api.github.com/users/AviAvni","html_url":"https://github.com/AviAvni","followers_url":"https://api.github.com/users/AviAvni/followers","following_url":"https://api.github.com/users/AviAvni/following{/other_user}","gists_url":"https://api.github.com/users/AviAvni/gists{/gist_id}","starred_url":"https://api.github.com/users/AviAvni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AviAvni/subscriptions","organizations_url":"https://api.github.com/users/AviAvni/orgs","repos_url":"https://api.github.com/users/AviAvni/repos","events_url":"https://api.github.com/users/AviAvni/events{/privacy}","received_events_url":"https://api.github.com/users/AviAvni/received_events","type":"User","site_admin":false},"repo":{"id":54913620,"name":"visualfsharp","full_name":"AviAvni/visualfsharp","owner":{"login":"AviAvni","id":1097246,"avatar_url":"https://avatars2.githubusercontent.com/u/1097246?v=4","gravatar_id":"","url":"https://api.github.com/users/AviAvni","html_url":"https://github.com/AviAvni","followers_url":"https://api.github.com/users/AviAvni/followers","following_url":"https://api.github.com/users/AviAvni/following{/other_user}","gists_url":"https://api.github.com/users/AviAvni/gists{/gist_id}","starred_url":"https://api.github.com/users/AviAvni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AviAvni/subscriptions","organizations_url":"https://api.github.com/users/AviAvni/orgs","repos_url":"https://api.github.com/users/AviAvni/repos","events_url":"https://api.github.com/users/AviAvni/events{/privacy}","received_events_url":"https://api.github.com/users/AviAvni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AviAvni/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/AviAvni/visualfsharp","forks_url":"https://api.github.com/repos/AviAvni/visualfsharp/forks","keys_url":"https://api.github.com/repos/AviAvni/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AviAvni/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AviAvni/visualfsharp/teams","hooks_url":"https://api.github.com/repos/AviAvni/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/AviAvni/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/AviAvni/visualfsharp/events","assignees_url":"https://api.github.com/repos/AviAvni/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/AviAvni/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/AviAvni/visualfsharp/tags","blobs_url":"https://api.github.com/repos/AviAvni/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AviAvni/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AviAvni/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/AviAvni/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AviAvni/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/AviAvni/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/AviAvni/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/AviAvni/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/AviAvni/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/AviAvni/visualfsharp/subscription","commits_url":"https://api.github.com/repos/AviAvni/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/AviAvni/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/AviAvni/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/AviAvni/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/AviAvni/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/AviAvni/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AviAvni/visualfsharp/merges","archive_url":"https://api.github.com/repos/AviAvni/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AviAvni/visualfsharp/downloads","issues_url":"https://api.github.com/repos/AviAvni/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/AviAvni/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/AviAvni/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/AviAvni/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AviAvni/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/AviAvni/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/AviAvni/visualfsharp/deployments","created_at":"2016-03-28T18:20:59Z","updated_at":"2016-03-28T18:21:12Z","pushed_at":"2018-02-20T10:54:31Z","git_url":"git://github.com/AviAvni/visualfsharp.git","ssh_url":"git@github.com:AviAvni/visualfsharp.git","clone_url":"https://github.com/AviAvni/visualfsharp.git","svn_url":"https://github.com/AviAvni/visualfsharp","homepage":null,"size":108992,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5728b68d9fea67aaf45f810b2f602419c1094b92","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/visualfsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2018-02-19T06:10:58Z","pushed_at":"2018-02-20T10:54:33Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":110422,"stargazers_count":1253,"watchers_count":1253,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":337,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":337,"open_issues":523,"watchers":1253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/4272"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/4272"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/4272/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/4272/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/5a7a0fae6a86cfe0d36e857fc92bfa8d37833334"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"forki"}}