{"action":"created","comment":{"url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/comments/215649488","pull_request_review_id":152961267,"id":215649488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTY0OTQ4OA==","diff_hunk":"@@ -769,28 +769,28 @@ struct TABLE_SHARE\n \n   /**\n     System versioning support.\n-   */\n-   struct period_info_t\n-   {\n-     TABLE_SHARE *s;\n-     uint16 start_fieldno;\n-     uint16 end_fieldno;\n-     Lex_ident name;\n-\n-     Field *start_field()\n-     {\n-       return s->field[start_fieldno];\n-     }\n-     Field *end_field()\n-     {\n-       return s->field[end_fieldno];\n-     }\n-   };\n+  */\n+  struct period_info_t\n+  {\n+    uint16 start_fieldno;\n+    uint16 end_fieldno;\n+    Lex_ident name;\n+    Field *start_field(TABLE_SHARE *s) const\n+    {\n+      return s->field[start_fieldno];","path":"sql/table.h","position":22,"original_position":29,"commit_id":"d88e631eebd4dc9547a4ca41be8b30fe76ba8c4c","original_commit_id":"d88e631eebd4dc9547a4ca41be8b30fe76ba8c4c","user":{"login":"midenok","id":3307037,"node_id":"MDQ6VXNlcjMzMDcwMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3307037?v=4","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false},"body":"True. Really, there is no best solution or I don't see one. Each one lacks something, so this is your freedom to choose. But keep away from making data members without good reason.","created_at":"2018-09-06T14:34:19Z","updated_at":"2018-09-06T14:34:19Z","html_url":"https://github.com/tempesta-tech/mariadb/pull/536#discussion_r215649488","pull_request_url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/comments/215649488"},"html":{"href":"https://github.com/tempesta-tech/mariadb/pull/536#discussion_r215649488"},"pull_request":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536"}},"in_reply_to_id":215339060},"pull_request":{"url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536","id":211767100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzY3MTAw","html_url":"https://github.com/tempesta-tech/mariadb/pull/536","diff_url":"https://github.com/tempesta-tech/mariadb/pull/536.diff","patch_url":"https://github.com/tempesta-tech/mariadb/pull/536.patch","issue_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/536","number":536,"state":"open","locked":false,"title":"MDEV-16972 Application-time periods support: CREATE, DELETE, UPDATE","user":{"login":"FooBarrior","id":394249,"node_id":"MDQ6VXNlcjM5NDI0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/394249?v=4","gravatar_id":"","url":"https://api.github.com/users/FooBarrior","html_url":"https://github.com/FooBarrior","followers_url":"https://api.github.com/users/FooBarrior/followers","following_url":"https://api.github.com/users/FooBarrior/following{/other_user}","gists_url":"https://api.github.com/users/FooBarrior/gists{/gist_id}","starred_url":"https://api.github.com/users/FooBarrior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FooBarrior/subscriptions","organizations_url":"https://api.github.com/users/FooBarrior/orgs","repos_url":"https://api.github.com/users/FooBarrior/repos","events_url":"https://api.github.com/users/FooBarrior/events{/privacy}","received_events_url":"https://api.github.com/users/FooBarrior/received_events","type":"User","site_admin":false},"body":"This pull request contains CREATE, DELETE and UPDATE parts of the feature. Commits are already prepared to the final look. \r\n\r\nTo see the natural commit history of the development process, you can refer to `nm/10.4-app-periods` branch.\r\n\r\nTwo patches were upmerged preliminarily:\r\nMDEV-16764: __Crash on delete from sql-versioned table with update trigger_ -- contains fix for versioned delete trigger\r\nMDEV-15966: _Behavior for TRUNCATE versioned table is not documented and not covered by tests_ -- contains handy frm parser refactorings\r\n\r\nAll tests have run, no new regressions","created_at":"2018-08-29T14:08:17Z","updated_at":"2018-09-06T14:34:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96baf49390d782d2e71539035313f22c0a52cf4a","assignee":{"login":"FooBarrior","id":394249,"node_id":"MDQ6VXNlcjM5NDI0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/394249?v=4","gravatar_id":"","url":"https://api.github.com/users/FooBarrior","html_url":"https://github.com/FooBarrior","followers_url":"https://api.github.com/users/FooBarrior/followers","following_url":"https://api.github.com/users/FooBarrior/following{/other_user}","gists_url":"https://api.github.com/users/FooBarrior/gists{/gist_id}","starred_url":"https://api.github.com/users/FooBarrior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FooBarrior/subscriptions","organizations_url":"https://api.github.com/users/FooBarrior/orgs","repos_url":"https://api.github.com/users/FooBarrior/repos","events_url":"https://api.github.com/users/FooBarrior/events{/privacy}","received_events_url":"https://api.github.com/users/FooBarrior/received_events","type":"User","site_admin":false},"assignees":[{"login":"FooBarrior","id":394249,"node_id":"MDQ6VXNlcjM5NDI0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/394249?v=4","gravatar_id":"","url":"https://api.github.com/users/FooBarrior","html_url":"https://github.com/FooBarrior","followers_url":"https://api.github.com/users/FooBarrior/followers","following_url":"https://api.github.com/users/FooBarrior/following{/other_user}","gists_url":"https://api.github.com/users/FooBarrior/gists{/gist_id}","starred_url":"https://api.github.com/users/FooBarrior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FooBarrior/subscriptions","organizations_url":"https://api.github.com/users/FooBarrior/orgs","repos_url":"https://api.github.com/users/FooBarrior/repos","events_url":"https://api.github.com/users/FooBarrior/events{/privacy}","received_events_url":"https://api.github.com/users/FooBarrior/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":388954538,"node_id":"MDU6TGFiZWwzODg5NTQ1Mzg=","url":"https://api.github.com/repos/tempesta-tech/mariadb/labels/feature","name":"feature","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536/commits","review_comments_url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536/comments","review_comment_url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/536/comments","statuses_url":"https://api.github.com/repos/tempesta-tech/mariadb/statuses/d88e631eebd4dc9547a4ca41be8b30fe76ba8c4c","head":{"label":"tempesta-tech:tt-10.4-app_periods","ref":"tt-10.4-app_periods","sha":"d88e631eebd4dc9547a4ca41be8b30fe76ba8c4c","user":{"login":"tempesta-tech","id":10939672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTM5Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/10939672?v=4","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":60608307,"node_id":"MDEwOlJlcG9zaXRvcnk2MDYwODMwNw==","name":"mariadb","full_name":"tempesta-tech/mariadb","owner":{"login":"tempesta-tech","id":10939672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTM5Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/10939672?v=4","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tempesta-tech/mariadb","description":"MariaDB System Versioning","fork":true,"url":"https://api.github.com/repos/tempesta-tech/mariadb","forks_url":"https://api.github.com/repos/tempesta-tech/mariadb/forks","keys_url":"https://api.github.com/repos/tempesta-tech/mariadb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tempesta-tech/mariadb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tempesta-tech/mariadb/teams","hooks_url":"https://api.github.com/repos/tempesta-tech/mariadb/hooks","issue_events_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/events{/number}","events_url":"https://api.github.com/repos/tempesta-tech/mariadb/events","assignees_url":"https://api.github.com/repos/tempesta-tech/mariadb/assignees{/user}","branches_url":"https://api.github.com/repos/tempesta-tech/mariadb/branches{/branch}","tags_url":"https://api.github.com/repos/tempesta-tech/mariadb/tags","blobs_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/refs{/sha}","trees_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tempesta-tech/mariadb/statuses/{sha}","languages_url":"https://api.github.com/repos/tempesta-tech/mariadb/languages","stargazers_url":"https://api.github.com/repos/tempesta-tech/mariadb/stargazers","contributors_url":"https://api.github.com/repos/tempesta-tech/mariadb/contributors","subscribers_url":"https://api.github.com/repos/tempesta-tech/mariadb/subscribers","subscription_url":"https://api.github.com/repos/tempesta-tech/mariadb/subscription","commits_url":"https://api.github.com/repos/tempesta-tech/mariadb/commits{/sha}","git_commits_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/commits{/sha}","comments_url":"https://api.github.com/repos/tempesta-tech/mariadb/comments{/number}","issue_comment_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/comments{/number}","contents_url":"https://api.github.com/repos/tempesta-tech/mariadb/contents/{+path}","compare_url":"https://api.github.com/repos/tempesta-tech/mariadb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tempesta-tech/mariadb/merges","archive_url":"https://api.github.com/repos/tempesta-tech/mariadb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tempesta-tech/mariadb/downloads","issues_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues{/number}","pulls_url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls{/number}","milestones_url":"https://api.github.com/repos/tempesta-tech/mariadb/milestones{/number}","notifications_url":"https://api.github.com/repos/tempesta-tech/mariadb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tempesta-tech/mariadb/labels{/name}","releases_url":"https://api.github.com/repos/tempesta-tech/mariadb/releases{/id}","deployments_url":"https://api.github.com/repos/tempesta-tech/mariadb/deployments","created_at":"2016-06-07T11:33:56Z","updated_at":"2018-09-04T19:17:45Z","pushed_at":"2018-09-06T08:50:19Z","git_url":"git://github.com/tempesta-tech/mariadb.git","ssh_url":"git@github.com:tempesta-tech/mariadb.git","clone_url":"https://github.com/tempesta-tech/mariadb.git","svn_url":"https://github.com/tempesta-tech/mariadb","homepage":"","size":639652,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":93,"watchers":6,"default_branch":"trunk"}},"base":{"label":"tempesta-tech:trunk_10.4","ref":"trunk_10.4","sha":"3d0465ac419900cfcc58d5080005da16487aaa1c","user":{"login":"tempesta-tech","id":10939672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTM5Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/10939672?v=4","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":60608307,"node_id":"MDEwOlJlcG9zaXRvcnk2MDYwODMwNw==","name":"mariadb","full_name":"tempesta-tech/mariadb","owner":{"login":"tempesta-tech","id":10939672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTM5Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/10939672?v=4","gravatar_id":"","url":"https://api.github.com/users/tempesta-tech","html_url":"https://github.com/tempesta-tech","followers_url":"https://api.github.com/users/tempesta-tech/followers","following_url":"https://api.github.com/users/tempesta-tech/following{/other_user}","gists_url":"https://api.github.com/users/tempesta-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/tempesta-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tempesta-tech/subscriptions","organizations_url":"https://api.github.com/users/tempesta-tech/orgs","repos_url":"https://api.github.com/users/tempesta-tech/repos","events_url":"https://api.github.com/users/tempesta-tech/events{/privacy}","received_events_url":"https://api.github.com/users/tempesta-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tempesta-tech/mariadb","description":"MariaDB System Versioning","fork":true,"url":"https://api.github.com/repos/tempesta-tech/mariadb","forks_url":"https://api.github.com/repos/tempesta-tech/mariadb/forks","keys_url":"https://api.github.com/repos/tempesta-tech/mariadb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tempesta-tech/mariadb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tempesta-tech/mariadb/teams","hooks_url":"https://api.github.com/repos/tempesta-tech/mariadb/hooks","issue_events_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/events{/number}","events_url":"https://api.github.com/repos/tempesta-tech/mariadb/events","assignees_url":"https://api.github.com/repos/tempesta-tech/mariadb/assignees{/user}","branches_url":"https://api.github.com/repos/tempesta-tech/mariadb/branches{/branch}","tags_url":"https://api.github.com/repos/tempesta-tech/mariadb/tags","blobs_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/refs{/sha}","trees_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tempesta-tech/mariadb/statuses/{sha}","languages_url":"https://api.github.com/repos/tempesta-tech/mariadb/languages","stargazers_url":"https://api.github.com/repos/tempesta-tech/mariadb/stargazers","contributors_url":"https://api.github.com/repos/tempesta-tech/mariadb/contributors","subscribers_url":"https://api.github.com/repos/tempesta-tech/mariadb/subscribers","subscription_url":"https://api.github.com/repos/tempesta-tech/mariadb/subscription","commits_url":"https://api.github.com/repos/tempesta-tech/mariadb/commits{/sha}","git_commits_url":"https://api.github.com/repos/tempesta-tech/mariadb/git/commits{/sha}","comments_url":"https://api.github.com/repos/tempesta-tech/mariadb/comments{/number}","issue_comment_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/comments{/number}","contents_url":"https://api.github.com/repos/tempesta-tech/mariadb/contents/{+path}","compare_url":"https://api.github.com/repos/tempesta-tech/mariadb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tempesta-tech/mariadb/merges","archive_url":"https://api.github.com/repos/tempesta-tech/mariadb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tempesta-tech/mariadb/downloads","issues_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues{/number}","pulls_url":"https://api.github.com/repos/tempesta-tech/mariadb/pulls{/number}","milestones_url":"https://api.github.com/repos/tempesta-tech/mariadb/milestones{/number}","notifications_url":"https://api.github.com/repos/tempesta-tech/mariadb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tempesta-tech/mariadb/labels{/name}","releases_url":"https://api.github.com/repos/tempesta-tech/mariadb/releases{/id}","deployments_url":"https://api.github.com/repos/tempesta-tech/mariadb/deployments","created_at":"2016-06-07T11:33:56Z","updated_at":"2018-09-04T19:17:45Z","pushed_at":"2018-09-06T08:50:19Z","git_url":"git://github.com/tempesta-tech/mariadb.git","ssh_url":"git@github.com:tempesta-tech/mariadb.git","clone_url":"https://github.com/tempesta-tech/mariadb.git","svn_url":"https://github.com/tempesta-tech/mariadb","homepage":"","size":639652,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":93,"watchers":6,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536"},"html":{"href":"https://github.com/tempesta-tech/mariadb/pull/536"},"issue":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/issues/536"},"comments":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/issues/536/comments"},"review_comments":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536/comments"},"review_comment":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/pulls/536/commits"},"statuses":{"href":"https://api.github.com/repos/tempesta-tech/mariadb/statuses/d88e631eebd4dc9547a4ca41be8b30fe76ba8c4c"}},"author_association":"NONE"}}
{"actor":{"display_login":"midenok"}}