{"action":"created","issue":{"url":"https://api.github.com/repos/kata-containers/runtime/issues/334","repository_url":"https://api.github.com/repos/kata-containers/runtime","labels_url":"https://api.github.com/repos/kata-containers/runtime/issues/334/labels{/name}","comments_url":"https://api.github.com/repos/kata-containers/runtime/issues/334/comments","events_url":"https://api.github.com/repos/kata-containers/runtime/issues/334/events","html_url":"https://github.com/kata-containers/runtime/pull/334","id":325583296,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5ODgxMDA5","number":334,"title":" make sure kataAgent/createContainer can decode old specs.Spec","user":{"login":"keloyang","id":11223367,"node_id":"MDQ6VXNlcjExMjIzMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/11223367?v=4","gravatar_id":"","url":"https://api.github.com/users/keloyang","html_url":"https://github.com/keloyang","followers_url":"https://api.github.com/users/keloyang/followers","following_url":"https://api.github.com/users/keloyang/following{/other_user}","gists_url":"https://api.github.com/users/keloyang/gists{/gist_id}","starred_url":"https://api.github.com/users/keloyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keloyang/subscriptions","organizations_url":"https://api.github.com/users/keloyang/orgs","repos_url":"https://api.github.com/users/keloyang/repos","events_url":"https://api.github.com/users/keloyang/events{/privacy}","received_events_url":"https://api.github.com/users/keloyang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-05-23T07:34:16Z","updated_at":"2018-06-01T01:56:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/334","html_url":"https://github.com/kata-containers/runtime/pull/334","diff_url":"https://github.com/kata-containers/runtime/pull/334.diff","patch_url":"https://github.com/kata-containers/runtime/pull/334.patch"},"body":"In old specs.Spec, Capabilities is [] string, but we don't use CompatOCISpec  for compatibility in kataAgent/createContainer, it lead to docker-1.11.2 failed to start kata-container, this pr will fix this.\r\n\r\nbefore this pr,\r\n```\r\n[root@localhost linux]# docker run --rm -it --runtime kata-runtime busybox sh\r\ndocker: Error response from daemon: oci runtime error: json: cannot unmarshal array into Go struct field Process.capabilities of type specs.LinuxCapabilities.\r\n```\r\nafter this pr\r\n```\r\n[root@localhost linux]# docker run --rm -it --runtime kata-runtime busybox sh\r\n/ # exit\r\n```"},"comment":{"url":"https://api.github.com/repos/kata-containers/runtime/issues/comments/393735252","html_url":"https://github.com/kata-containers/runtime/pull/334#issuecomment-393735252","issue_url":"https://api.github.com/repos/kata-containers/runtime/issues/334","id":393735252,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzczNTI1Mg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-01T01:56:09Z","updated_at":"2018-06-01T01:56:09Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/kata-containers/runtime/pull/334?src=pr&el=h1) Report\n> Merging [#334](https://codecov.io/gh/kata-containers/runtime/pull/334?src=pr&el=desc) into [master](https://codecov.io/gh/kata-containers/runtime/commit/5f5f619dfc03d921fc7d86484b835088c1a1b175?src=pr&el=desc) will **increase** coverage by `0.14%`.\n> The diff coverage is `50%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/kata-containers/runtime/pull/334/graphs/tree.svg?src=pr&token=yXWEIhaBKz&width=650&height=150)](https://codecov.io/gh/kata-containers/runtime/pull/334?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #334      +/-   ##\n==========================================\n+ Coverage   63.74%   63.89%   +0.14%     \n==========================================\n  Files          87       87              \n  Lines        8731     8633      -98     \n==========================================\n- Hits         5566     5516      -50     \n+ Misses       2569     2532      -37     \n+ Partials      596      585      -11\n```\n\n\n| [Impacted Files](https://codecov.io/gh/kata-containers/runtime/pull/334?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [virtcontainers/pkg/oci/utils.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMvcGtnL29jaS91dGlscy5nbw==) | `77.64% <50%> (-0.76%)` | :arrow_down: |\n| [virtcontainers/kata\\_agent.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMva2F0YV9hZ2VudC5nbw==) | `28.61% <0%> (-1.17%)` | :arrow_down: |\n| [virtcontainers/noop\\_agent.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMvbm9vcF9hZ2VudC5nbw==) | `90.9% <0%> (-0.76%)` | :arrow_down: |\n| [virtcontainers/api.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMvYXBpLmdv) | `63.12% <0%> (-0.62%)` | :arrow_down: |\n| [virtcontainers/pkg/vcmock/mock.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMvcGtnL3ZjbW9jay9tb2NrLmdv) | `95.18% <0%> (-0.43%)` | :arrow_down: |\n| [cli/pause.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-Y2xpL3BhdXNlLmdv) | `100% <0%> (ø)` | :arrow_up: |\n| [virtcontainers/implementation.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMvaW1wbGVtZW50YXRpb24uZ28=) | `0% <0%> (ø)` | :arrow_up: |\n| [virtcontainers/sandbox.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMvc2FuZGJveC5nbw==) | `67.45% <0%> (+0.34%)` | :arrow_up: |\n| [virtcontainers/hyperstart\\_agent.go](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree#diff-dmlydGNvbnRhaW5lcnMvaHlwZXJzdGFydF9hZ2VudC5nbw==) | `59.12% <0%> (+0.54%)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/kata-containers/runtime/pull/334/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kata-containers/runtime/pull/334?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kata-containers/runtime/pull/334?src=pr&el=footer). Last update [5f5f619...16bf8bf](https://codecov.io/gh/kata-containers/runtime/pull/334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}