{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/239965181","pull_request_review_id":182898036,"id":239965181,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk2NTE4MQ==","diff_hunk":"@@ -0,0 +1,68 @@\n+[tox]\n+envlist = py{35,36,37}-{pytest,setup}{,-all},docs,dev,flake8\n+skipsdist = True\n+requires = tox-venv\n+           setuptools >= 30.0.0\n+\n+[testenv]\n+usedevelop = True\n+whitelist_externals = which\n+passenv = HOME LC_ALL LC_CTYPE","path":"tox.ini","position":null,"original_position":10,"commit_id":"fc80038def303156f9c28e7638588fe32ac9731d","original_commit_id":"a2fed50db35d7a000134d18a0651ceaf0755107b","user":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"body":"Yep, I added CC and CFLAGS, which should fix the coverage for C files.","created_at":"2018-12-07T22:30:01Z","updated_at":"2018-12-07T22:30:01Z","html_url":"https://github.com/astropy/astropy/pull/8248#discussion_r239965181","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/8248","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/239965181"},"html":{"href":"https://github.com/astropy/astropy/pull/8248#discussion_r239965181"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/8248"}},"in_reply_to_id":239911289},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/8248","id":236849770,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODQ5Nzcw","html_url":"https://github.com/astropy/astropy/pull/8248","diff_url":"https://github.com/astropy/astropy/pull/8248.diff","patch_url":"https://github.com/astropy/astropy/pull/8248.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/8248","number":8248,"state":"open","locked":false,"title":"[WIP] Using Tox","user":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"body":"This adds a tox config, with envs both for pytest and setup.py, and use it on Travis and CircleCI (docs). \r\nIf run in a python with conda and tox-conda, then a conda env is used.\r\nSo this still relies on ci-helpers to install miniconda, but then the other features like pinning versions are not used. Discussion needed here. We could imagine running a script inside the conda env to do what is done currently by ci-helpers, but I'm not sure about what exactly is needed here (it would probably be great to simplify this!).\r\n\r\n```\r\n❯ tox -lv\r\nusing tox.ini: /home/simon/dev/astropy/tox.ini\r\nusing tox-3.5.3 from /home/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/tox/__init__.py\r\ndefault environments:\r\npy35-pytest     -> run tests with pytest\r\npy35-pytest-all -> run tests with pytest\r\npy35-setup      -> run tests with python setup.py\r\npy35-setup-all  -> run tests with python setup.py\r\npy36-pytest     -> run tests with pytest\r\npy36-pytest-all -> run tests with pytest\r\npy36-setup      -> run tests with python setup.py\r\npy36-setup-all  -> run tests with python setup.py\r\npy37-pytest     -> run tests with pytest\r\npy37-pytest-all -> run tests with pytest\r\npy37-setup      -> run tests with python setup.py\r\npy37-setup-all  -> run tests with python setup.py\r\ndocs            -> invoke sphinx-build to build the HTML docs\r\ndev             -> run with numpy and matplotlib dev versions\r\nflake8          -> [no description]\r\n```\r\n\r\nTODO:\r\n- [ ] Appveyor\r\n- [ ] need more flexibility with tox-conda to use conda only on a given env ? currently everything is run with conda on Travis\r\n- [ ] testing the installed version. Currently `usedevelop` is always used, I will come back to this later.\r\n- [ ] doctests (how is this done currently?)\r\n\r\nSee also:  #8202","created_at":"2018-12-07T12:16:30Z","updated_at":"2018-12-07T22:30:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"750c9f39e194a147ef398422129c7934bc1c91b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":316473427,"node_id":"MDU6TGFiZWwzMTY0NzM0Mjc=","url":"https://api.github.com/repos/astropy/astropy/labels/Refactoring","name":"Refactoring","color":"fef2c0","default":false},{"id":373761720,"node_id":"MDU6TGFiZWwzNzM3NjE3MjA=","url":"https://api.github.com/repos/astropy/astropy/labels/Work%20in%20progress","name":"Work in progress","color":"f9d0c4","default":false},{"id":182098,"node_id":"MDU6TGFiZWwxODIwOTg=","url":"https://api.github.com/repos/astropy/astropy/labels/testing","name":"testing","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/8248/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/8248/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/8248/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/fc80038def303156f9c28e7638588fe32ac9731d","head":{"label":"saimn:tox","ref":"tox","sha":"fc80038def303156f9c28e7638588fe32ac9731d","user":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"repo":{"id":5003242,"node_id":"MDEwOlJlcG9zaXRvcnk1MDAzMjQy","name":"astropy","full_name":"saimn/astropy","private":false,"owner":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/saimn/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/saimn/astropy","forks_url":"https://api.github.com/repos/saimn/astropy/forks","keys_url":"https://api.github.com/repos/saimn/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saimn/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saimn/astropy/teams","hooks_url":"https://api.github.com/repos/saimn/astropy/hooks","issue_events_url":"https://api.github.com/repos/saimn/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/saimn/astropy/events","assignees_url":"https://api.github.com/repos/saimn/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/saimn/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/saimn/astropy/tags","blobs_url":"https://api.github.com/repos/saimn/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saimn/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saimn/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/saimn/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saimn/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/saimn/astropy/languages","stargazers_url":"https://api.github.com/repos/saimn/astropy/stargazers","contributors_url":"https://api.github.com/repos/saimn/astropy/contributors","subscribers_url":"https://api.github.com/repos/saimn/astropy/subscribers","subscription_url":"https://api.github.com/repos/saimn/astropy/subscription","commits_url":"https://api.github.com/repos/saimn/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/saimn/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/saimn/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/saimn/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/saimn/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/saimn/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saimn/astropy/merges","archive_url":"https://api.github.com/repos/saimn/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saimn/astropy/downloads","issues_url":"https://api.github.com/repos/saimn/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/saimn/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/saimn/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/saimn/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saimn/astropy/labels{/name}","releases_url":"https://api.github.com/repos/saimn/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/saimn/astropy/deployments","created_at":"2012-07-12T12:45:57Z","updated_at":"2018-12-07T22:14:11Z","pushed_at":"2018-12-07T22:14:25Z","git_url":"git://github.com/saimn/astropy.git","ssh_url":"git@github.com:saimn/astropy.git","clone_url":"https://github.com/saimn/astropy.git","svn_url":"https://github.com/saimn/astropy","homepage":"astropy.org","size":68408,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"a170a74739e4356c169429a42e554f9777b53f4d","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxMjg5","name":"astropy","full_name":"astropy/astropy","private":false,"owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2018-12-07T22:27:41Z","pushed_at":"2018-12-07T22:27:31Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":77309,"stargazers_count":1935,"watchers_count":1935,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":995,"mirror_url":null,"archived":false,"open_issues_count":953,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":995,"open_issues":953,"watchers":1935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/8248"},"html":{"href":"https://github.com/astropy/astropy/pull/8248"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/8248"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/8248/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/8248/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/8248/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/fc80038def303156f9c28e7638588fe32ac9731d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saimn"}}