{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/reactxp/pulls/comments/224157182","pull_request_review_id":163455679,"id":224157182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDE1NzE4Mg==","diff_hunk":"@@ -179,10 +195,27 @@ export class Image extends React.Component<Types.ImageProps, Types.Stateless> im\n         if (this.props.headers) {\n             source.headers = this.props.headers;\n         }\n+        if (this._forceCache) {\n+            source.cache = 'force-cache';","path":"src/native-common/Image.tsx","position":53,"original_position":53,"commit_id":"564c823d279ba6094eede8f0dd43358104cca62c","original_commit_id":"564c823d279ba6094eede8f0dd43358104cca62c","user":{"login":"berickson1","id":1418465,"node_id":"MDQ6VXNlcjE0MTg0NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1418465?v=4","gravatar_id":"","url":"https://api.github.com/users/berickson1","html_url":"https://github.com/berickson1","followers_url":"https://api.github.com/users/berickson1/followers","following_url":"https://api.github.com/users/berickson1/following{/other_user}","gists_url":"https://api.github.com/users/berickson1/gists{/gist_id}","starred_url":"https://api.github.com/users/berickson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berickson1/subscriptions","organizations_url":"https://api.github.com/users/berickson1/orgs","repos_url":"https://api.github.com/users/berickson1/repos","events_url":"https://api.github.com/users/berickson1/events{/privacy}","received_events_url":"https://api.github.com/users/berickson1/received_events","type":"User","site_admin":false},"body":"Can you explain why you use force-cache instead of only-if-cached?\r\n\r\nforce-cache will try to make a network request if there's no data in the cache, which we already expect won't work (since we're in the failure path)","created_at":"2018-10-10T16:47:27Z","updated_at":"2018-10-10T16:50:36Z","html_url":"https://github.com/Microsoft/reactxp/pull/853#discussion_r224157182","pull_request_url":"https://api.github.com/repos/Microsoft/reactxp/pulls/853","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/reactxp/pulls/comments/224157182"},"html":{"href":"https://github.com/Microsoft/reactxp/pull/853#discussion_r224157182"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/reactxp/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/reactxp/pulls/853","id":221762899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzYyODk5","html_url":"https://github.com/Microsoft/reactxp/pull/853","diff_url":"https://github.com/Microsoft/reactxp/pull/853.diff","patch_url":"https://github.com/Microsoft/reactxp/pull/853.patch","issue_url":"https://api.github.com/repos/Microsoft/reactxp/issues/853","number":853,"state":"open","locked":false,"title":"Emulate Cache-Control: max-stale on iOS","user":{"login":"ladipro","id":12206368,"node_id":"MDQ6VXNlcjEyMjA2MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/12206368?v=4","gravatar_id":"","url":"https://api.github.com/users/ladipro","html_url":"https://github.com/ladipro","followers_url":"https://api.github.com/users/ladipro/followers","following_url":"https://api.github.com/users/ladipro/following{/other_user}","gists_url":"https://api.github.com/users/ladipro/gists{/gist_id}","starred_url":"https://api.github.com/users/ladipro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladipro/subscriptions","organizations_url":"https://api.github.com/users/ladipro/orgs","repos_url":"https://api.github.com/users/ladipro/repos","events_url":"https://api.github.com/users/ladipro/events{/privacy}","received_events_url":"https://api.github.com/users/ladipro/received_events","type":"User","site_admin":false},"body":"iOS does not seem to respect the max-stale header. It does not load\r\nexpired images from the cache unless the force-cache option (internally\r\nNSURLRequestReturnCacheDataElseLoad) is passed.\r\n\r\nWe can't use force-cache always because it has the opposite problem of\r\nloading only from the cache and using stale data even when the app is\r\nonline and the data served under the URL has changed.\r\n\r\nThe proposed solution is to fall back to force-cache only on encountering\r\nthe first error.","created_at":"2018-10-10T12:03:14Z","updated_at":"2018-10-10T16:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb3e90268390117fc32613b1acee0fcc14e10fc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"deregtd","id":2371464,"node_id":"MDQ6VXNlcjIzNzE0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2371464?v=4","gravatar_id":"","url":"https://api.github.com/users/deregtd","html_url":"https://github.com/deregtd","followers_url":"https://api.github.com/users/deregtd/followers","following_url":"https://api.github.com/users/deregtd/following{/other_user}","gists_url":"https://api.github.com/users/deregtd/gists{/gist_id}","starred_url":"https://api.github.com/users/deregtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deregtd/subscriptions","organizations_url":"https://api.github.com/users/deregtd/orgs","repos_url":"https://api.github.com/users/deregtd/repos","events_url":"https://api.github.com/users/deregtd/events{/privacy}","received_events_url":"https://api.github.com/users/deregtd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/reactxp/pulls/853/commits","review_comments_url":"https://api.github.com/repos/Microsoft/reactxp/pulls/853/comments","review_comment_url":"https://api.github.com/repos/Microsoft/reactxp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/reactxp/issues/853/comments","statuses_url":"https://api.github.com/repos/Microsoft/reactxp/statuses/564c823d279ba6094eede8f0dd43358104cca62c","head":{"label":"ladipro:ios-max-stale","ref":"ios-max-stale","sha":"564c823d279ba6094eede8f0dd43358104cca62c","user":{"login":"ladipro","id":12206368,"node_id":"MDQ6VXNlcjEyMjA2MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/12206368?v=4","gravatar_id":"","url":"https://api.github.com/users/ladipro","html_url":"https://github.com/ladipro","followers_url":"https://api.github.com/users/ladipro/followers","following_url":"https://api.github.com/users/ladipro/following{/other_user}","gists_url":"https://api.github.com/users/ladipro/gists{/gist_id}","starred_url":"https://api.github.com/users/ladipro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladipro/subscriptions","organizations_url":"https://api.github.com/users/ladipro/orgs","repos_url":"https://api.github.com/users/ladipro/repos","events_url":"https://api.github.com/users/ladipro/events{/privacy}","received_events_url":"https://api.github.com/users/ladipro/received_events","type":"User","site_admin":false},"repo":{"id":118255441,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyNTU0NDE=","name":"reactxp","full_name":"ladipro/reactxp","private":false,"owner":{"login":"ladipro","id":12206368,"node_id":"MDQ6VXNlcjEyMjA2MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/12206368?v=4","gravatar_id":"","url":"https://api.github.com/users/ladipro","html_url":"https://github.com/ladipro","followers_url":"https://api.github.com/users/ladipro/followers","following_url":"https://api.github.com/users/ladipro/following{/other_user}","gists_url":"https://api.github.com/users/ladipro/gists{/gist_id}","starred_url":"https://api.github.com/users/ladipro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladipro/subscriptions","organizations_url":"https://api.github.com/users/ladipro/orgs","repos_url":"https://api.github.com/users/ladipro/repos","events_url":"https://api.github.com/users/ladipro/events{/privacy}","received_events_url":"https://api.github.com/users/ladipro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ladipro/reactxp","description":"Library for cross-platform app development.","fork":true,"url":"https://api.github.com/repos/ladipro/reactxp","forks_url":"https://api.github.com/repos/ladipro/reactxp/forks","keys_url":"https://api.github.com/repos/ladipro/reactxp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ladipro/reactxp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ladipro/reactxp/teams","hooks_url":"https://api.github.com/repos/ladipro/reactxp/hooks","issue_events_url":"https://api.github.com/repos/ladipro/reactxp/issues/events{/number}","events_url":"https://api.github.com/repos/ladipro/reactxp/events","assignees_url":"https://api.github.com/repos/ladipro/reactxp/assignees{/user}","branches_url":"https://api.github.com/repos/ladipro/reactxp/branches{/branch}","tags_url":"https://api.github.com/repos/ladipro/reactxp/tags","blobs_url":"https://api.github.com/repos/ladipro/reactxp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ladipro/reactxp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ladipro/reactxp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ladipro/reactxp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ladipro/reactxp/statuses/{sha}","languages_url":"https://api.github.com/repos/ladipro/reactxp/languages","stargazers_url":"https://api.github.com/repos/ladipro/reactxp/stargazers","contributors_url":"https://api.github.com/repos/ladipro/reactxp/contributors","subscribers_url":"https://api.github.com/repos/ladipro/reactxp/subscribers","subscription_url":"https://api.github.com/repos/ladipro/reactxp/subscription","commits_url":"https://api.github.com/repos/ladipro/reactxp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ladipro/reactxp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ladipro/reactxp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ladipro/reactxp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ladipro/reactxp/contents/{+path}","compare_url":"https://api.github.com/repos/ladipro/reactxp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ladipro/reactxp/merges","archive_url":"https://api.github.com/repos/ladipro/reactxp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ladipro/reactxp/downloads","issues_url":"https://api.github.com/repos/ladipro/reactxp/issues{/number}","pulls_url":"https://api.github.com/repos/ladipro/reactxp/pulls{/number}","milestones_url":"https://api.github.com/repos/ladipro/reactxp/milestones{/number}","notifications_url":"https://api.github.com/repos/ladipro/reactxp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ladipro/reactxp/labels{/name}","releases_url":"https://api.github.com/repos/ladipro/reactxp/releases{/id}","deployments_url":"https://api.github.com/repos/ladipro/reactxp/deployments","created_at":"2018-01-20T15:33:20Z","updated_at":"2018-05-04T17:00:53Z","pushed_at":"2018-10-10T15:03:42Z","git_url":"git://github.com/ladipro/reactxp.git","ssh_url":"git@github.com:ladipro/reactxp.git","clone_url":"https://github.com/ladipro/reactxp.git","svn_url":"https://github.com/ladipro/reactxp","homepage":"https://microsoft.github.io/reactxp/","size":12476,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"411d476a47888d2d38e98ad72a53aabff8e0d196","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":85866753,"node_id":"MDEwOlJlcG9zaXRvcnk4NTg2Njc1Mw==","name":"reactxp","full_name":"Microsoft/reactxp","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/reactxp","description":"Library for cross-platform app development.","fork":false,"url":"https://api.github.com/repos/Microsoft/reactxp","forks_url":"https://api.github.com/repos/Microsoft/reactxp/forks","keys_url":"https://api.github.com/repos/Microsoft/reactxp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/reactxp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/reactxp/teams","hooks_url":"https://api.github.com/repos/Microsoft/reactxp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/reactxp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/reactxp/events","assignees_url":"https://api.github.com/repos/Microsoft/reactxp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/reactxp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/reactxp/tags","blobs_url":"https://api.github.com/repos/Microsoft/reactxp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/reactxp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/reactxp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/reactxp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/reactxp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/reactxp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/reactxp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/reactxp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/reactxp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/reactxp/subscription","commits_url":"https://api.github.com/repos/Microsoft/reactxp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/reactxp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/reactxp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/reactxp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/reactxp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/reactxp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/reactxp/merges","archive_url":"https://api.github.com/repos/Microsoft/reactxp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/reactxp/downloads","issues_url":"https://api.github.com/repos/Microsoft/reactxp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/reactxp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/reactxp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/reactxp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/reactxp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/reactxp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/reactxp/deployments","created_at":"2017-03-22T19:15:24Z","updated_at":"2018-10-10T14:49:32Z","pushed_at":"2018-10-10T15:03:44Z","git_url":"git://github.com/Microsoft/reactxp.git","ssh_url":"git@github.com:Microsoft/reactxp.git","clone_url":"https://github.com/Microsoft/reactxp.git","svn_url":"https://github.com/Microsoft/reactxp","homepage":"https://microsoft.github.io/reactxp/","size":12262,"stargazers_count":7069,"watchers_count":7069,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":486,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":486,"open_issues":31,"watchers":7069,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/reactxp/pulls/853"},"html":{"href":"https://github.com/Microsoft/reactxp/pull/853"},"issue":{"href":"https://api.github.com/repos/Microsoft/reactxp/issues/853"},"comments":{"href":"https://api.github.com/repos/Microsoft/reactxp/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/reactxp/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/reactxp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/reactxp/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/reactxp/statuses/564c823d279ba6094eede8f0dd43358104cca62c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"berickson1"}}