{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/213628764","pull_request_review_id":150502843,"id":213628764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYyODc2NA==","diff_hunk":"@@ -328,6 +329,18 @@ def run_pre_install():\n         payload.requirements.add_packages(payload.langpacks(), reason=\"langpacks\", strong=False)\n         payload.preInstall()\n \n+        # check if we need the syspurpose package needed for system purpose support\n+        subscription_module = SUBSCRIPTION.get_observer()\n+        subscription_module.connect()\n+        role = subscription_module.proxy.Role\n+        sla = subscription_module.proxy.SLA\n+        usage = subscription_module.proxy.Usage\n+        addons = subscription_module.proxy.Addons\n+        if any((role, sla, usage, addons)):","path":"pyanaconda/installation.py","position":28,"original_position":28,"commit_id":"ac89b1a2660cfe840309ef098abb00aa2c868791","original_commit_id":"ac89b1a2660cfe840309ef098abb00aa2c868791","user":{"login":"M4rtinK","id":829558,"node_id":"MDQ6VXNlcjgyOTU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/829558?v=4","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"body":"Yeah, I was unsure if we want to have that in the DBUS API, but looks like we should. \r\n\r\nAs for the name, I'm thinking about `SystemPurposeSet` as the module is called Subscription and \"enabled\" could be too generic.","created_at":"2018-08-29T10:45:16Z","updated_at":"2018-08-29T10:45:16Z","html_url":"https://github.com/rhinstaller/anaconda/pull/1584#discussion_r213628764","pull_request_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/213628764"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/1584#discussion_r213628764"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584"}},"in_reply_to_id":213576899},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584","id":211533572,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTMzNTcy","html_url":"https://github.com/rhinstaller/anaconda/pull/1584","diff_url":"https://github.com/rhinstaller/anaconda/pull/1584.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/1584.patch","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1584","number":1584,"state":"open","locked":false,"title":"Add system purpose support","user":{"login":"M4rtinK","id":829558,"node_id":"MDQ6VXNlcjgyOTU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/829558?v=4","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"body":"The system purpose functionality is used to give hints to other tools about the\r\nintended usage of the system.\r\n\r\nAnaconda plays adds support for setting system purpose values via\r\nkickstart & GUI and forwards them to the syspurpose tool which is\r\ncalled inside the installed system chroot after the package installation\r\nand configuration phase has been finished.\r\n\r\nAlso as with other kickstart/spoke combos in Anaconda, the values\r\nin kickstart should reflect in the GUI if possible and kickstart\r\ncan thus be used to pre-select system purpose values in the GUI\r\nif needed.\r\n\r\nIf a value from kickstart does not match to any of the valid values,\r\nit will still be forwarded to the syspurpose tool and shown as\r\nOther (<value>) in the GUI.\r\n\r\nThe system purpose support in Anaconda is considered fully optional,\r\nso an installation can be completed without setting any system purpose\r\nvalues in kickstart or GUI. In the same way Anaconda can tolerate\r\nmissing list of valid system purpose values and even no syspurpose utility\r\nbeing available on the installed system.\r\n\r\nResolves: rhbz#1612060","created_at":"2018-08-28T19:35:24Z","updated_at":"2018-08-29T10:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fdefea78004eccde6e237434a7aa6f2051ae862","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":995087181,"node_id":"MDU6TGFiZWw5OTUwODcxODE=","url":"https://api.github.com/repos/rhinstaller/anaconda/labels/rhel-devel","name":"rhel-devel","color":"3ce068","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1584/comments","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/ac89b1a2660cfe840309ef098abb00aa2c868791","head":{"label":"M4rtinK:rhel-devel-system_purpose","ref":"rhel-devel-system_purpose","sha":"ac89b1a2660cfe840309ef098abb00aa2c868791","user":{"login":"M4rtinK","id":829558,"node_id":"MDQ6VXNlcjgyOTU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/829558?v=4","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"repo":{"id":30928257,"node_id":"MDEwOlJlcG9zaXRvcnkzMDkyODI1Nw==","name":"anaconda","full_name":"M4rtinK/anaconda","owner":{"login":"M4rtinK","id":829558,"node_id":"MDQ6VXNlcjgyOTU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/829558?v=4","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/M4rtinK/anaconda","description":"Graphical system installer","fork":true,"url":"https://api.github.com/repos/M4rtinK/anaconda","forks_url":"https://api.github.com/repos/M4rtinK/anaconda/forks","keys_url":"https://api.github.com/repos/M4rtinK/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/M4rtinK/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/M4rtinK/anaconda/teams","hooks_url":"https://api.github.com/repos/M4rtinK/anaconda/hooks","issue_events_url":"https://api.github.com/repos/M4rtinK/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/M4rtinK/anaconda/events","assignees_url":"https://api.github.com/repos/M4rtinK/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/M4rtinK/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/M4rtinK/anaconda/tags","blobs_url":"https://api.github.com/repos/M4rtinK/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/M4rtinK/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/M4rtinK/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/M4rtinK/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/M4rtinK/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/M4rtinK/anaconda/languages","stargazers_url":"https://api.github.com/repos/M4rtinK/anaconda/stargazers","contributors_url":"https://api.github.com/repos/M4rtinK/anaconda/contributors","subscribers_url":"https://api.github.com/repos/M4rtinK/anaconda/subscribers","subscription_url":"https://api.github.com/repos/M4rtinK/anaconda/subscription","commits_url":"https://api.github.com/repos/M4rtinK/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/M4rtinK/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/M4rtinK/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/M4rtinK/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/M4rtinK/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/M4rtinK/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/M4rtinK/anaconda/merges","archive_url":"https://api.github.com/repos/M4rtinK/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/M4rtinK/anaconda/downloads","issues_url":"https://api.github.com/repos/M4rtinK/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/M4rtinK/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/M4rtinK/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/M4rtinK/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/M4rtinK/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/M4rtinK/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/M4rtinK/anaconda/deployments","created_at":"2015-02-17T17:27:17Z","updated_at":"2015-02-17T17:27:20Z","pushed_at":"2018-08-28T19:37:35Z","git_url":"git://github.com/M4rtinK/anaconda.git","ssh_url":"git@github.com:M4rtinK/anaconda.git","clone_url":"https://github.com/M4rtinK/anaconda.git","svn_url":"https://github.com/M4rtinK/anaconda","homepage":null,"size":140064,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:rhel-devel","ref":"rhel-devel","sha":"badc2e0c78e94b03d76632bfe27e2c608ba31088","user":{"login":"rhinstaller","id":10549274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQ5Mjc0","avatar_url":"https://avatars1.githubusercontent.com/u/10549274?v=4","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":30210846,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIxMDg0Ng==","name":"anaconda","full_name":"rhinstaller/anaconda","owner":{"login":"rhinstaller","id":10549274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQ5Mjc0","avatar_url":"https://avatars1.githubusercontent.com/u/10549274?v=4","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/anaconda","description":"Graphical system installer","fork":false,"url":"https://api.github.com/repos/rhinstaller/anaconda","forks_url":"https://api.github.com/repos/rhinstaller/anaconda/forks","keys_url":"https://api.github.com/repos/rhinstaller/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/anaconda/teams","hooks_url":"https://api.github.com/repos/rhinstaller/anaconda/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/anaconda/events","assignees_url":"https://api.github.com/repos/rhinstaller/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/anaconda/tags","blobs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/anaconda/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/anaconda/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/anaconda/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/anaconda/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/anaconda/subscription","commits_url":"https://api.github.com/repos/rhinstaller/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/anaconda/merges","archive_url":"https://api.github.com/repos/rhinstaller/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/anaconda/downloads","issues_url":"https://api.github.com/repos/rhinstaller/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/rhinstaller/anaconda/deployments","created_at":"2015-02-02T21:56:45Z","updated_at":"2018-08-29T09:52:44Z","pushed_at":"2018-08-29T10:16:15Z","git_url":"git://github.com/rhinstaller/anaconda.git","ssh_url":"git@github.com:rhinstaller/anaconda.git","clone_url":"https://github.com/rhinstaller/anaconda.git","svn_url":"https://github.com/rhinstaller/anaconda","homepage":null,"size":143596,"stargazers_count":188,"watchers_count":188,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":149,"open_issues":61,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/1584"},"issue":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/1584"},"comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/1584/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1584/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/anaconda/statuses/ac89b1a2660cfe840309ef098abb00aa2c868791"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"M4rtinK"}}