{"action":"closed","number":110,"pull_request":{"url":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/110","id":221727005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzI3MDA1","html_url":"https://github.com/bugsnag/bugsnag-java/pull/110","diff_url":"https://github.com/bugsnag/bugsnag-java/pull/110.diff","patch_url":"https://github.com/bugsnag/bugsnag-java/pull/110.patch","issue_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/110","number":110,"state":"closed","locked":false,"title":"fix: update autowiring to support spring 4.2.0","user":{"login":"fractalwrench","id":11800640,"node_id":"MDQ6VXNlcjExODAwNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/11800640?v=4","gravatar_id":"","url":"https://api.github.com/users/fractalwrench","html_url":"https://github.com/fractalwrench","followers_url":"https://api.github.com/users/fractalwrench/followers","following_url":"https://api.github.com/users/fractalwrench/following{/other_user}","gists_url":"https://api.github.com/users/fractalwrench/gists{/gist_id}","starred_url":"https://api.github.com/users/fractalwrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractalwrench/subscriptions","organizations_url":"https://api.github.com/users/fractalwrench/orgs","repos_url":"https://api.github.com/users/fractalwrench/repos","events_url":"https://api.github.com/users/fractalwrench/events{/privacy}","received_events_url":"https://api.github.com/users/fractalwrench/received_events","type":"User","site_admin":false},"body":"## Goal\r\n\r\nSpring did not support constructor autowiring before 4.3, meaning we must autowire on fields instead (or inject dependencies manually through the constructor).\r\n\r\nThis changeset alters bugsnag-spring to autowire its configuration classes via fields, which prevents it crashing the application during initialisation.\r\n\r\n## Changeset\r\n\r\n- Separate configuration classes into separate source files\r\n- Autowire via fields, not constructors\r\n\r\n## Tests\r\n\r\nChecked handled/unhandled, async, and scheduled task exceptions on Spring Boot 1.4.1 and Spring 4.2.\r\n\r\nNote: Uncaught exceptions in async methods which return a Future do not appear to be captured by Bugsnag in Spring 4.2.\r\n","created_at":"2018-10-10T09:56:59Z","updated_at":"2018-10-11T12:00:51Z","closed_at":"2018-10-11T12:00:51Z","merged_at":"2018-10-11T12:00:51Z","merge_commit_sha":"1697a7204855ce288d018300771242f7f52406e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/110/commits","review_comments_url":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/110/comments","review_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/110/comments","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-java/statuses/624d459831682c32964f86f583691c3251adb8c6","head":{"label":"bugsnag:autowire-fixes","ref":"autowire-fixes","sha":"624d459831682c32964f86f583691c3251adb8c6","user":{"login":"bugsnag","id":1058895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg4OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"repo":{"id":8467178,"node_id":"MDEwOlJlcG9zaXRvcnk4NDY3MTc4","name":"bugsnag-java","full_name":"bugsnag/bugsnag-java","private":false,"owner":{"login":"bugsnag","id":1058895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg4OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bugsnag/bugsnag-java","description":"Bugsnag error reporting for Java.","fork":false,"url":"https://api.github.com/repos/bugsnag/bugsnag-java","forks_url":"https://api.github.com/repos/bugsnag/bugsnag-java/forks","keys_url":"https://api.github.com/repos/bugsnag/bugsnag-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bugsnag/bugsnag-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bugsnag/bugsnag-java/teams","hooks_url":"https://api.github.com/repos/bugsnag/bugsnag-java/hooks","issue_events_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/events{/number}","events_url":"https://api.github.com/repos/bugsnag/bugsnag-java/events","assignees_url":"https://api.github.com/repos/bugsnag/bugsnag-java/assignees{/user}","branches_url":"https://api.github.com/repos/bugsnag/bugsnag-java/branches{/branch}","tags_url":"https://api.github.com/repos/bugsnag/bugsnag-java/tags","blobs_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-java/statuses/{sha}","languages_url":"https://api.github.com/repos/bugsnag/bugsnag-java/languages","stargazers_url":"https://api.github.com/repos/bugsnag/bugsnag-java/stargazers","contributors_url":"https://api.github.com/repos/bugsnag/bugsnag-java/contributors","subscribers_url":"https://api.github.com/repos/bugsnag/bugsnag-java/subscribers","subscription_url":"https://api.github.com/repos/bugsnag/bugsnag-java/subscription","commits_url":"https://api.github.com/repos/bugsnag/bugsnag-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/bugsnag/bugsnag-java/contents/{+path}","compare_url":"https://api.github.com/repos/bugsnag/bugsnag-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bugsnag/bugsnag-java/merges","archive_url":"https://api.github.com/repos/bugsnag/bugsnag-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bugsnag/bugsnag-java/downloads","issues_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues{/number}","pulls_url":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls{/number}","milestones_url":"https://api.github.com/repos/bugsnag/bugsnag-java/milestones{/number}","notifications_url":"https://api.github.com/repos/bugsnag/bugsnag-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bugsnag/bugsnag-java/labels{/name}","releases_url":"https://api.github.com/repos/bugsnag/bugsnag-java/releases{/id}","deployments_url":"https://api.github.com/repos/bugsnag/bugsnag-java/deployments","created_at":"2013-02-27T22:39:47Z","updated_at":"2018-09-26T10:32:54Z","pushed_at":"2018-10-11T12:00:50Z","git_url":"git://github.com/bugsnag/bugsnag-java.git","ssh_url":"git@github.com:bugsnag/bugsnag-java.git","clone_url":"https://github.com/bugsnag/bugsnag-java.git","svn_url":"https://github.com/bugsnag/bugsnag-java","homepage":"https://www.bugsnag.com/platforms/java/","size":888,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":5,"watchers":38,"default_branch":"master"}},"base":{"label":"bugsnag:spring-improvements","ref":"spring-improvements","sha":"e6b0f8cfd0c9fae23690eb9484b10a05550514db","user":{"login":"bugsnag","id":1058895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg4OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"repo":{"id":8467178,"node_id":"MDEwOlJlcG9zaXRvcnk4NDY3MTc4","name":"bugsnag-java","full_name":"bugsnag/bugsnag-java","private":false,"owner":{"login":"bugsnag","id":1058895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg4OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bugsnag/bugsnag-java","description":"Bugsnag error reporting for Java.","fork":false,"url":"https://api.github.com/repos/bugsnag/bugsnag-java","forks_url":"https://api.github.com/repos/bugsnag/bugsnag-java/forks","keys_url":"https://api.github.com/repos/bugsnag/bugsnag-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bugsnag/bugsnag-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bugsnag/bugsnag-java/teams","hooks_url":"https://api.github.com/repos/bugsnag/bugsnag-java/hooks","issue_events_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/events{/number}","events_url":"https://api.github.com/repos/bugsnag/bugsnag-java/events","assignees_url":"https://api.github.com/repos/bugsnag/bugsnag-java/assignees{/user}","branches_url":"https://api.github.com/repos/bugsnag/bugsnag-java/branches{/branch}","tags_url":"https://api.github.com/repos/bugsnag/bugsnag-java/tags","blobs_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-java/statuses/{sha}","languages_url":"https://api.github.com/repos/bugsnag/bugsnag-java/languages","stargazers_url":"https://api.github.com/repos/bugsnag/bugsnag-java/stargazers","contributors_url":"https://api.github.com/repos/bugsnag/bugsnag-java/contributors","subscribers_url":"https://api.github.com/repos/bugsnag/bugsnag-java/subscribers","subscription_url":"https://api.github.com/repos/bugsnag/bugsnag-java/subscription","commits_url":"https://api.github.com/repos/bugsnag/bugsnag-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/bugsnag/bugsnag-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/bugsnag/bugsnag-java/contents/{+path}","compare_url":"https://api.github.com/repos/bugsnag/bugsnag-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bugsnag/bugsnag-java/merges","archive_url":"https://api.github.com/repos/bugsnag/bugsnag-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bugsnag/bugsnag-java/downloads","issues_url":"https://api.github.com/repos/bugsnag/bugsnag-java/issues{/number}","pulls_url":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls{/number}","milestones_url":"https://api.github.com/repos/bugsnag/bugsnag-java/milestones{/number}","notifications_url":"https://api.github.com/repos/bugsnag/bugsnag-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bugsnag/bugsnag-java/labels{/name}","releases_url":"https://api.github.com/repos/bugsnag/bugsnag-java/releases{/id}","deployments_url":"https://api.github.com/repos/bugsnag/bugsnag-java/deployments","created_at":"2013-02-27T22:39:47Z","updated_at":"2018-09-26T10:32:54Z","pushed_at":"2018-10-11T12:00:50Z","git_url":"git://github.com/bugsnag/bugsnag-java.git","ssh_url":"git@github.com:bugsnag/bugsnag-java.git","clone_url":"https://github.com/bugsnag/bugsnag-java.git","svn_url":"https://github.com/bugsnag/bugsnag-java","homepage":"https://www.bugsnag.com/platforms/java/","size":888,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":5,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/110"},"html":{"href":"https://github.com/bugsnag/bugsnag-java/pull/110"},"issue":{"href":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/110"},"comments":{"href":"https://api.github.com/repos/bugsnag/bugsnag-java/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bugsnag/bugsnag-java/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/bugsnag/bugsnag-java/statuses/624d459831682c32964f86f583691c3251adb8c6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fractalwrench","id":11800640,"node_id":"MDQ6VXNlcjExODAwNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/11800640?v=4","gravatar_id":"","url":"https://api.github.com/users/fractalwrench","html_url":"https://github.com/fractalwrench","followers_url":"https://api.github.com/users/fractalwrench/followers","following_url":"https://api.github.com/users/fractalwrench/following{/other_user}","gists_url":"https://api.github.com/users/fractalwrench/gists{/gist_id}","starred_url":"https://api.github.com/users/fractalwrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractalwrench/subscriptions","organizations_url":"https://api.github.com/users/fractalwrench/orgs","repos_url":"https://api.github.com/users/fractalwrench/repos","events_url":"https://api.github.com/users/fractalwrench/events{/privacy}","received_events_url":"https://api.github.com/users/fractalwrench/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":181,"deletions":149,"changed_files":4}}
{"actor":{"display_login":"fractalwrench"}}