{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/203646037","pull_request_review_id":138574937,"id":203646037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY0NjAzNw==","diff_hunk":"@@ -197,14 +197,6 @@ private boolean resolveAsAlias() {\n \n \t\tString[] columnExpressions = element.getIdentityColumns();","path":"hibernate-core/src/main/java/org/hibernate/hql/internal/ast/tree/IdentNode.java","position":2,"original_position":2,"commit_id":"5d6130c05b8a3c8be224160863af234b337ce394","original_commit_id":"5d6130c05b8a3c8be224160863af234b337ce394","user":{"login":"gsmet","id":1279749,"node_id":"MDQ6VXNlcjEyNzk3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1279749?v=4","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"body":"So the general idea is to fix this `getIdentityColumns()` to avoid needing the workaround below.","created_at":"2018-07-19T08:44:28Z","updated_at":"2018-07-19T08:44:28Z","html_url":"https://github.com/hibernate/hibernate-orm/pull/2439#discussion_r203646037","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/203646037"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/2439#discussion_r203646037"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439","id":202468728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDY4NzI4","html_url":"https://github.com/hibernate/hibernate-orm/pull/2439","diff_url":"https://github.com/hibernate/hibernate-orm/pull/2439.diff","patch_url":"https://github.com/hibernate/hibernate-orm/pull/2439.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2439","number":2439,"state":"open","locked":false,"title":"HHH-12492 Jpa DELETE Query generated has missing table alias and thus incorrect semantics ","user":{"login":"yrodiere","id":412878,"node_id":"MDQ6VXNlcjQxMjg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/412878?v=4","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net//browse/HHH-12492\r\n\r\nGiven the very sensitive section of the code I had to change, maybe we should wait for 5.4 before merging this. That being said, my first attempt was definitely buggy and at least 3 previously existing tests failed as a result, which is reassuring.","created_at":"2018-07-19T07:30:52Z","updated_at":"2018-07-19T08:44:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca03989a16c0f150b95b4ce2e791da5e4729c8cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":979024942,"node_id":"MDU6TGFiZWw5NzkwMjQ5NDI=","url":"https://api.github.com/repos/hibernate/hibernate-orm/labels/5.3","name":"5.3","color":"41db46","default":false},{"id":253382539,"node_id":"MDU6TGFiZWwyNTMzODI1Mzk=","url":"https://api.github.com/repos/hibernate/hibernate-orm/labels/Ready%20for%20review","name":"Ready for review","color":"009800","default":false},{"id":357301438,"node_id":"MDU6TGFiZWwzNTczMDE0Mzg=","url":"https://api.github.com/repos/hibernate/hibernate-orm/labels/Requires%20Gail","name":"Requires Gail","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2439/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/5d6130c05b8a3c8be224160863af234b337ce394","head":{"label":"yrodiere:HHH-12492","ref":"HHH-12492","sha":"5d6130c05b8a3c8be224160863af234b337ce394","user":{"login":"yrodiere","id":412878,"node_id":"MDQ6VXNlcjQxMjg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/412878?v=4","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"repo":{"id":65308576,"node_id":"MDEwOlJlcG9zaXRvcnk2NTMwODU3Ng==","name":"hibernate-orm","full_name":"yrodiere/hibernate-orm","owner":{"login":"yrodiere","id":412878,"node_id":"MDQ6VXNlcjQxMjg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/412878?v=4","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yrodiere/hibernate-orm","description":"Hibernate's core Object/Relational Mapping functionality","fork":true,"url":"https://api.github.com/repos/yrodiere/hibernate-orm","forks_url":"https://api.github.com/repos/yrodiere/hibernate-orm/forks","keys_url":"https://api.github.com/repos/yrodiere/hibernate-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yrodiere/hibernate-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yrodiere/hibernate-orm/teams","hooks_url":"https://api.github.com/repos/yrodiere/hibernate-orm/hooks","issue_events_url":"https://api.github.com/repos/yrodiere/hibernate-orm/issues/events{/number}","events_url":"https://api.github.com/repos/yrodiere/hibernate-orm/events","assignees_url":"https://api.github.com/repos/yrodiere/hibernate-orm/assignees{/user}","branches_url":"https://api.github.com/repos/yrodiere/hibernate-orm/branches{/branch}","tags_url":"https://api.github.com/repos/yrodiere/hibernate-orm/tags","blobs_url":"https://api.github.com/repos/yrodiere/hibernate-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yrodiere/hibernate-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yrodiere/hibernate-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/yrodiere/hibernate-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yrodiere/hibernate-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/yrodiere/hibernate-orm/languages","stargazers_url":"https://api.github.com/repos/yrodiere/hibernate-orm/stargazers","contributors_url":"https://api.github.com/repos/yrodiere/hibernate-orm/contributors","subscribers_url":"https://api.github.com/repos/yrodiere/hibernate-orm/subscribers","subscription_url":"https://api.github.com/repos/yrodiere/hibernate-orm/subscription","commits_url":"https://api.github.com/repos/yrodiere/hibernate-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/yrodiere/hibernate-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/yrodiere/hibernate-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/yrodiere/hibernate-orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/yrodiere/hibernate-orm/contents/{+path}","compare_url":"https://api.github.com/repos/yrodiere/hibernate-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yrodiere/hibernate-orm/merges","archive_url":"https://api.github.com/repos/yrodiere/hibernate-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yrodiere/hibernate-orm/downloads","issues_url":"https://api.github.com/repos/yrodiere/hibernate-orm/issues{/number}","pulls_url":"https://api.github.com/repos/yrodiere/hibernate-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/yrodiere/hibernate-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/yrodiere/hibernate-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yrodiere/hibernate-orm/labels{/name}","releases_url":"https://api.github.com/repos/yrodiere/hibernate-orm/releases{/id}","deployments_url":"https://api.github.com/repos/yrodiere/hibernate-orm/deployments","created_at":"2016-08-09T15:57:34Z","updated_at":"2016-08-09T15:57:58Z","pushed_at":"2018-07-19T08:42:25Z","git_url":"git://github.com/yrodiere/hibernate-orm.git","ssh_url":"git@github.com:yrodiere/hibernate-orm.git","clone_url":"https://github.com/yrodiere/hibernate-orm.git","svn_url":"https://github.com/yrodiere/hibernate-orm","homepage":"http://hibernate.org","size":167102,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"f8964847dd40f64e1f478eba47c767be98742125","user":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":961036,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEwMzY=","name":"hibernate-orm","full_name":"hibernate/hibernate-orm","owner":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-orm","description":"Hibernate's core Object/Relational Mapping functionality","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-orm","forks_url":"https://api.github.com/repos/hibernate/hibernate-orm/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-orm/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-orm/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-orm/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-orm/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-orm/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-orm/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-orm/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-orm/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-orm/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-orm/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-orm/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-orm/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-orm/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-orm/deployments","created_at":"2010-10-04T16:15:52Z","updated_at":"2018-07-19T08:41:57Z","pushed_at":"2018-07-19T08:42:30Z","git_url":"git://github.com/hibernate/hibernate-orm.git","ssh_url":"git@github.com:hibernate/hibernate-orm.git","clone_url":"https://github.com/hibernate/hibernate-orm.git","svn_url":"https://github.com/hibernate/hibernate-orm","homepage":"http://hibernate.org","size":159588,"stargazers_count":3288,"watchers_count":3288,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2257,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":2257,"open_issues":88,"watchers":3288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/2439"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2439"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2439/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2439/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/5d6130c05b8a3c8be224160863af234b337ce394"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gsmet"}}