{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/217878671","pull_request_review_id":155706711,"id":217878671,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg3ODY3MQ==","diff_hunk":"@@ -13,57 +13,16 @@ namespace System.Text.Primitives.Benchmarks\n {\n     public partial class PrimitiveParserPerfTests\n     {\n-        private static readonly string[] s_Int16TextArray = new string[13]\n-        {\n-            \"21474\",\n-            \"2\",\n-            \"-21474\",\n-            \"31484\",\n-            \"-21\",\n-            \"-2\",\n-            \"214\",\n-            \"2147\",\n-            \"-2147\",\n-            \"-9345\",\n-            \"9345\",\n-            \"1000\",\n-            \"-214\"\n-        };\n-\n-        public IEnumerable<object> PrimitiveParserByteSpanToInt16_VariableLength_Arguments()\n-            => s_Int16TextArray.Select(text => new Utf8ByteArrayArgument(text));\n-        \n-        public IEnumerable<object> PrimitiveParserByteSpanToInt16_Arguments()\n-        {\n-            yield return new Utf8ByteArrayArgument(\"10737\"); // standard parse\n-            yield return new Utf8ByteArrayArgument(\"32767\"); // max value\n-            yield return new Utf8ByteArrayArgument(\"0\"); \n-            yield return new Utf8ByteArrayArgument(\"-32768\"); // min value\n-            yield return new Utf8ByteArrayArgument(\"-000000000000000000001235abcdfg\");\n-            yield return new Utf8ByteArrayArgument(\"-2147abcdefghijklmnop\");\n+        public IEnumerable<object> ByteSpanToInt16_Arguments()\t\t\n+        {\t\t\n+            yield return new Utf8ByteArrayArgument(\"10737\");\t\t\n+            yield return new Utf8ByteArrayArgument(\"21474\");\t\n+            yield return new Utf8ByteArrayArgument(\"0\"); \t\t\n+            yield return new Utf8ByteArrayArgument(\"000000000000000000001235abcdfg\");\t\t\n+            yield return new Utf8ByteArrayArgument(\"2147abcdefghijklmnop\");\t\t","path":"tests/Benchmarks/System.Text.Primitives/PrimitiveParserInt16PerfTests.cs","position":null,"original_position":38,"commit_id":"8a498558f30d449b5835c6ad660e429b01215aab","original_commit_id":"655377ed569c6d433e373daa5b3f82e902f1025f","user":{"login":"fredeil","id":17533404,"node_id":"MDQ6VXNlcjE3NTMzNDA0","avatar_url":"https://avatars1.githubusercontent.com/u/17533404?v=4","gravatar_id":"","url":"https://api.github.com/users/fredeil","html_url":"https://github.com/fredeil","followers_url":"https://api.github.com/users/fredeil/followers","following_url":"https://api.github.com/users/fredeil/following{/other_user}","gists_url":"https://api.github.com/users/fredeil/gists{/gist_id}","starred_url":"https://api.github.com/users/fredeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredeil/subscriptions","organizations_url":"https://api.github.com/users/fredeil/orgs","repos_url":"https://api.github.com/users/fredeil/repos","events_url":"https://api.github.com/users/fredeil/events{/privacy}","received_events_url":"https://api.github.com/users/fredeil/received_events","type":"User","site_admin":false},"body":"They should now","created_at":"2018-09-15T07:39:10Z","updated_at":"2018-09-15T07:39:10Z","html_url":"https://github.com/dotnet/corefxlab/pull/2478#discussion_r217878671","pull_request_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/217878671"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/2478#discussion_r217878671"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478"}},"in_reply_to_id":217878297},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478","id":215670595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjcwNTk1","html_url":"https://github.com/dotnet/corefxlab/pull/2478","diff_url":"https://github.com/dotnet/corefxlab/pull/2478.diff","patch_url":"https://github.com/dotnet/corefxlab/pull/2478.patch","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2478","number":2478,"state":"open","locked":false,"title":"Cleanup Utf8Parser tests","user":{"login":"fredeil","id":17533404,"node_id":"MDQ6VXNlcjE3NTMzNDA0","avatar_url":"https://avatars1.githubusercontent.com/u/17533404?v=4","gravatar_id":"","url":"https://api.github.com/users/fredeil","html_url":"https://github.com/fredeil","followers_url":"https://api.github.com/users/fredeil/followers","following_url":"https://api.github.com/users/fredeil/following{/other_user}","gists_url":"https://api.github.com/users/fredeil/gists{/gist_id}","starred_url":"https://api.github.com/users/fredeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredeil/subscriptions","organizations_url":"https://api.github.com/users/fredeil/orgs","repos_url":"https://api.github.com/users/fredeil/repos","events_url":"https://api.github.com/users/fredeil/events{/privacy}","received_events_url":"https://api.github.com/users/fredeil/received_events","type":"User","site_admin":false},"body":"Remove all redundant performance tests after moving them over to corefx (see https://github.com/dotnet/corefx/pull/32026) as requested here in https://github.com/dotnet/corefxlab/issues/2322#issuecomment-420903697.\r\n\r\nI left the special cases like thai parsing, since they were not moved to the corefx repo\r\n\r\nThis closes #2322.","created_at":"2018-09-14T18:08:37Z","updated_at":"2018-09-15T07:39:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae4ebf08ae26845bccb0293e7bc9158250ccc36b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2478/comments","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/8a498558f30d449b5835c6ad660e429b01215aab","head":{"label":"fredeil:cleanup-utf8parser","ref":"cleanup-utf8parser","sha":"8a498558f30d449b5835c6ad660e429b01215aab","user":{"login":"fredeil","id":17533404,"node_id":"MDQ6VXNlcjE3NTMzNDA0","avatar_url":"https://avatars1.githubusercontent.com/u/17533404?v=4","gravatar_id":"","url":"https://api.github.com/users/fredeil","html_url":"https://github.com/fredeil","followers_url":"https://api.github.com/users/fredeil/followers","following_url":"https://api.github.com/users/fredeil/following{/other_user}","gists_url":"https://api.github.com/users/fredeil/gists{/gist_id}","starred_url":"https://api.github.com/users/fredeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredeil/subscriptions","organizations_url":"https://api.github.com/users/fredeil/orgs","repos_url":"https://api.github.com/users/fredeil/repos","events_url":"https://api.github.com/users/fredeil/events{/privacy}","received_events_url":"https://api.github.com/users/fredeil/received_events","type":"User","site_admin":false},"repo":{"id":148166818,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxNjY4MTg=","name":"corefxlab","full_name":"fredeil/corefxlab","owner":{"login":"fredeil","id":17533404,"node_id":"MDQ6VXNlcjE3NTMzNDA0","avatar_url":"https://avatars1.githubusercontent.com/u/17533404?v=4","gravatar_id":"","url":"https://api.github.com/users/fredeil","html_url":"https://github.com/fredeil","followers_url":"https://api.github.com/users/fredeil/followers","following_url":"https://api.github.com/users/fredeil/following{/other_user}","gists_url":"https://api.github.com/users/fredeil/gists{/gist_id}","starred_url":"https://api.github.com/users/fredeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredeil/subscriptions","organizations_url":"https://api.github.com/users/fredeil/orgs","repos_url":"https://api.github.com/users/fredeil/repos","events_url":"https://api.github.com/users/fredeil/events{/privacy}","received_events_url":"https://api.github.com/users/fredeil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fredeil/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":true,"url":"https://api.github.com/repos/fredeil/corefxlab","forks_url":"https://api.github.com/repos/fredeil/corefxlab/forks","keys_url":"https://api.github.com/repos/fredeil/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fredeil/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fredeil/corefxlab/teams","hooks_url":"https://api.github.com/repos/fredeil/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/fredeil/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/fredeil/corefxlab/events","assignees_url":"https://api.github.com/repos/fredeil/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/fredeil/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/fredeil/corefxlab/tags","blobs_url":"https://api.github.com/repos/fredeil/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fredeil/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fredeil/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/fredeil/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fredeil/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/fredeil/corefxlab/languages","stargazers_url":"https://api.github.com/repos/fredeil/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/fredeil/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/fredeil/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/fredeil/corefxlab/subscription","commits_url":"https://api.github.com/repos/fredeil/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/fredeil/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/fredeil/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/fredeil/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/fredeil/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/fredeil/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fredeil/corefxlab/merges","archive_url":"https://api.github.com/repos/fredeil/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fredeil/corefxlab/downloads","issues_url":"https://api.github.com/repos/fredeil/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/fredeil/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/fredeil/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/fredeil/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fredeil/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/fredeil/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/fredeil/corefxlab/deployments","created_at":"2018-09-10T14:19:37Z","updated_at":"2018-09-14T17:56:00Z","pushed_at":"2018-09-15T07:38:58Z","git_url":"git://github.com/fredeil/corefxlab.git","ssh_url":"git@github.com:fredeil/corefxlab.git","clone_url":"https://github.com/fredeil/corefxlab.git","svn_url":"https://github.com/fredeil/corefxlab","homepage":"","size":57527,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ef7dd7bffcb1eedda5ed27e63b59af9c6b365a26","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29504192,"node_id":"MDEwOlJlcG9zaXRvcnkyOTUwNDE5Mg==","name":"corefxlab","full_name":"dotnet/corefxlab","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":false,"url":"https://api.github.com/repos/dotnet/corefxlab","forks_url":"https://api.github.com/repos/dotnet/corefxlab/forks","keys_url":"https://api.github.com/repos/dotnet/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefxlab/teams","hooks_url":"https://api.github.com/repos/dotnet/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefxlab/events","assignees_url":"https://api.github.com/repos/dotnet/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefxlab/tags","blobs_url":"https://api.github.com/repos/dotnet/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefxlab/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefxlab/subscription","commits_url":"https://api.github.com/repos/dotnet/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefxlab/merges","archive_url":"https://api.github.com/repos/dotnet/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefxlab/downloads","issues_url":"https://api.github.com/repos/dotnet/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefxlab/deployments","created_at":"2015-01-20T00:44:35Z","updated_at":"2018-09-14T14:29:31Z","pushed_at":"2018-09-15T07:38:59Z","git_url":"git://github.com/dotnet/corefxlab.git","ssh_url":"git@github.com:dotnet/corefxlab.git","clone_url":"https://github.com/dotnet/corefxlab.git","svn_url":"https://github.com/dotnet/corefxlab","homepage":"","size":57499,"stargazers_count":1175,"watchers_count":1175,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":305,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":305,"open_issues":197,"watchers":1175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/2478"},"issue":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/2478"},"comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/2478/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/2478/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefxlab/statuses/8a498558f30d449b5835c6ad660e429b01215aab"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fredeil"}}