{"action":"opened","number":94,"pull_request":{"url":"https://api.github.com/repos/thepowersgang/mrustc/pulls/94","id":234815653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODE1NjUz","html_url":"https://github.com/thepowersgang/mrustc/pull/94","diff_url":"https://github.com/thepowersgang/mrustc/pull/94.diff","patch_url":"https://github.com/thepowersgang/mrustc/pull/94.patch","issue_url":"https://api.github.com/repos/thepowersgang/mrustc/issues/94","number":94,"state":"open","locked":false,"title":"Mark destructors on base classes as virtual","user":{"login":"arlied-google","id":14058884,"node_id":"MDQ6VXNlcjE0MDU4ODg0","avatar_url":"https://avatars1.githubusercontent.com/u/14058884?v=4","gravatar_id":"","url":"https://api.github.com/users/arlied-google","html_url":"https://github.com/arlied-google","followers_url":"https://api.github.com/users/arlied-google/followers","following_url":"https://api.github.com/users/arlied-google/following{/other_user}","gists_url":"https://api.github.com/users/arlied-google/gists{/gist_id}","starred_url":"https://api.github.com/users/arlied-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arlied-google/subscriptions","organizations_url":"https://api.github.com/users/arlied-google/orgs","repos_url":"https://api.github.com/users/arlied-google/repos","events_url":"https://api.github.com/users/arlied-google/events{/privacy}","received_events_url":"https://api.github.com/users/arlied-google/received_events","type":"User","site_admin":false},"body":"In many situations, objects are deleted by deleting a pointer to their base class. In the previous code, these destructors were non-virtual. This violates a C++ rule (so it's undefined behavior), and on some platforms (such as Clang with -fsized-deallocation), this violation is detected and causes mrustc to abort.\r\n\r\nThe fix is simple; mark the relevant destructors as virtual.\r\n","created_at":"2018-11-29T22:58:27Z","updated_at":"2018-11-29T22:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thepowersgang/mrustc/pulls/94/commits","review_comments_url":"https://api.github.com/repos/thepowersgang/mrustc/pulls/94/comments","review_comment_url":"https://api.github.com/repos/thepowersgang/mrustc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thepowersgang/mrustc/issues/94/comments","statuses_url":"https://api.github.com/repos/thepowersgang/mrustc/statuses/c4939c4e12ac66aa3ac92470169abca16bb9ce5b","head":{"label":"arlied-google:fixes","ref":"fixes","sha":"c4939c4e12ac66aa3ac92470169abca16bb9ce5b","user":{"login":"arlied-google","id":14058884,"node_id":"MDQ6VXNlcjE0MDU4ODg0","avatar_url":"https://avatars1.githubusercontent.com/u/14058884?v=4","gravatar_id":"","url":"https://api.github.com/users/arlied-google","html_url":"https://github.com/arlied-google","followers_url":"https://api.github.com/users/arlied-google/followers","following_url":"https://api.github.com/users/arlied-google/following{/other_user}","gists_url":"https://api.github.com/users/arlied-google/gists{/gist_id}","starred_url":"https://api.github.com/users/arlied-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arlied-google/subscriptions","organizations_url":"https://api.github.com/users/arlied-google/orgs","repos_url":"https://api.github.com/users/arlied-google/repos","events_url":"https://api.github.com/users/arlied-google/events{/privacy}","received_events_url":"https://api.github.com/users/arlied-google/received_events","type":"User","site_admin":false},"repo":{"id":158466755,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0NjY3NTU=","name":"mrustc","full_name":"arlied-google/mrustc","private":false,"owner":{"login":"arlied-google","id":14058884,"node_id":"MDQ6VXNlcjE0MDU4ODg0","avatar_url":"https://avatars1.githubusercontent.com/u/14058884?v=4","gravatar_id":"","url":"https://api.github.com/users/arlied-google","html_url":"https://github.com/arlied-google","followers_url":"https://api.github.com/users/arlied-google/followers","following_url":"https://api.github.com/users/arlied-google/following{/other_user}","gists_url":"https://api.github.com/users/arlied-google/gists{/gist_id}","starred_url":"https://api.github.com/users/arlied-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arlied-google/subscriptions","organizations_url":"https://api.github.com/users/arlied-google/orgs","repos_url":"https://api.github.com/users/arlied-google/repos","events_url":"https://api.github.com/users/arlied-google/events{/privacy}","received_events_url":"https://api.github.com/users/arlied-google/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arlied-google/mrustc","description":"Alternative rust compiler (re-implementation)","fork":true,"url":"https://api.github.com/repos/arlied-google/mrustc","forks_url":"https://api.github.com/repos/arlied-google/mrustc/forks","keys_url":"https://api.github.com/repos/arlied-google/mrustc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arlied-google/mrustc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arlied-google/mrustc/teams","hooks_url":"https://api.github.com/repos/arlied-google/mrustc/hooks","issue_events_url":"https://api.github.com/repos/arlied-google/mrustc/issues/events{/number}","events_url":"https://api.github.com/repos/arlied-google/mrustc/events","assignees_url":"https://api.github.com/repos/arlied-google/mrustc/assignees{/user}","branches_url":"https://api.github.com/repos/arlied-google/mrustc/branches{/branch}","tags_url":"https://api.github.com/repos/arlied-google/mrustc/tags","blobs_url":"https://api.github.com/repos/arlied-google/mrustc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arlied-google/mrustc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arlied-google/mrustc/git/refs{/sha}","trees_url":"https://api.github.com/repos/arlied-google/mrustc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arlied-google/mrustc/statuses/{sha}","languages_url":"https://api.github.com/repos/arlied-google/mrustc/languages","stargazers_url":"https://api.github.com/repos/arlied-google/mrustc/stargazers","contributors_url":"https://api.github.com/repos/arlied-google/mrustc/contributors","subscribers_url":"https://api.github.com/repos/arlied-google/mrustc/subscribers","subscription_url":"https://api.github.com/repos/arlied-google/mrustc/subscription","commits_url":"https://api.github.com/repos/arlied-google/mrustc/commits{/sha}","git_commits_url":"https://api.github.com/repos/arlied-google/mrustc/git/commits{/sha}","comments_url":"https://api.github.com/repos/arlied-google/mrustc/comments{/number}","issue_comment_url":"https://api.github.com/repos/arlied-google/mrustc/issues/comments{/number}","contents_url":"https://api.github.com/repos/arlied-google/mrustc/contents/{+path}","compare_url":"https://api.github.com/repos/arlied-google/mrustc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arlied-google/mrustc/merges","archive_url":"https://api.github.com/repos/arlied-google/mrustc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arlied-google/mrustc/downloads","issues_url":"https://api.github.com/repos/arlied-google/mrustc/issues{/number}","pulls_url":"https://api.github.com/repos/arlied-google/mrustc/pulls{/number}","milestones_url":"https://api.github.com/repos/arlied-google/mrustc/milestones{/number}","notifications_url":"https://api.github.com/repos/arlied-google/mrustc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arlied-google/mrustc/labels{/name}","releases_url":"https://api.github.com/repos/arlied-google/mrustc/releases{/id}","deployments_url":"https://api.github.com/repos/arlied-google/mrustc/deployments","created_at":"2018-11-21T00:04:45Z","updated_at":"2018-11-28T21:40:32Z","pushed_at":"2018-11-29T22:53:47Z","git_url":"git://github.com/arlied-google/mrustc.git","ssh_url":"git@github.com:arlied-google/mrustc.git","clone_url":"https://github.com/arlied-google/mrustc.git","svn_url":"https://github.com/arlied-google/mrustc","homepage":null,"size":8786,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thepowersgang:master","ref":"master","sha":"146483f00b7e8014b7abd2a382d993daabaf3359","user":{"login":"thepowersgang","id":955596,"node_id":"MDQ6VXNlcjk1NTU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/955596?v=4","gravatar_id":"","url":"https://api.github.com/users/thepowersgang","html_url":"https://github.com/thepowersgang","followers_url":"https://api.github.com/users/thepowersgang/followers","following_url":"https://api.github.com/users/thepowersgang/following{/other_user}","gists_url":"https://api.github.com/users/thepowersgang/gists{/gist_id}","starred_url":"https://api.github.com/users/thepowersgang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepowersgang/subscriptions","organizations_url":"https://api.github.com/users/thepowersgang/orgs","repos_url":"https://api.github.com/users/thepowersgang/repos","events_url":"https://api.github.com/users/thepowersgang/events{/privacy}","received_events_url":"https://api.github.com/users/thepowersgang/received_events","type":"User","site_admin":false},"repo":{"id":27268808,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI2ODgwOA==","name":"mrustc","full_name":"thepowersgang/mrustc","private":false,"owner":{"login":"thepowersgang","id":955596,"node_id":"MDQ6VXNlcjk1NTU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/955596?v=4","gravatar_id":"","url":"https://api.github.com/users/thepowersgang","html_url":"https://github.com/thepowersgang","followers_url":"https://api.github.com/users/thepowersgang/followers","following_url":"https://api.github.com/users/thepowersgang/following{/other_user}","gists_url":"https://api.github.com/users/thepowersgang/gists{/gist_id}","starred_url":"https://api.github.com/users/thepowersgang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepowersgang/subscriptions","organizations_url":"https://api.github.com/users/thepowersgang/orgs","repos_url":"https://api.github.com/users/thepowersgang/repos","events_url":"https://api.github.com/users/thepowersgang/events{/privacy}","received_events_url":"https://api.github.com/users/thepowersgang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thepowersgang/mrustc","description":"Alternative rust compiler (re-implementation)","fork":false,"url":"https://api.github.com/repos/thepowersgang/mrustc","forks_url":"https://api.github.com/repos/thepowersgang/mrustc/forks","keys_url":"https://api.github.com/repos/thepowersgang/mrustc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thepowersgang/mrustc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thepowersgang/mrustc/teams","hooks_url":"https://api.github.com/repos/thepowersgang/mrustc/hooks","issue_events_url":"https://api.github.com/repos/thepowersgang/mrustc/issues/events{/number}","events_url":"https://api.github.com/repos/thepowersgang/mrustc/events","assignees_url":"https://api.github.com/repos/thepowersgang/mrustc/assignees{/user}","branches_url":"https://api.github.com/repos/thepowersgang/mrustc/branches{/branch}","tags_url":"https://api.github.com/repos/thepowersgang/mrustc/tags","blobs_url":"https://api.github.com/repos/thepowersgang/mrustc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thepowersgang/mrustc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thepowersgang/mrustc/git/refs{/sha}","trees_url":"https://api.github.com/repos/thepowersgang/mrustc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thepowersgang/mrustc/statuses/{sha}","languages_url":"https://api.github.com/repos/thepowersgang/mrustc/languages","stargazers_url":"https://api.github.com/repos/thepowersgang/mrustc/stargazers","contributors_url":"https://api.github.com/repos/thepowersgang/mrustc/contributors","subscribers_url":"https://api.github.com/repos/thepowersgang/mrustc/subscribers","subscription_url":"https://api.github.com/repos/thepowersgang/mrustc/subscription","commits_url":"https://api.github.com/repos/thepowersgang/mrustc/commits{/sha}","git_commits_url":"https://api.github.com/repos/thepowersgang/mrustc/git/commits{/sha}","comments_url":"https://api.github.com/repos/thepowersgang/mrustc/comments{/number}","issue_comment_url":"https://api.github.com/repos/thepowersgang/mrustc/issues/comments{/number}","contents_url":"https://api.github.com/repos/thepowersgang/mrustc/contents/{+path}","compare_url":"https://api.github.com/repos/thepowersgang/mrustc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thepowersgang/mrustc/merges","archive_url":"https://api.github.com/repos/thepowersgang/mrustc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thepowersgang/mrustc/downloads","issues_url":"https://api.github.com/repos/thepowersgang/mrustc/issues{/number}","pulls_url":"https://api.github.com/repos/thepowersgang/mrustc/pulls{/number}","milestones_url":"https://api.github.com/repos/thepowersgang/mrustc/milestones{/number}","notifications_url":"https://api.github.com/repos/thepowersgang/mrustc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thepowersgang/mrustc/labels{/name}","releases_url":"https://api.github.com/repos/thepowersgang/mrustc/releases{/id}","deployments_url":"https://api.github.com/repos/thepowersgang/mrustc/deployments","created_at":"2014-11-28T13:47:44Z","updated_at":"2018-11-28T16:16:26Z","pushed_at":"2018-11-24T06:51:43Z","git_url":"git://github.com/thepowersgang/mrustc.git","ssh_url":"git@github.com:thepowersgang/mrustc.git","clone_url":"https://github.com/thepowersgang/mrustc.git","svn_url":"https://github.com/thepowersgang/mrustc","homepage":null,"size":8786,"stargazers_count":665,"watchers_count":665,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":11,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thepowersgang/mrustc/pulls/94"},"html":{"href":"https://github.com/thepowersgang/mrustc/pull/94"},"issue":{"href":"https://api.github.com/repos/thepowersgang/mrustc/issues/94"},"comments":{"href":"https://api.github.com/repos/thepowersgang/mrustc/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/thepowersgang/mrustc/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/thepowersgang/mrustc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thepowersgang/mrustc/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/thepowersgang/mrustc/statuses/c4939c4e12ac66aa3ac92470169abca16bb9ce5b"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":6,"deletions":0,"changed_files":6}}
{"actor":{"display_login":"arlied-google"}}