{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/236461743","pull_request_review_id":178542531,"id":236461743,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjQ2MTc0Mw==","diff_hunk":"@@ -384,5 +384,27 @@\n         end\n       end\n     end\n+\n+    describe \"publish event\" do\n+      context \"with blank args\" do\n+        it \"resource action calls automate_queue_hash\" do\n+          Timecop.freeze(Time.now.utc) do\n+            expect(resource_action).to receive(:automate_queue_hash).with(vm, {}, user).and_return(:username => \"foo\")\n+\n+            User.with_user(user) { custom_button.publish_event('UI', vm) }\n+          end\n+        end\n+      end\n+\n+      context \"with args\" do\n+        it \"resource action doesn't call automate_queue_hash\" do\n+          Timecop.freeze(Time.now.utc) do\n+            expect(resource_action).not_to receive(:automate_queue_hash).with(vm, {}, user)","path":"spec/models/custom_button_spec.rb","position":19,"original_position":19,"commit_id":"c1fec3cd3ebfc70b8748a1d087dca692c622e88a","original_commit_id":"c1fec3cd3ebfc70b8748a1d087dca692c622e88a","user":{"login":"gmcculloug","id":2591569,"node_id":"MDQ6VXNlcjI1OTE1Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/2591569?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"body":"You can drop the `with(<params>)` since you do not expect it to be called at all.","created_at":"2018-11-26T23:02:11Z","updated_at":"2018-11-26T23:02:15Z","html_url":"https://github.com/ManageIQ/manageiq/pull/18178#discussion_r236461743","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/236461743"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/18178#discussion_r236461743"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178","id":229480482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDgwNDgy","html_url":"https://github.com/ManageIQ/manageiq/pull/18178","diff_url":"https://github.com/ManageIQ/manageiq/pull/18178.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/18178.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/18178","number":18178,"state":"open","locked":false,"title":"Separate queue put from publish event so we don't queue put twice","user":{"login":"d-m-u","id":16326669,"node_id":"MDQ6VXNlcjE2MzI2NjY5","avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"body":"The main repo part of https://github.com/ManageIQ/manageiq-api/pull/506/files. We're currently not creating custom button events for custom buttons with dialogs, because invoke never gets called. But invoke also does a queue put, which both custom buttons with and without dialogs handle, so the line to create custom button events needed to be later than the queue put as to not do the queue twice. \r\n\r\n\r\n\r\n## related \r\nhttps://github.com/ManageIQ/manageiq-api/pull/506","created_at":"2018-11-08T19:23:29Z","updated_at":"2018-11-26T23:02:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d340b70619e861f00eaba9d2da0f93d2ef2a54b4","assignee":{"login":"gmcculloug","id":2591569,"node_id":"MDQ6VXNlcjI1OTE1Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/2591569?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmcculloug","id":2591569,"node_id":"MDQ6VXNlcjI1OTE1Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/2591569?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bdunne","id":651659,"node_id":"MDQ6VXNlcjY1MTY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/651659?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},{"login":"mkanoor","id":6452699,"node_id":"MDQ6VXNlcjY0NTI2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6452699?v=4","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":382968361,"node_id":"MDU6TGFiZWwzODI5NjgzNjE=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/blocker","name":"blocker","color":"000000","default":false},{"id":106615676,"node_id":"MDU6TGFiZWwxMDY2MTU2NzY=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"ee0701","default":true},{"id":1069066996,"node_id":"MDU6TGFiZWwxMDY5MDY2OTk2","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/hammer/yes","name":"hammer/yes","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/18178/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/c1fec3cd3ebfc70b8748a1d087dca692c622e88a","head":{"label":"d-m-u:main_bz_bz1511126","ref":"main_bz_bz1511126","sha":"c1fec3cd3ebfc70b8748a1d087dca692c622e88a","user":{"login":"d-m-u","id":16326669,"node_id":"MDQ6VXNlcjE2MzI2NjY5","avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"repo":{"id":97605552,"node_id":"MDEwOlJlcG9zaXRvcnk5NzYwNTU1Mg==","name":"manageiq","full_name":"d-m-u/manageiq","private":false,"owner":{"login":"d-m-u","id":16326669,"node_id":"MDQ6VXNlcjE2MzI2NjY5","avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"html_url":"https://github.com/d-m-u/manageiq","description":"ManageIQ Open-Source Management Platform","fork":true,"url":"https://api.github.com/repos/d-m-u/manageiq","forks_url":"https://api.github.com/repos/d-m-u/manageiq/forks","keys_url":"https://api.github.com/repos/d-m-u/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-m-u/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-m-u/manageiq/teams","hooks_url":"https://api.github.com/repos/d-m-u/manageiq/hooks","issue_events_url":"https://api.github.com/repos/d-m-u/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/d-m-u/manageiq/events","assignees_url":"https://api.github.com/repos/d-m-u/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/d-m-u/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/d-m-u/manageiq/tags","blobs_url":"https://api.github.com/repos/d-m-u/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-m-u/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-m-u/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-m-u/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-m-u/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/d-m-u/manageiq/languages","stargazers_url":"https://api.github.com/repos/d-m-u/manageiq/stargazers","contributors_url":"https://api.github.com/repos/d-m-u/manageiq/contributors","subscribers_url":"https://api.github.com/repos/d-m-u/manageiq/subscribers","subscription_url":"https://api.github.com/repos/d-m-u/manageiq/subscription","commits_url":"https://api.github.com/repos/d-m-u/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-m-u/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-m-u/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-m-u/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-m-u/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/d-m-u/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-m-u/manageiq/merges","archive_url":"https://api.github.com/repos/d-m-u/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-m-u/manageiq/downloads","issues_url":"https://api.github.com/repos/d-m-u/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/d-m-u/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/d-m-u/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/d-m-u/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-m-u/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/d-m-u/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/d-m-u/manageiq/deployments","created_at":"2017-07-18T14:05:43Z","updated_at":"2018-06-06T19:26:47Z","pushed_at":"2018-11-26T20:41:33Z","git_url":"git://github.com/d-m-u/manageiq.git","ssh_url":"git@github.com:d-m-u/manageiq.git","clone_url":"https://github.com/d-m-u/manageiq.git","svn_url":"https://github.com/d-m-u/manageiq","homepage":"manageiq.org","size":240976,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"c9d1e4d6d7e1b52a8bf19687918e844d924909ec","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc4OTc1Nw==","name":"manageiq","full_name":"ManageIQ/manageiq","private":false,"owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2018-11-26T22:41:42Z","pushed_at":"2018-11-26T22:41:29Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":259245,"stargazers_count":753,"watchers_count":753,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":669,"mirror_url":null,"archived":false,"open_issues_count":551,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":669,"open_issues":551,"watchers":753,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/18178"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/18178"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/18178/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18178/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/c1fec3cd3ebfc70b8748a1d087dca692c622e88a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gmcculloug"}}