{"action":"created","issue":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2029","repository_url":"https://api.github.com/repos/umbraco/Umbraco-CMS","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2029/labels{/name}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2029/comments","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2029/events","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2029","id":240386228,"node_id":"MDExOlB1bGxSZXF1ZXN0MTI4Nzc3NjA2","number":2029,"title":"Allow for SMTP username and password to be optionally defined as AppSettings","user":{"login":"Jeavon","id":1829920,"node_id":"MDQ6VXNlcjE4Mjk5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1829920?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeavon","html_url":"https://github.com/Jeavon","followers_url":"https://api.github.com/users/Jeavon/followers","following_url":"https://api.github.com/users/Jeavon/following{/other_user}","gists_url":"https://api.github.com/users/Jeavon/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeavon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeavon/subscriptions","organizations_url":"https://api.github.com/users/Jeavon/orgs","repos_url":"https://api.github.com/users/Jeavon/repos","events_url":"https://api.github.com/users/Jeavon/events{/privacy}","received_events_url":"https://api.github.com/users/Jeavon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-07-04T10:56:28Z","updated_at":"2018-10-30T18:06:27Z","closed_at":"2018-10-23T16:44:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/2029","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2029","diff_url":"https://github.com/umbraco/Umbraco-CMS/pull/2029.diff","patch_url":"https://github.com/umbraco/Umbraco-CMS/pull/2029.patch"},"body":"This PR is to allow the environment to handle the app settings such as you have with Azure Web App, Application settings.\r\n\r\nThe SMTP password is now the only remaining credential that has to be stored physically in web.config on Azure Web App using Application Settings.\r\n\r\nI'm not sure about what the AppSetting names should be, I've gone with smtpUserName and smtpPassword but could be smtp:UserName, umbracoSmtpUserName etc...."},"comment":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments/434409720","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2029#issuecomment-434409720","issue_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2029","id":434409720,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQwOTcyMA==","user":{"login":"Jeavon","id":1829920,"node_id":"MDQ6VXNlcjE4Mjk5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1829920?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeavon","html_url":"https://github.com/Jeavon","followers_url":"https://api.github.com/users/Jeavon/followers","following_url":"https://api.github.com/users/Jeavon/following{/other_user}","gists_url":"https://api.github.com/users/Jeavon/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeavon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeavon/subscriptions","organizations_url":"https://api.github.com/users/Jeavon/orgs","repos_url":"https://api.github.com/users/Jeavon/repos","events_url":"https://api.github.com/users/Jeavon/events{/privacy}","received_events_url":"https://api.github.com/users/Jeavon/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T18:06:27Z","updated_at":"2018-10-30T18:06:27Z","author_association":"CONTRIBUTOR","body":"I did a quick Google to see if there's anything new and I didn't find anything so I think this is still valid. We still get the feedback from our monthly security audits that we need to remove the SMTP credentials from web.config as they are the only credentials that still have to be within web.config."}}
{"actor":{"display_login":"Jeavon"}}