{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/finality-afg/pulls/comments/208620661","pull_request_review_id":144467470,"id":208620661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYyMDY2MQ==","diff_hunk":"@@ -0,0 +1,67 @@\n+// Copyright 2018 Parity Technologies (UK) Ltd.\n+// This file is part of finality-afg.\n+\n+// Polkadot is free software: you can redistribute it and/or modify","path":"src/lib.rs","position":4,"original_position":4,"commit_id":"e21b4184dcc14c85e97356235e51577f647ca3d2","original_commit_id":"e21b4184dcc14c85e97356235e51577f647ca3d2","user":{"login":"gnunicorn","id":40496,"node_id":"MDQ6VXNlcjQwNDk2","avatar_url":"https://avatars1.githubusercontent.com/u/40496?v=4","gravatar_id":"","url":"https://api.github.com/users/gnunicorn","html_url":"https://github.com/gnunicorn","followers_url":"https://api.github.com/users/gnunicorn/followers","following_url":"https://api.github.com/users/gnunicorn/following{/other_user}","gists_url":"https://api.github.com/users/gnunicorn/gists{/gist_id}","starred_url":"https://api.github.com/users/gnunicorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnunicorn/subscriptions","organizations_url":"https://api.github.com/users/gnunicorn/orgs","repos_url":"https://api.github.com/users/gnunicorn/repos","events_url":"https://api.github.com/users/gnunicorn/events{/privacy}","received_events_url":"https://api.github.com/users/gnunicorn/received_events","type":"User","site_admin":false},"body":"Shouldn't this be `finality-afg` rather than `Polkadot`?","created_at":"2018-08-08T15:11:42Z","updated_at":"2018-08-08T15:37:35Z","html_url":"https://github.com/paritytech/finality-afg/pull/1#discussion_r208620661","pull_request_url":"https://api.github.com/repos/paritytech/finality-afg/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/paritytech/finality-afg/pulls/comments/208620661"},"html":{"href":"https://github.com/paritytech/finality-afg/pull/1#discussion_r208620661"},"pull_request":{"href":"https://api.github.com/repos/paritytech/finality-afg/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/finality-afg/pulls/1","id":206987715,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTg3NzE1","html_url":"https://github.com/paritytech/finality-afg/pull/1","diff_url":"https://github.com/paritytech/finality-afg/pull/1.diff","patch_url":"https://github.com/paritytech/finality-afg/pull/1.patch","issue_url":"https://api.github.com/repos/paritytech/finality-afg/issues/1","number":1,"state":"open","locked":false,"title":"Vote Graph and GHOST-hunting","user":{"login":"rphmeier","id":10121380,"node_id":"MDQ6VXNlcjEwMTIxMzgw","avatar_url":"https://avatars1.githubusercontent.com/u/10121380?v=4","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false},"body":"This PR contains the logic for imposing a further DAG on top of the blockchain, where nodes are blocks which have been voted on directly.\r\n\r\nCumulative votes (flowing back to the \"base\" -- in practice, the last finalized block) are kept updated, and a \"GHOST\" calculation can be done on this DAG to find the highest block with a common ancestor that fulfills some vote-predicate. This block may fall between some vote-nodes.\r\n\r\nThe GHOST logic, as it stands right now, operates under the assumption that the predicate will evaluate to `true` for at most one branch of any fork. Full GHOST is more expensive to implement as we have to compare the cumulative scores of all children and can't early-exit upon finding the first child which satisfies the predicate.","created_at":"2018-08-08T12:15:36Z","updated_at":"2018-08-08T15:37:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c286f148526ae9df72df719371b0dc1d4664b5a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1018339004,"node_id":"MDU6TGFiZWwxMDE4MzM5MDA0","url":"https://api.github.com/repos/paritytech/finality-afg/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/finality-afg/pulls/1/commits","review_comments_url":"https://api.github.com/repos/paritytech/finality-afg/pulls/1/comments","review_comment_url":"https://api.github.com/repos/paritytech/finality-afg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/finality-afg/issues/1/comments","statuses_url":"https://api.github.com/repos/paritytech/finality-afg/statuses/e21b4184dcc14c85e97356235e51577f647ca3d2","head":{"label":"paritytech:rh-vote-graph","ref":"rh-vote-graph","sha":"e21b4184dcc14c85e97356235e51577f647ca3d2","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":138737291,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MzcyOTE=","name":"finality-afg","full_name":"paritytech/finality-afg","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/finality-afg","description":"finality gadget for blockchains, based on PBFT","fork":false,"url":"https://api.github.com/repos/paritytech/finality-afg","forks_url":"https://api.github.com/repos/paritytech/finality-afg/forks","keys_url":"https://api.github.com/repos/paritytech/finality-afg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/finality-afg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/finality-afg/teams","hooks_url":"https://api.github.com/repos/paritytech/finality-afg/hooks","issue_events_url":"https://api.github.com/repos/paritytech/finality-afg/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/finality-afg/events","assignees_url":"https://api.github.com/repos/paritytech/finality-afg/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/finality-afg/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/finality-afg/tags","blobs_url":"https://api.github.com/repos/paritytech/finality-afg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/finality-afg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/finality-afg/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/finality-afg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/finality-afg/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/finality-afg/languages","stargazers_url":"https://api.github.com/repos/paritytech/finality-afg/stargazers","contributors_url":"https://api.github.com/repos/paritytech/finality-afg/contributors","subscribers_url":"https://api.github.com/repos/paritytech/finality-afg/subscribers","subscription_url":"https://api.github.com/repos/paritytech/finality-afg/subscription","commits_url":"https://api.github.com/repos/paritytech/finality-afg/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/finality-afg/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/finality-afg/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/finality-afg/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/finality-afg/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/finality-afg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/finality-afg/merges","archive_url":"https://api.github.com/repos/paritytech/finality-afg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/finality-afg/downloads","issues_url":"https://api.github.com/repos/paritytech/finality-afg/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/finality-afg/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/finality-afg/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/finality-afg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/finality-afg/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/finality-afg/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/finality-afg/deployments","created_at":"2018-06-26T12:48:53Z","updated_at":"2018-08-08T12:06:45Z","pushed_at":"2018-08-08T12:31:33Z","git_url":"git://github.com/paritytech/finality-afg.git","ssh_url":"git@github.com:paritytech/finality-afg.git","clone_url":"https://github.com/paritytech/finality-afg.git","svn_url":"https://github.com/paritytech/finality-afg","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"3186e058c9f4666c45f1af207defdf1c38dfe549","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":138737291,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MzcyOTE=","name":"finality-afg","full_name":"paritytech/finality-afg","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/finality-afg","description":"finality gadget for blockchains, based on PBFT","fork":false,"url":"https://api.github.com/repos/paritytech/finality-afg","forks_url":"https://api.github.com/repos/paritytech/finality-afg/forks","keys_url":"https://api.github.com/repos/paritytech/finality-afg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/finality-afg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/finality-afg/teams","hooks_url":"https://api.github.com/repos/paritytech/finality-afg/hooks","issue_events_url":"https://api.github.com/repos/paritytech/finality-afg/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/finality-afg/events","assignees_url":"https://api.github.com/repos/paritytech/finality-afg/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/finality-afg/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/finality-afg/tags","blobs_url":"https://api.github.com/repos/paritytech/finality-afg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/finality-afg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/finality-afg/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/finality-afg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/finality-afg/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/finality-afg/languages","stargazers_url":"https://api.github.com/repos/paritytech/finality-afg/stargazers","contributors_url":"https://api.github.com/repos/paritytech/finality-afg/contributors","subscribers_url":"https://api.github.com/repos/paritytech/finality-afg/subscribers","subscription_url":"https://api.github.com/repos/paritytech/finality-afg/subscription","commits_url":"https://api.github.com/repos/paritytech/finality-afg/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/finality-afg/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/finality-afg/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/finality-afg/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/finality-afg/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/finality-afg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/finality-afg/merges","archive_url":"https://api.github.com/repos/paritytech/finality-afg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/finality-afg/downloads","issues_url":"https://api.github.com/repos/paritytech/finality-afg/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/finality-afg/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/finality-afg/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/finality-afg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/finality-afg/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/finality-afg/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/finality-afg/deployments","created_at":"2018-06-26T12:48:53Z","updated_at":"2018-08-08T12:06:45Z","pushed_at":"2018-08-08T12:31:33Z","git_url":"git://github.com/paritytech/finality-afg.git","ssh_url":"git@github.com:paritytech/finality-afg.git","clone_url":"https://github.com/paritytech/finality-afg.git","svn_url":"https://github.com/paritytech/finality-afg","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/finality-afg/pulls/1"},"html":{"href":"https://github.com/paritytech/finality-afg/pull/1"},"issue":{"href":"https://api.github.com/repos/paritytech/finality-afg/issues/1"},"comments":{"href":"https://api.github.com/repos/paritytech/finality-afg/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/finality-afg/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/finality-afg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/finality-afg/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/finality-afg/statuses/e21b4184dcc14c85e97356235e51577f647ca3d2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gnunicorn"}}