{"action":"created","comment":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/221730302","pull_request_review_id":160452137,"id":221730302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTczMDMwMg==","diff_hunk":"@@ -133,6 +141,6 @@ function ($carry, Acl $item) {\n \n $returnData['success'] = true;\n $returnData['user_type'] = $_POST['user_type'];\n-$returnData['message'] = 'User <b>'.$_POST['username'].'</b> created successfully';\n+$returnData['message'] = 'User '.$_POST['username'].' created successfully';","path":"html/controllers/user_admin/create_user.php","position":29,"original_position":29,"commit_id":"1f604c7e4ac92fc0ab20553058249974dab25322","original_commit_id":"c67454bb0cd9fa8b011ed15c80ec438eab03086e","user":{"login":"ryanrath","id":10520715,"node_id":"MDQ6VXNlcjEwNTIwNzE1","avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"body":"Same reason that `update_user.php` was changed. Specifically, to make it easier ( Possible? ) to select the element that ends up containing `$returnData['message'] to verify that the user has been created successfully during testing. If you happen to have some thoughts on how that could be accomplished without this change I'm definitely all for it. ","created_at":"2018-10-01T19:36:30Z","updated_at":"2018-10-01T19:36:30Z","html_url":"https://github.com/ubccr/xdmod/pull/689#discussion_r221730302","pull_request_url":"https://api.github.com/repos/ubccr/xdmod/pulls/689","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/221730302"},"html":{"href":"https://github.com/ubccr/xdmod/pull/689#discussion_r221730302"},"pull_request":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/689"}},"in_reply_to_id":221729351},"pull_request":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/689","id":218460178,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDYwMTc4","html_url":"https://github.com/ubccr/xdmod/pull/689","diff_url":"https://github.com/ubccr/xdmod/pull/689.diff","patch_url":"https://github.com/ubccr/xdmod/pull/689.patch","issue_url":"https://api.github.com/repos/ubccr/xdmod/issues/689","number":689,"state":"open","locked":false,"title":"Unlock org for unknown person","user":{"login":"ryanrath","id":10520715,"node_id":"MDQ6VXNlcjEwNTIwNzE1","avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n- create_user.php: \r\n  - The organization associated with the newly created user was solely based off of the person they were mapped to. The organization and person mappings are now independent of each other. \r\n- update_user.php\r\n  - The organization associated with the user to be updated was solely based off of the person they were mapped to. The organization and person mappings are now independent.\r\n- TGUserDropDown.js\r\n  - If there is a callback specified, it should be called. Regardless of whether or not the value has changed.\r\n- SectionExistingUsers.js\r\n  - Ensure that when the 'Unknown' person is mapped that the institution drop down is enabled for manual override.\r\n- SectionNewUser.js\r\n  - Ensure that when the 'Unknown' person is mapped that the institution drop down is enabled for manual override.\r\n\r\n## Motivation and Context\r\nWe did not account for needing to manually override a User's associated\r\norganization when they are mapped to the 'Unknown' person. These changes enable\r\nthat on the front end and make sure that they are correctly taken into account\r\non the back end.\r\n\r\n\r\n## Tests performed\r\nManual Tests ( automated tests to follow )\r\n\r\nNew User\r\n  - Create a new User\r\n  - Map a Person other than 'Unknown' \r\n  - Ensure that the 'Institution' drop down is correctly populated and unable to be modified.\r\n  - Map the 'Unknown' Person\r\n  - Ensure that the 'Institution' drop down is able to be modified.\r\n\r\nExisting User ( Not 'Unknown' )\r\n  - Double click on an existing user not mapped to 'Unknown'\r\n  - Change their person to 'Unknown'\r\n  - Ensure that you can now update their 'Institution'\r\n  - Select a new 'Institution'\r\n  - Save changes\r\n  - Close the 'Create / Manage Users' dialog window.\r\n  - Double click on the same user\r\n  - Ensure that their person / institution has not changed.\r\n  - Force refresh the browser\r\n  - Double click on the same user\r\n  - Ensure that their person / institution has not changed.\r\n\r\nExisting User ( 'Unknown' ) \r\n  - Double click on an existing user who is mapped to 'Unknown'\r\n  - Change their person to anybody not == 'Unknown'\r\n  - Ensure that the \"Institution' drop down has been updated correctly\r\n  - Ensure that you are not able to update the 'Institution' drop down.\r\n  - Save changes\r\n  - Close the 'Create / Manage Users' dialog window.\r\n  - Double click on the same user\r\n  - Ensure that their person / institution has not changed.\r\n  - Force refresh the browser\r\n  - Double click on the same user\r\n  - Ensure that their person / institution has not changed.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [X] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project as found in the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n","created_at":"2018-09-26T21:27:02Z","updated_at":"2018-10-01T19:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35fae5d190e28c712417cffdf25342615b917649","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":625000550,"node_id":"MDU6TGFiZWw2MjUwMDA1NTA=","url":"https://api.github.com/repos/ubccr/xdmod/labels/Has%20test%20description%20needs%20automation","name":"Has test description needs automation","color":"c5def5","default":false},{"id":470896633,"node_id":"MDU6TGFiZWw0NzA4OTY2MzM=","url":"https://api.github.com/repos/ubccr/xdmod/labels/bug","name":"bug","color":"ee0701","default":true},{"id":816336441,"node_id":"MDU6TGFiZWw4MTYzMzY0NDE=","url":"https://api.github.com/repos/ubccr/xdmod/labels/internal%20dashboard","name":"internal dashboard","color":"d38c3b","default":false}],"milestone":{"url":"https://api.github.com/repos/ubccr/xdmod/milestones/8","html_url":"https://github.com/ubccr/xdmod/milestone/8","labels_url":"https://api.github.com/repos/ubccr/xdmod/milestones/8/labels","id":3075821,"node_id":"MDk6TWlsZXN0b25lMzA3NTgyMQ==","number":8,"title":"8.0.0","description":"","creator":{"login":"smgallo","id":2301909,"node_id":"MDQ6VXNlcjIzMDE5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2301909?v=4","gravatar_id":"","url":"https://api.github.com/users/smgallo","html_url":"https://github.com/smgallo","followers_url":"https://api.github.com/users/smgallo/followers","following_url":"https://api.github.com/users/smgallo/following{/other_user}","gists_url":"https://api.github.com/users/smgallo/gists{/gist_id}","starred_url":"https://api.github.com/users/smgallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smgallo/subscriptions","organizations_url":"https://api.github.com/users/smgallo/orgs","repos_url":"https://api.github.com/users/smgallo/repos","events_url":"https://api.github.com/users/smgallo/events{/privacy}","received_events_url":"https://api.github.com/users/smgallo/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":161,"state":"open","created_at":"2018-01-30T18:52:17Z","updated_at":"2018-10-01T18:18:19Z","due_on":"2018-08-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ubccr/xdmod/pulls/689/commits","review_comments_url":"https://api.github.com/repos/ubccr/xdmod/pulls/689/comments","review_comment_url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubccr/xdmod/issues/689/comments","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/1f604c7e4ac92fc0ab20553058249974dab25322","head":{"label":"ryanrath:unlock_org_for_unknown_person","ref":"unlock_org_for_unknown_person","sha":"1f604c7e4ac92fc0ab20553058249974dab25322","user":{"login":"ryanrath","id":10520715,"node_id":"MDQ6VXNlcjEwNTIwNzE1","avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"repo":{"id":77923709,"node_id":"MDEwOlJlcG9zaXRvcnk3NzkyMzcwOQ==","name":"xdmod","full_name":"ryanrath/xdmod","private":false,"owner":{"login":"ryanrath","id":10520715,"node_id":"MDQ6VXNlcjEwNTIwNzE1","avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ryanrath/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":true,"url":"https://api.github.com/repos/ryanrath/xdmod","forks_url":"https://api.github.com/repos/ryanrath/xdmod/forks","keys_url":"https://api.github.com/repos/ryanrath/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanrath/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanrath/xdmod/teams","hooks_url":"https://api.github.com/repos/ryanrath/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ryanrath/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ryanrath/xdmod/events","assignees_url":"https://api.github.com/repos/ryanrath/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ryanrath/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ryanrath/xdmod/tags","blobs_url":"https://api.github.com/repos/ryanrath/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanrath/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanrath/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanrath/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanrath/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanrath/xdmod/languages","stargazers_url":"https://api.github.com/repos/ryanrath/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ryanrath/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ryanrath/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ryanrath/xdmod/subscription","commits_url":"https://api.github.com/repos/ryanrath/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanrath/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanrath/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanrath/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanrath/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ryanrath/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanrath/xdmod/merges","archive_url":"https://api.github.com/repos/ryanrath/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanrath/xdmod/downloads","issues_url":"https://api.github.com/repos/ryanrath/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ryanrath/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanrath/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanrath/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanrath/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ryanrath/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ryanrath/xdmod/deployments","created_at":"2017-01-03T14:23:30Z","updated_at":"2017-01-03T14:23:34Z","pushed_at":"2018-10-01T19:33:24Z","git_url":"git://github.com/ryanrath/xdmod.git","ssh_url":"git@github.com:ryanrath/xdmod.git","clone_url":"https://github.com/ryanrath/xdmod.git","svn_url":"https://github.com/ryanrath/xdmod","homepage":"http://open.xdmod.org","size":13984,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"xdmod6.5"}},"base":{"label":"ubccr:xdmod8.0","ref":"xdmod8.0","sha":"2e81cea60cdc8466bdce1ee847f9c2238b07b858","user":{"login":"ubccr","id":2301947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDE5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"repo":{"id":72233032,"node_id":"MDEwOlJlcG9zaXRvcnk3MjIzMzAzMg==","name":"xdmod","full_name":"ubccr/xdmod","private":false,"owner":{"login":"ubccr","id":2301947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDE5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ubccr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":false,"url":"https://api.github.com/repos/ubccr/xdmod","forks_url":"https://api.github.com/repos/ubccr/xdmod/forks","keys_url":"https://api.github.com/repos/ubccr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubccr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubccr/xdmod/teams","hooks_url":"https://api.github.com/repos/ubccr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ubccr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ubccr/xdmod/events","assignees_url":"https://api.github.com/repos/ubccr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ubccr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ubccr/xdmod/tags","blobs_url":"https://api.github.com/repos/ubccr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubccr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubccr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubccr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ubccr/xdmod/languages","stargazers_url":"https://api.github.com/repos/ubccr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ubccr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ubccr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ubccr/xdmod/subscription","commits_url":"https://api.github.com/repos/ubccr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubccr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubccr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubccr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubccr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ubccr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubccr/xdmod/merges","archive_url":"https://api.github.com/repos/ubccr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubccr/xdmod/downloads","issues_url":"https://api.github.com/repos/ubccr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ubccr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ubccr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ubccr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubccr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ubccr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ubccr/xdmod/deployments","created_at":"2016-10-28T18:41:25Z","updated_at":"2018-10-01T18:18:30Z","pushed_at":"2018-10-01T19:33:25Z","git_url":"git://github.com/ubccr/xdmod.git","ssh_url":"git@github.com:ubccr/xdmod.git","clone_url":"https://github.com/ubccr/xdmod.git","svn_url":"https://github.com/ubccr/xdmod","homepage":"https://open.xdmod.org","size":12744,"stargazers_count":27,"watchers_count":27,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":27,"open_issues":6,"watchers":27,"default_branch":"xdmod8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/689"},"html":{"href":"https://github.com/ubccr/xdmod/pull/689"},"issue":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/689"},"comments":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/ubccr/xdmod/statuses/1f604c7e4ac92fc0ab20553058249974dab25322"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ryanrath"}}