{"action":"created","issue":{"url":"https://api.github.com/repos/QubesOS/qubes-issues/issues/4417","repository_url":"https://api.github.com/repos/QubesOS/qubes-issues","labels_url":"https://api.github.com/repos/QubesOS/qubes-issues/issues/4417/labels{/name}","comments_url":"https://api.github.com/repos/QubesOS/qubes-issues/issues/4417/comments","events_url":"https://api.github.com/repos/QubesOS/qubes-issues/issues/4417/events","html_url":"https://github.com/QubesOS/qubes-issues/issues/4417","id":372534892,"node_id":"MDU6SXNzdWUzNzI1MzQ4OTI=","number":4417,"title":"Syntax error on qubes.getAppmenus script in debian template","user":{"login":"haplo","id":71658,"node_id":"MDQ6VXNlcjcxNjU4","avatar_url":"https://avatars1.githubusercontent.com/u/71658?v=4","gravatar_id":"","url":"https://api.github.com/users/haplo","html_url":"https://github.com/haplo","followers_url":"https://api.github.com/users/haplo/followers","following_url":"https://api.github.com/users/haplo/following{/other_user}","gists_url":"https://api.github.com/users/haplo/gists{/gist_id}","starred_url":"https://api.github.com/users/haplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haplo/subscriptions","organizations_url":"https://api.github.com/users/haplo/orgs","repos_url":"https://api.github.com/users/haplo/repos","events_url":"https://api.github.com/users/haplo/events{/privacy}","received_events_url":"https://api.github.com/users/haplo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-22T14:03:41Z","updated_at":"2018-10-22T17:05:33Z","closed_at":null,"author_association":"NONE","body":"### Qubes OS version:\r\n<!-- (e.g., `R3.2`)\r\n     You can get it from the dom0 terminal with the command\r\n         `cat /etc/qubes-release`\r\n     Type below this line. -->\r\n\r\nR4.0\r\n\r\n<!-- Type above this line. -->\r\n### Affected component(s): \r\n<!-- Type below this line. -->\r\n\r\nqubes-core-agent-linux\r\n\r\n<!-- Type above this line. -->\r\n---\r\n<!--------------------------->\r\n### Steps to reproduce the behavior:\r\n<!-- Use single backticks (`) for in-line code snippets and\r\n     triple backticks (```) for code blocks.\r\n     Type below this line. -->\r\n\r\nUpgrade qubes-core-agent package in debian 9 template to version 4.0.37-1+deb9u1.\r\n\r\n<!-- Type above this line. -->\r\n### Expected behavior:\r\n<!-- Type below this line. -->\r\n\r\nInstall finishes fine with no errors.\r\n\r\n<!-- Type above this line. -->\r\n### Actual behavior:\r\n<!-- Type below this line. -->\r\n\r\nThere is a syntax error with the new changes to */etc/qubes-rpc/qubes.GetAppmenus*, please see the last line of this output:\r\n\r\n```\r\nSetting up qubes-core-agent (4.0.37-1+deb9u1) ...\r\nInstalling new version of config file /etc/qubes-rpc/qubes.GetAppmenus ...\r\nRemoved /etc/systemd/system/multi-user.target.wants/haveged.service.\r\nCreated symlink /etc/systemd/system/multi-user.target.wants/haveged.service → /etc/systemd/system/haveged.service.\r\nLeaving 'diversion of /etc/init/plymouth-shutdown.conf to /etc/init/plymouth-shutdown.conf.qubes-disabled by qubes-core-agent'\r\nLeaving 'diversion of /etc/iniSetting up qubes-core-agent (4.0.37-1+deb9u1) ...\r\nt/prefdm.conf to /etc/init/prefdm.conf.qubes-disabled by qubes-core-agent'\r\nLeaving 'diversion of /etc/Installing new version of config file /etc/qubes-rpc/qubes.GetAppmenus ...\r\nRemoved /etc/systemd/system/multi-user.target.wants/haveged.service.\r\ninit/splash-manager.conf to /etc/init/splasCreated symlink /etc/systemd/system/multi-user.target.wants/haveged.service → /etc/systemd/system/haveged.service.\r\nh-manager.conf.qubes-disabled by qubes-cLeaving 'diversion of /etc/init/plymouth-shutdown.conf to /etc/init/plymouth-shutdown.conf.qubes-disabled by qubes-core-agent'\r\nore-agent'\r\nLeaving 'diversion of /etLeaving 'diversion of /etc/init/prefdm.conf to /etc/init/prefdm.conf.qubes-disabled by qubes-core-agent'\r\nc/init/start-ttys.conf to /etc/init/staLeaving 'diversion of /etc/init/splash-manager.conf to /etc/init/splash-manager.conf.qubes-disabled by qubes-core-agent'\r\nrt-ttys.conf.qubes-disabled by qubes-core-agent'\r\nLeaving 'diversion of /etc/init/tty.conf to /etc/init/tty.conf.qubes-disabled by qubes-core-agent'\r\nLeaving 'diversion of /etc/init/serial.conf to /etc/init/serial.conf.qubes-orig by qubes-core-agent'\r\n/etc/qubes-rpc/qubes.GetAppmenus: 20: /etc/qubes-rpc/qubes.GetAppmenus: Syntax error: \"(\" unexpected\r\nLeaving 'diversion of /etc/init/start-ttys.conf to /etc/init/start-ttys.conf.qubes-disabled by qubes-core-agent'\r\nLeaving 'diversion of /etc/init/tty.conf to /etc/init/tty.conf.qubes-disabled by qubes-core-agent'\r\nLeaving 'diversion of /etc/init/serial.conf to /etc/init/serial.conf.qubes-orig by qubes-core-agent'\r\n/etc/qubes-rpc/qubes.GetAppmenus: 20: /etc/qubes-rpc/qubes.GetAppmenus: Syntax error: \"(\" unexpected\r\n```\r\n\r\n<!-- Type above this line. -->\r\n### General notes:\r\n<!-- Type below this line. -->\r\n\r\nThe offending commit is [d1f55ffeb8 on qubes-core-agent-linux](https://github.com/QubesOS/qubes-core-agent-linux/commit/d1f55ffeb896fe15191ef76d8b11edf6c0ffa071).\r\n\r\n<!-- Type above this line. -->\r\n---\r\n<!--------------------------->\r\n### Related issues:\r\n<!-- Type below this line. -->\r\n\r\n#4152 "},"comment":{"url":"https://api.github.com/repos/QubesOS/qubes-issues/issues/comments/431899496","html_url":"https://github.com/QubesOS/qubes-issues/issues/4417#issuecomment-431899496","issue_url":"https://api.github.com/repos/QubesOS/qubes-issues/issues/4417","id":431899496,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTg5OTQ5Ng==","user":{"login":"marmarek","id":726704,"node_id":"MDQ6VXNlcjcyNjcwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/726704?v=4","gravatar_id":"","url":"https://api.github.com/users/marmarek","html_url":"https://github.com/marmarek","followers_url":"https://api.github.com/users/marmarek/followers","following_url":"https://api.github.com/users/marmarek/following{/other_user}","gists_url":"https://api.github.com/users/marmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/marmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmarek/subscriptions","organizations_url":"https://api.github.com/users/marmarek/orgs","repos_url":"https://api.github.com/users/marmarek/repos","events_url":"https://api.github.com/users/marmarek/events{/privacy}","received_events_url":"https://api.github.com/users/marmarek/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T17:05:33Z","updated_at":"2018-10-22T17:05:33Z","author_association":"MEMBER","body":"The problem is that it use bash specific syntax (and have appropriate\n#!/bin/bash at the beginning for this), but during package update, it's\ncalled explicitly with /bin/sh which isn't bash on Debian.\n\nAs a workaround for now, call `qvm-sync-appmenus debian-9` from dom0\nwhen you get this error.\n\n-- \nBest Regards,\nMarek Marczykowski-Górecki\nInvisible Things Lab\nA: Because it messes up the order in which people normally read text.\nQ: Why is top-posting such a bad thing?\n"}}
{"actor":{"display_login":"marmarek"}}