{"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/quasar/pulls/comments/222785820","pull_request_review_id":161757661,"id":222785820,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjc4NTgyMA==","diff_hunk":"@@ -0,0 +1,78 @@\n+/*\n+ * Copyright 2014–2018 SlamData Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package quasar.mimir.evaluate\n+\n+import quasar.precog.common.{CString, RArray, RObject, RValue}\n+import quasar.qscript._\n+\n+import scalaz.syntax.std.option._\n+import scalaz.syntax.equal._\n+import scalaz.std.string._\n+\n+object Shifting {\n+\n+  final case class ShiftInfo(shiftPath: ShiftPath, idStatus: IdStatus, shiftKey: ShiftKey)\n+\n+  /* Returns the `RObject` at the provided path, returning `None` when\n+   * the path points to a non-object or the path does not exist.\n+   *\n+   * A path `foo.bar.baz` is represented as `List(\"foo\", \"bar\", \"baz\")`\n+   *\n+   * Paths including static array derefs are not currently supported.\n+   */\n+  def drillToObject(rvalue: RValue, path: List[String]): Option[RValue] = {\n+    (rvalue, path) match {","path":"mimir/src/main/scala/quasar/mimir/evaluate/Shifting.scala","position":38,"original_position":38,"commit_id":"4deb1493087e2c066691032d1d0bbbc279115004","original_commit_id":"4deb1493087e2c066691032d1d0bbbc279115004","user":{"login":"wemrysi","id":32185,"node_id":"MDQ6VXNlcjMyMTg1","avatar_url":"https://avatars3.githubusercontent.com/u/32185?v=4","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"body":"We could even add this to `RValue` as `def rPath(p: NonEmptyList[String]): Optional[RValue, RValue]`.","created_at":"2018-10-04T18:45:35Z","updated_at":"2018-10-04T18:45:35Z","html_url":"https://github.com/slamdata/quasar/pull/3844#discussion_r222785820","pull_request_url":"https://api.github.com/repos/slamdata/quasar/pulls/3844","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/comments/222785820"},"html":{"href":"https://github.com/slamdata/quasar/pull/3844#discussion_r222785820"},"pull_request":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3844"}},"in_reply_to_id":222765956},"pull_request":{"url":"https://api.github.com/repos/slamdata/quasar/pulls/3844","id":220185243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTg1MjQz","html_url":"https://github.com/slamdata/quasar/pull/3844","diff_url":"https://github.com/slamdata/quasar/pull/3844.diff","patch_url":"https://github.com/slamdata/quasar/pull/3844.patch","issue_url":"https://api.github.com/repos/slamdata/quasar/issues/3844","number":3844,"state":"open","locked":false,"title":"Implement shiftparsing for shifts after an object projection","user":{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false},"body":"[ch2172]\r\n\r\nImplements shiftparsing for queries of the form\r\n```sql\r\nselect foo{_} as value, foo{_:} as key from mydata\r\n```\r\nwhere any number of object projections before the shift are allowed, for example `a.b.c.d{_}`.\r\n\r\nTested the performance of a query of that form. Against master it evaluates in 68 seconds. On this branch it evaluates in 6 seconds. (Times measured in the REPL.)","created_at":"2018-10-03T21:25:46Z","updated_at":"2018-10-04T18:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9b331375fb632f59c5c464e2acbbe6e279ced42","assignee":{"login":"wemrysi","id":32185,"node_id":"MDQ6VXNlcjMyMTg1","avatar_url":"https://avatars3.githubusercontent.com/u/32185?v=4","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"assignees":[{"login":"wemrysi","id":32185,"node_id":"MDQ6VXNlcjMyMTg1","avatar_url":"https://avatars3.githubusercontent.com/u/32185?v=4","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"djspiewak","id":752,"node_id":"MDQ6VXNlcjc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/752?v=4","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":513640878,"node_id":"MDU6TGFiZWw1MTM2NDA4Nzg=","url":"https://api.github.com/repos/slamdata/quasar/labels/version:%20feature","name":"version: feature","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/quasar/pulls/3844/commits","review_comments_url":"https://api.github.com/repos/slamdata/quasar/pulls/3844/comments","review_comment_url":"https://api.github.com/repos/slamdata/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slamdata/quasar/issues/3844/comments","statuses_url":"https://api.github.com/repos/slamdata/quasar/statuses/4deb1493087e2c066691032d1d0bbbc279115004","head":{"label":"alissapajer:ch2172","ref":"ch2172","sha":"4deb1493087e2c066691032d1d0bbbc279115004","user":{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false},"repo":{"id":56490507,"node_id":"MDEwOlJlcG9zaXRvcnk1NjQ5MDUwNw==","name":"quasar","full_name":"alissapajer/quasar","private":false,"owner":{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alissapajer/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":true,"url":"https://api.github.com/repos/alissapajer/quasar","forks_url":"https://api.github.com/repos/alissapajer/quasar/forks","keys_url":"https://api.github.com/repos/alissapajer/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alissapajer/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alissapajer/quasar/teams","hooks_url":"https://api.github.com/repos/alissapajer/quasar/hooks","issue_events_url":"https://api.github.com/repos/alissapajer/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/alissapajer/quasar/events","assignees_url":"https://api.github.com/repos/alissapajer/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/alissapajer/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/alissapajer/quasar/tags","blobs_url":"https://api.github.com/repos/alissapajer/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alissapajer/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alissapajer/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/alissapajer/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alissapajer/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/alissapajer/quasar/languages","stargazers_url":"https://api.github.com/repos/alissapajer/quasar/stargazers","contributors_url":"https://api.github.com/repos/alissapajer/quasar/contributors","subscribers_url":"https://api.github.com/repos/alissapajer/quasar/subscribers","subscription_url":"https://api.github.com/repos/alissapajer/quasar/subscription","commits_url":"https://api.github.com/repos/alissapajer/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/alissapajer/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/alissapajer/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/alissapajer/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/alissapajer/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/alissapajer/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alissapajer/quasar/merges","archive_url":"https://api.github.com/repos/alissapajer/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alissapajer/quasar/downloads","issues_url":"https://api.github.com/repos/alissapajer/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/alissapajer/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/alissapajer/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/alissapajer/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alissapajer/quasar/labels{/name}","releases_url":"https://api.github.com/repos/alissapajer/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/alissapajer/quasar/deployments","created_at":"2016-04-18T08:29:41Z","updated_at":"2018-10-04T01:18:16Z","pushed_at":"2018-10-04T02:30:06Z","git_url":"git://github.com/alissapajer/quasar.git","ssh_url":"git@github.com:alissapajer/quasar.git","clone_url":"https://github.com/alissapajer/quasar.git","svn_url":"https://github.com/alissapajer/quasar","homepage":"http://quasar-analytics.org","size":74560,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slamdata:master","ref":"master","sha":"3ef598ad9827ba2488a7f334f6fa6cab254f83e9","user":{"login":"slamdata","id":5385602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODU2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5385602?v=4","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUxNTA1OA==","name":"quasar","full_name":"slamdata/quasar","private":false,"owner":{"login":"slamdata","id":5385602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODU2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5385602?v=4","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/slamdata/quasar","description":"A compiler and columnar analytics engine for a SQL dialect with support for heterogeneous structured data","fork":false,"url":"https://api.github.com/repos/slamdata/quasar","forks_url":"https://api.github.com/repos/slamdata/quasar/forks","keys_url":"https://api.github.com/repos/slamdata/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/quasar/teams","hooks_url":"https://api.github.com/repos/slamdata/quasar/hooks","issue_events_url":"https://api.github.com/repos/slamdata/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/quasar/events","assignees_url":"https://api.github.com/repos/slamdata/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/quasar/tags","blobs_url":"https://api.github.com/repos/slamdata/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/quasar/languages","stargazers_url":"https://api.github.com/repos/slamdata/quasar/stargazers","contributors_url":"https://api.github.com/repos/slamdata/quasar/contributors","subscribers_url":"https://api.github.com/repos/slamdata/quasar/subscribers","subscription_url":"https://api.github.com/repos/slamdata/quasar/subscription","commits_url":"https://api.github.com/repos/slamdata/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/slamdata/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/quasar/merges","archive_url":"https://api.github.com/repos/slamdata/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/quasar/downloads","issues_url":"https://api.github.com/repos/slamdata/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/quasar/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/slamdata/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2018-10-04T17:05:30Z","pushed_at":"2018-10-04T17:39:00Z","git_url":"git://github.com/slamdata/quasar.git","ssh_url":"git@github.com:slamdata/quasar.git","clone_url":"https://github.com/slamdata/quasar.git","svn_url":"https://github.com/slamdata/quasar","homepage":"","size":74569,"stargazers_count":681,"watchers_count":681,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":395,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":99,"open_issues":395,"watchers":681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3844"},"html":{"href":"https://github.com/slamdata/quasar/pull/3844"},"issue":{"href":"https://api.github.com/repos/slamdata/quasar/issues/3844"},"comments":{"href":"https://api.github.com/repos/slamdata/quasar/issues/3844/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3844/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3844/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/quasar/statuses/4deb1493087e2c066691032d1d0bbbc279115004"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wemrysi"}}