{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/3958","repository_url":"https://api.github.com/repos/kubernetes-sigs/kubespray","labels_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/3958/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/3958/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/3958/events","html_url":"https://github.com/kubernetes-sigs/kubespray/pull/3958","id":394748415,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDE2ODUz","number":3958,"title":"Fix kube-proxy configuration for kubeadm","user":{"login":"chadswen","id":727874,"node_id":"MDQ6VXNlcjcyNzg3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/727874?v=4","gravatar_id":"","url":"https://api.github.com/users/chadswen","html_url":"https://github.com/chadswen","followers_url":"https://api.github.com/users/chadswen/followers","following_url":"https://api.github.com/users/chadswen/following{/other_user}","gists_url":"https://api.github.com/users/chadswen/gists{/gist_id}","starred_url":"https://api.github.com/users/chadswen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadswen/subscriptions","organizations_url":"https://api.github.com/users/chadswen/orgs","repos_url":"https://api.github.com/users/chadswen/repos","events_url":"https://api.github.com/users/chadswen/events{/privacy}","received_events_url":"https://api.github.com/users/chadswen/received_events","type":"User","site_admin":false},"labels":[{"id":1031817353,"node_id":"MDU6TGFiZWwxMDMxODE3MzUz","url":"https://api.github.com/repos/kubernetes-sigs/kubespray/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485769464,"node_id":"MDU6TGFiZWw0ODU3Njk0NjQ=","url":"https://api.github.com/repos/kubernetes-sigs/kubespray/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":807067034,"node_id":"MDU6TGFiZWw4MDcwNjcwMzQ=","url":"https://api.github.com/repos/kubernetes-sigs/kubespray/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":676065130,"node_id":"MDU6TGFiZWw2NzYwNjUxMzA=","url":"https://api.github.com/repos/kubernetes-sigs/kubespray/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"woopstar","id":2997782,"node_id":"MDQ6VXNlcjI5OTc3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997782?v=4","gravatar_id":"","url":"https://api.github.com/users/woopstar","html_url":"https://github.com/woopstar","followers_url":"https://api.github.com/users/woopstar/followers","following_url":"https://api.github.com/users/woopstar/following{/other_user}","gists_url":"https://api.github.com/users/woopstar/gists{/gist_id}","starred_url":"https://api.github.com/users/woopstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woopstar/subscriptions","organizations_url":"https://api.github.com/users/woopstar/orgs","repos_url":"https://api.github.com/users/woopstar/repos","events_url":"https://api.github.com/users/woopstar/events{/privacy}","received_events_url":"https://api.github.com/users/woopstar/received_events","type":"User","site_admin":false},"assignees":[{"login":"woopstar","id":2997782,"node_id":"MDQ6VXNlcjI5OTc3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997782?v=4","gravatar_id":"","url":"https://api.github.com/users/woopstar","html_url":"https://github.com/woopstar","followers_url":"https://api.github.com/users/woopstar/followers","following_url":"https://api.github.com/users/woopstar/following{/other_user}","gists_url":"https://api.github.com/users/woopstar/gists{/gist_id}","starred_url":"https://api.github.com/users/woopstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woopstar/subscriptions","organizations_url":"https://api.github.com/users/woopstar/orgs","repos_url":"https://api.github.com/users/woopstar/repos","events_url":"https://api.github.com/users/woopstar/events{/privacy}","received_events_url":"https://api.github.com/users/woopstar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-29T01:33:19Z","updated_at":"2019-01-03T08:03:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kubespray/pulls/3958","html_url":"https://github.com/kubernetes-sigs/kubespray/pull/3958","diff_url":"https://github.com/kubernetes-sigs/kubespray/pull/3958.diff","patch_url":"https://github.com/kubernetes-sigs/kubespray/pull/3958.patch"},"body":"- Creates and defaults an ansible variable for every configuration option in the `kubeproxy.config.k8s.io/v1alpha1` type spec\r\n  - Fixes vars that were orphaned by removing non-kubeadm\r\n  - Fixes previously harcoded kubeadm values\r\n- Introduces a `main` directory for role default files per component (requires ansible 2.6.0+)\r\n  - Split out just `kube-proxy.yml` in this first effort\r\n- Removes the kube-proxy server field patch task\r\n\r\nWe should continue to pull out other components from `main.yml` into their own defaults files as I did here for `defaults/main/kube-proxy.yml`. I hope for and will need others to join me in this refactoring across the project until each component config template has a matching role defaults file, with shared defaults in `kubespray-defaults` or `downloads`"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/comments/451075781","html_url":"https://github.com/kubernetes-sigs/kubespray/pull/3958#issuecomment-451075781","issue_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/3958","id":451075781,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTA3NTc4MQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-01-03T08:03:05Z","updated_at":"2019-01-03T08:03:05Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes-sigs/kubespray/pull/3958#\" title=\"Author self-approved\">chadswen</a>*, *<a href=\"https://github.com/kubernetes-sigs/kubespray/pull/3958#issuecomment-451075767\" title=\"Approved\">woopstar</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [chadswen,woopstar]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}