{"action":"created","issue":{"url":"https://api.github.com/repos/secdev/scapy/issues/1201","repository_url":"https://api.github.com/repos/secdev/scapy","labels_url":"https://api.github.com/repos/secdev/scapy/issues/1201/labels{/name}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/1201/comments","events_url":"https://api.github.com/repos/secdev/scapy/issues/1201/events","html_url":"https://github.com/secdev/scapy/pull/1201","id":301686624,"number":1201,"title":"[fix] id in LLDPDUChassisID was from type XStrLenField but this seems…","user":{"login":"smehner1","id":8543146,"avatar_url":"https://avatars3.githubusercontent.com/u/8543146?v=4","gravatar_id":"","url":"https://api.github.com/users/smehner1","html_url":"https://github.com/smehner1","followers_url":"https://api.github.com/users/smehner1/followers","following_url":"https://api.github.com/users/smehner1/following{/other_user}","gists_url":"https://api.github.com/users/smehner1/gists{/gist_id}","starred_url":"https://api.github.com/users/smehner1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehner1/subscriptions","organizations_url":"https://api.github.com/users/smehner1/orgs","repos_url":"https://api.github.com/users/smehner1/repos","events_url":"https://api.github.com/users/smehner1/events{/privacy}","received_events_url":"https://api.github.com/users/smehner1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-02T08:20:06Z","updated_at":"2018-03-09T13:33:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/secdev/scapy/pulls/1201","html_url":"https://github.com/secdev/scapy/pull/1201","diff_url":"https://github.com/secdev/scapy/pull/1201.diff","patch_url":"https://github.com/secdev/scapy/pull/1201.patch"},"body":"if you create a LLDPDUChassisID packet with subtype 0x04 (MAC address) there was no MAC address in 'show()' but an long integer value\r\n\r\ne.g. for chosen chassis id: \"ff:dd:ee:bb:aa:99\" this is the output:\r\n\r\n--- XStrLenField ---\r\n...\r\n        _type     = chassis id\r\n        _length   = 18\r\n        subtype   = MAC address\r\n        id        = 66663a64643a65653a62623a61613a3939\r\n...\r\n\r\nLLDPDUPortID has a similar structure of the packet and at the end there was a MAC address\r\n\r\nSo I changed XStrLenField to StrLenField like in LLDPDUPortID:\r\n\r\n--- StrLenField ---\r\n...\r\n     _type     = chassis id\r\n     _length   = None\r\n     subtype   = MAC address\r\n     id        = 'ff:dd:ee:bb:aa:99'\r\n...\r\n\r\nNevertheless there are some more problems in this file.\r\nwireshark marks all packets as corrupt\r\n-> original lldpd linux daemon creates chassis id tlv with a length of 7 -> here it is always 18\r\n-> when manually setting _length attribute to 7, this will work so far, but the packet is still not correct"},"comment":{"url":"https://api.github.com/repos/secdev/scapy/issues/comments/371813054","html_url":"https://github.com/secdev/scapy/pull/1201#issuecomment-371813054","issue_url":"https://api.github.com/repos/secdev/scapy/issues/1201","id":371813054,"user":{"login":"guedou","id":11683796,"avatar_url":"https://avatars1.githubusercontent.com/u/11683796?v=4","gravatar_id":"","url":"https://api.github.com/users/guedou","html_url":"https://github.com/guedou","followers_url":"https://api.github.com/users/guedou/followers","following_url":"https://api.github.com/users/guedou/following{/other_user}","gists_url":"https://api.github.com/users/guedou/gists{/gist_id}","starred_url":"https://api.github.com/users/guedou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guedou/subscriptions","organizations_url":"https://api.github.com/users/guedou/orgs","repos_url":"https://api.github.com/users/guedou/repos","events_url":"https://api.github.com/users/guedou/events{/privacy}","received_events_url":"https://api.github.com/users/guedou/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T13:33:59Z","updated_at":"2018-03-09T13:33:59Z","author_association":"OWNER","body":"@smehner1 could you implement a regression test in https://github.com/secdev/scapy/blob/master/scapy/contrib/lldp.uts ? Thanks."}}
{"actor":{"display_login":"guedou"}}