{"action":"closed","number":119,"pull_request":{"url":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/119","id":204293714,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjkzNzE0","html_url":"https://github.com/FeelTrainCoop/shortcut/pull/119","diff_url":"https://github.com/FeelTrainCoop/shortcut/pull/119.diff","patch_url":"https://github.com/FeelTrainCoop/shortcut/pull/119.patch","issue_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/119","number":119,"state":"closed","locked":false,"title":"Upgrade to React Router v4","user":{"login":"dariusk","id":266454,"node_id":"MDQ6VXNlcjI2NjQ1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/266454?v=4","gravatar_id":"","url":"https://api.github.com/users/dariusk","html_url":"https://github.com/dariusk","followers_url":"https://api.github.com/users/dariusk/followers","following_url":"https://api.github.com/users/dariusk/following{/other_user}","gists_url":"https://api.github.com/users/dariusk/gists{/gist_id}","starred_url":"https://api.github.com/users/dariusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariusk/subscriptions","organizations_url":"https://api.github.com/users/dariusk/orgs","repos_url":"https://api.github.com/users/dariusk/repos","events_url":"https://api.github.com/users/dariusk/events{/privacy}","received_events_url":"https://api.github.com/users/dariusk/received_events","type":"User","site_admin":false},"body":"This PR upgrades us from React Router v3 to v4. I decided to upgrade mostly because v4 handles nested routes in a really sensible way, but this also allowed me to remove our entire \"view\" system that was really hacked together and didn't perform very well. We now rely on strict react-router-dom routes defined in `Main.js` on the client, which is a huge improvement in code readability (it's declarative!) and performance (our weird state system was getting triggered multiple times, basically resulting in full page repaints).\r\n\r\nCloses #12. Closes #13. Closes #117.","created_at":"2018-07-26T23:30:46Z","updated_at":"2018-07-27T00:00:08Z","closed_at":"2018-07-27T00:00:08Z","merged_at":"2018-07-27T00:00:07Z","merge_commit_sha":"551754b14836407ab286529f76f82c29506561f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/119/commits","review_comments_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/119/comments","review_comment_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/119/comments","statuses_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/statuses/b3a39ea9add788f97758751662c22f78bbb08d52","head":{"label":"FeelTrainCoop:117-upgrade-react-router","ref":"117-upgrade-react-router","sha":"b3a39ea9add788f97758751662c22f78bbb08d52","user":{"login":"FeelTrainCoop","id":13396392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzk2Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/13396392?v=4","gravatar_id":"","url":"https://api.github.com/users/FeelTrainCoop","html_url":"https://github.com/FeelTrainCoop","followers_url":"https://api.github.com/users/FeelTrainCoop/followers","following_url":"https://api.github.com/users/FeelTrainCoop/following{/other_user}","gists_url":"https://api.github.com/users/FeelTrainCoop/gists{/gist_id}","starred_url":"https://api.github.com/users/FeelTrainCoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeelTrainCoop/subscriptions","organizations_url":"https://api.github.com/users/FeelTrainCoop/orgs","repos_url":"https://api.github.com/users/FeelTrainCoop/repos","events_url":"https://api.github.com/users/FeelTrainCoop/events{/privacy}","received_events_url":"https://api.github.com/users/FeelTrainCoop/received_events","type":"Organization","site_admin":false},"repo":{"id":99033570,"node_id":"MDEwOlJlcG9zaXRvcnk5OTAzMzU3MA==","name":"shortcut","full_name":"FeelTrainCoop/shortcut","owner":{"login":"FeelTrainCoop","id":13396392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzk2Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/13396392?v=4","gravatar_id":"","url":"https://api.github.com/users/FeelTrainCoop","html_url":"https://github.com/FeelTrainCoop","followers_url":"https://api.github.com/users/FeelTrainCoop/followers","following_url":"https://api.github.com/users/FeelTrainCoop/following{/other_user}","gists_url":"https://api.github.com/users/FeelTrainCoop/gists{/gist_id}","starred_url":"https://api.github.com/users/FeelTrainCoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeelTrainCoop/subscriptions","organizations_url":"https://api.github.com/users/FeelTrainCoop/orgs","repos_url":"https://api.github.com/users/FeelTrainCoop/repos","events_url":"https://api.github.com/users/FeelTrainCoop/events{/privacy}","received_events_url":"https://api.github.com/users/FeelTrainCoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FeelTrainCoop/shortcut","description":"An open source tool for fans to cut and share their favorite podcast clips.","fork":false,"url":"https://api.github.com/repos/FeelTrainCoop/shortcut","forks_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/forks","keys_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/teams","hooks_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/hooks","issue_events_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/events{/number}","events_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/events","assignees_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/assignees{/user}","branches_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/branches{/branch}","tags_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/tags","blobs_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/refs{/sha}","trees_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/statuses/{sha}","languages_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/languages","stargazers_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/stargazers","contributors_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/contributors","subscribers_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/subscribers","subscription_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/subscription","commits_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/commits{/sha}","git_commits_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/commits{/sha}","comments_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/comments{/number}","issue_comment_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/comments{/number}","contents_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/contents/{+path}","compare_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/merges","archive_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/downloads","issues_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues{/number}","pulls_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls{/number}","milestones_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/milestones{/number}","notifications_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/labels{/name}","releases_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/releases{/id}","deployments_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/deployments","created_at":"2017-08-01T18:58:11Z","updated_at":"2018-07-13T04:39:03Z","pushed_at":"2018-07-27T00:00:07Z","git_url":"git://github.com/FeelTrainCoop/shortcut.git","ssh_url":"git@github.com:FeelTrainCoop/shortcut.git","clone_url":"https://github.com/FeelTrainCoop/shortcut.git","svn_url":"https://github.com/FeelTrainCoop/shortcut","homepage":null,"size":16120,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8,"open_issues":14,"watchers":80,"default_branch":"master"}},"base":{"label":"FeelTrainCoop:master","ref":"master","sha":"72e1a64856ee6899ed4cc20a48865343d05dbe42","user":{"login":"FeelTrainCoop","id":13396392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzk2Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/13396392?v=4","gravatar_id":"","url":"https://api.github.com/users/FeelTrainCoop","html_url":"https://github.com/FeelTrainCoop","followers_url":"https://api.github.com/users/FeelTrainCoop/followers","following_url":"https://api.github.com/users/FeelTrainCoop/following{/other_user}","gists_url":"https://api.github.com/users/FeelTrainCoop/gists{/gist_id}","starred_url":"https://api.github.com/users/FeelTrainCoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeelTrainCoop/subscriptions","organizations_url":"https://api.github.com/users/FeelTrainCoop/orgs","repos_url":"https://api.github.com/users/FeelTrainCoop/repos","events_url":"https://api.github.com/users/FeelTrainCoop/events{/privacy}","received_events_url":"https://api.github.com/users/FeelTrainCoop/received_events","type":"Organization","site_admin":false},"repo":{"id":99033570,"node_id":"MDEwOlJlcG9zaXRvcnk5OTAzMzU3MA==","name":"shortcut","full_name":"FeelTrainCoop/shortcut","owner":{"login":"FeelTrainCoop","id":13396392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzk2Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/13396392?v=4","gravatar_id":"","url":"https://api.github.com/users/FeelTrainCoop","html_url":"https://github.com/FeelTrainCoop","followers_url":"https://api.github.com/users/FeelTrainCoop/followers","following_url":"https://api.github.com/users/FeelTrainCoop/following{/other_user}","gists_url":"https://api.github.com/users/FeelTrainCoop/gists{/gist_id}","starred_url":"https://api.github.com/users/FeelTrainCoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeelTrainCoop/subscriptions","organizations_url":"https://api.github.com/users/FeelTrainCoop/orgs","repos_url":"https://api.github.com/users/FeelTrainCoop/repos","events_url":"https://api.github.com/users/FeelTrainCoop/events{/privacy}","received_events_url":"https://api.github.com/users/FeelTrainCoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FeelTrainCoop/shortcut","description":"An open source tool for fans to cut and share their favorite podcast clips.","fork":false,"url":"https://api.github.com/repos/FeelTrainCoop/shortcut","forks_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/forks","keys_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/teams","hooks_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/hooks","issue_events_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/events{/number}","events_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/events","assignees_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/assignees{/user}","branches_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/branches{/branch}","tags_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/tags","blobs_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/refs{/sha}","trees_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/statuses/{sha}","languages_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/languages","stargazers_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/stargazers","contributors_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/contributors","subscribers_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/subscribers","subscription_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/subscription","commits_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/commits{/sha}","git_commits_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/git/commits{/sha}","comments_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/comments{/number}","issue_comment_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/comments{/number}","contents_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/contents/{+path}","compare_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/merges","archive_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/downloads","issues_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues{/number}","pulls_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls{/number}","milestones_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/milestones{/number}","notifications_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/labels{/name}","releases_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/releases{/id}","deployments_url":"https://api.github.com/repos/FeelTrainCoop/shortcut/deployments","created_at":"2017-08-01T18:58:11Z","updated_at":"2018-07-13T04:39:03Z","pushed_at":"2018-07-27T00:00:07Z","git_url":"git://github.com/FeelTrainCoop/shortcut.git","ssh_url":"git@github.com:FeelTrainCoop/shortcut.git","clone_url":"https://github.com/FeelTrainCoop/shortcut.git","svn_url":"https://github.com/FeelTrainCoop/shortcut","homepage":null,"size":16120,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8,"open_issues":14,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/119"},"html":{"href":"https://github.com/FeelTrainCoop/shortcut/pull/119"},"issue":{"href":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/119"},"comments":{"href":"https://api.github.com/repos/FeelTrainCoop/shortcut/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FeelTrainCoop/shortcut/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/FeelTrainCoop/shortcut/statuses/b3a39ea9add788f97758751662c22f78bbb08d52"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dariusk","id":266454,"node_id":"MDQ6VXNlcjI2NjQ1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/266454?v=4","gravatar_id":"","url":"https://api.github.com/users/dariusk","html_url":"https://github.com/dariusk","followers_url":"https://api.github.com/users/dariusk/followers","following_url":"https://api.github.com/users/dariusk/following{/other_user}","gists_url":"https://api.github.com/users/dariusk/gists{/gist_id}","starred_url":"https://api.github.com/users/dariusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariusk/subscriptions","organizations_url":"https://api.github.com/users/dariusk/orgs","repos_url":"https://api.github.com/users/dariusk/repos","events_url":"https://api.github.com/users/dariusk/events{/privacy}","received_events_url":"https://api.github.com/users/dariusk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":158,"deletions":202,"changed_files":8}}
{"actor":{"display_login":"dariusk"}}