{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/181895412","pull_request_review_id":112600754,"id":181895412,"diff_hunk":"@@ -8,9 +10,25 @@ namespace Microsoft.CodeAnalysis.CSharp.Diagnostics.NamingStyles\n     [DiagnosticAnalyzer(LanguageNames.CSharp)]\n     internal sealed class CSharpNamingStyleDiagnosticAnalyzer : NamingStyleDiagnosticAnalyzerBase\n     {\n-        public CSharpNamingStyleDiagnosticAnalyzer()\n+        protected sealed override void OnCompilationStartAction(\n+            CompilationStartAnalysisContext context,\n+            ConcurrentDictionary<Guid, ConcurrentDictionary<string, string>> idToCachedResult)\n         {\n+            // HACK: RegisterSymbolAction doesn't work with local functions\n+            context.RegisterSyntaxNodeAction(SyntaxNodeAction, SyntaxKind.LocalFunctionStatement);\n \n+            void SyntaxNodeAction(SyntaxNodeAnalysisContext syntaxContext)","path":"src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpNamingStyleDiagnosticAnalyzer.cs","position":null,"original_position":20,"commit_id":"e2b81fc1a4aceeda298fe95239a187bcecc9fcd2","original_commit_id":"3a806e7f175d0985cd9170a78e4d9ba2bc2bf7c3","user":{"login":"Neme12","id":11444821,"avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-04-16T21:45:26Z","updated_at":"2018-04-16T21:45:26Z","html_url":"https://github.com/dotnet/roslyn/pull/26165#discussion_r181895412","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/181895412"},"html":{"href":"https://github.com/dotnet/roslyn/pull/26165#discussion_r181895412"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26165"}},"in_reply_to_id":181850782},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/26165","id":181716057,"html_url":"https://github.com/dotnet/roslyn/pull/26165","diff_url":"https://github.com/dotnet/roslyn/pull/26165.diff","patch_url":"https://github.com/dotnet/roslyn/pull/26165.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/26165","number":26165,"state":"open","locked":false,"title":"Naming style for local functions","user":{"login":"Neme12","id":11444821,"avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"body":"fixes #22440\r\n\r\nI added a new option for local functions because it seems that people are divided on whether they should be named as locals or methods. For the same reason, I think we shouldn't give them a default style for now.\r\n\r\nThey're not even included in the default set of specifications. Users can to either include them with methods or add a new specification.\r\n\r\n![image](https://user-images.githubusercontent.com/11444821/38782435-98906f8a-40f3-11e8-87bb-fbe07c184fa7.png)\r\n![image](https://user-images.githubusercontent.com/11444821/38782437-abc6db5c-40f3-11e8-9342-163f96c0498f.png)\r\n","created_at":"2018-04-15T19:28:58Z","updated_at":"2018-04-16T21:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"222296409b5379b63e83ee5df1d073f71b014896","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":166377917,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":288147422,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false},{"id":166672105,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Discussion","name":"Discussion","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/33","html_url":"https://github.com/dotnet/roslyn/milestone/33","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/33/labels","id":3020805,"number":33,"title":"15.8","description":null,"creator":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"open_issues":239,"closed_issues":78,"state":"open","created_at":"2018-01-08T19:35:57Z","updated_at":"2018-04-16T21:11:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26165/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26165/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/26165/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/e2b81fc1a4aceeda298fe95239a187bcecc9fcd2","head":{"label":"Neme12:localFunctionNamingStyle","ref":"localFunctionNamingStyle","sha":"e2b81fc1a4aceeda298fe95239a187bcecc9fcd2","user":{"login":"Neme12","id":11444821,"avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"repo":{"id":119984054,"name":"roslyn","full_name":"Neme12/roslyn","owner":{"login":"Neme12","id":11444821,"avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neme12/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/Neme12/roslyn","forks_url":"https://api.github.com/repos/Neme12/roslyn/forks","keys_url":"https://api.github.com/repos/Neme12/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neme12/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neme12/roslyn/teams","hooks_url":"https://api.github.com/repos/Neme12/roslyn/hooks","issue_events_url":"https://api.github.com/repos/Neme12/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/Neme12/roslyn/events","assignees_url":"https://api.github.com/repos/Neme12/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/Neme12/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/Neme12/roslyn/tags","blobs_url":"https://api.github.com/repos/Neme12/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neme12/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neme12/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neme12/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neme12/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/Neme12/roslyn/languages","stargazers_url":"https://api.github.com/repos/Neme12/roslyn/stargazers","contributors_url":"https://api.github.com/repos/Neme12/roslyn/contributors","subscribers_url":"https://api.github.com/repos/Neme12/roslyn/subscribers","subscription_url":"https://api.github.com/repos/Neme12/roslyn/subscription","commits_url":"https://api.github.com/repos/Neme12/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neme12/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neme12/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neme12/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neme12/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/Neme12/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neme12/roslyn/merges","archive_url":"https://api.github.com/repos/Neme12/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neme12/roslyn/downloads","issues_url":"https://api.github.com/repos/Neme12/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/Neme12/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/Neme12/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/Neme12/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neme12/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/Neme12/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/Neme12/roslyn/deployments","created_at":"2018-02-02T13:20:13Z","updated_at":"2018-04-15T14:35:31Z","pushed_at":"2018-04-16T21:43:21Z","git_url":"git://github.com/Neme12/roslyn.git","ssh_url":"git@github.com:Neme12/roslyn.git","clone_url":"https://github.com/Neme12/roslyn.git","svn_url":"https://github.com/Neme12/roslyn","homepage":"","size":323982,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5e1c3344ed329d37c49570e04f59e688934d4021","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-04-16T20:49:57Z","pushed_at":"2018-04-16T21:43:24Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":345053,"stargazers_count":9167,"watchers_count":9167,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2197,"mirror_url":null,"archived":false,"open_issues_count":4658,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2197,"open_issues":4658,"watchers":9167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26165"},"html":{"href":"https://github.com/dotnet/roslyn/pull/26165"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26165"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26165/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26165/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26165/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/e2b81fc1a4aceeda298fe95239a187bcecc9fcd2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Neme12"}}