{"action":"reopened","issue":{"url":"https://api.github.com/repos/fog/fog-openstack/issues/350","repository_url":"https://api.github.com/repos/fog/fog-openstack","labels_url":"https://api.github.com/repos/fog/fog-openstack/issues/350/labels{/name}","comments_url":"https://api.github.com/repos/fog/fog-openstack/issues/350/comments","events_url":"https://api.github.com/repos/fog/fog-openstack/issues/350/events","html_url":"https://github.com/fog/fog-openstack/issues/350","id":287210979,"number":350,"title":"Failing unit tests locally","user":{"login":"timuralp","id":703870,"avatar_url":"https://avatars2.githubusercontent.com/u/703870?v=4","gravatar_id":"","url":"https://api.github.com/users/timuralp","html_url":"https://github.com/timuralp","followers_url":"https://api.github.com/users/timuralp/followers","following_url":"https://api.github.com/users/timuralp/following{/other_user}","gists_url":"https://api.github.com/users/timuralp/gists{/gist_id}","starred_url":"https://api.github.com/users/timuralp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timuralp/subscriptions","organizations_url":"https://api.github.com/users/timuralp/orgs","repos_url":"https://api.github.com/users/timuralp/repos","events_url":"https://api.github.com/users/timuralp/events{/privacy}","received_events_url":"https://api.github.com/users/timuralp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-01-09T19:58:52Z","updated_at":"2018-02-12T06:14:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Looks like I'm unable to run unit tests locally without failure, as the following tests fail:\r\n```\r\nFog::Orchestration[:openstack] | stack requests::success#test_0005_#recurse_template_and_file\r\nFog::Orchestration[:openstack] | stack requests::success#test_0002_#get_file_contents_local_template\r\n```\r\nIn both cases, the failure is:\r\n```\r\nErrno::ENOENT: No such file or directory @ rb_sysopen - ///home/travis/build/fog/fog-openstack/test/requests/orchestration/no_recursion.yaml\r\n```\r\n\r\nI looked through the changes there, and it looks like it's related to the following change (from 2b32ce8b3d000b20d196601ddbda048d9a463554):\r\n```\r\ndiff --git a/lib/fog/orchestration/util/recursive_hot_file_loader.rb b/lib/fog/orchestration/util/recursive_hot_file_loader.rb\r\nindex 1de6f15..9361588 100644\r\n--- a/lib/fog/orchestration/util/recursive_hot_file_loader.rb\r\n+++ b/lib/fog/orchestration/util/recursive_hot_file_loader.rb\r\n@@ -123,10 +117,8 @@ module Fog\r\n-            # Don't process file:// outside our base_url. TODO raise an exception here?\r\n-            next if file_outside_base_url?(base_url, str_url)\r\n \r\n-            file_content = get_content(str_url)\r\n+            file_content = read_uri(str_url)\r\n```\r\n\r\n@ioggstream, could you look into this? My understanding is that there is a .yaml template that specifies a URL that conflicts with the base URL used. Previously, this would be skipped over (with a possible TODO for an exception), but now fetching there is an implicit requirement to recreate the `/home/travis/...` build path. I think the solution here could be to mock out the file, verify the path, and return contents from `$FOG_OPENSTACK/test/requests/orchestration/no_recursion.yaml`."}}
{"actor":{"display_login":"gildub"}}