{"action":"created","comment":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/197772126","pull_request_review_id":131578207,"id":197772126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc3MjEyNg==","diff_hunk":"@@ -77,111 +61,62 @@ class CameraPure extends React.Component<CameraPureType> {\n   }\n \n   render() {\n-    const {method, autoCapture, title, subTitle, onUploadFallback, onFallbackClick,\n-      onUserMedia, faceCaptureClick, webcamRef, isFullScreen, onWebcamError, i18n} = this.props;\n+    const {method, title, subTitle, onUploadFallback, onFallbackClick,\n+      onUserMedia, webcamRef, isFullScreen, onWebcamError, i18n, liveness: video} = this.props;\n \n     return (\n       <div className={style.camera}>\n         <Title {...{title, subTitle, isFullScreen}} smaller={true}/>\n         <div className={classNames(style[\"video-overlay\"], {[style.overlayFullScreen]: isFullScreen})}>\n           <Webcam\n             className={style.video}\n-            audio={false}\n+            audio={!!video}\n             height={720}\n             {...{onUserMedia, ref: webcamRef, onFailure: onWebcamError}}\n           />\n           <Overlay {...{method, isFullScreen}}/>\n-          <UploadFallback {...{onUploadFallback, onFallbackClick, method, i18n}}/>\n+          { !video && <UploadFallback {...{onUploadFallback, onFallbackClick, method, i18n}}/> }\n         </div>\n-        { autoCapture ? '' : <CaptureActions handeClick={faceCaptureClick} {...{i18n, isFullScreen}}/>}\n       </div>\n     )\n   }\n }\n \n-type CameraType = {\n-  ...CameraCommonType,\n-  onScreenshot: Function,\n-  trackScreen: Function,\n-}\n-\n type CameraStateType = {\n   hasWebcamAccess: boolean,\n   hasSeenPermissionsPrimer: boolean,\n }\n \n export default class Camera extends React.Component<CameraType, CameraStateType> {\n-  webcam: ?React$ElementRef<typeof Webcam> = null\n-  interval: ?Visibility\n-\n-  state:CameraStateType = {\n+  state: CameraStateType = {\n     hasWebcamAccess: false,\n     hasSeenPermissionsPrimer: false,\n   }\n \n-  capture = {\n-    start: () => {\n-      this.capture.stop()\n-      this.interval = Visibility.every(1000, this.screenshot)\n-    },\n-    stop: () => Visibility.stop(this.interval),\n-    once: () => {\n-      this.screenshot()\n-    }\n-  }\n-\n   constructor (props: CameraType) {","path":"src/components/Camera/index.js","position":162,"original_position":162,"commit_id":"4fd641a33431f9a6bf4d8c81e59df4d0d820c3fe","original_commit_id":"4fd641a33431f9a6bf4d8c81e59df4d0d820c3fe","user":{"login":"TheComfyChair","id":18562500,"node_id":"MDQ6VXNlcjE4NTYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/18562500?v=4","gravatar_id":"","url":"https://api.github.com/users/TheComfyChair","html_url":"https://github.com/TheComfyChair","followers_url":"https://api.github.com/users/TheComfyChair/followers","following_url":"https://api.github.com/users/TheComfyChair/following{/other_user}","gists_url":"https://api.github.com/users/TheComfyChair/gists{/gist_id}","starred_url":"https://api.github.com/users/TheComfyChair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheComfyChair/subscriptions","organizations_url":"https://api.github.com/users/TheComfyChair/orgs","repos_url":"https://api.github.com/users/TheComfyChair/repos","events_url":"https://api.github.com/users/TheComfyChair/events{/privacy}","received_events_url":"https://api.github.com/users/TheComfyChair/received_events","type":"User","site_admin":false},"body":"minor nitpick: If you're not doing anything except calling super(props), this constructor can be dropped :)","created_at":"2018-06-25T12:08:10Z","updated_at":"2018-06-25T12:21:51Z","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/350#discussion_r197772126","pull_request_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/197772126"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/350#discussion_r197772126"},"pull_request":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350","id":196502414,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTAyNDE0","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/350","diff_url":"https://github.com/onfido/onfido-sdk-ui/pull/350.diff","patch_url":"https://github.com/onfido/onfido-sdk-ui/pull/350.patch","issue_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/350","number":350,"state":"open","locked":false,"title":"Feature/liveness cx 2093","user":{"login":"stefaniacardenas","id":7127427,"node_id":"MDQ6VXNlcjcxMjc0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/7127427?v=4","gravatar_id":"","url":"https://api.github.com/users/stefaniacardenas","html_url":"https://github.com/stefaniacardenas","followers_url":"https://api.github.com/users/stefaniacardenas/followers","following_url":"https://api.github.com/users/stefaniacardenas/following{/other_user}","gists_url":"https://api.github.com/users/stefaniacardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/stefaniacardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefaniacardenas/subscriptions","organizations_url":"https://api.github.com/users/stefaniacardenas/orgs","repos_url":"https://api.github.com/users/stefaniacardenas/repos","events_url":"https://api.github.com/users/stefaniacardenas/events{/privacy}","received_events_url":"https://api.github.com/users/stefaniacardenas/received_events","type":"User","site_admin":false},"body":"# Problem\r\nUser should be able to record a video and reproduce it\r\n\r\n# Solution\r\nBy adding `?liveness=true`, once on the face step, a user can record a video and reproduce it.\r\nLiveness feature is currently behind a feature flag.\r\n\r\n## Checklist\r\n_put `n/a` if item is not relevant to PR changes_\r\n\r\n- [n/a] Have the CHANGELOG, README, MIGRATION, RELEASE_GUIDELINES docs been updated?\r\n- [n/a] Have new automated tests been implemented?\r\n- [x] Have new manual tests been written down?\r\n- [x] Have tests passed locally?\r\n- [x] Have any new strings been translated?\r\n","created_at":"2018-06-21T16:04:57Z","updated_at":"2018-06-25T12:21:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5f33813d6540b6d46209a4805123450ed1b672f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rsilva4","id":374537,"node_id":"MDQ6VXNlcjM3NDUzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/374537?v=4","gravatar_id":"","url":"https://api.github.com/users/rsilva4","html_url":"https://github.com/rsilva4","followers_url":"https://api.github.com/users/rsilva4/followers","following_url":"https://api.github.com/users/rsilva4/following{/other_user}","gists_url":"https://api.github.com/users/rsilva4/gists{/gist_id}","starred_url":"https://api.github.com/users/rsilva4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsilva4/subscriptions","organizations_url":"https://api.github.com/users/rsilva4/orgs","repos_url":"https://api.github.com/users/rsilva4/repos","events_url":"https://api.github.com/users/rsilva4/events{/privacy}","received_events_url":"https://api.github.com/users/rsilva4/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350/commits","review_comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350/comments","review_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/350/comments","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/4fd641a33431f9a6bf4d8c81e59df4d0d820c3fe","head":{"label":"onfido:feature/liveness-cx-2093","ref":"feature/liveness-cx-2093","sha":"4fd641a33431f9a6bf4d8c81e59df4d0d820c3fe","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2018-06-20T11:39:24Z","pushed_at":"2018-06-25T11:20:01Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"git@github.com:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":12255,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":7,"watchers":38,"default_branch":"master"}},"base":{"label":"onfido:development","ref":"development","sha":"d7bc2b7ffb7af99006ce5a74bd3bdbc4a322621d","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2018-06-20T11:39:24Z","pushed_at":"2018-06-25T11:20:01Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"git@github.com:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":12255,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":7,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/350"},"issue":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/350"},"comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/4fd641a33431f9a6bf4d8c81e59df4d0d820c3fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TheComfyChair"}}