{"action":"opened","number":38,"pull_request":{"url":"https://api.github.com/repos/ghowland/web6.0/pulls/38","id":185311532,"html_url":"https://github.com/ghowland/web6.0/pull/38","diff_url":"https://github.com/ghowland/web6.0/pull/38.diff","patch_url":"https://github.com/ghowland/web6.0/pull/38.patch","issue_url":"https://api.github.com/repos/ghowland/web6.0/issues/38","number":38,"state":"open","locked":false,"title":"Move config to a separate package","user":{"login":"ketkar","id":6488156,"avatar_url":"https://avatars0.githubusercontent.com/u/6488156?v=4","gravatar_id":"","url":"https://api.github.com/users/ketkar","html_url":"https://github.com/ketkar","followers_url":"https://api.github.com/users/ketkar/followers","following_url":"https://api.github.com/users/ketkar/following{/other_user}","gists_url":"https://api.github.com/users/ketkar/gists{/gist_id}","starred_url":"https://api.github.com/users/ketkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketkar/subscriptions","organizations_url":"https://api.github.com/users/ketkar/orgs","repos_url":"https://api.github.com/users/ketkar/repos","events_url":"https://api.github.com/users/ketkar/events{/privacy}","received_events_url":"https://api.github.com/users/ketkar/received_events","type":"User","site_admin":false},"body":"A package needing the Config struct, while also getting started by Start(), will create a circular dependency (which isn't allowed). In this diff, I separate the config into a separate package so multiple packages can call its functions. \r\n\r\nThis will unblock the job runner, which also connects to the DB and requires access to the Config struct. \r\n\r\nNo expected change in functionality. Tested locally. ","created_at":"2018-05-02T00:57:00Z","updated_at":"2018-05-02T00:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ghowland/web6.0/pulls/38/commits","review_comments_url":"https://api.github.com/repos/ghowland/web6.0/pulls/38/comments","review_comment_url":"https://api.github.com/repos/ghowland/web6.0/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghowland/web6.0/issues/38/comments","statuses_url":"https://api.github.com/repos/ghowland/web6.0/statuses/004a578f3bbac513199929149ad5e2dfb97da0ec","head":{"label":"ketkar:config-package","ref":"config-package","sha":"004a578f3bbac513199929149ad5e2dfb97da0ec","user":{"login":"ketkar","id":6488156,"avatar_url":"https://avatars0.githubusercontent.com/u/6488156?v=4","gravatar_id":"","url":"https://api.github.com/users/ketkar","html_url":"https://github.com/ketkar","followers_url":"https://api.github.com/users/ketkar/followers","following_url":"https://api.github.com/users/ketkar/following{/other_user}","gists_url":"https://api.github.com/users/ketkar/gists{/gist_id}","starred_url":"https://api.github.com/users/ketkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketkar/subscriptions","organizations_url":"https://api.github.com/users/ketkar/orgs","repos_url":"https://api.github.com/users/ketkar/repos","events_url":"https://api.github.com/users/ketkar/events{/privacy}","received_events_url":"https://api.github.com/users/ketkar/received_events","type":"User","site_admin":false},"repo":{"id":123341601,"name":"web6.0","full_name":"ketkar/web6.0","owner":{"login":"ketkar","id":6488156,"avatar_url":"https://avatars0.githubusercontent.com/u/6488156?v=4","gravatar_id":"","url":"https://api.github.com/users/ketkar","html_url":"https://github.com/ketkar","followers_url":"https://api.github.com/users/ketkar/followers","following_url":"https://api.github.com/users/ketkar/following{/other_user}","gists_url":"https://api.github.com/users/ketkar/gists{/gist_id}","starred_url":"https://api.github.com/users/ketkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketkar/subscriptions","organizations_url":"https://api.github.com/users/ketkar/orgs","repos_url":"https://api.github.com/users/ketkar/repos","events_url":"https://api.github.com/users/ketkar/events{/privacy}","received_events_url":"https://api.github.com/users/ketkar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ketkar/web6.0","description":"Web Six Point Oh","fork":true,"url":"https://api.github.com/repos/ketkar/web6.0","forks_url":"https://api.github.com/repos/ketkar/web6.0/forks","keys_url":"https://api.github.com/repos/ketkar/web6.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ketkar/web6.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ketkar/web6.0/teams","hooks_url":"https://api.github.com/repos/ketkar/web6.0/hooks","issue_events_url":"https://api.github.com/repos/ketkar/web6.0/issues/events{/number}","events_url":"https://api.github.com/repos/ketkar/web6.0/events","assignees_url":"https://api.github.com/repos/ketkar/web6.0/assignees{/user}","branches_url":"https://api.github.com/repos/ketkar/web6.0/branches{/branch}","tags_url":"https://api.github.com/repos/ketkar/web6.0/tags","blobs_url":"https://api.github.com/repos/ketkar/web6.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ketkar/web6.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ketkar/web6.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/ketkar/web6.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ketkar/web6.0/statuses/{sha}","languages_url":"https://api.github.com/repos/ketkar/web6.0/languages","stargazers_url":"https://api.github.com/repos/ketkar/web6.0/stargazers","contributors_url":"https://api.github.com/repos/ketkar/web6.0/contributors","subscribers_url":"https://api.github.com/repos/ketkar/web6.0/subscribers","subscription_url":"https://api.github.com/repos/ketkar/web6.0/subscription","commits_url":"https://api.github.com/repos/ketkar/web6.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/ketkar/web6.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/ketkar/web6.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/ketkar/web6.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/ketkar/web6.0/contents/{+path}","compare_url":"https://api.github.com/repos/ketkar/web6.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ketkar/web6.0/merges","archive_url":"https://api.github.com/repos/ketkar/web6.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ketkar/web6.0/downloads","issues_url":"https://api.github.com/repos/ketkar/web6.0/issues{/number}","pulls_url":"https://api.github.com/repos/ketkar/web6.0/pulls{/number}","milestones_url":"https://api.github.com/repos/ketkar/web6.0/milestones{/number}","notifications_url":"https://api.github.com/repos/ketkar/web6.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ketkar/web6.0/labels{/name}","releases_url":"https://api.github.com/repos/ketkar/web6.0/releases{/id}","deployments_url":"https://api.github.com/repos/ketkar/web6.0/deployments","created_at":"2018-02-28T20:57:37Z","updated_at":"2018-02-28T20:57:44Z","pushed_at":"2018-05-02T00:53:23Z","git_url":"git://github.com/ketkar/web6.0.git","ssh_url":"git@github.com:ketkar/web6.0.git","clone_url":"https://github.com/ketkar/web6.0.git","svn_url":"https://github.com/ketkar/web6.0","homepage":null,"size":11746,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ghowland:master","ref":"master","sha":"74b4acdabcd0cee0676573e324310fa3e5cb3081","user":{"login":"ghowland","id":2231935,"avatar_url":"https://avatars1.githubusercontent.com/u/2231935?v=4","gravatar_id":"","url":"https://api.github.com/users/ghowland","html_url":"https://github.com/ghowland","followers_url":"https://api.github.com/users/ghowland/followers","following_url":"https://api.github.com/users/ghowland/following{/other_user}","gists_url":"https://api.github.com/users/ghowland/gists{/gist_id}","starred_url":"https://api.github.com/users/ghowland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghowland/subscriptions","organizations_url":"https://api.github.com/users/ghowland/orgs","repos_url":"https://api.github.com/users/ghowland/repos","events_url":"https://api.github.com/users/ghowland/events{/privacy}","received_events_url":"https://api.github.com/users/ghowland/received_events","type":"User","site_admin":false},"repo":{"id":106609796,"name":"web6.0","full_name":"ghowland/web6.0","owner":{"login":"ghowland","id":2231935,"avatar_url":"https://avatars1.githubusercontent.com/u/2231935?v=4","gravatar_id":"","url":"https://api.github.com/users/ghowland","html_url":"https://github.com/ghowland","followers_url":"https://api.github.com/users/ghowland/followers","following_url":"https://api.github.com/users/ghowland/following{/other_user}","gists_url":"https://api.github.com/users/ghowland/gists{/gist_id}","starred_url":"https://api.github.com/users/ghowland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghowland/subscriptions","organizations_url":"https://api.github.com/users/ghowland/orgs","repos_url":"https://api.github.com/users/ghowland/repos","events_url":"https://api.github.com/users/ghowland/events{/privacy}","received_events_url":"https://api.github.com/users/ghowland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghowland/web6.0","description":"Web Six Point Oh","fork":false,"url":"https://api.github.com/repos/ghowland/web6.0","forks_url":"https://api.github.com/repos/ghowland/web6.0/forks","keys_url":"https://api.github.com/repos/ghowland/web6.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghowland/web6.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghowland/web6.0/teams","hooks_url":"https://api.github.com/repos/ghowland/web6.0/hooks","issue_events_url":"https://api.github.com/repos/ghowland/web6.0/issues/events{/number}","events_url":"https://api.github.com/repos/ghowland/web6.0/events","assignees_url":"https://api.github.com/repos/ghowland/web6.0/assignees{/user}","branches_url":"https://api.github.com/repos/ghowland/web6.0/branches{/branch}","tags_url":"https://api.github.com/repos/ghowland/web6.0/tags","blobs_url":"https://api.github.com/repos/ghowland/web6.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghowland/web6.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghowland/web6.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghowland/web6.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghowland/web6.0/statuses/{sha}","languages_url":"https://api.github.com/repos/ghowland/web6.0/languages","stargazers_url":"https://api.github.com/repos/ghowland/web6.0/stargazers","contributors_url":"https://api.github.com/repos/ghowland/web6.0/contributors","subscribers_url":"https://api.github.com/repos/ghowland/web6.0/subscribers","subscription_url":"https://api.github.com/repos/ghowland/web6.0/subscription","commits_url":"https://api.github.com/repos/ghowland/web6.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghowland/web6.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghowland/web6.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghowland/web6.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghowland/web6.0/contents/{+path}","compare_url":"https://api.github.com/repos/ghowland/web6.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghowland/web6.0/merges","archive_url":"https://api.github.com/repos/ghowland/web6.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghowland/web6.0/downloads","issues_url":"https://api.github.com/repos/ghowland/web6.0/issues{/number}","pulls_url":"https://api.github.com/repos/ghowland/web6.0/pulls{/number}","milestones_url":"https://api.github.com/repos/ghowland/web6.0/milestones{/number}","notifications_url":"https://api.github.com/repos/ghowland/web6.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghowland/web6.0/labels{/name}","releases_url":"https://api.github.com/repos/ghowland/web6.0/releases{/id}","deployments_url":"https://api.github.com/repos/ghowland/web6.0/deployments","created_at":"2017-10-11T21:09:48Z","updated_at":"2018-05-01T05:35:09Z","pushed_at":"2018-05-01T05:35:08Z","git_url":"git://github.com/ghowland/web6.0.git","ssh_url":"git@github.com:ghowland/web6.0.git","clone_url":"https://github.com/ghowland/web6.0.git","svn_url":"https://github.com/ghowland/web6.0","homepage":null,"size":11729,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghowland/web6.0/pulls/38"},"html":{"href":"https://github.com/ghowland/web6.0/pull/38"},"issue":{"href":"https://api.github.com/repos/ghowland/web6.0/issues/38"},"comments":{"href":"https://api.github.com/repos/ghowland/web6.0/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/ghowland/web6.0/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/ghowland/web6.0/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghowland/web6.0/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/ghowland/web6.0/statuses/004a578f3bbac513199929149ad5e2dfb97da0ec"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":64,"deletions":45,"changed_files":3}}
{"actor":{"display_login":"ketkar"}}