{"action":"created","issue":{"url":"https://api.github.com/repos/google/kythe/issues/2176","repository_url":"https://api.github.com/repos/google/kythe","labels_url":"https://api.github.com/repos/google/kythe/issues/2176/labels{/name}","comments_url":"https://api.github.com/repos/google/kythe/issues/2176/comments","events_url":"https://api.github.com/repos/google/kythe/issues/2176/events","html_url":"https://github.com/google/kythe/issues/2176","id":335636223,"node_id":"MDU6SXNzdWUzMzU2MzYyMjM=","number":2176,"title":"Documentation for `anchor` is unclear for `language` [phab:T258]","user":{"login":"kythe","id":10677145,"node_id":"MDQ6VXNlcjEwNjc3MTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/10677145?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"User","site_admin":false},"labels":[{"id":932810970,"node_id":"MDU6TGFiZWw5MzI4MTA5NzA=","url":"https://api.github.com/repos/google/kythe/labels/P2","name":"P2","color":"d97c5c","default":false},{"id":975094874,"node_id":"MDU6TGFiZWw5NzUwOTQ4NzQ=","url":"https://api.github.com/repos/google/kythe/labels/phabricator%20task","name":"phabricator task","color":"efd57f","default":false},{"id":932817892,"node_id":"MDU6TGFiZWw5MzI4MTc4OTI=","url":"https://api.github.com/repos/google/kythe/labels/schema","name":"schema","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-26T02:36:39Z","updated_at":"2018-06-28T00:33:23Z","closed_at":"2018-06-26T02:36:40Z","author_association":"COLLABORATOR","body":"_Created by **pludemann** at 2017-06-27 16:31:27_: \n\nhttp://www.kythe.io/docs/schema/#anchor has \"Language: No special rules.\"\n\nThis should be modified by either removing the comment about Language (because it's the same as most other nodes) or specifically saying that it should be the `language` as given by http://www.kythe.io/docs/schema/#lsr\nI prefer the latter because the `file` node explicitly has no `language`.\n\nAlso, the examples should have a verifier test for the language being set.\n\nAnd it wouldn't hurt if the verifier checked for non-empty `language` -- this is because the `anchor` facts are handled specially by the verifier (with ``)"},"comment":{"url":"https://api.github.com/repos/google/kythe/issues/comments/400873027","html_url":"https://github.com/google/kythe/issues/2176#issuecomment-400873027","issue_url":"https://api.github.com/repos/google/kythe/issues/2176","id":400873027,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDg3MzAyNw==","user":{"login":"kythe","id":10677145,"node_id":"MDQ6VXNlcjEwNjc3MTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/10677145?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T00:33:23Z","updated_at":"2018-06-28T00:33:23Z","author_association":"COLLABORATOR","body":"_**pludemann** wrote at 2017-06-27 17:13:44_:\n\nI would prefer explicitly saying that the `language` must be the same as other nodes. The reason is that most nodes are \"semantic\" only a few are concrete or \"syntactic\". 'file` is one and `anchor` is another. (`vcs` also, I suppose -- and I'm guessing that its `language` should be empty also)\n\nI didn't notice that the example has `language` set -- my bad ... but `verifier` should check this anyway (it should check that all nodes have `language` except for `file` and `vcs` ... does it do this check?)"}}
{"actor":{"display_login":"kythe"}}