{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2963","repository_url":"https://api.github.com/repos/Valloric/YouCompleteMe","labels_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2963/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2963/comments","events_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2963/events","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2963","id":309358314,"number":2963,"title":"[READY] Refactor CompleteDone logic","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars2.githubusercontent.com/u/10026824?v=4","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-28T13:05:09Z","updated_at":"2018-03-28T19:49:00Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2963","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2963","diff_url":"https://github.com/Valloric/YouCompleteMe/pull/2963.diff","patch_url":"https://github.com/Valloric/YouCompleteMe/pull/2963.patch"},"body":"Since the `CompleteDone` code only depends on the completion request, it makes sense to move its logic to the `CompletionRequest` class. This is also going to help fixing the issue where a FixIt is applied twice when selecting a completion:\r\n\r\n![completedone-bug](https://user-images.githubusercontent.com/10026824/38029281-bc09d224-3295-11e8-9976-d4dd031f2cca.gif)\r\n\r\nFinally, this reduces the time it takes to run the tests because the ycmd server is not started anymore in the `postcomplete` tests.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2963)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/comments/377013232","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2963#issuecomment-377013232","issue_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2963","id":377013232,"user":{"login":"bstaletic","id":7791699,"avatar_url":"https://avatars3.githubusercontent.com/u/7791699?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaletic","html_url":"https://github.com/bstaletic","followers_url":"https://api.github.com/users/bstaletic/followers","following_url":"https://api.github.com/users/bstaletic/following{/other_user}","gists_url":"https://api.github.com/users/bstaletic/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaletic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaletic/subscriptions","organizations_url":"https://api.github.com/users/bstaletic/orgs","repos_url":"https://api.github.com/users/bstaletic/repos","events_url":"https://api.github.com/users/bstaletic/events{/privacy}","received_events_url":"https://api.github.com/users/bstaletic/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T19:49:00Z","updated_at":"2018-03-28T19:49:00Z","author_association":"COLLABORATOR","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> with one small comment.\n\n---\n\nReviewed 5 of 5 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[python/ycm/tests/youcompleteme_test.py, line 41 at r1](https://beta.reviewable.io/reviews/valloric/youcompleteme/2963#-L8gmVYpprg9fyCxbuM7:-L8gmVYpprg9fyCxbuM8:b-bsq0xy) ([raw file](https://github.com/valloric/youcompleteme/blob/61bbb9a0d9dd13fd513362304e95192b374ae48b/python/ycm/tests/youcompleteme_test.py#L41)):*\n> ```Python\n>                         WaitUntilReady, YouCompleteMeInstance )\n> from ycm.client.base_request import _LoadExtraConfFile\n> # from ycm.client.completion_request import CompletionRequest\n> ```\n\nWhy the commented out import?\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/valloric/youcompleteme/2963#-:-L8i8wmLAw0hxCQxqTTh:b-mktm37)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"bstaletic"}}