{"action":"closed","issue":{"url":"https://api.github.com/repos/mozilla/iris/issues/552","repository_url":"https://api.github.com/repos/mozilla/iris","labels_url":"https://api.github.com/repos/mozilla/iris/issues/552/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/iris/issues/552/comments","events_url":"https://api.github.com/repos/mozilla/iris/issues/552/events","html_url":"https://github.com/mozilla/iris/issues/552","id":328244346,"node_id":"MDU6SXNzdWUzMjgyNDQzNDY=","number":552,"title":"Move lowres check out of maximize_window and into test runner","user":{"login":"mwobensmith","id":3019057,"node_id":"MDQ6VXNlcjMwMTkwNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/3019057?v=4","gravatar_id":"","url":"https://api.github.com/users/mwobensmith","html_url":"https://github.com/mwobensmith","followers_url":"https://api.github.com/users/mwobensmith/followers","following_url":"https://api.github.com/users/mwobensmith/following{/other_user}","gists_url":"https://api.github.com/users/mwobensmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mwobensmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwobensmith/subscriptions","organizations_url":"https://api.github.com/users/mwobensmith/orgs","repos_url":"https://api.github.com/users/mwobensmith/repos","events_url":"https://api.github.com/users/mwobensmith/events{/privacy}","received_events_url":"https://api.github.com/users/mwobensmith/received_events","type":"User","site_admin":false},"labels":[{"id":944942583,"node_id":"MDU6TGFiZWw5NDQ5NDI1ODM=","url":"https://api.github.com/repos/mozilla/iris/labels/core","name":"core","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"silviuFlorin","id":28757652,"node_id":"MDQ6VXNlcjI4NzU3NjUy","avatar_url":"https://avatars0.githubusercontent.com/u/28757652?v=4","gravatar_id":"","url":"https://api.github.com/users/silviuFlorin","html_url":"https://github.com/silviuFlorin","followers_url":"https://api.github.com/users/silviuFlorin/followers","following_url":"https://api.github.com/users/silviuFlorin/following{/other_user}","gists_url":"https://api.github.com/users/silviuFlorin/gists{/gist_id}","starred_url":"https://api.github.com/users/silviuFlorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silviuFlorin/subscriptions","organizations_url":"https://api.github.com/users/silviuFlorin/orgs","repos_url":"https://api.github.com/users/silviuFlorin/repos","events_url":"https://api.github.com/users/silviuFlorin/events{/privacy}","received_events_url":"https://api.github.com/users/silviuFlorin/received_events","type":"User","site_admin":false},"assignees":[{"login":"silviuFlorin","id":28757652,"node_id":"MDQ6VXNlcjI4NzU3NjUy","avatar_url":"https://avatars0.githubusercontent.com/u/28757652?v=4","gravatar_id":"","url":"https://api.github.com/users/silviuFlorin","html_url":"https://github.com/silviuFlorin","followers_url":"https://api.github.com/users/silviuFlorin/followers","following_url":"https://api.github.com/users/silviuFlorin/following{/other_user}","gists_url":"https://api.github.com/users/silviuFlorin/gists{/gist_id}","starred_url":"https://api.github.com/users/silviuFlorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silviuFlorin/subscriptions","organizations_url":"https://api.github.com/users/silviuFlorin/orgs","repos_url":"https://api.github.com/users/silviuFlorin/repos","events_url":"https://api.github.com/users/silviuFlorin/events{/privacy}","received_events_url":"https://api.github.com/users/silviuFlorin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mozilla/iris/milestones/1","html_url":"https://github.com/mozilla/iris/milestone/1","labels_url":"https://api.github.com/repos/mozilla/iris/milestones/1/labels","id":3400025,"node_id":"MDk6TWlsZXN0b25lMzQwMDAyNQ==","number":1,"title":"1.0","description":"Everything targeted for completion prior to Iris 1.0 release.","creator":{"login":"mwobensmith","id":3019057,"node_id":"MDQ6VXNlcjMwMTkwNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/3019057?v=4","gravatar_id":"","url":"https://api.github.com/users/mwobensmith","html_url":"https://github.com/mwobensmith","followers_url":"https://api.github.com/users/mwobensmith/followers","following_url":"https://api.github.com/users/mwobensmith/following{/other_user}","gists_url":"https://api.github.com/users/mwobensmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mwobensmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwobensmith/subscriptions","organizations_url":"https://api.github.com/users/mwobensmith/orgs","repos_url":"https://api.github.com/users/mwobensmith/repos","events_url":"https://api.github.com/users/mwobensmith/events{/privacy}","received_events_url":"https://api.github.com/users/mwobensmith/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":11,"state":"open","created_at":"2018-06-04T19:28:50Z","updated_at":"2018-06-23T01:14:48Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-05-31T18:15:56Z","updated_at":"2018-06-23T01:14:48Z","closed_at":"2018-06-23T01:14:48Z","author_association":"COLLABORATOR","body":"In #460 we updated `maximize_window` so that it does not run on low-resolution screens. The theory was that the small screen size already forced Firefox to be at its maximized state, and an attempt to maximize here actually toggled the window back into an un-maximized state. \r\n\r\nThis is a problem now, because the `maximize_window` function is so general that, when called, it has no way of knowing what the current state of the window is, and could potentially un-maximize the window. \r\n\r\nWe need a function that is more robust and recognizes the browser window state. However, at a minimum, this logic should not be in `maximize_window` and instead, should move to the test runner, where we at least know the state of each test we launch."}}
{"actor":{"display_login":"tracywalker"}}