{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/192949149","pull_request_review_id":125801438,"id":192949149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk0OTE0OQ==","diff_hunk":"@@ -0,0 +1,136 @@\n+apiVersion: v1\n+kind: Namespace\n+metadata:\n+  name: rook-minio-system\n+---\n+apiVersion: apiextensions.k8s.io/v1beta1\n+kind: CustomResourceDefinition\n+metadata:\n+  name: objectstores.minio.rook.io\n+spec:\n+  group: minio.rook.io\n+  names:\n+    kind: ObjectStore\n+    listKind: ObjectStoreList\n+    plural: objectstores\n+    singular: objectstore","path":"cluster/examples/kubernetes/minio/operator.yaml","position":16,"original_position":16,"commit_id":"a4dd9347372fbb67aca3c5e571e3dff5c0836ad8","original_commit_id":"a4dd9347372fbb67aca3c5e571e3dff5c0836ad8","user":{"login":"jbw976","id":4313439,"node_id":"MDQ6VXNlcjQzMTM0Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/4313439?v=4","gravatar_id":"","url":"https://api.github.com/users/jbw976","html_url":"https://github.com/jbw976","followers_url":"https://api.github.com/users/jbw976/followers","following_url":"https://api.github.com/users/jbw976/following{/other_user}","gists_url":"https://api.github.com/users/jbw976/gists{/gist_id}","starred_url":"https://api.github.com/users/jbw976/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbw976/subscriptions","organizations_url":"https://api.github.com/users/jbw976/orgs","repos_url":"https://api.github.com/users/jbw976/repos","events_url":"https://api.github.com/users/jbw976/events{/privacy}","received_events_url":"https://api.github.com/users/jbw976/received_events","type":"User","site_admin":false},"body":"we could consider a short name for this as well, similar to https://github.com/rook/rook/blob/master/cluster/examples/kubernetes/ceph/operator.yaml#L49","created_at":"2018-06-05T05:26:34Z","updated_at":"2018-06-05T05:52:10Z","html_url":"https://github.com/rook/rook/pull/1756#discussion_r192949149","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/1756","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/192949149"},"html":{"href":"https://github.com/rook/rook/pull/1756#discussion_r192949149"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/1756"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/1756","id":191865641,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODY1NjQx","html_url":"https://github.com/rook/rook/pull/1756","diff_url":"https://github.com/rook/rook/pull/1756.diff","patch_url":"https://github.com/rook/rook/pull/1756.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/1756","number":1756,"state":"open","locked":false,"title":"Implement Minio deployment/teardown","user":{"login":"tonya11en","id":1109246,"node_id":"MDQ6VXNlcjExMDkyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1109246?v=4","gravatar_id":"","url":"https://api.github.com/users/tonya11en","html_url":"https://github.com/tonya11en","followers_url":"https://api.github.com/users/tonya11en/followers","following_url":"https://api.github.com/users/tonya11en/following{/other_user}","gists_url":"https://api.github.com/users/tonya11en/gists{/gist_id}","starred_url":"https://api.github.com/users/tonya11en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonya11en/subscriptions","organizations_url":"https://api.github.com/users/tonya11en/orgs","repos_url":"https://api.github.com/users/tonya11en/repos","events_url":"https://api.github.com/users/tonya11en/events{/privacy}","received_events_url":"https://api.github.com/users/tonya11en/received_events","type":"User","site_admin":false},"body":"**Description of your changes:**\r\nThis patch implements the deployment/teardown of a Minio object store via an operator acting on Add/Delete events. Currently, Update events are not supported, but will be in a future PR. The operator introduces the ObjectStore CRD into the `minio.rook.io` namespace and allows for its creationg with the following parameters with the exception of the `placement` field:\r\n\r\n```\r\napiVersion: minio.rook.io/v1alpha1\r\nkind: ObjectStore\r\nmetadata:\r\n  name: my-store\r\n  namespace: rook-minio\r\nspec:\r\n  scope:\r\n    nodeCount: 4\r\n  placement:\r\n    tolerations:\r\n    nodeAffinity:\r\n    podAffinity:\r\n    podAnyAffinity:\r\n  port: 9000\r\n  credentials:\r\n    accessKey: \"TEMP_DEMO_ACCESS_KEY\"\r\n    secretKey: \"TEMP_DEMO_SECRET_KEY\"\r\n  objectStoreDataDir: \"/data\"\r\n```\r\n\r\nCurrently the `placement` field is unused in deployment.\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nResolves #1680\r\n","created_at":"2018-05-31T20:31:30Z","updated_at":"2018-06-05T05:52:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e84fcd8116c5a4a643bcb6acca024e6273b35c44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/1756/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/1756/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/1756/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/a4dd9347372fbb67aca3c5e571e3dff5c0836ad8","head":{"label":"tonya11en:minio_implementation","ref":"minio_implementation","sha":"a4dd9347372fbb67aca3c5e571e3dff5c0836ad8","user":{"login":"tonya11en","id":1109246,"node_id":"MDQ6VXNlcjExMDkyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1109246?v=4","gravatar_id":"","url":"https://api.github.com/users/tonya11en","html_url":"https://github.com/tonya11en","followers_url":"https://api.github.com/users/tonya11en/followers","following_url":"https://api.github.com/users/tonya11en/following{/other_user}","gists_url":"https://api.github.com/users/tonya11en/gists{/gist_id}","starred_url":"https://api.github.com/users/tonya11en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonya11en/subscriptions","organizations_url":"https://api.github.com/users/tonya11en/orgs","repos_url":"https://api.github.com/users/tonya11en/repos","events_url":"https://api.github.com/users/tonya11en/events{/privacy}","received_events_url":"https://api.github.com/users/tonya11en/received_events","type":"User","site_admin":false},"repo":{"id":128714930,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3MTQ5MzA=","name":"rook","full_name":"tonya11en/rook","owner":{"login":"tonya11en","id":1109246,"node_id":"MDQ6VXNlcjExMDkyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1109246?v=4","gravatar_id":"","url":"https://api.github.com/users/tonya11en","html_url":"https://github.com/tonya11en","followers_url":"https://api.github.com/users/tonya11en/followers","following_url":"https://api.github.com/users/tonya11en/following{/other_user}","gists_url":"https://api.github.com/users/tonya11en/gists{/gist_id}","starred_url":"https://api.github.com/users/tonya11en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonya11en/subscriptions","organizations_url":"https://api.github.com/users/tonya11en/orgs","repos_url":"https://api.github.com/users/tonya11en/repos","events_url":"https://api.github.com/users/tonya11en/events{/privacy}","received_events_url":"https://api.github.com/users/tonya11en/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonya11en/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":true,"url":"https://api.github.com/repos/tonya11en/rook","forks_url":"https://api.github.com/repos/tonya11en/rook/forks","keys_url":"https://api.github.com/repos/tonya11en/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonya11en/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonya11en/rook/teams","hooks_url":"https://api.github.com/repos/tonya11en/rook/hooks","issue_events_url":"https://api.github.com/repos/tonya11en/rook/issues/events{/number}","events_url":"https://api.github.com/repos/tonya11en/rook/events","assignees_url":"https://api.github.com/repos/tonya11en/rook/assignees{/user}","branches_url":"https://api.github.com/repos/tonya11en/rook/branches{/branch}","tags_url":"https://api.github.com/repos/tonya11en/rook/tags","blobs_url":"https://api.github.com/repos/tonya11en/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonya11en/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonya11en/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonya11en/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonya11en/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/tonya11en/rook/languages","stargazers_url":"https://api.github.com/repos/tonya11en/rook/stargazers","contributors_url":"https://api.github.com/repos/tonya11en/rook/contributors","subscribers_url":"https://api.github.com/repos/tonya11en/rook/subscribers","subscription_url":"https://api.github.com/repos/tonya11en/rook/subscription","commits_url":"https://api.github.com/repos/tonya11en/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonya11en/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonya11en/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonya11en/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonya11en/rook/contents/{+path}","compare_url":"https://api.github.com/repos/tonya11en/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonya11en/rook/merges","archive_url":"https://api.github.com/repos/tonya11en/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonya11en/rook/downloads","issues_url":"https://api.github.com/repos/tonya11en/rook/issues{/number}","pulls_url":"https://api.github.com/repos/tonya11en/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/tonya11en/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/tonya11en/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonya11en/rook/labels{/name}","releases_url":"https://api.github.com/repos/tonya11en/rook/releases{/id}","deployments_url":"https://api.github.com/repos/tonya11en/rook/deployments","created_at":"2018-04-09T04:34:24Z","updated_at":"2018-05-29T16:48:26Z","pushed_at":"2018-06-04T22:35:01Z","git_url":"git://github.com/tonya11en/rook.git","ssh_url":"git@github.com:tonya11en/rook.git","clone_url":"https://github.com/tonya11en/rook.git","svn_url":"https://github.com/tonya11en/rook","homepage":"https://rook.io","size":5506,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"30608137aae210bf5f252317988ff5f486988d25","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rook/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2018-06-05T00:47:38Z","pushed_at":"2018-06-05T00:47:34Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":5164,"stargazers_count":2884,"watchers_count":2884,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":320,"mirror_url":null,"archived":false,"open_issues_count":212,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":320,"open_issues":212,"watchers":2884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/1756"},"html":{"href":"https://github.com/rook/rook/pull/1756"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/1756"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/1756/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/1756/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/1756/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/a4dd9347372fbb67aca3c5e571e3dff5c0836ad8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jbw976"}}