{"action":"opened","number":1726,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1726","id":204886778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODg2Nzc4","html_url":"https://github.com/puppetlabs/facter/pull/1726","diff_url":"https://github.com/puppetlabs/facter/pull/1726.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1726.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1726","number":1726,"state":"open","locked":false,"title":"(FACT-1550) Get os.architecture from processors.models[0] on AIX","user":{"login":"ekinanp","id":29735501,"node_id":"MDQ6VXNlcjI5NzM1NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/29735501?v=4","gravatar_id":"","url":"https://api.github.com/users/ekinanp","html_url":"https://github.com/ekinanp","followers_url":"https://api.github.com/users/ekinanp/followers","following_url":"https://api.github.com/users/ekinanp/following{/other_user}","gists_url":"https://api.github.com/users/ekinanp/gists{/gist_id}","starred_url":"https://api.github.com/users/ekinanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekinanp/subscriptions","organizations_url":"https://api.github.com/users/ekinanp/orgs","repos_url":"https://api.github.com/users/ekinanp/repos","events_url":"https://api.github.com/users/ekinanp/events{/privacy}","received_events_url":"https://api.github.com/users/ekinanp/received_events","type":"User","site_admin":false},"body":"On AIX, we can dynamically add and remove resources from the LPAR.\r\nThis includes removing proc0, which is what we originally checked\r\nto obtain the OS architecture. In this case, we will report an\r\nempty value for the OS architecture, which is incorrect.\r\n\r\nThis commit uses the processors.model[0] fact to obtain the\r\narchitecture instead, where the processors fact directly queries the\r\nODM for all of the available processors on the system and thus is not\r\naffected by any LPAR configuration.\r\n\r\nWe also clean up the code here a bit by using our internal ODM APIs\r\ninstead of shelling out to lsattr and parsing its output to get the\r\nhardware info. It is better to use our internal ODM APIs instead to\r\nkeep things consistent with our other AIX fact resolvers and to\r\navoid shelling out when we don't need to. The resulting code's\r\nalso a lot cleaner.","created_at":"2018-07-30T18:14:08Z","updated_at":"2018-07-30T18:14:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1726/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1726/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1726/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/36deccc3f53f411b18f5b4a7a815b1cda59dc1c9","head":{"label":"ekinanp:FACT-1550","ref":"FACT-1550","sha":"36deccc3f53f411b18f5b4a7a815b1cda59dc1c9","user":{"login":"ekinanp","id":29735501,"node_id":"MDQ6VXNlcjI5NzM1NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/29735501?v=4","gravatar_id":"","url":"https://api.github.com/users/ekinanp","html_url":"https://github.com/ekinanp","followers_url":"https://api.github.com/users/ekinanp/followers","following_url":"https://api.github.com/users/ekinanp/following{/other_user}","gists_url":"https://api.github.com/users/ekinanp/gists{/gist_id}","starred_url":"https://api.github.com/users/ekinanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekinanp/subscriptions","organizations_url":"https://api.github.com/users/ekinanp/orgs","repos_url":"https://api.github.com/users/ekinanp/repos","events_url":"https://api.github.com/users/ekinanp/events{/privacy}","received_events_url":"https://api.github.com/users/ekinanp/received_events","type":"User","site_admin":false},"repo":{"id":108305866,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzMDU4NjY=","name":"facter","full_name":"ekinanp/facter","owner":{"login":"ekinanp","id":29735501,"node_id":"MDQ6VXNlcjI5NzM1NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/29735501?v=4","gravatar_id":"","url":"https://api.github.com/users/ekinanp","html_url":"https://github.com/ekinanp","followers_url":"https://api.github.com/users/ekinanp/followers","following_url":"https://api.github.com/users/ekinanp/following{/other_user}","gists_url":"https://api.github.com/users/ekinanp/gists{/gist_id}","starred_url":"https://api.github.com/users/ekinanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekinanp/subscriptions","organizations_url":"https://api.github.com/users/ekinanp/orgs","repos_url":"https://api.github.com/users/ekinanp/repos","events_url":"https://api.github.com/users/ekinanp/events{/privacy}","received_events_url":"https://api.github.com/users/ekinanp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekinanp/facter","description":"Collect and display system facts","fork":true,"url":"https://api.github.com/repos/ekinanp/facter","forks_url":"https://api.github.com/repos/ekinanp/facter/forks","keys_url":"https://api.github.com/repos/ekinanp/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekinanp/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekinanp/facter/teams","hooks_url":"https://api.github.com/repos/ekinanp/facter/hooks","issue_events_url":"https://api.github.com/repos/ekinanp/facter/issues/events{/number}","events_url":"https://api.github.com/repos/ekinanp/facter/events","assignees_url":"https://api.github.com/repos/ekinanp/facter/assignees{/user}","branches_url":"https://api.github.com/repos/ekinanp/facter/branches{/branch}","tags_url":"https://api.github.com/repos/ekinanp/facter/tags","blobs_url":"https://api.github.com/repos/ekinanp/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekinanp/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekinanp/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekinanp/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekinanp/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/ekinanp/facter/languages","stargazers_url":"https://api.github.com/repos/ekinanp/facter/stargazers","contributors_url":"https://api.github.com/repos/ekinanp/facter/contributors","subscribers_url":"https://api.github.com/repos/ekinanp/facter/subscribers","subscription_url":"https://api.github.com/repos/ekinanp/facter/subscription","commits_url":"https://api.github.com/repos/ekinanp/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekinanp/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekinanp/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekinanp/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekinanp/facter/contents/{+path}","compare_url":"https://api.github.com/repos/ekinanp/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekinanp/facter/merges","archive_url":"https://api.github.com/repos/ekinanp/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekinanp/facter/downloads","issues_url":"https://api.github.com/repos/ekinanp/facter/issues{/number}","pulls_url":"https://api.github.com/repos/ekinanp/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/ekinanp/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/ekinanp/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekinanp/facter/labels{/name}","releases_url":"https://api.github.com/repos/ekinanp/facter/releases{/id}","deployments_url":"https://api.github.com/repos/ekinanp/facter/deployments","created_at":"2017-10-25T17:57:44Z","updated_at":"2018-04-18T17:20:13Z","pushed_at":"2018-07-30T17:44:24Z","git_url":"git://github.com/ekinanp/facter.git","ssh_url":"git@github.com:ekinanp/facter.git","clone_url":"https://github.com/ekinanp/facter.git","svn_url":"https://github.com/ekinanp/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":13950,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"4b4c7146f7500d0b5113db7a1193ccf5a5f1d55d","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NTc=","name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/facter/deployments","created_at":"2010-09-14T19:31:04Z","updated_at":"2018-07-30T17:46:07Z","pushed_at":"2018-07-29T10:54:21Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":13946,"stargazers_count":509,"watchers_count":509,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":431,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":431,"open_issues":10,"watchers":509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1726"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1726"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1726"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1726/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1726/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1726/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/36deccc3f53f411b18f5b4a7a815b1cda59dc1c9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":26,"deletions":29,"changed_files":1}}
{"actor":{"display_login":"ekinanp"}}