{"action":"created","comment":{"url":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments/190351314","pull_request_review_id":122709027,"id":190351314,"diff_hunk":"@@ -51,29 +34,11 @@ function cleanLink(a) {\n   a.addEventListener(\"mouseover\", function (e) { e.stopPropagation(); }, true);","path":"src/js/firstparties/facebook.js","position":37,"original_position":37,"commit_id":"294eae9fc7d0b3adb532e825e1a527c716bce84b","original_commit_id":"294eae9fc7d0b3adb532e825e1a527c716bce84b","user":{"login":"bcyphers","id":4840035,"avatar_url":"https://avatars3.githubusercontent.com/u/4840035?v=4","gravatar_id":"","url":"https://api.github.com/users/bcyphers","html_url":"https://github.com/bcyphers","followers_url":"https://api.github.com/users/bcyphers/followers","following_url":"https://api.github.com/users/bcyphers/following{/other_user}","gists_url":"https://api.github.com/users/bcyphers/gists{/gist_id}","starred_url":"https://api.github.com/users/bcyphers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcyphers/subscriptions","organizations_url":"https://api.github.com/users/bcyphers/orgs","repos_url":"https://api.github.com/users/bcyphers/repos","events_url":"https://api.github.com/users/bcyphers/events{/privacy}","received_events_url":"https://api.github.com/users/bcyphers/received_events","type":"User","site_admin":false},"body":"Yes, definitely.","created_at":"2018-05-23T18:21:05Z","updated_at":"2018-05-23T18:21:05Z","html_url":"https://github.com/EFForg/privacybadger/pull/2016#discussion_r190351314","pull_request_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments/190351314"},"html":{"href":"https://github.com/EFForg/privacybadger/pull/2016#discussion_r190351314"},"pull_request":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016"}},"in_reply_to_id":189685006},"pull_request":{"url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016","id":187550600,"html_url":"https://github.com/EFForg/privacybadger/pull/2016","diff_url":"https://github.com/EFForg/privacybadger/pull/2016.diff","patch_url":"https://github.com/EFForg/privacybadger/pull/2016.patch","issue_url":"https://api.github.com/repos/EFForg/privacybadger/issues/2016","number":2016,"state":"open","locked":false,"title":"Add basic link-tracking protections to Google sites","user":{"login":"bcyphers","id":4840035,"avatar_url":"https://avatars3.githubusercontent.com/u/4840035?v=4","gravatar_id":"","url":"https://api.github.com/users/bcyphers","html_url":"https://github.com/bcyphers","followers_url":"https://api.github.com/users/bcyphers/followers","following_url":"https://api.github.com/users/bcyphers/following{/other_user}","gists_url":"https://api.github.com/users/bcyphers/gists{/gist_id}","starred_url":"https://api.github.com/users/bcyphers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcyphers/subscriptions","organizations_url":"https://api.github.com/users/bcyphers/orgs","repos_url":"https://api.github.com/users/bcyphers/repos","events_url":"https://api.github.com/users/bcyphers/events{/privacy}","received_events_url":"https://api.github.com/users/bcyphers/received_events","type":"User","site_admin":false},"body":"This pull request will add basic anti-link-tracking measures for Google searches (www.google.com) as well as to links pasted into Google Hangouts (hangouts.google.com).\r\n\r\nThe search script removes `click` and `mousedown` event listeners from vanilla search links on www.google.com. It doesn't apply to localized domains, or to any google sites other than web search. For some reason, link tracking happens differently in Firefox and Chrome. In Firefox, there is an event listener for `mousedown` that sneaks in and replaces the actual url with a `www.google.com/url?` redirect link. In Chrome, Google uses the new HTML5 [`ping` attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#Attributes), which I just learned about. As an aside, it might be worth blocking this attribute everywhere -- I can't think of a valid non-tracking use case.\r\n\r\nThe hangouts script is simpler because the tracking mechanism is simpler. It uses `setInterval` to rewrite all `href`s that start with `google.com/url?` in hangouts.google.com iframes.\r\n\r\nI also used this as an opportunity to abstract out the common functions that we use for link unwrapping into a `lib/` file, to DRY out the code and make it easier to add anti-link-tracking scripts for other sites in the future.\r\n\r\nFollows up on #1993 and #1392.","created_at":"2018-05-11T19:31:24Z","updated_at":"2018-05-23T18:21:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"948cf511624294e6b6b17eecb647635604cbd02e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016/commits","review_comments_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016/comments","review_comment_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EFForg/privacybadger/issues/2016/comments","statuses_url":"https://api.github.com/repos/EFForg/privacybadger/statuses/294eae9fc7d0b3adb532e825e1a527c716bce84b","head":{"label":"EFForg:google.com-link-unwrapping","ref":"google.com-link-unwrapping","sha":"294eae9fc7d0b3adb532e825e1a527c716bce84b","user":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":11321096,"name":"privacybadger","full_name":"EFForg/privacybadger","owner":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/privacybadger","description":"Privacy Badger - Block third party tracking in your browser! By EFF","fork":false,"url":"https://api.github.com/repos/EFForg/privacybadger","forks_url":"https://api.github.com/repos/EFForg/privacybadger/forks","keys_url":"https://api.github.com/repos/EFForg/privacybadger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/privacybadger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/privacybadger/teams","hooks_url":"https://api.github.com/repos/EFForg/privacybadger/hooks","issue_events_url":"https://api.github.com/repos/EFForg/privacybadger/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/privacybadger/events","assignees_url":"https://api.github.com/repos/EFForg/privacybadger/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/privacybadger/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/privacybadger/tags","blobs_url":"https://api.github.com/repos/EFForg/privacybadger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/privacybadger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/privacybadger/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/privacybadger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/privacybadger/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/privacybadger/languages","stargazers_url":"https://api.github.com/repos/EFForg/privacybadger/stargazers","contributors_url":"https://api.github.com/repos/EFForg/privacybadger/contributors","subscribers_url":"https://api.github.com/repos/EFForg/privacybadger/subscribers","subscription_url":"https://api.github.com/repos/EFForg/privacybadger/subscription","commits_url":"https://api.github.com/repos/EFForg/privacybadger/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/privacybadger/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/privacybadger/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/privacybadger/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/privacybadger/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/privacybadger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/privacybadger/merges","archive_url":"https://api.github.com/repos/EFForg/privacybadger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/privacybadger/downloads","issues_url":"https://api.github.com/repos/EFForg/privacybadger/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/privacybadger/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/privacybadger/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/privacybadger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/privacybadger/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/privacybadger/releases{/id}","deployments_url":"https://api.github.com/repos/EFForg/privacybadger/deployments","created_at":"2013-07-10T18:59:11Z","updated_at":"2018-05-23T15:44:50Z","pushed_at":"2018-05-23T15:25:39Z","git_url":"git://github.com/EFForg/privacybadger.git","ssh_url":"git@github.com:EFForg/privacybadger.git","clone_url":"https://github.com/EFForg/privacybadger.git","svn_url":"https://github.com/EFForg/privacybadger","homepage":"https://www.eff.org/privacybadger","size":24053,"stargazers_count":1096,"watchers_count":1096,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":298,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":212,"open_issues":298,"watchers":1096,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"7aa109e224a42c180b65aaffe2e351013a6cfd38","user":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":11321096,"name":"privacybadger","full_name":"EFForg/privacybadger","owner":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/privacybadger","description":"Privacy Badger - Block third party tracking in your browser! By EFF","fork":false,"url":"https://api.github.com/repos/EFForg/privacybadger","forks_url":"https://api.github.com/repos/EFForg/privacybadger/forks","keys_url":"https://api.github.com/repos/EFForg/privacybadger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/privacybadger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/privacybadger/teams","hooks_url":"https://api.github.com/repos/EFForg/privacybadger/hooks","issue_events_url":"https://api.github.com/repos/EFForg/privacybadger/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/privacybadger/events","assignees_url":"https://api.github.com/repos/EFForg/privacybadger/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/privacybadger/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/privacybadger/tags","blobs_url":"https://api.github.com/repos/EFForg/privacybadger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/privacybadger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/privacybadger/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/privacybadger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/privacybadger/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/privacybadger/languages","stargazers_url":"https://api.github.com/repos/EFForg/privacybadger/stargazers","contributors_url":"https://api.github.com/repos/EFForg/privacybadger/contributors","subscribers_url":"https://api.github.com/repos/EFForg/privacybadger/subscribers","subscription_url":"https://api.github.com/repos/EFForg/privacybadger/subscription","commits_url":"https://api.github.com/repos/EFForg/privacybadger/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/privacybadger/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/privacybadger/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/privacybadger/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/privacybadger/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/privacybadger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/privacybadger/merges","archive_url":"https://api.github.com/repos/EFForg/privacybadger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/privacybadger/downloads","issues_url":"https://api.github.com/repos/EFForg/privacybadger/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/privacybadger/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/privacybadger/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/privacybadger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/privacybadger/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/privacybadger/releases{/id}","deployments_url":"https://api.github.com/repos/EFForg/privacybadger/deployments","created_at":"2013-07-10T18:59:11Z","updated_at":"2018-05-23T15:44:50Z","pushed_at":"2018-05-23T15:25:39Z","git_url":"git://github.com/EFForg/privacybadger.git","ssh_url":"git@github.com:EFForg/privacybadger.git","clone_url":"https://github.com/EFForg/privacybadger.git","svn_url":"https://github.com/EFForg/privacybadger","homepage":"https://www.eff.org/privacybadger","size":24053,"stargazers_count":1096,"watchers_count":1096,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":298,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":212,"open_issues":298,"watchers":1096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016"},"html":{"href":"https://github.com/EFForg/privacybadger/pull/2016"},"issue":{"href":"https://api.github.com/repos/EFForg/privacybadger/issues/2016"},"comments":{"href":"https://api.github.com/repos/EFForg/privacybadger/issues/2016/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2016/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/privacybadger/statuses/294eae9fc7d0b3adb532e825e1a527c716bce84b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bcyphers"}}