{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/charts/issues/3013","repository_url":"https://api.github.com/repos/kubernetes/charts","labels_url":"https://api.github.com/repos/kubernetes/charts/issues/3013/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/3013/comments","events_url":"https://api.github.com/repos/kubernetes/charts/issues/3013/events","html_url":"https://github.com/kubernetes/charts/pull/3013","id":281516413,"number":3013,"title":"Add nginx-ldapauth-proxy","user":{"login":"rendhalver","id":1026337,"avatar_url":"https://avatars1.githubusercontent.com/u/1026337?v=4","gravatar_id":"","url":"https://api.github.com/users/rendhalver","html_url":"https://github.com/rendhalver","followers_url":"https://api.github.com/users/rendhalver/followers","following_url":"https://api.github.com/users/rendhalver/following{/other_user}","gists_url":"https://api.github.com/users/rendhalver/gists{/gist_id}","starred_url":"https://api.github.com/users/rendhalver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rendhalver/subscriptions","organizations_url":"https://api.github.com/users/rendhalver/orgs","repos_url":"https://api.github.com/users/rendhalver/repos","events_url":"https://api.github.com/users/rendhalver/events{/privacy}","received_events_url":"https://api.github.com/users/rendhalver/received_events","type":"User","site_admin":false},"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676596499,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-12-12T19:54:25Z","updated_at":"2018-03-02T18:52:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/3013","html_url":"https://github.com/kubernetes/charts/pull/3013","diff_url":"https://github.com/kubernetes/charts/pull/3013.diff","patch_url":"https://github.com/kubernetes/charts/pull/3013.patch"},"body":"We created this as an authentication layer on top of our ELK stack.\r\nWe thought it might be useful for other people as well.\r\n\r\n*****************************************************************************************\r\n\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the \r\nhistory. This will make it easier to identify new changes. The PR will be squashed \r\nanyways when it is merged. Thanks.\r\n\r\n*****************************************************************************************\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/charts/issues/comments/370017260","html_url":"https://github.com/kubernetes/charts/pull/3013#issuecomment-370017260","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/3013","id":370017260,"user":{"login":"rendhalver","id":1026337,"avatar_url":"https://avatars1.githubusercontent.com/u/1026337?v=4","gravatar_id":"","url":"https://api.github.com/users/rendhalver","html_url":"https://github.com/rendhalver","followers_url":"https://api.github.com/users/rendhalver/followers","following_url":"https://api.github.com/users/rendhalver/following{/other_user}","gists_url":"https://api.github.com/users/rendhalver/gists{/gist_id}","starred_url":"https://api.github.com/users/rendhalver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rendhalver/subscriptions","organizations_url":"https://api.github.com/users/rendhalver/orgs","repos_url":"https://api.github.com/users/rendhalver/repos","events_url":"https://api.github.com/users/rendhalver/events{/privacy}","received_events_url":"https://api.github.com/users/rendhalver/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T18:52:44Z","updated_at":"2018-03-02T18:52:44Z","author_association":"CONTRIBUTOR","body":"This is failing because there is no service for it to connect to.\r\nThis is the error the pod gives me when I run it locally.\r\n```\r\n13:44 $ kubectl --context=docker-for-desktop --namespace=testing logs nginx-proxy-nginx-ldapauth-proxy-84cd45586d-b24g7\r\n2018/03/02 18:45:12 [emerg] 1#1: host not found in upstream \"backend-service.default.svc.cluster.local:8080\" in /etc/nginx/nginx.conf:11\r\nnginx: [emerg] host not found in upstream \"backend-service.default.svc.cluster.local:8080\" in /etc/nginx/nginx.conf:11\r\n```\r\nI guess I could cheat and connect it to a service that always exists but I am not sure what that would be maybe the kubernetes service?\r\n\r\nI can verify that this does work as-is once you point it to a valid service and give it LDAP credentials.\r\nWe are using it for all of our elastic-stack clusters and it works well."}}
{"actor":{"display_login":"rendhalver"}}