{"action":"closed","issue":{"url":"https://api.github.com/repos/gdi2290/angular-starter/issues/2005","repository_url":"https://api.github.com/repos/gdi2290/angular-starter","labels_url":"https://api.github.com/repos/gdi2290/angular-starter/issues/2005/labels{/name}","comments_url":"https://api.github.com/repos/gdi2290/angular-starter/issues/2005/comments","events_url":"https://api.github.com/repos/gdi2290/angular-starter/issues/2005/events","html_url":"https://github.com/gdi2290/angular-starter/issues/2005","id":316628209,"node_id":"MDU6SXNzdWUzMTY2MjgyMDk=","number":2005,"title":"webpack4 issues","user":{"login":"JoelParke","id":12278498,"node_id":"MDQ6VXNlcjEyMjc4NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/12278498?v=4","gravatar_id":"","url":"https://api.github.com/users/JoelParke","html_url":"https://github.com/JoelParke","followers_url":"https://api.github.com/users/JoelParke/followers","following_url":"https://api.github.com/users/JoelParke/following{/other_user}","gists_url":"https://api.github.com/users/JoelParke/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelParke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelParke/subscriptions","organizations_url":"https://api.github.com/users/JoelParke/orgs","repos_url":"https://api.github.com/users/JoelParke/repos","events_url":"https://api.github.com/users/JoelParke/events{/privacy}","received_events_url":"https://api.github.com/users/JoelParke/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-23T00:38:38Z","updated_at":"2018-07-09T20:47:18Z","closed_at":"2018-07-09T20:47:17Z","author_association":"NONE","body":"**Note: for support questions, please use one of these channels:** [Chat: AngularClass.slack](http://angularclass.com/member-join/) or [Twitter: @TipeIO](https://twitter.com/TipeIO)\r\n\r\n* **What is the current behavior?**\r\nthe webpack4 branch can be made to build, when I shift to MiniCssExtractPlugin() from ExtractTextPlugin().  This works fairly well. \r\nBasically: \r\nI added:\r\n\r\n       const MiniCssExtractPlugin = require('mini-css-extract-plugin');\r\n       /**\r\n         * Extract CSS files from .src/styles directory to external CSS file\r\n         */\r\n        {\r\n          test: /\\.css$/,\r\n          use: [MiniCssExtractPlugin.loader, 'css-loader'],\r\n          include: [helpers.root('src', 'styles')]\r\n        },\r\n\r\n        /**\r\n         * Extract and compile SCSS files from .src/styles directory to external CSS file\r\n         */\r\n        {\r\n          test: /\\.scss$/,\r\n          use: [MiniCssExtractPlugin.loader, 'css-loader', 'sass-loader'],\r\n          include: [helpers.root('src', 'styles')]\r\n        },\r\n\r\nAnd I replaced new ExtractTextPlugin(....) with:\r\n\r\n      new MiniCssExtractPlugin({\r\n                   filename: '[name]-[hash].css',\r\n              chunkFilename: '[name]-[chunkhash].css'}),\r\n\r\nI also updated all the packages to the latest versions - on 4-22.\r\n\r\nI have a large project built around angular-starter, which works great with webpack 3.  But with webpack4, even with the changes above, I get killed late in the build \r\n\r\n     `WARNING in ./node_modules/@angular/core/esm5/core.js\r\n     System.import() is deprecated and will be removed soon. Use import() instead.\r\n     For more info visit https://webpack.js.org/guides/code-splitting/\r\n      @ ./src/environments/environment.ts 6570:15-36 2:0-47 4:0-14\r\n      @ ./src/main.browser.ts\r\n\r\n     WARNING in ./node_modules/@angular/core/esm5/core.js\r\n     System.import() is deprecated and will be removed soon. Use import() instead.\r\n     For more info visit https://webpack.js.org/guides/code-splitting/\r\n     @ ./src/environments/environment.ts 6590:15-102 2:0-47 4:0-14\r\n     @ ./src/main.browser.ts\r\n\r\n     ERROR in ./node_modules/font-awesome-webpack/font-awesome.config.js (./node_modules/font-awesome-webpack/node_modules/css-loader!./node_modules/font-awesome-webpack/node_modules/less-loader!./node_modules/font-awesome-webpack/font-awesome-styles.loader.js!./node_modules/font-awesome-webpack/font-awesome.config.js)\r\n     Module build failed: TypeError: Cannot read property 'lessLoader' of undefined\r\n    at Object.module.exports (/home/joel/workspace/Tracker3/node_modules/font-awesome-webpack/node_modules/less-loader/index.js:50:18)\r\n      @ ./node_modules/font-awesome-webpack/node_modules/style-loader!./node_modules/font-awesome-webpack/node_modules/css-loader!./node_modules/font-awesome-webpack/node_modules/less-loader!./node_modules/font-awesome-webpack/font-awesome-styles.loader.js!./node_modules/font-awesome-webpack/font-awesome.config.js 4:14-154\r\n      @ ./node_modules/font-awesome-webpack/index.js\r\n      @ ./src/app/app.module.ts\r\n      @ ./src/app/index.ts\r\n      @ ./src/main.browser.ts\r\n     Child html-webpack-plugin for \"index.html\":\r\n     1 asset\r\n    Entrypoint undefined = index.html\r\n    [MFLM] ./node_modules/html-webpack-plugin/lib/loader.js!./src/index.html 2.08 KiB {0} [built]\r\n        factory:4095ms building:18ms = 4113ms\r\n    [YuTi] (webpack)/buildin/module.js 497 bytes {0} [built]\r\n        [MFLM] 4113ms -> [LvDl] 169ms -> factory:9ms building:5ms = 4296ms\r\n    [yLpj] (webpack)/buildin/global.js 489 bytes {0} [built]\r\n        [MFLM] 4113ms -> [LvDl] 169ms -> factory:9ms building:5ms = 4296ms\r\n        + 1 hidden module\r\n`\r\nSO it seems that font-awesome is killing the build for webpack 4.  Any thoughts as to why this might be, would be very helpful.  I would like to experiment with some strategies to split chunks, but until I can get it running in production, it seems somewhat pointless.\r\n\r\n* **Please tell us about your environment:**\r\n - Ubuntu, latest node, npm, etc.   Intellij ide, Angular 5.2.x, Chrome\r\n"}}
{"actor":{"display_login":"lanovoy"}}