{"action":"created","comment":{"url":"https://api.github.com/repos/bitwarden/desktop/pulls/comments/171027875","pull_request_review_id":99809300,"id":171027875,"diff_hunk":"@@ -223,7 +223,6 @@\n     \"electron-updater\": \"2.20.1\",\n     \"keytar\": \"4.1.0\",\n     \"node-forge\": \"0.7.1\",\n-    \"os-locale\": \"2.1.0\",","path":"package.json","position":4,"original_position":4,"commit_id":"75a5ccc564725bee5471117634ed03196da4f3ed","original_commit_id":"75a5ccc564725bee5471117634ed03196da4f3ed","user":{"login":"kspearrin","id":1190944,"avatar_url":"https://avatars3.githubusercontent.com/u/1190944?v=4","gravatar_id":"","url":"https://api.github.com/users/kspearrin","html_url":"https://github.com/kspearrin","followers_url":"https://api.github.com/users/kspearrin/followers","following_url":"https://api.github.com/users/kspearrin/following{/other_user}","gists_url":"https://api.github.com/users/kspearrin/gists{/gist_id}","starred_url":"https://api.github.com/users/kspearrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kspearrin/subscriptions","organizations_url":"https://api.github.com/users/kspearrin/orgs","repos_url":"https://api.github.com/users/kspearrin/repos","events_url":"https://api.github.com/users/kspearrin/events{/privacy}","received_events_url":"https://api.github.com/users/kspearrin/received_events","type":"User","site_admin":false},"body":"There's another package.json in src that needs this removed from as well.","created_at":"2018-02-27T18:52:51Z","updated_at":"2018-02-27T18:53:01Z","html_url":"https://github.com/bitwarden/desktop/pull/46#discussion_r171027875","pull_request_url":"https://api.github.com/repos/bitwarden/desktop/pulls/46","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bitwarden/desktop/pulls/comments/171027875"},"html":{"href":"https://github.com/bitwarden/desktop/pull/46#discussion_r171027875"},"pull_request":{"href":"https://api.github.com/repos/bitwarden/desktop/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/bitwarden/desktop/pulls/46","id":171751289,"html_url":"https://github.com/bitwarden/desktop/pull/46","diff_url":"https://github.com/bitwarden/desktop/pull/46.diff","patch_url":"https://github.com/bitwarden/desktop/pull/46.patch","issue_url":"https://api.github.com/repos/bitwarden/desktop/issues/46","number":46,"state":"open","locked":false,"title":"Replace os-locale with native electron api, app.getLocale","user":{"login":"Hinton","id":137855,"avatar_url":"https://avatars1.githubusercontent.com/u/137855?v=4","gravatar_id":"","url":"https://api.github.com/users/Hinton","html_url":"https://github.com/Hinton","followers_url":"https://api.github.com/users/Hinton/followers","following_url":"https://api.github.com/users/Hinton/following{/other_user}","gists_url":"https://api.github.com/users/Hinton/gists{/gist_id}","starred_url":"https://api.github.com/users/Hinton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hinton/subscriptions","organizations_url":"https://api.github.com/users/Hinton/orgs","repos_url":"https://api.github.com/users/Hinton/repos","events_url":"https://api.github.com/users/Hinton/events{/privacy}","received_events_url":"https://api.github.com/users/Hinton/received_events","type":"User","site_admin":false},"body":"The native electron API seems to grab a more *correct* locale than the `os-locale` package on my machine.","created_at":"2018-02-27T18:48:54Z","updated_at":"2018-02-27T18:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c94275a19535c0a0d9993c5f21bfcf8494b1ac7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitwarden/desktop/pulls/46/commits","review_comments_url":"https://api.github.com/repos/bitwarden/desktop/pulls/46/comments","review_comment_url":"https://api.github.com/repos/bitwarden/desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitwarden/desktop/issues/46/comments","statuses_url":"https://api.github.com/repos/bitwarden/desktop/statuses/75a5ccc564725bee5471117634ed03196da4f3ed","head":{"label":"Hinton:feature/electron-get-locale","ref":"feature/electron-get-locale","sha":"75a5ccc564725bee5471117634ed03196da4f3ed","user":{"login":"Hinton","id":137855,"avatar_url":"https://avatars1.githubusercontent.com/u/137855?v=4","gravatar_id":"","url":"https://api.github.com/users/Hinton","html_url":"https://github.com/Hinton","followers_url":"https://api.github.com/users/Hinton/followers","following_url":"https://api.github.com/users/Hinton/following{/other_user}","gists_url":"https://api.github.com/users/Hinton/gists{/gist_id}","starred_url":"https://api.github.com/users/Hinton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hinton/subscriptions","organizations_url":"https://api.github.com/users/Hinton/orgs","repos_url":"https://api.github.com/users/Hinton/repos","events_url":"https://api.github.com/users/Hinton/events{/privacy}","received_events_url":"https://api.github.com/users/Hinton/received_events","type":"User","site_admin":false},"repo":{"id":123172959,"name":"desktop","full_name":"Hinton/desktop","owner":{"login":"Hinton","id":137855,"avatar_url":"https://avatars1.githubusercontent.com/u/137855?v=4","gravatar_id":"","url":"https://api.github.com/users/Hinton","html_url":"https://github.com/Hinton","followers_url":"https://api.github.com/users/Hinton/followers","following_url":"https://api.github.com/users/Hinton/following{/other_user}","gists_url":"https://api.github.com/users/Hinton/gists{/gist_id}","starred_url":"https://api.github.com/users/Hinton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hinton/subscriptions","organizations_url":"https://api.github.com/users/Hinton/orgs","repos_url":"https://api.github.com/users/Hinton/repos","events_url":"https://api.github.com/users/Hinton/events{/privacy}","received_events_url":"https://api.github.com/users/Hinton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hinton/desktop","description":"The desktop vault (Windows, macOS, and Linux).","fork":true,"url":"https://api.github.com/repos/Hinton/desktop","forks_url":"https://api.github.com/repos/Hinton/desktop/forks","keys_url":"https://api.github.com/repos/Hinton/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hinton/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hinton/desktop/teams","hooks_url":"https://api.github.com/repos/Hinton/desktop/hooks","issue_events_url":"https://api.github.com/repos/Hinton/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/Hinton/desktop/events","assignees_url":"https://api.github.com/repos/Hinton/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/Hinton/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/Hinton/desktop/tags","blobs_url":"https://api.github.com/repos/Hinton/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hinton/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hinton/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hinton/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hinton/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/Hinton/desktop/languages","stargazers_url":"https://api.github.com/repos/Hinton/desktop/stargazers","contributors_url":"https://api.github.com/repos/Hinton/desktop/contributors","subscribers_url":"https://api.github.com/repos/Hinton/desktop/subscribers","subscription_url":"https://api.github.com/repos/Hinton/desktop/subscription","commits_url":"https://api.github.com/repos/Hinton/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hinton/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hinton/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hinton/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hinton/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/Hinton/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hinton/desktop/merges","archive_url":"https://api.github.com/repos/Hinton/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hinton/desktop/downloads","issues_url":"https://api.github.com/repos/Hinton/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/Hinton/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/Hinton/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/Hinton/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hinton/desktop/labels{/name}","releases_url":"https://api.github.com/repos/Hinton/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/Hinton/desktop/deployments","created_at":"2018-02-27T18:47:49Z","updated_at":"2018-02-27T18:47:51Z","pushed_at":"2018-02-27T18:48:36Z","git_url":"git://github.com/Hinton/desktop.git","ssh_url":"git@github.com:Hinton/desktop.git","clone_url":"https://github.com/Hinton/desktop.git","svn_url":"https://github.com/Hinton/desktop","homepage":"https://bitwarden.com","size":3389,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitwarden:master","ref":"master","sha":"2d58acc86d8a7d87f13fcb4acb4486c9295b3ff0","user":{"login":"bitwarden","id":15990069,"avatar_url":"https://avatars0.githubusercontent.com/u/15990069?v=4","gravatar_id":"","url":"https://api.github.com/users/bitwarden","html_url":"https://github.com/bitwarden","followers_url":"https://api.github.com/users/bitwarden/followers","following_url":"https://api.github.com/users/bitwarden/following{/other_user}","gists_url":"https://api.github.com/users/bitwarden/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwarden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwarden/subscriptions","organizations_url":"https://api.github.com/users/bitwarden/orgs","repos_url":"https://api.github.com/users/bitwarden/repos","events_url":"https://api.github.com/users/bitwarden/events{/privacy}","received_events_url":"https://api.github.com/users/bitwarden/received_events","type":"Organization","site_admin":false},"repo":{"id":76930145,"name":"desktop","full_name":"bitwarden/desktop","owner":{"login":"bitwarden","id":15990069,"avatar_url":"https://avatars0.githubusercontent.com/u/15990069?v=4","gravatar_id":"","url":"https://api.github.com/users/bitwarden","html_url":"https://github.com/bitwarden","followers_url":"https://api.github.com/users/bitwarden/followers","following_url":"https://api.github.com/users/bitwarden/following{/other_user}","gists_url":"https://api.github.com/users/bitwarden/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwarden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwarden/subscriptions","organizations_url":"https://api.github.com/users/bitwarden/orgs","repos_url":"https://api.github.com/users/bitwarden/repos","events_url":"https://api.github.com/users/bitwarden/events{/privacy}","received_events_url":"https://api.github.com/users/bitwarden/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitwarden/desktop","description":"The desktop vault (Windows, macOS, and Linux).","fork":false,"url":"https://api.github.com/repos/bitwarden/desktop","forks_url":"https://api.github.com/repos/bitwarden/desktop/forks","keys_url":"https://api.github.com/repos/bitwarden/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitwarden/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitwarden/desktop/teams","hooks_url":"https://api.github.com/repos/bitwarden/desktop/hooks","issue_events_url":"https://api.github.com/repos/bitwarden/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/bitwarden/desktop/events","assignees_url":"https://api.github.com/repos/bitwarden/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/bitwarden/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/bitwarden/desktop/tags","blobs_url":"https://api.github.com/repos/bitwarden/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitwarden/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitwarden/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitwarden/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitwarden/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/bitwarden/desktop/languages","stargazers_url":"https://api.github.com/repos/bitwarden/desktop/stargazers","contributors_url":"https://api.github.com/repos/bitwarden/desktop/contributors","subscribers_url":"https://api.github.com/repos/bitwarden/desktop/subscribers","subscription_url":"https://api.github.com/repos/bitwarden/desktop/subscription","commits_url":"https://api.github.com/repos/bitwarden/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitwarden/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitwarden/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitwarden/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitwarden/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/bitwarden/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitwarden/desktop/merges","archive_url":"https://api.github.com/repos/bitwarden/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitwarden/desktop/downloads","issues_url":"https://api.github.com/repos/bitwarden/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/bitwarden/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/bitwarden/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/bitwarden/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitwarden/desktop/labels{/name}","releases_url":"https://api.github.com/repos/bitwarden/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/bitwarden/desktop/deployments","created_at":"2016-12-20T06:34:26Z","updated_at":"2018-02-27T12:42:24Z","pushed_at":"2018-02-27T18:48:54Z","git_url":"git://github.com/bitwarden/desktop.git","ssh_url":"git@github.com:bitwarden/desktop.git","clone_url":"https://github.com/bitwarden/desktop.git","svn_url":"https://github.com/bitwarden/desktop","homepage":"https://bitwarden.com","size":3389,"stargazers_count":144,"watchers_count":144,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":9,"open_issues":14,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitwarden/desktop/pulls/46"},"html":{"href":"https://github.com/bitwarden/desktop/pull/46"},"issue":{"href":"https://api.github.com/repos/bitwarden/desktop/issues/46"},"comments":{"href":"https://api.github.com/repos/bitwarden/desktop/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/bitwarden/desktop/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/bitwarden/desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitwarden/desktop/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/bitwarden/desktop/statuses/75a5ccc564725bee5471117634ed03196da4f3ed"}},"author_association":"NONE"}}
{"actor":{"display_login":"kspearrin"}}