{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/182534084","pull_request_review_id":113348696,"id":182534084,"diff_hunk":"@@ -314,7 +314,19 @@ func LogIf(ctx context.Context, err error) {\n \tfmt.Println(output)\n }\n \n+// CriticalIf :\n+// Like LogIf with exit\n+// It'll be called for fatal error conditions during run-time\n+func CriticalIf(ctx context.Context, err error) {","path":"cmd/logger/logger.go","position":7,"original_position":7,"commit_id":"596f7e9892ce29103f4124866e9190039b0a4810","original_commit_id":"596f7e9892ce29103f4124866e9190039b0a4810","user":{"login":"kannappanr","id":30541348,"avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"body":"Can the `LogIf` be moved into the `if` section that way we do not check for err not being nil twice.\r\n```\r\nfunc CriticalIf(ctx context.Context, err error) {\r\n\t\r\n\tif err != nil {\r\n               LogIf(ctx, err)\r\n\t\tos.Exit(1)\r\n\t}\r\n}```","created_at":"2018-04-18T18:55:01Z","updated_at":"2018-04-18T18:55:02Z","html_url":"https://github.com/minio/minio/pull/5807#discussion_r182534084","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/5807","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/182534084"},"html":{"href":"https://github.com/minio/minio/pull/5807#discussion_r182534084"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/5807"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5807","id":180765005,"html_url":"https://github.com/minio/minio/pull/5807","diff_url":"https://github.com/minio/minio/pull/5807.diff","patch_url":"https://github.com/minio/minio/pull/5807.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/5807","number":5807,"state":"open","locked":false,"title":"Replaces panic() with logger.FatalIf()","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"body":"Panic() calls are replaced with logger.FatalIf() calls to adhere our new logging standard.\r\n\r\n## Motivation and Context\r\nFixes #5728 \r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-04-11T00:57:54Z","updated_at":"2018-04-18T18:55:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86a92e5834e032581d1e9dea38c50544f5cdd37f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/5807/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/5807/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/5807/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/596f7e9892ce29103f4124866e9190039b0a4810","head":{"label":"ebozduman:panic_call_cleanup","ref":"panic_call_cleanup","sha":"596f7e9892ce29103f4124866e9190039b0a4810","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"repo":{"id":95580938,"name":"minio","full_name":"ebozduman/minio","owner":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebozduman/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/ebozduman/minio","forks_url":"https://api.github.com/repos/ebozduman/minio/forks","keys_url":"https://api.github.com/repos/ebozduman/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebozduman/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebozduman/minio/teams","hooks_url":"https://api.github.com/repos/ebozduman/minio/hooks","issue_events_url":"https://api.github.com/repos/ebozduman/minio/issues/events{/number}","events_url":"https://api.github.com/repos/ebozduman/minio/events","assignees_url":"https://api.github.com/repos/ebozduman/minio/assignees{/user}","branches_url":"https://api.github.com/repos/ebozduman/minio/branches{/branch}","tags_url":"https://api.github.com/repos/ebozduman/minio/tags","blobs_url":"https://api.github.com/repos/ebozduman/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebozduman/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebozduman/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebozduman/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebozduman/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/ebozduman/minio/languages","stargazers_url":"https://api.github.com/repos/ebozduman/minio/stargazers","contributors_url":"https://api.github.com/repos/ebozduman/minio/contributors","subscribers_url":"https://api.github.com/repos/ebozduman/minio/subscribers","subscription_url":"https://api.github.com/repos/ebozduman/minio/subscription","commits_url":"https://api.github.com/repos/ebozduman/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebozduman/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebozduman/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebozduman/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebozduman/minio/contents/{+path}","compare_url":"https://api.github.com/repos/ebozduman/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebozduman/minio/merges","archive_url":"https://api.github.com/repos/ebozduman/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebozduman/minio/downloads","issues_url":"https://api.github.com/repos/ebozduman/minio/issues{/number}","pulls_url":"https://api.github.com/repos/ebozduman/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/ebozduman/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/ebozduman/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebozduman/minio/labels{/name}","releases_url":"https://api.github.com/repos/ebozduman/minio/releases{/id}","deployments_url":"https://api.github.com/repos/ebozduman/minio/deployments","created_at":"2017-06-27T16:52:52Z","updated_at":"2017-06-27T16:52:55Z","pushed_at":"2018-04-18T18:32:16Z","git_url":"git://github.com/ebozduman/minio.git","ssh_url":"git@github.com:ebozduman/minio.git","clone_url":"https://github.com/ebozduman/minio.git","svn_url":"https://github.com/ebozduman/minio","homepage":"https://minio.io","size":35058,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"9f31da5d5710a2d9f1210ffe46435b69ce2d1753","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-04-18T18:12:30Z","pushed_at":"2018-04-18T18:47:15Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":34871,"stargazers_count":11001,"watchers_count":11001,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":929,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":929,"open_issues":121,"watchers":11001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/5807"},"html":{"href":"https://github.com/minio/minio/pull/5807"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/5807"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/5807/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/5807/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/5807/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/596f7e9892ce29103f4124866e9190039b0a4810"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kannappanr"}}