{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/513","repository_url":"https://api.github.com/repos/kubernetes/kube-state-metrics","labels_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/513/comments","events_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/513/events","html_url":"https://github.com/kubernetes/kube-state-metrics/pull/513","id":350786616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTQ1NzU0","number":513,"title":"main_test.go: Introduce overarching benchmark test","user":{"login":"mxinden","id":7047859,"node_id":"MDQ6VXNlcjcwNDc4NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7047859?v=4","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"labels":[{"id":764086825,"node_id":"MDU6TGFiZWw3NjQwODY4MjU=","url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485759093,"node_id":"MDU6TGFiZWw0ODU3NTkwOTM=","url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":764094115,"node_id":"MDU6TGFiZWw3NjQwOTQxMTU=","url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":704084945,"node_id":"MDU6TGFiZWw3MDQwODQ5NDU=","url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"assignees":[{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-08-15T12:11:26Z","updated_at":"2018-08-20T07:51:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/513","html_url":"https://github.com/kubernetes/kube-state-metrics/pull/513","diff_url":"https://github.com/kubernetes/kube-state-metrics/pull/513.diff","patch_url":"https://github.com/kubernetes/kube-state-metrics/pull/513.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nThis patch adds a simple go benchmark test, injecting Kubernetes objects\r\nand simulating scrape requests. It uses the Kubernetes client-go fake\r\nclient. Alongside comes some refactoring of each collectors structure\r\nusing informer factories to be compatible with the fake client.\r\n\r\nThe patch lays the groundwork to make future performance optimizations\r\ncomparable with past versions.\r\n\r\nHow to run test:\r\n`go test -race -bench  . -memprofile=mem.out -cpuprofile=cpu.out`\r\n\r\nRelates to https://github.com/kubernetes/kube-state-metrics/issues/498"},"comment":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/comments/414228333","html_url":"https://github.com/kubernetes/kube-state-metrics/pull/513#issuecomment-414228333","issue_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/513","id":414228333,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDIyODMzMw==","user":{"login":"andyxning","id":2404712,"node_id":"MDQ6VXNlcjI0MDQ3MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T07:51:41Z","updated_at":"2018-08-20T07:51:41Z","author_association":"MEMBER","body":"Maybe we need to add a e2e_test Makefile target to add more detailed e2e test."}}
{"actor":{"display_login":"andyxning"}}