{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/216401978","pull_request_review_id":153874311,"id":216401978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQwMTk3OA==","diff_hunk":"@@ -1627,6 +1643,8 @@ Parser::LookAheadInfo Parser::peekStatementType() const\n \tif (mightBeTypeName)\n \t{\n \t\tToken::Value next = m_scanner->peekNextToken();\n+\t\tif (Token::isElementaryTypeName(token) && Token::isStateMutabilitySpecifier(next, false))\n+\t\t\treturn LookAheadInfo::VariableDeclaration;","path":"libsolidity/parsing/Parser.cpp","position":51,"original_position":51,"commit_id":"b4719032143f89eedd97eeac59fd43b8694d33bf","original_commit_id":"b4719032143f89eedd97eeac59fd43b8694d33bf","user":{"login":"chriseth","id":9073706,"node_id":"MDQ6VXNlcjkwNzM3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Actually things like `address payable[` should resolve to `LookAheadInfo::IndexAccessStructure`. Basically I'm asking due to which reason can `address payable...` be handled differently than `address...` in this function?","created_at":"2018-09-10T17:12:24Z","updated_at":"2018-09-10T17:12:24Z","html_url":"https://github.com/ethereum/solidity/pull/4926#discussion_r216401978","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/4926","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/216401978"},"html":{"href":"https://github.com/ethereum/solidity/pull/4926#discussion_r216401978"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4926"}},"in_reply_to_id":216395003},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/4926","id":213687752,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjg3NzUy","html_url":"https://github.com/ethereum/solidity/pull/4926","diff_url":"https://github.com/ethereum/solidity/pull/4926.diff","patch_url":"https://github.com/ethereum/solidity/pull/4926.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/4926","number":4926,"state":"open","locked":false,"title":"Accept ``address payable`` during parsing.","user":{"login":"ekpyron","id":1347491,"node_id":"MDQ6VXNlcjEzNDc0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1347491?v=4","gravatar_id":"","url":"https://api.github.com/users/ekpyron","html_url":"https://github.com/ekpyron","followers_url":"https://api.github.com/users/ekpyron/followers","following_url":"https://api.github.com/users/ekpyron/following{/other_user}","gists_url":"https://api.github.com/users/ekpyron/gists{/gist_id}","starred_url":"https://api.github.com/users/ekpyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekpyron/subscriptions","organizations_url":"https://api.github.com/users/ekpyron/orgs","repos_url":"https://api.github.com/users/ekpyron/repos","events_url":"https://api.github.com/users/ekpyron/events{/privacy}","received_events_url":"https://api.github.com/users/ekpyron/received_events","type":"User","site_admin":false},"body":"Prerequisite of #4911.\r\n\r\nMerely allows the ``address payable`` type during parsing and extends ``ElementaryTypeName`` in the AST without actually changing the type system.\r\n\r\nWith this merged it should be possible to merge all documentation, compilation tests and external test updates that will arise during #4911 before #4911 itself without causing issues. (This will avoid the problems we had with #4829).","created_at":"2018-09-06T17:05:23Z","updated_at":"2018-09-10T17:12:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f656900cfa1542c18cebeb7ea06f101d9aed585e","assignee":{"login":"ekpyron","id":1347491,"node_id":"MDQ6VXNlcjEzNDc0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1347491?v=4","gravatar_id":"","url":"https://api.github.com/users/ekpyron","html_url":"https://github.com/ekpyron","followers_url":"https://api.github.com/users/ekpyron/followers","following_url":"https://api.github.com/users/ekpyron/following{/other_user}","gists_url":"https://api.github.com/users/ekpyron/gists{/gist_id}","starred_url":"https://api.github.com/users/ekpyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekpyron/subscriptions","organizations_url":"https://api.github.com/users/ekpyron/orgs","repos_url":"https://api.github.com/users/ekpyron/repos","events_url":"https://api.github.com/users/ekpyron/events{/privacy}","received_events_url":"https://api.github.com/users/ekpyron/received_events","type":"User","site_admin":false},"assignees":[{"login":"ekpyron","id":1347491,"node_id":"MDQ6VXNlcjEzNDc0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1347491?v=4","gravatar_id":"","url":"https://api.github.com/users/ekpyron","html_url":"https://github.com/ekpyron","followers_url":"https://api.github.com/users/ekpyron/followers","following_url":"https://api.github.com/users/ekpyron/following{/other_user}","gists_url":"https://api.github.com/users/ekpyron/gists{/gist_id}","starred_url":"https://api.github.com/users/ekpyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekpyron/subscriptions","organizations_url":"https://api.github.com/users/ekpyron/orgs","repos_url":"https://api.github.com/users/ekpyron/repos","events_url":"https://api.github.com/users/ekpyron/events{/privacy}","received_events_url":"https://api.github.com/users/ekpyron/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/4926/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/4926/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/4926/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/b4719032143f89eedd97eeac59fd43b8694d33bf","head":{"label":"ethereum:addressPayableParser","ref":"addressPayableParser","sha":"b4719032143f89eedd97eeac59fd43b8694d33bf","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-09-10T15:32:25Z","pushed_at":"2018-09-10T16:22:40Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":22972,"stargazers_count":5885,"watchers_count":5885,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1569,"mirror_url":null,"archived":false,"open_issues_count":585,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1569,"open_issues":585,"watchers":5885,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"cd26fa8300c37c7c119004acbc2acc67679174a7","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-09-10T15:32:25Z","pushed_at":"2018-09-10T16:22:40Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":22972,"stargazers_count":5885,"watchers_count":5885,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1569,"mirror_url":null,"archived":false,"open_issues_count":585,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1569,"open_issues":585,"watchers":5885,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4926"},"html":{"href":"https://github.com/ethereum/solidity/pull/4926"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4926"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4926/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4926/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4926/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/b4719032143f89eedd97eeac59fd43b8694d33bf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chriseth"}}