{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/168462460","pull_request_review_id":96830921,"id":168462460,"diff_hunk":"@@ -823,6 +826,24 @@ void Storage::OnServerListDownloaded(vector<string> const & urls)\n                                 bind(&Storage::OnMapFileDownloadProgress, this, _1));\n }\n \n+void Storage::DeferDownloading()\n+{\n+  ASSERT_THREAD_CHECKER(m_threadChecker, ());\n+\n+  m_needToStartDeferredDownloading = true;\n+}\n+\n+void Storage::DoDeferredDownloadIfNeeded()\n+{\n+  ASSERT_THREAD_CHECKER(m_threadChecker, ());\n+\n+  if (!m_needToStartDeferredDownloading || !m_sessionServerList)","path":"storage/storage.cpp","position":106,"original_position":106,"commit_id":"7f2fd19201063da413da630d7c2bd54b460773b6","original_commit_id":"7f2fd19201063da413da630d7c2bd54b460773b6","user":{"login":"milchakov","id":2606569,"avatar_url":"https://avatars1.githubusercontent.com/u/2606569?v=4","gravatar_id":"","url":"https://api.github.com/users/milchakov","html_url":"https://github.com/milchakov","followers_url":"https://api.github.com/users/milchakov/followers","following_url":"https://api.github.com/users/milchakov/following{/other_user}","gists_url":"https://api.github.com/users/milchakov/gists{/gist_id}","starred_url":"https://api.github.com/users/milchakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milchakov/subscriptions","organizations_url":"https://api.github.com/users/milchakov/orgs","repos_url":"https://api.github.com/users/milchakov/repos","events_url":"https://api.github.com/users/milchakov/events{/privacy}","received_events_url":"https://api.github.com/users/milchakov/received_events","type":"User","site_admin":false},"body":"может ли этот метод вызваться до `DownloadNextFile`? Кажется, что теоретически это возможно, тогда `m_needToStartDeferredDownloading` окажется равен `false`","created_at":"2018-02-15T12:34:59Z","updated_at":"2018-02-15T12:34:59Z","html_url":"https://github.com/mapsme/omim/pull/8102#discussion_r168462460","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/8102","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/168462460"},"html":{"href":"https://github.com/mapsme/omim/pull/8102#discussion_r168462460"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8102"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/8102","id":169330063,"html_url":"https://github.com/mapsme/omim/pull/8102","diff_url":"https://github.com/mapsme/omim/pull/8102.diff","patch_url":"https://github.com/mapsme/omim/pull/8102.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/8102","number":8102,"state":"open","locked":false,"title":"Ping downloading urls","user":{"login":"VladiMihaylenko","id":6297856,"avatar_url":"https://avatars3.githubusercontent.com/u/6297856?v=4","gravatar_id":"","url":"https://api.github.com/users/VladiMihaylenko","html_url":"https://github.com/VladiMihaylenko","followers_url":"https://api.github.com/users/VladiMihaylenko/followers","following_url":"https://api.github.com/users/VladiMihaylenko/following{/other_user}","gists_url":"https://api.github.com/users/VladiMihaylenko/gists{/gist_id}","starred_url":"https://api.github.com/users/VladiMihaylenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladiMihaylenko/subscriptions","organizations_url":"https://api.github.com/users/VladiMihaylenko/orgs","repos_url":"https://api.github.com/users/VladiMihaylenko/repos","events_url":"https://api.github.com/users/VladiMihaylenko/events{/privacy}","received_events_url":"https://api.github.com/users/VladiMihaylenko/received_events","type":"User","site_admin":false},"body":"Notice that the following tests are broken now: ```StorageTest_FailedDownloading,\r\nStorageTest_ObsoleteMapsRemoval```\r\n\r\nAlso, no tests provided for a new functionality. Probably will add some in next prs.","created_at":"2018-02-15T10:15:32Z","updated_at":"2018-02-15T12:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95383555132253bac6567ae7f2f2be1e3eeb9eb6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/8102/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/8102/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/8102/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/7f2fd19201063da413da630d7c2bd54b460773b6","head":{"label":"VladiMihaylenko:vm-master","ref":"vm-master","sha":"7f2fd19201063da413da630d7c2bd54b460773b6","user":{"login":"VladiMihaylenko","id":6297856,"avatar_url":"https://avatars3.githubusercontent.com/u/6297856?v=4","gravatar_id":"","url":"https://api.github.com/users/VladiMihaylenko","html_url":"https://github.com/VladiMihaylenko","followers_url":"https://api.github.com/users/VladiMihaylenko/followers","following_url":"https://api.github.com/users/VladiMihaylenko/following{/other_user}","gists_url":"https://api.github.com/users/VladiMihaylenko/gists{/gist_id}","starred_url":"https://api.github.com/users/VladiMihaylenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladiMihaylenko/subscriptions","organizations_url":"https://api.github.com/users/VladiMihaylenko/orgs","repos_url":"https://api.github.com/users/VladiMihaylenko/repos","events_url":"https://api.github.com/users/VladiMihaylenko/events{/privacy}","received_events_url":"https://api.github.com/users/VladiMihaylenko/received_events","type":"User","site_admin":false},"repo":{"id":43432599,"name":"omim","full_name":"VladiMihaylenko/omim","owner":{"login":"VladiMihaylenko","id":6297856,"avatar_url":"https://avatars3.githubusercontent.com/u/6297856?v=4","gravatar_id":"","url":"https://api.github.com/users/VladiMihaylenko","html_url":"https://github.com/VladiMihaylenko","followers_url":"https://api.github.com/users/VladiMihaylenko/followers","following_url":"https://api.github.com/users/VladiMihaylenko/following{/other_user}","gists_url":"https://api.github.com/users/VladiMihaylenko/gists{/gist_id}","starred_url":"https://api.github.com/users/VladiMihaylenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladiMihaylenko/subscriptions","organizations_url":"https://api.github.com/users/VladiMihaylenko/orgs","repos_url":"https://api.github.com/users/VladiMihaylenko/repos","events_url":"https://api.github.com/users/VladiMihaylenko/events{/privacy}","received_events_url":"https://api.github.com/users/VladiMihaylenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VladiMihaylenko/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/VladiMihaylenko/omim","forks_url":"https://api.github.com/repos/VladiMihaylenko/omim/forks","keys_url":"https://api.github.com/repos/VladiMihaylenko/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VladiMihaylenko/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VladiMihaylenko/omim/teams","hooks_url":"https://api.github.com/repos/VladiMihaylenko/omim/hooks","issue_events_url":"https://api.github.com/repos/VladiMihaylenko/omim/issues/events{/number}","events_url":"https://api.github.com/repos/VladiMihaylenko/omim/events","assignees_url":"https://api.github.com/repos/VladiMihaylenko/omim/assignees{/user}","branches_url":"https://api.github.com/repos/VladiMihaylenko/omim/branches{/branch}","tags_url":"https://api.github.com/repos/VladiMihaylenko/omim/tags","blobs_url":"https://api.github.com/repos/VladiMihaylenko/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VladiMihaylenko/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VladiMihaylenko/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/VladiMihaylenko/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VladiMihaylenko/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/VladiMihaylenko/omim/languages","stargazers_url":"https://api.github.com/repos/VladiMihaylenko/omim/stargazers","contributors_url":"https://api.github.com/repos/VladiMihaylenko/omim/contributors","subscribers_url":"https://api.github.com/repos/VladiMihaylenko/omim/subscribers","subscription_url":"https://api.github.com/repos/VladiMihaylenko/omim/subscription","commits_url":"https://api.github.com/repos/VladiMihaylenko/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/VladiMihaylenko/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/VladiMihaylenko/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/VladiMihaylenko/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/VladiMihaylenko/omim/contents/{+path}","compare_url":"https://api.github.com/repos/VladiMihaylenko/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VladiMihaylenko/omim/merges","archive_url":"https://api.github.com/repos/VladiMihaylenko/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VladiMihaylenko/omim/downloads","issues_url":"https://api.github.com/repos/VladiMihaylenko/omim/issues{/number}","pulls_url":"https://api.github.com/repos/VladiMihaylenko/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/VladiMihaylenko/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/VladiMihaylenko/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VladiMihaylenko/omim/labels{/name}","releases_url":"https://api.github.com/repos/VladiMihaylenko/omim/releases{/id}","deployments_url":"https://api.github.com/repos/VladiMihaylenko/omim/deployments","created_at":"2015-09-30T12:49:57Z","updated_at":"2016-01-12T07:16:27Z","pushed_at":"2018-02-15T10:32:28Z","git_url":"git://github.com/VladiMihaylenko/omim.git","ssh_url":"git@github.com:VladiMihaylenko/omim.git","clone_url":"https://github.com/VladiMihaylenko/omim.git","svn_url":"https://github.com/VladiMihaylenko/omim","homepage":null,"size":3462539,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"f558fed7f13d6c1dc8e964c1acb2db3b09f71598","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-02-15T08:51:34Z","pushed_at":"2018-02-15T12:34:52Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3641053,"stargazers_count":2549,"watchers_count":2549,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":551,"mirror_url":null,"archived":false,"open_issues_count":648,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":551,"open_issues":648,"watchers":2549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8102"},"html":{"href":"https://github.com/mapsme/omim/pull/8102"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/8102"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/8102/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8102/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8102/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/7f2fd19201063da413da630d7c2bd54b460773b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"milchakov"}}