{"action":"created","comment":{"url":"https://api.github.com/repos/systers/vms/pulls/comments/170421889","pull_request_review_id":99113231,"id":170421889,"diff_hunk":"@@ -42,7 +42,7 @@ <h2>{% trans \"Sign Up\" %}</h2>\n                     {% trans \"Password\" %}<span class=\"asteriskField\">*</span>\n                 </label>\n                 <div class=\"controls\">\n-                    <input id=\"id_password\" class=\"textinput textInput form-control\" type=\"password\" placeholder=\"{% blocktrans %}Password{% endblocktrans %}\" name=\"usr-password\">\n+                    <input id=\"id_password\" class=\"textinput textInput form-control\" type=\"password\" placeholder=\"{% blocktrans %}Password ( password length should be at least 8 characters long){% endblocktrans %}\" name=\"usr-password\">","path":"vms/registration/templates/registration/signup_volunteer.html","position":5,"original_position":5,"commit_id":"9d2e422245a7b998624f062c88e670310850b028","original_commit_id":"9d2e422245a7b998624f062c88e670310850b028","user":{"login":"tapasweni-pathak","id":4143778,"avatar_url":"https://avatars3.githubusercontent.com/u/4143778?v=4","gravatar_id":"","url":"https://api.github.com/users/tapasweni-pathak","html_url":"https://github.com/tapasweni-pathak","followers_url":"https://api.github.com/users/tapasweni-pathak/followers","following_url":"https://api.github.com/users/tapasweni-pathak/following{/other_user}","gists_url":"https://api.github.com/users/tapasweni-pathak/gists{/gist_id}","starred_url":"https://api.github.com/users/tapasweni-pathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tapasweni-pathak/subscriptions","organizations_url":"https://api.github.com/users/tapasweni-pathak/orgs","repos_url":"https://api.github.com/users/tapasweni-pathak/repos","events_url":"https://api.github.com/users/tapasweni-pathak/events{/privacy}","received_events_url":"https://api.github.com/users/tapasweni-pathak/received_events","type":"User","site_admin":false},"body":"Could you add a error message for >max_length and not placeholder text? For <min_length VMS throws error message.","created_at":"2018-02-24T13:59:11Z","updated_at":"2018-02-24T13:59:11Z","html_url":"https://github.com/systers/vms/pull/596#discussion_r170421889","pull_request_url":"https://api.github.com/repos/systers/vms/pulls/596","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/comments/170421889"},"html":{"href":"https://github.com/systers/vms/pull/596#discussion_r170421889"},"pull_request":{"href":"https://api.github.com/repos/systers/vms/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/systers/vms/pulls/596","id":167023094,"html_url":"https://github.com/systers/vms/pull/596","diff_url":"https://github.com/systers/vms/pull/596.diff","patch_url":"https://github.com/systers/vms/pull/596.patch","issue_url":"https://api.github.com/repos/systers/vms/issues/596","number":596,"state":"open","locked":false,"title":"Set a check on length of password field in sign up form.","user":{"login":"sammy1997","id":24635701,"avatar_url":"https://avatars1.githubusercontent.com/u/24635701?v=4","gravatar_id":"","url":"https://api.github.com/users/sammy1997","html_url":"https://github.com/sammy1997","followers_url":"https://api.github.com/users/sammy1997/followers","following_url":"https://api.github.com/users/sammy1997/following{/other_user}","gists_url":"https://api.github.com/users/sammy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/sammy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammy1997/subscriptions","organizations_url":"https://api.github.com/users/sammy1997/orgs","repos_url":"https://api.github.com/users/sammy1997/repos","events_url":"https://api.github.com/users/sammy1997/events{/privacy}","received_events_url":"https://api.github.com/users/sammy1997/received_events","type":"User","site_admin":false},"body":"# Description\r\nSet a max and min length for password input field in registration / sign up form \r\n\r\nFixes #578 \r\n# Type of Change:\r\n- Code\r\n- Bug fix (non-breaking change which fixes an issue)\r\n\r\n# Checklist:\r\n\r\n- [ ] My PR follows the style guidelines of this project\r\n- [ ] I have performed a self-review of my own code or materials\r\n- [ ] I have made corresponding changes to the documentation\r\n- [ ] My changes generate no new warnings \r\n- [ ] New and existing unit tests pass locally with my changes\r\n","created_at":"2018-02-04T18:34:31Z","updated_at":"2018-02-24T13:59:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b58a5cf2680eb53ea98b3b0b902790e93eca747","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/systers/vms/pulls/596/commits","review_comments_url":"https://api.github.com/repos/systers/vms/pulls/596/comments","review_comment_url":"https://api.github.com/repos/systers/vms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systers/vms/issues/596/comments","statuses_url":"https://api.github.com/repos/systers/vms/statuses/9d2e422245a7b998624f062c88e670310850b028","head":{"label":"sammy1997:develop","ref":"develop","sha":"9d2e422245a7b998624f062c88e670310850b028","user":{"login":"sammy1997","id":24635701,"avatar_url":"https://avatars1.githubusercontent.com/u/24635701?v=4","gravatar_id":"","url":"https://api.github.com/users/sammy1997","html_url":"https://github.com/sammy1997","followers_url":"https://api.github.com/users/sammy1997/followers","following_url":"https://api.github.com/users/sammy1997/following{/other_user}","gists_url":"https://api.github.com/users/sammy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/sammy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammy1997/subscriptions","organizations_url":"https://api.github.com/users/sammy1997/orgs","repos_url":"https://api.github.com/users/sammy1997/repos","events_url":"https://api.github.com/users/sammy1997/events{/privacy}","received_events_url":"https://api.github.com/users/sammy1997/received_events","type":"User","site_admin":false},"repo":{"id":120208707,"name":"vms","full_name":"sammy1997/vms","owner":{"login":"sammy1997","id":24635701,"avatar_url":"https://avatars1.githubusercontent.com/u/24635701?v=4","gravatar_id":"","url":"https://api.github.com/users/sammy1997","html_url":"https://github.com/sammy1997","followers_url":"https://api.github.com/users/sammy1997/followers","following_url":"https://api.github.com/users/sammy1997/following{/other_user}","gists_url":"https://api.github.com/users/sammy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/sammy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammy1997/subscriptions","organizations_url":"https://api.github.com/users/sammy1997/orgs","repos_url":"https://api.github.com/users/sammy1997/repos","events_url":"https://api.github.com/users/sammy1997/events{/privacy}","received_events_url":"https://api.github.com/users/sammy1997/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sammy1997/vms","description":"Volunteer Management System","fork":true,"url":"https://api.github.com/repos/sammy1997/vms","forks_url":"https://api.github.com/repos/sammy1997/vms/forks","keys_url":"https://api.github.com/repos/sammy1997/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sammy1997/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sammy1997/vms/teams","hooks_url":"https://api.github.com/repos/sammy1997/vms/hooks","issue_events_url":"https://api.github.com/repos/sammy1997/vms/issues/events{/number}","events_url":"https://api.github.com/repos/sammy1997/vms/events","assignees_url":"https://api.github.com/repos/sammy1997/vms/assignees{/user}","branches_url":"https://api.github.com/repos/sammy1997/vms/branches{/branch}","tags_url":"https://api.github.com/repos/sammy1997/vms/tags","blobs_url":"https://api.github.com/repos/sammy1997/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sammy1997/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sammy1997/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/sammy1997/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sammy1997/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/sammy1997/vms/languages","stargazers_url":"https://api.github.com/repos/sammy1997/vms/stargazers","contributors_url":"https://api.github.com/repos/sammy1997/vms/contributors","subscribers_url":"https://api.github.com/repos/sammy1997/vms/subscribers","subscription_url":"https://api.github.com/repos/sammy1997/vms/subscription","commits_url":"https://api.github.com/repos/sammy1997/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/sammy1997/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/sammy1997/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/sammy1997/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/sammy1997/vms/contents/{+path}","compare_url":"https://api.github.com/repos/sammy1997/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sammy1997/vms/merges","archive_url":"https://api.github.com/repos/sammy1997/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sammy1997/vms/downloads","issues_url":"https://api.github.com/repos/sammy1997/vms/issues{/number}","pulls_url":"https://api.github.com/repos/sammy1997/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/sammy1997/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/sammy1997/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sammy1997/vms/labels{/name}","releases_url":"https://api.github.com/repos/sammy1997/vms/releases{/id}","deployments_url":"https://api.github.com/repos/sammy1997/vms/deployments","created_at":"2018-02-04T17:55:38Z","updated_at":"2018-02-04T17:55:40Z","pushed_at":"2018-02-18T13:31:13Z","git_url":"git://github.com/sammy1997/vms.git","ssh_url":"git@github.com:sammy1997/vms.git","clone_url":"https://github.com/sammy1997/vms.git","svn_url":"https://github.com/sammy1997/vms","homepage":null,"size":2790,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"systers:develop","ref":"develop","sha":"587ba0abd82fb234b2779131d0eaca597edb0338","user":{"login":"systers","id":6520415,"avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"repo":{"id":19032264,"name":"vms","full_name":"systers/vms","owner":{"login":"systers","id":6520415,"avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systers/vms","description":"Volunteer Management System","fork":false,"url":"https://api.github.com/repos/systers/vms","forks_url":"https://api.github.com/repos/systers/vms/forks","keys_url":"https://api.github.com/repos/systers/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systers/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systers/vms/teams","hooks_url":"https://api.github.com/repos/systers/vms/hooks","issue_events_url":"https://api.github.com/repos/systers/vms/issues/events{/number}","events_url":"https://api.github.com/repos/systers/vms/events","assignees_url":"https://api.github.com/repos/systers/vms/assignees{/user}","branches_url":"https://api.github.com/repos/systers/vms/branches{/branch}","tags_url":"https://api.github.com/repos/systers/vms/tags","blobs_url":"https://api.github.com/repos/systers/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systers/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systers/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/systers/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systers/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/systers/vms/languages","stargazers_url":"https://api.github.com/repos/systers/vms/stargazers","contributors_url":"https://api.github.com/repos/systers/vms/contributors","subscribers_url":"https://api.github.com/repos/systers/vms/subscribers","subscription_url":"https://api.github.com/repos/systers/vms/subscription","commits_url":"https://api.github.com/repos/systers/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/systers/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/systers/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/systers/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/systers/vms/contents/{+path}","compare_url":"https://api.github.com/repos/systers/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systers/vms/merges","archive_url":"https://api.github.com/repos/systers/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systers/vms/downloads","issues_url":"https://api.github.com/repos/systers/vms/issues{/number}","pulls_url":"https://api.github.com/repos/systers/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/systers/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/systers/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systers/vms/labels{/name}","releases_url":"https://api.github.com/repos/systers/vms/releases{/id}","deployments_url":"https://api.github.com/repos/systers/vms/deployments","created_at":"2014-04-22T14:13:57Z","updated_at":"2018-02-21T17:36:26Z","pushed_at":"2018-02-23T15:44:40Z","git_url":"git://github.com/systers/vms.git","ssh_url":"git@github.com:systers/vms.git","clone_url":"https://github.com/systers/vms.git","svn_url":"https://github.com/systers/vms","homepage":null,"size":2798,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":130,"open_issues":117,"watchers":49,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/596"},"html":{"href":"https://github.com/systers/vms/pull/596"},"issue":{"href":"https://api.github.com/repos/systers/vms/issues/596"},"comments":{"href":"https://api.github.com/repos/systers/vms/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/systers/vms/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/systers/vms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systers/vms/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/systers/vms/statuses/9d2e422245a7b998624f062c88e670310850b028"}},"author_association":"NONE"}}
{"actor":{"display_login":"tapasweni-pathak"}}