{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/17","id":198204356,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjA0MzU2","html_url":"https://github.com/swingexplorer/swingexplorer/pull/17","diff_url":"https://github.com/swingexplorer/swingexplorer/pull/17.diff","patch_url":"https://github.com/swingexplorer/swingexplorer/pull/17.patch","issue_url":"https://api.github.com/repos/swingexplorer/swingexplorer/issues/17","number":17,"state":"closed","locked":false,"title":"Fix some compiler warnings","user":{"login":"apjanke","id":2618447,"node_id":"MDQ6VXNlcjI2MTg0NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2618447?v=4","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"body":"This fixes some compiler warnings that have crept back in to the build.\r\n\r\nFixes #15.\r\n\r\n###  Details\r\n\r\nThis mostly fixes the warnings by adding type parameters. The ListCellRenderer\r\nstuff can't be fixed like that, though, because DefaultListCellRenderer\r\nis already parameterized to type Object. So I suppressed those warnings\r\ninstead.\r\n\r\nAlso, deprecated `show()`/`hide()` calls are replaced with `setVisible(...)` calls.\r\n\r\nI also switched `PNLPlayerControllers.java` to always use an `OperationListModel`, even for the initial dummy data. \r\n\r\nBefore:\r\n\r\n```\r\n[INFO] Compiling 117 source files to /Users/janke/local/repos/swingexplorer/swingexplorer-core/target/classes\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[34,17] sun.swing.DefaultLookup is internal proprietary API and may be removed in a future release\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/PnlPlayerControls.java:[72,31] unchecked call to setModel(javax.swing.ListModel<E>) as a member of the raw type javax.swing.JList\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/PnlPlayerControls.java:[242,31] unchecked call to setModel(javax.swing.ListModel<E>) as a member of the raw type javax.swing.JList\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/MdlSwingExplorer.java:[313,49] show() in java.awt.Component has been deprecated\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/MdlSwingExplorer.java:[339,49] hide() in javax.swing.JComponent has been deprecated\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/PnlSwingExplorer.java:[307,27] unchecked call to DefaultComboBoxModel(E[]) as a member of the raw type javax.swing.DefaultComboBoxModel\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/PnlSwingExplorer.java:[307,26] unchecked call to setModel(javax.swing.ComboBoxModel<E>) as a member of the raw type javax.swing.JComboBox\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/ColorComboBox.java:[56,25] unchecked call to setModel(javax.swing.ComboBoxModel<E>) as a member of the raw type javax.swing.JComboBox\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/ColorComboBox.java:[59,28] unchecked call to setRenderer(javax.swing.ListCellRenderer<? super E>) as a member of the raw type javax.swing.JComboBox\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/sample/FrmPerson.java:[125,29] unchecked call to DefaultComboBoxModel(E[]) as a member of the raw type javax.swing.DefaultComboBoxModel\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/sample/FrmPerson.java:[125,28] unchecked call to setModel(javax.swing.ComboBoxModel<E>) as a member of the raw type javax.swing.JComboBox\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/personal/AbstractOnResizePersonalizer.java:[40,32] unchecked cast\r\n  required: T\r\n  found:    java.awt.Component\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[72,54] unchecked call to getListCellRendererComponent(javax.swing.JList<? extends E>,E,int,boolean,boolean) as a member of the raw type javax.swing.ListCellRenderer\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[79,54] unchecked call to getListCellRendererComponent(javax.swing.JList<? extends E>,E,int,boolean,boolean) as a member of the raw type javax.swing.ListCellRenderer\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[97,33] sun.swing.DefaultLookup is internal proprietary API and may be removed in a future release\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[99,33] sun.swing.DefaultLookup is internal proprietary API and may be removed in a future release\r\n```\r\n\r\nAfter:\r\n\r\nAll that remains are warnings about the internal proprietary sun.swing.DefaultLookup. These warnings cannot (officially) be suppressed.\r\n\r\n```\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[34,17] sun.swing.DefaultLookup is internal proprietary API and may be removed in a future release\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[98,33] sun.swing.DefaultLookup is internal proprietary API and may be removed in a future release\r\n[WARNING] /Users/janke/local/repos/swingexplorer/swingexplorer-core/src/main/java/org/swingexplorer/plaf/CustomComboBoxUI.java:[100,33] sun.swing.DefaultLookup is internal proprietary API and may be removed in a future release\r\n```","created_at":"2018-06-29T03:11:57Z","updated_at":"2018-07-05T21:23:37Z","closed_at":"2018-07-05T21:23:37Z","merged_at":"2018-07-05T21:23:37Z","merge_commit_sha":"490930798cffdc698a020ee57b41f0700687a3dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/17/commits","review_comments_url":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/17/comments","review_comment_url":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swingexplorer/swingexplorer/issues/17/comments","statuses_url":"https://api.github.com/repos/swingexplorer/swingexplorer/statuses/10e3b10cf356832ec4562020165335f13df646ed","head":{"label":"apjanke:fix-some-compiler-warnings","ref":"fix-some-compiler-warnings","sha":"10e3b10cf356832ec4562020165335f13df646ed","user":{"login":"apjanke","id":2618447,"node_id":"MDQ6VXNlcjI2MTg0NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2618447?v=4","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"repo":{"id":138925902,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5MjU5MDI=","name":"swingexplorer","full_name":"apjanke/swingexplorer","owner":{"login":"apjanke","id":2618447,"node_id":"MDQ6VXNlcjI2MTg0NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2618447?v=4","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apjanke/swingexplorer","description":"Core files of Swing Explorer tool","fork":true,"url":"https://api.github.com/repos/apjanke/swingexplorer","forks_url":"https://api.github.com/repos/apjanke/swingexplorer/forks","keys_url":"https://api.github.com/repos/apjanke/swingexplorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apjanke/swingexplorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apjanke/swingexplorer/teams","hooks_url":"https://api.github.com/repos/apjanke/swingexplorer/hooks","issue_events_url":"https://api.github.com/repos/apjanke/swingexplorer/issues/events{/number}","events_url":"https://api.github.com/repos/apjanke/swingexplorer/events","assignees_url":"https://api.github.com/repos/apjanke/swingexplorer/assignees{/user}","branches_url":"https://api.github.com/repos/apjanke/swingexplorer/branches{/branch}","tags_url":"https://api.github.com/repos/apjanke/swingexplorer/tags","blobs_url":"https://api.github.com/repos/apjanke/swingexplorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apjanke/swingexplorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apjanke/swingexplorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/apjanke/swingexplorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apjanke/swingexplorer/statuses/{sha}","languages_url":"https://api.github.com/repos/apjanke/swingexplorer/languages","stargazers_url":"https://api.github.com/repos/apjanke/swingexplorer/stargazers","contributors_url":"https://api.github.com/repos/apjanke/swingexplorer/contributors","subscribers_url":"https://api.github.com/repos/apjanke/swingexplorer/subscribers","subscription_url":"https://api.github.com/repos/apjanke/swingexplorer/subscription","commits_url":"https://api.github.com/repos/apjanke/swingexplorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/apjanke/swingexplorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/apjanke/swingexplorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/apjanke/swingexplorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/apjanke/swingexplorer/contents/{+path}","compare_url":"https://api.github.com/repos/apjanke/swingexplorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apjanke/swingexplorer/merges","archive_url":"https://api.github.com/repos/apjanke/swingexplorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apjanke/swingexplorer/downloads","issues_url":"https://api.github.com/repos/apjanke/swingexplorer/issues{/number}","pulls_url":"https://api.github.com/repos/apjanke/swingexplorer/pulls{/number}","milestones_url":"https://api.github.com/repos/apjanke/swingexplorer/milestones{/number}","notifications_url":"https://api.github.com/repos/apjanke/swingexplorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apjanke/swingexplorer/labels{/name}","releases_url":"https://api.github.com/repos/apjanke/swingexplorer/releases{/id}","deployments_url":"https://api.github.com/repos/apjanke/swingexplorer/deployments","created_at":"2018-06-27T19:45:54Z","updated_at":"2018-07-05T14:40:15Z","pushed_at":"2018-07-05T15:10:05Z","git_url":"git://github.com/apjanke/swingexplorer.git","ssh_url":"git@github.com:apjanke/swingexplorer.git","clone_url":"https://github.com/apjanke/swingexplorer.git","svn_url":"https://github.com/apjanke/swingexplorer","homepage":null,"size":632,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swingexplorer:master","ref":"master","sha":"57907d3694dfcf1fc87d1002807313ad2027a885","user":{"login":"swingexplorer","id":40040896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDQwODk2","avatar_url":"https://avatars0.githubusercontent.com/u/40040896?v=4","gravatar_id":"","url":"https://api.github.com/users/swingexplorer","html_url":"https://github.com/swingexplorer","followers_url":"https://api.github.com/users/swingexplorer/followers","following_url":"https://api.github.com/users/swingexplorer/following{/other_user}","gists_url":"https://api.github.com/users/swingexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/swingexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swingexplorer/subscriptions","organizations_url":"https://api.github.com/users/swingexplorer/orgs","repos_url":"https://api.github.com/users/swingexplorer/repos","events_url":"https://api.github.com/users/swingexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/swingexplorer/received_events","type":"Organization","site_admin":false},"repo":{"id":136523531,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MjM1MzE=","name":"swingexplorer","full_name":"swingexplorer/swingexplorer","owner":{"login":"swingexplorer","id":40040896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDQwODk2","avatar_url":"https://avatars0.githubusercontent.com/u/40040896?v=4","gravatar_id":"","url":"https://api.github.com/users/swingexplorer","html_url":"https://github.com/swingexplorer","followers_url":"https://api.github.com/users/swingexplorer/followers","following_url":"https://api.github.com/users/swingexplorer/following{/other_user}","gists_url":"https://api.github.com/users/swingexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/swingexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swingexplorer/subscriptions","organizations_url":"https://api.github.com/users/swingexplorer/orgs","repos_url":"https://api.github.com/users/swingexplorer/repos","events_url":"https://api.github.com/users/swingexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/swingexplorer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swingexplorer/swingexplorer","description":"Core files of Swing Explorer tool","fork":false,"url":"https://api.github.com/repos/swingexplorer/swingexplorer","forks_url":"https://api.github.com/repos/swingexplorer/swingexplorer/forks","keys_url":"https://api.github.com/repos/swingexplorer/swingexplorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swingexplorer/swingexplorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swingexplorer/swingexplorer/teams","hooks_url":"https://api.github.com/repos/swingexplorer/swingexplorer/hooks","issue_events_url":"https://api.github.com/repos/swingexplorer/swingexplorer/issues/events{/number}","events_url":"https://api.github.com/repos/swingexplorer/swingexplorer/events","assignees_url":"https://api.github.com/repos/swingexplorer/swingexplorer/assignees{/user}","branches_url":"https://api.github.com/repos/swingexplorer/swingexplorer/branches{/branch}","tags_url":"https://api.github.com/repos/swingexplorer/swingexplorer/tags","blobs_url":"https://api.github.com/repos/swingexplorer/swingexplorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swingexplorer/swingexplorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swingexplorer/swingexplorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/swingexplorer/swingexplorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swingexplorer/swingexplorer/statuses/{sha}","languages_url":"https://api.github.com/repos/swingexplorer/swingexplorer/languages","stargazers_url":"https://api.github.com/repos/swingexplorer/swingexplorer/stargazers","contributors_url":"https://api.github.com/repos/swingexplorer/swingexplorer/contributors","subscribers_url":"https://api.github.com/repos/swingexplorer/swingexplorer/subscribers","subscription_url":"https://api.github.com/repos/swingexplorer/swingexplorer/subscription","commits_url":"https://api.github.com/repos/swingexplorer/swingexplorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/swingexplorer/swingexplorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/swingexplorer/swingexplorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/swingexplorer/swingexplorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/swingexplorer/swingexplorer/contents/{+path}","compare_url":"https://api.github.com/repos/swingexplorer/swingexplorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swingexplorer/swingexplorer/merges","archive_url":"https://api.github.com/repos/swingexplorer/swingexplorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swingexplorer/swingexplorer/downloads","issues_url":"https://api.github.com/repos/swingexplorer/swingexplorer/issues{/number}","pulls_url":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls{/number}","milestones_url":"https://api.github.com/repos/swingexplorer/swingexplorer/milestones{/number}","notifications_url":"https://api.github.com/repos/swingexplorer/swingexplorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swingexplorer/swingexplorer/labels{/name}","releases_url":"https://api.github.com/repos/swingexplorer/swingexplorer/releases{/id}","deployments_url":"https://api.github.com/repos/swingexplorer/swingexplorer/deployments","created_at":"2018-06-07T19:45:30Z","updated_at":"2018-07-05T14:04:21Z","pushed_at":"2018-07-05T21:23:37Z","git_url":"git://github.com/swingexplorer/swingexplorer.git","ssh_url":"git@github.com:swingexplorer/swingexplorer.git","clone_url":"https://github.com/swingexplorer/swingexplorer.git","svn_url":"https://github.com/swingexplorer/swingexplorer","homepage":null,"size":593,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/17"},"html":{"href":"https://github.com/swingexplorer/swingexplorer/pull/17"},"issue":{"href":"https://api.github.com/repos/swingexplorer/swingexplorer/issues/17"},"comments":{"href":"https://api.github.com/repos/swingexplorer/swingexplorer/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swingexplorer/swingexplorer/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/swingexplorer/swingexplorer/statuses/10e3b10cf356832ec4562020165335f13df646ed"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"maxim-zakharenkov","id":1640837,"node_id":"MDQ6VXNlcjE2NDA4Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1640837?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-zakharenkov","html_url":"https://github.com/maxim-zakharenkov","followers_url":"https://api.github.com/users/maxim-zakharenkov/followers","following_url":"https://api.github.com/users/maxim-zakharenkov/following{/other_user}","gists_url":"https://api.github.com/users/maxim-zakharenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-zakharenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-zakharenkov/subscriptions","organizations_url":"https://api.github.com/users/maxim-zakharenkov/orgs","repos_url":"https://api.github.com/users/maxim-zakharenkov/repos","events_url":"https://api.github.com/users/maxim-zakharenkov/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-zakharenkov/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":26,"deletions":21,"changed_files":8}}
{"actor":{"display_login":"maxim-zakharenkov"}}