{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/193650747","pull_request_review_id":126657736,"id":193650747,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzY1MDc0Nw==","diff_hunk":"@@ -170,6 +170,11 @@ class Transactor\n \n     virtual TER doApply () = 0;\n \n+    static","path":"src/ripple/app/tx/impl/Transactor.h","position":31,"original_position":31,"commit_id":"59c26878415481863ce6769444ed46924fd27304","original_commit_id":"59c26878415481863ce6769444ed46924fd27304","user":{"login":"nbougalis","id":5085415,"node_id":"MDQ6VXNlcjUwODU0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5085415?v=4","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"body":"A javadoc comment explaining exactly what this function does would be great.","created_at":"2018-06-07T07:34:37Z","updated_at":"2018-06-07T07:37:14Z","html_url":"https://github.com/ripple/rippled/pull/2518#discussion_r193650747","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/2518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/193650747"},"html":{"href":"https://github.com/ripple/rippled/pull/2518#discussion_r193650747"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2518"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/2518","id":187038989,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MDM4OTg5","html_url":"https://github.com/ripple/rippled/pull/2518","diff_url":"https://github.com/ripple/rippled/pull/2518.diff","patch_url":"https://github.com/ripple/rippled/pull/2518.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/2518","number":2518,"state":"open","locked":false,"title":"Remove Transactor::mFeeDue member variable","user":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"* mFeeDue is only used in one place by one derived class, so\r\n  only compute it as a local in that function.\r\n\r\nThis is a pretty small change, not quite trivial, that I noticed while looking at something completely unrelated. In the interest of not mixing concerns, I split this out into its own PR.","created_at":"2018-05-09T21:00:31Z","updated_at":"2018-06-07T07:37:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c0707dada88e7fd8602c56b315751b67b6dad5d","assignee":{"login":"mellery451","id":463430,"node_id":"MDQ6VXNlcjQ2MzQzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"assignees":[{"login":"mellery451","id":463430,"node_id":"MDQ6VXNlcjQ2MzQzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},{"login":"seelabs","id":5853458,"node_id":"MDQ6VXNlcjU4NTM0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5853458?v=4","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/2518/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/2518/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2518/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/59c26878415481863ce6769444ed46924fd27304","head":{"label":"ximinez:feedue","ref":"feedue","sha":"59c26878415481863ce6769444ed46924fd27304","user":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"repo":{"id":17236735,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIzNjczNQ==","name":"rippled","full_name":"ximinez/rippled","owner":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ximinez/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/ximinez/rippled","forks_url":"https://api.github.com/repos/ximinez/rippled/forks","keys_url":"https://api.github.com/repos/ximinez/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ximinez/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ximinez/rippled/teams","hooks_url":"https://api.github.com/repos/ximinez/rippled/hooks","issue_events_url":"https://api.github.com/repos/ximinez/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ximinez/rippled/events","assignees_url":"https://api.github.com/repos/ximinez/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ximinez/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ximinez/rippled/tags","blobs_url":"https://api.github.com/repos/ximinez/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ximinez/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ximinez/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ximinez/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ximinez/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ximinez/rippled/languages","stargazers_url":"https://api.github.com/repos/ximinez/rippled/stargazers","contributors_url":"https://api.github.com/repos/ximinez/rippled/contributors","subscribers_url":"https://api.github.com/repos/ximinez/rippled/subscribers","subscription_url":"https://api.github.com/repos/ximinez/rippled/subscription","commits_url":"https://api.github.com/repos/ximinez/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ximinez/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ximinez/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ximinez/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ximinez/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ximinez/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ximinez/rippled/merges","archive_url":"https://api.github.com/repos/ximinez/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ximinez/rippled/downloads","issues_url":"https://api.github.com/repos/ximinez/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ximinez/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ximinez/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ximinez/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ximinez/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ximinez/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ximinez/rippled/deployments","created_at":"2014-02-27T04:33:56Z","updated_at":"2018-06-02T00:39:31Z","pushed_at":"2018-06-06T23:17:25Z","git_url":"git://github.com/ximinez/rippled.git","ssh_url":"git@github.com:ximinez/rippled.git","clone_url":"https://github.com/ximinez/rippled.git","svn_url":"https://github.com/ximinez/rippled","homepage":"https://ripple.com","size":94250,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"fd4636b0560900bd040b03004a1efc7ddb8369a0","user":{"login":"ripple","id":3165523,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjU1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI0MTY3","name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjU1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2018-06-06T23:13:59Z","pushed_at":"2018-06-07T02:45:29Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com/xrp","size":94255,"stargazers_count":2805,"watchers_count":2805,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":827,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":827,"open_issues":150,"watchers":2805,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2518"},"html":{"href":"https://github.com/ripple/rippled/pull/2518"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/2518"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/2518/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2518/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2518/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/59c26878415481863ce6769444ed46924fd27304"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nbougalis"}}