{"action":"closed","number":2755,"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2755","id":227389039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mzg5MDM5","html_url":"https://github.com/apache/geode/pull/2755","diff_url":"https://github.com/apache/geode/pull/2755.diff","patch_url":"https://github.com/apache/geode/pull/2755.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/2755","number":2755,"state":"closed","locked":false,"title":"GEODE-5881: simplify DefaultQuery.TestHook","user":{"login":"Bill","id":4002,"node_id":"MDQ6VXNlcjQwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4002?v=4","gravatar_id":"","url":"https://api.github.com/users/Bill","html_url":"https://github.com/Bill","followers_url":"https://api.github.com/users/Bill/followers","following_url":"https://api.github.com/users/Bill/following{/other_user}","gists_url":"https://api.github.com/users/Bill/gists{/gist_id}","starred_url":"https://api.github.com/users/Bill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bill/subscriptions","organizations_url":"https://api.github.com/users/Bill/orgs","repos_url":"https://api.github.com/users/Bill/repos","events_url":"https://api.github.com/users/Bill/events{/privacy}","received_events_url":"https://api.github.com/users/Bill/received_events","type":"User","site_admin":false},"body":"Consolidate three interface methods into one that takes an enum\r\nto identify the \"spot\" in the query processing logic.\r\n\r\nCo-authored-by: Bill Burcham <bburcham@pivotal.io>\r\nCo-authored-by: Dale Emery <demery@pivotal.io>\r\nCo-authored-by: Galen O'Sullivan <gosullivan@pivotal.io>\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n- [x] Does `gradlew build` run cleanly?\r\n\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n\r\n- N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n","created_at":"2018-10-31T18:03:46Z","updated_at":"2018-10-31T23:33:37Z","closed_at":"2018-10-31T23:33:37Z","merged_at":"2018-10-31T23:33:37Z","merge_commit_sha":"b040508b61839467e9bb737e1780920d4d2fe5c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/2755/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/2755/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/2755/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/955bc37661211f5cefbbb6d1414eabd1667aaeda","head":{"label":"Bill:feature/GEODE-5881","ref":"feature/GEODE-5881","sha":"955bc37661211f5cefbbb6d1414eabd1667aaeda","user":{"login":"Bill","id":4002,"node_id":"MDQ6VXNlcjQwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4002?v=4","gravatar_id":"","url":"https://api.github.com/users/Bill","html_url":"https://github.com/Bill","followers_url":"https://api.github.com/users/Bill/followers","following_url":"https://api.github.com/users/Bill/following{/other_user}","gists_url":"https://api.github.com/users/Bill/gists{/gist_id}","starred_url":"https://api.github.com/users/Bill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bill/subscriptions","organizations_url":"https://api.github.com/users/Bill/orgs","repos_url":"https://api.github.com/users/Bill/repos","events_url":"https://api.github.com/users/Bill/events{/privacy}","received_events_url":"https://api.github.com/users/Bill/received_events","type":"User","site_admin":false},"repo":{"id":148550439,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1NTA0Mzk=","name":"geode","full_name":"Bill/geode","private":false,"owner":{"login":"Bill","id":4002,"node_id":"MDQ6VXNlcjQwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4002?v=4","gravatar_id":"","url":"https://api.github.com/users/Bill","html_url":"https://github.com/Bill","followers_url":"https://api.github.com/users/Bill/followers","following_url":"https://api.github.com/users/Bill/following{/other_user}","gists_url":"https://api.github.com/users/Bill/gists{/gist_id}","starred_url":"https://api.github.com/users/Bill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bill/subscriptions","organizations_url":"https://api.github.com/users/Bill/orgs","repos_url":"https://api.github.com/users/Bill/repos","events_url":"https://api.github.com/users/Bill/events{/privacy}","received_events_url":"https://api.github.com/users/Bill/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bill/geode","description":"Apache Geode","fork":true,"url":"https://api.github.com/repos/Bill/geode","forks_url":"https://api.github.com/repos/Bill/geode/forks","keys_url":"https://api.github.com/repos/Bill/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bill/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bill/geode/teams","hooks_url":"https://api.github.com/repos/Bill/geode/hooks","issue_events_url":"https://api.github.com/repos/Bill/geode/issues/events{/number}","events_url":"https://api.github.com/repos/Bill/geode/events","assignees_url":"https://api.github.com/repos/Bill/geode/assignees{/user}","branches_url":"https://api.github.com/repos/Bill/geode/branches{/branch}","tags_url":"https://api.github.com/repos/Bill/geode/tags","blobs_url":"https://api.github.com/repos/Bill/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bill/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bill/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bill/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bill/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/Bill/geode/languages","stargazers_url":"https://api.github.com/repos/Bill/geode/stargazers","contributors_url":"https://api.github.com/repos/Bill/geode/contributors","subscribers_url":"https://api.github.com/repos/Bill/geode/subscribers","subscription_url":"https://api.github.com/repos/Bill/geode/subscription","commits_url":"https://api.github.com/repos/Bill/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bill/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bill/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bill/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bill/geode/contents/{+path}","compare_url":"https://api.github.com/repos/Bill/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bill/geode/merges","archive_url":"https://api.github.com/repos/Bill/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bill/geode/downloads","issues_url":"https://api.github.com/repos/Bill/geode/issues{/number}","pulls_url":"https://api.github.com/repos/Bill/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/Bill/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/Bill/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bill/geode/labels{/name}","releases_url":"https://api.github.com/repos/Bill/geode/releases{/id}","deployments_url":"https://api.github.com/repos/Bill/geode/deployments","created_at":"2018-09-12T22:36:03Z","updated_at":"2018-09-20T17:25:46Z","pushed_at":"2018-10-31T18:38:50Z","git_url":"git://github.com/Bill/geode.git","ssh_url":"git@github.com:Bill/geode.git","clone_url":"https://github.com/Bill/geode.git","svn_url":"https://github.com/Bill/geode","homepage":"","size":163881,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"04c1d0ed2f569e33a99a5109bba432ad9f8a7c33","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgzOTM4Mw==","name":"geode","full_name":"apache/geode","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-10-31T22:16:55Z","pushed_at":"2018-10-31T23:33:36Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":163910,"stargazers_count":1366,"watchers_count":1366,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":472,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":472,"open_issues":24,"watchers":1366,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/2755"},"html":{"href":"https://github.com/apache/geode/pull/2755"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/2755"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/2755/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/2755/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/2755/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/955bc37661211f5cefbbb6d1414eabd1667aaeda"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mcmellawatt","id":1082688,"node_id":"MDQ6VXNlcjEwODI2ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1082688?v=4","gravatar_id":"","url":"https://api.github.com/users/mcmellawatt","html_url":"https://github.com/mcmellawatt","followers_url":"https://api.github.com/users/mcmellawatt/followers","following_url":"https://api.github.com/users/mcmellawatt/following{/other_user}","gists_url":"https://api.github.com/users/mcmellawatt/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmellawatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmellawatt/subscriptions","organizations_url":"https://api.github.com/users/mcmellawatt/orgs","repos_url":"https://api.github.com/users/mcmellawatt/repos","events_url":"https://api.github.com/users/mcmellawatt/events{/privacy}","received_events_url":"https://api.github.com/users/mcmellawatt/received_events","type":"User","site_admin":false},"comments":2,"review_comments":5,"maintainer_can_modify":false,"commits":2,"additions":428,"deletions":415,"changed_files":14}}
{"actor":{"display_login":"mcmellawatt"}}