{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/googleapis/pulls/comments/239886358","pull_request_review_id":182796097,"id":239886358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTg4NjM1OA==","diff_hunk":"@@ -30,6 +30,7 @@ option java_multiple_files = true;\n option java_outer_classname = \"PubsubProto\";\n option java_package = \"com.google.pubsub.v1\";\n option php_namespace = \"Google\\\\Cloud\\\\PubSub\\\\V1\";\n+option ruby_namespace = \"Google::Cloud::PubSub::V1\";","path":"google/pubsub/v1/pubsub.proto","position":4,"original_position":4,"commit_id":"4dc955c4a728122051afd2cf813b222369b8b636","original_commit_id":"4dc955c4a728122051afd2cf813b222369b8b636","user":{"login":"andreamlin","id":4016818,"node_id":"MDQ6VXNlcjQwMTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"body":"[drive-by question]\r\nWhat is the rationale for including the `ruby_namespace` now, if the v1 proto library has already been generated and in existence for a while?","created_at":"2018-12-07T17:31:42Z","updated_at":"2018-12-07T17:31:42Z","html_url":"https://github.com/googleapis/googleapis/pull/532#discussion_r239886358","pull_request_url":"https://api.github.com/repos/googleapis/googleapis/pulls/532","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/googleapis/pulls/comments/239886358"},"html":{"href":"https://github.com/googleapis/googleapis/pull/532#discussion_r239886358"},"pull_request":{"href":"https://api.github.com/repos/googleapis/googleapis/pulls/532"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/googleapis/pulls/532","id":236727501,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzI3NTAx","html_url":"https://github.com/googleapis/googleapis/pull/532","diff_url":"https://github.com/googleapis/googleapis/pull/532.diff","patch_url":"https://github.com/googleapis/googleapis/pull/532.patch","issue_url":"https://api.github.com/repos/googleapis/googleapis/issues/532","number":532,"state":"open","locked":false,"title":"Add ruby_namespace option to PubSub","user":{"login":"blowmage","id":730,"node_id":"MDQ6VXNlcjczMA==","avatar_url":"https://avatars0.githubusercontent.com/u/730?v=4","gravatar_id":"","url":"https://api.github.com/users/blowmage","html_url":"https://github.com/blowmage","followers_url":"https://api.github.com/users/blowmage/followers","following_url":"https://api.github.com/users/blowmage/following{/other_user}","gists_url":"https://api.github.com/users/blowmage/gists{/gist_id}","starred_url":"https://api.github.com/users/blowmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowmage/subscriptions","organizations_url":"https://api.github.com/users/blowmage/orgs","repos_url":"https://api.github.com/users/blowmage/repos","events_url":"https://api.github.com/users/blowmage/events{/privacy}","received_events_url":"https://api.github.com/users/blowmage/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-07T01:29:21Z","updated_at":"2018-12-07T17:31:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22462bca9761e5d2087f812888bff0eef9056d89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/googleapis/pulls/532/commits","review_comments_url":"https://api.github.com/repos/googleapis/googleapis/pulls/532/comments","review_comment_url":"https://api.github.com/repos/googleapis/googleapis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/googleapis/issues/532/comments","statuses_url":"https://api.github.com/repos/googleapis/googleapis/statuses/4dc955c4a728122051afd2cf813b222369b8b636","head":{"label":"blowmage:ruby-pub_sub","ref":"ruby-pub_sub","sha":"4dc955c4a728122051afd2cf813b222369b8b636","user":{"login":"blowmage","id":730,"node_id":"MDQ6VXNlcjczMA==","avatar_url":"https://avatars0.githubusercontent.com/u/730?v=4","gravatar_id":"","url":"https://api.github.com/users/blowmage","html_url":"https://github.com/blowmage","followers_url":"https://api.github.com/users/blowmage/followers","following_url":"https://api.github.com/users/blowmage/following{/other_user}","gists_url":"https://api.github.com/users/blowmage/gists{/gist_id}","starred_url":"https://api.github.com/users/blowmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowmage/subscriptions","organizations_url":"https://api.github.com/users/blowmage/orgs","repos_url":"https://api.github.com/users/blowmage/repos","events_url":"https://api.github.com/users/blowmage/events{/privacy}","received_events_url":"https://api.github.com/users/blowmage/received_events","type":"User","site_admin":false},"repo":{"id":160753401,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3NTM0MDE=","name":"googleapis","full_name":"blowmage/googleapis","private":false,"owner":{"login":"blowmage","id":730,"node_id":"MDQ6VXNlcjczMA==","avatar_url":"https://avatars0.githubusercontent.com/u/730?v=4","gravatar_id":"","url":"https://api.github.com/users/blowmage","html_url":"https://github.com/blowmage","followers_url":"https://api.github.com/users/blowmage/followers","following_url":"https://api.github.com/users/blowmage/following{/other_user}","gists_url":"https://api.github.com/users/blowmage/gists{/gist_id}","starred_url":"https://api.github.com/users/blowmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowmage/subscriptions","organizations_url":"https://api.github.com/users/blowmage/orgs","repos_url":"https://api.github.com/users/blowmage/repos","events_url":"https://api.github.com/users/blowmage/events{/privacy}","received_events_url":"https://api.github.com/users/blowmage/received_events","type":"User","site_admin":false},"html_url":"https://github.com/blowmage/googleapis","description":"Public interface definitions of Google APIs.","fork":true,"url":"https://api.github.com/repos/blowmage/googleapis","forks_url":"https://api.github.com/repos/blowmage/googleapis/forks","keys_url":"https://api.github.com/repos/blowmage/googleapis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blowmage/googleapis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blowmage/googleapis/teams","hooks_url":"https://api.github.com/repos/blowmage/googleapis/hooks","issue_events_url":"https://api.github.com/repos/blowmage/googleapis/issues/events{/number}","events_url":"https://api.github.com/repos/blowmage/googleapis/events","assignees_url":"https://api.github.com/repos/blowmage/googleapis/assignees{/user}","branches_url":"https://api.github.com/repos/blowmage/googleapis/branches{/branch}","tags_url":"https://api.github.com/repos/blowmage/googleapis/tags","blobs_url":"https://api.github.com/repos/blowmage/googleapis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blowmage/googleapis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blowmage/googleapis/git/refs{/sha}","trees_url":"https://api.github.com/repos/blowmage/googleapis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blowmage/googleapis/statuses/{sha}","languages_url":"https://api.github.com/repos/blowmage/googleapis/languages","stargazers_url":"https://api.github.com/repos/blowmage/googleapis/stargazers","contributors_url":"https://api.github.com/repos/blowmage/googleapis/contributors","subscribers_url":"https://api.github.com/repos/blowmage/googleapis/subscribers","subscription_url":"https://api.github.com/repos/blowmage/googleapis/subscription","commits_url":"https://api.github.com/repos/blowmage/googleapis/commits{/sha}","git_commits_url":"https://api.github.com/repos/blowmage/googleapis/git/commits{/sha}","comments_url":"https://api.github.com/repos/blowmage/googleapis/comments{/number}","issue_comment_url":"https://api.github.com/repos/blowmage/googleapis/issues/comments{/number}","contents_url":"https://api.github.com/repos/blowmage/googleapis/contents/{+path}","compare_url":"https://api.github.com/repos/blowmage/googleapis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blowmage/googleapis/merges","archive_url":"https://api.github.com/repos/blowmage/googleapis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blowmage/googleapis/downloads","issues_url":"https://api.github.com/repos/blowmage/googleapis/issues{/number}","pulls_url":"https://api.github.com/repos/blowmage/googleapis/pulls{/number}","milestones_url":"https://api.github.com/repos/blowmage/googleapis/milestones{/number}","notifications_url":"https://api.github.com/repos/blowmage/googleapis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blowmage/googleapis/labels{/name}","releases_url":"https://api.github.com/repos/blowmage/googleapis/releases{/id}","deployments_url":"https://api.github.com/repos/blowmage/googleapis/deployments","created_at":"2018-12-07T01:20:29Z","updated_at":"2018-12-07T01:20:35Z","pushed_at":"2018-12-07T01:28:21Z","git_url":"git://github.com/blowmage/googleapis.git","ssh_url":"git@github.com:blowmage/googleapis.git","clone_url":"https://github.com/blowmage/googleapis.git","svn_url":"https://github.com/blowmage/googleapis","homepage":"","size":135289,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"200fbbe59cc7b0077ae525eb5f3d6420c0c53e61","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":32887098,"node_id":"MDEwOlJlcG9zaXRvcnkzMjg4NzA5OA==","name":"googleapis","full_name":"googleapis/googleapis","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/googleapis","description":"Public interface definitions of Google APIs.","fork":false,"url":"https://api.github.com/repos/googleapis/googleapis","forks_url":"https://api.github.com/repos/googleapis/googleapis/forks","keys_url":"https://api.github.com/repos/googleapis/googleapis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/googleapis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/googleapis/teams","hooks_url":"https://api.github.com/repos/googleapis/googleapis/hooks","issue_events_url":"https://api.github.com/repos/googleapis/googleapis/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/googleapis/events","assignees_url":"https://api.github.com/repos/googleapis/googleapis/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/googleapis/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/googleapis/tags","blobs_url":"https://api.github.com/repos/googleapis/googleapis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/googleapis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/googleapis/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/googleapis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/googleapis/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/googleapis/languages","stargazers_url":"https://api.github.com/repos/googleapis/googleapis/stargazers","contributors_url":"https://api.github.com/repos/googleapis/googleapis/contributors","subscribers_url":"https://api.github.com/repos/googleapis/googleapis/subscribers","subscription_url":"https://api.github.com/repos/googleapis/googleapis/subscription","commits_url":"https://api.github.com/repos/googleapis/googleapis/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/googleapis/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/googleapis/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/googleapis/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/googleapis/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/googleapis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/googleapis/merges","archive_url":"https://api.github.com/repos/googleapis/googleapis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/googleapis/downloads","issues_url":"https://api.github.com/repos/googleapis/googleapis/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/googleapis/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/googleapis/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/googleapis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/googleapis/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/googleapis/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/googleapis/deployments","created_at":"2015-03-25T19:47:34Z","updated_at":"2018-12-07T08:08:47Z","pushed_at":"2018-12-07T01:29:22Z","git_url":"git://github.com/googleapis/googleapis.git","ssh_url":"git@github.com:googleapis/googleapis.git","clone_url":"https://github.com/googleapis/googleapis.git","svn_url":"https://github.com/googleapis/googleapis","homepage":"","size":135281,"stargazers_count":1092,"watchers_count":1092,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":387,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":387,"open_issues":55,"watchers":1092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/googleapis/pulls/532"},"html":{"href":"https://github.com/googleapis/googleapis/pull/532"},"issue":{"href":"https://api.github.com/repos/googleapis/googleapis/issues/532"},"comments":{"href":"https://api.github.com/repos/googleapis/googleapis/issues/532/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/googleapis/pulls/532/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/googleapis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/googleapis/pulls/532/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/googleapis/statuses/4dc955c4a728122051afd2cf813b222369b8b636"}},"author_association":"NONE"}}
{"actor":{"display_login":"andreamlin"}}