{"action":"created","comment":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/185910836","pull_request_review_id":117394827,"id":185910836,"diff_hunk":"@@ -330,59 +400,207 @@ class SygusSymBreakNew\n \n   /** Get the canonical free variable for type tn */\n   TNode getFreeVar( TypeNode tn );\n+  /** get term order predicate\n+   *\n+   * Assuming that n1 and n2 are children of a commutative operator, this\n+   * returns a symmetry breaking predicate that can be instantiated for n1 and\n+   * n2 while preserving satisfiability. By default, this is the predicate\n+   *   ( DT_SIZE n1 ) >= ( DT_SIZE n2 )\n+   */\n   Node getTermOrderPredicate( Node n1, Node n2 );\n-private:\n- /**\n-  * Map from registered variables to whether they are a sygus enumerator.\n-  *\n-  * This should be user context-dependent if sygus is updated to work in\n-  * incremental mode.\n-  */\n- std::map<Node, bool> d_register_st;\n- void registerSizeTerm(Node e, std::vector<Node>& lemmas);\n- class SearchSizeInfo\n- {\n-  public:\n+\n+ private:\n+  /**\n+   * Map from registered variables to whether they are a sygus enumerator.\n+   *\n+   * This should be user context-dependent if sygus is updated to work in\n+   * incremental mode.\n+   */\n+  std::map<Node, bool> d_register_st;\n+  //----------------------search size information\n+  /**\n+   * Checks whether e is a sygus enumerator, that is, a term for which this\n+   * class will track size for.\n+   *\n+   * We associate each sygus enumerator e with a \"measure term\", which is used\n+   * for bounding the size of terms for the models of e. The measure term for a\n+   * sygus enumerator may e itself (if e has an active guard), or an arbitrary","path":"src/theory/datatypes/datatypes_sygus.h","position":152,"original_position":152,"commit_id":"6cdc5569c8de893074493e1bdffb56ae63107da8","original_commit_id":"6cdc5569c8de893074493e1bdffb56ae63107da8","user":{"login":"HanielB","id":2821688,"avatar_url":"https://avatars0.githubusercontent.com/u/2821688?v=4","gravatar_id":"","url":"https://api.github.com/users/HanielB","html_url":"https://github.com/HanielB","followers_url":"https://api.github.com/users/HanielB/followers","following_url":"https://api.github.com/users/HanielB/following{/other_user}","gists_url":"https://api.github.com/users/HanielB/gists{/gist_id}","starred_url":"https://api.github.com/users/HanielB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HanielB/subscriptions","organizations_url":"https://api.github.com/users/HanielB/orgs","repos_url":"https://api.github.com/users/HanielB/repos","events_url":"https://api.github.com/users/HanielB/events{/privacy}","received_events_url":"https://api.github.com/users/HanielB/received_events","type":"User","site_admin":false},"body":"may e --> may be e","created_at":"2018-05-03T19:24:56Z","updated_at":"2018-05-03T19:53:13Z","html_url":"https://github.com/CVC4/CVC4/pull/1818#discussion_r185910836","pull_request_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1818","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/185910836"},"html":{"href":"https://github.com/CVC4/CVC4/pull/1818#discussion_r185910836"},"pull_request":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1818"}}},"pull_request":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/1818","id":184404997,"html_url":"https://github.com/CVC4/CVC4/pull/1818","diff_url":"https://github.com/CVC4/CVC4/pull/1818.diff","patch_url":"https://github.com/CVC4/CVC4/pull/1818.patch","issue_url":"https://api.github.com/repos/CVC4/CVC4/issues/1818","number":1818,"state":"open","locked":false,"title":"Document datatypes sygus","user":{"login":"ajreynol","id":2973467,"avatar_url":"https://avatars0.githubusercontent.com/u/2973467?v=4","gravatar_id":"","url":"https://api.github.com/users/ajreynol","html_url":"https://github.com/ajreynol","followers_url":"https://api.github.com/users/ajreynol/followers","following_url":"https://api.github.com/users/ajreynol/following{/other_user}","gists_url":"https://api.github.com/users/ajreynol/gists{/gist_id}","starred_url":"https://api.github.com/users/ajreynol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajreynol/subscriptions","organizations_url":"https://api.github.com/users/ajreynol/orgs","repos_url":"https://api.github.com/users/ajreynol/repos","events_url":"https://api.github.com/users/ajreynol/events{/privacy}","received_events_url":"https://api.github.com/users/ajreynol/received_events","type":"User","site_admin":false},"body":"Fixes #1625.\r\n\r\nAlso removes various unused features.","created_at":"2018-04-26T17:01:30Z","updated_at":"2018-05-03T19:53:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"582e0da630f32fc1ad9f6d139db6a4787c067092","assignee":{"login":"HanielB","id":2821688,"avatar_url":"https://avatars0.githubusercontent.com/u/2821688?v=4","gravatar_id":"","url":"https://api.github.com/users/HanielB","html_url":"https://github.com/HanielB","followers_url":"https://api.github.com/users/HanielB/followers","following_url":"https://api.github.com/users/HanielB/following{/other_user}","gists_url":"https://api.github.com/users/HanielB/gists{/gist_id}","starred_url":"https://api.github.com/users/HanielB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HanielB/subscriptions","organizations_url":"https://api.github.com/users/HanielB/orgs","repos_url":"https://api.github.com/users/HanielB/repos","events_url":"https://api.github.com/users/HanielB/events{/privacy}","received_events_url":"https://api.github.com/users/HanielB/received_events","type":"User","site_admin":false},"assignees":[{"login":"HanielB","id":2821688,"avatar_url":"https://avatars0.githubusercontent.com/u/2821688?v=4","gravatar_id":"","url":"https://api.github.com/users/HanielB","html_url":"https://github.com/HanielB","followers_url":"https://api.github.com/users/HanielB/followers","following_url":"https://api.github.com/users/HanielB/following{/other_user}","gists_url":"https://api.github.com/users/HanielB/gists{/gist_id}","starred_url":"https://api.github.com/users/HanielB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HanielB/subscriptions","organizations_url":"https://api.github.com/users/HanielB/orgs","repos_url":"https://api.github.com/users/HanielB/repos","events_url":"https://api.github.com/users/HanielB/events{/privacy}","received_events_url":"https://api.github.com/users/HanielB/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":671892488,"url":"https://api.github.com/repos/CVC4/CVC4/labels/minor","name":"minor","color":"fef2c0","default":false},{"id":717338434,"url":"https://api.github.com/repos/CVC4/CVC4/labels/moderate","name":"moderate","color":"88ccf5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1818/commits","review_comments_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1818/comments","review_comment_url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CVC4/CVC4/issues/1818/comments","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/6cdc5569c8de893074493e1bdffb56ae63107da8","head":{"label":"ajreynol:docDtSygus","ref":"docDtSygus","sha":"6cdc5569c8de893074493e1bdffb56ae63107da8","user":{"login":"ajreynol","id":2973467,"avatar_url":"https://avatars0.githubusercontent.com/u/2973467?v=4","gravatar_id":"","url":"https://api.github.com/users/ajreynol","html_url":"https://github.com/ajreynol","followers_url":"https://api.github.com/users/ajreynol/followers","following_url":"https://api.github.com/users/ajreynol/following{/other_user}","gists_url":"https://api.github.com/users/ajreynol/gists{/gist_id}","starred_url":"https://api.github.com/users/ajreynol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajreynol/subscriptions","organizations_url":"https://api.github.com/users/ajreynol/orgs","repos_url":"https://api.github.com/users/ajreynol/repos","events_url":"https://api.github.com/users/ajreynol/events{/privacy}","received_events_url":"https://api.github.com/users/ajreynol/received_events","type":"User","site_admin":false},"repo":{"id":17024816,"name":"CVC4","full_name":"ajreynol/CVC4","owner":{"login":"ajreynol","id":2973467,"avatar_url":"https://avatars0.githubusercontent.com/u/2973467?v=4","gravatar_id":"","url":"https://api.github.com/users/ajreynol","html_url":"https://github.com/ajreynol","followers_url":"https://api.github.com/users/ajreynol/followers","following_url":"https://api.github.com/users/ajreynol/following{/other_user}","gists_url":"https://api.github.com/users/ajreynol/gists{/gist_id}","starred_url":"https://api.github.com/users/ajreynol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajreynol/subscriptions","organizations_url":"https://api.github.com/users/ajreynol/orgs","repos_url":"https://api.github.com/users/ajreynol/repos","events_url":"https://api.github.com/users/ajreynol/events{/privacy}","received_events_url":"https://api.github.com/users/ajreynol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajreynol/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":true,"url":"https://api.github.com/repos/ajreynol/CVC4","forks_url":"https://api.github.com/repos/ajreynol/CVC4/forks","keys_url":"https://api.github.com/repos/ajreynol/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajreynol/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajreynol/CVC4/teams","hooks_url":"https://api.github.com/repos/ajreynol/CVC4/hooks","issue_events_url":"https://api.github.com/repos/ajreynol/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/ajreynol/CVC4/events","assignees_url":"https://api.github.com/repos/ajreynol/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/ajreynol/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/ajreynol/CVC4/tags","blobs_url":"https://api.github.com/repos/ajreynol/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajreynol/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajreynol/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajreynol/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajreynol/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/ajreynol/CVC4/languages","stargazers_url":"https://api.github.com/repos/ajreynol/CVC4/stargazers","contributors_url":"https://api.github.com/repos/ajreynol/CVC4/contributors","subscribers_url":"https://api.github.com/repos/ajreynol/CVC4/subscribers","subscription_url":"https://api.github.com/repos/ajreynol/CVC4/subscription","commits_url":"https://api.github.com/repos/ajreynol/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajreynol/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajreynol/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajreynol/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajreynol/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/ajreynol/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajreynol/CVC4/merges","archive_url":"https://api.github.com/repos/ajreynol/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajreynol/CVC4/downloads","issues_url":"https://api.github.com/repos/ajreynol/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/ajreynol/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/ajreynol/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/ajreynol/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajreynol/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/ajreynol/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/ajreynol/CVC4/deployments","created_at":"2014-02-20T15:22:15Z","updated_at":"2018-05-03T12:54:50Z","pushed_at":"2018-05-03T19:24:45Z","git_url":"git://github.com/ajreynol/CVC4.git","ssh_url":"git@github.com:ajreynol/CVC4.git","clone_url":"https://github.com/ajreynol/CVC4.git","svn_url":"https://github.com/ajreynol/CVC4","homepage":null,"size":45455,"stargazers_count":0,"watchers_count":0,"language":"SMT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CVC4:master","ref":"master","sha":"68a994dbb7527b6f98975bbb776687413f23d451","user":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars0.githubusercontent.com/u/2973223?v=4","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"repo":{"id":7040894,"name":"CVC4","full_name":"CVC4/CVC4","owner":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars0.githubusercontent.com/u/2973223?v=4","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CVC4/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":false,"url":"https://api.github.com/repos/CVC4/CVC4","forks_url":"https://api.github.com/repos/CVC4/CVC4/forks","keys_url":"https://api.github.com/repos/CVC4/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CVC4/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CVC4/CVC4/teams","hooks_url":"https://api.github.com/repos/CVC4/CVC4/hooks","issue_events_url":"https://api.github.com/repos/CVC4/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/CVC4/CVC4/events","assignees_url":"https://api.github.com/repos/CVC4/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/CVC4/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/CVC4/CVC4/tags","blobs_url":"https://api.github.com/repos/CVC4/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CVC4/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CVC4/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/CVC4/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/CVC4/CVC4/languages","stargazers_url":"https://api.github.com/repos/CVC4/CVC4/stargazers","contributors_url":"https://api.github.com/repos/CVC4/CVC4/contributors","subscribers_url":"https://api.github.com/repos/CVC4/CVC4/subscribers","subscription_url":"https://api.github.com/repos/CVC4/CVC4/subscription","commits_url":"https://api.github.com/repos/CVC4/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/CVC4/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/CVC4/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/CVC4/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/CVC4/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/CVC4/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CVC4/CVC4/merges","archive_url":"https://api.github.com/repos/CVC4/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CVC4/CVC4/downloads","issues_url":"https://api.github.com/repos/CVC4/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/CVC4/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/CVC4/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/CVC4/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CVC4/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/CVC4/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/CVC4/CVC4/deployments","created_at":"2012-12-06T18:45:04Z","updated_at":"2018-05-03T19:23:54Z","pushed_at":"2018-05-03T19:23:49Z","git_url":"git://github.com/CVC4/CVC4.git","ssh_url":"git@github.com:CVC4/CVC4.git","clone_url":"https://github.com/CVC4/CVC4.git","svn_url":"https://github.com/CVC4/CVC4","homepage":null,"size":44053,"stargazers_count":193,"watchers_count":193,"language":"SMT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":81,"open_issues":204,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1818"},"html":{"href":"https://github.com/CVC4/CVC4/pull/1818"},"issue":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/1818"},"comments":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/1818/comments"},"review_comments":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1818/comments"},"review_comment":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1818/commits"},"statuses":{"href":"https://api.github.com/repos/CVC4/CVC4/statuses/6cdc5569c8de893074493e1bdffb56ae63107da8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"HanielB"}}