{"action":"created","issue":{"url":"https://api.github.com/repos/mami-project/pathspider/issues/234","repository_url":"https://api.github.com/repos/mami-project/pathspider","labels_url":"https://api.github.com/repos/mami-project/pathspider/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/mami-project/pathspider/issues/234/comments","events_url":"https://api.github.com/repos/mami-project/pathspider/issues/234/events","html_url":"https://github.com/mami-project/pathspider/issues/234","id":351632236,"node_id":"MDU6SXNzdWUzNTE2MzIyMzY=","number":234,"title":"Pathspider not terminating with dscp","user":{"login":"nstudach","id":19391990,"node_id":"MDQ6VXNlcjE5MzkxOTkw","avatar_url":"https://avatars3.githubusercontent.com/u/19391990?v=4","gravatar_id":"","url":"https://api.github.com/users/nstudach","html_url":"https://github.com/nstudach","followers_url":"https://api.github.com/users/nstudach/followers","following_url":"https://api.github.com/users/nstudach/following{/other_user}","gists_url":"https://api.github.com/users/nstudach/gists{/gist_id}","starred_url":"https://api.github.com/users/nstudach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nstudach/subscriptions","organizations_url":"https://api.github.com/users/nstudach/orgs","repos_url":"https://api.github.com/users/nstudach/repos","events_url":"https://api.github.com/users/nstudach/events{/privacy}","received_events_url":"https://api.github.com/users/nstudach/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-17T15:10:02Z","updated_at":"2018-08-18T17:54:04Z","closed_at":"2018-08-17T22:49:10Z","author_association":"NONE","body":"Pathspider will not terminate on its own.\r\nworks with: `pspdr measure -i eth0 --input webtest.ndjson --output sgGxn-ams3-ecn -w 20 ecn`\r\n**Reproducing error:**\r\n1: `pspdr measure -i eth0 --input webtest.ndjson --output NHJ6q-location:fra1-dscp -w 20 dscp`\r\nalso with:\r\n2. `pspdr measure -i eth0 --input webtest.ndjson --output NHJ6q-fra1-dscp -w 20 dscp`\r\n\r\n**Terminal output:\r\n1:**\r\n```\r\nERROR:pathspider:exception occurred. terminating.\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 403, in exception_wrapper\r\n    target(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 410, in run_flow_enqueuer\r\n    f = self._next_flow()\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 320, in _next_flow\r\n    if not self._next_packet():\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 183, in _next_packet\r\n    keep_flow = keep_flow and fn(rec, self._pkt.ip6, rev=rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 102, in ip6\r\n    return self._dscp_extract(rec, ip, rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 112, in _dscp_extract\r\n    if ip.pkt_len == (ip.hdr_len + ip.tcp.doff) * 4: # No payload\r\nTypeError: unsupported operand type(s) for +: 'NoneType' and 'int'\r\nINFO:pathspider:terminating pathspider\r\nProcess observer:\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 403, in exception_wrapper\r\n    target(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 410, in run_flow_enqueuer\r\n    f = self._next_flow()\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 320, in _next_flow\r\n    if not self._next_packet():\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 183, in _next_packet\r\n    keep_flow = keep_flow and fn(rec, self._pkt.ip6, rev=rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 102, in ip6\r\n    return self._dscp_extract(rec, ip, rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 112, in _dscp_extract\r\n    if ip.pkt_len == (ip.hdr_len + ip.tcp.doff) * 4: # No payload\r\nTypeError: unsupported operand type(s) for +: 'NoneType' and 'int'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/usr/lib/python3.6/multiprocessing/process.py\", line 258, in _bootstrap\r\n    self.run()\r\n  File \"/usr/lib/python3.6/multiprocessing/process.py\", line 93, in run\r\n    self._target(*self._args, **self._kwargs)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 410, in exception_wrapper\r\n    self.terminate()\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 588, in terminate\r\n    self.merger_thread.join()\r\nAttributeError: 'NoneType' object has no attribute 'join'\r\n```\r\n**2:**\r\n```\r\nINFO:pathspider:activating spider...\r\nINFO:pathspider:starting pathspider\r\nINFO:pathspider:Creating observer\r\nERROR:pathspider:exception occurred. terminating.\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 403, in exception_wrapper\r\n    target(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 410, in run_flow_enqueuer\r\n    f = self._next_flow()\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 320, in _next_flow\r\n    if not self._next_packet():\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 183, in _next_packet\r\n    keep_flow = keep_flow and fn(rec, self._pkt.ip6, rev=rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 102, in ip6\r\n    return self._dscp_extract(rec, ip, rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 112, in _dscp_extract\r\n    if ip.pkt_len == (ip.hdr_len + ip.tcp.doff) * 4: # No payload\r\nTypeError: unsupported operand type(s) for +: 'NoneType' and 'int'\r\nINFO:pathspider:terminating pathspider\r\nProcess observer:\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 403, in exception_wrapper\r\n    target(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 410, in run_flow_enqueuer\r\n    f = self._next_flow()\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 320, in _next_flow\r\n    if not self._next_packet():\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/observer.py\", line 183, in _next_packet\r\n    keep_flow = keep_flow and fn(rec, self._pkt.ip6, rev=rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 102, in ip6\r\n    return self._dscp_extract(rec, ip, rev)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/chains/dscp.py\", line 112, in _dscp_extract\r\n    if ip.pkt_len == (ip.hdr_len + ip.tcp.doff) * 4: # No payload\r\nTypeError: unsupported operand type(s) for +: 'NoneType' and 'int'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/usr/lib/python3.6/multiprocessing/process.py\", line 258, in _bootstrap\r\n    self.run()\r\n  File \"/usr/lib/python3.6/multiprocessing/process.py\", line 93, in run\r\n    self._target(*self._args, **self._kwargs)\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 410, in exception_wrapper\r\n    self.terminate()\r\n  File \"/usr/local/lib/python3.6/dist-packages/pathspider-2.0.0.dev0-py3.6.egg/pathspider/base.py\", line 588, in terminate\r\n    self.merger_thread.join()\r\nAttributeError: 'NoneType' object has no attribute 'join'\r\nINFO:feeder:job_feeder: all jobs added, waiting for spider to finish\r\nINFO:pathspider:opening output file NHJ6q-fra1-dscp\r\nINFO:pathspider:beginning shutdown\r\n```"},"comment":{"url":"https://api.github.com/repos/mami-project/pathspider/issues/comments/414075461","html_url":"https://github.com/mami-project/pathspider/issues/234#issuecomment-414075461","issue_url":"https://api.github.com/repos/mami-project/pathspider/issues/234","id":414075461,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDA3NTQ2MQ==","user":{"login":"mirjak","id":8420764,"node_id":"MDQ6VXNlcjg0MjA3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8420764?v=4","gravatar_id":"","url":"https://api.github.com/users/mirjak","html_url":"https://github.com/mirjak","followers_url":"https://api.github.com/users/mirjak/followers","following_url":"https://api.github.com/users/mirjak/following{/other_user}","gists_url":"https://api.github.com/users/mirjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mirjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirjak/subscriptions","organizations_url":"https://api.github.com/users/mirjak/orgs","repos_url":"https://api.github.com/users/mirjak/repos","events_url":"https://api.github.com/users/mirjak/events{/privacy}","received_events_url":"https://api.github.com/users/mirjak/received_events","type":"User","site_admin":false},"created_at":"2018-08-18T17:54:04Z","updated_at":"2018-08-18T17:54:04Z","author_association":"CONTRIBUTOR","body":"Thanks! And sorry, I did this in a bit a rush yesterdays evening"}}
{"actor":{"display_login":"mirjak"}}