{"action":"created","comment":{"url":"https://api.github.com/repos/github/orchestrator-agent/pulls/comments/177996255","pull_request_review_id":107974475,"id":177996255,"diff_hunk":"@@ -60,21 +65,39 @@ case \"$1\" in\n     PID=$(cat $PIDFILE)\n     cd $DAEMON_PATH\n     if [ -f $PIDFILE ]; then\n-      kill -HUP $PID\n-      printf \"%s\\n\" \"Ok\"\n+      kill -TERM $PID\n       rm -f $PIDFILE\n+      # Wait for orchestrator to stop otherwise restart may fail.","path":"etc/init.d/orchestrator-agent.bash","position":20,"original_position":20,"commit_id":"46468cd55c02954e18217b8314f435198cb45310","original_commit_id":"46468cd55c02954e18217b8314f435198cb45310","user":{"login":"shlomi-noach","id":2607934,"avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":true},"body":"Change to \"Wait for orchestrator-agent to stop...\"","created_at":"2018-03-29T09:11:12Z","updated_at":"2018-03-29T09:15:54Z","html_url":"https://github.com/github/orchestrator-agent/pull/20#discussion_r177996255","pull_request_url":"https://api.github.com/repos/github/orchestrator-agent/pulls/20","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/github/orchestrator-agent/pulls/comments/177996255"},"html":{"href":"https://github.com/github/orchestrator-agent/pull/20#discussion_r177996255"},"pull_request":{"href":"https://api.github.com/repos/github/orchestrator-agent/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/github/orchestrator-agent/pulls/20","id":176478220,"html_url":"https://github.com/github/orchestrator-agent/pull/20","diff_url":"https://github.com/github/orchestrator-agent/pull/20.diff","patch_url":"https://github.com/github/orchestrator-agent/pull/20.patch","issue_url":"https://api.github.com/repos/github/orchestrator-agent/issues/20","number":20,"state":"open","locked":false,"title":"Improve orchestrator-agent for use xtrabackup command for data seeding between nodes","user":{"login":"Slach","id":105560,"avatar_url":"https://avatars3.githubusercontent.com/u/105560?v=4","gravatar_id":"","url":"https://api.github.com/users/Slach","html_url":"https://github.com/Slach","followers_url":"https://api.github.com/users/Slach/followers","following_url":"https://api.github.com/users/Slach/following{/other_user}","gists_url":"https://api.github.com/users/Slach/gists{/gist_id}","starred_url":"https://api.github.com/users/Slach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slach/subscriptions","organizations_url":"https://api.github.com/users/Slach/orgs","repos_url":"https://api.github.com/users/Slach/repos","events_url":"https://api.github.com/users/Slach/events{/privacy}","received_events_url":"https://api.github.com/users/Slach/received_events","type":"User","site_admin":false},"body":"* Сustomize orchestrator-agent config, adding several *Command parameters \r\n* add handle signal syscall.SIGHUP with config.Reload, and terminate with SIGTERM, SIGKILL\r\n* Improve init.d script for SIGHUP and reload support\r\n* extract SeedTransferPort from const to config\r\n","created_at":"2018-03-21T13:38:25Z","updated_at":"2018-03-29T09:15:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad161c6d8267a1cb06e18d84757dc952abb8f5bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/github/orchestrator-agent/pulls/20/commits","review_comments_url":"https://api.github.com/repos/github/orchestrator-agent/pulls/20/comments","review_comment_url":"https://api.github.com/repos/github/orchestrator-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/orchestrator-agent/issues/20/comments","statuses_url":"https://api.github.com/repos/github/orchestrator-agent/statuses/46468cd55c02954e18217b8314f435198cb45310","head":{"label":"Slach:reanimate_api","ref":"reanimate_api","sha":"46468cd55c02954e18217b8314f435198cb45310","user":{"login":"Slach","id":105560,"avatar_url":"https://avatars3.githubusercontent.com/u/105560?v=4","gravatar_id":"","url":"https://api.github.com/users/Slach","html_url":"https://github.com/Slach","followers_url":"https://api.github.com/users/Slach/followers","following_url":"https://api.github.com/users/Slach/following{/other_user}","gists_url":"https://api.github.com/users/Slach/gists{/gist_id}","starred_url":"https://api.github.com/users/Slach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slach/subscriptions","organizations_url":"https://api.github.com/users/Slach/orgs","repos_url":"https://api.github.com/users/Slach/repos","events_url":"https://api.github.com/users/Slach/events{/privacy}","received_events_url":"https://api.github.com/users/Slach/received_events","type":"User","site_admin":false},"repo":{"id":124831476,"name":"orchestrator-agent","full_name":"Slach/orchestrator-agent","owner":{"login":"Slach","id":105560,"avatar_url":"https://avatars3.githubusercontent.com/u/105560?v=4","gravatar_id":"","url":"https://api.github.com/users/Slach","html_url":"https://github.com/Slach","followers_url":"https://api.github.com/users/Slach/followers","following_url":"https://api.github.com/users/Slach/following{/other_user}","gists_url":"https://api.github.com/users/Slach/gists{/gist_id}","starred_url":"https://api.github.com/users/Slach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slach/subscriptions","organizations_url":"https://api.github.com/users/Slach/orgs","repos_url":"https://api.github.com/users/Slach/repos","events_url":"https://api.github.com/users/Slach/events{/privacy}","received_events_url":"https://api.github.com/users/Slach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Slach/orchestrator-agent","description":"MySQL replication topology manager - agent (daemon)","fork":true,"url":"https://api.github.com/repos/Slach/orchestrator-agent","forks_url":"https://api.github.com/repos/Slach/orchestrator-agent/forks","keys_url":"https://api.github.com/repos/Slach/orchestrator-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Slach/orchestrator-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Slach/orchestrator-agent/teams","hooks_url":"https://api.github.com/repos/Slach/orchestrator-agent/hooks","issue_events_url":"https://api.github.com/repos/Slach/orchestrator-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Slach/orchestrator-agent/events","assignees_url":"https://api.github.com/repos/Slach/orchestrator-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Slach/orchestrator-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Slach/orchestrator-agent/tags","blobs_url":"https://api.github.com/repos/Slach/orchestrator-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Slach/orchestrator-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Slach/orchestrator-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Slach/orchestrator-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Slach/orchestrator-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Slach/orchestrator-agent/languages","stargazers_url":"https://api.github.com/repos/Slach/orchestrator-agent/stargazers","contributors_url":"https://api.github.com/repos/Slach/orchestrator-agent/contributors","subscribers_url":"https://api.github.com/repos/Slach/orchestrator-agent/subscribers","subscription_url":"https://api.github.com/repos/Slach/orchestrator-agent/subscription","commits_url":"https://api.github.com/repos/Slach/orchestrator-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Slach/orchestrator-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Slach/orchestrator-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Slach/orchestrator-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Slach/orchestrator-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Slach/orchestrator-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Slach/orchestrator-agent/merges","archive_url":"https://api.github.com/repos/Slach/orchestrator-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Slach/orchestrator-agent/downloads","issues_url":"https://api.github.com/repos/Slach/orchestrator-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Slach/orchestrator-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Slach/orchestrator-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Slach/orchestrator-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Slach/orchestrator-agent/labels{/name}","releases_url":"https://api.github.com/repos/Slach/orchestrator-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Slach/orchestrator-agent/deployments","created_at":"2018-03-12T03:57:10Z","updated_at":"2018-03-12T03:57:12Z","pushed_at":"2018-03-21T13:05:48Z","git_url":"git://github.com/Slach/orchestrator-agent.git","ssh_url":"git@github.com:Slach/orchestrator-agent.git","clone_url":"https://github.com/Slach/orchestrator-agent.git","svn_url":"https://github.com/Slach/orchestrator-agent","homepage":null,"size":254,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"28b02997aee16ec181650ff8d89e9f772d379c7c","user":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":70903180,"name":"orchestrator-agent","full_name":"github/orchestrator-agent","owner":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/orchestrator-agent","description":"MySQL replication topology manager - agent (daemon)","fork":true,"url":"https://api.github.com/repos/github/orchestrator-agent","forks_url":"https://api.github.com/repos/github/orchestrator-agent/forks","keys_url":"https://api.github.com/repos/github/orchestrator-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/orchestrator-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/orchestrator-agent/teams","hooks_url":"https://api.github.com/repos/github/orchestrator-agent/hooks","issue_events_url":"https://api.github.com/repos/github/orchestrator-agent/issues/events{/number}","events_url":"https://api.github.com/repos/github/orchestrator-agent/events","assignees_url":"https://api.github.com/repos/github/orchestrator-agent/assignees{/user}","branches_url":"https://api.github.com/repos/github/orchestrator-agent/branches{/branch}","tags_url":"https://api.github.com/repos/github/orchestrator-agent/tags","blobs_url":"https://api.github.com/repos/github/orchestrator-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/orchestrator-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/orchestrator-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/orchestrator-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/orchestrator-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/github/orchestrator-agent/languages","stargazers_url":"https://api.github.com/repos/github/orchestrator-agent/stargazers","contributors_url":"https://api.github.com/repos/github/orchestrator-agent/contributors","subscribers_url":"https://api.github.com/repos/github/orchestrator-agent/subscribers","subscription_url":"https://api.github.com/repos/github/orchestrator-agent/subscription","commits_url":"https://api.github.com/repos/github/orchestrator-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/orchestrator-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/orchestrator-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/orchestrator-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/orchestrator-agent/contents/{+path}","compare_url":"https://api.github.com/repos/github/orchestrator-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/orchestrator-agent/merges","archive_url":"https://api.github.com/repos/github/orchestrator-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/orchestrator-agent/downloads","issues_url":"https://api.github.com/repos/github/orchestrator-agent/issues{/number}","pulls_url":"https://api.github.com/repos/github/orchestrator-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/github/orchestrator-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/github/orchestrator-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/orchestrator-agent/labels{/name}","releases_url":"https://api.github.com/repos/github/orchestrator-agent/releases{/id}","deployments_url":"https://api.github.com/repos/github/orchestrator-agent/deployments","created_at":"2016-10-14T11:15:59Z","updated_at":"2018-03-20T19:30:54Z","pushed_at":"2018-03-21T13:38:25Z","git_url":"git://github.com/github/orchestrator-agent.git","ssh_url":"git@github.com:github/orchestrator-agent.git","clone_url":"https://github.com/github/orchestrator-agent.git","svn_url":"https://github.com/github/orchestrator-agent","homepage":null,"size":242,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":5,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/orchestrator-agent/pulls/20"},"html":{"href":"https://github.com/github/orchestrator-agent/pull/20"},"issue":{"href":"https://api.github.com/repos/github/orchestrator-agent/issues/20"},"comments":{"href":"https://api.github.com/repos/github/orchestrator-agent/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/github/orchestrator-agent/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/github/orchestrator-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/orchestrator-agent/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/github/orchestrator-agent/statuses/46468cd55c02954e18217b8314f435198cb45310"}},"author_association":"NONE"}}
{"actor":{"display_login":"shlomi-noach"}}