{"action":"created","comment":{"url":"https://api.github.com/repos/urbit/arvo/pulls/comments/224946606","pull_request_review_id":164447836,"id":224946606,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk0NjYwNg==","diff_hunk":"@@ -694,13 +691,6 @@\n   ::  (emit /rekey %next sec:ex:(pit:nu:crub 512 (shaz (mix %next (shaz eny)))))\n   ~&  %rekey-stub  .","path":"lib/hood/womb.hoon","position":28,"original_position":28,"commit_id":"c0c256e93e1b8f373aedd6ca2f10b2162d3d9e0d","original_commit_id":"c0c256e93e1b8f373aedd6ca2f10b2162d3d9e0d","user":{"login":"joemfb","id":702304,"node_id":"MDQ6VXNlcjcwMjMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/702304?v=4","gravatar_id":"","url":"https://api.github.com/users/joemfb","html_url":"https://github.com/joemfb","followers_url":"https://api.github.com/users/joemfb/followers","following_url":"https://api.github.com/users/joemfb/following{/other_user}","gists_url":"https://api.github.com/users/joemfb/gists{/gist_id}","starred_url":"https://api.github.com/users/joemfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemfb/subscriptions","organizations_url":"https://api.github.com/users/joemfb/orgs","repos_url":"https://api.github.com/users/joemfb/repos","events_url":"https://api.github.com/users/joemfb/events{/privacy}","received_events_url":"https://api.github.com/users/joemfb/received_events","type":"User","site_admin":false},"body":"That seems plausible to me, but I don't know for sure. Who could make that call?","created_at":"2018-10-13T02:10:24Z","updated_at":"2018-10-13T02:10:24Z","html_url":"https://github.com/urbit/arvo/pull/858#discussion_r224946606","pull_request_url":"https://api.github.com/repos/urbit/arvo/pulls/858","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/urbit/arvo/pulls/comments/224946606"},"html":{"href":"https://github.com/urbit/arvo/pull/858#discussion_r224946606"},"pull_request":{"href":"https://api.github.com/repos/urbit/arvo/pulls/858"}},"in_reply_to_id":224931078},"pull_request":{"url":"https://api.github.com/repos/urbit/arvo/pulls/858","id":222550552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTUwNTUy","html_url":"https://github.com/urbit/arvo/pull/858","diff_url":"https://github.com/urbit/arvo/pull/858.diff","patch_url":"https://github.com/urbit/arvo/pull/858.patch","issue_url":"https://api.github.com/repos/urbit/arvo/issues/858","number":858,"state":"open","locked":false,"title":"ethereum-integrated boot and networking","user":{"login":"joemfb","id":702304,"node_id":"MDQ6VXNlcjcwMjMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/702304?v=4","gravatar_id":"","url":"https://api.github.com/users/joemfb","html_url":"https://github.com/joemfb","followers_url":"https://api.github.com/users/joemfb/followers","following_url":"https://api.github.com/users/joemfb/following{/other_user}","gists_url":"https://api.github.com/users/joemfb/gists{/gist_id}","starred_url":"https://api.github.com/users/joemfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemfb/subscriptions","organizations_url":"https://api.github.com/users/joemfb/orgs","repos_url":"https://api.github.com/users/joemfb/repos","events_url":"https://api.github.com/users/joemfb/events{/privacy}","received_events_url":"https://api.github.com/users/joemfb/received_events","type":"User","site_admin":false},"body":"This PR includes a variety of changes and new features to support our ethereum integration.\r\n\r\n- pre-boot validation\r\n\r\nAlready added in #844, refined and commented here.\r\n\r\n- new single-homed boot\r\n\r\nWhile we still boot through %dill, the boot event is now routed to %jael instead of %ames. `%dawn` is a validated, live, ethereum-integrated boot - including our private keys, galaxy table, ames domains, and sponsor. `%fake` does what is says on the can. Everything related to the old multi-homed comet-upgrading boot process has been removed.\r\n\r\nPrivate key files for this boot can be generated with `+key` or `+moon` (but note that moons are not yet wired into the boot process).\r\n\r\nArvo is practically single-homed (it will always only have one identity), but formally still multi-homed, as the old Arvo/vane storage structures and interfaces are still present.\r\n\r\n- %ames/%jael integration\r\n\r\nThe old inline PKI in ames has been removed (with allowances for moons and comets), and all PKI updates are sent from %jael to %ames. %jael itself gets these updates by subscribing to its sponsor, or directly polling an ethereum node.\r\n\r\nThis changes the %ames packet acceptance criteria in some subtle ways, but the gist of the typical path is that %ames drops packets from unfamiliar ships until it receives the appropriate keys from %jael.\r\n\r\n- individual continuity breaches\r\n\r\nSunken ships are no more! Or rather, they can be *discontinuously* re-keyed in the Ships contract. When %jael learns of such an occurrence, it sends a `%sunk` event to all (relevant) vanes, which can in turn purge state and subscriptions related to the ship in question. The most important such vane is %ames, which must reset sequence numbers to be able to communicate with a breached ship. The other vanes currently treat this event as a no-op. Thanks @ixv!\r\n\r\nThere's much more to discuss and document in these changes, and all will be revealed in due time. Work on the remaining features mentioned above is ongoing.\r\n\r\nThis PR is the dual of urbit/urbit#1037, and should be merged at the same time.","created_at":"2018-10-12T18:31:51Z","updated_at":"2018-10-13T02:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7d6c54cf26a2bf7e1c056e95f4c6346654d6ff7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cgyarvin","id":193025,"node_id":"MDQ6VXNlcjE5MzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/193025?v=4","gravatar_id":"","url":"https://api.github.com/users/cgyarvin","html_url":"https://github.com/cgyarvin","followers_url":"https://api.github.com/users/cgyarvin/followers","following_url":"https://api.github.com/users/cgyarvin/following{/other_user}","gists_url":"https://api.github.com/users/cgyarvin/gists{/gist_id}","starred_url":"https://api.github.com/users/cgyarvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgyarvin/subscriptions","organizations_url":"https://api.github.com/users/cgyarvin/orgs","repos_url":"https://api.github.com/users/cgyarvin/repos","events_url":"https://api.github.com/users/cgyarvin/events{/privacy}","received_events_url":"https://api.github.com/users/cgyarvin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urbit/arvo/pulls/858/commits","review_comments_url":"https://api.github.com/repos/urbit/arvo/pulls/858/comments","review_comment_url":"https://api.github.com/repos/urbit/arvo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urbit/arvo/issues/858/comments","statuses_url":"https://api.github.com/repos/urbit/arvo/statuses/c0c256e93e1b8f373aedd6ca2f10b2162d3d9e0d","head":{"label":"urbit:ames-eth-keys","ref":"ames-eth-keys","sha":"c0c256e93e1b8f373aedd6ca2f10b2162d3d9e0d","user":{"login":"urbit","id":5237680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMzc2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5237680?v=4","gravatar_id":"","url":"https://api.github.com/users/urbit","html_url":"https://github.com/urbit","followers_url":"https://api.github.com/users/urbit/followers","following_url":"https://api.github.com/users/urbit/following{/other_user}","gists_url":"https://api.github.com/users/urbit/gists{/gist_id}","starred_url":"https://api.github.com/users/urbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbit/subscriptions","organizations_url":"https://api.github.com/users/urbit/orgs","repos_url":"https://api.github.com/users/urbit/repos","events_url":"https://api.github.com/users/urbit/events{/privacy}","received_events_url":"https://api.github.com/users/urbit/received_events","type":"Organization","site_admin":false},"repo":{"id":51740301,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc0MDMwMQ==","name":"arvo","full_name":"urbit/arvo","private":false,"owner":{"login":"urbit","id":5237680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMzc2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5237680?v=4","gravatar_id":"","url":"https://api.github.com/users/urbit","html_url":"https://github.com/urbit","followers_url":"https://api.github.com/users/urbit/followers","following_url":"https://api.github.com/users/urbit/following{/other_user}","gists_url":"https://api.github.com/users/urbit/gists{/gist_id}","starred_url":"https://api.github.com/users/urbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbit/subscriptions","organizations_url":"https://api.github.com/users/urbit/orgs","repos_url":"https://api.github.com/users/urbit/repos","events_url":"https://api.github.com/users/urbit/events{/privacy}","received_events_url":"https://api.github.com/users/urbit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/urbit/arvo","description":"The Urbit operating system","fork":false,"url":"https://api.github.com/repos/urbit/arvo","forks_url":"https://api.github.com/repos/urbit/arvo/forks","keys_url":"https://api.github.com/repos/urbit/arvo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbit/arvo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbit/arvo/teams","hooks_url":"https://api.github.com/repos/urbit/arvo/hooks","issue_events_url":"https://api.github.com/repos/urbit/arvo/issues/events{/number}","events_url":"https://api.github.com/repos/urbit/arvo/events","assignees_url":"https://api.github.com/repos/urbit/arvo/assignees{/user}","branches_url":"https://api.github.com/repos/urbit/arvo/branches{/branch}","tags_url":"https://api.github.com/repos/urbit/arvo/tags","blobs_url":"https://api.github.com/repos/urbit/arvo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbit/arvo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbit/arvo/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbit/arvo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbit/arvo/statuses/{sha}","languages_url":"https://api.github.com/repos/urbit/arvo/languages","stargazers_url":"https://api.github.com/repos/urbit/arvo/stargazers","contributors_url":"https://api.github.com/repos/urbit/arvo/contributors","subscribers_url":"https://api.github.com/repos/urbit/arvo/subscribers","subscription_url":"https://api.github.com/repos/urbit/arvo/subscription","commits_url":"https://api.github.com/repos/urbit/arvo/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbit/arvo/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbit/arvo/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbit/arvo/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbit/arvo/contents/{+path}","compare_url":"https://api.github.com/repos/urbit/arvo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbit/arvo/merges","archive_url":"https://api.github.com/repos/urbit/arvo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbit/arvo/downloads","issues_url":"https://api.github.com/repos/urbit/arvo/issues{/number}","pulls_url":"https://api.github.com/repos/urbit/arvo/pulls{/number}","milestones_url":"https://api.github.com/repos/urbit/arvo/milestones{/number}","notifications_url":"https://api.github.com/repos/urbit/arvo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbit/arvo/labels{/name}","releases_url":"https://api.github.com/repos/urbit/arvo/releases{/id}","deployments_url":"https://api.github.com/repos/urbit/arvo/deployments","created_at":"2016-02-15T08:13:53Z","updated_at":"2018-10-08T21:48:45Z","pushed_at":"2018-10-12T23:15:53Z","git_url":"git://github.com/urbit/arvo.git","ssh_url":"git@github.com:urbit/arvo.git","clone_url":"https://github.com/urbit/arvo.git","svn_url":"https://github.com/urbit/arvo","homepage":"https://github.com/urbit/urbit","size":29659,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":210,"watchers":69,"default_branch":"master"}},"base":{"label":"urbit:release-candidate","ref":"release-candidate","sha":"7b5291f166832cadc96a3ce227a184ce7d9f1bfe","user":{"login":"urbit","id":5237680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMzc2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5237680?v=4","gravatar_id":"","url":"https://api.github.com/users/urbit","html_url":"https://github.com/urbit","followers_url":"https://api.github.com/users/urbit/followers","following_url":"https://api.github.com/users/urbit/following{/other_user}","gists_url":"https://api.github.com/users/urbit/gists{/gist_id}","starred_url":"https://api.github.com/users/urbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbit/subscriptions","organizations_url":"https://api.github.com/users/urbit/orgs","repos_url":"https://api.github.com/users/urbit/repos","events_url":"https://api.github.com/users/urbit/events{/privacy}","received_events_url":"https://api.github.com/users/urbit/received_events","type":"Organization","site_admin":false},"repo":{"id":51740301,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc0MDMwMQ==","name":"arvo","full_name":"urbit/arvo","private":false,"owner":{"login":"urbit","id":5237680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMzc2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5237680?v=4","gravatar_id":"","url":"https://api.github.com/users/urbit","html_url":"https://github.com/urbit","followers_url":"https://api.github.com/users/urbit/followers","following_url":"https://api.github.com/users/urbit/following{/other_user}","gists_url":"https://api.github.com/users/urbit/gists{/gist_id}","starred_url":"https://api.github.com/users/urbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbit/subscriptions","organizations_url":"https://api.github.com/users/urbit/orgs","repos_url":"https://api.github.com/users/urbit/repos","events_url":"https://api.github.com/users/urbit/events{/privacy}","received_events_url":"https://api.github.com/users/urbit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/urbit/arvo","description":"The Urbit operating system","fork":false,"url":"https://api.github.com/repos/urbit/arvo","forks_url":"https://api.github.com/repos/urbit/arvo/forks","keys_url":"https://api.github.com/repos/urbit/arvo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbit/arvo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbit/arvo/teams","hooks_url":"https://api.github.com/repos/urbit/arvo/hooks","issue_events_url":"https://api.github.com/repos/urbit/arvo/issues/events{/number}","events_url":"https://api.github.com/repos/urbit/arvo/events","assignees_url":"https://api.github.com/repos/urbit/arvo/assignees{/user}","branches_url":"https://api.github.com/repos/urbit/arvo/branches{/branch}","tags_url":"https://api.github.com/repos/urbit/arvo/tags","blobs_url":"https://api.github.com/repos/urbit/arvo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbit/arvo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbit/arvo/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbit/arvo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbit/arvo/statuses/{sha}","languages_url":"https://api.github.com/repos/urbit/arvo/languages","stargazers_url":"https://api.github.com/repos/urbit/arvo/stargazers","contributors_url":"https://api.github.com/repos/urbit/arvo/contributors","subscribers_url":"https://api.github.com/repos/urbit/arvo/subscribers","subscription_url":"https://api.github.com/repos/urbit/arvo/subscription","commits_url":"https://api.github.com/repos/urbit/arvo/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbit/arvo/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbit/arvo/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbit/arvo/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbit/arvo/contents/{+path}","compare_url":"https://api.github.com/repos/urbit/arvo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbit/arvo/merges","archive_url":"https://api.github.com/repos/urbit/arvo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbit/arvo/downloads","issues_url":"https://api.github.com/repos/urbit/arvo/issues{/number}","pulls_url":"https://api.github.com/repos/urbit/arvo/pulls{/number}","milestones_url":"https://api.github.com/repos/urbit/arvo/milestones{/number}","notifications_url":"https://api.github.com/repos/urbit/arvo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbit/arvo/labels{/name}","releases_url":"https://api.github.com/repos/urbit/arvo/releases{/id}","deployments_url":"https://api.github.com/repos/urbit/arvo/deployments","created_at":"2016-02-15T08:13:53Z","updated_at":"2018-10-08T21:48:45Z","pushed_at":"2018-10-12T23:15:53Z","git_url":"git://github.com/urbit/arvo.git","ssh_url":"git@github.com:urbit/arvo.git","clone_url":"https://github.com/urbit/arvo.git","svn_url":"https://github.com/urbit/arvo","homepage":"https://github.com/urbit/urbit","size":29659,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":210,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urbit/arvo/pulls/858"},"html":{"href":"https://github.com/urbit/arvo/pull/858"},"issue":{"href":"https://api.github.com/repos/urbit/arvo/issues/858"},"comments":{"href":"https://api.github.com/repos/urbit/arvo/issues/858/comments"},"review_comments":{"href":"https://api.github.com/repos/urbit/arvo/pulls/858/comments"},"review_comment":{"href":"https://api.github.com/repos/urbit/arvo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urbit/arvo/pulls/858/commits"},"statuses":{"href":"https://api.github.com/repos/urbit/arvo/statuses/c0c256e93e1b8f373aedd6ca2f10b2162d3d9e0d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joemfb"}}