{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/comments/231437086","pull_request_review_id":172405732,"id":231437086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQzNzA4Ng==","diff_hunk":"@@ -31,16 +31,16 @@ - (void)tearDown {\n }\n \n - (void)testRegisterLogger {\n-    if(@available(iOS 10.0, macOS 10.12, tvOS 10.0, watchOS 3.0, *)) {\n-        DDOSLogger *logger = [DDOSLogger sharedInstance];\n+    if (@available(iOS 10.0, macOS 10.12, tvOS 10.0, watchOS 3.0, *)) {\n+        __auto_type logger = [DDOSLogger new];\n         [DDLog addLogger:logger];\n-        XCTAssertEqualObjects(logger.loggerName, @\"cocoa.lumberjack.osLogger\");\n-        XCTAssertEqualObjects(logger, DDLog.allLoggers[0]);\n+        XCTAssertEqualObjects(logger.loggerName, [DDOSLogger new].loggerName);","path":"Tests/Tests/DDOSLoggingTests.m","position":11,"original_position":11,"commit_id":"925e26518a00ecdca560b1d9f2770816be75ca06","original_commit_id":"925e26518a00ecdca560b1d9f2770816be75ca06","user":{"login":"ffried","id":1689782,"node_id":"MDQ6VXNlcjE2ODk3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1689782?v=4","gravatar_id":"","url":"https://api.github.com/users/ffried","html_url":"https://github.com/ffried","followers_url":"https://api.github.com/users/ffried/followers","following_url":"https://api.github.com/users/ffried/following{/other_user}","gists_url":"https://api.github.com/users/ffried/gists{/gist_id}","starred_url":"https://api.github.com/users/ffried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffried/subscriptions","organizations_url":"https://api.github.com/users/ffried/orgs","repos_url":"https://api.github.com/users/ffried/repos","events_url":"https://api.github.com/users/ffried/events{/privacy}","received_events_url":"https://api.github.com/users/ffried/received_events","type":"User","site_admin":false},"body":"> `// checks that copy-pasted arbitrary string is equal to current logger name. wtf?`\r\n\r\nNope. It checks that the logger name is what it should be. Imagine if someone used the library and checked for this constant in code to identify an `OSLogger`. Now if by some accident the name is changed, and this test would not exist, all tests would be green. But the code of said user of the library would suddenly start to fail.\r\nThis test makes sure this does not happen. And yes, constants are sometimes duplicated in production code and test code... 🤷‍♂️ ","created_at":"2018-11-07T09:41:49Z","updated_at":"2018-11-07T09:41:49Z","html_url":"https://github.com/CocoaLumberjack/CocoaLumberjack/pull/982#discussion_r231437086","pull_request_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/comments/231437086"},"html":{"href":"https://github.com/CocoaLumberjack/CocoaLumberjack/pull/982#discussion_r231437086"},"pull_request":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982"}},"in_reply_to_id":231431917},"pull_request":{"url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982","id":228962815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTYyODE1","html_url":"https://github.com/CocoaLumberjack/CocoaLumberjack/pull/982","diff_url":"https://github.com/CocoaLumberjack/CocoaLumberjack/pull/982.diff","patch_url":"https://github.com/CocoaLumberjack/CocoaLumberjack/pull/982.patch","issue_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/issues/982","number":982,"state":"open","locked":false,"title":"Cleanup after 981","user":{"login":"lolgear","id":2188522,"node_id":"MDQ6VXNlcjIxODg1MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2188522?v=4","gravatar_id":"","url":"https://api.github.com/users/lolgear","html_url":"https://github.com/lolgear","followers_url":"https://api.github.com/users/lolgear/followers","following_url":"https://api.github.com/users/lolgear/following{/other_user}","gists_url":"https://api.github.com/users/lolgear/gists{/gist_id}","starred_url":"https://api.github.com/users/lolgear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolgear/subscriptions","organizations_url":"https://api.github.com/users/lolgear/orgs","repos_url":"https://api.github.com/users/lolgear/repos","events_url":"https://api.github.com/users/lolgear/events{/privacy}","received_events_url":"https://api.github.com/users/lolgear/received_events","type":"User","site_admin":false},"body":"### New Pull Request Checklist\r\n\r\n* [x] I have read and understood the [CONTRIBUTING guide](https://github.com/CocoaLumberjack/CocoaLumberjack/blob/master/.github/CONTRIBUTING.md)\r\n* [x] I have read the [Documentation](http://cocoadocs.org/docsets/CocoaLumberjack/)\r\n* [x] I have searched for a similar pull request in the [project](https://github.com/CocoaLumberjack/CocoaLumberjack/pulls) and found none\r\n\r\n* [x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)\r\n* [x] I have added the required tests to prove the fix/feature I am adding\r\n* [x] I have updated the documentation (if necessary)\r\n* [x] I have run the tests and they pass\r\n* [x] I have run the lint and it passes (`pod lib lint`)\r\n\r\nThis merge request fixes / refers to the following issues: ...\r\n\r\n### Pull Request Description\r\n\r\nCleanup after #981 \r\n\r\n","created_at":"2018-11-07T09:21:22Z","updated_at":"2018-11-07T09:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1c99db8eca844452566a72d146a6a17781c3800","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982/commits","review_comments_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982/comments","review_comment_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/issues/982/comments","statuses_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/statuses/925e26518a00ecdca560b1d9f2770816be75ca06","head":{"label":"lolgear:cleanup_after_981","ref":"cleanup_after_981","sha":"925e26518a00ecdca560b1d9f2770816be75ca06","user":{"login":"lolgear","id":2188522,"node_id":"MDQ6VXNlcjIxODg1MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2188522?v=4","gravatar_id":"","url":"https://api.github.com/users/lolgear","html_url":"https://github.com/lolgear","followers_url":"https://api.github.com/users/lolgear/followers","following_url":"https://api.github.com/users/lolgear/following{/other_user}","gists_url":"https://api.github.com/users/lolgear/gists{/gist_id}","starred_url":"https://api.github.com/users/lolgear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolgear/subscriptions","organizations_url":"https://api.github.com/users/lolgear/orgs","repos_url":"https://api.github.com/users/lolgear/repos","events_url":"https://api.github.com/users/lolgear/events{/privacy}","received_events_url":"https://api.github.com/users/lolgear/received_events","type":"User","site_admin":false},"repo":{"id":144448319,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0NDgzMTk=","name":"CocoaLumberjack","full_name":"lolgear/CocoaLumberjack","private":false,"owner":{"login":"lolgear","id":2188522,"node_id":"MDQ6VXNlcjIxODg1MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2188522?v=4","gravatar_id":"","url":"https://api.github.com/users/lolgear","html_url":"https://github.com/lolgear","followers_url":"https://api.github.com/users/lolgear/followers","following_url":"https://api.github.com/users/lolgear/following{/other_user}","gists_url":"https://api.github.com/users/lolgear/gists{/gist_id}","starred_url":"https://api.github.com/users/lolgear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolgear/subscriptions","organizations_url":"https://api.github.com/users/lolgear/orgs","repos_url":"https://api.github.com/users/lolgear/repos","events_url":"https://api.github.com/users/lolgear/events{/privacy}","received_events_url":"https://api.github.com/users/lolgear/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lolgear/CocoaLumberjack","description":"A fast & simple, yet powerful & flexible logging framework for Mac and iOS","fork":true,"url":"https://api.github.com/repos/lolgear/CocoaLumberjack","forks_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/forks","keys_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/teams","hooks_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/hooks","issue_events_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/issues/events{/number}","events_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/events","assignees_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/assignees{/user}","branches_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/branches{/branch}","tags_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/tags","blobs_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/git/refs{/sha}","trees_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/statuses/{sha}","languages_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/languages","stargazers_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/stargazers","contributors_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/contributors","subscribers_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/subscribers","subscription_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/subscription","commits_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/commits{/sha}","git_commits_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/git/commits{/sha}","comments_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/comments{/number}","issue_comment_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/issues/comments{/number}","contents_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/contents/{+path}","compare_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/merges","archive_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/downloads","issues_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/issues{/number}","pulls_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/pulls{/number}","milestones_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/milestones{/number}","notifications_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/labels{/name}","releases_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/releases{/id}","deployments_url":"https://api.github.com/repos/lolgear/CocoaLumberjack/deployments","created_at":"2018-08-12T07:54:40Z","updated_at":"2018-08-12T07:54:42Z","pushed_at":"2018-11-07T09:20:14Z","git_url":"git://github.com/lolgear/CocoaLumberjack.git","ssh_url":"git@github.com:lolgear/CocoaLumberjack.git","clone_url":"https://github.com/lolgear/CocoaLumberjack.git","svn_url":"https://github.com/lolgear/CocoaLumberjack","homepage":"","size":4374,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaLumberjack:master","ref":"master","sha":"1f97c2c11b5917aaa5215dec97572d4825e439ab","user":{"login":"CocoaLumberjack","id":6108054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMDgwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6108054?v=4","gravatar_id":"","url":"https://api.github.com/users/CocoaLumberjack","html_url":"https://github.com/CocoaLumberjack","followers_url":"https://api.github.com/users/CocoaLumberjack/followers","following_url":"https://api.github.com/users/CocoaLumberjack/following{/other_user}","gists_url":"https://api.github.com/users/CocoaLumberjack/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaLumberjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaLumberjack/subscriptions","organizations_url":"https://api.github.com/users/CocoaLumberjack/orgs","repos_url":"https://api.github.com/users/CocoaLumberjack/repos","events_url":"https://api.github.com/users/CocoaLumberjack/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaLumberjack/received_events","type":"Organization","site_admin":false},"repo":{"id":1549138,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ5MTM4","name":"CocoaLumberjack","full_name":"CocoaLumberjack/CocoaLumberjack","private":false,"owner":{"login":"CocoaLumberjack","id":6108054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMDgwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6108054?v=4","gravatar_id":"","url":"https://api.github.com/users/CocoaLumberjack","html_url":"https://github.com/CocoaLumberjack","followers_url":"https://api.github.com/users/CocoaLumberjack/followers","following_url":"https://api.github.com/users/CocoaLumberjack/following{/other_user}","gists_url":"https://api.github.com/users/CocoaLumberjack/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaLumberjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaLumberjack/subscriptions","organizations_url":"https://api.github.com/users/CocoaLumberjack/orgs","repos_url":"https://api.github.com/users/CocoaLumberjack/repos","events_url":"https://api.github.com/users/CocoaLumberjack/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaLumberjack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CocoaLumberjack/CocoaLumberjack","description":"A fast & simple, yet powerful & flexible logging framework for Mac and iOS","fork":false,"url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack","forks_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/forks","keys_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/teams","hooks_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/hooks","issue_events_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/events","assignees_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/tags","blobs_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/languages","stargazers_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/stargazers","contributors_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/contributors","subscribers_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/subscribers","subscription_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/subscription","commits_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/merges","archive_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/downloads","issues_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/labels{/name}","releases_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/releases{/id}","deployments_url":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/deployments","created_at":"2011-03-31T02:38:39Z","updated_at":"2018-11-07T09:26:22Z","pushed_at":"2018-11-07T09:21:22Z","git_url":"git://github.com/CocoaLumberjack/CocoaLumberjack.git","ssh_url":"git@github.com:CocoaLumberjack/CocoaLumberjack.git","clone_url":"https://github.com/CocoaLumberjack/CocoaLumberjack.git","svn_url":"https://github.com/CocoaLumberjack/CocoaLumberjack","homepage":"https://cocoalumberjack.github.io/","size":4172,"stargazers_count":10720,"watchers_count":10720,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1896,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1896,"open_issues":26,"watchers":10720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982"},"html":{"href":"https://github.com/CocoaLumberjack/CocoaLumberjack/pull/982"},"issue":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/issues/982"},"comments":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/issues/982/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/pulls/982/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaLumberjack/CocoaLumberjack/statuses/925e26518a00ecdca560b1d9f2770816be75ca06"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ffried"}}