{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/7029","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/7029/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/7029/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/7029/events","html_url":"https://github.com/status-im/status-react/pull/7029","id":388243500,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTUzMjI4","number":7029,"title":"No logs in desktop release","user":{"login":"vkjr","id":5786310,"node_id":"MDQ6VXNlcjU3ODYzMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5786310?v=4","gravatar_id":"","url":"https://api.github.com/users/vkjr","html_url":"https://github.com/vkjr","followers_url":"https://api.github.com/users/vkjr/followers","following_url":"https://api.github.com/users/vkjr/following{/other_user}","gists_url":"https://api.github.com/users/vkjr/gists{/gist_id}","starred_url":"https://api.github.com/users/vkjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkjr/subscriptions","organizations_url":"https://api.github.com/users/vkjr/orgs","repos_url":"https://api.github.com/users/vkjr/repos","events_url":"https://api.github.com/users/vkjr/events{/privacy}","received_events_url":"https://api.github.com/users/vkjr/received_events","type":"User","site_admin":false},"labels":[{"id":782926578,"node_id":"MDU6TGFiZWw3ODI5MjY1Nzg=","url":"https://api.github.com/repos/status-im/status-react/labels/desktop","name":"desktop","color":"fcb099","default":false},{"id":1153770135,"node_id":"MDU6TGFiZWwxMTUzNzcwMTM1","url":"https://api.github.com/repos/status-im/status-react/labels/desktop-release","name":"desktop-release","color":"581c9e","default":false}],"state":"open","locked":false,"assignee":{"login":"churik","id":4557972,"node_id":"MDQ6VXNlcjQ1NTc5NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4557972?v=4","gravatar_id":"","url":"https://api.github.com/users/churik","html_url":"https://github.com/churik","followers_url":"https://api.github.com/users/churik/followers","following_url":"https://api.github.com/users/churik/following{/other_user}","gists_url":"https://api.github.com/users/churik/gists{/gist_id}","starred_url":"https://api.github.com/users/churik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/churik/subscriptions","organizations_url":"https://api.github.com/users/churik/orgs","repos_url":"https://api.github.com/users/churik/repos","events_url":"https://api.github.com/users/churik/events{/privacy}","received_events_url":"https://api.github.com/users/churik/received_events","type":"User","site_admin":false},"assignees":[{"login":"churik","id":4557972,"node_id":"MDQ6VXNlcjQ1NTc5NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4557972?v=4","gravatar_id":"","url":"https://api.github.com/users/churik","html_url":"https://github.com/churik","followers_url":"https://api.github.com/users/churik/followers","following_url":"https://api.github.com/users/churik/following{/other_user}","gists_url":"https://api.github.com/users/churik/gists{/gist_id}","starred_url":"https://api.github.com/users/churik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/churik/subscriptions","organizations_url":"https://api.github.com/users/churik/orgs","repos_url":"https://api.github.com/users/churik/repos","events_url":"https://api.github.com/users/churik/events{/privacy}","received_events_url":"https://api.github.com/users/churik/received_events","type":"User","site_admin":false},{"login":"vkjr","id":5786310,"node_id":"MDQ6VXNlcjU3ODYzMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5786310?v=4","gravatar_id":"","url":"https://api.github.com/users/vkjr","html_url":"https://github.com/vkjr","followers_url":"https://api.github.com/users/vkjr/followers","following_url":"https://api.github.com/users/vkjr/following{/other_user}","gists_url":"https://api.github.com/users/vkjr/gists{/gist_id}","starred_url":"https://api.github.com/users/vkjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkjr/subscriptions","organizations_url":"https://api.github.com/users/vkjr/orgs","repos_url":"https://api.github.com/users/vkjr/repos","events_url":"https://api.github.com/users/vkjr/events{/privacy}","received_events_url":"https://api.github.com/users/vkjr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2018-12-06T14:41:50Z","updated_at":"2018-12-12T11:05:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/7029","html_url":"https://github.com/status-im/status-react/pull/7029","diff_url":"https://github.com/status-im/status-react/pull/7029.diff","patch_url":"https://github.com/status-im/status-react/pull/7029.patch"},"body":"fixes #6569\r\n\r\n### Summary:\r\n\r\nFlag added to build system to disable logs in desktop release build.\r\nBy default no records will appear in Status.log when app started/used/finished.\r\n\r\nTo enable logs for specific application areas: \r\n1. open terminal\r\n\r\n2. set environment variable:\r\n```sh\r\nexport QT_LOGGING_RULES=\"VIEWMANAGER=false;NETWORKING=true\"\r\n```\r\nList of all existing areas can be found here - https://github.com/status-im/status-react/pull/7029/files#diff-b3598ffec8b87686b94e17539c68ea4aR262\r\n\r\n3. Start app: `open Status.app`\r\n\r\n### Testing notes (optional):\r\nThese changes impact only release build. So instead of taking binaries from PR, please take them from this build - \r\nhttps://ci.status.im/job/status-react/job/release/job/release%252Ftest-desktop-nologs-remove-later2/\r\nIt has the same changes but build for release\r\n\r\n#### Platforms (optional)\r\n- macOS\r\n- Linux\r\n- Windows\r\n\r\n<!-- (Specify if some specific areas has to be tested, for example 1-1 chats) -->\r\n#### Areas that maybe impacted (optional)\r\nOnly console logging impacted\r\n\r\n<!-- (Specify exact steps to test if there are such) -->\r\n### Steps to test:\r\nSee steps in Summary section\r\n\r\n<!-- (PRs will only be accepted if squashed into single commit.) -->\r\n\r\nstatus: ready\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/446549170","html_url":"https://github.com/status-im/status-react/pull/7029#issuecomment-446549170","issue_url":"https://api.github.com/repos/status-im/status-react/issues/7029","id":446549170,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjU0OTE3MA==","user":{"login":"vkjr","id":5786310,"node_id":"MDQ6VXNlcjU3ODYzMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5786310?v=4","gravatar_id":"","url":"https://api.github.com/users/vkjr","html_url":"https://github.com/vkjr","followers_url":"https://api.github.com/users/vkjr/followers","following_url":"https://api.github.com/users/vkjr/following{/other_user}","gists_url":"https://api.github.com/users/vkjr/gists{/gist_id}","starred_url":"https://api.github.com/users/vkjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkjr/subscriptions","organizations_url":"https://api.github.com/users/vkjr/orgs","repos_url":"https://api.github.com/users/vkjr/repos","events_url":"https://api.github.com/users/vkjr/events{/privacy}","received_events_url":"https://api.github.com/users/vkjr/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T11:05:57Z","updated_at":"2018-12-12T11:05:57Z","author_association":"MEMBER","body":"@churik, build is not yet fully completed, but build artefacts are ready and can be downloaded for desktop platforms - https://ci.status.im/job/status-react/job/release/job/release%252Ftest-desktop-nologs-remove-later2/"}}
{"actor":{"display_login":"vkjr"}}