{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/118","repository_url":"https://api.github.com/repos/zooniverse/front-end-monorepo","labels_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/118/comments","events_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/118/events","html_url":"https://github.com/zooniverse/front-end-monorepo/issues/118","id":350358573,"node_id":"MDU6SXNzdWUzNTAzNTg1NzM=","number":118,"title":"Snapshot tests can fail if there are any leftover changes in compiled grommet theme","user":{"login":"rogerhutchings","id":2725841,"node_id":"MDQ6VXNlcjI3MjU4NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2725841?v=4","gravatar_id":"","url":"https://api.github.com/users/rogerhutchings","html_url":"https://github.com/rogerhutchings","followers_url":"https://api.github.com/users/rogerhutchings/followers","following_url":"https://api.github.com/users/rogerhutchings/following{/other_user}","gists_url":"https://api.github.com/users/rogerhutchings/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerhutchings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerhutchings/subscriptions","organizations_url":"https://api.github.com/users/rogerhutchings/orgs","repos_url":"https://api.github.com/users/rogerhutchings/repos","events_url":"https://api.github.com/users/rogerhutchings/events{/privacy}","received_events_url":"https://api.github.com/users/rogerhutchings/received_events","type":"User","site_admin":false},"labels":[{"id":903182904,"node_id":"MDU6TGFiZWw5MDMxODI5MDQ=","url":"https://api.github.com/repos/zooniverse/front-end-monorepo/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-14T09:55:39Z","updated_at":"2018-08-14T14:36:45Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Package**\r\n\r\n`lib-react-components`\r\n\r\n**Feature or Issue Description**\r\n\r\nWhen I was reviewing #105, I found that the snapshot tests were initially failing. I discovered that it was because I'd compiled a version of the grommet theme with some additional stuff for modals, and it was causing a mismatch between the tested component and snapshot. There was no _actual_ discrepancy, it was just some additional styles I'd added for modals, but enough to cause the test to fail.\r\n\r\nUsing the source of the grommet theme would solve this issue, and save a compilation step in a separate package, but without knowing more about how snapshots work at the moment I'm not sure if this is a good idea or not."},"comment":{"url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/comments/412894483","html_url":"https://github.com/zooniverse/front-end-monorepo/issues/118#issuecomment-412894483","issue_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/118","id":412894483,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjg5NDQ4Mw==","user":{"login":"srallen","id":5016731,"node_id":"MDQ6VXNlcjUwMTY3MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/5016731?v=4","gravatar_id":"","url":"https://api.github.com/users/srallen","html_url":"https://github.com/srallen","followers_url":"https://api.github.com/users/srallen/followers","following_url":"https://api.github.com/users/srallen/following{/other_user}","gists_url":"https://api.github.com/users/srallen/gists{/gist_id}","starred_url":"https://api.github.com/users/srallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srallen/subscriptions","organizations_url":"https://api.github.com/users/srallen/orgs","repos_url":"https://api.github.com/users/srallen/repos","events_url":"https://api.github.com/users/srallen/events{/privacy}","received_events_url":"https://api.github.com/users/srallen/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T14:36:45Z","updated_at":"2018-08-14T14:36:45Z","author_association":"MEMBER","body":"A slightly different issue that I also want to comment here: \r\n\r\nThe snapshot files shouldn't end up in the library's compiled files, but they are because the repo is still using a simple npm script setup with the babel CLI. I'll have to see if there's a way to tell the babel CLI to exclude certain file types. If it can't, then we'll have to switch to a more robust webpack setup. "}}
{"actor":{"display_login":"srallen"}}