{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/libpod/pulls/comments/183425316","pull_request_review_id":114420780,"id":183425316,"diff_hunk":"@@ -964,18 +973,18 @@ func (c *Container) generateSpec(ctx context.Context) (*spec.Spec, error) {\n \t\t\treturn nil, errors.Wrapf(ErrCtrStateInvalid, \"container %s must be mounted in order to add additional groups\", c.ID())\n \t\t}\n \t\tfor _, group := range c.config.Groups {\n-\t\t\t_, gid, err := chrootuser.GetUser(c.state.Mountpoint, strconv.Itoa(int(g.Spec().Process.User.UID))+\":\"+group)\n+\t\t\tgid, err := chrootuser.GetGroup(c.state.Mountpoint, group)\n \t\t\tif err != nil {\n \t\t\t\treturn nil, err\n \t\t\t}\n-\t\t\tg.AddProcessAdditionalGid(uint32(gid))\n+\t\t\tg.AddProcessAdditionalGid(gid)\n \t\t}\n \t}\n \n \t// Look up and add groups the user belongs to\n \tgroups, err := chrootuser.GetAdditionalGroupsForUser(c.state.Mountpoint, uint64(g.Spec().Process.User.UID))\n \tif err != nil {\n-\t\treturn nil, err\n+\t\tlogrus.Debugf(\"user %q doesn't belong to any additional groups: %v\", c.config.User, err)","path":"libpod/container_internal.go","position":43,"original_position":44,"commit_id":"3aa5f77c6db80de8b8c32a935fb48dcbc60bedaf","original_commit_id":"5292b4d2d0c2df76209d6565be5725170681c5b9","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"That's a really bad error. Can we improve the chrootuser package to get us a better one?","created_at":"2018-04-23T14:55:32Z","updated_at":"2018-04-23T14:55:32Z","html_url":"https://github.com/projectatomic/libpod/pull/652#discussion_r183425316","pull_request_url":"https://api.github.com/repos/projectatomic/libpod/pulls/652","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/comments/183425316"},"html":{"href":"https://github.com/projectatomic/libpod/pull/652#discussion_r183425316"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/652"}},"in_reply_to_id":183415838},"pull_request":{"url":"https://api.github.com/repos/projectatomic/libpod/pulls/652","id":183130272,"html_url":"https://github.com/projectatomic/libpod/pull/652","diff_url":"https://github.com/projectatomic/libpod/pull/652.diff","patch_url":"https://github.com/projectatomic/libpod/pull/652.patch","issue_url":"https://api.github.com/repos/projectatomic/libpod/issues/652","number":652,"state":"open","locked":false,"title":"Modify --user flag for podman create and run","user":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"body":"If an integer is passed into the --user flag, i.e --user=1234\r\ndon't look up the user in /etc/passwd, just assign the integer as the uid.\r\n\r\nFixes https://github.com/projectatomic/libpod/issues/631\r\n\r\nSigned-off-by: umohnani8 <umohnani@redhat.com>","created_at":"2018-04-20T17:54:59Z","updated_at":"2018-04-23T14:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dfaa171673fe40a66c0a0654de6d57dca6b78f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/libpod/pulls/652/commits","review_comments_url":"https://api.github.com/repos/projectatomic/libpod/pulls/652/comments","review_comment_url":"https://api.github.com/repos/projectatomic/libpod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/libpod/issues/652/comments","statuses_url":"https://api.github.com/repos/projectatomic/libpod/statuses/3aa5f77c6db80de8b8c32a935fb48dcbc60bedaf","head":{"label":"umohnani8:user","ref":"user","sha":"3aa5f77c6db80de8b8c32a935fb48dcbc60bedaf","user":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"repo":{"id":109307694,"name":"libpod","full_name":"umohnani8/libpod","owner":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/umohnani8/libpod","description":"libpod is a library used to create container pods.","fork":true,"url":"https://api.github.com/repos/umohnani8/libpod","forks_url":"https://api.github.com/repos/umohnani8/libpod/forks","keys_url":"https://api.github.com/repos/umohnani8/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umohnani8/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umohnani8/libpod/teams","hooks_url":"https://api.github.com/repos/umohnani8/libpod/hooks","issue_events_url":"https://api.github.com/repos/umohnani8/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/umohnani8/libpod/events","assignees_url":"https://api.github.com/repos/umohnani8/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/umohnani8/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/umohnani8/libpod/tags","blobs_url":"https://api.github.com/repos/umohnani8/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umohnani8/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umohnani8/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/umohnani8/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umohnani8/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/umohnani8/libpod/languages","stargazers_url":"https://api.github.com/repos/umohnani8/libpod/stargazers","contributors_url":"https://api.github.com/repos/umohnani8/libpod/contributors","subscribers_url":"https://api.github.com/repos/umohnani8/libpod/subscribers","subscription_url":"https://api.github.com/repos/umohnani8/libpod/subscription","commits_url":"https://api.github.com/repos/umohnani8/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/umohnani8/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/umohnani8/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/umohnani8/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/umohnani8/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/umohnani8/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umohnani8/libpod/merges","archive_url":"https://api.github.com/repos/umohnani8/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umohnani8/libpod/downloads","issues_url":"https://api.github.com/repos/umohnani8/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/umohnani8/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/umohnani8/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/umohnani8/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umohnani8/libpod/labels{/name}","releases_url":"https://api.github.com/repos/umohnani8/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/umohnani8/libpod/deployments","created_at":"2017-11-02T19:09:24Z","updated_at":"2017-11-02T19:09:26Z","pushed_at":"2018-04-23T14:55:14Z","git_url":"git://github.com/umohnani8/libpod.git","ssh_url":"git@github.com:umohnani8/libpod.git","clone_url":"https://github.com/umohnani8/libpod.git","svn_url":"https://github.com/umohnani8/libpod","homepage":null,"size":10676,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"8493dba23c73617d9529b7ca13b400d50ac6f455","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":109145553,"name":"libpod","full_name":"projectatomic/libpod","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/libpod","description":"libpod is a library used to create container pods.","fork":false,"url":"https://api.github.com/repos/projectatomic/libpod","forks_url":"https://api.github.com/repos/projectatomic/libpod/forks","keys_url":"https://api.github.com/repos/projectatomic/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/libpod/teams","hooks_url":"https://api.github.com/repos/projectatomic/libpod/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/libpod/events","assignees_url":"https://api.github.com/repos/projectatomic/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/libpod/tags","blobs_url":"https://api.github.com/repos/projectatomic/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/libpod/languages","stargazers_url":"https://api.github.com/repos/projectatomic/libpod/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/libpod/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/libpod/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/libpod/subscription","commits_url":"https://api.github.com/repos/projectatomic/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/libpod/merges","archive_url":"https://api.github.com/repos/projectatomic/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/libpod/downloads","issues_url":"https://api.github.com/repos/projectatomic/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/libpod/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/libpod/deployments","created_at":"2017-11-01T15:01:27Z","updated_at":"2018-04-23T14:51:34Z","pushed_at":"2018-04-23T14:55:15Z","git_url":"git://github.com/projectatomic/libpod.git","ssh_url":"git@github.com:projectatomic/libpod.git","clone_url":"https://github.com/projectatomic/libpod.git","svn_url":"https://github.com/projectatomic/libpod","homepage":null,"size":10662,"stargazers_count":92,"watchers_count":92,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":39,"open_issues":57,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/652"},"html":{"href":"https://github.com/projectatomic/libpod/pull/652"},"issue":{"href":"https://api.github.com/repos/projectatomic/libpod/issues/652"},"comments":{"href":"https://api.github.com/repos/projectatomic/libpod/issues/652/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/652/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/652/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/libpod/statuses/3aa5f77c6db80de8b8c32a935fb48dcbc60bedaf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mheon"}}