{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/comments/167389554","pull_request_review_id":95612950,"id":167389554,"diff_hunk":"@@ -45,19 +41,29 @@ contributors: Jordan Harband\n \n <ins class=\"block\">\n <emu-clause id=\"sec-matchalliterator\" aoid=\"MatchAllIterator\">\n-\t<h1>MatchAllIterator ( _R_, _O_ )</h1>\n+\t<h1>MatchAllIterator ( _regexp_, _O_ )</h1>\n \n \t<p>The abstract operation _MatchAllIterator_ performs the following steps:</p>\n \t<emu-alg>\n-\t\t1. If ? IsRegExp(_R_) is not *true*, throw a *TypeError* exception.\n+\t\t1. Perform ! RequireObjectCoercible(_regexp_).\n+\t\t1. If ? IsRegExp(_regexp_) is `true`, then\n+\t\t\t1. Let _R_ be _regexp_.\n+\t\t\t1. Let _C_ be ? SpeciesConstructor(_R_, %RegExp%).\n+\t\t\t1. Let _flags_ be ? ToString(? Get(_R_, `\"flags\"`)).\n+\t\t\t1. Let _matcher_ be ? Construct(_C_, &laquo; _R_, _flags_ &raquo;).","path":"spec.emu","position":43,"original_position":33,"commit_id":"4f46f31216710f365371c7ea14d229348b79f9f9","original_commit_id":"a51eb22d1190c3555cf79d9833e599f52c7c10fb","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars1.githubusercontent.com/u/45469?v=4","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"The retrieved flags are derived from checking each of the relevant properties: https://tc39.github.io/ecma262/#sec-get-regexp.prototype.flags","created_at":"2018-02-10T04:59:09Z","updated_at":"2018-02-10T04:59:09Z","html_url":"https://github.com/tc39/proposal-string-matchall/pull/33#discussion_r167389554","pull_request_url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/comments/167389554"},"html":{"href":"https://github.com/tc39/proposal-string-matchall/pull/33#discussion_r167389554"},"pull_request":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33"}},"in_reply_to_id":166352803},"pull_request":{"url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33","id":166696617,"html_url":"https://github.com/tc39/proposal-string-matchall/pull/33","diff_url":"https://github.com/tc39/proposal-string-matchall/pull/33.diff","patch_url":"https://github.com/tc39/proposal-string-matchall/pull/33.patch","issue_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/33","number":33,"state":"open","locked":false,"title":"Normative: when `regexp` arg is a string, minimize observable operations","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars1.githubusercontent.com/u/45469?v=4","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Per #32.\r\n\r\ncc @anba","created_at":"2018-02-02T01:26:21Z","updated_at":"2018-02-10T04:59:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"537ad025d101b214d16b4ccd66db3059c3ac8d8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33/commits","review_comments_url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33/comments","review_comment_url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/33/comments","statuses_url":"https://api.github.com/repos/tc39/proposal-string-matchall/statuses/4f46f31216710f365371c7ea14d229348b79f9f9","head":{"label":"tc39:less_observability","ref":"less_observability","sha":"4f46f31216710f365371c7ea14d229348b79f9f9","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":39852046,"name":"proposal-string-matchall","full_name":"tc39/proposal-string-matchall","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/proposal-string-matchall","description":"ES Proposal, specs, tests, reference implementation, and polyfill/shim for String.prototype.matchAll","fork":false,"url":"https://api.github.com/repos/tc39/proposal-string-matchall","forks_url":"https://api.github.com/repos/tc39/proposal-string-matchall/forks","keys_url":"https://api.github.com/repos/tc39/proposal-string-matchall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/proposal-string-matchall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/proposal-string-matchall/teams","hooks_url":"https://api.github.com/repos/tc39/proposal-string-matchall/hooks","issue_events_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/proposal-string-matchall/events","assignees_url":"https://api.github.com/repos/tc39/proposal-string-matchall/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/proposal-string-matchall/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/proposal-string-matchall/tags","blobs_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/proposal-string-matchall/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/proposal-string-matchall/languages","stargazers_url":"https://api.github.com/repos/tc39/proposal-string-matchall/stargazers","contributors_url":"https://api.github.com/repos/tc39/proposal-string-matchall/contributors","subscribers_url":"https://api.github.com/repos/tc39/proposal-string-matchall/subscribers","subscription_url":"https://api.github.com/repos/tc39/proposal-string-matchall/subscription","commits_url":"https://api.github.com/repos/tc39/proposal-string-matchall/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/proposal-string-matchall/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/proposal-string-matchall/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/proposal-string-matchall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/proposal-string-matchall/merges","archive_url":"https://api.github.com/repos/tc39/proposal-string-matchall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/proposal-string-matchall/downloads","issues_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/proposal-string-matchall/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/proposal-string-matchall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/proposal-string-matchall/labels{/name}","releases_url":"https://api.github.com/repos/tc39/proposal-string-matchall/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/proposal-string-matchall/deployments","created_at":"2015-07-28T18:52:03Z","updated_at":"2018-02-03T19:08:17Z","pushed_at":"2018-02-07T08:23:09Z","git_url":"git://github.com/tc39/proposal-string-matchall.git","ssh_url":"git@github.com:tc39/proposal-string-matchall.git","clone_url":"https://github.com/tc39/proposal-string-matchall.git","svn_url":"https://github.com/tc39/proposal-string-matchall","homepage":"https://tc39.github.io/proposal-string-matchall/","size":153,"stargazers_count":58,"watchers_count":58,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":58,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"078e448a886c7f7f87ece0ecc493dc50f468be79","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":39852046,"name":"proposal-string-matchall","full_name":"tc39/proposal-string-matchall","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/proposal-string-matchall","description":"ES Proposal, specs, tests, reference implementation, and polyfill/shim for String.prototype.matchAll","fork":false,"url":"https://api.github.com/repos/tc39/proposal-string-matchall","forks_url":"https://api.github.com/repos/tc39/proposal-string-matchall/forks","keys_url":"https://api.github.com/repos/tc39/proposal-string-matchall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/proposal-string-matchall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/proposal-string-matchall/teams","hooks_url":"https://api.github.com/repos/tc39/proposal-string-matchall/hooks","issue_events_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/proposal-string-matchall/events","assignees_url":"https://api.github.com/repos/tc39/proposal-string-matchall/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/proposal-string-matchall/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/proposal-string-matchall/tags","blobs_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/proposal-string-matchall/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/proposal-string-matchall/languages","stargazers_url":"https://api.github.com/repos/tc39/proposal-string-matchall/stargazers","contributors_url":"https://api.github.com/repos/tc39/proposal-string-matchall/contributors","subscribers_url":"https://api.github.com/repos/tc39/proposal-string-matchall/subscribers","subscription_url":"https://api.github.com/repos/tc39/proposal-string-matchall/subscription","commits_url":"https://api.github.com/repos/tc39/proposal-string-matchall/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/proposal-string-matchall/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/proposal-string-matchall/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/proposal-string-matchall/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/proposal-string-matchall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/proposal-string-matchall/merges","archive_url":"https://api.github.com/repos/tc39/proposal-string-matchall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/proposal-string-matchall/downloads","issues_url":"https://api.github.com/repos/tc39/proposal-string-matchall/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/proposal-string-matchall/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/proposal-string-matchall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/proposal-string-matchall/labels{/name}","releases_url":"https://api.github.com/repos/tc39/proposal-string-matchall/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/proposal-string-matchall/deployments","created_at":"2015-07-28T18:52:03Z","updated_at":"2018-02-03T19:08:17Z","pushed_at":"2018-02-07T08:23:09Z","git_url":"git://github.com/tc39/proposal-string-matchall.git","ssh_url":"git@github.com:tc39/proposal-string-matchall.git","clone_url":"https://github.com/tc39/proposal-string-matchall.git","svn_url":"https://github.com/tc39/proposal-string-matchall","homepage":"https://tc39.github.io/proposal-string-matchall/","size":153,"stargazers_count":58,"watchers_count":58,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33"},"html":{"href":"https://github.com/tc39/proposal-string-matchall/pull/33"},"issue":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/33"},"comments":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/proposal-string-matchall/statuses/4f46f31216710f365371c7ea14d229348b79f9f9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ljharb"}}