{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/184869017","pull_request_review_id":116152582,"id":184869017,"diff_hunk":"@@ -272,8 +272,71 @@ GLOBAL_LIST_INIT(available_depts, list(SEC_DEPT_ENGINEERING, SEC_DEPT_MEDICAL, S\n \telse\r\n \t\tto_chat(M, \"<b>You have not been assigned to any department. Patrol the halls and help where needed.</b>\")\r\n \r\n+\tgrant_department_bonus(H, department)\r\n \r\n \r\n+/datum/job/officer/grant_department_bonus(mob/living/carbon/human/H, department)\r\n+\tvar/random = rand(1,3)\r\n+\r\n+\tvar/flavour_text\r\n+\r\n+\tswitch(department)\r\n+\t\tif(SEC_DEPT_SUPPLY)\r\n+\t\t\tswitch(rand)\r\n+\t\t\t\tif(1)\r\n+\t\t\t\t\tvar/gun_path = pick(/obj/item/gun/ballistic/shotgun/automatic/combat, /obj/item/gun/ballistic/shotgun/boltaction, /obj/item/gun/ballistic/automatic/wt550)\r\n+\t\t\t\t\tvar/gun = new gun_path\r\n+\t\t\t\t\tH.put_in_hands(gun)\r\n+\t\t\t\t\tflavour_text = \"For Close Encounters: Whether inspired by a bad experience with mining fauna, or simply from your connections with the Cargo Techs and their arms shipments, you've acquired an appreciation for classic solid projectile weapons. You carry one with you at all times.\"\r\n+\t\t\t\tif(2)\r\n+\t\t\t\t\tflavour_text \"Contraband: Whether confinscated, or given as a bribe to make you look the other way, you are enjoying your own slice of Cargos more illicit side. You have a [contraband item]\r\n+\t\t\t\t\tvar/contraband = (//traitor items?)\r\n+\t\t\t\tif(3)\r\n+\t\t\t\t\tflavour_text \"Friend of Miners: Whether you've gone toe to toe against hostile natives, or the miners just pity a friendly face stuck on the station, they've taken a liking to you, and gifted you [mining_item]\r\n+\t\t\t\t\tvar/mining_gift = pick(lavaland item? mining gear?)\r\n+\r\n+\t\tif(SEC DEPT_ENGINEERING)\r\n+\t\t\tswitch(rand)\r\n+\t\t\t\tif(1)\r\n+\t\t\t\t\tflavour_text \"Handy With Tools: You've learned to help out around Engineering during quiet stretches of your shift. You are in the habit of carrying your own set of tools with you.\"\r\n+\t\t\t\t\t//toolbelt and yellow gloves? Maybe special tools?\r\n+\t\t\t\tif(2)\r\n+\t\t\t\t\tflavour_text \"Breacher: Your time in the Engineering Department has taught you respect for the mighty RCD.\"\r\n+\t\t\t\t\t//RCD obviously\r\n+\t\t\t\tif(3)\r\n+\t\t\t\t\tflavour_text \"EVA Patrol:\r\n+\t\t\t\t\t//Special softsuit\r\n+\t\tif(SEC_DEPT_MEDICAL)\r\n+\r\n+\t\t//Medical experiment. Special organs or third arm\r\n+\r\n+\t\t//Combat Medic: Compact Defib, medkit, maybe a special white helmet if we can get sprites\r\n+\r\n+\t\t// Chem injector? Implant?\r\n+\r\n+\t\tif(SEC_DEPT_SCIENCE)\r\n+\t\t//Robot rebuild. Random assortment of augmetics.\r\n+\r\n+\t\t//Experimental Weapon/Armour. Strange gun or reactive armour.\r\n+\r\n+\t\t//\r\n+\r\n+\t\telse //basic security officer\r\n+\t\trandom = rand(1,5)\r\n+\t\t//More of these per round so the list will be longer with its own rand\r\n+\r\n+\t\t//Rapid Fire. Slightly lower click delay on shooting/melee\r\n+\r\n+\t\t//Backup weapon. That disabler pistol that never got used.\r\n+\r\n+\t\t//Close Quarters Expert: Baton with a parry chance? Compact shield?\r","path":"code/modules/jobs/job_types/security.dm","position":61,"original_position":61,"commit_id":"a3de81e9fe32d31d3d58050c1e024cb5c86f9fcf","original_commit_id":"a3de81e9fe32d31d3d58050c1e024cb5c86f9fcf","user":{"login":"Qustinnus","id":20987591,"avatar_url":"https://avatars3.githubusercontent.com/u/20987591?v=4","gravatar_id":"","url":"https://api.github.com/users/Qustinnus","html_url":"https://github.com/Qustinnus","followers_url":"https://api.github.com/users/Qustinnus/followers","following_url":"https://api.github.com/users/Qustinnus/following{/other_user}","gists_url":"https://api.github.com/users/Qustinnus/gists{/gist_id}","starred_url":"https://api.github.com/users/Qustinnus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qustinnus/subscriptions","organizations_url":"https://api.github.com/users/Qustinnus/orgs","repos_url":"https://api.github.com/users/Qustinnus/repos","events_url":"https://api.github.com/users/Qustinnus/events{/privacy}","received_events_url":"https://api.github.com/users/Qustinnus/received_events","type":"User","site_admin":false},"body":"one that slows people :^)","created_at":"2018-04-29T01:16:23Z","updated_at":"2018-04-29T01:16:23Z","html_url":"https://github.com/tgstation/tgstation/pull/37531#discussion_r184869017","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/37531","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/184869017"},"html":{"href":"https://github.com/tgstation/tgstation/pull/37531#discussion_r184869017"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/37531"}},"in_reply_to_id":184867082},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/37531","id":184808445,"html_url":"https://github.com/tgstation/tgstation/pull/37531","diff_url":"https://github.com/tgstation/tgstation/pull/37531.diff","patch_url":"https://github.com/tgstation/tgstation/pull/37531.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/37531","number":37531,"state":"open","locked":false,"title":"Department Based Security Perks","user":{"login":"KorPhaeron","id":14340985,"avatar_url":"https://avatars0.githubusercontent.com/u/14340985?v=4","gravatar_id":"","url":"https://api.github.com/users/KorPhaeron","html_url":"https://github.com/KorPhaeron","followers_url":"https://api.github.com/users/KorPhaeron/followers","following_url":"https://api.github.com/users/KorPhaeron/following{/other_user}","gists_url":"https://api.github.com/users/KorPhaeron/gists{/gist_id}","starred_url":"https://api.github.com/users/KorPhaeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorPhaeron/subscriptions","organizations_url":"https://api.github.com/users/KorPhaeron/orgs","repos_url":"https://api.github.com/users/KorPhaeron/repos","events_url":"https://api.github.com/users/KorPhaeron/events{/privacy}","received_events_url":"https://api.github.com/users/KorPhaeron/received_events","type":"User","site_admin":false},"body":"Security officers will get a small special item or mob bonus based on their department assignment, along with a bit of fluff suggesting why they might have it. Kind of a mini list of security only random Traits\r\n\r\nWhy: Security officers have long complained they don't feel they get anything cool or special, and giving a random toy to Curator and Chaplain made those players happy, so a small bonus item with a bit of LORE behind it might make them feel cool, even if the item probably won't have that much of an impact on the round as a whole. Wishful thinking, but an item linking their character to a job or department in a more personal way might encourage the more roleplay minded players as well. \r\n\r\nThis PR is obviously incomplete and does not compile, but I had to leave halfway through making it so I figured I'd throw it up here so people could suggest things to help finish it or tear apart the idea or whatever.","created_at":"2018-04-28T22:33:35Z","updated_at":"2018-04-29T01:16:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ab4c9e403e98160365bf1d21d08d94313c01008","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":181676257,"url":"https://api.github.com/repos/tgstation/tgstation/labels/FUCK","name":"FUCK","color":"000000","default":false},{"id":255847001,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Work%20In%20Progress","name":"Work In Progress","color":"006B75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/37531/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/37531/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/37531/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/a3de81e9fe32d31d3d58050c1e024cb5c86f9fcf","head":{"label":"KorPhaeron:securityperk","ref":"securityperk","sha":"a3de81e9fe32d31d3d58050c1e024cb5c86f9fcf","user":{"login":"KorPhaeron","id":14340985,"avatar_url":"https://avatars0.githubusercontent.com/u/14340985?v=4","gravatar_id":"","url":"https://api.github.com/users/KorPhaeron","html_url":"https://github.com/KorPhaeron","followers_url":"https://api.github.com/users/KorPhaeron/followers","following_url":"https://api.github.com/users/KorPhaeron/following{/other_user}","gists_url":"https://api.github.com/users/KorPhaeron/gists{/gist_id}","starred_url":"https://api.github.com/users/KorPhaeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorPhaeron/subscriptions","organizations_url":"https://api.github.com/users/KorPhaeron/orgs","repos_url":"https://api.github.com/users/KorPhaeron/repos","events_url":"https://api.github.com/users/KorPhaeron/events{/privacy}","received_events_url":"https://api.github.com/users/KorPhaeron/received_events","type":"User","site_admin":false},"repo":{"id":42754791,"name":"kortg","full_name":"KorPhaeron/kortg","owner":{"login":"KorPhaeron","id":14340985,"avatar_url":"https://avatars0.githubusercontent.com/u/14340985?v=4","gravatar_id":"","url":"https://api.github.com/users/KorPhaeron","html_url":"https://github.com/KorPhaeron","followers_url":"https://api.github.com/users/KorPhaeron/followers","following_url":"https://api.github.com/users/KorPhaeron/following{/other_user}","gists_url":"https://api.github.com/users/KorPhaeron/gists{/gist_id}","starred_url":"https://api.github.com/users/KorPhaeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorPhaeron/subscriptions","organizations_url":"https://api.github.com/users/KorPhaeron/orgs","repos_url":"https://api.github.com/users/KorPhaeron/repos","events_url":"https://api.github.com/users/KorPhaeron/events{/privacy}","received_events_url":"https://api.github.com/users/KorPhaeron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KorPhaeron/kortg","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/KorPhaeron/kortg","forks_url":"https://api.github.com/repos/KorPhaeron/kortg/forks","keys_url":"https://api.github.com/repos/KorPhaeron/kortg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KorPhaeron/kortg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KorPhaeron/kortg/teams","hooks_url":"https://api.github.com/repos/KorPhaeron/kortg/hooks","issue_events_url":"https://api.github.com/repos/KorPhaeron/kortg/issues/events{/number}","events_url":"https://api.github.com/repos/KorPhaeron/kortg/events","assignees_url":"https://api.github.com/repos/KorPhaeron/kortg/assignees{/user}","branches_url":"https://api.github.com/repos/KorPhaeron/kortg/branches{/branch}","tags_url":"https://api.github.com/repos/KorPhaeron/kortg/tags","blobs_url":"https://api.github.com/repos/KorPhaeron/kortg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KorPhaeron/kortg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KorPhaeron/kortg/git/refs{/sha}","trees_url":"https://api.github.com/repos/KorPhaeron/kortg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KorPhaeron/kortg/statuses/{sha}","languages_url":"https://api.github.com/repos/KorPhaeron/kortg/languages","stargazers_url":"https://api.github.com/repos/KorPhaeron/kortg/stargazers","contributors_url":"https://api.github.com/repos/KorPhaeron/kortg/contributors","subscribers_url":"https://api.github.com/repos/KorPhaeron/kortg/subscribers","subscription_url":"https://api.github.com/repos/KorPhaeron/kortg/subscription","commits_url":"https://api.github.com/repos/KorPhaeron/kortg/commits{/sha}","git_commits_url":"https://api.github.com/repos/KorPhaeron/kortg/git/commits{/sha}","comments_url":"https://api.github.com/repos/KorPhaeron/kortg/comments{/number}","issue_comment_url":"https://api.github.com/repos/KorPhaeron/kortg/issues/comments{/number}","contents_url":"https://api.github.com/repos/KorPhaeron/kortg/contents/{+path}","compare_url":"https://api.github.com/repos/KorPhaeron/kortg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KorPhaeron/kortg/merges","archive_url":"https://api.github.com/repos/KorPhaeron/kortg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KorPhaeron/kortg/downloads","issues_url":"https://api.github.com/repos/KorPhaeron/kortg/issues{/number}","pulls_url":"https://api.github.com/repos/KorPhaeron/kortg/pulls{/number}","milestones_url":"https://api.github.com/repos/KorPhaeron/kortg/milestones{/number}","notifications_url":"https://api.github.com/repos/KorPhaeron/kortg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KorPhaeron/kortg/labels{/name}","releases_url":"https://api.github.com/repos/KorPhaeron/kortg/releases{/id}","deployments_url":"https://api.github.com/repos/KorPhaeron/kortg/deployments","created_at":"2015-09-19T01:35:06Z","updated_at":"2017-10-25T23:34:20Z","pushed_at":"2018-04-28T22:29:17Z","git_url":"git://github.com/KorPhaeron/kortg.git","ssh_url":"git@github.com:KorPhaeron/kortg.git","clone_url":"https://github.com/KorPhaeron/kortg.git","svn_url":"https://github.com/KorPhaeron/kortg","homepage":"http://www.tgstation13.org/","size":1123830,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"ad9643b0e1f642162405ed9e5b14881dae3c7868","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2018-04-28T23:21:59Z","pushed_at":"2018-04-29T01:03:22Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"https://www.tgstation13.org/","size":1120086,"stargazers_count":508,"watchers_count":508,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1769,"mirror_url":null,"archived":false,"open_issues_count":1207,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1769,"open_issues":1207,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/37531"},"html":{"href":"https://github.com/tgstation/tgstation/pull/37531"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/37531"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/37531/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/37531/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/37531/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/a3de81e9fe32d31d3d58050c1e024cb5c86f9fcf"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Qustinnus"}}