{"action":"created","issue":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/3139","repository_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/3139/labels{/name}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/3139/comments","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/3139/events","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/3139","id":384031687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzQ2Mjcw","number":3139,"title":"[Spree Upgrade] Fix tests in bulk_product_update spec","user":{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false},"assignees":[{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-11-24T23:34:15Z","updated_at":"2018-11-27T16:04:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/3139","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/3139","diff_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/3139.diff","patch_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/3139.patch"},"body":"This was what was done in different specs:\r\n- setting on_hand in the variant and not in the product directly\r\n- setting variant on_demand to false (default from the factory is on_demand true)\r\n- saving the variant after doing this to trigger appropriate callbacks like creating missing variant stock items (this may not be required depending on the final state of PR #3132 which is under discussion right now)\r\n\r\n#### What? Why?\r\n\r\nThis PR fixes 5 of the 7 tests in #2804 \r\nThe remaining two tests (line 307 and line 700) also need the on_hand and on_demand fields to be working in the product bulk edit page. That is addressed in PR #3132. So, after this PR and #3132 is merged, the issue #2804 can be closed as all tests will be green.\r\n"},"comment":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/comments/442114358","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/3139#issuecomment-442114358","issue_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/3139","id":442114358,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjExNDM1OA==","user":{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T16:04:31Z","updated_at":"2018-11-27T16:04:31Z","author_association":"CONTRIBUTOR","body":"ready for rereview @sauloperez "}}
{"actor":{"display_login":"luisramos0"}}