{"action":"opened","issue":{"url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/111","repository_url":"https://api.github.com/repos/kblok/puppeteer-sharp","labels_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/111/comments","events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/111/events","html_url":"https://github.com/kblok/puppeteer-sharp/issues/111","id":310346453,"number":111,"title":"split TestConstants to be like puppeteer","user":{"login":"Meir017","id":9786571,"avatar_url":"https://avatars3.githubusercontent.com/u/9786571?v=4","gravatar_id":"","url":"https://api.github.com/users/Meir017","html_url":"https://github.com/Meir017","followers_url":"https://api.github.com/users/Meir017/followers","following_url":"https://api.github.com/users/Meir017/following{/other_user}","gists_url":"https://api.github.com/users/Meir017/gists{/gist_id}","starred_url":"https://api.github.com/users/Meir017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meir017/subscriptions","organizations_url":"https://api.github.com/users/Meir017/orgs","repos_url":"https://api.github.com/users/Meir017/repos","events_url":"https://api.github.com/users/Meir017/events{/privacy}","received_events_url":"https://api.github.com/users/Meir017/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-01T19:13:11Z","updated_at":"2018-04-01T19:13:11Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://github.com/GoogleChrome/puppeteer/blob/v1.0.0/test/test.js#L81\r\nsplit into 2:\r\n* server\r\n  * PREFIX\r\n  * CROSS_PROCESS_PREFIX\r\n  * EMPTY_PAGE\r\n* httpsServer\r\n  * PREFIX\r\n  * CROSS_PROCESS_PREFIX\r\n  * EMPTY_PAGE\r\n\r\nwe could split into 2 classes or just move them to the base class.\r\n\r\nsomething like:\r\n```cs\r\npublic class PuppeteerBaseTests : IAsyncLifetime\r\n{\r\n    protected static readonly int Port = 8907;\r\n    ...\r\n\r\n    protected static readonly int HttpsPort = Port + 1;\r\n    ...\r\n\r\n    protected Browser Browser { get; private set; }\r\n    public async Task InitializeAsync()\r\n    {\r\n        Browser = await PuppeteerSharp.Puppeteer.LaunchAsync(TestConstants.DefaultBrowserOptions(), TestConstants.ChromiumRevision);\r\n    }\r\n\r\n    public async Task DisposeAsync()\r\n    {\r\n        await Browser.CloseAsync();\r\n    }\r\n}\r\n\r\npublic class PuppeteerPageBaseTests: PuppeteerBaseTests\r\n{\r\n    protected Page Page { get; private set; }\r\n    public new async Task InitializeAsync()\r\n    {\r\n        await base.InitializeAsync();\r\n        Page = await Browser.NewPageAsync();\r\n    }\r\n\r\n    public new async Task DisposeAsync()\r\n    {\r\n        await base.DisposeAsync();\r\n        await Page.CloseAsync();\r\n    }\r\n}\r\n```"}}
{"actor":{"display_login":"Meir017"}}