{"action":"created","issue":{"url":"https://api.github.com/repos/RaphaelJenni/FirebaseUI-Angular/issues/58","repository_url":"https://api.github.com/repos/RaphaelJenni/FirebaseUI-Angular","labels_url":"https://api.github.com/repos/RaphaelJenni/FirebaseUI-Angular/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/RaphaelJenni/FirebaseUI-Angular/issues/58/comments","events_url":"https://api.github.com/repos/RaphaelJenni/FirebaseUI-Angular/issues/58/events","html_url":"https://github.com/RaphaelJenni/FirebaseUI-Angular/issues/58","id":329901988,"node_id":"MDU6SXNzdWUzMjk5MDE5ODg=","number":58,"title":"Weird deprecation warnings","user":{"login":"jscti","id":1594035,"node_id":"MDQ6VXNlcjE1OTQwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1594035?v=4","gravatar_id":"","url":"https://api.github.com/users/jscti","html_url":"https://github.com/jscti","followers_url":"https://api.github.com/users/jscti/followers","following_url":"https://api.github.com/users/jscti/following{/other_user}","gists_url":"https://api.github.com/users/jscti/gists{/gist_id}","starred_url":"https://api.github.com/users/jscti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscti/subscriptions","organizations_url":"https://api.github.com/users/jscti/orgs","repos_url":"https://api.github.com/users/jscti/repos","events_url":"https://api.github.com/users/jscti/events{/privacy}","received_events_url":"https://api.github.com/users/jscti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-06T14:48:44Z","updated_at":"2018-06-06T15:10:38Z","closed_at":null,"author_association":"NONE","body":"Hi there. Got two warnings from firebaseui-angular (and firebaseui) : \r\n\r\n> [FirebaseUiAngular] signInSuccess callback is deprecated. Please use signInSuccessWithAuthResult callback instead. To remove this warning set disableSignInSuccessCallback on the FirebaseUiConfig Object.\r\n> [firebaseui] signInSuccess callback is deprecated. Please use signInSuccessWithAuthResult callback instead.\r\n\r\nI only used the `signInSuccessWithAuthResult` in my template (but it's not documented (yet?)). After diging through the code, I saw that the firebaseUiAngular warning is emited independently of the use or not of either callback, which seems weird.\r\nSo well, I used disableSignInSuccessCallback=false but ... didn't understood all that.\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/RaphaelJenni/FirebaseUI-Angular/issues/comments/395104146","html_url":"https://github.com/RaphaelJenni/FirebaseUI-Angular/issues/58#issuecomment-395104146","issue_url":"https://api.github.com/repos/RaphaelJenni/FirebaseUI-Angular/issues/58","id":395104146,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTEwNDE0Ng==","user":{"login":"jscti","id":1594035,"node_id":"MDQ6VXNlcjE1OTQwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1594035?v=4","gravatar_id":"","url":"https://api.github.com/users/jscti","html_url":"https://github.com/jscti","followers_url":"https://api.github.com/users/jscti/followers","following_url":"https://api.github.com/users/jscti/following{/other_user}","gists_url":"https://api.github.com/users/jscti/gists{/gist_id}","starred_url":"https://api.github.com/users/jscti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscti/subscriptions","organizations_url":"https://api.github.com/users/jscti/orgs","repos_url":"https://api.github.com/users/jscti/repos","events_url":"https://api.github.com/users/jscti/events{/privacy}","received_events_url":"https://api.github.com/users/jscti/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T15:10:38Z","updated_at":"2018-06-06T15:10:38Z","author_association":"NONE","body":"Thanks for the (super) quick answer !\r\n\r\nTotally understood with your comment. Maybe you could : \r\n- add this detailed explanation in your flag documentation\r\n- not show the warning + auto-disable-signInSuccess (for firebaseui) when `signInSuccessWithAuthResult`is properly used (and `signInSuccess` not used ..)\r\n?\r\n\r\nBut I guess anybody having the same problem as me will fall here and understand.\r\nThanks"}}
{"actor":{"display_login":"jscti"}}