{"action":"created","issue":{"url":"https://api.github.com/repos/campDevs/DiscordBot/issues/17","repository_url":"https://api.github.com/repos/campDevs/DiscordBot","labels_url":"https://api.github.com/repos/campDevs/DiscordBot/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/campDevs/DiscordBot/issues/17/comments","events_url":"https://api.github.com/repos/campDevs/DiscordBot/issues/17/events","html_url":"https://github.com/campDevs/DiscordBot/pull/17","id":320482321,"number":17,"title":"Feature","user":{"login":"pahosler","id":11909710,"avatar_url":"https://avatars1.githubusercontent.com/u/11909710?v=4","gravatar_id":"","url":"https://api.github.com/users/pahosler","html_url":"https://github.com/pahosler","followers_url":"https://api.github.com/users/pahosler/followers","following_url":"https://api.github.com/users/pahosler/following{/other_user}","gists_url":"https://api.github.com/users/pahosler/gists{/gist_id}","starred_url":"https://api.github.com/users/pahosler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pahosler/subscriptions","organizations_url":"https://api.github.com/users/pahosler/orgs","repos_url":"https://api.github.com/users/pahosler/repos","events_url":"https://api.github.com/users/pahosler/events{/privacy}","received_events_url":"https://api.github.com/users/pahosler/received_events","type":"User","site_admin":false},"labels":[{"id":922422571,"url":"https://api.github.com/repos/campDevs/DiscordBot/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"pahosler","id":11909710,"avatar_url":"https://avatars1.githubusercontent.com/u/11909710?v=4","gravatar_id":"","url":"https://api.github.com/users/pahosler","html_url":"https://github.com/pahosler","followers_url":"https://api.github.com/users/pahosler/followers","following_url":"https://api.github.com/users/pahosler/following{/other_user}","gists_url":"https://api.github.com/users/pahosler/gists{/gist_id}","starred_url":"https://api.github.com/users/pahosler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pahosler/subscriptions","organizations_url":"https://api.github.com/users/pahosler/orgs","repos_url":"https://api.github.com/users/pahosler/repos","events_url":"https://api.github.com/users/pahosler/events{/privacy}","received_events_url":"https://api.github.com/users/pahosler/received_events","type":"User","site_admin":false},"assignees":[{"login":"pahosler","id":11909710,"avatar_url":"https://avatars1.githubusercontent.com/u/11909710?v=4","gravatar_id":"","url":"https://api.github.com/users/pahosler","html_url":"https://github.com/pahosler","followers_url":"https://api.github.com/users/pahosler/followers","following_url":"https://api.github.com/users/pahosler/following{/other_user}","gists_url":"https://api.github.com/users/pahosler/gists{/gist_id}","starred_url":"https://api.github.com/users/pahosler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pahosler/subscriptions","organizations_url":"https://api.github.com/users/pahosler/orgs","repos_url":"https://api.github.com/users/pahosler/repos","events_url":"https://api.github.com/users/pahosler/events{/privacy}","received_events_url":"https://api.github.com/users/pahosler/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-05-05T05:48:53Z","updated_at":"2018-05-06T10:06:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/campDevs/DiscordBot/pulls/17","html_url":"https://github.com/campDevs/DiscordBot/pull/17","diff_url":"https://github.com/campDevs/DiscordBot/pull/17.diff","patch_url":"https://github.com/campDevs/DiscordBot/pull/17.patch"},"body":"**In feature branch**:\r\nAdded a \"fun\" section and my horoscope feature into the fun-section\r\ntest in dev"},"comment":{"url":"https://api.github.com/repos/campDevs/DiscordBot/issues/comments/386868254","html_url":"https://github.com/campDevs/DiscordBot/pull/17#issuecomment-386868254","issue_url":"https://api.github.com/repos/campDevs/DiscordBot/issues/17","id":386868254,"user":{"login":"glynnw","id":1103591,"avatar_url":"https://avatars1.githubusercontent.com/u/1103591?v=4","gravatar_id":"","url":"https://api.github.com/users/glynnw","html_url":"https://github.com/glynnw","followers_url":"https://api.github.com/users/glynnw/followers","following_url":"https://api.github.com/users/glynnw/following{/other_user}","gists_url":"https://api.github.com/users/glynnw/gists{/gist_id}","starred_url":"https://api.github.com/users/glynnw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glynnw/subscriptions","organizations_url":"https://api.github.com/users/glynnw/orgs","repos_url":"https://api.github.com/users/glynnw/repos","events_url":"https://api.github.com/users/glynnw/events{/privacy}","received_events_url":"https://api.github.com/users/glynnw/received_events","type":"User","site_admin":false},"created_at":"2018-05-06T10:06:49Z","updated_at":"2018-05-06T10:06:49Z","author_association":"OWNER","body":"On semicolons, no, we've not reached a decision on that yet I don't think. But it is usually common practice to stick with the style of the code you're contributing to so for now we can be semicolonless till a decision is made.\r\n\r\nAs for the dotenv, the only reason dotenv was used in the first place was to provide a place for secrets to be kept out of version control and glitch deploys. If it is something we can provide defaults for it shouldn't end up in the dotenv due to the dotenv not existing in the repo. Instead we should consider using a config file like the one used to configure the prefix.\r\n\r\nObviously adding a variable to the dotenv is trivial. Explaining where to optain the what goes in that variable is a little less trivial. It adds up and the more we have in the dotenv or any config for that matter, the more we have to explain in the installation/usage sections. Even though it isn't completely possible due to the bot token, I say we should try for as close as we can to zero config. Try to have defaults that make the deploy to glitch or where ever as simple as possible."}}
{"actor":{"display_login":"glynnw"}}