{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/pmdk/issues/2765","repository_url":"https://api.github.com/repos/pmem/pmdk","labels_url":"https://api.github.com/repos/pmem/pmdk/issues/2765/labels{/name}","comments_url":"https://api.github.com/repos/pmem/pmdk/issues/2765/comments","events_url":"https://api.github.com/repos/pmem/pmdk/issues/2765/events","html_url":"https://github.com/pmem/pmdk/pull/2765","id":306907795,"number":2765,"title":"common: unsafe shutdown count for windows","user":{"login":"lplewa","id":19689632,"avatar_url":"https://avatars2.githubusercontent.com/u/19689632?v=4","gravatar_id":"","url":"https://api.github.com/users/lplewa","html_url":"https://github.com/lplewa","followers_url":"https://api.github.com/users/lplewa/followers","following_url":"https://api.github.com/users/lplewa/following{/other_user}","gists_url":"https://api.github.com/users/lplewa/gists{/gist_id}","starred_url":"https://api.github.com/users/lplewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lplewa/subscriptions","organizations_url":"https://api.github.com/users/lplewa/orgs","repos_url":"https://api.github.com/users/lplewa/repos","events_url":"https://api.github.com/users/lplewa/events{/privacy}","received_events_url":"https://api.github.com/users/lplewa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-20T15:09:20Z","updated_at":"2018-03-21T16:43:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pmem/pmdk/pulls/2765","html_url":"https://github.com/pmem/pmdk/pull/2765","diff_url":"https://github.com/pmem/pmdk/pull/2765.diff","patch_url":"https://github.com/pmem/pmdk/pull/2765.patch"},"body":"sds tests for windows will be added in separate PR\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/pmdk/2765)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/pmdk/issues/comments/375011571","html_url":"https://github.com/pmem/pmdk/pull/2765#issuecomment-375011571","issue_url":"https://api.github.com/repos/pmem/pmdk/issues/2765","id":375011571,"user":{"login":"lplewa","id":19689632,"avatar_url":"https://avatars2.githubusercontent.com/u/19689632?v=4","gravatar_id":"","url":"https://api.github.com/users/lplewa","html_url":"https://github.com/lplewa","followers_url":"https://api.github.com/users/lplewa/followers","following_url":"https://api.github.com/users/lplewa/following{/other_user}","gists_url":"https://api.github.com/users/lplewa/gists{/gist_id}","starred_url":"https://api.github.com/users/lplewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lplewa/subscriptions","organizations_url":"https://api.github.com/users/lplewa/orgs","repos_url":"https://api.github.com/users/lplewa/repos","events_url":"https://api.github.com/users/lplewa/events{/privacy}","received_events_url":"https://api.github.com/users/lplewa/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T16:43:17Z","updated_at":"2018-03-21T16:43:17Z","author_association":"MEMBER","body":"\n\n\n\nReview status: 15 of 17 files reviewed at latest revision, 9 unresolved discussions.\n\n---\n\n*[src/common/os_dimm_windows.c, line 121 at r3](https://beta.reviewable.io/reviews/pmem/pmdk/2765#-L87ix9dI0Dl-XPJsmNV:-L88K8JlAe2OPirpseCs:b-896fix) ([raw file](https://github.com/pmem/pmdk/blob/720df0aae855404808c2d0ee3e7cc2714bff19f8/src/common/os_dimm_windows.c#L121)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\nsizeof(prop) sizeof(ret)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/common/os_dimm_windows.c, line 127 at r3](https://beta.reviewable.io/reviews/pmem/pmdk/2765#-L87j3vo0hNAJhS4bHjz:-L88OMvO4h4b6M6qjp0c:byiwxkc) ([raw file](https://github.com/pmem/pmdk/blob/720df0aae855404808c2d0ee3e7cc2714bff19f8/src/common/os_dimm_windows.c#L127)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\nhow about other errors ?\n</blockquote></details>\n\nWe ignore them too, like on Linux - anyway MSDN doesn't document possible errors.....\n\n---\n\n*[src/common/os_dimm_windows.c, line 137 at r3](https://beta.reviewable.io/reviews/pmem/pmdk/2765#-L87j8wPYQdEQrSLVFhU:-L87r_SICgplr3bxaPFH:b-896fix) ([raw file](https://github.com/pmem/pmdk/blob/720df0aae855404808c2d0ee3e7cc2714bff19f8/src/common/os_dimm_windows.c#L137)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\nbrackets not needed\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/common/os_dimm_windows.c, line 150 at r3](https://beta.reviewable.io/reviews/pmem/pmdk/2765#-L87jYFvJl8wdO8sdn0J:-L87r3aJlOplFhoc1NNH:biv4i17) ([raw file](https://github.com/pmem/pmdk/blob/720df0aae855404808c2d0ee3e7cc2714bff19f8/src/common/os_dimm_windows.c#L150)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\nhow about errno = ENOSYS + return -1 ?\n</blockquote></details>\n\nthis copy/paste from os_dimm_none -> anyway we don't want to fail on windows due to not implemented BB support\n\n---\n\n*[src/common/os_dimm_windows.c, line 168 at r3](https://beta.reviewable.io/reviews/pmem/pmdk/2765#-L87j_Gn3swPRzCQdX51:-L87rKb35psvP0UbzLs5:biv4i17) ([raw file](https://github.com/pmem/pmdk/blob/720df0aae855404808c2d0ee3e7cc2714bff19f8/src/common/os_dimm_windows.c#L168)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\n\"\n</blockquote></details>\n\nthis copy/paste from os_dimm_none -> anyway we don't want to fail on windows due to not implemented BB support\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/pmem/pmdk/2765)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"lplewa"}}