{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/225639197","pull_request_review_id":165281623,"id":225639197,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTYzOTE5Nw==","diff_hunk":"@@ -190,6 +189,19 @@ export class UiSettingsService {\n       const resp = await this._savedObjectsClient.get(this._type, this._id);\n       return resp.attributes;\n     } catch (error) {\n+      if (isNotFoundError(error)) {\n+        try {\n+          await createOrUpgradeSavedConfig({\n+            savedObjectsClient: this._savedObjectsClient,\n+            version: this._id,\n+            buildNum: this._buildNum,\n+            log: this._log,\n+          });\n+        } catch (e) {","path":"src/ui/ui_settings/ui_settings_service.js","position":20,"original_position":20,"commit_id":"67ee655f404ca95eaf06c0dca1acf1b3a66e101c","original_commit_id":"67ee655f404ca95eaf06c0dca1acf1b3a66e101c","user":{"login":"spalger","id":1329312,"node_id":"MDQ6VXNlcjEzMjkzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1329312?v=4","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"body":"We should really be checking this error to make sure it's what we expect. Otherwise we could be swallowing errors that indicate unexpected issues down the road.","created_at":"2018-10-16T17:35:10Z","updated_at":"2018-10-16T17:35:10Z","html_url":"https://github.com/elastic/kibana/pull/23377#discussion_r225639197","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/23377","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/225639197"},"html":{"href":"https://github.com/elastic/kibana/pull/23377#discussion_r225639197"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23377"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/23377","id":217076852,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDc2ODUy","html_url":"https://github.com/elastic/kibana/pull/23377","diff_url":"https://github.com/elastic/kibana/pull/23377.diff","patch_url":"https://github.com/elastic/kibana/pull/23377.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/23377","number":23377,"state":"closed","locked":false,"title":"doing config migration during config get if necessary","user":{"login":"bmcconaghy","id":2479496,"node_id":"MDQ6VXNlcjI0Nzk0OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2479496?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcconaghy","html_url":"https://github.com/bmcconaghy","followers_url":"https://api.github.com/users/bmcconaghy/followers","following_url":"https://api.github.com/users/bmcconaghy/following{/other_user}","gists_url":"https://api.github.com/users/bmcconaghy/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcconaghy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcconaghy/subscriptions","organizations_url":"https://api.github.com/users/bmcconaghy/orgs","repos_url":"https://api.github.com/users/bmcconaghy/repos","events_url":"https://api.github.com/users/bmcconaghy/events{/privacy}","received_events_url":"https://api.github.com/users/bmcconaghy/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/elastic/kibana/issues/22541\r\n\r\nFixing issue with migration and config not getting migrated to new version.  This code makes it so if a config is missing, it gets migrated during _read.","created_at":"2018-09-20T19:09:47Z","updated_at":"2018-10-16T17:35:10Z","closed_at":"2018-10-16T14:05:55Z","merged_at":"2018-10-16T14:05:55Z","merge_commit_sha":"0b4f82da787dda2f66e2c6db6f2b7aa1dd2a1427","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/23377/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/23377/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/23377/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/67ee655f404ca95eaf06c0dca1acf1b3a66e101c","head":{"label":"bmcconaghy:fix_issue_with_config_upgrage","ref":"fix_issue_with_config_upgrage","sha":"67ee655f404ca95eaf06c0dca1acf1b3a66e101c","user":{"login":"bmcconaghy","id":2479496,"node_id":"MDQ6VXNlcjI0Nzk0OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2479496?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcconaghy","html_url":"https://github.com/bmcconaghy","followers_url":"https://api.github.com/users/bmcconaghy/followers","following_url":"https://api.github.com/users/bmcconaghy/following{/other_user}","gists_url":"https://api.github.com/users/bmcconaghy/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcconaghy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcconaghy/subscriptions","organizations_url":"https://api.github.com/users/bmcconaghy/orgs","repos_url":"https://api.github.com/users/bmcconaghy/repos","events_url":"https://api.github.com/users/bmcconaghy/events{/privacy}","received_events_url":"https://api.github.com/users/bmcconaghy/received_events","type":"User","site_admin":false},"repo":{"id":101643148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE2NDMxNDg=","name":"kibana","full_name":"bmcconaghy/kibana","private":false,"owner":{"login":"bmcconaghy","id":2479496,"node_id":"MDQ6VXNlcjI0Nzk0OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2479496?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcconaghy","html_url":"https://github.com/bmcconaghy","followers_url":"https://api.github.com/users/bmcconaghy/followers","following_url":"https://api.github.com/users/bmcconaghy/following{/other_user}","gists_url":"https://api.github.com/users/bmcconaghy/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcconaghy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcconaghy/subscriptions","organizations_url":"https://api.github.com/users/bmcconaghy/orgs","repos_url":"https://api.github.com/users/bmcconaghy/repos","events_url":"https://api.github.com/users/bmcconaghy/events{/privacy}","received_events_url":"https://api.github.com/users/bmcconaghy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bmcconaghy/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/bmcconaghy/kibana","forks_url":"https://api.github.com/repos/bmcconaghy/kibana/forks","keys_url":"https://api.github.com/repos/bmcconaghy/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmcconaghy/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmcconaghy/kibana/teams","hooks_url":"https://api.github.com/repos/bmcconaghy/kibana/hooks","issue_events_url":"https://api.github.com/repos/bmcconaghy/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/bmcconaghy/kibana/events","assignees_url":"https://api.github.com/repos/bmcconaghy/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/bmcconaghy/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/bmcconaghy/kibana/tags","blobs_url":"https://api.github.com/repos/bmcconaghy/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmcconaghy/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmcconaghy/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmcconaghy/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmcconaghy/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/bmcconaghy/kibana/languages","stargazers_url":"https://api.github.com/repos/bmcconaghy/kibana/stargazers","contributors_url":"https://api.github.com/repos/bmcconaghy/kibana/contributors","subscribers_url":"https://api.github.com/repos/bmcconaghy/kibana/subscribers","subscription_url":"https://api.github.com/repos/bmcconaghy/kibana/subscription","commits_url":"https://api.github.com/repos/bmcconaghy/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmcconaghy/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmcconaghy/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmcconaghy/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmcconaghy/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/bmcconaghy/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmcconaghy/kibana/merges","archive_url":"https://api.github.com/repos/bmcconaghy/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmcconaghy/kibana/downloads","issues_url":"https://api.github.com/repos/bmcconaghy/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/bmcconaghy/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/bmcconaghy/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/bmcconaghy/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmcconaghy/kibana/labels{/name}","releases_url":"https://api.github.com/repos/bmcconaghy/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/bmcconaghy/kibana/deployments","created_at":"2017-08-28T12:57:20Z","updated_at":"2018-10-15T12:56:33Z","pushed_at":"2018-10-16T14:06:56Z","git_url":"git://github.com/bmcconaghy/kibana.git","ssh_url":"git@github.com:bmcconaghy/kibana.git","clone_url":"https://github.com/bmcconaghy/kibana.git","svn_url":"https://github.com/bmcconaghy/kibana","homepage":"https://www.elastic.co/products/kibana","size":469347,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"c2cb0d3b92b07eba5a4157be8271162a818b2911","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-10-16T17:02:42Z","pushed_at":"2018-10-16T17:29:39Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":544932,"stargazers_count":10272,"watchers_count":10272,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3994,"mirror_url":null,"archived":false,"open_issues_count":3627,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3994,"open_issues":3627,"watchers":10272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23377"},"html":{"href":"https://github.com/elastic/kibana/pull/23377"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/23377"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/23377/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23377/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23377/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/67ee655f404ca95eaf06c0dca1acf1b3a66e101c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spalger"}}