{"action":"created","comment":{"url":"https://api.github.com/repos/infection/infection/pulls/comments/198406723","pull_request_review_id":132330761,"id":198406723,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQwNjcyMw==","diff_hunk":"@@ -78,25 +81,12 @@ public function logBadMsiErrorMessage(MetricsCalculator $metricsCalculator, floa\n         $this->io->error(\n             sprintf(\n                 self::CI_FLAG_ERROR,\n-                'MSI',\n+                ($type === TestRunConstraintChecker::MSI_FAILURE ? 'MSI' : 'Covered Code MSI'),","path":"src/Console/ConsoleOutput.php","position":31,"original_position":31,"commit_id":"f8d23f384380aa6d65cdbbec80854c95ec9f13c6","original_commit_id":"f8d23f384380aa6d65cdbbec80854c95ec9f13c6","user":{"login":"sanmai","id":139488,"node_id":"MDQ6VXNlcjEzOTQ4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/139488?v=4","gravatar_id":"","url":"https://api.github.com/users/sanmai","html_url":"https://github.com/sanmai","followers_url":"https://api.github.com/users/sanmai/followers","following_url":"https://api.github.com/users/sanmai/following{/other_user}","gists_url":"https://api.github.com/users/sanmai/gists{/gist_id}","starred_url":"https://api.github.com/users/sanmai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanmai/subscriptions","organizations_url":"https://api.github.com/users/sanmai/orgs","repos_url":"https://api.github.com/users/sanmai/repos","events_url":"https://api.github.com/users/sanmai/events{/privacy}","received_events_url":"https://api.github.com/users/sanmai/received_events","type":"User","site_admin":false},"body":"As for static typing, I think that for any API is best to stick to specific return/input types as much as possible. This way a user would never ever need to use `===` just because all types are known beforehand.\r\n\r\n@theofidry Is that what you assume under static typing? ","created_at":"2018-06-27T08:28:47Z","updated_at":"2018-06-27T08:28:47Z","html_url":"https://github.com/infection/infection/pull/379#discussion_r198406723","pull_request_url":"https://api.github.com/repos/infection/infection/pulls/379","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infection/infection/pulls/comments/198406723"},"html":{"href":"https://github.com/infection/infection/pull/379#discussion_r198406723"},"pull_request":{"href":"https://api.github.com/repos/infection/infection/pulls/379"}},"in_reply_to_id":198043750},"pull_request":{"url":"https://api.github.com/repos/infection/infection/pulls/379","id":192708340,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzA4MzQw","html_url":"https://github.com/infection/infection/pull/379","diff_url":"https://github.com/infection/infection/pull/379.diff","patch_url":"https://github.com/infection/infection/pull/379.patch","issue_url":"https://api.github.com/repos/infection/infection/issues/379","number":379,"state":"open","locked":false,"title":"Extract functionality out of infection command","user":{"login":"BackEndTea","id":14289961,"node_id":"MDQ6VXNlcjE0Mjg5OTYx","avatar_url":"https://avatars1.githubusercontent.com/u/14289961?v=4","gravatar_id":"","url":"https://api.github.com/users/BackEndTea","html_url":"https://github.com/BackEndTea","followers_url":"https://api.github.com/users/BackEndTea/followers","following_url":"https://api.github.com/users/BackEndTea/following{/other_user}","gists_url":"https://api.github.com/users/BackEndTea/gists{/gist_id}","starred_url":"https://api.github.com/users/BackEndTea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BackEndTea/subscriptions","organizations_url":"https://api.github.com/users/BackEndTea/orgs","repos_url":"https://api.github.com/users/BackEndTea/repos","events_url":"https://api.github.com/users/BackEndTea/events{/privacy}","received_events_url":"https://api.github.com/users/BackEndTea/received_events","type":"User","site_admin":false},"body":"The command class is kind of a god class, this PR removes some functionality from the command and places it into its own sub classes, notably:\r\n\r\n* Creation of event subscribers\r\n* Checking if we can generate or have coverage\r\n* Checking if mutation testing run passed its constraints\r\n\r\nMeaning this functionality can possibly be unit tested, and it works towards testability of the command class","created_at":"2018-06-05T13:31:51Z","updated_at":"2018-06-27T08:28:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3ddb8e604afbcb2d50db2e6f2dd2f9bf10f8489","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infection/infection/pulls/379/commits","review_comments_url":"https://api.github.com/repos/infection/infection/pulls/379/comments","review_comment_url":"https://api.github.com/repos/infection/infection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infection/infection/issues/379/comments","statuses_url":"https://api.github.com/repos/infection/infection/statuses/f8d23f384380aa6d65cdbbec80854c95ec9f13c6","head":{"label":"BackEndTea:enhancement/extract-from-command","ref":"enhancement/extract-from-command","sha":"f8d23f384380aa6d65cdbbec80854c95ec9f13c6","user":{"login":"BackEndTea","id":14289961,"node_id":"MDQ6VXNlcjE0Mjg5OTYx","avatar_url":"https://avatars1.githubusercontent.com/u/14289961?v=4","gravatar_id":"","url":"https://api.github.com/users/BackEndTea","html_url":"https://github.com/BackEndTea","followers_url":"https://api.github.com/users/BackEndTea/followers","following_url":"https://api.github.com/users/BackEndTea/following{/other_user}","gists_url":"https://api.github.com/users/BackEndTea/gists{/gist_id}","starred_url":"https://api.github.com/users/BackEndTea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BackEndTea/subscriptions","organizations_url":"https://api.github.com/users/BackEndTea/orgs","repos_url":"https://api.github.com/users/BackEndTea/repos","events_url":"https://api.github.com/users/BackEndTea/events{/privacy}","received_events_url":"https://api.github.com/users/BackEndTea/received_events","type":"User","site_admin":false},"repo":{"id":115420174,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MjAxNzQ=","name":"infection","full_name":"BackEndTea/infection","owner":{"login":"BackEndTea","id":14289961,"node_id":"MDQ6VXNlcjE0Mjg5OTYx","avatar_url":"https://avatars1.githubusercontent.com/u/14289961?v=4","gravatar_id":"","url":"https://api.github.com/users/BackEndTea","html_url":"https://github.com/BackEndTea","followers_url":"https://api.github.com/users/BackEndTea/followers","following_url":"https://api.github.com/users/BackEndTea/following{/other_user}","gists_url":"https://api.github.com/users/BackEndTea/gists{/gist_id}","starred_url":"https://api.github.com/users/BackEndTea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BackEndTea/subscriptions","organizations_url":"https://api.github.com/users/BackEndTea/orgs","repos_url":"https://api.github.com/users/BackEndTea/repos","events_url":"https://api.github.com/users/BackEndTea/events{/privacy}","received_events_url":"https://api.github.com/users/BackEndTea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BackEndTea/infection","description":"AST based PHP Mutation Testing Framework","fork":true,"url":"https://api.github.com/repos/BackEndTea/infection","forks_url":"https://api.github.com/repos/BackEndTea/infection/forks","keys_url":"https://api.github.com/repos/BackEndTea/infection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BackEndTea/infection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BackEndTea/infection/teams","hooks_url":"https://api.github.com/repos/BackEndTea/infection/hooks","issue_events_url":"https://api.github.com/repos/BackEndTea/infection/issues/events{/number}","events_url":"https://api.github.com/repos/BackEndTea/infection/events","assignees_url":"https://api.github.com/repos/BackEndTea/infection/assignees{/user}","branches_url":"https://api.github.com/repos/BackEndTea/infection/branches{/branch}","tags_url":"https://api.github.com/repos/BackEndTea/infection/tags","blobs_url":"https://api.github.com/repos/BackEndTea/infection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BackEndTea/infection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BackEndTea/infection/git/refs{/sha}","trees_url":"https://api.github.com/repos/BackEndTea/infection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BackEndTea/infection/statuses/{sha}","languages_url":"https://api.github.com/repos/BackEndTea/infection/languages","stargazers_url":"https://api.github.com/repos/BackEndTea/infection/stargazers","contributors_url":"https://api.github.com/repos/BackEndTea/infection/contributors","subscribers_url":"https://api.github.com/repos/BackEndTea/infection/subscribers","subscription_url":"https://api.github.com/repos/BackEndTea/infection/subscription","commits_url":"https://api.github.com/repos/BackEndTea/infection/commits{/sha}","git_commits_url":"https://api.github.com/repos/BackEndTea/infection/git/commits{/sha}","comments_url":"https://api.github.com/repos/BackEndTea/infection/comments{/number}","issue_comment_url":"https://api.github.com/repos/BackEndTea/infection/issues/comments{/number}","contents_url":"https://api.github.com/repos/BackEndTea/infection/contents/{+path}","compare_url":"https://api.github.com/repos/BackEndTea/infection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BackEndTea/infection/merges","archive_url":"https://api.github.com/repos/BackEndTea/infection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BackEndTea/infection/downloads","issues_url":"https://api.github.com/repos/BackEndTea/infection/issues{/number}","pulls_url":"https://api.github.com/repos/BackEndTea/infection/pulls{/number}","milestones_url":"https://api.github.com/repos/BackEndTea/infection/milestones{/number}","notifications_url":"https://api.github.com/repos/BackEndTea/infection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BackEndTea/infection/labels{/name}","releases_url":"https://api.github.com/repos/BackEndTea/infection/releases{/id}","deployments_url":"https://api.github.com/repos/BackEndTea/infection/deployments","created_at":"2017-12-26T12:25:57Z","updated_at":"2018-05-14T16:59:29Z","pushed_at":"2018-06-27T07:31:22Z","git_url":"git://github.com/BackEndTea/infection.git","ssh_url":"git@github.com:BackEndTea/infection.git","clone_url":"https://github.com/BackEndTea/infection.git","svn_url":"https://github.com/BackEndTea/infection","homepage":"https://infection.github.io","size":1231,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infection:0.9","ref":"0.9","sha":"9caf4836381381e2c1f30ca325d22a694657d6dd","user":{"login":"infection","id":29210618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjEwNjE4","avatar_url":"https://avatars2.githubusercontent.com/u/29210618?v=4","gravatar_id":"","url":"https://api.github.com/users/infection","html_url":"https://github.com/infection","followers_url":"https://api.github.com/users/infection/followers","following_url":"https://api.github.com/users/infection/following{/other_user}","gists_url":"https://api.github.com/users/infection/gists{/gist_id}","starred_url":"https://api.github.com/users/infection/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infection/subscriptions","organizations_url":"https://api.github.com/users/infection/orgs","repos_url":"https://api.github.com/users/infection/repos","events_url":"https://api.github.com/users/infection/events{/privacy}","received_events_url":"https://api.github.com/users/infection/received_events","type":"Organization","site_admin":false},"repo":{"id":95741878,"node_id":"MDEwOlJlcG9zaXRvcnk5NTc0MTg3OA==","name":"infection","full_name":"infection/infection","owner":{"login":"infection","id":29210618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjEwNjE4","avatar_url":"https://avatars2.githubusercontent.com/u/29210618?v=4","gravatar_id":"","url":"https://api.github.com/users/infection","html_url":"https://github.com/infection","followers_url":"https://api.github.com/users/infection/followers","following_url":"https://api.github.com/users/infection/following{/other_user}","gists_url":"https://api.github.com/users/infection/gists{/gist_id}","starred_url":"https://api.github.com/users/infection/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infection/subscriptions","organizations_url":"https://api.github.com/users/infection/orgs","repos_url":"https://api.github.com/users/infection/repos","events_url":"https://api.github.com/users/infection/events{/privacy}","received_events_url":"https://api.github.com/users/infection/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infection/infection","description":"AST based PHP Mutation Testing Framework","fork":false,"url":"https://api.github.com/repos/infection/infection","forks_url":"https://api.github.com/repos/infection/infection/forks","keys_url":"https://api.github.com/repos/infection/infection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infection/infection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infection/infection/teams","hooks_url":"https://api.github.com/repos/infection/infection/hooks","issue_events_url":"https://api.github.com/repos/infection/infection/issues/events{/number}","events_url":"https://api.github.com/repos/infection/infection/events","assignees_url":"https://api.github.com/repos/infection/infection/assignees{/user}","branches_url":"https://api.github.com/repos/infection/infection/branches{/branch}","tags_url":"https://api.github.com/repos/infection/infection/tags","blobs_url":"https://api.github.com/repos/infection/infection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infection/infection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infection/infection/git/refs{/sha}","trees_url":"https://api.github.com/repos/infection/infection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infection/infection/statuses/{sha}","languages_url":"https://api.github.com/repos/infection/infection/languages","stargazers_url":"https://api.github.com/repos/infection/infection/stargazers","contributors_url":"https://api.github.com/repos/infection/infection/contributors","subscribers_url":"https://api.github.com/repos/infection/infection/subscribers","subscription_url":"https://api.github.com/repos/infection/infection/subscription","commits_url":"https://api.github.com/repos/infection/infection/commits{/sha}","git_commits_url":"https://api.github.com/repos/infection/infection/git/commits{/sha}","comments_url":"https://api.github.com/repos/infection/infection/comments{/number}","issue_comment_url":"https://api.github.com/repos/infection/infection/issues/comments{/number}","contents_url":"https://api.github.com/repos/infection/infection/contents/{+path}","compare_url":"https://api.github.com/repos/infection/infection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infection/infection/merges","archive_url":"https://api.github.com/repos/infection/infection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infection/infection/downloads","issues_url":"https://api.github.com/repos/infection/infection/issues{/number}","pulls_url":"https://api.github.com/repos/infection/infection/pulls{/number}","milestones_url":"https://api.github.com/repos/infection/infection/milestones{/number}","notifications_url":"https://api.github.com/repos/infection/infection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infection/infection/labels{/name}","releases_url":"https://api.github.com/repos/infection/infection/releases{/id}","deployments_url":"https://api.github.com/repos/infection/infection/deployments","created_at":"2017-06-29T05:29:49Z","updated_at":"2018-06-26T09:35:46Z","pushed_at":"2018-06-27T07:32:46Z","git_url":"git://github.com/infection/infection.git","ssh_url":"git@github.com:infection/infection.git","clone_url":"https://github.com/infection/infection.git","svn_url":"https://github.com/infection/infection","homepage":"https://infection.github.io","size":1222,"stargazers_count":455,"watchers_count":455,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":39,"open_issues":44,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infection/infection/pulls/379"},"html":{"href":"https://github.com/infection/infection/pull/379"},"issue":{"href":"https://api.github.com/repos/infection/infection/issues/379"},"comments":{"href":"https://api.github.com/repos/infection/infection/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/infection/infection/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/infection/infection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infection/infection/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/infection/infection/statuses/f8d23f384380aa6d65cdbbec80854c95ec9f13c6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sanmai"}}