{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13534","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13534/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13534/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13534/events","html_url":"https://github.com/home-assistant/home-assistant/pull/13534","id":309820552,"number":13534,"title":"Cleanup and bugfix (add timeout)","user":{"login":"cdce8p","id":30130371,"avatar_url":"https://avatars2.githubusercontent.com/u/30130371?v=4","gravatar_id":"","url":"https://api.github.com/users/cdce8p","html_url":"https://github.com/cdce8p","followers_url":"https://api.github.com/users/cdce8p/followers","following_url":"https://api.github.com/users/cdce8p/following{/other_user}","gists_url":"https://api.github.com/users/cdce8p/gists{/gist_id}","starred_url":"https://api.github.com/users/cdce8p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdce8p/subscriptions","organizations_url":"https://api.github.com/users/cdce8p/orgs","repos_url":"https://api.github.com/users/cdce8p/repos","events_url":"https://api.github.com/users/cdce8p/events{/privacy}","received_events_url":"https://api.github.com/users/cdce8p/received_events","type":"User","site_admin":false},"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":840363345,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20homekit","name":"component: homekit","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-29T16:25:12Z","updated_at":"2018-03-30T09:15:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13534","html_url":"https://github.com/home-assistant/home-assistant/pull/13534","diff_url":"https://github.com/home-assistant/home-assistant/pull/13534.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/13534.patch"},"body":"## Description:\r\nThis PR fixes an issue, where for continuous characteristics slowly changing the value in the `Home` app caused multiple service calls, instead of just one. ~~Since this timeout feature introduces latency, I decided to add a configuration parameter for it, so users can decide how long the timeout should be (float, between 0 and 5s).~~ The Timeout is set to 0.5s.\r\n\r\nIn addition I did some style cleanup.\r\n\r\n\r\n**Related issue:** fixes #13493\r\n**Discussion belove:** #12819\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#5050\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nhomekit:\r\n  timeout: 2\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n  - [x] Tests have been added to verify that the new code works.\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\n---\r\n\r\ncc: @maxclaey @DaveOke"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/377485330","html_url":"https://github.com/home-assistant/home-assistant/pull/13534#issuecomment-377485330","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13534","id":377485330,"user":{"login":"pvizeli","id":15338540,"avatar_url":"https://avatars3.githubusercontent.com/u/15338540?v=4","gravatar_id":"","url":"https://api.github.com/users/pvizeli","html_url":"https://github.com/pvizeli","followers_url":"https://api.github.com/users/pvizeli/followers","following_url":"https://api.github.com/users/pvizeli/following{/other_user}","gists_url":"https://api.github.com/users/pvizeli/gists{/gist_id}","starred_url":"https://api.github.com/users/pvizeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvizeli/subscriptions","organizations_url":"https://api.github.com/users/pvizeli/orgs","repos_url":"https://api.github.com/users/pvizeli/repos","events_url":"https://api.github.com/users/pvizeli/events{/privacy}","received_events_url":"https://api.github.com/users/pvizeli/received_events","type":"User","site_admin":false},"created_at":"2018-03-30T09:15:57Z","updated_at":"2018-03-30T09:15:57Z","author_association":"OWNER","body":"use our helper.events.call_later they return a cancelable object."}}
{"actor":{"display_login":"pvizeli"}}