{"action":"closed","number":1477,"pull_request":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1477","id":242333696,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzMzNjk2","html_url":"https://github.com/tensorflow/tfjs-core/pull/1477","diff_url":"https://github.com/tensorflow/tfjs-core/pull/1477.diff","patch_url":"https://github.com/tensorflow/tfjs-core/pull/1477.patch","issue_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1477","number":1477,"state":"closed","locked":false,"title":"Fix reduction op compilation on Firefox Linux","user":{"login":"dsmilkov","id":2294279,"node_id":"MDQ6VXNlcjIyOTQyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2294279?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmilkov","html_url":"https://github.com/dsmilkov","followers_url":"https://api.github.com/users/dsmilkov/followers","following_url":"https://api.github.com/users/dsmilkov/following{/other_user}","gists_url":"https://api.github.com/users/dsmilkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmilkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmilkov/subscriptions","organizations_url":"https://api.github.com/users/dsmilkov/orgs","repos_url":"https://api.github.com/users/dsmilkov/repos","events_url":"https://api.github.com/users/dsmilkov/events{/privacy}","received_events_url":"https://api.github.com/users/dsmilkov/received_events","type":"User","site_admin":false},"body":"Due to glsl 300, WebGL on Firefox on Linux can't compile 1.0 / 0.0, thus we use 1.0 / 1e-20. Relevant discussion: https://github.com/tensorflow/tfjs-core/pull/1421#issuecomment-451258903\r\n\r\nBUG\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/tensorflow/tfjs-core/1477)\r\n<!-- Reviewable:end -->\r\n","created_at":"2019-01-04T18:09:03Z","updated_at":"2019-01-04T18:21:21Z","closed_at":"2019-01-04T18:21:21Z","merged_at":"2019-01-04T18:21:21Z","merge_commit_sha":"12751381c8883638dd241043945548b81743eb5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1477/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1477/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1477/comments","statuses_url":"https://api.github.com/repos/tensorflow/tfjs-core/statuses/ffbe18d4f99cc66f4f74c89766e3ee89d8b99561","head":{"label":"tensorflow:fix-firefox-linux","ref":"fix-firefox-linux","sha":"ffbe18d4f99cc66f4f74c89766e3ee89d8b99561","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":99127696,"node_id":"MDEwOlJlcG9zaXRvcnk5OTEyNzY5Ng==","name":"tfjs-core","full_name":"tensorflow/tfjs-core","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/tfjs-core","description":"WebGL-accelerated ML // linear algebra // automatic differentiation for JavaScript.","fork":false,"url":"https://api.github.com/repos/tensorflow/tfjs-core","forks_url":"https://api.github.com/repos/tensorflow/tfjs-core/forks","keys_url":"https://api.github.com/repos/tensorflow/tfjs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tfjs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tfjs-core/teams","hooks_url":"https://api.github.com/repos/tensorflow/tfjs-core/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tfjs-core/events","assignees_url":"https://api.github.com/repos/tensorflow/tfjs-core/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tfjs-core/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tfjs-core/tags","blobs_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tfjs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tfjs-core/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tfjs-core/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tfjs-core/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tfjs-core/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tfjs-core/subscription","commits_url":"https://api.github.com/repos/tensorflow/tfjs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tfjs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tfjs-core/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tfjs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tfjs-core/merges","archive_url":"https://api.github.com/repos/tensorflow/tfjs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tfjs-core/downloads","issues_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tfjs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tfjs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tfjs-core/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tfjs-core/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tfjs-core/deployments","created_at":"2017-08-02T14:45:47Z","updated_at":"2019-01-04T17:11:26Z","pushed_at":"2019-01-04T18:21:21Z","git_url":"git://github.com/tensorflow/tfjs-core.git","ssh_url":"git@github.com:tensorflow/tfjs-core.git","clone_url":"https://github.com/tensorflow/tfjs-core.git","svn_url":"https://github.com/tensorflow/tfjs-core","homepage":"https://js.tensorflow.org","size":362600,"stargazers_count":8263,"watchers_count":8263,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":901,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":901,"open_issues":28,"watchers":8263,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"1b475ac4e7e9248445d38a6217b4a39f9e60de13","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":99127696,"node_id":"MDEwOlJlcG9zaXRvcnk5OTEyNzY5Ng==","name":"tfjs-core","full_name":"tensorflow/tfjs-core","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/tfjs-core","description":"WebGL-accelerated ML // linear algebra // automatic differentiation for JavaScript.","fork":false,"url":"https://api.github.com/repos/tensorflow/tfjs-core","forks_url":"https://api.github.com/repos/tensorflow/tfjs-core/forks","keys_url":"https://api.github.com/repos/tensorflow/tfjs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tfjs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tfjs-core/teams","hooks_url":"https://api.github.com/repos/tensorflow/tfjs-core/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tfjs-core/events","assignees_url":"https://api.github.com/repos/tensorflow/tfjs-core/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tfjs-core/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tfjs-core/tags","blobs_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tfjs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tfjs-core/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tfjs-core/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tfjs-core/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tfjs-core/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tfjs-core/subscription","commits_url":"https://api.github.com/repos/tensorflow/tfjs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tfjs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tfjs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tfjs-core/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tfjs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tfjs-core/merges","archive_url":"https://api.github.com/repos/tensorflow/tfjs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tfjs-core/downloads","issues_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tfjs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tfjs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tfjs-core/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tfjs-core/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tfjs-core/deployments","created_at":"2017-08-02T14:45:47Z","updated_at":"2019-01-04T17:11:26Z","pushed_at":"2019-01-04T18:21:21Z","git_url":"git://github.com/tensorflow/tfjs-core.git","ssh_url":"git@github.com:tensorflow/tfjs-core.git","clone_url":"https://github.com/tensorflow/tfjs-core.git","svn_url":"https://github.com/tensorflow/tfjs-core","homepage":"https://js.tensorflow.org","size":362600,"stargazers_count":8263,"watchers_count":8263,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":901,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":901,"open_issues":28,"watchers":8263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1477"},"html":{"href":"https://github.com/tensorflow/tfjs-core/pull/1477"},"issue":{"href":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1477"},"comments":{"href":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1477/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1477/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1477/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tfjs-core/statuses/ffbe18d4f99cc66f4f74c89766e3ee89d8b99561"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dsmilkov","id":2294279,"node_id":"MDQ6VXNlcjIyOTQyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2294279?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmilkov","html_url":"https://github.com/dsmilkov","followers_url":"https://api.github.com/users/dsmilkov/followers","following_url":"https://api.github.com/users/dsmilkov/following{/other_user}","gists_url":"https://api.github.com/users/dsmilkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmilkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmilkov/subscriptions","organizations_url":"https://api.github.com/users/dsmilkov/orgs","repos_url":"https://api.github.com/users/dsmilkov/repos","events_url":"https://api.github.com/users/dsmilkov/events{/privacy}","received_events_url":"https://api.github.com/users/dsmilkov/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"dsmilkov"}}