{"action":"created","issue":{"url":"https://api.github.com/repos/containers/libpod/issues/1689","repository_url":"https://api.github.com/repos/containers/libpod","labels_url":"https://api.github.com/repos/containers/libpod/issues/1689/labels{/name}","comments_url":"https://api.github.com/repos/containers/libpod/issues/1689/comments","events_url":"https://api.github.com/repos/containers/libpod/issues/1689/events","html_url":"https://github.com/containers/libpod/pull/1689","id":372099699,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mzk3NDc5","number":1689,"title":"Do not call out to runc for sync","user":{"login":"mheon","id":7735048,"node_id":"MDQ6VXNlcjc3MzUwNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"labels":[{"id":1070348377,"node_id":"MDU6TGFiZWwxMDcwMzQ4Mzc3","url":"https://api.github.com/repos/containers/libpod/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1069153503,"node_id":"MDU6TGFiZWwxMDY5MTUzNTAz","url":"https://api.github.com/repos/containers/libpod/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-10-19T20:10:17Z","updated_at":"2018-11-01T16:40:29Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/containers/libpod/pulls/1689","html_url":"https://github.com/containers/libpod/pull/1689","diff_url":"https://github.com/containers/libpod/pull/1689.diff","patch_url":"https://github.com/containers/libpod/pull/1689.patch"},"body":"An initial attempt to solve #1574 \r\n\r\nPresently, for almost all API operations, we update the container's state using runc. This is very expensive (a full fork/exec for every container involved in an API operation like `ps` adds up very quickly). Also, we're seeing issues when running large quantities of runc processes (as in #1574).\r\n\r\nThis attempts to resolve this by replacing the expensive call to runc with a much faster `stat()` call to check for the existence of the container exit file created by Conmon when the container exits (and even this can be avoided in most container states).\r\n\r\nI'd like to also introduce a --force-sync flag (or something similar) to force a full sync against runc to prevent desync from occurring, but that will come later."},"comment":{"url":"https://api.github.com/repos/containers/libpod/issues/comments/435102978","html_url":"https://github.com/containers/libpod/pull/1689#issuecomment-435102978","issue_url":"https://api.github.com/repos/containers/libpod/issues/1689","id":435102978,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTEwMjk3OA==","user":{"login":"cevich","id":1183438,"node_id":"MDQ6VXNlcjExODM0Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1183438?v=4","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T16:40:29Z","updated_at":"2018-11-01T16:40:29Z","author_association":"COLLABORATOR","body":"> I'm pretty confident something happening with runc in both cases.\r\n\r\nokay @mheon I'll bow-out then, lemmie know if/how I can help."}}
{"actor":{"display_login":"cevich"}}