{"action":"created","issue":{"url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs/issues/92","repository_url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs","labels_url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs/issues/92/comments","events_url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs/issues/92/events","html_url":"https://github.com/RethinkRobotics-opensource/rosnodejs/pull/92","id":307444203,"number":92,"title":"Added goal to GoalHandle","user":{"login":"jstnhuang","id":1175286,"avatar_url":"https://avatars0.githubusercontent.com/u/1175286?v=4","gravatar_id":"","url":"https://api.github.com/users/jstnhuang","html_url":"https://github.com/jstnhuang","followers_url":"https://api.github.com/users/jstnhuang/followers","following_url":"https://api.github.com/users/jstnhuang/following{/other_user}","gists_url":"https://api.github.com/users/jstnhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/jstnhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstnhuang/subscriptions","organizations_url":"https://api.github.com/users/jstnhuang/orgs","repos_url":"https://api.github.com/users/jstnhuang/repos","events_url":"https://api.github.com/users/jstnhuang/events{/privacy}","received_events_url":"https://api.github.com/users/jstnhuang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-21T22:44:11Z","updated_at":"2018-03-22T14:13:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs/pulls/92","html_url":"https://github.com/RethinkRobotics-opensource/rosnodejs/pull/92","diff_url":"https://github.com/RethinkRobotics-opensource/rosnodejs/pull/92.diff","patch_url":"https://github.com/RethinkRobotics-opensource/rosnodejs/pull/92.patch"},"body":"Relevant to #88.\r\n\r\nThis change makes the ActionServer pass the goal message to a GoalHandle, which is stored in the `.goal` field. When GoalHandles are created for cancellations, the goal message is left undefined.\r\n\r\nThis incorporates changes from #91. I put the changes from #91 into a separate pull request since it's a straightforward typo fix, whereas I'm not sure if this is the best way to fix #88."},"comment":{"url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs/issues/comments/375320710","html_url":"https://github.com/RethinkRobotics-opensource/rosnodejs/pull/92#issuecomment-375320710","issue_url":"https://api.github.com/repos/RethinkRobotics-opensource/rosnodejs/issues/92","id":375320710,"user":{"login":"chris-smith","id":5223570,"avatar_url":"https://avatars2.githubusercontent.com/u/5223570?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-smith","html_url":"https://github.com/chris-smith","followers_url":"https://api.github.com/users/chris-smith/followers","following_url":"https://api.github.com/users/chris-smith/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith/subscriptions","organizations_url":"https://api.github.com/users/chris-smith/orgs","repos_url":"https://api.github.com/users/chris-smith/repos","events_url":"https://api.github.com/users/chris-smith/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T14:13:30Z","updated_at":"2018-03-22T14:13:30Z","author_association":"COLLABORATOR","body":"It may make sense for goal to be \"private\" (`GoalHandle._goal`) and accessable through a `getGoal()` function to mirror what [GoalHandle](http://docs.ros.org/jade/api/actionlib/html/classactionlib_1_1ServerGoalHandle.html#a5eef2ff08ae8ca77682c39fadb09ff11) in actionlib does.\r\n\r\nOtherwise this all seems like the right thing to do."}}
{"actor":{"display_login":"chris-smith"}}