{"action":"created","comment":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments/187758777","pull_request_review_id":119609468,"id":187758777,"diff_hunk":"@@ -6,6 +6,7 @@ const autoprefixer = require( 'autoprefixer' );\n const externals = {\n \tjquery: 'jQuery',\n \t'@eventespresso/eejs': 'eejs',\n+\t'@eventespresso/i18n': 'eejs.i18n',","path":"webpack.common.js","position":4,"original_position":4,"commit_id":"11740c8f6f75621d826530764c5f9621968b4c0b","original_commit_id":"11740c8f6f75621d826530764c5f9621968b4c0b","user":{"login":"nerrad","id":1429108,"avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false},"body":"there's a problem with this entry because there are now two entries for `@eventespresso/i18n`.  This might be a merge artifact but there should only be one.  If you remove this one, it will most closely match what I see in `Gutenberg/master`","created_at":"2018-05-12T00:40:49Z","updated_at":"2018-05-12T00:41:05Z","html_url":"https://github.com/eventespresso/event-espresso-core/pull/354#discussion_r187758777","pull_request_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments/187758777"},"html":{"href":"https://github.com/eventespresso/event-espresso-core/pull/354#discussion_r187758777"},"pull_request":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354","id":184180249,"html_url":"https://github.com/eventespresso/event-espresso-core/pull/354","diff_url":"https://github.com/eventespresso/event-espresso-core/pull/354.diff","patch_url":"https://github.com/eventespresso/event-espresso-core/pull/354.patch","issue_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/354","number":354,"state":"open","locked":false,"title":"Build GutenbergBlockManager and supporting classes for locating and loading Gutenberg blocks","user":{"login":"tn3rb","id":1751030,"avatar_url":"https://avatars1.githubusercontent.com/u/1751030?v=4","gravatar_id":"","url":"https://api.github.com/users/tn3rb","html_url":"https://github.com/tn3rb","followers_url":"https://api.github.com/users/tn3rb/followers","following_url":"https://api.github.com/users/tn3rb/following{/other_user}","gists_url":"https://api.github.com/users/tn3rb/gists{/gist_id}","starred_url":"https://api.github.com/users/tn3rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn3rb/subscriptions","organizations_url":"https://api.github.com/users/tn3rb/orgs","repos_url":"https://api.github.com/users/tn3rb/repos","events_url":"https://api.github.com/users/tn3rb/events{/privacy}","received_events_url":"https://api.github.com/users/tn3rb/received_events","type":"User","site_admin":false},"body":"replaces #317 AND #340 which both got messed up for various reasons\r\n\r\nCodebase ticket: https://events.codebasehq.com/projects/event-espresso/tickets/11400\r\n\r\nalready need something like this in place to start converting REM over to work with Gutenberg (otherwise the replacement code I write now for REM will just have to be converted AGAIN later on)\r\n\r\nMVP will be really simple and straightforward as we don't yet know what functionality the various interfaces will require\r\n\r\nThe pseudo code would be something like:\r\n\r\nEE_System (or similar class) loads GutenbergBlockManager\r\nGutenbergBlockManager scans a core directory (maybe: core/services/gutenberg/blocks/) to return a list of folder names that correspond to EE block loaders and then wraps the resulting array in a filter so that addons can inject paths\r\nGutenbergBlockManager then (or at a later hookpoint) loops through those folder paths and grabs files matching a particular naming schema (like: *GutenbergBlockLoader.php), instantiates each class, and adds each service to a collection which restricts what kind of objects can be added\r\nGutenbergBlockManager then (or at a later hookpoint) loops through that collection, maybe calls some sort of init() method which would allow blocks the opportunity to set hooks for preventing other blocks from loading (ie: allows addons to override blocks), and then tells each loader to load its corresponding block.\r\neach individual GutenbergBlockLoader class would determine whether it should proceed to load its corresponding block or just do nothing because it has been told not to, or because its corresponding block is not valid for the current request.","created_at":"2018-04-25T22:25:43Z","updated_at":"2018-05-12T00:41:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d989e0b08a9a00f54407a99b33e0230faa0931c","assignee":{"login":"nerrad","id":1429108,"avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false},"assignees":[{"login":"nerrad","id":1429108,"avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":883825333,"url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/category:gutenberg","name":"category:gutenberg","color":"84b6eb","default":false},{"id":926508794,"url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/status:on-hold","name":"status:on-hold","color":"efefef","default":false},{"id":906208204,"url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/status:review","name":"status:review","color":"efefef","default":false},{"id":39832544,"url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/type:feature-request","name":"type:feature-request","color":"ebf7a0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354/commits","review_comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354/comments","review_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/354/comments","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/11740c8f6f75621d826530764c5f9621968b4c0b","head":{"label":"eventespresso:Gutenberg/block-manager","ref":"Gutenberg/block-manager","sha":"11740c8f6f75621d826530764c5f9621968b4c0b","user":{"login":"eventespresso","id":3077278,"avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"repo":{"id":7252233,"name":"event-espresso-core","full_name":"eventespresso/event-espresso-core","owner":{"login":"eventespresso","id":3077278,"avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventespresso/event-espresso-core","description":"Event Espresso 4 Core for WordPress: Build an Event Ticketing Website Today!","fork":false,"url":"https://api.github.com/repos/eventespresso/event-espresso-core","forks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/forks","keys_url":"https://api.github.com/repos/eventespresso/event-espresso-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventespresso/event-espresso-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventespresso/event-espresso-core/teams","hooks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/hooks","issue_events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/events{/number}","events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/events","assignees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/assignees{/user}","branches_url":"https://api.github.com/repos/eventespresso/event-espresso-core/branches{/branch}","tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/tags","blobs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eventespresso/event-espresso-core/languages","stargazers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/stargazers","contributors_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contributors","subscribers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscribers","subscription_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscription","commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contents/{+path}","compare_url":"https://api.github.com/repos/eventespresso/event-espresso-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventespresso/event-espresso-core/merges","archive_url":"https://api.github.com/repos/eventespresso/event-espresso-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventespresso/event-espresso-core/downloads","issues_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues{/number}","pulls_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eventespresso/event-espresso-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eventespresso/event-espresso-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels{/name}","releases_url":"https://api.github.com/repos/eventespresso/event-espresso-core/releases{/id}","deployments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/deployments","created_at":"2012-12-20T04:38:57Z","updated_at":"2018-05-11T23:12:40Z","pushed_at":"2018-05-11T23:12:37Z","git_url":"git://github.com/eventespresso/event-espresso-core.git","ssh_url":"git@github.com:eventespresso/event-espresso-core.git","clone_url":"https://github.com/eventespresso/event-espresso-core.git","svn_url":"https://github.com/eventespresso/event-espresso-core","homepage":"https://eventespresso.com","size":90492,"stargazers_count":82,"watchers_count":82,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":51,"open_issues":62,"watchers":82,"default_branch":"master"}},"base":{"label":"eventespresso:Gutenberg/master","ref":"Gutenberg/master","sha":"eed722d6dbae1ccc42161a4a6de3c2751751c4b4","user":{"login":"eventespresso","id":3077278,"avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"repo":{"id":7252233,"name":"event-espresso-core","full_name":"eventespresso/event-espresso-core","owner":{"login":"eventespresso","id":3077278,"avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventespresso/event-espresso-core","description":"Event Espresso 4 Core for WordPress: Build an Event Ticketing Website Today!","fork":false,"url":"https://api.github.com/repos/eventespresso/event-espresso-core","forks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/forks","keys_url":"https://api.github.com/repos/eventespresso/event-espresso-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventespresso/event-espresso-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventespresso/event-espresso-core/teams","hooks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/hooks","issue_events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/events{/number}","events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/events","assignees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/assignees{/user}","branches_url":"https://api.github.com/repos/eventespresso/event-espresso-core/branches{/branch}","tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/tags","blobs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eventespresso/event-espresso-core/languages","stargazers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/stargazers","contributors_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contributors","subscribers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscribers","subscription_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscription","commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contents/{+path}","compare_url":"https://api.github.com/repos/eventespresso/event-espresso-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventespresso/event-espresso-core/merges","archive_url":"https://api.github.com/repos/eventespresso/event-espresso-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventespresso/event-espresso-core/downloads","issues_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues{/number}","pulls_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eventespresso/event-espresso-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eventespresso/event-espresso-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels{/name}","releases_url":"https://api.github.com/repos/eventespresso/event-espresso-core/releases{/id}","deployments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/deployments","created_at":"2012-12-20T04:38:57Z","updated_at":"2018-05-11T23:12:40Z","pushed_at":"2018-05-11T23:12:37Z","git_url":"git://github.com/eventespresso/event-espresso-core.git","ssh_url":"git@github.com:eventespresso/event-espresso-core.git","clone_url":"https://github.com/eventespresso/event-espresso-core.git","svn_url":"https://github.com/eventespresso/event-espresso-core","homepage":"https://eventespresso.com","size":90492,"stargazers_count":82,"watchers_count":82,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":51,"open_issues":62,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354"},"html":{"href":"https://github.com/eventespresso/event-espresso-core/pull/354"},"issue":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/354"},"comments":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/11740c8f6f75621d826530764c5f9621968b4c0b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nerrad"}}