{"action":"closed","number":249,"pull_request":{"url":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/249","id":229031751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDMxNzUx","html_url":"https://github.com/zooniverse/front-end-monorepo/pull/249","diff_url":"https://github.com/zooniverse/front-end-monorepo/pull/249.diff","patch_url":"https://github.com/zooniverse/front-end-monorepo/pull/249.patch","issue_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/249","number":249,"state":"closed","locked":false,"title":"Classifier - TESS Light Curve Viewer - Zoom buttons","user":{"login":"shaunanoordin","id":13952701,"node_id":"MDQ6VXNlcjEzOTUyNzAx","avatar_url":"https://avatars0.githubusercontent.com/u/13952701?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunanoordin","html_url":"https://github.com/shaunanoordin","followers_url":"https://api.github.com/users/shaunanoordin/followers","following_url":"https://api.github.com/users/shaunanoordin/following{/other_user}","gists_url":"https://api.github.com/users/shaunanoordin/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunanoordin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunanoordin/subscriptions","organizations_url":"https://api.github.com/users/shaunanoordin/orgs","repos_url":"https://api.github.com/users/shaunanoordin/repos","events_url":"https://api.github.com/users/shaunanoordin/events{/privacy}","received_events_url":"https://api.github.com/users/shaunanoordin/received_events","type":"User","site_admin":false},"body":"## PR Overview\r\nPackage: `lib-classifier`\r\nCloses #237 \r\n\r\nThe goal of this PR is to hook up the LCV with the Classifier's Toolbar\r\n- [x] The Zoom buttons on the Classifier toolbar should allow users to zoom in/out of the Light Curve Viewer.\r\n- [x] The Reset Image button on the Classifier toolbar should reset the LCV to its default zoom and view position.\r\n\r\nSimple in theory, but there are two main hurdles:\r\n- we'll be modifying the Subject Viewer Store with an \"onZoom\" callback function, or something similar.\r\n- The D3 code in LightCurveViewer.js needs to programmatically update the Transform of the Zoom object: https://bl.ocks.org/mbostock/7ec977c95910dd026812\r\n\r\n### Status\r\n~~WIP~~\r\n~~This branch is based off #219 and should not be reviewed or merged until that one is.~~\r\n~~Development for this PR is now complete. However, it's _probably_ advisable to not review this until #219 is merged, and it should _definitely_ not be merged until 219 is. (2018.11.08)~~\r\n\r\nReady for review 👍 (2011.11.12)","created_at":"2018-11-07T13:44:33Z","updated_at":"2018-11-20T13:36:25Z","closed_at":"2018-11-20T13:36:25Z","merged_at":"2018-11-20T13:36:24Z","merge_commit_sha":"4bec29d5839509f6e4dfae51b2a95439aa101588","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rogerhutchings","id":2725841,"node_id":"MDQ6VXNlcjI3MjU4NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2725841?v=4","gravatar_id":"","url":"https://api.github.com/users/rogerhutchings","html_url":"https://github.com/rogerhutchings","followers_url":"https://api.github.com/users/rogerhutchings/followers","following_url":"https://api.github.com/users/rogerhutchings/following{/other_user}","gists_url":"https://api.github.com/users/rogerhutchings/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerhutchings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerhutchings/subscriptions","organizations_url":"https://api.github.com/users/rogerhutchings/orgs","repos_url":"https://api.github.com/users/rogerhutchings/repos","events_url":"https://api.github.com/users/rogerhutchings/events{/privacy}","received_events_url":"https://api.github.com/users/rogerhutchings/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/249/commits","review_comments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/249/comments","review_comment_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/249/comments","statuses_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/statuses/a1fb7cfa31df988f76ceae64adcf0109c8de60ac","head":{"label":"zooniverse:tess-lcv-zoom-buttons","ref":"tess-lcv-zoom-buttons","sha":"a1fb7cfa31df988f76ceae64adcf0109c8de60ac","user":{"login":"zooniverse","id":106856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":129710921,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3MTA5MjE=","name":"front-end-monorepo","full_name":"zooniverse/front-end-monorepo","private":false,"owner":{"login":"zooniverse","id":106856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zooniverse/front-end-monorepo","description":null,"fork":false,"url":"https://api.github.com/repos/zooniverse/front-end-monorepo","forks_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/forks","keys_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/teams","hooks_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/hooks","issue_events_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/events","assignees_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/tags","blobs_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/languages","stargazers_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/stargazers","contributors_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/contributors","subscribers_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/subscribers","subscription_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/subscription","commits_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/merges","archive_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/downloads","issues_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/deployments","created_at":"2018-04-16T08:34:38Z","updated_at":"2018-11-20T10:28:56Z","pushed_at":"2018-11-20T13:36:24Z","git_url":"git://github.com/zooniverse/front-end-monorepo.git","ssh_url":"git@github.com:zooniverse/front-end-monorepo.git","clone_url":"https://github.com/zooniverse/front-end-monorepo.git","svn_url":"https://github.com/zooniverse/front-end-monorepo","homepage":"https://www.zooniverse.org","size":4598,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":76,"watchers":1,"default_branch":"master"}},"base":{"label":"zooniverse:master","ref":"master","sha":"8067c1fac225a404937bc8f0721bc7ef81df9718","user":{"login":"zooniverse","id":106856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":129710921,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3MTA5MjE=","name":"front-end-monorepo","full_name":"zooniverse/front-end-monorepo","private":false,"owner":{"login":"zooniverse","id":106856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zooniverse/front-end-monorepo","description":null,"fork":false,"url":"https://api.github.com/repos/zooniverse/front-end-monorepo","forks_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/forks","keys_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/teams","hooks_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/hooks","issue_events_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/events","assignees_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/tags","blobs_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/languages","stargazers_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/stargazers","contributors_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/contributors","subscribers_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/subscribers","subscription_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/subscription","commits_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/merges","archive_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/downloads","issues_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/deployments","created_at":"2018-04-16T08:34:38Z","updated_at":"2018-11-20T10:28:56Z","pushed_at":"2018-11-20T13:36:24Z","git_url":"git://github.com/zooniverse/front-end-monorepo.git","ssh_url":"git@github.com:zooniverse/front-end-monorepo.git","clone_url":"https://github.com/zooniverse/front-end-monorepo.git","svn_url":"https://github.com/zooniverse/front-end-monorepo","homepage":"https://www.zooniverse.org","size":4598,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":76,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/249"},"html":{"href":"https://github.com/zooniverse/front-end-monorepo/pull/249"},"issue":{"href":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/249"},"comments":{"href":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/zooniverse/front-end-monorepo/statuses/a1fb7cfa31df988f76ceae64adcf0109c8de60ac"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shaunanoordin","id":13952701,"node_id":"MDQ6VXNlcjEzOTUyNzAx","avatar_url":"https://avatars0.githubusercontent.com/u/13952701?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunanoordin","html_url":"https://github.com/shaunanoordin","followers_url":"https://api.github.com/users/shaunanoordin/followers","following_url":"https://api.github.com/users/shaunanoordin/following{/other_user}","gists_url":"https://api.github.com/users/shaunanoordin/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunanoordin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunanoordin/subscriptions","organizations_url":"https://api.github.com/users/shaunanoordin/orgs","repos_url":"https://api.github.com/users/shaunanoordin/repos","events_url":"https://api.github.com/users/shaunanoordin/events{/privacy}","received_events_url":"https://api.github.com/users/shaunanoordin/received_events","type":"User","site_admin":false},"comments":7,"review_comments":2,"maintainer_can_modify":false,"commits":21,"additions":69,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"shaunanoordin"}}